coreboot.git
13 years agoFirst round of ICH2/ICH2-M cleanups after split from i82801xx.
Uwe Hermann [Mon, 11 Oct 2010 21:38:49 +0000 (21:38 +0000)]
First round of ICH2/ICH2-M cleanups after split from i82801xx.

 - Drop all non-ICH2 "struct pci_driver" entries from all files.

 - Kconfig: Add missing USE_WATCHDOG_ON_BOOT.

 - Drop i82801bx_sata.c and i82801bx_usb_ehci.c, ICH2 doesn't have SATA/EHCI.

 - Simplify lots of code, getting rid of i82801xx remainders.

 - Use u8 et al (instead of uint8_t) in a few more places.

 - Use #defines from header files where possible.

 - Various other fixes and updates.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5938 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoFactor out a few commonly duplicated functions from northbridge.c.
Uwe Hermann [Mon, 11 Oct 2010 19:36:13 +0000 (19:36 +0000)]
Factor out a few commonly duplicated functions from northbridge.c.

The following functions are moved to devices/device_util.c:

 - ram_resource()

 - tolm_test()

 - find_pci_tolm()

There are only two tolm_test() / find_pci_tolm() which differ from the
defaults, one of them can easily be eliminated in a follow-up patch,
maybe even both, but for now keep it simple and only eliminate the majority.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5937 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agofix typo in minilzma.cc, found by Idwer.
Stefan Reinauer [Sun, 10 Oct 2010 22:05:02 +0000 (22:05 +0000)]
fix typo in minilzma.cc, found by Idwer.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5936 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agodon't include unused code, we only need the header.
Stefan Reinauer [Sun, 10 Oct 2010 21:15:53 +0000 (21:15 +0000)]
don't include unused code, we only need the header.
Acked-by: Stefan Reinauer <stepan@coresystems.de>
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5935 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agofix typos found by zbao in other files.
Stefan Reinauer [Sun, 10 Oct 2010 21:15:01 +0000 (21:15 +0000)]
fix typos found by zbao in other files.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5934 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoSame applies for SB600.
Rudolf Marek [Sun, 10 Oct 2010 20:43:00 +0000 (20:43 +0000)]
Same applies for SB600.

Following patch enables UDMA on ALL IDE devices. The current code enables it only for primary master, which causes my DVD drive to fail under windows install
and even after hard reset in linux (DMA seems lockup).

The fix should not have any influence for Linux because the IDE driver will
correctly reprogram this bit.

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5933 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoFollowing patch fixes the boot_switch_sata_ide logic. It can swap
Rudolf Marek [Sun, 10 Oct 2010 19:55:32 +0000 (19:55 +0000)]
Following patch fixes the boot_switch_sata_ide logic. It can swap
primary / secondary IDE channel with SATA (in IDE mode).

The bug was that setup was done in wrong device.

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5932 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoFollowing patch enables UDMA on ALL IDE devices. The current code enables it only...
Rudolf Marek [Sun, 10 Oct 2010 19:54:15 +0000 (19:54 +0000)]
Following patch enables UDMA on ALL IDE devices. The current code enables it only for primary master, which causes my DVD drive to fail under windows install
and even after hard reset in linux (DMA seems lockup).

The fix should not have any influence for Linux because the IDE driver will
correctly reprogram this bit.

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5931 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoTrivial. Spelling check.
Zheng Bao [Sun, 10 Oct 2010 15:18:53 +0000 (15:18 +0000)]
Trivial. Spelling check.

Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Acked-by: Zheng Bao <zheng.bao@amd.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5930 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoRemove various .c #includes from Intel 440BX/82371EB boards.
Uwe Hermann [Sat, 9 Oct 2010 17:00:18 +0000 (17:00 +0000)]
Remove various .c #includes from Intel 440BX/82371EB boards.

 - Use 'romstage-y' to turn i82371eb_early_pm.c and i82371eb_early_smbus.c
   into distinct compilation units, and don't #include the files anymore
   in romstage.c files.

 - Ditto for lib/debug.c, northbridge/intel/i440bx/raminit.c, and
   northbridge/intel/i440bx/debug.c.

 - Add various header files which are now needed.

 - Make functions that need to be visible non-static.

 - Drop a remaining "select ROMCC" from a 4440BX board.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Idwer Vollering <vidwer@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5929 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoTrivial. Spell checking.
Zheng Bao [Sat, 9 Oct 2010 07:18:50 +0000 (07:18 +0000)]
Trivial. Spell checking.

Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Acked-by: Zheng Bao <zheng.bao@amd.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5928 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoTrivial. Spell checking.
Zheng Bao [Sat, 9 Oct 2010 02:31:10 +0000 (02:31 +0000)]
Trivial. Spell checking.

Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Acked-by: Zheng Bao <zheng.bao@amd.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5927 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoDrop unused i82801ax_early_lpc.c and i82801bx_early_lpc.c.
Uwe Hermann [Fri, 8 Oct 2010 20:09:21 +0000 (20:09 +0000)]
Drop unused i82801ax_early_lpc.c and i82801bx_early_lpc.c.

Nothing ever calls the functions in these files, and we already have
i82801ax_watchdog.c and i82801bx_watchdog.c which basically do the same
_and_ are hooked up correctly in the Makefile.inc and via the
USE_WATCHDOG_ON_BOOT mechanism.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5926 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoRound 2 of i82801AX fixes to get it into a usable shape.
Uwe Hermann [Fri, 8 Oct 2010 19:24:56 +0000 (19:24 +0000)]
Round 2 of i82801AX fixes to get it into a usable shape.

 - Remove left-overs from more generic code in i82801xx times, and fix
   register names as needed.

 - Simplify IDE init code (and save some ROM space too).

 - Simplify PIRQ code.

 - Use u8 et al instead of uint8_t everywhere.

 - Random other fixes.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5925 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoIntel 82801ax/82801bx: Fix and hook up i82801xx_smbus.c.
Uwe Hermann [Fri, 8 Oct 2010 16:40:23 +0000 (16:40 +0000)]
Intel 82801ax/82801bx: Fix and hook up i82801xx_smbus.c.

 - Fix incorrect #includes, add missing ones.

 - Drop unused do_smbus_write_block() and smbus_wait_until_blk_done().

 - Pass smbus_io_base to all functions as the other ICH implementations do.

 - Random other fixes which are required to make it build.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5924 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoTrivial. Spell checking.
Zheng Bao [Fri, 8 Oct 2010 05:08:47 +0000 (05:08 +0000)]
Trivial. Spell checking.

Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Acked-by: Zheng Bao <zheng.bao@amd.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5923 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoTrivial. Fix the typo.
Zheng Bao [Fri, 8 Oct 2010 03:35:12 +0000 (03:35 +0000)]
Trivial. Fix the typo.

Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Acked-by: Zheng Bao <zheng.bao@amd.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5922 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoRemove some duplicate #include files (trivial).
Uwe Hermann [Thu, 7 Oct 2010 23:42:17 +0000 (23:42 +0000)]
Remove some duplicate #include files (trivial).

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5921 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoRemove duplicate line from pci_ids.h.
Jonathan Kollasch [Thu, 7 Oct 2010 23:02:06 +0000 (23:02 +0000)]
Remove duplicate line from pci_ids.h.

Signed-off-by: Jonathan Kollasch <jakllsch@kollasch.net>
Acked-by: Jonathan Kollasch <jakllsch@kollasch.net>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5920 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoRS780 function ProgK8TempMmioBase is setting a reserved
Scott Duplichan [Thu, 7 Oct 2010 18:25:04 +0000 (18:25 +0000)]
RS780 function ProgK8TempMmioBase is setting a reserved
bit in the AMD processor 'MMIO Limit Address Register'.
I suspect it is because of a typo where 0x80 was entered
as 0x8. If 0x80 is used, then the strap configuration
register accesses become non-posted, which is how the
Shiner reference BIOS does it.

Signed-off-by: Scott Duplichan <scott@notabs.org>
Acked-by: Rudolf Marek <r.marek@assembler.cz>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5919 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoConvert all Intel 82371AB/EB/MB based boards to TINY_BOOTBLOCK.
Uwe Hermann [Thu, 7 Oct 2010 16:24:28 +0000 (16:24 +0000)]
Convert all Intel 82371AB/EB/MB based boards to TINY_BOOTBLOCK.

Also:

Unfortunately Intel 440BX + 82371AB/EB/MB boards can have their ISA device
on various PCI bus:device.function locations.
Examples we encountered: 00:07.0, 00:04.0, or 00:14.0.

Thus, instead of hardcoding PCI bus:device.function numbers such as
PCI_DEV(0, 7, 0), we now simply find the ISA device via PCI IDs, which
works the same on all boards.

As an additional benefit this patch also gets rid of one .c file include
in romstage.c.

Abuild-tested.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5918 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoConvert all Intel 440BX boards to Cache-as-RAM (CAR).
Uwe Hermann [Wed, 6 Oct 2010 19:32:39 +0000 (19:32 +0000)]
Convert all Intel 440BX boards to Cache-as-RAM (CAR).

 - Add "select CACHE_AS_RAM" in src/cpu/intel/slot_1/Kconfig.

 - Add the following in src/cpu/intel/slot_1/Makefile.inc:
   cpu_incs += $(src)/cpu/intel/car/cache_as_ram.inc

 - Remove "select ROMCC" from all 440BX board Kconfig files.

 - Drop all early_mtrr_init() calls, that's done by CAR code now.

Various small fixes were needed to make it build:

 - Drop do_smbus_recv_byte(), do_smbus_send_byte(), do_smbus_write_byte(),
   those were never called anyways.

 - Remove the "static" from the main() functions in romstage.c files.

 - Always call dump_spd_registers() from the 440BX debug.c, but use
   "#if CONFIG_DEBUG_RAM_SETUP" to only have that code if RAM debugging
   is enabled in menuconfig.

 - Drop all "lib/ramtest.c" #includes and ram_check() calls (even if
   commented out) from romstage.c's, as we've done for most other boards.

 - Add missing #includes or prototypes. Some of the prototypes will be
   removed later when we get rid of the #include'd .c files.

Abuild-tested for all boards, and boot-tested on A-Trend ATC-6220.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Patrick Georgi <patrick@georgi-clan.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5917 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoRemove duplicate line from pci_ids.h.
Jonathan Kollasch [Tue, 5 Oct 2010 19:39:35 +0000 (19:39 +0000)]
Remove duplicate line from pci_ids.h.

Signed-off-by: Jonathan Kollasch <jakllsch@kollasch.net>
Acked-by: Jonathan Kollasch <jakllsch@kollasch.net>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5916 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoUse %p instead of %x to print void *.
Jonathan Kollasch [Tue, 5 Oct 2010 19:38:04 +0000 (19:38 +0000)]
Use %p instead of %x to print void *.

Signed-off-by: Jonathan Kollasch <jakllsch@kollasch.net>
Acked-by: Jonathan Kollasch <jakllsch@kollasch.net>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5915 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agomkelfImage: set kernel_alignment so 2.6.31+ work
Eric W. Biederman [Tue, 5 Oct 2010 18:22:00 +0000 (18:22 +0000)]
mkelfImage: set kernel_alignment so 2.6.31+ work

The kernel initialization code as of boot protocol 2.10 is now reading the
kernel_alignment field.  With the field left unset the kernel attempts to
align things to 4GB which is unlikely to work, so change the alignment to
the kernel's normal value of 16MB so newer kernels processed by mkelfImage
will boot.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5914 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoAdd second CK804 for tyan/s2895 and sunw/ultra40.
Myles Watson [Tue, 5 Oct 2010 18:21:58 +0000 (18:21 +0000)]
Add second CK804 for tyan/s2895 and sunw/ultra40.

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5913 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoattached patch moves a couple more config flags out of romstage:
Patrick Georgi [Tue, 5 Oct 2010 17:59:12 +0000 (17:59 +0000)]
attached patch moves a couple more config flags out of romstage:
CK804_USE_NIC, CK804_USE_ACI, CK804_NUM.
MCP55_USE_NIC, MCP55_USE_ACI, MCP55_NUM.

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Pter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5912 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years ago- move EHCI_BAR_INDEX to ehci.h - it's constant as per EHCI spec 2.3.1
Patrick Georgi [Tue, 5 Oct 2010 13:40:31 +0000 (13:40 +0000)]
- move EHCI_BAR_INDEX to ehci.h - it's constant as per EHCI spec 2.3.1
- move EHCI_BAR and EHCI_DEBUG_OFFSET to Kconfig to be set by USB debug port enabled southbridges
- drop USB debug code includes from romstage.cs and use romstage-srcs in the build system instead

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5911 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoRemove lib/ramtest.c-include from all CAR boards.
Patrick Georgi [Tue, 5 Oct 2010 09:07:10 +0000 (09:07 +0000)]
Remove lib/ramtest.c-include from all CAR boards.
Remove many more .c-includes from i945 based boards.

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5910 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoAdd missing Intel Pentium II/III era CPU IDs.
Uwe Hermann [Mon, 4 Oct 2010 20:43:55 +0000 (20:43 +0000)]
Add missing Intel Pentium II/III era CPU IDs.

Add links to the respective Intel specification updates or manuals where
the IDs are listed. Mention the possible core steppings of each CPU ID.

There are duplicate IDs in model_6xx and model_68x for now, not sure if
those should be eliminated, but there were already duplicates before this
patch, so that's probably an extra issue to look into.

Abuild-tested.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5909 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoAdd comments to make it clear why these two lines are written like that:
Uwe Hermann [Sat, 2 Oct 2010 20:51:29 +0000 (20:51 +0000)]
Add comments to make it clear why these two lines are written like that:

  movl    $REAL_XIP_ROM_BASE, %eax
  orl     $MTRR_TYPE_WRBACK, %eax

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5908 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoAllow selecting the physical USB Debug Port on AMD SB700.
Uwe Hermann [Sat, 2 Oct 2010 20:36:26 +0000 (20:36 +0000)]
Allow selecting the physical USB Debug Port on AMD SB700.

The AMD SB700 allows changing the physical USB port to be used as
USB Debug Port, implement support for this.

Also, fix incorrect PCI device of the SB700 EHCI device. Actually, the
SB700 has _two_ EHCI devices (D18:F2 and D19:F2), but for now we only use
D18:F2. Our generic USBDEBUG code cannot handle multiple EHCI PCI devices
currently, AFAICS.

Hook up all SB700 boards to the CONFIG_USBDEBUG_DEFAULT_PORT facility.

Untested, but should work.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5907 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoAMD SB600 uses a hardcoded USB Debug Port number.
Uwe Hermann [Sat, 2 Oct 2010 20:33:56 +0000 (20:33 +0000)]
AMD SB600 uses a hardcoded USB Debug Port number.

It cannot be changed via software according to the datasheet, whereas
this is indeed possible on AMD SB700. I tested using the SB700 mechanism
on SB600 but it didn't work, so I suspect the datasheet is indeed correct.

Thus, don't show the kconfig option for selecting the physical USB port
on the AMD SB600 southbridge.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5906 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoDon't define K8_4RANK_DIMM_SUPPORT, nothing uses it.
Jonathan Kollasch [Sat, 2 Oct 2010 14:10:08 +0000 (14:10 +0000)]
Don't define K8_4RANK_DIMM_SUPPORT, nothing uses it.

All these boards define QRANK_DIMM_SUPPORT anyway,
which is probably what was meant.

Signed-off-by: Jonathan Kollasch <jakllsch@kollasch.net>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5905 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoFix spelling/typos in comments.
Jonathan Kollasch [Sat, 2 Oct 2010 12:51:38 +0000 (12:51 +0000)]
Fix spelling/typos in comments.

Signed-off-by: Jonathan Kollasch <jakllsch@kollasch.net>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5904 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoRedirect the output of iasl to a file to make the build quieter.
Myles Watson [Fri, 1 Oct 2010 21:48:52 +0000 (21:48 +0000)]
Redirect the output of iasl to a file to make the build quieter.

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5903 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoFactor out common CAR asm snippets.
Uwe Hermann [Fri, 1 Oct 2010 21:46:04 +0000 (21:46 +0000)]
Factor out common CAR asm snippets.

This makes the CAR implementations a lot more readable, shorter and
easier to follow, and also reduces the amount of uselessly duplicated code.

For example there are more than 12 open-coded "enable cache" instances
spread all over the place (and 12 "disable cache" ones), multiple
"enable mtrr", "save BIST", "restore BIST", etc. etc.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5902 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoCosmetics, whitespace and coding-style fixes for Intel CAR (trivial).
Uwe Hermann [Fri, 1 Oct 2010 17:37:45 +0000 (17:37 +0000)]
Cosmetics, whitespace and coding-style fixes for Intel CAR (trivial).

This is abuild-tested.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5901 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoFix make warnings:
Myles Watson [Fri, 1 Oct 2010 15:23:41 +0000 (15:23 +0000)]
Fix make warnings:

Makefile:261: warning: overriding commands for target `coreboot-builds/a-trend_atc-6220/lib/lzma.ramstage.o'
Makefile:261: warning: ignoring old commands for target `coreboot-builds/a-trend_atc-6220/lib/lzma.ramstage.o'

lzma.c is already included unconditionally in the same file.

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5900 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoFix some breakage from 5890.
Myles Watson [Fri, 1 Oct 2010 15:16:20 +0000 (15:16 +0000)]
Fix some breakage from 5890.

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5899 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoMove CACHE_AS_RAM_ADDRESS_DEBUG out of romstage.c into Kconfig,
Patrick Georgi [Fri, 1 Oct 2010 14:50:12 +0000 (14:50 +0000)]
Move CACHE_AS_RAM_ADDRESS_DEBUG out of romstage.c into Kconfig,
rename it slightly, make it visible only on relevant northbridges,
drop it entirely from via boards (as they seem to have picked it
up from AMD code without using it themselves), and make it
default to false for all boards.

Some romstages used to set this to "true" (ie. "print debug output"),
but I didn't follow up on it in Kconfig - if you need it to debug CAR,
enable it yourself.

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5898 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agofix VIA C7 code.
Stefan Reinauer [Fri, 1 Oct 2010 12:24:57 +0000 (12:24 +0000)]
fix VIA C7 code.
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5897 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoICS951462_ADDRESS defined but _never_ used. Drop it.
Patrick Georgi [Fri, 1 Oct 2010 11:34:05 +0000 (11:34 +0000)]
ICS951462_ADDRESS defined but _never_ used. Drop it.

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5896 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoMake i945/raminit.c:fsbclk() return u16 rather than int
Peter Stuge [Fri, 1 Oct 2010 10:02:33 +0000 (10:02 +0000)]
Make i945/raminit.c:fsbclk() return u16 rather than int

This is needed for Gentoo gcc-4.1.2 to build the i945 code. A warning is
thrown because the comparison in the last hunk is between u16 and -1 and
can never be true.

Signed-off-by: Peter Stuge <peter@stuge.se>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5895 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoRemove a couple of defines that seem to be the result of
Patrick Georgi [Fri, 1 Oct 2010 09:58:44 +0000 (09:58 +0000)]
Remove a couple of defines that seem to be the result of
copy&paste, without actually being used.

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5894 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoSplit NORTHBRIDGE_INTEL_I945 into more precise _I945GC and _I945GM
Peter Stuge [Fri, 1 Oct 2010 09:13:18 +0000 (09:13 +0000)]
Split NORTHBRIDGE_INTEL_I945 into more precise _I945GC and _I945GM

Both chipsets use the src/northbridge/intel/i945 code but that code
needs to know which chipset is actually used. Having separate
NORTHBRIDGE_ options allows the I945GC/I945GM choice to be removed
since code can test the NORTHBRIDGE_ option directly.

Signed-off-by: Peter Stuge <peter@stuge.se>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5893 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoAdd missing parenthesis (trivial).
Uwe Hermann [Fri, 1 Oct 2010 09:11:15 +0000 (09:11 +0000)]
Add missing parenthesis (trivial).

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5892 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoMove several i945 config #defines from romstage.c to Kconfig.
Patrick Georgi [Fri, 1 Oct 2010 08:02:45 +0000 (08:02 +0000)]
Move several i945 config #defines from romstage.c to Kconfig.

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5891 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoCAR simplifications, typos, readability improvements (trivial).
Uwe Hermann [Fri, 1 Oct 2010 07:27:51 +0000 (07:27 +0000)]
CAR simplifications, typos, readability improvements (trivial).

 - Use some more #defines instead of hard-coding values.

 - Merge multiple movl/orl or movl/andl lines into one where possible.

 - Add some TODOs in places which seem to have either an incorrect
   code or incorrect comment.

 - Fix typos: s/for/from/, s/BSC/BSP/, s/size/carsize/.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5890 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoTrivial. Re-indent the code.
Zheng Bao [Fri, 1 Oct 2010 06:27:35 +0000 (06:27 +0000)]
Trivial. Re-indent the code.

Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Acked-by: Zheng Bao <zheng.bao@amd.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5889 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoVarious cosmetic and coding style fixes in CAR code (trivial).
Uwe Hermann [Thu, 30 Sep 2010 23:15:36 +0000 (23:15 +0000)]
Various cosmetic and coding style fixes in CAR code (trivial).

Also, whitespace fixes, consistency fixes, and drop some of the less
useful comments.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5888 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoUse existing, readable MTRR #defines instead of hardcoding numbers.
Uwe Hermann [Thu, 30 Sep 2010 21:22:40 +0000 (21:22 +0000)]
Use existing, readable MTRR #defines instead of hardcoding numbers.

Replace $0x200 with $MTRRphysBase_MSR(0) etc. Also, move some #ifdef stuff
a little bit around (should not affect any functionality) to make the
Intel/AMD/VIA CAR implementations more similar and easier to compare.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5887 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoRename build system variables to be more intuitive, and
Patrick Georgi [Thu, 30 Sep 2010 16:55:02 +0000 (16:55 +0000)]
Rename build system variables to be more intuitive, and
at the same time let the user specify sources instead
of object files:
- objs becomes ramstage-srcs
- initobjs becomes romstage-srcs
- driver becomes driver-srcs
- smmobj becomes smm-srcs

The user servicable parts are named accordingly:
ramstage-y, romstage-y, driver-y, smm-y

Also, the object file names are properly renamed now, using
.ramstage.o, .romstage.o, .driver.o, .smm.o suffixes consistently.

Remove stubbed out via/epia-m700 dsdt/ssdt files - they didn't
easily fit in the build system and aren't useful anyway.

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coreystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5886 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agofix Kontron KT690 and clean up socket S1G1 boards accordingly.
Stefan Reinauer [Thu, 30 Sep 2010 07:56:12 +0000 (07:56 +0000)]
fix Kontron KT690 and clean up socket S1G1 boards accordingly.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5885 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agodrop unneeded earlymtrr.c include
Stefan Reinauer [Thu, 30 Sep 2010 07:45:58 +0000 (07:45 +0000)]
drop unneeded earlymtrr.c include

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5884 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoMove CAR settings to board config for socket 940 boards.
Warren Turkal [Thu, 30 Sep 2010 03:35:00 +0000 (03:35 +0000)]
Move CAR settings to board config for socket 940 boards.

For the a number of the socket 940 based machines, I collapsed their CAR
configurations into the socket config.

However, I have kept a number of overrides in place for the following
machines:
* broadcom/blast
* ibm/e32{5,6}
* newisys/khepri
* sunw/ultra40
* tyan/s488{0,2}

These machines used different setting than the defaults for socket 940
systems.

Signed-off-by: Warren Turkal <wt@penguintechs.org>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5883 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoMove VIA C7 board CAR config to VIA C7 instead of boards.
Warren Turkal [Thu, 30 Sep 2010 03:13:21 +0000 (03:13 +0000)]
Move VIA C7 board CAR config to VIA C7 instead of boards.

This change is somewhat dangerous as it enables CAR for some boards that
it was not enabled for before.

Signed-off-by: Warren Turkal <wt@penguintechs.org>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5882 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoDon't run clean-abuild on distclean target. It breaks full abuild runs.
Patrick Georgi [Wed, 29 Sep 2010 20:28:59 +0000 (20:28 +0000)]
Don't run clean-abuild on distclean target. It breaks full abuild runs.

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5881 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoForgot to 'svn add' src/cpu/x86/name (trivial).
Uwe Hermann [Wed, 29 Sep 2010 10:51:05 +0000 (10:51 +0000)]
Forgot to 'svn add' src/cpu/x86/name (trivial).

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5880 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoFactor out fill_processor_name() and strcpy() functions.
Uwe Hermann [Wed, 29 Sep 2010 09:54:16 +0000 (09:54 +0000)]
Factor out fill_processor_name() and strcpy() functions.

The fill_processor_name() function was duplicated in multiple
model_*_init.c files, move it into a new src/cpu/x86/name
directory.

The strcpy() function was also duplicated multiple times, move it
to <string.h> where we already have similar functions.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5879 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoAs $PWD is not exported by all shells, use make-builtin $(CURDIR)
Jonathan Kollasch [Tue, 28 Sep 2010 21:11:48 +0000 (21:11 +0000)]
As $PWD is not exported by all shells, use make-builtin $(CURDIR)
instead of $(PWD).

Signed-off-by: Jonathan Kollasch <jakllsch@kollasch.net>
Acked-by: Peter Stuge <peter@stuge.se>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5878 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoFix small typo in root Makefile.
Warren Turkal [Tue, 28 Sep 2010 21:02:03 +0000 (21:02 +0000)]
Fix small typo in root Makefile.

Signed-off-by: Warren Turkal <wt@penguintechs.org>
Acked-by: Peter Stuge <peter@stuge.se>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5877 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoDrop some unneeded "#if CONFIG_USBDEBUG" (trivial).
Uwe Hermann [Tue, 28 Sep 2010 17:48:24 +0000 (17:48 +0000)]
Drop some unneeded "#if CONFIG_USBDEBUG" (trivial).

We don't surround the <usbdebug.h> #include with those checks in other
places either. Abuild-tested.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5876 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoRemove redundant HW_MEM_HOLE_SIZEK and HW_MEM_HOLE_SIZE_AUTO_INC settings.
Myles Watson [Tue, 28 Sep 2010 16:16:58 +0000 (16:16 +0000)]
Remove redundant HW_MEM_HOLE_SIZEK and HW_MEM_HOLE_SIZE_AUTO_INC settings.

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5875 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoTrivial. re-Indent the code.
Zheng Bao [Tue, 28 Sep 2010 04:43:16 +0000 (04:43 +0000)]
Trivial. re-Indent the code.

Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Acked-by: Zheng Bao <zheng.bao@amd.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5874 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoI missed these boards in a previous commit.
Warren Turkal [Mon, 27 Sep 2010 21:28:21 +0000 (21:28 +0000)]
I missed these boards in a previous commit.

Signed-off-by: Warren Turkal <wt@penguintechs.org>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5873 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoGood bye, OLPC...
Stefan Reinauer [Mon, 27 Sep 2010 21:26:46 +0000 (21:26 +0000)]
Good bye, OLPC...

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Nils Jacobs <njacobs8@hetnet.nl>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5872 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoAll these boards already had the CACHE_AS_RAM option in their individual
Warren Turkal [Mon, 27 Sep 2010 21:18:26 +0000 (21:18 +0000)]
All these boards already had the CACHE_AS_RAM option in their individual
configs. I just moved it the the CPU that they all use.

Signed-off-by: Warren Turkal <wt@penguintechs.org>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5871 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoMove CAR config from mainboard to CPU config for AMD GX2 boards.
Warren Turkal [Mon, 27 Sep 2010 21:15:56 +0000 (21:15 +0000)]
Move CAR config from mainboard to CPU config for AMD GX2 boards.
Signed-off-by: Warren Turkal <wt@penguintechs.org>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5870 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoThe commandline parsing for abuild doing a couple of buggy things:
Warren Turkal [Mon, 27 Sep 2010 21:14:19 +0000 (21:14 +0000)]
The commandline parsing for abuild doing a couple of buggy things:
* Long options of the form --opt=arg were not having the arg stripped
  off into a another argument in the output. As a result, all long
  options with args had to be written like "--opt arg" on the command
  line to be recognized.
* The --remove option was shifting too many times.

As a bonus, I also added some logic to make "make distclean" cleanup
the default abuild build dir.

Signed-off-by: Warren Turkal <wt@penguintechs.org>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5869 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoThis patch moves one of the CAR configs to the socket from the single
Warren Turkal [Mon, 27 Sep 2010 21:11:54 +0000 (21:11 +0000)]
This patch moves one of the CAR configs to the socket from the single
mainboard that uses it.

Signed-off-by: Warren Turkal <wt@penguintechs.org>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5868 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoObviously missing brackets.
Xavi Drudis Ferran [Mon, 27 Sep 2010 21:08:40 +0000 (21:08 +0000)]
Obviously missing brackets.

Signed-off-by: Xavi Drudis Ferran <xdrudis@tinet.cat>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5867 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agodrop some dead code from model_fxx_init.c
Stefan Reinauer [Mon, 27 Sep 2010 21:00:34 +0000 (21:00 +0000)]
drop some dead code from model_fxx_init.c

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5866 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agooops. always run abuild on a clean tree with no other patches applied.
Stefan Reinauer [Mon, 27 Sep 2010 20:51:33 +0000 (20:51 +0000)]
oops. always run abuild on a clean tree with no other patches applied.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5865 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoRAMBASE = 0x4000 is no longer needed. Drop it.
Stefan Reinauer [Mon, 27 Sep 2010 18:57:07 +0000 (18:57 +0000)]
RAMBASE = 0x4000 is no longer needed. Drop it.
Now we only need to clean out the FAM10 stack mess and we're good to go with a
uniform RAMBASE.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5864 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agodrop excessive blank line
Stefan Reinauer [Mon, 27 Sep 2010 18:55:00 +0000 (18:55 +0000)]
drop excessive blank line
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5863 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoAdd 2 missing license headers based on svn logs and remove an unneeded #include
Stefan Reinauer [Mon, 27 Sep 2010 18:49:46 +0000 (18:49 +0000)]
Add 2 missing license headers based on svn logs and remove an unneeded #include
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5862 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agominor include cleanups
Stefan Reinauer [Mon, 27 Sep 2010 18:48:15 +0000 (18:48 +0000)]
minor include cleanups
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5861 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoAdd a kconfig option to allow the user to select a specific physical
Uwe Hermann [Mon, 27 Sep 2010 18:03:18 +0000 (18:03 +0000)]
Add a kconfig option to allow the user to select a specific physical
USB port for use as Debug Port (on chipsets which support that).

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5860 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoAdd a few missing license headers based on svn logs, and also add a
Uwe Hermann [Mon, 27 Sep 2010 17:53:17 +0000 (17:53 +0000)]
Add a few missing license headers based on svn logs, and also add a
few more code comments to src/cpu/x86/*.inc files.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5859 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agodrop double include (trivial)
Stefan Reinauer [Mon, 27 Sep 2010 11:11:09 +0000 (11:11 +0000)]
drop double include (trivial)

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5858 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoDuplicate the MCP55 EHCI Debug Port enable code for use with CK804.
Jonathan Kollasch [Sun, 26 Sep 2010 16:01:08 +0000 (16:01 +0000)]
Duplicate the MCP55 EHCI Debug Port enable code for use with CK804.

Signed-off-by: Jonathan Kollasch <jakllsch@kollasch.net>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5857 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoi82801bx defines the hard reset function, so move the "select" statement to
Warren Turkal [Sun, 26 Sep 2010 15:23:28 +0000 (15:23 +0000)]
i82801bx defines the hard reset function, so move the "select" statement to
that component rather than the mainboard.

The intel/d810e2cb is the only board using the i82801bx southbridge.

Signed-off-by: Warren Turkal <wt@penguintechs.org>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5856 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoRemove hard reset config from some mainboard configs
Warren Turkal [Sun, 26 Sep 2010 15:20:56 +0000 (15:20 +0000)]
Remove hard reset config from some mainboard configs

Most of the mainboards with i82801gx SBs seem to use the
HAVE_HARD_RESET, which is already selected in the i82801gx SB config.
Removing it from some of those boards should be a functional no-op.

Signed-off-by: Warren Turkal <wt@penguintechs.org>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5855 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agodrop some more unneeded ../../..
Stefan Reinauer [Sun, 26 Sep 2010 15:19:44 +0000 (15:19 +0000)]
drop some more unneeded ../../..

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5854 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoNormalize the config option for the Intel Atom CPU.
Warren Turkal [Sun, 26 Sep 2010 15:18:21 +0000 (15:18 +0000)]
Normalize the config option for the Intel Atom CPU.

All Intel CPU models appear to be identified with the form
INTEL_CPU_MODEL_xxxxx. I haved changed the Atom to fit this normal form.

A side effect is that the CPU doesn't need to be listed on the boards
that support it since the socket identifies the CPUs it supports.

Signed-off-by: Warren Turkal <wt@penguintechs.org>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5853 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agothe utility is called dumpmmcr, not dump_mmcr
Stefan Reinauer [Sun, 26 Sep 2010 15:15:48 +0000 (15:15 +0000)]
the utility is called dumpmmcr, not dump_mmcr

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5852 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agodumpmmcr utility is available under util and shares most of the code.
Stefan Reinauer [Sun, 26 Sep 2010 15:04:46 +0000 (15:04 +0000)]
dumpmmcr utility is available under util and shares most of the code.
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5851 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoupdate license header for dumpmmcr utility according to svn history.
Stefan Reinauer [Sun, 26 Sep 2010 15:04:14 +0000 (15:04 +0000)]
update license header for dumpmmcr utility according to svn history.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5850 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoFix the build, CONFIG_USBDEBUG must always be defined (trivial).
Uwe Hermann [Sun, 26 Sep 2010 10:34:36 +0000 (10:34 +0000)]
Fix the build, CONFIG_USBDEBUG must always be defined (trivial).

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5849 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoOnly show the USB Debug Port kconfig option to the user if a mainboard
Uwe Hermann [Sun, 26 Sep 2010 07:35:55 +0000 (07:35 +0000)]
Only show the USB Debug Port kconfig option to the user if a mainboard
is selected that uses a chipset which actually has that functionality _and_
we have code to initialize the Debug Port in coreboot (for that chipset).

Also, remove the duplicate list of PCI IDs and just link to the wiki page at:

  http://www.coreboot.org/EHCI_Debug_Port

The list is now less useful in the kconfig help as this option will only
appear for those boards where it's actually supported.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5848 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoVarious Debug Port southbridge implementation fixes / cosmetics.
Uwe Hermann [Sat, 25 Sep 2010 23:47:15 +0000 (23:47 +0000)]
Various Debug Port southbridge implementation fixes / cosmetics.

 - Use PCI_COMMAND and PCI_COMMAND_MEMORY from pci_def.h instead of
   hardcoding their values.

 - SB600/SB700: Drop useless/unused SB600_DEVN_BASE and SB700_DEVN_BASE.

 - ICH7: Drop unused EHCI_CONFIG_FLAG and EHCI_PORTSC.

 - s/uint32_t/u32/.

 - Cosmetics, whitespace, coding style fixes and added code comments.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5847 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoMark read-only data as read-only, so the global vars test doesn't fail on it.
Patrick Georgi [Sat, 25 Sep 2010 17:24:10 +0000 (17:24 +0000)]
Mark read-only data as read-only, so the global vars test doesn't fail on it.

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5846 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoAdd an EHCI driver to libpayload's USB stack.
Patrick Georgi [Sat, 25 Sep 2010 17:01:13 +0000 (17:01 +0000)]
Add an EHCI driver to libpayload's USB stack.
Interrupt transfer support is missing (ie. no keyboard),
bulk and control transfers work (ie. mass storage).

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5845 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoDrop some useless "../../../" in #includes (trivial).
Uwe Hermann [Sat, 25 Sep 2010 16:17:20 +0000 (16:17 +0000)]
Drop some useless "../../../" in #includes (trivial).

Build-tested using abuild.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5844 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoVarious CONFIG_DEBUG_RAM_SETUP related fixes (trivial).
Uwe Hermann [Sat, 25 Sep 2010 14:58:28 +0000 (14:58 +0000)]
Various CONFIG_DEBUG_RAM_SETUP related fixes (trivial).

Some boards still used the old DEBUG_RAM_SETUP (without _CONFIG prefix).

Also, consistently use "#if CONFIG_DEBUG_RAM_SETUP" (not #ifdef) as we do
elsewhere.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5843 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoVarious USB Debug Port fixes (trivial).
Uwe Hermann [Sat, 25 Sep 2010 14:23:31 +0000 (14:23 +0000)]
Various USB Debug Port fixes (trivial).

 - Drop unused DBGP_DEFAULT #defines on boards with chipsets where no
   USB Debug Port support is implemented anyway (at the moment, at least):

    - hp/dl145_g3
    - hp/dl165_g6_fam10

 - ICH7: Move unrelated code out of set_debug_port(). All ICH southbridges
   with Debug Port hardcode the physical USB port used as Debug Port to 1.
   In other words, this port is not user-configurable (as seems to be
   the case on NVIDIA MCP55). For now we keep the 'port' parameter in order
   to not change the API, this might be fixed differently later.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5842 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoMake globals in romstage break the build, so we don't have to
Patrick Georgi [Sat, 25 Sep 2010 14:15:41 +0000 (14:15 +0000)]
Make globals in romstage break the build, so we don't have to
wonder why variables in .data or .bss (both somewhere in ROM space)
are wrong.

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5841 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoDrop <cpu/amd/mtrr.h> #include from Intel CPUs.
Uwe Hermann [Sat, 25 Sep 2010 12:37:33 +0000 (12:37 +0000)]
Drop <cpu/amd/mtrr.h> #include from Intel CPUs.

Three CAR implementations on Intel CPUs include <cpu/amd/mtrr.h>, which
is obviously wrong, so drop the #includes. None of their #defines are used
in the Intel code.

Build-tested with two of the affected boards.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5840 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

13 years agoKeep the mc146818rtc.h include close to the option table include where
Myles Watson [Sat, 25 Sep 2010 10:42:55 +0000 (10:42 +0000)]
Keep the mc146818rtc.h include close to the option table include where
possible.

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5839 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1