coreboot.git
12 years agosuperiotool: add detection and dump of Infineon SLB9635 TPM
Jonathan A. Kollasch [Mon, 7 Nov 2011 16:56:42 +0000 (10:56 -0600)]
superiotool: add detection and dump of Infineon SLB9635 TPM

Change-Id: If94ea5f45135a4b65bdd37532851fa0ba864bb73
Signed-off-by: Jonathan A. Kollasch <jakllsch@kollasch.net>
Reviewed-on: http://review.coreboot.org/421
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agobuildgcc: don't download python and expat if disabled
Jonathan A. Kollasch [Mon, 7 Nov 2011 19:05:18 +0000 (13:05 -0600)]
buildgcc: don't download python and expat if disabled

Change-Id: I18cb1426e935c46ead30c72685829c20d186f9d8
Signed-off-by: Jonathan A. Kollasch <jakllsch@kollasch.net>
Reviewed-on: http://review.coreboot.org/423
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoabuild: Don't try to use files that don't exist
Patrick Georgi [Mon, 7 Nov 2011 18:01:54 +0000 (19:01 +0100)]
abuild: Don't try to use files that don't exist

Collecting per-board abuild.xml is bound to fail if there
are no such files.

Change-Id: I6bd6b4389beda51654005e0380f0e52f006642db
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/422
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agorename vt8237r_cfg() to k8x8xx_vt8237r_cfg() and make publicly accessible
Florian Zumbiehl [Tue, 1 Nov 2011 19:19:01 +0000 (20:19 +0100)]
rename vt8237r_cfg() to k8x8xx_vt8237r_cfg() and make publicly accessible

Change-Id: I82d1ec5117a58aaa8cfd2a342b7172a2786f5680
Signed-off-by: Florian Zumbiehl <florz@florz.de>
Reviewed-on: http://review.coreboot.org/379
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agofactor out common config for k8x8xx's dram_enable() and vt8237r_cfg()
Florian Zumbiehl [Tue, 1 Nov 2011 19:18:30 +0000 (20:18 +0100)]
factor out common config for k8x8xx's dram_enable() and vt8237r_cfg()

Instead of writing to config registers in k8x8xx's dram_enable()
and reading those back in vt8237r_cfg(), factor out generation of
the values and reuse that in both places.

Change-Id: I87a37398efe84b33e6678df74cd40b5abfe4f879
Signed-off-by: Florian Zumbiehl <florz@florz.de>
Reviewed-on: http://review.coreboot.org/378
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoadd support for 1106:3188 (host controller of the old version of k8t800)
Florian Zumbiehl [Tue, 1 Nov 2011 19:19:02 +0000 (20:19 +0100)]
add support for 1106:3188 (host controller of the old version of k8t800)

Change-Id: Id61678f03e1f7d964f7180a062dd6a689852d4ac
Signed-off-by: Florian Zumbiehl <florz@florz.de>
Reviewed-on: http://review.coreboot.org/401
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoAvoid false detection of SMSC FDC37N972 when Infineon TPM is present
Jonathan A. Kollasch [Mon, 7 Nov 2011 16:43:05 +0000 (10:43 -0600)]
Avoid false detection of SMSC FDC37N972 when Infineon TPM is present

Change-Id: Ibfb3af4c5d7675a5d4e27021cbb988c2ce00fd9f
Signed-off-by: Jonathan A. Kollasch <jakllsch@kollasch.net>
Reviewed-on: http://review.coreboot.org/420
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoin vt8237r_enable(), write function enables only to ISA bridge config space
Florian Zumbiehl [Tue, 1 Nov 2011 19:16:16 +0000 (20:16 +0100)]
in vt8237r_enable(), write function enables only to ISA bridge config space

vt8237r_enable() so far wrote the function enable values to the same
offset in the config space of every one of the vt8237's functions,
even though the register is located in the ISA bridge only.

Change-Id: I639586dc238132f5b8d2f320b794948718281b9c
Signed-off-by: Florian Zumbiehl <florz@florz.de>
Reviewed-on: http://review.coreboot.org/368
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoCycle time at CAS Latency (CLX - 2) is at 25 in DDR2 SPD, not at 26
Florian Zumbiehl [Tue, 1 Nov 2011 19:17:12 +0000 (20:17 +0100)]
Cycle time at CAS Latency (CLX - 2) is at 25 in DDR2 SPD, not at 26

Change-Id: Ic77854130ad43715daa7c0eb462291db48df9f84
Signed-off-by: Florian Zumbiehl <florz@florz.de>
Reviewed-on: http://review.coreboot.org/370
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agobuildgcc: Explicitely state CC everywhere
Patrick Georgi [Fri, 4 Nov 2011 20:30:49 +0000 (21:30 +0100)]
buildgcc: Explicitely state CC everywhere

This should fix issues with the iasl Makefile on Debian and
prepares ccache support for buildgcc.

Change-Id: Id9e6b2044b159b19bf013ec5c47b60ca1c2f2991
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/399
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agokconfig: Use more collision resistant temporary filenames
Patrick Georgi [Sat, 5 Nov 2011 13:39:56 +0000 (14:39 +0100)]
kconfig: Use more collision resistant temporary filenames

kconfig creates reasonably safe filenames for its temporary files
except for two of them.

Change-Id: I6861f55ae2a5311e3fb7919333ce9af1e39ce78b
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/408
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoabuild: Write XML/JUnit files per board
Patrick Georgi [Sat, 5 Nov 2011 12:21:14 +0000 (13:21 +0100)]
abuild: Write XML/JUnit files per board

Write them per-board and merge them after everything is done.
This prepares for build parallelization.

Change-Id: Ia4e7ce03473bcf8861fb9ae06e9c1270292401ac
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/407
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoabuild: Refactor parallelization support
Patrick Georgi [Sat, 5 Nov 2011 11:55:18 +0000 (12:55 +0100)]
abuild: Refactor parallelization support

Use MAKEFLAGS to propagate the parallelization configuration to
the build

Change-Id: If90ed446edd8e6dc679d284ee9db7a24269edd36
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/406
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoabuild: Avoid race condition when running abuild parallely
Patrick Georgi [Sat, 5 Nov 2011 11:47:13 +0000 (12:47 +0100)]
abuild: Avoid race condition when running abuild parallely

By moving the just-created file away, parallel runs of abuild might break.

Change-Id: I03368f00e9b11dad4c80d41279970e28debc7ed5
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/405
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoInline Makefile.bootblock.inc
Patrick Georgi [Tue, 1 Nov 2011 17:55:59 +0000 (18:55 +0100)]
Inline Makefile.bootblock.inc

This was split out when we had separate rules for big bootblock.

Change-Id: Id0a117f6996fb6bdef7bf97e7d80c36f5dec0ad7
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/404
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoFix typo
Patrick Georgi [Fri, 14 Oct 2011 23:03:16 +0000 (01:03 +0200)]
Fix typo

Change-Id: I195ea15ddbc725091e32191fac3b84d01b456580
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/410
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agow83627hf: multiple fixes and enhancements in ASL include
Christoph Grenz [Sat, 5 Nov 2011 22:39:20 +0000 (23:39 +0100)]
w83627hf: multiple fixes and enhancements in ASL include

Fix multiple copy&paste errors and some other bugs in
devtree.asl. Redesign ENCM method to enter configuration mode
and set LDN by parameter. Reordered and commented some
statements to make the code a bit more readable. Add an ifdef
to enable never showing the keyboard controller as disabled,
which seems to cause bugs at least with some Linux kernels.
Remove keyboard controller IO regions from PS/2 mouse device
as e.g. Linux infers them from the keyboard controller device.

Change-Id: I44611339fabe31a8a584a3e6bd225082bfdd0b8e
Signed-off-by: Christoph Grenz <christophg+cb@grenz-bonn.de>
Reviewed-on: http://review.coreboot.org/357
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agow83627hf: drop Scope(\_SB) from ASL include
Christoph Grenz [Sat, 5 Nov 2011 21:14:41 +0000 (22:14 +0100)]
w83627hf: drop Scope(\_SB) from ASL include

Drop explicit Scope(\_SB) from devtree.asl as it forces the SuperIO
to appear as child of the root device.
devtree.asl then needs to be included at a reasonable position inside
the \_SB device tree.

Change-Id: I72a57eddc5ec5f9763fdf789094a7be042758256
Signed-off-by: Christoph Grenz <christophg+cb@grenz-bonn.de>
Reviewed-on: http://review.coreboot.org/298
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agobuildgcc: Fix wrapper Makefile
Patrick Georgi [Sat, 5 Nov 2011 21:30:56 +0000 (22:30 +0100)]
buildgcc: Fix wrapper Makefile

buildgcc moved from building gdb by default (with opt-out) to
gdb being optional. Adapt Makefile so it works again

Change-Id: I663a8c70db4f7b5d07456fb67a223dbb2de2c133
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/417
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agolibpayload: Implement usb_exit
Patrick Georgi [Fri, 4 Nov 2011 11:06:06 +0000 (12:06 +0100)]
libpayload: Implement usb_exit

So far it was empty and never published. It now exists and shuts down
all controllers (esp. EHCI which resets the port routers).

Change-Id: I81e355e8a05778d6397675417b085a094a6f48ee
Signed-off-by: Patrick Georgi <patrick.georgi@secunet.com>
Reviewed-on: http://review.coreboot.org/397
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agolibpayload: Tell EHCI to re-enable USB1 controllers
Patrick Georgi [Fri, 4 Nov 2011 10:57:46 +0000 (11:57 +0100)]
libpayload: Tell EHCI to re-enable USB1 controllers

EHCI can take over all ports (and then reroute devices to
companion controllers if needs be). We do that, and then never
reset it.

Consequence:
Systems with only USB1 HC drivers (OHCI/UHCI) never see any devices.

Change-Id: If1d91e9142a6618289b0b3f6b56587ec857158e3
Signed-off-by: Patrick Georgi <patrick.georgi@secunet.com>
Reviewed-on: http://review.coreboot.org/396
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins)
12 years agolibpayload: Drop usb_fatal()
Patrick Georgi [Fri, 4 Nov 2011 10:50:03 +0000 (11:50 +0100)]
libpayload: Drop usb_fatal()

We have fatal(), which is just as good.

Coccinelle script:
  @@
  expression E;
  @@
  -usb_fatal(E)
  +fatal(E)

Change-Id: Iabecbcc7d068cc0f82687bf51d89c2626642cd86
Signed-off-by: Patrick Georgi <patrick.georgi@secunet.com>
Reviewed-on: http://review.coreboot.org/395
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins)
12 years agoRevert "add support for 1106:3188 (host controller of the old version of k8t800)...
Patrick Georgi [Fri, 4 Nov 2011 12:18:26 +0000 (13:18 +0100)]
Revert "add support for 1106:3188 (host controller of the old version of k8t800)" due to dependency issues.

This reverts commit 68c554550f59bd96caace96260ae2e30ed55ceb4

Change-Id: I353bd36b008f489a972c7c656d7ad07416f01387
Reviewed-on: http://review.coreboot.org/398
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoadd support for writing to SMBus with vt8237
Florian Zumbiehl [Tue, 1 Nov 2011 19:17:13 +0000 (20:17 +0100)]
add support for writing to SMBus with vt8237

Change-Id: I70fe072f8f3447d0be7b7ac64508a954fe47091d
Signed-off-by: Florian Zumbiehl <florz@florz.de>
Reviewed-on: http://review.coreboot.org/372
Tested-by: build bot (Jenkins)
Reviewed-by: Rudolf Marek <r.marek@assembler.cz>
12 years agoadd support for 1106:3188 (host controller of the old version of k8t800)
Florian Zumbiehl [Tue, 1 Nov 2011 19:19:02 +0000 (20:19 +0100)]
add support for 1106:3188 (host controller of the old version of k8t800)

Change-Id: I10135b37a6cef460be9bfbfd34746140310859a6
Signed-off-by: Florian Zumbiehl <florz@florz.de>
Reviewed-on: http://review.coreboot.org/381
Tested-by: build bot (Jenkins)
Reviewed-by: Rudolf Marek <r.marek@assembler.cz>
12 years agolibpayload: Reduce verbosity in USB stack
Mathias Krause [Wed, 8 Jun 2011 13:36:55 +0000 (15:36 +0200)]
libpayload: Reduce verbosity in USB stack

The USB stack is pretty noisy. Reduce the output to a sane level.

Change-Id: I250949e5cf74a8c6d43822b2e7487143b2ae1c65
Signed-off-by: Mathias Krause <mathias.krause@secunet.com>
Reviewed-on: http://review.coreboot.org/393
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agolibpayload: Put coreboot version into lib_sysinfo
Mathias Krause [Thu, 20 Oct 2011 12:06:26 +0000 (14:06 +0200)]
libpayload: Put coreboot version into lib_sysinfo

Change-Id: I22319efe90e475c66b9556f734a7a5e54f7c59bc
Signed-off-by: Patrick Georgi <patrick.georgi@secunet.com>
Reviewed-on: http://review.coreboot.org/394
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agofix superiotool for NCT6776F
Florian Zumbiehl [Wed, 2 Nov 2011 08:46:34 +0000 (09:46 +0100)]
fix superiotool for NCT6776F

The current code exits config mode of the NCT6776F immediately after
detection, so the register dump shows all 0xffs. This patch adds code to
re-enter config mode for the register dump so that the register contents
can be read.

Change-Id: I4ad0c108b6411a665e31f55dea4b91ca77d1a5f7
Signed-off-by: Florian Zumbiehl <florz@florz.de>
Reviewed-on: http://review.coreboot.org/391
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agosimplify IDE cable detection for Asus M2V
Florian Zumbiehl [Tue, 1 Nov 2011 19:17:13 +0000 (20:17 +0100)]
simplify IDE cable detection for Asus M2V

Change-Id: If8e4dcf405e24b744ac34f581c5609fcce96fd07
Signed-off-by: Florian Zumbiehl <florz@florz.de>
Reviewed-on: http://review.coreboot.org/371
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agobuildgcc: Update coreboot reference toolchain to gcc 4.6.2
Stefan Reinauer [Tue, 1 Nov 2011 21:39:41 +0000 (22:39 +0100)]
buildgcc: Update coreboot reference toolchain to gcc 4.6.2

In addition:
- drop some unneeded patches
- make the scripting support depend on SKIPPYTHON not SKIPGDB
  so it is possible to build GDB with and without scripting support
- rename the repository checkout version of GCC trunk, not X+1
  so we don't have to change it on every version upgrade.

Change-Id: I1b7d5b8921187c1c1d39b04f20bb715ddba72fe8
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/367
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agodon't scan beyond end of CBFS
Florian Zumbiehl [Tue, 1 Nov 2011 19:17:11 +0000 (20:17 +0100)]
don't scan beyond end of CBFS

Change-Id: I66e535f77e513dbfa5fc906ecf288193af78ae62
Signed-off-by: Florian Zumbiehl <florz@florz.de>
Reviewed-on: http://review.coreboot.org/369
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoAdd Python scripting to GDB.
Stefan Reinauer [Tue, 1 Nov 2011 20:43:50 +0000 (21:43 +0100)]
Add Python scripting to GDB.

This allows GDB to run Python scripts. The Python build is dependant on the GDB
build flag.

Changes by Stefan Reinauer:
- update to latest buildgcc script
- disable GDB per default
- disable python scripting, if GDB is not enabled
- bump version number to 1.06

Change-Id: Ie7fc8706deec41c804870415d3c79d225c98cd31
Signed-off-by: Marc Jones <marcj303@gmail.com>
Reviewed-on: http://review.coreboot.org/153
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins)
12 years agolibpayload: remove trailing whitespace and run dos2unix
Stefan Reinauer [Mon, 31 Oct 2011 19:54:00 +0000 (12:54 -0700)]
libpayload: remove trailing whitespace and run dos2unix

Change-Id: Iffed3602456f5306711c65f06c873c58d4086e11
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/363
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agolibpayload: Fix OHCI some more
Patrick Georgi [Thu, 27 Oct 2011 11:08:13 +0000 (13:08 +0200)]
libpayload: Fix OHCI some more

OHCI works when USB_DEBUG is disabled, but not, when disabled.
This is because the controller requires some more time after a
schedule has finished.

Also improve compliance with the OHCI spec.

Change-Id: I4685cc485ff9c52b489fbaa352ab889671cff876
Signed-off-by: Patrick Georgi <patrick.georgi@secunet.com>
Reviewed-on: http://review.coreboot.org/365
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoremove trailing whitespace
Stefan Reinauer [Mon, 31 Oct 2011 19:56:45 +0000 (12:56 -0700)]
remove trailing whitespace

Change-Id: Ib91889a374515d36a2b12b53aeb12b6ea6e22732
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/364
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoRemove XIP_ROM_BASE
Patrick Georgi [Mon, 31 Oct 2011 16:07:52 +0000 (17:07 +0100)]
Remove XIP_ROM_BASE

The base is now calculated automatically, and all mentions of that
config option were typical anyway (4GB - XIP_ROM_SIZE).

Change-Id: Icdf908dc043719f3810f7b5b85ad9938f362ea40
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/366
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoRun dos2unix on bayou and remove white space at the end of lines.
Stefan Reinauer [Mon, 31 Oct 2011 19:52:22 +0000 (12:52 -0700)]
Run dos2unix on bayou and remove white space at the end of lines.

Change-Id: If13d9a49ece2699885ae3e998173d3d44507b302
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/362
Tested-by: build bot (Jenkins)
Reviewed-by: Peter Stuge <peter@stuge.se>
12 years agobuildgcc: Fix colors for dash
Patrick Georgi [Mon, 31 Oct 2011 11:15:55 +0000 (12:15 +0100)]
buildgcc: Fix colors for dash

The previous fix broke buildgcc colors on MacOS X.
This uses an encoding that should be more universal.

Change-Id: I31ac6090ffb7c04784cf6566823652f229aebbb5
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/361
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoAdd support for E7505 northbridge.
Kyösti Mälkki [Mon, 31 Oct 2011 12:18:33 +0000 (14:18 +0200)]
Add support for E7505 northbridge.

Adapted from northbridge/intel/e7501 with only minor changes.
This commit provides minimal patch from e7501 and I prefer any
cosmetic clean-up to be done after initial merge.

Due the incomplete register specifications, it is safer to have
e7505 as a separate directory in case I improve it to support
wider range of memory configurations. I have no e7501 to test with.

Change-Id: Iba3bf9d69ff5e9d9ef3a6ebf8259f048c55d637d
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/295
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoFix usb debug dongle support
Sven Schnelle [Sun, 30 Oct 2011 08:57:35 +0000 (09:57 +0100)]
Fix usb debug dongle support

- move enable_usbdebug() declaration to usbdebug.h
- reinitialize debug driver in ramstage, as copying the data
  structure from romstage doesn't work right now. This way of copying
  data from romstage to ramstage is really board/cpu specific, and is
  likely to break often. So don't do it.

Change-Id: I394678ded6679c1803e29eb691b926182bdcab68
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/355
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agocrossgcc: Fix colors with dash
Patrick Georgi [Fri, 28 Oct 2011 22:00:19 +0000 (00:00 +0200)]
crossgcc: Fix colors with dash

Ubuntu (and probably other distros) have dash as /bin/sh, which
doesn't display colors by itself. If /usr/bin/printf is found, it's
used instead of the internal printf to re-enable colors.

Change-Id: I3e6d413cd0c8a46ef91821d8c07e88166de58af4
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/352
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoFix slow CAR execution introduced by 7c7d87182feb78cb2bc02fb3558bef56a41682c9
Rudolf Marek [Sun, 30 Oct 2011 17:06:58 +0000 (18:06 +0100)]
Fix slow CAR execution introduced by 7c7d87182feb78cb2bc02fb3558bef56a41682c9

It is meant to be a address and not a dereference. Otherwise MTRR
is filled with code and not with the address.

This is what I hate at most on the AT&T syntax. Instead of taking
the address, it was a dereference. Not greatly visible, except
I wondered why opcode is not 0xb4 but 0xa1 and it took another
half an our to see it.

Change-Id: I6b339656024de8f6e6b3cde63b16b7ff5562d055
Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Reviewed-on: http://review.coreboot.org/358
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins)
12 years agoFix gcc 4.6.1 breakage of southbridge/amd/sr5650/pcie.c.
Stefan Reinauer [Sun, 30 Oct 2011 19:30:48 +0000 (20:30 +0100)]
Fix gcc 4.6.1 breakage of southbridge/amd/sr5650/pcie.c.

Change-Id: I3ccb3860207e1b3ccac4313f7b537c434af5166f
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/360
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins)
Reviewed-by: Rudolf Marek <r.marek@assembler.cz>
12 years agointeltool: Add Intel i63xx I/O Controller Hub
Sven Schnelle [Sun, 30 Oct 2011 12:30:36 +0000 (13:30 +0100)]
inteltool: Add Intel i63xx I/O Controller Hub

Change-Id: Iaea7e4d1b206d43661ecb61d2ae517723fb8d008
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/356
Tested-by: build bot (Jenkins)
12 years agoremove usbdebug.h include from mainboard/romstage code
Sven Schnelle [Sun, 30 Oct 2011 07:49:43 +0000 (08:49 +0100)]
remove usbdebug.h include from mainboard/romstage code

No romstage is supposed to use usbdebug functions/defines
directly, so remove all those includes. The usb code is now
called and setup from console code.

Change-Id: I9b1120d96f5993303d6b302accc86e14a91f7a9f
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/354
Tested-by: build bot (Jenkins)
12 years agoUpdate coreboot cross toolchain to gcc 4.6.1
Stefan Reinauer [Wed, 12 Oct 2011 05:37:59 +0000 (22:37 -0700)]
Update coreboot cross toolchain to gcc 4.6.1

- Tested on Mac OS X 10.7.1
- Tested on Ubuntu 10.04 LTS (Lucid Lynx)
- Tested on Ubuntu 11.10 (Oneiric Ocelot)

Please test on Windows and other Linux distributions

Change-Id: I132c01293fc0cff0cfb84556a93c0b8de8e57230
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/250
Tested-by: build bot (Jenkins)
Reviewed-by: Sven Schnelle <svens@stackframe.org>
12 years agoasus/m5a88-v: Fix build
Patrick Georgi [Sat, 29 Oct 2011 20:42:22 +0000 (22:42 +0200)]
asus/m5a88-v: Fix build

We added some new flag for certain AMD boards after support for
this board was submitted. Also integrate the mptable refactorings
that happened in the meantime.

Change-Id: I50cf50f343a740832fd1a14a2a1ef5b903315675
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/353
Tested-by: build bot (Jenkins)
Reviewed-by: Sven Schnelle <svens@stackframe.org>
12 years agoFix coreboot updates
Patrick Georgi [Fri, 28 Oct 2011 20:52:11 +0000 (22:52 +0200)]
Fix coreboot updates

The rule to prepare a new coreboot.pre1 was ignored in the
"update image" scenario because a perfectly fine file exists.
Mark it phony to fix it.

Change-Id: Ie7f8b36b71015a593958cd6e19602bad6b854320
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/351
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agow83627hf: add method to retrieve wake event source register to ASL include
Christoph Grenz [Wed, 19 Oct 2011 00:25:08 +0000 (02:25 +0200)]
w83627hf: add method to retrieve wake event source register to ASL include

Add a method WAKS to devtree.asl which returns the wake-up source register
to simplify retrieving the wake source e.g. in \_WAK.

Change-Id: Ia258f8fc9ff79b18391c55464da73863889e2255
Signed-off-by: Christoph Grenz <christophg+cb@grenz-bonn.de>
Reviewed-on: http://review.coreboot.org/297
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoAdd ASUS M5A88-V mainboard support
QingPei Wang [Tue, 13 Sep 2011 09:54:12 +0000 (17:54 +0800)]
Add ASUS M5A88-V mainboard support

it's a AMD 880+800 mainboard. I port the code
based on the AMD reference code.
update: 1.use CIMX instead of pmio
          2.fix some whitespace
          3.fix subsystemid of devicetree.cb

Change-Id: I9725ccdbb25365c4007621318efee80b131fec29
Signed-off-by: QingPei Wang <wangqingpei@gmail.com>
Reviewed-on: http://review.coreboot.org/205
Tested-by: build bot (Jenkins)
Reviewed-by: Kerry Sheh <shekairui@gmail.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoGet rid of the old romstage-as-bootblock ROM layout
Patrick Georgi [Sat, 22 Oct 2011 07:54:36 +0000 (09:54 +0200)]
Get rid of the old romstage-as-bootblock ROM layout

This change removes CONFIG_TINY_BOOTBLOCK, CONFIG_BIG_BOOTBLOCK, and
all their uses, assuming TINY_BOOTBLOCK=y, BIG_BOOTBLOCK=n.

This might break a couple of boards on runtime, but so far, fixes were
quite simple.
There's a flag day: Code that relies on CONFIG_TINY_BOOTBLOCK must be
adapted.

Change-Id: I1e17a4a1b9c9adb8b43ca4db8aed5a6d44d645f5
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/320
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoGet rid of AUTO_XIP_ROM_BASE
Patrick Georgi [Fri, 28 Oct 2011 18:28:03 +0000 (20:28 +0200)]
Get rid of AUTO_XIP_ROM_BASE

That value is now generated from a code address and CONFIG_XIP_ROM_SIZE.
This works as MTRRs are fully specified by their size and any address
within the range.

Change-Id: Id35d34eaf3be37f59cd2a968e3327d333ba71a34
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/348
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agosb600: Implement EHCI workaround
Patrick Georgi [Fri, 28 Oct 2011 07:01:54 +0000 (09:01 +0200)]
sb600: Implement EHCI workaround

Linux implements it itself, but older Linuxes and other systems
might not. Without this, the host controller might not respond
to drivers.

Change-Id: I4ff0e3683c02e7aa00d188428847c64c4c5d589d
Signed-off-by: Patrick Georgi <patrick.georgi@secunet.com>
Reviewed-on: http://review.coreboot.org/345
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agosiemens/sitemp_g1p1: Add more devices to PIR and MP table
Patrick Georgi [Thu, 6 Oct 2011 12:36:08 +0000 (14:36 +0200)]
siemens/sitemp_g1p1: Add more devices to PIR and MP table

Linux 2.4 is happier that way

Change-Id: I016609ae1e004ec856e8223893352dcdd061b291
Signed-off-by: Patrick Georgi <patrick.georgi@secunet.com>
Reviewed-on: http://review.coreboot.org/346
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoClear improper use of CONFIG_CACHE_AS_RAM
Kyösti Mälkki [Fri, 28 Oct 2011 13:15:47 +0000 (16:15 +0300)]
Clear improper use of CONFIG_CACHE_AS_RAM

Choice between printk/print_ is related to CAR, but really
depends whether we compiled with GCC or ROMCC.

Change-Id: I9fe831a215736462e8b3f4b96ffe231133ecf79b
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/347
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoT60: remove redundant usbdebug_init call()
Sven Schnelle [Fri, 28 Oct 2011 19:26:16 +0000 (21:26 +0200)]
T60: remove redundant usbdebug_init call()

called from console code, no need to call it here.

Change-Id: I4c34f89c82cc2478db8de4e98584e69d7ab0ca82
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/350
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agocopy e7501 component to e7505
Stefan Reinauer [Fri, 21 Oct 2011 19:57:59 +0000 (12:57 -0700)]
copy e7501 component to e7505

Change-Id: Ie69a6b6a040a8b0e7693083b3a2d13c327a165b3
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/310
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoPrevent multiple inclusions of object files and rules
Patrick Georgi [Tue, 25 Oct 2011 21:32:21 +0000 (14:32 -0700)]
Prevent multiple inclusions of object files and rules

This removes 54 make warnings from the build

Change-Id: I94ac9875526febe2f95334c1c3971641c1d27f8f
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/338
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoFix checksum calculation both in romstage and ramstage.
Stefan Reinauer [Thu, 27 Oct 2011 16:42:53 +0000 (18:42 +0200)]
Fix checksum calculation both in romstage and ramstage.

The earlier fix for CMOS checksums only fixed the function rtc_set_checksum,
which would fix the checksum, but then coreboot would no longer honor the
settings because it assumed the checksum is wrong after this.
This change fixes the remaining functions.

Change-Id: I3f52d074df29fc29ae1d940b3dcec3aa2cfc96a5
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/342
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoAdd support for AMD IMC controller.
Rudolf Marek [Thu, 27 Oct 2011 18:42:11 +0000 (20:42 +0200)]
Add support for AMD IMC controller.

This patch adds support to dump SIO like interface of AMD Embedded Controller
in the SB7xx and SB8xxx southbridges. Parts of the register interface are
documented in SBxxx RRG BDG.

Change-Id: Ib2ccaa3dfe33cfa8e7cba19d8ab0798286ad2f92
Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Reviewed-on: http://review.coreboot.org/343
Tested-by: build bot (Jenkins)
Reviewed-by: Peter Stuge <peter@stuge.se>
12 years agoAdded smbus block read/write for amd8111
Oskar Enoksson [Fri, 14 Oct 2011 00:16:48 +0000 (02:16 +0200)]
Added smbus block read/write for amd8111

Signed-off-by: Oskar Enoksson <enok@lysator.liu.se>
Change-Id: I86c80a27fd13c9a2be4034fdfb63be4ab2fadbfc
Reviewed-on: http://review.coreboot.org/281
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoMove linux 2.6.11 workaround to generic code
Patrick Georgi [Fri, 14 Oct 2011 21:02:57 +0000 (23:02 +0200)]
Move linux 2.6.11 workaround to generic code

Linux 2.6.11 seems to require a certain order in CPUs listed in mptable,
so enforce it. This was only done on arima/hdama, but now is generic.
Unfortunately this is somewhat slow.

Change-Id: I85715ebae8a009cb816bc9ffd6372708f246bf66
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/280
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoX60/T60: enable AHCI mode
Sven Schnelle [Thu, 27 Oct 2011 11:10:14 +0000 (13:10 +0200)]
X60/T60: enable AHCI mode

Signed-off-by: Sven Schnelle <svens@stackframe.org>
Change-Id: I2166ae9ee9e7e0e431583249f015d130d15fac61
Reviewed-on: http://review.coreboot.org/341
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoi82801gx: Fix port status in AHCI mode
Sven Schnelle [Thu, 27 Oct 2011 11:05:40 +0000 (13:05 +0200)]
i82801gx: Fix port status in AHCI mode

The code used PCI register 0x92 to enable sata ports,
which is wrong. The ICH7 documentation states:

"This register is only used in systems that do not
support AHCI. In AHCI enabled systems, bits[3:0] must
always be set (ICH7R only) / bits[2,0] must always be set
(Mobile only), and the status of the port is controlled
through AHCI memory space."

Writing 0x0f to ICH7-M doesn't seem to hurt, so lets write
0x0f for both variants. This patch makes sata_ahci work on
my Thinkpad T60 and X60s.

Change-Id: If3b3daec2e5fbaa446de00272ebde01cd8d52475
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/340
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoAdd -Werror to xcompile's testcc
Stefan Reinauer [Tue, 25 Oct 2011 19:28:40 +0000 (12:28 -0700)]
Add -Werror to xcompile's testcc

If -Werror is not specified, tests for certain compiler flags
will emit a warning, which makes the build break since we compile
with -Werror.

Change-Id: I7be56530ff9f94e5500bad226c83e47145a808d7
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/336
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoFix libpayload speaker driver
Stefan Reinauer [Tue, 25 Oct 2011 21:15:57 +0000 (14:15 -0700)]
Fix libpayload speaker driver

The frequency for the PC speaker has to be specified as
1193180 / frequency according to http://wiki.osdev.org/PC_Speaker

Change-Id: Iaca9d45807e080efe834611e719b350680b5fb90
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/337
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoX60: enable Cx power saving modes
Sven Schnelle [Sun, 23 Oct 2011 14:57:50 +0000 (16:57 +0200)]
X60: enable Cx power saving modes

Change-Id: Ib03d9aa77050edde2538b80b32158cb3f0610be6
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/331
Tested-by: build bot (Jenkins)
12 years agoT60: add _CST table
Sven Schnelle [Sat, 22 Oct 2011 11:41:28 +0000 (13:41 +0200)]
T60: add _CST table

Used by power management code to enable Cx powersaving modes.

Change-Id: I02c6b10762245bc48f21a341286236e203421de0
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/322
Tested-by: build bot (Jenkins)
12 years agoT60: enable C4onC3 mode
Sven Schnelle [Sun, 23 Oct 2011 14:36:22 +0000 (16:36 +0200)]
T60: enable C4onC3 mode

It is safe to enable this setting on these Boards.

Change-Id: Iaa7377117743d18a95c496c25abf9fb4a1b20ad9
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/330
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoT60: use ICS954309 clock driver
Sven Schnelle [Sun, 23 Oct 2011 13:54:31 +0000 (15:54 +0200)]
T60: use ICS954309 clock driver

Change-Id: I3f30fe601215784e1688c5ec51108dc0cf03e320
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/328
Tested-by: build bot (Jenkins)
12 years agoAdd driver for ICS954309 clock generator
Sven Schnelle [Sun, 23 Oct 2011 13:53:47 +0000 (15:53 +0200)]
Add driver for ICS954309 clock generator

Change-Id: Iac7e91cdd995dad1954eaa2d4dd52bffa293fc95
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/327
Tested-by: build bot (Jenkins)
12 years agoi82801gx: Add setting for C4onC3 mode
Sven Schnelle [Sun, 23 Oct 2011 14:35:01 +0000 (16:35 +0200)]
i82801gx: Add setting for C4onC3 mode

If this bit is set, ich7 will enter C4 mode if possible instead of
C3. See ich7 specification (LPC controller, Power management control
registers) for more details.

Change-Id: I352cccdbc51ff6269f153a4542c7ee1df0c01d22
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/329
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoSPEEDSTEP: write _CST tables
Sven Schnelle [Sat, 22 Oct 2011 11:41:16 +0000 (13:41 +0200)]
SPEEDSTEP: write _CST tables

Change-Id: Idb4b57044808918de343d31519768d0986840f01
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/321
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoACPI: Add function for writing _CST tables
Sven Schnelle [Fri, 21 Oct 2011 19:46:47 +0000 (21:46 +0200)]
ACPI: Add function for writing _CST tables

Change-Id: I4e16a0d37717c56a3529f9f9fdb05efec1d93f99
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/312
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agow83627hf: correct typo in ASL include, correct indexed registers and remove unneccesa...
Christoph Grenz [Wed, 19 Oct 2011 00:24:23 +0000 (02:24 +0200)]
w83627hf: correct typo in ASL include, correct indexed registers and remove unneccesary _PR0 defs

Correct a typo in devtree.asl which causes AML processors to fail executing
the DSDT with AE_NO_MEMORY or (in case of acpiexec) Divide By Zero.
Also removes an superfluous item in the register IndexField and removes
unneccessary _PR0 definitions which could confuse AML processors.

Change-Id: I02cb9ce4e8f2101cfff8cec4abba7e070fd66364
Signed-off-by: Christoph Grenz <christophg+cb@grenz-bonn.de>
Reviewed-on: http://review.coreboot.org/296
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoLenovo H8: Fix h8_set_audio_mute()
Sven Schnelle [Tue, 25 Oct 2011 13:29:47 +0000 (15:29 +0200)]
Lenovo H8: Fix h8_set_audio_mute()

Logic is inverted (if argument is true, one would expect that
mute is enabled) and the wrong bit was used (1 instead 0)

Change-Id: I71133ba639f1fb0d3c3582f16211dd266a11cc64
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/334
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoX60/T60: remove superflous h8_set_audio_mute()
Sven Schnelle [Tue, 25 Oct 2011 13:31:26 +0000 (15:31 +0200)]
X60/T60: remove superflous h8_set_audio_mute()

muting is handled by h8 code, no need to do it here.

Change-Id: I3f152e99f30701cd032b03105cbe3ae778865305
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/335
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoi82801gx: Add write and read/write block functions
Sven Schnelle [Sun, 23 Oct 2011 13:36:15 +0000 (15:36 +0200)]
i82801gx: Add write and read/write block functions

Change-Id: Icbfc47a8d7bfe1600e4212b26e99b2a604de9ef7
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/326
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoVarious fixes to cbfstool.
Stefan Reinauer [Fri, 21 Oct 2011 21:24:57 +0000 (14:24 -0700)]
Various fixes to cbfstool.

- add ntohll and htonll (as coreboot parses 64bit fields now)
- use the same byte swapping code across platforms
- detect endianess early
- fix lots of warnings
- Don't override CFLAGS in Makefile

Change-Id: Iaea02ff7a31ab6a95fd47858d0efd9af764a3e5f
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/313
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoi82801gx: Don't set I/O base address to static value
Sven Schnelle [Sun, 23 Oct 2011 13:30:29 +0000 (15:30 +0200)]
i82801gx: Don't set I/O base address to static value

Doing it this way will break all subsequent smbus calls, because
the smbus code still uses res->base, which points to the old base
address. Fix this by allocating a proper resource.

Change-Id: I0f3d8fba5f8e2db7fe4ca991ef2c345aff436ea4
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/325
Reviewed-by: Rudolf Marek <r.marek@assembler.cz>
Tested-by: build bot (Jenkins)
12 years agoFILO: Pass LIBCONFIG_PATH variable to FILOs make
Thomas Gstädtner [Fri, 21 Oct 2011 20:01:32 +0000 (22:01 +0200)]
FILO: Pass LIBCONFIG_PATH variable to FILOs make

This fixes the build for HEAD/master.
Current stable will not work, because it is too old for recent corboot.

Change-Id: I9dfd5de472d4f58f07147cb9b9bb0b543f228561
Signed-off-by: Thomas Gstädtner <thomas@gstaedtner.net>
Reviewed-on: http://review.coreboot.org/311
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoAllow XGCCPATH to be set on the make command line.
Marc Jones [Fri, 7 Oct 2011 23:20:30 +0000 (17:20 -0600)]
Allow XGCCPATH to be set on the make command line.

The xgcc toolchain may be moved by the user and passed in on the commandline. Updates the Makefile and the xcompile script.

Change-Id: I05797b2cabce39bdd7868c2515f30d34043fc8cc
Signed-off-by: Marc Jones <marcj303@gmail.com>
Reviewed-on: http://review.coreboot.org/318
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoconsole: support integrated 7-segment displays for POST codes
Christoph Grenz [Sun, 18 Sep 2011 20:54:51 +0000 (22:54 +0200)]
console: support integrated 7-segment displays for POST codes

Add a configuration option POST_PORT which defaults to 0x80 and
can be redefined by boards which have integrated POST displays
on another I/O port. Change post.c to output POST codes to this
port instead of 0x80 hardcoded.

Change-Id: I8f8e820f8c75641b35e7249bf622b63a3604b9f3
Signed-off-by: Christoph Grenz <christophg+cb@grenz-bonn.de>
Reviewed-on: http://review.coreboot.org/221
Tested-by: build bot (Jenkins)
Reviewed-by: Rudolf Marek <r.marek@assembler.cz>
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoSB800: Hide unused gpp ports
Kerry Sheh [Wed, 12 Oct 2011 04:06:23 +0000 (12:06 +0800)]
SB800: Hide unused gpp ports

Add configure option SB_GPP_UNHIDE_PORTS for mainboard
to hide/unhide the unused sb800 gpp ports.
Certain gpp port should be hidden, if no device was detected and
hotplug feature is disabled for such port.
Hidden unused ports makes lspci -vvv get more accurate information under Linux.
Test on avalue/eax-785e mainboard.

Change-Id: I1d7df0f2ab6ad69b1b99b8bf046411ae7cdb09c0
Signed-off-by: Kerry Sheh <kerry.she@amd.com>
Signed-off-by: Kerry Sheh <shekairui@gmail.com>
Reviewed-on: http://review.coreboot.org/207
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoFix CMOS checksum calculation in libpayload.
Stefan Reinauer [Fri, 21 Oct 2011 21:37:52 +0000 (14:37 -0700)]
Fix CMOS checksum calculation in libpayload.

Change-Id: I64ea53fa098fbcfc76e0ebd5f049a2ee3d0a1024
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/314
Tested-by: build bot (Jenkins)
Reviewed-by: Marc Jones <marcj303@gmail.com>
12 years agoAdd ifdtool, utility to read / modify Intel Firmware Descriptor images
Stefan Reinauer [Fri, 14 Oct 2011 19:49:41 +0000 (12:49 -0700)]
Add ifdtool, utility to read / modify Intel Firmware Descriptor images

Change-Id: Ie78b97bf573d238d0dff9a663e774deb1b7dea44
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/272
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agonvramtool: Fix CMOS checksum to match coreboot (and /dev/nvram)
Stefan Reinauer [Mon, 17 Oct 2011 15:58:27 +0000 (08:58 -0700)]
nvramtool: Fix CMOS checksum to match coreboot (and /dev/nvram)

Change-Id: I28b0dbad36403a31be83581107f40b3ca1332dcc
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/287
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoExtend coreboot table entry for serial ports
Stefan Reinauer [Wed, 22 Jun 2011 23:39:19 +0000 (16:39 -0700)]
Extend coreboot table entry for serial ports

Add information about memory mapped/io mapped base addresses.

and fix up libpayload to use the same structures

Signed-off-by: Stefan Reinauer <reinauer@google.com>
Change-Id: I5f7b5eda6063261b9acb7a46310172d4a5471dfb
Reviewed-on: http://review.coreboot.org/261
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoRemove redunancy in Kconfig
Kyösti Mälkki [Fri, 21 Oct 2011 15:41:44 +0000 (18:41 +0300)]
Remove redunancy in Kconfig

Socket Kconfig unconditionally selects CPU_INTEL_CORE.

Change-Id: I5eb7dd17047a2a031dd7345390d7f5f756055e18
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/307
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agoFILO: Change FILO Makefile.inc from SVN to GIT
Thomas Gstädtner [Fri, 21 Oct 2011 15:40:42 +0000 (17:40 +0200)]
FILO: Change FILO Makefile.inc from SVN to GIT

This commit replaces the old svn checkout code for the external FILO
payload with a git checkout for the new repo on gerrit.
The stable checkout is implemented similarly to the former SVN variant,
it checks out a specific commit (same commit as svn r136 which was
checked out before).
The HEAD checkout gets the master branch from
http://review.coreboot.org/p/filo.git
In future this should probably be changed to a stable tag or repo.
It is necessary to remove the old svn checkout by hand (or run
distclean), because I did not include code to remove an existing svn
FILO checkout.

Change-Id: I08a703f3428ae7b987f7079a4901be4cf6d7e505
Signed-off-by: Thomas Gstädtner <thomas@gstaedtner.net>
Reviewed-on: http://review.coreboot.org/308
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agolibpayload: fix bulk transfers on OHCI controllers
Patrick Georgi [Fri, 21 Oct 2011 13:45:09 +0000 (15:45 +0200)]
libpayload: fix bulk transfers on OHCI controllers

Time for the brown paper bag: OHCI controllers are not happy when
told to send data, but with obviously wrong addresses. It helps
to write the addresses into the data structures.

Change-Id: Ic0967dc8939e64af119cfb89400a045a2c077171
Signed-off-by: Patrick Georgi <patrick.georgi@secunet.com>
Reviewed-on: http://review.coreboot.org/306
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
12 years agosch: strip quotes around cmc.bin filename
Patrick Georgi [Fri, 21 Oct 2011 11:56:04 +0000 (13:56 +0200)]
sch: strip quotes around cmc.bin filename

This was mentioned several times already, how about we get it in?
It avoids cbfstool to fail because path/to/"file" doesn't work.

Change-Id: Ia01acbd78f81a5db890fd1573a2f3cbe1450562f
Signed-off-by: Patrick Georgi <patrick.georgi@secunet.com>
Reviewed-on: http://review.coreboot.org/305
Tested-by: build bot (Jenkins)
Reviewed-by: Peter Stuge <peter@stuge.se>
12 years agoUse ntohll where appropriate.
Stefan Reinauer [Mon, 17 Oct 2011 16:51:15 +0000 (09:51 -0700)]
Use ntohll where appropriate.

also clean out a local copy of ntohl in yabel.

Change-Id: Iffe85a53c9ea25abeb3ac663870eb7eb4874a704
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/288
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoAdd macros for 64bit byte order swapping
Stefan Reinauer [Fri, 14 Oct 2011 22:11:16 +0000 (15:11 -0700)]
Add macros for 64bit byte order swapping

Change-Id: Ic31ccd41ba3e0af7046eafc29221810d4cd196c8
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/275
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
12 years agoT60: Add support for Ultrabay Legacy I/O devices (40Y8122)
Sven Schnelle [Sat, 15 Oct 2011 15:31:01 +0000 (17:31 +0200)]
T60: Add support for Ultrabay Legacy I/O devices (40Y8122)

Those modules have basically the same Super I/O capabilities as
the Docking station. Unfortunately, the Super I/O in the module
shares the same I/O address as the Docking station, so we're not
allowed to connect the LPC Docking Bus if such a module is present.

To be able to detect this device and use it as early console for
coreboot, we have to initialize the GPIO Controller before, as
this device is detected via GPIO06.

Change-Id: If7c38bb6797f76cf28f09f3614ab9a33878571fb
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/282
Tested-by: build bot (Jenkins)
12 years agoi82801dx: Replace romstage printk's
Kyösti Mälkki [Mon, 17 Oct 2011 14:37:45 +0000 (17:37 +0300)]
i82801dx: Replace romstage printk's

Patch is required to compile this with romcc.

Change-Id: I5c4c0f5b32e5edeb8c48d8455b3493ca79f8b452
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/291
Tested-by: build bot (Jenkins)
Reviewed-by: Peter Stuge <peter@stuge.se>
12 years agoasrock/e350m1: Enable the superio ACPI device in devicetree.cb
Peter Stuge [Tue, 18 Oct 2011 03:10:36 +0000 (05:10 +0200)]
asrock/e350m1: Enable the superio ACPI device in devicetree.cb

This makes the power_on_after_fail NVRAM option work correctly.

Change-Id: I96f05f82d7f133b343cf8d4ef09db50a3db7a83d
Signed-off-by: Peter Stuge <peter@stuge.se>
Reviewed-on: http://review.coreboot.org/292
Tested-by: build bot (Jenkins)
12 years agoIOAPIC: fix bitmask
Kyösti Mälkki [Wed, 19 Oct 2011 04:23:51 +0000 (07:23 +0300)]
IOAPIC: fix bitmask

APIC ID is bits 27..24, not 19..16.

Change-Id: Ib53a480bf4328901094ca2c4713e8317321962a1
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/299
Tested-by: build bot (Jenkins)
Reviewed-by: Peter Stuge <peter@stuge.se>
12 years agosconfig: check whether component directory actually exists
Stefan Reinauer [Fri, 14 Oct 2011 19:41:46 +0000 (12:41 -0700)]
sconfig: check whether component directory actually exists

and add drivers/generic/generic back (empty), since it is used by many
devicetree.cb files.

Without this patch typos in component names in devicetree.cb cause
the component to be silently ignored.

Change-Id: I3cfca2725816f0cd7d72139ae53af815009e8ab4
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/270
Tested-by: build bot (Jenkins)
Reviewed-by: Peter Stuge <peter@stuge.se>
12 years agoDrop eh_frame instead of moving it into the image.
Stefan Reinauer [Fri, 14 Oct 2011 17:29:21 +0000 (10:29 -0700)]
Drop eh_frame instead of moving it into the image.

That's what SeaBIOS does, too, and it works just fine.

Change-Id: I3e17c15848aca86f775fc86f4ad906c820625887
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/269
Tested-by: build bot (Jenkins)
Reviewed-by: Peter Stuge <peter@stuge.se>