w83627hf: correct typo in ASL include, correct indexed registers and remove unneccesa...
authorChristoph Grenz <christophg+cb@grenz-bonn.de>
Wed, 19 Oct 2011 00:24:23 +0000 (02:24 +0200)
committerStefan Reinauer <stefan.reinauer@coreboot.org>
Tue, 25 Oct 2011 15:52:06 +0000 (17:52 +0200)
Correct a typo in devtree.asl which causes AML processors to fail executing
the DSDT with AE_NO_MEMORY or (in case of acpiexec) Divide By Zero.
Also removes an superfluous item in the register IndexField and removes
unneccessary _PR0 definitions which could confuse AML processors.

Change-Id: I02cb9ce4e8f2101cfff8cec4abba7e070fd66364
Signed-off-by: Christoph Grenz <christophg+cb@grenz-bonn.de>
Reviewed-on: http://review.coreboot.org/296
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
src/superio/winbond/w83627hf/devtree.asl

index fa78845a18b830ad38b90c0d45c4dcf913cd2c85..cbc132d467e0dbe2b4834f7210c10ac939f36d3e 100644 (file)
@@ -74,7 +74,7 @@ Scope (\_SB)
                        ADDR,   8,
                        DATA,   8
                }
-               IndexField (CREG, DATA, ByteAcc, NoLock, Preserve)
+               IndexField (ADDR, DATA, ByteAcc, NoLock, Preserve)
                {
                        Offset (0x02),
                        RST,    1,     /* Soft reset */
@@ -84,7 +84,6 @@ Scope (\_SB)
                        Offset (0x20),
                        DID,    8,     /* Device ID */
                        DREV,   8,     /* Device Revision */
-                       POWC,   8,
                        FDPW,   1,     /* FDC Power Down */
                        ,       2,
                        PRPW,   1,     /* PRT Power Down */
@@ -258,7 +257,6 @@ Scope (\_SB)
                                Store (One, FDPW)
                                EXCM ()
                        }
-                       Name (_PR0, Package () { ^^ })
 
                        Method (_DIS)
                        {
@@ -470,7 +468,6 @@ Scope (\_SB)
                                Store (One, PRPW)
                                EXCM ()
                        }
-                       Name (_PR0, Package () { ^^ })
 
                        Method (_DIS) {
                                ENCM ()
@@ -650,7 +647,6 @@ Scope (\_SB)
                                Store (One, UAPW)
                                EXCM ()
                        }
-                       Name (_PR0, Package () { ^^ })
 
                        Method (_DIS)
                        {
@@ -783,7 +779,6 @@ Scope (\_SB)
                                Store (One, UBPW)
                                EXCM ()
                        }
-                       Name (_PR0, Package () { ^^ })
 
                        Method (_DIS)
                        {
@@ -916,7 +911,6 @@ Scope (\_SB)
                                Store (One, UBPW)
                                EXCM ()
                        }
-                       Name (_PR0, Package () { ^^ })
 
                        Method (_DIS)
                        {
@@ -1479,7 +1473,6 @@ Scope (\_SB)
                                Store (One, HWPW)
                                EXCM ()
                        }
-                       Name (_PR0, Package () { ^^ })
 
                        Method (_CRS)
                        {
@@ -1511,4 +1504,4 @@ Scope (\_SB)
                }
                #endif
        }
-}
\ No newline at end of file
+}