SB800: Hide unused gpp ports

Add configure option SB_GPP_UNHIDE_PORTS for mainboard
to hide/unhide the unused sb800 gpp ports.
Certain gpp port should be hidden, if no device was detected and
hotplug feature is disabled for such port.
Hidden unused ports makes lspci -vvv get more accurate information under Linux.
Test on avalue/eax-785e mainboard.

Change-Id: I1d7df0f2ab6ad69b1b99b8bf046411ae7cdb09c0
Signed-off-by: Kerry Sheh <kerry.she@amd.com>
Signed-off-by: Kerry Sheh <shekairui@gmail.com>
Reviewed-on: http://review.coreboot.org/207
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>

diff --git a/src/mainboard/advansus/a785e-i/platform_cfg.h b/src/mainboard/advansus/a785e-i/platform_cfg.h
index ee68386189e6fc63c104031cc3251e68277ef21e..5fd49d6b6abdf7f34609ad939625b703678a9457 100644 (file)
--- a/src/mainboard/advansus/a785e-i/platform_cfg.h
+++ b/src/mainboard/advansus/a785e-i/platform_cfg.h
@@ -211,6 +211,12 @@
  */
 #define SB_GPP_GEN2                    TRUE
 
+/**
+ * @def SB_GPP_UNHIDE_PORTS
+ *    TRUE   - ports visable always, even port empty
+ *    FALSE  - ports invisable if port empty
+ */
+#define SB_GPP_UNHIDE_PORTS            FALSE
 
 /**
  * @def   GEC_CONFIG

diff --git a/src/mainboard/amd/inagua/platform_cfg.h b/src/mainboard/amd/inagua/platform_cfg.h
index 4a3f080d67ae75ee0d4b5354515623156780a586..aa7cb5c05c59d8bbbb131d6674922dd59f7c9816 100644 (file)
--- a/src/mainboard/amd/inagua/platform_cfg.h
+++ b/src/mainboard/amd/inagua/platform_cfg.h
@@ -213,6 +213,12 @@
  */
 #define SB_GPP_GEN2                    TRUE
 
+/**
+ * @def SB_GPP_UNHIDE_PORTS
+ *    TRUE   - ports visable always, even port empty
+ *    FALSE  - ports invisable if port empty
+ */
+#define SB_GPP_UNHIDE_PORTS            FALSE
 
 /**
  * @def   GEC_CONFIG

diff --git a/src/mainboard/amd/persimmon/platform_cfg.h b/src/mainboard/amd/persimmon/platform_cfg.h
index e4fedd9336aa1f0c73ac1ba7a0643e54a5dd1314..66aab8bf4be1df5ce2f7b41269632471c42b8a14 100644 (file)
--- a/src/mainboard/amd/persimmon/platform_cfg.h
+++ b/src/mainboard/amd/persimmon/platform_cfg.h
@@ -213,6 +213,12 @@
  */
 #define SB_GPP_GEN2                    TRUE
 
+/**
+ * @def SB_GPP_UNHIDE_PORTS
+ *    TRUE   - ports visable always, even port empty
+ *    FALSE  - ports invisable if port empty
+ */
+#define SB_GPP_UNHIDE_PORTS            FALSE
 
 /**
  * @def   GEC_CONFIG

diff --git a/src/mainboard/asrock/e350m1/platform_cfg.h b/src/mainboard/asrock/e350m1/platform_cfg.h
index a0cbd118f9c7247593a8d83a88d8c9b70f28cfcf..6aa31d2cdb98f72ffe976ff0c770175dfa6be821 100644 (file)
--- a/src/mainboard/asrock/e350m1/platform_cfg.h
+++ b/src/mainboard/asrock/e350m1/platform_cfg.h
@@ -213,6 +213,12 @@
  */
 #define SB_GPP_GEN2                    TRUE
 
+/**
+ * @def SB_GPP_UNHIDE_PORTS
+ *    TRUE   - ports visable always, even port empty
+ *    FALSE  - ports invisable if port empty
+ */
+#define SB_GPP_UNHIDE_PORTS            FALSE
 
 /**
  * @def   GEC_CONFIG

diff --git a/src/southbridge/amd/cimx/sb800/cfg.c b/src/southbridge/amd/cimx/sb800/cfg.c
index a34dd14baac74a792521e3177135bf879103320d..2998fa2ff1e9f607e2041ac963a2b6f889e16ed0 100644 (file)
--- a/src/southbridge/amd/cimx/sb800/cfg.c
+++ b/src/southbridge/amd/cimx/sb800/cfg.c
@@ -108,7 +108,7 @@ void sb800_cimx_config(AMDSBCFG *sb_config)
        sb_config->PORTCONFIG[1].PortCfg.PortPresent = CIMX_OPTION_ENABLED;
        sb_config->PORTCONFIG[2].PortCfg.PortPresent = CIMX_OPTION_ENABLED;
        sb_config->PORTCONFIG[3].PortCfg.PortPresent = CIMX_OPTION_ENABLED;
-       sb_config->GppUnhidePorts = TRUE; //visable always, even port empty
+       sb_config->GppUnhidePorts = SB_GPP_UNHIDE_PORTS;
        sb_config->NbSbGen2 = NB_SB_GEN2;
        sb_config->GppGen2 = SB_GPP_GEN2;