pci1x2x: remove latency/bridge control/cacheline size settings
authorSven Schnelle <svens@stackframe.org>
Wed, 20 Apr 2011 08:58:38 +0000 (08:58 +0000)
committerSven Schnelle <svens@stackframe.org>
Wed, 20 Apr 2011 08:58:38 +0000 (08:58 +0000)
Those settings should be handled by the generic PCI/Cardbus code,
and not by the driver itself.

Signed-off-by: Sven Schnelle <svens@stackframe.org>
Acked-by: Sven Schnelle <svens@stackframe.org>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6528 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

src/mainboard/nokia/ip530/devicetree.cb
src/southbridge/ti/pci1x2x/chip.h
src/southbridge/ti/pci1x2x/pci1x2x.c

index a1326044723791c053a1ef1c26012e4c994030ae..f89d1cd9fec18bea17395153dc3f0ce9cb75306a 100644 (file)
@@ -33,8 +33,6 @@ chip northbridge/intel/i440bx         # Northbridge
             device pci 00.0 on
                        subsystemid 0x13b8 0x0000
             end
-            register "cltr" = "0x40"
-            register "bcr" = "0x7c0"
             register "scr" = "0x08449060"
             register "mrr" = "0x00007522"
        end
index b40194e328c032b8b8e5ee7cf106c77b070d979b..4c3676153d05049a9d11dd268b2fde518d3aa12e 100644 (file)
@@ -6,8 +6,5 @@ extern struct chip_operations southbridge_ti_pci1x2x_ops;
 struct southbridge_ti_pci1x2x_config {
        int scr;
        int mrr;
-       int clsr;
-       int cltr;
-       int bcr;
 };
 #endif
index dfb183cd278b898945b40a8ce92f380f6b5e61bf..e59be4fd2c5722d68f47f4c710716ee09a0c67fd 100644 (file)
@@ -34,12 +34,6 @@ static void ti_pci1x2y_init(struct device *dev)
        struct southbridge_ti_pci1x2x_config *conf = dev->chip_info;
 
        if (conf) {
-               /* Cache Line Size (offset 0x0C) */
-               pci_write_config8(dev, 0x0C, conf->clsr);
-               /* CardBus latency timer (offset 0x1B) */
-               pci_write_config8(dev, 0x1B, conf->cltr);
-               /* Bridge control (offset 0x3E) */
-               pci_write_config16(dev, 0x3E, conf->bcr);
                /* System control (offset 0x80) */
                pci_write_config32(dev, 0x80, conf->scr);
                /* Multifunction routing */