Myles Watson [Thu, 4 Jun 2009 20:18:42 +0000 (20:18 +0000)]
The point of the patch is to make it easier to understand the raminit
code, specifically the difference between pre_f and f code.
The only functional changes are in printk statements. The rest is white space.
1. Remove some #if 0 and #if 1 blocks
2. Remove #if USE_DCACHE_RAM blocks. All K8 boards use CAR.
2. Correct typos (canidate -> candidate)
3. Try to minimize the differences between amdk8_f.h and amdk8_pre_f.h
4. Try to minimize the differences between raminit.c and raminit_f.c
5. Make boards that have rev_f processors include the correct raminit code
There is much more that could be done, but it's a start.
Abuild tested and boot tested on s2892 and serengeti_cheetah.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4337
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Zheng Bao [Thu, 4 Jun 2009 01:57:03 +0000 (01:57 +0000)]
This patch is about some noticable bugs which was made by no reason.
1. In rs690_cmn.c, mask the lower 4 bits of the BAR3. No doubt, right?
2. In rs690_pcie.c,
(1) Obviously, the mask should be 0xF, and bit 19 should be set to 1 (in comment).
In rpr 5.10.2, step 2, step 2.1 & step 2.6
(2) The dynamic buffer allocation is enabled by setting bit 11 of PCIEIND: 0x20,
instead of PCIEIND_P: 0x20.
In rpr 5.10.2, step 5. Dynamic Slave CPL Buffer Allocation
Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4336
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Luc Verhaegen [Wed, 3 Jun 2009 14:19:33 +0000 (14:19 +0000)]
Revert "CMOS: Add set_option and rework get_option."
This reverts commit
eb7bb49eb5b48c39baf7a256b7c74e23e3da5660.
Stepan pointed out that "s" means string, which makes the following statement
in this commit message invalid: "Since we either have reserved space (which
we shouldn't do anything with in these two functions), an enum or a
hexadecimal value, unsigned int seemed like the way to go."
Signed-off-by: Luc Verhaegen <libv@skynet.be>
Acked-by: Luc Verhaegen <libv@skynet.be>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4335
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Luc Verhaegen [Wed, 3 Jun 2009 14:19:20 +0000 (14:19 +0000)]
Revert "kontron 986lcd_m: cmos.layout: mark boot_devices as reserved."
This reverts commit
c03527377db5951f0d3228e2a93b4c57dd81b8ec.
Stepan pointed out that 's' means string, and that therefor strings do exist.
Marking this as reserved breaks some payloads.
Signed-off-by: Luc Verhaegen <libv@skynet.be>
Acked-by: Luc Verhaegen <libv@skynet.be>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4334
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Luc Verhaegen [Wed, 3 Jun 2009 11:53:54 +0000 (11:53 +0000)]
kontron 986lcd_m: cmos.layout: mark boot_devices as reserved.
The kontron 986lcd_m cmos.layout had a 512bit area claimed for "boot_devices".
The changes to the cmos code no longer allow usage of values larger than
32bits. Since this option was completely unused, mark it as reserved.
Fixes build after the get_option change (r4332)..
Signed-off-by: Luc Verhaegen <libv@skynet.be>
Acked-by: Luc Verhaegen <libv@skynet.be>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4333
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Luc Verhaegen [Wed, 3 Jun 2009 10:47:19 +0000 (10:47 +0000)]
CMOS: Add set_option and rework get_option.
To ease some of my debugging pain on the unichrome, i decided i needed to
move FB size selection into cmos, so i could test a size and then reset it
to the default after loading this value so that the next reboot uses the
(working) default again. This meant implementing set_option in parallel to
get_option.
get_option was then found to have inversed argument ordering (like outb) and
passing char * and then depending on the cmos layout length, which made me
feel quite uncomfortable. Since we either have reserved space (which we
shouldn't do anything with in these two functions), an enum or a
hexadecimal value, unsigned int seemed like the way to go. So all users of
get_option now have their arguments inversed and switched from using ints
to unsigned ints now.
The way get_cmos_value was implemented forced us to not overlap byte and to
have multibyte values be byte aligned. This logic is now adapted to do a
full uint32_t read (when needed) at any offset and any length up to 32, and
the shifting all happens inside an uint32_t as well. set_cmos_value was
implemented similarly. Both routines have been extensively tested in a
quick separate little program as it is not easy to get this stuff right.
build_opt_tbl.c was altered to function correctly within these new
parameters. The enum value retrieval has been changed strol(..., NULL, 10)
to stroul(..., NULL, 0), so that we not only are able to use unsigned ints
now but so that we also interprete hex values correctly. The 32bit limit
gets imposed on all entries not marked reserved, an unused "user_data" field
that appeared in a lot of cmos.layouts has been changed to reserved as well.
Signed-off-by: Luc Verhaegen <libv@skynet.be>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4332
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Zheng Bao [Wed, 3 Jun 2009 03:15:05 +0000 (03:15 +0000)]
Modify it based on the RPR 5.7.7. Switching GGSP Configuration By Register Programming.
Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4331
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Uwe Hermann [Tue, 2 Jun 2009 23:49:00 +0000 (23:49 +0000)]
More compact format for wiki output at
http://www.coreboot.org/Coreboot_Options (trivial).
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4330
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Patrick Georgi [Mon, 1 Jun 2009 20:02:21 +0000 (20:02 +0000)]
cbfstool reacts to a too large bootblock file by stopping
with an error code now.
Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4329
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Uwe Hermann [Mon, 1 Jun 2009 01:38:29 +0000 (01:38 +0000)]
Cosmetics and consistency fixes in src/superio/serverengines/pilot/ (trivial).
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4328
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Rudolf Marek [Sun, 31 May 2009 17:00:25 +0000 (17:00 +0000)]
Following patch moves all vt8237 fadt.c from mainboard/* file to chipset
directory just with one common file.
Changes to FADT: move to rev4, fix the generic register descriptors, detect additional VT8237S features.
Change the compiler to CORE , its revision to 42.
Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4327
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Stefan Reinauer [Sat, 30 May 2009 15:12:33 +0000 (15:12 +0000)]
Many Kudos go to Segher Boessenkool and Patrick Georgi for figuring this one
out. Fix the libgcc dependency on abort() due to nested functions.
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4326
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Joseph Smith [Fri, 29 May 2009 18:41:09 +0000 (18:41 +0000)]
rename the option CONFIG_PCI_OPTION_ROM_RUN_VM86 to CONFIG_PCI_OPTION_ROM_RUN_REALMODE.
Signed-off-by: Joseph Smith <joe@settoplinux.org>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4325
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Joseph Smith [Fri, 29 May 2009 13:45:22 +0000 (13:45 +0000)]
enable/disable IDE 0/1 (Primary/Secondary) interfaces on the i82801xx southbridge.
Signed-off-by: Joseph Smith <joe@settoplinux.org>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4324
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Stefan Reinauer [Fri, 29 May 2009 13:08:27 +0000 (13:08 +0000)]
drop most of the crappy vm86 code and replace it with a rewritten
version that has all assembler in a .S file and all C code in a .c
file. Also, remove requirement to move around between GDTs.
This version includes the suggestions from Peter to clean up CR0 manipulation
and to guard critical code paths by cli/sti. Tested and working on my hardware.
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4323
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Luc Verhaegen [Fri, 29 May 2009 03:44:47 +0000 (03:44 +0000)]
Fix build with CONFIG_*_ROM_RUN.
Last commit broke it due to leftover "void" from prototype.
Signed-off-by: Luc Verhaegen <libv@skynet.be>
Acked-by: Luc Verhaegen <libv@skynet.be>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4322
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Luc Verhaegen [Fri, 29 May 2009 03:04:16 +0000 (03:04 +0000)]
Implement native VGA Support.
This code brings a rather complete set of VGA IO routines for whoever wants it.
These consist of the by now familiar read/write/mask sets. Due to the crazy
nature of VGA, an ancient standard with bits all over the place, it makes no
sense to define individual registers. You need a vga register spec at hand if
you want to do anything anyway. These IO routines are always exposed.
It also provides code to natively set up a 640x400 VGA textmode with an 8x16
font. The native VGA mode code is behind the OPTION_VGA option, as the font
really adds to the size of the compiled/compressed rom. The font is the one
also present in the linux kernel, but this file is unlicensed. Another copy of
this is also present in coreboot in the deprecated console/btext code.
The vga console code has been cleaned up, but it still has some TODO's left
open, but that's for when i finally have found the remaining issue with the
epia-m. Right now, it is important to get parts of my work out already and to
make the remainder managable again.
Signed-off-by: Luc Verhaegen <libv@skynet.be>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4321
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Patrick Georgi [Thu, 28 May 2009 22:18:25 +0000 (22:18 +0000)]
Add lzma.o for CBFS, regardless if CONFIG_COMPRESSED_PAYLOAD_LZMA is
enabled or not.
CONFIG_COMPRESSED_PAYLOAD_LZMA is set only if the lzma utility is found
on the system - at least when using abuild. CBFS doesn't use this tool
for compression.
The result was a failed build if lzma (the tool) wasn't found, or
failed runtime (if src/lib/cbfs.c disables lzma decompression based on
CONFIG_COMPRESSED_PAYLOAD_LZMA)
Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4320
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Myles Watson [Thu, 28 May 2009 21:57:11 +0000 (21:57 +0000)]
Make memmove copy (dev->resources -i) resource structs instead of
(dev->resources-i) bytes in compact_resources.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4319
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Uwe Hermann [Wed, 27 May 2009 18:55:19 +0000 (18:55 +0000)]
First batch of indent-aided code cleanups, more will follow.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4318
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Uwe Hermann [Wed, 27 May 2009 17:06:54 +0000 (17:06 +0000)]
Make directory hierarchy flat to match the same layout we use
for other chipsets, as suggested on IRC.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4317
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Patrick Georgi [Wed, 27 May 2009 14:57:53 +0000 (14:57 +0000)]
Trivial, but brown paper bag worthy:
#ifdef CONFIG_foo
is a bad idea with our build system
Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4316
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Patrick Georgi [Wed, 27 May 2009 14:19:31 +0000 (14:19 +0000)]
Move coreboot_ram and coreboot_apc to CBFS. This allows to
reduce the size of the bootblock (done for kontron/986lcd-m)
Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4315
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Uwe Hermann [Wed, 27 May 2009 13:46:37 +0000 (13:46 +0000)]
Change all vx800 file names from CamelCase to camel_case to match
our coding guidelines (trivial).
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4314
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Bari Ari [Wed, 27 May 2009 13:12:42 +0000 (13:12 +0000)]
Here's the VIA vx800 patch from OLPC.
It's untested, but a good starting point for everyone.
Signed-off-by: Bari Ari <bari@onelabs.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4313
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Luc Verhaegen [Wed, 27 May 2009 11:39:16 +0000 (11:39 +0000)]
util/vgabios: build/warning fixes.
Signed-off-by: Luc Verhaegen <libv@skynet.be>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4312
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Patrick Georgi [Tue, 26 May 2009 19:39:14 +0000 (19:39 +0000)]
Clean up acpi table writing code, and don't rely
on a given alignment for the RSDP and RSDT - look
it up instead.
Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4311
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Stefan Reinauer [Tue, 26 May 2009 18:01:53 +0000 (18:01 +0000)]
Tell lpgcc about the target architecture directory. This slipped through since
FILO does not use lpgcc (yet)
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4310
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Patrick Georgi [Tue, 26 May 2009 14:49:59 +0000 (14:49 +0000)]
Make printk_* behaviour more consistent. Without it, side
effects in the arguments (eg. a pci config read, or variable increment)
"vanish" with the message, and the behaviour changes.
Some of these effects might be unwanted, but at least they are consistent now.
To reduce the memory footprint slightly, the formatted strings are discarded.
Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4309
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Stefan Reinauer [Tue, 26 May 2009 14:37:17 +0000 (14:37 +0000)]
encapsule mbi initialization in write_multiboot_table, where it belongs. (very
simple and trivial)
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4308
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Patrick Georgi [Tue, 26 May 2009 14:31:37 +0000 (14:31 +0000)]
Make vsprintf reentrant. More importantly, eliminate global variable.
Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4307
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Stefan Reinauer [Tue, 26 May 2009 14:07:44 +0000 (14:07 +0000)]
Major cleanup of i386 tables.c:
* fix copyright messages
* remove all HAVE_HIGH_TABLES and HAVE_LOW_TABLES preprocessor hackery
and instead use high_tables_base to find out if high tables should be used.
The code path with high tables disabled and high tables not available for
another reason should be the same.
* put MP-table into Fseg instead of 0x10. This allows us to drop an huge and ugly
portion of code. And it will make some ugly Linux warnings go away.
* use ALIGN macro instead of hand crafted aligning.
* renumber post codes in this piece of code (don't jump ahead and
back anymore)
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4306
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Patrick Georgi [Tue, 26 May 2009 14:03:51 +0000 (14:03 +0000)]
Various fixes to the tree to get coreboot-v2 to build on Solaris
- Replace $(PWD) with $(CURDIR) in Makefiles. I don't know why
the Solaris version behaves differently, but CURDIR is a safe
choice on gnu make (and we require gnu make already)
- Use tail -1 instead of tail -n1 in a file that already relies on
tail -1 support in another place
- Use tail -1 as alternative to tail -n1 in another place
- Use #define for ulong_t in romcc, as that name is used on Solaris
- Avoid fprinting a null pointer. The standard doesn't mandate that
this is a special case, and Solaris doesn't implement it that way.
Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4305
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Patrick Georgi [Tue, 26 May 2009 14:00:49 +0000 (14:00 +0000)]
Attached patch moves the CBFS payload loader to selfboot.c as it's
the only selfboot user in CBFS.
This way, CBFS can be used without importing selfboot.c, as long as
no payloads are loaded.
Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4304
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Stefan Reinauer [Tue, 26 May 2009 13:03:30 +0000 (13:03 +0000)]
the i82801xx driver does not know ide{0,1}_enable in its chip.h, so comment it
out in the mainboard config file. (trivial)
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4303
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Stefan Reinauer [Tue, 26 May 2009 12:58:00 +0000 (12:58 +0000)]
ops can not be const because of the pci conf1/conf2 hackery we do. trivial
patch, just removes the warnings like
coreboot-v2/src/southbridge/intel/i82801xx/i82801xx_ac97.c:73: warning: initialization discards qualifiers from pointer target type
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4302
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Stefan Reinauer [Tue, 26 May 2009 12:33:52 +0000 (12:33 +0000)]
acpi.c: add a cast to remove warning (trivial)
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4301
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Stefan Reinauer [Tue, 26 May 2009 12:33:06 +0000 (12:33 +0000)]
remove some dead code from cpu.c (trivial)
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4300
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Stefan Reinauer [Tue, 26 May 2009 12:22:10 +0000 (12:22 +0000)]
Cosmetic cbfstool update (trivial)
* remove some dead code
* fix indentation
* comment in some destructors and fix some other warnings
* use HOSTCC instead of CC (not all the way cosmetic, but very simple)
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4299
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Stefan Reinauer [Sat, 23 May 2009 22:02:31 +0000 (22:02 +0000)]
keyboard driver: function definitions should not omit void if they don't take
parameters. (trivial)
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4298
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Stefan Reinauer [Sat, 23 May 2009 22:00:58 +0000 (22:00 +0000)]
fix comment in keyboard driver (trivial)
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4297
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Uwe Hermann [Fri, 22 May 2009 18:17:06 +0000 (18:17 +0000)]
Make the getpir output look less crappy and add a license
header template, as people keep forgetting them.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4296
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Ward Vandewege [Fri, 22 May 2009 16:03:04 +0000 (16:03 +0000)]
Fix MAINBOARD_PART_NUMBER to be h8dme, I forgot to change it from the h8dmr
tree it was copied from.
This is a trivial patch.
Signed-off-by: Ward Vandewege <ward@gnu.org>
Acked-by: Ward Vandewege <ward@gnu.org>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4295
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Myles Watson [Thu, 21 May 2009 15:12:39 +0000 (15:12 +0000)]
Defaulting to the board's default size is the correct thing to do.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4294
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Patrick Georgi [Thu, 21 May 2009 10:02:52 +0000 (10:02 +0000)]
This change adds PPC support to libpayload, and hooks it up in the build
process.
The PPC support is still stubbed, with commented out x86 code as guide
line for an implementor.
Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4293
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Myles Watson [Tue, 19 May 2009 18:15:49 +0000 (18:15 +0000)]
Trivial update of Config-lab.lb so that it works again.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4292
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Patrick Georgi [Sun, 17 May 2009 20:36:45 +0000 (20:36 +0000)]
Add type field to memranges, and fill it from the source data.
type field contains e820 type ids, which are used by coreboot
and multiboot (the two source formats), so they can be used
as-is.
The MEMMAP_RAM_ONLY define is a way to allow a payload to opt
for only having CB_MEM_RAM type fields, which might be helpful
to support older payloads easily (just add the define, and it
won't encounter "weird" fields)
Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4291
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Ronald G. Minnich [Sat, 16 May 2009 23:05:20 +0000 (23:05 +0000)]
This patch implements a "flash friendly" value for initialized areas of flash.
It makes the write part of flashrom dramatically faster with small
payloads like filo; and it also eliminates unnecessary wear on flash
by not writing zeros (it's unlikely this really matters; let me know
next time you flash a BIOS flash 100,000 times!).
More importantly, it allows for future partial flash upgrades with cbfs.
Note that uninitialized_flash_value is a global that can, if we ever need it,
be set by an argument in main. Assuming we ever see a flash where the
"erased" value is 0, not 0xff.
At the same time, "erased" value has been "1" on every EEPROM or
FLASH I've used for some time now.
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4290
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Vincent Lim [Fri, 15 May 2009 18:02:25 +0000 (18:02 +0000)]
There were a few updates lately that generates ROM size > 512K. I am changing the default ROM size to 1M to accommodate this and future changes. I tested on SimNow family10h_1p.bsd and it POSTs OK.
Signed-off-by: Vincent Lim <vincent.lim@amd.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4289
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Marc Jones [Thu, 14 May 2009 23:42:41 +0000 (23:42 +0000)]
Update equivalent processor revision ID to load latest microcode patches and
register setting for all FAM10 processors.
This does not include new errata for FAM10 C2.
Signed-off-by: Marc Jones <marcj303@gmail.com>
Acked-by: Vincent Lim (vincent.lim@amd.com)
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4288
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Vincent Lim [Thu, 14 May 2009 22:11:08 +0000 (22:11 +0000)]
Trivia: remove comment
Signed-off-by: Vincent Lim <vincent.lim@amd.com>
Acked-by: Vincent Lim <vincent.lim@amd.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4287
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Vincent Lim [Thu, 14 May 2009 22:00:28 +0000 (22:00 +0000)]
From AMD family 10h Processor BKDG (rev. D): a platform is capable of having up to 8 nodes, and each nodes supports 1,2,3,4,5, or 6 cores.
Signed-off-by: Vincent Lim <vincent.lim@amd.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4286
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Ronald G. Minnich [Thu, 14 May 2009 21:26:28 +0000 (21:26 +0000)]
#136: failed to boot under KVM\QEMU
> -------------------------------------+--------------------------------------
> Reporter: silicium@… | Owner: somebody
> Type: defect | Status: new
> Priority: major | Milestone:
> Component: coreboot | Version: v2
> Keywords: | Dependencies:
> Patchstatus: patch needs review |
> -------------------------------------+--------------------------------------
Fix use of uninitialized pointers. To help in future, move
the declaration to the same scope as the use.
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4285
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Ward Vandewege [Thu, 14 May 2009 03:00:15 +0000 (03:00 +0000)]
The cbfstool print command should pretty-print the type of components that are
type 'deleted'.
Signed-off-by: Ward Vandewege <ward@gnu.org>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4284
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Ward Vandewege [Wed, 13 May 2009 20:11:04 +0000 (20:11 +0000)]
This patch fixes a segfault when a file too large to fit is added to a rom
image.
Signed-off-by: Ward Vandewege <ward@gnu.org>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4283
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Ward Vandewege [Wed, 13 May 2009 20:08:28 +0000 (20:08 +0000)]
Add support for human-friendly component string types for the cbfstool add
command.
Make use of it in config.g (Myles)
Signed-off-by: Ward Vandewege <ward@gnu.org>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4282
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Patrick Georgi [Wed, 13 May 2009 16:27:25 +0000 (16:27 +0000)]
Allow dynamic size for the {s,}elfboot bounce buffer.
Use that to fix selfboot with compressed payloads.
Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4281
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Patrick Georgi [Wed, 13 May 2009 14:39:59 +0000 (14:39 +0000)]
Make ACPI with low and high tables work again. The RSDP contained a
bogus RSDT pointer due to a wrong order of commands.
Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4280
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Myles Watsonmylesgw [Wed, 13 May 2009 02:48:58 +0000 (02:48 +0000)]
Remove a shadowed variable and an unnecessary local variable in cbfstool/fs.c.
It is nearly trivial.
Signed-off-by: Myles Watson<mylesgw@gmail.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4279
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Joseph Smith [Wed, 13 May 2009 02:47:14 +0000 (02:47 +0000)]
Oops forgot small part. Set up PIRQs in mainboard Config.lb for IP1000 and RM4100 instead of using the ones in i82801xx_lpc.c.
Signed-off-by: Joseph Smith <joe@settoplinux.org>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4278
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Samuel Verstraete [Tue, 12 May 2009 15:15:07 +0000 (15:15 +0000)]
This is the final patch that got everything working for me with the HP dl145g3.
I would like to remind you that this firmware enables the hardware
virtualization on the AMD cpu's on the machine. That feature was
explicitly disabled by the factory BIOS.
Due to an error in the VGAROM no other rom loader (YABEL or X*^BIOS)
than SeaBIOS manages to load the VGA rom. The VGA ROM tries to read
config space of a device that is actually not present.
Because SeaBIOS does not support AHCI SATA it can not start the
bootable drive of the machine so i had to add filo to seabios to
manage booting:
./cbfstool coreboot.rom add-payload filo.elf img/FILO
Signed-off-by: Samuel Verstraete <samuel.verstraete@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4277
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Ronald G. Minnich [Tue, 12 May 2009 15:06:54 +0000 (15:06 +0000)]
This fixes a rather silly bug in cbfs with filenames > 16 characters.
Tested to booting linux with qemu.
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Myles Watson<mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4276
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Uwe Hermann [Tue, 12 May 2009 14:24:25 +0000 (14:24 +0000)]
There's no 'svg2pdf' in Debian AFAICT, probably the same problem on
other systems too.
So, check for svg2pdf, convert, and inkscape and use the first one that is
found to convert the SVG files to PDF.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4275
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Myles Watson [Tue, 12 May 2009 14:14:54 +0000 (14:14 +0000)]
I guess a couple of function calls pushed these boards over the 0x1700 edge on
the build server.
Add Config-abuild.lb to fix s2892 & s2891.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4274
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Myles Watson [Tue, 12 May 2009 14:03:12 +0000 (14:03 +0000)]
Trivially copy Config.lb to Config-abuild.lb to fix asus/m2v-mx_se.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4273
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Uwe Hermann [Tue, 12 May 2009 14:01:14 +0000 (14:01 +0000)]
Fix pdflatex build issues (trivial).
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4272
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Myles Watson [Tue, 12 May 2009 13:43:34 +0000 (13:43 +0000)]
Use the debugging functions to print out the tree and resources.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4271
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Myles Watson [Mon, 11 May 2009 22:45:35 +0000 (22:45 +0000)]
Bring v3-style debug output to v2. Fix a minor typo.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4270
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Myles Watson [Mon, 11 May 2009 22:44:14 +0000 (22:44 +0000)]
This patch adds high table support to qemu. It was already added to
src/northbridge/intel/i440bx/ but not to
src/cpu/emulation/qemu-x86/northbridge.c
It also adds a driver for the ISA device that is found when using
0.9.1 If you look in a log without this patch you won't find the RTC
init lines.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4269
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Myles Watson [Mon, 11 May 2009 22:24:53 +0000 (22:24 +0000)]
Trivial white space fixes so that the next patches are easier to read.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4268
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Zheng Bao [Mon, 11 May 2009 13:45:11 +0000 (13:45 +0000)]
We should separate the it8718f_24mhz_clkin like the way IT8712 does.
Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Acked-by; Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4267
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Uwe Hermann [Mon, 11 May 2009 01:44:54 +0000 (01:44 +0000)]
Fix manual build on the Kontron board (trivial).
A manual build was yielding section overlaps, so increase
ROM_IMAGE_SIZE to the same size the Config-abuild.lb is using.
Build-tested by me using a manual build.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4266
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Rudolf Marek [Sun, 10 May 2009 20:35:18 +0000 (20:35 +0000)]
Following patch fixes the XIP computation issue. I removed the normal image
because it was not working anyway (it was hardcoded) and because it allows me to
fix the XIP base to something sane (and use generic computation and approach)
This board is bit tricky because until now it required the VGA BIOS on the flash
start. XIP will work with 64KB aligned base, therefore the VGA ROM image must be
aligned too to 64KB.
Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4265
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Ronald G. Minnich [Sat, 9 May 2009 17:14:58 +0000 (17:14 +0000)]
I would have liked to get an ack, but the error this corrects is pretty
critical, since unless it is fixed this tool creates empty tables that cause
coreboot to (in some cases, e.g. on qemu) triple fault and die.
For the record, an empty option_table is not allowed. The table must,
at least, have 3 32-bit entries in this order:
type -- should be 200, 0r 0xc8, i.e. 0xc8, 0, 0, 0
size of table in LE order, 4 bytes
size of header in LE order, which is always 12,0,0,0
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4264
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Myles Watson [Fri, 8 May 2009 20:07:00 +0000 (20:07 +0000)]
Trivial clean up of print usage and parameter checking.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4263
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Myles Watson [Fri, 8 May 2009 19:39:15 +0000 (19:39 +0000)]
Add -Werror to help us keep the code clean.
Change sizes from unsigned int to int.
Clean up some usage and parameter checking.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4262
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Ronald G. Minnich [Fri, 8 May 2009 19:23:00 +0000 (19:23 +0000)]
I have made a very simple mod to cbfstool that is compatible with the
src/lib/ code in coreboot. I.e. the tool changes but the coreboot code
does not.
Currently, as cbfstool manages the ROM, there are files and empty
space. To allocate files, the code does, first, a walk of the headers
and, if that fails, does a brute-force search of the rest of the
space.
We all agree that the brute-force search has lots of problems from a
performance and correctness standpoint.
I've made a slight change. Instead of an "empty space" area with no
valid headers, I've made a header for the empty space.
So cbfs creation looks like this:
- set up the boot block
- create a file, of type CBFS_COMPONENT_NULL, that contains the empty
space. CBFS_COMPONENT_NULL was already defined in cbfs.h
Here's an example:
[rminnich@xcpu2 cbfstool]$ ./cbfstool testcbfs create
1048576 2048
(cbfstool) E: Unable to open (null): Bad address
[rminnich@xcpu2 cbfstool]$ ./cbfstool testcbfs print
testcbfs: 1024 kB, bootblocksize 2048, romsize
1048576, offset 0x0
Alignment: 16 bytes
Name Offset Type Size
0x0 0xffffffff
1046456
So how do we create a new file?
It's easy: walk the files and find a file of type CBFS_COMPONENT_NULL,
which is as large
or larger than the file you are trying to create. Then you use that file.
- if the file is the same size as the NULL file, then it's easy: take it
- if the file is smaller than the NULL file, you split the NULL file
into two parts.
note that this works in the base case: the base case is that the whole
storage is CBFS_COMPONENT_NULL.
Here's an example of adding a file.
[rminnich@xcpu2 cbfstool]$ ./cbfstool testcbfs add-stage testfixed t
[rminnich@xcpu2 cbfstool]$ ./cbfstool testcbfs print
testcbfs: 1024 kB, bootblocksize 2048, romsize
1048576, offset 0x0
Alignment: 16 bytes
Name Offset Type Size
t 0x0 stage 23176
0x5ab0 0xffffffff
1023240
Note that the NULL split and got smaller. But the entire ROM is still
contained by the two files. To walk this entire rom will require two
FLASH accesses.
Add another file:
[rminnich@xcpu2 cbfstool]$ ./cbfstool testcbfs add-stage testfixed tt
[rminnich@xcpu2 cbfstool]$ ./cbfstool testcbfs print
testcbfs: 1024 kB, bootblocksize 2048, romsize
1048576, offset 0x0
Alignment: 16 bytes
Name Offset Type Size
t 0x0 stage 23176
tt 0x5ab0 stage 23176
0xb560 0xffffffff
1000024
[rminnich@xcpu2 cbfstool]$
So, taking current ROMs as an example, I can reduce FLASH accesses for
cbfs from (potentially) thousands to (typically) less than 10.
Index: fs.c
Changes for readability and cleanliness. Move common blobs of code to functions.
New function: rom_alloc,which allocates files by finding NULL files and using/splitting.
Other changes as needed to support this usage.
Index: util.c
Creating a cbfs archive now requires creation of a NULL file covering the file system space.
Index: cbfs.h
Add a DELETED file type with value 0. Any file can be marked deleted by zero its type; this is a
FLASH-friendly definition for all known FLASH types.
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
I think it is a step in the right direction. Could you add the
function prototype to cbfstool.h?
Acked-by: Myles Watson <mylesgw@gmail.com>
(I added the prototype)
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4261
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Joseph Smith [Fri, 8 May 2009 00:45:47 +0000 (00:45 +0000)]
Trivial fixup IRQS on IP1000 and RM4100.
Signed-off-by: Joseph Smith <joe@settoplinux.org>
Acked-by: Joseph Smith <joe@settoplinux.org>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4260
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Joseph Smith [Fri, 8 May 2009 00:24:24 +0000 (00:24 +0000)]
Set up PIRQs in mainboard Config.lb for IP1000 and RM4100 instead of using the ones in i82801xx_lpc.c.
Signed-off-by: Joseph Smith <joe@settoplinux.org>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4259
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Joseph Smith [Fri, 8 May 2009 00:19:13 +0000 (00:19 +0000)]
Disable the AC97 modem via the ICH4 LPC disable function register early in the boot process.
Signed-off-by: Joseph Smith <joe@settoplinux.org>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4258
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Joseph Smith [Thu, 7 May 2009 05:47:05 +0000 (05:47 +0000)]
Trivial checksum fixup for irq tables on IP1000 and RM4100.
Signed-off-by: Joseph Smith <joe@settoplinux.org>
Acked-by: Joseph Smith <joe@settoplinux.org>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4257
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Uwe Hermann [Thu, 7 May 2009 00:21:02 +0000 (00:21 +0000)]
Fix my last commit. I looked at the wrong dead laptop.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4256
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Uwe Hermann [Thu, 7 May 2009 00:03:18 +0000 (00:03 +0000)]
Support for detecting the SMSC FDC37N869 (trivial).
No datasheet available, chip identified by probing and looking at the PCB.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4255
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Patrick Georgi [Tue, 5 May 2009 14:06:20 +0000 (14:06 +0000)]
Fix a bug introduced in the copy_and_run refactoring.
The new code always decompressed to dst (as it should)
and then jumped to _iseg, when it should jump to dst.
With dst != _iseg this breaks (coreboot_apc)
Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Ward Vandewege <ward@gnu.org>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4254
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Myles Watson [Mon, 4 May 2009 20:27:09 +0000 (20:27 +0000)]
This patch removes these warnings:
Makefile:435: warning: overriding commands for target `src/lib/memset.o'
And replaces these debug messages:
partobj dir 0 parent <__main__.partobj instance at 0x7f1e846a7ab8>
part pci_domain
with:
partobj dir 0 parent northbridge_amd_amdk8_root_complex_dev2 part pci_domain
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4253
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Rudolf Marek [Mon, 4 May 2009 19:26:43 +0000 (19:26 +0000)]
The rev 4099 broke ECC boards, they need to have tidy the ECC tags. Myles reverted this change.
I think we can return the 4099 back under HAVE_ACPI_RESUME define to make everyone happy (and booting ;).
Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Rudolf Marek <r.marek@assembler.cz>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4252
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Joseph Smith [Sat, 2 May 2009 21:30:57 +0000 (21:30 +0000)]
Assign PIRQs in mainboard Config.lb or use the default ones listed in i82801xx_lpc.c.
Signed-off-by: Joseph Smith <joe@settoplinux.org>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4251
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Stefan Reinauer [Sat, 2 May 2009 12:42:30 +0000 (12:42 +0000)]
Run dos2unix on all files:
find . -type f| grep -v svn | xargs dos2unix
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4250
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Joseph Smith [Sat, 2 May 2009 00:59:03 +0000 (00:59 +0000)]
Trivial, update email address.
Signed-off-by: Joseph Smith <joe@settoplinux.org>
Acked-by: Joseph Smith <joe@settoplinux.org>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4249
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Joseph Smith [Sat, 2 May 2009 00:50:58 +0000 (00:50 +0000)]
Trivial fix up to the GPIO's connected to the IP1000 and RM4100, only set ones that are actually connected to something.
Signed-off-by: Joseph Smith <joe@settoplinux.org>
Acked-by: Joseph Smith <joe@settoplinux.org>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4248
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Peter Stuge [Fri, 1 May 2009 14:33:19 +0000 (14:33 +0000)]
Trivial removal of svn:executable property from vga.c.
Signed-off-by: Peter Stuge <peter@stuge.se>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4247
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Joseph Smith [Fri, 1 May 2009 04:53:58 +0000 (04:53 +0000)]
This is a patch to use another IRQ besides IRQ12 to fix conflicts with i8042 - PS/2 Mouse.
Signed-off-by: Joseph Smith <joe@settoplinux.org>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4246
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Joseph Smith [Fri, 1 May 2009 04:44:36 +0000 (04:44 +0000)]
This patch changes the default rom emulator to VM86.
Signed-off-by: Joseph Smith <joe@settoplinux.org>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4245
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Joseph Smith [Fri, 1 May 2009 04:37:13 +0000 (04:37 +0000)]
This patch allows a custom vga driver that will give the flexibility to run code after vga is initialized for tv-out.
Signed-off-by: Joseph Smith <joe@settoplinux.org>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4244
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Myles Watson [Fri, 1 May 2009 04:36:38 +0000 (04:36 +0000)]
Trivial patch to make #defines generated from cmos.layout have unique names. Kills a few more compiler warnings.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4243
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Joseph Smith [Fri, 1 May 2009 03:04:20 +0000 (03:04 +0000)]
Trivial cosmetic fixes to IP1000 and RM4100 irq_tables.c Signed-off-by: Joseph Smith <joe@settoplinux.org> Acked-by: Joseph Smith <joe@settoplinux.org>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4242
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Myles Watson [Fri, 1 May 2009 02:24:40 +0000 (02:24 +0000)]
The semantics of the changed code are pretty simple and looking at
other parts of the same file shows that it is a common construct.
Remove the shadowed variable.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4241
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Myles Watson [Thu, 30 Apr 2009 22:45:41 +0000 (22:45 +0000)]
Remove warnings from compilation of the s2892 with and without CBFS.
I didn't try to remove "defined but not used" warnings because there are too
many ifdefs to be sure I wouldn't break something.
For shadowed variable declarations I renamed the inner-most variable.
The one in src/pc80/keyboard.c might need help. I didn't change the
functionality but it looks like a bug.
I boot tested it on s2892 and abuild tested it.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4240
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Stefan Reinauer [Thu, 30 Apr 2009 16:46:12 +0000 (16:46 +0000)]
Some driver fixes for libpayload:
- fix minor bug in serial driver.
- latest USB stack fixes
- fix dead store in options.c
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4239
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1
Stefan Reinauer [Thu, 30 Apr 2009 13:58:42 +0000 (13:58 +0000)]
Add high tables support to all northbridges.
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4238
2b7e53f0-3cfb-0310-b3e9-
8179ed1497e1