Trivial clean up of print usage and parameter checking.
authorMyles Watson <mylesgw@gmail.com>
Fri, 8 May 2009 20:07:00 +0000 (20:07 +0000)
committerMyles Watson <mylesgw@gmail.com>
Fri, 8 May 2009 20:07:00 +0000 (20:07 +0000)
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4263 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

util/cbfstool/print.c

index b23f949e0628f6767429445e275f7cf02d8eaf93..234fefb423d5530fdd4fb254b4a8821107810af5 100644 (file)
@@ -27,8 +27,11 @@ void print_usage(void)
 
 int print_handler(struct rom *rom, int argc, char **argv)
 {
-       if (argc > 0 || argv[1] != NULL)
-               printf("print\t\t\t\tShow the contents of the ROM\n");
+       if ( argc > 0 ) {
+               ERROR("print %s? print takes no arguments.\n", argv[0]);
+               print_usage();
+               return -1;
+       }
 
        printf("%s: %d kB, bootblocksize %d, romsize %d, offset 0x%x\n", rom->name, rom->size / 1024, 
                                ntohl(rom->header->bootblocksize), ntohl(rom->header->romsize), ntohl(rom->header->offset));