The semantics of the changed code are pretty simple and looking at
authorMyles Watson <mylesgw@gmail.com>
Fri, 1 May 2009 02:24:40 +0000 (02:24 +0000)
committerMyles Watson <mylesgw@gmail.com>
Fri, 1 May 2009 02:24:40 +0000 (02:24 +0000)
other parts of the same file shows that it is a common construct.

Remove the shadowed variable.

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4241 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

src/pc80/keyboard.c

index 325e2eabca45d7e4be009d8a596d7a7aa5d30614..e255132a7eaa85304d71938f98ea9b0301357763 100644 (file)
@@ -112,11 +112,10 @@ static void pc_keyboard_init(struct pc_keyboard *keyboard)
                outb(0x60, 0x64);
                if (!kbc_input_buffer_empty()) return;
                outb(0x20, 0x60);       /* send cmd: enable keyboard and IRQ 1 */
-               u8 broken_resend = 10;
                if ((inb(0x64) & 0x01)) {
                        regval = inb(0x60);
                }
-               --broken_resend;
+               --resend;
        } while (regval == 0xFE && resend > 0);
 
        /* clean up any junk that might have been in the keyboard */