coreboot.git
15 years agoFix typo.
Marc Jones [Wed, 1 Apr 2009 22:07:53 +0000 (22:07 +0000)]
Fix typo.
trivial.

Signed-off-by: Marc Jones <marcj303@gmail.com>
Acked-by: Marc Jones <marcj303@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4046 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoUpdated microcode for for AMD Fam10 DR-B2 and B3.
Zheng Bao [Wed, 1 Apr 2009 16:22:38 +0000 (16:22 +0000)]
Updated microcode for for AMD Fam10 DR-B2 and B3.

Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Acked-by: Marc Jones <marcj303@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4045 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoforgot this.
Ronald G. Minnich [Wed, 1 Apr 2009 16:06:33 +0000 (16:06 +0000)]
forgot this.

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4044 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years ago(trivial) add filo call back for those few mainboards that still (need to)
Stefan Reinauer [Wed, 1 Apr 2009 13:54:16 +0000 (13:54 +0000)]
(trivial) add filo call back for those few mainboards that still (need to)
use the built-in filo.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4043 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoDrop CONFIG_CHIP_NAME. Those config statements in Config.lb should
Stefan Reinauer [Wed, 1 Apr 2009 13:43:21 +0000 (13:43 +0000)]
Drop CONFIG_CHIP_NAME. Those config statements in Config.lb should
be used unconditionally, and the names don't hurt.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4042 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoForgot CONFIG_ROMFS for supermicro/h8dme.
Patrick Georgi [Wed, 1 Apr 2009 11:37:39 +0000 (11:37 +0000)]
Forgot CONFIG_ROMFS for supermicro/h8dme.
Trivial fix, just add the defaults as with all other boards.

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4041 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoAdd copyright notices to two files, src/boot/elfboot.c
ebiederm [Wed, 1 Apr 2009 11:03:32 +0000 (11:03 +0000)]
Add copyright notices to two files, src/boot/elfboot.c
and its derivative src/boot/selfboot.c.

The mail in which Eric asserts authorship on elfboot.c is
quoted below, selfboot.c was substantially edited by Ron.
With that information in mind the change is trivial.

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Wed, 01 Apr 2009 03:31:15 -0700
To: Patrick Georgi <patrick@georgi-clan.de>

Patrick Georgi <patrick@georgi-clan.de> writes:

> Hi,
>
> We found some file in the coreboot tree that we suspect is yours.
> Unfortunately,
> both copyright notice and license are missing.
> Could you please take a look at it, and state whether it's yours,
> and if so,
> what license is to be attached?

Yes. GPLv2

> The file in question is
> http://tracker.coreboot.org/trac/coreboot/browser/trunk/coreboot-v2/src/boot/elfboot.c
> and its history goes back to
> http://tracker.coreboot.org/trac/coreboot/log/trunk/LinuxBIOSv2/src/boot/elfboot.c?rev=2890

Eric

git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4040 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis code adds support for coreboot images that use ROMFS.
Ronald G. Minnich [Wed, 1 Apr 2009 10:48:39 +0000 (10:48 +0000)]
This code adds support for coreboot images that use ROMFS.

It also removes the call to FILO from hardwaremain -- that
has needed removal for a long time.

abuild tested.
Note that this code has been tested and works on
both qemu and kontron. The changes to use it are coming
next.

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4039 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agofix typo
Stefan Reinauer [Tue, 31 Mar 2009 17:17:30 +0000 (17:17 +0000)]
fix typo

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4038 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agofix typo
Stefan Reinauer [Tue, 31 Mar 2009 17:15:42 +0000 (17:15 +0000)]
fix typo

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4037 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agofix shadow variable in compute_ip_checksum.c
Stefan Reinauer [Tue, 31 Mar 2009 16:42:57 +0000 (16:42 +0000)]
fix shadow variable in compute_ip_checksum.c

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4036 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoAdd the CONFIG_ROMS config variable.
Ronald G. Minnich [Tue, 31 Mar 2009 16:32:01 +0000 (16:32 +0000)]
Add the CONFIG_ROMS config variable.

Tested under abuild, causes no trouble.

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4035 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis fixes a shadowed declaration in multiboot.c.
Robert Millan [Tue, 31 Mar 2009 14:11:19 +0000 (14:11 +0000)]
This fixes a shadowed declaration in multiboot.c.

Signed-off-by: Robert Millan <rmh@aybabtu.com>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4034 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agocosmetic fix for function definition.
Stefan Reinauer [Tue, 31 Mar 2009 14:10:42 +0000 (14:10 +0000)]
cosmetic fix for function definition.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4033 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis patch adds Jordan's romtool support for v2.
Ronald G. Minnich [Tue, 31 Mar 2009 11:57:36 +0000 (11:57 +0000)]
This patch adds Jordan's romtool support for v2.
There are a few changes. The 20K bootblock size restriction is gone.

ROMFS has been tested and works on v2 with qemu and kontron. Once this
patch is in, those patches will follow.

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4032 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoflashrom: Board enable support for HP DL145 G3.
Mondrian Nuessle [Mon, 30 Mar 2009 13:20:01 +0000 (13:20 +0000)]
flashrom: Board enable support for HP DL145 G3.

This is a BCM5785 based machine, WP# and TLB# need to be deasserted using
GPIO 2 and 5 from the PM registers of the southbridge.
This is very similar to the x3455 implementation.

Signed-off-by: Mondrian Nuessle <nuessle@uni-hd.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4031 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoDuring the suspend/resume programming I came to an issue that first 4KB of
Rudolf Marek [Thu, 26 Mar 2009 21:45:26 +0000 (21:45 +0000)]
During the suspend/resume programming I came to an issue that first 4KB of
memory must be clear with 0s because otherwise the resources of K8 will be
totally messed up.

res = probe_resource(dev, 0x100 + (reg | link));

This is called with dev = NULL and this is no good for probe_resource at all.
The attached patch fixes the potential problems and of course the problem
itself. On one particular place was missing test if the device really exists.
This was copied to fam10 and perhaps the same issue is in v3 (DID NOT check).
The rest of the patch is just very paranoid and do all checkings.

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Myles Watson <mylesgw@gmail.com>
--This line, and those below, will be igno
red--

M    src/devices/pci_ops.c
M    src/northbridge/amd/amdk8/northbridge.c
M    src/northbridge/amd/amdfam10/northbridge.c

git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4030 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years ago- List SMSC LPC47N227 runtime register block as supported.
Uwe Hermann [Wed, 25 Mar 2009 17:38:40 +0000 (17:38 +0000)]
- List SMSC LPC47N227 runtime register block as supported.

- Add missing contributor in README.

- Cosmetic fixes.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4029 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThe latest ucode patches for Family 10h:
Zeng Bao [Wed, 25 Mar 2009 15:47:58 +0000 (15:47 +0000)]
The latest ucode patches for Family 10h:

9fh for RB/BL/DA Rev C;
96h for DR Rev B.

Signed-off-by: Zeng Bao <zheng.bao@amd.com>
Acked-by: Marc Jones <marcj303@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4028 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoEvery object file with a struct pci_driver ... __pci_driver needs to be marked
Stefan Reinauer [Tue, 24 Mar 2009 12:28:44 +0000 (12:28 +0000)]
Every object file with a struct pci_driver ... __pci_driver needs to be marked
as "driver" instead of "object" in order to get the init code actually
executed.

This patch fixes up all northbridges that did not do this before.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Joseph Smith <joe@settoplinux.org>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4027 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agomsrtool: If an MSR name lookup fails in msraddrbyname(), return the strtoul() convers...
Peter Stuge [Mon, 23 Mar 2009 17:43:12 +0000 (17:43 +0000)]
msrtool: If an MSR name lookup fails in msraddrbyname(), return the strtoul() conversion result.

Thanks to Mart for finding and reporting the problem!

Signed-off-by: Peter Stuge <peter@stuge.se>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4026 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoTo make use of HAVE_HIGH_TABLES following patch is needed. Also, it moves
Rudolf Marek [Sat, 21 Mar 2009 11:52:29 +0000 (11:52 +0000)]
To make use of HAVE_HIGH_TABLES following patch is needed. Also, it moves
coreboot to 1MB and tries to cache whole range for XIP. The UMA part colide a
bit with the HAVE_HIGH_TABLES region. I solved that by relocation of the region.

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4025 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoTo make use of HAVE_HIGH_TABLES following patch is needed. Also, it moves
Rudolf Marek [Sat, 21 Mar 2009 11:50:20 +0000 (11:50 +0000)]
To make use of HAVE_HIGH_TABLES following patch is needed. Also, it moves
coreboot to 1MB and tries to cache whole range for XIP. The UMA part colide a
bit with the HAVE_HIGH_TABLES region. I solved that by relocation of the region.

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4024 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoKevin O'Connor said:
Myles Watson [Fri, 20 Mar 2009 18:29:49 +0000 (18:29 +0000)]
Kevin O'Connor said:
  The bug is in src/arch/i386/boot/boot.c.  The inline assembly in
  jmp_to_elf_entry uses the "g" flag to pass in parameters.  However,
  "g" allows gcc to use stack relative addressing of parameters.

  Easiest fix would be to change "g" to "ri" - put the parameter either
  in a register or as an immediate value.

That's what this patch does.

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4023 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoAdd Supermicro h8dm3 mainboard. This is mostly a copy from the h8dmr.
Marc Jones [Fri, 20 Mar 2009 16:36:05 +0000 (16:36 +0000)]
Add Supermicro h8dm3 mainboard. This is mostly a copy from the h8dmr.
The one issues is the SPD address switch for the second CPU. That means that
the memory must be an exact match on each CPU.

Signed-off-by: Marc Jones <marcj303@gmail.com>
Acked-by: Ward Vandewege <ward@gnu.org>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4022 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoFix CPUID typo. This caused fid to memory speed calculations to be off.
Marc Jones [Fri, 20 Mar 2009 16:03:37 +0000 (16:03 +0000)]
Fix CPUID typo. This caused fid to memory speed calculations to be off.

Signed-off-by: Marc Jones <marcj303@gmail.com>
Acked-by: Ward Vandewege <ward@gnu.org>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4021 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoMove the Atmel AT45 comments about block and page sizes from the end of
Carl-Daniel Hailfinger [Thu, 19 Mar 2009 12:18:13 +0000 (12:18 +0000)]
Move the Atmel AT45 comments about block and page sizes from the end of
the struct to the individual struct members to improve readability.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4020 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agofix the following warning on all boards that don't have PIRQ_ROUTE enabled
Stefan Reinauer [Thu, 19 Mar 2009 01:30:16 +0000 (01:30 +0000)]
fix the following warning on all boards that don't have PIRQ_ROUTE enabled

In file included from coreboot-v2-4017//src/arch/i386/boot/pirq_routing.c:2:
coreboot-v2-4017/src/arch/i386/include/arch/pirq_routing.h:45:5: warning: "PIRQ_ROUTE" is not defined
coreboot-v2-4017//src/arch/i386/boot/pirq_routing.c:103:6: warning: "PIRQ_ROUTE" is not defined

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4019 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agofix totalimpact briq compilation. the target had a cpu specific and a mainboard
Stefan Reinauer [Thu, 19 Mar 2009 01:13:01 +0000 (01:13 +0000)]
fix totalimpact briq compilation. the target had a cpu specific and a mainboard
specific clock.c. Since no other target uses the same cpu, I commented out the
CPU's clock.c.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4018 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoadd YABEL flag to options to decide wether access to devices other than the one yabel...
Pattrick Hueper [Wed, 18 Mar 2009 16:25:34 +0000 (16:25 +0000)]
add YABEL flag to options to decide wether access to devices other than the one yabel is running for is possible

Signed-off-by: Pattrick Hueper <phueper@hueper.net>
Tested and Acked-by: Joseph Smith <joe@settoplinux.org>

git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4017 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoAdd high coreboot table support to libpayload
Stefan Reinauer [Tue, 17 Mar 2009 16:41:01 +0000 (16:41 +0000)]
Add high coreboot table support to libpayload

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4016 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoAdd support for high coreboot table to mkelfimage
Stefan Reinauer [Tue, 17 Mar 2009 15:33:41 +0000 (15:33 +0000)]
Add support for high coreboot table to mkelfimage

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4015 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoDon't know if this is the correct fix, but it fixes compilation of the PPC
Stefan Reinauer [Tue, 17 Mar 2009 15:15:15 +0000 (15:15 +0000)]
Don't know if this is the correct fix, but it fixes compilation of the PPC
targets.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4014 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis patch adds "high coreboot table support" to coreboot version 2.
Stefan Reinauer [Tue, 17 Mar 2009 14:39:36 +0000 (14:39 +0000)]
This patch adds "high coreboot table support" to coreboot version 2.

Some bootloaders seem to overwrite memory starting at 0x600, thus destroying
the coreboot table integrity, rendering the table useless.

By moving the table to the high tables area (if it's activated), this problem
is fixed.

In order to move the table, a 40 bytes mini coreboot table with a single sub
table is placed at 0x500/0x530 that points to the real coreboot table. This is
comparable to the ACPI RSDT or the MP floating table.

This patch also adds "table forward" support to flashrom and nvramtool.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4013 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis patch adds "high coreboot table support" to coreboot version 2.
Stefan Reinauer [Tue, 17 Mar 2009 14:39:25 +0000 (14:39 +0000)]
This patch adds "high coreboot table support" to coreboot version 2.

Some bootloaders seem to overwrite memory starting at 0x600, thus destroying
the coreboot table integrity, rendering the table useless.

By moving the table to the high tables area (if it's activated), this problem
is fixed.

In order to move the table, a 40 bytes mini coreboot table with a single sub
table is placed at 0x500/0x530 that points to the real coreboot table. This is
comparable to the ACPI RSDT or the MP floating table.

This patch also adds "table forward" support to flashrom and nvramtool.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4012 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis patch adds "high coreboot table support" to coreboot version 2.
Stefan Reinauer [Tue, 17 Mar 2009 14:38:48 +0000 (14:38 +0000)]
This patch adds "high coreboot table support" to coreboot version 2.

Some bootloaders seem to overwrite memory starting at 0x600, thus destroying
the coreboot table integrity, rendering the table useless.

By moving the table to the high tables area (if it's activated), this problem
is fixed.

In order to move the table, a 40 bytes mini coreboot table with a single sub
table is placed at 0x500/0x530 that points to the real coreboot table. This is
comparable to the ACPI RSDT or the MP floating table.

This patch also adds "table forward" support to flashrom and nvramtool.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4011 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years ago- TOM2 is filled in by the dynamic ACPI code. Don't hardcode it in the
Carl-Daniel Hailfinger [Tue, 17 Mar 2009 01:47:25 +0000 (01:47 +0000)]
- TOM2 is filled in by the dynamic ACPI code. Don't hardcode it in the
  DSDT and use the dynamic TOM2 variable instead.
- The DSDT needs to be revision 2 or above to handle 64 bit variables.
  This will require a recent (not older than 2007) iasl (ACPI compiler).
- Fix an incorrect comment.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4010 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agodrop empty directory. (trivial)
stepan [Mon, 16 Mar 2009 17:28:07 +0000 (17:28 +0000)]
drop empty directory. (trivial)

Signed-off-by: <stepan@coresystems.de>
Acked-by: <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4009 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agofix typo in pci_device.c (trivial)
Stefan Reinauer [Mon, 16 Mar 2009 15:27:00 +0000 (15:27 +0000)]
fix typo in pci_device.c (trivial)

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4008 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoFix all build problems on PPC except the _SDA_BASE issues caused by the
Stefan Reinauer [Sun, 15 Mar 2009 10:04:41 +0000 (10:04 +0000)]
Fix all build problems on PPC except the _SDA_BASE issues caused by the
code expecting too old binutils(?).

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4007 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoabuild: Don't forget CROSS_COMPILE anymore.
Stefan Reinauer [Sun, 15 Mar 2009 09:55:17 +0000 (09:55 +0000)]
abuild: Don't forget CROSS_COMPILE anymore.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4006 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agotrivial patch for abuild: allow powerpc-elf-gcc, too.
Stefan Reinauer [Sat, 14 Mar 2009 16:33:22 +0000 (16:33 +0000)]
trivial patch for abuild: allow powerpc-elf-gcc, too.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4005 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoadd YABEL Debug Flags to Options
Pattrick Hueper [Sat, 14 Mar 2009 15:43:42 +0000 (15:43 +0000)]
add YABEL Debug Flags to Options

Signed-off-by: Pattrick Hueper <phueper@hueper.net>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4004 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agothis commit should fix Ticket #122 (proper log files for all builds)
Stefan Reinauer [Fri, 13 Mar 2009 17:22:53 +0000 (17:22 +0000)]
this commit should fix Ticket #122 (proper log files for all builds)

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4003 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis patch reverts SuperIO changes that I was too hasty with. Even though the
Myles Watson [Fri, 13 Mar 2009 17:20:59 +0000 (17:20 +0000)]
This patch reverts SuperIO changes that I was too hasty with.  Even though the
address of the RTC is 0x70, you need to write 0x400 to it.  Now the dump from
superiotool matches the factory except 0xf0 of the keyboard.  When you boot with
the factory BIOS that is 0x04, but with coreboot it is not set.

It's trivial because it is reverts.

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4002 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis one is an example on how to drop vgabios.c from the mainboard or chipset
Stefan Reinauer [Fri, 13 Mar 2009 17:00:46 +0000 (17:00 +0000)]
This one is an example on how to drop vgabios.c from the mainboard or chipset
directories and use the global (v3) one in util/x86emu instead. It also fixes
the breakage introduced by 4000

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4001 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis, ladies and gentlement, is commit #4000.
Stefan Reinauer [Fri, 13 Mar 2009 15:42:27 +0000 (15:42 +0000)]
This, ladies and gentlement, is commit #4000.

Use the (almost) same strict CFLAGS in v2 that we use on v3. And fix a few
include files and missing prototypes. Also, fix up the Config-abuild.lb files
to properly work for cross compiling.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4000 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoACPI implementation for i945, ICH7, Kontron 986LCD-M
Stefan Reinauer [Fri, 13 Mar 2009 00:44:09 +0000 (00:44 +0000)]
ACPI implementation for i945, ICH7, Kontron 986LCD-M

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3999 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoFix HIGH_TABLES introduced error when compiling without MP table
Myles Watson [Thu, 12 Mar 2009 17:42:20 +0000 (17:42 +0000)]
Fix HIGH_TABLES introduced error when compiling without MP table

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3998 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoi945 northbridge update
Stefan Reinauer [Wed, 11 Mar 2009 16:20:39 +0000 (16:20 +0000)]
i945 northbridge update

- lots of PCIe updates
- various bug fixes to early init
- some fixes for typos and warnings
- initial support for PCIe x16
- some minor fixes to memory init code
- some subsystem vendor id patches, to be consistent with ICH7

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3997 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years ago20090310-3-scanbuild:
Patrick Georgi [Wed, 11 Mar 2009 15:43:02 +0000 (15:43 +0000)]
20090310-3-scanbuild:
Add support for clang's scan-build utility to abuild. scan-build wraps
the compiler and runs its own compiler on the same sources to do some
static analysis on them. It adds an option "-sb" or "--scan-build" that
creates a coreboot-builds/$target-scanbuild directory for every $target,
containing the output of scan-build, which is a HTML documentation on
its results.
Be aware, that scanbuild significantly increases build time: A board
that takes 6-7 seconds normally requires 60 seconds with that option
enabled on my test system.
The patch also moves the stack-protector option down a bit, so it
applies to crosscompiled targets, too (which overwrote the compiler
settings before)

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3996 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years ago20090310-2-gcc-for-real:
Patrick Georgi [Wed, 11 Mar 2009 15:36:39 +0000 (15:36 +0000)]
20090310-2-gcc-for-real:
Create a variable "GCC", which defaults to the content of CC, but allows
the user to provide a gcc to use in this instance, even when normally a
different tool is chosen. That helps with scan-build (see next patch),
and might help with distcc, ccache etc, too.

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3995 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years ago20090310-1-paths:
Patrick Georgi [Wed, 11 Mar 2009 15:35:22 +0000 (15:35 +0000)]
20090310-1-paths:
The rules changed in this patch originally wanted to write c_start.o
into the source tree. That triggered a bug in my other work, and is
generally not what we want.

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3994 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoKontron 986LCD-M updates:
Stefan Reinauer [Wed, 11 Mar 2009 15:20:36 +0000 (15:20 +0000)]
Kontron 986LCD-M updates:
* ACPI updates: MCFG, HPET, FADT
* some mptable fixes for certain riser cards
* Use Channel XOR randomization
* Fix SuperIO HWM setup
* Enable all three network adapters

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3993 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoabuild:
Stefan Reinauer [Wed, 11 Mar 2009 15:00:50 +0000 (15:00 +0000)]
abuild:

- add configure only mode to easily and quickly check Config.lb and Option.lb
  files
- fix up cross compiler handling
- don't use in-place sed, not all sed versions can do it
- use perl instead of date to avoid non-gnu date trouble

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3992 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis patch contains some significant updates to the i82801gx component and will
Stefan Reinauer [Wed, 11 Mar 2009 14:54:18 +0000 (14:54 +0000)]
This patch contains some significant updates to the i82801gx component and will
be required for a series of later patches. Roughly it contains:

* fixed SMBus driver (was not compiled in before)
* fixed S-ATA/P-ATA combination
* Added warnings to drivers being called with a NULL dev->chip_info
* Set subsystem ids for those boards that have none specified in Options.lb
* Fix license headers. The code was originally released under GPL v2 but
  some files sneaked in with a v2 or later header.
* some attempts to fix azalia/Intel HDA.. not working yet
* clean up and fix pci bridge handling code
* Add Config based GPI handling to LPC driver
* Add HPET enable function
* Enable clock gating where appropriate
* first attempt at USB debug console support (not working yet)
* Add required options to kontron board
* many other minor changes

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3991 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoAdd support for the LPC47M182 to superiotool
Stefan Reinauer [Wed, 11 Mar 2009 14:48:20 +0000 (14:48 +0000)]
Add support for the LPC47M182 to superiotool

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Joseph Smith <joe@settoplinux.org>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3990 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis patch adds ACPI support for Tyan s2891, s2892, and s2895. There is still
Myles Watson [Tue, 10 Mar 2009 20:56:54 +0000 (20:56 +0000)]
This patch adds ACPI support for Tyan s2891, s2892, and s2895.  There is still
a problem with IRQ 9, but besides that Linux is happy.  BSOD in Windows still.

changes by file:

src/mainboard/tyan/s289X/Options.lb:
Add options and defaults for ACPI tables and resources.

src/mainboard/tyan/s289X/mainboard.c:
Add high_tables resource ala Stefan's code for the Kontron.

src/mainboard/tyan/s289X/acpi_tables.c:
Fill out the ACPI tables, using existing code where possible.
Only the madt is different between the boards, to be combined later.

src/mainboard/tyan/s289X/Config.lb:
Compile in acpi_tables.c and dsdt.dsl.
Turn on the parallel port and the real-time-clock.

src/mainboard/tyan/s289x/dsdt.dsl:
The board layout (thanks Rudolf) and interrupts from mptable.c

src/mainboard/tyan/s289x/mptable.c:
Minor formatting changes to make them diff better.

src/superio/smsc/lpc47b397/superio.c:
Correct the size of the real-time-clock so it can be where it belongs.

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Rudolf Marek <r.marek@assembler.cz>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3989 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis patch adds common elements for ck804-based boards.
Myles Watson [Tue, 10 Mar 2009 20:39:27 +0000 (20:39 +0000)]
This patch adds common elements for ck804-based boards.

changes by file:
src/northbridge/amd/amdk8/northbridge.c:
Add high tables code ala Stefan's code for the i945.

src/southbridge/nvidia/ck804/ck804_lpc.c:
Enable High Precision Event Timers.
Add pm_base for ACPI.

src/southbridge/nvidia/ck804/ck804_fadt.c:
Since fadt is only dependent on the Southbridge, add it here.

src/southbridge/nvidia/ck804/Config.lb:
Compile in ck804_fadt.c

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3988 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis patch adds empty acpi_fill_slit functions so they build again.
Myles Watson [Tue, 10 Mar 2009 18:44:34 +0000 (18:44 +0000)]
This patch adds empty acpi_fill_slit functions so they build again.

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3987 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis patch makes the boards use a single amdk8_util.asl. There are only
Myles Watson [Tue, 10 Mar 2009 18:06:47 +0000 (18:06 +0000)]
This patch makes the boards use a single amdk8_util.asl.  There are only
whitespace differences between this file and the amdk8_util.asl from
asus/m2v_mxe.

It also enables SLIT filling if you have one, zeroes the unused fields in the
srat_lapic structure, and adds some declarations in acpi.h.

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Rudolf Marek <r.marek@assembler.cz>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3986 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoAdd some basic K8 MSRs.
Marc Jones [Sun, 8 Mar 2009 04:37:39 +0000 (04:37 +0000)]
Add some basic K8 MSRs.
Fix bash script type.
Removed const return type on msraddrbyname() to fix gcc warning/error.

Signed-off-by: Marc Jones <marcj303@gmail.com>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3985 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoFreeBSD definitions of (read|write)[bwl] collide with our own. Before we
Carl-Daniel Hailfinger [Fri, 6 Mar 2009 22:26:00 +0000 (22:26 +0000)]
FreeBSD definitions of (read|write)[bwl] collide with our own. Before we
attempt trickery, we can simply rename the accessor functions.

Patch created with the help of Coccinelle.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Idwer Vollering <idwer_v@hotmail.com>
Acked-by: Patrick Georgi <patrick@georgi-clan.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3984 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoSome updates for core/core duo/core2/core2 duo cpus.
Stefan Reinauer [Fri, 6 Mar 2009 19:54:15 +0000 (19:54 +0000)]
Some updates for core/core duo/core2/core2 duo cpus.

The microcode is from Intel's Linux microcode file, so it's unproblematic.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3983 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years ago* fix a minor power state issue in the ich7 smm handler
Stefan Reinauer [Fri, 6 Mar 2009 19:52:36 +0000 (19:52 +0000)]
* fix a minor power state issue in the ich7 smm handler
* move mainboard dependent code into a mainboard SMI handler.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3982 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoFix mmconf (PCIe memory mapped config space access) support in v2. It was
Stefan Reinauer [Fri, 6 Mar 2009 19:11:52 +0000 (19:11 +0000)]
Fix mmconf (PCIe memory mapped config space access) support in v2. It was
horribly broken and thus never used by any platform. This needs to get
straightened out so current chipsets drivers can use the full feature set.

Create wrapper functions similar to the io pci config space ones.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3981 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agouse include file for i8259 where appropriate (trivial)
Stefan Reinauer [Fri, 6 Mar 2009 18:39:54 +0000 (18:39 +0000)]
use include file for i8259 where appropriate (trivial)
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3980 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoclean up qemu target config (trivial)
Stefan Reinauer [Fri, 6 Mar 2009 18:38:28 +0000 (18:38 +0000)]
clean up qemu target config (trivial)

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3979 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agofix strstr. Seems the function never worked before, except the searched
Stefan Reinauer [Fri, 6 Mar 2009 17:43:20 +0000 (17:43 +0000)]
fix strstr. Seems the function never worked before, except the searched
substring is at the end.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3978 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agofix a bunch of cast and type warnings and don't call the apic "nvram", that
Stefan Reinauer [Fri, 6 Mar 2009 17:24:29 +0000 (17:24 +0000)]
fix a bunch of cast and type warnings and don't call the apic "nvram", that
doesn't make no sense. (trivial)

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3977 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agouse pointers instead of size_t when dealing with pointers. Also fix a few
Stefan Reinauer [Fri, 6 Mar 2009 17:22:35 +0000 (17:22 +0000)]
use pointers instead of size_t when dealing with pointers. Also fix a few
warnings (trivial)

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3976 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agouse inb instead of outb for delays in usb debug code (trivial)
Stefan Reinauer [Fri, 6 Mar 2009 17:21:23 +0000 (17:21 +0000)]
use inb instead of outb for delays in usb debug code (trivial)

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3975 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoreally clean out all compile time generated files (trivial)
Stefan Reinauer [Fri, 6 Mar 2009 17:20:17 +0000 (17:20 +0000)]
really clean out all compile time generated files (trivial)

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3974 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoDuring the conversion of flash chip accesses to helper functions, I
Carl-Daniel Hailfinger [Fri, 6 Mar 2009 00:40:25 +0000 (00:40 +0000)]
During the conversion of flash chip accesses to helper functions, I
spotted assignments to volatile variables which were neither placed
inside the mmapped ROM area nor were they counters.
Due to the use of accessor functions, volatile usage can be reduced
significantly because the accessor functions take care of actually
performing the reads/writes correctly.

The following semantic patch spotted them (linebreak in python string
for readability reasons, please remove before usage):
@r exists@
expression b;
typedef uint8_t;
volatile uint8_t a;
position p1;
@@
 a@p1 = readb(b);

@script:python@
p1 << r.p1;
a << r.a;
b << r.b;
@@
print "* file: %s line %s has assignment to unnecessarily volatile
variable: %s = readb(%s);" % (p1[0].file, p1[0].line, a, b)

Result was:
HANDLING: sst28sf040.c
* file: sst28sf040.c line 44 has assignment to unnecessarily volatile
variable: tmp = readb(TODO: Binary);
* file: sst28sf040.c line 43 has assignment to unnecessarily volatile
variable: tmp = readb(TODO: Binary);
* file: sst28sf040.c line 42 has assignment to unnecessarily volatile
variable: tmp = readb(TODO: Binary);
* file: sst28sf040.c line 41 has assignment to unnecessarily volatile
variable: tmp = readb(TODO: Binary);
* file: sst28sf040.c line 40 has assignment to unnecessarily volatile
variable: tmp = readb(TODO: Binary);
* file: sst28sf040.c line 39 has assignment to unnecessarily volatile
variable: tmp = readb(TODO: Binary);
* file: sst28sf040.c line 38 has assignment to unnecessarily volatile
variable: tmp = readb(TODO: Binary);
* file: sst28sf040.c line 58 has assignment to unnecessarily volatile
variable: tmp = readb(TODO: Binary);
* file: sst28sf040.c line 57 has assignment to unnecessarily volatile
variable: tmp = readb(TODO: Binary);
* file: sst28sf040.c line 56 has assignment to unnecessarily volatile
variable: tmp = readb(TODO: Binary);
* file: sst28sf040.c line 55 has assignment to unnecessarily volatile
variable: tmp = readb(TODO: Binary);
* file: sst28sf040.c line 54 has assignment to unnecessarily volatile
variable: tmp = readb(TODO: Binary);
* file: sst28sf040.c line 53 has assignment to unnecessarily volatile
variable: tmp = readb(TODO: Binary);
* file: sst28sf040.c line 52 has assignment to unnecessarily volatile
variable: tmp = readb(TODO: Binary);

The following semantic patch uses the spatch builtin match printing
functionality by prepending a "*" to the line with the pattern:
@@
expression b;
typedef uint8_t;
volatile uint8_t a;
@@
* a = readb(b);

Result is:
HANDLING: sst28sf040.c
diff =
--- sst28sf040.c        2009-03-06 01:04:49.000000000 +0100
@@ -35,13 +35,6 @@ static __inline__ void protect_28sf040(v
        /* ask compiler not to optimize this */
        volatile uint8_t tmp;

-       tmp = readb(bios + 0x1823);
-       tmp = readb(bios + 0x1820);
-       tmp = readb(bios + 0x1822);
-       tmp = readb(bios + 0x0418);
-       tmp = readb(bios + 0x041B);
-       tmp = readb(bios + 0x0419);
-       tmp = readb(bios + 0x040A);
 }

 static __inline__ void unprotect_28sf040(volatile uint8_t *bios)
@@ -49,13 +42,6 @@ static __inline__ void unprotect_28sf040
        /* ask compiler not to optimize this */
        volatile uint8_t tmp;

-       tmp = readb(bios + 0x1823);
-       tmp = readb(bios + 0x1820);
-       tmp = readb(bios + 0x1822);
-       tmp = readb(bios + 0x0418);
-       tmp = readb(bios + 0x041B);
-       tmp = readb(bios + 0x0419);
-       tmp = readb(bios + 0x041A);
 }

 static __inline__ int erase_sector_28sf040(volatile uint8_t *bios,

It's arguably a bit easier to read if you get used to the leading "-"
for matching lines.

This patch was enabled by Coccinelle:
http://www.emn.fr/x-info/coccinelle/

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Joseph Smith <joe@settoplinux.org>
--
http://www.hailfinger.org/

git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3973 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoIf get_pbus() is called for a device which has no parent/ancestor bus
Carl-Daniel Hailfinger [Thu, 5 Mar 2009 19:33:12 +0000 (19:33 +0000)]
If get_pbus() is called for a device which has no parent/ancestor bus
with nonzero PCI bus operations, get_pbus() will get stuck in a silent
endless loop.
Detect the endless loop and break out with an error message.

Such a situation can happen if the device tree is not yet
initialized/walked completely.

This fixes the unexplainable hang if pci_{read,write}_config{8,16,32}was
used in early mainboard code for the AMD DBM690T. Instead, the code will
now die() with a meaningful error message.

Thanks to Ward Vandewege for testing my patches to track down that bug.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Marc Jones <marcj303@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3972 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoflashrom: Use helper functions to access flash chips.
Carl-Daniel Hailfinger [Thu, 5 Mar 2009 19:24:22 +0000 (19:24 +0000)]
flashrom: Use helper functions to access flash chips.

Right now we perform direct pointer manipulation without any abstraction
to read from and write to memory mapped flash chips. That makes it
impossible to drive any flasher which does not mmap the whole chip.

Using helper functions readb() and writeb() allows a driver for external
flash programmers like Paraflasher to replace readb and writeb with
calls to its own chip access routines.

This patch has the additional advantage of removing lots of unnecessary
casts to volatile uint8_t * and now-superfluous parentheses which caused
poor readability.

I used the semantic patcher Coccinelle to create this patch. The
semantic patch follows:
@@
expression a;
typedef uint8_t;
volatile uint8_t *b;
@@
- *(b) = (a);
+ writeb(a, b);
@@
volatile uint8_t *b;
@@
- *(b)
+ readb(b)
@@
type T;
T b;
@@
(
 readb
|
 writeb
)
 (...,
- (T)
- (b)
+ b
 )

In contrast to a sed script, the semantic patch performs type checking
before converting anything.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: FENG Yu Ning <fengyuning1984@gmail.com>
Tested-by: Joe Julian
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3971 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoI just went on a bugfix frenzy and fixed all printk format warnings
Carl-Daniel Hailfinger [Wed, 4 Mar 2009 01:06:41 +0000 (01:06 +0000)]
I just went on a bugfix frenzy and fixed all printk format warnings
triggered by the AMD 690/SB600 targets.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3970 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agofix make clean as suggested by Myles Watson.
Stefan Reinauer [Wed, 4 Mar 2009 00:25:44 +0000 (00:25 +0000)]
fix make clean as suggested by Myles Watson.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3969 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoSmall bug somehow slipped there. The method body length is incorrectly computed.
Rudolf Marek [Mon, 2 Mar 2009 22:45:31 +0000 (22:45 +0000)]
Small bug somehow slipped there. The method body length is incorrectly computed.
The attached patch fixes this. I did not spotted that because the return arg is
moved just outside of method and I have overseen the closing }

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3968 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years ago(Trivial) Add missing header file.
Rudolf Marek [Sun, 1 Mar 2009 18:05:25 +0000 (18:05 +0000)]
(Trivial) Add missing header file.

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Rudolf Marek <r.marek@assembler.cz>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3967 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoSome changes required to get yabel working on v2 (and they generally make
Stefan Reinauer [Sun, 1 Mar 2009 10:16:01 +0000 (10:16 +0000)]
Some changes required to get yabel working on v2 (and they generally make
sense, too). Have one u64 instead of three.

In order to use the old bios emulator, you have to do nothing. (Default, if
CONFIG_PCI_ROM_RUN is enabled)

In order to use yabel in your target, you need to add the following lines to
your config:
  uses CONFIG_PCI_OPTION_ROM_RUN_YABEL
  default CONFIG_PCI_OPTION_ROM_RUN_YABEL=1

In order to use vm86 in your target, you need to add the following lines to
your config:
  uses CONFIG_PCI_OPTION_ROM_RUN_VM86
  default CONFIG_PCI_OPTION_ROM_RUN_VM86=1
Note: vm86 only works on platforms with _RAMBASE in the lower megabyte.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Joseph Smith <joe@settoplinux.org>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3965 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agocoreboot-v2: drop this ugly historic union name in v2 that was dropped in v3
Stefan Reinauer [Sat, 28 Feb 2009 20:10:20 +0000 (20:10 +0000)]
coreboot-v2: drop this ugly historic union name in v2 that was dropped in v3
a long time ago. This will make it easier to port v2 boards forward to v3 at
some point (and other things)

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3964 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agofix those two boards that broke due to the config tool fixes.
Stefan Reinauer [Sat, 28 Feb 2009 17:19:55 +0000 (17:19 +0000)]
fix those two boards that broke due to the config tool fixes.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3963 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis is a small fix for the last checkin (does not fix those two boards) that
Stefan Reinauer [Sat, 28 Feb 2009 17:09:29 +0000 (17:09 +0000)]
This is a small fix for the last checkin (does not fix those two boards) that
caused same filenames to still cause objects being dropped from the build list
- which was the whole purpose of the patch.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3962 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoWith this patch the v2 build system will create a directory hierarchy
Stefan Reinauer [Sat, 28 Feb 2009 12:50:32 +0000 (12:50 +0000)]
With this patch the v2 build system will create a directory hierarchy
similar to what v3 does. This is required to have two source files with
the same name but in different directories. (As in, two different SuperIOs on
board, with a superio.c each)

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3961 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoGeneric approach of putting BIOS tables at the end of memory
Stefan Reinauer [Fri, 27 Feb 2009 23:09:55 +0000 (23:09 +0000)]
Generic approach of putting BIOS tables at the end of memory
(in addition to their low locations)

This adds the kontron 986LCD-M and the i945 as a sample.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3960 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis patch makes several CMOS/NVRAM reads dependent on whether there's a table to...
Myles Watson [Fri, 27 Feb 2009 17:51:16 +0000 (17:51 +0000)]
This patch makes several CMOS/NVRAM reads dependent on whether there's a table to read.  Otherwise you never know what you'll get from the factory BIOS.  There are probably more, but these are the ones compiled into the s2895.

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3959 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoflashrom: Add SST25VF040.REMS with TEST_OK_ PROBE READ
Zheng Bao [Wed, 25 Feb 2009 08:07:33 +0000 (08:07 +0000)]
flashrom: Add SST25VF040.REMS with TEST_OK_ PROBE READ

Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3958 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agolibpayload: Fix build when both USB and PS/2 keyboard support is disabled
Mart Raudsepp [Sun, 22 Feb 2009 23:13:33 +0000 (23:13 +0000)]
libpayload: Fix build when both USB and PS/2 keyboard support is disabled

libpayload uses -Werror for some reason right now, and the
variable 'c' in curses_getchar is only used if CONFIG_USB_HID
or CONFIG_PC_KEYBOARD is defined, giving an unused variable
warning that gets promoted to an error.
So wrap the variable declaration around appropriate #ifdef's

Signed-off-by: Mart Raudsepp <leio@gentoo.org>
Acked-by: Ulf Jordan <jordan@chalmers.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3957 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoflashrom: SST29EE020A TEST_OK_ PROBE READ ERASE WRITE
Peter Stuge [Sun, 22 Feb 2009 21:07:28 +0000 (21:07 +0000)]
flashrom: SST29EE020A TEST_OK_ PROBE READ ERASE WRITE

Report by Holger Mickler. Thanks!

Signed-off-by: Peter Stuge <peter@stuge.se>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3956 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis patch is for AMD boards which can do the P state generation. This just
Rudolf Marek [Thu, 19 Feb 2009 08:39:16 +0000 (08:39 +0000)]
This patch is for AMD boards which can do the P state generation. This just
removes the ugly binary DSDT patching and all other related stuff. Stick to
infrastructure in previous patch.

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3955 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoCarl-Daniel's part:
Carl-Daniel Hailfinger [Wed, 18 Feb 2009 20:41:57 +0000 (20:41 +0000)]
Carl-Daniel's part:

This patch converts mainboard_$VENDOR_$BOARD_ops to mainboard_ops and
mainboard_$VENDOR_$BOARD_config to mainboard_config.

Ron's part:
The config change that makes the naming change not break every build.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3954 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoAdd QWord support to acpigen.
Carl-Daniel Hailfinger [Tue, 17 Feb 2009 21:38:51 +0000 (21:38 +0000)]
Add QWord support to acpigen.

Add TOM2 to the K8 DSDT.

Thanks to Rudolf Marek for testing and fixing this patch.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3953 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoBayou: Clean up Bayou's window after returning from a payload.
Ulf Jordan [Tue, 17 Feb 2009 16:23:26 +0000 (16:23 +0000)]
Bayou: Clean up Bayou's window after returning from a payload.

Signed-off-by: Ulf Jordan <jordan@chalmers.se>
Acked-by: Jordan Crouse <jordan@cosmicpenguin.net>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3952 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoUnify CAR so the same compiled code does the right thing on both
Patrick Georgi [Tue, 17 Feb 2009 12:56:58 +0000 (12:56 +0000)]
Unify CAR so the same compiled code does the right thing on both
K8 and Fam10+ CPUs.

What this patch does:
1. Enable SSE (to get some more registers to play with)
2. Determine CPUID, and stash it in an XMM register, and reference
   value for comparison in another XMM register (mangled somewhat to
   simplify inequality comparisons)
3. Add a macro jmp_if_k8, which jumps if the CPU is K8
   (using an SSE compare)
4. Replace #if CAR_FAM10 sections with runtime checks using jmp_if_k8.
   This is pretty mechanical work. The macro uses local labels
   (1: and 2:) to prevent namespace issues
5. At one time, CPU_ADDR_BITS is used to fill a register. This is
   replaced with hardcoded values for both cases, and switched
   appropriately.
6. Disable SSE

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3951 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoThis is a safety measure, since the shipping buildrom fails badly at present.
Ronald G. Minnich [Sun, 15 Feb 2009 23:32:57 +0000 (23:32 +0000)]
This is a safety measure, since the shipping buildrom fails badly at present.

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3950 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years ago- Fix up amd pistachio and dbm690t.
Stefan Reinauer [Sun, 15 Feb 2009 02:53:18 +0000 (02:53 +0000)]
- Fix up amd pistachio and dbm690t.
- make uma_memory_base and uma_memory_size uint64_t as they may be 64bit BARs
  on some platforms.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3949 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoChange Log:
Rudolf Marek [Sat, 14 Feb 2009 16:23:16 +0000 (16:23 +0000)]
Change Log:
Bellongs to r3947

Following patch adds dynamically generated P-States infrastructure as well as
M2V-MX SE as example how to do that. It is based on AMD code and mine code for
ACPI generation.

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3948 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoBellongs to r3946
Rudolf Marek [Sat, 14 Feb 2009 15:42:42 +0000 (15:42 +0000)]
Bellongs to r3946

Following patch adds dynamically generated P-States infrastructure as well as
M2V-MX SE as example how to do that. It is based on AMD code and mine code for
ACPI generation.

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3947 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

15 years agoFollowing patch adds dynamically generated P-States infrastructure as well as
Rudolf Marek [Sat, 14 Feb 2009 15:40:23 +0000 (15:40 +0000)]
Following patch adds dynamically generated P-States infrastructure as well as
M2V-MX SE as example how to do that. It is based on AMD code and mine code for
ACPI generation.

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3946 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1