Merge pull request #4453 from lambdageek/bug-49721
authorAleksey Kliger (λgeek) <akliger@gmail.com>
Thu, 16 Mar 2017 23:09:00 +0000 (19:09 -0400)
committerGitHub <noreply@github.com>
Thu, 16 Mar 2017 23:09:00 +0000 (19:09 -0400)
[loader] Check strong name when loading from application base. (Fixes #49721)

479 files changed:
Makefile.am
configure.ac
external/ikdasm
mcs/build/Makefile
mcs/build/common/Consts.cs.in
mcs/class/.gitignore
mcs/class/Makefile
mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/BuildPropertyGroup.cs
mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/ConsoleLogger.cs
mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/Project.cs
mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/Target.cs
mcs/class/Microsoft.Build/Microsoft.Build.Construction/ElementLocation.cs
mcs/class/Microsoft.Build/Microsoft.Build.Evaluation/Project.cs
mcs/class/Microsoft.Build/Microsoft.Build.Evaluation/ProjectCollection.cs
mcs/class/Mono.Simd/Mono.Simd/Vector16b.cs
mcs/class/Mono.Simd/Mono.Simd/Vector16sb.cs
mcs/class/Mono.Simd/Mono.Simd/Vector2d.cs
mcs/class/Mono.Simd/Mono.Simd/Vector2l.cs
mcs/class/Mono.Simd/Mono.Simd/Vector2ul.cs
mcs/class/Mono.Simd/Mono.Simd/Vector4f.cs
mcs/class/Mono.Simd/Mono.Simd/Vector4i.cs
mcs/class/Mono.Simd/Mono.Simd/Vector4ui.cs
mcs/class/Mono.Simd/Mono.Simd/Vector8s.cs
mcs/class/Mono.Simd/Mono.Simd/Vector8us.cs
mcs/class/Novell.Directory.Ldap/Novell.Directory.Ldap.dll.sources
mcs/class/System.Configuration/System.Configuration.Internal/DelegatingConfigHost.cs
mcs/class/System.Configuration/System.Configuration.Internal/IInternalConfigHost.cs
mcs/class/System.Configuration/System.Configuration/AppSettingsSection.cs
mcs/class/System.Configuration/System.Configuration/Configuration.cs
mcs/class/System.Configuration/System.Configuration/ConfigurationElement.cs
mcs/class/System.Configuration/System.Configuration/ConfigurationElementCollection.cs
mcs/class/System.Configuration/System.Configuration/ConfigurationProperty.cs
mcs/class/System.Configuration/System.Configuration/ConfigurationSectionGroup.cs
mcs/class/System.Configuration/System.Configuration/ConnectionStringSettingsCollection.cs
mcs/class/System.Configuration/System.Configuration/DpapiProtectedConfigurationProvider.cs
mcs/class/System.Configuration/System.Configuration/IgnoreSection.cs
mcs/class/System.Configuration/System.Configuration/ProtectedConfigurationProvider.cs
mcs/class/System.Configuration/System.Configuration/ProviderSettings.cs
mcs/class/System.Configuration/System.Configuration/ProviderSettingsCollection.cs
mcs/class/System.Configuration/System.Configuration/RsaProtectedConfigurationProvider.cs
mcs/class/System.Configuration/System.Configuration/SectionInformation.cs
mcs/class/System.Configuration/System.Configuration/ValidatorCallback.cs
mcs/class/System.Core/System.Security.Cryptography/AesCryptoServiceProvider.cs
mcs/class/System.Data.Linq/src/DbLinq/Data/Linq/DataContext.cs
mcs/class/System.Data.OracleClient/System.Data.OracleClient/OracleCommandBuilder.cs
mcs/class/System.Data/System.Data.SqlClient/SqlConnection.cs
mcs/class/System.Data/System.Data.SqlClient/SqlCredential.cs
mcs/class/System.Data/mobile_System.Data.dll.sources
mcs/class/System.Design/System.ComponentModel.Design.Serialization/CodeDomSerializer.cs
mcs/class/System.Design/System.ComponentModel.Design.Serialization/CodeDomSerializerBase.cs
mcs/class/System.Design/System.ComponentModel.Design.Serialization/DesignerSerializationManager.cs
mcs/class/System.Design/System.ComponentModel.Design.Serialization/ObjectStatementCollection.cs
mcs/class/System.Design/System.ComponentModel.Design.Serialization/RootContext.cs
mcs/class/System.Design/System.ComponentModel.Design/ComponentDesigner.cs
mcs/class/System.Design/System.ComponentModel.Design/DesignSurfaceManager.cs
mcs/class/System.Design/System.ComponentModel.Design/EventBindingService.cs
mcs/class/System.Design/System.ComponentModel.Design/MenuCommandService.cs
mcs/class/System.Design/System.Data.Design/TypedDataSetGeneratorException.cs
mcs/class/System.Design/System.Web.UI.Design.WebControls/BaseDataListComponentEditor.cs
mcs/class/System.Design/System.Web.UI.Design.WebControls/BaseDataListDesigner.cs
mcs/class/System.Design/System.Web.UI.Design.WebControls/DataListComponentEditor.cs
mcs/class/System.Design/System.Web.UI.Design.WebControls/ListControlDataBindingHandler.cs
mcs/class/System.Design/System.Web.UI.Design.WebControls/PanelDesigner.cs
mcs/class/System.Design/System.Web.UI.Design.WebControls/RepeaterDesigner.cs
mcs/class/System.Design/System.Web.UI.Design.WebControls/TableCellsCollectionEditor.cs
mcs/class/System.Design/System.Web.UI.Design.WebControls/TableRowsCollectionEditor.cs
mcs/class/System.Design/System.Windows.Forms.Design/ComponentTray.cs
mcs/class/System.Design/System.Windows.Forms.Design/ControlDesigner.cs
mcs/class/System.Design/System.Windows.Forms.Design/DocumentDesigner.cs
mcs/class/System.Design/System.Windows.Forms.Design/ParentControlDesigner.cs
mcs/class/System.Design/System.Windows.Forms.Design/ScrollableControlDesigner.cs
mcs/class/System.DirectoryServices/System.DirectoryServices.dll.sources
mcs/class/System.DirectoryServices/System.DirectoryServices/DirectoryEntries.cs
mcs/class/System.DirectoryServices/System.DirectoryServices/DirectoryServicesPermission.cs
mcs/class/System.DirectoryServices/System.DirectoryServices/DirectoryServicesPermissionEntryCollection.cs
mcs/class/System.DirectoryServices/System.DirectoryServices/PropertyValueCollection.cs
mcs/class/System.DirectoryServices/System.DirectoryServices/ResultPropertyCollection.cs
mcs/class/System.DirectoryServices/System.DirectoryServices/ResultPropertyValueCollection.cs
mcs/class/System.DirectoryServices/System.DirectoryServices/SchemaNameCollection.cs
mcs/class/System.Drawing/System.Drawing.Drawing2D/GraphicsPath.cs
mcs/class/System.Drawing/System.Drawing.Drawing2D/HatchBrush.cs
mcs/class/System.Drawing/System.Drawing.Imaging/ColorMatrix.cs
mcs/class/System.Drawing/System.Drawing.Imaging/EncoderParameter.cs
mcs/class/System.Drawing/System.Drawing.Imaging/ImageAttributes.cs
mcs/class/System.Drawing/System.Drawing.Imaging/Metafile.cs
mcs/class/System.Drawing/System.Drawing/Graphics.cs
mcs/class/System.Drawing/System.Drawing/gdipFunctions.cs
mcs/class/System.Drawing/Test/System.Drawing/TestBitmap.cs
mcs/class/System.EnterpriseServices/System.EnterpriseServices/ContextUtil.cs
mcs/class/System.EnterpriseServices/System.EnterpriseServices/RegistrationException.cs
mcs/class/System.IdentityModel.Selectors/System.IdentityModel.Selectors/CardSpacePolicyElement.cs
mcs/class/System.IdentityModel.Selectors/System.IdentityModel.Selectors/CardSpaceSelector.cs
mcs/class/System.IdentityModel/System.IdentityModel.Claims/Claim.cs
mcs/class/System.IdentityModel/System.IdentityModel.Claims/ClaimSet.cs
mcs/class/System.IdentityModel/System.IdentityModel.Claims/WindowsClaimSet.cs
mcs/class/System.IdentityModel/System.IdentityModel.Policy/AuthorizationContext.cs
mcs/class/System.IdentityModel/System.IdentityModel.Policy/EvaluationContext.cs
mcs/class/System.IdentityModel/System.IdentityModel.Selectors/KerberosSecurityTokenProvider.cs
mcs/class/System.IdentityModel/System.IdentityModel.Selectors/SecurityTokenManager.cs
mcs/class/System.IdentityModel/System.IdentityModel.Selectors/SecurityTokenProvider.cs
mcs/class/System.IdentityModel/System.IdentityModel.Selectors/SecurityTokenRequirement.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/BinaryKeyIdentifierClause.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/BootstrapContext.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/EncryptedKeyIdentifierClause.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/GenericXmlSecurityToken.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/InMemorySymmetricSecurityKey.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/KerberosReceiverSecurityToken.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/KerberosRequestorSecurityToken.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/LocalIdKeyIdentifierClause.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/RsaKeyIdentifierClause.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/RsaSecurityKey.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/RsaSecurityToken.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SamlAction.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SamlAdvice.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SamlAssertion.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SamlAssertionKeyIdentifierClause.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SamlAttribute.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SamlAttributeStatement.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SamlAuthenticationStatement.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SamlAuthorityBinding.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SamlAuthorizationDecisionClaimResource.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SamlAuthorizationDecisionStatement.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SamlConditions.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SamlEvidence.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SamlSecurityToken.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SamlSerializer.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SamlStatement.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SamlSubject.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SecurityKeyIdentifier.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SecurityKeyIdentifierClause.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SecurityToken.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SecurityTokenException.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SecurityTokenExpiredException.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SecurityTokenNotYetValidException.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SecurityTokenReplayDetectedException.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/SecurityTokenValidationException.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/WindowsSecurityToken.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/X509IssuerSerialKeyIdentifierClause.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/X509SecurityToken.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/X509SubjectKeyIdentifierClause.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/X509ThumbprintKeyIdentifierClause.cs
mcs/class/System.IdentityModel/System.IdentityModel.Tokens/X509WindowsSecurityToken.cs
mcs/class/System.IdentityModel/System.IdentityModel/SignatureVerificationFailedException.cs
mcs/class/System.Management/System.Management/MethodDataCollection.cs
mcs/class/System.Security/System.Security.Cryptography.Pkcs/SignedCms.cs
mcs/class/System.Security/System.Security.Cryptography.Xml/CipherReference.cs
mcs/class/System.Security/System.Security.Cryptography.Xml/DataReference.cs
mcs/class/System.Security/System.Security.Cryptography.Xml/EncryptedReference.cs
mcs/class/System.Security/System.Security.Cryptography.Xml/EncryptedXml.cs
mcs/class/System.Security/System.Security.Cryptography.Xml/EncryptionMethod.cs
mcs/class/System.Security/System.Security.Cryptography.Xml/EncryptionProperty.cs
mcs/class/System.Security/System.Security.Cryptography.Xml/KeyInfoEncryptedKey.cs
mcs/class/System.Security/System.Security.Cryptography.Xml/KeyInfoRetrievalMethod.cs
mcs/class/System.Security/System.Security.Cryptography.Xml/KeyReference.cs
mcs/class/System.Security/System.Security.Permissions/DataProtectionPermission.cs
mcs/class/System.ServiceModel.Discovery/System.ServiceModel.Discovery.Configuration/DiscoveryEndpointElement.cs
mcs/class/System.ServiceModel.Discovery/System.ServiceModel.Discovery.Configuration/UdpAnnouncementEndpointElement.cs
mcs/class/System.ServiceModel.Discovery/System.ServiceModel.Discovery.Configuration/UdpDiscoveryEndpointElement.cs
mcs/class/System.ServiceModel.Web/System.ServiceModel.Syndication/Atom10ItemFormatter.cs
mcs/class/System.ServiceModel.Web/System.ServiceModel.Syndication/SyndicationContent.cs
mcs/class/System.ServiceModel.Web/System.ServiceModel.Syndication/SyndicationItem.cs
mcs/class/System.ServiceModel.Web/System.ServiceModel.Syndication/XmlSyndicationContent.cs
mcs/class/System.ServiceModel.Web/System.ServiceModel.Web/WebChannelFactory.cs
mcs/class/System.ServiceModel.Web/System.ServiceModel.Web/WebOperationContext.cs
mcs/class/System.ServiceModel.Web/System.ServiceModel/WebHttpBinding.cs
mcs/class/System.ServiceModel.Web/System/UriTemplateMatchException.cs
mcs/class/System.ServiceModel/System.Collections.Generic/KeyedByTypeCollection.cs
mcs/class/System.ServiceModel/System.Collections.Generic/SynchronizedKeyedCollection.cs
mcs/class/System.ServiceModel/System.Collections.Generic/SynchronizedReadOnlyCollection.cs
mcs/class/System.ServiceModel/System.ServiceModel.Channels/Binding.cs
mcs/class/System.ServiceModel/System.ServiceModel.Channels/ChannelListenerBase_1.cs
mcs/class/System.ServiceModel/System.ServiceModel.Channels/CustomBinding.cs
mcs/class/System.ServiceModel/System.ServiceModel.Channels/Message.cs
mcs/class/System.ServiceModel/System.ServiceModel.Channels/MessageBuffer.cs
mcs/class/System.ServiceModel/System.ServiceModel.Channels/MessageFault.cs
mcs/class/System.ServiceModel/System.ServiceModel.Channels/MessageHeaders.cs
mcs/class/System.ServiceModel/System.ServiceModel.Channels/MtomMessageEncodingBindingElement.cs
mcs/class/System.ServiceModel/System.ServiceModel.Channels/NamedPipetransportBindingElement.cs
mcs/class/System.ServiceModel/System.ServiceModel.Channels/StreamUpgradeBindingElement.cs
mcs/class/System.ServiceModel/System.ServiceModel.Channels/TransactionFlowBindingElement.cs
mcs/class/System.ServiceModel/System.ServiceModel.Channels/UnderstoodHeaders.cs
mcs/class/System.ServiceModel/System.ServiceModel.Configuration/BinaryMessageEncodingElement.cs
mcs/class/System.ServiceModel/System.ServiceModel.Configuration/BindingsSection.cs
mcs/class/System.ServiceModel/System.ServiceModel.Configuration/ClientCredentialsElement.cs
mcs/class/System.ServiceModel/System.ServiceModel.Configuration/ReliableSessionElement.cs
mcs/class/System.ServiceModel/System.ServiceModel.Configuration/ServiceCredentialsElement.cs
mcs/class/System.ServiceModel/System.ServiceModel.Configuration/ServiceModelConfigurationElementCollection.cs
mcs/class/System.ServiceModel/System.ServiceModel.Configuration/StandardBindingOptionalReliableSessionElement.cs
mcs/class/System.ServiceModel/System.ServiceModel.Configuration/StandardBindingReliableSessionElement.cs
mcs/class/System.ServiceModel/System.ServiceModel.Configuration/StandardEndpointElement.cs
mcs/class/System.ServiceModel/System.ServiceModel.Configuration/StandardEndpointsSection.cs
mcs/class/System.ServiceModel/System.ServiceModel.Configuration/TextMessageEncodingElement.cs
mcs/class/System.ServiceModel/System.ServiceModel.Description/FaultDescriptionCollection.cs
mcs/class/System.ServiceModel/System.ServiceModel.Description/IServiceBehavior.cs
mcs/class/System.ServiceModel/System.ServiceModel.Description/IWsdlImporter.cs
mcs/class/System.ServiceModel/System.ServiceModel.Description/MetadataConversionError.cs
mcs/class/System.ServiceModel/System.ServiceModel.Description/OperationContractGenerationContext.cs
mcs/class/System.ServiceModel/System.ServiceModel.Description/PolicyAssertionCollection.cs
mcs/class/System.ServiceModel/System.ServiceModel.Description/ServiceContractGenerator.cs
mcs/class/System.ServiceModel/System.ServiceModel.Description/ServiceDescription.cs
mcs/class/System.ServiceModel/System.ServiceModel.Description/ServiceEndpointCollection.cs
mcs/class/System.ServiceModel/System.ServiceModel.Description/TypedMessageConverter.cs
mcs/class/System.ServiceModel/System.ServiceModel.Description/WsdlEndpointConversionContext.cs
mcs/class/System.ServiceModel/System.ServiceModel.Description/WsdlExporter.cs
mcs/class/System.ServiceModel/System.ServiceModel.Description/WsdlImporter.cs
mcs/class/System.ServiceModel/System.ServiceModel.Description/XmlSerializerOperationBehavior.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/ActionMessageFilter.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/ExceptionHandler.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/FilterInvalidBodyAccessException.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/IDispatchMessageFormatter.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/IDispatchMessageInspector.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/IDispatchOperationSelector.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/IErrorHandler.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/IInstanceContextInitializer.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/IInstanceProvider.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/IMessageFilterTable.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/InstanceContextIdleCallback.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/InvalidBodyAccessException.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/MatchAllMessageFilter.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/MatchNoneMessageFilter.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/MessageFilterNodeQuotaExceededException.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/MessageFilterTable.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/MultipleMessageFilterMatchesException.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/NavigatorInvalidBodyAccessException.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/SeekableXPathNavigator.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/XPathMessageContext.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/XPathMessageFilter.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/XPathMessageFilterTable.cs
mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/XPathNavigatorException.cs
mcs/class/System.ServiceModel/System.ServiceModel.PeerResolvers/UnregisterInfo.cs
mcs/class/System.ServiceModel/System.ServiceModel.Security.Tokens/IssuedSecurityTokenParameters.cs
mcs/class/System.ServiceModel/System.ServiceModel.Security.Tokens/KerberosSecurityTokenParameters.cs
mcs/class/System.ServiceModel/System.ServiceModel.Security.Tokens/RsaSecurityTokenParameters.cs
mcs/class/System.ServiceModel/System.ServiceModel.Security.Tokens/SecureConversationSecurityTokenParameters.cs
mcs/class/System.ServiceModel/System.ServiceModel.Security.Tokens/SecurityContextSecurityToken.cs
mcs/class/System.ServiceModel/System.ServiceModel.Security.Tokens/SslSecurityTokenParameters.cs
mcs/class/System.ServiceModel/System.ServiceModel.Security.Tokens/SspiSecurityToken.cs
mcs/class/System.ServiceModel/System.ServiceModel.Security.Tokens/SspiSecurityTokenParameters.cs
mcs/class/System.ServiceModel/System.ServiceModel.Security.Tokens/UserNameSecurityTokenParameters.cs
mcs/class/System.ServiceModel/System.ServiceModel.Security.Tokens/X509SecurityTokenParameters.cs
mcs/class/System.ServiceModel/System.ServiceModel.Security/MessagePartSpecification.cs
mcs/class/System.ServiceModel/System.ServiceModel.Security/ServiceCredentialsSecurityTokenManager.cs
mcs/class/System.ServiceModel/System.ServiceModel.Security/WSSecurityTokenSerializer.cs
mcs/class/System.ServiceModel/System.ServiceModel/AddressAccessDeniedException.cs
mcs/class/System.ServiceModel/System.ServiceModel/AddressAlreadyInUseException.cs
mcs/class/System.ServiceModel/System.ServiceModel/ChannelFactory.cs
mcs/class/System.ServiceModel/System.ServiceModel/ChannelFactory_1.cs
mcs/class/System.ServiceModel/System.ServiceModel/ChannelTerminatedException.cs
mcs/class/System.ServiceModel/System.ServiceModel/ClientBase.cs
mcs/class/System.ServiceModel/System.ServiceModel/ClientCredentialsSecurityTokenManager.cs
mcs/class/System.ServiceModel/System.ServiceModel/DuplexChannelFactory.cs
mcs/class/System.ServiceModel/System.ServiceModel/DuplexClientBase.cs
mcs/class/System.ServiceModel/System.ServiceModel/EndpointAddress.cs
mcs/class/System.ServiceModel/System.ServiceModel/EndpointIdentity.cs
mcs/class/System.ServiceModel/System.ServiceModel/FaultException.cs
mcs/class/System.ServiceModel/System.ServiceModel/MsmqException.cs
mcs/class/System.ServiceModel/System.ServiceModel/MsmqPoisonMessageException.cs
mcs/class/System.ServiceModel/System.ServiceModel/OptionalReliableSession.cs
mcs/class/System.ServiceModel/System.ServiceModel/PoisonMessageException.cs
mcs/class/System.ServiceModel/System.ServiceModel/ReliableSession.cs
mcs/class/System.ServiceModel/System.ServiceModel/RsaEndpointIdentity.cs
mcs/class/System.ServiceModel/System.ServiceModel/ServiceAuthorizationManager.cs
mcs/class/System.ServiceModel/System.ServiceModel/ServiceHost.cs
mcs/class/System.ServiceModel/System.ServiceModel/ServiceHostBase.cs
mcs/class/System.ServiceModel/System.ServiceModel/UriSchemeKeyedCollection.cs
mcs/class/System.ServiceModel/System.ServiceModel/WS2007FederationHttpBinding.cs
mcs/class/System.ServiceModel/System.ServiceModel/WS2007HttpBinding.cs
mcs/class/System.ServiceModel/System.ServiceModel/WSFederationHttpBinding.cs
mcs/class/System.ServiceModel/System.ServiceModel/WSHttpBinding.cs
mcs/class/System.ServiceModel/System.ServiceModel/X509CertificateEndpointIdentity.cs
mcs/class/System.Transactions/System.Transactions/CommittableTransaction.cs
mcs/class/System.Transactions/System.Transactions/IDtcTransaction.cs
mcs/class/System.Transactions/System.Transactions/IPromotableSinglePhaseNotification.cs
mcs/class/System.Transactions/System.Transactions/ISinglePhaseNotification.cs
mcs/class/System.Transactions/System.Transactions/PreparingEnlistment.cs
mcs/class/System.Transactions/System.Transactions/SubordinateTransaction.cs
mcs/class/System.Transactions/System.Transactions/Transaction.cs
mcs/class/System.Transactions/System.Transactions/TransactionInterop.cs
mcs/class/System.Transactions/System.Transactions/TransactionManager.cs
mcs/class/System.Transactions/System.Transactions/TransactionOptions.cs
mcs/class/System.Transactions/System.Transactions/TransactionScope.cs
mcs/class/System.Transactions/Test/TransactionScopeTest.cs
mcs/class/System.Web.ApplicationServices/System.Web.Security/MembershipProvider.cs
mcs/class/System.Web.ApplicationServices/System.Web.Security/MembershipUser.cs
mcs/class/System.Web.ApplicationServices/System.Web.Security/RoleProvider.cs
mcs/class/System.Web.Extensions/System.Web.Handlers/ScriptModule.cs
mcs/class/System.Web.Extensions/System.Web.UI/ScriptResourceAttribute.cs
mcs/class/System.Web/System.Web.Configuration_2.0/AssemblyCollection.cs
mcs/class/System.Web/System.Web.Configuration_2.0/BufferModesCollection.cs
mcs/class/System.Web/System.Web.Configuration_2.0/EventMappingSettingsCollection.cs
mcs/class/System.Web/System.Web.Configuration_2.0/HttpModuleActionCollection.cs
mcs/class/System.Web/System.Web.Configuration_2.0/ProfileSettingsCollection.cs
mcs/class/System.Web/System.Web.Configuration_2.0/RootProfilePropertySettingsCollection.cs
mcs/class/System.Web/System.Web.Configuration_2.0/RuleSettingsCollection.cs
mcs/class/System.Web/System.Web.Configuration_2.0/TagMapInfo.cs
mcs/class/System.Web/System.Web.Configuration_2.0/TrustLevelCollection.cs
mcs/class/System.Web/System.Web.Hosting/IAppManagerAppDomainFactory.cs
mcs/class/System.Web/System.Web.Management/IWebEventCustomEvaluator.cs
mcs/class/System.Web/System.Web.Management/WebBaseEvent.cs
mcs/class/System.Web/System.Web.Security/ActiveDirectoryMembershipProvider.cs
mcs/class/System.Web/System.Web.Security/Membership.cs
mcs/class/System.Web/System.Web.Security/Roles.cs
mcs/class/System.Web/System.Web.Security/SqlMembershipProvider.cs
mcs/class/System.Web/System.Web.Security/SqlRoleProvider.cs
mcs/class/System.Web/System.Web.SessionState_2.0/HttpSessionState.cs
mcs/class/System.Web/System.Web.SessionState_2.0/IHttpSessionState.cs
mcs/class/System.Web/System.Web.SessionState_2.0/ISessionIDManager.cs
mcs/class/System.Web/System.Web.SessionState_2.0/ISessionStateItemCollection.cs
mcs/class/System.Web/System.Web.SessionState_2.0/SessionStateStoreData.cs
mcs/class/System.Web/System.Web.UI.Adapters/ControlAdapter.cs
mcs/class/System.Web/System.Web.UI.Adapters/PageAdapter.cs
mcs/class/System.Web/System.Web.UI.HtmlControls/HtmlForm.cs
mcs/class/System.Web/System.Web.UI.HtmlControls/HtmlImage.cs
mcs/class/System.Web/System.Web.UI.HtmlControls/HtmlSelect.cs
mcs/class/System.Web/System.Web.UI.WebControls.WebParts/ConnectionInterfaceCollection.cs
mcs/class/System.Web/System.Web.UI.WebControls.WebParts/ConsumerConnectionPoint.cs
mcs/class/System.Web/System.Web.UI.WebControls.WebParts/ProviderConnectionPoint.cs
mcs/class/System.Web/System.Web.UI.WebControls.WebParts/WebPartVerb.cs
mcs/class/System.Web/System.Web.UI.WebControls/AdRotator.cs
mcs/class/System.Web/System.Web.UI.WebControls/BaseCompareValidator.cs
mcs/class/System.Web/System.Web.UI.WebControls/BaseValidator.cs
mcs/class/System.Web/System.Web.UI.WebControls/BoundField.cs
mcs/class/System.Web/System.Web.UI.WebControls/ButtonField.cs
mcs/class/System.Web/System.Web.UI.WebControls/Calendar.cs
mcs/class/System.Web/System.Web.UI.WebControls/CheckBox.cs
mcs/class/System.Web/System.Web.UI.WebControls/CompareValidator.cs
mcs/class/System.Web/System.Web.UI.WebControls/CompositeControl.cs
mcs/class/System.Web/System.Web.UI.WebControls/ControlParameter.cs
mcs/class/System.Web/System.Web.UI.WebControls/CookieParameter.cs
mcs/class/System.Web/System.Web.UI.WebControls/DataControlFieldCell.cs
mcs/class/System.Web/System.Web.UI.WebControls/DataControlFieldCollection.cs
mcs/class/System.Web/System.Web.UI.WebControls/DataControlFieldHeaderCell.cs
mcs/class/System.Web/System.Web.UI.WebControls/DataGridItem.cs
mcs/class/System.Web/System.Web.UI.WebControls/DataKey.cs
mcs/class/System.Web/System.Web.UI.WebControls/DetailsView.cs
mcs/class/System.Web/System.Web.UI.WebControls/DetailsViewDeleteEventArgs.cs
mcs/class/System.Web/System.Web.UI.WebControls/DetailsViewInsertEventArgs.cs
mcs/class/System.Web/System.Web.UI.WebControls/DetailsViewRowCollection.cs
mcs/class/System.Web/System.Web.UI.WebControls/DetailsViewUpdateEventArgs.cs
mcs/class/System.Web/System.Web.UI.WebControls/FontUnit.cs
mcs/class/System.Web/System.Web.UI.WebControls/FormParameter.cs
mcs/class/System.Web/System.Web.UI.WebControls/FormView.cs
mcs/class/System.Web/System.Web.UI.WebControls/FormViewCommandEventArgs.cs
mcs/class/System.Web/System.Web.UI.WebControls/FormViewDeleteEventArgs.cs
mcs/class/System.Web/System.Web.UI.WebControls/FormViewInsertEventArgs.cs
mcs/class/System.Web/System.Web.UI.WebControls/FormViewRow.cs
mcs/class/System.Web/System.Web.UI.WebControls/FormViewUpdateEventArgs.cs
mcs/class/System.Web/System.Web.UI.WebControls/GridView.cs
mcs/class/System.Web/System.Web.UI.WebControls/GridViewDeleteEventArgs.cs
mcs/class/System.Web/System.Web.UI.WebControls/GridViewRowCollection.cs
mcs/class/System.Web/System.Web.UI.WebControls/HotSpotCollection.cs
mcs/class/System.Web/System.Web.UI.WebControls/HyperLink.cs
mcs/class/System.Web/System.Web.UI.WebControls/HyperLinkColumn.cs
mcs/class/System.Web/System.Web.UI.WebControls/HyperLinkField.cs
mcs/class/System.Web/System.Web.UI.WebControls/ImageField.cs
mcs/class/System.Web/System.Web.UI.WebControls/LinkButton.cs
mcs/class/System.Web/System.Web.UI.WebControls/ListControl.cs
mcs/class/System.Web/System.Web.UI.WebControls/ListItem.cs
mcs/class/System.Web/System.Web.UI.WebControls/Literal.cs
mcs/class/System.Web/System.Web.UI.WebControls/Menu.cs
mcs/class/System.Web/System.Web.UI.WebControls/MenuItemBindingCollection.cs
mcs/class/System.Web/System.Web.UI.WebControls/MenuItemCollection.cs
mcs/class/System.Web/System.Web.UI.WebControls/MenuItemStyleCollection.cs
mcs/class/System.Web/System.Web.UI.WebControls/MenuItemTemplateContainer.cs
mcs/class/System.Web/System.Web.UI.WebControls/MultiView.cs
mcs/class/System.Web/System.Web.UI.WebControls/PagedDataSource.cs
mcs/class/System.Web/System.Web.UI.WebControls/Panel.cs
mcs/class/System.Web/System.Web.UI.WebControls/ParameterCollection.cs
mcs/class/System.Web/System.Web.UI.WebControls/QueryStringParameter.cs
mcs/class/System.Web/System.Web.UI.WebControls/RegularExpressionValidator.cs
mcs/class/System.Web/System.Web.UI.WebControls/RepeatInfo.cs
mcs/class/System.Web/System.Web.UI.WebControls/RequiredFieldValidator.cs
mcs/class/System.Web/System.Web.UI.WebControls/ServerValidateEventArgs.cs
mcs/class/System.Web/System.Web.UI.WebControls/SessionParameter.cs
mcs/class/System.Web/System.Web.UI.WebControls/SiteMapDataSourceView.cs
mcs/class/System.Web/System.Web.UI.WebControls/SiteMapPath.cs
mcs/class/System.Web/System.Web.UI.WebControls/SqlDataSource.cs
mcs/class/System.Web/System.Web.UI.WebControls/Style.cs
mcs/class/System.Web/System.Web.UI.WebControls/SubMenuStyleCollection.cs
mcs/class/System.Web/System.Web.UI.WebControls/TextBox.cs
mcs/class/System.Web/System.Web.UI.WebControls/TreeNode.cs
mcs/class/System.Web/System.Web.UI.WebControls/TreeNodeBindingCollection.cs
mcs/class/System.Web/System.Web.UI.WebControls/TreeNodeCollection.cs
mcs/class/System.Web/System.Web.UI.WebControls/TreeNodeStyleCollection.cs
mcs/class/System.Web/System.Web.UI.WebControls/TreeView.cs
mcs/class/System.Web/System.Web.UI.WebControls/Unit.cs
mcs/class/System.Web/System.Web.UI.WebControls/Wizard.cs
mcs/class/System.Web/System.Web.UI.WebControls/WizardNavigationEventArgs.cs
mcs/class/System.Web/System.Web.UI.WebControls/WizardNavigationEventHandler.cs
mcs/class/System.Web/System.Web.UI/AttributeCollection.cs
mcs/class/System.Web/System.Web.UI/ChtmlTextWriter.cs
mcs/class/System.Web/System.Web.UI/CompiledTemplateBuilder.cs
mcs/class/System.Web/System.Web.UI/Control.cs
mcs/class/System.Web/System.Web.UI/ControlCollection.cs
mcs/class/System.Web/System.Web.UI/ControlValuePropertyAttribute.cs
mcs/class/System.Web/System.Web.UI/DataBinder.cs
mcs/class/System.Web/System.Web.UI/DataSourceControl.cs
mcs/class/System.Web/System.Web.UI/DataSourceSelectArguments.cs
mcs/class/System.Web/System.Web.UI/DataSourceView.cs
mcs/class/System.Web/System.Web.UI/DataSourceViewOperationCallback.cs
mcs/class/System.Web/System.Web.UI/ExpressionBindingCollection.cs
mcs/class/System.Web/System.Web.UI/HtmlTextWriter.cs
mcs/class/System.Web/System.Web.UI/LiteralControl.cs
mcs/class/System.Web/System.Web.UI/Page.cs
mcs/class/System.Web/System.Web.UI/PageHandlerFactory.cs
mcs/class/System.Web/System.Web.UI/Pair.cs
mcs/class/System.Web/System.Web.UI/TemplateContainerAttribute.cs
mcs/class/System.Web/System.Web.UI/TemplateControl.cs
mcs/class/System.Web/System.Web.UI/XPathBinder.cs
mcs/class/System.Web/System.Web/HttpCachePolicy.cs
mcs/class/System.Web/System.Web/HttpCacheVaryByParams.cs
mcs/class/System.Web/System.Web/HttpContext.cs
mcs/class/System.Web/System.Web/HttpContextWrapper.cs
mcs/class/System.Web/System.Web/HttpCookieCollection.cs
mcs/class/System.Web/System.Web/HttpFileCollection.cs
mcs/class/System.Web/System.Web/HttpModuleCollection.cs
mcs/class/System.Web/System.Web/HttpParseException.cs
mcs/class/System.Web/System.Web/HttpResponseWrapper.cs
mcs/class/System.Web/System.Web/HttpUtility.cs
mcs/class/System.Web/System.Web/ParserErrorCollection.cs
mcs/class/System.Web/System.Web/SiteMapNode.cs
mcs/class/System.Web/System.Web/SiteMapNodeCollection.cs
mcs/class/System.Web/System.Web/TraceContext.cs
mcs/class/System.Windows.Forms.DataVisualization/System.Windows.Forms.DataVisualization.Charting/DataPointCustomProperties.cs
mcs/class/System.Xaml/System.Windows.Markup/ContentWrapperAttribute.cs
mcs/class/System.Xaml/System.Xaml.Schema/XamlTypeName.cs
mcs/class/System.Xaml/System.Xaml.Schema/XamlValueConverter.cs
mcs/class/System.Xaml/System.Xaml/XamlMember.cs
mcs/class/System.Xaml/System.Xaml/XamlServices.cs
mcs/class/System.Xaml/System.Xaml/XamlType.cs
mcs/class/System.Xaml/System.Xaml/XamlXmlWriter.cs
mcs/class/System/System.Configuration/ConfigXmlDocument.cs
mcs/class/System/System.Configuration/SettingElement.cs
mcs/class/System/System.Configuration/SpecialSettingAttribute.cs
mcs/class/System/System.Diagnostics/CounterSample.cs
mcs/class/System/System.Diagnostics/EventLogEntryCollection.cs
mcs/class/System/System.Diagnostics/EventLogTraceListener.cs
mcs/class/System/System.Diagnostics/Process.cs
mcs/class/System/System.IO.Compression/DeflateStream.cs
mcs/class/System/System.IO.Ports/SerialPort.cs
mcs/class/System/System.Net.Mail/AlternateView.cs
mcs/class/System/System.Net.Mail/MailAddress.cs
mcs/class/System/System.Net.Mail/SmtpClient.cs
mcs/class/System/System.Net.Mail/SmtpException.cs
mcs/class/System/System.Net.Mail/SmtpFailedRecipientException.cs
mcs/class/System/System.Net.Mail/SmtpFailedRecipientsException.cs
mcs/class/System/System.Net.Sockets/Socket.cs
mcs/class/System/System.Net/HttpWebRequest.cs
mcs/class/System/System.Security.Permissions/StorePermission.cs
mcs/class/System/Test/System.Net.Mail/SmtpExceptionTest.cs
mcs/class/WindowsBase/System.ComponentModel/CurrentChangingEventHandler.cs
mcs/class/corlib/System/Environment.cs
mcs/class/corlib/System/NumberFormatter.cs
mcs/class/corlib/Test/System/Int32Test.cs
mcs/tools/corcompare/mono-api-info.cs
mcs/tools/mdb2ppdb/Makefile
mcs/tools/xbuild/Makefile
mono/metadata/appdomain.c
mono/metadata/assembly.c
mono/metadata/culture-info-tables.h
mono/metadata/debug-helpers.c
mono/metadata/image.c
mono/metadata/metadata-internals.h
mono/mini/Makefile.am.in
mono/mini/aot-compiler.c
mono/mini/basic-simd.cs
mono/mini/mini-amd64.h
mono/mini/mini-ops.h
mono/mini/mini-x86.c
mono/mini/simd-intrinsics.c
mono/utils/mono-context.c
mono/utils/mono-context.h
mono/utils/mono-sigcontext.h
msvc/winsetup.bat
tools/locale-builder/Patterns.cs
tools/nuget-hash-extractor/Makefile
tools/nuget-hash-extractor/download.sh
tools/nuget-hash-extractor/nuget-hash-extractor.cs
winconfig.h

index 16e5ba16c16ef6a2292039a17e01d5c1abd5043a..1dbe3b14a2ecd964a9bf9f6ce48492b3eed09520 100644 (file)
@@ -56,15 +56,14 @@ DISTCLEANFILES= mono-uninstalled.pc
 # building with monolite
 mcslib = $(mcs_topdir)/class/lib
 monolite = $(mcslib)/monolite
-mono_corlib_version = $(shell sed -n "s/\#define MONO_CORLIB_VERSION //p" $(srcdir)/mono/metadata/appdomain.c)
-monolite_url = http://download.mono-project.com/monolite/monolite-$(mono_corlib_version)-latest.tar.gz
+monolite_url = https://download.mono-project.com/monolite/monolite-$(MONO_CORLIB_VERSION)-latest.tar.gz
 .PHONY: get-monolite-latest 
 get-monolite-latest:
        -rm -fr $(mcslib)/monolite-*
        -mkdir -p $(mcslib)
        test ! -d $(monolite) || test ! -d $(monolite).old || rm -fr $(monolite).old
        test ! -d $(monolite) || mv -f $(monolite) $(monolite).old
-       cd $(mcslib) && { (wget -O- $(monolite_url) || curl $(monolite_url)) | gzip -d | tar xf - ; }
+       cd $(mcslib) && { (wget -O- $(monolite_url) || curl -L $(monolite_url)) | gzip -d | tar xf - ; }
        cd $(mcslib) && mv -f monolite-* monolite
 
 if BITCODE
index 4533d289ef958597fadc5c37e13749773d4294ae..433ff566fd7d69a1ce7475421f6914d99e4aae4a 100644 (file)
@@ -29,6 +29,24 @@ AC_PROG_LN_S
 
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 
+MONO_VERSION_MAJOR=`echo $VERSION | cut -d . -f 1`
+MONO_VERSION_MINOR=`echo $VERSION | cut -d . -f 2`
+MONO_VERSION_BUILD=`echo $VERSION | cut -d . -f 3`
+
+# This is the version number of the corlib-runtime interface. When
+# making changes to this interface (by changing the layout
+# of classes the runtime knows about, changing icall signature or
+# semantics etc), increment this variable.
+#
+# This can be reset to 0 when Mono's version number is bumped
+# since it's part of the corlib version (the prefix '1' in the full
+# version number is to ensure the number isn't treated as octal in C)
+MONO_CORLIB_COUNTER=0
+MONO_CORLIB_VERSION=`printf "1%02d%02d%02d%03d" $MONO_VERSION_MAJOR $MONO_VERSION_MINOR $MONO_VERSION_BUILD $MONO_CORLIB_COUNTER`
+
+AC_DEFINE_UNQUOTED(MONO_CORLIB_VERSION,$MONO_CORLIB_VERSION,[Version of the corlib-runtime interface])
+AC_SUBST(MONO_CORLIB_VERSION)
+
 case $host_os in
 *cygwin* )
                 echo "Run configure using ./configure --host=i686-pc-mingw32"
@@ -4536,6 +4554,7 @@ fi
     }')]
 
     echo "MONO_VERSION = $myver" >> $mcs_topdir/build/config.make
+    echo "MONO_CORLIB_VERSION = $MONO_CORLIB_VERSION" >> $mcs_topdir/build/config.make
 
     if test x$host_darwin = xyes; then
       echo "PLATFORM = darwin" >> $mcs_topdir/build/config.make
index e4deabf61c11999f200dcea6f6d6b42474cc2131..88b67c42ca8b7d58141c176b46749819bfcef166 160000 (submodule)
@@ -1 +1 @@
-Subproject commit e4deabf61c11999f200dcea6f6d6b42474cc2131
+Subproject commit 88b67c42ca8b7d58141c176b46749819bfcef166
index 14ad0cbd10c74283e2d25bc4cb1682d77c5dcb90..5af3d0449898ad5d21b2a0a6ac5d1da61cf4f7f4 100644 (file)
@@ -12,7 +12,8 @@ clean-local:
 
 common/Consts.cs: common/Consts.cs.in $(wildcard config.make)
        test -n '$(MONO_VERSION)'
-       sed -e 's,@''MONO_VERSION@,$(MONO_VERSION),' $< > $@
+       test -n '$(MONO_CORLIB_VERSION)'
+       sed -e 's,@''MONO_VERSION@,$(MONO_VERSION),' -e 's,@''MONO_CORLIB_VERSION@,$(MONO_CORLIB_VERSION),' $< > $@
 
 PLATFORMS = darwin linux win32
 PROFILES = \
index 87b005e763a2c4b30abb0dd0f05862fe49c10380..8bb64bc43a700954c45074712655ac02159ec3fc 100644 (file)
@@ -38,6 +38,7 @@ static class Consts
        public const string MonoCompany = "Mono development team";
        public const string MonoProduct = "Mono Common Language Infrastructure";
        public const string MonoCopyright = "(c) Various Mono authors";
+       public const int MonoCorlibVersion = @MONO_CORLIB_VERSION@;
 
 #if MOBILE
        // Versions of .NET Framework for Silverlight 4.0
index 7890bf0fef55dc8fffe4dcd37506f9dc3c1857a8..4da3ed027ecfd901653351ee7744606e8181cc1f 100644 (file)
@@ -1,2 +1,3 @@
 /lib
 /compat/
+monolite-*.tar.gz
index fa9e99d722dfc86189a2cfa2bda0c2a669044e98..3016300230ec3394807c44fd1264c78e0f47286c 100644 (file)
@@ -425,6 +425,11 @@ $(build_files:%=lib/build/%):
 
 dist-monolite: $(monolite_files) lib/$(monolite_dir)/mcs.exe
 
+package-monolite-latest:
+       MONOLITE=monolite-$(MONO_CORLIB_VERSION)-latest; \
+       $(MAKE) dist-monolite monolite_dir=$$MONOLITE; \
+       tar zcvpf $$MONOLITE.tar.gz --directory=lib $$MONOLITE/
+
 dist-default: dist-monolite
 
 dist-local: dist-default
index 9800c6883f57527042e4bc6cbf9ca3be2dd3e921..d75ac2543e4a1ed16b52bc1964987bdf8608a1cb 100644 (file)
@@ -168,19 +168,19 @@ namespace Microsoft.Build.BuildEngine {
                                        yield return kvp.Value;
                }
 
-               public void RemoveProperty (BuildProperty propertyToRemove)
+               public void RemoveProperty (BuildProperty property)
                {
-                       if (propertyToRemove == null)
-                               throw new ArgumentNullException ("propertyToRemove");
+                       if (property == null)
+                               throw new ArgumentNullException ("property");
 
                        if (FromXml) {
-                               if (!propertyToRemove.FromXml)
+                               if (!property.FromXml)
                                        throw new InvalidOperationException ("The specified property does not belong to the current property group.");
 
-                               propertyToRemove.XmlElement.ParentNode.RemoveChild (propertyToRemove.XmlElement);
-                               properties.Remove (propertyToRemove);
+                               property.XmlElement.ParentNode.RemoveChild (property.XmlElement);
+                               properties.Remove (property);
                        } else
-                               propertiesByName.Remove (propertyToRemove.Name);
+                               propertiesByName.Remove (property.Name);
                }
 
                public void RemoveProperty (string propertyName)
index ff6acda08f3a4e3465a0ec2ff5237c56694f2a65..2e3e06f47a8330b18e59e8fa890082a23751e1a0 100644 (file)
@@ -296,14 +296,14 @@ namespace Microsoft.Build.BuildEngine
                        return build_records.GetOrAdd (key, _ => new BuildRecord (this));
                }
 
-               public void BuildStartedHandler (object sender, BuildStartedEventArgs args)
+               public void BuildStartedHandler (object sender, BuildStartedEventArgs e)
                {
-                       GetBuildRecord (sender).BuildStartedHandler (sender, args);
+                       GetBuildRecord (sender).BuildStartedHandler (sender, e);
                }
                
-               public void BuildFinishedHandler (object sender, BuildFinishedEventArgs args)
+               public void BuildFinishedHandler (object sender, BuildFinishedEventArgs e)
                {
-                       GetBuildRecord (sender).BuildFinishedHandler (args);
+                       GetBuildRecord (sender).BuildFinishedHandler (e);
                        ((IDictionary) build_records).Remove (sender);
                }
                
@@ -315,47 +315,47 @@ namespace Microsoft.Build.BuildEngine
                {
                        GetBuildRecord (sender).PopEvent (args);
                }
-               public void ProjectStartedHandler (object sender, ProjectStartedEventArgs args)
+               public void ProjectStartedHandler (object sender, ProjectStartedEventArgs e)
                {
-                       GetBuildRecord (sender).ProjectStartedHandler (args);
+                       GetBuildRecord (sender).ProjectStartedHandler (e);
                }
-               public void ProjectFinishedHandler (object sender, ProjectFinishedEventArgs args)
+               public void ProjectFinishedHandler (object sender, ProjectFinishedEventArgs e)
                {
-                       GetBuildRecord (sender).ProjectFinishedHandler (args);
+                       GetBuildRecord (sender).ProjectFinishedHandler (e);
                }               
-               public void TargetStartedHandler (object sender, TargetStartedEventArgs args)
+               public void TargetStartedHandler (object sender, TargetStartedEventArgs e)
                {
-                       GetBuildRecord (sender).TargetStartedHandler (args);
+                       GetBuildRecord (sender).TargetStartedHandler (e);
                }
-               public void TargetFinishedHandler (object sender, TargetFinishedEventArgs args)
+               public void TargetFinishedHandler (object sender, TargetFinishedEventArgs e)
                {
-                       GetBuildRecord (sender).TargetFinishedHandler (args);
+                       GetBuildRecord (sender).TargetFinishedHandler (e);
                }
-               public void TaskStartedHandler (object sender, TaskStartedEventArgs args)
+               public void TaskStartedHandler (object sender, TaskStartedEventArgs e)
                {
-                       GetBuildRecord (sender).TaskStartedHandler (args);
+                       GetBuildRecord (sender).TaskStartedHandler (e);
                }
-               public void TaskFinishedHandler (object sender, TaskFinishedEventArgs args)
+               public void TaskFinishedHandler (object sender, TaskFinishedEventArgs e)
                {
-                       GetBuildRecord (sender).TaskFinishedHandler (args);
+                       GetBuildRecord (sender).TaskFinishedHandler (e);
                }
-               public void MessageHandler (object sender, BuildMessageEventArgs args)
+               public void MessageHandler (object sender, BuildMessageEventArgs e)
                {
-                       GetBuildRecord (sender).MessageHandler (args);
+                       GetBuildRecord (sender).MessageHandler (e);
                }
-               public void WarningHandler (object sender, BuildWarningEventArgs args)
+               public void WarningHandler (object sender, BuildWarningEventArgs e)
                {
-                       GetBuildRecord (sender).WarningHandler (args);
+                       GetBuildRecord (sender).WarningHandler (e);
                }
-               public void ErrorHandler (object sender, BuildErrorEventArgs args)
+               public void ErrorHandler (object sender, BuildErrorEventArgs e)
                {
-                       GetBuildRecord (sender).ErrorHandler (args);
+                       GetBuildRecord (sender).ErrorHandler (e);
                }
                
                [MonoTODO]
-               public void CustomEventHandler (object sender, CustomBuildEventArgs args)
+               public void CustomEventHandler (object sender, CustomBuildEventArgs e)
                {
-                       build_records [sender].CustomHandler (args);
+                       build_records [sender].CustomHandler (e);
                }
 
                void SetColor (ConsoleColor color)
index b4ed8562382595c92f99c2b474a5c9ecc4043757..b1e95b14c69ef46d2271defdd679deedf2e3a3f0 100644 (file)
@@ -131,17 +131,17 @@ namespace Microsoft.Build.BuildEngine {
                }
 
                [MonoTODO ("Not tested")]
-               public void AddNewImport (string importLocation,
-                                         string importCondition)
+               public void AddNewImport (string projectFile,
+                                         string condition)
                {
-                       if (importLocation == null)
-                               throw new ArgumentNullException ("importLocation");
+                       if (projectFile == null)
+                               throw new ArgumentNullException ("projectFile");
 
                        XmlElement importElement = xmlDocument.CreateElement ("Import", XmlNamespace);
                        xmlDocument.DocumentElement.AppendChild (importElement);
-                       importElement.SetAttribute ("Project", importLocation);
-                       if (!String.IsNullOrEmpty (importCondition))
-                               importElement.SetAttribute ("Condition", importCondition);
+                       importElement.SetAttribute ("Project", projectFile);
+                       if (!String.IsNullOrEmpty (condition))
+                               importElement.SetAttribute ("Condition", condition);
 
                        AddImport (importElement, null, false);
                        MarkProjectAsDirty ();
@@ -506,9 +506,9 @@ namespace Microsoft.Build.BuildEngine {
                        Load (projectFileName, ProjectLoadSettings.None);
                }
 
-               public void Load (string projectFileName, ProjectLoadSettings settings)
+               public void Load (string projectFileName, ProjectLoadSettings projectLoadSettings)
                {
-                       project_load_settings = settings;
+                       project_load_settings = projectLoadSettings;
                        if (String.IsNullOrEmpty (projectFileName))
                                throw new ArgumentNullException ("projectFileName");
 
@@ -644,7 +644,7 @@ namespace Microsoft.Build.BuildEngine {
                
                [MonoTODO]
                // NOTE: does not modify imported projects
-               public void RemoveItemGroupsWithMatchingCondition (string matchingCondition)
+               public void RemoveItemGroupsWithMatchingCondition (string matchCondition)
                {
                        throw new NotImplementedException ();
                }
@@ -697,9 +697,9 @@ namespace Microsoft.Build.BuildEngine {
                        isDirty = false;
                }
 
-               public void Save (TextWriter outTextWriter)
+               public void Save (TextWriter textWriter)
                {
-                       xmlDocument.Save (outTextWriter);
+                       xmlDocument.Save (textWriter);
                        isDirty = false;
                }
 
@@ -733,12 +733,12 @@ namespace Microsoft.Build.BuildEngine {
                        throw new NotImplementedException ();
                }
 
-               public void SetProjectExtensions (string id, string xmlText)
+               public void SetProjectExtensions (string id, string content)
                {
                        if (id == null)
                                throw new ArgumentNullException ("id");
-                       if (xmlText == null)
-                               throw new ArgumentNullException ("xmlText");
+                       if (content == null)
+                               throw new ArgumentNullException ("content");
 
                        XmlNode projectExtensions, node;
 
@@ -749,7 +749,7 @@ namespace Microsoft.Build.BuildEngine {
                                xmlDocument.DocumentElement.AppendChild (projectExtensions);
 
                                node = xmlDocument.CreateElement (id, XmlNamespace);
-                               node.InnerXml = xmlText;
+                               node.InnerXml = content;
                                projectExtensions.AppendChild (node);
                        } else {
                                node = xmlDocument.SelectSingleNode (String.Format ("/tns:Project/tns:ProjectExtensions/tns:{0}", id), XmlNamespaceManager);
@@ -759,7 +759,7 @@ namespace Microsoft.Build.BuildEngine {
                                        projectExtensions.AppendChild (node);
                                }
                                
-                               node.InnerXml = xmlText;
+                               node.InnerXml = content;
                                
                        }
 
index dd1b9cc88c22293fb00c16bc9f1f48c6b13aa5d4..e4f384bceacf19d8a63d48efc268bf5f6078a832 100644 (file)
@@ -111,11 +111,11 @@ namespace Microsoft.Build.BuildEngine {
                }
 
                // FIXME: shouldn't we remove it from XML?
-               public void RemoveTask (BuildTask buildTask)
+               public void RemoveTask (BuildTask taskElement)
                {
-                       if (buildTask == null)
-                               throw new ArgumentNullException ("buildTask");
-                       buildTasks.Remove (buildTask);
+                       if (taskElement == null)
+                               throw new ArgumentNullException ("taskElement");
+                       buildTasks.Remove (taskElement);
                }
 
                bool Build ()
index 271029897218c81eb9d1a562cac5a734fa1c0c77..794d33e0fc7a8b2424455d3bc9e0ca8c2904eacd 100644 (file)
@@ -45,9 +45,9 @@ namespace Microsoft.Build.Construction
                        get { return Line == 0 ? File : String.Format ("{0} ({1}{2})", File, Line, Column != 0 ? "," + Column : String.Empty); }
                }
 
-               public override bool Equals (object other)
+               public override bool Equals (object obj)
                {
-                       var o = other as ElementLocation;
+                       var o = obj as ElementLocation;
                        return (object) o != null && o.File == File && o.Line == Line && o.Column == Column;
                }
 
index 4189bf8b2f108f19b8086e5a8fa52423e329419a..e4263aa9de1c6ba6bc994e8facf7998cf05d02b1 100644 (file)
@@ -79,27 +79,27 @@ namespace Microsoft.Build.Evaluation
        + "{data.Items.Count} #Targets={data.Targets.Count}")]
        public class Project
        {
-               public Project (XmlReader xml)
-                       : this (ProjectRootElement.Create (xml))
+               public Project (XmlReader xmlReader)
+                       : this (ProjectRootElement.Create (xmlReader))
                {
                }
 
-               public Project (XmlReader xml, IDictionary<string, string> globalProperties,
+               public Project (XmlReader xmlReader, IDictionary<string, string> globalProperties,
                                              string toolsVersion)
-                       : this (ProjectRootElement.Create (xml), globalProperties, toolsVersion)
+                       : this (ProjectRootElement.Create (xmlReader), globalProperties, toolsVersion)
                {
                }
 
-               public Project (XmlReader xml, IDictionary<string, string> globalProperties,
+               public Project (XmlReader xmlReader, IDictionary<string, string> globalProperties,
                                              string toolsVersion, ProjectCollection projectCollection)
-                       : this (ProjectRootElement.Create (xml), globalProperties, toolsVersion, projectCollection)
+                       : this (ProjectRootElement.Create (xmlReader), globalProperties, toolsVersion, projectCollection)
                {
                }
 
-               public Project (XmlReader xml, IDictionary<string, string> globalProperties,
+               public Project (XmlReader xmlReader, IDictionary<string, string> globalProperties,
                                              string toolsVersion, ProjectCollection projectCollection,
                                              ProjectLoadSettings loadSettings)
-                       : this (ProjectRootElement.Create (xml), globalProperties, toolsVersion, projectCollection, loadSettings)
+                       : this (ProjectRootElement.Create (xmlReader), globalProperties, toolsVersion, projectCollection, loadSettings)
                {
                }
 
index 01a66207142e41dec4ebf2fd0b1fa8710341147b..21df964a75ad4c13a065c2ea747d182d50889a0e 100644 (file)
@@ -49,15 +49,15 @@ namespace Microsoft.Build.Evaluation
 {
        public class ProjectCollection : IDisposable
        {
-               public delegate void ProjectAddedEventHandler (object target, ProjectAddedToProjectCollectionEventArgs args);
+               public delegate void ProjectAddedEventHandler (object sender, ProjectAddedToProjectCollectionEventArgs e);
                
                public class ProjectAddedToProjectCollectionEventArgs : EventArgs
                {
-                       public ProjectAddedToProjectCollectionEventArgs (ProjectRootElement project)
+                       public ProjectAddedToProjectCollectionEventArgs (ProjectRootElement element)
                        {
-                               if (project == null)
+                               if (element == null)
                                        throw new ArgumentNullException ("project");
-                               ProjectRootElement = project;
+                               ProjectRootElement = element;
                        }
                        
                        public ProjectRootElement ProjectRootElement { get; private set; }
@@ -98,8 +98,8 @@ namespace Microsoft.Build.Evaluation
                {
                }
 
-               public ProjectCollection (ToolsetDefinitionLocations toolsetDefinitionLocations)
-               : this (null, null, toolsetDefinitionLocations)
+               public ProjectCollection (ToolsetDefinitionLocations toolsetLocations)
+               : this (null, null, toolsetLocations)
                {
                }
 
index e626959aa1fb2b8e5abb583d369ac48d0b466892..f6eb089e95a22dae35bee5511f3b9c3ba0639337 100644 (file)
@@ -29,6 +29,7 @@ using System.Runtime.InteropServices;
 
 namespace Mono.Simd
 {
+       [Obsolete ("Use the types in the System.Numerics.Vectors namespace")]
        [StructLayout(LayoutKind.Explicit, Pack = 1, Size = 16)]
        public struct Vector16b
        {
index e0dc37effe2946bae177b0facd6cc1d7df2e53ad..58395987ca1584d3120fc63879ae336a3da5d92e 100644 (file)
@@ -29,6 +29,7 @@ using System.Runtime.InteropServices;
 
 namespace Mono.Simd
 {
+       [Obsolete ("Use the types in the System.Numerics.Vectors namespace")]
        [StructLayout(LayoutKind.Explicit, Pack = 1, Size = 16)]
        [CLSCompliant(false)]
        public struct Vector16sb
index 9c57b793928aef0a7a454e5b5d0339a9709c2841..59f0bb753826f323edac085c3d43e556788f250c 100644 (file)
@@ -30,7 +30,7 @@ using System.Runtime.InteropServices;
 
 namespace Mono.Simd
 {
-
+       [Obsolete ("Use the types in the System.Numerics.Vectors namespace")]
        [StructLayout(LayoutKind.Explicit, Pack = 0, Size = 16)]
        public struct Vector2d
        {
index 0e5a1d80e2f634333c7f57a35b73f4eaed3a51e9..a08d06d14e357628c7023d96d62f28c277d7e865 100644 (file)
@@ -29,6 +29,7 @@ using System.Runtime.InteropServices;
 
 namespace Mono.Simd
 {
+       [Obsolete ("Use the types in the System.Numerics.Vectors namespace")]
        [StructLayout(LayoutKind.Explicit, Pack = 0, Size = 16)]
        public struct Vector2l
        {
index de273f596b62fae978e96716f2e992f5638de56c..25de9047d560c0f4553e059f12130f2713b1e590 100644 (file)
@@ -29,6 +29,7 @@ using System.Runtime.InteropServices;
 
 namespace Mono.Simd
 {
+       [Obsolete ("Use the types in the System.Numerics.Vectors namespace")]
        [StructLayout(LayoutKind.Explicit, Pack = 0, Size = 16)]
        [CLSCompliant(false)]
        public struct Vector2ul
index db7143b9b4952b293cdef1282405e012f7df392a..e018f92e6898e6959af5693ceb51dadfa5e585c0 100644 (file)
@@ -84,6 +84,7 @@ namespace Mono.Simd
                Replace Shuffle with less bug prone methods
 */
 
+       [Obsolete ("Use the types in the System.Numerics.Vectors namespace")]
        [StructLayout(LayoutKind.Explicit, Pack = 0, Size = 16)]
        public struct Vector4f
        {
index aa5ee39d697716244c4439b01230101895748295..1df6171b41ef9ffa0dc9c91a64b0dcb1e297d20b 100644 (file)
@@ -29,6 +29,7 @@ using System.Runtime.InteropServices;
 
 namespace Mono.Simd
 {
+       [Obsolete ("Use the types in the System.Numerics.Vectors namespace")]
        [StructLayout(LayoutKind.Explicit, Pack = 0, Size = 16)]
        public struct Vector4i
        {
index c62365c61a3337906905f93b8f3ee23b9c04d23d..b961987a5eafd1295750e950b4b5ca0a78cadd00 100644 (file)
@@ -29,6 +29,7 @@ using System.Runtime.InteropServices;
 
 namespace Mono.Simd
 {
+       [Obsolete ("Use the types in the System.Numerics.Vectors namespace")]
        [StructLayout(LayoutKind.Explicit, Pack = 0, Size = 16)]
        [CLSCompliant(false)]
        public struct Vector4ui
index be178470a85e19f302f9cbffe4419624c7bc2e2e..1008c20920b7b478d1f316f0dc69ea86923c1a98 100644 (file)
@@ -29,6 +29,7 @@ using System.Runtime.InteropServices;
 
 namespace Mono.Simd
 {
+       [Obsolete ("Use the types in the System.Numerics.Vectors namespace")]
        [StructLayout(LayoutKind.Explicit, Pack = 0, Size = 16)]
        public struct Vector8s
        {
index 2c9afd33c0b3076ff0180196ed3f32a12558f5a5..0aa16ee49a89960db5497cb37705b346163f3f4b 100644 (file)
@@ -29,6 +29,7 @@ using System.Runtime.InteropServices;
 
 namespace Mono.Simd
 {
+       [Obsolete ("Use the types in the System.Numerics.Vectors namespace")]
        [StructLayout(LayoutKind.Explicit, Pack = 0, Size = 16)]
        [CLSCompliant(false)]
        public struct Vector8us
index d5010fd1970591d149e8ac43a38e5c4990a7651b..7c62434346c2e711f6622fdf8c10045339e968d9 100755 (executable)
@@ -1,5 +1,5 @@
 Novell.Directory.Ldap/AssemblyInfo.cs
-../../build/common/Consts.cs.in
+../../build/common/Consts.cs
 Novell.Directory.Ldap/SupportClass.cs
 Novell.Directory.Ldap.Utilclass/Base64.cs
 Novell.Directory.Ldap.Utilclass/DN.cs
index c642a6ce5b672d77fb00c7ea627e4a95ed92f912..db86289ba1ac218b2a63b6829701f3990422c66a 100644 (file)
@@ -56,9 +56,9 @@ namespace System.Configuration.Internal
                        return host.CreateDeprecatedConfigContext (configPath);
                }
                
-               public virtual string DecryptSection (string encryptedXml, ProtectedConfigurationProvider protectionProvider, ProtectedConfigurationSection protectedSection)
+               public virtual string DecryptSection (string encryptedXml, ProtectedConfigurationProvider protectionProvider, ProtectedConfigurationSection protectedConfigSection)
                {
-                       return host.DecryptSection (encryptedXml, protectionProvider, protectedSection);
+                       return host.DecryptSection (encryptedXml, protectionProvider, protectedConfigSection);
                }
                
                public virtual void DeleteStream (string streamName)
@@ -66,14 +66,14 @@ namespace System.Configuration.Internal
                        host.DeleteStream (streamName);
                }
                
-               public virtual string EncryptSection (string encryptedXml, ProtectedConfigurationProvider protectionProvider, ProtectedConfigurationSection protectedSection)
+               public virtual string EncryptSection (string clearTextXml, ProtectedConfigurationProvider protectionProvider, ProtectedConfigurationSection protectedConfigSection)
                {
-                       return host.EncryptSection (encryptedXml, protectionProvider, protectedSection);
+                       return host.EncryptSection (clearTextXml, protectionProvider, protectedConfigSection);
                }
                
-               public virtual string GetConfigPathFromLocationSubPath (string configPath, string locatinSubPath)
+               public virtual string GetConfigPathFromLocationSubPath (string configPath, string locationSubPath)
                {
-                       return host.GetConfigPathFromLocationSubPath (configPath, locatinSubPath);
+                       return host.GetConfigPathFromLocationSubPath (configPath, locationSubPath);
                }
                
                public virtual Type GetConfigType (string typeName, bool throwOnError)
@@ -111,14 +111,14 @@ namespace System.Configuration.Internal
                        return host.Impersonate ();
                }
                
-               public virtual void Init (IInternalConfigRoot root, params object[] hostInitParams)
+               public virtual void Init (IInternalConfigRoot configRoot, params object[] hostInitParams)
                {
-                       host.Init (root, hostInitParams);
+                       host.Init (configRoot, hostInitParams);
                }
                
-               public virtual void InitForConfiguration (ref string locationSubPath, out string configPath, out string locationConfigPath, IInternalConfigRoot root, params object[] hostInitConfigurationParams)
+               public virtual void InitForConfiguration (ref string locationSubPath, out string configPath, out string locationConfigPath, IInternalConfigRoot configRoot, params object[] hostInitConfigurationParams)
                {
-                       host.InitForConfiguration (ref locationSubPath, out configPath, out locationConfigPath, root, hostInitConfigurationParams);
+                       host.InitForConfiguration (ref locationSubPath, out configPath, out locationConfigPath, configRoot, hostInitConfigurationParams);
                }
                
                public virtual bool IsAboveApplication (string configPath)
index 2cde5e60c788f9f212202d2ed7cdf581d758536b..0445508661f3cab32fdba62270e71f7f87f5521a 100644 (file)
@@ -38,10 +38,10 @@ namespace System.Configuration.Internal
        {
                object CreateConfigurationContext (string configPath, string locationSubPath);
                object CreateDeprecatedConfigContext (string configPath);
-               string DecryptSection (string encryptedXml, ProtectedConfigurationProvider protectionProvider, ProtectedConfigurationSection protectedSection);
+               string DecryptSection (string encryptedXml, ProtectedConfigurationProvider protectionProvider, ProtectedConfigurationSection protectedConfigSection);
                void DeleteStream (string streamName);
-               string EncryptSection (string encryptedXml, ProtectedConfigurationProvider protectionProvider, ProtectedConfigurationSection protectedSection);
-               string GetConfigPathFromLocationSubPath (string configPath, string locatinSubPath);
+               string EncryptSection (string clearTextXml, ProtectedConfigurationProvider protectionProvider, ProtectedConfigurationSection protectedConfigSection);
+               string GetConfigPathFromLocationSubPath (string configPath, string locationSubPath);
                Type GetConfigType (string typeName, bool throwOnError);
                string GetConfigTypeName (Type t);
                void GetRestrictedPermissions (IInternalConfigRecord configRecord, out PermissionSet permissionSet, out bool isHostReady);
@@ -49,8 +49,8 @@ namespace System.Configuration.Internal
                string GetStreamNameForConfigSource (string streamName, string configSource);
                object GetStreamVersion (string streamName);
                IDisposable Impersonate ();
-               void Init (IInternalConfigRoot root, params object[] hostInitParams);
-               void InitForConfiguration (ref string locationSubPath, out string configPath, out string locationConfigPath, IInternalConfigRoot root, params object[] hostInitConfigurationParams);
+               void Init (IInternalConfigRoot configRoot, params object[] hostInitParams);
+               void InitForConfiguration (ref string locationSubPath, out string configPath, out string locationConfigPath, IInternalConfigRoot configRoot, params object[] hostInitConfigurationParams);
                bool IsAboveApplication (string configPath);
                bool IsConfigRecordRequired (string configPath);
                bool IsDefinitionAllowed (string configPath, ConfigurationAllowDefinition allowDefinition, ConfigurationAllowExeDefinition allowExeDefinition);
index 9badcd34afdf5f85d9f3656310870bfdc67e2c70..65b63cdee8b266d8699e9eb47c6e565b1f84ac7e 100644 (file)
@@ -95,10 +95,10 @@ namespace System.Configuration {
 
                [MonoTODO]
                protected internal override string SerializeSection (
-                       ConfigurationElement parent, string name, ConfigurationSaveMode mode)
+                       ConfigurationElement parentElement, string name, ConfigurationSaveMode saveMode)
                {
                        if (File == "") {
-                               return base.SerializeSection (parent, name, mode);
+                               return base.SerializeSection (parentElement, name, saveMode);
                        }
                        else {
                                throw new NotImplementedException ();
index fb48cc9664f27b743154806f992f342e7e9a8f35..7e78b1b325f1946ab1bcbb8e95c0ee43ffa7681f 100644 (file)
@@ -251,9 +251,9 @@ namespace System.Configuration {
                        get { return RootSectionGroup.Sections; }
                }
                
-               public ConfigurationSection GetSection (string path)
+               public ConfigurationSection GetSection (string sectionName)
                {
-                       string[] parts = path.Split ('/');
+                       string[] parts = sectionName.Split ('/');
                        if (parts.Length == 1)
                                return Sections [parts[0]];
 
@@ -267,9 +267,9 @@ namespace System.Configuration {
                                return null;
                }
                
-               public ConfigurationSectionGroup GetSectionGroup (string path)
+               public ConfigurationSectionGroup GetSectionGroup (string sectionGroupName)
                {
-                       string[] parts = path.Split ('/');
+                       string[] parts = sectionGroupName.Split ('/');
                        ConfigurationSectionGroup group = SectionGroups [parts[0]];
                        for (int n=1; group != null && n<parts.Length; n++)
                                group = group.SectionGroups [parts [n]];
@@ -388,14 +388,14 @@ namespace System.Configuration {
                        Save (ConfigurationSaveMode.Modified, false);
                }
                
-               public void Save (ConfigurationSaveMode mode)
+               public void Save (ConfigurationSaveMode saveMode)
                {
-                       Save (mode, false);
+                       Save (saveMode, false);
                }
                
-               public void Save (ConfigurationSaveMode mode, bool forceUpdateAll)
+               public void Save (ConfigurationSaveMode saveMode, bool forceSaveAll)
                {
-                       if (!forceUpdateAll && (mode != ConfigurationSaveMode.Full) && !HasValues (mode)) {
+                       if (!forceSaveAll && (saveMode != ConfigurationSaveMode.Full) && !HasValues (saveMode)) {
                                ResetModified ();
                                return;
                        }
@@ -410,7 +410,7 @@ namespace System.Configuration {
                                if (saveStart != null)
                                        saveStart (this, new ConfigurationSaveEventArgs (streamName, true, null, ctx));
                                
-                               Save (stream, mode, forceUpdateAll);
+                               Save (stream, saveMode, forceSaveAll);
                                system.Host.WriteCompleted (streamName, true, ctx);
                        } catch (Exception ex) {
                                saveEx = ex;
@@ -428,15 +428,15 @@ namespace System.Configuration {
                        SaveAs (filename, ConfigurationSaveMode.Modified, false);
                }
                
-               public void SaveAs (string filename, ConfigurationSaveMode mode)
+               public void SaveAs (string filename, ConfigurationSaveMode saveMode)
                {
-                       SaveAs (filename, mode, false);
+                       SaveAs (filename, saveMode, false);
                }
 
                [MonoInternalNote ("Detect if file has changed")]
-               public void SaveAs (string filename, ConfigurationSaveMode mode, bool forceUpdateAll)
+               public void SaveAs (string filename, ConfigurationSaveMode saveMode, bool forceSaveAll)
                {
-                       if (!forceUpdateAll && (mode != ConfigurationSaveMode.Full) && !HasValues (mode)) {
+                       if (!forceSaveAll && (saveMode != ConfigurationSaveMode.Full) && !HasValues (saveMode)) {
                                ResetModified ();
                                return;
                        }
@@ -444,7 +444,7 @@ namespace System.Configuration {
                        string dir = Path.GetDirectoryName (Path.GetFullPath (filename));
                        if (!Directory.Exists (dir))
                                Directory.CreateDirectory (dir);
-                       Save (new FileStream (filename, FileMode.OpenOrCreate, FileAccess.Write), mode, forceUpdateAll);
+                       Save (new FileStream (filename, FileMode.OpenOrCreate, FileAccess.Write), saveMode, forceSaveAll);
                }
 
                void Save (Stream stream, ConfigurationSaveMode mode, bool forceUpdateAll)
index 1123e9ad15642f65c7df07e1bbf333a5feb79a2a..a1e6e16d9535378634eff6a5832e803ee88abf09 100644 (file)
@@ -155,7 +155,7 @@ namespace System.Configuration
                }
 
                [MonoTODO]
-               protected virtual void ListErrors (IList list)
+               protected virtual void ListErrors (IList errorList)
                {
                        throw new NotImplementedException ();
                }
@@ -215,24 +215,24 @@ namespace System.Configuration
                        return defaultCollection;
                }
 
-               protected internal object this [ConfigurationProperty property] {
-                       get { return this [property.Name]; }
-                       set { this [property.Name] = value; }
+               protected internal object this [ConfigurationProperty prop] {
+                       get { return this [prop.Name]; }
+                       set { this [prop.Name] = value; }
                }
 
-               protected internal object this [string property_name] {
+               protected internal object this [string propertyName] {
                        get {
-                               PropertyInformation pi = ElementInformation.Properties [property_name];
+                               PropertyInformation pi = ElementInformation.Properties [propertyName];
                                if (pi == null)
-                                       throw new InvalidOperationException ("Property '" + property_name + "' not found in configuration element");
+                                       throw new InvalidOperationException ("Property '" + propertyName + "' not found in configuration element");
 
                                return pi.Value;
                        }
 
                        set {
-                               PropertyInformation pi = ElementInformation.Properties [property_name];
+                               PropertyInformation pi = ElementInformation.Properties [propertyName];
                                if (pi == null)
-                                       throw new InvalidOperationException ("Property '" + property_name + "' not found in configuration element");
+                                       throw new InvalidOperationException ("Property '" + propertyName + "' not found in configuration element");
 
                                SetPropertyValue (pi.Property, value, false);
 
@@ -415,7 +415,7 @@ namespace System.Configuration
                        return false;
                }
 
-               protected virtual bool OnDeserializeUnrecognizedElement (string element, XmlReader reader)
+               protected virtual bool OnDeserializeUnrecognizedElement (string elementName, XmlReader reader)
                {
                        return false;
                }
@@ -545,16 +545,16 @@ namespace System.Configuration
                }
 
                protected internal virtual void Unmerge (
-                               ConfigurationElement source, ConfigurationElement parent,
-                               ConfigurationSaveMode updateMode)
+                               ConfigurationElement sourceElement, ConfigurationElement parentElement,
+                               ConfigurationSaveMode saveMode)
                {
-                       if (parent != null && source.GetType() != parent.GetType())
+                       if (parentElement != null && sourceElement.GetType() != parentElement.GetType())
                                throw new ConfigurationErrorsException ("Can't unmerge two elements of different type");
 
-                       bool isMinimalOrModified = updateMode == ConfigurationSaveMode.Minimal ||
-                               updateMode == ConfigurationSaveMode.Modified;
+                       bool isMinimalOrModified = saveMode == ConfigurationSaveMode.Minimal ||
+                               saveMode == ConfigurationSaveMode.Modified;
 
-                       foreach (PropertyInformation prop in source.ElementInformation.Properties)
+                       foreach (PropertyInformation prop in sourceElement.ElementInformation.Properties)
                        {
                                if (prop.ValueOrigin == PropertyValueOrigin.Default)
                                        continue;
@@ -562,7 +562,7 @@ namespace System.Configuration
                                PropertyInformation unmergedProp = ElementInformation.Properties [prop.Name];
                                
                                object sourceValue = prop.Value;
-                               if (parent == null || !parent.HasValue (prop.Name)) {
+                               if (parentElement == null || !parentElement.HasValue (prop.Name)) {
                                        unmergedProp.Value = sourceValue;
                                        continue;
                                }
@@ -570,26 +570,26 @@ namespace System.Configuration
                                if (sourceValue == null)
                                        continue;
 
-                               object parentValue = parent [prop.Name];
+                               object parentValue = parentElement [prop.Name];
                                if (!prop.IsElement) {
                                        if (!object.Equals (sourceValue, parentValue) || 
-                                           (updateMode == ConfigurationSaveMode.Full) ||
-                                           (updateMode == ConfigurationSaveMode.Modified && prop.ValueOrigin == PropertyValueOrigin.SetHere))
+                                           (saveMode == ConfigurationSaveMode.Full) ||
+                                           (saveMode == ConfigurationSaveMode.Modified && prop.ValueOrigin == PropertyValueOrigin.SetHere))
                                                unmergedProp.Value = sourceValue;
                                        continue;
                                }
 
-                               var sourceElement = (ConfigurationElement) sourceValue;
-                               if (isMinimalOrModified && !sourceElement.IsModified ())
+                               var sourceElementValue = (ConfigurationElement) sourceValue;
+                               if (isMinimalOrModified && !sourceElementValue.IsModified ())
                                        continue;
                                if (parentValue == null) {
                                        unmergedProp.Value = sourceValue;
                                        continue;
                                }
 
-                               var parentElement = (ConfigurationElement) parentValue;
+                               var parentElementValue = (ConfigurationElement) parentValue;
                                ConfigurationElement copy = (ConfigurationElement) unmergedProp.Value;
-                               copy.Unmerge (sourceElement, parentElement, updateMode);
+                               copy.Unmerge (sourceElementValue, parentElementValue, saveMode);
                        }
                }
                
index 6e379c87b9153222c541f65ea3cacf33c3561aed..c5a87877276f5cfd6de8e2f343b7fd986a4ca21b 100644 (file)
@@ -555,7 +555,7 @@ namespace System.Configuration
                        return false;
                }
                
-               protected internal override void Unmerge (ConfigurationElement sourceElement, ConfigurationElement parentElement, ConfigurationSaveMode updateMode)
+               protected internal override void Unmerge (ConfigurationElement sourceElement, ConfigurationElement parentElement, ConfigurationSaveMode saveMode)
                {
                        ConfigurationElementCollection source = (ConfigurationElementCollection) sourceElement;
                        ConfigurationElementCollection parent = (ConfigurationElementCollection) parentElement;
@@ -565,9 +565,9 @@ namespace System.Configuration
                                object key = source.GetElementKey (sitem);
                                ConfigurationElement pitem = parent != null ? parent.BaseGet (key) as ConfigurationElement : null;
                                ConfigurationElement nitem = CreateNewElementInternal (null);
-                               if (pitem != null && updateMode != ConfigurationSaveMode.Full) {
-                                       nitem.Unmerge (sitem, pitem, updateMode);
-                                       if (nitem.HasValues (pitem, updateMode))
+                               if (pitem != null && saveMode != ConfigurationSaveMode.Full) {
+                                       nitem.Unmerge (sitem, pitem, saveMode);
+                                       if (nitem.HasValues (pitem, saveMode))
                                                BaseAdd (nitem);
                                } else {
                                        nitem.Unmerge (sitem, null, ConfigurationSaveMode.Full);
@@ -575,7 +575,7 @@ namespace System.Configuration
                                }
                        }
                        
-                       if (updateMode == ConfigurationSaveMode.Full)
+                       if (saveMode == ConfigurationSaveMode.Full)
                                EmitClear = true;
                        else if (parent != null) {
                                for (int n=0; n<parent.Count; n++) {
index ec3738812310c8e3e9649b5a33d41af3353d9dd4..50b8406ae41fa0e0974ca20756b6506c81a74d0e 100644 (file)
@@ -49,60 +49,60 @@ namespace System.Configuration
                        : this (name, type, NoDefaultValue, TypeDescriptor.GetConverter (type), new DefaultValidator(), ConfigurationPropertyOptions.None, null)
                { }
 
-               public ConfigurationProperty (string name, Type type, object default_value)
-                       : this (name, type, default_value, TypeDescriptor.GetConverter (type), new DefaultValidator(), ConfigurationPropertyOptions.None, null)
+               public ConfigurationProperty (string name, Type type, object defaultValue)
+                       : this (name, type, defaultValue, TypeDescriptor.GetConverter (type), new DefaultValidator(), ConfigurationPropertyOptions.None, null)
                { }
 
                public ConfigurationProperty (
-                                       string name, Type type, object default_value,
-                                       ConfigurationPropertyOptions flags)
-                       :this (name, type, default_value, TypeDescriptor.GetConverter (type), new DefaultValidator(), flags, null)
+                                       string name, Type type, object defaultValue,
+                                       ConfigurationPropertyOptions options)
+                       :this (name, type, defaultValue, TypeDescriptor.GetConverter (type), new DefaultValidator(), options, null)
                { }
                
                public ConfigurationProperty (
-                                       string name, Type type, object default_value,
-                                       TypeConverter converter,
-                                       ConfigurationValidatorBase validation,
-                                       ConfigurationPropertyOptions flags)
-                       : this (name, type, default_value, converter, validation, flags, null)
+                                       string name, Type type, object defaultValue,
+                                       TypeConverter typeConverter,
+                                       ConfigurationValidatorBase validator,
+                                       ConfigurationPropertyOptions options)
+                       : this (name, type, defaultValue, typeConverter, validator, options, null)
                { }
 
                public ConfigurationProperty (
-                                       string name, Type type, object default_value,
-                                       TypeConverter converter,
-                                       ConfigurationValidatorBase validation,
-                                       ConfigurationPropertyOptions flags,
+                                       string name, Type type, object defaultValue,
+                                       TypeConverter typeConverter,
+                                       ConfigurationValidatorBase validator,
+                                       ConfigurationPropertyOptions options,
                                        string description)
                {
                        this.name = name;
-                       this.converter = converter != null ? converter : TypeDescriptor.GetConverter (type);
-                       if (default_value != null) {
-                               if (default_value == NoDefaultValue) {
+                       this.converter = typeConverter != null ? typeConverter : TypeDescriptor.GetConverter (type);
+                       if (defaultValue != null) {
+                               if (defaultValue == NoDefaultValue) {
                                        switch (Type.GetTypeCode (type)) {
                                        case TypeCode.Object:
-                                               default_value = null;
+                                               defaultValue = null;
                                                break;
                                        case TypeCode.String:
-                                               default_value = String.Empty;
+                                               defaultValue = String.Empty;
                                                break;
                                        default:
-                                               default_value = Activator.CreateInstance (type);
+                                               defaultValue = Activator.CreateInstance (type);
                                                break;
                                        }
                                }
                                else
-                                       if (!type.IsAssignableFrom (default_value.GetType ())) {
-                                               if (!this.converter.CanConvertFrom (default_value.GetType ()))
+                                       if (!type.IsAssignableFrom (defaultValue.GetType ())) {
+                                               if (!this.converter.CanConvertFrom (defaultValue.GetType ()))
                                                        throw new ConfigurationErrorsException (String.Format ("The default value for property '{0}' has a different type than the one of the property itself: expected {1} but was {2}",
-                                                                                                          name, type, default_value.GetType ()));
+                                                                                                          name, type, defaultValue.GetType ()));
 
-                                               default_value = this.converter.ConvertFrom (default_value);
+                                               defaultValue = this.converter.ConvertFrom (defaultValue);
                                        }
                        }
-                       this.default_value = default_value;
-                       this.flags = flags;
+                       this.default_value = defaultValue;
+                       this.flags = options;
                        this.type = type;
-                       this.validation = validation != null ? validation : new DefaultValidator ();
+                       this.validation = validator != null ? validator : new DefaultValidator ();
                        this.description = description;
                }
 
index add89b5bd3f5bb673ecf4f83b3866822c205f6ae..1412ede6e6a5222285e912683b603091b5bf6aed 100644 (file)
@@ -70,9 +70,9 @@ namespace System.Configuration
                }
 
                [MonoTODO]
-               public void ForceDeclaration (bool require)
+               public void ForceDeclaration (bool force)
                {
-                       this.require_declaration = require;
+                       this.require_declaration = force;
                }
 
                public void ForceDeclaration ()
index 7da715ce56b673905927aac7fa1ab18965da320d..8044246f229ad1fa20d6bff7ba3e59be90939a94 100644 (file)
@@ -41,13 +41,13 @@ namespace System.Configuration
                 {
                 }
 
-                public new ConnectionStringSettings this [string Name]
+                public new ConnectionStringSettings this [string name]
                 {
                         get {
                                 foreach (ConfigurationElement c in this) {
                                         if (!(c is ConnectionStringSettings))
                                                 continue;
-                                        if (string.Compare(((ConnectionStringSettings) c).Name, Name, true, 
+                                        if (string.Compare(((ConnectionStringSettings) c).Name, name, true, 
                                                 System.Globalization.CultureInfo.InvariantCulture) == 0)
                                                 return c as ConnectionStringSettings;
 
index 71fd65b193fcf99f29d2996059274a042ec0df96..6ac6b6b39fb1063f67d5418eafe08e0b352ab429 100644 (file)
@@ -38,7 +38,7 @@ namespace System.Configuration
 Protection API, and is unimplemented in Mono.  For portability's sake,
 it is suggested that you use the RsaProtectedConfigurationProvider.";
                [MonoNotSupported (NotSupportedReason)]
-               public override XmlNode Decrypt (XmlNode encrypted_node)
+               public override XmlNode Decrypt (XmlNode encryptedNode)
                {
                        throw new NotSupportedException (NotSupportedReason);
                }
index 0e6672df18b5bb10dc4b1c5ce3af88e5333c3ddd..09883818be557d2a61847686f9d0fe05bf0a8783 100644 (file)
@@ -54,15 +54,15 @@ namespace System.Configuration {
                        return false;
                }
 
-               protected internal override void DeserializeSection (XmlReader reader)
+               protected internal override void DeserializeSection (XmlReader xmlReader)
                {
-                       xml = reader.ReadOuterXml ();
+                       xml = xmlReader.ReadOuterXml ();
                }
 
                [MonoTODO]
-               protected internal override void Reset (ConfigurationElement parentElement)
+               protected internal override void Reset (ConfigurationElement parentSection)
                {
-                       base.Reset (parentElement);
+                       base.Reset (parentSection);
                }
 
                [MonoTODO]
@@ -71,7 +71,7 @@ namespace System.Configuration {
                        base.ResetModified ();
                }
 
-               protected internal override string SerializeSection (ConfigurationElement parentElement, string name, ConfigurationSaveMode saveMode)
+               protected internal override string SerializeSection (ConfigurationElement parentSection, string name, ConfigurationSaveMode saveMode)
                {
                        return xml;
                }
index aca0c163f02bcc4587b7a7223635fe172c732c5c..c957954115a5f3e09d1194311df59047e7ead3d1 100644 (file)
@@ -37,7 +37,7 @@ namespace System.Configuration
                {
                }
 
-               public abstract XmlNode Decrypt (XmlNode encrypted_node);
+               public abstract XmlNode Decrypt (XmlNode encryptedNode);
 
                public abstract XmlNode Encrypt (XmlNode node);
        }
index 6d4db6a0b077bb72ef79978599a6d32cfa999417..ea4d72cc12c022178a472d881db44b96110670e6 100644 (file)
@@ -89,10 +89,10 @@ namespace System.Configuration
 
                [MonoTODO]
                protected internal override void Unmerge (
-                               ConfigurationElement source, ConfigurationElement parent,
-                               ConfigurationSaveMode updateMode)
+                               ConfigurationElement sourceElement, ConfigurationElement parentElement,
+                               ConfigurationSaveMode saveMode)
                {
-                       base.Unmerge (source, parent, updateMode);
+                       base.Unmerge (sourceElement, parentElement, saveMode);
                }
                
                [ConfigurationProperty ("name", Options = ConfigurationPropertyOptions.IsRequired | ConfigurationPropertyOptions.IsKey)]
index 25bbc3a41f4094a9e51b3fa36898319bfe5290db..f115cd2a3c97e9d498eac667706ed7c2a4c47c24 100644 (file)
@@ -58,15 +58,15 @@ namespace System.Configuration
                        return ((ProviderSettings)element).Name;
                }
                
-               public void Remove (string key)
+               public void Remove (string name)
                {
-                       BaseRemove (key);
+                       BaseRemove (name);
                }
                
-               public ProviderSettings this [int n]
+               public ProviderSettings this [int index]
                {
-                       get { return (ProviderSettings) BaseGet (n); }
-                       set { BaseAdd (n, value); }
+                       get { return (ProviderSettings) BaseGet (index); }
+                       set { BaseAdd (index, value); }
                }
                
                public new ProviderSettings this [string key]
index bbb0eea08b302223ce6347cb7ad559d2f2fe5f2d..d20a75195648e899c2fc53c81516d767b6eb782f 100644 (file)
@@ -63,11 +63,11 @@ namespace System.Configuration
                }
 
                [MonoTODO]
-               public override XmlNode Decrypt (XmlNode encrypted_node)
+               public override XmlNode Decrypt (XmlNode encryptedNode)
                {
                        XmlDocument doc = new ConfigurationXmlDocument ();
                        
-                       doc.Load (new StringReader (encrypted_node.OuterXml));
+                       doc.Load (new StringReader (encryptedNode.OuterXml));
 
                        EncryptedXml ex = new EncryptedXml (doc);
 
index f05406c4b5bf19f22054bca318f66cdef8f87a2a..5bbf19f1fa0b4a24bcd457dcdea0adf0ae4f424e 100644 (file)
@@ -175,13 +175,13 @@ namespace System.Configuration
                        return raw_xml;
                }
 
-               public void ProtectSection (string provider)
+               public void ProtectSection (string protectionProvider)
                {
-                       protection_provider = ProtectedConfiguration.GetProvider (provider, true);
+                       protection_provider = ProtectedConfiguration.GetProvider (protectionProvider, true);
                }
 
                [MonoTODO]
-               public void ForceDeclaration (bool require)
+               public void ForceDeclaration (bool force)
                {
                }
 
@@ -201,9 +201,9 @@ namespace System.Configuration
                        protection_provider = null;
                }
 
-               public void SetRawXml (string xml)
+               public void SetRawXml (string rawXml)
                {
-                       raw_xml = xml;
+                       raw_xml = rawXml;
                }
 
                [MonoTODO]
index 4713a1d4a373cd0530ba6431a1367ef609149b1b..7233b87d5132f4cee0fd3b47816c25d54c118339 100644 (file)
@@ -30,6 +30,6 @@ using System;
 using System.IO;
 
 namespace System.Configuration {
-       public delegate void ValidatorCallback (object o);
+       public delegate void ValidatorCallback (object value);
 }
 
index 7dc7a62e7dd8c3df4024d1ff97d42b0cf5c3f1cc..0b05a53f089ffc27e41ce937fe86894317f83d0d 100644 (file)
@@ -51,18 +51,18 @@ namespace System.Security.Cryptography {
                        KeyValue = KeyBuilder.Key (KeySizeValue >> 3);
                }
                
-               public override ICryptoTransform CreateDecryptor (byte[] rgbKey, byte[] rgbIV
+               public override ICryptoTransform CreateDecryptor (byte[] key, byte[] iv
                {
                        if ((Mode == CipherMode.CFB) && (FeedbackSize > 64))
                                throw new CryptographicException ("CFB with Feedbaack > 64 bits");
-                       return new AesTransform (this, false, rgbKey, rgbIV);
+                       return new AesTransform (this, false, key, iv);
                }
                
-               public override ICryptoTransform CreateEncryptor (byte[] rgbKey, byte[] rgbIV
+               public override ICryptoTransform CreateEncryptor (byte[] key, byte[] iv
                {
                        if ((Mode == CipherMode.CFB) && (FeedbackSize > 64))
                                throw new CryptographicException ("CFB with Feedbaack > 64 bits");
-                       return new AesTransform (this, true, rgbKey, rgbIV);
+                       return new AesTransform (this, true, key, iv);
                }
 
                // I suppose some attributes differs ?!? because this does not look required
index acef0f904787c5d6f670ef532e27b7ee545c8fc0..db68b96777b3473655a9a97785e4452b77f7157f 100644 (file)
@@ -192,12 +192,12 @@ namespace DbLinq.Data.Linq
         /// </summary>\r
         /// <param name="connectionString">specifies file or server connection</param>\r
         [DbLinqToDo]\r
-        public DataContext(string connectionString)\r
+        public DataContext(string fileOrServerOrConnection)\r
         {\r
             Profiler.At("START DataContext(string)");\r
-            IVendor ivendor = GetVendor(ref connectionString);\r
+            IVendor ivendor = GetVendor(ref fileOrServerOrConnection);\r
 \r
-            IDbConnection dbConnection = ivendor.CreateDbConnection(connectionString);\r
+            IDbConnection dbConnection = ivendor.CreateDbConnection(fileOrServerOrConnection);\r
             Init(new DatabaseContext(dbConnection), null, ivendor);\r
 \r
             Profiler.At("END DataContext(string)");\r
index 26fce3ab35bca21a6fb912b81fd57a357a1a8fe4..b4467919cee20ef63d4c5c2dcba846c9eb69f094 100644 (file)
@@ -1,4 +1,4 @@
-//
+//
 // System.Data.OracleClient.OracleCommandBuilder.cs
 //
 // based on the SqlCommandBuilder in mcs/class/System.Data/System.Data.SqlClient
@@ -490,8 +490,8 @@ namespace System.Data.OracleClient {
                }
 
                 [MonoTODO]
-                protected override void ApplyParameterInfo (DbParameter dbParameter,
-                                                           DataRow row,
+                protected override void ApplyParameterInfo (DbParameter parameter,
+                                                           DataRow datarow,
                                                            StatementType statementType,
                                                            bool whereClause)
                 {
@@ -499,7 +499,7 @@ namespace System.Data.OracleClient {
                 }
 
                 [MonoTODO]
-                protected override string GetParameterName (int position)
+                protected override string GetParameterName (int parameterOrdinal)
                 {
                         throw new NotImplementedException ();
                 }
@@ -511,7 +511,7 @@ namespace System.Data.OracleClient {
                 }
 
                 [MonoTODO]
-                protected override string GetParameterPlaceholder (int position)
+                protected override string GetParameterPlaceholder (int parameterOrdinal)
                 {
                         throw new NotImplementedException ();
                 }
index ff5dc821d854f550cd59f6b5ab6be1db6207fb17..40ccb46eb118fc587d7357d9b90c1078fbea852e 100644 (file)
@@ -126,10 +126,10 @@ namespace System.Data.SqlClient
                        ConnectionString = connectionString;
                }
 
-               public SqlConnection (string connectionString, SqlCredential cred)
+               public SqlConnection (string connectionString, SqlCredential credential)
                {
                        ConnectionString = connectionString;
-                       Credentials = cred;
+                       Credentials = credential;
                }
 
                #endregion // Constructors
index 5b15b48cb66d28b53be95809b6a2cedb2d54ed5f..0bc80680560b4add463011e433f2505c99be0d47 100644 (file)
@@ -49,13 +49,13 @@ namespace System.Data.SqlClient {
 
                #region Constructors
 
-               public SqlCredential (string user, SecureString password)
+               public SqlCredential (string userId, SecureString password)
                {
-                       if (user == null)
-                               throw new ArgumentNullException("UserID");
+                       if (userId == null)
+                               throw new ArgumentNullException("userId");
                        if (password == null)
-                               throw new ArgumentNullException("Password");
-                       this.uid = user;
+                               throw new ArgumentNullException("password");
+                       this.uid = userId;
                        this.pwd = password;
                }
 
index c80fb2a16e4ee20291584e2d01805c8c9df28985..cbf257234a78565aed5f2f8a6eae698bfebe3705 100644 (file)
@@ -1,5 +1,5 @@
 Assembly/AssemblyInfo.cs
-../../build/common/Consts.cs.in
+../../build/common/Consts.cs
 ../../build/common/Locale.cs
 ../../build/common/SR.cs
 ../../build/common/MonoTODOAttribute.cs
index b3f8ec5e785eee7a51134c14f3344daa4d0a1e87..c4e3d6517d4094f780378063f1b11a36ba85d93b 100644 (file)
@@ -101,47 +101,47 @@ namespace System.ComponentModel.Design.Serialization
                }
 
                public virtual CodeStatementCollection SerializeMember (IDesignerSerializationManager manager, 
-                                                                       object owningobject, MemberDescriptor member)
+                                                                       object owningObject, MemberDescriptor member)
                {
                        if (member == null)
                                throw new ArgumentNullException ("member");
-                       if (owningobject == null)
-                               throw new ArgumentNullException ("owningobject");
+                       if (owningObject == null)
+                               throw new ArgumentNullException ("owningObject");
                        if (manager == null)
                                throw new ArgumentNullException ("manager");
 
                        CodeStatementCollection statements = new CodeStatementCollection ();
 
-                       CodeExpression expression = base.GetExpression (manager, owningobject);
+                       CodeExpression expression = base.GetExpression (manager, owningObject);
                        if (expression == null) {
-                               string name = manager.GetName (owningobject);
+                               string name = manager.GetName (owningObject);
                                if (name == null)
-                                       name = base.GetUniqueName (manager, owningobject);
+                                       name = base.GetUniqueName (manager, owningObject);
                                expression = new CodeVariableReferenceExpression (name);
-                               base.SetExpression (manager, owningobject, expression);
+                               base.SetExpression (manager, owningObject, expression);
                        }
 
                        if (member is PropertyDescriptor)
-                               base.SerializeProperty (manager, statements, owningobject, (PropertyDescriptor) member);
+                               base.SerializeProperty (manager, statements, owningObject, (PropertyDescriptor) member);
                        if (member is EventDescriptor)
-                               base.SerializeEvent (manager, statements, owningobject, (EventDescriptor) member);
+                               base.SerializeEvent (manager, statements, owningObject, (EventDescriptor) member);
 
                        return statements;
                }
 
                public virtual CodeStatementCollection SerializeMemberAbsolute (IDesignerSerializationManager manager, 
-                                                                               object owningobject, MemberDescriptor member)
+                                                                               object owningObject, MemberDescriptor member)
                {
                        if (member == null)
                                throw new ArgumentNullException ("member");
-                       if (owningobject == null)
-                               throw new ArgumentNullException ("owningobject");
+                       if (owningObject == null)
+                               throw new ArgumentNullException ("owningObject");
                        if (manager == null)
                                throw new ArgumentNullException ("manager");
 
                        SerializeAbsoluteContext context = new SerializeAbsoluteContext (member);
                        manager.Context.Push (context);
-                       CodeStatementCollection result = this.SerializeMember (manager, owningobject, member);
+                       CodeStatementCollection result = this.SerializeMember (manager, owningObject, member);
                        manager.Context.Pop ();
                        return result;
                }
index 37a07439dc8c1525874742705feb9bedd0f28a96..46818dfa6c00201200a515bb2241e5b2f66e63dc 100644 (file)
@@ -67,18 +67,18 @@ namespace System.ComponentModel.Design.Serialization
                {
                }
 
-               protected CodeExpression SerializeToExpression (IDesignerSerializationManager manager, object instance)
+               protected CodeExpression SerializeToExpression (IDesignerSerializationManager manager, object value)
                {
                        if (manager == null)
                                throw new ArgumentNullException ("manager");
 
                        CodeExpression expression = null;
-                       if (instance != null)
-                               expression = this.GetExpression (manager, instance); // 1 - IDesignerSerializationManager.GetExpression
+                       if (value != null)
+                               expression = this.GetExpression (manager, value); // 1 - IDesignerSerializationManager.GetExpression
                        if (expression == null) {
-                               CodeDomSerializer serializer = this.GetSerializer (manager, instance); // 2 - manager.GetSerializer().Serialize()
+                               CodeDomSerializer serializer = this.GetSerializer (manager, value); // 2 - manager.GetSerializer().Serialize()
                                if (serializer != null) {
-                                       object serialized = serializer.Serialize (manager, instance);
+                                       object serialized = serializer.Serialize (manager, value);
                                        expression = serialized as CodeExpression; // 3 - CodeStatement or CodeStatementCollection
                                        if (expression == null) {
                                                CodeStatement statement = serialized as CodeStatement;
@@ -88,8 +88,8 @@ namespace System.ComponentModel.Design.Serialization
                                                        CodeStatementCollection contextStatements = null;
 
                                                        StatementContext context = manager.Context[typeof (StatementContext)] as StatementContext;
-                                                       if (context != null && instance != null)
-                                                               contextStatements = context.StatementCollection[instance];
+                                                       if (context != null && value != null)
+                                                               contextStatements = context.StatementCollection[value];
 
                                                        if (contextStatements == null)
                                                                contextStatements = manager.Context[typeof (CodeStatementCollection)] as CodeStatementCollection;
@@ -102,25 +102,25 @@ namespace System.ComponentModel.Design.Serialization
                                                        }
                                                }
                                        }
-                                       if (expression == null && instance != null)
-                                               expression = this.GetExpression (manager, instance); // 4
+                                       if (expression == null && value != null)
+                                               expression = this.GetExpression (manager, value); // 4
                                } else {
-                                       ReportError (manager, "No serializer found for type '" + instance.GetType ().Name + "'");
+                                       ReportError (manager, "No serializer found for type '" + value.GetType ().Name + "'");
                                }
                        }
                        return expression;
                }
 
-               protected CodeDomSerializer GetSerializer (IDesignerSerializationManager manager, object instance)
+               protected CodeDomSerializer GetSerializer (IDesignerSerializationManager manager, object value)
                {
                        DesignerSerializerAttribute attrInstance, attrType;
                        attrType = attrInstance = null;
 
                        CodeDomSerializer serializer = null;
-                       if (instance == null)
+                       if (value == null)
                                serializer = this.GetSerializer (manager, null);
                        else {          
-                               AttributeCollection attributes = TypeDescriptor.GetAttributes (instance);
+                               AttributeCollection attributes = TypeDescriptor.GetAttributes (value);
                                foreach (Attribute a in attributes) {
                                        DesignerSerializerAttribute designerAttr = a as DesignerSerializerAttribute;
                                        if (designerAttr != null && manager.GetType (designerAttr.SerializerBaseTypeName) == typeof (CodeDomSerializer)) {
@@ -129,7 +129,7 @@ namespace System.ComponentModel.Design.Serialization
                                        }
                                }
        
-                               attributes = TypeDescriptor.GetAttributes (instance.GetType ());
+                               attributes = TypeDescriptor.GetAttributes (value.GetType ());
                                foreach (Attribute a in attributes) {
                                        DesignerSerializerAttribute designerAttr = a as DesignerSerializerAttribute;
                                        if (designerAttr != null && manager.GetType (designerAttr.SerializerBaseTypeName) == typeof (CodeDomSerializer)) {
@@ -143,47 +143,47 @@ namespace System.ComponentModel.Design.Serialization
                                if (attrType != null && attrInstance != null && attrType.SerializerTypeName != attrInstance.SerializerTypeName)
                                        serializer = Activator.CreateInstance (manager.GetType (attrInstance.SerializerTypeName)) as CodeDomSerializer;
                                else
-                                       serializer = this.GetSerializer (manager, instance.GetType ());
+                                       serializer = this.GetSerializer (manager, value.GetType ());
                        }
 
                        return serializer;
                }
 
-               protected CodeDomSerializer GetSerializer (IDesignerSerializationManager manager, Type instanceType)
+               protected CodeDomSerializer GetSerializer (IDesignerSerializationManager manager, Type valueType)
                {
-                       return manager.GetSerializer (instanceType, typeof (CodeDomSerializer)) as CodeDomSerializer;
+                       return manager.GetSerializer (valueType, typeof (CodeDomSerializer)) as CodeDomSerializer;
                }
 
-               protected CodeExpression GetExpression (IDesignerSerializationManager manager, object instance)
+               protected CodeExpression GetExpression (IDesignerSerializationManager manager, object value)
                {
                        if (manager == null)
                                throw new ArgumentNullException ("manager");
-                       if (instance == null)
-                               throw new ArgumentNullException ("instance");
+                       if (value == null)
+                               throw new ArgumentNullException ("value");
 
                        CodeExpression expression = null;
 
                        ExpressionTable expressions = manager.Context[typeof (ExpressionTable)] as ExpressionTable;
                        if (expressions != null) // 1st try: ExpressionTable
-                               expression = expressions [instance] as CodeExpression;
+                               expression = expressions [value] as CodeExpression;
 
                        if (expression == null) { // 2nd try: RootContext
                                RootContext context = manager.Context[typeof (RootContext)] as RootContext;
-                               if (context != null && context.Value == instance)
+                               if (context != null && context.Value == value)
                                        expression = context.Expression;
                        }
 
                        if (expression == null) { // 3rd try: IReferenceService (instance.property.property.property
-                               string name = manager.GetName (instance);
+                               string name = manager.GetName (value);
                                if (name == null || name.IndexOf (".") == -1) {
                                        IReferenceService service = manager.GetService (typeof (IReferenceService)) as IReferenceService;
                                        if (service != null) {
-                                               name = service.GetName (instance);
+                                               name = service.GetName (value);
                                                if (name != null && name.IndexOf (".") != -1) {
                                                        string[] parts = name.Split (new char[] { ',' });
-                                                       instance = manager.GetInstance (parts[0]);
-                                                       if (instance != null) {
-                                                               expression = SerializeToExpression (manager, instance);
+                                                       value = manager.GetInstance (parts[0]);
+                                                       if (value != null) {
+                                                               expression = SerializeToExpression (manager, value);
                                                                if (expression != null) {
                                                                        for (int i=1; i < parts.Length; i++)
                                                                                expression = new CodePropertyReferenceExpression (expression, parts[i]);
@@ -196,19 +196,19 @@ namespace System.ComponentModel.Design.Serialization
                        return expression;
                }
 
-               protected void SetExpression (IDesignerSerializationManager manager, object instance, CodeExpression expression)
+               protected void SetExpression (IDesignerSerializationManager manager, object value, CodeExpression expression)
                {
-                       SetExpression (manager, instance, expression, false);
+                       SetExpression (manager, value, expression, false);
                }
 
                // XXX: isPreset - what does this do when set?
                //
-               protected void SetExpression (IDesignerSerializationManager manager, object instance, CodeExpression expression, bool isPreset)
+               protected void SetExpression (IDesignerSerializationManager manager, object value, CodeExpression expression, bool isPreset)
                {
                        if (manager == null)
                                throw new ArgumentNullException ("manager");
-                       if (instance == null)
-                               throw new ArgumentNullException ("instance");
+                       if (value == null)
+                               throw new ArgumentNullException ("value");
                        if (expression == null)
                                throw new ArgumentNullException ("expression");
 
@@ -218,7 +218,7 @@ namespace System.ComponentModel.Design.Serialization
                                manager.Context.Append (expressions);
                        }
 
-                       expressions[instance] = expression;
+                       expressions[value] = expression;
                }
 
                protected bool IsSerialized (IDesignerSerializationManager manager, object value) 
@@ -227,14 +227,14 @@ namespace System.ComponentModel.Design.Serialization
                }
 
                // XXX: What should honorPreset do?
-               protected bool IsSerialized (IDesignerSerializationManager manager, object instance, bool honorPreset) 
+               protected bool IsSerialized (IDesignerSerializationManager manager, object value, bool honorPreset) 
                {
-                       if (instance == null)
-                               throw new ArgumentNullException ("instance");
+                       if (value == null)
+                               throw new ArgumentNullException ("value");
                        if (manager == null)
                                throw new ArgumentNullException ("manager");
 
-                       if (this.GetExpression (manager, instance) != null)
+                       if (this.GetExpression (manager, value) != null)
                                return true;
                        else
                                return false;
@@ -390,20 +390,20 @@ namespace System.ComponentModel.Design.Serialization
                        return manager.CreateInstance (type, parameters, name, addToContainer);
                }
 
-               protected string GetUniqueName (IDesignerSerializationManager manager, object instance)
+               protected string GetUniqueName (IDesignerSerializationManager manager, object value)
                {
-                       if (instance == null)
-                               throw new ArgumentNullException ("instance");
+                       if (value == null)
+                               throw new ArgumentNullException ("value");
                        if (manager == null)
                                throw new ArgumentNullException ("manager");
 
-                       string name = manager.GetName (instance);
+                       string name = manager.GetName (value);
                        if (name == null) {
                                INameCreationService service = manager.GetService (typeof (INameCreationService)) as INameCreationService;
-                               name = service.CreateName (null, instance.GetType ());
+                               name = service.CreateName (null, value.GetType ());
                                if (name == null)
-                                       name = instance.GetType ().Name.ToLower ();
-                               manager.SetName (instance, name);
+                                       name = value.GetType ().Name.ToLower ();
+                               manager.SetName (value, name);
                        }
                        return name;
                }
index 777d9ed18be09149573c4925b8fb62fb6cb51646..937fb3b0e75ffa2e5883ed953523bc53fd930c73 100644 (file)
@@ -220,7 +220,7 @@ namespace System.ComponentModel.Design.Serialization
                        return instance;
                }
 
-               public object GetSerializer (Type componentType, Type serializerType)
+               public object GetSerializer (Type objectType, Type serializerType)
                {
                        VerifyInSession ();
                        
@@ -229,17 +229,17 @@ namespace System.ComponentModel.Design.Serialization
                                
                        object serializer = null;
 
-                       if (componentType != null) {
+                       if (objectType != null) {
                                // try 1: from cache
                                //
-                               _serializersCache.TryGetValue (componentType, out serializer);
+                               _serializersCache.TryGetValue (objectType, out serializer);
 
                                // check for provider attribute and add it to the list of providers
                                //
                                if (serializer != null && !serializerType.IsAssignableFrom (serializer.GetType ()))
                                        serializer = null;
                                
-                               AttributeCollection attributes = TypeDescriptor.GetAttributes (componentType);
+                               AttributeCollection attributes = TypeDescriptor.GetAttributes (objectType);
                                DefaultSerializationProviderAttribute providerAttribute = attributes[typeof (DefaultSerializationProviderAttribute)] 
                                                                                                                                                           as DefaultSerializationProviderAttribute;
                                if (providerAttribute != null && this.GetType (providerAttribute.ProviderTypeName) == serializerType) {
@@ -252,8 +252,8 @@ namespace System.ComponentModel.Design.Serialization
 
                        // try 2: DesignerSerializerAttribute
                        //
-                       if (serializer == null && componentType != null) {
-                               AttributeCollection attributes = TypeDescriptor.GetAttributes (componentType);
+                       if (serializer == null && objectType != null) {
+                               AttributeCollection attributes = TypeDescriptor.GetAttributes (objectType);
                                DesignerSerializerAttribute serializerAttribute = attributes[typeof (DesignerSerializerAttribute)] as DesignerSerializerAttribute;
                                if (serializerAttribute != null && 
                                        this.GetType (serializerAttribute.SerializerBaseTypeName) == serializerType) {
@@ -266,14 +266,14 @@ namespace System.ComponentModel.Design.Serialization
                                }
                                
                                if (serializer != null)
-                                       _serializersCache[componentType] = serializer;
+                                       _serializersCache[objectType] = serializer;
                        }
 
                        // try 3: from provider
                        //
                        if (serializer == null && _serializationProviders != null) {
                                foreach (IDesignerSerializationProvider provider in _serializationProviders) {
-                                       serializer = provider.GetSerializer (this, null, componentType, serializerType);
+                                       serializer = provider.GetSerializer (this, null, objectType, serializerType);
                                        if (serializer != null)
                                                break;
                                }
@@ -332,19 +332,19 @@ namespace System.ComponentModel.Design.Serialization
                                _serializationCompleteHandler (this, EventArgs.Empty);
                }
                                
-               protected virtual Type GetType (string name)
+               protected virtual Type GetType (string typeName)
                {
-                       if (name == null)
-                               throw new ArgumentNullException ("name");
+                       if (typeName == null)
+                               throw new ArgumentNullException ("typeName");
                        
                        this.VerifyInSession ();
                        
                        Type result = null;
                        ITypeResolutionService typeResSvc = this.GetService (typeof (ITypeResolutionService)) as ITypeResolutionService;
                        if (typeResSvc != null)
-                               result = typeResSvc.GetType (name);
+                               result = typeResSvc.GetType (typeName);
                        if (result == null)
-                               result = Type.GetType (name);
+                               result = Type.GetType (typeName);
                        
                        return result;
                }
@@ -491,16 +491,16 @@ namespace System.ComponentModel.Design.Serialization
                }         
 #endregion
                
-               object IServiceProvider.GetService (Type service)
+               object IServiceProvider.GetService (Type serviceType)
                {
-                       return this.GetService (service);
+                       return this.GetService (serviceType);
                }
                
-               protected virtual object GetService (Type service)
+               protected virtual object GetService (Type serviceType)
                {
                        object result = null;
                        if (_serviceProvider != null)
-                               result = _serviceProvider.GetService (service);
+                               result = _serviceProvider.GetService (serviceType);
                        
                        return result;
                }
index 1961d840d7e9d31b6a765e4991bbf6b482791e9e..5712ddc249d3202599b41aa7df8dc70261c73e88 100644 (file)
@@ -54,9 +54,9 @@ namespace System.ComponentModel.Design.Serialization
                        return _statements.GetEnumerator ();
                }
 
-               public CodeStatementCollection this[object owner]
+               public CodeStatementCollection this[object statementOwner]
                {
-                       get { return _statements[owner] as CodeStatementCollection; }
+                       get { return _statements[statementOwner] as CodeStatementCollection; }
                }
 
                IEnumerator IEnumerable.GetEnumerator()
index 77f284dad48dab55e8c788068a4147d253e56ac9..a476a2ab6b0deec4c047dd58bee937eee16132ce 100644 (file)
@@ -40,13 +40,13 @@ namespace System.ComponentModel.Design.Serialization
                CodeExpression _expression;
                object _value;
 
-               public RootContext (CodeExpression expresion, object value)
+               public RootContext (CodeExpression expression, object value)
                {
-                       if (expresion == null)
+                       if (expression == null)
                                throw new ArgumentNullException ("expression");
                        if (value == null)
                                throw new ArgumentNullException ("value");
-                       _expression = expresion;
+                       _expression = expression;
                        _value = value;
                }
 
index 4362e35f110ad3fceff50c7f19777ea07c036e78..45b11116cc1d10bbec4bf3c39ba4eb5c2954e1d4 100644 (file)
@@ -408,10 +408,10 @@ namespace System.ComponentModel.Design
 
                // Helper method - not an ISerivceProvider
                //
-               protected virtual object GetService (Type service)
+               protected virtual object GetService (Type serviceType)
                {
                        if (_component != null && _component.Site != null)
-                               return _component.Site.GetService (service);
+                               return _component.Site.GetService (serviceType);
 
                        return null;
                }
index 38d1a604c06117f34cde38f6d5f1d8015f32928e..0a0d67474183ebc5b95351f61e94a4ca52ff9f0f 100644 (file)
@@ -73,9 +73,9 @@ namespace System.ComponentModel.Design
                {
                }
 
-               public DesignSurfaceManager (IServiceProvider serviceProvider)
+               public DesignSurfaceManager (IServiceProvider parentProvider)
                {
-                       _parentProvider = serviceProvider;
+                       _parentProvider = parentProvider;
                        this.ServiceContainer.AddService (typeof (IDesignerEventService), new DesignerEventService ());
                }
 
@@ -224,10 +224,10 @@ namespace System.ComponentModel.Design
                                
                }
                
-               public object GetService (Type service)
+               public object GetService (Type serviceType)
                {
                        if (_serviceContainer != null)
-                               return _serviceContainer.GetService (service);
+                               return _serviceContainer.GetService (serviceType);
 
                        return null;
                }
index 3eb602c5b141971bdabd9db0334541bbf7e24002..c2f5535b9a9bef70fddae9afb2b7ef6631b5f4b0 100644 (file)
@@ -50,8 +50,8 @@ namespace System.ComponentModel.Design
                protected abstract bool ShowCode (IComponent component, EventDescriptor e, string methodName);
                protected abstract bool ShowCode (int lineNumber);
                protected abstract bool ShowCode ();
-               protected abstract string CreateUniqueMethodName (IComponent component, EventDescriptor eventDescriptor);
-               protected abstract ICollection GetCompatibleMethods (EventDescriptor eventDescriptor);
+               protected abstract string CreateUniqueMethodName (IComponent component, EventDescriptor e);
+               protected abstract ICollection GetCompatibleMethods (EventDescriptor e);
 
                protected virtual void FreeMethod (IComponent component, EventDescriptor e, string methodName)
                {
@@ -67,10 +67,10 @@ namespace System.ComponentModel.Design
                }
  
 
-               protected object GetService (Type service)
+               protected object GetService (Type serviceType)
                {
                        if (_provider != null)
-                               return _provider.GetService (service);
+                               return _provider.GetService (serviceType);
                        return null;
                }
 
index cb6f015cf1bee987d834ae4a4f713727abffc4cf..8a4e797d9962802d0172f1af046cb56936c8867d 100644 (file)
@@ -210,12 +210,12 @@ namespace System.ComponentModel.Design
                        return false;
                }
 
-               public virtual bool GlobalInvoke (CommandID commandID, object arg)
+               public virtual bool GlobalInvoke (CommandID commandId, object arg)
                {
-                       if (commandID == null)
-                               throw new ArgumentNullException ("commandID");
+                       if (commandId == null)
+                               throw new ArgumentNullException ("commandId");
 
-                       MenuCommand command = this.FindCommand (commandID);
+                       MenuCommand command = this.FindCommand (commandId);
                        if (command != null) {
                                command.Invoke (arg);
                                return true;
index 61cd66cea52c1dc5675004bdfd07221bfd4043b9..f442854a3f189c097296f5ed822a144b94b72b02 100644 (file)
@@ -66,12 +66,12 @@ namespace System.Data.Design {
                                errorList.Add (info.GetString("KEY_ARRAYVALUES" + i));
                }
 
-               public TypedDataSetGeneratorException (String error) : base (error)
+               public TypedDataSetGeneratorException (String message) : base (message)
                {
                }
                
-               public TypedDataSetGeneratorException (String error, Exception inner
-                       : base (error, inner)
+               public TypedDataSetGeneratorException (String message, Exception innerException
+                       : base (message, innerException)
                {
                }
                #endregion //Constructors       
@@ -82,15 +82,15 @@ namespace System.Data.Design {
 
                #region Methods
                                                                                                     
-                public override void GetObjectData (SerializationInfo si, StreamingContext context)
+                public override void GetObjectData (SerializationInfo info, StreamingContext context)
                 {
-                       base.GetObjectData (si, context);
+                       base.GetObjectData (info, context);
                                                 
                        int count = (errorList != null) ? ErrorList.Count : 0;
-                       si.AddValue ("KEY_ARRAYCOUNT", count);
+                       info.AddValue ("KEY_ARRAYCOUNT", count);
 
                        for (int i=0; i < count; i++)
-                               si.AddValue("KEY_ARRAYVALUES" + i, ErrorList [i]);
+                               info.AddValue("KEY_ARRAYVALUES" + i, ErrorList [i]);
                 }
                                                                                                     
                 #endregion // Methods
index 5fba73eab9fdd432168c23fdd98a69d007a0eb11..8b2b9d60fce64ab13ee7653b5c0e229d46253152 100644 (file)
@@ -35,9 +35,9 @@ namespace System.Web.UI.Design.WebControls {
        {
                int initial_page;
 
-               public BaseDataListComponentEditor (int initial_page)
+               public BaseDataListComponentEditor (int initialPage)
                {
-                       this.initial_page = initial_page;
+                       this.initial_page = initialPage;
                }
 
                public override bool EditComponent (
index 22f9b85c0391147585ebd17acc3afe22f59a4530..5e9a0f2653e7944305348f1a6a9ebfa74fe0e2bf 100644 (file)
@@ -74,16 +74,16 @@ namespace System.Web.UI.Design.WebControls {
                }
 
                protected IEnumerable GetDesignTimeDataSource (
-                       int minimum_rows,
-                       out bool dummy_data_source)
+                       int minimumRows,
+                       out bool dummyDataSource)
                {
                        throw new NotImplementedException ();
                }
 
                protected IEnumerable GetDesignTimeDataSource (
-                       IEnumerable selected_data_source,
-                       int minimum_rows,
-                       out bool dummy_data_source)
+                       IEnumerable selectedDataSource,
+                       int minimumRows,
+                       out bool dummyDataSource)
                {
                        throw new NotImplementedException ();
                }
@@ -98,7 +98,7 @@ namespace System.Web.UI.Design.WebControls {
                        throw new NotImplementedException ();
                }
 
-               public override IEnumerable GetTemplateContainerDataSource (string template_name)
+               public override IEnumerable GetTemplateContainerDataSource (string templateName)
                {
                        throw new NotImplementedException ();
                }
@@ -108,7 +108,7 @@ namespace System.Web.UI.Design.WebControls {
                        throw new NotImplementedException ();
                }
 
-               protected internal void InvokePropertyBuilder (int initial_page)
+               protected internal void InvokePropertyBuilder (int initialPage)
                {
                        throw new NotImplementedException ();
                }
index 59bdb670f4ba369c125dacb172b4d0c4689cd8e5..96f54b622f2574f788c14fc2142af482585b2342 100644 (file)
@@ -38,8 +38,8 @@ namespace System.Web.UI.Design.WebControls {
                {
                }
 
-               public DataListComponentEditor (int initial_page)
-                       : base (initial_page)
+               public DataListComponentEditor (int initialPage)
+                       : base (initialPage)
                {
                }
 
index 3442c86eeae5a64f1bfa4f9ba2f6aea7b08b3166..755dadcca377d9cd25ad01015cb116c35afc1472 100644 (file)
@@ -38,7 +38,7 @@ namespace System.Web.UI.Design.WebControls {
                        throw new NotImplementedException ();
                }
 
-               public override void DataBindControl (IDesignerHost designer_host, Control control)
+               public override void DataBindControl (IDesignerHost designerHost, Control control)
                {
                        throw new NotImplementedException ();
                }
index 918b650f1ac07a9da576cfdab8606d12d5d9d269..4e057a6adb27ca59cfa9122c41ee34b77c2666a5 100644 (file)
@@ -37,7 +37,7 @@ namespace System.Web.UI.Design.WebControls {
                {
                }
 
-               protected override void MapPropertyToStyle (string name, object value)
+               protected override void MapPropertyToStyle (string propName, object varPropValue)
                {
                        throw new NotImplementedException ();
                }
index 8f6314559c4d5a3e2e3f468f7729857c7531655b..81d53cbca219b52fc954155bf7bf338384656741 100644 (file)
@@ -63,14 +63,14 @@ namespace System.Web.UI.Design.WebControls {
                        throw new NotImplementedException ();
                }
 
-               protected IEnumerable GetDesignTimeDataSource (int minimum_rows)
+               protected IEnumerable GetDesignTimeDataSource (int minimumRows)
                {
                        throw new NotImplementedException ();
                }
 
                protected IEnumerable GetDesignTimeDataSource (
-                       IEnumerable selected_data_source,
-                       int minimum_rows)
+                       IEnumerable selectedDataSource,
+                       int minimumRows)
                {
                        throw new NotImplementedException ();
                }
@@ -105,7 +105,7 @@ namespace System.Web.UI.Design.WebControls {
                        throw new NotImplementedException ();
                }
 
-               public override void OnComponentChanged (object sender, ComponentChangedEventArgs e)
+               public override void OnComponentChanged (object source, ComponentChangedEventArgs ce)
                {
                        throw new NotImplementedException ();
                }
index 4cbd0cefcd7f21553874a337742fe3ab1e1d1e5d..dc949952f919056c4330c7c25518d5e4e7a699cc 100644 (file)
@@ -42,7 +42,7 @@ namespace System.Web.UI.Design.WebControls {
                        throw new NotImplementedException ();
                }
 
-               protected override object CreateInstance (Type item_type)
+               protected override object CreateInstance (Type itemType)
                {
                        throw new NotImplementedException ();
                }
index 1961b98f073409a2ef0a95862744b5f447936e95..c7865dcf91131f4ed0969cc9c3efe90b0b8b5c52 100644 (file)
@@ -42,7 +42,7 @@ namespace System.Web.UI.Design.WebControls {
                        throw new NotImplementedException ();
                }
 
-               protected override object CreateInstance (Type item_type)
+               protected override object CreateInstance (Type itemType)
                {
                        throw new NotImplementedException ();
                }
index 970390e629c8c97cd8a562787657e7d27d58f853..5efc9c963fa236f7f0aa0b1297a43ff250532589 100644 (file)
@@ -235,10 +235,10 @@ namespace System.Windows.Forms.Design
                        return false;
                }
 
-               protected override object GetService (Type service)
+               protected override object GetService (Type serviceType)
                {
                        if (_serviceProvider != null) {
-                               return _serviceProvider.GetService (service);
+                               return _serviceProvider.GetService (serviceType);
                        }
                        return null;
                }
index 2eefad53d0fcebff14bddac2d56583009288bf0b..10641f4d3732faac0b3cd443be9b3b5e05345d37 100644 (file)
@@ -554,19 +554,19 @@ namespace System.Windows.Forms.Design
 
                
 #region Parenting
-               protected void HookChildControls (Control firstControl)
+               protected void HookChildControls (Control firstChild)
                {
-                       if (firstControl != null) {
-                               foreach (Control control in firstControl.Controls) {
+                       if (firstChild != null) {
+                               foreach (Control control in firstChild.Controls) {
                                        control.WindowTarget = (IWindowTarget) new WndProcRouter (control, (IMessageReceiver) this);
                                }
                        }
                }
 
-               protected void UnhookChildControls (Control firstControl)
+               protected void UnhookChildControls (Control firstChild)
                {
-                       if (firstControl != null) {
-                               foreach (Control control in firstControl.Controls) {
+                       if (firstChild != null) {
+                               foreach (Control control in firstChild.Controls) {
                                        if (control.WindowTarget is WndProcRouter)
                                                ((WndProcRouter) control.WindowTarget).Dispose ();
                                }
@@ -662,11 +662,11 @@ namespace System.Windows.Forms.Design
                        e.UseDefaultCursors = false;
                }
 
-               protected virtual void OnDragDrop (DragEventArgs e)
+               protected virtual void OnDragDrop (DragEventArgs de)
                {
                }
 
-               protected virtual void OnDragEnter (DragEventArgs e)
+               protected virtual void OnDragEnter (DragEventArgs de)
                {
                }
 
@@ -674,7 +674,7 @@ namespace System.Windows.Forms.Design
                {
                }
 
-               protected virtual void OnDragOver (DragEventArgs e)
+               protected virtual void OnDragOver (DragEventArgs de)
                {
                }
 #endregion
index 6d369dfc4f3ad84cf329350f3cb365277f01aacd..365ba61c7feb161fd11795080864f8f544e784e6 100644 (file)
@@ -494,9 +494,9 @@ namespace System.Windows.Forms.Design
                // component - The IComponent to ensure has a context menu service.
                // XXX: Not sure exactly what this should do...
                //
-               protected virtual void EnsureMenuEditorService (IComponent component)
+               protected virtual void EnsureMenuEditorService (IComponent c)
                {
-                       if (this.menuEditorService == null && component is ContextMenu)
+                       if (this.menuEditorService == null && c is ContextMenu)
                                menuEditorService = (IMenuEditorService) GetService (typeof (IMenuEditorService));
                }
 #endregion
index 469bcd67328b971958cdd23e11e79ac814106b12..eb53ae4bc538cd074508188feb7dd603ac73e507 100644 (file)
@@ -210,23 +210,23 @@ namespace System.Windows.Forms.Design
                        return false;
                }
 
-               public virtual bool CanParent (ControlDesigner designer)
+               public virtual bool CanParent (ControlDesigner controlDesigner)
                {
-                       return CanParent (designer.Control);
+                       return CanParent (controlDesigner.Control);
                }
 
-               protected override void OnDragDrop (DragEventArgs e)
+               protected override void OnDragDrop (DragEventArgs de)
                {
                        IUISelectionService selectionServ = this.GetService (typeof (IUISelectionService)) as IUISelectionService;
                        if (selectionServ != null) {
                                // once this is fired the parent control (parentcontroldesigner) will start getting dragover events.
                                //
-                               Point location = this.SnapPointToGrid (this.Control.PointToClient (new Point (e.X, e.Y)));
+                               Point location = this.SnapPointToGrid (this.Control.PointToClient (new Point (de.X, de.Y)));
                                selectionServ.DragDrop (false, this.Control, location.X, location.Y);
                        }
                }
 
-               protected override void OnDragEnter (DragEventArgs e)
+               protected override void OnDragEnter (DragEventArgs de)
                {
                        this.Control.Refresh ();
                }
@@ -236,16 +236,16 @@ namespace System.Windows.Forms.Design
                        this.Control.Refresh ();
                }
 
-               protected override void OnDragOver (DragEventArgs e)
+               protected override void OnDragOver (DragEventArgs de)
                {
                        IUISelectionService selectionServ = this.GetService (typeof (IUISelectionService)) as IUISelectionService;
                        if (selectionServ != null) {
                                // once ControlDesigner.MouseDragBegin is called this will start getting dragover events.
                                //
-                               Point location = this.SnapPointToGrid (this.Control.PointToClient (new Point (e.X, e.Y)));
+                               Point location = this.SnapPointToGrid (this.Control.PointToClient (new Point (de.X, de.Y)));
                                selectionServ.DragOver (this.Control, location.X, location.Y);
                        }
-                       e.Effect = DragDropEffects.Move;
+                       de.Effect = DragDropEffects.Move;
                }
 #endregion
 
index 266afd8f852cbfcd073387d6b8aa9af62308f897..567d3ace1538c8e1fe503b1827dc2e321c9ec907 100644 (file)
@@ -51,9 +51,9 @@ namespace System.Windows.Forms.Design
                private const int HTHSCROLL = 6;
                private const int HTVSCROLL = 7;
 
-               protected override bool GetHitTest (Point point)
+               protected override bool GetHitTest (Point pt)
                {
-                       if (base.GetHitTest (point)) {
+                       if (base.GetHitTest (pt)) {
                                return true;
                        }
 
@@ -65,7 +65,7 @@ namespace System.Windows.Forms.Design
                                int hitTestResult = (int) Native.SendMessage (this.Control.Handle,
                                                                                                                                         Native.Msg.WM_NCHITTEST,
                                                                                                                                         IntPtr.Zero,
-                                                                                                                                       (IntPtr) Native.LParam (point.X, point.Y));
+                                                                                                                                       (IntPtr) Native.LParam (pt.X, pt.Y));
                                if (hitTestResult == HTHSCROLL || hitTestResult == HTVSCROLL)
                                        return true;
                        }
index acaf20cac11e7d6f21ba27ecd88aa28c7f419b8f..5861a327a1516252604c2f1fbb4a818bef9e8f8b 100644 (file)
@@ -1,5 +1,5 @@
 Assembly/AssemblyInfo.cs
-../../build/common/Consts.cs.in
+../../build/common/Consts.cs
 ../../build/common/Locale.cs
 System.DirectoryServices/ActiveDirectoryAccessRule.cs
 System.DirectoryServices/ActiveDirectoryAuditRule.cs
index 89cb0579359850e1288ad31c2e7cbcf7aed1d047..7d1a0abbb8b0b59c5e6cb77eeaf6772e895ae62d 100644 (file)
@@ -215,9 +215,9 @@ namespace System.DirectoryServices
                /// <param name="filter">relative distinguised name of the child
                /// </param>
                /// <returns>Child entry with the specified name </returns>
-               public DirectoryEntry Find(string filter)
+               public DirectoryEntry Find(string name)
                {
-                       DirectoryEntry child=CheckEntry(filter);
+                       DirectoryEntry child=CheckEntry(name);
                        return child;
                }
 
@@ -229,12 +229,12 @@ namespace System.DirectoryServices
                /// <param name="otype"> Type of the child i.e strutcuralObjectClass
                /// name of the child </param>
                /// <returns>Child entry with the specified name and type</returns>
-               public DirectoryEntry Find(string filter, string otype)
+               public DirectoryEntry Find(string name, string schemaClassName)
                {
-                       DirectoryEntry child=CheckEntry(filter);
+                       DirectoryEntry child=CheckEntry(name);
 
                        if( child != null)                      {
-                               if(child.Properties["objectclass"].ContainsCaselessStringValue(otype))
+                               if(child.Properties["objectclass"].ContainsCaselessStringValue(schemaClassName))
                                        return child;
                                else
                                        throw new SystemException("An unknown directory object was requested");
index d0d23937e27ba259b0da0292382f6a564f2d4fde..1df7a9ba452cacb19aaa173c82e7f0e3b990403a 100644 (file)
@@ -45,11 +45,11 @@ namespace System.DirectoryServices {
                        SetUp ();
                }
 
-               public DirectoryServicesPermission (DirectoryServicesPermissionEntry[] entries)
+               public DirectoryServicesPermission (DirectoryServicesPermissionEntry[] permissionAccessEntries)
                {
                        SetUp ();
                        innerCollection = new DirectoryServicesPermissionEntryCollection (this);
-                       innerCollection.AddRange (entries);
+                       innerCollection.AddRange (permissionAccessEntries);
                }
 
                public DirectoryServicesPermission (PermissionState state)
@@ -58,11 +58,11 @@ namespace System.DirectoryServices {
                        SetUp ();
                }
 
-               public DirectoryServicesPermission (DirectoryServicesPermissionAccess access, string path)
+               public DirectoryServicesPermission (DirectoryServicesPermissionAccess permissionAccess, string path)
                {
                        SetUp ();
                        innerCollection = new DirectoryServicesPermissionEntryCollection (this);
-                       innerCollection.Add (new DirectoryServicesPermissionEntry (access, path));
+                       innerCollection.Add (new DirectoryServicesPermissionEntry (permissionAccess, path));
                }
 
                public DirectoryServicesPermissionEntryCollection PermissionEntries {
index 95c07b65f6ef0df921bb0c45a76bd5c37f0e0753..c413ea6d4064a4a67045fa3aedf7700b807e739d 100644 (file)
@@ -61,47 +61,47 @@ namespace System.DirectoryServices {
                        set { List[index] = value; }
                }
 
-               public int Add (DirectoryServicesPermissionEntry entry)
+               public int Add (DirectoryServicesPermissionEntry value)
                {
-                       return List.Add (entry);
+                       return List.Add (value);
                }
 
-               public void AddRange (DirectoryServicesPermissionEntry[] entries)
+               public void AddRange (DirectoryServicesPermissionEntry[] value)
                {
-                       foreach (DirectoryServicesPermissionEntry entry in entries)
+                       foreach (DirectoryServicesPermissionEntry entry in value)
                                Add (entry);
                }
 
-               public void AddRange (DirectoryServicesPermissionEntryCollection entries)
+               public void AddRange (DirectoryServicesPermissionEntryCollection value)
                {
-                       foreach (DirectoryServicesPermissionEntry entry in entries)
+                       foreach (DirectoryServicesPermissionEntry entry in value)
                                Add (entry);
                }
 
-               public void CopyTo (DirectoryServicesPermissionEntry[] copy_to, int index)
+               public void CopyTo (DirectoryServicesPermissionEntry[] array, int index)
                {
                        foreach (DirectoryServicesPermissionEntry entry in List)
-                               copy_to[index++] = entry;
+                               array[index++] = entry;
                }
 
-               public bool Contains (DirectoryServicesPermissionEntry entry)
+               public bool Contains (DirectoryServicesPermissionEntry value)
                {
-                       return List.Contains (entry);
+                       return List.Contains (value);
                }
 
-               public int IndexOf (DirectoryServicesPermissionEntry entry)
+               public int IndexOf (DirectoryServicesPermissionEntry value)
                {
-                       return List.IndexOf (entry);
+                       return List.IndexOf (value);
                }
 
-               public void Insert (int pos, DirectoryServicesPermissionEntry entry)
+               public void Insert (int index, DirectoryServicesPermissionEntry value)
                {
-                       List.Insert (pos, entry);
+                       List.Insert (index, value);
                }
 
-               public void Remove (DirectoryServicesPermissionEntry entry)
+               public void Remove (DirectoryServicesPermissionEntry value)
                {
-                       List.Remove (entry);
+                       List.Remove (value);
                }
 
                protected override void OnClear ()
index 15089be8d54d7ec1b010650b35035026ba1de6b5..5b7533e7bd33c98082c381cde572c4b63df00afb 100644 (file)
@@ -85,16 +85,16 @@ namespace System.DirectoryServices
 
                }
 
-               public void AddRange(object[] values)
+               public void AddRange(object[] value)
                {
-                       foreach (object value in values)
-                               Add (value);
+                       foreach (object val in value)
+                               Add (val);
                }
 
-               public void AddRange (PropertyValueCollection coll)
+               public void AddRange (PropertyValueCollection value)
                {
-                       foreach (object value in coll)
-                               Add (value);
+                       foreach (object val in value)
+                               Add (val);
                }
 
                public int IndexOf( object value )  
@@ -132,10 +132,10 @@ namespace System.DirectoryServices
                        return false;
                }
 
-               public void CopyTo (object[] copy_to, int index)
+               public void CopyTo (object[] array, int index)
                {
                        foreach (object o in List)
-                               copy_to[index++] = o;
+                               array[index++] = o;
                }
 
                [MonoTODO]
index 2c7460276fdf710a212eb49aeb1692b250ae12d1..df35e219994142cf0aed68823b46ee3a6660dd7f 100644 (file)
@@ -58,10 +58,10 @@ namespace System.DirectoryServices
                        
                }
 
-               public ResultPropertyValueCollection this[string key]
+               public ResultPropertyValueCollection this[string name]
                {
                        get {
-                               return (ResultPropertyValueCollection) this.Dictionary[key.ToLower()];
+                               return (ResultPropertyValueCollection) this.Dictionary[name.ToLower()];
                        }
 //                     set { this.Dictionary[key] = value; } 
                }
@@ -72,9 +72,9 @@ namespace System.DirectoryServices
                } 
                
                //see if collection contains an entry corresponding to key
-               public bool Contains(string key)
+               public bool Contains(string propertyName)
                {
-                       return this.Dictionary.Contains(key.ToLower());
+                       return this.Dictionary.Contains(propertyName.ToLower());
                }
                
                public ICollection PropertyNames 
@@ -93,10 +93,10 @@ namespace System.DirectoryServices
                        }
                }
 
-               public void CopyTo (ResultPropertyValueCollection[] copy_to, int index)
+               public void CopyTo (ResultPropertyValueCollection[] array, int index)
                {
                        foreach (ResultPropertyValueCollection vals in Values)
-                               copy_to[index++] = vals;
+                               array[index++] = vals;
                }
        }
 }
index 05b352889de61595477b4054995e2240ac1c1189..e2703927095c5dd3370cfab0380bc3e3e337b0d4 100644 (file)
@@ -74,9 +74,9 @@ namespace System.DirectoryServices
                        return InnerList.Contains (value);
                }
 
-               public void CopyTo (object[] array, int index)
+               public void CopyTo (object[] values, int index)
                {
-                       InnerList.CopyTo (array, index);
+                       InnerList.CopyTo (values, index);
                }
 
                public int IndexOf (object value)
index 6b94d89070f3d42acf0e6b630e3f0c304c232c0f..2afb3bc8c6a999ec54ea90fead8de1407cf56bce 100644 (file)
@@ -158,19 +158,19 @@ namespace System.DirectoryServices
                }
 
                [MonoTODO]
-               public void AddRange (SchemaNameCollection coll)
+               public void AddRange (SchemaNameCollection value)
                {
                        throw new NotImplementedException();
                }
 
                [MonoTODO]
-               public void AddRange (string[] coll)
+               public void AddRange (string[] value)
                {
                        throw new NotImplementedException();
                }
 
                [MonoTODO]
-               public bool Contains (string s)
+               public bool Contains (string value)
                {
                        throw new NotImplementedException();
                }
@@ -182,25 +182,25 @@ namespace System.DirectoryServices
                }
 
                [MonoTODO]
-               public void CopyTo (string[] copy_to, int pos)
+               public void CopyTo (string[] stringArray, int index)
                {
                        throw new NotImplementedException();
                }
 
                [MonoTODO]
-               public int IndexOf (string s)
+               public int IndexOf (string value)
                {
                        throw new NotImplementedException();
                }
 
                [MonoTODO]
-               public void Insert (int pos, string s)
+               public void Insert (int index, string value)
                {
                        throw new NotImplementedException();
                }
 
                [MonoTODO]
-               public void Remove (string s)
+               public void Remove (string value)
                {
                        throw new NotImplementedException();
                }
index 191fc387f4c09627c7c87e73102ee2a057ffef01..dc747fdfb588a297efdc715fa96d313f22c7c209 100644 (file)
@@ -221,27 +221,27 @@ namespace System.Drawing.Drawing2D
                 //
                 // AddArc
                 //
-                public void AddArc (Rectangle rect, float start_angle, float sweep_angle)
+                public void AddArc (Rectangle rect, float startAngle, float sweepAngle)
                 {
-                        Status status = GDIPlus.GdipAddPathArcI (nativePath, rect.X, rect.Y, rect.Width, rect.Height, start_angle, sweep_angle);
+                        Status status = GDIPlus.GdipAddPathArcI (nativePath, rect.X, rect.Y, rect.Width, rect.Height, startAngle, sweepAngle);
                         GDIPlus.CheckStatus (status);                          
                 }
 
-                public void AddArc (RectangleF rect, float start_angle, float sweep_angle)
+                public void AddArc (RectangleF rect, float startAngle, float sweepAngle)
                 {
-                        Status status = GDIPlus.GdipAddPathArc (nativePath, rect.X, rect.Y, rect.Width, rect.Height, start_angle, sweep_angle);
+                        Status status = GDIPlus.GdipAddPathArc (nativePath, rect.X, rect.Y, rect.Width, rect.Height, startAngle, sweepAngle);
                         GDIPlus.CheckStatus (status);                          
                 }
 
-                public void AddArc (int x, int y, int width, int height, float start_angle, float sweep_angle)
+                public void AddArc (int x, int y, int width, int height, float startAngle, float sweepAngle)
                 {
-                        Status status = GDIPlus.GdipAddPathArcI (nativePath, x, y, width, height, start_angle, sweep_angle);
+                        Status status = GDIPlus.GdipAddPathArcI (nativePath, x, y, width, height, startAngle, sweepAngle);
                         GDIPlus.CheckStatus (status);                          
                 }
 
-                public void AddArc (float x, float y, float width, float height, float start_angle, float sweep_angle)
+                public void AddArc (float x, float y, float width, float height, float startAngle, float sweepAngle)
                 {
-                        Status status = GDIPlus.GdipAddPathArc (nativePath, x, y, width, height, start_angle, sweep_angle);
+                        Status status = GDIPlus.GdipAddPathArc (nativePath, x, y, width, height, startAngle, sweepAngle);
                         GDIPlus.CheckStatus (status);                          
                 }
 
@@ -279,28 +279,28 @@ namespace System.Drawing.Drawing2D
                 //
                 // AddBeziers
                 //
-                public void AddBeziers (params Point [] pts)
+                public void AddBeziers (params Point [] points)
                 {
-                       if (pts == null)
-                               throw new ArgumentNullException ("pts");
-                        Status status = GDIPlus.GdipAddPathBeziersI (nativePath, pts, pts.Length);
+                       if (points == null)
+                               throw new ArgumentNullException ("points");
+                        Status status = GDIPlus.GdipAddPathBeziersI (nativePath, points, points.Length);
                         GDIPlus.CheckStatus (status);                          
                 }
 
-                public void AddBeziers (PointF [] pts)
+                public void AddBeziers (PointF [] points)
                 {
-                       if (pts == null)
-                               throw new ArgumentNullException ("pts");
-                        Status status = GDIPlus.GdipAddPathBeziers (nativePath, pts, pts.Length);
+                       if (points == null)
+                               throw new ArgumentNullException ("points");
+                        Status status = GDIPlus.GdipAddPathBeziers (nativePath, points, points.Length);
                         GDIPlus.CheckStatus (status);                          
                 }
 
                 //
                 // AddEllipse
                 //
-                public void AddEllipse (RectangleF r)
+                public void AddEllipse (RectangleF rect)
                 {
-                        Status status = GDIPlus.GdipAddPathEllipse (nativePath, r.X, r.Y, r.Width, r.Height);
+                        Status status = GDIPlus.GdipAddPathEllipse (nativePath, rect.X, rect.Y, rect.Width, rect.Height);
                         GDIPlus.CheckStatus (status);                          
                 }
                 
@@ -310,9 +310,9 @@ namespace System.Drawing.Drawing2D
                         GDIPlus.CheckStatus (status);                          
                 }
 
-                public void AddEllipse (Rectangle r)
+                public void AddEllipse (Rectangle rect)
                 {
-                        Status status = GDIPlus.GdipAddPathEllipseI (nativePath, r.X, r.Y, r.Width, r.Height);
+                        Status status = GDIPlus.GdipAddPathEllipseI (nativePath, rect.X, rect.Y, rect.Width, rect.Height);
                         GDIPlus.CheckStatus (status);                          
                 }
                 
@@ -326,16 +326,16 @@ namespace System.Drawing.Drawing2D
                 //
                 // AddLine
                 //
-                public void AddLine (Point a, Point b)
+                public void AddLine (Point pt1, Point pt2)
                 {
-                        Status status = GDIPlus.GdipAddPathLineI (nativePath, a.X, a.Y, b.X, b.Y);
+                        Status status = GDIPlus.GdipAddPathLineI (nativePath, pt1.X, pt1.Y, pt2.X, pt2.Y);
                         GDIPlus.CheckStatus (status);                          
                 }
 
-                public void AddLine (PointF a, PointF b)
+                public void AddLine (PointF pt1, PointF pt2)
                 {
-                        Status status = GDIPlus.GdipAddPathLine (nativePath, a.X, a.Y, b.X,
-                                        b.Y);
+                        Status status = GDIPlus.GdipAddPathLine (nativePath, pt1.X, pt1.Y, pt2.X,
+                                        pt2.Y);
                                         
                        GDIPlus.CheckStatus (status);                                                                  
                 }
index 024e0c2adde5b360738ba020ff676d82efc2d3f0..9c92b91caa54c3059626815c0d889b0d08b6bfd5 100644 (file)
@@ -45,14 +45,14 @@ namespace System.Drawing.Drawing2D
                {
                }
 
-               public HatchBrush (HatchStyle hatchStyle, Color foreColor)
-                                       : this (hatchStyle, foreColor, Color.Black)
+               public HatchBrush (HatchStyle hatchstyle, Color foreColor)
+                                       : this (hatchstyle, foreColor, Color.Black)
                {
                }
 
-               public HatchBrush(HatchStyle hatchStyle, Color foreColor, Color backColor)
+               public HatchBrush(HatchStyle hatchstyle, Color foreColor, Color backColor)
                {
-                       Status status = GDIPlus.GdipCreateHatchBrush (hatchStyle, foreColor.ToArgb (), backColor.ToArgb (), out nativeObject);
+                       Status status = GDIPlus.GdipCreateHatchBrush (hatchstyle, foreColor.ToArgb (), backColor.ToArgb (), out nativeObject);
                        GDIPlus.CheckStatus (status);
                }
 
index 3b042cad175e945dbd3b31229f1e5d37beb6b404..515362c99dfd4be37dc34685df791e478bc28f0a 100644 (file)
@@ -77,33 +77,33 @@ namespace System.Drawing.Imaging
                }
 
                [CLSCompliant(false)]
-               public ColorMatrix (float[][] matrix)
+               public ColorMatrix (float[][] newColorMatrix)
                {                       
-                       color00 = matrix [0][0];
-                       color01 = matrix [0][1];
-                       color02 = matrix [0][2];
-                       color03 = matrix [0][3];
-                       color04 = matrix [0][4];
-                       color10 = matrix [1][0];
-                       color11 = matrix [1][1];
-                       color12 = matrix [1][2];
-                       color13 = matrix [1][3];
-                       color14 = matrix [1][4];
-                       color20 = matrix [2][0];
-                       color21 = matrix [2][1];
-                       color22 = matrix [2][2];
-                       color23 = matrix [2][3];
-                       color24 = matrix [2][4];
-                       color30 = matrix [3][0];
-                       color31 = matrix [3][1];
-                       color32 = matrix [3][2];
-                       color33 = matrix [3][3];
-                       color34 = matrix [3][4];
-                       color40 = matrix [4][0];
-                       color41 = matrix [4][1];
-                       color42 = matrix [4][2];
-                       color43 = matrix [4][3];
-                       color44 = matrix [4][4];                                                
+                       color00 = newColorMatrix [0][0];
+                       color01 = newColorMatrix [0][1];
+                       color02 = newColorMatrix [0][2];
+                       color03 = newColorMatrix [0][3];
+                       color04 = newColorMatrix [0][4];
+                       color10 = newColorMatrix [1][0];
+                       color11 = newColorMatrix [1][1];
+                       color12 = newColorMatrix [1][2];
+                       color13 = newColorMatrix [1][3];
+                       color14 = newColorMatrix [1][4];
+                       color20 = newColorMatrix [2][0];
+                       color21 = newColorMatrix [2][1];
+                       color22 = newColorMatrix [2][2];
+                       color23 = newColorMatrix [2][3];
+                       color24 = newColorMatrix [2][4];
+                       color30 = newColorMatrix [3][0];
+                       color31 = newColorMatrix [3][1];
+                       color32 = newColorMatrix [3][2];
+                       color33 = newColorMatrix [3][3];
+                       color34 = newColorMatrix [3][4];
+                       color40 = newColorMatrix [4][0];
+                       color41 = newColorMatrix [4][1];
+                       color42 = newColorMatrix [4][2];
+                       color43 = newColorMatrix [4][3];
+                       color44 = newColorMatrix [4][4];                                                
                }
 
                // properties
index f21831faa49f42af62d3669d57a509e58db0957e..8f19320aac39c78e70b12869b1af47bbc0aa1c5a 100644 (file)
@@ -198,21 +198,21 @@ namespace System.Drawing.Imaging {
                        }
                }
 
-               public EncoderParameter (Encoder encoder, int numberOfValues, int type, int value)
+               public EncoderParameter (Encoder encoder, int NumberOfValues, int Type, int Value)
                {
                        this.encoder = encoder;
-                       this.valuePtr = (IntPtr) value;
-                       this.valuesCount = numberOfValues;
-                       this.type = (EncoderParameterValueType) type;
+                       this.valuePtr = (IntPtr) Value;
+                       this.valuesCount = NumberOfValues;
+                       this.type = (EncoderParameterValueType) Type;
                }
 
-               public EncoderParameter (Encoder encoder, int numerator1, int denominator1, int numerator2, int denominator2)
+               public EncoderParameter (Encoder encoder, int numerator1, int demoninator1, int numerator2, int demoninator2)
                {
                        this.encoder = encoder;
                        this.valuesCount = 1;
                        this.type = EncoderParameterValueType.ValueTypeRationalRange;
                        this.valuePtr = Marshal.AllocHGlobal (4 * 4);
-                       int [] valuearray = { numerator1, denominator1, numerator2, denominator2 };
+                       int [] valuearray = { numerator1, demoninator1, numerator2, demoninator2 };
                        Marshal.Copy (valuearray, 0, this.valuePtr, 4);
                }
 
index 4bf494ea08892e82f78bdc0a2409ae3107edd223..dbbf98d5fa134547418a2258eda7d98283940790 100644 (file)
@@ -160,22 +160,22 @@ namespace System.Drawing.Imaging {
                        SetColorKey (colorLow, colorHigh, ColorAdjustType.Default);
                }
 
-               public void SetColorMatrix (ColorMatrix colorMatrix)
+               public void SetColorMatrix (ColorMatrix newColorMatrix)
                {
-                       SetColorMatrix (colorMatrix, ColorMatrixFlag.Default, ColorAdjustType.Default);
+                       SetColorMatrix (newColorMatrix, ColorMatrixFlag.Default, ColorAdjustType.Default);
                }
 
-               public void SetColorMatrix (ColorMatrix colorMatrix, ColorMatrixFlag colorMatrixFlag)
+               public void SetColorMatrix (ColorMatrix newColorMatrix, ColorMatrixFlag flags)
                {
-                       SetColorMatrix (colorMatrix, colorMatrixFlag, ColorAdjustType.Default);
+                       SetColorMatrix (newColorMatrix, flags, ColorAdjustType.Default);
                }
 
-               public void SetColorMatrix (ColorMatrix colorMatrix, ColorMatrixFlag colorMatrixFlag, ColorAdjustType colorAdjustType)
+               public void SetColorMatrix (ColorMatrix newColorMatrix, ColorMatrixFlag mode, ColorAdjustType type)
                {
-                       IntPtr cm = ColorMatrix.Alloc (colorMatrix);
+                       IntPtr cm = ColorMatrix.Alloc (newColorMatrix);
                        try {
                                Status status = GDIPlus.GdipSetImageAttributesColorMatrix (nativeImageAttr, 
-                                       colorAdjustType, true, cm, IntPtr.Zero, colorMatrixFlag);
+                                       type, true, cm, IntPtr.Zero, mode);
                                GDIPlus.CheckStatus (status);
                        }
                        finally {
@@ -294,9 +294,9 @@ namespace System.Drawing.Imaging {
                        SetGamma (gamma, ColorAdjustType.Default);
                }
 
-               public void SetGamma (float gamma, ColorAdjustType coloradjust)
+               public void SetGamma (float gamma, ColorAdjustType type)
                {
-                       Status status = GDIPlus.GdipSetImageAttributesGamma (nativeImageAttr, coloradjust, true, gamma);
+                       Status status = GDIPlus.GdipSetImageAttributesGamma (nativeImageAttr, type, true, gamma);
                        GDIPlus.CheckStatus (status);                                           
                }       
                
index 7498619e3c045412c5eaabe24ecb612a11391c2c..b28654bae370bc05486a2be5e24de4a38a5fb9e4 100644 (file)
@@ -220,10 +220,10 @@ namespace System.Drawing.Imaging {
                }
 
                public Metafile (IntPtr referenceHdc, Rectangle frameRect, MetafileFrameUnit frameUnit, EmfType type,
-                       string description)
+                       string desc)
                {
                        Status status = GDIPlus.GdipRecordMetafileI (referenceHdc, type, ref frameRect, frameUnit,
-                               description, out nativeObject);
+                               desc, out nativeObject);
                        GDIPlus.CheckStatus (status);
                }
 
@@ -261,8 +261,8 @@ namespace System.Drawing.Imaging {
                }
                
                public Metafile (string fileName, IntPtr referenceHdc, RectangleF frameRect, MetafileFrameUnit frameUnit, 
-                       string description) : this (fileName, referenceHdc, frameRect, frameUnit, EmfType.EmfPlusDual,
-                       description
+                       string desc) : this (fileName, referenceHdc, frameRect, frameUnit, EmfType.EmfPlusDual,
+                       desc) 
                {
                }
                
@@ -405,11 +405,11 @@ namespace System.Drawing.Imaging {
                }
 
                [MonoLimitation ("Metafiles aren't only partially supported by libgdiplus.")]
-               public static MetafileHeader GetMetafileHeader (IntPtr henhmetafile, WmfPlaceableFileHeader wmfHeader)
+               public static MetafileHeader GetMetafileHeader (IntPtr hmetafile, WmfPlaceableFileHeader wmfHeader)
                {
                        IntPtr header = Marshal.AllocHGlobal (Marshal.SizeOf (typeof (MetafileHeader)));
                        try {
-                               Status status = GDIPlus.GdipGetMetafileHeaderFromEmf (henhmetafile, header);
+                               Status status = GDIPlus.GdipGetMetafileHeaderFromEmf (hmetafile, header);
                                GDIPlus.CheckStatus (status);
                                return new MetafileHeader (header);
                        }
index 64d13ab0594d1fa0d4bf6ecf7ffb3fa6761fb0f8..f983b74f6b68d251c6228745e37ddd95b3041131 100644 (file)
@@ -56,7 +56,7 @@ namespace System.Drawing
                                                            IntPtr data,
                                                            PlayRecordCallback callbackData);
                
-               public delegate bool DrawImageAbort (IntPtr callbackData);
+               public delegate bool DrawImageAbort (IntPtr callbackdata);
 
                internal Graphics (IntPtr nativeGraphics)
                {
index fedcd14d7e1a54d6e81365ad2f0ef2bf16def9c1..da5aca1d82a68ac870cbc1e1ef05e2d22ade09d3 100644 (file)
@@ -7,7 +7,7 @@
 //     Sanjay Gupta (gsanjay@novell.com)
 //     Ravindra (rkumar@novell.com)
 //     Peter Dennis Bartok (pbartok@novell.com)
-//     Sebastien Pouliot  <sebastien@ximian.com>
+//     Sebastien Pouliot <sebastien@ximian.com>
 //
 // Copyright (C) 2004 - 2007 Novell, Inc (http://www.novell.com)
 //
@@ -166,7 +166,7 @@ namespace System.Drawing
                // Copies an array of Points to unmanaged memory
                static public IntPtr FromPointToUnManagedMemoryI (Point [] pts)
                {
-                       int nPointSize =  Marshal.SizeOf (pts[0]);
+                       int nPointSize = Marshal.SizeOf (pts[0]);
                        IntPtr dest = Marshal.AllocHGlobal (nPointSize * pts.Length);
                        IntPtr pos = dest;
                        for (int i=0; i<pts.Length; i++, pos = new IntPtr (pos.ToInt64 () + nPointSize))
@@ -189,7 +189,7 @@ namespace System.Drawing
                // Copies an array of Points to unmanaged memory
                static public IntPtr FromPointToUnManagedMemory (PointF [] pts)
                {
-                       int nPointSize =  Marshal.SizeOf (pts[0]);
+                       int nPointSize = Marshal.SizeOf (pts[0]);
                        IntPtr dest = Marshal.AllocHGlobal (nPointSize * pts.Length);
                        IntPtr pos = dest;
                        for (int i=0; i<pts.Length; i++, pos = new IntPtr (pos.ToInt64 () + nPointSize))
@@ -287,7 +287,7 @@ namespace System.Drawing
                static internal extern Status GdipCreateRegionRect (ref RectangleF rect, out IntPtr region);
 
                [DllImport(GdiPlus)]
-               static internal extern Status GdipCreateRegionRectI (ref Rectangle rect,  out IntPtr region);
+               static internal extern Status GdipCreateRegionRectI (ref Rectangle rect, out IntPtr region);
 
                [DllImport(GdiPlus)]
                static internal extern Status GdipCreateRegionPath (IntPtr path, out IntPtr region);
@@ -311,7 +311,7 @@ namespace System.Drawing
                        float height, IntPtr graphics, out bool result);
 
                [DllImport(GdiPlus)]
-               static internal extern Status  GdipIsVisibleRegionRectI (IntPtr region, int x, int y, int width,
+               static internal extern Status GdipIsVisibleRegionRectI (IntPtr region, int x, int y, int width,
                        int height, IntPtr graphics, out bool result);
 
 
@@ -354,13 +354,13 @@ namespace System.Drawing
 
                [DllImport(GdiPlus)]
                static internal extern Status GdipGetRegionData (IntPtr region, byte[] buffer, int bufferSize,
-                 out int sizeFilled);
+                out int sizeFilled);
 
                [DllImport(GdiPlus)]
                static internal extern Status GdipGetRegionScansCount (IntPtr region, out int count, IntPtr matrix);
 
                [DllImport(GdiPlus)]
-               static internal extern Status GdipGetRegionScans (IntPtr region,  IntPtr rects, out int count,
+               static internal extern Status GdipGetRegionScans (IntPtr region, IntPtr rects, out int count,
                        IntPtr matrix);
 
                [DllImport(GdiPlus)]
@@ -397,7 +397,7 @@ namespace System.Drawing
                [DllImport(GdiPlus)]
                static internal extern Status GdipGetTextureImage (IntPtr texture, out IntPtr image);
                [DllImport(GdiPlus)]
-               static internal extern Status GdipCreateTexture (IntPtr image, WrapMode wrapMode,  out IntPtr texture);
+               static internal extern Status GdipCreateTexture (IntPtr image, WrapMode wrapMode, out IntPtr texture);
                [DllImport(GdiPlus)]
                static internal extern Status GdipCreateTextureIAI (IntPtr image, IntPtr imageAttributes, int x, int y, int width, int height, out IntPtr texture);
                [DllImport(GdiPlus)]
@@ -606,13 +606,13 @@ namespace System.Drawing
                [DllImport(GdiPlus)]
                static internal extern Status GdipFillEllipse (IntPtr graphics, IntPtr pen, float x, float y, float width, float height);
                [DllImport (GdiPlus)]
-               static internal extern  Status GdipFillPolygon (IntPtr graphics, IntPtr brush, PointF [] points, int count, FillMode fillMode);
+               static internal extern Status GdipFillPolygon (IntPtr graphics, IntPtr brush, PointF [] points, int count, FillMode fillMode);
                [DllImport (GdiPlus)]
-               static internal extern  Status GdipFillPolygonI (IntPtr graphics, IntPtr brush, Point [] points, int count, FillMode fillMode);
+               static internal extern Status GdipFillPolygonI (IntPtr graphics, IntPtr brush, Point [] points, int count, FillMode fillMode);
                [DllImport (GdiPlus)]
-               static internal extern  Status GdipFillPolygon2 (IntPtr graphics, IntPtr brush, PointF [] points, int count);
+               static internal extern Status GdipFillPolygon2 (IntPtr graphics, IntPtr brush, PointF [] points, int count);
                [DllImport (GdiPlus)]
-               static internal extern  Status GdipFillPolygon2I (IntPtr graphics, IntPtr brush, Point [] points, int count);
+               static internal extern Status GdipFillPolygon2I (IntPtr graphics, IntPtr brush, Point [] points, int count);
                [DllImport(GdiPlus)]
                static internal extern Status GdipFillRectangle (IntPtr graphics, IntPtr brush, float x1, float y1, float x2, float y2);
                [DllImport(GdiPlus)]
@@ -692,7 +692,7 @@ namespace System.Drawing
 
                [DllImport(GdiPlus)]
                internal static extern Status GdipFillClosedCurve2(IntPtr graphics, IntPtr brush,
-                                         PointF [] points, int count, float tension, FillMode fillMode);
+                                       PointF [] points, int count, float tension, FillMode fillMode);
 
                [DllImport(GdiPlus)]
                internal static extern Status GdipFillClosedCurve2I(IntPtr graphics, IntPtr brush,
@@ -710,7 +710,7 @@ namespace System.Drawing
                internal static extern Status GdipFillPath(IntPtr graphics, IntPtr brush, IntPtr path);
 
                [DllImport(GdiPlus)]
-               internal static extern Status GdipGetNearestColor(IntPtr graphics,  out int argb);
+               internal static extern Status GdipGetNearestColor(IntPtr graphics, out int argb);
 
                [DllImport(GdiPlus)]
                internal static extern Status GdipIsVisiblePoint(IntPtr graphics, float x, float y, out bool result);
@@ -728,7 +728,7 @@ namespace System.Drawing
 
                [DllImport(GdiPlus)]
                internal static extern Status GdipTransformPoints(IntPtr graphics, CoordinateSpace destSpace,
-                       CoordinateSpace srcSpace, IntPtr points,  int count);
+                       CoordinateSpace srcSpace, IntPtr points, int count);
 
                [DllImport(GdiPlus)]
                internal static extern Status GdipTransformPointsI(IntPtr graphics, CoordinateSpace destSpace,
@@ -953,7 +953,7 @@ namespace System.Drawing
                internal static extern Status GdipSetStringFormatMeasurableCharacterRanges (IntPtr native,
                        int cnt, CharacterRange [] range);
 
-               [DllImport(GdiPlus)]
+               [DllImport(GdiPlus)]
                internal static extern Status GdipGetStringFormatMeasurableCharacterRangeCount (IntPtr native,
                        out int cnt);
 
@@ -1092,7 +1092,7 @@ namespace System.Drawing
                internal static extern Status GdipImageRotateFlip ( IntPtr image, RotateFlipType rotateFlipType );
 
                [DllImport(GdiPlus, CharSet=CharSet.Unicode)]
-               internal static extern Status GdipSaveImageToFile (IntPtr image, string filename,  ref Guid encoderClsID, IntPtr encoderParameters);
+               internal static extern Status GdipSaveImageToFile (IntPtr image, string filename, ref Guid encoderClsID, IntPtr encoderParameters);
 
                [DllImport(GdiPlus)]
                internal static extern Status GdipSaveAdd ( IntPtr image, IntPtr encoderParameters );
@@ -1119,7 +1119,7 @@ namespace System.Drawing
 
 
                [DllImport(GdiPlus)]
-               internal static extern Status GdipDrawImagePointsI (IntPtr graphics, IntPtr image,  Point [] destPoints, int count);
+               internal static extern Status GdipDrawImagePointsI (IntPtr graphics, IntPtr image, Point [] destPoints, int count);
 
                [DllImport(GdiPlus)]
                internal static extern Status GdipDrawImageRectRectI (IntPtr graphics, IntPtr image,
@@ -1155,7 +1155,7 @@ namespace System.Drawing
                                int srcheight, GraphicsUnit srcUnit);
 
                [DllImport(GdiPlus)]
-               internal static extern Status GdipCreateStringFormat(StringFormatFlags formatAttributes,  int language, out IntPtr native);
+               internal static extern Status GdipCreateStringFormat(StringFormatFlags formatAttributes, int language, out IntPtr native);
 
                [DllImport(GdiPlus)]
                internal static extern Status GdipCreateHBITMAPFromBitmap (IntPtr bmp, out IntPtr HandleBmp, int clrbackground);
@@ -1170,7 +1170,7 @@ namespace System.Drawing
                internal static extern Status GdipCreateHICONFromBitmap (IntPtr bmp, out IntPtr HandleIcon);
 
                [DllImport(GdiPlus)]
-               internal static extern Status GdipCreateBitmapFromHICON (IntPtr  hicon,  out IntPtr bitmap);
+               internal static extern Status GdipCreateBitmapFromHICON (IntPtr hicon, out IntPtr bitmap);
 
                [DllImport(GdiPlus)]
                internal static extern Status GdipCreateBitmapFromResource (IntPtr hInstance,
@@ -1209,13 +1209,13 @@ namespace System.Drawing
                [DllImport (GdiPlus)]
                internal static extern Status GdipInvertMatrix (IntPtr matrix);
                [DllImport (GdiPlus)]
-               internal static extern Status GdipTransformMatrixPoints (IntPtr matrix, PointF [] pts, int count);
+               internal static extern Status GdipTransformMatrixPoints (IntPtr matrix, [In, Out] PointF [] pts, int count);
                [DllImport (GdiPlus)]
-               internal static extern Status GdipTransformMatrixPointsI (IntPtr matrix, Point [] pts, int count);
+               internal static extern Status GdipTransformMatrixPointsI (IntPtr matrix, [In, Out] Point [] pts, int count);
                [DllImport (GdiPlus)]
-               internal static extern Status GdipVectorTransformMatrixPoints (IntPtr matrix, PointF [] pts, int count);
+               internal static extern Status GdipVectorTransformMatrixPoints (IntPtr matrix, [In, Out] PointF [] pts, int count);
                [DllImport (GdiPlus)]
-               internal static extern Status GdipVectorTransformMatrixPointsI (IntPtr matrix, Point [] pts, int count);
+               internal static extern Status GdipVectorTransformMatrixPointsI (IntPtr matrix, [In, Out] Point [] pts, int count);
                [DllImport (GdiPlus)]
                internal static extern Status GdipIsMatrixInvertible (IntPtr matrix, out bool result);
 
@@ -1393,7 +1393,7 @@ namespace System.Drawing
                [DllImport (GdiPlus)]
                internal static extern Status GdipSetImageAttributesColorMatrix (IntPtr imageattr,
                                ColorAdjustType type, bool enableFlag, IntPtr colorMatrix,
-                               IntPtr grayMatrix,  ColorMatrixFlag flags);
+                               IntPtr grayMatrix, ColorMatrixFlag flags);
 
                [DllImport (GdiPlus)]
                internal static extern Status GdipSetImageAttributesGamma (IntPtr imageattr,
@@ -1428,13 +1428,13 @@ namespace System.Drawing
                        ColorAdjustType colorAdjustType);
 
                [DllImport (GdiPlus)]
-               internal static extern Status GdipSetImageAttributesWrapMode(IntPtr imageattr,  WrapMode wrap,
+               internal static extern Status GdipSetImageAttributesWrapMode(IntPtr imageattr, WrapMode wrap,
                        int argb, bool clamp);
 
 
                // Font
                [DllImport(GdiPlus)]
-               internal static extern Status GdipCreateFont (IntPtr fontFamily, float emSize, FontStyle style, GraphicsUnit  unit,  out IntPtr font);
+               internal static extern Status GdipCreateFont (IntPtr fontFamily, float emSize, FontStyle style, GraphicsUnit unit, out IntPtr font);
                [DllImport(GdiPlus)]
                internal static extern Status GdipDeleteFont (IntPtr font);
                [DllImport(GdiPlus, CharSet=CharSet.Auto)]
@@ -1589,7 +1589,7 @@ namespace System.Drawing
 
                // String Format
                [DllImport (GdiPlus)]
-               internal static extern Status GdipCreateStringFormat(int formatAttributes, int language, out IntPtr  format);
+               internal static extern Status GdipCreateStringFormat(int formatAttributes, int language, out IntPtr format);
                [DllImport (GdiPlus)]
                internal static extern Status GdipStringFormatGetGenericDefault(out IntPtr format);
                [DllImport (GdiPlus)]
@@ -1710,7 +1710,7 @@ namespace System.Drawing
                        private byte[]  start_buf;
                        private int     start_buf_pos;
                        private int     start_buf_len;
-                       private byte[]  managedBuf;
+                       private byte[] managedBuf;
                        private const int default_bufsize = 4096;
 
                        public GdiPlusStreamHelper (Stream s, bool seekToOrigin)
@@ -1723,7 +1723,7 @@ namespace System.Drawing
                                }
                        }
 
-                       public int StreamGetHeaderImpl (IntPtr buf, int bufsz)  {
+                       public int StreamGetHeaderImpl (IntPtr buf, int bufsz) {
                                int     bytesRead;
 
                                start_buf = new byte[bufsz];
index 178bddb250a409f0edf8af0d7181013c8c7d0362..2d87ac21cd5ee404003264eaafd7cc092ea00b59 100644 (file)
@@ -608,7 +608,7 @@ namespace MonoTests.System.Drawing {
                                }                               
                        }
                
-                       hash = new MD5CryptoServiceProvider().ComputeHash (pixels);
+                       hash = MD5.Create ().ComputeHash (pixels);
                        return ByteArrayToString (hash);
                }
                public string RotateIndexedBmp (Bitmap src, RotateFlipType type)
@@ -658,7 +658,7 @@ namespace MonoTests.System.Drawing {
                        if (pixel_data == null)
                                return "--ERROR--";
 
-                       byte[] hash = new MD5CryptoServiceProvider().ComputeHash (pixel_data);
+                       byte[] hash = MD5.Create ().ComputeHash (pixel_data);
                        return ByteArrayToString (hash);
                }
                
index 3b3d96acc7bebf09ccb6bccbc5bd47e1ace9b7f8..e4028a717fd8616e056d4a9ad580c64b6db83912 100644 (file)
@@ -159,7 +159,7 @@ namespace System.EnterpriseServices {
                }\r
 \r
                [MonoTODO]\r
-               public static void SetNamedProperty (string name, object property)\r
+               public static void SetNamedProperty (string name, object value)\r
                {\r
                        throw new NotImplementedException ();\r
                }\r
index 634104d140e4f3a3eba23ddf38f9aabc66d890d8..450a1c7c42195aa321e3a6770da50bb3106b4a2c 100644 (file)
@@ -55,8 +55,8 @@ namespace System.EnterpriseServices {
                {\r
                }\r
 \r
-               public RegistrationException (string msg, Exception innerException)\r
-                       : base (msg, innerException)\r
+               public RegistrationException (string msg, Exception inner)\r
+                       : base (msg, inner)\r
                {\r
                }\r
 \r
index a7c85802fa9ad60d54d8d1ad427ffa47f81b7fb5..59487fcc710d5267faf5512ef97c6979ee365652 100644 (file)
@@ -36,15 +36,15 @@ namespace System.IdentityModel.Selectors
                public CardSpacePolicyElement (
                        XmlElement target, XmlElement issuer,
                        Collection<XmlElement> parameters,
-                       Uri policyNoticeLink,
-                       int policyNoticeVersion,
+                       Uri privacyNoticeLink,
+                       int privacyNoticeVersion,
                        bool isManagedIssuer)
                {
                        this.target = target;
                        this.issuer = issuer;
                        this.parameters = parameters ?? new Collection<XmlElement> ();
-                       this.policy_link = policyNoticeLink;
-                       policy_ver = policyNoticeVersion;
+                       this.policy_link = privacyNoticeLink;
+                       policy_ver = privacyNoticeVersion;
                        is_managed = isManagedIssuer;
                }
 
index 16b6de3a66a8d7893bf1cc6b000dc867936a70c9..4a37f4a1b06c62d81f44374127fe579aa4053b8b 100644 (file)
@@ -62,19 +62,19 @@ namespace System.IdentityModel.Selectors
                [MonoTODO]
                public static GenericXmlSecurityToken GetToken (
                        CardSpacePolicyElement [] policyChain,
-                       SecurityTokenSerializer serializer)
+                       SecurityTokenSerializer tokenSerializer)
                {
-                       return (GenericXmlSecurityToken) get_token.Invoke (impl, new object [] {policyChain, serializer});
+                       return (GenericXmlSecurityToken) get_token.Invoke (impl, new object [] {policyChain, tokenSerializer});
                }
 
                public static GenericXmlSecurityToken GetToken (
                        XmlElement endpoint,
                        IEnumerable<XmlElement> policy,
                        XmlElement requiredRemoteTokenIssuer,
-                       SecurityTokenSerializer serializer)
+                       SecurityTokenSerializer tokenSerializer)
                {
                        CardSpacePolicyElement pe = new CardSpacePolicyElement (endpoint, requiredRemoteTokenIssuer, new Collection<XmlElement> (new List<XmlElement> (policy)), null, 0, requiredRemoteTokenIssuer != null);
-                       return GetToken (new CardSpacePolicyElement [] {pe}, serializer);
+                       return GetToken (new CardSpacePolicyElement [] {pe}, tokenSerializer);
                }
 
                [MonoTODO]
index 17df9c02d6d682728dc698abfb6f1defe206fb2c..5a214aba0d023b94b59ea9841e9957a0cee4e254 100644 (file)
@@ -78,7 +78,7 @@ namespace System.IdentityModel.Claims
                }
 
                [MonoTODO]
-               public static Claim CreateDenyOnlyWindowsSidClaim (SecurityIdentifier identifier)
+               public static Claim CreateDenyOnlyWindowsSidClaim (SecurityIdentifier sid)
                {
                        throw new NotImplementedException ();
                }
index 35f2b509c3e7cf75a9dd8815a12dea6fce220e07..35bdf0a78fd4145d016567171761e8994812c4ef 100644 (file)
@@ -71,7 +71,7 @@ namespace System.IdentityModel.Claims
                }
 
                public abstract IEnumerable<Claim> FindClaims (
-                       string resourceType, string right);
+                       string claimType, string right);
 
                public abstract IEnumerator<Claim> GetEnumerator ();
 
index 539c7a6dca7c134c8c7263b3b548a662e96ebff1..b7370764ee6344717e3cc1798b977c9093dc1a84 100644 (file)
@@ -41,25 +41,25 @@ namespace System.IdentityModel.Claims
                // Constructors
 
                [MonoTODO]
-               public WindowsClaimSet (WindowsIdentity identity)
+               public WindowsClaimSet (WindowsIdentity windowsIdentity)
                {
                        throw new NotImplementedException ();
                }
 
                [MonoTODO]
-               public WindowsClaimSet (WindowsIdentity identity, bool includeWindowsGroups)
+               public WindowsClaimSet (WindowsIdentity windowsIdentity, bool includeWindowsGroups)
                {
                        throw new NotImplementedException ();
                }
 
                [MonoTODO]
-               public WindowsClaimSet (WindowsIdentity identity, DateTime expirationTime)
+               public WindowsClaimSet (WindowsIdentity windowsIdentity, DateTime expirationTime)
                {
                        throw new NotImplementedException ();
                }
 
                [MonoTODO]
-               public WindowsClaimSet (WindowsIdentity identity, bool includeWindowsGroups, DateTime expirationTime)
+               public WindowsClaimSet (WindowsIdentity windowsIdentity, bool includeWindowsGroups, DateTime expirationTime)
                {
                        throw new NotImplementedException ();
                }
index b4479a72ff773feedb3a722dc323513b92f990a8..5b7287bf9cf858282e857e1c9a8d9a0b2c9267d3 100644 (file)
@@ -39,15 +39,15 @@ namespace System.IdentityModel.Policy
        {
                [MonoTODO]
                public static AuthorizationContext 
-                       CreateDefaultAuthorizationContext (IList<IAuthorizationPolicy> policies)
+                       CreateDefaultAuthorizationContext (IList<IAuthorizationPolicy> authorizationPolicies)
                {
-                       if (policies == null)
-                               throw new ArgumentNullException ("policies");
+                       if (authorizationPolicies == null)
+                               throw new ArgumentNullException ("authorizationPolicies");
 
                        string id = new UniqueId ().ToString ();
                        DefaultEvaluationContext ctx =
                                new DefaultEvaluationContext ();
-                       foreach (IAuthorizationPolicy a in policies) {
+                       foreach (IAuthorizationPolicy a in authorizationPolicies) {
                                object o = null;
                                a.Evaluate (ctx, ref o);
                        }
index 9f4e82b7e7896a275d1f3168696ca0b9ce5f6834..7fde4e6659dca3f11f08e3c7385a366b1fea7d8b 100644 (file)
@@ -46,10 +46,10 @@ namespace System.IdentityModel.Policy
                public abstract ReadOnlyCollection<ClaimSet> ClaimSets { get; }
 
                public abstract void AddClaimSet (
-                       IAuthorizationPolicy authorizationPolicy,
+                       IAuthorizationPolicy policy,
                        ClaimSet claimSet);
 
-               public abstract void RecordExpirationTime (DateTime time);
+               public abstract void RecordExpirationTime (DateTime expirationTime);
        }
 
        // default implementation
index 62d7d56782b7c268da482d868ba4bbb5a958e10f..644fda786cad80241bd5d0f9437a75e855f99df3 100644 (file)
@@ -46,11 +46,11 @@ namespace System.IdentityModel.Selectors
                }
 
                [MonoTODO]
-               public KerberosSecurityTokenProvider (string servicePrincipalName, TokenImpersonationLevel tokenImpersonationLevel, NetworkCredential credential)
+               public KerberosSecurityTokenProvider (string servicePrincipalName, TokenImpersonationLevel tokenImpersonationLevel, NetworkCredential networkCredential)
                {
                        name = servicePrincipalName;
                        impersonation_level = tokenImpersonationLevel;
-                       this.credential = credential;
+                       this.credential = networkCredential;
                }
 
                string name;
index 7381e691500e25d2b080acbde12490dec182a9c7..b78eea054be8fcb04e6c9f36bc43de4b6e41b86e 100644 (file)
@@ -41,11 +41,11 @@ namespace System.IdentityModel.Selectors
 
                public abstract SecurityTokenAuthenticator 
                        CreateSecurityTokenAuthenticator (
-                       SecurityTokenRequirement requirement,
-                       out SecurityTokenResolver resolver);
+                       SecurityTokenRequirement tokenRequirement,
+                       out SecurityTokenResolver outOfBandTokenResolver);
 
                public abstract SecurityTokenProvider 
-                       CreateSecurityTokenProvider(SecurityTokenRequirement requirement);
+                       CreateSecurityTokenProvider(SecurityTokenRequirement tokenRequirement);
 
                public abstract SecurityTokenSerializer 
                        CreateSecurityTokenSerializer (SecurityTokenVersion version);
index 386e285bd77db7c414cd63107369f6d934f1d34f..9bc5a1ec5f6b1902c39c88d6727d967bd9f81703 100644 (file)
@@ -77,16 +77,16 @@ namespace System.IdentityModel.Selectors
                        EndCancelTokenCore (result);
                }
 
-               public SecurityToken RenewToken (TimeSpan timeout, SecurityToken token)
+               public SecurityToken RenewToken (TimeSpan timeout, SecurityToken tokenToBeRenewed)
                {
-                       return RenewTokenCore (timeout, token);
+                       return RenewTokenCore (timeout, tokenToBeRenewed);
                }
 
                public IAsyncResult BeginRenewToken (
-                       TimeSpan timeout, SecurityToken token,
+                       TimeSpan timeout, SecurityToken tokenToBeRenewed,
                        AsyncCallback callback, object state)
                {
-                       return BeginRenewTokenCore (timeout, token, callback, state);
+                       return BeginRenewTokenCore (timeout, tokenToBeRenewed, callback, state);
                }
 
                public SecurityToken EndRenewToken (IAsyncResult result)
@@ -101,7 +101,7 @@ namespace System.IdentityModel.Selectors
                        throw new NotSupportedException (String.Format ("Token cancellation on this security token provider '{0}' is not supported.", this));
                }
 
-               protected virtual SecurityToken RenewTokenCore (TimeSpan timeout, SecurityToken token)
+               protected virtual SecurityToken RenewTokenCore (TimeSpan timeout, SecurityToken tokenToBeRenewed)
                {
                        throw new NotSupportedException (String.Format ("Token renewal on this security token provider '{0}' is not supported.", this));
                }
@@ -124,7 +124,7 @@ namespace System.IdentityModel.Selectors
 
                protected virtual IAsyncResult BeginRenewTokenCore (
                        TimeSpan timeout,
-                       SecurityToken token,
+                       SecurityToken tokenToBeRenewed,
                        AsyncCallback callback, object state)
                {
                        throw new NotSupportedException (String.Format ("Token renewal on this security token provider '{0}' is not supported.", this));
index c75e373ab19eb5ee47967c20cf3f19acc9e0ed82..bff51cdf302451cea20e26e166e7073fd1538bcf 100644 (file)
@@ -125,28 +125,28 @@ namespace System.IdentityModel.Selectors
                        }
                }
 
-               public TValue GetProperty<TValue> (string property)
+               public TValue GetProperty<TValue> (string propertyName)
                {
                        TValue ret;
-                       if (TryGetProperty<TValue> (property, out ret))
+                       if (TryGetProperty<TValue> (propertyName, out ret))
                                return ret;
-                       throw new ArgumentException (String.Format ("Property '{0}' was not found.", property));
+                       throw new ArgumentException (String.Format ("Property '{0}' was not found.", propertyName));
                }
 
-               public bool TryGetProperty<TValue> (string property, out TValue value)
+               public bool TryGetProperty<TValue> (string propertyName, out TValue result)
                {
                        object tmp;
-                       value = default (TValue);
+                       result = default (TValue);
 
-                       if (!Properties.TryGetValue (property, out tmp))
+                       if (!Properties.TryGetValue (propertyName, out tmp))
                                return false;
                        if (tmp == null && !typeof (TValue).IsValueType)
-                               value = default (TValue);
+                               result = default (TValue);
                        else if (tmp is TValue)
-                               value = (TValue) tmp;
+                               result = (TValue) tmp;
                        else
-                               throw new ArgumentException (String.Format ("The value of property '{0}' is of type '{1}', while '{2}' is expected.", property, tmp.GetType (), typeof (TValue)));
-                       return value != null;
+                               throw new ArgumentException (String.Format ("The value of property '{0}' is of type '{1}', while '{2}' is expected.", propertyName, tmp.GetType (), typeof (TValue)));
+                       return result != null;
                }
        }
 }
index e82c35c1f6229918579e16ccee0ef3cf053a26b4..808479b45e10d73723a0a297e6aa43a14447b7be 100644 (file)
@@ -54,10 +54,10 @@ namespace System.IdentityModel.Tokens
                        return (byte []) GetRawBuffer ().Clone ();
                }
 
-               public override bool Matches (SecurityKeyIdentifierClause clause)
+               public override bool Matches (SecurityKeyIdentifierClause keyIdentifierClause)
                {
                        BinaryKeyIdentifierClause other =
-                               clause as BinaryKeyIdentifierClause;
+                               keyIdentifierClause as BinaryKeyIdentifierClause;
                        if (other == null)
                                return false;
                        return Matches (other.GetRawBuffer ());
index d835a6acc8e3f9aa55bf18f950ca5b60981c1380..6b7625c16a52bc71c577a7b71f90f46df324e33d 100644 (file)
@@ -1,4 +1,4 @@
-//
+//
 // BootstrapContext.cs
 //
 // Author:
@@ -60,14 +60,14 @@ namespace System.IdentityModel.Tokens {
                }
 
                /// <summary>Initializes a new instance of the <see cref="BootstrapContext"/> class by using the specified security token and token handler.</summary>
-               public BootstrapContext (SecurityToken token, SecurityTokenHandler handler)
+               public BootstrapContext (SecurityToken token, SecurityTokenHandler tokenHandler)
                {
                        if (token == null)
                                throw new ArgumentNullException ("token");
-                       if (handler == null)
-                               throw new ArgumentNullException ("handler");
+                       if (tokenHandler == null)
+                               throw new ArgumentNullException ("tokenHandler");
                        SecurityToken = token;
-                       SecurityTokenHandler = handler;
+                       SecurityTokenHandler = tokenHandler;
                }
 
                /// <summary>Initializes a new instance of the <see cref="BootstrapContext"/> class from a stream.</summary>
index 102a45afaf36583f18b8130287e9de446cf4be83..ea9b1c079e8ad806a6f744f88316139cb5bb52e4 100644 (file)
@@ -42,26 +42,26 @@ namespace System.IdentityModel.Tokens
 
                public EncryptedKeyIdentifierClause (
                        byte [] encryptedKey, string encryptionMethod, 
-                       SecurityKeyIdentifier identifier)
-                       : this (encryptedKey, encryptionMethod, identifier, null)
+                       SecurityKeyIdentifier encryptingKeyIdentifier)
+                       : this (encryptedKey, encryptionMethod, encryptingKeyIdentifier, null)
                {
                }
 
                public EncryptedKeyIdentifierClause (
                        byte [] encryptedKey, string encryptionMethod,
-                       SecurityKeyIdentifier identifier, string carriedKeyName)
-                       : this (encryptedKey, encryptionMethod, identifier, carriedKeyName, null, 0)
+                       SecurityKeyIdentifier encryptingKeyIdentifier, string carriedKeyName)
+                       : this (encryptedKey, encryptionMethod, encryptingKeyIdentifier, carriedKeyName, null, 0)
                {
                }
 
                public EncryptedKeyIdentifierClause (
                        byte [] encryptedKey, string encryptionMethod,
-                       SecurityKeyIdentifier identifier, string carriedKeyName,
+                       SecurityKeyIdentifier encryptingKeyIdentifier, string carriedKeyName,
                        byte [] derivationNonce, int derivationLength)
                        : base (encryptionMethod, encryptedKey, true, derivationNonce, derivationLength)
                {
                        this.carried_key_name = carriedKeyName;
-                       this.identifier = identifier;
+                       this.identifier = encryptingKeyIdentifier;
                        this.enc_method = encryptionMethod;
                }
 
@@ -100,10 +100,10 @@ namespace System.IdentityModel.Tokens
                        return true;
                }
 
-               public override bool Matches (SecurityKeyIdentifierClause clause)
+               public override bool Matches (SecurityKeyIdentifierClause keyIdentifierClause)
                {
                        EncryptedKeyIdentifierClause e =
-                               clause as EncryptedKeyIdentifierClause;
+                               keyIdentifierClause as EncryptedKeyIdentifierClause;
                        return e != null && Matches (e.GetRawBuffer (), e.EncryptionMethod, e.CarriedKeyName);
                }
 
index e503a3588691dd02f9dc7a208c66c376f5f46d97..8b845d14b0aeb0682941dffaa8368b384b9b10b6 100644 (file)
@@ -111,7 +111,7 @@ namespace System.IdentityModel.Tokens
 
                [MonoTODO]
                public override bool MatchesKeyIdentifierClause (
-                       SecurityKeyIdentifierClause skiClause)
+                       SecurityKeyIdentifierClause keyIdentifierClause)
                {
                        throw new NotImplementedException ();
                }
index b6a0f8c329c80f5610474da9a3b1e50a2884bf7f..014d8a70f7f2686cd87480b0e296d6aefac06e18 100644 (file)
@@ -42,16 +42,16 @@ namespace System.IdentityModel.Tokens
        {
                byte [] key;
 
-               public InMemorySymmetricSecurityKey (byte [] key)
-                       : this (key, true)
+               public InMemorySymmetricSecurityKey (byte [] symmetricKey)
+                       : this (symmetricKey, true)
                {
                }
 
-               public InMemorySymmetricSecurityKey (byte [] key, bool clone)
+               public InMemorySymmetricSecurityKey (byte [] symmetricKey, bool cloneBuffer)
                {
-                       if (key == null)
-                               throw new ArgumentNullException ("key");
-                       this.key = clone ? (byte []) key.Clone() : key;
+                       if (symmetricKey == null)
+                               throw new ArgumentNullException ("symmetricKey");
+                       this.key = cloneBuffer ? (byte []) symmetricKey.Clone() : symmetricKey;
                }
 
                // SymmetricSecurityKey implementation
index 9d6badcb5f1d544c81c1fd6199d50670c074a31a..610efd0d48da17050d816d7ba364adcf985c1944 100644 (file)
@@ -72,7 +72,7 @@ namespace System.IdentityModel.Tokens
 
                [MonoTODO]
                public override bool MatchesKeyIdentifierClause (
-                       SecurityKeyIdentifierClause skiClause)
+                       SecurityKeyIdentifierClause keyIdentifierClause)
                {
                        throw new NotImplementedException ();
                }
index 3de266be9eca04ffc419134f9581fbfc9624696f..aabede60c0e87a1984bf02c19d2677faea64ac79 100644 (file)
@@ -98,7 +98,7 @@ namespace System.IdentityModel.Tokens
 
                [MonoTODO]
                public override bool MatchesKeyIdentifierClause (
-                       SecurityKeyIdentifierClause skiClause)
+                       SecurityKeyIdentifierClause keyIdentifierClause)
                {
                        throw new NotImplementedException ();
                }
index 82dbb01c4f21d253722086754148698838474189..c58bc50c99b6a1afe2974131148c18c358956494 100644 (file)
@@ -62,12 +62,12 @@ namespace System.IdentityModel.Tokens
                        get { return owner_type; }
                }
 
-               public override bool Matches (SecurityKeyIdentifierClause clause)
+               public override bool Matches (SecurityKeyIdentifierClause keyIdentifierClause)
                {
-                       if (clause == null)
-                               throw new ArgumentNullException ("clause");
+                       if (keyIdentifierClause == null)
+                               throw new ArgumentNullException ("keyIdentifierClause");
                        LocalIdKeyIdentifierClause c =
-                               clause as LocalIdKeyIdentifierClause;
+                               keyIdentifierClause as LocalIdKeyIdentifierClause;
                        return c != null && Matches (c.LocalId, c.OwnerType);
                }
 
index a06b6a38fa13f7b71e6843e3162c72beaedc241b..a448130eef33b52644b1a3feab579e60f88ad839 100644 (file)
@@ -78,12 +78,12 @@ namespace System.IdentityModel.Tokens
                        throw new NotImplementedException ();
                }
 
-               public override bool Matches (SecurityKeyIdentifierClause clause)
+               public override bool Matches (SecurityKeyIdentifierClause keyIdentifierClause)
                {
-                       if (clause == null)
-                               throw new ArgumentNullException ("clause");
+                       if (keyIdentifierClause == null)
+                               throw new ArgumentNullException ("keyIdentifierClause");
                        RsaKeyIdentifierClause rkic =
-                               clause as RsaKeyIdentifierClause;
+                               keyIdentifierClause as RsaKeyIdentifierClause;
                        return rkic != null && Matches (rkic.Rsa);
                }
 
index b1cc2bf2ee3957350cce6d3017fd59ba37bd19d1..2f5031ea72cd19ca70644c4ed2f61178bae0d248 100644 (file)
@@ -46,7 +46,7 @@ namespace System.IdentityModel.Tokens
 
                [MonoTODO]
                public override AsymmetricAlgorithm GetAsymmetricAlgorithm (
-                       string algorithm, bool privateKey)
+                       string algorithm, bool requiresPrivateKey)
                {
                        throw new NotImplementedException ();
                }
index c44bc1dc99851a604e91d945f7246447d8afcc8c..b3fd1fafd0c9e4ad0c89ac4fd9ece95ebc9e9605 100644 (file)
@@ -87,7 +87,7 @@ namespace System.IdentityModel.Tokens
 
                [MonoTODO]
                public override bool MatchesKeyIdentifierClause (
-                       SecurityKeyIdentifierClause skiClause)
+                       SecurityKeyIdentifierClause keyIdentifierClause)
                {
                        throw new NotImplementedException ();
                }
index 7deb10412229ec9d1714b7ee15b17c9cef661849..8f07e506e3297a8f5b1d04a50857b2279fb9d3ad 100644 (file)
@@ -87,7 +87,7 @@ namespace System.IdentityModel.Tokens
 
                public virtual void ReadXml (XmlDictionaryReader reader,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer,
+                       SecurityTokenSerializer keyInfoSerializer,
                        SecurityTokenResolver outOfBandTokenResolver)
                {
                        if (reader == null)
@@ -104,7 +104,7 @@ namespace System.IdentityModel.Tokens
 
                public virtual void WriteXml (XmlDictionaryWriter writer,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer)
+                       SecurityTokenSerializer keyInfoSerializer)
                {
                        if (writer == null)
                                throw new ArgumentNullException ("writer");
index 306de28a9083aebf0cd0afedd578d0ed80d76655..b4b295a687571f026332a212c0bc06536e7dffa1 100644 (file)
@@ -89,7 +89,7 @@ namespace System.IdentityModel.Tokens
 
                public virtual void ReadXml (XmlDictionaryReader reader,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer,
+                       SecurityTokenSerializer keyInfoSerializer,
                        SecurityTokenResolver outOfBandTokenResolver)
                {
                        if (reader == null)
@@ -105,7 +105,7 @@ namespace System.IdentityModel.Tokens
                                switch (reader.LocalName) {
                                case "Assertion":
                                        SamlAssertion a = new SamlAssertion ();
-                                       a.ReadXml (reader, samlSerializer, keyInfoTokenSerializer, outOfBandTokenResolver);
+                                       a.ReadXml (reader, samlSerializer, keyInfoSerializer, outOfBandTokenResolver);
                                        assertions.Add (a);
                                        break;
                                case "AssertionIDReference":
@@ -120,7 +120,7 @@ namespace System.IdentityModel.Tokens
 
                public virtual void WriteXml (XmlDictionaryWriter writer,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer)
+                       SecurityTokenSerializer keyInfoSerializer)
                {
                        if (writer == null)
                                throw new ArgumentNullException ("writer");
@@ -130,7 +130,7 @@ namespace System.IdentityModel.Tokens
                        foreach (string idref in AssertionIdReferences)
                                writer.WriteElementString ("saml", "AssertionIDReference", SamlConstants.Namespace, idref);
                        foreach (SamlAssertion assertion in Assertions)
-                               assertion.WriteXml (writer, samlSerializer, keyInfoTokenSerializer);
+                               assertion.WriteXml (writer, samlSerializer, keyInfoSerializer);
                        writer.WriteEndElement ();
                }
        }
index 65715ee56b9e5e5ffb00b06f5672221426bb47e2..43d54cc3f6bbe26a7d692c8a4d77ba3368724609 100644 (file)
@@ -53,16 +53,16 @@ namespace System.IdentityModel.Tokens
                }
 
                public SamlAssertion (string assertionId, string issuer,
-                       DateTime issueInstant, SamlConditions conditions,
-                       SamlAdvice advice, IEnumerable<SamlStatement> statements)
+                       DateTime issueInstant, SamlConditions samlConditions,
+                       SamlAdvice samlAdvice, IEnumerable<SamlStatement> samlStatements)
                {
                        if (IsInvalidAssertionId (assertionId))
                                throw new ArgumentException (String.Format ("The assertionId '{0}' must be a valid XML NCName.", assertionId));
 
                        if (issuer == null || issuer.Length == 0)
                                throw new ArgumentException ("issuer");
-                       if (statements == null)
-                               throw new ArgumentNullException ("statements");
+                       if (samlStatements == null)
+                               throw new ArgumentNullException ("samlStatements");
 
                        major = 1;
                        minor = 1;
@@ -70,9 +70,9 @@ namespace System.IdentityModel.Tokens
                        assertion_id = assertionId;
                        this.issuer = issuer;
                        issue_instant = issueInstant;
-                       this.conditions = conditions;
-                       this.advice = advice;
-                       foreach (SamlStatement s in statements) {
+                       this.conditions = samlConditions;
+                       this.advice = samlAdvice;
+                       foreach (SamlStatement s in samlStatements) {
                                if (s == null)
                                        throw new ArgumentException ("statements contain null item.");
                                this.statements.Add (s);
@@ -180,7 +180,7 @@ namespace System.IdentityModel.Tokens
                [MonoTODO]
                public virtual void ReadXml (XmlDictionaryReader reader,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer,
+                       SecurityTokenSerializer keyInfoSerializer,
                        SecurityTokenResolver outOfBandTokenResolver)
                {
                        throw new NotImplementedException ();
@@ -188,7 +188,7 @@ namespace System.IdentityModel.Tokens
 
                public virtual void WriteXml (XmlDictionaryWriter writer,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer)
+                       SecurityTokenSerializer keyInfoSerializer)
                {
                        if (writer == null)
                                throw new ArgumentNullException ("writer");
@@ -211,11 +211,11 @@ namespace System.IdentityModel.Tokens
 
                        try {
                                if (Conditions != null)
-                                       Conditions.WriteXml (writer, samlSerializer, keyInfoTokenSerializer);
+                                       Conditions.WriteXml (writer, samlSerializer, keyInfoSerializer);
                                if (Advice != null)
-                                       Advice.WriteXml (writer, samlSerializer, keyInfoTokenSerializer);
+                                       Advice.WriteXml (writer, samlSerializer, keyInfoSerializer);
                                foreach (SamlStatement statement in Statements)
-                                       statement.WriteXml (writer, samlSerializer, keyInfoTokenSerializer);
+                                       statement.WriteXml (writer, samlSerializer, keyInfoSerializer);
                        } catch (NotImplementedException) {
                                throw;
                        } catch (Exception ex) { // bad catch, eh?
@@ -226,7 +226,7 @@ namespace System.IdentityModel.Tokens
 
                [MonoTODO]
                protected void ReadSignature (XmlDictionaryReader reader,
-                       SecurityTokenSerializer keyInfoTokenSerializer,
+                       SecurityTokenSerializer keyInfoSerializer,
                        SecurityTokenResolver outOfBandTokenResolver,
                        SamlSerializer samlSerializer)
                {
index 61bf8b4de8577f4cff4f5b3286045e03f87c13b9..33d76628e4b4b7d584e2142fdc3c89e78b3d6d03 100644 (file)
@@ -49,7 +49,7 @@ namespace System.IdentityModel.Tokens
                }
 
                [MonoTODO]
-               public override bool Matches (SecurityKeyIdentifierClause clause)
+               public override bool Matches (SecurityKeyIdentifierClause keyIdentifierClause)
                {
                        throw new NotImplementedException ();
                }
index 92605125f51083b009f14cd9e9dfd363bb7615a2..f1e54538329887ad3e6cc04c9a89b8c637d6d4b4 100644 (file)
@@ -114,7 +114,7 @@ namespace System.IdentityModel.Tokens
                [MonoTODO]
                public virtual void ReadXml (XmlDictionaryReader reader,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer,
+                       SecurityTokenSerializer keyInfoSerializer,
                        SecurityTokenResolver outOfBandTokenResolver)
                {
                        throw new NotImplementedException ();
@@ -122,7 +122,7 @@ namespace System.IdentityModel.Tokens
 
                public virtual void WriteXml (XmlDictionaryWriter writer,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer)
+                       SecurityTokenSerializer keyInfoSerializer)
                {
                        writer.WriteStartElement ("saml", "Attribute", SamlConstants.Namespace);
                        writer.WriteAttributeString ("AttributeName", Name);
index abd6206926f802c815d7dcac868188a5ddd3ffa3..0ef757e5d4d0140daf85380b48c3a93dfd2a6e57 100644 (file)
@@ -66,7 +66,7 @@ namespace System.IdentityModel.Tokens
                [MonoTODO]
                public override void ReadXml (XmlDictionaryReader reader,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer,
+                       SecurityTokenSerializer keyInfoSerializer,
                        SecurityTokenResolver outOfBandTokenResolver)
                {
                        throw new NotImplementedException ();
@@ -74,14 +74,14 @@ namespace System.IdentityModel.Tokens
 
                public override void WriteXml (XmlDictionaryWriter writer,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer)
+                       SecurityTokenSerializer keyInfoSerializer)
                {
                        if (SamlSubject == null)
                                throw new SecurityTokenException ("Subject is null in the AttributeStatement");
                        writer.WriteStartElement ("saml", "AttributeStatement", SamlConstants.Namespace);
-                       SamlSubject.WriteXml (writer, samlSerializer, keyInfoTokenSerializer);
+                       SamlSubject.WriteXml (writer, samlSerializer, keyInfoSerializer);
                        foreach (SamlAttribute a in Attributes)
-                               a.WriteXml (writer, samlSerializer, keyInfoTokenSerializer);
+                               a.WriteXml (writer, samlSerializer, keyInfoSerializer);
                        writer.WriteEndElement ();
                }
 
index 4dd369238f89ab101a9ac43cefafd3f898ddbc27..13e07b66be89d23a7e35186fd524b0d33e8ad1e1 100644 (file)
@@ -124,7 +124,7 @@ namespace System.IdentityModel.Tokens
                [MonoTODO]
                public override void ReadXml (XmlDictionaryReader reader,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer,
+                       SecurityTokenSerializer keyInfoSerializer,
                        SecurityTokenResolver outOfBandTokenResolver)
                {
                        throw new NotImplementedException ();
@@ -132,7 +132,7 @@ namespace System.IdentityModel.Tokens
 
                public override void WriteXml (XmlDictionaryWriter writer,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer)
+                       SecurityTokenSerializer keyInfoSerializer)
                {
                        if (writer == null)
                                throw new ArgumentNullException ("writer");
@@ -145,7 +145,7 @@ namespace System.IdentityModel.Tokens
                        writer.WriteAttributeString ("AuthenticationMethod", AuthenticationMethod);
                        writer.WriteAttributeString ("AuthenticationInstant", 
                                AuthenticationInstant.ToString (SamlConstants.DateFormat, CultureInfo.InvariantCulture));
-                       SamlSubject.WriteXml (writer, samlSerializer, keyInfoTokenSerializer);
+                       SamlSubject.WriteXml (writer, samlSerializer, keyInfoSerializer);
                        if (DnsAddress != null || IPAddress != null) {
                                writer.WriteStartElement ("saml", "SubjectLocality", SamlConstants.Namespace);
                                if (IPAddress != null)
index 8949c160ee1bd103cdc6267460f18d5e5bef366e..e9d8d77507dd5ac3b988c28c68a8e7f15512a503 100644 (file)
@@ -46,11 +46,11 @@ namespace System.IdentityModel.Tokens
                {
                }
 
-               public SamlAuthorityBinding (XmlQualifiedName kind, string binding, string location)
+               public SamlAuthorityBinding (XmlQualifiedName authorityKind, string binding, string location)
                {
-                       if (kind == null)
-                               throw new ArgumentNullException ("kind");
-                       AuthorityKind = kind;
+                       if (authorityKind == null)
+                               throw new ArgumentNullException ("authorityKind");
+                       AuthorityKind = authorityKind;
                        Binding = binding;
                        Location = location;
                }
index 94d3813459df62b6094aae68956aeb1cc030773d..16dfcce1d6285bbe9a61dcbdc3b8622403f631c0 100644 (file)
@@ -39,10 +39,10 @@ namespace System.IdentityModel.Tokens
        public class SamlAuthorizationDecisionClaimResource
        {
                public SamlAuthorizationDecisionClaimResource (
-                       string resource, SamlAccessDecision decision, string actionName, string actionNamespace)
+                       string resource, SamlAccessDecision accessDecision, string actionNamespace, string actionName)
                {
                        this.resource = resource;
-                       this.decision = decision;
+                       this.decision = accessDecision;
                        this.name = actionName;
                        this.ns = actionNamespace;
                }
index 816c2369fbdaebab768a9a37a2e49cdeec6c3859..a3cd23bbb9b717eb2b420d43f9eee2dab502d6fa 100644 (file)
@@ -132,7 +132,7 @@ namespace System.IdentityModel.Tokens
                public override void ReadXml (XmlDictionaryReader reader,
                        SamlSerializer samlSerializer, 
                        SecurityTokenSerializer keyInfoSerializer, 
-                       SecurityTokenResolver resolver)
+                       SecurityTokenResolver outOfBandTokenResolver)
                {
                        if (reader == null)
                                throw new ArgumentNullException ("reader");
@@ -159,20 +159,20 @@ namespace System.IdentityModel.Tokens
 
                        reader.MoveToContent ();
                        SamlSubject = new SamlSubject ();
-                       SamlSubject.ReadXml (reader, samlSerializer, keyInfoSerializer, resolver);
+                       SamlSubject.ReadXml (reader, samlSerializer, keyInfoSerializer, outOfBandTokenResolver);
                        SamlActions.Clear ();
                        for (reader.MoveToContent ();
                             reader.LocalName == "Action" &&
                             reader.NamespaceURI == SamlConstants.Namespace;
                             reader.MoveToContent ()) {
                                SamlAction action = new SamlAction ();
-                               action.ReadXml (reader, samlSerializer, keyInfoSerializer, resolver);
+                               action.ReadXml (reader, samlSerializer, keyInfoSerializer, outOfBandTokenResolver);
                                SamlActions.Add (action);
                        }
                        if (reader.LocalName == "Evidence" &&
                            reader.NamespaceURI == SamlConstants.Namespace) {
                                Evidence = new SamlEvidence ();
-                               Evidence.ReadXml (reader, samlSerializer, keyInfoSerializer, resolver);
+                               Evidence.ReadXml (reader, samlSerializer, keyInfoSerializer, outOfBandTokenResolver);
                                reader.MoveToContent ();
                        }
                        reader.ReadEndElement ();
index e4e956844821b4d60c059a3d08520045149ec94f..d72e789b310facbad8edd086726ee3d3e0804ba4 100644 (file)
@@ -102,7 +102,7 @@ namespace System.IdentityModel.Tokens
                [MonoTODO]
                public virtual void ReadXml (XmlDictionaryReader reader,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer,
+                       SecurityTokenSerializer keyInfoSerializer,
                        SecurityTokenResolver outOfBandTokenResolver)
                {
                        throw new NotImplementedException ();
@@ -110,7 +110,7 @@ namespace System.IdentityModel.Tokens
 
                public virtual void WriteXml (XmlDictionaryWriter writer,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer)
+                       SecurityTokenSerializer keyInfoSerializer)
                {
                        if (writer == null)
                                throw new ArgumentNullException ("writer");
@@ -123,7 +123,7 @@ namespace System.IdentityModel.Tokens
                        if (has_not_on_after)
                                writer.WriteAttributeString ("NotOnOrAfter", NotOnOrAfter.ToString (SamlConstants.DateFormat, invariant));
                        foreach (SamlCondition cond in Conditions)
-                               cond.WriteXml (writer, samlSerializer, keyInfoTokenSerializer);
+                               cond.WriteXml (writer, samlSerializer, keyInfoSerializer);
                        writer.WriteEndElement ();
                }
        }
index 65469029179324979a089ef0435609acdd58e1a9..dd66972c5026b26bf60cd86fc7eac201fa4b0109 100644 (file)
@@ -100,7 +100,7 @@ namespace System.IdentityModel.Tokens
                public virtual void ReadXml (XmlDictionaryReader reader,
                        SamlSerializer samlSerializer, 
                        SecurityTokenSerializer keyInfoSerializer, 
-                       SecurityTokenResolver resolver)
+                       SecurityTokenResolver outOfBandTokenResolver)
                {
                        if (reader == null)
                                throw new ArgumentNullException ("reader");
@@ -118,7 +118,7 @@ namespace System.IdentityModel.Tokens
                                switch (reader.LocalName) {
                                case "Assertion":
                                        SamlAssertion a = new SamlAssertion ();
-                                       a.ReadXml (reader, samlSerializer, keyInfoSerializer, resolver);
+                                       a.ReadXml (reader, samlSerializer, keyInfoSerializer, outOfBandTokenResolver);
                                        assertions.Add (a);
                                        break;
                                case "AssertionIDReference":
index c2d1538d1d0f9a47f1d37f3f040ead9fe037136e..7f58a9f2a6a84a119a76e5c7b0378c5e52c03ece 100644 (file)
@@ -87,7 +87,7 @@ namespace System.IdentityModel.Tokens
 
                [MonoTODO]
                public override bool MatchesKeyIdentifierClause (
-                       SecurityKeyIdentifierClause skiClause)
+                       SecurityKeyIdentifierClause keyIdentifierClause)
                {
                        throw new NotImplementedException ();
                }
index 85c1ea1c619802f6e1785947e8b0b1b7e146b5a4..03ff28b46a68b65b1aba687eca10da33ae1dedc9 100644 (file)
@@ -43,56 +43,56 @@ namespace System.IdentityModel.Tokens
 
                [MonoTODO]
                public virtual SamlAdvice LoadAdvice (XmlDictionaryReader reader,
-                       SecurityTokenSerializer tokenSerializer,
-                       SecurityTokenResolver tokenResolver)
+                       SecurityTokenSerializer keyInfoSerializer,
+                       SecurityTokenResolver outOfBandTokenResolver)
                {
                        throw new NotImplementedException ();
                }
 
                [MonoTODO]
                public virtual SamlAssertion LoadAssertion (XmlDictionaryReader reader,
-                       SecurityTokenSerializer tokenSerializer,
-                       SecurityTokenResolver tokenResolver)
+                       SecurityTokenSerializer keyInfoSerializer,
+                       SecurityTokenResolver outOfBandTokenResolver)
                {
                        throw new NotImplementedException ();
                }
 
                [MonoTODO]
                public virtual SamlAttribute LoadAttribute (XmlDictionaryReader reader,
-                       SecurityTokenSerializer tokenSerializer,
-                       SecurityTokenResolver tokenResolver)
+                       SecurityTokenSerializer keyInfoSerializer,
+                       SecurityTokenResolver outOfBandTokenResolver)
                {
                        throw new NotImplementedException ();
                }
 
                [MonoTODO]
                public virtual SamlCondition LoadCondition (XmlDictionaryReader reader,
-                       SecurityTokenSerializer tokenSerializer,
-                       SecurityTokenResolver tokenResolver)
+                       SecurityTokenSerializer keyInfoSerializer,
+                       SecurityTokenResolver outOfBandTokenResolver)
                {
                        throw new NotImplementedException ();
                }
 
                [MonoTODO]
                public virtual SamlConditions LoadConditions (XmlDictionaryReader reader,
-                       SecurityTokenSerializer tokenSerializer,
-                       SecurityTokenResolver tokenResolver)
+                       SecurityTokenSerializer keyInfoSerializer,
+                       SecurityTokenResolver outOfBandTokenResolver)
                {
                        throw new NotImplementedException ();
                }
 
                [MonoTODO]
                public virtual SamlStatement LoadStatement (XmlDictionaryReader reader,
-                       SecurityTokenSerializer tokenSerializer,
-                       SecurityTokenResolver tokenResolver)
+                       SecurityTokenSerializer keyInfoSerializer,
+                       SecurityTokenResolver outOfBandTokenResolver)
                {
                        throw new NotImplementedException ();
                }
 
                [MonoTODO]
                public virtual SamlSecurityToken ReadToken (XmlReader reader,
-                       SecurityTokenSerializer tokenSerializer,
-                       SecurityTokenResolver tokenResolver)
+                       SecurityTokenSerializer keyInfoSerializer,
+                       SecurityTokenResolver outOfBandTokenResolver)
                {
                        throw new NotImplementedException ();
                }
index 4feb41544bf0098091cd7aa9ae4b22cc53d3c40b..4917cf161f51b2bbdaefb2defbef423ba6829857 100644 (file)
@@ -49,11 +49,11 @@ namespace System.IdentityModel.Tokens
 
                public abstract void ReadXml (XmlDictionaryReader reader,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer,
+                       SecurityTokenSerializer keyInfoSerializer,
                        SecurityTokenResolver outOfBandTokenResolver);
 
                public abstract void WriteXml (XmlDictionaryWriter writer,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer);
+                       SecurityTokenSerializer keyInfoSerializer);
        }
 }
index 975f9727e1931ef6870d3253efae2177e2b66a52..c456500a118d50b14c8534a90afc58552f924528 100644 (file)
@@ -153,7 +153,7 @@ namespace System.IdentityModel.Tokens
 
                public virtual void ReadXml (XmlDictionaryReader reader,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer,
+                       SecurityTokenSerializer keyInfoSerializer,
                        SecurityTokenResolver outOfBandTokenResolver)
                {
                        if (reader == null)
@@ -173,7 +173,7 @@ namespace System.IdentityModel.Tokens
 
                public virtual void WriteXml (XmlDictionaryWriter writer,
                        SamlSerializer samlSerializer,
-                       SecurityTokenSerializer keyInfoTokenSerializer)
+                       SecurityTokenSerializer keyInfoSerializer)
                {
                        if (writer == null)
                                throw new ArgumentNullException ("writer");
index 302fe39cf053f9d756780609139d92619e924c5a..bf35190026f86b722982909afc14a548558b469d 100644 (file)
@@ -42,9 +42,9 @@ namespace System.IdentityModel.Tokens
                        this.list = new List<SecurityKeyIdentifierClause> ();
                }
 
-               public SecurityKeyIdentifier (params SecurityKeyIdentifierClause [] identifiers)
+               public SecurityKeyIdentifier (params SecurityKeyIdentifierClause [] clauses)
                {
-                       this.list = new List<SecurityKeyIdentifierClause> (identifiers);
+                       this.list = new List<SecurityKeyIdentifierClause> (clauses);
                }
 
                List<SecurityKeyIdentifierClause> list;
@@ -67,15 +67,15 @@ namespace System.IdentityModel.Tokens
                        get { return is_readonly; }
                }
 
-               public SecurityKeyIdentifierClause this [int i] {
-                       get { return list [i]; }
+               public SecurityKeyIdentifierClause this [int index] {
+                       get { return list [index]; }
                }
 
-               public void Add (SecurityKeyIdentifierClause item)
+               public void Add (SecurityKeyIdentifierClause clause)
                {
                        if (is_readonly)
                                throw new InvalidOperationException ("This SecurityKeyIdentifier is read-only.");
-                       list.Add (item);
+                       list.Add (clause);
                }
 
                public SecurityKey CreateKey ()
@@ -121,13 +121,13 @@ namespace System.IdentityModel.Tokens
                        return sb.ToString ();
                }
 
-               public bool TryFind<TClause> (out TClause result)
+               public bool TryFind<TClause> (out TClause clause)
                        where TClause : SecurityKeyIdentifierClause
                {
-                       result = default (TClause);
+                       clause = default (TClause);
                        foreach (SecurityKeyIdentifierClause kic in this)
                                if (typeof (TClause).IsAssignableFrom (kic.GetType ())) {
-                                       result = (TClause) kic;
+                                       clause = (TClause) kic;
                                        return true;
                                }
                        return false;
index 1dba4954631b1a7f4cb250a028dd50ad99f72dbb..d464e524bcc9ff85865cff6eab84ec008f08a9bd 100644 (file)
@@ -39,12 +39,12 @@ namespace System.IdentityModel.Tokens
                        this.clause_type = clauseType;
                }
 
-               protected SecurityKeyIdentifierClause (string clauseType, byte [] derivationNonce, int derivationLength)
+               protected SecurityKeyIdentifierClause (string clauseType, byte [] nonce, int length)
                {
                        this.clause_type = clauseType;
-                       if (derivationNonce != null)
-                               this.nonce = (byte []) derivationNonce.Clone ();
-                       this.deriv_length = derivationLength;
+                       if (nonce != null)
+                               this.nonce = (byte []) nonce.Clone ();
+                       this.deriv_length = length;
                }
 
                string clause_type;
@@ -76,7 +76,7 @@ namespace System.IdentityModel.Tokens
                }
 
                [MonoTODO]
-               public virtual bool Matches (SecurityKeyIdentifierClause clause)
+               public virtual bool Matches (SecurityKeyIdentifierClause keyIdentifierClause)
                {
                        throw new NotImplementedException ();
                }
index 23a636626f8b237bab21a4940d6cc63820fca821..335808fc560caf14d12484c68e76c0d0cd159816 100644 (file)
@@ -63,24 +63,24 @@ namespace System.IdentityModel.Tokens
                }
 
                public virtual bool MatchesKeyIdentifierClause (
-                       SecurityKeyIdentifierClause skiClause)
+                       SecurityKeyIdentifierClause keyIdentifierClause)
                {
                        return false;
                }
 
                [MonoTODO]
                public virtual SecurityKey ResolveKeyIdentifierClause (
-                       SecurityKeyIdentifierClause skiClause)
+                       SecurityKeyIdentifierClause keyIdentifierClause)
                {
-                       if (skiClause == null)
-                               throw new ArgumentNullException ("skiClause");
-                       if (!MatchesKeyIdentifierClause (skiClause))
-                               throw new InvalidOperationException (String.Format ("This '{0}' security token does not support resolving '{1}' key identifier clause.", GetType (), skiClause));
-                       if (skiClause.CanCreateKey)
-                               return skiClause.CreateKey ();
+                       if (keyIdentifierClause == null)
+                               throw new ArgumentNullException ("keyIdentifierClause");
+                       if (!MatchesKeyIdentifierClause (keyIdentifierClause))
+                               throw new InvalidOperationException (String.Format ("This '{0}' security token does not support resolving '{1}' key identifier clause.", GetType (), keyIdentifierClause));
+                       if (keyIdentifierClause.CanCreateKey)
+                               return keyIdentifierClause.CreateKey ();
                        // FIXME: examine it.
                        if (SecurityKeys.Count == 0)
-                               throw new InvalidOperationException (String.Format ("This '{0}' security token does not have any keys that can be resolved.", GetType (), skiClause));
+                               throw new InvalidOperationException (String.Format ("This '{0}' security token does not have any keys that can be resolved.", GetType (), keyIdentifierClause));
                        return SecurityKeys [0];
                }
        }
index bdd6eb50e03aff0028500d722832153a117d6f8d..9ce9eb87b33272c5e3f791ceeaf129c7e4271821 100644 (file)
@@ -35,8 +35,8 @@ namespace System.IdentityModel.Tokens
        public class SecurityTokenException : SystemException
        {
                public SecurityTokenException () : base () {}
-               public SecurityTokenException (string msg) : base (msg) {}
-               public SecurityTokenException (string msg, Exception inner) : base (msg, inner) {}
+               public SecurityTokenException (string message) : base (message) {}
+               public SecurityTokenException (string message, Exception innerException) : base (message, innerException) {}
                protected SecurityTokenException (SerializationInfo info, StreamingContext context) :
                        base (info, context) {}
        }
index c5301cd6f8ed148697bfe4d831dfe65896fd38e2..9aaf39d51a02d83460a1ddddff02475ed9a68474 100644 (file)
@@ -1,4 +1,4 @@
-//
+//
 // SecurityTokenExpiredException.cs
 //
 // Author:
@@ -41,8 +41,8 @@ namespace System.IdentityModel.Tokens
                        : base(message)
                { }
 
-               public SecurityTokenExpiredException(string message, Exception innerException)
-                       : base(message, innerException)
+               public SecurityTokenExpiredException(string message, Exception inner)
+                       : base(message, inner)
                { }
 
                public SecurityTokenExpiredException(SerializationInfo info, StreamingContext context)
index 4f9e5f18f6c928ec20824583f523e6faa596c327..4f4b76d676ef013d57e2aaf4bfc3a4a39491c4cb 100644 (file)
@@ -1,4 +1,4 @@
-//
+//
 // SecurityTokenNotYetValidException.cs
 //
 // Author:
@@ -41,8 +41,8 @@ namespace System.IdentityModel.Tokens
                        : base(message)
                { }
 
-               public SecurityTokenNotYetValidException(string message, Exception innerException)
-                       : base(message, innerException)
+               public SecurityTokenNotYetValidException(string message, Exception inner)
+                       : base(message, inner)
                { }
 
                public SecurityTokenNotYetValidException(SerializationInfo info, StreamingContext context)
index e04d0cbd28e59ee712b2e6cf15222a5dc3d35cb1..b0113defd8bbe701968794c4622d2e46cc4bbcf8 100644 (file)
@@ -1,4 +1,4 @@
-//
+//
 // SecurityTokenReplayDetectedException.cs
 //
 // Author:
@@ -41,8 +41,8 @@ namespace System.IdentityModel.Tokens
                        : base(message)
                { }
 
-               public SecurityTokenReplayDetectedException(string message, Exception innerException)
-                       : base(message, innerException)
+               public SecurityTokenReplayDetectedException(string message, Exception inner)
+                       : base(message, inner)
                { }
 
                public SecurityTokenReplayDetectedException(SerializationInfo info, StreamingContext context)
index 72189b8b97db6f716dbc846b80a0389b89bd8a84..e9c5bc879b4d8e2e59efa8814f2cba94e24c1430 100644 (file)
@@ -35,8 +35,8 @@ namespace System.IdentityModel.Tokens
        public class SecurityTokenValidationException : SecurityTokenException
        {
                public SecurityTokenValidationException () : base () {}
-               public SecurityTokenValidationException (string msg) : base (msg) {}
-               public SecurityTokenValidationException (string msg, Exception inner) : base (msg, inner) {}
+               public SecurityTokenValidationException (string message) : base (message) {}
+               public SecurityTokenValidationException (string message, Exception innerException) : base (message, innerException) {}
                protected SecurityTokenValidationException (SerializationInfo info, StreamingContext context) :
                        base (info, context) {}
        }
index 66c68c0030ba5da8bf2a7a3152dece259e48429c..1a37602138df09f91b3dd66c69ec277c9b627912 100644 (file)
@@ -42,14 +42,14 @@ namespace System.IdentityModel.Tokens
                }
 
                [MonoTODO]
-               public WindowsSecurityToken (WindowsIdentity identity)
+               public WindowsSecurityToken (WindowsIdentity windowsIdentity)
                {
                        throw new NotImplementedException ();
                }
 
-               public WindowsSecurityToken (WindowsIdentity identity, string id)
+               public WindowsSecurityToken (WindowsIdentity windowsIdentity, string id)
                {
-                       this.identity = identity;
+                       this.identity = windowsIdentity;
                        this.id = id;
                }
 
index f95ec9bb5d43c15b379adee5f9ee4f467477b909..3dc838424de18fc388c254732dcd90c5d0adb4bc 100644 (file)
@@ -99,10 +99,10 @@ namespace System.IdentityModel.Tokens
                        get { return serial; }
                }
 
-               public override bool Matches (SecurityKeyIdentifierClause clause)
+               public override bool Matches (SecurityKeyIdentifierClause keyIdentifierClause)
                {
                        X509IssuerSerialKeyIdentifierClause other =
-                               clause as X509IssuerSerialKeyIdentifierClause;
+                               keyIdentifierClause as X509IssuerSerialKeyIdentifierClause;
                        return other != null && Matches (other.name, other.serial);
                }
 
index fe3751b96a6bd7bc049e0cfea060b403aff115dd..ea545764c01500fec9fc39929f2511785663b230 100644 (file)
@@ -111,27 +111,27 @@ namespace System.IdentityModel.Tokens
 
                [MonoTODO]
                public override bool MatchesKeyIdentifierClause (
-                       SecurityKeyIdentifierClause skiClause)
+                       SecurityKeyIdentifierClause keyIdentifierClause)
                {
                        LocalIdKeyIdentifierClause l =
-                               skiClause as LocalIdKeyIdentifierClause;
+                               keyIdentifierClause as LocalIdKeyIdentifierClause;
                        if (l != null)
                                return l.LocalId == Id;
 
                        X509ThumbprintKeyIdentifierClause t =
-                               skiClause as X509ThumbprintKeyIdentifierClause;
+                               keyIdentifierClause as X509ThumbprintKeyIdentifierClause;
                        if (t != null)
                                return t.Matches (cert);
                        X509IssuerSerialKeyIdentifierClause i =
-                               skiClause as X509IssuerSerialKeyIdentifierClause;
+                               keyIdentifierClause as X509IssuerSerialKeyIdentifierClause;
                        if (i != null)
                                return i.Matches (cert);
                        X509SubjectKeyIdentifierClause s =
-                               skiClause as X509SubjectKeyIdentifierClause;
+                               keyIdentifierClause as X509SubjectKeyIdentifierClause;
                        if (s != null)
                                return s.Matches (cert);
                        X509RawDataKeyIdentifierClause r =
-                               skiClause as X509RawDataKeyIdentifierClause;
+                               keyIdentifierClause as X509RawDataKeyIdentifierClause;
                        if (r != null)
                                return r.Matches (cert);
 
index 9780e8b9e1fbb0f154c6a7b8b569232d3088d98d..b1f7adffe6f318b430609b054033468e7f955269 100644 (file)
@@ -35,8 +35,8 @@ namespace System.IdentityModel.Tokens
        public class X509SubjectKeyIdentifierClause : BinaryKeyIdentifierClause
        {
                [MonoTODO]
-               public X509SubjectKeyIdentifierClause (byte [] certificateSubject)
-                       : base (null, certificateSubject, true)
+               public X509SubjectKeyIdentifierClause (byte [] ski)
+                       : base (null, ski, true)
                {
                        throw new NotImplementedException ();
                }
@@ -66,7 +66,7 @@ namespace System.IdentityModel.Tokens
                }
 
                [MonoTODO]
-               public static bool TryCreateFrom (X509Certificate2 certificate, out X509SubjectKeyIdentifierClause clause)
+               public static bool TryCreateFrom (X509Certificate2 certificate, out X509SubjectKeyIdentifierClause keyIdentifierClause)
                {
                        throw new NotImplementedException ();
                }
index 4b8cdda2edf3f26b6be1ea77740ac4eba9abc3d8..0ae177e7d79357bc14fd9c6b76c53199e23811fa 100644 (file)
@@ -34,8 +34,8 @@ namespace System.IdentityModel.Tokens
 {
        public class X509ThumbprintKeyIdentifierClause : BinaryKeyIdentifierClause
        {
-               public X509ThumbprintKeyIdentifierClause (byte [] certificateThumbprint)
-                       : base (null, certificateThumbprint, true)
+               public X509ThumbprintKeyIdentifierClause (byte [] thumbprint)
+                       : base (null, thumbprint, true)
                {
                }
 
index c2c77269bcbbafe4560fd8362579b7fb7591ded5..fe0c7b52d50c6954bd0be6fe1565da83211c1b87 100644 (file)
@@ -37,16 +37,16 @@ namespace System.IdentityModel.Tokens
        public class X509WindowsSecurityToken : X509SecurityToken
        {
                [MonoTODO]
-               public X509WindowsSecurityToken (X509Certificate2 cert, WindowsIdentity identity)
-                       : base (cert)
+               public X509WindowsSecurityToken (X509Certificate2 certificate, WindowsIdentity windowsIdentity)
+                       : base (certificate)
                {
                        throw new NotImplementedException ();
                }
 
-               public X509WindowsSecurityToken (X509Certificate2 cert, WindowsIdentity identity, string id)
-                       : base (cert, id)
+               public X509WindowsSecurityToken (X509Certificate2 certificate, WindowsIdentity windowsIdentity, string id)
+                       : base (certificate, id)
                {
-                       this.identity = identity;
+                       this.identity = windowsIdentity;
                }
 
                WindowsIdentity identity;
index 0a1f0ceb480dfb7a01364937047ff4eeb076f827..6ce46ff3afd7864ef60d4564b767daea0e21a3bb 100644 (file)
@@ -1,4 +1,4 @@
-//
+//
 // SignatureVerificationFailedException.cs
 //
 // Author:
@@ -41,8 +41,8 @@ namespace System.IdentityModel
                        : base(message)
                { }
 
-               public SignatureVerificationFailedException(string message, Exception innerException)
-                       : base(message, innerException)
+               public SignatureVerificationFailedException(string message, Exception inner)
+                       : base(message, inner)
                { }
 
                public SignatureVerificationFailedException(SerializationInfo info, StreamingContext context)
index 24691a7ce8843b98a15e8def5f03cee83a272375..dcf57c57c857635b0eb672383e371de107a3e86b 100644 (file)
@@ -68,7 +68,7 @@ namespace System.Management
                        throw new NotImplementedException ();
                }
 
-               public virtual void Add (string methodName, ManagementBaseObject inParams, ManagementBaseObject outParams)
+               public virtual void Add (string methodName, ManagementBaseObject inParameters, ManagementBaseObject outParameters)
                {
                        throw new NotImplementedException ();
                }
index 52ddd84da3d6889bdc650f48072c2973778acb42..0dbbbdabad5c4ac82ec73c479e4350e058407670 100644 (file)
@@ -55,18 +55,18 @@ namespace System.Security.Cryptography.Pkcs {
                        _info = new SignerInfoCollection ();
                }
 
-               public SignedCms (ContentInfo content) 
-                       : this (content, false)
+               public SignedCms (ContentInfo contentInfo
+                       : this (contentInfo, false)
                {
                }
 
-               public SignedCms (ContentInfo content, bool detached) 
+               public SignedCms (ContentInfo contentInfo, bool detached) 
                        : this ()
                {
-                       if (content == null)
-                               throw new ArgumentNullException ("content");
+                       if (contentInfo == null)
+                               throw new ArgumentNullException ("contentInfo");
 
-                       _content = content;
+                       _content = contentInfo;
                        _detached = detached;
                }
 
@@ -75,14 +75,14 @@ namespace System.Security.Cryptography.Pkcs {
                        _type = signerIdentifierType;
                }
 
-               public SignedCms (SubjectIdentifierType signerIdentifierType, ContentInfo content) 
-                       : this (content, false) 
+               public SignedCms (SubjectIdentifierType signerIdentifierType, ContentInfo contentInfo
+                       : this (contentInfo, false) 
                {
                        _type = signerIdentifierType;
                }
 
-               public SignedCms (SubjectIdentifierType signerIdentifierType, ContentInfo content, bool detached) 
-                       : this (content, detached) 
+               public SignedCms (SubjectIdentifierType signerIdentifierType, ContentInfo contentInfo, bool detached) 
+                       : this (contentInfo, detached) 
                {
                        _type = signerIdentifierType;
                }
index b927fa2b71bcc88d1ac12e93ab49c8d3b62ed694..9c83f3bb0ab92d69900ac1510cf18bc4661a9588 100644 (file)
@@ -46,8 +46,8 @@ namespace System.Security.Cryptography.Xml {
                {
                }
        
-               public CipherReference (string uri, TransformChain tc)
-                       : base (uri, tc)
+               public CipherReference (string uri, TransformChain transformChain)
+                       : base (uri, transformChain)
                {
                }
        
index 23fedd437a1f7b60676b50c8ca6e5f25f6e9562f..c3aa93666810d79cb9528c1a816d2e4c5c63dbdb 100644 (file)
@@ -48,8 +48,8 @@ namespace System.Security.Cryptography.Xml {
                        ReferenceType = XmlEncryption.ElementNames.DataReference;
                }
        
-               public DataReference (string uri, TransformChain tc)
-                       : base (uri, tc)
+               public DataReference (string uri, TransformChain transformChain)
+                       : base (uri, transformChain)
                {
                        ReferenceType = XmlEncryption.ElementNames.DataReference;
                }
index 04f3799f8cc2760e975c2202ea379fbf1d53c3e7..e748523cbc49855417b2f7e308e61ecc142e1e57 100644 (file)
@@ -55,11 +55,11 @@ namespace System.Security.Cryptography.Xml {
                        TransformChain = new TransformChain ();
                }
        
-               protected EncryptedReference (string uri, TransformChain tc)
+               protected EncryptedReference (string uri, TransformChain transformChain)
                        : this ()
                {
                        Uri = uri;
-                       TransformChain = tc;
+                       TransformChain = transformChain;
                }
        
                #endregion // Constructors
index 6dde9199a2ad36d5c5f9d8620f7444ff22760df2..362f973e35619b9ed08fa418c824910786c85869 100644 (file)
@@ -138,19 +138,19 @@ namespace System.Security.Cryptography.Xml {
                        keyNameMapping.Clear ();
                }
 
-               public byte[] DecryptData (EncryptedData encryptedData, SymmetricAlgorithm symAlg)
+               public byte[] DecryptData (EncryptedData encryptedData, SymmetricAlgorithm symmetricAlgorithm)
                {
                        if (encryptedData == null)
                                throw new ArgumentNullException ("encryptedData");
-                       if (symAlg == null)
-                               throw new ArgumentNullException ("symAlg");
+                       if (symmetricAlgorithm == null)
+                               throw new ArgumentNullException ("symmetricAlgorithm");
 
-                       PaddingMode bak = symAlg.Padding;
+                       PaddingMode bak = symmetricAlgorithm.Padding;
                        try {
-                               symAlg.Padding = Padding;
-                               return Transform (encryptedData.CipherData.CipherValue, symAlg.CreateDecryptor (), symAlg.BlockSize / 8, true);
+                               symmetricAlgorithm.Padding = Padding;
+                               return Transform (encryptedData.CipherData.CipherValue, symmetricAlgorithm.CreateDecryptor (), symmetricAlgorithm.BlockSize / 8, true);
                        } finally {
-                               symAlg.Padding = bak;
+                               symmetricAlgorithm.Padding = bak;
                        }
                }
 
@@ -186,25 +186,25 @@ namespace System.Security.Cryptography.Xml {
                        return DecryptKey (encryptedKey.CipherData.CipherValue, (SymmetricAlgorithm) keyAlg);
                }
 
-               public static byte[] DecryptKey (byte[] keyData, SymmetricAlgorithm symAlg)
+               public static byte[] DecryptKey (byte[] keyData, SymmetricAlgorithm symmetricAlgorithm)
                {
                        if (keyData == null)
                                throw new ArgumentNullException ("keyData");
-                       if (symAlg == null)
-                               throw new ArgumentNullException ("symAlg");
+                       if (symmetricAlgorithm == null)
+                               throw new ArgumentNullException ("symmetricAlgorithm");
 
-                       if (symAlg is TripleDES)
-                               return SymmetricKeyWrap.TripleDESKeyWrapDecrypt (symAlg.Key, keyData);
-                       if (symAlg is Rijndael)
-                               return SymmetricKeyWrap.AESKeyWrapDecrypt (symAlg.Key, keyData);
+                       if (symmetricAlgorithm is TripleDES)
+                               return SymmetricKeyWrap.TripleDESKeyWrapDecrypt (symmetricAlgorithm.Key, keyData);
+                       if (symmetricAlgorithm is Rijndael)
+                               return SymmetricKeyWrap.AESKeyWrapDecrypt (symmetricAlgorithm.Key, keyData);
                        throw new CryptographicException ("The specified cryptographic transform is not supported.");
                }
 
                [MonoTODO ("Test this.")]
-               public static byte[] DecryptKey (byte[] keyData, RSA rsa, bool fOAEP)
+               public static byte[] DecryptKey (byte[] keyData, RSA rsa, bool useOAEP)
                {
                        AsymmetricKeyExchangeDeformatter deformatter = null;
-                       if (fOAEP) 
+                       if (useOAEP) 
                                deformatter = new RSAOAEPKeyExchangeDeformatter (rsa);
                        else
                                deformatter = new RSAPKCS1KeyExchangeDeformatter (rsa);
@@ -254,19 +254,19 @@ namespace System.Security.Cryptography.Xml {
                        throw new NotImplementedException ();
                }
 
-               public byte[] EncryptData (byte[] plainText, SymmetricAlgorithm symAlg)
+               public byte[] EncryptData (byte[] plaintext, SymmetricAlgorithm symmetricAlgorithm)
                {
-                       if (plainText == null)
-                               throw new ArgumentNullException ("plainText");
-                       if (symAlg == null)
-                               throw new ArgumentNullException ("symAlg");
+                       if (plaintext == null)
+                               throw new ArgumentNullException ("plaintext");
+                       if (symmetricAlgorithm == null)
+                               throw new ArgumentNullException ("symmetricAlgorithm");
 
-                       PaddingMode bak = symAlg.Padding;
+                       PaddingMode bak = symmetricAlgorithm.Padding;
                        try {
-                               symAlg.Padding = Padding;
-                               return EncryptDataCore (plainText, symAlg);
+                               symmetricAlgorithm.Padding = Padding;
+                               return EncryptDataCore (plaintext, symmetricAlgorithm);
                        } finally {
-                               symAlg.Padding = bak;
+                               symmetricAlgorithm.Padding = bak;
                        }
                }
 
@@ -289,37 +289,37 @@ namespace System.Security.Cryptography.Xml {
                        return output;
                }
 
-               public byte[] EncryptData (XmlElement inputElement, SymmetricAlgorithm symAlg, bool content)
+               public byte[] EncryptData (XmlElement inputElement, SymmetricAlgorithm symmetricAlgorithm, bool content)
                {
                        if (inputElement == null)
                                throw new ArgumentNullException ("inputElement");
 
                        if (content)
-                               return EncryptData (Encoding.GetBytes (inputElement.InnerXml), symAlg);
+                               return EncryptData (Encoding.GetBytes (inputElement.InnerXml), symmetricAlgorithm);
                        else
-                               return EncryptData (Encoding.GetBytes (inputElement.OuterXml), symAlg);
+                               return EncryptData (Encoding.GetBytes (inputElement.OuterXml), symmetricAlgorithm);
                }
 
-               public static byte[] EncryptKey (byte[] keyData, SymmetricAlgorithm symAlg)
+               public static byte[] EncryptKey (byte[] keyData, SymmetricAlgorithm symmetricAlgorithm)
                {
                        if (keyData == null)
                                throw new ArgumentNullException ("keyData");
-                       if (symAlg == null)
-                               throw new ArgumentNullException ("symAlg");
+                       if (symmetricAlgorithm == null)
+                               throw new ArgumentNullException ("symmetricAlgorithm");
 
-                       if (symAlg is TripleDES)
-                               return SymmetricKeyWrap.TripleDESKeyWrapEncrypt (symAlg.Key, keyData);
-                       if (symAlg is Rijndael)
-                               return SymmetricKeyWrap.AESKeyWrapEncrypt (symAlg.Key, keyData);
+                       if (symmetricAlgorithm is TripleDES)
+                               return SymmetricKeyWrap.TripleDESKeyWrapEncrypt (symmetricAlgorithm.Key, keyData);
+                       if (symmetricAlgorithm is Rijndael)
+                               return SymmetricKeyWrap.AESKeyWrapEncrypt (symmetricAlgorithm.Key, keyData);
 
                        throw new CryptographicException ("The specified cryptographic transform is not supported.");
                }
 
                [MonoTODO ("Test this.")]
-               public static byte[] EncryptKey (byte[] keyData, RSA rsa, bool fOAEP)
+               public static byte[] EncryptKey (byte[] keyData, RSA rsa, bool useOAEP)
                {
                        AsymmetricKeyExchangeFormatter formatter = null;
-                       if (fOAEP) 
+                       if (useOAEP) 
                                formatter = new RSAOAEPKeyExchangeFormatter (rsa);
                        else
                                formatter = new RSAPKCS1KeyExchangeFormatter (rsa);
@@ -402,25 +402,25 @@ namespace System.Security.Cryptography.Xml {
                        throw new ArgumentException ("keyAlg");
                }
 
-               public virtual byte[] GetDecryptionIV (EncryptedData encryptedData, string symAlgUri)
+               public virtual byte[] GetDecryptionIV (EncryptedData encryptedData, string symmetricAlgorithmUri)
                {
                        if (encryptedData == null)
                                throw new ArgumentNullException ("encryptedData");
 
-                       SymmetricAlgorithm symAlg = GetAlgorithm (symAlgUri);
+                       SymmetricAlgorithm symAlg = GetAlgorithm (symmetricAlgorithmUri);
                        byte[] iv = new Byte [symAlg.BlockSize / 8];
                        Buffer.BlockCopy (encryptedData.CipherData.CipherValue, 0, iv, 0, iv.Length);
                        return iv;
                }
 
-               public virtual SymmetricAlgorithm GetDecryptionKey (EncryptedData encryptedData, string symAlgUri)
+               public virtual SymmetricAlgorithm GetDecryptionKey (EncryptedData encryptedData, string symmetricAlgorithmUri)
                {
                        if (encryptedData == null)
                                throw new ArgumentNullException ("encryptedData");
-                       if (symAlgUri == null)
+                       if (symmetricAlgorithmUri == null)
                                return null;
 
-                       SymmetricAlgorithm symAlg = GetAlgorithm (symAlgUri);
+                       SymmetricAlgorithm symAlg = GetAlgorithm (symmetricAlgorithmUri);
                        symAlg.IV = GetDecryptionIV (encryptedData, encryptedData.EncryptionMethod.KeyAlgorithm);
                        KeyInfo keyInfo = encryptedData.KeyInfo;
                        foreach (KeyInfoClause clause in keyInfo) {
index 91815a19a308026260dbebccef5de3ad96883f1f..cd68158bf0f52f54d5eba00247857212dc21231a 100644 (file)
@@ -48,9 +48,9 @@ namespace System.Security.Cryptography.Xml {
                        KeyAlgorithm = null;
                }
 
-               public EncryptionMethod (string strAlgorithm)
+               public EncryptionMethod (string algorithm)
                {
-                       KeyAlgorithm = strAlgorithm;
+                       KeyAlgorithm = algorithm;
                }
 
                #endregion // Constructors
index eee49e6b6a0c95f78e689bf2e0730c098b770cf9..ca662892da9cc9f3435a37a9fadd63765a32e3fb 100644 (file)
@@ -47,9 +47,9 @@ namespace System.Security.Cryptography.Xml {
                {
                }
 
-               public EncryptionProperty (XmlElement elemProp)
+               public EncryptionProperty (XmlElement elementProperty)
                {
-                       LoadXml (elemProp);
+                       LoadXml (elementProperty);
                }
 
                #endregion // Constructors
index afd079b7dc2c62692308e6bdf3282b8111fab019..62aa8afd3ca781bd2966e3a194b520be9c381e7d 100644 (file)
@@ -48,9 +48,9 @@ namespace System.Security.Cryptography.Xml {
                {
                }
 
-               public KeyInfoEncryptedKey (EncryptedKey ek)
+               public KeyInfoEncryptedKey (EncryptedKey encryptedKey)
                {
-                       EncryptedKey = ek;
+                       EncryptedKey = encryptedKey;
                }
 
                #endregion // Constructors
index 2732de63be779629128cea996864910dac1f7c9d..532ba5ca2ce86400967963dae6c573a1def85d80 100644 (file)
@@ -49,10 +49,10 @@ namespace System.Security.Cryptography.Xml {
                        URI = strUri;
                }
 
-               public KeyInfoRetrievalMethod (string strUri, string strType)
+               public KeyInfoRetrievalMethod (string strUri, string typeName)
                        : this (strUri)
                {
-                       Type = strType;
+                       Type = typeName;
                }
 
                [ComVisible (false)]
index 2fe171e72f4b4d7eae831b8ff508f90af715361e..ba33bf25b32e31fd4ac366565a93364fff7afa22 100644 (file)
@@ -48,8 +48,8 @@ namespace System.Security.Cryptography.Xml {
                        ReferenceType = XmlEncryption.ElementNames.KeyReference;
                }
        
-               public KeyReference (string uri, TransformChain tc)
-                       : base (uri, tc)
+               public KeyReference (string uri, TransformChain transformChain)
+                       : base (uri, transformChain)
                {
                        ReferenceType = XmlEncryption.ElementNames.KeyReference;
                }
index e36b30e12b292b2b3aa0e9ee90daf3c576f63432..43560cd40cf6933fdd32f71bf8d21c705ec6c177 100644 (file)
@@ -45,10 +45,10 @@ namespace System.Security.Permissions {
                                _flags = DataProtectionPermissionFlags.AllFlags;
                }
 
-               public DataProtectionPermission (DataProtectionPermissionFlags flags
+               public DataProtectionPermission (DataProtectionPermissionFlags flag) 
                {
                        // reuse validation by the Flags property
-                       Flags = flags;
+                       Flags = flag;
                }
 
 
@@ -114,15 +114,15 @@ namespace System.Security.Permissions {
                        return ((_flags & ~dp._flags) == 0);
                }
 
-               public override void FromXml (SecurityElement e
+               public override void FromXml (SecurityElement securityElement
                {
                        // General validation in CodeAccessPermission
-                       PermissionHelper.CheckSecurityElement (e, "e", version, version);
+                       PermissionHelper.CheckSecurityElement (securityElement, "securityElement", version, version);
                        // Note: we do not (yet) care about the return value 
                        // as we only accept version 1 (min/max values)
 
                        _flags = (DataProtectionPermissionFlags) Enum.Parse (
-                               typeof (DataProtectionPermissionFlags), e.Attribute ("Flags"));
+                               typeof (DataProtectionPermissionFlags), securityElement.Attribute ("Flags"));
                }
 
                public override SecurityElement ToXml () 
index 9dbb1ed60719bb9ec3b7873eb4b5362afd5ba3ab..7166a0330f70f23d5d48e8e69cbc01dfa55f77d9 100644 (file)
@@ -126,7 +126,7 @@ namespace System.ServiceModel.Discovery.Configuration
                        // It seems to do nothing.
                }
                
-               protected override void OnInitializeAndValidate (ServiceEndpointElement channelEndpointElement)
+               protected override void OnInitializeAndValidate (ServiceEndpointElement serviceEndpointElement)
                {
                        // It seems to do nothing.
                }
index ad09f0567cb291cfaf2d026be3f347baf51ccbba..5e6af3f8eebf17175a2d1d5b7681243660fa5b0d 100644 (file)
@@ -142,10 +142,10 @@ namespace System.ServiceModel.Discovery.Configuration
                        base.OnInitializeAndValidate (channelEndpointElement);
                }
 
-               protected override void OnInitializeAndValidate (ServiceEndpointElement channelEndpointElement)
+               protected override void OnInitializeAndValidate (ServiceEndpointElement serviceEndpointElement)
                {
                        // It seems to do nothing.
-                       base.OnInitializeAndValidate (channelEndpointElement);
+                       base.OnInitializeAndValidate (serviceEndpointElement);
                }
        }
 }
index 8ac3d43a3e0bfd9f595df6f7f276babe94636b88..ece16ae6fcc4923f10801e04e53db55b2b43cf87 100644 (file)
@@ -150,10 +150,10 @@ namespace System.ServiceModel.Discovery.Configuration
                        base.OnInitializeAndValidate (channelEndpointElement);
                }
 
-               protected override void OnInitializeAndValidate (ServiceEndpointElement channelEndpointElement)
+               protected override void OnInitializeAndValidate (ServiceEndpointElement serviceEndpointElement)
                {
                        // It seems to do nothing.
-                       base.OnInitializeAndValidate (channelEndpointElement);
+                       base.OnInitializeAndValidate (serviceEndpointElement);
                }
        }
 }
index 0c181289d2562c2b98b505d3c5f9ab117ab3e69d..7e2a31e73a3daa27b87dc0b95be0347606932e99 100644 (file)
@@ -64,8 +64,8 @@ namespace System.ServiceModel.Syndication
                {
                }
 
-               public Atom10ItemFormatter (SyndicationItem feedToWrite)
-                       : base (feedToWrite)
+               public Atom10ItemFormatter (SyndicationItem itemToWrite)
+                       : base (itemToWrite)
                {
                }
 
index 1191c92b2be3ef0683f244bb024eefff8c525cb9..1393a62493e14a08ec06d18dabbbbecf86b9c82e 100644 (file)
@@ -75,9 +75,9 @@ namespace System.ServiceModel.Syndication
                        return new XmlSyndicationContent (null, xmlSerializerObject, serializer);
                }
 
-               public static XmlSyndicationContent CreateXmlContent (XmlReader reader)
+               public static XmlSyndicationContent CreateXmlContent (XmlReader xmlReader)
                {
-                       return new XmlSyndicationContent (reader);
+                       return new XmlSyndicationContent (xmlReader);
                }
 
                #endregion
index 10f786c2ff389a88fe37518b5209305e70023741..1726b78eded0dfb887604d57c2b78ae1ae0ad245 100644 (file)
@@ -62,24 +62,24 @@ namespace System.ServiceModel.Syndication
                {
                }
 
-               public SyndicationItem (string title, string content, Uri feedAlternateLink)
-                       : this (title, content, feedAlternateLink, null, default (DateTimeOffset))
+               public SyndicationItem (string title, string content, Uri itemAlternateLink)
+                       : this (title, content, itemAlternateLink, null, default (DateTimeOffset))
                {
                }
 
-               public SyndicationItem (string title, string content, Uri feedAlternateLink, string id,
+               public SyndicationItem (string title, string content, Uri itemAlternateLink, string id,
                                        DateTimeOffset lastUpdatedTime)
-                       : this (title, content != null ? SyndicationContent.CreatePlaintextContent (content) : null, feedAlternateLink, id, lastUpdatedTime)
+                       : this (title, content != null ? SyndicationContent.CreatePlaintextContent (content) : null, itemAlternateLink, id, lastUpdatedTime)
                {
                }
 
-               public SyndicationItem (string title, SyndicationContent content, Uri feedAlternateLink, string id,
+               public SyndicationItem (string title, SyndicationContent content, Uri itemAlternateLink, string id,
                                        DateTimeOffset lastUpdatedTime)
                {
                        Title = title != null ? new TextSyndicationContent (title) : null;
                        Content = content;
-                       if (feedAlternateLink != null)
-                               AddPermalink (feedAlternateLink);
+                       if (itemAlternateLink != null)
+                               AddPermalink (itemAlternateLink);
                        Id = id;
                        LastUpdatedTime = lastUpdatedTime;
                }
@@ -210,11 +210,11 @@ namespace System.ServiceModel.Syndication
                        set { title = value; }
                }
 
-               public void AddPermalink (Uri link)
+               public void AddPermalink (Uri permalink)
                {
-                       if (link == null)
-                               throw new ArgumentNullException ("link");
-                       Links.Add (SyndicationLink.CreateAlternateLink (link));
+                       if (permalink == null)
+                               throw new ArgumentNullException ("permalink");
+                       Links.Add (SyndicationLink.CreateAlternateLink (permalink));
                }
 
                public virtual SyndicationItem Clone ()
index b380fd834ad074115d7a09271b23ccbb492db52c..174f06b584078685a637c0d16596e3d85a88b835 100644 (file)
@@ -119,9 +119,9 @@ namespace System.ServiceModel.Syndication
                        return extension.GetObject<TContent> ();
                }
 
-               public TContent ReadContent<TContent> (XmlObjectSerializer serializer)
+               public TContent ReadContent<TContent> (XmlObjectSerializer dataContractSerializer)
                {
-                       return extension.GetObject<TContent> (serializer);
+                       return extension.GetObject<TContent> (dataContractSerializer);
                }
 
                public TContent ReadContent<TContent> (XmlSerializer serializer)
index 4a5289dd51f235ed5f8067c560a1b46c627893f0..c05cf8f0c8e1ef783d24d22d032c99694511ad66 100644 (file)
@@ -56,13 +56,13 @@ namespace System.ServiceModel.Web
                }
 #endif
 
-               public WebChannelFactory(Type serviceType)
-                       : base (serviceType)
+               public WebChannelFactory(Type channelType)
+                       : base (channelType)
                {
                }
 
-               public WebChannelFactory (string configurationName)
-                       : base (configurationName)
+               public WebChannelFactory (string endpointConfigurationName)
+                       : base (endpointConfigurationName)
                {
                }
 
index a372b24c6b696e9bc809f0f58a9f5312092f6666..3e8e500329a578b4e4a9ec7a35f9c36790d6a9e3 100644 (file)
@@ -68,15 +68,15 @@ namespace System.ServiceModel.Web
                OutgoingWebRequestContext outgoing_request;
                OutgoingWebResponseContext outgoing_response;
 
-               public WebOperationContext (OperationContext operation)
+               public WebOperationContext (OperationContext operationContext)
                {
-                       if (operation == null)
-                               throw new ArgumentNullException ("operation");
+                       if (operationContext == null)
+                               throw new ArgumentNullException ("operationContext");
 
                        outgoing_request = new OutgoingWebRequestContext ();
-                       incoming_response = new IncomingWebResponseContext (operation);
+                       incoming_response = new IncomingWebResponseContext (operationContext);
 #if !MOBILE
-                       incoming_request = new IncomingWebRequestContext (operation);
+                       incoming_request = new IncomingWebRequestContext (operationContext);
                        outgoing_response = new OutgoingWebResponseContext ();
 #endif
                }
@@ -101,12 +101,12 @@ namespace System.ServiceModel.Web
                }
 #endif
 
-               public void Attach (OperationContext context)
+               public void Attach (OperationContext owner)
                {
                        // do nothing
                }
 
-               public void Detach (OperationContext context)
+               public void Detach (OperationContext owner)
                {
                        // do nothing
                }
index df3dd8f16f6576edf5def249884eca9d7f7c561e..2a71219697dbf668bb63282b8f33978c65c6437a 100644 (file)
@@ -45,9 +45,9 @@ namespace System.ServiceModel
                {
                }
 
-               public WebHttpBinding (WebHttpSecurityMode mode)
+               public WebHttpBinding (WebHttpSecurityMode securityMode)
                {
-                       Initialize (mode);
+                       Initialize (securityMode);
                }
 
                public WebHttpBinding (string configurationName)
index 3a6629e57bc5278eb6f154c94ea62ba12320e385..60ddd555928e15735f7d85428caac5e97e66afbf 100644 (file)
@@ -35,8 +35,8 @@ namespace System
        public class UriTemplateMatchException : SystemException
        {
                public UriTemplateMatchException () : base () {}
-               public UriTemplateMatchException (string msg) : base (msg) {}
-               public UriTemplateMatchException (string msg, Exception inner) : base (msg, inner) {}
+               public UriTemplateMatchException (string message) : base (message) {}
+               public UriTemplateMatchException (string message, Exception innerException) : base (message, innerException) {}
                protected UriTemplateMatchException (SerializationInfo info, StreamingContext context) :
                        base (info, context) {}
        }
index 3e79f9e85ac5d5fbc4c5620ed8eb704c3b2d6e70..dc046928ad37d0624a63c41f52e0426e5ffcdcd3 100644 (file)
@@ -65,14 +65,14 @@ namespace System.Collections.Generic
                        return list;
                }
 
-               protected override void InsertItem (int index, TItem kind)
+               protected override void InsertItem (int index, TItem item)
                {
-                       base.InsertItem (index, kind);
+                       base.InsertItem (index, item);
                }
 
-               protected override void SetItem (int index, TItem kind)
+               protected override void SetItem (int index, TItem item)
                {
-                       base.SetItem (index, kind);
+                       base.SetItem (index, item);
                }
 
                public T Remove<T> ()
index 5e47797fc3f79a16401e0bccb79050966ae0bb2e..b110d15f243614a30ab6740c47aaece7aa9e98df 100644 (file)
@@ -57,10 +57,10 @@ namespace System.Collections.Generic
                }
 
                protected SynchronizedKeyedCollection (object syncRoot,
-                       IEqualityComparer<K> comparer, int capacity)
+                       IEqualityComparer<K> comparer, int dictionaryCreationThreshold)
                        : base (syncRoot)
                {
-                       dict = new Dictionary<K, T> (capacity, comparer);
+                       dict = new Dictionary<K, T> (dictionaryCreationThreshold, comparer);
                }
 
                // see bug #76417
index fdc7c3e56e7767b88e2802e8e9097440c6620cab..b7924ff5a781192001068ae253739a9ebe2f633c 100644 (file)
@@ -43,25 +43,25 @@ namespace System.Collections.Generic
                {
                }
 
-               public SynchronizedReadOnlyCollection (object sync_root)
-                       : this (sync_root, new List<T> ())
+               public SynchronizedReadOnlyCollection (object syncRoot)
+                       : this (syncRoot, new List<T> ())
                {
                }
 
-               public SynchronizedReadOnlyCollection (object sync_root, IEnumerable<T> list)
+               public SynchronizedReadOnlyCollection (object syncRoot, IEnumerable<T> list)
                {
-                       if (sync_root == null)
-                               throw new ArgumentNullException ("sync_root");
+                       if (syncRoot == null)
+                               throw new ArgumentNullException ("syncRoot");
 
                        if (list == null)
                                throw new ArgumentNullException ("list");
 
-                       this.sync_root = sync_root;
+                       this.sync_root = syncRoot;
                        this.l = new List<T> (list);
                }
 
-               public SynchronizedReadOnlyCollection (object sync_root, params T [] list)
-                       : this (sync_root, (IEnumerable<T>) list)
+               public SynchronizedReadOnlyCollection (object syncRoot, params T [] list)
+                       : this (syncRoot, (IEnumerable<T>) list)
                {
                }
 
index 9e66babb71aff4f93a2a183a089baa7ec2dba92f..5d942eebb25d119f29d778db8f46a4f3e0c0c139 100644 (file)
@@ -176,7 +176,7 @@ namespace System.ServiceModel.Channels
 
                public virtual IChannelListener<TChannel>
                        BuildChannelListener<TChannel> (
-                       Uri listenUri,
+                       Uri listenUriBaseAddress,
                        params object [] parameters)
                        where TChannel : class, IChannel
                {
@@ -184,16 +184,16 @@ namespace System.ServiceModel.Channels
                                new BindingParameterCollection ();
                        foreach (object o in parameters)
                                pl.Add (o);
-                       return BuildChannelListener<TChannel> (listenUri, pl);
+                       return BuildChannelListener<TChannel> (listenUriBaseAddress, pl);
                }
 
                public virtual IChannelListener<TChannel>
                        BuildChannelListener<TChannel> (
-                       Uri listenUri,
+                       Uri listenUriBaseAddress,
                        BindingParameterCollection parameters)
                        where TChannel : class, IChannel
                {
-                       return BuildChannelListener<TChannel> (listenUri,
+                       return BuildChannelListener<TChannel> (listenUriBaseAddress,
                                String.Empty, parameters);
                }
 
index be4ff59937a85d6340f0d20209c5bfb06c58bb3e..7c2936e07acbf85dda453bea12d1f0d427336114 100644 (file)
@@ -197,16 +197,16 @@ namespace System.ServiceModel.Channels
                }
 
                public IAsyncResult BeginAcceptChannel (
-                       AsyncCallback callback, object asyncState)
+                       AsyncCallback callback, object state)
                {
                        return BeginAcceptChannel (
-                               timeouts.ReceiveTimeout, callback, asyncState);
+                               timeouts.ReceiveTimeout, callback, state);
                }
 
                public IAsyncResult BeginAcceptChannel (TimeSpan timeout,
-                       AsyncCallback callback, object asyncState)
+                       AsyncCallback callback, object state)
                {
-                       return OnBeginAcceptChannel (timeout, callback, asyncState);
+                       return OnBeginAcceptChannel (timeout, callback, state);
                }
 
                public TChannel EndAcceptChannel (IAsyncResult result)
@@ -217,7 +217,7 @@ namespace System.ServiceModel.Channels
                protected abstract TChannel OnAcceptChannel (TimeSpan timeout);
 
                protected abstract IAsyncResult OnBeginAcceptChannel (TimeSpan timeout,
-                       AsyncCallback callback, object asyncState);
+                       AsyncCallback callback, object state);
 
                protected abstract TChannel OnEndAcceptChannel (IAsyncResult result);
        }
index feb1f9ae7758247e9ce9563dccc7d1c09d4d0e25..c1630966b01c4598325ad4e30536931ca49cf9d5 100644 (file)
@@ -43,8 +43,8 @@ namespace System.ServiceModel.Channels
                ISecurityCapabilities security;
                string scheme = "";
 
-               public CustomBinding (string name)
-                       : this (name, default_ns)
+               public CustomBinding (string configurationName)
+                       : this (configurationName, default_ns)
                {
                }
 
index 1b6be5ad60d66d7d4064dcf22255545d65abf0a7..a5e5b39ec653c203ec48a20cf641dcd411f27fc4 100644 (file)
@@ -334,19 +334,19 @@ namespace System.ServiceModel.Channels
 
                // 1)
                public static Message CreateMessage (MessageVersion version,
-                       FaultCode code, string reason, string action)
+                       FaultCode faultCode, string reason, string action)
                {
-                       MessageFault fault = MessageFault.CreateFault (code, reason);
+                       MessageFault fault = MessageFault.CreateFault (faultCode, reason);
                        return CreateMessage (version, fault, action);
                }
 
                // 2)
                public static Message CreateMessage (MessageVersion version,
-                       FaultCode code, string reason, object detail,
+                       FaultCode faultCode, string reason, object detail,
                        string action)
                {
                        MessageFault fault = MessageFault.CreateFault (
-                               code, new FaultReason (reason), detail);
+                               faultCode, new FaultReason (reason), detail);
                        return CreateMessage (version, fault, action);
                }
 
index ecbf261c316dc066cb37c6babecaafe198b1f6a2..1bb8186155dca65600a39f18acdc6d4b9eb959da 100644 (file)
@@ -47,9 +47,9 @@ namespace System.ServiceModel.Channels {
                        return CreateNavigator (XmlSpace.Default);
                }
 
-               public XPathNavigator CreateNavigator (int node_quota)
+               public XPathNavigator CreateNavigator (int nodeQuota)
                {
-                       return CreateNavigator (node_quota, XmlSpace.Default);
+                       return CreateNavigator (nodeQuota, XmlSpace.Default);
                }
 
                [MonoTODO ("supply proper quota")]
@@ -60,10 +60,10 @@ namespace System.ServiceModel.Channels {
                }
 
                [MonoTODO ("Handle node_quota and xmlspace")]
-               public XPathNavigator CreateNavigator (int node_quota, XmlSpace space)
+               public XPathNavigator CreateNavigator (int nodeQuota, XmlSpace space)
                {
                        if (nav_cache == null) {
-                               DTMXPathDocumentWriter2 pw = new DTMXPathDocumentWriter2 (new NameTable (), node_quota);
+                               DTMXPathDocumentWriter2 pw = new DTMXPathDocumentWriter2 (new NameTable (), nodeQuota);
                                XmlDictionaryWriter w = XmlDictionaryWriter.CreateDictionaryWriter (pw);
                                CreateMessage ().WriteMessage (w);
                                nav_cache = pw.CreateDocument ().CreateNavigator ();
index 8527e5c313419206b5ee66e7b38885e7a449c393..6e3675e95a2d7d99f58a0a62d0b8513dd335f04b 100644 (file)
@@ -220,26 +220,26 @@ namespace System.ServiceModel.Channels
 
                public static MessageFault CreateFault (FaultCode code,
                        FaultReason reason, object detail,
-                       XmlObjectSerializer formatter)
+                       XmlObjectSerializer serializer)
                {
                        return new SimpleMessageFault (code, reason, true,
-                               detail, formatter, String.Empty, String.Empty);
+                               detail, serializer, String.Empty, String.Empty);
                }
 
                public static MessageFault CreateFault (FaultCode code,
                        FaultReason reason, object detail,
-                       XmlObjectSerializer formatter, string actor)
+                       XmlObjectSerializer serializer, string actor)
                {
                        return new SimpleMessageFault (code, reason,
-                               true, detail, formatter, actor, String.Empty);
+                               true, detail, serializer, actor, String.Empty);
                }
 
                public static MessageFault CreateFault (FaultCode code,
                        FaultReason reason, object detail,
-                       XmlObjectSerializer formatter, string actor, string node)
+                       XmlObjectSerializer serializer, string actor, string node)
                {
                        return new SimpleMessageFault (code, reason,
-                               true, detail, formatter, actor, node);
+                               true, detail, serializer, actor, node);
                }
 
                // pretty simple implementation class
index c08ef8697dd13e5cba749f5e94fc573d69450439..3ee4ef203dead9ccad1dac7978026a856031c5dd 100644 (file)
@@ -50,10 +50,10 @@ namespace System.ServiceModel.Channels
                        new Dictionary<Type, XmlObjectSerializer> ();
                MessageVersion version;
 
-               public MessageHeaders (MessageHeaders headers)
-                       : this (headers.MessageVersion)
+               public MessageHeaders (MessageHeaders collection)
+                       : this (collection.MessageVersion)
                {
-                       CopyHeadersFrom (headers);
+                       CopyHeadersFrom (collection);
                }
 
                public MessageHeaders (MessageVersion version)
@@ -61,10 +61,10 @@ namespace System.ServiceModel.Channels
                {
                }
 
-               public MessageHeaders (MessageVersion version, int capacity)
+               public MessageHeaders (MessageVersion version, int initialSize)
                {
                        this.version = version;
-                       l = new List<MessageHeaderInfo> (capacity);
+                       l = new List<MessageHeaderInfo> (initialSize);
                }
                
                public void Add (MessageHeader header)
index 2b43d40adf1ee86d451bd797132edf7191155937..5faeb48c50227205b92b26c63786d676073fa3af 100644 (file)
@@ -49,10 +49,10 @@ namespace System.ServiceModel.Channels
                }
 
                public MtomMessageEncodingBindingElement (
-                       MessageVersion version, Encoding encoding)
+                       MessageVersion messageVersion, Encoding writeEncoding)
                {
-                       this.version = version;
-                       this.encoding = encoding;
+                       this.version = messageVersion;
+                       this.encoding = writeEncoding;
                }
 
                public int MaxBufferSize {
index 759bafd5b16ada72c59c80396bf4ae186a87fdcb..674d6cef46f84d51e60ee6d1018ccc69b767a073 100644 (file)
@@ -41,10 +41,10 @@ namespace System.ServiceModel.Channels
                }
 
                protected NamedPipeTransportBindingElement (
-                       NamedPipeTransportBindingElement other)
-                       : base (other)
+                       NamedPipeTransportBindingElement elementToBeCloned)
+                       : base (elementToBeCloned)
                {
-                       pool.CopyPropertiesFrom (other.pool);
+                       pool.CopyPropertiesFrom (elementToBeCloned.pool);
                }
 
                NamedPipeConnectionPoolSettings pool = new NamedPipeConnectionPoolSettings ();
index 0a5fa43897a31254f03bd51bad8a9746ecff7928..f6b58f582a377039c700e5f1c416e793f9e0f639 100644 (file)
@@ -37,7 +37,7 @@ namespace System.ServiceModel.Channels
                {
                }
 
-               protected StreamUpgradeBindingElement (StreamUpgradeBindingElement other)
+               protected StreamUpgradeBindingElement (StreamUpgradeBindingElement elementToBeCloned)
                {
                }
 
index dee266e465b9301daa4c88572e8223f8bdce9e8c..07356fb41833b902249fd92dc03f58c87c384817 100644 (file)
@@ -45,9 +45,9 @@ namespace System.ServiceModel.Channels
                {
                }
 
-               public TransactionFlowBindingElement (TransactionProtocol protocol)
+               public TransactionFlowBindingElement (TransactionProtocol transactionProtocol)
                {
-                       this.protocol = protocol;
+                       this.protocol = transactionProtocol;
                }
 
                public TransactionProtocol TransactionProtocol {
index cea035495e2be69d8ec040b06e75b3d2251989b2..92f746e2236079680a78a3af78976ba3fbff29b0 100644 (file)
@@ -40,14 +40,14 @@ namespace System.ServiceModel.Channels
                {
                        headers = new List<MessageHeaderInfo> ();
                }
-               public void Add (MessageHeaderInfo header)
+               public void Add (MessageHeaderInfo headerInfo)
                {
-                       headers.Add (header);
+                       headers.Add (headerInfo);
                }
 
-               public bool Contains (MessageHeaderInfo header)
+               public bool Contains (MessageHeaderInfo headerInfo)
                {
-                       return headers.Contains (header);
+                       return headers.Contains (headerInfo);
                }
 
                public IEnumerator<MessageHeaderInfo> GetEnumerator ()
@@ -55,9 +55,9 @@ namespace System.ServiceModel.Channels
                        return headers.GetEnumerator ();
                }
 
-               public void Remove (MessageHeaderInfo header)
+               public void Remove (MessageHeaderInfo headerInfo)
                {
-                       headers.Remove (header);
+                       headers.Remove (headerInfo);
                }
 
                IEnumerator IEnumerable.GetEnumerator ()
index a83fffc8b2ede9ea49d1c7a61148b3c56ec1ee6b..a69522b599e0edd9c6f56b3af3b9d419d6ac9ad5 100644 (file)
@@ -111,9 +111,9 @@ namespace System.ServiceModel.Configuration
                        return new BinaryMessageEncodingBindingElement ();
                }
 
-               public override void ApplyConfiguration (BindingElement element)
+               public override void ApplyConfiguration (BindingElement bindingElement)
                {
-                       var b = (BinaryMessageEncodingBindingElement) element;
+                       var b = (BinaryMessageEncodingBindingElement) bindingElement;
                        b.MaxReadPoolSize = MaxReadPoolSize;
                        b.MaxSessionSize = MaxSessionSize;
                        b.MaxWritePoolSize = MaxWritePoolSize;
@@ -121,9 +121,9 @@ namespace System.ServiceModel.Configuration
                        ReaderQuotas.ApplyConfiguration (b.ReaderQuotas);
                }
 
-               public override void CopyFrom (ServiceModelExtensionElement element)
+               public override void CopyFrom (ServiceModelExtensionElement from)
                {
-                       var b = (BinaryMessageEncodingElement) element;
+                       var b = (BinaryMessageEncodingElement) from;
                        MaxReadPoolSize = b.MaxReadPoolSize;
                        MaxSessionSize = b.MaxSessionSize;
                        MaxWritePoolSize = b.MaxWritePoolSize;
@@ -131,9 +131,9 @@ namespace System.ServiceModel.Configuration
                        ReaderQuotas.CopyFrom (b.ReaderQuotas);
                }
 
-               protected internal override void InitializeFrom (BindingElement element)
+               protected internal override void InitializeFrom (BindingElement bindingElement)
                {
-                       var b = (BinaryMessageEncodingBindingElement) element;
+                       var b = (BinaryMessageEncodingBindingElement) bindingElement;
                        MaxReadPoolSize = b.MaxReadPoolSize;
                        MaxSessionSize = b.MaxSessionSize;
                        MaxWritePoolSize = b.MaxWritePoolSize;
index 1b17fc25e3f4ea4e258d62df557ea50204009deb..8d0846419766dfca96d8ace9a4a0d03bdcbfa551 100644 (file)
@@ -165,12 +165,12 @@ namespace System.ServiceModel.Configuration
                        return sm.Bindings;
                }
 
-               public new BindingCollectionElement this [string name] {
+               public new BindingCollectionElement this [string binding] {
                        get {
-                               object element = base [name];
+                               object element = base [binding];
                                if (element is BindingCollectionElement)
                                        return (BindingCollectionElement) element;
-                               throw new NotImplementedException (String.Format ("Could not find {0}", name));
+                               throw new NotImplementedException (String.Format ("Could not find {0}", binding));
                        }
                }
 
index 9b1300e425db27c1330018df3831cadf24c51cce..b2460ce48a9e43f529c4d522a7e0437b5d258e23 100644 (file)
@@ -147,21 +147,21 @@ namespace System.ServiceModel.Configuration
                        return cb;
                }
 
-               protected internal void ApplyConfiguration (ClientCredentials cb)
+               protected internal void ApplyConfiguration (ClientCredentials behavior)
                {
-                       cb.SupportInteractive = SupportInteractive;
+                       behavior.SupportInteractive = SupportInteractive;
                        // how is "Type" used?
 
                        // ClientCertificate
                        if (!String.IsNullOrEmpty (ClientCertificate.FindValue))
-                               cb.ClientCertificate.SetCertificate (ClientCertificate.StoreLocation, ClientCertificate.StoreName, ClientCertificate.X509FindType, ClientCertificate.FindValue);
+                               behavior.ClientCertificate.SetCertificate (ClientCertificate.StoreLocation, ClientCertificate.StoreName, ClientCertificate.X509FindType, ClientCertificate.FindValue);
 
                        // HttpDigest
                        if (HttpDigest.ImpersonationLevel != TokenImpersonationLevel.None)
                                throw new NotImplementedException ();
 
                        // IssuedToken
-                       var bi = cb.IssuedToken;
+                       var bi = behavior.IssuedToken;
                        var ci = IssuedToken;
                        bi.CacheIssuedTokens = ci.CacheIssuedTokens;
                        bi.DefaultKeyEntropyMode = ci.DefaultKeyEntropyMode;
@@ -174,19 +174,19 @@ namespace System.ServiceModel.Configuration
 
                        // Peer
                        if (!String.IsNullOrEmpty (Peer.Certificate.FindValue))
-                               cb.Peer.SetCertificate (Peer.Certificate.StoreLocation, Peer.Certificate.StoreName, Peer.Certificate.X509FindType, Peer.Certificate.FindValue);
+                               behavior.Peer.SetCertificate (Peer.Certificate.StoreLocation, Peer.Certificate.StoreName, Peer.Certificate.X509FindType, Peer.Certificate.FindValue);
                        // cb.Peer.MeshPassword = /* cannot fill it here */
-                       cb.Peer.MessageSenderAuthentication.CustomCertificateValidator = (X509CertificateValidator) CreateInstance (Peer.MessageSenderAuthentication.CustomCertificateValidatorType);
-                       cb.Peer.MessageSenderAuthentication.CertificateValidationMode = Peer.MessageSenderAuthentication.CertificateValidationMode;
-                       cb.Peer.MessageSenderAuthentication.RevocationMode = Peer.MessageSenderAuthentication.RevocationMode;
-                       cb.Peer.MessageSenderAuthentication.TrustedStoreLocation = Peer.MessageSenderAuthentication.TrustedStoreLocation;
-                       cb.Peer.PeerAuthentication.CustomCertificateValidator = (X509CertificateValidator) CreateInstance (Peer.PeerAuthentication.CustomCertificateValidatorType);
-                       cb.Peer.PeerAuthentication.CertificateValidationMode = Peer.PeerAuthentication.CertificateValidationMode;
-                       cb.Peer.PeerAuthentication.RevocationMode = Peer.PeerAuthentication.RevocationMode;
-                       cb.Peer.PeerAuthentication.TrustedStoreLocation = Peer.PeerAuthentication.TrustedStoreLocation;
+                       behavior.Peer.MessageSenderAuthentication.CustomCertificateValidator = (X509CertificateValidator) CreateInstance (Peer.MessageSenderAuthentication.CustomCertificateValidatorType);
+                       behavior.Peer.MessageSenderAuthentication.CertificateValidationMode = Peer.MessageSenderAuthentication.CertificateValidationMode;
+                       behavior.Peer.MessageSenderAuthentication.RevocationMode = Peer.MessageSenderAuthentication.RevocationMode;
+                       behavior.Peer.MessageSenderAuthentication.TrustedStoreLocation = Peer.MessageSenderAuthentication.TrustedStoreLocation;
+                       behavior.Peer.PeerAuthentication.CustomCertificateValidator = (X509CertificateValidator) CreateInstance (Peer.PeerAuthentication.CustomCertificateValidatorType);
+                       behavior.Peer.PeerAuthentication.CertificateValidationMode = Peer.PeerAuthentication.CertificateValidationMode;
+                       behavior.Peer.PeerAuthentication.RevocationMode = Peer.PeerAuthentication.RevocationMode;
+                       behavior.Peer.PeerAuthentication.TrustedStoreLocation = Peer.PeerAuthentication.TrustedStoreLocation;
 
                        // ServiceCertificate
-                       var bsc = cb.ServiceCertificate;
+                       var bsc = behavior.ServiceCertificate;
                        var csc = ServiceCertificate;
                        var bsca = bsc.Authentication;
                        var csca = csc.Authentication;
@@ -202,8 +202,8 @@ namespace System.ServiceModel.Configuration
                        // cb.UserNamePassword : not configurable ...
 
                        // Windows
-                       cb.Windows.AllowedImpersonationLevel = Windows.AllowedImpersonationLevel;
-                       cb.Windows.AllowNtlm = Windows.AllowNtlm;
+                       behavior.Windows.AllowedImpersonationLevel = Windows.AllowedImpersonationLevel;
+                       behavior.Windows.AllowNtlm = Windows.AllowNtlm;
                }
 
                object CreateInstance (string typeName)
index 41220685f8a117be360ec6228b90ea760877d244..ff1c1441357e7edfd08da089a5377610783de6ba 100644 (file)
@@ -150,9 +150,9 @@ namespace System.ServiceModel.Configuration
                        return new ReliableSessionBindingElement ();
                }
 
-               public override void ApplyConfiguration (BindingElement element)
+               public override void ApplyConfiguration (BindingElement bindingElement)
                {
-                       var b = (ReliableSessionBindingElement) element;
+                       var b = (ReliableSessionBindingElement) bindingElement;
                        b.AcknowledgementInterval = AcknowledgementInterval;
                        b.FlowControlEnabled = FlowControlEnabled;
                        b.InactivityTimeout = InactivityTimeout;
@@ -163,9 +163,9 @@ namespace System.ServiceModel.Configuration
                        b.ReliableMessagingVersion = ReliableMessagingVersion;
                }
 
-               public override void CopyFrom (ServiceModelExtensionElement element)
+               public override void CopyFrom (ServiceModelExtensionElement from)
                {
-                       var b = (ReliableSessionElement) element;
+                       var b = (ReliableSessionElement) from;
                        AcknowledgementInterval = b.AcknowledgementInterval;
                        FlowControlEnabled = b.FlowControlEnabled;
                        InactivityTimeout = b.InactivityTimeout;
@@ -176,9 +176,9 @@ namespace System.ServiceModel.Configuration
                        ReliableMessagingVersion = b.ReliableMessagingVersion;
                }
 
-               protected internal override void InitializeFrom (BindingElement element)
+               protected internal override void InitializeFrom (BindingElement bindingElement)
                {
-                       var b = (ReliableSessionBindingElement) element;
+                       var b = (ReliableSessionBindingElement) bindingElement;
                        AcknowledgementInterval = b.AcknowledgementInterval;
                        FlowControlEnabled = b.FlowControlEnabled;
                        InactivityTimeout = b.InactivityTimeout;
index 9830a57ce690035aa64e9ff8a25f38117ebc67e5..498103508ced18adff08b18e71151da9cc2c235c 100644 (file)
@@ -132,57 +132,57 @@ namespace System.ServiceModel.Configuration
                        return sb;
                }
 
-               protected internal void ApplyConfiguration (ServiceCredentials sb)
+               protected internal void ApplyConfiguration (ServiceCredentials behavior)
                {
                        // IssuedToken
                        foreach (AllowedAudienceUriElement ae in IssuedTokenAuthentication.AllowedAudienceUris)
-                               sb.IssuedTokenAuthentication.AllowedAudienceUris.Add (ae.AllowedAudienceUri);
-                       sb.IssuedTokenAuthentication.AllowUntrustedRsaIssuers = IssuedTokenAuthentication.AllowUntrustedRsaIssuers;
-                       sb.IssuedTokenAuthentication.AudienceUriMode = IssuedTokenAuthentication.AudienceUriMode;
+                               behavior.IssuedTokenAuthentication.AllowedAudienceUris.Add (ae.AllowedAudienceUri);
+                       behavior.IssuedTokenAuthentication.AllowUntrustedRsaIssuers = IssuedTokenAuthentication.AllowUntrustedRsaIssuers;
+                       behavior.IssuedTokenAuthentication.AudienceUriMode = IssuedTokenAuthentication.AudienceUriMode;
 
                        if (!String.IsNullOrEmpty (IssuedTokenAuthentication.CustomCertificateValidatorType))
-                       sb.IssuedTokenAuthentication.CustomCertificateValidator = (X509CertificateValidator) CreateInstance (IssuedTokenAuthentication.CustomCertificateValidatorType);
-                       sb.IssuedTokenAuthentication.CertificateValidationMode = IssuedTokenAuthentication.CertificateValidationMode;
-                       sb.IssuedTokenAuthentication.RevocationMode = IssuedTokenAuthentication.RevocationMode;
-                       sb.IssuedTokenAuthentication.TrustedStoreLocation = IssuedTokenAuthentication.TrustedStoreLocation;
+                       behavior.IssuedTokenAuthentication.CustomCertificateValidator = (X509CertificateValidator) CreateInstance (IssuedTokenAuthentication.CustomCertificateValidatorType);
+                       behavior.IssuedTokenAuthentication.CertificateValidationMode = IssuedTokenAuthentication.CertificateValidationMode;
+                       behavior.IssuedTokenAuthentication.RevocationMode = IssuedTokenAuthentication.RevocationMode;
+                       behavior.IssuedTokenAuthentication.TrustedStoreLocation = IssuedTokenAuthentication.TrustedStoreLocation;
                        foreach (X509CertificateTrustedIssuerElement ce in IssuedTokenAuthentication.KnownCertificates)
-                               sb.IssuedTokenAuthentication.KnownCertificates.Add (GetCertificate (ce.StoreLocation, ce.StoreName, ce.X509FindType, ce.FindValue));
+                               behavior.IssuedTokenAuthentication.KnownCertificates.Add (GetCertificate (ce.StoreLocation, ce.StoreName, ce.X509FindType, ce.FindValue));
 
-                       sb.IssuedTokenAuthentication.SamlSerializer = (SamlSerializer) CreateInstance (IssuedTokenAuthentication.SamlSerializerType);
+                       behavior.IssuedTokenAuthentication.SamlSerializer = (SamlSerializer) CreateInstance (IssuedTokenAuthentication.SamlSerializerType);
 
 
                        // Peer
                        if (!String.IsNullOrEmpty (Peer.Certificate.FindValue))
-                               sb.Peer.SetCertificate (Peer.Certificate.StoreLocation, Peer.Certificate.StoreName, Peer.Certificate.X509FindType, Peer.Certificate.FindValue);
+                               behavior.Peer.SetCertificate (Peer.Certificate.StoreLocation, Peer.Certificate.StoreName, Peer.Certificate.X509FindType, Peer.Certificate.FindValue);
                        // sb.Peer.MeshPassword = /* cannot fill it here */
-                       sb.Peer.MessageSenderAuthentication.CustomCertificateValidator = (X509CertificateValidator) CreateInstance (Peer.MessageSenderAuthentication.CustomCertificateValidatorType);
-                       sb.Peer.MessageSenderAuthentication.CertificateValidationMode = Peer.MessageSenderAuthentication.CertificateValidationMode;
-                       sb.Peer.MessageSenderAuthentication.RevocationMode = Peer.MessageSenderAuthentication.RevocationMode;
-                       sb.Peer.MessageSenderAuthentication.TrustedStoreLocation = Peer.MessageSenderAuthentication.TrustedStoreLocation;
-                       sb.Peer.PeerAuthentication.CustomCertificateValidator = (X509CertificateValidator) CreateInstance (Peer.PeerAuthentication.CustomCertificateValidatorType);
-                       sb.Peer.PeerAuthentication.CertificateValidationMode = Peer.PeerAuthentication.CertificateValidationMode;
-                       sb.Peer.PeerAuthentication.RevocationMode = Peer.PeerAuthentication.RevocationMode;
-                       sb.Peer.PeerAuthentication.TrustedStoreLocation = Peer.PeerAuthentication.TrustedStoreLocation;
+                       behavior.Peer.MessageSenderAuthentication.CustomCertificateValidator = (X509CertificateValidator) CreateInstance (Peer.MessageSenderAuthentication.CustomCertificateValidatorType);
+                       behavior.Peer.MessageSenderAuthentication.CertificateValidationMode = Peer.MessageSenderAuthentication.CertificateValidationMode;
+                       behavior.Peer.MessageSenderAuthentication.RevocationMode = Peer.MessageSenderAuthentication.RevocationMode;
+                       behavior.Peer.MessageSenderAuthentication.TrustedStoreLocation = Peer.MessageSenderAuthentication.TrustedStoreLocation;
+                       behavior.Peer.PeerAuthentication.CustomCertificateValidator = (X509CertificateValidator) CreateInstance (Peer.PeerAuthentication.CustomCertificateValidatorType);
+                       behavior.Peer.PeerAuthentication.CertificateValidationMode = Peer.PeerAuthentication.CertificateValidationMode;
+                       behavior.Peer.PeerAuthentication.RevocationMode = Peer.PeerAuthentication.RevocationMode;
+                       behavior.Peer.PeerAuthentication.TrustedStoreLocation = Peer.PeerAuthentication.TrustedStoreLocation;
 
                        // WSSC
-                       sb.SecureConversationAuthentication.SecurityStateEncoder = (SecurityStateEncoder) CreateInstance (SecureConversationAuthentication.SecurityStateEncoderType);
+                       behavior.SecureConversationAuthentication.SecurityStateEncoder = (SecurityStateEncoder) CreateInstance (SecureConversationAuthentication.SecurityStateEncoderType);
 
                        // X509
                        if (!String.IsNullOrEmpty (ServiceCertificate.FindValue))
-                               sb.ServiceCertificate.SetCertificate (ServiceCertificate.StoreLocation, ServiceCertificate.StoreName, ServiceCertificate.X509FindType, ServiceCertificate.FindValue);
+                               behavior.ServiceCertificate.SetCertificate (ServiceCertificate.StoreLocation, ServiceCertificate.StoreName, ServiceCertificate.X509FindType, ServiceCertificate.FindValue);
 
                        // UserNamePassword
-                       sb.UserNameAuthentication.CachedLogonTokenLifetime = UserNameAuthentication.CachedLogonTokenLifetime;
-                       sb.UserNameAuthentication.CacheLogonTokens = UserNameAuthentication.CacheLogonTokens;
-                       sb.UserNameAuthentication.CustomUserNamePasswordValidator = (UserNamePasswordValidator) CreateInstance (UserNameAuthentication.CustomUserNamePasswordValidatorType);
-                       sb.UserNameAuthentication.IncludeWindowsGroups = UserNameAuthentication.IncludeWindowsGroups;
-                       sb.UserNameAuthentication.MaxCachedLogonTokens = UserNameAuthentication.MaxCachedLogonTokens;
-                       sb.UserNameAuthentication.MembershipProvider = (MembershipProvider) CreateInstance (UserNameAuthentication.MembershipProviderName);
-                       sb.UserNameAuthentication.UserNamePasswordValidationMode = UserNameAuthentication.UserNamePasswordValidationMode;
+                       behavior.UserNameAuthentication.CachedLogonTokenLifetime = UserNameAuthentication.CachedLogonTokenLifetime;
+                       behavior.UserNameAuthentication.CacheLogonTokens = UserNameAuthentication.CacheLogonTokens;
+                       behavior.UserNameAuthentication.CustomUserNamePasswordValidator = (UserNamePasswordValidator) CreateInstance (UserNameAuthentication.CustomUserNamePasswordValidatorType);
+                       behavior.UserNameAuthentication.IncludeWindowsGroups = UserNameAuthentication.IncludeWindowsGroups;
+                       behavior.UserNameAuthentication.MaxCachedLogonTokens = UserNameAuthentication.MaxCachedLogonTokens;
+                       behavior.UserNameAuthentication.MembershipProvider = (MembershipProvider) CreateInstance (UserNameAuthentication.MembershipProviderName);
+                       behavior.UserNameAuthentication.UserNamePasswordValidationMode = UserNameAuthentication.UserNamePasswordValidationMode;
 
                        // Windows
-                       sb.WindowsAuthentication.AllowAnonymousLogons = WindowsAuthentication.AllowAnonymousLogons;
-                       sb.WindowsAuthentication.IncludeWindowsGroups = WindowsAuthentication.IncludeWindowsGroups;
+                       behavior.WindowsAuthentication.AllowAnonymousLogons = WindowsAuthentication.AllowAnonymousLogons;
+                       behavior.WindowsAuthentication.IncludeWindowsGroups = WindowsAuthentication.IncludeWindowsGroups;
                }
 
                X509Certificate2 GetCertificate (StoreLocation storeLocation, StoreName storeName, X509FindType findType, object findValue)
index 6de08d8d9015275a143dce8bd75ab8519c32d1a9..4dfa45e011d4d2f7f588a9f0d4ecab8fe93df733 100644 (file)
@@ -94,19 +94,19 @@ namespace System.ServiceModel.Configuration
                        return (ConfigurationElement) Activator.CreateInstance (typeof (ConfigurationElementType), new object [0]);
                }
 
-               public void CopyTo (ConfigurationElementType [] array, int index)
+               public void CopyTo (ConfigurationElementType [] array, int start)
                {
-                       base.CopyTo (array, index);
+                       base.CopyTo (array, start);
                }
 
-               public int IndexOf (ConfigurationElementType item)
+               public int IndexOf (ConfigurationElementType element)
                {
-                       return BaseIndexOf (item);
+                       return BaseIndexOf (element);
                }
 
-               public void Remove (ConfigurationElementType item)
+               public void Remove (ConfigurationElementType element)
                {
-                       BaseRemove (GetElementKey (item));
+                       BaseRemove (GetElementKey (element));
                }
 
                public void RemoveAt (int index)
@@ -114,9 +114,9 @@ namespace System.ServiceModel.Configuration
                        BaseRemoveAt (index);
                }
 
-               public void RemoveAt (object index)
+               public void RemoveAt (object key)
                {
-                       BaseRemove (index);
+                       BaseRemove (key);
                }
        }
 }
index 45b4b753ba6caa04d7c60b656f725116f9bdfe84..a2bf4f649e8aa15ebfe7e9178ca6b7357cbf5a4e 100644 (file)
@@ -92,10 +92,10 @@ namespace System.ServiceModel.Configuration
 
                // Methods
 
-               public void ApplyConfiguration (OptionalReliableSession s)
+               public void ApplyConfiguration (OptionalReliableSession optionalReliableSession)
                {
-                       base.ApplyConfiguration (s);
-                       s.Enabled = this.Enabled;
+                       base.ApplyConfiguration (optionalReliableSession);
+                       optionalReliableSession.Enabled = this.Enabled;
                }
        }
 
index 08d4aaa59a562ac8232857031d454e69f4a10895..6a06b7375b65a6e37e42b8a7d61ba48c80e0eeec 100644 (file)
@@ -115,10 +115,10 @@ namespace System.ServiceModel.Configuration
 
                // Methods
 
-               public void ApplyConfiguration (ReliableSession s)
+               public void ApplyConfiguration (ReliableSession reliableSession)
                {
-                       s.InactivityTimeout = InactivityTimeout;
-                       s.Ordered = Ordered;
+                       reliableSession.InactivityTimeout = InactivityTimeout;
+                       reliableSession.Ordered = Ordered;
                }
        }
 
index 559481da6b7486efc75c5e69f4a4e66738f0d10f..fe3a6ff11522ba76a13035eec8899686634aa98e 100644 (file)
@@ -114,11 +114,11 @@ namespace System.ServiceModel.Configuration
 
                protected abstract void OnApplyConfiguration (ServiceEndpoint endpoint, ChannelEndpointElement channelEndpointElement);
 
-               protected abstract void OnApplyConfiguration (ServiceEndpoint endpoint, ServiceEndpointElement channelEndpointElement);
+               protected abstract void OnApplyConfiguration (ServiceEndpoint endpoint, ServiceEndpointElement serviceEndpointElement);
 
                protected abstract void OnInitializeAndValidate (ChannelEndpointElement channelEndpointElement);
 
-               protected abstract void OnInitializeAndValidate (ServiceEndpointElement channelEndpointElement);
+               protected abstract void OnInitializeAndValidate (ServiceEndpointElement serviceEndpointElement);
 
                protected override void Reset (ConfigurationElement parentElement)
                {
index 2a82a49ac5fa32fd1526b9a655671005dac034aa..aa38ecda1a570556bfd35b5f1d67174697b492ef 100644 (file)
@@ -109,12 +109,12 @@ namespace System.ServiceModel.Configuration
                        return sm.StandardEndpoints;
                }
 
-               public new EndpointCollectionElement this [string name] {
+               public new EndpointCollectionElement this [string endpoint] {
                        get {
-                               object element = base [name];
+                               object element = base [endpoint];
                                if (element is EndpointCollectionElement)
                                        return (EndpointCollectionElement) element;
-                               throw new ArgumentException (String.Format ("Could not find {0}", name));
+                               throw new ArgumentException (String.Format ("Could not find {0}", endpoint));
                        }
                }
 
index 56cfdc76f564e9d92e8430cc4de23c341c931041..2aa626e6186ea28ab23d3b3f290417cc64e3fb7c 100644 (file)
@@ -124,9 +124,9 @@ namespace System.ServiceModel.Configuration
                }
 
 
-               public override void ApplyConfiguration (BindingElement element)
+               public override void ApplyConfiguration (BindingElement bindingElement)
                {
-                       var b = (TextMessageEncodingBindingElement) element;
+                       var b = (TextMessageEncodingBindingElement) bindingElement;
                        b.MaxReadPoolSize = MaxReadPoolSize;
                        b.MaxWritePoolSize = MaxWritePoolSize;
                        b.MessageVersion = MessageVersion;
@@ -135,9 +135,9 @@ namespace System.ServiceModel.Configuration
                        ReaderQuotas.ApplyConfiguration (b.ReaderQuotas);
                }
 
-               public override void CopyFrom (ServiceModelExtensionElement element)
+               public override void CopyFrom (ServiceModelExtensionElement from)
                {
-                       var b = (TextMessageEncodingElement) element;
+                       var b = (TextMessageEncodingElement) from;
                        MaxReadPoolSize = b.MaxReadPoolSize;
                        MaxWritePoolSize = b.MaxWritePoolSize;
                        MessageVersion = b.MessageVersion;
@@ -146,9 +146,9 @@ namespace System.ServiceModel.Configuration
                        ReaderQuotas.CopyFrom (b.ReaderQuotas);
                }
 
-               protected internal override void InitializeFrom (BindingElement element)
+               protected internal override void InitializeFrom (BindingElement bindingElement)
                {
-                       var b = (TextMessageEncodingBindingElement) element;
+                       var b = (TextMessageEncodingBindingElement) bindingElement;
                        MaxReadPoolSize = b.MaxReadPoolSize;
                        MaxWritePoolSize = b.MaxWritePoolSize;
                        MessageVersion = b.MessageVersion;
index b77c331a401d92f025b6d16541b7c380626da090..11f9991a60f30c72cddfb6e1dbaa3d743e2b8d73 100644 (file)
@@ -40,20 +40,20 @@ namespace System.ServiceModel.Description
                {
                }
 
-               public FaultDescription Find (string name)
+               public FaultDescription Find (string action)
                {
                        foreach (FaultDescription d in this)
-                               if (d.Name == name)
+                               if (d.Name == action)
                                        return d;
                        return null;
                }
 
-               public Collection<FaultDescription> FindAll (string name)
+               public Collection<FaultDescription> FindAll (string action)
                {
                        Collection<FaultDescription> ret =
                                new Collection<FaultDescription> ();
                        foreach (FaultDescription d in this)
-                               if (d.Name == name)
+                               if (d.Name == action)
                                        ret.Add (d);
                        return ret;
                }
index 39103884b408e6de2789d802f0229ab2dfacd719..fb16e0a9a4870b9ac6e59556d1b61251347a261c 100644 (file)
@@ -35,17 +35,17 @@ namespace System.ServiceModel.Description
        public interface IServiceBehavior
        {
                void AddBindingParameters (
-                       ServiceDescription description,
+                       ServiceDescription serviceDescription,
                        ServiceHostBase serviceHostBase,
                        Collection<ServiceEndpoint> endpoints,
-                       BindingParameterCollection parameters);
+                       BindingParameterCollection bindingParameters);
 
                void ApplyDispatchBehavior (
-                       ServiceDescription description,
+                       ServiceDescription serviceDescription,
                        ServiceHostBase serviceHostBase);
 
                void Validate (
-                       ServiceDescription description,
+                       ServiceDescription serviceDescription,
                        ServiceHostBase serviceHostBase);
        }
 }
index 31374445b0b1a1f4e9cd7b2ec99bd6934882fdec..07a26129c50bfa87ca2924e707cf62b9d8d087c4 100644 (file)
@@ -41,9 +41,9 @@ namespace System.ServiceModel.Description
                        XmlSchemaSet xmlSchemas, ICollection<XmlElement> policy);
 
                void ImportContract (WsdlImporter importer,
-                       WsdlContractConversionContext contractContext);
+                       WsdlContractConversionContext context);
 
                void ImportEndpoint (WsdlImporter importer,
-                       WsdlEndpointConversionContext endpointContext);
+                       WsdlEndpointConversionContext context);
        }
 }
index afa66b942941ba4ccf36a489b91a4511f8e8f8e8..91388a15594210d4caae4bc99fd2e1161f716816 100644 (file)
@@ -57,9 +57,9 @@ namespace System.ServiceModel.Description
                        get { return msg; }
                }
 
-               public override bool Equals (object other)
+               public override bool Equals (object obj)
                {
-                       MetadataConversionError e = other as MetadataConversionError;
+                       MetadataConversionError e = obj as MetadataConversionError;
                        return e != null &&
                                e.warning == warning &&
                                e.msg == msg;
index 274a2be62be773633fde11e04d6763c3161419a5..018250f4b9e20c270814a36bedf3f84ffbb9fc36 100644 (file)
@@ -53,7 +53,7 @@ namespace System.ServiceModel.Description
                        ServiceContractGenerationContext contract,
                        OperationDescription operation,
                        CodeTypeDeclaration declaringType,
-                       CodeMemberMethod method,
+                       CodeMemberMethod syncMethod,
                        CodeMemberMethod beginMethod,
                        CodeMemberMethod endMethod)
                {
@@ -61,7 +61,7 @@ namespace System.ServiceModel.Description
                        this.contract = contract;
                        this.operation = operation;
                        declaring_type = declaringType;
-                       this.method = method;
+                       this.method = syncMethod;
                        this.begin_method = beginMethod;
                        this.end_method = endMethod;
                }
index 60d03dc17c733a7a23b994fd9ed66e66db128b44..3fb7105f046e7e12f1a469124179e682492e8890 100644 (file)
@@ -41,45 +41,45 @@ namespace System.ServiceModel.Description
                {
                }
 
-               public PolicyAssertionCollection (IEnumerable<XmlElement> list)
-                       : base (new List<XmlElement> (list))
+               public PolicyAssertionCollection (IEnumerable<XmlElement> elements)
+                       : base (new List<XmlElement> (elements))
                {
                }
 
                [MonoTODO]
-               public bool Contains (string name, string ns)
+               public bool Contains (string localName, string namespaceUri)
                {
                        foreach (XmlElement el in this)
-                               if (el.LocalName == name && el.NamespaceURI == ns)
+                               if (el.LocalName == localName && el.NamespaceURI == namespaceUri)
                                        return true;
                        return false;
                }
 
                [MonoTODO]
-               public XmlElement Find (string name, string ns)
+               public XmlElement Find (string localName, string namespaceUri)
                {
                        foreach (XmlElement el in this)
-                               if (el.LocalName == name && el.NamespaceURI == ns)
+                               if (el.LocalName == localName && el.NamespaceURI == namespaceUri)
                                        return el;
                        return null;
                }
 
                [MonoTODO]
-               public Collection<XmlElement> FindAll (string name, string ns)
+               public Collection<XmlElement> FindAll (string localName, string namespaceUri)
                {
                        Collection<XmlElement> ret =
                                new Collection<XmlElement> ();
                        foreach (XmlElement el in this)
-                               if (el.LocalName == name && el.NamespaceURI == ns)
+                               if (el.LocalName == localName && el.NamespaceURI == namespaceUri)
                                        ret.Add (el);
                        return ret;
                }
 
                [MonoTODO]
-               public XmlElement Remove (string name, string ns)
+               public XmlElement Remove (string localName, string namespaceUri)
                {
                        foreach (XmlElement el in this)
-                               if (el.LocalName == name && el.NamespaceURI == ns) {
+                               if (el.LocalName == localName && el.NamespaceURI == namespaceUri) {
                                        Remove (el);
                                        return el;
                                }
@@ -87,9 +87,9 @@ namespace System.ServiceModel.Description
                }
 
                [MonoTODO]
-               public Collection<XmlElement> RemoveAll (string name, string ns)
+               public Collection<XmlElement> RemoveAll (string localName, string namespaceUri)
                {
-                       Collection<XmlElement> list = FindAll (name, ns);
+                       Collection<XmlElement> list = FindAll (localName, namespaceUri);
                        foreach (XmlElement el in list)
                                Remove (el);
                        return list;
index 59f0aa2ce7f4e9fd457e7b6016f79bcfedc62eda..8590c4538c532deab96263dff10a91815823c294 100644 (file)
@@ -111,23 +111,23 @@ namespace System.ServiceModel.Description
                {
                }
 
-               public ServiceContractGenerator (CodeCompileUnit ccu)
-                       : this (ccu, null)
+               public ServiceContractGenerator (CodeCompileUnit targetCompileUnit)
+                       : this (targetCompileUnit, null)
                {
                }
 
-               public ServiceContractGenerator (ConfigurationType config)
-                       : this (null, config)
+               public ServiceContractGenerator (ConfigurationType targetConfig)
+                       : this (null, targetConfig)
                {
                }
 
-               public ServiceContractGenerator (CodeCompileUnit ccu, ConfigurationType config)
+               public ServiceContractGenerator (CodeCompileUnit targetCompileUnit, ConfigurationType targetConfig)
                {
-                       if (ccu == null)
+                       if (targetCompileUnit == null)
                                this.ccu = new CodeCompileUnit ();
                        else
-                               this.ccu = ccu;
-                       this.config = config;
+                               this.ccu = targetCompileUnit;
+                       this.config = targetConfig;
                        Options |= ServiceContractGenerationOptions.ChannelInterface | 
                                ServiceContractGenerationOptions.ClientClass;
                }
index 4235e393b8a89b489410fa67a541f53435db877c..5b6caccb2c20e38db25c6cf5a42c9fc68ebe9c10 100644 (file)
@@ -81,30 +81,30 @@ namespace System.ServiceModel.Description
                        set { service_type = value; }
                }
 
-               public static ServiceDescription GetService (Type type)
+               public static ServiceDescription GetService (Type serviceType)
                {
                        // null Type is not rejected
                        ServiceDescription sd = new ServiceDescription ();
-                       sd.ServiceType = type;
-                       if (type != null) {
-                               var att = type.GetCustomAttribute<ServiceBehaviorAttribute> (true);
+                       sd.ServiceType = serviceType;
+                       if (serviceType != null) {
+                               var att = serviceType.GetCustomAttribute<ServiceBehaviorAttribute> (true);
                                if (att != null) {
                                        sd.Name = att.Name;
                                        sd.Namespace = att.Namespace;
                                }
                                if (sd.Name == null)
-                                       sd.Name = type.Name;
+                                       sd.Name = serviceType.Name;
                                if (sd.Namespace == null)
                                        sd.Namespace = "http://tempuri.org/";
                        }
                        return sd;
                }
 
-               public static ServiceDescription GetService (object wellKnown)
+               public static ServiceDescription GetService (object serviceImplementation)
                {
                        // null instance is not rejected
                        ServiceDescription sd = new ServiceDescription ();
-                       sd.ServiceType = wellKnown != null ? wellKnown.GetType () : null;
+                       sd.ServiceType = serviceImplementation != null ? serviceImplementation.GetType () : null;
                        return sd;
                }
        }
index 191d411ed41c86e21abe97d4709a70aeb911dc9d..6641e62b4da9757f092aa0fbd763d6ccd258f0ac 100644 (file)
@@ -38,27 +38,27 @@ namespace System.ServiceModel.Description
                {
                }
 
-               public ServiceEndpoint Find (Type type)
+               public ServiceEndpoint Find (Type contractType)
                {
                        foreach (ServiceEndpoint e in this)
-                               if (e.Contract.ContractType == type)
+                               if (e.Contract.ContractType == contractType)
                                        return e;
                        return null;
                }
 
-               public ServiceEndpoint Find (Uri uri)
+               public ServiceEndpoint Find (Uri address)
                {
                        foreach (ServiceEndpoint e in this)
-                               if (e.Address.Uri == uri)
+                               if (e.Address.Uri == address)
                                        return e;
                        return null;
                }
 
-               public ServiceEndpoint Find (XmlQualifiedName name)
+               public ServiceEndpoint Find (XmlQualifiedName contractName)
                {
                        foreach (ServiceEndpoint e in this)
-                               if (e.Contract.Name == name.Name &&
-                                       e.Contract.Namespace == name.Namespace)
+                               if (e.Contract.Name == contractName.Name &&
+                                       e.Contract.Namespace == contractName.Namespace)
                                        return e;
                        return null;
                }
@@ -96,13 +96,13 @@ namespace System.ServiceModel.Description
                        return list;
                }
 
-               public Collection<ServiceEndpoint> FindAll (XmlQualifiedName name)
+               public Collection<ServiceEndpoint> FindAll (XmlQualifiedName contractName)
                {
                        Collection<ServiceEndpoint> list =
                                new Collection<ServiceEndpoint> ();
                        foreach (ServiceEndpoint e in this)
-                               if (e.Contract.Name == name.Name &&
-                                   e.Contract.Namespace == name.Namespace)
+                               if (e.Contract.Name == contractName.Name &&
+                                   e.Contract.Namespace == contractName.Namespace)
                                        list.Add (e);
                        return list;
                }
index 153f3713d2e4bcee7ad3605cb75e4e6db9ddf9ff..aff8033dacdd3f22cc962b1fecc0036adac2a28d 100644 (file)
@@ -73,50 +73,50 @@ namespace System.ServiceModel.Description
                }
 
                public static TypedMessageConverter Create (
-                       Type type, string action)
+                       Type messageContract, string action)
                {
-                       return Create (type, action, TempUri);
+                       return Create (messageContract, action, TempUri);
                }
 
                public static TypedMessageConverter Create (
-                       Type type, string action,
+                       Type messageContract, string action,
                        string defaultNamespace)
                {
-                       return Create (type, action, defaultNamespace, (DataContractFormatAttribute)null);
+                       return Create (messageContract, action, defaultNamespace, (DataContractFormatAttribute)null);
                }
 
                public static TypedMessageConverter Create (
-                       Type type, string action,
+                       Type messageContract, string action,
                        DataContractFormatAttribute formatterAttribute)
                {
-                       return Create (type, action, TempUri, formatterAttribute);
+                       return Create (messageContract, action, TempUri, formatterAttribute);
                }
 
                public static TypedMessageConverter Create (
-                       Type type,
+                       Type messageContract,
                        string action, string defaultNamespace,
                        DataContractFormatAttribute formatterAttribute)
                {
                        return new DefaultTypedMessageConverter (
                                new DataContractMessagesFormatter (
-                                       MessageContractToMessagesDescription (type, defaultNamespace, action),
+                                       MessageContractToMessagesDescription (messageContract, defaultNamespace, action),
                                        formatterAttribute));
                }
 
                public static TypedMessageConverter Create (
-                       Type type, string action,
+                       Type messageContract, string action,
                        XmlSerializerFormatAttribute formatterAttribute)
                {
-                       return Create (type, action, TempUri, formatterAttribute);
+                       return Create (messageContract, action, TempUri, formatterAttribute);
                }
 
                public static TypedMessageConverter Create (
-                       Type type, string action, string defaultNamespace,
+                       Type messageContract, string action, string defaultNamespace,
                        XmlSerializerFormatAttribute formatterAttribute)
                {
                        return new DefaultTypedMessageConverter (
                                new XmlMessagesFormatter (
-                                       MessageContractToMessagesDescription (type, defaultNamespace, action),
+                                       MessageContractToMessagesDescription (messageContract, defaultNamespace, action),
                                        formatterAttribute));
                }
 
index da253dd1e955feb176377b7cdde0bd83369401e0..b604d64c8ecfb84f1d2630973267987e50d6cb3a 100644 (file)
@@ -76,7 +76,7 @@ namespace System.ServiceModel.Description
                }
 
                public MessageDescription GetMessageDescription (
-                       MessageBinding message)
+                       MessageBinding messageBinding)
                {
                        throw new NotImplementedException ();
                }
@@ -88,7 +88,7 @@ namespace System.ServiceModel.Description
                }
 
                public OperationDescription GetOperationDescription (
-                       OperationBinding operation)
+                       OperationBinding operationBinding)
                {
                        throw new NotImplementedException ();
                }
index be5e051ff47524fa6ac28485f5baaa1836fa7e1a..a1ceff80101413176fcbd12990cfc34cdda04767 100644 (file)
@@ -441,12 +441,12 @@ namespace System.ServiceModel.Description
 
                public void ExportEndpoints (
                        IEnumerable<ServiceEndpoint> endpoints,
-                       XmlQualifiedName name)
+                       XmlQualifiedName wsdlServiceQName)
                {
                        if (endpoints == null)
                                throw new ArgumentNullException ("endpoints");
-                       if (name == null)
-                               throw new ArgumentNullException ("name");
+                       if (wsdlServiceQName == null)
+                               throw new ArgumentNullException ("wsdlServiceQName");
 
                        foreach (ServiceEndpoint ep in endpoints) {
                                if (ep.Contract.Name == ServiceMetadataBehavior.MexContractName)
index 562e02b25d43fd7b718d077cd2a6c23a80d2277b..dd95be31d54ae4331d1bdaf8669e09bb0ef0cb6d 100644 (file)
@@ -153,9 +153,9 @@ namespace System.ServiceModel.Description
                        beforeImportCalled = true;
                }
 
-               public SMBinding ImportBinding (WSBinding binding)
+               public SMBinding ImportBinding (WSBinding wsdlBinding)
                {
-                       return ImportBinding (binding, true).Binding;
+                       return ImportBinding (wsdlBinding, true).Binding;
                }
 
                ServiceEndpoint ImportBinding (WSBinding binding, bool throwOnError)
@@ -546,20 +546,20 @@ namespace System.ServiceModel.Description
                        }
                }
 
-               public ServiceEndpointCollection ImportEndpoints (WSBinding binding)
+               public ServiceEndpointCollection ImportEndpoints (WSBinding wsdlBinding)
                {
                        var coll = new ServiceEndpointCollection ();
-                       ImportEndpoints (coll, binding);
+                       ImportEndpoints (coll, wsdlBinding);
                        return coll;
                }
 
-               public ServiceEndpointCollection ImportEndpoints (PortType portType)
+               public ServiceEndpointCollection ImportEndpoints (PortType wsdlPortType)
                {
                        var coll = new ServiceEndpointCollection ();
 
                        foreach (WSServiceDescription wsd in wsdl_documents) {
                                foreach (WS.Binding binding in wsd.Bindings) {
-                                       if (!binding.Type.Name.Equals (portType.Name))
+                                       if (!binding.Type.Name.Equals (wsdlPortType.Name))
                                                continue;
 
                                        ImportEndpoints (coll, binding);
@@ -569,11 +569,11 @@ namespace System.ServiceModel.Description
                        return coll;
                }
 
-               public ServiceEndpointCollection ImportEndpoints (Service service)
+               public ServiceEndpointCollection ImportEndpoints (Service wsdlService)
                {
                        var coll = new ServiceEndpointCollection ();
                        
-                       foreach (Port port in service.Ports) {
+                       foreach (Port port in wsdlService.Ports) {
                                var sep = ImportEndpoint (port, false);
                                if (sep != null)
                                        coll.Add (sep);
index 26ee9d753d8beec3770a30e0154032b6e7534cc7..6a43f3510e9f1e667ed8fef1600252c7349da942 100644 (file)
@@ -51,13 +51,13 @@ namespace System.ServiceModel.Description
 
                public XmlSerializerOperationBehavior (
                        OperationDescription operation,
-                       XmlSerializerFormatAttribute format)
+                       XmlSerializerFormatAttribute attribute)
                {
                        if (operation == null)
                                throw new ArgumentNullException ("operation");
-                       if (format == null)
-                               format = new XmlSerializerFormatAttribute ();
-                       this.format = format;
+                       if (attribute == null)
+                               attribute = new XmlSerializerFormatAttribute ();
+                       this.format = attribute;
                        this.operation = operation;
                }
 
index 07ecb269b3a6aec28cd0bbf1bbb3303dacd57d6e..714395236747afb0f6bc4cdd8e259565c4a34086 100644 (file)
@@ -70,10 +70,10 @@ namespace System.ServiceModel.Dispatcher {
                        return false;
                }
 
-               public override bool Match (MessageBuffer buffer)
+               public override bool Match (MessageBuffer messageBuffer)
                {
                        bool retval;
-                       Message m = buffer.CreateMessage ();
+                       Message m = messageBuffer.CreateMessage ();
                        retval = Match (m);
                        m.Close ();
                        
index ed5cdd8428ef1d2144d21982ef00848085890a39..72133244baba28e708b9da3a0b19c99d491d0ab6 100644 (file)
@@ -65,6 +65,6 @@ namespace System.ServiceModel.Dispatcher {
                        set { transport_handler = value; }
                }
 
-               public abstract bool HandleException (Exception e);
+               public abstract bool HandleException (Exception exception);
        }
 }
\ No newline at end of file
index faa7b6c0773dd411403867749b50c04bce9f8997..9479897fb0c5a5dafd308d4413643cc7f09c7b6f 100644 (file)
@@ -38,19 +38,19 @@ namespace System.ServiceModel.Dispatcher
                Collection<MessageFilter> filters;
 
                public FilterInvalidBodyAccessException () : base ("Not allowed to navigate to body.") {}
-               public FilterInvalidBodyAccessException (string msg) : base (msg) {}
-               public FilterInvalidBodyAccessException (string msg, Exception inner) : base (msg, inner) {}            
+               public FilterInvalidBodyAccessException (string message) : base (message) {}
+               public FilterInvalidBodyAccessException (string message, Exception innerException) : base (message, innerException) {}          
                protected FilterInvalidBodyAccessException (SerializationInfo info, StreamingContext context)
                        : base (info, context) {}
 
-               public FilterInvalidBodyAccessException (string msg, Collection<MessageFilter> filters)
-                       : base (msg)
+               public FilterInvalidBodyAccessException (string message, Collection<MessageFilter> filters)
+                       : base (message)
                {
                        this.filters = filters;
                }
 
-               public FilterInvalidBodyAccessException (string msg, Exception inner, Collection<MessageFilter> filters)
-                       : base (msg, inner)
+               public FilterInvalidBodyAccessException (string message, Exception innerException, Collection<MessageFilter> filters)
+                       : base (message, innerException)
                {
                        this.filters = filters;
                }
index ca367777b14cca7389dbca13b83d340cb76e5146..b00e94f0428b66808f083685682c24d1de5d3651 100644 (file)
@@ -32,6 +32,6 @@ namespace System.ServiceModel.Dispatcher
        public interface IDispatchMessageFormatter
        {
                void DeserializeRequest (Message message, object [] parameters);
-               Message SerializeReply (MessageVersion version, object [] parameters, object result);
+               Message SerializeReply (MessageVersion messageVersion, object [] parameters, object result);
        }
 }
index b9c278cf08422724d89b7716f6d4296948785f5c..a8fcaac45ef6a92464916f900fb2849cf9c40804 100644 (file)
@@ -32,8 +32,8 @@ namespace System.ServiceModel.Dispatcher
 {
        public interface IDispatchMessageInspector
        {
-               object AfterReceiveRequest (ref Message message,
-                       IClientChannel channel, InstanceContext context);
-               void BeforeSendReply (ref Message message, object instance);
+               object AfterReceiveRequest (ref Message request,
+                       IClientChannel channel, InstanceContext instanceContext);
+               void BeforeSendReply (ref Message reply, object correlationState);
        }
 }
index 04441f07955efb455d0fcee2856348c263dc1ee5..49357ef56863269348a080a839738b7acffb52fe 100644 (file)
@@ -32,6 +32,6 @@ namespace System.ServiceModel.Dispatcher
 {
        public interface IDispatchOperationSelector
        {
-               string SelectOperation (ref Message msg);
+               string SelectOperation (ref Message message);
        }
 }
index f9b2f101b160d737038d595a15a986adebe3e930..9f5e99a6092cf72380f0834e6ed2e02e6a997986 100644 (file)
@@ -31,8 +31,8 @@ namespace System.ServiceModel.Dispatcher
 {
        public interface IErrorHandler
        {
-               bool HandleError (Exception exception);
-               void ProvideFault (Exception exception, MessageVersion version,
+               bool HandleError (Exception error);
+               void ProvideFault (Exception error, MessageVersion version,
                        ref Message fault);
        }
 }
index d3887da87794259b34f4c5d0dd4c5dbd0e68d95b..3d26c75c0970408c2cfa0d3ac78110f81964f79c 100644 (file)
@@ -32,6 +32,6 @@ namespace System.ServiceModel.Dispatcher
 {
        public interface IInstanceContextInitializer
        {
-               void Initialize (InstanceContext context, Message message);
+               void Initialize (InstanceContext instanceContext, Message message);
        }
 }
index eb93926827220c09b572bb64aa8ba8e32baf240f..22ba41ccfbcbc06688303a952306cf1a1b4b16b0 100644 (file)
@@ -31,8 +31,8 @@ namespace System.ServiceModel.Dispatcher
 {
        public interface IInstanceProvider
        {
-               object GetInstance (InstanceContext context);
-               object GetInstance (InstanceContext context, Message message);
-               void ReleaseInstance (InstanceContext context, object instance);
+               object GetInstance (InstanceContext instanceContext);
+               object GetInstance (InstanceContext instanceContext, Message message);
+               void ReleaseInstance (InstanceContext instanceContext, object instance);
        }
 }
index 5e185ac55b3899221f1d6415d8ce1b8938887023..6e5967ab6580d3633de8cca60a481a8804062b8d 100644 (file)
@@ -40,16 +40,16 @@ namespace System.ServiceModel.Dispatcher
                  IEnumerable<KeyValuePair<MessageFilter,TFilterData>>,
                  IEnumerable
        {
-               bool GetMatchingFilter (Message message, out MessageFilter result);
-               bool GetMatchingFilter (MessageBuffer buffer, out MessageFilter result);
+               bool GetMatchingFilter (Message message, out MessageFilter filter);
+               bool GetMatchingFilter (MessageBuffer messageBuffer, out MessageFilter filter);
 
                bool GetMatchingFilters (Message message, ICollection<MessageFilter> results);
-               bool GetMatchingFilters (MessageBuffer buffer, ICollection<MessageFilter> results);
+               bool GetMatchingFilters (MessageBuffer messageBuffer, ICollection<MessageFilter> results);
 
-               bool GetMatchingValue (Message message, out TFilterData data);
-               bool GetMatchingValue (MessageBuffer buffer, out TFilterData data);
+               bool GetMatchingValue (Message message, out TFilterData value);
+               bool GetMatchingValue (MessageBuffer messageBuffer, out TFilterData value);
 
                bool GetMatchingValues (Message message, ICollection<TFilterData> results);
-               bool GetMatchingValues (MessageBuffer buffer, ICollection<TFilterData> results);
+               bool GetMatchingValues (MessageBuffer messageBuffer, ICollection<TFilterData> results);
        }
 }
index 9d46d2743b9e1a353970771248a04f54857bd291..ad6a5194a1bbfb31e6099257b922fdd2a6e3be7f 100644 (file)
@@ -1,4 +1,4 @@
-//
+//
 // InstanceContextIdleCallback.cs
 //
 // Author: Atsushi Enomoto (atsushi@ximian.com)
@@ -28,5 +28,5 @@ using System;
 
 namespace System.ServiceModel.Dispatcher
 {
-       public delegate void InstanceContextIdleCallback (InstanceContext context);
+       public delegate void InstanceContextIdleCallback (InstanceContext instanceContext);
 }
index 2c34c3cd679ec87966115928b9dc2944dfaf84fb..7474906c6d097c1f434d7c25db76f84cd7151ac0 100644 (file)
@@ -34,8 +34,8 @@ namespace System.ServiceModel.Dispatcher
        [Serializable]
        public abstract class InvalidBodyAccessException : SystemException
        {
-               protected InvalidBodyAccessException (string msg) : base (msg) {}
-               protected InvalidBodyAccessException (string msg, Exception inner) : base (msg, inner) {}
+               protected InvalidBodyAccessException (string message) : base (message) {}
+               protected InvalidBodyAccessException (string message, Exception innerException) : base (message, innerException) {}
                protected InvalidBodyAccessException (SerializationInfo info, StreamingContext context)
                        : base (info, context) {}
        }
index 4f0aa6be5ea546d4d8d58c973ee2b8c2a9ce96b9..5b9de5e2f4ab00073d2000e425ec7a24fe510c62 100644 (file)
@@ -44,7 +44,7 @@ namespace System.ServiceModel.Dispatcher
                        return true; 
                }
 
-               public override bool Match (MessageBuffer buffer)
+               public override bool Match (MessageBuffer messageBuffer)
                {
                        // as documented
                        return true; 
index 32721443858f81762591eca6ce5f6f1e27cd4fb8..d0fe3aef8673ce1164e5a03d353e977707d278ad 100644 (file)
@@ -44,7 +44,7 @@ namespace System.ServiceModel.Dispatcher
                        return false; 
                }
 
-               public override bool Match (MessageBuffer buffer)
+               public override bool Match (MessageBuffer messageBuffer)
                {
                        // as documented
                        return false; 
index 50b526a913edc89f2b7b2022fc758cc55c808217..5801ca38919839dc1716ce59eb4db456ccf7b3f1 100644 (file)
@@ -38,19 +38,19 @@ namespace System.ServiceModel.Dispatcher
                Collection<MessageFilter> filters;
 
                public MessageFilterException () : this ("MessageFilter node quota exceeded.") {}
-               public MessageFilterException (string msg) : base (msg) {}
-               public MessageFilterException (string msg, Exception inner) : base (msg, inner) {}              
+               public MessageFilterException (string message) : base (message) {}
+               public MessageFilterException (string message, Exception innerException) : base (message, innerException) {}            
                protected MessageFilterException (SerializationInfo info, StreamingContext context)
                        : base (info, context) {}
 
-               public MessageFilterException (string msg, Collection<MessageFilter> filters)
-                       : base (msg)
+               public MessageFilterException (string message, Collection<MessageFilter> filters)
+                       : base (message)
                {
                        this.filters = filters;
                }
 
-               public MessageFilterException (string msg, Exception inner, Collection<MessageFilter> filters)
-                       : base (msg, inner)
+               public MessageFilterException (string message, Exception innerException, Collection<MessageFilter> filters)
+                       : base (message, innerException)
                {
                        this.filters = filters;
                }
index b0f4021300292bd10deb855efdae037b40924406..e93fb8be4f9bd0d54e53b13b73ac60d217b3cc1d 100644 (file)
@@ -46,9 +46,9 @@ namespace System.ServiceModel.Dispatcher
                public MessageFilterTable ()
                        : this (0) {} // 0 is the default
 
-               public MessageFilterTable (int default_priority)
+               public MessageFilterTable (int defaultPriority)
                {
-                       this.default_priority = default_priority;
+                       this.default_priority = defaultPriority;
                        table = new Dictionary<MessageFilter, TFilterData> ();
                        priority_list = new Dictionary<MessageFilter, int> ();
                }
@@ -85,9 +85,9 @@ namespace System.ServiceModel.Dispatcher
                        return table.ContainsKey (filter);
                }
 
-               public void CopyTo (KeyValuePair<MessageFilter, TFilterData> [] array, int index)
+               public void CopyTo (KeyValuePair<MessageFilter, TFilterData> [] array, int arrayIndex)
                {
-                       ((ICollection) table).CopyTo (array, index);
+                       ((ICollection) table).CopyTo (array, arrayIndex);
                }
 
                protected virtual IMessageFilterTable<TFilterData> CreateFilterTable (MessageFilter filter)
@@ -105,11 +105,11 @@ namespace System.ServiceModel.Dispatcher
                        return priority_list [filter];
                }
 
-               public bool GetMatchingFilter (Message message, out MessageFilter result)
+               public bool GetMatchingFilter (Message message, out MessageFilter filter)
                {
                        if (message == null)
                                throw new ArgumentNullException ("message is null");
-                       result = null;
+                       filter = null;
 
                        int count = 0;
                        foreach (MessageFilter f in table.Keys) {
@@ -121,14 +121,14 @@ namespace System.ServiceModel.Dispatcher
                                            "More than one filter matches.");
 
                                count++;
-                               result = f;
+                               filter = f;
                        }
                        return count == 1;
                }
 
-               public bool GetMatchingFilter (MessageBuffer buffer, out MessageFilter result)
+               public bool GetMatchingFilter (MessageBuffer buffer, out MessageFilter filter)
                {
-                       return GetMatchingFilter (buffer.CreateMessage (), out result);
+                       return GetMatchingFilter (buffer.CreateMessage (), out filter);
                }
 
                [MonoTODO ("Consider priority")]                
index b33c0fdca294da28bf2aec5939c5e5f4f6e073e6..9f8caadeb9b435900d729cfce93daffa09609c31 100644 (file)
@@ -38,19 +38,19 @@ namespace System.ServiceModel.Dispatcher
                Collection<MessageFilter> filters;
 
                public MultipleFilterMatchesException () : base () {}
-               public MultipleFilterMatchesException (string msg) : base (msg) {}
-               public MultipleFilterMatchesException (string msg, Exception inner) : base (msg, inner) {}              
+               public MultipleFilterMatchesException (string message) : base (message) {}
+               public MultipleFilterMatchesException (string message, Exception innerException) : base (message, innerException) {}            
                protected MultipleFilterMatchesException (SerializationInfo info, StreamingContext context)
                        : base (info, context) {}
 
-               public MultipleFilterMatchesException (string msg, Collection<MessageFilter> filters)
-                       : base (msg)
+               public MultipleFilterMatchesException (string message, Collection<MessageFilter> filters)
+                       : base (message)
                {
                        this.filters = filters;
                }
 
-               public MultipleFilterMatchesException (string msg, Exception inner, Collection<MessageFilter> filters)
-                       : base (msg, inner)
+               public MultipleFilterMatchesException (string message, Exception innerException, Collection<MessageFilter> filters)
+                       : base (message, innerException)
                {
                        this.filters = filters;
                }
index 08d3b19f6ba622d6113125e643f2fe209c39a6c6..595110a87c276a29e3a2b086418a42b8e4951a4c 100644 (file)
@@ -35,8 +35,8 @@ namespace System.ServiceModel.Dispatcher
        public class NavigatorInvalidBodyAccessException : InvalidBodyAccessException
        {
                public NavigatorInvalidBodyAccessException () : base ("Not allowed to navigate to body.") {}
-               public NavigatorInvalidBodyAccessException (string msg) : base (msg) {}
-               public NavigatorInvalidBodyAccessException (string msg, Exception inner) : base (msg, inner) {}
+               public NavigatorInvalidBodyAccessException (string message) : base (message) {}
+               public NavigatorInvalidBodyAccessException (string message, Exception innerException) : base (message, innerException) {}
                protected NavigatorInvalidBodyAccessException (SerializationInfo info, StreamingContext context)
                        : base (info, context) {}
        }
index cac0bf91116dfbf8cd74e6f58893c90769c78ee2..a4f8f2c721a91cdeb077eeb9cdc92c65a4774143 100644 (file)
@@ -36,12 +36,12 @@ namespace System.ServiceModel.Dispatcher
        {
                protected SeekableXPathNavigator () {}
 
-               public abstract XmlNodeOrder ComparePosition (long first, long second);
-               public abstract string GetLocalName (long node_position);
-               public abstract string GetName (long node_position);
-               public abstract string GetNamespace (long node_position);
-               public abstract XPathNodeType GetNodeType (long node_position);
-               public abstract string GetValue (long node_position);
+               public abstract XmlNodeOrder ComparePosition (long firstPosition, long secondPosition);
+               public abstract string GetLocalName (long nodePosition);
+               public abstract string GetName (long nodePosition);
+               public abstract string GetNamespace (long nodePosition);
+               public abstract XPathNodeType GetNodeType (long nodePosition);
+               public abstract string GetValue (long nodePosition);
 
                public abstract long CurrentPosition { get; set; }
        }
index 3bef60dc7cf8b33c4a41ce81b6d17ce60baebdab..302facfca815b83b1737ec7e030db4cb223bba42 100644 (file)
@@ -41,8 +41,8 @@ namespace System.ServiceModel.Dispatcher
                {
                }
 
-               public XPathMessageContext (NameTable nameTable)
-                       : base (nameTable)
+               public XPathMessageContext (NameTable table)
+                       : base (table)
                {
                        AddNamespace ("s11", Constants.Soap11);
                        AddNamespace ("s12", Constants.Soap12);
@@ -52,9 +52,9 @@ namespace System.ServiceModel.Dispatcher
                        get { return false; } // as documented.
                }
 
-               public override int CompareDocument (string uri1, string uri2)
+               public override int CompareDocument (string baseUri, string nextBaseUri)
                {
-                       return String.CompareOrdinal (uri1, uri2);
+                       return String.CompareOrdinal (baseUri, nextBaseUri);
                }
 
                public override bool PreserveWhitespace (XPathNavigator node)
index 17a612b62a1bdc3c6ee19c0b6be4ab2603a3e8e0..658a5d1ed05377b507747c963e24d1caaafd7c70 100644 (file)
@@ -68,9 +68,9 @@ namespace System.ServiceModel.Dispatcher
                        Initialize (xpath, namespaces);
                }
 
-               public XPathMessageFilter (string xpath, XsltContext namespaces)
+               public XPathMessageFilter (string xpath, XsltContext context)
                {
-                       Initialize (xpath, namespaces);
+                       Initialize (xpath, context);
                }
 
                [MonoTODO]
@@ -86,9 +86,9 @@ namespace System.ServiceModel.Dispatcher
                }
 
                [MonoTODO]
-               public XPathMessageFilter (XmlReader reader, XsltContext namespaces)
+               public XPathMessageFilter (XmlReader reader, XsltContext context)
                {
-                       Initialize (reader.ReadString (), namespaces);
+                       Initialize (reader.ReadString (), context);
                }
 
                private void Initialize (string xpath, XmlNamespaceManager nsmgr)
index 71d7536fd34d95852b8f0af0763bfe1611f25552..f0c72f5de86e0d3a8e954e08c6f781a6d1df21fb 100644 (file)
@@ -55,9 +55,9 @@ namespace System.ServiceModel.Dispatcher
                {
                }
 
-               public XPathMessageFilterTable (int quota)
+               public XPathMessageFilterTable (int capacity)
                {
-                       this.quota = quota;
+                       this.quota = capacity;
                }
 
                [DataMember]
@@ -66,9 +66,9 @@ namespace System.ServiceModel.Dispatcher
                        set { quota = value; }
                }
 
-               public TFilterData this [MessageFilter key] {
-                       get { return dict [key]; }
-                       set { dict [key] = value; }
+               public TFilterData this [MessageFilter filter] {
+                       get { return dict [filter]; }
+                       set { dict [filter] = value; }
                }
 
                public int Count {
@@ -114,17 +114,17 @@ namespace System.ServiceModel.Dispatcher
                                dict [item.Key].Equals (item.Value);
                }
 
-               public bool ContainsKey (MessageFilter key)
+               public bool ContainsKey (MessageFilter filter)
                {
-                       return dict.ContainsKey (key);
+                       return dict.ContainsKey (filter);
                }
 
-               public void CopyTo (KeyValuePair<MessageFilter,TFilterData> [] array, int index)
+               public void CopyTo (KeyValuePair<MessageFilter,TFilterData> [] array, int arrayIndex)
                {
-                       if (index < 0 || dict.Count >= array.Length - index)
-                               throw new ArgumentOutOfRangeException ("index");
+                       if (arrayIndex < 0 || dict.Count >= array.Length - arrayIndex)
+                               throw new ArgumentOutOfRangeException ("arrayIndex");
                        foreach (KeyValuePair<MessageFilter,TFilterData> item in dict)
-                               array [index++] = item;
+                               array [arrayIndex++] = item;
                }
 
                public IEnumerator<KeyValuePair<MessageFilter,TFilterData>> GetEnumerator ()
@@ -137,12 +137,12 @@ namespace System.ServiceModel.Dispatcher
                        return GetEnumerator ();
                }
 
-               public bool GetMatchingFilter (Message message, out MessageFilter result)
+               public bool GetMatchingFilter (Message message, out MessageFilter filter)
                {
                        throw new NotImplementedException ();
                }
 
-               public bool GetMatchingFilter (MessageBuffer buffer, out MessageFilter result)
+               public bool GetMatchingFilter (MessageBuffer messageBuffer, out MessageFilter filter)
                {
                        throw new NotImplementedException ();
                }
@@ -162,7 +162,7 @@ namespace System.ServiceModel.Dispatcher
                        throw new NotImplementedException ();
                }
 
-               public bool GetMatchingFilters (MessageBuffer buffer, ICollection<MessageFilter> results)
+               public bool GetMatchingFilters (MessageBuffer messageBuffer, ICollection<MessageFilter> results)
                {
                        throw new NotImplementedException ();
                }
@@ -182,7 +182,7 @@ namespace System.ServiceModel.Dispatcher
                        throw new NotImplementedException ();
                }
 
-               public bool GetMatchingValue (MessageBuffer buffer, out TFilterData data)
+               public bool GetMatchingValue (MessageBuffer messageBuffer, out TFilterData data)
                {
                        throw new NotImplementedException ();
                }
@@ -202,7 +202,7 @@ namespace System.ServiceModel.Dispatcher
                        throw new NotImplementedException ();
                }
 
-               public bool GetMatchingValues (MessageBuffer buffer, ICollection<TFilterData> results)
+               public bool GetMatchingValues (MessageBuffer messageBuffer, ICollection<TFilterData> results)
                {
                        throw new NotImplementedException ();
                }
index 365a7be5bfe80b1fd42c6bdd511e84a77f542675..b3cd66a6a3b84100488fe031ea6babcacc6d98ea 100644 (file)
@@ -36,9 +36,9 @@ namespace System.ServiceModel.Dispatcher
        public class XPathNavigatorException : XPathException
        {
                public XPathNavigatorException () : this ("Navigator node quota exceeded") {}
-               public XPathNavigatorException (string msg) : base (msg) {}
-               public XPathNavigatorException (string msg, Exception inner)
-                       : base (msg, inner) {}          
+               public XPathNavigatorException (string message) : base (message) {}
+               public XPathNavigatorException (string message, Exception innerException)
+                       : base (message, innerException) {}             
                protected XPathNavigatorException (SerializationInfo info,
                                                            StreamingContext context)
                        : base (info, context) {}
index 654f8550330973a4765650813a586261231cf202..a060cf0f5a8cac66caff65397819677ecec9a7d7 100644 (file)
@@ -29,10 +29,10 @@ namespace System.ServiceModel.PeerResolvers
                {
                }
                
-               public UnregisterInfo (string meshId, Guid registration_id)
+               public UnregisterInfo (string meshId, Guid registrationId)
                {
                        Body.MeshId = meshId;
-                       Body.RegistrationId = registration_id;
+                       Body.RegistrationId = registrationId;
                }
                
                public string MeshId {
index a865639e0b4744285ce77bb8281f43fde67b6221..762e5876baf5fd8978121560c14fab0474490b31 100644 (file)
@@ -61,17 +61,17 @@ namespace System.ServiceModel.Security.Tokens
                        binding = issuerBinding;
                }
 
-               protected IssuedSecurityTokenParameters (IssuedSecurityTokenParameters source)
-                       : base (source)
+               protected IssuedSecurityTokenParameters (IssuedSecurityTokenParameters other)
+                       : base (other)
                {
-                       binding = source.binding;
-                       issuer_address = source.issuer_address;
-                       issuer_meta_address = source.issuer_meta_address;
-                       key_size = source.key_size;
-                       key_type = source.key_type;
-                       token_type = source.token_type;
-                       reqs = new Collection<ClaimTypeRequirement> (source.reqs);
-                       additional_reqs = new Collection<XmlElement> (source.additional_reqs);
+                       binding = other.binding;
+                       issuer_address = other.issuer_address;
+                       issuer_meta_address = other.issuer_meta_address;
+                       key_size = other.key_size;
+                       key_type = other.key_type;
+                       token_type = other.token_type;
+                       reqs = new Collection<ClaimTypeRequirement> (other.reqs);
+                       additional_reqs = new Collection<XmlElement> (other.additional_reqs);
                }
 
                Binding binding;
index 37a82c0123157300da9aedea85c3137d6f6b4f74..9d6a5f0797886b31d4e45a069605b784ef063b63 100644 (file)
@@ -37,8 +37,8 @@ namespace System.ServiceModel.Security.Tokens
                {
                }
 
-               protected KerberosSecurityTokenParameters (KerberosSecurityTokenParameters source)
-                       : base (source)
+               protected KerberosSecurityTokenParameters (KerberosSecurityTokenParameters other)
+                       : base (other)
                {
                }
 
index f0dcdee2cf13a51355968891d5aba1b7f8ebc34a..02e2a7818b5d644f40365cd8a95b099f251a5fab 100644 (file)
@@ -39,8 +39,8 @@ namespace System.ServiceModel.Security.Tokens
                        RequireDerivedKeys = true;
                }
 
-               protected RsaSecurityTokenParameters (RsaSecurityTokenParameters source)
-                       : base (source)
+               protected RsaSecurityTokenParameters (RsaSecurityTokenParameters other)
+                       : base (other)
                {
                }
 
index 41a1376f053884266ff70be148235365855c5d36..16ea4653b1c851c9f280b5c569b9bc2d35af2de9 100644 (file)
@@ -111,11 +111,11 @@ namespace System.ServiceModel.Security.Tokens
                }
 #endif
 
-               protected SecureConversationSecurityTokenParameters (SecureConversationSecurityTokenParameters source)
-                       : base (source)
+               protected SecureConversationSecurityTokenParameters (SecureConversationSecurityTokenParameters other)
+                       : base (other)
                {
-                       this.element = (SecurityBindingElement) source.element.Clone ();
-                       this.cancellable = source.cancellable;
+                       this.element = (SecurityBindingElement) other.element.Clone ();
+                       this.cancellable = other.cancellable;
 #if !MOBILE && !XAMMAC_4_5
                        this.requirements = new ChannelProtectionRequirements (default_channel_protection_requirements);
 #endif
index 846d8358f519cfd8d0be81db5d058ead9da936fe..3bff55ef9db3d67b1f476261ac9ae491dac9de31 100644 (file)
@@ -200,10 +200,10 @@ namespace System.ServiceModel.Security.Tokens
                        throw new NotSupportedException (String.Format ("X509SecurityToken does not support creation of {0}.", t));
                }
 
-               public override bool MatchesKeyIdentifierClause (SecurityKeyIdentifierClause clause)
+               public override bool MatchesKeyIdentifierClause (SecurityKeyIdentifierClause keyIdentifierClause)
                {
                        SecurityContextKeyIdentifierClause sctic =
-                               clause as SecurityContextKeyIdentifierClause;
+                               keyIdentifierClause as SecurityContextKeyIdentifierClause;
                        return sctic != null && sctic.ContextId == ContextId &&
                               sctic.Generation == KeyGeneration;
                }
index 92bbf9d37f6f57c6d014526a8c07664883f7a075..9eb21fd621c303ddc3a5be88f6a099231590d05f 100644 (file)
@@ -52,11 +52,11 @@ namespace System.ServiceModel.Security.Tokens
                        this.cancel = requireCancellation;
                }
 
-               protected SslSecurityTokenParameters (SslSecurityTokenParameters source)
-                       : base (source)
+               protected SslSecurityTokenParameters (SslSecurityTokenParameters other)
+                       : base (other)
                {
-                       cert = source.cert;
-                       cancel = source.cancel;
+                       cert = other.cert;
+                       cancel = other.cancel;
                }
 
                bool cert, cancel;
index be273ce27e5dcfc2c7ffeaa9143f4cf4fde351db..72e2cb0a92b4eb525ed46f4b7a2277da11f4dc26 100644 (file)
@@ -44,7 +44,7 @@ namespace System.ServiceModel.Security.Tokens
                bool extract_groups, allow_unauth;
 
                [MonoTODO]
-               public SspiSecurityToken (NetworkCredential cred,
+               public SspiSecurityToken (NetworkCredential networkCredential,
                        bool extractGroupsForWindowsAccounts,
                        bool allowUnauthenticatedCallers)
                {
@@ -54,7 +54,7 @@ namespace System.ServiceModel.Security.Tokens
                [MonoTODO]
                public SspiSecurityToken (
                        TokenImpersonationLevel impersonationLevel,
-                       bool allowNtlm, NetworkCredential cred)
+                       bool allowNtlm, NetworkCredential networkCredential)
                {
                        throw new NotImplementedException ();
                }
index 16cf529e431de4ddff06959651061719efcc450a..1efbf1f1cd34a578343d4f63043e446a459574b4 100644 (file)
@@ -47,10 +47,10 @@ namespace System.ServiceModel.Security.Tokens
                        this.cancel = requireCancellation;
                }
 
-               protected SspiSecurityTokenParameters (SspiSecurityTokenParameters source)
-                       : base (source)
+               protected SspiSecurityTokenParameters (SspiSecurityTokenParameters other)
+                       : base (other)
                {
-                       this.cancel = source.cancel;
+                       this.cancel = other.cancel;
                }
 
                public bool RequireCancellation {
index 46f14360654c6e604d775af18b399764511d0e95..c69d8bb2c91ec889e17c02db273a7aee76f135a5 100644 (file)
@@ -40,8 +40,8 @@ namespace System.ServiceModel.Security.Tokens
                        RequireDerivedKeys = false;
                }
 
-               protected UserNameSecurityTokenParameters (UserNameSecurityTokenParameters source)
-                       : base (source)
+               protected UserNameSecurityTokenParameters (UserNameSecurityTokenParameters other)
+                       : base (other)
                {
                }
 
index c02dfd44342c14e30423551e80089277e9f70094..2d2aa06d568e4fdde23a91a7b8b45ee6c3e7fcb4 100644 (file)
@@ -51,10 +51,10 @@ namespace System.ServiceModel.Security.Tokens
                        InclusionMode = inclusionMode;
                }
 
-               protected X509SecurityTokenParameters (X509SecurityTokenParameters source)
-                       : base (source)
+               protected X509SecurityTokenParameters (X509SecurityTokenParameters other)
+                       : base (other)
                {
-                       reference_style = source.reference_style;
+                       reference_style = other.reference_style;
                }
 
                public X509KeyIdentifierClauseType X509ReferenceStyle {
index 17695f1ec289da5d15014570f974e479bf885c7a..7e30915cd66f993ab2e1fe81191e670b8a0d7c67 100644 (file)
@@ -95,14 +95,14 @@ namespace System.ServiceModel.Security
                                header_types = new ReadOnlyCollection<XmlQualifiedName> (header_types);
                }
 
-               public void Union (MessagePartSpecification other)
+               public void Union (MessagePartSpecification specification)
                {
-                       if (other == null)
-                               throw new ArgumentNullException ("other");
+                       if (specification == null)
+                               throw new ArgumentNullException ("specification");
                        if (header_types.IsReadOnly)
                                throw new InvalidOperationException ("This MessagePartSpecification is read-only.");
-                       body |= other.body;
-                       foreach (XmlQualifiedName q in other.header_types)
+                       body |= specification.body;
+                       foreach (XmlQualifiedName q in specification.header_types)
                                // Sigh. It could be much better here.
                                //if (!header_types.Contains (q))
                                        header_types.Add (q);
index d788a5a0b27ca6ace51b87cfb5db8e511483fca2..b747dee7c981d7428739d86dc279c056fa7361fc 100644 (file)
@@ -1,4 +1,4 @@
-//
+//
 // ServiceCredentialsSecurityTokenManager.cs
 //
 // Author:
@@ -44,9 +44,9 @@ namespace System.ServiceModel.Security
                ServiceCredentials credentials;
 
                public ServiceCredentialsSecurityTokenManager (
-                       ServiceCredentials credentials)
+                       ServiceCredentials parent)
                {
-                       this.credentials = credentials;
+                       this.credentials = parent;
                }
 
                public ServiceCredentials ServiceCredentials {
@@ -55,35 +55,35 @@ namespace System.ServiceModel.Security
 
                [MonoTODO]
                public virtual EndpointIdentity GetIdentityOfSelf (
-                       SecurityTokenRequirement requirement)
+                       SecurityTokenRequirement tokenRequirement)
                {
                        throw new NotImplementedException ();
                }
 
                [MonoTODO]
                public override SecurityTokenAuthenticator CreateSecurityTokenAuthenticator (
-                       SecurityTokenRequirement requirement,
+                       SecurityTokenRequirement tokenRequirement,
                        out SecurityTokenResolver outOfBandTokenResolver)
                {
                        outOfBandTokenResolver = null;
-                       if (requirement.TokenType == SecurityTokenTypes.UserName)
-                               return CreateUserNameAuthenticator (requirement);
-                       if (requirement.TokenType == SecurityTokenTypes.X509Certificate)
-                               return CreateX509Authenticator (requirement);
-                       if (requirement.TokenType == SecurityTokenTypes.Rsa)
+                       if (tokenRequirement.TokenType == SecurityTokenTypes.UserName)
+                               return CreateUserNameAuthenticator (tokenRequirement);
+                       if (tokenRequirement.TokenType == SecurityTokenTypes.X509Certificate)
+                               return CreateX509Authenticator (tokenRequirement);
+                       if (tokenRequirement.TokenType == SecurityTokenTypes.Rsa)
                                return new RsaSecurityTokenAuthenticator ();
-                       if (requirement.TokenType == ServiceModelSecurityTokenTypes.SecureConversation) {
+                       if (tokenRequirement.TokenType == ServiceModelSecurityTokenTypes.SecureConversation) {
                                SecurityBindingElement binding;
-                               if (!requirement.TryGetProperty<SecurityBindingElement> (ReqType.SecurityBindingElementProperty, out binding))
+                               if (!tokenRequirement.TryGetProperty<SecurityBindingElement> (ReqType.SecurityBindingElementProperty, out binding))
                                        throw new ArgumentException ("SecurityBindingElement is required in the security token requirement");
                                SecureConversationSecurityTokenParameters issuedParams;
-                               if (!requirement.TryGetProperty<SecureConversationSecurityTokenParameters> (ReqType.IssuedSecurityTokenParametersProperty, out issuedParams))
+                               if (!tokenRequirement.TryGetProperty<SecureConversationSecurityTokenParameters> (ReqType.IssuedSecurityTokenParametersProperty, out issuedParams))
                                        throw new ArgumentException ("IssuedSecurityTokenParameters are required in the security token requirement");
                                BindingContext issuerBC;
-                               if (!requirement.TryGetProperty<BindingContext> (ReqType.IssuerBindingContextProperty, out issuerBC))
+                               if (!tokenRequirement.TryGetProperty<BindingContext> (ReqType.IssuerBindingContextProperty, out issuerBC))
                                        throw new ArgumentException ("IssuerBindingContext is required in the security token requirement");
                                SecurityTokenVersion secVer;
-                               if (!requirement.TryGetProperty<SecurityTokenVersion> (ReqType.MessageSecurityVersionProperty, out secVer))
+                               if (!tokenRequirement.TryGetProperty<SecurityTokenVersion> (ReqType.MessageSecurityVersionProperty, out secVer))
                                        throw new ArgumentException ("MessageSecurityVersion property (of type SecurityTokenVersion) is required in the security token requirement");
 
                                // FIXME: get parameters from somewhere
@@ -92,16 +92,16 @@ namespace System.ServiceModel.Security
                                outOfBandTokenResolver = resolver;
                                SecurityContextSecurityTokenAuthenticator sc =
                                        new SecurityContextSecurityTokenAuthenticator ();
-                               return new SecureConversationSecurityTokenAuthenticator (requirement, sc, resolver);
+                               return new SecureConversationSecurityTokenAuthenticator (tokenRequirement, sc, resolver);
                        }
-                       if (requirement.TokenType == ServiceModelSecurityTokenTypes.AnonymousSslnego)
-                               return CreateSslTokenAuthenticator (requirement);
-                       if (requirement.TokenType == ServiceModelSecurityTokenTypes.MutualSslnego)
-                               return CreateSslTokenAuthenticator (requirement);
-                       if (requirement.TokenType == ServiceModelSecurityTokenTypes.Spnego)
-                               return CreateSpnegoTokenAuthenticator (requirement);
+                       if (tokenRequirement.TokenType == ServiceModelSecurityTokenTypes.AnonymousSslnego)
+                               return CreateSslTokenAuthenticator (tokenRequirement);
+                       if (tokenRequirement.TokenType == ServiceModelSecurityTokenTypes.MutualSslnego)
+                               return CreateSslTokenAuthenticator (tokenRequirement);
+                       if (tokenRequirement.TokenType == ServiceModelSecurityTokenTypes.Spnego)
+                               return CreateSpnegoTokenAuthenticator (tokenRequirement);
                        else
-                               throw new NotImplementedException ("Not implemented token type: " + requirement.TokenType);
+                               throw new NotImplementedException ("Not implemented token type: " + tokenRequirement.TokenType);
                }
 
                SpnegoSecurityTokenAuthenticator CreateSpnegoTokenAuthenticator (SecurityTokenRequirement requirement)
index 026daa9a8225a8cd4176fadb296b321bfe39bcc6..f690f32e86712321da088c641cc0a6ebabae5fc3 100644 (file)
@@ -239,7 +239,7 @@ namespace System.ServiceModel.Security
 
                [MonoTODO]
                public virtual SecurityKeyIdentifierClause CreateKeyIdentifierClauseFromTokenXml (
-                       XmlElement tokenXml, SecurityTokenReferenceStyle referenceStyle)
+                       XmlElement element, SecurityTokenReferenceStyle tokenReferenceStyle)
                {
                        throw new NotImplementedException ();
                }
index ac3b605cf9dbee23e19d6bc98c14751fe4e00442..0801770d6e948c8d2473a8121f14d9f872203bad 100644 (file)
@@ -34,8 +34,8 @@ namespace System.ServiceModel {
        public class AddressAccessDeniedException : CommunicationException
        {
                public AddressAccessDeniedException () : base () {}
-               public AddressAccessDeniedException (string msg) : base (msg) {}
-               public AddressAccessDeniedException (string msg, Exception inner) : base (msg, inner) {}
+               public AddressAccessDeniedException (string message) : base (message) {}
+               public AddressAccessDeniedException (string message, Exception innerException) : base (message, innerException) {}
                protected AddressAccessDeniedException (SerializationInfo info, StreamingContext context) :
                        base (info, context) {}
 
index 70103060fb190f9555c01b3216f1be8e084bf8b5..33e238146f556a066cbffa63da0679205eb44d12 100644 (file)
@@ -34,8 +34,8 @@ namespace System.ServiceModel {
        public class AddressAlreadyInUseException : CommunicationException
        {
                public AddressAlreadyInUseException () : base () {}
-               public AddressAlreadyInUseException (string msg) : base (msg) {}
-               public AddressAlreadyInUseException (string msg, Exception inner) : base (msg, inner) {}
+               public AddressAlreadyInUseException (string message) : base (message) {}
+               public AddressAlreadyInUseException (string message, Exception innerException) : base (message, innerException) {}
                protected AddressAlreadyInUseException (SerializationInfo info, StreamingContext context) :
                        base (info, context) {}
 
index 84b8f96db81167bdaab35788a4e94545208a1d82..d4d00e768cc499a726337e982617cbf2caa73ad5 100644 (file)
@@ -299,11 +299,11 @@ namespace System.ServiceModel
 
                protected void InitializeEndpoint (
                        string configurationName,
-                       EndpointAddress remoteAddress)
+                       EndpointAddress address)
                {
                        InitializeEndpoint (CreateDescription ());
-                       if (remoteAddress != null)
-                               service_endpoint.Address = remoteAddress;
+                       if (address != null)
+                               service_endpoint.Address = address;
                        ApplyConfiguration (configurationName);
                }
 
index 0f6560c743f6dec1e8d53e34efbeca3bf3b40dba..25277d302b919789384d0d62d260ef470a5dbf56 100644 (file)
@@ -125,14 +125,14 @@ namespace System.ServiceModel
                        return ch;
                }
 
-               public static TChannel CreateChannel (Binding binding, EndpointAddress address)
+               public static TChannel CreateChannel (Binding binding, EndpointAddress endpointAddress)
                {
-                       return CreateChannelCore (new ChannelFactory<TChannel> (binding, address), f => f.CreateChannel ());
+                       return CreateChannelCore (new ChannelFactory<TChannel> (binding, endpointAddress), f => f.CreateChannel ());
                }
 
-               public static TChannel CreateChannel (Binding binding, EndpointAddress address, Uri via)
+               public static TChannel CreateChannel (Binding binding, EndpointAddress endpointAddress, Uri via)
                {
-                       return CreateChannelCore (new ChannelFactory<TChannel> (binding), f => f.CreateChannel (address, via));
+                       return CreateChannelCore (new ChannelFactory<TChannel> (binding), f => f.CreateChannel (endpointAddress, via));
                }
 
                public virtual TChannel CreateChannel (EndpointAddress address, Uri via)
index 012b9b141ef6a2a6870928eaa62a0b955d26af18..2a5c04c74ebd26807f2b39d3681ca7240f5e5e6d 100644 (file)
@@ -35,8 +35,8 @@ namespace System.ServiceModel
        public class ChannelTerminatedException : CommunicationException
        {
                public ChannelTerminatedException () : base () {}
-               public ChannelTerminatedException (string msg) : base (msg) {}
-               public ChannelTerminatedException (string msg, Exception inner) : base (msg, inner) {}
+               public ChannelTerminatedException (string message) : base (message) {}
+               public ChannelTerminatedException (string message, Exception innerException) : base (message, innerException) {}
                protected ChannelTerminatedException (SerializationInfo info, StreamingContext context) :
                        base (info, context) {}
        }
index 09f72793c27e486e858b9feee2a0bd83d116a067..54d4067b3afe92e30b55a1488458958fcd39b53c 100644 (file)
@@ -75,58 +75,58 @@ namespace System.ServiceModel
                {
                }
 
-               protected ClientBase (InstanceContext instance)
-                       : this (instance, "*")
+               protected ClientBase (InstanceContext callbackInstance)
+                       : this (callbackInstance, "*")
                {
                }
 
-               protected ClientBase (InstanceContext instance, string endpointConfigurationName)
+               protected ClientBase (InstanceContext callbackInstance, string endpointConfigurationName)
                {
-                       if (instance == null)
+                       if (callbackInstance == null)
                                throw new ArgumentNullException ("instanceContext");
                        if (endpointConfigurationName == null)
                                throw new ArgumentNullException ("endpointConfigurationName");
 
-                       Initialize (instance, endpointConfigurationName, null);
+                       Initialize (callbackInstance, endpointConfigurationName, null);
                }
 
-               protected ClientBase (InstanceContext instance,
+               protected ClientBase (InstanceContext callbackInstance,
                        string endpointConfigurationName, EndpointAddress remoteAddress)
                {
-                       if (instance == null)
+                       if (callbackInstance == null)
                                throw new ArgumentNullException ("instanceContext");
                        if (endpointConfigurationName == null)
                                throw new ArgumentNullException ("endpointConfigurationName");
                        if (remoteAddress == null)
                                throw new ArgumentNullException ("remoteAddress");
 
-                       Initialize (instance, endpointConfigurationName, remoteAddress);
+                       Initialize (callbackInstance, endpointConfigurationName, remoteAddress);
                }
 
-               protected ClientBase (InstanceContext instance,
+               protected ClientBase (InstanceContext callbackInstance,
                        string endpointConfigurationName, string remoteAddress)
                {
-                       if (instance == null)
+                       if (callbackInstance == null)
                                throw new ArgumentNullException ("instanceContext");
                        if (remoteAddress == null)
                                throw new ArgumentNullException ("endpointAddress");
                        if (endpointConfigurationName == null)
                                throw new ArgumentNullException ("endpointConfigurationName");
 
-                       Initialize (instance, endpointConfigurationName, new EndpointAddress (remoteAddress));
+                       Initialize (callbackInstance, endpointConfigurationName, new EndpointAddress (remoteAddress));
                }
 
-               protected ClientBase (InstanceContext instance,
+               protected ClientBase (InstanceContext callbackInstance,
                        Binding binding, EndpointAddress remoteAddress)
                {
-                       if (instance == null)
+                       if (callbackInstance == null)
                                throw new ArgumentNullException ("instanceContext");
                        if (binding == null)
                                throw new ArgumentNullException ("binding");
                        if (remoteAddress == null)
                                throw new ArgumentNullException ("remoteAddress");
 
-                       Initialize (instance, binding, remoteAddress);
+                       Initialize (callbackInstance, binding, remoteAddress);
                }
 
                protected ClientBase (ServiceEndpoint endpoint)
@@ -134,8 +134,8 @@ namespace System.ServiceModel
                {
                }
 
-               protected ClientBase (InstanceContext instance, ServiceEndpoint endpoint)
-                       : this (instance, new ChannelFactory<TChannel> (endpoint))
+               protected ClientBase (InstanceContext callbackInstance, ServiceEndpoint endpoint)
+                       : this (callbackInstance, new ChannelFactory<TChannel> (endpoint))
                {
                }
 
index af12296808a117512ff236b0317124d08480185a..c19ad84413ee740b22b682f65a805658a0609aaf 100644 (file)
@@ -1,4 +1,4 @@
-//
+//
 // ClientCredentialsSecurityTokenManager.cs
 //
 // Author:
@@ -45,11 +45,11 @@ namespace System.ServiceModel
        {
                ClientCredentials credentials;
 
-               public ClientCredentialsSecurityTokenManager (ClientCredentials credentials)
+               public ClientCredentialsSecurityTokenManager (ClientCredentials clientCredentials)
                {
-                       if (credentials == null)
-                               throw new ArgumentNullException ("credentials");
-                       this.credentials = credentials;
+                       if (clientCredentials == null)
+                               throw new ArgumentNullException ("clientCredentials");
+                       this.credentials = clientCredentials;
                }
 
                public ClientCredentials ClientCredentials {
@@ -58,25 +58,25 @@ namespace System.ServiceModel
 
                [MonoTODO]
                public override SecurityTokenAuthenticator CreateSecurityTokenAuthenticator (
-                       SecurityTokenRequirement requirement,
+                       SecurityTokenRequirement tokenRequirement,
                        out SecurityTokenResolver outOfBandTokenResolver)
                {
                        outOfBandTokenResolver = null;
-                       if (requirement == null)
-                               throw new ArgumentNullException ("requirement");
-                       if (requirement.TokenType == SecurityTokenTypes.UserName) {
+                       if (tokenRequirement == null)
+                               throw new ArgumentNullException ("tokenRequirement");
+                       if (tokenRequirement.TokenType == SecurityTokenTypes.UserName) {
                                // unsupported
                        }
-                       else if (requirement.TokenType == SecurityTokenTypes.Rsa)
+                       else if (tokenRequirement.TokenType == SecurityTokenTypes.Rsa)
                                return new RsaSecurityTokenAuthenticator ();
-                       else if (requirement.TokenType == SecurityTokenTypes.X509Certificate)
-                               return CreateX509Authenticator (requirement);
-                       else if (requirement.TokenType == ServiceModelSecurityTokenTypes.Spnego)
-                               return new SspiClientSecurityTokenAuthenticator (this, requirement);
+                       else if (tokenRequirement.TokenType == SecurityTokenTypes.X509Certificate)
+                               return CreateX509Authenticator (tokenRequirement);
+                       else if (tokenRequirement.TokenType == ServiceModelSecurityTokenTypes.Spnego)
+                               return new SspiClientSecurityTokenAuthenticator (this, tokenRequirement);
                        else
-                               throw new NotImplementedException ("Security token type " + requirement.TokenType);
+                               throw new NotImplementedException ("Security token type " + tokenRequirement.TokenType);
 
-                       throw new NotSupportedException (String.Format ("Security token requirement '{0}' is not supported to create SecurityTokenAuthenticator.", requirement));
+                       throw new NotSupportedException (String.Format ("Security token requirement '{0}' is not supported to create SecurityTokenAuthenticator.", tokenRequirement));
                }
 
 
@@ -102,40 +102,40 @@ namespace System.ServiceModel
                #region CreateSecurityTokenProvider()
 
                [MonoTODO]
-               public override SecurityTokenProvider CreateSecurityTokenProvider (SecurityTokenRequirement requirement)
+               public override SecurityTokenProvider CreateSecurityTokenProvider (SecurityTokenRequirement tokenRequirement)
                {
-                       if (IsIssuedSecurityTokenRequirement (requirement))
-                               return CreateIssuedTokenProvider (requirement);
+                       if (IsIssuedSecurityTokenRequirement (tokenRequirement))
+                               return CreateIssuedTokenProvider (tokenRequirement);
 
                        bool isInitiator;
 
                        // huh, they are not constants but properties.
-                       if (requirement.TokenType == SecurityTokenTypes.X509Certificate)
-                               return CreateX509SecurityTokenProvider (requirement);
-                       else if (requirement.TokenType == ServiceModelSecurityTokenTypes.SecureConversation)
-                               return CreateSecureConversationProvider (requirement);
-                       else if (requirement.TokenType == ServiceModelSecurityTokenTypes.AnonymousSslnego) {
-                               if (requirement.TryGetProperty<bool> (ReqType.IsInitiatorProperty, out isInitiator) && isInitiator)
-                                       return CreateSslnegoProvider (requirement);
-                       } else if (requirement.TokenType == ServiceModelSecurityTokenTypes.MutualSslnego) {
-                               if (requirement.TryGetProperty<bool> (ReqType.IsInitiatorProperty, out isInitiator) && isInitiator)
-                                       return CreateSslnegoProvider (requirement);
-                       } else if (requirement.TokenType == ServiceModelSecurityTokenTypes.SecurityContext) {
+                       if (tokenRequirement.TokenType == SecurityTokenTypes.X509Certificate)
+                               return CreateX509SecurityTokenProvider (tokenRequirement);
+                       else if (tokenRequirement.TokenType == ServiceModelSecurityTokenTypes.SecureConversation)
+                               return CreateSecureConversationProvider (tokenRequirement);
+                       else if (tokenRequirement.TokenType == ServiceModelSecurityTokenTypes.AnonymousSslnego) {
+                               if (tokenRequirement.TryGetProperty<bool> (ReqType.IsInitiatorProperty, out isInitiator) && isInitiator)
+                                       return CreateSslnegoProvider (tokenRequirement);
+                       } else if (tokenRequirement.TokenType == ServiceModelSecurityTokenTypes.MutualSslnego) {
+                               if (tokenRequirement.TryGetProperty<bool> (ReqType.IsInitiatorProperty, out isInitiator) && isInitiator)
+                                       return CreateSslnegoProvider (tokenRequirement);
+                       } else if (tokenRequirement.TokenType == ServiceModelSecurityTokenTypes.SecurityContext) {
                                // FIXME: implement
-                       } else if (requirement.TokenType == ServiceModelSecurityTokenTypes.Spnego) {
-                               return CreateSpnegoProvider (requirement);
-                       } else if (requirement.TokenType == ServiceModelSecurityTokenTypes.SspiCredential) {
+                       } else if (tokenRequirement.TokenType == ServiceModelSecurityTokenTypes.Spnego) {
+                               return CreateSpnegoProvider (tokenRequirement);
+                       } else if (tokenRequirement.TokenType == ServiceModelSecurityTokenTypes.SspiCredential) {
                                // FIXME: implement
-                       } else if (requirement.TokenType == SecurityTokenTypes.Rsa) {
+                       } else if (tokenRequirement.TokenType == SecurityTokenTypes.Rsa) {
                                // FIXME: implement
-                       } else if (requirement.TokenType == SecurityTokenTypes.Saml) {
+                       } else if (tokenRequirement.TokenType == SecurityTokenTypes.Saml) {
                                // FIXME: implement
-                       } else if (requirement.TokenType == SecurityTokenTypes.UserName)
-                               return CreateUserNameProvider (requirement);
-                       else if (requirement.TokenType == SecurityTokenTypes.Kerberos) {
-                               return CreateKerberosProvider (requirement);
+                       } else if (tokenRequirement.TokenType == SecurityTokenTypes.UserName)
+                               return CreateUserNameProvider (tokenRequirement);
+                       else if (tokenRequirement.TokenType == SecurityTokenTypes.Kerberos) {
+                               return CreateKerberosProvider (tokenRequirement);
                        }
-                       throw new NotSupportedException (String.Format ("Token type '{0}' is not supported", requirement.TokenType));
+                       throw new NotSupportedException (String.Format ("Token type '{0}' is not supported", tokenRequirement.TokenType));
                }
 
                UserNameSecurityTokenProvider CreateUserNameProvider (
index 01336d803a50be8a40a7d2015c5358837439d86f..51d7685b53b1e653ff26f972834a467506223448 100644 (file)
@@ -93,47 +93,47 @@ namespace System.ServiceModel
                        callback_instance_type = callbackInstanceType;
                }
 
-               public DuplexChannelFactory (object callbackInstance)
-                       : this (new InstanceContext (callbackInstance))
+               public DuplexChannelFactory (object callbackObject)
+                       : this (new InstanceContext (callbackObject))
                {
                }
 
-               public DuplexChannelFactory (object callbackInstance,
+               public DuplexChannelFactory (object callbackObject,
                        string endpointConfigurationName)
-                       : this (new InstanceContext (callbackInstance), endpointConfigurationName)
+                       : this (new InstanceContext (callbackObject), endpointConfigurationName)
                {
                }
 
-               public DuplexChannelFactory (object callbackInstance,
+               public DuplexChannelFactory (object callbackObject,
                        string endpointConfigurationName,
                        EndpointAddress remoteAddress)
-                       : this (new InstanceContext (callbackInstance), endpointConfigurationName, remoteAddress)
+                       : this (new InstanceContext (callbackObject), endpointConfigurationName, remoteAddress)
                {
                }
 
-               public DuplexChannelFactory (object callbackInstance,
+               public DuplexChannelFactory (object callbackObject,
                        ServiceEndpoint endpoint)
-                       : this (new InstanceContext (callbackInstance), endpoint)
+                       : this (new InstanceContext (callbackObject), endpoint)
                {
                }
 
-               public DuplexChannelFactory (object callbackInstance,
+               public DuplexChannelFactory (object callbackObject,
                        Binding binding)
-                       : this (new InstanceContext (callbackInstance), binding)
+                       : this (new InstanceContext (callbackObject), binding)
                {
                }
 
-               public DuplexChannelFactory (object callbackInstance,
+               public DuplexChannelFactory (object callbackObject,
                        Binding binding,
                        string remoteAddress)
-                       : this (callbackInstance, binding, new EndpointAddress (remoteAddress))
+                       : this (callbackObject, binding, new EndpointAddress (remoteAddress))
                {
                }
 
-               public DuplexChannelFactory (object callbackInstance,
+               public DuplexChannelFactory (object callbackObject,
                        Binding binding,
                        EndpointAddress remoteAddress)
-                       : this (new InstanceContext (callbackInstance), binding, remoteAddress)
+                       : this (new InstanceContext (callbackObject), binding, remoteAddress)
                {
                }
 
index 64ce85812b5dabce76d928c81a1a802369c78231..c51ce43a77739320e33d3ba989049d01ae512b86 100644 (file)
@@ -52,8 +52,8 @@ namespace System.ServiceModel
                }
 
                protected DuplexClientBase (object callbackInstance,
-                       string bindingConfigurationName, EndpointAddress remoteAddress)
-                       : this (new InstanceContext (callbackInstance), bindingConfigurationName, remoteAddress)
+                       string endpointConfigurationName, EndpointAddress remoteAddress)
+                       : this (new InstanceContext (callbackInstance), endpointConfigurationName, remoteAddress)
                {
                }
 
@@ -87,8 +87,8 @@ namespace System.ServiceModel
                }
 
                protected DuplexClientBase (InstanceContext callbackInstance,
-                       string endpointConfigurationName, EndpointAddress address)
-                       : base (callbackInstance, endpointConfigurationName, address)
+                       string endpointConfigurationName, EndpointAddress remoteAddress)
+                       : base (callbackInstance, endpointConfigurationName, remoteAddress)
                {
                }
 
index 1740e4d99066ab81ce59ebfa32cce5e3c797bcfa..19e8a56ae742eac7cea8c55ff3dc6c70b1d992b3 100644 (file)
@@ -406,19 +406,19 @@ namespace System.ServiceModel
                public void WriteTo (
                        AddressingVersion addressingVersion,
                        XmlDictionaryWriter writer,
-                       XmlDictionaryString localname,
+                       XmlDictionaryString localName,
                        XmlDictionaryString ns)
                {
-                       writer.WriteStartElement (localname, ns);
+                       writer.WriteStartElement (localName, ns);
                        WriteContentsTo (addressingVersion, writer);
                        writer.WriteEndElement ();
                }
 
                public void WriteTo (
                        AddressingVersion addressingVersion,
-                       XmlWriter writer, string localname, string ns)
+                       XmlWriter writer, string localName, string ns)
                {
-                       writer.WriteStartElement (localname, ns);
+                       writer.WriteStartElement (localName, ns);
                        WriteContentsTo (addressingVersion, writer);
                        writer.WriteEndElement ();
                }
index 71ff2f0f13436e54537452d8db30e66aefc26115..9963d396158679271f74641dc480a8b0c9d86024 100644 (file)
@@ -110,9 +110,9 @@ namespace System.ServiceModel
                        return new X509CertificateEndpointIdentity (primaryCertificate, supportingCertificates);
                }
 
-               public override bool Equals (object other)
+               public override bool Equals (object obj)
                {
-                       EndpointIdentity e = other as EndpointIdentity;
+                       EndpointIdentity e = obj as EndpointIdentity;
                        return e != null && comparer.Equals (claim, e.claim);
                }
 
@@ -126,19 +126,19 @@ namespace System.ServiceModel
                        return String.Concat ("identity(", claim, ")");
                }
 
-               protected void Initialize (Claim claim)
+               protected void Initialize (Claim identityClaim)
                {
-                       Initialize (claim, Claim.DefaultComparer);
+                       Initialize (identityClaim, Claim.DefaultComparer);
                }
 
-               protected void Initialize (Claim claim, IEqualityComparer<Claim> comparer)
+               protected void Initialize (Claim identityClaim, IEqualityComparer<Claim> claimComparer)
                {
-                       if (claim == null)
-                               throw new ArgumentNullException ("claim");
-                       if (comparer == null)
-                               throw new ArgumentNullException ("comparer");
-                       this.claim = claim;
-                       this.comparer = comparer;
+                       if (identityClaim == null)
+                               throw new ArgumentNullException ("identityClaim");
+                       if (claimComparer == null)
+                               throw new ArgumentNullException ("claimComparer");
+                       this.claim = identityClaim;
+                       this.comparer = claimComparer;
                }
        }
 }
index 05b3af01caf8117bb1e39b4eae01a04e70323469..1fdfa99acfb18153d9325239245f7844599af9cb 100644 (file)
@@ -44,13 +44,13 @@ namespace System.ServiceModel
                {
                }
 
-               public FaultException (string msg)
-                       : this (new FaultReason (msg))
+               public FaultException (string reason)
+                       : this (new FaultReason (reason))
                {
                }
 
-               public FaultException (string msg, FaultCode code)
-                       : this (new FaultReason (msg), code)
+               public FaultException (string reason, FaultCode code)
+                       : this (new FaultReason (reason), code)
                {
                }
 
index 223cd81753ed77683a4278d79775b35fc3491f35..f9970c33e4a55bb54c42d9f43f2b366f23f525ac 100644 (file)
@@ -36,9 +36,9 @@ namespace System.ServiceModel
        public class MsmqException : ExternalException
        {
                public MsmqException () : base () {}
-               public MsmqException (string msg) : base (msg) {}
-               public MsmqException (string msg, int win32ErrorCode) : base (msg, win32ErrorCode) {}
-               public MsmqException (string msg, Exception inner) : base (msg, inner) {}
+               public MsmqException (string message) : base (message) {}
+               public MsmqException (string message, int error) : base (message, error) {}
+               public MsmqException (string message, Exception inner) : base (message, inner) {}
                protected MsmqException (SerializationInfo info, StreamingContext context) :
                        base (info, context) {}
        }
index 57fc6fe2872bb5070ad8ee9f0e953eec2a23f4ec..120a5ad8a2efd2b6f8995f944accab06a977fdd6 100644 (file)
@@ -35,8 +35,8 @@ namespace System.ServiceModel
        public class MsmqPoisonMessageException : PoisonMessageException
        {
                public MsmqPoisonMessageException () : base () {}
-               public MsmqPoisonMessageException (string msg) : base (msg) {}
-               public MsmqPoisonMessageException (string msg, Exception inner) : base (msg, inner) {}
+               public MsmqPoisonMessageException (string message) : base (message) {}
+               public MsmqPoisonMessageException (string message, Exception innerException) : base (message, innerException) {}
                protected MsmqPoisonMessageException (SerializationInfo info, StreamingContext context) :
                        base (info, context) {}
        }
index 3d8ebe30b81b0f66ef5deaeea4a7bf83bd95ea8d..9dd6a59691730be8948177a4af8b225664d7c102 100644 (file)
@@ -1,4 +1,4 @@
-//
+//
 // OptionalReliableSession.cs
 //
 // Author:
@@ -42,11 +42,11 @@ namespace System.ServiceModel
                {
                }
 
-               public OptionalReliableSession (ReliableSessionBindingElement binding)
-                       : base (binding)
+               public OptionalReliableSession (ReliableSessionBindingElement reliableSessionBindingElement)
+                       : base (reliableSessionBindingElement)
                {
-                       if (binding == null)
-                               throw new ArgumentNullException ("binding");
+                       if (reliableSessionBindingElement == null)
+                               throw new ArgumentNullException ("reliableSessionBindingElement");
                }
 
                public bool Enabled {
index 9d0fc743e67f9b5b1c67a3338bf21f4f06581c17..99751678f4770417a05e69d2230273d83ea1788a 100644 (file)
@@ -35,8 +35,8 @@ namespace System.ServiceModel
        public class PoisonMessageException : SystemException
        {
                public PoisonMessageException () : base () {}
-               public PoisonMessageException (string msg) : base (msg) {}
-               public PoisonMessageException (string msg, Exception inner) : base (msg, inner) {}
+               public PoisonMessageException (string message) : base (message) {}
+               public PoisonMessageException (string message, Exception innerException) : base (message, innerException) {}
                protected PoisonMessageException (SerializationInfo info, StreamingContext context) :
                        base (info, context) {}
        }
index 5a5a3509e68fc8da5d2ba671c858658bfa4a41a8..243ae798b2af1114b52cdb1a850623119378097e 100644 (file)
@@ -1,4 +1,4 @@
-//
+//
 // ReliableSession.cs
 //
 // Author:
@@ -39,12 +39,12 @@ namespace System.ServiceModel
                {
                }
 
-               public ReliableSession (ReliableSessionBindingElement binding)
+               public ReliableSession (ReliableSessionBindingElement reliableSessionBindingElement)
                {
-                       if (binding == null)
-                               throw new ArgumentNullException ("binding");
-                       InactivityTimeout = binding.InactivityTimeout;
-                       Ordered = binding.Ordered;
+                       if (reliableSessionBindingElement == null)
+                               throw new ArgumentNullException ("reliableSessionBindingElement");
+                       InactivityTimeout = reliableSessionBindingElement.InactivityTimeout;
+                       Ordered = reliableSessionBindingElement.Ordered;
                }
 
                public TimeSpan InactivityTimeout { get; set; }
index 1d0bf8fefc0c705e6eb21b716cd7323b5a62f902..caca3f0b8433819c34a36b39cae4eba97e35e1da 100644 (file)
@@ -49,11 +49,11 @@ namespace System.ServiceModel
                        throw new NotImplementedException ();
                }
 
-               public RsaEndpointIdentity (X509Certificate2 cert)
+               public RsaEndpointIdentity (X509Certificate2 certificate)
                {
-                       if (cert == null)
-                               throw new ArgumentNullException ("cert");
-                       rsa = (RSA) cert.PublicKey.Key;
+                       if (certificate == null)
+                               throw new ArgumentNullException ("certificate");
+                       rsa = (RSA) certificate.PublicKey.Key;
                }
        }
 }
index 4a547c3ab8b86d5a34985b0d9b5ce2b4fa145fe1..14b5cec4aa8b35618648fd4f2a9f195c08822a2d 100644 (file)
@@ -33,24 +33,24 @@ namespace System.ServiceModel
 {
        public class ServiceAuthorizationManager
        {
-               public virtual bool CheckAccess (OperationContext context)
+               public virtual bool CheckAccess (OperationContext operationContext)
                {
-                       return CheckAccessCore (context);
+                       return CheckAccessCore (operationContext);
                }
 
-               public virtual bool CheckAccess (OperationContext context, ref Message message)
+               public virtual bool CheckAccess (OperationContext operationContext, ref Message message)
                {
-                       return CheckAccessCore (context);
+                       return CheckAccessCore (operationContext);
                }
 
                [MonoTODO]
-               protected virtual bool CheckAccessCore (OperationContext context)
+               protected virtual bool CheckAccessCore (OperationContext operationContext)
                {
                        return false;
                }
 
                [MonoTODO]
-               protected virtual ReadOnlyCollection<IAuthorizationPolicy> GetAuthorizationPolicies (OperationContext context)
+               protected virtual ReadOnlyCollection<IAuthorizationPolicy> GetAuthorizationPolicies (OperationContext operationContext)
                {
                        throw new NotImplementedException ();
                }
index e438c8f5b71f59e09ced2747c4c82441254084b4..47c3bc2993c55bb7c71dfd27cf8789ced5ac5a1e 100644 (file)
@@ -45,12 +45,12 @@ namespace System.ServiceModel
                {
                }
 
-               public ServiceHost (object serviceInstance,
+               public ServiceHost (object singletonInstance,
                        params Uri [] baseAddresses)
                {
-                       if (serviceInstance == null)
-                               throw new ArgumentNullException ("serviceInstance");
-                       InitializeDescription (serviceInstance,
+                       if (singletonInstance == null)
+                               throw new ArgumentNullException ("singletonInstance");
+                       InitializeDescription (singletonInstance,
                                new UriSchemeKeyedCollection (baseAddresses));
                }
 
@@ -165,10 +165,10 @@ namespace System.ServiceModel
                        InitializeDescription (baseAddresses);
                }
 
-               protected void InitializeDescription (object serviceInstance, UriSchemeKeyedCollection baseAddresses)
+               protected void InitializeDescription (object singletonInstance, UriSchemeKeyedCollection baseAddresses)
                {
-                       instance = serviceInstance;
-                       InitializeDescription (serviceInstance.GetType (), baseAddresses);
+                       instance = singletonInstance;
+                       InitializeDescription (singletonInstance.GetType (), baseAddresses);
                }
        }
 }
index 29a3d4aba6d72c5328cb908ee67a835a54b8f677..1a84cecc5842e18f6e3e6df25253cbea370641fd 100644 (file)
@@ -492,9 +492,9 @@ namespace System.ServiceModel
                                throw new InvalidOperationException ("The ServiceHost must have at least one application endpoint (that does not include metadata exchange endpoint) defined by either configuration, behaviors or call to AddServiceEndpoint methods.");
                }
 
-               protected void LoadConfigurationSection (ServiceElement element)
+               protected void LoadConfigurationSection (ServiceElement serviceSection)
                {
-                       ApplyServiceElement (element);
+                       ApplyServiceElement (serviceSection);
                }
 
                protected override sealed void OnAbort ()
index c2ea59f9a8a0815d7e4abfbd7978e9a52394085d..8430860cb7918b54981aba50d27152d168dd9fdb 100644 (file)
@@ -35,24 +35,24 @@ namespace System.ServiceModel
        public class UriSchemeKeyedCollection
                : SynchronizedKeyedCollection<string, Uri>
        {
-               public UriSchemeKeyedCollection (params Uri [] uris)
+               public UriSchemeKeyedCollection (params Uri [] addresses)
                        : base (new object ())
                {
-                       if (uris == null)
+                       if (addresses == null)
                                /* FIXME: masterinfo says, param name should be
                                   baseAddresses */
-                               throw new ArgumentNullException ("uris");
+                               throw new ArgumentNullException ("addresses");
 
-                       for (int i = 0; i < uris.Length; i ++) {
-                               if (!uris [i].IsAbsoluteUri)
+                       for (int i = 0; i < addresses.Length; i ++) {
+                               if (!addresses [i].IsAbsoluteUri)
                                        throw new ArgumentException ("Only an absolute URI can be used as a base address");
 
-                               if (Contains (uris [i].Scheme))
-                                       throw new ArgumentException ("Collection already contains an address with scheme "+ uris [i].Scheme);
-                               if (uris [i].Query != String.Empty)
+                               if (Contains (addresses [i].Scheme))
+                                       throw new ArgumentException ("Collection already contains an address with scheme "+ addresses [i].Scheme);
+                               if (addresses [i].Query != String.Empty)
                                        throw new ArgumentException ("A base address cannot contain a query string.");
 
-                               InsertItem (i, uris [i]);
+                               InsertItem (i, addresses [i]);
                        }
                }
 
index c0b1564ff2413e2d3442713bf2efb75c9a4b25c4..b0af17b06e852d063c78b885f15e0d65635b14d7 100644 (file)
@@ -1,4 +1,4 @@
-//
+//
 // WS2007FederationHttpBinding.cs
 //
 // Author:
@@ -52,8 +52,8 @@ namespace System.ServiceModel
                }
 
                [MonoTODO]
-               public WS2007FederationHttpBinding (string configurationName)
-                       : base (configurationName)
+               public WS2007FederationHttpBinding (string configName)
+                       : base (configName)
                {
                        throw new NotImplementedException ();
                }
index 4ac7a2ea4813a5cb02cee96e83fa7280a1bbb37a..0a5cfbc3394c4290da6e0b7d6b83da5fe4a3e2b2 100644 (file)
@@ -1,4 +1,4 @@
-//
+//
 // WS2007HttpBinding.cs
 //
 // Author:
@@ -40,19 +40,19 @@ namespace System.ServiceModel
                {
                }
 
-               public WS2007HttpBinding (SecurityMode mode)
-                       : base (mode)
+               public WS2007HttpBinding (SecurityMode securityMode)
+                       : base (securityMode)
                {
                }
 
-               public WS2007HttpBinding (SecurityMode mode, bool reliableSessionEnabled)
-                       : base (mode, reliableSessionEnabled)
+               public WS2007HttpBinding (SecurityMode securityMode, bool reliableSessionEnabled)
+                       : base (securityMode, reliableSessionEnabled)
                {
                }
 
                [MonoTODO]
-               public WS2007HttpBinding (string configurationName)
-                       : base (configurationName)
+               public WS2007HttpBinding (string configName)
+                       : base (configName)
                {
                }
        }
index cfc054ea7ae3289d10cfbf89e0c66c78760389e4..7fc121e8ad518abbbb1aa03f66514afde01e4791 100644 (file)
@@ -61,7 +61,7 @@ namespace System.ServiceModel
                }
 
                [MonoTODO]
-               public WSFederationHttpBinding (string configurationName)
+               public WSFederationHttpBinding (string configName)
                {
                        throw new NotImplementedException ();
                }
index 0a56a6df1fb2fcc834d673df313ee9314b728718..90a4849a6e3d18443b8587a7cbb3279272ccab8b 100644 (file)
@@ -1,4 +1,4 @@
-//
+//
 // WSHttpBinding.cs
 //
 // Author:
@@ -45,20 +45,20 @@ namespace System.ServiceModel
                {
                }
 
-               public WSHttpBinding (SecurityMode mode)
-                       : this (mode, false)
+               public WSHttpBinding (SecurityMode securityMode)
+                       : this (securityMode, false)
                {
                }
 
-               public WSHttpBinding (SecurityMode mode,
+               public WSHttpBinding (SecurityMode securityMode,
                        bool reliableSessionEnabled)
                        : base (reliableSessionEnabled)
                {
-                       security = new WSHttpSecurity (mode);
+                       security = new WSHttpSecurity (securityMode);
                }
 
                [MonoTODO]
-               public WSHttpBinding (string configurationName)
+               public WSHttpBinding (string configName)
                {
                        throw new NotImplementedException ();
                }
index 88845ed8a60ffb6bd9ab525b457152f4a95a6252..3b71fc19e740737b9118dd46dce72f2adb87ea1c 100644 (file)
@@ -40,12 +40,12 @@ namespace System.ServiceModel
                X509Certificate2 primary;
                X509Certificate2Collection supporting, all;
 
-               public X509CertificateEndpointIdentity (X509Certificate2 cert)
+               public X509CertificateEndpointIdentity (X509Certificate2 certificate)
                {
-                       if (cert == null)
-                               throw new ArgumentNullException ("cert");
-                       primary = cert;
-                       Initialize (Claim.CreateThumbprintClaim (cert.GetCertHash ()));
+                       if (certificate == null)
+                               throw new ArgumentNullException ("certificate");
+                       primary = certificate;
+                       Initialize (Claim.CreateThumbprintClaim (certificate.GetCertHash ()));
                }
 
                public X509CertificateEndpointIdentity (
index f6781dc923fc6d5a14cc56e59f35a860f533a03e..f98f6fa6e129338cf2482e497d981ef24cc0b0db 100644 (file)
@@ -41,26 +41,26 @@ namespace System.Transactions
                        this.options = options;
                }
 
-               public IAsyncResult BeginCommit (AsyncCallback callback,
-                       object user_defined_state)
+               public IAsyncResult BeginCommit (AsyncCallback asyncCallback,
+                       object asyncState)
                {
-                       this.callback = callback;
-                       this.user_defined_state = user_defined_state;
+                       this.callback = asyncCallback;
+                       this.user_defined_state = asyncState;
 
                        AsyncCallback cb = null;
-                       if (callback != null)
+                       if (asyncCallback != null)
                                cb = new AsyncCallback (CommitCallback);
 
                        asyncResult = BeginCommitInternal (cb);
                        return this;
                }
                
-               public void EndCommit (IAsyncResult ar)
+               public void EndCommit (IAsyncResult asyncResult)
                {
-                       if (ar != this)
+                       if (asyncResult != this)
                                throw new ArgumentException ("The IAsyncResult parameter must be the same parameter as returned by BeginCommit.", "asyncResult");
 
-                       EndCommitInternal (asyncResult);
+                       EndCommitInternal (this.asyncResult);
                }
 
                private void CommitCallback (IAsyncResult ar)
index 65d012779cfb9f634f7d3d7d396a23ef192f72c1..29a2ee72120293faa3c356edd53bc0bdfd98e66e 100644 (file)
@@ -19,11 +19,11 @@ namespace System.Transactions
        [InterfaceType (ComInterfaceType.InterfaceIsIUnknown)]
        public interface IDtcTransaction
        {
-               void Abort (IntPtr manager, int whatever, int whatever2);
+               void Abort (IntPtr reason, int retaining, int async);
 
-               void Commit (int whatever, int whatever2, int whatever3);
+               void Commit (int retaining, int commitType, int reserved);
 
-               void GetTransactionInfo (IntPtr whatever);
+               void GetTransactionInfo (IntPtr transactionInformation);
        }
 }
 
index 4e01d02de6150218a6e1c31f49f35c34c1de5f75..9684e74298c8d72a6de6563730be2ea8c2ea2614 100644 (file)
@@ -14,9 +14,9 @@ namespace System.Transactions
        {
                void Initialize ();
 
-               void Rollback (SinglePhaseEnlistment enlistment);
+               void Rollback (SinglePhaseEnlistment singlePhaseEnlistment);
 
-               void SinglePhaseCommit (SinglePhaseEnlistment enlistment);
+               void SinglePhaseCommit (SinglePhaseEnlistment singlePhaseEnlistment);
        }
 }
 
index e206193a4c346e0efcaed492632ca50a88173c38..7d029fa0c7958216caf93cf371ba158639916611 100644 (file)
@@ -13,7 +13,7 @@ namespace System.Transactions
        public interface ISinglePhaseNotification
                : IEnlistmentNotification
        {
-               void SinglePhaseCommit (SinglePhaseEnlistment enlistment);
+               void SinglePhaseCommit (SinglePhaseEnlistment singlePhaseEnlistment);
        }
 }
 
index 766d637bbed5f5571a79406d232b5297c5fac567..e662279f85b5c65a21e2728dd10d3b66e6855990 100644 (file)
@@ -40,9 +40,9 @@ namespace System.Transactions
                }
 
                [MonoTODO]
-               public void ForceRollback (Exception ex)
+               public void ForceRollback (Exception e)
                {
-                       tx.Rollback (ex, enlisted);
+                       tx.Rollback (e, enlisted);
                        /* See test RMFail2 */
                        ((ManualResetEvent) waitHandle).Set ();
                }
index 198ab796d55a9a68ecadd30e1b10a558b7b69048..efb1c4007a3a82c2555bad1c7499833dd571e902 100644 (file)
@@ -14,7 +14,7 @@ namespace System.Transactions
        [Serializable]
        public sealed class SubordinateTransaction : Transaction
        {
-               public SubordinateTransaction (IsolationLevel level,
+               public SubordinateTransaction (IsolationLevel isoLevel,
                        ISimpleTransactionSuperior superior)
                {
                        throw new NotImplementedException ();
index 20c31072d9b00d20b51759ca1180610e3d0124d8..33422d15f1ea5b75a5fbd996e8b7a46ba9c82222 100644 (file)
@@ -137,44 +137,44 @@ namespace System.Transactions
 
                [MonoTODO]
                public DependentTransaction DependentClone (
-                       DependentCloneOption option)
+                       DependentCloneOption cloneOption)
                {
                        DependentTransaction d = 
-                               new DependentTransaction (this, option);
+                               new DependentTransaction (this, cloneOption);
                        dependents.Add (d);
                        return d;
                }
 
                [MonoTODO ("Only SinglePhase commit supported for durable resource managers.")]
                [PermissionSetAttribute (SecurityAction.LinkDemand)]
-               public Enlistment EnlistDurable (Guid manager,
-                       IEnlistmentNotification notification,
-                       EnlistmentOptions options)
+               public Enlistment EnlistDurable (Guid resourceManagerIdentifier,
+                       IEnlistmentNotification enlistmentNotification,
+                       EnlistmentOptions enlistmentOptions)
                {
                        throw new NotImplementedException ("DTC unsupported, only SinglePhase commit supported for durable resource managers.");
                }
 
                [MonoTODO ("Only Local Transaction Manager supported. Cannot have more than 1 durable resource per transaction. Only EnlistmentOptions.None supported yet.")]
                [PermissionSetAttribute (SecurityAction.LinkDemand)]
-               public Enlistment EnlistDurable (Guid manager,
-                       ISinglePhaseNotification notification,
-                       EnlistmentOptions options)
+               public Enlistment EnlistDurable (Guid resourceManagerIdentifier,
+                       ISinglePhaseNotification singlePhaseNotification,
+                       EnlistmentOptions enlistmentOptions)
                {
                        EnsureIncompleteCurrentScope ();
                        if (pspe != null || Durables.Count > 0)
                                throw new NotImplementedException ("DTC unsupported, multiple durable resource managers aren't supported.");
 
-                       if (options != EnlistmentOptions.None)
+                       if (enlistmentOptions != EnlistmentOptions.None)
                                throw new NotImplementedException ("EnlistmentOptions other than None aren't supported");
 
-                       Durables.Add (notification);
+                       Durables.Add (singlePhaseNotification);
 
                        /* FIXME: Enlistment ?? */
                        return new Enlistment ();
                }
 
                public bool EnlistPromotableSinglePhase (
-                       IPromotableSinglePhaseNotification notification)
+                       IPromotableSinglePhaseNotification promotableSinglePhaseNotification)
                {
                        EnsureIncompleteCurrentScope ();
 
@@ -183,7 +183,7 @@ namespace System.Transactions
                        if (pspe != null || Durables.Count > 0)
                                return false;
 
-                       pspe = notification;
+                       pspe = promotableSinglePhaseNotification;
                        pspe.Initialize();
 
                        return true;
@@ -211,19 +211,19 @@ namespace System.Transactions
 
                [MonoTODO ("EnlistmentOptions being ignored")]
                public Enlistment EnlistVolatile (
-                       IEnlistmentNotification notification,
-                       EnlistmentOptions options)
+                       IEnlistmentNotification enlistmentNotification,
+                       EnlistmentOptions enlistmentOptions)
                {
-                       return EnlistVolatileInternal (notification, options);
+                       return EnlistVolatileInternal (enlistmentNotification, enlistmentOptions);
                }
 
                [MonoTODO ("EnlistmentOptions being ignored")]
                public Enlistment EnlistVolatile (
-                       ISinglePhaseNotification notification,
-                       EnlistmentOptions options)
+                       ISinglePhaseNotification singlePhaseNotification,
+                       EnlistmentOptions enlistmentOptions)
                {
                        /* FIXME: Anything extra reqd for this? */
-                       return EnlistVolatileInternal (notification, options);
+                       return EnlistVolatileInternal (singlePhaseNotification, enlistmentOptions);
                }
 
                private Enlistment EnlistVolatileInternal (
@@ -287,10 +287,10 @@ namespace System.Transactions
                        Rollback (null);
                }
 
-               public void Rollback (Exception ex)
+               public void Rollback (Exception e)
                {
                        EnsureIncompleteCurrentScope ();
-                       Rollback (ex, null);
+                       Rollback (e, null);
                }
 
                internal void Rollback (Exception ex, object abortingEnlisted)
index a764cf6e096157e1d29f4bca3dae7bbc469d5b50..2d0cf35bed6a0fe696e0f23c246de7552d87d18f 100644 (file)
@@ -25,27 +25,27 @@ namespace System.Transactions
 
                [MonoTODO]
                public static byte [] GetExportCookie (Transaction transaction,
-                       byte [] exportCookie)
+                       byte [] whereabouts)
                {
                        throw new NotImplementedException ();
                }
 
                [MonoTODO]
                public static Transaction GetTransactionFromDtcTransaction (
-                       IDtcTransaction dtc)
+                       IDtcTransaction transactionNative)
                {
                        throw new NotImplementedException ();
                }
 
                [MonoTODO]
                public static Transaction GetTransactionFromExportCookie (
-                       byte [] exportCookie)
+                       byte [] cookie)
                {
                        throw new NotImplementedException ();
                }
 
                [MonoTODO]
-               public static Transaction GetTransactionFromTransmitterPropagationToken (byte [] token)
+               public static Transaction GetTransactionFromTransmitterPropagationToken (byte [] propagationToken)
                {
                        throw new NotImplementedException ();
                }
index b0d90bc2eaae9dea0ce61b20157263519752e1af..491f46f765ab20a103dbe26913846cac6c6a1bad 100644 (file)
@@ -67,15 +67,15 @@ namespace System.Transactions
                }
 
                [MonoTODO ("Not implemented")]
-               public static void RecoveryComplete (Guid manager)
+               public static void RecoveryComplete (Guid resourceManagerIdentifier)
                {
                        throw new NotImplementedException ();
                }
 
                [MonoTODO ("Not implemented")]
-               public static Enlistment Reenlist (Guid manager,
-                       byte[] recoveryInfo,
-                       IEnlistmentNotification notification)
+               public static Enlistment Reenlist (Guid resourceManagerIdentifier,
+                       byte[] recoveryInformation,
+                       IEnlistmentNotification enlistmentNotification)
                {
                        throw new NotImplementedException ();
                }
index a466cfb74ca0627700543d1e41c78101dbe9bc9e..03fbab0966a6df749f73f95c626963681512dca8 100644 (file)
@@ -32,18 +32,18 @@ namespace System.Transactions
                        set { timeout = value; }
                }
 
-               public static bool operator == (TransactionOptions  o1,
-                       TransactionOptions o2)
+               public static bool operator == (TransactionOptions  x,
+                       TransactionOptions y)
                {
-                       return o1.level == o2.level &&
-                               o1.timeout == o2.timeout;
+                       return x.level == y.level &&
+                               x.timeout == y.timeout;
                }
 
-               public static bool operator != (TransactionOptions o1,
-                       TransactionOptions o2)
+               public static bool operator != (TransactionOptions x,
+                       TransactionOptions y)
                {
-                       return o1.level != o2.level ||
-                               o1.timeout != o2.timeout;
+                       return x.level != y.level ||
+                               x.timeout != y.timeout;
                }
 
                public override bool Equals (object obj)
index ac57713b59d85e08fcb5bf0ca159c08529a8bf3d..874ddde0d88af472e69ab26b4cde13798ecd6a0b 100644 (file)
@@ -39,39 +39,39 @@ namespace System.Transactions
                {
                }
 
-               public TransactionScope(TransactionScopeAsyncFlowOption asyncFlow)
+               public TransactionScope(TransactionScopeAsyncFlowOption asyncFlowOption)
                        : this(TransactionScopeOption.Required,
-                               TransactionManager.DefaultTimeout, asyncFlow)
+                               TransactionManager.DefaultTimeout, asyncFlowOption)
                {
                }
 
-               public TransactionScope (Transaction transaction)
-                       : this (transaction, TransactionManager.DefaultTimeout)
+               public TransactionScope (Transaction transactionToUse)
+                       : this (transactionToUse, TransactionManager.DefaultTimeout)
                {
                }
 
-               public TransactionScope (Transaction transaction,
-                       TimeSpan timeout)
-                       : this (transaction, timeout, DTCOption.None)
+               public TransactionScope (Transaction transactionToUse,
+                       TimeSpan scopeTimeout)
+                       : this (transactionToUse, scopeTimeout, DTCOption.None)
                {
                }
 
                [MonoTODO ("EnterpriseServicesInteropOption not supported.")]
-               public TransactionScope (Transaction transaction,
-                       TimeSpan timeout, DTCOption opt)
+               public TransactionScope (Transaction transactionToUse,
+                       TimeSpan scopeTimeout, DTCOption interopOption)
                {
                        Initialize (TransactionScopeOption.Required,
-                               transaction, defaultOptions, opt, timeout, TransactionScopeAsyncFlowOption.Suppress);
+                               transactionToUse, defaultOptions, interopOption, scopeTimeout, TransactionScopeAsyncFlowOption.Suppress);
                }
 
-               public TransactionScope (TransactionScopeOption option)
-                       : this (option, TransactionManager.DefaultTimeout)
+               public TransactionScope (TransactionScopeOption scopeOption)
+                       : this (scopeOption, TransactionManager.DefaultTimeout)
                {
                }
 
-               public TransactionScope (TransactionScopeOption option,
-                       TimeSpan timeout)
-                       : this (option, timeout, TransactionScopeAsyncFlowOption.Suppress)
+               public TransactionScope (TransactionScopeOption scopeOption,
+                       TimeSpan scopeTimeout)
+                       : this (scopeOption, scopeTimeout, TransactionScopeAsyncFlowOption.Suppress)
                {
                }
 
@@ -80,25 +80,25 @@ namespace System.Transactions
                {
                }
 
-       public TransactionScope (TransactionScopeOption option,
-                       TimeSpan timeout, TransactionScopeAsyncFlowOption asyncFlow)
+               public TransactionScope (TransactionScopeOption scopeOption,
+                       TimeSpan scopeTimeout, TransactionScopeAsyncFlowOption asyncFlow)
                {
-                       Initialize (option, null, defaultOptions,
-                               DTCOption.None, timeout, asyncFlow);
+                       Initialize (scopeOption, null, defaultOptions,
+                               DTCOption.None, scopeTimeout, asyncFlow);
                }
 
                public TransactionScope (TransactionScopeOption scopeOption,
-                       TransactionOptions options)
-                       : this (scopeOption, options, DTCOption.None)
+                       TransactionOptions transactionOptions)
+                       : this (scopeOption, transactionOptions, DTCOption.None)
                {
                }
 
                [MonoTODO ("EnterpriseServicesInteropOption not supported")]
                public TransactionScope (TransactionScopeOption scopeOption,
-                       TransactionOptions options,
-                       DTCOption opt)
+                       TransactionOptions transactionOptions,
+                       DTCOption interopOption)
                {
-                       Initialize (scopeOption, null, options, opt,
+                       Initialize (scopeOption, null, transactionOptions, interopOption,
                                TransactionManager.DefaultTimeout, TransactionScopeAsyncFlowOption.Suppress);
                }
 
@@ -124,17 +124,17 @@ namespace System.Transactions
 
                void Initialize (TransactionScopeOption scopeOption,
                        Transaction tx, TransactionOptions options,
-                       DTCOption interop, TimeSpan timeout, TransactionScopeAsyncFlowOption asyncFlow)
+                       DTCOption interop, TimeSpan scopeTimeout, TransactionScopeAsyncFlowOption asyncFlow)
                {
                        completed = false;
                        isRoot = false;
                        nested = 0;
                        asyncFlowEnabled = asyncFlow == TransactionScopeAsyncFlowOption.Enabled;
 
-                       if (timeout < TimeSpan.Zero)
-                               throw new ArgumentOutOfRangeException ("timeout");
+                       if (scopeTimeout < TimeSpan.Zero)
+                               throw new ArgumentOutOfRangeException ("scopeTimeout");
 
-                       this.timeout = timeout;
+                       this.timeout = scopeTimeout;
 
                        oldTransaction = Transaction.CurrentInternal;
 
index 1dbda6e1d228fbeb49710a4fc8b4d0309b647715..a474c995e63cfbbfa619608e9719db6857a83f64 100644 (file)
@@ -25,14 +25,14 @@ namespace MonoTests.System.Transactions
                                TransactionScope scope = new TransactionScope (TransactionScopeOption.Required, TimeSpan.FromSeconds (-1));
                                Assert.Fail ("Expected exception when passing TransactionScopeOption and an invalid TimeSpan.");
                        } catch (ArgumentOutOfRangeException ex) {
-                               Assert.AreEqual (ex.ParamName, "timeout");
+                               Assert.AreEqual ("scopeTimeout", ex.ParamName);
                        }
 
                        try {
                                TransactionScope scope = new TransactionScope (null, TimeSpan.FromSeconds (-1));
                                Assert.Fail ("Expected exception when passing TransactionScopeOption and an invalid TimeSpan.");
                        } catch (ArgumentOutOfRangeException ex) {
-                               Assert.AreEqual (ex.ParamName, "timeout");
+                               Assert.AreEqual ("scopeTimeout", ex.ParamName);
                        }
                }
 
index 068e1c45ccff43b779236ceaeeaf4fc2f1d3fee2..77a6fbeca398d7fd43f60f9761f1fe0ff85634ad 100644 (file)
@@ -72,21 +72,21 @@ namespace System.Web.Security
                {
                }
                
-               public abstract bool ChangePassword (string name, string oldPwd, string newPwd);
-               public abstract bool ChangePasswordQuestionAndAnswer (string name, string password, string newPwdQuestion, string newPwdAnswer);
-               public abstract MembershipUser CreateUser (string username, string password, string email, string pwdQuestion, string pwdAnswer, bool isApproved, object providerUserKey, out MembershipCreateStatus status);
-               public abstract bool DeleteUser (string name, bool deleteAllRelatedData);
+               public abstract bool ChangePassword (string username, string oldPassword, string newPassword);
+               public abstract bool ChangePasswordQuestionAndAnswer (string username, string password, string newPasswordQuestion, string newPasswordAnswer);
+               public abstract MembershipUser CreateUser (string username, string password, string email, string passwordQuestion, string passwordAnswer, bool isApproved, object providerUserKey, out MembershipCreateStatus status);
+               public abstract bool DeleteUser (string username, bool deleteAllRelatedData);
                public abstract MembershipUserCollection FindUsersByEmail (string emailToMatch, int pageIndex, int pageSize, out int totalRecords);
-               public abstract MembershipUserCollection FindUsersByName (string nameToMatch, int pageIndex, int pageSize, out int totalRecords);
+               public abstract MembershipUserCollection FindUsersByName (string usernameToMatch, int pageIndex, int pageSize, out int totalRecords);
                public abstract MembershipUserCollection GetAllUsers (int pageIndex, int pageSize, out int totalRecords);
                public abstract int GetNumberOfUsersOnline ();
-               public abstract string GetPassword (string name, string answer);
-               public abstract MembershipUser GetUser (string name, bool userIsOnline);
+               public abstract string GetPassword (string username, string answer);
+               public abstract MembershipUser GetUser (string username, bool userIsOnline);
                public abstract MembershipUser GetUser (object providerUserKey, bool userIsOnline);
                public abstract string GetUserNameByEmail (string email);
-               public abstract string ResetPassword (string name, string answer);
+               public abstract string ResetPassword (string username, string answer);
                public abstract void UpdateUser (MembershipUser user);
-               public abstract bool ValidateUser (string name, string password);
+               public abstract bool ValidateUser (string username, string password);
                public abstract bool UnlockUser (string userName);
                
                public abstract string ApplicationName { get; set; }
@@ -101,11 +101,11 @@ namespace System.Web.Security
                public abstract string PasswordStrengthRegularExpression { get; }
                public abstract bool RequiresUniqueEmail { get; }
                
-               protected virtual void OnValidatingPassword (ValidatePasswordEventArgs args)
+               protected virtual void OnValidatingPassword (ValidatePasswordEventArgs e)
                {
                        MembershipValidatePasswordEventHandler eh = events [validatingPasswordEvent] as MembershipValidatePasswordEventHandler;
                        if (eh != null)
-                               eh (this, args);
+                               eh (this, e);
                }
 
                protected virtual byte [] DecryptPassword (byte [] encodedPassword)
index c370f21661bf432ac7d42bd09251d6a7db82db12..5bb84e31496749f003707fd2bc005b96a327a7eb 100644 (file)
@@ -119,9 +119,9 @@ namespace System.Web.Security
                        return GetPassword (null);
                }
                
-               public virtual string GetPassword (string answer)
+               public virtual string GetPassword (string passwordAnswer)
                {
-                       return Provider.GetPassword (UserName, answer);
+                       return Provider.GetPassword (UserName, passwordAnswer);
                }
                
                public virtual string ResetPassword ()
@@ -129,9 +129,9 @@ namespace System.Web.Security
                        return ResetPassword (null);
                }
                
-               public virtual string ResetPassword (string answer)
+               public virtual string ResetPassword (string passwordAnswer)
                {
-                       string newPass = Provider.ResetPassword (UserName, answer);
+                       string newPass = Provider.ResetPassword (UserName, passwordAnswer);
 
                        UpdateUser ();
                        
index ad9079c09fe9e909cd624643b058c472e66ca36b..6ea65718441454d7c2b20138362c577029db7798 100644 (file)
@@ -39,16 +39,16 @@ namespace System.Web.Security
                {
                }
                
-               public abstract void AddUsersToRoles (string [] usernames, string [] rolenames);
-               public abstract void CreateRole (string rolename);
-               public abstract bool DeleteRole (string rolename, bool throwOnPopulatedRole);
+               public abstract void AddUsersToRoles (string [] usernames, string [] roleNames);
+               public abstract void CreateRole (string roleName);
+               public abstract bool DeleteRole (string roleName, bool throwOnPopulatedRole);
                public abstract string [] FindUsersInRole (string roleName, string usernameToMatch);
                public abstract string [] GetAllRoles ();
                public abstract string [] GetRolesForUser (string username);
-               public abstract string [] GetUsersInRole (string rolename);
-               public abstract bool IsUserInRole (string username, string rolename);
-               public abstract void RemoveUsersFromRoles (string [] usernames, string [] rolenames);
-               public abstract bool RoleExists (string rolename);
+               public abstract string [] GetUsersInRole (string roleName);
+               public abstract bool IsUserInRole (string username, string roleName);
+               public abstract void RemoveUsersFromRoles (string [] usernames, string [] roleNames);
+               public abstract bool RoleExists (string roleName);
                public abstract string ApplicationName { get; set; }
        }
 }
index 9c05b6da132834d499f2ea1e75d2091544b16d35..fc53ba0bb3b833cb9888b1fa022b96c5a5276eff 100644 (file)
@@ -1,4 +1,4 @@
-//\r
+//\r
 // ScriptModule.cs\r
 //\r
 // Author:\r
@@ -37,10 +37,10 @@ namespace System.Web.Handlers
 {\r
        public class ScriptModule : IHttpModule\r
        {\r
-               protected virtual void Init (HttpApplication context) {\r
-                       context.PreSendRequestHeaders += new EventHandler (PreSendRequestHeaders);\r
-                       context.PostAcquireRequestState += new EventHandler (PostAcquireRequestState);\r
-                       context.AuthenticateRequest += new EventHandler (AuthenticateRequest);\r
+               protected virtual void Init (HttpApplication app) {\r
+                       app.PreSendRequestHeaders += new EventHandler (PreSendRequestHeaders);\r
+                       app.PostAcquireRequestState += new EventHandler (PostAcquireRequestState);\r
+                       app.AuthenticateRequest += new EventHandler (AuthenticateRequest);\r
                }\r
 \r
                void AuthenticateRequest (object sender, EventArgs e) {\r
index bb3c401d541af3c7b083bced6d92ba1e8c5b4b13..f09ccc9adc0d2e1bda7b82ef627bb6de989591c8 100644 (file)
@@ -1,4 +1,4 @@
-//
+//
 // ScriptResourceAttribute.cs
 //
 // Author:
@@ -40,10 +40,10 @@ namespace System.Web.UI
                string _scriptResourceName;
                string _typeName;
 
-               public ScriptResourceAttribute (string scriptName, string scriptResourceName, string typeName) {
+               public ScriptResourceAttribute (string scriptName, string stringResourceName, string stringResourceClientTypeName) {
                        _scriptName = scriptName;
-                       _scriptResourceName = scriptResourceName;
-                       _typeName = typeName;
+                       _scriptResourceName = stringResourceName;
+                       _typeName = stringResourceClientTypeName;
                }
 
                public string ScriptName {
index eb12379d18a2c76da2d04ee28e5130f79bd068bf..65c7d538856de0cd7e94bb6a0e5d0ff2affc9a98 100644 (file)
@@ -45,9 +45,9 @@ namespace System.Web.Configuration
                        properties = new ConfigurationPropertyCollection();
                }
 
-               public void Add (AssemblyInfo info)
+               public void Add (AssemblyInfo assemblyInformation)
                {
-                       BaseAdd (info, false);
+                       BaseAdd (assemblyInformation, false);
                }
                
                public void Clear ()
index 9150b7b7724682c4c155578db76b6837d85fe0d5..812b4b5fa4cd85b9ac641ba80652037937d59f6f 100644 (file)
@@ -74,8 +74,8 @@ namespace System.Web.Configuration {
                        set {  if (BaseGet(index) != null)  BaseRemoveAt(index);  BaseAdd(index, value); }
                }
 
-               public new BufferModeSettings this [string name] {
-                       get { return (BufferModeSettings) BaseGet (name); }
+               public new BufferModeSettings this [string key] {
+                       get { return (BufferModeSettings) BaseGet (key); }
                }
 
                protected internal override ConfigurationPropertyCollection Properties {
index 4ef5798fc293c6be8f1fea5057b502b32d15cda6..f35c51aac5dc16be8a132fa9cbe3f25f3bf12a0a 100644 (file)
@@ -99,8 +99,8 @@ namespace System.Web.Configuration {
                        set { if (BaseGet (index) != null) BaseRemoveAt (index); BaseAdd (index, value); }
                }
 
-               public new EventMappingSettings this [string name] {
-                       get { return (EventMappingSettings) BaseGet (name); }
+               public new EventMappingSettings this [string key] {
+                       get { return (EventMappingSettings) BaseGet (key); }
                }
 
                protected internal override ConfigurationPropertyCollection Properties {
index 7d314ac73c35366662f74559230c833e35663256..dd44ba4fa26b8a267ee0a2c163a3dc78f4b116da 100644 (file)
@@ -48,9 +48,9 @@ namespace System.Web.Configuration
                {
                }
                        
-               public void Add (HttpModuleAction httpModuleAction)
+               public void Add (HttpModuleAction httpModule)
                {
-                       BaseAdd (httpModuleAction);
+                       BaseAdd (httpModule);
                }
 
                public void Clear ()
index cb506ccf31ac28b49ec1136a452ad6d793386db9..d3dffccb01d67c086430ddf0cba2b8c561987fb7 100644 (file)
@@ -94,8 +94,8 @@ namespace System.Web.Configuration {
                        BaseRemoveAt (index);
                }
 
-               public new ProfileSettings this [string name] {
-                       get { return (ProfileSettings)BaseGet (name); }
+               public new ProfileSettings this [string key] {
+                       get { return (ProfileSettings)BaseGet (key); }
                }
 
                public ProfileSettings this [int index] {
index 2b66727eb5ba022987ec6c11e2143a69373a6f2e..eff9ad76e3436dfca8b1be68813d766782551a67 100644 (file)
@@ -51,9 +51,9 @@ namespace System.Web.Configuration
                        groupSettings = new ProfileGroupSettingsCollection ();
                }               
                
-               public override bool Equals (object obj)
+               public override bool Equals (object rootProfilePropertySettingsCollection)
                {
-                       RootProfilePropertySettingsCollection col = obj as RootProfilePropertySettingsCollection;
+                       RootProfilePropertySettingsCollection col = rootProfilePropertySettingsCollection as RootProfilePropertySettingsCollection;
                        if (col == null)
                                return false;
 
index 75ccd99b202a3d069879fbc1f340f0a2defb89ea..8598559f4525129e5dbf6a7336275a84f47b3d36 100644 (file)
@@ -94,8 +94,8 @@ namespace System.Web.Configuration {
                        BaseRemoveAt (index);
                }
 
-               public new RuleSettings this [string name] {
-                       get { return (RuleSettings) BaseGet (name); }
+               public new RuleSettings this [string key] {
+                       get { return (RuleSettings) BaseGet (key); }
                }
 
                public RuleSettings this [int index] {
index a8b129a119d967a349f45fa3643bed076bdb42dd..efdc4941021695b6bd92a235f89545c64c305a83 100644 (file)
@@ -69,9 +69,9 @@ namespace System.Web.Configuration
                        this.MappedTagType = mappedTagTypeName;
                }
 
-               public override bool Equals (object map)
+               public override bool Equals (object o)
                {
-                       TagMapInfo info = map as TagMapInfo;
+                       TagMapInfo info = o as TagMapInfo;
                        if (info == null)
                                return false;
 
index 478a207d82d15bf1bcfdb26fbcb7da45953dfb80..04097841934d7771bced7452fe113fcd99adadb5 100644 (file)
@@ -99,8 +99,8 @@ namespace System.Web.Configuration {
                        get { return "trustLevel"; }
                }
 
-               public new TrustLevel this [string name] {
-                       get { return (TrustLevel) BaseGet (name); }
+               public new TrustLevel this [string key] {
+                       get { return (TrustLevel) BaseGet (key); }
                }
 
                public TrustLevel this [int index] {
index 93fcadc9b65dffd7f15e54b0f63d85a52dcb8a21..8f81fd61c484ee52d665f94296a35cbabd46949a 100644 (file)
@@ -37,8 +37,8 @@ namespace System.Web.Hosting
         public interface IAppManagerAppDomainFactory
         {
                [return: MarshalAs (UnmanagedType.Interface)]
-                object Create ([In, MarshalAs(UnmanagedType.BStr)] string s,
-                              [In, MarshalAs(UnmanagedType.BStr)] string app_id);
+                object Create ([In, MarshalAs(UnmanagedType.BStr)] string appId,
+                              [In, MarshalAs(UnmanagedType.BStr)] string appPath);
                 void Stop ();
         }
 }
index 9a8c42dc6f85905f1a511faf40b6a54ab65ac115..d46422584756f3f96ad3063dcc2526ec7b462b54 100644 (file)
@@ -33,6 +33,6 @@ namespace System.Web.Management
 {
         public interface IWebEventCustomEvaluator
         {
-                bool CanFire (WebBaseEvent raised_event, RuleFiringRecord record);
+                bool CanFire (WebBaseEvent raisedEvent, RuleFiringRecord record);
         }
 }
index a7cd1a8e04289343c138177e05445f14459fe8b8..ef2adb8bda950d4cc5cf54949b74c0d593aeb81a 100644 (file)
@@ -36,19 +36,19 @@ namespace System.Web.Management
                 object event_source;
                 int event_code, event_detail_code;
 
-                protected WebBaseEvent (string message, object event_source, int event_code)
+                protected WebBaseEvent (string message, object eventSource, int eventCode)
                 {
                         this.message = message;
-                        this.event_source = event_source;
-                        this.event_code = event_code;
+                        this.event_source = eventSource;
+                        this.event_code = eventCode;
                 }
 
-                protected WebBaseEvent (string message, object event_source, int event_code, int event_detail_code)
+                protected WebBaseEvent (string message, object eventSource, int eventCode, int eventDetailCode)
                 {
                         this.message = message;
-                        this.event_source = event_source;
-                        this.event_code = event_code;
-                        this.event_detail_code = event_detail_code;
+                        this.event_source = eventSource;
+                        this.event_code = eventCode;
+                        this.event_detail_code = eventDetailCode;
                 }
                 
                 public static WebApplicationInformation ApplicationInformation {
@@ -116,7 +116,7 @@ namespace System.Web.Management
                         throw new NotImplementedException ();
                 }
 
-                public static void Raise (WebBaseEvent event_raised)
+                public static void Raise (WebBaseEvent eventRaised)
                 {
                         throw new NotImplementedException ();
                 }
@@ -126,7 +126,7 @@ namespace System.Web.Management
                         throw new NotImplementedException ();
                 }
 
-                public virtual string ToString (bool include_app_info, bool include_custom_event_details)
+                public virtual string ToString (bool includeAppInfo, bool includeCustomEventDetails)
                 {
                         throw new NotImplementedException ();
                 }
index 79b503fc6775c8f27f2f56374a6fc18d4294a88d..4d40d02016ee4f6068ac47c9f19b36ade159fa9b 100644 (file)
@@ -37,19 +37,19 @@ namespace System.Web.Security {
        public class ActiveDirectoryMembershipProvider : MembershipProvider {
                
                [MonoTODO ("Not implemented")]
-               public override bool ChangePassword (string username, string oldPwd, string newPwd)
+               public override bool ChangePassword (string username, string oldPassword, string newPassword)
                {
                        throw new NotImplementedException ();
                }
                
                [MonoTODO ("Not implemented")]
-               public override bool ChangePasswordQuestionAndAnswer (string username, string password, string newPwdQuestion, string newPwdAnswer)
+               public override bool ChangePasswordQuestionAndAnswer (string username, string password, string newPasswordQuestion, string newPasswordAnswer)
                {
                        throw new NotImplementedException ();
                }
                
                [MonoTODO ("Not implemented")]
-               public override MembershipUser CreateUser (string username, string password, string email, string pwdQuestion, string pwdAnswer, bool isApproved, object providerUserKey, out MembershipCreateStatus status)
+               public override MembershipUser CreateUser (string username, string password, string email, string passwordQuestion, string passwordAnswer, bool isApproved, object providerUserKey, out MembershipCreateStatus status)
                {
                        throw new NotImplementedException ();
                }
@@ -73,7 +73,7 @@ namespace System.Web.Security {
                }
                
                [MonoTODO ("Not implemented")]
-               public override MembershipUserCollection FindUsersByName (string nameToMatch, int pageIndex, int pageSize, out int totalRecords)
+               public override MembershipUserCollection FindUsersByName (string usernameToMatch, int pageIndex, int pageSize, out int totalRecords)
                {
                        throw new NotImplementedException ();
                }
@@ -91,7 +91,7 @@ namespace System.Web.Security {
                }
                
                [MonoTODO("Not implemented")]
-               public override string GetPassword (string username, string answer)
+               public override string GetPassword (string username, string passwordAnswer)
                {
                        throw new NotImplementedException ();
                }
@@ -121,7 +121,7 @@ namespace System.Web.Security {
                }
                
                [MonoTODO("Not implemented")]
-               public override string ResetPassword (string username, string answer)
+               public override string ResetPassword (string username, string passwordAnswer)
                {
                        throw new NotImplementedException ();
                }
@@ -139,7 +139,7 @@ namespace System.Web.Security {
                }
                
                [MonoTODO("Not implemented")]
-               public override bool UnlockUser (string userName)
+               public override bool UnlockUser (string username)
                {
                        throw new NotImplementedException ();
                }
index dbedffc04b70a37d026494d253f389575a3f4b03..35fd75d96deb8e8d8825d74d9d56b7a971da2aca 100644 (file)
@@ -83,12 +83,12 @@ namespace System.Web.Security
                        return usr;
                }
                
-               public static MembershipUser CreateUser (string username, string password, string email, string pwdQuestion, string pwdAnswer, bool isApproved, out MembershipCreateStatus status)
+               public static MembershipUser CreateUser (string username, string password, string email, string passwordQuestion, string passwordAnswer, bool isApproved, out MembershipCreateStatus status)
                {
-                       return CreateUser (username, password, email, pwdQuestion, pwdAnswer, isApproved, null, out status);
+                       return CreateUser (username, password, email, passwordQuestion, passwordAnswer, isApproved, null, out status);
                }
                
-               public static MembershipUser CreateUser (string username, string password, string email, string pwdQuestion, string pwdAnswer, bool isApproved, object providerUserKey, out MembershipCreateStatus status)
+               public static MembershipUser CreateUser (string username, string password, string email, string passwordQuestion, string passwordAnswer, bool isApproved, object providerUserKey, out MembershipCreateStatus status)
                {
                        if (String.IsNullOrEmpty (username)) {
                                status = MembershipCreateStatus.InvalidUserName;
@@ -100,7 +100,7 @@ namespace System.Web.Security
                                return null;
                        }
 
-                       return Provider.CreateUser (username, password, email, pwdQuestion, pwdAnswer, isApproved, providerUserKey, out status);
+                       return Provider.CreateUser (username, password, email, passwordQuestion, passwordAnswer, isApproved, providerUserKey, out status);
                }
                
                public static bool DeleteUser (string username)
@@ -221,9 +221,9 @@ namespace System.Web.Security
                        return Provider.GetUser (providerUserKey, userIsOnline);
                }
                
-               public static string GetUserNameByEmail (string email)
+               public static string GetUserNameByEmail (string emailToMatch)
                {
-                       return Provider.GetUserNameByEmail (email);
+                       return Provider.GetUserNameByEmail (emailToMatch);
                }
                
                public static void UpdateUser (MembershipUser user)
@@ -247,15 +247,15 @@ namespace System.Web.Security
                        return Provider.FindUsersByEmail (emailToMatch, pageIndex, pageSize, out totalRecords);
                }
                
-               public static MembershipUserCollection FindUsersByName (string nameToMatch)
+               public static MembershipUserCollection FindUsersByName (string usernameToMatch)
                {
                        int totalRecords;
-                       return Provider.FindUsersByName (nameToMatch, 0, int.MaxValue, out totalRecords);
+                       return Provider.FindUsersByName (usernameToMatch, 0, int.MaxValue, out totalRecords);
                }
                
-               public static MembershipUserCollection FindUsersByName (string nameToMatch, int pageIndex, int pageSize, out int totalRecords)
+               public static MembershipUserCollection FindUsersByName (string usernameToMatch, int pageIndex, int pageSize, out int totalRecords)
                {
-                       return Provider.FindUsersByName (nameToMatch, pageIndex, pageSize, out totalRecords);
+                       return Provider.FindUsersByName (usernameToMatch, pageIndex, pageSize, out totalRecords);
                }
 
                public static string ApplicationName {
index 7ec98ead7d6f4f9011b60c71dfd8e54171f64334..f799c71258e8d0f593e28423f228479a060ce2de 100644 (file)
@@ -46,29 +46,29 @@ namespace System.Web.Security {
                }
 
 
-               public static void AddUsersToRole (string [] usernames, string rolename)
+               public static void AddUsersToRole (string [] usernames, string roleName)
                {
-                       Provider.AddUsersToRoles (usernames, new string[] {rolename});
+                       Provider.AddUsersToRoles (usernames, new string[] {roleName});
                }
                
-               public static void AddUsersToRoles (string [] usernames, string [] rolenames)
+               public static void AddUsersToRoles (string [] usernames, string [] roleNames)
                {
-                       Provider.AddUsersToRoles (usernames, rolenames);
+                       Provider.AddUsersToRoles (usernames, roleNames);
                }
                
-               public static void AddUserToRole (string username, string rolename)
+               public static void AddUserToRole (string username, string roleName)
                {
-                       Provider.AddUsersToRoles (new string[] {username}, new string[] {rolename});
+                       Provider.AddUsersToRoles (new string[] {username}, new string[] {roleName});
                }
                
-               public static void AddUserToRoles (string username, string [] rolenames)
+               public static void AddUserToRoles (string username, string [] roleNames)
                {
-                       Provider.AddUsersToRoles (new string[] {username}, rolenames);
+                       Provider.AddUsersToRoles (new string[] {username}, roleNames);
                }
                
-               public static void CreateRole (string rolename)
+               public static void CreateRole (string roleName)
                {
-                       Provider.CreateRole (rolename);
+                       Provider.CreateRole (roleName);
                }
                
                public static void DeleteCookie ()
@@ -91,14 +91,14 @@ namespace System.Web.Security {
                        }
                }
                
-               public static bool DeleteRole (string rolename)
+               public static bool DeleteRole (string roleName)
                {
-                       return Provider.DeleteRole (rolename, true);
+                       return Provider.DeleteRole (roleName, true);
                }
                
-               public static bool DeleteRole (string rolename, bool throwOnPopulatedRole)
+               public static bool DeleteRole (string roleName, bool throwOnPopulatedRole)
                {
-                       return Provider.DeleteRole (rolename, throwOnPopulatedRole);
+                       return Provider.DeleteRole (roleName, throwOnPopulatedRole);
                }
                
                public static string [] GetAllRoles ()
@@ -125,51 +125,51 @@ namespace System.Web.Security {
                        return Provider.GetRolesForUser (username);
                }
                
-               public static string [] GetUsersInRole (string rolename)
+               public static string [] GetUsersInRole (string roleName)
                {
-                       return Provider.GetUsersInRole (rolename);
+                       return Provider.GetUsersInRole (roleName);
                }
                
-               public static bool IsUserInRole (string rolename)
+               public static bool IsUserInRole (string roleName)
                {
-                       return IsUserInRole (CurrentUser, rolename);
+                       return IsUserInRole (CurrentUser, roleName);
                }
                
-               public static bool IsUserInRole (string username, string rolename)
+               public static bool IsUserInRole (string username, string roleName)
                {
                        if (String.IsNullOrEmpty (username))
                                return false;
-                       return Provider.IsUserInRole (username, rolename);
+                       return Provider.IsUserInRole (username, roleName);
                }
                
-               public static void RemoveUserFromRole (string username, string rolename)
+               public static void RemoveUserFromRole (string username, string roleName)
                {
-                       Provider.RemoveUsersFromRoles (new string[] {username}, new string[] {rolename});
+                       Provider.RemoveUsersFromRoles (new string[] {username}, new string[] {roleName});
                }
                
-               public static void RemoveUserFromRoles (string username, string [] rolenames)
+               public static void RemoveUserFromRoles (string username, string [] roleNames)
                {
-                       Provider.RemoveUsersFromRoles (new string[] {username}, rolenames);
+                       Provider.RemoveUsersFromRoles (new string[] {username}, roleNames);
                }
                
-               public static void RemoveUsersFromRole (string [] usernames, string rolename)
+               public static void RemoveUsersFromRole (string [] usernames, string roleName)
                {
-                       Provider.RemoveUsersFromRoles (usernames, new string[] {rolename});
+                       Provider.RemoveUsersFromRoles (usernames, new string[] {roleName});
                }
                
-               public static void RemoveUsersFromRoles (string [] usernames, string [] rolenames)
+               public static void RemoveUsersFromRoles (string [] usernames, string [] roleNames)
                {
-                       Provider.RemoveUsersFromRoles (usernames, rolenames);
+                       Provider.RemoveUsersFromRoles (usernames, roleNames);
                }
                
-               public static bool RoleExists (string rolename)
+               public static bool RoleExists (string roleName)
                {
-                       return Provider.RoleExists (rolename);
+                       return Provider.RoleExists (roleName);
                }
                
-               public static string[] FindUsersInRole (string rolename, string usernameToMatch)
+               public static string[] FindUsersInRole (string roleName, string usernameToMatch)
                {
-                       return Provider.FindUsersInRole (rolename, usernameToMatch);
+                       return Provider.FindUsersInRole (roleName, usernameToMatch);
                }
                
                public static string ApplicationName {
index cca4e838166cbbd279bf56d9ee389d7c6dd54f6c..820acd502e2eded6595e077fd7a7f4b59e91e300 100644 (file)
@@ -122,28 +122,28 @@ namespace System.Web.Security {
                                throw new ArgumentException (String.Format ("invalid format for {0}", pName));
                }
 
-               public override bool ChangePassword (string username, string oldPwd, string newPwd)
+               public override bool ChangePassword (string username, string oldPassword, string newPassword)
                {
                        if (username != null) username = username.Trim ();
-                       if (oldPwd != null) oldPwd = oldPwd.Trim ();
-                       if (newPwd != null) newPwd = newPwd.Trim ();
+                       if (oldPassword != null) oldPassword = oldPassword.Trim ();
+                       if (newPassword != null) newPassword = newPassword.Trim ();
 
                        CheckParam ("username", username, 256);
-                       CheckParam ("oldPwd", oldPwd, 128);
-                       CheckParam ("newPwd", newPwd, 128);
+                       CheckParam ("oldPassword", oldPassword, 128);
+                       CheckParam ("newPassword", newPassword, 128);
 
-                       if (!CheckPassword (newPwd))
+                       if (!CheckPassword (newPassword))
                                throw new ArgumentException (string.Format (
                                                "New Password invalid. New Password length minimum: {0}. Non-alphanumeric characters required: {1}.",
                                                MinRequiredPasswordLength,
                                                MinRequiredNonAlphanumericCharacters));
 
                        using (DbConnection connection = CreateConnection ()) {
-                               PasswordInfo pi = ValidateUsingPassword (username, oldPwd);
+                               PasswordInfo pi = ValidateUsingPassword (username, oldPassword);
 
                                if (pi != null) {
-                                       EmitValidatingPassword (username, newPwd, false);
-                                       string db_password = EncodePassword (newPwd, pi.PasswordFormat, pi.PasswordSalt);
+                                       EmitValidatingPassword (username, newPassword, false);
+                                       string db_password = EncodePassword (newPassword, pi.PasswordFormat, pi.PasswordSalt);
 
                                        DbCommand command = factory.CreateCommand ();
                                        command.Connection = connection;
@@ -169,23 +169,23 @@ namespace System.Web.Security {
                        }
                }
 
-               public override bool ChangePasswordQuestionAndAnswer (string username, string password, string newPwdQuestion, string newPwdAnswer)
+               public override bool ChangePasswordQuestionAndAnswer (string username, string password, string newPasswordQuestion, string newPasswordAnswer)
                {
                        if (username != null) username = username.Trim ();
-                       if (newPwdQuestion != null) newPwdQuestion = newPwdQuestion.Trim ();
-                       if (newPwdAnswer != null) newPwdAnswer = newPwdAnswer.Trim ();
+                       if (newPasswordQuestion != null) newPasswordQuestion = newPasswordQuestion.Trim ();
+                       if (newPasswordAnswer != null) newPasswordAnswer = newPasswordAnswer.Trim ();
 
                        CheckParam ("username", username, 256);
                        if (RequiresQuestionAndAnswer)
-                               CheckParam ("newPwdQuestion", newPwdQuestion, 128);
+                               CheckParam ("newPasswordQuestion", newPasswordQuestion, 128);
                        if (RequiresQuestionAndAnswer)
-                               CheckParam ("newPwdAnswer", newPwdAnswer, 128);
+                               CheckParam ("newPasswordAnswer", newPasswordAnswer, 128);
 
                        using (DbConnection connection = CreateConnection ()) {
                                PasswordInfo pi = ValidateUsingPassword (username, password);
 
                                if (pi != null) {
-                                       string db_passwordAnswer = EncodePassword (newPwdAnswer, pi.PasswordFormat, pi.PasswordSalt);
+                                       string db_passwordAnswer = EncodePassword (newPasswordAnswer, pi.PasswordFormat, pi.PasswordSalt);
 
                                        DbCommand command = factory.CreateCommand ();
                                        command.Connection = connection;
@@ -194,7 +194,7 @@ namespace System.Web.Security {
 
                                        AddParameter (command, "@ApplicationName", ApplicationName);
                                        AddParameter (command, "@UserName", username);
-                                       AddParameter (command, "@NewPasswordQuestion", newPwdQuestion);
+                                       AddParameter (command, "@NewPasswordQuestion", newPasswordQuestion);
                                        AddParameter (command, "@NewPasswordAnswer", db_passwordAnswer);
                                        DbParameter returnValue = AddParameter (command, "@ReturnVal", ParameterDirection.ReturnValue, DbType.Int32, null);
 
@@ -212,8 +212,8 @@ namespace System.Web.Security {
                public override MembershipUser CreateUser (string username,
                                                           string password,
                                                           string email,
-                                                          string pwdQuestion,
-                                                          string pwdAnswer,
+                                                          string passwordQuestion,
+                                                          string passwordAnswer,
                                                           bool isApproved,
                                                           object providerUserKey,
                                                           out MembershipCreateStatus status)
@@ -221,8 +221,8 @@ namespace System.Web.Security {
                        if (username != null) username = username.Trim ();
                        if (password != null) password = password.Trim ();
                        if (email != null) email = email.Trim ();
-                       if (pwdQuestion != null) pwdQuestion = pwdQuestion.Trim ();
-                       if (pwdAnswer != null) pwdAnswer = pwdAnswer.Trim ();
+                       if (passwordQuestion != null) passwordQuestion = passwordQuestion.Trim ();
+                       if (passwordAnswer != null) passwordAnswer = passwordAnswer.Trim ();
 
                        /* some initial validation */
                        if (username == null || username.Length == 0 || username.Length > 256 || username.IndexOf (',') != -1) {
@@ -245,14 +245,14 @@ namespace System.Web.Security {
                                return null;
                        }
                        if (RequiresQuestionAndAnswer &&
-                               (pwdQuestion == null ||
-                                pwdQuestion.Length == 0 || pwdQuestion.Length > 256)) {
+                               (passwordQuestion == null ||
+                                passwordQuestion.Length == 0 || passwordQuestion.Length > 256)) {
                                status = MembershipCreateStatus.InvalidQuestion;
                                return null;
                        }
                        if (RequiresQuestionAndAnswer &&
-                               (pwdAnswer == null ||
-                                pwdAnswer.Length == 0 || pwdAnswer.Length > 128)) {
+                               (passwordAnswer == null ||
+                                passwordAnswer.Length == 0 || passwordAnswer.Length > 128)) {
                                status = MembershipCreateStatus.InvalidAnswer;
                                return null;
                        }
@@ -275,7 +275,7 @@ namespace System.Web.Security {
 
                        password = EncodePassword (password, PasswordFormat, passwordSalt);
                        if (RequiresQuestionAndAnswer)
-                               pwdAnswer = EncodePassword (pwdAnswer, PasswordFormat, passwordSalt);
+                               passwordAnswer = EncodePassword (passwordAnswer, PasswordFormat, passwordSalt);
 
                        /* make sure the hashed/encrypted password and
                         * answer are still under 128 characters. */
@@ -285,7 +285,7 @@ namespace System.Web.Security {
                        }
 
                        if (RequiresQuestionAndAnswer) {
-                               if (pwdAnswer.Length > 128) {
+                               if (passwordAnswer.Length > 128) {
                                        status = MembershipCreateStatus.InvalidAnswer;
                                        return null;
                                }
@@ -307,8 +307,8 @@ namespace System.Web.Security {
                                        AddParameter (command, "@Password", password);
                                        AddParameter (command, "@PasswordSalt", passwordSalt);
                                        AddParameter (command, "@Email", email);
-                                       AddParameter (command, "@PasswordQuestion", pwdQuestion);
-                                       AddParameter (command, "@PasswordAnswer", pwdAnswer);
+                                       AddParameter (command, "@PasswordQuestion", passwordQuestion);
+                                       AddParameter (command, "@PasswordAnswer", passwordAnswer);
                                        AddParameter (command, "@IsApproved", isApproved);
                                        AddParameter (command, "@CurrentTimeUtc", Now);
                                        AddParameter (command, "@CreateDate", Now);
@@ -429,9 +429,9 @@ namespace System.Web.Security {
                        }
                }
 
-               public override MembershipUserCollection FindUsersByName (string nameToMatch, int pageIndex, int pageSize, out int totalRecords)
+               public override MembershipUserCollection FindUsersByName (string usernameToMatch, int pageIndex, int pageSize, out int totalRecords)
                {
-                       CheckParam ("nameToMatch", nameToMatch, 256);
+                       CheckParam ("usernameToMatch", usernameToMatch, 256);
 
                        if (pageIndex < 0)
                                throw new ArgumentException ("pageIndex must be >= 0");
@@ -449,7 +449,7 @@ namespace System.Web.Security {
 
                                AddParameter (command, "@PageIndex", pageIndex);
                                AddParameter (command, "@PageSize", pageSize);
-                               AddParameter (command, "@UserNameToMatch", nameToMatch);
+                               AddParameter (command, "@UserNameToMatch", usernameToMatch);
                                AddParameter (command, "@ApplicationName", ApplicationName);
                                // return value
                                AddParameter (command, "@ReturnValue", ParameterDirection.ReturnValue, null);
@@ -529,20 +529,20 @@ namespace System.Web.Security {
                        }
                }
 
-               public override string GetPassword (string username, string answer)
+               public override string GetPassword (string username, string passwordAnswer)
                {
                        if (!EnablePasswordRetrieval)
                                throw new NotSupportedException ("this provider has not been configured to allow the retrieval of passwords");
 
                        CheckParam ("username", username, 256);
                        if (RequiresQuestionAndAnswer)
-                               CheckParam ("answer", answer, 128);
+                               CheckParam ("passwordAnswer", passwordAnswer, 128);
 
                        PasswordInfo pi = GetPasswordInfo (username);
                        if (pi == null)
                                throw new ProviderException ("An error occurred while retrieving the password from the database");
 
-                       string user_answer = EncodePassword (answer, pi.PasswordFormat, pi.PasswordSalt);
+                       string user_answer = EncodePassword (passwordAnswer, pi.PasswordFormat, pi.PasswordSalt);
                        string password = null;
 
                        using (DbConnection connection = CreateConnection ()) {
@@ -790,7 +790,7 @@ namespace System.Web.Security {
                                ProvidersHelper.GetDbProviderFactory (connectionString.ProviderName);
                }
 
-               public override string ResetPassword (string username, string answer)
+               public override string ResetPassword (string username, string passwordAnswer)
                {
                        if (!EnablePasswordReset)
                                throw new NotSupportedException ("this provider has not been configured to allow the resetting of passwords");
@@ -798,7 +798,7 @@ namespace System.Web.Security {
                        CheckParam ("username", username, 256);
 
                        if (RequiresQuestionAndAnswer)
-                               CheckParam ("answer", answer, 128);
+                               CheckParam ("passwordAnswer", passwordAnswer, 128);
 
                        using (DbConnection connection = CreateConnection ()) {
 
@@ -810,7 +810,7 @@ namespace System.Web.Security {
                                EmitValidatingPassword (username, newPassword, false);
 
                                string db_password = EncodePassword (newPassword, pi.PasswordFormat, pi.PasswordSalt);
-                               string db_answer = EncodePassword (answer, pi.PasswordFormat, pi.PasswordSalt);
+                               string db_answer = EncodePassword (passwordAnswer, pi.PasswordFormat, pi.PasswordSalt);
 
                                DbCommand command = factory.CreateCommand ();
                                command.Connection = connection;
index 76ed81a58fce80463fa35ac52b4f87b80dfe3a55..770645f0445288eef79ed94acf41356f51656d77 100644 (file)
@@ -87,7 +87,7 @@ namespace System.Web.Security
                        return dbp;
                }
 
-               public override void AddUsersToRoles (string [] usernames, string [] rolenames)
+               public override void AddUsersToRoles (string [] usernames, string [] roleNames)
                {
                        Hashtable h = new Hashtable ();
 
@@ -102,7 +102,7 @@ namespace System.Web.Security
                        }
 
                        h = new Hashtable ();
-                       foreach (string r in rolenames) {
+                       foreach (string r in roleNames) {
                                if (r == null)
                                        throw new ArgumentNullException ("null element in rolenames array");
                                if (h.ContainsKey (r))
@@ -119,7 +119,7 @@ namespace System.Web.Security
                                command.Connection = connection;
                                command.CommandType = CommandType.StoredProcedure;
 
-                               AddParameter (command, "@RoleNames", String.Join (",", rolenames));
+                               AddParameter (command, "@RoleNames", String.Join (",", roleNames));
                                AddParameter (command, "@UserNames", String.Join (",", usernames));
                                AddParameter (command, "@ApplicationName", ApplicationName);
                                AddParameter (command, "@CurrentTimeUtc", DateTime.UtcNow);
@@ -139,12 +139,12 @@ namespace System.Web.Security
                        }
                }
 
-               public override void CreateRole (string rolename)
+               public override void CreateRole (string roleName)
                {
-                       if (rolename == null)
-                               throw new ArgumentNullException ("rolename");
+                       if (roleName == null)
+                               throw new ArgumentNullException ("roleName");
 
-                       if (rolename.Length == 0 || rolename.Length > 256 || rolename.IndexOf (',') != -1)
+                       if (roleName.Length == 0 || roleName.Length > 256 || roleName.IndexOf (',') != -1)
                                throw new ArgumentException ("rolename is in invalid format");
 
                        using (DbConnection connection = CreateConnection ()) {
@@ -154,25 +154,25 @@ namespace System.Web.Security
                                command.CommandType = CommandType.StoredProcedure;
                                
                                AddParameter (command, "@ApplicationName", ApplicationName);
-                               AddParameter (command, "@RoleName", rolename);
+                               AddParameter (command, "@RoleName", roleName);
                                DbParameter dbpr = AddParameter (command, "@ReturnVal", ParameterDirection.ReturnValue, DbType.Int32, null);
 
                                command.ExecuteNonQuery ();
                                int returnValue = (int) dbpr.Value;
 
                                if (returnValue == 1)
-                                       throw new ProviderException (rolename + " already exists in the database");
+                                       throw new ProviderException (roleName + " already exists in the database");
                                else
                                        return;
                        }
                }
 
-               public override bool DeleteRole (string rolename, bool throwOnPopulatedRole)
+               public override bool DeleteRole (string roleName, bool throwOnPopulatedRole)
                {
-                       if (rolename == null)
-                               throw new ArgumentNullException ("rolename");
+                       if (roleName == null)
+                               throw new ArgumentNullException ("roleName");
 
-                       if (rolename.Length == 0 || rolename.Length > 256 || rolename.IndexOf (',') != -1)
+                       if (roleName.Length == 0 || roleName.Length > 256 || roleName.IndexOf (',') != -1)
                                throw new ArgumentException ("rolename is in invalid format");
 
                        using (DbConnection connection = CreateConnection ()) {
@@ -182,7 +182,7 @@ namespace System.Web.Security
                                command.Connection = connection;
                                command.CommandType = CommandType.StoredProcedure;
                                AddParameter (command, "@ApplicationName", ApplicationName);
-                               AddParameter (command, "@RoleName", rolename);
+                               AddParameter (command, "@RoleName", roleName);
                                AddParameter (command, "@DeleteOnlyIfRoleIsEmpty", throwOnPopulatedRole);
                                DbParameter dbpr = AddParameter (command, "@ReturnVal", ParameterDirection.ReturnValue, DbType.Int32, null);
 
@@ -194,7 +194,7 @@ namespace System.Web.Security
                                if (returnValue == 1)
                                        return false; //role does not exist
                                else if (returnValue == 2 && throwOnPopulatedRole)
-                                       throw new ProviderException (rolename + " is not empty");
+                                       throw new ProviderException (roleName + " is not empty");
                                else
                                        return false;
                        }
@@ -272,7 +272,7 @@ namespace System.Web.Security
                        }
                }
 
-               public override string [] GetUsersInRole (string rolename)
+               public override string [] GetUsersInRole (string roleName)
                {
                        using (DbConnection connection = CreateConnection ()) {
                                DbCommand command = factory.CreateCommand ();
@@ -280,7 +280,7 @@ namespace System.Web.Security
                                command.Connection = connection;
 
                                command.CommandType = CommandType.StoredProcedure;
-                               AddParameter (command, "@RoleName", rolename);
+                               AddParameter (command, "@RoleName", roleName);
                                AddParameter (command, "@ApplicationName", ApplicationName);
 
                                DbDataReader reader = command.ExecuteReader ();
@@ -327,7 +327,7 @@ namespace System.Web.Security
                                ProvidersHelper.GetDbProviderFactory (connectionString.ProviderName);
                }
 
-               public override bool IsUserInRole (string username, string rolename)
+               public override bool IsUserInRole (string username, string roleName)
                {
                        using (DbConnection connection = CreateConnection ()) {
                                DbCommand command = factory.CreateCommand ();
@@ -335,7 +335,7 @@ namespace System.Web.Security
                                command.Connection = connection;
 
                                command.CommandType = CommandType.StoredProcedure;
-                               AddParameter (command, "@RoleName", rolename);
+                               AddParameter (command, "@RoleName", roleName);
                                AddParameter (command, "@UserName", username);
                                AddParameter (command, "@ApplicationName", ApplicationName);
                                DbParameter dbpr = AddParameter (command, "@ReturnVal", ParameterDirection.ReturnValue, DbType.Int32, null);
@@ -350,7 +350,7 @@ namespace System.Web.Security
                        }
                }
 
-               public override void RemoveUsersFromRoles (string [] usernames, string [] rolenames)
+               public override void RemoveUsersFromRoles (string [] usernames, string [] roleNames)
                {
                        Hashtable h = new Hashtable ();
 
@@ -365,7 +365,7 @@ namespace System.Web.Security
                        }
 
                        h = new Hashtable ();
-                       foreach (string r in rolenames) {
+                       foreach (string r in roleNames) {
                                if (r == null)
                                        throw new ArgumentNullException ("null element in rolenames array");
                                if (h.ContainsKey (r))
@@ -382,7 +382,7 @@ namespace System.Web.Security
                                command.CommandType = CommandType.StoredProcedure;
 
                                AddParameter (command, "@UserNames", String.Join (",", usernames));
-                               AddParameter (command, "@RoleNames", String.Join (",", rolenames));
+                               AddParameter (command, "@RoleNames", String.Join (",", roleNames));
                                AddParameter (command, "@ApplicationName", ApplicationName);
                                DbParameter dbpr = AddParameter (command, "@ReturnVal", ParameterDirection.ReturnValue, DbType.Int32, null);
 
@@ -402,7 +402,7 @@ namespace System.Web.Security
                        }
                }
 
-               public override bool RoleExists (string rolename)
+               public override bool RoleExists (string roleName)
                {
                        using (DbConnection connection = CreateConnection ()) {
 
@@ -412,7 +412,7 @@ namespace System.Web.Security
                                command.CommandType = CommandType.StoredProcedure;
 
                                AddParameter (command, "@ApplicationName", ApplicationName);
-                               AddParameter (command, "@RoleName", rolename);
+                               AddParameter (command, "@RoleName", roleName);
                                DbParameter dbpr = AddParameter (command, "@ReturnVal", ParameterDirection.ReturnValue, DbType.Int32, null);
 
                                command.ExecuteNonQuery ();
index 9428f68e0a1304f91da00797f2ab329cc436100d..f2b6e54b8e7b83ba8294de642d2466ce807707da 100644 (file)
@@ -86,9 +86,9 @@ public sealed class HttpSessionState : ICollection, IEnumerable
                get { return container.IsSynchronized; }
        }
 
-       public object this [string key] {
-               get { return container [key]; }
-               set { container [key] = value; }
+       public object this [string name] {
+               get { return container [name]; }
+               set { container [name] = value; }
        }
 
        public object this [int index] {
index b0bb4d063312595889031f98c723f678fd4f5136..d3d5b80ab0be5570e0bba174be22abff5c72b1f3 100644 (file)
@@ -37,11 +37,11 @@ namespace System.Web.SessionState {
        {
                ///methods
                void Abandon ();
-               void Add (string itemName, object itemValue);
+               void Add (string name, object value);
                void Clear ();
-               void CopyTo (Array sessionValues, int index);
+               void CopyTo (Array array, int index);
                IEnumerator GetEnumerator ();
-               void Remove (string itemName);
+               void Remove (string name);
                void RemoveAll ();
                void RemoveAt (int index);
        
index 272ab9b8e273486d62a2f23b957f722bdc87b0dc..d70a46a04a954f68e9b6df4e81ff0f32b7ef7570 100644 (file)
@@ -41,7 +41,7 @@ namespace System.Web.SessionState {
                void Initialize ();
                bool InitializeRequest (HttpContext context, bool suppressAutoDetectRedirect, out bool supportSessionIDReissue);
                void RemoveSessionID (HttpContext context);
-               void SaveSessionID (HttpContext context, string sessionID, out bool isRedirected, out bool isCookieAdded);
+               void SaveSessionID (HttpContext context, string id, out bool redirected, out bool cookieAdded);
                bool Validate (string id);
        }
 }
index 56e8f0110afd9ba5a549c7243e72f57ad4f37ca8..9cabdb0bea83b14f70af0a1718222744caab5d04 100644 (file)
@@ -36,7 +36,7 @@ namespace System.Web.SessionState {
        {
                ///methods
                void Clear ();
-               void Remove (string itemName);
+               void Remove (string name);
                void RemoveAt (int index);
        
                ///properties
index 7e4b770bcf9d7e11986d1276e2808480f09bb8a2..93343e98aa19b6761e180a6759aa3636b46edf49 100644 (file)
@@ -38,12 +38,12 @@ namespace System.Web.SessionState {
                HttpStaticObjectsCollection staticObjects;
                int timeout;
 
-               public SessionStateStoreData (ISessionStateItemCollection items,
-                                               HttpStaticObjectsCollection objects,
+               public SessionStateStoreData (ISessionStateItemCollection sessionItems,
+                                               HttpStaticObjectsCollection staticObjects,
                                                int timeout)
                {
-                       sessionItems = items;
-                       staticObjects = objects;
+                       this.sessionItems = sessionItems;
+                       this.staticObjects = staticObjects;
                        this.timeout = timeout;
                }
 
index ea0aa13b97df70875b3c7d3ffc115140804e2548..9fe54d8b7362f04d3b39673f4f9e845a1550259f 100644 (file)
@@ -92,9 +92,9 @@ namespace System.Web.UI.Adapters
                        }
                }
 
-               protected internal virtual void BeginRender (HtmlTextWriter w)
+               protected internal virtual void BeginRender (HtmlTextWriter writer)
                {
-                       w.BeginRender();
+                       writer.BeginRender();
                }
 
                protected internal virtual void CreateChildControls ()
@@ -104,9 +104,9 @@ namespace System.Web.UI.Adapters
                                control.CreateChildControls ();
                }
 
-               protected internal virtual void EndRender (HtmlTextWriter w)
+               protected internal virtual void EndRender (HtmlTextWriter writer)
                {
-                       w.EndRender ();
+                       writer.EndRender ();
                }
 
                protected internal virtual void LoadAdapterControlState (object state)
@@ -149,20 +149,20 @@ namespace System.Web.UI.Adapters
                                control.OnUnload(e);
                }
 
-               protected internal virtual void Render (HtmlTextWriter w)
+               protected internal virtual void Render (HtmlTextWriter writer)
                {
                        Control control = Control;
 
                        if (control != null)
-                               control.Render (w);
+                               control.Render (writer);
                }
 
-               protected internal virtual void RenderChildren (HtmlTextWriter w)
+               protected internal virtual void RenderChildren (HtmlTextWriter writer)
                {
                        Control control = Control;
 
                        if (control != null)
-                               control.RenderChildren (w);
+                               control.RenderChildren (writer);
                }
 
                protected internal virtual object SaveAdapterControlState ()
index a86a98f71be152bb9696bbfb9439e7195a5fcdf2..77a75ec3ac23591e0c45f9bd31c482cb7f3a197b 100644 (file)
@@ -89,23 +89,23 @@ namespace System.Web.UI.Adapters
                                radioButtons.Add(radioButton);
                }
 
-               public virtual void RenderBeginHyperlink (HtmlTextWriter w,
+               public virtual void RenderBeginHyperlink (HtmlTextWriter writer,
                                                          string targetUrl,
                                                          bool encodeUrl,
-                                                         string softKeyLabel)
+                                                         string softkeyLabel)
                {
-                       InternalRenderBeginHyperlink (w, targetUrl, encodeUrl, softKeyLabel, null);
+                       InternalRenderBeginHyperlink (writer, targetUrl, encodeUrl, softkeyLabel, null);
                }
 
-               public virtual void RenderBeginHyperlink (HtmlTextWriter w,
+               public virtual void RenderBeginHyperlink (HtmlTextWriter writer,
                                                          string targetUrl,
                                                          bool encodeUrl,
-                                                         string softKeyLabel,
+                                                         string softkeyLabel,
                                                          string accessKey)
                {
                        if (accessKey != null && accessKey.Length > 1)
                                throw new ArgumentOutOfRangeException("accessKey");
-                       InternalRenderBeginHyperlink (w, targetUrl, encodeUrl, softKeyLabel, accessKey);
+                       InternalRenderBeginHyperlink (writer, targetUrl, encodeUrl, softkeyLabel, accessKey);
                }
                
                void InternalRenderBeginHyperlink (HtmlTextWriter w,
@@ -121,35 +121,35 @@ namespace System.Web.UI.Adapters
                }
                
                
-               public virtual void RenderEndHyperlink (HtmlTextWriter w)
+               public virtual void RenderEndHyperlink (HtmlTextWriter writer)
                {
-                       w.RenderEndTag();
+                       writer.RenderEndTag();
                }
 
-               public virtual void RenderPostBackEvent (HtmlTextWriter w,
+               public virtual void RenderPostBackEvent (HtmlTextWriter writer,
                                                         string target,
                                                         string argument,
-                                                        string softKeyLabel,
+                                                        string softkeyLabel,
                                                         string text)
                {
-                       RenderPostBackEvent (w, target, argument, softKeyLabel, text, Page.Request.FilePath, null, true);
+                       RenderPostBackEvent (writer, target, argument, softkeyLabel, text, Page.Request.FilePath, null, true);
                }
 
-               public virtual void RenderPostBackEvent (HtmlTextWriter w,
+               public virtual void RenderPostBackEvent (HtmlTextWriter writer,
                                                         string target,
                                                         string argument,
-                                                        string softKeyLabel,
+                                                        string softkeyLabel,
                                                         string text,
                                                         string postUrl,
                                                         string accessKey)
                {
-                       RenderPostBackEvent (w, target, argument, softKeyLabel, text, postUrl, accessKey, true);
+                       RenderPostBackEvent (writer, target, argument, softkeyLabel, text, postUrl, accessKey, true);
                }
 
-               protected void RenderPostBackEvent (HtmlTextWriter w,
+               protected void RenderPostBackEvent (HtmlTextWriter writer,
                                                    string target,
                                                    string argument,
-                                                   string softKeyLabel,
+                                                   string softkeyLabel,
                                                    string text,
                                                    string postUrl,
                                                    string accessKey,
@@ -157,9 +157,9 @@ namespace System.Web.UI.Adapters
                {
                        string url = String.Format ("{0}?__VIEWSTATE={1}&__EVENTTARGET={2}&__EVENTARGUMENT={3}&__PREVIOUSPAGE={4}",
                                postUrl, HttpUtility.UrlEncode (Page.GetSavedViewState ()), target, argument, Page.Request.FilePath);
-                       RenderBeginHyperlink (w, url, encode, softKeyLabel, accessKey);
-                       w.Write(text);
-                       RenderEndHyperlink(w);
+                       RenderBeginHyperlink (writer, url, encode, softkeyLabel, accessKey);
+                       writer.Write(text);
+                       RenderEndHyperlink(writer);
                }
 
                public virtual string TransformText (string text) 
@@ -167,9 +167,9 @@ namespace System.Web.UI.Adapters
                        return text;
                }
                
-               protected internal virtual string GetPostBackFormReference (string formID)
+               protected internal virtual string GetPostBackFormReference (string formId)
                {
-                       return String.Format("document.forms['{0}']", formID);
+                       return String.Format("document.forms['{0}']", formId);
                }
                
                ListDictionary radio_button_group;
index 495b941099cadedb3088c7adeddd89a96d783039..4fa9af17d06a4936d74c7e3aeef34201cc161a75 100644 (file)
@@ -216,7 +216,7 @@ namespace System.Web.UI.HtmlControls
                        base.OnPreRender(e);
                }
 
-               protected override void RenderAttributes (HtmlTextWriter w)
+               protected override void RenderAttributes (HtmlTextWriter writer)
                {
                        /* Need to always render: method, action and id
                         */
@@ -268,12 +268,12 @@ namespace System.Web.UI.HtmlControls
                                        if (RenderingCompatibilityLessThan40)
                                                // LAMESPEC: MSDN says the 'name' attribute is rendered only in
                                                // Legacy mode, this is not true.
-                                               w.WriteAttribute ("name", Name);
+                                               writer.WriteAttribute ("name", Name);
                        }
                        
-                       w.WriteAttribute ("method", Method);
+                       writer.WriteAttribute ("method", Method);
                        if (String.IsNullOrEmpty (customAction))
-                               w.WriteAttribute ("action", action, true);
+                               writer.WriteAttribute ("action", action, true);
 
                        /*
                         * This is a hack that guarantees the ID is set properly for HtmlControl to
@@ -292,7 +292,7 @@ namespace System.Web.UI.HtmlControls
                        string submit = page != null ? page.GetSubmitStatements () : null;
                        if (!String.IsNullOrEmpty (submit)) {
                                Attributes.Remove ("onsubmit");
-                               w.WriteAttribute ("onsubmit", submit);
+                               writer.WriteAttribute ("onsubmit", submit);
                        }
                        
                        /* enctype and target should not be written if
@@ -300,11 +300,11 @@ namespace System.Web.UI.HtmlControls
                         */
                        string enctype = Enctype;
                        if (!String.IsNullOrEmpty (enctype))
-                               w.WriteAttribute ("enctype", enctype);
+                               writer.WriteAttribute ("enctype", enctype);
 
                        string target = Target;
                        if (!String.IsNullOrEmpty (target))
-                               w.WriteAttribute ("target", target);
+                               writer.WriteAttribute ("target", target);
 
                        string defaultbutton = DefaultButton;
                        if (!String.IsNullOrEmpty (defaultbutton)) {
@@ -315,7 +315,7 @@ namespace System.Web.UI.HtmlControls
                                                                                           ID));
 
                                if (page != null && DetermineRenderUplevel ()) {
-                                       w.WriteAttribute (
+                                       writer.WriteAttribute (
                                                "onkeypress",
                                                "javascript:return " + page.WebFormScriptReference + ".WebForm_FireDefaultButton(event, '" + c.ClientID + "')");
                                }
@@ -328,10 +328,10 @@ namespace System.Web.UI.HtmlControls
                        Attributes.Remove ("enctype");
                        Attributes.Remove ("target");
 
-                       base.RenderAttributes (w);
+                       base.RenderAttributes (writer);
                }
 
-               protected internal override void RenderChildren (HtmlTextWriter w)
+               protected internal override void RenderChildren (HtmlTextWriter writer)
                {
                        Page page = Page;
                        
@@ -340,22 +340,22 @@ namespace System.Web.UI.HtmlControls
                                page.RegisterForm (this);
                        }
                        if (page != null)
-                               page.OnFormRender (w, ClientID);
-                       base.RenderChildren (w);
+                               page.OnFormRender (writer, ClientID);
+                       base.RenderChildren (writer);
                        if (page != null)
-                               page.OnFormPostRender (w, ClientID);
+                               page.OnFormPostRender (writer, ClientID);
                }
 
                /* According to corcompare */
                [MonoTODO ("why override?")]
-               public override void RenderControl (HtmlTextWriter w)
+               public override void RenderControl (HtmlTextWriter writer)
                {
-                       base.RenderControl (w);
+                       base.RenderControl (writer);
                }
 
-               protected internal override void Render (HtmlTextWriter w)
+               protected internal override void Render (HtmlTextWriter output)
                {
-                       base.Render (w);
+                       base.Render (output);
                }
        }
 }
index 871e22e6ad9dbf83aa0f635b5c98eb995473abc1..dfee69482279de53ecc3b81ca591f9bfe3643efb 100644 (file)
@@ -185,9 +185,9 @@ namespace System.Web.UI.HtmlControls
                        }
                }
 
-               protected override void RenderAttributes (HtmlTextWriter w)
+               protected override void RenderAttributes (HtmlTextWriter writer)
                {
-                       PreProcessRelativeReference (w, "src");
+                       PreProcessRelativeReference (writer, "src");
 
                        /* MS does not seem to render the src attribute if it
                         * is empty. Firefox, at least, will fetch the current
@@ -197,13 +197,13 @@ namespace System.Web.UI.HtmlControls
                        if (src == null || src.Length == 0)
                                Attributes.Remove ("src");
 
-                       base.RenderAttributes (w);
+                       base.RenderAttributes (writer);
 
                        /* MS closes the HTML element at the end of
                         * the attributes too, according to the nunit
                         * tests
                         */
-                       w.Write (" /");
+                       writer.Write (" /");
                }
        }
 }
index 5416e3af666aa2834319955581f9ef419569c64a..fb1dbdc20a3cff6090bf3edeb6ff4745d0176fc1 100644 (file)
@@ -585,7 +585,7 @@ namespace System.Web.UI.HtmlControls
                        }
                }
                
-               protected override void RenderAttributes (HtmlTextWriter w)
+               protected override void RenderAttributes (HtmlTextWriter writer)
                {
                        Page page = Page;
                        if (page != null)
@@ -594,7 +594,7 @@ namespace System.Web.UI.HtmlControls
                        /* If there is no "name" attribute,
                         * LoadPostData doesn't work...
                         */
-                       w.WriteAttribute ("name", Name);
+                       writer.WriteAttribute ("name", Name);
                        Attributes.Remove ("name");
                        
                        /* Don't render the databinding attributes */
@@ -602,24 +602,24 @@ namespace System.Web.UI.HtmlControls
                        Attributes.Remove ("datatextfield");
                        Attributes.Remove ("datavaluefield");
                        
-                       base.RenderAttributes (w);
+                       base.RenderAttributes (writer);
                }
                
-               protected internal override void RenderChildren (HtmlTextWriter w)
+               protected internal override void RenderChildren (HtmlTextWriter writer)
                {
-                       base.RenderChildren (w);
+                       base.RenderChildren (writer);
 
                        if (items == null)
                                return;
                        
-                       w.WriteLine ();
+                       writer.WriteLine ();
 
                        bool done_sel = false;
                        
                        int count = items.Count;
                        for (int i = 0; i < count; i++) {
                                ListItem item = items[i];
-                               w.Indent++;
+                               writer.Indent++;
                                
                                /* Write the <option> elements this
                                 * way so that the output HTML matches
@@ -628,29 +628,29 @@ namespace System.Web.UI.HtmlControls
                                 * element, cos that breaks other
                                 * stuff.)
                                 */
-                               w.WriteBeginTag ("option");
+                               writer.WriteBeginTag ("option");
                                if (item.Selected && !done_sel) {
 
-                                       w.WriteAttribute ("selected", "selected");
+                                       writer.WriteAttribute ("selected", "selected");
 
                                        if (!Multiple) {
                                                done_sel = true;
                                        }
                                }
                                
-                               w.WriteAttribute ("value", item.Value, true);
+                               writer.WriteAttribute ("value", item.Value, true);
                                if (item.HasAttributes) {
                                        AttributeCollection attrs = item.Attributes;
                                        foreach (string key in attrs.Keys)
-                                               w.WriteAttribute (key, HttpUtility.HtmlAttributeEncode (attrs [key]));
+                                               writer.WriteAttribute (key, HttpUtility.HtmlAttributeEncode (attrs [key]));
                                }
-                               w.Write (HtmlTextWriter.TagRightChar);
+                               writer.Write (HtmlTextWriter.TagRightChar);
                                
-                               w.Write (HttpUtility.HtmlEncode(item.Text));
-                               w.WriteEndTag ("option");
-                               w.WriteLine ();
+                               writer.Write (HttpUtility.HtmlEncode(item.Text));
+                               writer.WriteEndTag ("option");
+                               writer.WriteLine ();
 
-                               w.Indent--;
+                               writer.Indent--;
                        }
                }
 
index 0ddd1f85537e27ef5a68c8a303084544c25768c9..d69f398988a328b0e3d5b7e1a60efd98a50c5dbc 100644 (file)
@@ -54,9 +54,9 @@ namespace System.Web.UI.WebControls.WebParts
                        InnerList.AddRange (connectionInterfaces);
                }
 
-               public bool Contains (Type t)
+               public bool Contains (Type value)
                {
-                       return InnerList.Contains (t);
+                       return InnerList.Contains (value);
                }
 
                public void CopyTo (Type[] array, 
@@ -65,9 +65,9 @@ namespace System.Web.UI.WebControls.WebParts
                        InnerList.CopyTo (array, index);
                }
 
-               public int IndexOf (Type t)
+               public int IndexOf (Type value)
                {
-                       return InnerList.IndexOf (t);
+                       return InnerList.IndexOf (value);
                }
 
                public Type this [ int index ] {
index 55b14d558c29881f2ff6da91fce4f6f33604c7fe..414fb2eed1f02580c0ca768747419cf1f1667285 100644 (file)
@@ -32,10 +32,10 @@ namespace System.Web.UI.WebControls.WebParts
 {
        public class ConsumerConnectionPoint : ConnectionPoint
        {
-               public ConsumerConnectionPoint (MethodInfo callBack, Type interFace,
-                       Type control, string name, string id, 
-                       bool allowsMultiConnections) : base (callBack, interFace,
-                                       control, name, id, allowsMultiConnections)
+               public ConsumerConnectionPoint (MethodInfo callbackMethod, Type interfaceType,
+                       Type controlType, string displayName, string id, 
+                       bool allowsMultipleConnections) : base (callbackMethod, interfaceType,
+                                       controlType, displayName, id, allowsMultipleConnections)
                {                       
                }
 
index ccf929e3955a15cac87f7d1f2092582968a05ca1..ce66e17394fd28c5287c01fd3f9169eded5ec1a3 100644 (file)
@@ -32,10 +32,10 @@ namespace System.Web.UI.WebControls.WebParts
 {
        public class ProviderConnectionPoint : ConnectionPoint
        {
-               public ProviderConnectionPoint (MethodInfo callBack, Type interFace,
-                       Type control, string name, string id,
-                       bool allowsMultiConnections) : base (callBack, interFace,
-                                       control, name, id, allowsMultiConnections)
+               public ProviderConnectionPoint (MethodInfo callbackMethod, Type interfaceType,
+                       Type controlType, string displayName, string id,
+                       bool allowsMultipleConnections) : base (callbackMethod, interfaceType,
+                                       controlType, displayName, id, allowsMultipleConnections)
                {
                }
 
index f67c7391df077613585923ba50cb12815004724f..38b281967997623173d9f1b697f246226cc1f55a 100644 (file)
@@ -53,11 +53,11 @@ namespace System.Web.UI.WebControls.WebParts
                        get { return id;}
                }
 
-               public WebPartVerb (string id, string clientHandler) {
+               public WebPartVerb (string id, string clientClickHandler) {
                        this.id = id;
-                       this.clientClickHandler = clientHandler;
+                       this.clientClickHandler = clientClickHandler;
                        stateBag = new StateBag ();
-                       stateBag.Add ("clientClickHandler", clientHandler);
+                       stateBag.Add ("clientClickHandler", clientClickHandler);
                }
 
 
index 4e866c0b4ac621cf5c183a42fac00663ec2b7ec6..42a36909e1b7ce7feb47a0b13bdea2fc3a0e1751 100644 (file)
@@ -53,7 +53,7 @@ namespace System.Web.UI.WebControls
                        base.OnInit(e);
                }
 
-               protected internal override void OnPreRender (EventArgs eee)
+               protected internal override void OnPreRender (EventArgs e)
                {
                        Hashtable ht = null;
                        
@@ -62,9 +62,9 @@ namespace System.Web.UI.WebControls
                                ht = ChooseAd ();
                        }
 
-                       AdCreatedEventArgs e = new AdCreatedEventArgs (ht);
-                       OnAdCreated (e);
-                       createdargs = e;
+                       AdCreatedEventArgs ev = new AdCreatedEventArgs (ht);
+                       OnAdCreated (ev);
+                       createdargs = ev;
                        
                }
 
@@ -80,27 +80,27 @@ namespace System.Web.UI.WebControls
                        throw new NotImplementedException ();
                }
 
-               protected internal override void Render (HtmlTextWriter w)
+               protected internal override void Render (HtmlTextWriter writer)
                {
                        AdCreatedEventArgs e = createdargs;
 
-                       base.AddAttributesToRender (w);
+                       base.AddAttributesToRender (writer);
 
                        if (e.NavigateUrl != null && e.NavigateUrl.Length > 0)
-                               w.AddAttribute (HtmlTextWriterAttribute.Href, ResolveAdUrl (e.NavigateUrl));
+                               writer.AddAttribute (HtmlTextWriterAttribute.Href, ResolveAdUrl (e.NavigateUrl));
                        if (Target != null && Target.Length > 0)
-                               w.AddAttribute (HtmlTextWriterAttribute.Target, Target);
+                               writer.AddAttribute (HtmlTextWriterAttribute.Target, Target);
                        
-                       w.RenderBeginTag (HtmlTextWriterTag.A);
+                       writer.RenderBeginTag (HtmlTextWriterTag.A);
 
                        if (e.ImageUrl != null && e.ImageUrl.Length > 0)
-                               w.AddAttribute (HtmlTextWriterAttribute.Src, ResolveAdUrl (e.ImageUrl));
+                               writer.AddAttribute (HtmlTextWriterAttribute.Src, ResolveAdUrl (e.ImageUrl));
 
-                       w.AddAttribute (HtmlTextWriterAttribute.Alt, e.AlternateText == null ? String.Empty : e.AlternateText);
-                       w.AddAttribute (HtmlTextWriterAttribute.Border, "0", false);
-                       w.RenderBeginTag (HtmlTextWriterTag.Img);
-                       w.RenderEndTag (); // img
-                       w.RenderEndTag (); // a
+                       writer.AddAttribute (HtmlTextWriterAttribute.Alt, e.AlternateText == null ? String.Empty : e.AlternateText);
+                       writer.AddAttribute (HtmlTextWriterAttribute.Border, "0", false);
+                       writer.RenderBeginTag (HtmlTextWriterTag.Img);
+                       writer.RenderEndTag (); // img
+                       writer.RenderEndTag (); // a
                }
 
                string ResolveAdUrl (string url)
index 5969ffcc9b3fa45a31aafbefb034428efc304b9b..8f0af318c4fb8a5b8d273b3765023a0adaabfedd 100644 (file)
@@ -44,7 +44,7 @@ namespace System.Web.UI.WebControls
                {
                }
 
-               protected override void AddAttributesToRender (HtmlTextWriter w)
+               protected override void AddAttributesToRender (HtmlTextWriter writer)
                {
                        if (RenderUplevel) {
                                if (Page != null) {
@@ -69,7 +69,7 @@ namespace System.Web.UI.WebControls
                                }
                        }
 
-                       base.AddAttributesToRender (w);
+                       base.AddAttributesToRender (writer);
                }
 
                public static bool CanConvert (string text,
@@ -87,9 +87,9 @@ namespace System.Web.UI.WebControls
                        return BaseCompareValidator.Convert(text, type, false, out value);
                }
 
-               protected static bool Compare (string left, string right, ValidationCompareOperator op, ValidationDataType type)
+               protected static bool Compare (string leftText, string rightText, ValidationCompareOperator op, ValidationDataType type)
                {
-                       return BaseCompareValidator.Compare(left, false, right, false, op, type);       
+                       return BaseCompareValidator.Compare(leftText, false, rightText, false, op, type);       
                }
 
                protected override bool DetermineRenderUplevel ()
@@ -134,7 +134,7 @@ namespace System.Web.UI.WebControls
                        return order.ToString ();
                }
 
-               protected static int GetFullYear (int two_digit_year)
+               protected static int GetFullYear (int shortYear)
                {
                        /* This is an implementation that matches the
                         * docs on msdn, but MS doesn't seem to go by
@@ -142,10 +142,10 @@ namespace System.Web.UI.WebControls
                        int cutoff = CutoffYear;
                        int twodigitcutoff = cutoff % 100;
 
-                       if (two_digit_year <= twodigitcutoff)
-                               return cutoff - twodigitcutoff + two_digit_year;
+                       if (shortYear <= twodigitcutoff)
+                               return cutoff - twodigitcutoff + shortYear;
                        else
-                               return cutoff - twodigitcutoff - 100 + two_digit_year;
+                               return cutoff - twodigitcutoff - 100 + shortYear;
                }
 
                [DefaultValue (false)]
@@ -175,16 +175,16 @@ namespace System.Web.UI.WebControls
                        return Convert(text, type, cultureInvariant, out value);
                }
 
-               protected static bool Compare (string left, 
+               protected static bool Compare (string leftText
                                               bool cultureInvariantLeftText, 
-                                              string right, 
+                                              string rightText
                                               bool cultureInvariantRightText, 
                                               ValidationCompareOperator op, 
                                               ValidationDataType type)
                {
                        object lo, ro;
 
-                       if (!Convert(left, type, cultureInvariantLeftText, out lo))
+                       if (!Convert(leftText, type, cultureInvariantLeftText, out lo))
                                return false;
 
                        /* DataTypeCheck is a unary operator that only
@@ -195,7 +195,7 @@ namespace System.Web.UI.WebControls
                        /* pretty crackladen, but if we're unable to
                         * convert the rhs to @type, the comparison
                         * succeeds */
-                       if (!Convert(right, type, cultureInvariantRightText, out ro))
+                       if (!Convert(rightText, type, cultureInvariantRightText, out ro))
                                return true;
 
                        int comp = ((IComparable)lo).CompareTo((IComparable)ro);
index 5b30e41aa85a66b2e5385f0f11066f547ad5ea3d..77a24f745094f5fd9e3d1ccb5a5f29f4bd143b1c 100644 (file)
@@ -287,13 +287,13 @@ namespace System.Web.UI.WebControls
                        return o.ToString ();
                }
 
-               public static PropertyDescriptor GetValidationProperty (object o)
+               public static PropertyDescriptor GetValidationProperty (object component)
                {
                        PropertyDescriptorCollection props;
                        System.ComponentModel.AttributeCollection col;
 
-                       props = TypeDescriptor.GetProperties (o);
-                       col = TypeDescriptor.GetAttributes (o);
+                       props = TypeDescriptor.GetProperties (component);
+                       col = TypeDescriptor.GetAttributes (component);
 
                        foreach (Attribute at in col) {
                                ValidationPropertyAttribute vpa = at as ValidationPropertyAttribute;
index 8f067835b7533cb476d588ed2649d532d8e51654..acfb922daefe36502384de9b70617980e217afda 100644 (file)
@@ -186,12 +186,12 @@ namespace System.Web.UI.WebControls
                        get { return true; }
                }
                
-               protected virtual string FormatDataValue (object value, bool encode)
+               protected virtual string FormatDataValue (object dataValue, bool encode)
                {
                        string res;
                        bool htmlEncodeFormatString = HtmlEncodeFormatString;
-                       string stringValue = (value != null) ? value.ToString () : String.Empty;
-                       if (value == null || (stringValue.Length == 0 && ConvertEmptyStringToNull)) {
+                       string stringValue = (dataValue != null) ? dataValue.ToString () : String.Empty;
+                       if (dataValue == null || (stringValue.Length == 0 && ConvertEmptyStringToNull)) {
                                if (NullDisplayText.Length == 0) {
                                        encode = false;
                                        res = "&nbsp;";
@@ -201,7 +201,7 @@ namespace System.Web.UI.WebControls
                                string format = DataFormatString;
                                if (!String.IsNullOrEmpty (format)) {
                                        if (!encode || htmlEncodeFormatString)
-                                               res = String.Format (format, value);
+                                               res = String.Format (format, dataValue);
                                        else
                                                res = String.Format (format, encode ? HttpUtility.HtmlEncode (stringValue) : stringValue);
                                } else
index 30c1827bea938540395d32ffb49ae3757d91d961..fd0f857bb615e68cc90bf6bdeae74cad5386d01d 100644 (file)
@@ -107,14 +107,14 @@ namespace System.Web.UI.WebControls
                        return base.Initialize (sortingEnabled, control);
                }
                
-               protected virtual string FormatDataTextValue (object value)
+               protected virtual string FormatDataTextValue (object dataTextValue)
                {
                        if (DataTextFormatString.Length > 0)
-                               return String.Format (DataTextFormatString, value);
-                       else if (value == null)
+                               return String.Format (DataTextFormatString, dataTextValue);
+                       else if (dataTextValue == null)
                                return String.Empty;
                        else
-                               return value.ToString ();
+                               return dataTextValue.ToString ();
                }
                
                public override void InitializeCell (DataControlFieldCell cell, DataControlCellType cellType, DataControlRowState rowState, int rowIndex)
index 5f67b35db343e39b6a9969ce331839607fb54a1c..1f7f7da5b0d19e6df524381bad568f7077e9202d 100644 (file)
@@ -542,24 +542,24 @@ namespace System.Web.UI.WebControls
                        RaisePostBackEvent (eventArgument);
                }
 
-               protected virtual void RaisePostBackEvent (string arg)
+               protected virtual void RaisePostBackEvent (string eventArgument)
                {
-                       ValidateEvent (UniqueID, arg);
-                       if (arg.Length < 1)
+                       ValidateEvent (UniqueID, eventArgument);
+                       if (eventArgument.Length < 1)
                                return;
 
-                       if (arg[0] == 'V') { // Goes to Next or Previous month
+                       if (eventArgument[0] == 'V') { // Goes to Next or Previous month
                                DateTime prev = VisibleDate;
-                               int days = Int32.Parse (arg.Substring (1));
+                               int days = Int32.Parse (eventArgument.Substring (1));
                                DateTime dt = GetGlobalCalendar().AddDays (dateZenith, days);
                                VisibleDate = dt;
                                OnVisibleMonthChanged (VisibleDate, prev);
                                return;
                        }
 
-                       if (arg[0] == 'R') { // Selects a range of dates
+                       if (eventArgument[0] == 'R') { // Selects a range of dates
                                string num, date, days;
-                               num = arg.Substring (1);
+                               num = eventArgument.Substring (1);
                                days = num.Substring (num.Length - 2, 2);
                                date = num.Substring (0, num.Length - 2);
                                DateTime d = GetGlobalCalendar().AddDays (dateZenith, Int32.Parse (date));
@@ -569,7 +569,7 @@ namespace System.Web.UI.WebControls
                        }
 
                        // Selects a single day
-                       int daysFromZenith = Int32.Parse (arg);
+                       int daysFromZenith = Int32.Parse (eventArgument);
                        DateTime day = GetGlobalCalendar().AddDays (dateZenith, daysFromZenith);
                        SelectedDates.SelectRange (day, day);
                        OnSelectionChanged ();
index 27c3a7fb9dc870f7018c9a6956ef0871173ecb54..7579eb9428c1fe94ec2614a669d07759c04f0d01 100644 (file)
@@ -304,7 +304,7 @@ namespace System.Web.UI.WebControls
                        return false;
                }
 
-               protected internal override void Render (HtmlTextWriter w)
+               protected internal override void Render (HtmlTextWriter writer)
                {
                        Page page = Page;
                        if (page != null) {
@@ -318,38 +318,38 @@ namespace System.Web.UI.WebControls
                                if (!RenderingCompatibilityLessThan40)
                                        ControlStyle.PrependCssClass (DisabledCssClass);
                                else
-                                       w.AddAttribute (HtmlTextWriterAttribute.Disabled, "disabled", false);
+                                       writer.AddAttribute (HtmlTextWriterAttribute.Disabled, "disabled", false);
                                need_span = true;
                        }
 
                        if (need_span) {
-                               AddDisplayStyleAttribute (w);
-                               ControlStyle.AddAttributesToRender (w, this);
+                               AddDisplayStyleAttribute (writer);
+                               ControlStyle.AddAttributesToRender (writer, this);
                        }
                        
                        string tt = ToolTip;
                        if (tt != null && tt.Length > 0){
-                               w.AddAttribute ("title", tt);
+                               writer.AddAttribute ("title", tt);
                                need_span = true;
                        }
 
-                       if (HasAttributes && AddAttributesForSpan (w))
+                       if (HasAttributes && AddAttributesForSpan (writer))
                                need_span = true;
                        
                        if (need_span)
-                               w.RenderBeginTag (HtmlTextWriterTag.Span);
+                               writer.RenderBeginTag (HtmlTextWriterTag.Span);
 
                        TextAlign align = TextAlign;
                        if (align == TextAlign.Right) {
-                               RenderInput (w, enabled);
-                               RenderLabel (w);
+                               RenderInput (writer, enabled);
+                               RenderLabel (writer);
                        } else {
-                               RenderLabel (w);
-                               RenderInput (w, enabled);
+                               RenderLabel (writer);
+                               RenderInput (writer, enabled);
                        }
 
                        if (need_span)
-                               w.RenderEndTag ();
+                               writer.RenderEndTag ();
                }
 
                void RenderInput (HtmlTextWriter w, bool enabled)
index 207a32319b994ce974f7d2c8e5586f807b23e32c..f9015f2ef0362be0811458df90f5ce152bd14463 100644 (file)
@@ -43,7 +43,7 @@ namespace System.Web.UI.WebControls
                {
                }
 
-               protected override void AddAttributesToRender (HtmlTextWriter w)
+               protected override void AddAttributesToRender (HtmlTextWriter writer)
                {
                        if (RenderUplevel) {
                                RegisterExpandoAttribute (ClientID, "evaluationfunction", "CompareValidatorEvaluateIsValid");
@@ -54,7 +54,7 @@ namespace System.Web.UI.WebControls
                                RegisterExpandoAttribute (ClientID, "operator", Operator.ToString ());
                        }
 
-                       base.AddAttributesToRender (w);
+                       base.AddAttributesToRender (writer);
                }
 
                protected override bool ControlPropertiesValid ()
index 88614e2a1b4573ffb1cc99d3363d9edc0abccc08..beeaf5365653a4b2301a934cd79a67f4f357e7ea 100644 (file)
@@ -53,12 +53,12 @@ namespace System.Web.UI.WebControls
                        base.DataBind();
                }
 
-               protected internal override void Render (HtmlTextWriter w)
+               protected internal override void Render (HtmlTextWriter writer)
                {
                        /* make sure all the child controls have been created */
                        EnsureChildControls ();
                        /* and then... */
-                       base.Render (w);
+                       base.Render (writer);
                }
 
                void ICompositeControlDesignerAccessor.RecreateChildControls ()
index a94d6a3560a4fe70fba7fd8e998bf286958ef155..fe82e5895a6b80231e8aceae07f12ef2decdf9e5 100644 (file)
@@ -78,7 +78,7 @@ namespace System.Web.UI.WebControls
                        return new ControlParameter (this);
                }
                protected internal
-               override object Evaluate (HttpContext ctx, Control control)
+               override object Evaluate (HttpContext context, Control control)
                {
                        if (control == null)
                                return null;
index be5171213f371dd52366709a39314c99b3801f99..1b7b3e3f474fbbddd186f323f08d74af1e7851ec 100644 (file)
@@ -68,12 +68,12 @@ namespace System.Web.UI.WebControls
                        return new CookieParameter (this);
                }
                protected internal
-               override object Evaluate (HttpContext ctx, Control control)
+               override object Evaluate (HttpContext context, Control control)
                {
-                       if (ctx == null || ctx.Request == null)
+                       if (context == null || context.Request == null)
                                return null;
                        
-                       HttpCookie c = ctx.Request.Cookies [CookieName];
+                       HttpCookie c = context.Request.Cookies [CookieName];
                        if (c == null)
                                return null;
                        
index 2335873bddc2c1befd8eb7bc0b805dde2c7aa866..4865a5cb55e3d39802c8d2e51eb67bd0b7fde813 100644 (file)
@@ -36,13 +36,13 @@ namespace System.Web.UI.WebControls
        {
                DataControlField containerField;
                
-               public DataControlFieldCell (DataControlField containerField) : this (HtmlTextWriterTag.Td, containerField)
+               public DataControlFieldCell (DataControlField containingField) : this (HtmlTextWriterTag.Td, containingField)
                {               
                }
                
-               protected DataControlFieldCell (HtmlTextWriterTag tagKey, DataControlField containerField) : base (tagKey)
+               protected DataControlFieldCell (HtmlTextWriterTag tagKey, DataControlField containingField) : base (tagKey)
                {
-                       this.containerField = containerField;
+                       this.containerField = containingField;
                }
 
                public DataControlField ContainingField {
index 080ebcf5f28a660f37be53938a2f70953e8bb359..cd4fd52bc92dc528f32c116456b8dcae3cbe4cea 100644 (file)
@@ -94,8 +94,8 @@ namespace System.Web.UI.WebControls
                }
                
                [Browsable (false)]
-               public DataControlField this [int i] {
-                       get { return (DataControlField) ((IList)this) [i]; }
+               public DataControlField this [int index] {
+                       get { return (DataControlField) ((IList)this) [index]; }
                }
 
                protected override void OnInsertComplete (int index, object value)
index 2d2d958e588b2af9632b46f3272286655991fd31..6911a856791485f6f348b1fa1eda3435a360f9ed 100644 (file)
@@ -35,7 +35,7 @@ namespace System.Web.UI.WebControls
        {
                TableHeaderScope scope;
                
-               public DataControlFieldHeaderCell (DataControlField containerField): base (HtmlTextWriterTag.Th, containerField)
+               public DataControlFieldHeaderCell (DataControlField containingField): base (HtmlTextWriterTag.Th, containingField)
                {
                }
                
index c87a6b05e9affdf52e068f2d246791bf978621c0..1567f25d0d2222b7701a069adc3963dc9c51e214 100644 (file)
@@ -83,15 +83,15 @@ namespace System.Web.UI.WebControls
                #endregion      // IDataItemContainer Properties
 
                #region Public Instance Methods
-               protected override bool OnBubbleEvent(object source, EventArgs args)
+               protected override bool OnBubbleEvent(object source, EventArgs e)
                {
                        // Nikhil Kothari, pg 312-313:
-                       if (args is CommandEventArgs) {
-                               RaiseBubbleEvent(this, new DataGridCommandEventArgs(this, source, (CommandEventArgs)args));
+                       if (e is CommandEventArgs) {
+                               RaiseBubbleEvent(this, new DataGridCommandEventArgs(this, source, (CommandEventArgs)e));
                                return true;
                        }
 
-                       return base.OnBubbleEvent (source, args);
+                       return base.OnBubbleEvent (source, e);
                }
 
                protected internal virtual void SetItemType(ListItemType itemType)
index 347671436853274b9013b0855bc4da7278e7bb80..2b721dd3af37ff24d87d4efd8f77e019d359f4e0 100644 (file)
@@ -120,17 +120,17 @@ namespace System.Web.UI.WebControls
                        
                        return true;
                }
-               protected virtual void LoadViewState (object savedState)
+               protected virtual void LoadViewState (object state)
                {
-                       if (savedState is Pair) {
-                               Pair p = (Pair) savedState;
+                       if (state is Pair) {
+                               Pair p = (Pair) state;
                                object[] akeys = (object[]) p.First;
                                object[] avals = (object[]) p.Second;
                                for (int n=0; n<akeys.Length; n++) {
                                        keyTable [akeys[n]] = avals [n];
                                }
-                       } else if (savedState is object[]) {
-                               object[] avals = (object[]) savedState;
+                       } else if (state is object[]) {
+                               object[] avals = (object[]) state;
                                for (int n=0; n<avals.Length; n++)
                                        keyTable [keyNames[n]] = avals [n];
                        }
index b007474c550997c5dd73a059a672cc6d51c5e196..af981d0994395f7fb944f5e24164f85185df9482 100644 (file)
@@ -1109,24 +1109,24 @@ namespace System.Web.UI.WebControls
                        return style;
                }
                
-               protected override int CreateChildControls (IEnumerable data, bool dataBinding)
+               protected override int CreateChildControls (IEnumerable dataSource, bool dataBinding)
                {
-                       PagedDataSource dataSource = new PagedDataSource ();
-                       dataSource.DataSource = CurrentMode != DetailsViewMode.Insert ? data : null;
-                       dataSource.AllowPaging = AllowPaging;
-                       dataSource.PageSize = 1;
-                       dataSource.CurrentPageIndex = PageIndex;
+                       PagedDataSource pagedDataSource = new PagedDataSource ();
+                       pagedDataSource.DataSource = CurrentMode != DetailsViewMode.Insert ? dataSource : null;
+                       pagedDataSource.AllowPaging = AllowPaging;
+                       pagedDataSource.PageSize = 1;
+                       pagedDataSource.CurrentPageIndex = PageIndex;
 
                        if (dataBinding && CurrentMode != DetailsViewMode.Insert) {
                                DataSourceView view = GetData ();
                                if (view != null && view.CanPage) {
-                                       dataSource.AllowServerPaging = true;
+                                       pagedDataSource.AllowServerPaging = true;
                                        if (SelectArguments.RetrieveTotalRowCount)
-                                               dataSource.VirtualCount = SelectArguments.TotalRowCount;
+                                               pagedDataSource.VirtualCount = SelectArguments.TotalRowCount;
                                }
                        }
 
-                       bool showPager = AllowPaging && (dataSource.PageCount > 1);
+                       bool showPager = AllowPaging && (pagedDataSource.PageCount > 1);
 
                        Controls.Clear ();
                        table = CreateTable ();
@@ -1140,19 +1140,19 @@ namespace System.Web.UI.WebControls
                        // Gets the current data item
 
                        if (AllowPaging) {
-                               PageCount = dataSource.DataSourceCount;
+                               PageCount = pagedDataSource.DataSourceCount;
                                if (PageIndex >= PageCount && PageCount > 0)
-                                       pageIndex = dataSource.CurrentPageIndex = PageCount - 1;
-                               if (dataSource.DataSource != null) {
-                                       IEnumerator e = dataSource.GetEnumerator ();
+                                       pageIndex = pagedDataSource.CurrentPageIndex = PageCount - 1;
+                               if (pagedDataSource.DataSource != null) {
+                                       IEnumerator e = pagedDataSource.GetEnumerator ();
                                        if (e.MoveNext ())
                                                dataItem = e.Current;
                                }
                        } else {
                                int page = 0;
                                object lastItem = null;
-                               if (dataSource.DataSource != null) {
-                                       IEnumerator e = dataSource.GetEnumerator ();
+                               if (pagedDataSource.DataSource != null) {
+                                       IEnumerator e = pagedDataSource.GetEnumerator ();
                                        for (; e.MoveNext (); page++) {
                                                lastItem = e.Current;
                                                if (page == PageIndex)
@@ -1202,7 +1202,7 @@ namespace System.Web.UI.WebControls
                                if (showPager && PagerSettings.Position == PagerPosition.Top ||
                                                PagerSettings.Position == PagerPosition.TopAndBottom) {
                                        topPagerRow = CreateRow (-1, DataControlRowType.Pager, DataControlRowState.Normal);
-                                       InitializePager (topPagerRow, dataSource);
+                                       InitializePager (topPagerRow, pagedDataSource);
                                        table.Rows.Add (topPagerRow);
                                }
 
@@ -1229,7 +1229,7 @@ namespace System.Web.UI.WebControls
                                if (showPager && PagerSettings.Position == PagerPosition.Bottom ||
                                                PagerSettings.Position == PagerPosition.TopAndBottom) {
                                        bottomPagerRow = CreateRow (-1, DataControlRowType.Pager, DataControlRowState.Normal);
-                                       InitializePager (bottomPagerRow, dataSource);
+                                       InitializePager (bottomPagerRow, pagedDataSource);
                                        table.Rows.Add (bottomPagerRow);
                                }
                        }
@@ -1268,7 +1268,7 @@ namespace System.Web.UI.WebControls
                        return rstate;
                }
                
-               protected virtual void InitializePager (DetailsViewRow row, PagedDataSource dataSource)
+               protected virtual void InitializePager (DetailsViewRow row, PagedDataSource pagedDataSource)
                {
                        TableCell cell = new TableCell ();
                        cell.ColumnSpan = 2;
@@ -1276,7 +1276,7 @@ namespace System.Web.UI.WebControls
                        if (pagerTemplate != null)
                                pagerTemplate.InstantiateIn (cell);
                        else
-                               cell.Controls.Add (PagerSettings.CreatePagerControl (dataSource.CurrentPageIndex, dataSource.PageCount));
+                               cell.Controls.Add (PagerSettings.CreatePagerControl (pagedDataSource.CurrentPageIndex, pagedDataSource.PageCount));
                        
                        row.Cells.Add (cell);
                }
@@ -1349,7 +1349,7 @@ namespace System.Web.UI.WebControls
                        return dic;
                }
                
-               protected virtual void ExtractRowValues (IOrderedDictionary fieldValues, bool includeReadOnlyFields, bool includePrimaryKey)
+               protected virtual void ExtractRowValues (IOrderedDictionary fieldValues, bool includeReadOnlyFields, bool includeKeys)
                {
                        foreach (DetailsViewRow row in Rows) {
                                if (row.Cells.Count < 1)
@@ -1358,7 +1358,7 @@ namespace System.Web.UI.WebControls
                                if (c != null)
                                        c.ContainingField.ExtractValuesFromCell (fieldValues, c, row.RowState, includeReadOnlyFields);
                        }
-                       if (!includePrimaryKey && DataKeyNames != null)
+                       if (!includeKeys && DataKeyNames != null)
                                foreach (string key in DataKeyNames)
                                        fieldValues.Remove (key);
                }
@@ -1595,9 +1595,9 @@ namespace System.Web.UI.WebControls
                        }
                }
                public
-               void SetPageIndex (int newIndex)
+               void SetPageIndex (int index)
                {
-                       DetailsViewPageEventArgs args = new DetailsViewPageEventArgs (newIndex);
+                       DetailsViewPageEventArgs args = new DetailsViewPageEventArgs (index);
                        OnPageIndexChanging (args);
 
                        if (args.Cancel || !IsBoundUsingDataSourceID)
@@ -1764,11 +1764,11 @@ namespace System.Web.UI.WebControls
                        RequireBinding ();
                }
 
-               protected internal override void LoadControlState (object ob)
+               protected internal override void LoadControlState (object savedState)
                {
-                       if (ob == null)
+                       if (savedState == null)
                                return;
-                       object[] state = (object[]) ob;
+                       object[] state = (object[]) savedState;
                        base.LoadControlState (state[0]);
                        pageIndex = (int) state[1];
                        pageCount = (int) state[2];
@@ -1900,14 +1900,14 @@ namespace System.Web.UI.WebControls
                                ControlStyle.LoadViewState (states [12]);
                }
                
-               void ICallbackEventHandler.RaiseCallbackEvent (string eventArgs)
+               void ICallbackEventHandler.RaiseCallbackEvent (string eventArgument)
                {
-                       RaiseCallbackEvent (eventArgs);
+                       RaiseCallbackEvent (eventArgument);
                }
                
-               protected virtual void RaiseCallbackEvent (string eventArgs)
+               protected virtual void RaiseCallbackEvent (string eventArgument)
                {
-                       string[] clientData = eventArgs.Split ('|');
+                       string[] clientData = eventArgument.Split ('|');
                        PageIndex = int.Parse (clientData[0]);
                        
                        RaisePostBackEvent (clientData[1]);
index ac971e52f8b86a337960c6ce01aee29921db2d58..696c91fbafe981f9b6a81d3f868607854c7e484b 100644 (file)
@@ -39,9 +39,9 @@ namespace System.Web.UI.WebControls
                IOrderedDictionary keys;
                IOrderedDictionary values;
                
-               public DetailsViewDeleteEventArgs (int index)
+               public DetailsViewDeleteEventArgs (int rowIndex)
                {
-                       this.rowIndex = index;
+                       this.rowIndex = rowIndex;
                }
                
                internal DetailsViewDeleteEventArgs (int index, IOrderedDictionary keys, IOrderedDictionary values)
index 1a29e6b045d8ba0558294816045949fc62d9f9aa..654dd36836c2cbde5e11ba36c8966fd7ba48c6c1 100644 (file)
@@ -38,9 +38,9 @@ namespace System.Web.UI.WebControls
                object argument;
                IOrderedDictionary values;
                
-               public DetailsViewInsertEventArgs (object argument)
+               public DetailsViewInsertEventArgs (object commandArgument)
                {
-                       this.argument = argument;
+                       this.argument = commandArgument;
                }
                
                internal DetailsViewInsertEventArgs (object argument, IOrderedDictionary values)
index 40ac132b2e81dfdd6720731aee7492048f1123a5..f238754ff61b66eb343624c156748e5b2ce3e0ef 100644 (file)
@@ -42,8 +42,8 @@ namespace System.Web.UI.WebControls
                        this.rows = rows;
                }
                
-               public DetailsViewRow this [int i] {
-                       get { return (DetailsViewRow) rows [i]; }
+               public DetailsViewRow this [int index] {
+                       get { return (DetailsViewRow) rows [index]; }
                }
                
                public void CopyTo (DetailsViewRow[] array, int index)
index 3565e6d7f57977d9e9f2b90971ab650ab64a4f2b..ae3c193c23ef8ffe23855354c8b815e6e1cb396e 100644 (file)
@@ -39,9 +39,9 @@ namespace System.Web.UI.WebControls
                IOrderedDictionary newValues;
                IOrderedDictionary oldValues;
                
-               public DetailsViewUpdateEventArgs (object argument)
+               public DetailsViewUpdateEventArgs (object commandArgument)
                {
-                       this.argument = argument;
+                       this.argument = commandArgument;
                }
                
                internal DetailsViewUpdateEventArgs (object argument, IOrderedDictionary keys, IOrderedDictionary oldValues, IOrderedDictionary newValues)
index 20857a14abd383b78b246ab655901a85e2d7c543..7282dd10f27f16f1601866f7de7676a5d99402bc 100644 (file)
@@ -204,12 +204,12 @@ namespace System.Web.UI.WebControls
                        return new FontUnit (n);
                }
 
-               public string ToString (IFormatProvider fmt)
+               public string ToString (IFormatProvider formatProvider)
                {
                        if (type == FontSize.NotSet)
                                return String.Empty;
                        else if (type == FontSize.AsUnit)
-                               return unit.ToString (fmt);
+                               return unit.ToString (formatProvider);
                        else
                                return font_size_names [(int) type];
                }
index 3e6711bb8d4111b17f94299344d0fe3c65804f77..56ad7b4a1dfd4b77986f0b0c24119ed88e7041ce 100644 (file)
@@ -68,9 +68,9 @@ namespace System.Web.UI.WebControls
                        return new FormParameter (this);
                }
                protected internal
-               override object Evaluate (HttpContext ctx, Control control)
+               override object Evaluate (HttpContext context, Control control)
                {
-                       HttpRequest req = ctx != null ? ctx.Request : null;
+                       HttpRequest req = context != null ? context.Request : null;
                        if (req == null)
                                return null;
                        
index 55decb19cab8956616cca87da85a38ecc6aa59eb..082c31ed0a6032a14c51d332e52939b569735f72 100644 (file)
@@ -882,12 +882,12 @@ namespace System.Web.UI.WebControls
                        return arg;
                }
                
-               protected virtual FormViewRow CreateRow (int rowIndex, DataControlRowType rowType, DataControlRowState rowState)
+               protected virtual FormViewRow CreateRow (int itemIndex, DataControlRowType rowType, DataControlRowState rowState)
                {
                        if (rowType == DataControlRowType.Pager)
-                               return new FormViewPagerRow (rowIndex, rowType, rowState);
+                               return new FormViewPagerRow (itemIndex, rowType, rowState);
                        else
-                               return new FormViewRow (rowIndex, rowType, rowState);
+                               return new FormViewRow (itemIndex, rowType, rowState);
                }
                
                void RequireBinding ()
@@ -922,25 +922,25 @@ namespace System.Web.UI.WebControls
                        return style;
                }
                
-               protected override int CreateChildControls (IEnumerable data, bool dataBinding)
+               protected override int CreateChildControls (IEnumerable dataSource, bool dataBinding)
                {
-                       PagedDataSource dataSource = new PagedDataSource ();
-                       dataSource.DataSource = CurrentMode != FormViewMode.Insert ? data : null;
-                       dataSource.AllowPaging = AllowPaging;
-                       dataSource.PageSize = 1;
-                       dataSource.CurrentPageIndex = PageIndex;
+                       PagedDataSource pagedDataSource = new PagedDataSource ();
+                       pagedDataSource.DataSource = CurrentMode != FormViewMode.Insert ? dataSource : null;
+                       pagedDataSource.AllowPaging = AllowPaging;
+                       pagedDataSource.PageSize = 1;
+                       pagedDataSource.CurrentPageIndex = PageIndex;
 
                        if (dataBinding && CurrentMode != FormViewMode.Insert) {
                                DataSourceView view = GetData ();
                                if (view != null && view.CanPage) {
-                                       dataSource.AllowServerPaging = true;
+                                       pagedDataSource.AllowServerPaging = true;
                                        if (SelectArguments.RetrieveTotalRowCount)
-                                               dataSource.VirtualCount = SelectArguments.TotalRowCount;
+                                               pagedDataSource.VirtualCount = SelectArguments.TotalRowCount;
                                }
                        }
 
                        PagerSettings pagerSettings = PagerSettings;
-                       bool showPager = AllowPaging && pagerSettings.Visible && (dataSource.PageCount > 1);
+                       bool showPager = AllowPaging && pagerSettings.Visible && (pagedDataSource.PageCount > 1);
                        
                        Controls.Clear ();
                        table = CreateTable ();
@@ -953,20 +953,20 @@ namespace System.Web.UI.WebControls
                        // Gets the current data item
 
                        if (AllowPaging) {
-                               PageCount = dataSource.DataSourceCount;
+                               PageCount = pagedDataSource.DataSourceCount;
                                if (PageIndex >= PageCount && PageCount > 0)
-                                       pageIndex = dataSource.CurrentPageIndex = PageCount - 1;
+                                       pageIndex = pagedDataSource.CurrentPageIndex = PageCount - 1;
                                
-                               if (dataSource.DataSource != null) {
-                                       IEnumerator e = dataSource.GetEnumerator ();
+                               if (pagedDataSource.DataSource != null) {
+                                       IEnumerator e = pagedDataSource.GetEnumerator ();
                                        if (e.MoveNext ())
                                                dataItem = e.Current;
                                }
                        } else {
                                int page = 0;
                                object lastItem = null;
-                               if (dataSource.DataSource != null) {
-                                       IEnumerator e = dataSource.GetEnumerator ();
+                               if (pagedDataSource.DataSource != null) {
+                                       IEnumerator e = pagedDataSource.GetEnumerator ();
                                        for (; e.MoveNext (); page++) {
                                                lastItem = e.Current;
                                                if (page == PageIndex)
@@ -991,7 +991,7 @@ namespace System.Web.UI.WebControls
 
                        if (showPager && pagerSettings.Position == PagerPosition.Top || pagerSettings.Position == PagerPosition.TopAndBottom) {
                                topPagerRow = CreateRow (-1, DataControlRowType.Pager, DataControlRowState.Normal);
-                               InitializePager (topPagerRow, dataSource);
+                               InitializePager (topPagerRow, pagedDataSource);
                                table.Rows.Add (topPagerRow);
                        }
 
@@ -1024,7 +1024,7 @@ namespace System.Web.UI.WebControls
                        
                        if (showPager && pagerSettings.Position == PagerPosition.Bottom || pagerSettings.Position == PagerPosition.TopAndBottom) {
                                bottomPagerRow = CreateRow (0, DataControlRowType.Pager, DataControlRowState.Normal);
-                               InitializePager (bottomPagerRow, dataSource);
+                               InitializePager (bottomPagerRow, pagedDataSource);
                                table.Rows.Add (bottomPagerRow);
                        }
 
@@ -1046,7 +1046,7 @@ namespace System.Web.UI.WebControls
                        return rstate;
                }
                
-               protected virtual void InitializePager (FormViewRow row, PagedDataSource dataSource)
+               protected virtual void InitializePager (FormViewRow row, PagedDataSource pagedDataSource)
                {
                        TableCell cell = new TableCell ();
                        cell.ColumnSpan = 2;
@@ -1054,7 +1054,7 @@ namespace System.Web.UI.WebControls
                        if (pagerTemplate != null)
                                pagerTemplate.InstantiateIn (cell);
                        else
-                               cell.Controls.Add (PagerSettings.CreatePagerControl (dataSource.CurrentPageIndex, dataSource.PageCount));
+                               cell.Controls.Add (PagerSettings.CreatePagerControl (pagedDataSource.CurrentPageIndex, pagedDataSource.PageCount));
                        
                        row.Cells.Add (cell);
                }
@@ -1497,10 +1497,10 @@ namespace System.Web.UI.WebControls
                        RequireBinding ();
                }
 
-               protected internal override void LoadControlState (object ob)
+               protected internal override void LoadControlState (object savedState)
                {
-                       if (ob == null) return;
-                       object[] state = (object[]) ob;
+                       if (savedState == null) return;
+                       object[] state = (object[]) savedState;
                        base.LoadControlState (state[0]);
                        pageIndex = (int) state[1];
                        pageCount = (int) state[2];
index 7e36a716d38b7e21a7c882c86a5792dee7770acc..d74cd37b7515925cf78c243a69865586a00df651 100644 (file)
@@ -34,9 +34,9 @@ namespace System.Web.UI.WebControls
        {
                object source;
                
-               public FormViewCommandEventArgs (object source, CommandEventArgs arguments) : base (arguments)
+               public FormViewCommandEventArgs (object commandSource, CommandEventArgs originalArgs) : base (originalArgs)
                {
-                       this.source = source;
+                       this.source = commandSource;
                }
                
                public object CommandSource {
index 5b5d8593b66b3a284d30e559371a2aac9b919c12..eac224b6cca2b0a0b98f103c8adc22442113c8a6 100644 (file)
@@ -39,9 +39,9 @@ namespace System.Web.UI.WebControls
                IOrderedDictionary keys;
                IOrderedDictionary values;
                
-               public FormViewDeleteEventArgs (int index)
+               public FormViewDeleteEventArgs (int rowIndex)
                {
-                       this.rowIndex = index;
+                       this.rowIndex = rowIndex;
                }
                
                internal FormViewDeleteEventArgs (int index, IOrderedDictionary keys, IOrderedDictionary values) 
index ce90ee92398139e7c05f2e4155819aaa2a0fdaa0..c189c852341208dee3ffcaf61ce678eb39269888 100644 (file)
@@ -38,9 +38,9 @@ namespace System.Web.UI.WebControls
                object argument;
                IOrderedDictionary values;
                
-               public FormViewInsertEventArgs (object argument)
+               public FormViewInsertEventArgs (object commandArgument)
                {
-                       this.argument = argument;
+                       this.argument = commandArgument;
                }
                
                internal FormViewInsertEventArgs (object argument, IOrderedDictionary values)
index ff8b000baaf3c863f006ad619b3aeed2a4e3288c..def2c43e5763c5bb655e0a37a4c1bb9fe5429474 100644 (file)
@@ -46,9 +46,9 @@ namespace System.Web.UI.WebControls
                        get;
                        set;
                }
-               public FormViewRow (int rowIndex, DataControlRowType rowType, DataControlRowState rowState)
+               public FormViewRow (int itemIndex, DataControlRowType rowType, DataControlRowState rowState)
                {
-                       this.rowIndex = rowIndex;
+                       this.rowIndex = itemIndex;
                        this.rowType = rowType;
                        this.rowState = rowState;
                }
index 27ce67d2703df1177e37b606214bd34d4942845a..edbf1de5b3fe87484b55106d1b2bb7fcf215c57b 100644 (file)
@@ -40,9 +40,9 @@ namespace System.Web.UI.WebControls
                IOrderedDictionary oldValues;
                IOrderedDictionary newValues;
                
-               public FormViewUpdateEventArgs (object argument)
+               public FormViewUpdateEventArgs (object commandArgument)
                {
-                       this.argument = argument;
+                       this.argument = commandArgument;
                }
                
                internal FormViewUpdateEventArgs (object argument, IOrderedDictionary keys, IOrderedDictionary oldValues, IOrderedDictionary newValues)
index 8e2695137dc52db23095d788fe99b00ddf509982..6989c73c4ce20158300ba76df6012e1cf8a8c8ff 100644 (file)
@@ -1375,44 +1375,44 @@ namespace System.Web.UI.WebControls
                        }
                }
                
-               protected override int CreateChildControls (IEnumerable data, bool dataBinding)
+               protected override int CreateChildControls (IEnumerable dataSource, bool dataBinding)
                {
                        // clear GridView
                        Controls.Clear ();
                        table = null;
                        rows = null;
 
-                       if (data == null)
+                       if (dataSource == null)
                                return 0;
 
-                       PagedDataSource dataSource;
+                       PagedDataSource pagedDataSource;
 
                        if (dataBinding) {
                                DataSourceView view = GetData ();
-                               dataSource = new PagedDataSource ();
-                               dataSource.DataSource = data;
+                               pagedDataSource = new PagedDataSource ();
+                               pagedDataSource.DataSource = dataSource;
                                
                                if (AllowPaging) {
-                                       dataSource.AllowPaging = true;
-                                       dataSource.PageSize = PageSize;
+                                       pagedDataSource.AllowPaging = true;
+                                       pagedDataSource.PageSize = PageSize;
                                        if (view.CanPage) {
-                                               dataSource.AllowServerPaging = true;
+                                               pagedDataSource.AllowServerPaging = true;
                                                if (SelectArguments.RetrieveTotalRowCount)
-                                                       dataSource.VirtualCount = SelectArguments.TotalRowCount;
+                                                       pagedDataSource.VirtualCount = SelectArguments.TotalRowCount;
                                        }
-                                       if (PageIndex >= dataSource.PageCount)
-                                               pageIndex = dataSource.PageCount - 1;
-                                       dataSource.CurrentPageIndex = PageIndex;
+                                       if (PageIndex >= pagedDataSource.PageCount)
+                                               pageIndex = pagedDataSource.PageCount - 1;
+                                       pagedDataSource.CurrentPageIndex = PageIndex;
                                }
                                
-                               PageCount = dataSource.PageCount;
+                               PageCount = pagedDataSource.PageCount;
                        } else {
-                               dataSource = new PagedDataSource ();
-                               dataSource.DataSource = data;
+                               pagedDataSource = new PagedDataSource ();
+                               pagedDataSource.DataSource = dataSource;
                                if (AllowPaging) {
-                                       dataSource.AllowPaging = true;
-                                       dataSource.PageSize = PageSize;
-                                       dataSource.CurrentPageIndex = PageIndex;
+                                       pagedDataSource.AllowPaging = true;
+                                       pagedDataSource.PageSize = PageSize;
+                                       pagedDataSource.CurrentPageIndex = PageIndex;
                                }
                        }
 
@@ -1423,7 +1423,7 @@ namespace System.Web.UI.WebControls
                        // Creates the set of fields to show
 
                        _dataEnumerator = null;
-                       ICollection fieldCollection = CreateColumns (dataSource, dataBinding);
+                       ICollection fieldCollection = CreateColumns (pagedDataSource, dataBinding);
                        int fieldCount = fieldCollection.Count;
                        DataControlField dcf;
                        DataControlField[] fields = new DataControlField [fieldCount];
@@ -1443,7 +1443,7 @@ namespace System.Web.UI.WebControls
                                enumerator = _dataEnumerator;
                                skip_first = true;
                        } else
-                               enumerator = dataSource.GetEnumerator ();
+                               enumerator = pagedDataSource.GetEnumerator ();
 
                        // Main table creation
                        Table mainTable = ContainedTable;
@@ -1469,7 +1469,7 @@ namespace System.Web.UI.WebControls
                                
                                if (list.Count == 0) {
                                        if (createPager && (PagerSettings.Position == PagerPosition.Top || PagerSettings.Position == PagerPosition.TopAndBottom)) {
-                                               topPagerRow = CreatePagerRow (fieldCount, dataSource);
+                                               topPagerRow = CreatePagerRow (fieldCount, pagedDataSource);
                                                OnRowCreated (new GridViewRowEventArgs (topPagerRow));
                                                mainTable.Rows.Add (topPagerRow);
                                                if (dataBinding) {
@@ -1527,7 +1527,7 @@ namespace System.Web.UI.WebControls
                                }
 
                                if (createPager && (PagerSettings.Position == PagerPosition.Bottom || PagerSettings.Position == PagerPosition.TopAndBottom)) {
-                                       bottomPagerRow = CreatePagerRow (fieldCount, dataSource);
+                                       bottomPagerRow = CreatePagerRow (fieldCount, pagedDataSource);
                                        OnRowCreated (new GridViewRowEventArgs (bottomPagerRow));
                                        mainTable.Rows.Add (bottomPagerRow);
                                        if (dataBinding) {
@@ -1545,7 +1545,7 @@ namespace System.Web.UI.WebControls
                                return -1;
 
                        if (AllowPaging)
-                               return dataSource.DataSourceCount;
+                               return pagedDataSource.DataSourceCount;
                        else
                                return list.Count;
                }
@@ -1586,7 +1586,7 @@ namespace System.Web.UI.WebControls
                        return row;
                }
                
-               protected virtual void InitializePager (GridViewRow row, int columnSpan, PagedDataSource dataSource)
+               protected virtual void InitializePager (GridViewRow row, int columnSpan, PagedDataSource pagedDataSource)
                {
                        TableCell cell = new TableCell ();
                        if (columnSpan > 1)
@@ -1595,7 +1595,7 @@ namespace System.Web.UI.WebControls
                        if (pagerTemplate != null)
                                pagerTemplate.InstantiateIn (cell);
                        else
-                               cell.Controls.Add (PagerSettings.CreatePagerControl (dataSource.CurrentPageIndex, dataSource.PageCount));
+                               cell.Controls.Add (PagerSettings.CreatePagerControl (pagedDataSource.CurrentPageIndex, pagedDataSource.PageCount));
                        
                        row.Cells.Add (cell);
                }
@@ -1983,9 +1983,9 @@ namespace System.Web.UI.WebControls
                        Sort (newSortExpression, newDirection);
                }
                
-               public virtual void Sort (string newSortExpression, SortDirection newSortDirection)
+               public virtual void Sort (string sortExpression, SortDirection sortDirection)
                {
-                       GridViewSortEventArgs args = new GridViewSortEventArgs (newSortExpression, newSortDirection);
+                       GridViewSortEventArgs args = new GridViewSortEventArgs (sortExpression, sortDirection);
                        OnSorting (args);
                        if (args.Cancel)
                                return;
@@ -2000,9 +2000,9 @@ namespace System.Web.UI.WebControls
                        OnSorted (EventArgs.Empty);
                }
                public
-               void SelectRow (int index)
+               void SelectRow (int rowIndex)
                {
-                       GridViewSelectEventArgs args = new GridViewSelectEventArgs (index);
+                       GridViewSelectEventArgs args = new GridViewSelectEventArgs (rowIndex);
                        OnSelectedIndexChanging (args);
                        if (!args.Cancel) {
                                RequireBinding ();
@@ -2011,9 +2011,9 @@ namespace System.Web.UI.WebControls
                        }
                }
                public
-               void SetPageIndex (int newIndex)
+               void SetPageIndex (int rowIndex)
                {
-                       GridViewPageEventArgs args = new GridViewPageEventArgs (newIndex);
+                       GridViewPageEventArgs args = new GridViewPageEventArgs (rowIndex);
                        OnPageIndexChanging (args);
                        
                        if (args.Cancel || !IsBoundUsingDataSourceID)
@@ -2024,9 +2024,9 @@ namespace System.Web.UI.WebControls
                        OnPageIndexChanged (EventArgs.Empty);
                }
                public
-               void SetEditRow (int index)
+               void SetEditRow (int rowIndex)
                {
-                       GridViewEditEventArgs args = new GridViewEditEventArgs (index);
+                       GridViewEditEventArgs args = new GridViewEditEventArgs (rowIndex);
                        OnRowEditing (args);
                        
                        if (args.Cancel || !IsBoundUsingDataSourceID)
@@ -2134,11 +2134,11 @@ namespace System.Web.UI.WebControls
                        currentEditNewValues = null;
                }
 
-               protected internal override void LoadControlState (object ob)
+               protected internal override void LoadControlState (object savedState)
                {
-                       if (ob == null)
+                       if (savedState == null)
                                return;
-                       object[] state = (object[]) ob;
+                       object[] state = (object[]) savedState;
                        base.LoadControlState (state[0]);
                        pageIndex = (int) state[1];
                        selectedIndex = (int) state[2];
@@ -2351,14 +2351,14 @@ namespace System.Web.UI.WebControls
                                ((IStateManager)sortedDescendingHeaderStyle).LoadViewState (states [15]);
                }
                
-               void ICallbackEventHandler.RaiseCallbackEvent (string eventArgs)
+               void ICallbackEventHandler.RaiseCallbackEvent (string eventArgument)
                {
-                       RaiseCallbackEvent (eventArgs);
+                       RaiseCallbackEvent (eventArgument);
                }
                
-               protected virtual void RaiseCallbackEvent (string eventArgs)
+               protected virtual void RaiseCallbackEvent (string eventArgument)
                {
-                       string[] clientData = eventArgs.Split ('|');
+                       string[] clientData = eventArgument.Split ('|');
                        PageIndex = int.Parse (clientData[0]);
                        SortExpression = HttpUtility.UrlDecode (clientData [1]);
                        SortDirection = (SortDirection) int.Parse (clientData [2]);
@@ -2384,18 +2384,18 @@ namespace System.Web.UI.WebControls
                        return sw.ToString ();
                }
 
-               string ICallbackContainer.GetCallbackScript (IButtonControl control, string argument)
+               string ICallbackContainer.GetCallbackScript (IButtonControl buttonControl, string argument)
                {
-                       return GetCallbackScript (control, argument);
+                       return GetCallbackScript (buttonControl, argument);
                }
                
-               protected virtual string GetCallbackScript (IButtonControl control, string argument)
+               protected virtual string GetCallbackScript (IButtonControl buttonControl, string argument)
                {
                        if (EnableSortingAndPagingCallbacks) {
                                Page page = Page;
                                if (page != null)
                                        page.ClientScript.RegisterForEventValidation (UniqueID, argument);
-                               return "javascript:GridView_ClientEvent (\"" + ClientID + "\",\"" + control.CommandName + "$" + control.CommandArgument + "\"); return false;";
+                               return "javascript:GridView_ClientEvent (\"" + ClientID + "\",\"" + buttonControl.CommandName + "$" + buttonControl.CommandArgument + "\"); return false;";
                        } else
                                return null;
                }
index 47a3de33f855aa36ebbdfba0017ba0f7ae02634e..e62233cf40ea0ff25b7ed1a0be99554b564a9545 100644 (file)
@@ -39,9 +39,9 @@ namespace System.Web.UI.WebControls
                IOrderedDictionary keys;
                IOrderedDictionary values;
                
-               public GridViewDeleteEventArgs (int index)
+               public GridViewDeleteEventArgs (int rowIndex)
                {
-                       this.rowIndex = index;
+                       this.rowIndex = rowIndex;
                }
                
                internal GridViewDeleteEventArgs (int index, IOrderedDictionary keys, IOrderedDictionary values)
index 257f9015fe6ff46a335f4d2f94e0ee7f3cebbba5..236f3144fa1ee75fbffe35272710d2ef4afe37e0 100644 (file)
@@ -42,8 +42,8 @@ namespace System.Web.UI.WebControls
                        this.rows = rows;
                }
                
-               public GridViewRow this [int i] {
-                       get { return (GridViewRow) rows [i]; }
+               public GridViewRow this [int index] {
+                       get { return (GridViewRow) rows [index]; }
                }
                
                public void CopyTo (GridViewRow[] array, int index)
index 664fba67bf488494f7cc9e73ada3c0d2fffec452..c8c43effa63359a90b2bb46fcdf228ac75f23c5b 100644 (file)
@@ -45,8 +45,8 @@ namespace System.Web.UI.WebControls
                        typeof (RectangleHotSpot)
                };
                                                    
-               public HotSpot this [int idx] {
-                       get { return (HotSpot) ((IList)this)[idx]; }
+               public HotSpot this [int index] {
+                       get { return (HotSpot) ((IList)this)[index]; }
                }
 
                public int Add (HotSpot spot)
@@ -54,9 +54,9 @@ namespace System.Web.UI.WebControls
                        return ((IList)this).Add (spot);
                }
                
-               protected override object CreateKnownType (int idx)
+               protected override object CreateKnownType (int index)
                {
-                       switch (idx) {
+                       switch (index) {
                                case 0:
                                        return new CircleHotSpot ();
                                case 1:
@@ -73,9 +73,9 @@ namespace System.Web.UI.WebControls
                        return _knownTypes;
                }
                
-               public void Insert (int idx, HotSpot spot)
+               public void Insert (int index, HotSpot spot)
                {
-                       ((IList)this).Insert (idx, spot);
+                       ((IList)this).Insert (index, spot);
                }
                
                protected override void OnValidate (object o)
@@ -91,9 +91,9 @@ namespace System.Web.UI.WebControls
                        ((IList)this).Remove (spot);
                }
 
-               public void RemoveAt (int idx)
+               public void RemoveAt (int index)
                {
-                       ((IList)this).RemoveAt (idx);
+                       ((IList)this).RemoveAt (index);
                }
 
                protected override void SetDirtyObject (object o)
index b90a4f0b947b60d2ed63d39668ffb4cde390d6ba..3151bbd3605d57ee488271bdfd517b7e1ebfd8c9 100644 (file)
@@ -49,19 +49,19 @@ namespace System.Web.UI.WebControls
                {
                }
                                
-               protected override void AddAttributesToRender (HtmlTextWriter w)
+               protected override void AddAttributesToRender (HtmlTextWriter writer)
                {
-                       base.AddAttributesToRender (w);
-                       AddDisplayStyleAttribute (w);
+                       base.AddAttributesToRender (writer);
+                       AddDisplayStyleAttribute (writer);
                        if (!IsEnabled)
                                return;
                        // add attributes - only if they're not empty
                        string t = Target;
                        string s = NavigateUrl;
                        if (s.Length > 0)
-                               w.AddAttribute (HtmlTextWriterAttribute.Href, ResolveClientUrl (s));
+                               writer.AddAttribute (HtmlTextWriterAttribute.Href, ResolveClientUrl (s));
                        if (t.Length > 0)
-                               w.AddAttribute (HtmlTextWriterAttribute.Target, t);
+                               writer.AddAttribute (HtmlTextWriterAttribute.Target, t);
                }
                
                protected override void AddParsedSubObject (object obj)
@@ -90,25 +90,25 @@ namespace System.Web.UI.WebControls
                        base.LoadViewState (savedState);
                }
                
-               protected internal override void RenderContents (HtmlTextWriter w)      
+               protected internal override void RenderContents (HtmlTextWriter writer) 
                {
                        if (HasControls () || HasRenderMethodDelegate ()) {
-                               base.RenderContents (w);
+                               base.RenderContents (writer);
                                return;
                        }
                        string image_url = ImageUrl;
                        if (!String.IsNullOrEmpty (image_url)) {
                                string str = ToolTip;
                                if (!String.IsNullOrEmpty (str))
-                                       w.AddAttribute (HtmlTextWriterAttribute.Title, str);
+                                       writer.AddAttribute (HtmlTextWriterAttribute.Title, str);
 
-                               w.AddAttribute (HtmlTextWriterAttribute.Src, ResolveClientUrl (image_url));
+                               writer.AddAttribute (HtmlTextWriterAttribute.Src, ResolveClientUrl (image_url));
                                str = Text;
-                                       w.AddAttribute (HtmlTextWriterAttribute.Alt, str);
-                               w.RenderBeginTag (HtmlTextWriterTag.Img);
-                               w.RenderEndTag ();
+                                       writer.AddAttribute (HtmlTextWriterAttribute.Alt, str);
+                               writer.RenderBeginTag (HtmlTextWriterTag.Img);
+                               writer.RenderEndTag ();
                        } else
-                               w.Write (Text);
+                               writer.Write (Text);
                }
 
                [Bindable(true)]
index 3a35cdb09b5d99f3f2cdb5d7b1165eca3b96df2d..904d0d913ddb6d259c69262415940f68a05c962b 100644 (file)
@@ -113,22 +113,22 @@ namespace System.Web.UI.WebControls {
                        set { ViewState ["Text"] = value; }
                }
 
-               protected virtual string FormatDataNavigateUrlValue (object value)
+               protected virtual string FormatDataNavigateUrlValue (object dataUrlValue)
                {
                        string format = DataNavigateUrlFormatString;
                        if (format == "")
                                format = null;
 
-                       return DataBinder.FormatResult (value, format);
+                       return DataBinder.FormatResult (dataUrlValue, format);
                }
 
-               protected virtual string FormatDataTextValue (object value)
+               protected virtual string FormatDataTextValue (object dataTextValue)
                {
                        string format = DataTextFormatString;
                        if (format == "")
                                format = null;
 
-                       return DataBinder.FormatResult (value, format);
+                       return DataBinder.FormatResult (dataTextValue, format);
                }
 
                public override void Initialize ()
@@ -155,11 +155,11 @@ namespace System.Web.UI.WebControls {
                        ctrl.Target = Target;
                }
 
-               public override void InitializeCell (TableCell cell, int column_index, ListItemType item_type)
+               public override void InitializeCell (TableCell cell, int columnIndex, ListItemType itemType)
                {
-                       base.InitializeCell (cell, column_index, item_type);
+                       base.InitializeCell (cell, columnIndex, itemType);
 
-                       switch (item_type)
+                       switch (itemType)
                        {
                        case ListItemType.Separator: 
                        case ListItemType.Pager:
index df9fa49da84ae59bd360949986b2bdae6a8dd5e1..982b6734f7b39cce8a319cadc92ae4ec1e133e60 100644 (file)
@@ -45,9 +45,9 @@ namespace System.Web.UI.WebControls
                PropertyDescriptor[] urlProperties;
                static string[] emptyFields;
                
-               public override bool Initialize (bool sortingEnabled, Control control)
+               public override bool Initialize (bool enableSorting, Control control)
                {
-                       return base.Initialize (sortingEnabled, control);
+                       return base.Initialize (enableSorting, control);
                }
                
                [EditorAttribute ("System.Web.UI.Design.WebControls.DataFieldEditor, " + Consts.AssemblySystem_Design, "System.Drawing.Design.UITypeEditor, " + Consts.AssemblySystem_Drawing)]
index 7b0a331483091b118b175ff869923318c6d3426d..b8cf43ae7931dce90e19af7a1b0ddf85bbeffdd9 100644 (file)
@@ -46,9 +46,9 @@ namespace System.Web.UI.WebControls {
                PropertyDescriptor imageProperty;
                PropertyDescriptor textProperty;
                
-               public override bool Initialize (bool sortingEnabled, Control control)
+               public override bool Initialize (bool enableSorting, Control control)
                {
-                       return base.Initialize (sortingEnabled, control);
+                       return base.Initialize (enableSorting, control);
                }
 
                [DefaultValueAttribute ("")]
@@ -237,14 +237,14 @@ namespace System.Web.UI.WebControls {
                        }
                }
                
-               protected virtual string FormatImageUrlValue (object value)
+               protected virtual string FormatImageUrlValue (object dataValue)
                {
-                       if (value == null)
+                       if (dataValue == null)
                                return null;
                        else if (DataImageUrlFormatString.Length > 0)
-                               return string.Format (DataImageUrlFormatString, value);
+                               return string.Format (DataImageUrlFormatString, dataValue);
                        else
-                               return value.ToString ();
+                               return dataValue.ToString ();
                }
                
                protected virtual string GetFormattedAlternateText (Control controlContainer)
index 241934632a0e22d727f304ba5311c501125d226b..c5ae39c8595577f8b52c4baade3a69cc0e6d98ea 100644 (file)
@@ -49,13 +49,13 @@ namespace System.Web.UI.WebControls
                {
                }
        
-               protected override void AddAttributesToRender (HtmlTextWriter w)
+               protected override void AddAttributesToRender (HtmlTextWriter writer)
                {
                        Page page = Page;
                        if (page != null)
                                page.VerifyRenderingInServerForm (this);
 
-                       base.AddAttributesToRender (w);
+                       base.AddAttributesToRender (writer);
                        bool enabled = IsEnabled;
                        string onclick = OnClientClick;
                        onclick = ClientScriptManager.EnsureEndsWithSemicolon (onclick);
@@ -65,15 +65,15 @@ namespace System.Web.UI.WebControls
                        }
 
                        if (onclick.Length > 0)
-                               w.AddAttribute (HtmlTextWriterAttribute.Onclick, onclick);
+                               writer.AddAttribute (HtmlTextWriterAttribute.Onclick, onclick);
                        
                        if (enabled && page != null) {
                                PostBackOptions options = GetPostBackOptions ();
                                string href = page.ClientScript.GetPostBackEventReference (options, true);
-                               w.AddAttribute (HtmlTextWriterAttribute.Href, href);
+                               writer.AddAttribute (HtmlTextWriterAttribute.Href, href);
                        }
                        
-                       AddDisplayStyleAttribute (w);
+                       AddDisplayStyleAttribute (writer);
                }
 
                protected virtual void RaisePostBackEvent (string eventArgument)
index a99a5555c2dc5865ee46042534c84e669ef38236..1dbe89198ac7690ac8229f5d26dbd8b3805220e2 100644 (file)
@@ -254,9 +254,9 @@ namespace System.Web.UI.WebControls {
                        }
                }
 
-               protected override void AddAttributesToRender (HtmlTextWriter w)
+               protected override void AddAttributesToRender (HtmlTextWriter writer)
                {
-                       base.AddAttributesToRender (w);
+                       base.AddAttributesToRender (writer);
                }
 
                public virtual void ClearSelection ()
index a37b9182f8d7f095ded5d6a5ee3a2579feaa184b..7cf08e944dbf04cadc157f1d52ad7fd3a42afb81 100644 (file)
@@ -58,9 +58,9 @@ namespace System.Web.UI.WebControls {
                {
                }
        
-               public static ListItem FromString (string text)
+               public static ListItem FromString (string s)
                {
-                       return new ListItem (text);
+                       return new ListItem (s);
                }
        
                public override bool Equals (object o)
index 7e832dec6fdc69a984d16a42dbc04b5f98dc126e..032b4d2fa9a7603d0aee3a055bf9f7555e40e53f 100644 (file)
@@ -101,12 +101,12 @@ namespace System.Web.UI.WebControls {
                }
 
                protected internal
-               override void Render (HtmlTextWriter output)
+               override void Render (HtmlTextWriter writer)
                {
                        if (Mode == LiteralMode.Encode)
-                               output.Write (HttpUtility.HtmlEncode (Text));
+                               writer.Write (HttpUtility.HtmlEncode (Text));
                        else
-                       output.Write (Text);
+                       writer.Write (Text);
                }
        }
 }
index 912f6c4f55771c1bd6a6f20152f8799744a961e6..1cfeea14f30feab7f1ed815a1a80da15b625695c 100644 (file)
@@ -1136,12 +1136,12 @@ namespace System.Web.UI.WebControls
                        return null;
                }
 
-               protected override void LoadViewState (object savedState)
+               protected override void LoadViewState (object state)
                {
-                       if (savedState == null)
+                       if (state == null)
                                return;
 
-                       object [] states = (object []) savedState;
+                       object [] states = (object []) state;
                        base.LoadViewState (states[0]);
                        
                        if (states[1] != null)
@@ -1178,10 +1178,10 @@ namespace System.Web.UI.WebControls
                        base.OnInit (e);
                }
                
-               protected internal override void LoadControlState (object ob)
+               protected internal override void LoadControlState (object savedState)
                {
-                       if (ob == null) return;
-                       object[] state = (object[]) ob;
+                       if (savedState == null) return;
+                       object[] state = (object[]) savedState;
                        base.LoadControlState (state[0]);
                        selectedItemPath = state[1] as string;
                }
@@ -1274,12 +1274,12 @@ namespace System.Web.UI.WebControls
                        base.DataBind ();
                }
                
-               protected override bool OnBubbleEvent (object source, EventArgs args)
+               protected override bool OnBubbleEvent (object source, EventArgs e)
                {
-                       if (!(args is CommandEventArgs))
+                       if (!(e is CommandEventArgs))
                                return false;
 
-                       MenuEventArgs menuArgs = args as MenuEventArgs;
+                       MenuEventArgs menuArgs = e as MenuEventArgs;
                        if (menuArgs != null && string.Equals (menuArgs.CommandName, MenuItemClickCommandName))
                                OnMenuItemClick (menuArgs);
                        return true;
index 6ed16f68b74b5c2c0c9ab8b9e30e6688373f918f..da9363a2345aaa352c2c8af605d48a291049534f 100644 (file)
@@ -68,9 +68,9 @@ namespace System.Web.UI.WebControls
                        return types;
                }
                
-               public int IndexOf (MenuItemBinding binding)
+               public int IndexOf (MenuItemBinding value)
                {
-                       return ((IList)this).IndexOf (binding);
+                       return ((IList)this).IndexOf (value);
                }
                
                public void Insert (int index, MenuItemBinding binding)
index 1bcb60e5ccc44964d48e59b7a5d158825ae64511..af6b7f6d0a5729dd42418c581541d4ab416ff740 100644 (file)
@@ -65,8 +65,8 @@ namespace System.Web.UI.WebControls
                                item.Menu = menu;
                }
                
-               public MenuItem this [int i] {
-                       get { return (MenuItem) items [i]; }
+               public MenuItem this [int index] {
+                       get { return (MenuItem) items [index]; }
                }
                
                public void Add (MenuItem child)
@@ -114,19 +114,19 @@ namespace System.Web.UI.WebControls
                        }
                }
                
-               public bool Contains (MenuItem child)
+               public bool Contains (MenuItem c)
                {
-                       return items.Contains (child);
+                       return items.Contains (c);
                }
                
-               public void CopyTo (Array itemArray, int index)
+               public void CopyTo (Array array, int index)
                {
-                       items.CopyTo (itemArray, index);
+                       items.CopyTo (array, index);
                }
                
-               public void CopyTo (MenuItem[] itemArray, int index)
+               public void CopyTo (MenuItem[] array, int index)
                {
-                       items.CopyTo (itemArray, index);
+                       items.CopyTo (array, index);
                }
                
                public IEnumerator GetEnumerator ()
@@ -134,18 +134,18 @@ namespace System.Web.UI.WebControls
                        return items.GetEnumerator ();
                }
                
-               public int IndexOf (MenuItem item)
+               public int IndexOf (MenuItem value)
                {
-                       return items.IndexOf (item);
+                       return items.IndexOf (value);
                }
                
-               public void Remove (MenuItem item)
+               public void Remove (MenuItem value)
                {
-                       int i = IndexOf (item);
+                       int i = IndexOf (value);
                        if (i == -1) return;
                        items.RemoveAt (i);
                        if (menu != null)
-                               item.Menu = null;
+                               value.Menu = null;
                        if (marked) {
                                SetDirty ();
                        }
index bf0a297256e082e9800d5aa92f902c98d6d61802..80dde584cbc43252ac13b1ef6af6a1a9337946fa 100644 (file)
@@ -53,9 +53,9 @@ namespace System.Web.UI.WebControls
                        return ((IList)this).Contains (style);
                }
                
-               public void CopyTo (MenuItemStyle[] array, int index)
+               public void CopyTo (MenuItemStyle[] styleArray, int index)
                {
-                       ((IList)this).CopyTo (array, index);
+                       ((IList)this).CopyTo (styleArray, index);
                }
                
                protected override object CreateKnownType (int index)
index a4681d9f9b5cfbd13d9aad20ed31217367301916..987f09bdf9096533699ef6eac10013a62d9e42c9 100644 (file)
@@ -40,15 +40,15 @@ namespace System.Web.UI.WebControls
                object dataItem;
                int index;
                
-               public MenuItemTemplateContainer (int itemIndex, MenuItem menuItem)
+               public MenuItemTemplateContainer (int itemIndex, MenuItem dataItem)
                {
-                       index = itemIndex;
-                       dataItem = menuItem;
+                       this.index = itemIndex;
+                       this.dataItem = dataItem;
                }
                
-               protected override bool OnBubbleEvent (object source, EventArgs args)
+               protected override bool OnBubbleEvent (object source, EventArgs e)
                {
-                       CommandEventArgs command = args as CommandEventArgs;
+                       CommandEventArgs command = e as CommandEventArgs;
                        if (command == null)
                                return false;
 
index 9c6d916fb024ab41f9db73cc8b46566aa0ece69d..faae2cee9de33124af589a9304c0e7a5b3655749 100644 (file)
@@ -59,10 +59,10 @@ namespace System.Web.UI.WebControls
                        remove { Events.RemoveHandler (ActiveViewChangedEvent, value); }
                }
                
-               protected override void AddParsedSubObject (object ob)
+               protected override void AddParsedSubObject (object obj)
                {
-                       if (ob is View)
-                               Controls.Add (ob as View);
+                       if (obj is View)
+                               Controls.Add (obj as View);
                        // LAMESPEC: msdn talks that only View contorls are allowed, for others controls HttpException should be thrown
                        // but actually, aspx praser adds LiteralControl controls.
                        //else
index 56600e995985d30a3670b7b641f3d6b3ac013aab..015c761d008078a6c1a0c6c4c2a5f684d20d6414 100644 (file)
@@ -220,15 +220,15 @@ namespace System.Web.UI.WebControls {
                        return source.GetEnumerator ();
                }
 
-               public PropertyDescriptorCollection GetItemProperties (PropertyDescriptor [] list_accessors)
+               public PropertyDescriptorCollection GetItemProperties (PropertyDescriptor [] listAccessors)
                {
                        ITypedList typed = source as ITypedList;
                        if (typed == null)
                                return null;
-                       return typed.GetItemProperties (list_accessors);
+                       return typed.GetItemProperties (listAccessors);
                }
 
-               public string GetListName (PropertyDescriptor [] list_accessors)
+               public string GetListName (PropertyDescriptor [] listAccessors)
                {
                        return String.Empty; // as documented
                }
index 6a6f99a07b2640b6c20a71ea1e476ab4b3c94bf4..9e1c41838761ad17813caa54720f29c805821de8 100644 (file)
@@ -47,14 +47,14 @@ namespace System.Web.UI.WebControls {
                {
                }
                
-               protected override void AddAttributesToRender (HtmlTextWriter w)
+               protected override void AddAttributesToRender (HtmlTextWriter writer)
                {
-                       base.AddAttributesToRender (w);
+                       base.AddAttributesToRender (writer);
                        
                        string image = BackImageUrl;
                        if (image != "") {
                                image = ResolveClientUrl (image);
-                               w.AddStyleAttribute (HtmlTextWriterStyle.BackgroundImage, image);
+                               writer.AddStyleAttribute (HtmlTextWriterStyle.BackgroundImage, image);
                        }
 
                        if (!String.IsNullOrEmpty (DefaultButton) && Page != null) {
@@ -64,32 +64,32 @@ namespace System.Web.UI.WebControls {
 
                                Page.ClientScript.RegisterWebFormClientScript ();
 
-                               w.AddAttribute ("onkeypress",
+                               writer.AddAttribute ("onkeypress",
                                                "javascript:return " + Page.WebFormScriptReference + ".WebForm_FireDefaultButton(event, '" + button.ClientID + "')");
                        }
 
                        if (Direction != ContentDirection.NotSet) {
-                               w.AddAttribute (HtmlTextWriterAttribute.Dir, Direction == ContentDirection.RightToLeft ? "rtl" : "ltr", false);
+                               writer.AddAttribute (HtmlTextWriterAttribute.Dir, Direction == ContentDirection.RightToLeft ? "rtl" : "ltr", false);
                        }
 
                        switch (ScrollBars) {
                        case ScrollBars.Auto:
-                               w.AddStyleAttribute (HtmlTextWriterStyle.Overflow, "auto");
+                               writer.AddStyleAttribute (HtmlTextWriterStyle.Overflow, "auto");
                                break;
                        case ScrollBars.Both:
-                               w.AddStyleAttribute (HtmlTextWriterStyle.Overflow, "scroll");
+                               writer.AddStyleAttribute (HtmlTextWriterStyle.Overflow, "scroll");
                                break;
                        case ScrollBars.Horizontal:
-                               w.AddStyleAttribute (HtmlTextWriterStyle.OverflowX, "scroll");
+                               writer.AddStyleAttribute (HtmlTextWriterStyle.OverflowX, "scroll");
                                break;
                        case ScrollBars.Vertical:
-                               w.AddStyleAttribute (HtmlTextWriterStyle.OverflowY, "scroll");
+                               writer.AddStyleAttribute (HtmlTextWriterStyle.OverflowY, "scroll");
                                break;
                        }
 
 
                        if (!Wrap) {
-                               w.AddStyleAttribute (HtmlTextWriterStyle.WhiteSpace, "nowrap");
+                               writer.AddStyleAttribute (HtmlTextWriterStyle.WhiteSpace, "nowrap");
                        }
 
                        string align = "";
@@ -102,7 +102,7 @@ namespace System.Web.UI.WebControls {
                        }
 
                        if (align != "")
-                               w.AddStyleAttribute (HtmlTextWriterStyle.TextAlign, align);
+                               writer.AddStyleAttribute (HtmlTextWriterStyle.TextAlign, align);
                }
                PanelStyle PanelStyle {
                        get { return (ControlStyle as PanelStyle); }
index 0fa2d56c069d4c59c67cc3e8fa33820a1244361f..92b8d4dc2786fa27d64f85be999523adbdaf5a4d 100644 (file)
@@ -50,9 +50,9 @@ namespace System.Web.UI.WebControls
                                                    
                EventHandler _parametersChanged;
 
-               public int Add (Parameter param)
+               public int Add (Parameter parameter)
                {
-                       return ((IList)this).Add (param);
+                       return ((IList)this).Add (parameter);
                }
 
                public int Add (string name, string value)
@@ -70,9 +70,9 @@ namespace System.Web.UI.WebControls
                        return ((IList)this).Add (new Parameter (name, dbType, value));
                }
                
-               protected override object CreateKnownType (int idx)
+               protected override object CreateKnownType (int index)
                {
-                       switch (idx) {
+                       switch (index) {
                        case 0:
                                return new ControlParameter ();
                        case 1:
@@ -114,9 +114,9 @@ namespace System.Web.UI.WebControls
                                param.UpdateValue (context, control);
                }
                
-               public void Insert (int idx, Parameter param)
+               public void Insert (int index, Parameter parameter)
                {
-                       ((IList)this).Insert (idx, param);
+                       ((IList)this).Insert (index, parameter);
                }
 
                protected override void OnClearComplete ()
@@ -125,15 +125,15 @@ namespace System.Web.UI.WebControls
                        OnParametersChanged (EventArgs.Empty);
                }
 
-               protected override void OnInsert (int idx, object value)
+               protected override void OnInsert (int index, object value)
                {
-                       base.OnInsert (idx, value);
+                       base.OnInsert (index, value);
                        ((Parameter)value).SetOwnerCollection (this);
                }
 
-               protected override void OnInsertComplete (int idx, object value)
+               protected override void OnInsertComplete (int index, object value)
                {
-                       base.OnInsertComplete (idx, value);
+                       base.OnInsertComplete (index, value);
                        OnParametersChanged (EventArgs.Empty);
                }
 
@@ -151,14 +151,14 @@ namespace System.Web.UI.WebControls
                                throw new ArgumentException ("o is not a Parameter");
                }
 
-               public void Remove (Parameter param)
+               public void Remove (Parameter parameter)
                {
-                       ((IList)this).Remove (param);
+                       ((IList)this).Remove (parameter);
                }
 
-               public void RemoveAt (int idx)
+               public void RemoveAt (int index)
                {
-                       ((IList)this).RemoveAt (idx);
+                       ((IList)this).RemoveAt (index);
                }
 
                protected override void SetDirtyObject (object o)
@@ -181,12 +181,12 @@ namespace System.Web.UI.WebControls
                        return -1;
                }
 
-               public Parameter this[int idx] {
+               public Parameter this[int index] {
                        get {
-                               return (Parameter) ((IList)this)[idx];
+                               return (Parameter) ((IList)this)[index];
                        }
                        set {
-                               ((IList)this)[idx] = value;
+                               ((IList)this)[index] = value;
                        }
                }
 
@@ -212,19 +212,19 @@ namespace System.Web.UI.WebControls
                        remove { _parametersChanged -= value; }
                }
 
-               public bool Contains (Parameter param)
+               public bool Contains (Parameter parameter)
                {
-                       return ((IList)this).Contains (param);
+                       return ((IList)this).Contains (parameter);
                }
 
-               public void CopyTo (Parameter[] paramArray, int index)
+               public void CopyTo (Parameter[] parameterArray, int index)
                {
-                       ((IList)this).CopyTo (paramArray, index);
+                       ((IList)this).CopyTo (parameterArray, index);
                }
 
-               public int IndexOf (Parameter param)
+               public int IndexOf (Parameter parameter)
                {
-                       return ((IList)this).IndexOf (param);
+                       return ((IList)this).IndexOf (parameter);
                }
 
                protected override void OnRemoveComplete (int index, object value)
index e6813d1eef1cfd2bec7afb8b89456e5e4d42b910..f6e0fbe1acd6f9d18f7c27b8ec9bd93b69a38ddc 100644 (file)
@@ -69,12 +69,12 @@ namespace System.Web.UI.WebControls {
                        return new QueryStringParameter (this);
                }
                protected internal
-               override object Evaluate (HttpContext ctx, Control control)
+               override object Evaluate (HttpContext context, Control control)
                {
-                       if (ctx == null || ctx.Request == null)
+                       if (context == null || context.Request == null)
                                return null;
                        
-                       return ctx.Request.QueryString [QueryStringField];
+                       return context.Request.QueryString [QueryStringField];
                }
                
                [DefaultValueAttribute ("")]
index c80ad4d105ba60e0480b0acc6c383ad4ecd1512c..5764a48930cf8fc8e447834e1c8d58235494c0b4 100644 (file)
@@ -46,7 +46,7 @@ namespace System.Web.UI.WebControls {
                {
                }
 
-               protected override void AddAttributesToRender (HtmlTextWriter w)
+               protected override void AddAttributesToRender (HtmlTextWriter writer)
                {
                        if (RenderUplevel) {
                                RegisterExpandoAttribute (ClientID, "evaluationfunction", "RegularExpressionValidatorEvaluateIsValid");
@@ -54,7 +54,7 @@ namespace System.Web.UI.WebControls {
                                        RegisterExpandoAttribute (ClientID, "validationexpression", ValidationExpression, true);
                        }
 
-                       base.AddAttributesToRender (w);
+                       base.AddAttributesToRender (writer);
                }
 
                protected override bool EvaluateIsValid ()
index 953d23981ce05e66f58043095f9ffae058bc1a88..42b5ddb8a0ad15246bb04ddf1ce93d428935ccfa 100644 (file)
@@ -39,7 +39,7 @@ namespace System.Web.UI.WebControls {
        public sealed class RepeatInfo {
 
                // What is baseControl for ?
-               public void RenderRepeater (HtmlTextWriter w, IRepeatInfoUser user, Style controlStyle, WebControl baseControl)
+               public void RenderRepeater (HtmlTextWriter writer, IRepeatInfoUser user, Style controlStyle, WebControl baseControl)
                {
                        PrintValues (user);
                        RepeatLayout layout = RepeatLayout;
@@ -60,13 +60,13 @@ namespace System.Web.UI.WebControls {
                        }
                        if (RepeatDirection == RepeatDirection.Vertical) {
                                if (listLayout)
-                                       RenderList (w, user, controlStyle, baseControl);
+                                       RenderList (writer, user, controlStyle, baseControl);
                                else
-                                       RenderVert (w, user, controlStyle, baseControl);
+                                       RenderVert (writer, user, controlStyle, baseControl);
                        } else {
                                if (listLayout)
                                                throw new InvalidOperationException ("The UnorderedList and OrderedList layouts only support vertical layout.");
-                               RenderHoriz (w, user, controlStyle, baseControl);
+                               RenderHoriz (writer, user, controlStyle, baseControl);
                        }
                }
 
index d0e5bdf645f1223840b3ed2c198fe8d74f6ed220..d57bbc9ae19bb7c94b7094fd5332c59bf1e18d3c 100644 (file)
@@ -36,14 +36,14 @@ namespace System.Web.UI.WebControls {
        // attributes
        [ToolboxData ("<{0}:RequiredFieldValidator runat=\"server\" ErrorMessage=\"RequiredFieldValidator\"></{0}:RequiredFieldValidator>")]
        public class RequiredFieldValidator : BaseValidator {
-               protected override void AddAttributesToRender (HtmlTextWriter w)
+               protected override void AddAttributesToRender (HtmlTextWriter writer)
                {
                        if (RenderUplevel) {
                                RegisterExpandoAttribute (ClientID, "evaluationfunction", "RequiredFieldValidatorEvaluateIsValid");
                                RegisterExpandoAttribute (ClientID, "initialvalue", InitialValue, true);
                        }
 
-                       base.AddAttributesToRender (w);
+                       base.AddAttributesToRender (writer);
                }
                
                protected override bool EvaluateIsValid ()
index 7555cb77befed5b2cb2d51bf7f3fe9f3fe8bc1df..62b90b13d7fde5e68a7e276adeb12abc5096777f 100644 (file)
@@ -33,10 +33,10 @@ namespace System.Web.UI.WebControls {
                string value;
                bool is_valid;
                
-               public ServerValidateEventArgs (string value, bool is_valid)
+               public ServerValidateEventArgs (string value, bool isValid)
                {
                        this.value = value;
-                       this.is_valid = is_valid;
+                       this.is_valid = isValid;
                }
 
                public string Value {
index e90afda34ee92084bf41790ee14a80ea3d236d78..156754611bf1a881dca6a44d66215e29baa6c9c2 100644 (file)
@@ -68,12 +68,12 @@ namespace System.Web.UI.WebControls {
                        return new SessionParameter (this);
                }
                protected internal
-               override object Evaluate (HttpContext ctx, Control control)
+               override object Evaluate (HttpContext context, Control control)
                {
-                       if (ctx == null || ctx.Session == null)
+                       if (context == null || context.Session == null)
                                return null;
                        
-                       return ctx.Session [SessionField];
+                       return context.Session [SessionField];
                }
                
                [DefaultValueAttribute ("")]
index 071578a04104ef1808f73082281f8f843ff187ff..06899980797fd6bd320ad436d52d580e2fbad1d6 100644 (file)
@@ -42,13 +42,13 @@ namespace System.Web.UI.WebControls
        {
                SiteMapNodeCollection collection;
                
-               public SiteMapDataSourceView (SiteMapDataSource owner, string viewName, SiteMapNode node)
-               : this (owner, viewName, new SiteMapNodeCollection (node))
+               public SiteMapDataSourceView (SiteMapDataSource owner, string name, SiteMapNode node)
+               : this (owner, name, new SiteMapNodeCollection (node))
                {
                }
                
-               public SiteMapDataSourceView (SiteMapDataSource owner, string viewName, SiteMapNodeCollection collection)
-               : base (owner, viewName)
+               public SiteMapDataSourceView (SiteMapDataSource owner, string name, SiteMapNodeCollection collection)
+               : base (owner, name)
                {
                        this.collection = collection;
                }
index ae6e64a65811031ae0b5341b5c8d4f710dfc35e6..312b169c9b7fc8dc69b03a0a06e22103479f50ff 100644 (file)
@@ -451,12 +451,12 @@ namespace System.Web.UI.WebControls
                }
                
                [MonoTODO ("why override?")]
-               protected internal override void Render (HtmlTextWriter w)
+               protected internal override void Render (HtmlTextWriter writer)
                {
-                       base.Render (w);
+                       base.Render (writer);
                }
 
-               protected internal override void RenderContents (HtmlTextWriter w)
+               protected internal override void RenderContents (HtmlTextWriter writer)
                {
                        string skip_id = ClientID + "_SkipLink";
                        string altText = SkipLinkText;
@@ -464,27 +464,27 @@ namespace System.Web.UI.WebControls
                        
                        if (needAnchor) {
                                // Anchor start
-                               w.AddAttribute (HtmlTextWriterAttribute.Href, "#" + skip_id);
-                               w.RenderBeginTag (HtmlTextWriterTag.A);
+                               writer.AddAttribute (HtmlTextWriterAttribute.Href, "#" + skip_id);
+                               writer.RenderBeginTag (HtmlTextWriterTag.A);
 
                                // Image
-                               w.AddAttribute (HtmlTextWriterAttribute.Alt, altText);
-                               w.AddAttribute (HtmlTextWriterAttribute.Height, "0");
-                               w.AddAttribute (HtmlTextWriterAttribute.Width, "0");
-                               w.AddAttribute (HtmlTextWriterAttribute.Src, Page.ClientScript.GetWebResourceUrl (typeof (SiteMapPath), "transparent.gif"));
-                               w.AddStyleAttribute (HtmlTextWriterStyle.BorderWidth, "0px");
-                               w.RenderBeginTag (HtmlTextWriterTag.Img);
-                               w.RenderEndTag ();
+                               writer.AddAttribute (HtmlTextWriterAttribute.Alt, altText);
+                               writer.AddAttribute (HtmlTextWriterAttribute.Height, "0");
+                               writer.AddAttribute (HtmlTextWriterAttribute.Width, "0");
+                               writer.AddAttribute (HtmlTextWriterAttribute.Src, Page.ClientScript.GetWebResourceUrl (typeof (SiteMapPath), "transparent.gif"));
+                               writer.AddStyleAttribute (HtmlTextWriterStyle.BorderWidth, "0px");
+                               writer.RenderBeginTag (HtmlTextWriterTag.Img);
+                               writer.RenderEndTag ();
 
-                               w.RenderEndTag ();
+                               writer.RenderEndTag ();
                        }
 
-                       base.RenderContents (w);
+                       base.RenderContents (writer);
 
                        if (needAnchor) {
-                                w.AddAttribute(HtmlTextWriterAttribute.Id, skip_id);
-                                w.RenderBeginTag(HtmlTextWriterTag.A);
-                                w.RenderEndTag();
+                                writer.AddAttribute(HtmlTextWriterAttribute.Id, skip_id);
+                                writer.RenderBeginTag(HtmlTextWriterTag.A);
+                                writer.RenderEndTag();
                        }
                }
                
index e27be97b4108819d78de5879bcd1b41c5783e78b..5970caae0ac806b95fd50c8ea291ca4b057eeb47 100644 (file)
@@ -118,9 +118,9 @@ namespace System.Web.UI.WebControls {
                        return View.Delete (null, null);
                }
                
-               public IEnumerable Select (DataSourceSelectArguments args)
+               public IEnumerable Select (DataSourceSelectArguments arguments)
                {
-                       return View.Select (args);                      
+                       return View.Select (arguments);                 
                }
                
                public int Update ()
index b975b4ce35f2ce4adf1003f7be2a37ca6facca12..5557f2dc18e6c3bb36a4c4f96c727f0dbf366674 100644 (file)
@@ -673,10 +673,10 @@ namespace System.Web.UI.WebControls {
                        registered_class = name;
                }
 
-               public CssStyleCollection GetStyleAttributes (IUrlResolutionService resolver)
+               public CssStyleCollection GetStyleAttributes (IUrlResolutionService urlResolver)
                {
                        CssStyleCollection col = new CssStyleCollection ();
-                       FillStyleAttributes (col, resolver);
+                       FillStyleAttributes (col, urlResolver);
                        return col;
                }
 
index ed4a84bab557348cc1aeb57a0b34e7d931f50138..3e1b071c9d7cb43b1979fef7d741650bc9415b5b 100644 (file)
@@ -53,9 +53,9 @@ namespace System.Web.UI.WebControls
                        return ((IList)this).Contains (style);
                }
                
-               public void CopyTo (SubMenuStyle[] array, int index)
+               public void CopyTo (SubMenuStyle[] styleArray, int index)
                {
-                       ((IList)this).CopyTo (array, index);
+                       ((IList)this).CopyTo (styleArray, index);
                }
                
                protected override object CreateKnownType (int index)
index 1d6fa34163f3ad7c9f55ba59e67532b731518a71..6ceb488e1bf7081cd6e4fe7ebd0e6579e3f28237 100644 (file)
@@ -84,7 +84,7 @@ namespace System.Web.UI.WebControls {
                        "search"
                };
 
-               protected override void AddAttributesToRender (HtmlTextWriter w)
+               protected override void AddAttributesToRender (HtmlTextWriter writer)
                {
                        Page page = Page;
                        if (page != null)
@@ -93,17 +93,17 @@ namespace System.Web.UI.WebControls {
                        switch (TextMode) {
                        case TextBoxMode.MultiLine:
                                if (Columns != 0)
-                                       w.AddAttribute (HtmlTextWriterAttribute.Cols, Columns.ToString (), false);
+                                       writer.AddAttribute (HtmlTextWriterAttribute.Cols, Columns.ToString (), false);
                                else
-                                       w.AddAttribute (HtmlTextWriterAttribute.Cols, "20", false);
+                                       writer.AddAttribute (HtmlTextWriterAttribute.Cols, "20", false);
                                
                                if (Rows != 0)
-                                       w.AddAttribute (HtmlTextWriterAttribute.Rows, Rows.ToString (), false);
+                                       writer.AddAttribute (HtmlTextWriterAttribute.Rows, Rows.ToString (), false);
                                else
-                                       w.AddAttribute (HtmlTextWriterAttribute.Rows, "2", false);
+                                       writer.AddAttribute (HtmlTextWriterAttribute.Rows, "2", false);
 
                                if (!Wrap)
-                                       w.AddAttribute (HtmlTextWriterAttribute.Wrap, "off", false);
+                                       writer.AddAttribute (HtmlTextWriterAttribute.Wrap, "off", false);
                                
                                break;
                                
@@ -111,45 +111,45 @@ namespace System.Web.UI.WebControls {
                        case TextBoxMode.Password:
                                
                                if (TextMode == TextBoxMode.Password)
-                                       w.AddAttribute (HtmlTextWriterAttribute.Type, "password", false);
+                                       writer.AddAttribute (HtmlTextWriterAttribute.Type, "password", false);
                                else {
-                                       w.AddAttribute (HtmlTextWriterAttribute.Type, "text", false);
+                                       writer.AddAttribute (HtmlTextWriterAttribute.Type, "text", false);
                                        if (Text.Length > 0)
-                                               w.AddAttribute (HtmlTextWriterAttribute.Value, Text);
+                                               writer.AddAttribute (HtmlTextWriterAttribute.Value, Text);
                                }
                                
                                if (Columns != 0)
-                                       w.AddAttribute (HtmlTextWriterAttribute.Size, Columns.ToString (), false);
+                                       writer.AddAttribute (HtmlTextWriterAttribute.Size, Columns.ToString (), false);
                
                                if (MaxLength != 0)
-                                       w.AddAttribute (HtmlTextWriterAttribute.Maxlength, MaxLength.ToString (), false);
+                                       writer.AddAttribute (HtmlTextWriterAttribute.Maxlength, MaxLength.ToString (), false);
 
                                if (AutoCompleteType != AutoCompleteType.None && TextMode == TextBoxMode.SingleLine)
                                        if (AutoCompleteType != AutoCompleteType.Disabled)
-                                               w.AddAttribute (HtmlTextWriterAttribute.VCardName, VCardValues [(int) AutoCompleteType]);
+                                               writer.AddAttribute (HtmlTextWriterAttribute.VCardName, VCardValues [(int) AutoCompleteType]);
                                        else
-                                               w.AddAttribute (HtmlTextWriterAttribute.AutoComplete, "off", false);
+                                               writer.AddAttribute (HtmlTextWriterAttribute.AutoComplete, "off", false);
                                break;  
                        }
 
                        if (AutoPostBack) {
-                               w.AddAttribute ("onkeypress", "if (WebForm_TextBoxKeyHandler(event) == false) return false;", false);
+                               writer.AddAttribute ("onkeypress", "if (WebForm_TextBoxKeyHandler(event) == false) return false;", false);
 
                                if (page != null) {
                                        string onchange = page.ClientScript.GetPostBackEventReference (GetPostBackOptions (), true);
                                        onchange = String.Concat ("setTimeout('", onchange.Replace ("\\", "\\\\").Replace ("'", "\\'"), "', 0)");
-                                       w.AddAttribute (HtmlTextWriterAttribute.Onchange, BuildScriptAttribute ("onchange", onchange));
+                                       writer.AddAttribute (HtmlTextWriterAttribute.Onchange, BuildScriptAttribute ("onchange", onchange));
                                }
                        } else if (page != null)
                                page.ClientScript.RegisterForEventValidation (UniqueID, String.Empty);
                                
 
                        if (ReadOnly)
-                               w.AddAttribute (HtmlTextWriterAttribute.ReadOnly, "ReadOnly", false);
+                               writer.AddAttribute (HtmlTextWriterAttribute.ReadOnly, "ReadOnly", false);
 
-                       w.AddAttribute (HtmlTextWriterAttribute.Name, UniqueID);
+                       writer.AddAttribute (HtmlTextWriterAttribute.Name, UniqueID);
                        
-                       base.AddAttributesToRender (w);
+                       base.AddAttributesToRender (writer);
                }
 
                protected override void AddParsedSubObject (object obj)
@@ -174,16 +174,16 @@ namespace System.Web.UI.WebControls {
                }
 
                protected internal
-               override void Render (HtmlTextWriter w)
+               override void Render (HtmlTextWriter writer)
                {
                        // Why didn't msft just override RenderContents!?
-                       RenderBeginTag (w);
+                       RenderBeginTag (writer);
                        if (TextMode == TextBoxMode.MultiLine) {
-                               w.WriteLine ();
-                               HttpUtility.HtmlEncode (Text, w);
+                               writer.WriteLine ();
+                               HttpUtility.HtmlEncode (Text, writer);
                        }
                        
-                       RenderEndTag (w);
+                       RenderEndTag (writer);
                }
                
                protected virtual
index 73c8d5fc401e4771f6d11c21fd86b140f15d66a0..c521745f036a45ced8a09bbf3b1190a0ea372fca 100644 (file)
@@ -506,17 +506,17 @@ namespace System.Web.UI.WebControls
                        Expanded = !Expanded.GetValueOrDefault(false);
                }
 
-               void IStateManager.LoadViewState (object savedState)
+               void IStateManager.LoadViewState (object state)
                {
-                       LoadViewState (savedState);
+                       LoadViewState (state);
                }
 
-               protected virtual void LoadViewState (object savedState)
+               protected virtual void LoadViewState (object state)
                {
-                       if (savedState == null)
+                       if (state == null)
                                return;
 
-                       object[] states = (object[]) savedState;
+                       object[] states = (object[]) state;
                        ViewState.LoadViewState (states [0]);
                        
                        if (tree != null && SelectedFlag)
index 887166dbfd2456e000b0b1d44cf8af2e7a9e4623..c6152b8d6906d729b59ef2739cc634df38f7fdb6 100644 (file)
@@ -53,9 +53,9 @@ namespace System.Web.UI.WebControls
                        return ((IList)this).Contains (binding);
                }
                
-               public void CopyTo (TreeNodeBinding[] array, int index)
+               public void CopyTo (TreeNodeBinding[] bindingArray, int index)
                {
-                       ((IList)this).CopyTo (array, index);
+                       ((IList)this).CopyTo (bindingArray, index);
                }
                
                protected override object CreateKnownType (int index)
index e022825bb925ff4be99d0b03bbc2a0d10c44defa..177cd5d73e8137a109884fc17e6d410a597b3d45 100644 (file)
@@ -65,8 +65,8 @@ namespace System.Web.UI.WebControls
                                node.Tree = tree;
                }
                
-               public TreeNode this [int i] {
-                       get { return (TreeNode) items [i]; }
+               public TreeNode this [int index] {
+                       get { return (TreeNode) items [index]; }
                }
                
                public void Add (TreeNode child)
@@ -127,9 +127,9 @@ namespace System.Web.UI.WebControls
                        }
                }
                
-               public bool Contains (TreeNode child)
+               public bool Contains (TreeNode c)
                {
-                       return items.Contains (child);
+                       return items.Contains (c);
                }
                
                public void CopyTo (TreeNode[] nodeArray, int index)
@@ -142,18 +142,18 @@ namespace System.Web.UI.WebControls
                        return items.GetEnumerator ();
                }
                
-               public int IndexOf (TreeNode node)
+               public int IndexOf (TreeNode value)
                {
-                       return items.IndexOf (node);
+                       return items.IndexOf (value);
                }
                
-               public void Remove (TreeNode node)
+               public void Remove (TreeNode value)
                {
-                       int i = IndexOf (node);
+                       int i = IndexOf (value);
                        if (i == -1) return;
                        items.RemoveAt (i);
                        if (tree != null)
-                               node.Tree = null;
+                               value.Tree = null;
                        if (marked) {
                                SetDirty ();
                        }
index b8761bf75daa0818090cd9e0cdea61cdfb1dec1f..3a78a6c606d909d8c53492a8f922664d837ee3ac 100644 (file)
@@ -57,9 +57,9 @@ namespace System.Web.UI.WebControls
                        return ((IList)this).Contains (style);
                }
                
-               public void CopyTo (TreeNodeStyle[] array, int index)
+               public void CopyTo (TreeNodeStyle[] styleArray, int index)
                {
-                       ((IList)this).CopyTo (array, index);
+                       ((IList)this).CopyTo (styleArray, index);
                }
                
                protected override object CreateKnownType (int index)
index f0ebcdeb3eaf0d54cd235454161b097dac8f7eeb..dddf18f0c56c2ea9df41bba7685e0a145057c881 100644 (file)
@@ -827,12 +827,12 @@ namespace System.Web.UI.WebControls
                        return null;
                }
 
-               protected override void LoadViewState (object savedState)
+               protected override void LoadViewState (object state)
                {
-                       if (savedState == null)
+                       if (state == null)
                                return;
                                
-                       object [] states = (object []) savedState;
+                       object [] states = (object []) state;
                        base.LoadViewState (states[0]);
                        
                        if (states[1] != null)
@@ -921,9 +921,9 @@ namespace System.Web.UI.WebControls
                }
                
                string callbackResult;
-               protected virtual void RaiseCallbackEvent (string eventArgs)
+               protected virtual void RaiseCallbackEvent (string eventArgument)
                {
-                       string[] args = eventArgs.Split ('|');
+                       string[] args = eventArgument.Split ('|');
                        RequiresDataBinding = true;
                        EnsureDataBound ();
                        
index 29cb4e82e376262994963b432371216914e71fe7..bd20017e7b9f36a61c57cc9010c8e693b15c2fd3 100644 (file)
@@ -376,14 +376,14 @@ namespace System.Web.UI.WebControls {
                        return ToString (Helpers.InvariantCulture);
                }
 
-               public string ToString (IFormatProvider provider)
+               public string ToString (IFormatProvider formatProvider)
                {
                        if (type == 0)
                                return String.Empty;
 
                        string ex = GetExtension (type);
 
-                       return value.ToString (provider) + ex;
+                       return value.ToString (formatProvider) + ex;
                }
        }
 
index 3cb54bf0dfd7aa6a3bd0f9e2c169982c398d6097..e7c1846c3719677c0adfaeb5049d1186dbe80126 100644 (file)
@@ -1299,13 +1299,13 @@ namespace System.Web.UI.WebControls
                        throw new NotImplementedException ();
                }
                
-               protected internal override void LoadControlState (object ob)
+               protected internal override void LoadControlState (object state)
                {
-                       if (ob == null) return;
-                       object[] state = (object[]) ob;
-                       base.LoadControlState (state[0]);
-                       activeStepIndex = (int) state[1];
-                       history = (ArrayList) state[2];
+                       if (state == null) return;
+                       object[] controlState = (object[]) state;
+                       base.LoadControlState (controlState[0]);
+                       activeStepIndex = (int) controlState[1];
+                       history = (ArrayList) controlState[2];
                }
                
                protected internal override object SaveControlState ()
index d451f634aa1d8b5b177238e6d81d4de3231fa6de..961e240e721d4ac89b1cdf9066c3e68c2f80dc6a 100644 (file)
@@ -37,10 +37,10 @@ namespace System.Web.UI.WebControls
                int nxtStepIndex;
                bool cancel;
                
-               public WizardNavigationEventArgs (int currentIndex, int nextIndex)
+               public WizardNavigationEventArgs (int currentStepIndex, int nextStepIndex)
                {
-                       this.curStepIndex = currentIndex;
-                       this.nxtStepIndex = nextIndex;
+                       this.curStepIndex = currentStepIndex;
+                       this.nxtStepIndex = nextStepIndex;
                        cancel = false;
                }
                
index 294f4825b1d10b345fe5787d1e3e8c09d27d0fe5..53d1544c524851e17ab5d1e7b5e244e02f34f39c 100644 (file)
@@ -29,6 +29,6 @@
 //
 
 namespace System.Web.UI.WebControls {
-       public delegate void WizardNavigationEventHandler (object source, WizardNavigationEventArgs e);
+       public delegate void WizardNavigationEventHandler (object sender, WizardNavigationEventArgs e);
 }
 
index 4bcf8835302941b49c07801dfd3ff6f1d3223f20..3044263a8da7c4045ceba007bdf1f658a97a956c 100644 (file)
@@ -48,9 +48,9 @@ namespace System.Web.UI {
                        this.bag = bag;
                }
 
-               public override bool Equals (object obj
+               public override bool Equals (object o) 
                {
-                       AttributeCollection other = obj as AttributeCollection;
+                       AttributeCollection other = o as AttributeCollection;
                        if (other == null) {
                                return false;
                        }
index f02d74c7d6ea761a154d579426a94fca5b30a9f4..e443504fd112cc73b728faac6c82c34392a12a10 100644 (file)
@@ -167,14 +167,14 @@ namespace System.Web.UI {
                        return (bool) attr_render [null];
                }
 
-               protected override bool OnStyleAttributeRender (string styleAttrName, string value, HtmlTextWriterStyle key)
+               protected override bool OnStyleAttributeRender (string name, string value, HtmlTextWriterStyle key)
                {
                        return key == HtmlTextWriterStyle.Display;
                }
 
-               protected override bool OnTagRender (string name, HtmlTextWriterTag tag)
+               protected override bool OnTagRender (string name, HtmlTextWriterTag key)
                {
-                       return tag != HtmlTextWriterTag.Span;
+                       return key != HtmlTextWriterTag.Span;
                }
        }
 }
index 0d4acd2943ef20bbfe3009573c34e5f952883da2..90361751a556e2140fc82c5a46081815b832ba1d 100644 (file)
@@ -41,14 +41,14 @@ public sealed class CompiledTemplateBuilder : ITemplate
 {
        BuildTemplateMethod templateMethod;
 
-       public CompiledTemplateBuilder (BuildTemplateMethod templateMethod)
+       public CompiledTemplateBuilder (BuildTemplateMethod buildTemplateMethod)
        {
-               this.templateMethod = templateMethod;
+               this.templateMethod = buildTemplateMethod;
        }
 
-       public void InstantiateIn (Control ctrl)
+       public void InstantiateIn (Control container)
        {
-               templateMethod (ctrl);
+               templateMethod (container);
        }
 }
 }
index d50949ac5026825a2b52219f95518946ef11e4f1..6a166f43e2e575b9c9e733d6f64e397ad4f63742 100644 (file)
@@ -1950,7 +1950,7 @@ namespace System.Web.UI
                        Page.SetFocus (this);
                }
 
-               protected internal virtual void LoadControlState (object state)
+               protected internal virtual void LoadControlState (object savedState)
                {
                }
 
index db51d4725c0c07a45be1cf83b48f2aedca59bc06..8929d3832d98c42e5e98e5f5692ace77487c45ac 100644 (file)
@@ -183,12 +183,12 @@ namespace System.Web.UI {
                        return new SimpleEnumerator (this);
                }
 
-               public virtual int IndexOf (Control c)
+               public virtual int IndexOf (Control value)
                {
-                       if (controls == null || c == null)
+                       if (controls == null || value == null)
                                return -1;
 
-                       return Array.IndexOf (controls, c);
+                       return Array.IndexOf (controls, value);
                }
 
                public virtual void Remove (Control value)
index 5810a86b19545a6e02404cd956ee87571939c207..6e9ea56b9c2e4bf8f434e68c3497f5ebedce4cd1 100644 (file)
@@ -38,21 +38,21 @@ namespace System.Web.UI {
                object propertyValue;
                Type propertyType;
 
-               public ControlValuePropertyAttribute (string propName) 
+               public ControlValuePropertyAttribute (string name) 
                {
-                       this.propertyName = propName;
+                       this.propertyName = name;
                }
 
-               public ControlValuePropertyAttribute (string propName, object propValue) 
+               public ControlValuePropertyAttribute (string name, object defaultValue) 
                {
-                       this.propertyName = propName;
-                       this.propertyValue = propValue;
+                       this.propertyName = name;
+                       this.propertyValue = defaultValue;
                }
 
-               public ControlValuePropertyAttribute (string propName, Type type, string propValue) 
+               public ControlValuePropertyAttribute (string name, Type type, string defaultValue) 
                {
-                       this.propertyName = propName;
-                       this.propertyValue = propValue;
+                       this.propertyName = name;
+                       this.propertyValue = defaultValue;
                        this.propertyType = type;
                }
 
index 822ac4b34639eb37d365995d1842c82c95207f99..34c8c955eb593e59b341b568478884941f87f80d 100644 (file)
@@ -167,9 +167,9 @@ namespace System.Web.UI {
                        return prop.GetValue (container, args);
                }
 
-               public static string GetIndexedPropertyValue (object container, string expr, string format)
+               public static string GetIndexedPropertyValue (object container, string propName, string format)
                {
-                       object result = GetIndexedPropertyValue (container, expr);
+                       object result = GetIndexedPropertyValue (container, propName);
                        return FormatResult (result, format);
                }
 
index 751a8ae1d1a2e700f740e97bf90ba42765d662b9..803a60e2e6563dcf27e457c37b55bcc6ab213143 100644 (file)
@@ -108,9 +108,9 @@ namespace System.Web.UI {
                }
 
                [EditorBrowsable (EditorBrowsableState.Never)]
-               public override void RenderControl (HtmlTextWriter tw)
+               public override void RenderControl (HtmlTextWriter writer)
                {
-                       base.RenderControl (tw);
+                       base.RenderControl (writer);
                }
 
                [EditorBrowsable (EditorBrowsableState.Never)]
index 6c0f0451912d878447739826b71d393e0399955d..3965b664f5f42ffd9a167ca3e2da7d92fac5ccf9 100644 (file)
@@ -57,22 +57,22 @@ namespace System.Web.UI
                        this.sortExpression = sortExpression;
                }
 
-               public DataSourceSelectArguments (int startingRowIndex, int maxRows)
+               public DataSourceSelectArguments (int startRowIndex, int maximumRows)
                {
-                       this.startingRowIndex = startingRowIndex;
-                       this.maxRows = maxRows;
+                       this.startingRowIndex = startRowIndex;
+                       this.maxRows = maximumRows;
                }
 
-               public DataSourceSelectArguments (string sortExpression, int startingRowIndex, int maxRows)
+               public DataSourceSelectArguments (string sortExpression, int startRowIndex, int maximumRows)
                {
                        this.sortExpression = sortExpression; 
-                       this.startingRowIndex = startingRowIndex;
-                       this.maxRows = maxRows;
+                       this.startingRowIndex = startRowIndex;
+                       this.maxRows = maximumRows;
                }
 
-               public void AddSupportedCapabilities (DataSourceCapabilities srcCapabilities)
+               public void AddSupportedCapabilities (DataSourceCapabilities capabilities)
                {
-                       this.dsc = this.dsc | srcCapabilities;
+                       this.dsc = this.dsc | capabilities;
                }
 
                // MSDN: The DataSourceSelectArguments class overrides the Object.Equals method to test 
index 7415b671ec96a16e45f27931d151c0727dd42e29..f8c4ae5adcd7c60fac25f6fec06851481ad649d5 100644 (file)
@@ -55,30 +55,30 @@ namespace System.Web.UI {
                        OnDataSourceViewChanged (EventArgs.Empty);
                }
 
-               public virtual void Delete (IDictionary keys, IDictionary values,
-                                               DataSourceViewOperationCallback callBack)
+               public virtual void Delete (IDictionary keys, IDictionary oldValues,
+                                               DataSourceViewOperationCallback callback)
                {
-                       if (callBack == null)
+                       if (callback == null)
                                throw new ArgumentNullException ("callBack");
 
                        int rowAffected;
                        try {
-                               rowAffected = ExecuteDelete (keys, values);
+                               rowAffected = ExecuteDelete (keys, oldValues);
                        }
                        catch (Exception e) {
-                               if (!callBack (0, e))
+                               if (!callback (0, e))
                                        throw;
                                return;
                        }
-                       callBack (rowAffected, null);
+                       callback (rowAffected, null);
                }
 
-               protected virtual int ExecuteDelete(IDictionary keys, IDictionary values)
+               protected virtual int ExecuteDelete(IDictionary keys, IDictionary oldValues)
                {
                        throw new NotSupportedException ();
                }
 
-               protected virtual int ExecuteInsert (IDictionary keys)
+               protected virtual int ExecuteInsert (IDictionary values)
                {
                        throw new NotSupportedException();
                }
@@ -93,29 +93,29 @@ namespace System.Web.UI {
                }
 
                public virtual void Insert (IDictionary values, 
-                                       DataSourceViewOperationCallback callBack)
+                                       DataSourceViewOperationCallback callback)
                {
-                       if (callBack == null)
-                               throw new ArgumentNullException("callBack");
+                       if (callback == null)
+                               throw new ArgumentNullException("callback");
 
                        int rowAffected;
                        try {
                                rowAffected = ExecuteInsert (values);
                        } catch (Exception e) {
-                               if (!callBack (0, e))
+                               if (!callback (0, e))
                                        throw;
                                return;
                        }
 
-                       callBack (rowAffected, null);
+                       callback (rowAffected, null);
                }
 
-               protected virtual void OnDataSourceViewChanged (EventArgs eventArgs)
+               protected virtual void OnDataSourceViewChanged (EventArgs e)
                {
                        if (eventsList != null) {
                                EventHandler evtHandler = eventsList [EventDataSourceViewChanged] as EventHandler;
                                if (evtHandler != null)
-                                       evtHandler(this, eventArgs);
+                                       evtHandler(this, e);
                        }
                }
                
@@ -137,34 +137,34 @@ namespace System.Web.UI {
                        return;
                }
 
-               public virtual void Select (DataSourceSelectArguments selectArgs,
-                                               DataSourceViewSelectCallback callBack)
+               public virtual void Select (DataSourceSelectArguments arguments,
+                                               DataSourceViewSelectCallback callback)
                {
-                       if (callBack == null)
+                       if (callback == null)
                                throw new ArgumentNullException("callBack");
 
-                       selectArgs.RaiseUnsupportedCapabilitiesError (this);
+                       arguments.RaiseUnsupportedCapabilitiesError (this);
                        
-                       IEnumerable selectList = ExecuteSelect (selectArgs);
-                       callBack (selectList);
+                       IEnumerable selectList = ExecuteSelect (arguments);
+                       callback (selectList);
                }
 
                public virtual void Update(IDictionary keys, IDictionary values,
-                       IDictionary oldValues, DataSourceViewOperationCallback callBack)
+                       IDictionary oldValues, DataSourceViewOperationCallback callback)
                {
-                       if (callBack == null)
-                               throw new ArgumentNullException ("callBack");
+                       if (callback == null)
+                               throw new ArgumentNullException ("callback");
 
                        int rowAffected;
                        try {
                                rowAffected = ExecuteUpdate (keys, values, oldValues);
                        } catch (Exception e) {
-                               if (!callBack (0, e))
+                               if (!callback (0, e))
                                        throw;
                                return;
                        }
 
-                       callBack (rowAffected, null);
+                       callback (rowAffected, null);
                } 
                
                public virtual bool CanDelete { get { return false; } }
index 003aabdd17d3415e8027eeb4deb78f358ce3b1b8..665a80ef14a13311755420218ecf057f0235aebd 100644 (file)
@@ -32,5 +32,5 @@ using System;
 
 namespace System.Web.UI
 {
-        public delegate bool DataSourceViewOperationCallback (int recordsAffected, Exception exception);
+        public delegate bool DataSourceViewOperationCallback (int affectedRecords, Exception ex);
 }
index a9590228e3295504bf7638a4479809f2abcc92b9..8cd4b7a874f1c7e67f8b9654831609f06637096a 100644 (file)
@@ -91,9 +91,9 @@ namespace System.Web.UI {
                        OnChanged (new EventArgs ());
                }
 
-               public bool Contains (string propertyName)
+               public bool Contains (string propName)
                {
-                       return list.Contains (propertyName);
+                       return list.Contains (propName);
                }
 
                public void CopyTo (Array array, int index)
@@ -101,17 +101,17 @@ namespace System.Web.UI {
                        list.CopyTo (array, index);
                }
 
-               public void CopyTo (ExpressionBinding [] bindings, int index)
+               public void CopyTo (ExpressionBinding [] array, int index)
                {
                        if (index < 0)
                                throw new ArgumentNullException ("Index cannot be negative");
-                       if (index >= bindings.Length)
+                       if (index >= array.Length)
                                throw new ArgumentException ("Index cannot be greater than or equal to length of array passed");            
-                       if (list.Count > (bindings.Length - index + 1))
+                       if (list.Count > (array.Length - index + 1))
                                throw new ArgumentException ("Number of elements in source is greater than available space from index to end of destination");
             
                        foreach (string key in list.Keys)
-                               bindings [index++] = (ExpressionBinding) list [key];
+                               array [index++] = (ExpressionBinding) list [key];
                }
 
                public IEnumerator GetEnumerator ()
index 45ce22e46e9fe5e50cbf3c0fded9fc049cdceccb..d0eb70ed90516e6530744bd7de2d911ca4fa3f42 100644 (file)
@@ -112,9 +112,9 @@ namespace System.Web.UI {
                }
 
 
-               public virtual void AddAttribute (string name, string value, bool fEncode)
+               public virtual void AddAttribute (string name, string value, bool fEndode)
                {
-                       if (fEncode)
+                       if (fEndode)
                                value = HttpUtility.HtmlAttributeEncode (value);
 
                        AddAttribute (name, value, GetAttributeKey (name));
@@ -562,10 +562,10 @@ namespace System.Web.UI {
                        b.Write (format, arg0, arg1);
                }
 
-               public override void Write (string format, params object [] args)
+               public override void Write (string format, params object [] arg)
                {
                        OutputTabs ();
-                       b.Write (format, args);
+                       b.Write (format, arg);
                }
 
                public override void Write (string s)
@@ -680,10 +680,10 @@ namespace System.Web.UI {
                        newline = true;
                }
 
-               public override void WriteLine (string format, params object [] args)
+               public override void WriteLine (string format, params object [] arg)
                {
                        OutputTabs ();
-                       b.WriteLine (format, args);
+                       b.WriteLine (format, arg);
                        newline = true;
                }
 
index b4274ba661f6795a8d5f5763aadb8ab3865d711d..ab78c49e8d74ccc746ee614501d743d57cb75159 100644 (file)
@@ -62,9 +62,9 @@ namespace System.Web.UI {
                         }
                 }
 
-               protected internal override void Render (HtmlTextWriter writer)
+               protected internal override void Render (HtmlTextWriter output)
                 {
-                        writer.Write (_text);
+                        output.Write (_text);
                 }
 
                protected override ControlCollection CreateControlCollection ()
index 69cd30decdf551af411d6dfa7937b71d1ecc26ad..eeb8a37d13266f4fde0a6f242c555e4b70665d1c 100644 (file)
@@ -1600,17 +1600,17 @@ public partial class Page : TemplateControl, IHttpHandler
        }
 
        [EditorBrowsable (EditorBrowsableState.Advanced)]
-       protected virtual void SavePageStateToPersistenceMedium (object viewState)
+       protected virtual void SavePageStateToPersistenceMedium (object state)
        {
                PageStatePersister persister = this.PageStatePersister;
                if (persister == null)
                        return;
-               Pair pair = viewState as Pair;
+               Pair pair = state as Pair;
                if (pair != null) {
                        persister.ViewState = pair.First;
                        persister.ControlState = pair.Second;
                } else
-                       persister.ViewState = viewState;
+                       persister.ViewState = state;
                persister.Save ();
        }
 
@@ -2531,9 +2531,9 @@ public partial class Page : TemplateControl, IHttpHandler
 
        [MonoDocumentationNote ("Not implemented.  Only used by .net aspx parser")]
        [EditorBrowsable (EditorBrowsableState.Never)]
-       protected object GetWrappedFileDependencies (string [] list)
+       protected object GetWrappedFileDependencies (string [] virtualFileDependencies)
        {
-               return list;
+               return virtualFileDependencies;
        }
 
        [MonoDocumentationNote ("Does nothing.  Used by .net aspx parser")]
index 9a882e38d2bd14f5ebda68f951a2c1df2ceaf556..a009c81d15f1f0988141b2778607f8cc893d126c 100644 (file)
@@ -39,9 +39,9 @@ namespace System.Web.UI
                {
                }
                
-               public virtual IHttpHandler GetHandler (HttpContext context, string requestType, string url, string path)
+               public virtual IHttpHandler GetHandler (HttpContext context, string requestType, string virtualPath, string path)
                {
-                       return PageParser.GetCompiledPageInstance (url, path, context);
+                       return PageParser.GetCompiledPageInstance (virtualPath, path, context);
                }
 
                public virtual void ReleaseHandler (IHttpHandler handler)
index f8601e17c13e14185582d8ac093d07cd721d8790..b300cf5b1ab0328f3befab93c700e75c186c6427 100644 (file)
@@ -35,10 +35,10 @@ namespace System.Web.UI
        [Serializable]
        public sealed class Pair 
        {
-               public Pair (object first, object second)
+               public Pair (object x, object y)
                {
-                       First = first;
-                       Second = second;
+                       First = x;
+                       Second = y;
                }
 
                public Pair ()
index 6780219f5f84e6eab128c36a07421e89a70a4a7b..c4aa1c221d70ff5961dae3567fad11fedc2a9201 100644 (file)
@@ -40,10 +40,10 @@ namespace System.Web.UI
                Type containerType;
                BindingDirection direction;
                
-               public TemplateContainerAttribute (Type containerType, BindingDirection direction)
+               public TemplateContainerAttribute (Type containerType, BindingDirection bindingDirection)
                {
                        this.containerType = containerType;
-                       this.direction = direction;
+                       this.direction = bindingDirection;
                }
                
                public BindingDirection BindingDirection {
index 6480b008bd983488f7a684fb58121c89be6db3d4..69ca3faba68c0ceb20efce64f2601291e2c6cafe 100644 (file)
@@ -226,22 +226,22 @@ namespace System.Web.UI
                        return LoadControl (type, null);
                }
 
-               public Control LoadControl (Type type, object[] parameters) 
+               public Control LoadControl (Type t, object[] parameters) 
                {
                        object [] attrs = null;
 
-                       if (type != null)
-                               type.GetCustomAttributes (typeof (PartialCachingAttribute), true);
+                       if (t != null)
+                               t.GetCustomAttributes (typeof (PartialCachingAttribute), true);
                        if (attrs != null && attrs.Length == 1) {
                                PartialCachingAttribute attr = (PartialCachingAttribute) attrs [0];
-                               PartialCachingControl ctrl = new PartialCachingControl (type, parameters);
+                               PartialCachingControl ctrl = new PartialCachingControl (t, parameters);
                                ctrl.VaryByParams = attr.VaryByParams;
                                ctrl.VaryByControls = attr.VaryByControls;
                                ctrl.VaryByCustom = attr.VaryByCustom;
                                return ctrl;
                        }
 
-                       object control = Activator.CreateInstance (type, parameters);
+                       object control = Activator.CreateInstance (t, parameters);
                        if (control is UserControl)
                                ((UserControl) control).InitializeAsUserControl (Page);
 
@@ -495,34 +495,34 @@ namespace System.Web.UI
                        return DataBinder.Eval (Page.GetDataItem(), expression, format);
                }
        
-               protected internal object XPath (string xpathexpression)
+               protected internal object XPath (string xPathExpression)
                {
-                       return XPathBinder.Eval (Page.GetDataItem(), xpathexpression);
+                       return XPathBinder.Eval (Page.GetDataItem(), xPathExpression);
                }
        
-               protected internal object XPath (string xpathexpression, IXmlNamespaceResolver resolver)
+               protected internal object XPath (string xPathExpression, IXmlNamespaceResolver resolver)
                {
-                       return XPathBinder.Eval (Page.GetDataItem (), xpathexpression, null, resolver);
+                       return XPathBinder.Eval (Page.GetDataItem (), xPathExpression, null, resolver);
                }
 
-               protected internal string XPath (string xpathexpression, string format)
+               protected internal string XPath (string xPathExpression, string format)
                {
-                       return XPathBinder.Eval (Page.GetDataItem(), xpathexpression, format);
+                       return XPathBinder.Eval (Page.GetDataItem(), xPathExpression, format);
                }
        
-               protected internal string XPath (string xpathexpression, string format, IXmlNamespaceResolver resolver)
+               protected internal string XPath (string xPathExpression, string format, IXmlNamespaceResolver resolver)
                {
-                       return XPathBinder.Eval (Page.GetDataItem (), xpathexpression, format, resolver);
+                       return XPathBinder.Eval (Page.GetDataItem (), xPathExpression, format, resolver);
                }
 
-               protected internal IEnumerable XPathSelect (string xpathexpression)
+               protected internal IEnumerable XPathSelect (string xPathExpression)
                {
-                       return XPathBinder.Select (Page.GetDataItem(), xpathexpression);
+                       return XPathBinder.Select (Page.GetDataItem(), xPathExpression);
                }
 
-               protected internal IEnumerable XPathSelect (string xpathexpression, IXmlNamespaceResolver resolver)
+               protected internal IEnumerable XPathSelect (string xPathExpression, IXmlNamespaceResolver resolver)
                {
-                       return XPathBinder.Select (Page.GetDataItem (), xpathexpression, resolver);
+                       return XPathBinder.Select (Page.GetDataItem (), xPathExpression, resolver);
                }
 
                // IFilterResolutionService
index 135edad6a4b7007d5292ee1bfd2eb6a648742776..ebf293b109abeb4b142715eec083cfd7a8c6e163 100644 (file)
@@ -42,22 +42,22 @@ namespace System.Web.UI
                {
                }
 
-               public static object Eval (object container, string xpath)
+               public static object Eval (object container, string xPath)
                {
-                       return Eval (container, xpath, (IXmlNamespaceResolver)null);
+                       return Eval (container, xPath, (IXmlNamespaceResolver)null);
                }
 
-               public static object Eval (object container, string xpath, IXmlNamespaceResolver resolver) 
+               public static object Eval (object container, string xPath, IXmlNamespaceResolver resolver) 
                {
-                       if (xpath == null || xpath.Length == 0)
-                               throw new ArgumentNullException ("xpath");
+                       if (xPath == null || xPath.Length == 0)
+                               throw new ArgumentNullException ("xPath");
 
                        IXPathNavigable factory = container as IXPathNavigable;
 
                        if (factory == null)
                                throw new ArgumentException ("container");
 
-                       object result = factory.CreateNavigator ().Evaluate (xpath, resolver);
+                       object result = factory.CreateNavigator ().Evaluate (xPath, resolver);
 
                        XPathNodeIterator itr = result as XPathNodeIterator;
                        if (itr != null) {
@@ -70,14 +70,14 @@ namespace System.Web.UI
                        return result;
                }
 
-               public static string Eval (object container, string xpath, string format)
+               public static string Eval (object container, string xPath, string format)
                {
-                       return Eval (container, xpath, format, null);
+                       return Eval (container, xPath, format, null);
                }
 
-               public static string Eval (object container, string xpath, string format, IXmlNamespaceResolver resolver)
+               public static string Eval (object container, string xPath, string format, IXmlNamespaceResolver resolver)
                {
-                       object result = Eval (container, xpath, resolver);
+                       object result = Eval (container, xPath, resolver);
                        
                        if (result == null)
                                return String.Empty;
@@ -87,22 +87,22 @@ namespace System.Web.UI
                        return String.Format (format, result);
                }
 
-               public static IEnumerable Select (object container, string xpath)
+               public static IEnumerable Select (object container, string xPath)
                {
-                       return Select (container, xpath, null);
+                       return Select (container, xPath, null);
                }
 
-               public static IEnumerable Select (object container, string xpath, IXmlNamespaceResolver resolver)
+               public static IEnumerable Select (object container, string xPath, IXmlNamespaceResolver resolver)
                {
-                       if (xpath == null || xpath.Length == 0)
-                               throw new ArgumentNullException ("xpath");
+                       if (xPath == null || xPath.Length == 0)
+                               throw new ArgumentNullException ("xPath");
                        
                        IXPathNavigable factory = container as IXPathNavigable;
                        
                        if (factory == null)
                                throw new ArgumentException ("container");
                        
-                       XPathNodeIterator itr = factory.CreateNavigator ().Select (xpath, resolver);
+                       XPathNodeIterator itr = factory.CreateNavigator ().Select (xPath, resolver);
                        ArrayList ret = new ArrayList ();
                        
                        while (itr.MoveNext ()) {
index 4f9ddcda64181589b222cc9bad99f45628431763..8ab07311d909c5a9a404a1233925b11409f16af8 100644 (file)
@@ -229,15 +229,15 @@ namespace System.Web
                        last_modified_from_file_dependencies = true;
                }
 
-               public void SetMaxAge (TimeSpan date)
+               public void SetMaxAge (TimeSpan delta)
                {
-                       if (date < TimeSpan.Zero)
-                               throw new ArgumentOutOfRangeException ("date");
+                       if (delta < TimeSpan.Zero)
+                               throw new ArgumentOutOfRangeException ("delta");
 
-                       if (HaveMaxAge && MaxAge < date)
+                       if (HaveMaxAge && MaxAge < delta)
                                return;
 
-                       MaxAge = date;
+                       MaxAge = delta;
                        HaveMaxAge = true;
                }
 
index 9d28fbc04bd026121af47930fc6798260658a518..3292d30974c48fd1daafad5549422cc535f3e2a0 100644 (file)
@@ -84,23 +84,23 @@ namespace System.Web
                        }
                }
 
-               public bool this [ string param ] {
+               public bool this [ string header ] {
                        get {
-                               if (param == null)
+                               if (header == null)
                                        throw new ArgumentNullException ();
 
-                               return parms.Contains (param);
+                               return parms.Contains (header);
                        }
                        set {
-                               if (param == null)
+                               if (header == null)
                                        throw new ArgumentNullException ();
 
                                ignore_parms = false;
                                if (value)
-                                       if (!parms.Contains (param))
-                                               parms.Add (param, true);
+                                       if (!parms.Contains (header))
+                                               parms.Add (header, true);
                                else
-                                       parms.Remove (param);
+                                       parms.Remove (header);
                        }
                }
        }
index 5171412528a58ae0ab3e84cfcdbd5c0bdd01cc63..94648b5ed51476d54019924fb5f8f9009254478c 100644 (file)
@@ -519,9 +519,9 @@ namespace System.Web
                        return GetLocalObjectFromFactory (virtualPath, resourceKey, culture);
                }
 
-               public object GetSection (string name)
+               public object GetSection (string sectionName)
                {
-                       return WebConfigurationManager.GetSection (name);
+                       return WebConfigurationManager.GetSection (sectionName);
                }
 
                object IServiceProvider.GetService (Type service)
index 64975a813c0f8a93e76439a141399da2c45fee8e..92d7d179d597303aaa6887f9e4a8ac0dd00d29d0 100644 (file)
@@ -166,14 +166,14 @@ namespace System.Web
                        return HttpContext.GetGlobalResourceObject (classKey, resourceKey, culture);
                }
 
-               public override object GetLocalResourceObject (string overridePath, string resourceKey)
+               public override object GetLocalResourceObject (string virtualPath, string resourceKey)
                {
-                       return HttpContext.GetLocalResourceObject (overridePath, resourceKey);
+                       return HttpContext.GetLocalResourceObject (virtualPath, resourceKey);
                }
 
-               public override object GetLocalResourceObject (string overridePath, string resourceKey, CultureInfo culture)
+               public override object GetLocalResourceObject (string virtualPath, string resourceKey, CultureInfo culture)
                {
-                       return HttpContext.GetLocalResourceObject (overridePath, resourceKey, culture);
+                       return HttpContext.GetLocalResourceObject (virtualPath, resourceKey, culture);
                }
 
                public override object GetSection (string sectionName)
index e780ff380410b4aa816355d9c2430528f4fe9f02..81f9a061a5931b1cc8d9f4af2eabba9b5cf460e0 100644 (file)
@@ -88,13 +88,13 @@ namespace System.Web
                        BaseClear ();
                }
 
-               public void CopyTo (Array array, int index)
+               public void CopyTo (Array dest, int index)
                {
                        /* XXX this is kind of gross and inefficient
                         * since it makes a copy of the superclass's
                         * list */
                        object[] values = BaseGetAllValues();
-                       values.CopyTo (array, index);
+                       values.CopyTo (dest, index);
                }
 
                public string GetKey (int index)
index 7b77b5cc02c3c238b654e2efdeebdbd3dc02a69d..201e90dae4252e3b764c21ab580e42d142f0170e 100644 (file)
@@ -65,14 +65,14 @@ namespace System.Web {
                        return (HttpPostedFile)BaseGet (index);
                }
 
-               public HttpPostedFile Get (string key)
+               public HttpPostedFile Get (string name)
                {
-                       return (HttpPostedFile)BaseGet (key);
+                       return (HttpPostedFile)BaseGet (name);
                }
 
-               public HttpPostedFile this [string key] {
+               public HttpPostedFile this [string name] {
                        get {
-                               return Get (key);
+                               return Get (name);
                        }
                }
 
index 2c3bb7087117dd53338b22f87485ef832e2ca1aa..d10784c17afefa8617a71c37e694d5dd9d9dd5d9 100644 (file)
@@ -65,14 +65,14 @@ namespace System.Web {
                        return (IHttpModule)BaseGet (index);
                }
 
-               public IHttpModule Get (string key)
+               public IHttpModule Get (string name)
                {
-                       return (IHttpModule)BaseGet (key);
+                       return (IHttpModule)BaseGet (name);
                }
 
-               public IHttpModule this [string key] {
+               public IHttpModule this [string name] {
                        get {
-                               return Get (key);
+                               return Get (name);
                        }
                }
 
index 761d34744cc7d7bcde5525eebb04cc46e3683d0f..bad72200852765abfe1ccf7026bbc3d16df31700 100644 (file)
@@ -81,9 +81,9 @@ namespace System.Web
                }
 
                [SecurityPermission (SecurityAction.Demand, SerializationFormatter = true)]
-               public override void GetObjectData (SerializationInfo info, StreamingContext ctx)
+               public override void GetObjectData (SerializationInfo info, StreamingContext context)
                {
-                       base.GetObjectData (info, ctx);
+                       base.GetObjectData (info, context);
                        info.AddValue ("_virtualPath", virtualPath);
                        info.AddValue ("_parserErrors", errors);
                        info.AddValue ("_line", line);
index 1e437e4621fc0f50469090e946dd1e66e53acf1c..89c3e12f7a5cc243331cc2be09fe824d2dbe8e0e 100644 (file)
@@ -235,9 +235,9 @@ namespace System.Web
                        w.AppendToLog (param);
                }
 
-               public override string ApplyAppPathModifier (string overridePath)
+               public override string ApplyAppPathModifier (string virtualPath)
                {
-                       return w.ApplyAppPathModifier (overridePath);
+                       return w.ApplyAppPathModifier (virtualPath);
                }
 
                public override void BinaryWrite (byte [] buffer)
index 83fe4eb3b7193aab797cf0ca252095ead23716c2..0183aa2cab9a8bce6cf2f4160064302eac3ce91a 100644 (file)
@@ -112,34 +112,34 @@ namespace System.Web {
                                buf.Add ((byte)ch);
                }
                
-               public static string UrlDecode (string s, Encoding e)
+               public static string UrlDecode (string str, Encoding e)
                {
-                       if (null == s) 
+                       if (null == str
                                return null;
 
-                       if (s.IndexOf ('%') == -1 && s.IndexOf ('+') == -1)
-                               return s;
+                       if (str.IndexOf ('%') == -1 && str.IndexOf ('+') == -1)
+                               return str;
                        
                        if (e == null)
                                e = Encoding.UTF8;
 
-                       long len = s.Length;
+                       long len = str.Length;
                        var bytes = new List <byte> ();
                        int xchar;
                        char ch;
                        
                        for (int i = 0; i < len; i++) {
-                               ch = s [i];
-                               if (ch == '%' && i + 2 < len && s [i + 1] != '%') {
-                                       if (s [i + 1] == 'u' && i + 5 < len) {
+                               ch = str [i];
+                               if (ch == '%' && i + 2 < len && str [i + 1] != '%') {
+                                       if (str [i + 1] == 'u' && i + 5 < len) {
                                                // unicode hex sequence
-                                               xchar = GetChar (s, i + 2, 4);
+                                               xchar = GetChar (str, i + 2, 4);
                                                if (xchar != -1) {
                                                        WriteCharBytes (bytes, (char)xchar, e);
                                                        i += 5;
                                                } else
                                                        WriteCharBytes (bytes, '%', e);
-                                       } else if ((xchar = GetChar (s, i + 1, 2)) != -1) {
+                                       } else if ((xchar = GetChar (str, i + 1, 2)) != -1) {
                                                WriteCharBytes (bytes, (char)xchar, e);
                                                i += 2;
                                        } else {
@@ -338,18 +338,18 @@ namespace System.Web {
                        return UrlEncode(str, Encoding.UTF8);
                }
        
-               public static string UrlEncode (string s, Encoding Enc
+               public static string UrlEncode (string str, Encoding e
                {
-                       if (s == null)
+                       if (str == null)
                                return null;
 
-                       if (s == String.Empty)
+                       if (str == String.Empty)
                                return String.Empty;
 
                        bool needEncode = false;
-                       int len = s.Length;
+                       int len = str.Length;
                        for (int i = 0; i < len; i++) {
-                               char c = s [i];
+                               char c = str [i];
                                if ((c < '0') || (c < 'A' && c > '9') || (c > 'Z' && c < 'a') || (c > 'z')) {
                                        if (HttpEncoder.NotEncoded (c))
                                                continue;
@@ -360,11 +360,11 @@ namespace System.Web {
                        }
 
                        if (!needEncode)
-                               return s;
+                               return str;
 
                        // avoided GetByteCount call
-                       byte [] bytes = new byte[Enc.GetMaxByteCount(s.Length)];
-                       int realLen = Enc.GetBytes (s, 0, s.Length, bytes, 0);
+                       byte [] bytes = new byte[e.GetMaxByteCount(str.Length)];
+                       int realLen = e.GetBytes (str, 0, str.Length, bytes, 0);
                        return Encoding.ASCII.GetString (UrlEncodeToBytes (bytes, 0, realLen));
                }
          
@@ -593,9 +593,9 @@ namespace System.Web {
 
                        return sb.ToString ();
                }
-               public static string UrlPathEncode (string s)
+               public static string UrlPathEncode (string str)
                {
-                       return HttpEncoder.Current.UrlPathEncode (s);
+                       return HttpEncoder.Current.UrlPathEncode (str);
                }
 
                public static NameValueCollection ParseQueryString (string query)
index ebacf23fef958cf5e73ee3e3cd6b12750b1caf1d..fb9e688bbaa0100055071ae5c58458afb16b04bc 100644 (file)
@@ -40,9 +40,9 @@ namespace System.Web
                {
                }
 
-               public ParserErrorCollection (ParserError[] errors)
+               public ParserErrorCollection (ParserError[] value)
                {
-                       InnerList.AddRange (errors);
+                       InnerList.AddRange (value);
                }
                
                public ParserError this [int index]
@@ -51,44 +51,44 @@ namespace System.Web
                        set { InnerList[index] = value; }
                }
                
-               public int Add (ParserError error)
+               public int Add (ParserError value)
                {
-                       return List.Add (error);
+                       return List.Add (value);
                }
                
-               public void AddRange (ParserErrorCollection collection)
+               public void AddRange (ParserErrorCollection value)
                {
-                       InnerList.AddRange (collection);
+                       InnerList.AddRange (value);
                }
                
-               public void AddRange (ParserError[] errors)
+               public void AddRange (ParserError[] value)
                {
-                       InnerList.AddRange (errors);
+                       InnerList.AddRange (value);
                }
                
-               public bool Contains (ParserError error)
+               public bool Contains (ParserError value)
                {
-                       return InnerList.Contains (error);
+                       return InnerList.Contains (value);
                }
                
-               public void CopyTo (ParserError[] errors, int index)
+               public void CopyTo (ParserError[] array, int index)
                {
-                       List.CopyTo (errors, index);
+                       List.CopyTo (array, index);
                }
                
-               public int IndexOf (ParserError error)
+               public int IndexOf (ParserError value)
                {
-                       return InnerList.IndexOf (error);
+                       return InnerList.IndexOf (value);
                }
                
-               public void Insert (int index, ParserError error)
+               public void Insert (int index, ParserError value)
                {
-                       InnerList.Insert (index, error);
+                       InnerList.Insert (index, value);
                }
                
-               public void Remove (ParserError error)
+               public void Remove (ParserError value)
                {
-                       InnerList.Remove (error);
+                       InnerList.Remove (value);
                }
        }
 }
index b1660b8752c2365c8ff4981c3682921cafbd764c..41f49773fe3761b348b359013fac9d66b0c24e69 100644 (file)
@@ -81,9 +81,9 @@ namespace System.Web {
                        return new SiteMapHierarchicalDataSourceView (this);
                }
                
-               public virtual bool IsAccessibleToUser (System.Web.HttpContext ctx)
+               public virtual bool IsAccessibleToUser (System.Web.HttpContext context)
                {
-                       return provider.IsAccessibleToUser (ctx, this);
+                       return provider.IsAccessibleToUser (context, this);
                }
                
                public override string ToString()
@@ -297,9 +297,9 @@ namespace System.Web {
                        return node;
                }
                                
-               public override bool Equals (object ob)
+               public override bool Equals (object obj)
                {
-                       SiteMapNode node = ob as SiteMapNode;
+                       SiteMapNode node = obj as SiteMapNode;
                        if (node == null) return false;
                        
                        if (node.key != key ||
index 84a92091ce61b5ff19824c40c7cfaefc8c2d7426..da33bc4ab222a19c805be7bee29c71679041873d 100644 (file)
@@ -63,14 +63,14 @@ namespace System.Web
                        Add (value);
                }
                
-               public SiteMapNodeCollection (SiteMapNode[] values)
+               public SiteMapNodeCollection (SiteMapNode[] value)
                {
-                       AddRangeInternal (values);
+                       AddRangeInternal (value);
                }
                
-               public SiteMapNodeCollection (SiteMapNodeCollection values)
+               public SiteMapNodeCollection (SiteMapNodeCollection value)
                {
-                       AddRangeInternal (values);
+                       AddRangeInternal (value);
                }
                
                internal static SiteMapNodeCollection EmptyCollection {
index e887c76cff90e8d9b772dc41e425cfdcb1ceb24f..e695f8e9db768a428fbe138094d26562418e2b5e 100644 (file)
@@ -58,9 +58,9 @@ namespace System.Web
                        remove { events.AddHandler (traceFinishedEvent, value); }
                }
 
-               public TraceContext (HttpContext Context)
+               public TraceContext (HttpContext context)
                {
-                       _Context = Context;
+                       _Context = context;
                }
 
                internal bool HaveTrace {
@@ -104,34 +104,34 @@ namespace System.Web
                        }
                }
 
-               public void Warn(string msg)
+               public void Warn(string message)
                {
-                       Write (String.Empty, msg, null, true);
+                       Write (String.Empty, message, null, true);
                }
 
-               public void Warn(string category, string msg)
+               public void Warn(string category, string message)
                {
-                       Write (category, msg, null, true);
+                       Write (category, message, null, true);
                }
 
-               public void Warn (string category, string msg, Exception error)
+               public void Warn (string category, string message, Exception errorInfo)
                {
-                       Write (category, msg, error, true);
+                       Write (category, message, errorInfo, true);
                }
 
-               public void Write (string msg)
+               public void Write (string message)
                {
-                       Write (String.Empty, msg, null, false);
+                       Write (String.Empty, message, null, false);
                }
 
-               public void Write (string category, string msg)
+               public void Write (string category, string message)
                {
-                       Write (category, msg, null, false);
+                       Write (category, message, null, false);
                }
 
-               public void Write (string category, string msg, Exception error)
+               public void Write (string category, string message, Exception errorInfo)
                {
-                       Write (category, msg, error, false);
+                       Write (category, message, errorInfo, false);
                }
 
                void Write (string category, string msg, Exception error, bool Warning)
index 4a185f574f231e6a3629fb0bda3f0aac030e3ccc..7bcbb5be4a00b55e60301aa142d029dde853d7a7 100644 (file)
@@ -1,4 +1,4 @@
-//
+//
 // Authors:
 // Jonathan Pobst (monkey@jpobst.com)
 // Francis Fisher (frankie@terrorise.me.uk)
@@ -59,7 +59,7 @@ namespace System.Windows.Forms.DataVisualization.Charting
                        }
                }
                [MonoTODO]
-               public string this[string propName] {
+               public string this[string name] {
                        get { 
                                throw new NotImplementedException ();
                        }
index d64a2a9645b2f88bed2dd535a6a76efb4a0ef87e..89896814ea4d2a33b6c99b11be464a0a216412f0 100755 (executable)
@@ -41,9 +41,9 @@ namespace System.Windows.Markup
                }
 #endif
 
-               public override bool Equals (object other)
+               public override bool Equals (object obj)
                {
-                       var cwa = other as ContentWrapperAttribute;
+                       var cwa = obj as ContentWrapperAttribute;
                        if (cwa == null)
                                return false;
                        return ContentWrapper != null ? ContentWrapper == cwa.ContentWrapper : cwa.ContentWrapper == null;
index 5cd79018f4a6ceb772153e3ee129202eb4c8d747..e6002c386db090d3b176fdf03a7267e57aef7f28 100644 (file)
@@ -105,14 +105,14 @@ namespace System.Xaml.Schema
 
                static readonly char [] comma_or_parens = new char [] {',', '(', ')'};
 
-               public static bool TryParseList (string typeNameList, IXamlNamespaceResolver namespaceResolver, out IList<XamlTypeName> list)
+               public static bool TryParseList (string typeNameList, IXamlNamespaceResolver namespaceResolver, out IList<XamlTypeName> result)
                {
                        if (typeNameList == null)
                                throw new ArgumentNullException ("typeNameList");
                        if (namespaceResolver == null)
                                throw new ArgumentNullException ("namespaceResolver");
 
-                       list = null;
+                       result = null;
                        int idx = 0;
                        int parens = 0;
                        XamlTypeName tn;
@@ -153,7 +153,7 @@ namespace System.Xaml.Schema
                                ret.Add (tn);
                        }
 
-                       list = ret;
+                       result = ret;
                        return true;
                }
 
index 5273358236a3f8e98dd834c0732287e9eda3a7fa..fda91aa3b9ce0a9070049ab0a97a5500a1d8c4c7 100755 (executable)
@@ -56,9 +56,9 @@ namespace System.Xaml.Schema
                public XamlType TargetType { get; private set; }
 
                
-               public static bool operator == (XamlValueConverter<TConverterBase> left, XamlValueConverter<TConverterBase> right)
+               public static bool operator == (XamlValueConverter<TConverterBase> converter1, XamlValueConverter<TConverterBase> converter2)
                {
-                       return IsNull (left) ? IsNull (right) : left.Equals (right);
+                       return IsNull (converter1) ? IsNull (converter2) : converter1.Equals (converter2);
                }
 
                static bool IsNull (XamlValueConverter<TConverterBase> a)
@@ -66,9 +66,9 @@ namespace System.Xaml.Schema
                        return Object.ReferenceEquals (a, null);
                }
 
-               public static bool operator != (XamlValueConverter<TConverterBase> left, XamlValueConverter<TConverterBase> right)
+               public static bool operator != (XamlValueConverter<TConverterBase> converter1, XamlValueConverter<TConverterBase> converter2)
                {
-                       return IsNull (left) ? !IsNull (right) : IsNull (right) || left.ConverterType != right.ConverterType || left.TargetType != right.TargetType || left.Name != right.Name;
+                       return IsNull (converter1) ? !IsNull (converter2) : IsNull (converter2) || converter1.ConverterType != converter2.ConverterType || converter1.TargetType != converter2.TargetType || converter1.Name != converter2.Name;
                }
                
                public bool Equals (XamlValueConverter<TConverterBase> other)
index ad03cbf628324356cdb88b0c3942e3d793b5ee48..4e0f460103958c08ae2e9ce03c066e5066349ef0 100644 (file)
@@ -236,9 +236,9 @@ namespace System.Xaml
                        get { return LookupValueSerializer (); }
                }
 
-               public static bool operator == (XamlMember left, XamlMember right)
+               public static bool operator == (XamlMember xamlMember1, XamlMember xamlMember2)
                {
-                       return IsNull (left) ? IsNull (right) : left.Equals (right);
+                       return IsNull (xamlMember1) ? IsNull (xamlMember2) : xamlMember1.Equals (xamlMember2);
                }
 
                static bool IsNull (XamlMember a)
@@ -246,14 +246,14 @@ namespace System.Xaml
                        return Object.ReferenceEquals (a, null);
                }
 
-               public static bool operator != (XamlMember left, XamlMember right)
+               public static bool operator != (XamlMember xamlMember1, XamlMember xamlMember2)
                {
-                       return !(left == right);
+                       return !(xamlMember1 == xamlMember2);
                }
                
-               public override bool Equals (object other)
+               public override bool Equals (object obj)
                {
-                       var x = other as XamlMember;
+                       var x = obj as XamlMember;
                        return Equals (x);
                }
                
index c8026d195a452f5607331bd1422937c8fcdcd0b9..115de3f7940de8fe65fd499478513639f954c030 100755 (executable)
@@ -83,23 +83,23 @@ namespace System.Xaml
                                Save (xw, instance);
                }
 
-               public static void Save (TextWriter textWriter, object instance)
+               public static void Save (TextWriter writer, object instance)
                {
-                       using (var xw = XmlWriter.Create (textWriter, new XmlWriterSettings () { OmitXmlDeclaration = true, Indent = true }))
+                       using (var xw = XmlWriter.Create (writer, new XmlWriterSettings () { OmitXmlDeclaration = true, Indent = true }))
                                Save (xw, instance);
                }
 
-               public static void Save (XmlWriter xmlWriter, object instance)
+               public static void Save (XmlWriter writer, object instance)
                {
-                       Save (new XamlXmlWriter (xmlWriter, new XamlSchemaContext ()), instance);
+                       Save (new XamlXmlWriter (writer, new XamlSchemaContext ()), instance);
                }
 
-               public static void Save (XamlWriter xamlWriter, object instance)
+               public static void Save (XamlWriter writer, object instance)
                {
-                       if (xamlWriter == null)
-                               throw new ArgumentNullException ("xamlWriter");
-                       var r = new XamlObjectReader (instance, xamlWriter.SchemaContext);
-                       Transform (r, xamlWriter);
+                       if (writer == null)
+                               throw new ArgumentNullException ("writer");
+                       var r = new XamlObjectReader (instance, writer.SchemaContext);
+                       Transform (r, writer);
                }
 
                public static void Transform (XamlReader xamlReader, XamlWriter xamlWriter)
index 6aebc3ebddd8abd38c72924788e64e13aa70613b..0081cca23759dc14af3689877d814df84cb918cf 100755 (executable)
@@ -252,9 +252,9 @@ namespace System.Xaml
                        return stn != null ? stn.Name : Name;
                }
 
-               public static bool operator == (XamlType left, XamlType right)
+               public static bool operator == (XamlType xamlType1, XamlType xamlType2)
                {
-                       return IsNull (left) ? IsNull (right) : left.Equals (right);
+                       return IsNull (xamlType1) ? IsNull (xamlType2) : xamlType1.Equals (xamlType2);
                }
 
                static bool IsNull (XamlType a)
@@ -262,9 +262,9 @@ namespace System.Xaml
                        return Object.ReferenceEquals (a, null);
                }
 
-               public static bool operator != (XamlType left, XamlType right)
+               public static bool operator != (XamlType xamlType1, XamlType xamlType2)
                {
-                       return !(left == right);
+                       return !(xamlType1 == xamlType2);
                }
                
                public bool Equals (XamlType other)
index 4d2a6571d95c795539c7cde22ede9ec74f0ce4a5..ef3be44fd52b5c1f3ee5f91c1cd3b8a1a832bf53 100755 (executable)
@@ -139,9 +139,9 @@ namespace System.Xaml
                        intl.WriteNamespace (namespaceDeclaration);
                }
 
-               public override void WriteStartObject (XamlType xamlType)
+               public override void WriteStartObject (XamlType type)
                {
-                       intl.WriteStartObject (xamlType);
+                       intl.WriteStartObject (type);
                }
                
                public override void WriteValue (object value)
index c6ec61f1af60067e9072385ad0d2f13720d2f9a7..8f66d022a818cdec9e05741f0ccac99c72bb67c5 100644 (file)
@@ -63,9 +63,9 @@ namespace System.Configuration
                        return new ConfigXmlCDataSection (this, data);
                }
 
-               public override XmlComment CreateComment (string comment)
+               public override XmlComment CreateComment (string data)
                {
-                       return new ConfigXmlComment (this, comment);
+                       return new ConfigXmlComment (this, data);
                }
 
                public override XmlElement CreateElement (string prefix, string localName, string namespaceUri)
index 2a711689493251c6ee6350c3534782e8a33a9db8..b4ea085301ebba81ecbd8cbdeb79277bc4e6031c 100644 (file)
@@ -93,9 +93,9 @@ namespace System.Configuration
                        get { return properties; }
                }
 
-               public override bool Equals (object o)
+               public override bool Equals (object settings)
                {
-                       SettingElement e = o as SettingElement;
+                       SettingElement e = settings as SettingElement;
                        if (e == null)
                                return false;
 
index b47afa3cc43f35d3610ec697aa5eaa598487d202..e8a20f502a2875f1648d9248c31de07ac4355990 100644 (file)
@@ -35,9 +35,9 @@ namespace System.Configuration
        {
                SpecialSetting setting;
 
-               public SpecialSettingAttribute (SpecialSetting setting)
+               public SpecialSettingAttribute (SpecialSetting specialSetting)
                {
-                       this.setting = setting;
+                       this.setting = specialSetting;
                }
 
                public SpecialSetting SpecialSetting {
index 64ecf29d541ebf3f43b2b10cfaba008506762b37..82132de9959fbde07ed4c9a0be92d50b2969620a 100644 (file)
@@ -125,34 +125,34 @@ namespace System.Diagnostics {
                        return CounterSampleCalculator.ComputeCounterValue (counterSample, nextCounterSample);
                }
 
-               public override bool Equals (object obj)
+               public override bool Equals (object o)
                {
-                       if (!(obj is CounterSample))
+                       if (!(o is CounterSample))
                                return false;
-                       return Equals ((CounterSample) obj);
+                       return Equals ((CounterSample) o);
                }
 
-               public bool Equals (CounterSample other)
+               public bool Equals (CounterSample sample)
                {
                        return
-                               rawValue == other.rawValue &&
-                               baseValue == other.counterFrequency &&
-                               counterFrequency == other.counterFrequency &&
-                               systemFrequency == other.systemFrequency &&
-                               timeStamp == other.timeStamp &&
-                               timeStamp100nSec == other.timeStamp100nSec &&
-                               counterTimeStamp == other.counterTimeStamp &&
-                               counterType == other.counterType;
+                               rawValue == sample.rawValue &&
+                               baseValue == sample.counterFrequency &&
+                               counterFrequency == sample.counterFrequency &&
+                               systemFrequency == sample.systemFrequency &&
+                               timeStamp == sample.timeStamp &&
+                               timeStamp100nSec == sample.timeStamp100nSec &&
+                               counterTimeStamp == sample.counterTimeStamp &&
+                               counterType == sample.counterType;
                }
 
-               public static bool operator == (CounterSample obj1, CounterSample obj2)
+               public static bool operator == (CounterSample a, CounterSample b)
                {
-                       return obj1.Equals (obj2);
+                       return a.Equals (b);
                }
 
-               public static bool operator != (CounterSample obj1, CounterSample obj2)
+               public static bool operator != (CounterSample a, CounterSample b)
                {
-                       return !obj1.Equals (obj2);
+                       return !a.Equals (b);
                }
 
                public override int GetHashCode ()
index c79752dffe720b925de59c7ac6659d7885ba72db..70cb0df4fcdb5f049e7b1d9f8749f71db0f2e053 100644 (file)
@@ -60,10 +60,10 @@ namespace System.Diagnostics {
                        get { return this; }
                }
 
-               public void CopyTo (EventLogEntry[] eventLogEntries, int index)
+               public void CopyTo (EventLogEntry[] entries, int index)
                {
-                       EventLogEntry[] entries = _impl.GetEntries ();
-                       Array.Copy (entries, 0, eventLogEntries, index, entries.Length);
+                       EventLogEntry[] evLogEntries = _impl.GetEntries ();
+                       Array.Copy (evLogEntries, 0, entries, index, evLogEntries.Length);
                }
 
                public IEnumerator GetEnumerator ()
index d7eeb0469776cd84328dcb5235459ed9402a68f6..46dad17505ba9fba58a28e08d303f562ff2212bf 100644 (file)
@@ -95,11 +95,11 @@ namespace System.Diagnostics
 
                [ComVisible (false)]
                public override void TraceData (TraceEventCache eventCache,
-                                               string source, TraceEventType eventType,
+                                               string source, TraceEventType severity,
                                                int id, object data)
                {
                        EventLogEntryType type;
-                       switch (eventType) {
+                       switch (severity) {
                        case TraceEventType.Critical:
                        case TraceEventType.Error:
                                type = EventLogEntryType.Error;
@@ -116,7 +116,7 @@ namespace System.Diagnostics
 
                [ComVisible (false)]
                public override void TraceData (TraceEventCache eventCache,
-                                               string source, TraceEventType eventType,
+                                               string source, TraceEventType severity,
                                                int id, params object [] data)
                {
                        string s = String.Empty;
@@ -126,23 +126,23 @@ namespace System.Diagnostics
                                        arr [i] = data [i] != null ? data [i].ToString () : String.Empty;
                                s = String.Join (", ", arr);
                        }
-                       TraceData (eventCache, source, eventType, id, s);
+                       TraceData (eventCache, source, severity, id, s);
                }
 
                [ComVisible (false)]
                public override void TraceEvent (TraceEventCache eventCache,
-                                                string source, TraceEventType eventType,
+                                                string source, TraceEventType severity,
                                                 int id, string message)
                {
-                       TraceData (eventCache, source, eventType, id, message);
+                       TraceData (eventCache, source, severity, id, message);
                }
 
                [ComVisible (false)]
                public override void TraceEvent (TraceEventCache eventCache,
-                                                string source, TraceEventType eventType,
+                                                string source, TraceEventType severity,
                                                 int id, string format, params object [] args)
                {
-                       TraceEvent (eventCache, source, eventType, id, format != null ? String.Format (format, args) : null);
+                       TraceEvent (eventCache, source, severity, id, format != null ? String.Format (format, args) : null);
                }
        }
 }
index 9b3fdf9dc5e26a631378240e3aba9405896f8dbd..59544083c38a96a0a74dbbf4769910302b163f83 100644 (file)
@@ -849,13 +849,13 @@ namespace System.Diagnostics
                }
 
                [Obsolete ("Process.Start is not supported on the current platform.", true)]
-               public static Process Start(string fileName, string username, SecureString password, string domain)
+               public static Process Start(string fileName, string userName, SecureString password, string domain)
                {
                        throw new PlatformNotSupportedException ("Process.Start is not supported on the current platform.");
                }
 
                [Obsolete ("Process.Start is not supported on the current platform.", true)]
-               public static Process Start(string fileName, string arguments, string username, SecureString password, string domain)
+               public static Process Start(string fileName, string arguments, string userName, SecureString password, string domain)
                {
                        throw new PlatformNotSupportedException ("Process.Start is not supported on the current platform.");
                }
index 4c41dbdf2e7ea58c0f6de168032ba6525427280f..9d8dd61eb2415641247d742c0cc3f77c7130ed3f 100644 (file)
@@ -193,8 +193,8 @@ namespace System.IO.Compression
                        }
                }
 
-               public override IAsyncResult BeginRead (byte [] buffer, int offset, int count,
-                                                       AsyncCallback cback, object state)
+               public override IAsyncResult BeginRead (byte [] array, int offset, int count,
+                                                       AsyncCallback asyncCallback, object asyncState)
                {
                        if (disposed)
                                throw new ObjectDisposedException (GetType ().FullName);
@@ -202,8 +202,8 @@ namespace System.IO.Compression
                        if (!CanRead)
                                throw new NotSupportedException ("This stream does not support reading");
 
-                       if (buffer == null)
-                               throw new ArgumentNullException ("buffer");
+                       if (array == null)
+                               throw new ArgumentNullException ("array");
 
                        if (count < 0)
                                throw new ArgumentOutOfRangeException ("count", "Must be >= 0");
@@ -211,15 +211,15 @@ namespace System.IO.Compression
                        if (offset < 0)
                                throw new ArgumentOutOfRangeException ("offset", "Must be >= 0");
 
-                       if (count + offset > buffer.Length)
+                       if (count + offset > array.Length)
                                throw new ArgumentException ("Buffer too small. count/offset wrong.");
 
                        ReadMethod r = new ReadMethod (ReadInternal);
-                       return r.BeginInvoke (buffer, offset, count, cback, state);
+                       return r.BeginInvoke (array, offset, count, asyncCallback, asyncState);
                }
 
-               public override IAsyncResult BeginWrite (byte [] buffer, int offset, int count,
-                                                       AsyncCallback cback, object state)
+               public override IAsyncResult BeginWrite (byte [] array, int offset, int count,
+                                                       AsyncCallback asyncCallback, object asyncState)
                {
                        if (disposed)
                                throw new ObjectDisposedException (GetType ().FullName);
@@ -227,8 +227,8 @@ namespace System.IO.Compression
                        if (!CanWrite)
                                throw new InvalidOperationException ("This stream does not support writing");
 
-                       if (buffer == null)
-                               throw new ArgumentNullException ("buffer");
+                       if (array == null)
+                               throw new ArgumentNullException ("array");
 
                        if (count < 0)
                                throw new ArgumentOutOfRangeException ("count", "Must be >= 0");
@@ -236,43 +236,43 @@ namespace System.IO.Compression
                        if (offset < 0)
                                throw new ArgumentOutOfRangeException ("offset", "Must be >= 0");
 
-                       if (count + offset > buffer.Length)
+                       if (count + offset > array.Length)
                                throw new ArgumentException ("Buffer too small. count/offset wrong.");
 
                        WriteMethod w = new WriteMethod (WriteInternal);
-                       return w.BeginInvoke (buffer, offset, count, cback, state);                     
+                       return w.BeginInvoke (array, offset, count, asyncCallback, asyncState);                 
                }
 
-               public override int EndRead(IAsyncResult async_result)
+               public override int EndRead(IAsyncResult asyncResult)
                {
-                       if (async_result == null)
-                               throw new ArgumentNullException ("async_result");
+                       if (asyncResult == null)
+                               throw new ArgumentNullException ("asyncResult");
 
-                       AsyncResult ares = async_result as AsyncResult;
+                       AsyncResult ares = asyncResult as AsyncResult;
                        if (ares == null)
-                               throw new ArgumentException ("Invalid IAsyncResult", "async_result");
+                               throw new ArgumentException ("Invalid IAsyncResult", "asyncResult");
 
                        ReadMethod r = ares.AsyncDelegate as ReadMethod;
                        if (r == null)
-                               throw new ArgumentException ("Invalid IAsyncResult", "async_result");
+                               throw new ArgumentException ("Invalid IAsyncResult", "asyncResult");
 
-                       return r.EndInvoke (async_result);
+                       return r.EndInvoke (asyncResult);
                }
 
-               public override void EndWrite (IAsyncResult async_result)
+               public override void EndWrite (IAsyncResult asyncResult)
                {
-                       if (async_result == null)
-                               throw new ArgumentNullException ("async_result");
+                       if (asyncResult == null)
+                               throw new ArgumentNullException ("asyncResult");
 
-                       AsyncResult ares = async_result as AsyncResult;
+                       AsyncResult ares = asyncResult as AsyncResult;
                        if (ares == null)
-                               throw new ArgumentException ("Invalid IAsyncResult", "async_result");
+                               throw new ArgumentException ("Invalid IAsyncResult", "asyncResult");
 
                        WriteMethod w = ares.AsyncDelegate as WriteMethod;
                        if (w == null)
-                               throw new ArgumentException ("Invalid IAsyncResult", "async_result");
+                               throw new ArgumentException ("Invalid IAsyncResult", "asyncResult");
 
-                       w.EndInvoke (async_result);
+                       w.EndInvoke (asyncResult);
                        return;
                }
 
index 65189c5813f986b05aeac8d71d7bdbd7ed6f5c8a..5fb9d624e855f31c9fcc5cebe307c36b4ad42202 100644 (file)
@@ -696,13 +696,13 @@ namespace System.IO.Ports
                        return encoding.GetString (seen.ToArray ());
                }
 
-               public void Write (string str)
+               public void Write (string text)
                {
                        CheckOpen ();
-                       if (str == null)
-                               throw new ArgumentNullException ("str");
+                       if (text == null)
+                               throw new ArgumentNullException ("text");
                        
-                       byte [] buffer = encoding.GetBytes (str);
+                       byte [] buffer = encoding.GetBytes (text);
                        Write (buffer, 0, buffer.Length);
                }
 
@@ -739,9 +739,9 @@ namespace System.IO.Ports
                        stream.Write (bytes, 0, bytes.Length);
                }
 
-               public void WriteLine (string str)
+               public void WriteLine (string text)
                {
-                       Write (str + new_line);
+                       Write (text + new_line);
                }
 
                void CheckOpen ()
index 2a84e67de361acc803f459bb1f975057bce62f72..df85b0f97c76379d3b012df5f52f7c7d1986faca 100644 (file)
@@ -111,16 +111,16 @@ namespace System.Net.Mail {
                        return av;
                }
 
-               public static AlternateView CreateAlternateViewFromString (string content, Encoding encoding, string mediaType)
+               public static AlternateView CreateAlternateViewFromString (string content, Encoding contentEncoding, string mediaType)
                {
                        if (content == null)
                                throw new ArgumentNullException ("content");
-                       if (encoding == null)
-                               encoding = Encoding.UTF8;
-                       MemoryStream ms = new MemoryStream (encoding.GetBytes (content));
+                       if (contentEncoding == null)
+                               contentEncoding = Encoding.UTF8;
+                       MemoryStream ms = new MemoryStream (contentEncoding.GetBytes (content));
                        ContentType ct = new ContentType ();
                        ct.MediaType = mediaType;
-                       ct.CharSet = encoding.HeaderName;
+                       ct.CharSet = contentEncoding.HeaderName;
                        AlternateView av = new AlternateView (ms, ct);
                        av.TransferEncoding = TransferEncoding.QuotedPrintable;
                        return av;
index 5ffaf6b4bd110ee2dac9486133082dba434a1783..ff342b3cd0f1746e4932a332923b67a016d945d0 100644 (file)
@@ -143,12 +143,12 @@ namespace System.Net.Mail {
 
 #region Methods
                
-               public override bool Equals (object obj)
+               public override bool Equals (object value)
                {
-                       if (obj == null)
+                       if (value == null)
                                return false;
 
-                       return (0 == String.Compare (ToString (), obj.ToString (), StringComparison.OrdinalIgnoreCase));
+                       return (0 == String.Compare (ToString (), value.ToString (), StringComparison.OrdinalIgnoreCase));
                }
 
                public override int GetHashCode ()
index ca658c23d752345e3bbd9f5e7f6fa6434ae1f7ca..19197681a7ed5caad5500a133ca6bfca22560474 100644 (file)
@@ -742,9 +742,9 @@ namespace System.Net.Mail {
                        }
                }
 
-               public void Send (string from, string to, string subject, string body)
+               public void Send (string from, string recipients, string subject, string body)
                {
-                       Send (new MailMessage (from, to, subject, body));
+                       Send (new MailMessage (from, recipients, subject, body));
                }
 
                public Task SendMailAsync (MailMessage message)
@@ -836,9 +836,9 @@ namespace System.Net.Mail {
                        worker.RunWorkerAsync (userToken);
                }
 
-               public void SendAsync (string from, string to, string subject, string body, object userToken)
+               public void SendAsync (string from, string recipients, string subject, string body, object userToken)
                {
-                       SendAsync (new MailMessage (from, to, subject, body), userToken);
+                       SendAsync (new MailMessage (from, recipients, subject, body), userToken);
                }
 
                public void SendAsyncCancel ()
index ceda2dd7b9caa132f07aaf9b3bf42742366c10b1..7dc3e94bc0a74829635a7144e1330ed530895370 100644 (file)
@@ -57,14 +57,14 @@ namespace System.Net.Mail {
                {
                }
 
-               protected SmtpException (SerializationInfo info, StreamingContext context)
-                       : base (info, context)
+               protected SmtpException (SerializationInfo serializationInfo, StreamingContext streamingContext)
+                       : base (serializationInfo, streamingContext)
                {
                        try {
-                               statusCode = (SmtpStatusCode) info.GetValue ("Status", typeof (int));
+                               statusCode = (SmtpStatusCode) serializationInfo.GetValue ("Status", typeof (int));
                        } catch (SerializationException) {
                                //For compliance with previously serialized version:
-                               statusCode = (SmtpStatusCode) info.GetValue ("statusCode", typeof (SmtpStatusCode));
+                               statusCode = (SmtpStatusCode) serializationInfo.GetValue ("statusCode", typeof (SmtpStatusCode));
                        }
                }
 
@@ -91,12 +91,12 @@ namespace System.Net.Mail {
 
                #endregion // Properties
 
-               public override void GetObjectData (SerializationInfo info, StreamingContext context)
+               public override void GetObjectData (SerializationInfo serializationInfo, StreamingContext streamingContext)
                {
-                       if (info == null)
-                               throw new ArgumentNullException ("info");
-                       base.GetObjectData (info, context);
-                       info.AddValue ("Status", statusCode, typeof (int));
+                       if (serializationInfo == null)
+                               throw new ArgumentNullException ("serializationInfo");
+                       base.GetObjectData (serializationInfo, streamingContext);
+                       serializationInfo.AddValue ("Status", statusCode, typeof (int));
                }
                void ISerializable.GetObjectData (SerializationInfo info, StreamingContext context)
                {
index c4dbe9c03416f9904074d69539bdbdb77c6e4b8c..faff2db4dbf1772a8c6c2c1715cd3ffd0c292aa6 100644 (file)
@@ -52,12 +52,12 @@ namespace System.Net.Mail {
                {
                }
 
-               protected SmtpFailedRecipientException (SerializationInfo serializationInfo, StreamingContext streamingContext)
-                       : base (serializationInfo, streamingContext)
+               protected SmtpFailedRecipientException (SerializationInfo info, StreamingContext context)
+                       : base (info, context)
                {
-                       if (serializationInfo == null)
-                               throw new ArgumentNullException ("serializationInfo");
-                       failedRecipient = serializationInfo.GetString ("failedRecipient");
+                       if (info == null)
+                               throw new ArgumentNullException ("info");
+                       failedRecipient = info.GetString ("failedRecipient");
                }
 
                public SmtpFailedRecipientException (SmtpStatusCode statusCode, string failedRecipient) : base (statusCode)
index 6f2e3af8e50d808092b2836f09c10893d703c199..70ac1a324b2d08c37a2b00e2266cbac7c535811d 100644 (file)
@@ -80,12 +80,12 @@ namespace System.Net.Mail {
 
                #region Methods
 
-               public override void GetObjectData (SerializationInfo info, StreamingContext context)
+               public override void GetObjectData (SerializationInfo serializationInfo, StreamingContext streamingContext)
                {
-                       if (info == null)
-                               throw new ArgumentNullException ("info");
-                       base.GetObjectData (info, context);
-                       info.AddValue ("innerExceptions", innerExceptions);
+                       if (serializationInfo == null)
+                               throw new ArgumentNullException ("serializationInfo");
+                       base.GetObjectData (serializationInfo, streamingContext);
+                       serializationInfo.AddValue ("innerExceptions", innerExceptions);
                }
 
                void ISerializable.GetObjectData (SerializationInfo info, StreamingContext context)
index 91d43ad31617cb9019794b41eb6c1264747b01a6..e5d0536e06876efb440c7eedf3a070826fa5ccc5 100644 (file)
@@ -709,11 +709,11 @@ namespace System.Net.Sockets
                        sockares.Complete (acc_socket, total);
                });
 
-               public Socket EndAccept (IAsyncResult result)
+               public Socket EndAccept (IAsyncResult asyncResult)
                {
                        int bytes;
                        byte[] buffer;
-                       return EndAccept (out buffer, out bytes, result);
+                       return EndAccept (out buffer, out bytes, asyncResult);
                }
 
                public Socket EndAccept (out byte[] buffer, out int bytesTransferred, IAsyncResult asyncResult)
@@ -948,7 +948,7 @@ namespace System.Net.Sockets
                        }
                });
 
-               public IAsyncResult BeginConnect (string host, int port, AsyncCallback callback, object state)
+               public IAsyncResult BeginConnect (string host, int port, AsyncCallback requestCallback, object state)
                {
                        ThrowIfDisposedAndClosed ();
 
@@ -961,31 +961,31 @@ namespace System.Net.Sockets
                        if (is_listening)
                                throw new InvalidOperationException ();
 
-                       return BeginConnect (Dns.GetHostAddresses (host), port, callback, state);
+                       return BeginConnect (Dns.GetHostAddresses (host), port, requestCallback, state);
                }
 
-               public IAsyncResult BeginConnect (EndPoint end_point, AsyncCallback callback, object state)
+               public IAsyncResult BeginConnect (EndPoint remoteEP, AsyncCallback callback, object state)
                {
                        ThrowIfDisposedAndClosed ();
 
-                       if (end_point == null)
-                               throw new ArgumentNullException ("end_point");
+                       if (remoteEP == null)
+                               throw new ArgumentNullException ("remoteEP");
                        if (is_listening)
                                throw new InvalidOperationException ();
 
                        SocketAsyncResult sockares = new SocketAsyncResult (this, callback, state, SocketOperation.Connect) {
-                               EndPoint = end_point,
+                               EndPoint = remoteEP,
                        };
 
                        // Bug #75154: Connect() should not succeed for .Any addresses.
-                       if (end_point is IPEndPoint) {
-                               IPEndPoint ep = (IPEndPoint) end_point;
+                       if (remoteEP is IPEndPoint) {
+                               IPEndPoint ep = (IPEndPoint) remoteEP;
                                if (ep.Address.Equals (IPAddress.Any) || ep.Address.Equals (IPAddress.IPv6Any)) {
                                        sockares.Complete (new SocketException ((int) SocketError.AddressNotAvailable), true);
                                        return sockares;
                                }
                                
-                               end_point = RemapIPEndPoint (ep);
+                               remoteEP = RemapIPEndPoint (ep);
                        }
 
                        int error = 0;
@@ -1004,7 +1004,7 @@ namespace System.Net.Sockets
                        bool blk = is_blocking;
                        if (blk)
                                Blocking = false;
-                       Connect_internal (m_Handle, end_point.Serialize (), out error, false);
+                       Connect_internal (m_Handle, remoteEP.Serialize (), out error, false);
                        if (blk)
                                Blocking = true;
 
@@ -1034,7 +1034,7 @@ namespace System.Net.Sockets
                        return sockares;
                }
 
-               public IAsyncResult BeginConnect (IPAddress[] addresses, int port, AsyncCallback callback, object state)
+               public IAsyncResult BeginConnect (IPAddress[] addresses, int port, AsyncCallback requestCallback, object state)
                {
                        ThrowIfDisposedAndClosed ();
 
@@ -1049,7 +1049,7 @@ namespace System.Net.Sockets
                        if (is_listening)
                                throw new InvalidOperationException ();
 
-                       SocketAsyncResult sockares = new SocketAsyncResult (this, callback, state, SocketOperation.Connect) {
+                       SocketAsyncResult sockares = new SocketAsyncResult (this, requestCallback, state, SocketOperation.Connect) {
                                Addresses = addresses,
                                Port = port,
                        };
@@ -1142,11 +1142,11 @@ namespace System.Net.Sockets
                        }
                });
 
-               public void EndConnect (IAsyncResult result)
+               public void EndConnect (IAsyncResult asyncResult)
                {
                        ThrowIfDisposedAndClosed ();
 
-                       SocketAsyncResult sockares = ValidateEndIAsyncResult (result, "EndConnect", "result");
+                       SocketAsyncResult sockares = ValidateEndIAsyncResult (asyncResult, "EndConnect", "asyncResult");
 
                        if (!sockares.IsCompleted)
                                sockares.AsyncWaitHandle.WaitOne();
@@ -1629,21 +1629,21 @@ namespace System.Net.Sockets
                        }
                });
 
-               public IAsyncResult BeginReceiveFrom (byte[] buffer, int offset, int size, SocketFlags socket_flags, ref EndPoint remote_end, AsyncCallback callback, object state)
+               public IAsyncResult BeginReceiveFrom (byte[] buffer, int offset, int size, SocketFlags socketFlags, ref EndPoint remoteEP, AsyncCallback callback, object state)
                {
                        ThrowIfDisposedAndClosed ();
                        ThrowIfBufferNull (buffer);
                        ThrowIfBufferOutOfRange (buffer, offset, size);
 
-                       if (remote_end == null)
-                               throw new ArgumentNullException ("remote_end");
+                       if (remoteEP == null)
+                               throw new ArgumentNullException ("remoteEP");
 
                        SocketAsyncResult sockares = new SocketAsyncResult (this, callback, state, SocketOperation.ReceiveFrom) {
                                Buffer = buffer,
                                Offset = offset,
                                Size = size,
-                               SockFlags = socket_flags,
-                               EndPoint = remote_end,
+                               SockFlags = socketFlags,
+                               EndPoint = remoteEP,
                        };
 
                        QueueIOSelectorJob (ReadSem, sockares.Handle, new IOSelectorJob (IOOperation.Read, BeginReceiveFromCallback, sockares));
@@ -1671,21 +1671,21 @@ namespace System.Net.Sockets
                        sockares.Complete (total);
                });
 
-               public int EndReceiveFrom(IAsyncResult result, ref EndPoint end_point)
+               public int EndReceiveFrom(IAsyncResult asyncResult, ref EndPoint endPoint)
                {
                        ThrowIfDisposedAndClosed ();
 
-                       if (end_point == null)
-                               throw new ArgumentNullException ("remote_end");
+                       if (endPoint == null)
+                               throw new ArgumentNullException ("endPoint");
 
-                       SocketAsyncResult sockares = ValidateEndIAsyncResult (result, "EndReceiveFrom", "result");
+                       SocketAsyncResult sockares = ValidateEndIAsyncResult (asyncResult, "EndReceiveFrom", "asyncResult");
 
                        if (!sockares.IsCompleted)
                                sockares.AsyncWaitHandle.WaitOne();
 
                        sockares.CheckIfThrowDelayedException();
 
-                       end_point = sockares.EndPoint;
+                       endPoint = sockares.EndPoint;
 
                        return sockares.Total;
                }
@@ -2095,7 +2095,7 @@ m_Handle, buffer, offset + sent, size - sent, socketFlags, out nativeError, is_b
                        }
                });
 
-               public IAsyncResult BeginSendTo(byte[] buffer, int offset, int size, SocketFlags socket_flags, EndPoint remote_end, AsyncCallback callback, object state)
+               public IAsyncResult BeginSendTo(byte[] buffer, int offset, int size, SocketFlags socketFlags, EndPoint remoteEP, AsyncCallback callback, object state)
                {
                        ThrowIfDisposedAndClosed ();
                        ThrowIfBufferNull (buffer);
@@ -2105,8 +2105,8 @@ m_Handle, buffer, offset + sent, size - sent, socketFlags, out nativeError, is_b
                                Buffer = buffer,
                                Offset = offset,
                                Size = size,
-                               SockFlags = socket_flags,
-                               EndPoint = remote_end,
+                               SockFlags = socketFlags,
+                               EndPoint = remoteEP,
                        };
 
                        QueueIOSelectorJob (WriteSem, sockares.Handle, new IOSelectorJob (IOOperation.Write, s => BeginSendToCallback ((SocketAsyncResult) s, 0), sockares));
@@ -2140,11 +2140,11 @@ m_Handle, buffer, offset + sent, size - sent, socketFlags, out nativeError, is_b
                        sockares.Complete ();
                }
 
-               public int EndSendTo (IAsyncResult result)
+               public int EndSendTo (IAsyncResult asyncResult)
                {
                        ThrowIfDisposedAndClosed ();
 
-                       SocketAsyncResult sockares = ValidateEndIAsyncResult (result, "EndSendTo", "result");
+                       SocketAsyncResult sockares = ValidateEndIAsyncResult (asyncResult, "EndSendTo", "result");
 
                        if (!sockares.IsCompleted)
                                sockares.AsyncWaitHandle.WaitOne();
index a57c579250ed33e6f27cb11ad04469840f3a06b3..5ca0425eb5af4444e5868505ef30bdac53e1890d 100644 (file)
@@ -1031,9 +1031,9 @@ namespace System.Net
                        return result.Response;
                }
                
-               public Stream EndGetRequestStream (IAsyncResult asyncResult, out TransportContext transportContext)
+               public Stream EndGetRequestStream (IAsyncResult asyncResult, out TransportContext context)
                {
-                       transportContext = null;
+                       context = null;
                        return EndGetRequestStream (asyncResult);
                }
 
index 0debdb9b9b47d24041064d84868dbe94c90153b9..62ae915ca3b7fce7c748b192fa2367417df3e974 100644 (file)
@@ -46,10 +46,10 @@ namespace System.Security.Permissions {
                                _flags = StorePermissionFlags.NoFlags;
                }
 
-               public StorePermission (StorePermissionFlags flags
+               public StorePermission (StorePermissionFlags flag) 
                {
                        // reuse validation by the Flags property
-                       Flags = flags;
+                       Flags = flag;
                }
 
 
@@ -129,14 +129,14 @@ namespace System.Security.Permissions {
                        return ((_flags & ~dp._flags) == 0);
                }
 
-               public override void FromXml (SecurityElement e
+               public override void FromXml (SecurityElement securityElement
                {
                        // General validation in CodeAccessPermission
-                       PermissionHelper.CheckSecurityElement (e, "e", version, version);
+                       PermissionHelper.CheckSecurityElement (securityElement, "securityElement", version, version);
                        // Note: we do not (yet) care about the return value 
                        // as we only accept version 1 (min/max values)
 
-                       string s = e.Attribute ("Flags");
+                       string s = securityElement.Attribute ("Flags");
                        if (s == null)
                                _flags = StorePermissionFlags.NoFlags;
                        else
index 40c11663fab1e1fce0138446c343cc81a4d78519..64469915dff1cc72f5228125ee95f3d2a1bd3fc0 100644 (file)
@@ -302,14 +302,14 @@ namespace MonoTests.System.Net.Mail {
                                Assert.AreEqual (typeof (ArgumentNullException), ex.GetType (), "#2");
                                Assert.IsNull (ex.InnerException, "#3");
                                Assert.IsNotNull (ex.Message, "#4");
-                               Assert.AreEqual ("info", ex.ParamName, "#5");
+                               Assert.AreEqual ("serializationInfo", ex.ParamName, "#5");
                        }
                }
        }
 
        class MySmtpException : SmtpException {
-               public MySmtpException (SerializationInfo info, StreamingContext context)
-                       : base (info, context)
+               public MySmtpException (SerializationInfo serializationInfo, StreamingContext streamingContext)
+                       : base (serializationInfo, streamingContext)
                {
                }
        }
index 7ff0ef376d6f63153adf2fa6ee3212817ca291b2..cf8634c54b77cc4e78c85dfdcd194d4267aeffee 100644 (file)
@@ -27,6 +27,6 @@ using System;
 
 namespace System.ComponentModel {
 
-       public delegate void CurrentChangingEventHandler (object sender, CurrentChangingEventArgs args);
+       public delegate void CurrentChangingEventHandler (object sender, CurrentChangingEventArgs e);
 
 }
index 72bf7779d501992cfca5ba03a9a038e16d926963..04247b244502738e218987625d7d650ef820e719 100644 (file)
@@ -48,16 +48,11 @@ namespace System {
        public static partial class Environment {
 
                /*
-                * This is the version number of the corlib-runtime interface. When
-                * making changes to this interface (by changing the layout
-                * of classes the runtime knows about, changing icall signature or
-                * semantics etc), increment this variable. Also increment the
-                * pair of this variable in the runtime in metadata/appdomain.c.
-                * Changes which are already detected at runtime, like the addition
-                * of icalls, do not require an increment.
+                * This is the version number of the corlib-runtime interface.
+                * It is defined in configure.ac.
                 */
 #pragma warning disable 169
-               private const int mono_corlib_version = 164;
+               private const int mono_corlib_version = Consts.MonoCorlibVersion;
 #pragma warning restore 169
 
                [ComVisible (true)]
index 72276936b08d43266180a2f39e868edb16ffb7ec..3e3d0d3e8f0e716708dd91edbe4a40e9f7c97e22 100644 (file)
@@ -1813,54 +1813,42 @@ namespace System
                                                return;
                                        }
                                }
-                               if (index == 2) {
-                                       if (zero) {
-                                               offset = lens [0] + lens [1] + 2;
-                                               length = format.Length - offset;
-                                               return;
-                                       }
-                                       if (positive) {
-                                               offset = 0;
-                                               length = lens [0];
-                                               return;
-                                       }
-                                       if (lens [1] > 0) {
-                                               positive = true;
-                                               offset = lens [0] + 1;
-                                               length = lens [1];
+                               if (zero) {
+                                       if (index == 2) {
+                                               if (format.Length - lastPos == 0) {
+                                                       offset = 0;
+                                                       length = lens [0];
+                                               } else {
+                                                       offset = lens [0] + lens [1] + 2;
+                                                       length = format.Length - offset;
+                                               }
                                                return;
                                        }
-                                       else {
+
+                                       if (lens [2] == 0) {
                                                offset = 0;
                                                length = lens [0];
-                                               return;
-                                       }
-                               }
-                               if (index == 3) {
-                                       if (zero) {
+                                       } else {
                                                offset = lens [0] + lens [1] + 2;
                                                length = lens [2];
-                                               return;
-                                       }
-                                       if (positive) {
-                                               offset = 0;
-                                               length = lens [0];
-                                               return;
-                                       }
-                                       if (lens [1] > 0) {
-                                               positive = true;
-                                               offset = lens [0] + 1;
-                                               length = lens [1];
-                                               return;
-                                       }
-                                       else {
-                                               offset = 0;
-                                               length = lens [0];
-                                               return;
                                        }
-                               }
 
-                               throw new ArgumentException ();
+                                       return;
+
+                               }
+                               if (positive) {
+                                       offset = 0;
+                                       length = lens [0];
+                                       return;
+                               }
+                               if (lens [1] > 0) {
+                                       positive = true;
+                                       offset = lens [0] + 1;
+                                       length = lens [1];
+                                       return;
+                               }
+                               offset = 0;
+                               length = lens [0];
                        }
 
                        public static CustomInfo Parse (string format, int offset, int length, NumberFormatInfo nfi)
index 8d9a7fb03a02aa9bdcf2a1aff83ab6d1949fcaf3..d9cf780bb22140695c1f2ac537fd82af9eb7d363 100644 (file)
@@ -467,10 +467,14 @@ public class Int32Test
                int hundred = 100;
                int neghund = -100;
                
-               Assert.IsTrue ( hundred.ToString ("#;#") == "100", "#TS1");
-               Assert.IsTrue ( hundred.ToString ("-#;#") == "-100", "#TS2");
-               Assert.IsTrue ( neghund.ToString ("#;#") == "100", "#TS3");
-               Assert.IsTrue ( neghund.ToString ("#;-#") == "-100", "#TS3");
+               Assert.AreEqual ("100", hundred.ToString ("#;#"), "#TS1");
+               Assert.AreEqual ("-100", hundred.ToString ("-#;#"), "#TS2");
+               Assert.AreEqual ("100", neghund.ToString ("#;#"), "#TS3");
+               Assert.AreEqual ("-100", neghund.ToString ("#;-#"), "#TS4");
+               Assert.AreEqual ("3", 0.ToString ("3;;"), "#TS5");
+               Assert.AreEqual ("3", 0.ToString ("3;2;"), "#TS6");
+               Assert.AreEqual ("3", 0.ToString ("3;"), "#TS7");
+               Assert.AreEqual ("3", 0.ToString ("3;;;;;;;"), "#TS8");
        }
        
        [Test]
index dde1cb6bbbdeb0fc1914d9ec1b00d3fd2663753d..0db2fed2633fa06bc8305983cc6b28624636edf0 100644 (file)
@@ -1377,10 +1377,18 @@ namespace CorCompare
                                if (ca.Count != 1)
                                        break;
 
+                               if (mapping == null)
+                                       mapping = new Dictionary<string, object> (StringComparer.Ordinal);
+
                                if (constructor.Parameters[0].ParameterType == constructor.Module.TypeSystem.Boolean) {
-                                       if (mapping == null)
-                                               mapping = new Dictionary<string, object> (StringComparer.Ordinal);
                                        mapping.Add ("Bindable", ca[0].Value);
+                               } else if (constructor.Parameters[0].ParameterType.FullName == "System.ComponentModel.BindableSupport") {
+                                       if ((int)ca[0].Value == 0)
+                                               mapping.Add ("Bindable", false);
+                                       else if ((int)ca[0].Value == 1)
+                                               mapping.Add ("Bindable", true);
+                                       else
+                                               throw new NotImplementedException ();
                                } else {
                                        throw new NotImplementedException ();
                                }
index 3445b1b8d0a125d519e9e975cb7ab7e30aebf318..bcbb6d97fc4e74eaae3d7f4f1c3ad4b0a3e0426b 100644 (file)
@@ -7,4 +7,6 @@ PROGRAM = mdb2ppdb.exe
 LOCAL_MCS_FLAGS =
 LIB_REFS = Mono.Cecil Mono.Cecil.Mdb
 
+NO_INSTALL = yes
+
 include ../../build/executable.make
index 75ebb3fd1340761c70b6e3457f31e46fc9092389..e02eaf6cc7fc28d39f4a4744f033aa234fc5151d 100644 (file)
@@ -154,8 +154,24 @@ EXTRA_DISTFILES = \
        data/Microsoft.VisualBasic.targets \
        data/MSBuild/Microsoft.Build.CommonTypes.xsd \
        data/MSBuild/Microsoft.Build.Core.xsd \
-       data/Portable/Targets/* \
-       data/Portable/Frameworks/v5.0/* \
+       data/Portable/Targets/Microsoft.Portable.Core.props \
+       data/Portable/Targets/Microsoft.Portable.Core.targets \
+       data/Portable/Targets/v4.0/Microsoft.Portable.Common.targets \
+       data/Portable/Targets/v4.0/Microsoft.Portable.CSharp.targets \
+       data/Portable/Targets/v4.0/Microsoft.Portable.VisualBasic.targets \
+       data/Portable/Targets/v4.5/Microsoft.Portable.Common.targets \
+       data/Portable/Targets/v4.5/Microsoft.Portable.CSharp.targets \
+       data/Portable/Targets/v4.5/Microsoft.Portable.VisualBasic.targets \
+       data/Portable/Targets/v4.6/Microsoft.Portable.Common.targets \
+       data/Portable/Targets/v4.6/Microsoft.Portable.CSharp.targets \
+       data/Portable/Targets/v4.6/Microsoft.Portable.VisualBasic.targets \
+       data/Portable/Targets/v5.0/Microsoft.Portable.Common.targets \
+       data/Portable/Targets/v5.0/Microsoft.Portable.CSharp.targets \
+       data/Portable/Targets/v5.0/Microsoft.Portable.VisualBasic.targets \
+       "data/Portable/Frameworks/v5.0/.NET Framework 4.6.xml" \
+       "data/Portable/Frameworks/v5.0/ASP.NET Core 1.0.xml" \
+       "data/Portable/Frameworks/v5.0/FrameworkList.xml" \
+       "data/Portable/Frameworks/v5.0/Windows Universal 10.0.xml" \
        frameworks/net_2.0.xml \
        frameworks/net_3.0.xml \
        frameworks/net_3.5.xml \
index cbfa2c3c24613e59517c70334e04187846770913..81a92adc2e1a3ceb6b36797384d078e8770b7666 100644 (file)
 #include <direct.h>
 #endif
 
-/*
- * This is the version number of the corlib-runtime interface. When
- * making changes to this interface (by changing the layout
- * of classes the runtime knows about, changing icall signature or
- * semantics etc), increment this variable. Also increment the
- * pair of this variable in mscorlib in:
- *       mcs/class/corlib/System/Environment.cs
- *
- * Changes which are already detected at runtime, like the addition
- * of icalls, do not require an increment.
- */
-#define MONO_CORLIB_VERSION 164
-
 typedef struct
 {
        int runtime_count;
@@ -1188,12 +1175,13 @@ add_assemblies_to_domain (MonoDomain *domain, MonoAssembly *ass, GHashTable *ht)
        if (!ht) {
                ht = g_hash_table_new (mono_aligned_addr_hash, NULL);
                destroy_ht = TRUE;
+               for (tmp = domain->domain_assemblies; tmp; tmp = tmp->next) {
+                       g_hash_table_insert (ht, tmp->data, tmp->data);
+               }
        }
 
        /* FIXME: handle lazy loaded assemblies */
-       for (tmp = domain->domain_assemblies; tmp; tmp = tmp->next) {
-               g_hash_table_insert (ht, tmp->data, tmp->data);
-       }
+
        if (!g_hash_table_lookup (ht, ass)) {
                mono_assembly_addref (ass);
                g_hash_table_insert (ht, ass, ass);
@@ -1202,11 +1190,12 @@ add_assemblies_to_domain (MonoDomain *domain, MonoAssembly *ass, GHashTable *ht)
        }
 
        if (ass->image->references) {
-               for (i = 0; ass->image->references [i] != NULL; i++) {
-                       if (ass->image->references [i] != REFERENCE_MISSING)
+               for (i = 0; i < ass->image->nreferences; i++) {
+                       if (ass->image->references[i] && ass->image->references [i] != REFERENCE_MISSING) {
                                if (!g_hash_table_lookup (ht, ass->image->references [i])) {
                                        add_assemblies_to_domain (domain, ass->image->references [i], ht);
                                }
+                       }
                }
        }
        if (destroy_ht)
index 94d041ed0d590e9b7f1dafea9a5ceca322e7580b..aa900409470e52ba1c0b1d51e3ed2ca1608d7215 100644 (file)
@@ -3004,6 +3004,12 @@ assembly_binding_info_parsed (MonoAssemblyBindingInfo *info, void *user_data)
        if (!domain)
                return;
 
+       if (info->has_new_version && mono_assembly_is_problematic_version (info->name, info->new_version.major, info->new_version.minor, info->new_version.build, info->new_version.revision)) {
+               mono_trace (G_LOG_LEVEL_INFO, MONO_TRACE_ASSEMBLY, "Discarding assembly binding to problematic version %s v%d.%d.%d.%d",
+                       info->name, info->new_version.major, info->new_version.minor, info->new_version.build, info->new_version.revision);
+               return;
+       }
+
        for (tmp = domain->assembly_bindings; tmp; tmp = tmp->next) {
                info_tmp = (MonoAssemblyBindingInfo *)tmp->data;
                if (strcmp (info->name, info_tmp->name) == 0 && info_versions_equal (info, info_tmp))
@@ -3381,7 +3387,7 @@ mono_assembly_load_full_nosearch (MonoAssemblyName *aname,
        int len;
 
        aname = mono_assembly_remap_version (aname, &maped_aname);
-       
+
        /* Reflection only assemblies don't get assembly binding */
        if (!refonly)
                aname = mono_assembly_apply_binding (aname, &maped_name_pp);
index 89b744761bf04312b03558dc2459fbbde069d158..4d8cab37139d108d86dc723fcd8c0eb72b798b86 100644 (file)
@@ -390,9 +390,9 @@ static const NumberFormatEntry number_format_entries [] = {
        {1264, 1328, 1264, 1328, 1792, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 11, 1264, 11, 1359, 1337, 1339, 1343, 1795, 1811, 1824, 1357, 8, 3, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 1328, 1264, 1328, 1359, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
-       {1264, 1328, 1264, 1328, 1359, 1337, 1828, 1343, 1831, 1843, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
+       {1264, 1328, 1264, 1328, 1359, 1337, 1828, 1343, 1831, 1843, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {2, -1}, {3, -1}},
        {1264, 1328, 1264, 1328, 1359, 1337, 1339, 1343, 1854, 1865, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
-       {1264, 1328, 1264, 1328, 0, 1337, 0, 1343, 1347, 1311, 55, 1357, 8, 3, 1, 1, 1, 2, 2, {3, 0}, {3, 0}},
+       {1264, 1328, 1264, 1328, 0, 1337, 0, 1343, 1347, 1311, 55, 1357, 8, 3, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {1, 1264, 1, 1264, 1875, 1494, 0, 1296, 1347, 1311, 55, 1357, 3, 0, 0, 0, 3, 2, 2, {3, -1}, {3, -1}},
        {1264, 11, 1264, 11, 1884, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 1888, 1337, 1891, 1343, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
@@ -425,20 +425,20 @@ static const NumberFormatEntry number_format_entries [] = {
        {11, 1264, 11, 1264, 1971, 1337, 1339, 1343, 1347, 1311, 55, 1357, 12, 2, 0, 0, 1, 2, 2, {3, 2}, {3, 2}},
        {11, 1264, 11, 1264, 1971, 1337, 1339, 1343, 1347, 1311, 55, 1357, 12, 2, 0, 0, 1, 2, 2, {3, 2}, {3, 2}},
        {11, 1264, 11, 1264, 1971, 1337, 1339, 1343, 1347, 1311, 55, 1357, 12, 2, 0, 0, 1, 2, 2, {3, 2}, {3, 2}},
-       {11, 1264, 11, 1264, 1971, 1337, 1339, 1343, 1347, 1311, 55, 1357, 12, 2, 2, 2, 1, 2, 2, {3, 2}, {3, 2}},
+       {11, 1264, 11, 1264, 1971, 1337, 1339, 1343, 1347, 1311, 55, 1357, 12, 2, 2, 2, 1, 2, 2, {3, -1}, {3, 2}},
        {11, 1264, 11, 1264, 1971, 1337, 0, 1343, 1347, 1311, 55, 1357, 12, 2, 1, 1, 1, 2, 2, {3, 2}, {3, 2}},
        {2067, 1264, 11, 1264, 1971, 1337, 1339, 1343, 1347, 1311, 55, 1357, 12, 2, 0, 0, 1, 2, 2, {3, 2}, {3, 2}},
        {11, 1264, 11, 1264, 0, 1337, 1339, 1343, 1347, 1311, 55, 1357, 9, 2, 1, 1, 1, 0, 2, {3, -1}, {3, -1}},
-       {11, 1264, 11, 1264, 1380, 1337, 1339, 1343, 1347, 1311, 55, 1357, 2, 0, 1, 1, 1, 2, 2, {3, 0}, {3, 0}},
+       {11, 1264, 11, 1264, 1380, 1337, 1339, 1343, 1347, 1311, 55, 1357, 2, 0, 1, 1, 1, 2, 2, {3, 0}, {3, -1}},
        {11, 1264, 11, 1264, 2069, 1337, 0, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
-       {11, 1264, 11, 1264, 2072, 1337, 1339, 1343, 1347, 1311, 55, 1357, 5, 1, 1, 1, 2, 2, 2, {3, -1}, {3, 0}},
-       {1264, 11, 1264, 11, 2076, 1337, 2080, 1343, 1347, 1311, 55, 1357, 2, 0, 1, 1, 1, 0, 2, {3, 0}, {3, 0}},
+       {11, 1264, 11, 1264, 2072, 1337, 1339, 1343, 1347, 1311, 55, 1357, 5, 1, 1, 1, 2, 2, 2, {3, -1}, {3, -1}},
+       {1264, 11, 1264, 11, 2076, 1337, 2080, 1343, 1347, 1311, 55, 1357, 2, 0, 1, 1, 1, 0, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 2126, 1337, 2128, 1343, 1347, 1311, 55, 1357, 9, 2, 1, 1, 1, 0, 2, {3, -1}, {3, -1}},
        {1264, 11, 1264, 11, 1359, 1337, 1339, 1343, 1466, 1476, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 1971, 1337, 0, 1343, 1347, 1311, 55, 1357, 12, 2, 0, 0, 1, 2, 2, {3, 2}, {3, 2}},
-       {11, 1264, 11, 1264, 2168, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, 2}},
+       {11, 1264, 11, 1264, 2168, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 0, 1337, 1339, 1343, 1347, 1311, 55, 1357, 0, 0, 1, 0, 1, 2, 2, {3, -1}, {3, -1}},
-       {11, 1264, 11, 1264, 2176, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 1, {3, 0}, {3, 0}},
+       {11, 1264, 11, 1264, 2176, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 1, {3, -1}, {3, -1}},
        {1264, 1328, 1264, 1328, 0, 1337, 0, 1343, 1497, 1505, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 2183, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, 2}},
        {1264, 11, 1264, 11, 1359, 1337, 1339, 1343, 1347, 1311, 55, 1357, 11, 2, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
@@ -449,13 +449,13 @@ static const NumberFormatEntry number_format_entries [] = {
        {11, 1264, 11, 1264, 2197, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1328, 11, 1328, 1924, 1337, 0, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 1328, 1264, 1328, 1359, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
-       {1264, 11, 1264, 11, 1411, 1337, 1729, 1343, 1347, 1311, 55, 1357, 12, 2, 0, 0, 1, 2, 2, {3, 0}, {3, 0}},
+       {1264, 11, 1264, 11, 1411, 1337, 1729, 1343, 1347, 1311, 55, 1357, 12, 2, 0, 0, 1, 2, 2, {3, 0}, {3, -1}},
        {11, 1264, 11, 1264, 2197, 1337, 1339, 1296, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 1792, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 2201, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 1464, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 2205, 1337, 0, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 0, 2, {3, -1}, {3, -1}},
-       {11, 1264, 11, 1264, 1380, 1337, 0, 1343, 1347, 1311, 55, 1357, 2, 0, 1, 1, 1, 2, 2, {3, -1}, {3, 0}},
+       {11, 1264, 11, 1264, 1380, 1337, 0, 1343, 1347, 1311, 55, 1357, 2, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 1328, 1264, 1328, 1359, 1337, 0, 1343, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 1539, 1337, 1339, 1343, 1347, 1311, 55, 1357, 2, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 1328, 1264, 1328, 1359, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
@@ -498,9 +498,9 @@ static const NumberFormatEntry number_format_entries [] = {
        {1264, 1328, 1264, 1328, 1792, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 11, 1264, 11, 1359, 1337, 1339, 1343, 1795, 1811, 1824, 1357, 8, 3, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 1328, 1264, 1328, 1359, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
-       {1264, 1328, 1264, 1328, 1359, 1337, 1828, 1343, 1831, 1843, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
+       {1264, 1328, 1264, 1328, 1359, 1337, 1828, 1343, 1831, 1843, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {2, -1}, {3, -1}},
        {1264, 1328, 1264, 1328, 1359, 1337, 1339, 1343, 1854, 1865, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
-       {1264, 1328, 1264, 1328, 1999, 1337, 0, 1343, 1347, 1311, 55, 1357, 8, 3, 1, 1, 1, 2, 2, {3, 0}, {3, 0}},
+       {1264, 1328, 1264, 1328, 1999, 1337, 0, 1343, 1347, 1311, 55, 1357, 8, 3, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {1, 1264, 1, 1264, 1875, 1494, 0, 1296, 1347, 1311, 55, 1357, 3, 0, 0, 0, 3, 0, 2, {3, -1}, {3, -1}},
        {1264, 11, 1264, 11, 1884, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 0, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 1888, 1337, 1891, 1343, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 0, 2, {3, -1}, {3, -1}},
@@ -531,19 +531,19 @@ static const NumberFormatEntry number_format_entries [] = {
        {11, 1264, 11, 1264, 1971, 1337, 1339, 1343, 1347, 1311, 55, 1357, 12, 2, 0, 0, 1, 2, 2, {3, 2}, {3, 2}},
        {11, 1264, 11, 1264, 1971, 1337, 1339, 1343, 1347, 1311, 55, 1357, 12, 2, 0, 0, 1, 2, 2, {3, 2}, {3, 2}},
        {11, 1264, 11, 1264, 1971, 1337, 1339, 1343, 1347, 1311, 55, 1357, 12, 2, 0, 0, 1, 2, 2, {3, 2}, {3, 2}},
-       {11, 1264, 11, 1264, 1971, 1337, 1339, 1343, 1347, 1311, 55, 1357, 12, 2, 2, 2, 1, 2, 2, {3, 2}, {3, 2}},
+       {11, 1264, 11, 1264, 1971, 1337, 1339, 1343, 1347, 1311, 55, 1357, 12, 2, 2, 2, 1, 2, 2, {3, -1}, {3, 2}},
        {11, 1264, 11, 1264, 1971, 1337, 0, 1343, 1347, 1311, 55, 1357, 12, 2, 1, 1, 1, 2, 2, {3, 2}, {3, 2}},
        {2067, 1264, 11, 1264, 1971, 1337, 1339, 1343, 1347, 1311, 55, 1357, 12, 2, 0, 0, 1, 2, 2, {3, 2}, {3, 2}},
        {11, 1264, 11, 1264, 2263, 1337, 1339, 1343, 1347, 1311, 55, 1357, 9, 2, 1, 1, 1, 0, 2, {3, -1}, {3, -1}},
-       {11, 1264, 11, 1264, 1380, 1337, 1339, 1343, 1347, 1311, 55, 1357, 2, 0, 1, 1, 1, 2, 2, {3, 0}, {3, 0}},
+       {11, 1264, 11, 1264, 1380, 1337, 1339, 1343, 1347, 1311, 55, 1357, 2, 0, 1, 1, 1, 2, 2, {3, 0}, {3, -1}},
        {11, 1264, 11, 1264, 2069, 1337, 0, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
-       {11, 1264, 11, 1264, 2072, 1337, 1339, 1343, 1347, 1311, 55, 1357, 5, 1, 1, 1, 2, 2, 2, {3, -1}, {3, 0}},
-       {1264, 11, 1264, 11, 2076, 1337, 2080, 1343, 1347, 1311, 55, 1357, 2, 0, 1, 1, 1, 0, 2, {3, 0}, {3, 0}},
+       {11, 1264, 11, 1264, 2072, 1337, 1339, 1343, 1347, 1311, 55, 1357, 5, 1, 1, 1, 2, 2, 2, {3, -1}, {3, -1}},
+       {1264, 11, 1264, 11, 2076, 1337, 2080, 1343, 1347, 1311, 55, 1357, 2, 0, 1, 1, 1, 0, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 2126, 1337, 2128, 1343, 1347, 1311, 55, 1357, 9, 2, 1, 1, 1, 0, 2, {3, -1}, {3, -1}},
        {1264, 11, 1264, 11, 1359, 1337, 1339, 1343, 1466, 1476, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 1971, 1337, 0, 1343, 1347, 1311, 55, 1357, 12, 2, 0, 0, 1, 2, 2, {3, 2}, {3, 2}},
-       {11, 1264, 11, 1264, 2168, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, 2}},
-       {11, 1264, 11, 1264, 2176, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 1, {3, 0}, {3, 0}},
+       {11, 1264, 11, 1264, 2168, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
+       {11, 1264, 11, 1264, 2176, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 1, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 2267, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, 2}},
        {1264, 11, 1264, 11, 1359, 1337, 1339, 1343, 1347, 1311, 55, 1357, 11, 2, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 11, 1264, 11, 2190, 1494, 1339, 1296, 1753, 1311, 1769, 1777, 8, 3, 1, 1, 1, 0, 2, {3, -1}, {3, -1}},
@@ -552,13 +552,13 @@ static const NumberFormatEntry number_format_entries [] = {
        {11, 1264, 11, 1264, 2197, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1328, 11, 1328, 1924, 1337, 0, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 1328, 1264, 1328, 1359, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
-       {1264, 11, 1264, 11, 1411, 1337, 1729, 1343, 1347, 1311, 55, 1357, 12, 2, 0, 0, 1, 2, 2, {3, 0}, {3, 0}},
+       {1264, 11, 1264, 11, 1411, 1337, 1729, 1343, 1347, 1311, 55, 1357, 12, 2, 0, 0, 1, 2, 2, {3, 0}, {3, -1}},
        {11, 1264, 11, 1264, 2197, 1337, 1339, 1296, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 1792, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 1792, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 1464, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 2205, 1337, 0, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 0, 2, {3, -1}, {3, -1}},
-       {11, 1264, 11, 1264, 1380, 1337, 0, 1343, 1347, 1311, 55, 1357, 2, 0, 1, 1, 1, 2, 2, {3, -1}, {3, 0}},
+       {11, 1264, 11, 1264, 1380, 1337, 0, 1343, 1347, 1311, 55, 1357, 2, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 1328, 1264, 1328, 1359, 1337, 0, 1343, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 1539, 1337, 1339, 1343, 1347, 1311, 55, 1357, 2, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 1328, 1264, 1328, 1359, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
@@ -579,7 +579,7 @@ static const NumberFormatEntry number_format_entries [] = {
        {1264, 11, 1264, 11, 2292, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 1328, 1264, 1328, 2292, 1337, 1645, 1343, 1662, 1690, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 1328, 1264, 1328, 1359, 1337, 1729, 1736, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
-       {11, 1264, 11, 1264, 1971, 1337, 1339, 1343, 1753, 1311, 1769, 1777, 1, 0, 1, 2, 1, 2, 2, {3, -1}, {3, -1}},
+       {11, 1264, 11, 1264, 1971, 1337, 1339, 1343, 1753, 1311, 1769, 1777, 1, 0, 1, 2, 1, 2, 2, {3, 2}, {3, -1}},
        {1264, 1328, 1264, 1328, 2253, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 11, 1264, 11, 1359, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1328, 11, 1328, 2294, 1337, 0, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
@@ -589,7 +589,7 @@ static const NumberFormatEntry number_format_entries [] = {
        {1264, 1328, 1264, 1328, 2296, 1494, 2303, 1296, 1347, 1311, 55, 1357, 9, 2, 1, 1, 1, 0, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 2336, 1337, 1339, 1343, 1347, 1311, 55, 1357, 12, 2, 1, 0, 1, 2, 2, {3, 2}, {3, 2}},
        {11, 1264, 11, 1264, 2340, 1494, 1339, 1296, 1347, 1311, 55, 1517, 9, 2, 9, 3, 2, 0, 2, {3, -1}, {3, -1}},
-       {11, 1264, 11, 1264, 2343, 1337, 1339, 1343, 1347, 1311, 55, 1357, 9, 2, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
+       {11, 1264, 11, 1264, 2343, 1337, 1339, 1343, 1347, 1311, 55, 1357, 9, 2, 1, 1, 1, 2, 2, {3, 2}, {3, 2}},
        {11, 1264, 11, 1264, 1971, 1337, 1339, 1343, 1347, 1311, 55, 1357, 9, 2, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 2201, 1337, 1339, 1343, 1347, 1311, 55, 1357, 1, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 2347, 1276, 1281, 1296, 1299, 1311, 1320, 1324, 3, 2, 0, 0, 3, 2, 2, {3, -1}, {3, -1}},
@@ -667,7 +667,7 @@ static const NumberFormatEntry number_format_entries [] = {
        {11, 1264, 11, 1264, 2292, 1337, 1339, 1343, 1466, 1476, 55, 1357, 1, 0, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 2562, 1337, 1339, 1343, 1466, 1476, 55, 1357, 1, 0, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 1464, 1337, 1339, 1343, 1466, 1476, 55, 1357, 1, 0, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
-       {11, 1264, 11, 1264, 1464, 1337, 1339, 1343, 1466, 1476, 55, 1357, 0, 0, 1, 1, 1, 2, 2, {3, -1}, {3, 0}},
+       {11, 1264, 11, 1264, 1464, 1337, 1339, 1343, 1466, 1476, 55, 1357, 0, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 1464, 1337, 1339, 1343, 1466, 1476, 55, 1357, 1, 0, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 11, 1264, 11, 2423, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 11, 1264, 11, 2373, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
@@ -685,7 +685,7 @@ static const NumberFormatEntry number_format_entries [] = {
        {11, 1264, 11, 1264, 2357, 1337, 2239, 1343, 1347, 1311, 55, 1357, 0, 0, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 1328, 1264, 1328, 1726, 1276, 1339, 1296, 1347, 1311, 55, 1324, 9, 2, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 11, 1264, 11, 2573, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 1, 1, 1, 0, 2, {3, -1}, {3, -1}},
-       {1264, 1328, 1264, 1328, 1999, 1337, 0, 1343, 1347, 1311, 55, 1357, 8, 3, 1, 1, 1, 2, 2, {3, 0}, {3, 0}},
+       {1264, 1328, 1264, 1328, 1999, 1337, 0, 1343, 1347, 1311, 55, 1357, 8, 3, 1, 1, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 11, 1264, 11, 1359, 1337, 1339, 1343, 1347, 1311, 55, 1357, 8, 3, 0, 0, 1, 2, 2, {3, -1}, {3, -1}},
        {1264, 1328, 1264, 1328, 2257, 1494, 2041, 1296, 1347, 1311, 55, 1357, 9, 2, 1, 1, 1, 0, 2, {3, -1}, {3, -1}},
        {11, 1264, 11, 1264, 2340, 1494, 1339, 1296, 1347, 1311, 55, 1517, 9, 2, 9, 3, 2, 2, 2, {3, -1}, {3, -1}},
index d0937fdf70af561b9dcd6d9653a953f985b5a5d8..3cac05ef00e9e8259f8c8f0a5afe872e643f2691 100644 (file)
@@ -814,6 +814,7 @@ mono_method_get_name_full (MonoMethod *method, gboolean signature, gboolean ret,
        char wrapper [64];
        char *klass_desc;
        char *inst_desc = NULL;
+       MonoError error;
 
        if (format == MONO_TYPE_NAME_FORMAT_IL)
                klass_desc = mono_type_full_name (&method->klass->byval_arg);
@@ -858,14 +859,22 @@ mono_method_get_name_full (MonoMethod *method, gboolean signature, gboolean ret,
                strcpy (wrapper, "");
 
        if (signature) {
-               char *tmpsig = mono_signature_get_desc (mono_method_signature (method), TRUE);
+               MonoMethodSignature *sig = mono_method_signature_checked (method, &error);
+               char *tmpsig;
+
+               if (!is_ok (&error)) {
+                       tmpsig = g_strdup_printf ("<unable to load signature>");
+                       mono_error_cleanup (&error);
+               } else {
+                       tmpsig = mono_signature_get_desc (sig, TRUE);
+               }
 
                if (method->wrapper_type != MONO_WRAPPER_NONE)
                        sprintf (wrapper, "(wrapper %s) ", wrapper_type_to_str (method->wrapper_type));
                else
                        strcpy (wrapper, "");
-               if (ret) {
-                       char *ret_str = mono_type_full_name (mono_method_signature (method)->ret);
+               if (ret && sig) {
+                       char *ret_str = mono_type_full_name (sig->ret);
                        res = g_strdup_printf ("%s%s %s:%s%s (%s)", wrapper, ret_str, klass_desc,
                                                                   method->name, inst_desc ? inst_desc : "", tmpsig);
                        g_free (ret_str);
index 0c507f5c1da1301a5ba886ac032240700bb0b143..a886f17f202a3ca66d143279002e952201426fe2 100644 (file)
@@ -1102,7 +1102,7 @@ Mono provides its own implementation of those assemblies so it's safe to do so.
 
 The ignored_assemblies list is generated using tools/nuget-hash-extractor and feeding the problematic nugets to it.
 
-Right now the list of nugets are the ones that provide the assemblies in $ignored_assemblies_names.
+Right now the list of nugets are the ones that provide the assemblies in $ignored_assemblies_file_names.
 
 This is to be removed once a proper fix is shipped through nuget.
 
@@ -1124,7 +1124,12 @@ typedef struct {
        const char guid [40];
 } IgnoredAssembly;
 
-const char *ignored_assemblies_names[] = {
+typedef struct {
+       int assembly_name;
+       guint16 major, minor, build, revision;
+} IgnoredAssemblyVersion;
+
+const char *ignored_assemblies_file_names[] = {
        "System.Runtime.InteropServices.RuntimeInformation.dll",
        "System.Globalization.Extensions.dll",
        "System.IO.Compression.dll",
@@ -1155,6 +1160,54 @@ static const IgnoredAssembly ignored_assemblies [] = {
        IGNORED_ASSEMBLY (0x75B4B041, SYS_VALUE_TUPLE, "F81A4140-A898-4E2B-B6E9-55CE78C273EC", "4.3.0 netstandard1.0"),
 };
 
+
+const char *ignored_assemblies_names[] = {
+       "System.Runtime.InteropServices.RuntimeInformation",
+       "System.Globalization.Extensions",
+       "System.IO.Compression",
+       "System.Net.Http",
+       "System.Text.Encoding.CodePages",
+       "System.Reflection.DispatchProxy",
+       "System.ValueTuple"
+};
+
+#define IGNORED_ASM_VER(NAME, MAJOR, MINOR, BUILD, REVISION) { .assembly_name = NAME, .major = MAJOR, .minor = MINOR, .build = BUILD, .revision = REVISION }
+
+static const IgnoredAssemblyVersion ignored_assembly_versions [] = {
+       IGNORED_ASM_VER (SYS_GLOBALIZATION_EXT, 4, 0, 0, 0),
+       IGNORED_ASM_VER (SYS_GLOBALIZATION_EXT, 4, 0, 1, 0),
+       IGNORED_ASM_VER (SYS_GLOBALIZATION_EXT, 4, 0, 2, 0),
+       IGNORED_ASM_VER (SYS_IO_COMPRESSION, 4, 1, 0, 0),
+       IGNORED_ASM_VER (SYS_IO_COMPRESSION, 4, 1, 2, 0),
+       IGNORED_ASM_VER (SYS_NET_HTTP, 4, 1, 0, 0),
+       IGNORED_ASM_VER (SYS_NET_HTTP, 4, 1, 0, 1),
+       IGNORED_ASM_VER (SYS_NET_HTTP, 4, 1, 1, 0),
+       IGNORED_ASM_VER (SYS_REF_DISP_PROXY, 4, 0, 0, 0),
+       IGNORED_ASM_VER (SYS_REF_DISP_PROXY, 4, 0, 1, 0),
+       IGNORED_ASM_VER (SYS_REF_DISP_PROXY, 4, 0, 2, 0),
+       IGNORED_ASM_VER (SYS_RT_INTEROP_RUNTIME_INFO, 4, 0, 0, 0),
+       IGNORED_ASM_VER (SYS_RT_INTEROP_RUNTIME_INFO, 4, 0, 1, 0),
+       IGNORED_ASM_VER (SYS_TEXT_ENC_CODEPAGES, 4, 0, 1, 0),
+       IGNORED_ASM_VER (SYS_TEXT_ENC_CODEPAGES, 4, 0, 2, 0),
+       IGNORED_ASM_VER (SYS_VALUE_TUPLE, 4, 0, 1, 0),
+};
+
+gboolean
+mono_assembly_is_problematic_version (const char *name, guint16 major, guint16 minor, guint16 build, guint16 revision)
+{
+       return FALSE;
+       for (int i = 0; i < G_N_ELEMENTS (ignored_assembly_versions); ++i) {
+               if (ignored_assembly_versions [i].major != major ||
+                       ignored_assembly_versions [i].minor != minor ||
+                       ignored_assembly_versions [i].build != build ||
+                       ignored_assembly_versions [i].revision != revision)
+                               continue;
+               if (!strcmp (ignored_assemblies_names [ignored_assembly_versions [i].assembly_name], name))
+                       return TRUE;
+       }
+       return FALSE;
+}
+
 /*
 Equivalent C# code:
        static void Main  () {
@@ -1187,7 +1240,7 @@ is_problematic_image (MonoImage *image)
        // Either sort by hash and bseach or use SoA and make the linear search more cache efficient.
        for (int i = 0; i < G_N_ELEMENTS (ignored_assemblies); ++i) {
                if (ignored_assemblies [i].hash == h && !strcmp (image->guid, ignored_assemblies [i].guid)) {
-                       const char *needle = ignored_assemblies_names [ignored_assemblies [i].assembly_name];
+                       const char *needle = ignored_assemblies_file_names [ignored_assemblies [i].assembly_name];
                        size_t needle_len = strlen (needle);
                        size_t asm_len = strlen (image->name);
                        if (asm_len > needle_len && !g_ascii_strcasecmp (image->name + (asm_len - needle_len), needle))
index 5ff20a90e6e6b80c3d23d41ea84a2aeeb51b3ad8..cdd4a301dbad590e1e9187de5d9d558350dda983 100644 (file)
@@ -934,5 +934,8 @@ mono_find_image_set_owner (void *ptr);
 void
 mono_loader_register_module (const char *name, MonoDl *module);
 
+gboolean
+mono_assembly_is_problematic_version (const char *name, guint16 major, guint16 minor, guint16 build, guint16 revision);
+
 #endif /* __MONO_METADATA_INTERNALS_H__ */
 
index 4592dec23c164804b8b72003e49d64372c4aa311..482398288f8e40139c6f997f77069ad163d40f5d 100755 (executable)
@@ -650,7 +650,7 @@ libmonoincludedir = $(includedir)/mono-$(API_VER)/mono/jit
 
 libmonoinclude_HEADERS = jit.h
 
-CSFLAGS = -unsafe -nowarn:0219,0169,0414,0649
+CSFLAGS = -unsafe -nowarn:0219,0169,0414,0649,0618
 
 basic-simd.exe: basic-simd.cs TestDriver.dll
        $(MCS) -out:$@ $(CSFLAGS) $< -r:TestDriver.dll -r:$(CLASS)/Mono.Simd.dll
index 22dc64f95197ac60691c4a89eac17f793438fc2f..59a123ed0573475ceb7e0551c9ee6c1b7171bbfb 100644 (file)
@@ -7597,8 +7597,11 @@ compile_method (MonoAotCompile *acfg, MonoMethod *method)
                return;
        }
        if (cfg->exception_type != MONO_EXCEPTION_NONE) {
-               if (acfg->aot_opts.print_skipped_methods)
+               if (acfg->aot_opts.print_skipped_methods) {
                        printf ("Skip (JIT failure): %s\n", mono_method_get_full_name (method));
+                       if (cfg->exception_message)
+                               printf ("Caused by: %s\n", cfg->exception_message);
+               }
                /* Let the exception happen at runtime */
                return;
        }
index 168e69c3d89f429166eb6f0e0df8a74f1c550698..f8fdcebaf9b220170a913328bda60bf8e77ead3b 100644 (file)
@@ -557,12 +557,12 @@ public class SimdTests {
                if (a.Y != 2)
                        return 2;
 
-               a.X = 500000000000055l;
-               a.Y = -12345678900l;
+               a.X = 500000000000055L;
+               a.Y = -12345678900L;
 
-               if (a.X != 500000000000055l)
+               if (a.X != 500000000000055L)
                        return 3;
-               if (a.Y != -12345678900l)
+               if (a.Y != -12345678900L)
                        return 4;
                return 0;
        }
index dc7b3699b445e3f76dfbd74108cb3c2d9b59d41b..202134e87d88db842088d18b120312df9570d00e 100644 (file)
@@ -63,19 +63,19 @@ typedef struct {
 // instead of RtlInstallFunctionTableCallback. This gives us the benefit to
 // include all needed unwind upon registration.
 typedef DWORD (NTAPI* RtlAddGrowableFunctionTablePtr)(
-    _Out_ PVOID * DynamicTable,
-    _In_reads_(MaximumEntryCount) PRUNTIME_FUNCTION FunctionTable,
-    _In_ DWORD EntryCount,
-    _In_ DWORD MaximumEntryCount,
-    _In_ ULONG_PTR RangeBase,
-    _In_ ULONG_PTR RangeEnd);
+    PVOID * DynamicTable,
+    PRUNTIME_FUNCTION FunctionTable,
+    DWORD EntryCount,
+    DWORD MaximumEntryCount,
+    ULONG_PTR RangeBase,
+    ULONG_PTR RangeEnd);
 
 typedef VOID (NTAPI* RtlGrowFunctionTablePtr)(
-    _Inout_ PVOID DynamicTable,
-    _In_ DWORD NewEntryCount);
+    PVOID DynamicTable,
+    DWORD NewEntryCount);
 
 typedef VOID (NTAPI* RtlDeleteGrowableFunctionTablePtr)(
-    _In_ PVOID DynamicTable);
+    PVOID DynamicTable);
 
 #endif /* HOST_WIN32 */
 
index bccd97d16a30f26b935ece4bae2b85f8d19c0c69..3ecc77cf66b82cbaed40a6f7def0fabaad6591eb 100644 (file)
@@ -864,6 +864,7 @@ MINI_OP(OP_PSUBW_SAT_UN, "psubw_sat_un", XREG, XREG, XREG)
 
 MINI_OP(OP_PMULW, "pmulw", XREG, XREG, XREG)
 MINI_OP(OP_PMULD, "pmuld", XREG, XREG, XREG)
+/* Multiplies two 32 bit numbers into a 64 bit one */
 MINI_OP(OP_PMULQ, "pmulq", XREG, XREG, XREG)
 
 MINI_OP(OP_PMULW_HIGH_UN, "pmul_high_un", XREG, XREG, XREG)
index b85c2242c69e8fc7fb8e2b4ddfce4cb25bdcd6ab..2c96700f4395f523f20bcf7113dbc13b69932110 100644 (file)
@@ -1180,7 +1180,7 @@ mono_arch_create_vars (MonoCompile *cfg)
        if (cfg->method->save_lmf) {
                cfg->create_lmf_var = TRUE;
                cfg->lmf_ir = TRUE;
-#ifndef HOST_WIN32
+#if !defined(HOST_WIN32) && !defined(TARGET_ANDROID)
                cfg->lmf_ir_mono_lmf = TRUE;
 #endif
        }
@@ -5262,24 +5262,18 @@ mono_arch_emit_epilog (MonoCompile *cfg)
                /* check if we need to restore protection of the stack after a stack overflow */
                if (!cfg->compile_aot && mono_arch_have_fast_tls () && mono_tls_get_tls_offset (TLS_KEY_JIT_TLS) != -1) {
                        code = mono_x86_emit_tls_get (code, X86_ECX, mono_tls_get_tls_offset (TLS_KEY_JIT_TLS));
-               } else {
-                       gpointer func = mono_tls_get_tls_getter (TLS_KEY_JIT_TLS, TRUE);
-                       /* FIXME use tls only from IR level */
-                       x86_xchg_reg_reg (code, X86_EAX, X86_ECX, 4);
-                       code = emit_call (cfg, code, MONO_PATCH_INFO_INTERNAL_METHOD, func);
-                       x86_xchg_reg_reg (code, X86_EAX, X86_ECX, 4);
-               }
 
-               /* we load the value in a separate instruction: this mechanism may be
-                * used later as a safer way to do thread interruption
-                */
-               x86_mov_reg_membase (code, X86_ECX, X86_ECX, MONO_STRUCT_OFFSET (MonoJitTlsData, restore_stack_prot), 4);
-               x86_alu_reg_imm (code, X86_CMP, X86_ECX, 0);
-               patch = code;
-               x86_branch8 (code, X86_CC_Z, 0, FALSE);
-               /* note that the call trampoline will preserve eax/edx */
-               x86_call_reg (code, X86_ECX);
-               x86_patch (patch, code);
+                       /* we load the value in a separate instruction: this mechanism may be
+                        * used later as a safer way to do thread interruption
+                        */
+                       x86_mov_reg_membase (code, X86_ECX, X86_ECX, MONO_STRUCT_OFFSET (MonoJitTlsData, restore_stack_prot), 4);
+                       x86_alu_reg_imm (code, X86_CMP, X86_ECX, 0);
+                       patch = code;
+                       x86_branch8 (code, X86_CC_Z, 0, FALSE);
+                       /* note that the call trampoline will preserve eax/edx */
+                       x86_call_reg (code, X86_ECX);
+                       x86_patch (patch, code);
+               }
 
                /* restore caller saved regs */
                if (cfg->used_int_regs & (1 << X86_EBX)) {
index 2240a94cc67521fc623f0b65b7c085152754597b..3782178bed347ce27a16b2c8334f24ef98ef2503 100644 (file)
@@ -1028,13 +1028,15 @@ type_to_pmul_op (MonoType *t)
        case MONO_TYPE_U4:
        case MONO_TYPE_I4:
                return OP_PMULD;
-       case MONO_TYPE_U8:
-       case MONO_TYPE_I8:
-               return OP_PMULQ;
        case MONO_TYPE_R4:
                return OP_MULPS;
        case MONO_TYPE_R8:
                return OP_MULPD;
+       case MONO_TYPE_U8:
+               /* PMULQ multiplies two 32 bit numbers into a 64 bit one */
+               return -1;
+       case MONO_TYPE_I8:
+               return -1;
        default:
                break;
        }
@@ -2148,9 +2150,9 @@ emit_vector_t_intrinsics (MonoCompile *cfg, MonoMethod *cmethod, MonoMethodSigna
        case SN_op_Explicit:
                return simd_intrinsic_emit_cast (intrins, cfg, cmethod, args);
        case SN_Equals:
-               if (fsig->param_count == 1)
+               if (fsig->param_count == 1 && fsig->ret->type == MONO_TYPE_BOOLEAN && mono_metadata_type_equal (fsig->params [0], type))
                        return simd_intrinsic_emit_equality_op (cfg, cmethod, args, type_to_comp_op (etype), SIMD_COMP_EQ);
-               if (fsig->param_count == 2)
+               if (fsig->param_count == 2 && fsig->ret->type == MONO_TYPE_BOOLEAN && mono_metadata_type_equal (fsig->params [0], type) && mono_metadata_type_equal (fsig->params [1], type))
                        return simd_intrinsic_emit_binary_op (cfg, type_to_comp_op (etype), 0, cmethod->klass, fsig->params [0], fsig->params [1], args [0], args [1]);
                break;
 
@@ -2176,16 +2178,16 @@ emit_vector_t_intrinsics (MonoCompile *cfg, MonoMethod *cmethod, MonoMethodSigna
                switch (intrins->name) {
                case SN_GreaterThan:
                        return simd_intrinsic_emit_binary_op (cfg, gt_op, 0, cmethod->klass, fsig->params [0], fsig->params [1], args [0], args [1]);
-               case SN_LessThanOrEqual:
+               case SN_LessThan:
                        return simd_intrinsic_emit_binary_op (cfg, gt_op, 0, cmethod->klass, fsig->params [0], fsig->params [1], args [1], args [0]);
+               case SN_LessThanOrEqual:
+                       cmp1 = simd_intrinsic_emit_binary_op (cfg, eq_op, 0, cmethod->klass, fsig->params [0], fsig->params [1], args [1], args [0]);
+                       cmp2 = simd_intrinsic_emit_binary_op (cfg, gt_op, 0, cmethod->klass, fsig->params [0], fsig->params [1], args [1], args [0]);
+                       return simd_intrinsic_emit_binary_op (cfg, OP_POR, 0, cmethod->klass, fsig->params [0], fsig->params [1], cmp1, cmp2);
                case SN_GreaterThanOrEqual:
                        cmp1 = simd_intrinsic_emit_binary_op (cfg, eq_op, 0, cmethod->klass, fsig->params [0], fsig->params [1], args [0], args [1]);
                        cmp2 = simd_intrinsic_emit_binary_op (cfg, gt_op, 0, cmethod->klass, fsig->params [0], fsig->params [1], args [0], args [1]);
                        return simd_intrinsic_emit_binary_op (cfg, OP_POR, 0, cmethod->klass, fsig->params [0], fsig->params [1], cmp1, cmp2);
-               case SN_LessThan:
-                       cmp1 = simd_intrinsic_emit_binary_op (cfg, eq_op, 0, cmethod->klass, fsig->params [0], fsig->params [1], args [1], args [0]);
-                       cmp2 = simd_intrinsic_emit_binary_op (cfg, gt_op, 0, cmethod->klass, fsig->params [0], fsig->params [1], args [1], args [0]);
-                       return simd_intrinsic_emit_binary_op (cfg, OP_POR, 0, cmethod->klass, fsig->params [0], fsig->params [1], cmp1, cmp2);
                default:
                        g_assert_not_reached ();
                        break;
index 36ec4a4e0bb5d97e2b67b3bb06cc8d405eed660a..07822b8d62b8695f1dbde2d70663f22e597288af 100644 (file)
@@ -60,6 +60,16 @@ mono_sigctx_to_monoctx (void *sigctx, MonoContext *mctx)
        mctx->esi = UCONTEXT_REG_ESI (ctx);
        mctx->edi = UCONTEXT_REG_EDI (ctx);
        mctx->eip = UCONTEXT_REG_EIP (ctx);
+#ifdef UCONTEXT_REG_XMM
+       mctx->fregs [0] = UCONTEXT_REG_XMM0 (ctx);
+       mctx->fregs [1] = UCONTEXT_REG_XMM1 (ctx);
+       mctx->fregs [2] = UCONTEXT_REG_XMM2 (ctx);
+       mctx->fregs [3] = UCONTEXT_REG_XMM3 (ctx);
+       mctx->fregs [4] = UCONTEXT_REG_XMM4 (ctx);
+       mctx->fregs [5] = UCONTEXT_REG_XMM5 (ctx);
+       mctx->fregs [6] = UCONTEXT_REG_XMM6 (ctx);
+       mctx->fregs [7] = UCONTEXT_REG_XMM7 (ctx);
+#endif
 #elif defined(HOST_WIN32)
        CONTEXT *context = (CONTEXT*)sigctx;
 
@@ -106,6 +116,16 @@ mono_monoctx_to_sigctx (MonoContext *mctx, void *sigctx)
        UCONTEXT_REG_ESI (ctx) = mctx->esi;
        UCONTEXT_REG_EDI (ctx) = mctx->edi;
        UCONTEXT_REG_EIP (ctx) = mctx->eip;
+#ifdef UCONTEXT_REG_XMM
+       UCONTEXT_REG_XMM0 (ctx) = mctx->fregs [0];
+       UCONTEXT_REG_XMM1 (ctx) = mctx->fregs [1];
+       UCONTEXT_REG_XMM2 (ctx) = mctx->fregs [2];
+       UCONTEXT_REG_XMM3 (ctx) = mctx->fregs [3];
+       UCONTEXT_REG_XMM4 (ctx) = mctx->fregs [4];
+       UCONTEXT_REG_XMM5 (ctx) = mctx->fregs [5];
+       UCONTEXT_REG_XMM6 (ctx) = mctx->fregs [6];
+       UCONTEXT_REG_XMM7 (ctx) = mctx->fregs [7];
+#endif
 #elif defined(HOST_WIN32)
        CONTEXT *context = (CONTEXT*)sigctx;
 
index 6e7cf7bd442e212121babd370ef644db76fb971d..dea2a526f81af4fff9ddc66d934732cf0c6cb9b7 100644 (file)
@@ -192,7 +192,7 @@ typedef struct {
                                [xmm4] MONO_CONTEXT_OFFSET (fregs, X86_XMM4, MonoContextSimdReg), \
                                [xmm5] MONO_CONTEXT_OFFSET (fregs, X86_XMM5, MonoContextSimdReg), \
                                [xmm6] MONO_CONTEXT_OFFSET (fregs, X86_XMM6, MonoContextSimdReg), \
-                               [xmm7] MONO_CONTEXT_OFFSET (fregs, X86_XMM7, MonoContextSimdReg), \
+                               [xmm7] MONO_CONTEXT_OFFSET (fregs, X86_XMM7, MonoContextSimdReg)); \
        } while (0)
 #else
 #define MONO_CONTEXT_GET_CURRENT_FREGS(ctx)
index 643bb4d7709a9f7299bd8b039e7665d6e058921c..c63f7d3f420d059bc9caf696c879c9488032ed3f 100644 (file)
        #define UCONTEXT_REG_ESI(ctx) (((ucontext_t*)(ctx))->uc_mcontext->__ss.__esi)
        #define UCONTEXT_REG_EDI(ctx) (((ucontext_t*)(ctx))->uc_mcontext->__ss.__edi)
        #define UCONTEXT_REG_EIP(ctx) (((ucontext_t*)(ctx))->uc_mcontext->__ss.__eip)
+       #define UCONTEXT_REG_XMM
+       #define UCONTEXT_REG_XMM0(ctx) (((ucontext_t*)(ctx))->uc_mcontext->__fs.__fpu_xmm0)
+       #define UCONTEXT_REG_XMM1(ctx) (((ucontext_t*)(ctx))->uc_mcontext->__fs.__fpu_xmm1)
+       #define UCONTEXT_REG_XMM2(ctx) (((ucontext_t*)(ctx))->uc_mcontext->__fs.__fpu_xmm2)
+       #define UCONTEXT_REG_XMM3(ctx) (((ucontext_t*)(ctx))->uc_mcontext->__fs.__fpu_xmm3)
+       #define UCONTEXT_REG_XMM4(ctx) (((ucontext_t*)(ctx))->uc_mcontext->__fs.__fpu_xmm4)
+       #define UCONTEXT_REG_XMM5(ctx) (((ucontext_t*)(ctx))->uc_mcontext->__fs.__fpu_xmm5)
+       #define UCONTEXT_REG_XMM6(ctx) (((ucontext_t*)(ctx))->uc_mcontext->__fs.__fpu_xmm6)
+       #define UCONTEXT_REG_XMM7(ctx) (((ucontext_t*)(ctx))->uc_mcontext->__fs.__fpu_xmm7)
 #  else
        #define UCONTEXT_REG_EAX(ctx) (((ucontext_t*)(ctx))->uc_mcontext->ss.eax)
        #define UCONTEXT_REG_EBX(ctx) (((ucontext_t*)(ctx))->uc_mcontext->ss.ebx)
index e6afb26d8ff37979b08de265bda5f08c04d6ce23..d3729144a610939269165092422bce631af42d6a 100755 (executable)
@@ -22,6 +22,7 @@ IF NOT %ERRORLEVEL% == 0 (
        ECHO copy %WIN_CONFIG_H% %CONFIG_H%
        copy %WIN_CONFIG_H% %CONFIG_H%
        %windir%\system32\WindowsPowerShell\v1.0\powershell.exe -NonInteractive -Command "(Get-Content %CONFIG_H%) -replace '#MONO_VERSION#', (Select-String -path %CONFIGURE_AC% -pattern 'AC_INIT\(mono, \[(.*)\]').Matches[0].Groups[1].Value | Set-Content %CONFIG_H%" 2>&1
+       %windir%\system32\WindowsPowerShell\v1.0\powershell.exe -NonInteractive -Command "$mono_version=[int[]](Select-String -path %CONFIGURE_AC% -pattern 'AC_INIT\(mono, \[(.*)\]').Matches[0].Groups[1].Value.Split('.'); $corlib_counter=[int](Select-String -path %CONFIGURE_AC% -pattern 'MONO_CORLIB_COUNTER=(.*)').Matches[0].Groups[1].Value; (Get-Content %CONFIG_H%) -replace '#MONO_CORLIB_VERSION#',('1{0:00}{1:00}{2:00}{3:000}' -f $mono_version[0],$mono_version[1],$mono_version[2],$corlib_counter) | Set-Content %CONFIG_H%" 2>&1
 )
 
 %windir%\system32\WindowsPowerShell\v1.0\powershell.exe -executionpolicy bypass -NonInteractive -File compare-config-files.ps1 %EGLIB_WIN_CONFIG_H% %EGLIB_CONFIG_H% 2>&1
index 0ccce3ad57e095ad8c8fee3a58c6c0a5c453d76c..980f4322c14fae2f19df47dc5af7e9f23c42b3c9 100644 (file)
@@ -464,7 +464,7 @@ namespace Mono.Tools.LocaleBuilder
                };
 
                static readonly Dictionary<int, string[][]> GroupSizes = new Dictionary<int, string[][]> {
-                       { 0x0028, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
+                       { 0x0026, new [] { new [] { "2" }, new [] { "3" }, new [] { "3" } } },
                        { 0x0039, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x0045, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x0046, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
@@ -473,23 +473,16 @@ namespace Mono.Tools.LocaleBuilder
                        { 0x0049, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x004a, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x004b, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
-                       { 0x004c, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
+                       { 0x004c, new [] { new [] { "3" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x004d, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x004e, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x004f, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
-                       { 0x0051, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x0053, new [] { new [] { "3" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x0054, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
+                       { 0x0051, new [] { new [] { "3", "0" }, new [] { "3" }, new [] { "3" } } },
                        { 0x0057, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
-                       { 0x005b, new [] { new [] { "3" }, new [] { "3", "2" }, new [] { "3", "2" } } },
-                       { 0x005d, new [] { new [] { "3" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x005e, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
+                       { 0x0060, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x0061, new [] { new [] { "3" }, new [] { "3", "2" }, new [] { "3", "2" } } },
-                       { 0x006d, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x006f, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x0078, new [] { new [] { "3" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x007c, new [] { new [] { "3" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x0428, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
+                       { 0x006f, new [] { new [] { "3", "0" }, new [] { "3" }, new [] { "3" } } },
+                       { 0x0426, new [] { new [] { "2" }, new [] { "3" }, new [] { "3" } } },
                        { 0x0439, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x0445, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x0446, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
@@ -498,31 +491,24 @@ namespace Mono.Tools.LocaleBuilder
                        { 0x0449, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x044a, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x044b, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
-                       { 0x044c, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
+                       { 0x044c, new [] { new [] { "3" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x044d, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x044e, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x044f, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
-                       { 0x0451, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x0453, new [] { new [] { "3" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x0454, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
+                       { 0x0451, new [] { new [] { "3", "0" }, new [] { "3" }, new [] { "3" } } },
                        { 0x0457, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
-                       { 0x045b, new [] { new [] { "3" }, new [] { "3", "2" }, new [] { "3", "2" } } },
-                       { 0x045d, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x045e, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
+                       { 0x0460, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x0461, new [] { new [] { "3" }, new [] { "3", "2" }, new [] { "3", "2" } } },
-                       { 0x046d, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x046f, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x0478, new [] { new [] { "3" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x047c, new [] { new [] { "3" }, new [] { "3", "0" }, new [] { "3", "0" } } },
+                       { 0x046f, new [] { new [] { "3", "0" }, new [] { "3" }, new [] { "3" } } },
+                       { 0x0820, new [] { new [] { "3", "2" }, new [] { "3" }, new [] { "3" } } },
                        { 0x0845, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
+                       { 0x0849, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x0850, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x085d, new [] { new [] { "3" }, new [] { "3", "0" }, new [] { "3", "0" } } },
+                       { 0x0860, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
+                       { 0x0c50, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
+                       { 0x0c51, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
                        { 0x4009, new [] { new [] { "3", "2" }, new [] { "3", "2" }, new [] { "3", "2" } } },
-                       { 0x540a, new [] { new [] { "3" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x785d, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x7c28, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
                        { 0x7c50, new [] { new [] { "3", "0" }, new [] { "3", "0" }, new [] { "3", "0" } } },
-                       { 0x7c5d, new [] { new [] { "3" }, new [] { "3", "0" }, new [] { "3", "0" } } },
                };
 
                static readonly Dictionary<int, string[]> Text = new Dictionary<int, string[]> {
index 1d52b77c0cf11ca21ed8ab645b9f618491c92de6..371aca44bbfd05a69f6cf936406bda325d4b17c5 100644 (file)
@@ -4,10 +4,19 @@ SOURCES = \
 nuget-hash-extractor.exe: $(SOURCES)
         mcs /r:System.Xml.Linq  /r:System.IO.Compression -o:nuget-hash-extractor.exe $(SOURCES)
 
-download:
+.download_stamp_file: Makefile download.sh
        echo "Downloading all the nugets";      \
        ./download.sh
 
-run: nuget-hash-extractor.exe
+download: .download_stamp_file
+
+run: nuget-hash-extractor.exe .download_stamp_file
        mono nuget-hash-extractor.exe nugets
+
+run-asm: nuget-hash-extractor.exe .download_stamp_file
+       mono nuget-hash-extractor.exe nugets asm
+
+run-ver: nuget-hash-extractor.exe .download_stamp_file
+       mono nuget-hash-extractor.exe nugets ver
+
 .PHONY: download run
index f79ee5f351c058841e6f5b8c40d509aad0858dda..a16a3bfac027d6d142480187bc0dcf2d84f6de13 100755 (executable)
@@ -33,4 +33,6 @@ wget https://www.nuget.org/api/v2/package/System.Reflection.DispatchProxy/4.0.0
 #System.ValueTuple
 wget https://www.nuget.org/api/v2/package/System.ValueTuple/4.3.0 -O nugets/system.valuetuple.4.3.0.nupkg
 
-#System.Security.Cryptography.OpenSsl when .net 4.6.2 + 1 is out
\ No newline at end of file
+#System.Security.Cryptography.OpenSsl when .net 4.6.2 + 1 is out
+
+touch .download_stamp_file
\ No newline at end of file
index 013097f83c8e9c1a21c27d07e423300605f6f83c..96b4b7c8c91e9ca0e010acfca6062e81327a92c6 100644 (file)
@@ -33,7 +33,16 @@ class Driver {
                        LoadAndDump (et, version);
                }
        }
+
+       static bool dump_asm, dump_ver;
        static void Main (string[] args) {
+
+               if (args.Length > 1) {
+                       dump_asm = args [1].Equals ("asm");
+                       dump_ver = args [1].Equals ("ver");
+               } else {
+                       dump_asm = true;
+               }
                foreach (var f in Directory.GetFiles (args [0], "*.nupkg")) {
                        DumpNuget (f);
                }
@@ -52,12 +61,13 @@ class Driver {
                var data = StreamToArray (entry.Open ());
                AppDomain ad = AppDomain.CreateDomain ("parse_" + ++domain_id);
                DoParse p = (DoParse)ad.CreateInstanceAndUnwrap (typeof (DoParse).Assembly.FullName, typeof (DoParse).FullName);
-               p.ParseAssembly (data, version, entry.Name, entry.FullName);
+               p.ParseAssembly (data, version, entry.Name, entry.FullName, dump_asm, dump_ver);
                AppDomain.Unload (ad);
        }
 }
 
 class DoParse : MarshalByRefObject {
+
        static int Hash (string str) {
                int h = 5381;
         for (int i = 0;  i < str.Length; ++i)
@@ -82,7 +92,7 @@ class DoParse : MarshalByRefObject {
                return parts[parts.Length - 2];
        }
 
-       public void ParseAssembly (byte[] data, string version, string name, string fullname) {
+       public void ParseAssembly (byte[] data, string version, string name, string fullname, bool dump_asm, bool dump_ver) {
                var a = Assembly.ReflectionOnlyLoad (data);
                var m = a.GetModules ()[0];
                var id = m.ModuleVersionId.ToString ().ToUpper ();
@@ -91,6 +101,13 @@ class DoParse : MarshalByRefObject {
 
                string ver_str = version + " " + FileToMoniker (fullname);      
 
-               Console.WriteLine ($"IGNORED_ASSEMBLY (0x{hash_code}, {str}, \"{id}\", \"{ver_str}\"),");
+               if (dump_asm)
+                       Console.WriteLine ($"IGNORED_ASSEMBLY (0x{hash_code}, {str}, \"{id}\", \"{ver_str}\"),");
+
+               //IGNORED_ASM_VER (SYS_IO_COMPRESSION, 4, 1, 2, 0),
+               var ver = a.GetName ().Version;
+               if (dump_ver)
+                       Console.WriteLine ($"IGNORED_ASM_VER ({str}, {ver.Major}, {ver.Minor}, {ver.Build}, {ver.Revision}),");
+               
        }
 }
\ No newline at end of file
index 37a232b6a53a1715de5a96064b544663f18252ad..6a4873657aa8d012c32b2183dcf7efaeaf2ac680 100644 (file)
 
 /* Version number of package */
 #define VERSION "#MONO_VERSION#"
+
+/* Version of the corlib-runtime interface */
+#define MONO_CORLIB_VERSION #MONO_CORLIB_VERSION#
+
 #endif