mono.git
8 years agoMerge pull request #2869 from BrzVlad/feature-mod-union-opt
Vlad Brezae [Thu, 21 Apr 2016 13:53:02 +0000 (16:53 +0300)]
Merge pull request #2869 from BrzVlad/feature-mod-union-opt

[sgen] Optimize mod union usage

8 years agoMerge pull request #2935 from kumpera/new-gc-test
monojenkins [Thu, 21 Apr 2016 07:45:27 +0000 (08:45 +0100)]
Merge pull request #2935 from kumpera/new-gc-test

[sgen] Add regression test for the interaction between the bridge and handles.

The bridge code was triggering handles to be considered deallocated thus leading
them to be overwritten.

8 years agoMerge pull request #2932 from ludovic-henry/fix-waithandle-remoting
monojenkins [Thu, 21 Apr 2016 06:30:26 +0000 (07:30 +0100)]
Merge pull request #2932 from ludovic-henry/fix-waithandle-remoting

[corlib] Ifdef out calls to SynchronizationAttribute on monotouch

When WaitHandle was imported from referencesource in f6fa8f0, the code was refactored and basically all WaitHandle.Wait* calls end up in WaitOneNative or WaitMultiple now.

On monotouch those methods threw a NotSupportedException when exitContext == true even before the import, so this behavior got inherited to some other methods that didn't throw after the exception was removed from them in 93e31cb. This broke tests in maccore and other code that passed exitContext=true.

To fix this, we just ifdef out the calls to SynchronizationAttribute on monotouch since they don't make sense there anyway since remoting isn't available. The commit that initially added the exception in 2ce9fc1 only did that to make the behavior consistent when the linker is enabled. By removing the calls we get the same result.

Do the same for Monitor so we're consistent.

commit message from @akoeplinger

8 years agoMerge pull request #2880 from kumpera/fix_5644
monojenkins [Wed, 20 Apr 2016 22:50:38 +0000 (23:50 +0100)]
Merge pull request #2880 from kumpera/fix_5644

[verifier] Do method visibility checks for virtual final methods. Enable type visibility for all methods. Fixes #5644.

I cannot repro the issue mentioned in the comments of mono_method_can_access_method.

* FIXME:
* with generics calls to explicit interface implementations can be expressed
* directly: the method is private, but we must allow it. This may be opening
* a hole or the generics code should handle this differently.
* Maybe just ensure the interface type is public.

@monojenkins merge

8 years ago[sgen] Add regression test for the interaction between the bridge and handles.
Rodrigo Kumpera [Wed, 20 Apr 2016 22:15:18 +0000 (15:15 -0700)]
[sgen] Add regression test for the interaction between the bridge and handles.

The bridge code was triggering handles to be considered deallocated thus leading
them to be overwritten.

8 years ago[docs] Added index.xml entry for CFNetworkHandler. (#2930)
Joel Martinez [Wed, 20 Apr 2016 20:51:37 +0000 (16:51 -0400)]
[docs] Added index.xml entry for CFNetworkHandler. (#2930)

This particular piece of documentation is added manually, because it's not in the regular BCL library, but is provided by Xamarin on the iOS platform. Because it was missing an entry in the index file, it was excluded from the published documentation when doing mdoc assemble.

8 years agoMerge pull request #2934 from vargaz/fix-36852
Zoltan Varga [Wed, 20 Apr 2016 20:14:44 +0000 (16:14 -0400)]
Merge pull request #2934 from vargaz/fix-36852

[sgen] Avoid returning NULL from null_link_if (), that means an empty…

8 years ago[corlib] Ifdef out calls to SynchronizationAttribute on monotouch
Ludovic Henry [Wed, 20 Apr 2016 15:38:34 +0000 (17:38 +0200)]
[corlib] Ifdef out calls to SynchronizationAttribute on monotouch

When WaitHandle was imported from referencesource in f6fa8f0, the code was refactored and basically all WaitHandle.Wait* calls end up in WaitOneNative or WaitMultiple now.

On monotouch those methods threw a NotSupportedException when exitContext == true even before the import, so this behavior got inherited to some other methods that didn't throw after the exception was removed from them in 93e31cb. This broke tests in maccore and other code that passed exitContext=true.

To fix this, we just ifdef out the calls to SynchronizationAttribute on monotouch since they don't make sense there anyway since remoting isn't available. The commit that initially added the exception in 2ce9fc1 only did that to make the behavior consistent when the linker is enabled. By removing the calls we get the same result.

Do the same for Monitor so we're consistent.

8 years ago[sgen] Avoid returning NULL from null_link_if (), that means an empty slot, not a...
Zoltan Varga [Wed, 20 Apr 2016 18:53:45 +0000 (14:53 -0400)]
[sgen] Avoid returning NULL from null_link_if (), that means an empty slot, not a handle pointing to null. Fixes #36852.

8 years agoWIP fix the previous issue.
Rodrigo Kumpera [Wed, 20 Apr 2016 17:14:46 +0000 (10:14 -0700)]
WIP fix the previous issue.

8 years agoWIP - don't merge
Rodrigo Kumpera [Tue, 19 Apr 2016 21:30:19 +0000 (14:30 -0700)]
WIP - don't merge

8 years ago[verifier] Do method visibility checks for virtual final methods. Enable type visibil...
Rodrigo Kumpera [Thu, 14 Apr 2016 00:41:20 +0000 (17:41 -0700)]
[verifier] Do method visibility checks for virtual final methods. Enable type visibility for all methods. Fixes #5644.

I cannot repro the issue mentioned in the comments of mono_method_can_access_method.

* FIXME:
* with generics calls to explicit interface implementations can be expressed
* directly: the method is private, but we must allow it. This may be opening
* a hole or the generics code should handle this differently.
* Maybe just ensure the interface type is public.

8 years ago[build] Add missing empty assemblies needed by default csc config
Marek Safar [Wed, 20 Apr 2016 15:27:50 +0000 (17:27 +0200)]
[build] Add missing empty assemblies needed by default csc config

8 years ago[profile] Fix a regression from last commit.
Rodrigo Kumpera [Wed, 20 Apr 2016 15:21:28 +0000 (08:21 -0700)]
[profile] Fix a regression from last commit.

8 years agoMerge pull request #2859 from lambdageek/dev/monoerror-object-c
Aleksey Kliger (λgeek) [Wed, 20 Apr 2016 14:46:47 +0000 (10:46 -0400)]
Merge pull request #2859 from lambdageek/dev/monoerror-object-c

[runtime] Grab bag of MonoError fixes in object.c

8 years ago[mcs] Fixes crash during conversion error reporting. Fixes #40536
Marek Safar [Wed, 20 Apr 2016 13:56:46 +0000 (15:56 +0200)]
[mcs] Fixes crash during conversion error reporting. Fixes #40536

8 years ago[mcs] null operator receiver type needs to be convertible to null. Fixes #40493
Marek Safar [Wed, 20 Apr 2016 12:23:19 +0000 (14:23 +0200)]
[mcs] null operator receiver type needs to be convertible to null. Fixes #40493

8 years ago[tools] Fixes compiler tester error messages verification
Marek Safar [Wed, 20 Apr 2016 12:18:29 +0000 (14:18 +0200)]
[tools] Fixes compiler tester error messages verification

8 years agoMerge pull request #2891 from xmcclure/bug-39669
Marek Safar [Wed, 20 Apr 2016 06:09:32 +0000 (08:09 +0200)]
Merge pull request #2891 from xmcclure/bug-39669

Allow xml configuration sections to reference System.dll (bug#39669)

8 years ago[profiler] Remove unneeded call to mono_lock_free_queue_node_init.
Rodrigo Kumpera [Tue, 19 Apr 2016 22:57:16 +0000 (15:57 -0700)]
[profiler] Remove unneeded call to mono_lock_free_queue_node_init.

Remove calls to mono_lock_free_queue_node_init for nodes that just came out of mono_lock_free_queue_dequeue.

That call is superfluous as dequeue will set the returned node 'next' field to INVALID_NEXT, which is the
same thing the mono_lock_free_queue_node_init call did.

8 years agoMerge pull request #2922 from akoeplinger/fix-tvos
monojenkins [Tue, 19 Apr 2016 22:40:34 +0000 (23:40 +0100)]
Merge pull request #2922 from akoeplinger/fix-tvos

[utils] Fix MONO_SIGNAL_USE_UCONTEXT_T not being defined on tvOS simulator

In the maccore tvossimulator tests we were seeing the following assertion with the Mono 4.5 preview:

```
error: * Assertion: should not be reached at /Users/builder/data/lanes/1381/0d6923b4/source/maccore/external/mono/mono/utils/mono-context.c:194

0   dont link                           0x000000010175702d mono_handle_native_sigsegv + 253
1   libsystem_platform.dylib            0x000000010a0cfeaa _sigtramp + 26
2   ???                                 0x0000000001bfc4db 0x0 + 29344987
3   libsystem_c.dylib                   0x0000000109e56cbc abort + 129
4   dont link                           0x00000001018d1503 _ZL12log_callbackPKcS0_S0_iPv + 67
5   dont link                           0x00000001018c26d0 monoeg_assertion_message + 192
6   dont link                           0x00000001018af6de mono_sigctx_to_monoctx + 30
7   dont link                           0x000000010183f473 sgen_suspend_thread + 323
8   dont link                           0x000000010183f58e sgen_thread_handshake + 126
9   dont link                           0x000000010183fb20 sgen_client_stop_world + 1296
10  dont link                           0x0000000101871283 sgen_stop_world + 67
11  dont link                           0x0000000101870d43 sgen_perform_collection + 99
12  dont link                           0x0000000101872576 sgen_gc_collect + 102
13  dont link                           0x00000001018d1886 _ZL7pump_gcPv + 54
14  libsystem_pthread.dylib             0x000000010a0b7c13 _pthread_body + 131
15  libsystem_pthread.dylib             0x000000010a0b7b90 _pthread_body + 0
16  libsystem_pthread.dylib             0x000000010a0b5375 thread_start + 13
```

This was caused by a4e257a07f511062a8feb3e06e1566fd980110ce, the issue is that the check was changed from UCONTEXT_REG_RAX to MONO_SIGNAL_USE_UCONTEXT_T, but that is only available when HAVE_SIGACTION is defined which it is not in this case.

Talked with Zoltan, fixing this by enabling MONO_SIGNAL_USE_UCONTEXT_T on all apple platforms for now.

/cc @vargaz @xmcclure

@monojenkins merge

8 years agoAnother round of profiler fixes/improvements. PR #2882 (Manually Merged)
Rodrigo Kumpera [Tue, 19 Apr 2016 22:13:09 +0000 (15:13 -0700)]
Another round of profiler fixes/improvements. PR #2882 (Manually Merged)

https://github.com/mono/mono/pull/2882

8 years ago[runtime] MonoError-ize mono_ldstr_metadata_sig
Aleksey Kliger [Fri, 8 Apr 2016 18:47:20 +0000 (14:47 -0400)]
[runtime] MonoError-ize mono_ldstr_metadata_sig

8 years ago[runtime] MonoError-ize mono_string_new_len
Aleksey Kliger [Fri, 8 Apr 2016 18:17:26 +0000 (14:17 -0400)]
[runtime] MonoError-ize mono_string_new_len

Mark it external only.  Runtime should use mono_string_new_len_checked.

8 years ago[runtime] MonoError-ize mono_wait_handle_new
Aleksey Kliger [Fri, 8 Apr 2016 16:16:09 +0000 (12:16 -0400)]
[runtime] MonoError-ize mono_wait_handle_new

8 years ago[runtime] MonoError-ize mono_array_new_cached
Aleksey Kliger [Fri, 8 Apr 2016 15:56:27 +0000 (11:56 -0400)]
[runtime] MonoError-ize mono_array_new_cached

8 years ago[runtime] MonoError-ize mono_array_new
Aleksey Kliger [Thu, 7 Apr 2016 23:25:53 +0000 (19:25 -0400)]
[runtime] MonoError-ize mono_array_new

Mark it external only.

Runtime should use mono_array_new_checked.
The icall is ves_icall_array_new.

8 years ago[runtime] object.c don't raise in external only functions
Aleksey Kliger [Thu, 7 Apr 2016 19:15:36 +0000 (15:15 -0400)]
[runtime] object.c don't raise in external only functions

- Variants of mono_object_new
- mono_object_clone
- mono_array_new_full

All these functions have _checked variants that are used by the runtime.

8 years ago[runtime] MonoError-ize mono_array_clone
Aleksey Kliger [Thu, 7 Apr 2016 17:15:45 +0000 (13:15 -0400)]
[runtime] MonoError-ize mono_array_clone

1. Mark mono_array_clone external only.  Runtime should use
  mono_array_clone_checked.
2. Add MonoError* arg to mono_array_clone_in_domain.
3. Separate ves_icall_System_Array_Clone

8 years ago[runtime] Mark mono_object_new_from_token external only.
Aleksey Kliger [Thu, 7 Apr 2016 16:58:34 +0000 (12:58 -0400)]
[runtime] Mark mono_object_new_from_token external only.

Does not appear to be used in the runtime.
Changed it not to raise exceptions.

8 years ago[runtime] Set pending, don't raise, in object.c icalls
Aleksey Kliger [Thu, 7 Apr 2016 16:57:04 +0000 (12:57 -0400)]
[runtime] Set pending, don't raise, in object.c icalls

8 years ago[runtime] MonoError-ize mono_object_xdomain_representation
Aleksey Kliger [Wed, 6 Apr 2016 21:03:34 +0000 (17:03 -0400)]
[runtime] MonoError-ize mono_object_xdomain_representation

8 years ago[runtime] MonoError-ize mono_property_get_value
Aleksey Kliger [Fri, 1 Apr 2016 23:56:29 +0000 (19:56 -0400)]
[runtime] MonoError-ize mono_property_get_value

Mark it external only.  Runtime should use mono_property_get_value_checked.

8 years ago[runtime] MonoError-ize mono_property_set_value
Aleksey Kliger [Fri, 1 Apr 2016 20:21:51 +0000 (16:21 -0400)]
[runtime] MonoError-ize mono_property_set_value

Mark it external only.  Runtime should use
mono_property_set_value_checked.

Note: mono_property_set_value_checked always catches exceptions from
managed code and threads them out via MonoError.

8 years ago[runtime] Don't raise exns, set pending exception
Aleksey Kliger [Fri, 1 Apr 2016 20:11:20 +0000 (16:11 -0400)]
[runtime] Don't raise exns, set pending exception

8 years ago[runtime] MonoError-ize mono_runtime_create_jump_trampoline
Aleksey Kliger [Fri, 1 Apr 2016 00:27:10 +0000 (20:27 -0400)]
[runtime] MonoError-ize mono_runtime_create_jump_trampoline

8 years ago[attach] Don't raise in mono_attach_load_agent
Aleksey Kliger [Thu, 31 Mar 2016 21:00:34 +0000 (17:00 -0400)]
[attach] Don't raise in mono_attach_load_agent

8 years agoMerge pull request #2806 from lambdageek/dev/monoerror-marshal_remote
monojenkins [Tue, 19 Apr 2016 21:50:30 +0000 (22:50 +0100)]
Merge pull request #2806 from lambdageek/dev/monoerror-marshal_remote

[runtime] MonoError-ize marshal and remoting code

Get rid of calls to `mono_raise_exception` in marshaling and remoting code.

8 years ago[profiler] Don't link against libmono.
Rodrigo Kumpera [Wed, 13 Apr 2016 20:31:28 +0000 (22:31 +0200)]
[profiler] Don't link against libmono.

This would result in duplicate runtimes being loaded (as evidenced by
/proc/$pid/maps), which could lead to all sorts of breakage.

8 years ago[profiler] Load the profiler with MONO_DL_EAGER.
Alex Rønne Petersen [Wed, 13 Apr 2016 18:19:12 +0000 (20:19 +0200)]
[profiler] Load the profiler with MONO_DL_EAGER.

We need to make sure all external references have been resolved so that we
don't invoke the dynamic linker in the mono_sample_hit () callback which is
called in async-signal context.

8 years ago[utils/dl] Add a MONO_DL_EAGER enum value for clarity.
Alex Rønne Petersen [Thu, 14 Apr 2016 14:51:13 +0000 (16:51 +0200)]
[utils/dl] Add a MONO_DL_EAGER enum value for clarity.

8 years ago[profiler] Don't use a real-time signal on Android.
Alex Rønne Petersen [Tue, 12 Apr 2016 07:43:27 +0000 (09:43 +0200)]
[profiler] Don't use a real-time signal on Android.

8 years ago[profiler] Use 'start_unload' events instead of 'end_unload' events to avoid crashes.
Alex Rønne Petersen [Mon, 11 Apr 2016 05:49:14 +0000 (07:49 +0200)]
[profiler] Use 'start_unload' events instead of 'end_unload' events to avoid crashes.

'end_unload' events can receive mostly-freed structures.

8 years ago[profiler] Use a signal to interrupt the sampler thread's sleep if needed.
Alex Rønne Petersen [Sat, 9 Apr 2016 11:16:29 +0000 (13:16 +0200)]
[profiler] Use a signal to interrupt the sampler thread's sleep if needed.

There is a slight problem when we're using CLOCK_PROCESS_CPUTIME_ID: If we're
shutting down and there's largely no activity in the process other than waiting
for the sampler thread to shut down, it can take upwards of 20 seconds
(depending on a lot of factors) for us to shut down because the sleep
progresses very slowly as a result of the low CPU activity.

We fix this by repeatedly sending the profiler signal to the sampler thread in
order to interrupt the sleep.

We do not need to do this on platforms where we use a regular sleep based on a
monotonic clock. The sleep will return in a reasonable amount of time in those
cases.

8 years ago[profiler] Add some more counters.
Alex Rønne Petersen [Sat, 9 Apr 2016 02:01:19 +0000 (04:01 +0200)]
[profiler] Add some more counters.

8 years ago[profiler] Limit the number of allocated sample hit structures.
Andi McClure [Sat, 9 Apr 2016 01:16:10 +0000 (03:16 +0200)]
[profiler] Limit the number of allocated sample hit structures.

8 years ago[profiler] Add counters for log buffers and sample hits.
Andi McClure [Sat, 9 Apr 2016 01:14:33 +0000 (03:14 +0200)]
[profiler] Add counters for log buffers and sample hits.

8 years ago[profiler] Rewrite the log profiler's handling of sample hits.
Alex Rønne Petersen [Sat, 9 Apr 2016 01:06:41 +0000 (03:06 +0200)]
[profiler] Rewrite the log profiler's handling of sample hits.

The old code had quite a few problems:

1. It would result in stack corruption under heavy load, somehow. This typically
   resulted in an assertion when starting the unwinding process because the
   unwinding flags would be inconsistent.
2. It sometimes wrote complete garbage into the statistical buffers.
3. As a result of using the helper thread to assemble collected samples into log
   buffers, it did not work on platforms where the helper thread is disabled.
4. Performance was poor under heavy load because waking up the helper thread to
   assemble events would always trigger a counters sample + dump.
5. The code was very complicated and hard to understand/maintain.

(Points (1) and (2) can probably be attributed to point (5).)

In the new sampling world order, we use a lock-free allocator and a lock-free
reuse queue to acquire memory for sample hit events in the sample hit callback.
We then fill it with the info we collect during the async stack walk. Finally,
we ship it off to a separate dumper thread (via another lock-free queue) where
it gets turned into a log buffer and then shipped off to the writer thread.

This new approach appears very stable; I've yet to make it crash in any of the
stress tests I typically run. In a heavy workload, the helper thread's CPU
usage was previously around 25-30%. It is now down to basically 0% while the
dumper thread is only around 15%. CPU usage by threads that are collecting
samples is a bit higher than before, but only until the reuse queue converges
on a size that is big enough to satisfy all sample event requests. At that
point, no more allocations from the lock-free allocator happen, and performance
improves.

8 years ago[utils/lfa] Export the lock-free allocation code for use in the profiler.
Alex Rønne Petersen [Fri, 8 Apr 2016 23:24:06 +0000 (01:24 +0200)]
[utils/lfa] Export the lock-free allocation code for use in the profiler.

8 years ago[profiler] Add counters for numbers of signals sent/received/accepted.
Andi McClure [Fri, 8 Apr 2016 23:22:52 +0000 (01:22 +0200)]
[profiler] Add counters for numbers of signals sent/received/accepted.

8 years ago[counters] Add a profiler category.
Alex Rønne Petersen [Fri, 8 Apr 2016 23:22:32 +0000 (01:22 +0200)]
[counters] Add a profiler category.

8 years ago[profiler] Make the default sample frequency 100 Hz.
Alex Rønne Petersen [Sat, 9 Apr 2016 01:16:44 +0000 (03:16 +0200)]
[profiler] Make the default sample frequency 100 Hz.

Our previous default (1000 Hz) was quite extreme and resulted in very high
overhead from the profiler for moderate workloads.

Also, fix the profiler to actually treat the 'freq' argument as a frequency
when passing it to the runtime. It was being incorrectly treated as a sleep
interval.

8 years ago[domain] Report domain unloads to the profiler when finalizing the domain.
Alex Rønne Petersen [Sat, 9 Apr 2016 01:57:16 +0000 (03:57 +0200)]
[domain] Report domain unloads to the profiler when finalizing the domain.

We would miss the unload event for the root domain because we reported it just
before freeing the domain, by which time the profiler was detached.

8 years ago[profiler] Only initialize the sampler thread once.
Alex Rønne Petersen [Sat, 9 Apr 2016 02:11:14 +0000 (04:11 +0200)]
[profiler] Only initialize the sampler thread once.

8 years ago[System.Configuration] Fail tests on standalone error
Marek Safar [Tue, 19 Apr 2016 21:24:12 +0000 (23:24 +0200)]
[System.Configuration] Fail tests on standalone error

8 years agoAdd xml configuration section test (bug#39669)
Andi McClure [Tue, 19 Apr 2016 21:13:31 +0000 (17:13 -0400)]
Add xml configuration section test (bug#39669)

8 years ago[System.Configuration] re-enable standalone tests
Marek Safar [Tue, 19 Apr 2016 21:10:21 +0000 (23:10 +0200)]
[System.Configuration] re-enable standalone tests

8 years ago[utils] Fix MONO_SIGNAL_USE_UCONTEXT_T not being defined on tvOS simulator
Alexander Köplinger [Tue, 19 Apr 2016 19:30:53 +0000 (21:30 +0200)]
[utils] Fix MONO_SIGNAL_USE_UCONTEXT_T not being defined on tvOS simulator

In the maccore tvossimulator tests we were seeing the following assertion with the Mono 4.5 preview:

```
error: * Assertion: should not be reached at /Users/builder/data/lanes/1381/0d6923b4/source/maccore/external/mono/mono/utils/mono-context.c:194

0   dont link                           0x000000010175702d mono_handle_native_sigsegv + 253
1   libsystem_platform.dylib            0x000000010a0cfeaa _sigtramp + 26
2   ???                                 0x0000000001bfc4db 0x0 + 29344987
3   libsystem_c.dylib                   0x0000000109e56cbc abort + 129
4   dont link                           0x00000001018d1503 _ZL12log_callbackPKcS0_S0_iPv + 67
5   dont link                           0x00000001018c26d0 monoeg_assertion_message + 192
6   dont link                           0x00000001018af6de mono_sigctx_to_monoctx + 30
7   dont link                           0x000000010183f473 sgen_suspend_thread + 323
8   dont link                           0x000000010183f58e sgen_thread_handshake + 126
9   dont link                           0x000000010183fb20 sgen_client_stop_world + 1296
10  dont link                           0x0000000101871283 sgen_stop_world + 67
11  dont link                           0x0000000101870d43 sgen_perform_collection + 99
12  dont link                           0x0000000101872576 sgen_gc_collect + 102
13  dont link                           0x00000001018d1886 _ZL7pump_gcPv + 54
14  libsystem_pthread.dylib             0x000000010a0b7c13 _pthread_body + 131
15  libsystem_pthread.dylib             0x000000010a0b7b90 _pthread_body + 0
16  libsystem_pthread.dylib             0x000000010a0b5375 thread_start + 13
```

This was caused by a4e257a07f511062a8feb3e06e1566fd980110ce, the issue is that the check was changed from UCONTEXT_REG_RAX to MONO_SIGNAL_USE_UCONTEXT_T, but that is only available when HAVE_SIGACTION is defined which it is not in this case.

Discussed with Zoltan, fixing this by enabling MONO_SIGNAL_USE_UCONTEXT_T on all apple platforms for now.

8 years ago[runtime] Remove use of mono_raise_exception in mono_object_isinst_mbyref_checked
Aleksey Kliger [Mon, 28 Mar 2016 19:04:42 +0000 (15:04 -0400)]
[runtime] Remove use of mono_raise_exception in mono_object_isinst_mbyref_checked

8 years ago[remoting] Remove calls to mono_raise_exception
Aleksey Kliger [Tue, 29 Mar 2016 16:45:02 +0000 (12:45 -0400)]
[remoting] Remove calls to mono_raise_exception

1. MonoError-ize mono_remoting_wrapper icall.
   This is a bit this method is allowed to use
   mono_error_raise_exception: it is called from a
   MONO_WRAPPER_REMOTING_INVOKE method which is considered a "protected
   wrapper" in which the usual pending exception interruption check is a no-op.
2. Use mono_set_pending_exception in mono_marshal_set_domain_by_id icall

fixup f5dc934

8 years ago[mcs] Don't do empty array interpolation on user code, weird code expects empty array...
Marek Safar [Tue, 19 Apr 2016 17:14:44 +0000 (19:14 +0200)]
[mcs] Don't do empty array interpolation on user code, weird code expects empty array not to be equal

8 years ago[symbolicate] Switch to Cecil backend
Marek Safar [Tue, 19 Apr 2016 13:26:02 +0000 (15:26 +0200)]
[symbolicate] Switch to Cecil backend

8 years ago[monosymbolicate] Small cleanups
Marek Safar [Mon, 18 Apr 2016 19:19:45 +0000 (21:19 +0200)]
[monosymbolicate] Small cleanups

8 years agoSupport custom Xamarin Android HttpClient handler
Marek Habersack [Wed, 13 Apr 2016 07:12:08 +0000 (09:12 +0200)]
Support custom Xamarin Android HttpClient handler

Make it possible to select a default System.Net.HttpClient handler
on Android. Selection of the handler is handled on the Xamarin Android
side.

8 years agoMerge pull request #2863 from alexrp/windows-critsect-debug-info
Alex Rønne Petersen [Tue, 19 Apr 2016 09:48:24 +0000 (11:48 +0200)]
Merge pull request #2863 from alexrp/windows-critsect-debug-info

[utils/mutex] Initialize Win32 critical sections without debug info.

8 years ago[offsets-tool] Fix path to Options.cs
Rolf Bjarne Kvinge [Tue, 19 Apr 2016 08:41:25 +0000 (10:41 +0200)]
[offsets-tool] Fix path to Options.cs

8 years agoMerge pull request #2919 from lewurm/random-mini-stuff
monojenkins [Tue, 19 Apr 2016 07:15:21 +0000 (08:15 +0100)]
Merge pull request #2919 from lewurm/random-mini-stuff

Random mini stuff

@monojenkins merge

8 years ago[io-layer] Fail to modification time if it's beyond the limit allowed by the system...
Rodrigo Kumpera [Tue, 19 Apr 2016 00:03:26 +0000 (17:03 -0700)]
[io-layer] Fail to modification time if it's beyond the limit allowed by the system. Fixes #40368

This is the case for 32bits OSX that uses 32bits time_t for everything.

8 years agoMerge pull request #2821 from lambdageek/dev/monoerror-assembly
Aleksey Kliger (λgeek) [Mon, 18 Apr 2016 22:02:47 +0000 (18:02 -0400)]
Merge pull request #2821 from lambdageek/dev/monoerror-assembly

[assembly loader] Don't raise in mono_assembly_open_full and mono_assembly_load_with_partial_name

8 years agoMerge pull request #2910 from cptjazz/compiler_warnings
monojenkins [Mon, 18 Apr 2016 22:00:48 +0000 (23:00 +0100)]
Merge pull request #2910 from cptjazz/compiler_warnings

Fix undefined behaviour in left-shift.

This PR fixes a left-shift that relied on undefined behaviour.

Clang emitted the following warning (prior to this patch):
```
sgen-descriptor.c:189:54: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
   return desc | VECTOR_SUBTYPE_REFS | ((gssize)(-1) << 16);
                                        ~~~~~~~~~~~~ ^
```

8 years ago[debug] print exception name for conditional exception OP
Bernhard Urban [Tue, 12 Apr 2016 18:37:38 +0000 (11:37 -0700)]
[debug] print exception name for conditional exception OP

8 years ago[runtime] MonoError-ize mono_store_remote_field_new
Aleksey Kliger [Tue, 29 Mar 2016 16:38:51 +0000 (12:38 -0400)]
[runtime] MonoError-ize mono_store_remote_field_new

Mark mono_store_remote_field_new external only.
Runtime should use mono_store_remote_field_new_checked.
Change mono_marshal_get_stfld_remote_wrapper to use
mono_store_remote_field_new_icall instead of a native call.

8 years ago[runtime] MonoError-ize mono_store_remote_field
Aleksey Kliger [Tue, 29 Mar 2016 16:15:33 +0000 (12:15 -0400)]
[runtime] MonoError-ize mono_store_remote_field

Marked it external only.
Runtime should use mono_store_remote_field_checked.

8 years ago[runtime] MonoError-ize mono_load_remote_field_new
Aleksey Kliger [Mon, 28 Mar 2016 22:18:34 +0000 (18:18 -0400)]
[runtime] MonoError-ize mono_load_remote_field_new

Add mono_load_remote_field_new_checked.  Mark mono_load_remote_field_new
external only.  Add icall mono_load_remote_field_new_icall and use it in
remoting wrappers.

8 years ago[runtime] Add mono_load_remote_field_checked
Aleksey Kliger [Mon, 28 Mar 2016 21:25:43 +0000 (17:25 -0400)]
[runtime] Add mono_load_remote_field_checked

Update it to use MonoError.

Mark mono_load_remote_field external only.

8 years ago[runtime] MonoError-ize mono_method_return_message_restore
Aleksey Kliger [Mon, 28 Mar 2016 19:10:15 +0000 (15:10 -0400)]
[runtime] MonoError-ize mono_method_return_message_restore

8 years agoMerge pull request #2814 from lambdageek/dev/monoerror-appdomain
monojenkins [Mon, 18 Apr 2016 19:15:22 +0000 (20:15 +0100)]
Merge pull request #2814 from lambdageek/dev/monoerror-appdomain

[appdomain] Cleanup MonoError code

1. Assert in mono_get_corlib_version instead of raising an exn.
2. Don't raise in mono_domain_create_appdomain external API function.
3. Assert in mono_domain_assembly_postload_search instead of raising.
4. Don't raise in mono_domain_fire_assembly_load.
5. Use mono_error_set_pending_exception in
   ves_icall_System_AppDomain_InternalGetProcessGuid
6. Dont' raise in unload_thread_main, populate unload_data instead.

8 years agoBump version in configure.ac
Alexander Köplinger [Mon, 18 Apr 2016 18:22:56 +0000 (20:22 +0200)]
Bump version in configure.ac

8 years ago[marshal] use meaningful constant instead of hard coded value
Bernhard Urban [Thu, 7 Apr 2016 22:08:34 +0000 (15:08 -0700)]
[marshal] use meaningful constant instead of hard coded value

8 years ago[jit] Fix the linking of bblocks in mono_replace_ins () by avoiding iterating over...
Zoltan Varga [Mon, 18 Apr 2016 17:26:55 +0000 (13:26 -0400)]
[jit] Fix the linking of bblocks in mono_replace_ins () by avoiding iterating over an array which is modified in place by mono_unlink_bblock ().

8 years ago[tools] Add aot offsets generation tool.
Rolf Bjarne Kvinge [Mon, 18 Apr 2016 15:12:20 +0000 (17:12 +0200)]
[tools] Add aot offsets generation tool.

List of original contributors:

Marek Habersack <grendel@twistedcode.net>
João Matos <joao@tritao.eu>
Zoltan Varga <vargaz@gmail.com>
Rolf Bjarne Kvinge <rolf@xamarin.com>

8 years agoMerge pull request #2916 from ludovic-henry/fix-40306
Ludovic Henry [Mon, 18 Apr 2016 16:58:42 +0000 (18:58 +0200)]
Merge pull request #2916 from ludovic-henry/fix-40306

[threadpool-io] Fix crash on shutdownin System.Net.Sockets.Socket:Close_internal

8 years agoMerge pull request #2915 from poedgirl/master
monojenkins [Mon, 18 Apr 2016 14:05:26 +0000 (15:05 +0100)]
Merge pull request #2915 from poedgirl/master

Added support for SHA256, 384 and 512 in AuthenticodeDeformatter.

Due to the changes introduced by Microsoft to require signing with stronger algorithms, SHA-256, SHA-384 and SHA-512 support was needed.

This change is released under the MIT license.

8 years ago[threadpool-io] Fix crash on shutdownin System.Net.Sockets.Socket:Close_internal
Ludovic Henry [Mon, 18 Apr 2016 13:40:44 +0000 (15:40 +0200)]
[threadpool-io] Fix crash on shutdownin System.Net.Sockets.Socket:Close_internal

There could be a race between System.Net.Sockets.Socket:Close_internal and the io threadpool cleanup, which would lead to a native crash. That's because the io threadpool cleanup would clean the mutex, condition variables as well as close the sockets.

The easiest way to fix that is by cleaning only what's going to stop the runtime from shutting down, and in this case the background selector thread. The same is done for the threadpool where we just shutdown the monitor thread and the worker threads.

8 years agoAdded support for SHA256, 384 and 512 in AuthenticodeDeformatter.
Michelle Allen [Mon, 18 Apr 2016 08:31:10 +0000 (16:31 +0800)]
Added support for SHA256, 384 and 512 in AuthenticodeDeformatter.

Due to the changes introduced by Microsoft to require signing with stronger algorithms, SHA-256, SHA-384 and SHA-512 support was needed.

This change is released under the MIT license.

8 years agoMerge pull request #2897 from kumpera/marshal_fixes
monojenkins [Mon, 18 Apr 2016 05:00:21 +0000 (06:00 +0100)]
Merge pull request #2897 from kumpera/marshal_fixes

[marshal] Ensure marshal code emit the right indirect store when dealing with ref types.

The marshal code was using CEE_STIND_I for a lot of ref stores. This would not
generate a WB and is a heap corruption vector.

8 years agoImplement mono_threads_core_set_name() on NetBSD (#2914)
Kamil Rytarowski [Mon, 18 Apr 2016 01:55:53 +0000 (03:55 +0200)]
Implement mono_threads_core_set_name() on NetBSD (#2914)

Part of man-page showing this interface:

PTHREAD_GETNAME_NP(3)      Library Functions Manual      PTHREAD_GETNAME_NP(3)

NAME
     pthread_getname_np - get and set descriptive name of a thread

LIBRARY
     POSIX Threads Library (libpthread, -lpthread)

SYNOPSIS
     #include <pthread.h>

     int
     pthread_getname_np(pthread_t thread, char *name, size_t len);

     int
     pthread_setname_np(pthread_t thread, const char *name, void *arg);

   -- pthread_setname_np(3)

8 years agoMerge pull request #2913 from krytarowski/netbsd-support-11
Alexander Köplinger [Sun, 17 Apr 2016 22:52:40 +0000 (00:52 +0200)]
Merge pull request #2913 from krytarowski/netbsd-support-11

Remove stale file in the repository

8 years agoRemove stale file in the repository
Kamil Rytarowski [Sun, 17 Apr 2016 22:48:26 +0000 (00:48 +0200)]
Remove stale file in the repository

The .orig files are traditionally files of patch(1) and diff(1) tools.
Remove stale file Makefile.orig as it is generating false positives for
grabbing patches from a directory tree.

8 years agoMerge pull request #2912 from krytarowski/netbsd-support-10
Alexander Köplinger [Sun, 17 Apr 2016 22:12:49 +0000 (00:12 +0200)]
Merge pull request #2912 from krytarowski/netbsd-support-10

Remove unportable shell construct detected on NetBSD

8 years agoMerge pull request #2911 from akoeplinger/handleref
monojenkins [Sun, 17 Apr 2016 21:55:19 +0000 (22:55 +0100)]
Merge pull request #2911 from akoeplinger/handleref

[metadata] Don't require HandleRef in domain.c

In 1da6b7629701e71afed2a28c86e7a9cb0f2c6f07 loading of System.Runtime.InteropServices.HandleRef
was changed from optional to required. This caused errors in the maccore tests:

```
MONO_PATH=/Users/builder/data/lanes/1411/5ca65b46/source/maccore/msbuild/tests/MyKeyboardExtension/obj/iPhone/Debug/mtouch-cache/64/Build /Users/builder/data/lanes/1411/5ca65b46/source/maccore/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/bin/arm64-darwin-mono-sgen --debug -O=gsharedvt  --aot=mtriple=arm64-ios,data-outfile=/Users/builder/data/lanes/1411/5ca65b46/source/maccore/msbuild/tests/MyKeyboardExtension/obj/iPhone/Debug/mtouch-cache/System.arm64.aotdata,static,asmonly,direct-icalls,full,dwarfdebug,no-direct-calls,outfile=/Users/builder/data/lanes/1411/5ca65b46/source/maccore/msbuild/tests/MyKeyboardExtension/obj/iPhone/Debug/mtouch-cache/System.dll.arm64.s "/Users/builder/data/lanes/1411/5ca65b46/source/maccore/msbuild/tests/MyKeyboardExtension/obj/iPhone/Debug/mtouch-cache/64/Build/System.dll"
Runtime critical type System.Runtime.InteropServices.HandleRef not found
AOT Compilation exited with code 134, command:
```

@monojenkins merge

8 years agoRemove unportable shell construct detected on NetBSD
Kamil Rytarowski [Sun, 17 Apr 2016 20:45:26 +0000 (22:45 +0200)]
Remove unportable shell construct detected on NetBSD

8 years ago[metadata] Don't require HandleRef in domain.c
Alexander Köplinger [Sun, 17 Apr 2016 18:22:04 +0000 (20:22 +0200)]
[metadata] Don't require HandleRef in domain.c

In 1da6b7629701e71afed2a28c86e7a9cb0f2c6f07 loading of System.Runtime.InteropServices.HandleRef
was changed from optional to required. This caused errors in the maccore tests:

```
MONO_PATH=/Users/builder/data/lanes/1411/5ca65b46/source/maccore/msbuild/tests/MyKeyboardExtension/obj/iPhone/Debug/mtouch-cache/64/Build /Users/builder/data/lanes/1411/5ca65b46/source/maccore/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/bin/arm64-darwin-mono-sgen --debug -O=gsharedvt  --aot=mtriple=arm64-ios,data-outfile=/Users/builder/data/lanes/1411/5ca65b46/source/maccore/msbuild/tests/MyKeyboardExtension/obj/iPhone/Debug/mtouch-cache/System.arm64.aotdata,static,asmonly,direct-icalls,full,dwarfdebug,no-direct-calls,outfile=/Users/builder/data/lanes/1411/5ca65b46/source/maccore/msbuild/tests/MyKeyboardExtension/obj/iPhone/Debug/mtouch-cache/System.dll.arm64.s "/Users/builder/data/lanes/1411/5ca65b46/source/maccore/msbuild/tests/MyKeyboardExtension/obj/iPhone/Debug/mtouch-cache/64/Build/System.dll"
Runtime critical type System.Runtime.InteropServices.HandleRef not found
AOT Compilation exited with code 134, command:
```

8 years agoMerge pull request #2908 from krytarowski/netbsd-support-8
Alexander Köplinger [Sun, 17 Apr 2016 18:08:00 +0000 (20:08 +0200)]
Merge pull request #2908 from krytarowski/netbsd-support-8

Add new ./configure target & xtarget: arm*-netbsd*-eabi*

8 years agoMerge pull request #2907 from krytarowski/netbsd-support-7
Alexander Köplinger [Sun, 17 Apr 2016 18:07:38 +0000 (20:07 +0200)]
Merge pull request #2907 from krytarowski/netbsd-support-7

Improve NetBSD target handling in ./configure

8 years agoMerge pull request #2906 from krytarowski/netbsd-support-6
Alexander Köplinger [Sun, 17 Apr 2016 18:06:56 +0000 (20:06 +0200)]
Merge pull request #2906 from krytarowski/netbsd-support-6

Welcome to ARM ucontext registers on NetBSD

8 years ago[tests/verifier] Fix a few issues in the Makefile
Alexander Köplinger [Sun, 17 Apr 2016 17:04:58 +0000 (19:04 +0200)]
[tests/verifier] Fix a few issues in the Makefile

gmcs and ilasm2 are no longer distributed with Mono.

The run-test step had several issues that prevented it from running,
e.g. the comments caused "unexpected end of line" issues on OSX.

8 years agoMerge pull request 2899 from krytarowski/netbsd-support-1
Alexander Köplinger [Sun, 17 Apr 2016 17:24:59 +0000 (19:24 +0200)]
Merge pull request 2899 from krytarowski/netbsd-support-1

Improve shell portability on NetBSD

The "test" command, as well as the "[" command, are not required to know
the "==" operator.

Comparing with empty strings ("") might lead to unspecified results.

Replace unportable shell loops:
    for I in {2..6}; do ..; done
with POSIX ones:
    I=2; while [ $I -le 6 ]; do ..; I=$((I + 1)); done

8 years agoFix undefined behaviour in left-shift.
Alexander Jesner [Sun, 17 Apr 2016 16:31:32 +0000 (18:31 +0200)]
Fix undefined behaviour in left-shift.

8 years agoAdd new ./configure target & xtarget: arm*-netbsd*-eabi*
Kamil Rytarowski [Sun, 17 Apr 2016 14:04:53 +0000 (16:04 +0200)]
Add new ./configure target & xtarget: arm*-netbsd*-eabi*

Example GNU triplets:

evbarm 7.0 NetBSD ignored arm arm-unknown-netbsdelf7.0
evbarm 7.0 NetBSD ignored armeb armeb-unknown-netbsdelf7.0
evbarm 7.0 NetBSD ignored earmv6 armv6-unknown-netbsdelf7.0-eabi
evbarm 7.0 NetBSD ignored earmv6eb armv6eb-unknown-netbsdelf7.0-eabi
evbarm 7.0 NetBSD ignored earmv6hf armv6-unknown-netbsdelf7.0-eabihf
evbarm 7.0 NetBSD ignored earmv6hfeb armv6eb-unknown-netbsdelf7.0-eabihf
evbarm 7.0 NetBSD ignored earmv7 armv7-unknown-netbsdelf7.0-eabi
evbarm 7.0 NetBSD ignored earmv7eb armv7eb-unknown-netbsdelf7.0-eabi
evbarm 7.0 NetBSD ignored earmv7hf armv7-unknown-netbsdelf7.0-eabihf
evbarm 7.0 NetBSD ignored earmv7hfeb armv7eb-unknown-netbsdelf7.0-eabihf

-- http://git.savannah.gnu.org/cgit/config.git/tree/testsuite/config-guess.data

For now support just EABI targets (available since ARMv4).