Ankit Jain [Thu, 16 Feb 2017 21:56:28 +0000 (16:56 -0500)]
[xbuild] Don't show the deprecation notice for minimal or quiet logging
.. levels. This is useful for scripts that might depend on minimal/quiet
levels, to parse output of a specific target execution, eg.
Xamarin.Android .
Ludovic Henry [Mon, 13 Feb 2017 19:19:21 +0000 (14:19 -0500)]
[threadpool] Extract ThreadPoolDomain creation from tpdomain_get
Ludovic Henry [Wed, 8 Feb 2017 19:32:00 +0000 (14:32 -0500)]
[threadpool] Make sure we check if the runtime is shutting down in case of interruption
Ludovic Henry [Wed, 8 Feb 2017 16:35:28 +0000 (11:35 -0500)]
[threadpool] Make ThreadPoolWorker staticaly allocated
Ludovic Henry [Tue, 7 Feb 2017 21:50:34 +0000 (16:50 -0500)]
[threadpool] Make ThreadPool global variable staticaly allocated
We wouldn't free it on cleanup, so we would end up leaking it anyway.
Aleksey Kliger [Wed, 15 Feb 2017 20:58:21 +0000 (15:58 -0500)]
[w2file] Fix shutdown assert in checked mode
console_close triggered a MONO_REQ_GC_SAFE_MODE assert in checked mode on
because the console handles were unref'd which caused them to close.
Until w32handle is coop-aware, just transition to GC unsafe mode (a noop if
it's already in unsafe) in these callbacks.
Aleksey Kliger [Wed, 15 Feb 2017 19:43:34 +0000 (14:43 -0500)]
[w32file] Transition to GC safe mode when file handles unref'd.
And don't transition around calls to mono_w32file_close which does its own coop transition
Aleksey Kliger [Wed, 15 Feb 2017 19:39:55 +0000 (14:39 -0500)]
[checked] Include file and line number in thread state assertions.
Alexander Köplinger [Thu, 16 Feb 2017 18:40:35 +0000 (19:40 +0100)]
Revert "[ci] Temporarily use http url to download server until cert is fixed"
This reverts commit
9281d4a7e6a644a73c87819139a5d3047052c1bb.
SSL works again now on the download server
Ludovic Henry [Thu, 16 Feb 2017 18:10:33 +0000 (13:10 -0500)]
[process] Allocate a handle even for non-child processes (#4393)
Rodrigo Kumpera [Thu, 16 Feb 2017 17:42:57 +0000 (09:42 -0800)]
Merge pull request #4385 from mono/work-btls-
02152017
[btls]: Make configure fail when building on Android without '--with-btls-android-ndk'
monojenkins [Thu, 16 Feb 2017 16:35:07 +0000 (17:35 +0100)]
[msvc] Update csproj files (#4395)
Ludovic Henry [Thu, 16 Feb 2017 12:20:41 +0000 (07:20 -0500)]
[treadpool] Fix flaky System.Threading.ThreadTest.SetNameInThreadPoolThread test (#4392)
Ludovic Henry [Thu, 16 Feb 2017 12:18:12 +0000 (07:18 -0500)]
[socket] Add EPROTOTYPE error case (#4391)
Fixes bug https://bugzilla.xamarin.com/show_bug.cgi?id=52549
Rodrigo Kumpera [Thu, 16 Feb 2017 09:01:33 +0000 (01:01 -0800)]
Merge pull request #4376 from kumpera/test-hardneing
Disable some flaky tests and harden another one.
Alexander Köplinger [Thu, 16 Feb 2017 01:58:08 +0000 (02:58 +0100)]
[System] Fix failing ClientWebSocket test
The wrong part of the ifdef was deleted in
a4df7d4923aa,
we need to InvalidOperationException instead of PNSE.
Ludovic Henry [Thu, 16 Feb 2017 01:56:49 +0000 (20:56 -0500)]
[socket] Fix bad parameter passed to select (#4390)
If fd is equals to FD_SETSIZE, then we pass (FD_SETSIZE + 1) as first parameter to select, making it return EINVAL.
Alexander Köplinger [Thu, 16 Feb 2017 01:55:45 +0000 (02:55 +0100)]
Merge pull request #4386 from akoeplinger/fix-netstandard
Fix netstandard facade build and remove the NETSTANDARD ifdef from profiles
Ludovic Henry [Thu, 16 Feb 2017 01:46:26 +0000 (20:46 -0500)]
[socket] Fix race on SocketAsyncResult (#4389)
It might be possible that the callback modifies the current SocketAsyncResult via the Init method. We observe it with AcceptAsync with a ReceiveAsync in the callback.
Marek Safar [Wed, 15 Feb 2017 23:04:19 +0000 (00:04 +0100)]
[System] Fixes failing tests on mobile
Rodrigo Kumpera [Wed, 15 Feb 2017 22:34:29 +0000 (14:34 -0800)]
[corlib] Assert of wait failure.
Alexander Köplinger [Wed, 15 Feb 2017 18:53:59 +0000 (19:53 +0100)]
[bcl] Remove the NETSTANDARD ifdef from profiles
We're always using the code now and will deal with the
differences to .NET 4.x by producing reference assemblies.
Alexander Köplinger [Wed, 15 Feb 2017 18:33:25 +0000 (19:33 +0100)]
[Facades] Fix netstandard facade build
Martin Baulig [Wed, 15 Feb 2017 18:13:58 +0000 (19:13 +0100)]
[btls]: Make configure fail when building on Android without '--with-btls-android-ndk'.
When building on Android with BTLS support, the '--with-btls-android-ndk' argument
is required to teach the underlying cmake the NDK location. Fixes #52511.
monojenkins [Wed, 15 Feb 2017 16:33:08 +0000 (17:33 +0100)]
[msvc] Update csproj files (#4384)
Marek Safar [Wed, 15 Feb 2017 16:17:44 +0000 (17:17 +0100)]
[mcs] lifted binary operator for decimal arguments need to call user operator for comparison. Fixes #52086
Alexander Köplinger [Wed, 15 Feb 2017 16:01:34 +0000 (17:01 +0100)]
[man] Remove outdated version numbers (#4382)
We haven't been consistent in keeping those version numbers
up to date as we bump Mono's version so it's less confusing
to not show them in the manual pages.
`mono --version` is and has been the source of truth.
Marek Safar [Wed, 15 Feb 2017 13:34:06 +0000 (14:34 +0100)]
[mcs] Always resolve new initializers with conditional access receivers enabled. Fixes #52340
Marek Safar [Tue, 14 Feb 2017 15:20:31 +0000 (16:20 +0100)]
[System.Net.Http] Add Transfer-Encoding: chunked special handling. Fixes #47599
Marek Safar [Wed, 15 Feb 2017 11:07:58 +0000 (12:07 +0100)]
Merge pull request #4371 from marek-safar/cecil-update
Cecil update
Marek Safar [Tue, 14 Feb 2017 16:04:21 +0000 (17:04 +0100)]
[Mono.CodeContracts] Read debug symbols only when they are going to be used
Marek Safar [Mon, 13 Feb 2017 11:35:38 +0000 (12:35 +0100)]
Cecil update
Rodrigo Kumpera [Wed, 15 Feb 2017 00:33:28 +0000 (16:33 -0800)]
[corlib] Rewrite the timer tests to something that can actually be verified.
Alexander Köplinger [Tue, 14 Feb 2017 21:13:47 +0000 (22:13 +0100)]
[System.ServiceModel.Internals] Use the mobile sources for testing_aot_full and orbis profile (#4378)
Aleksey Kliger [Tue, 14 Feb 2017 17:39:59 +0000 (12:39 -0500)]
[w32file] transition to GC unsafe in file handle close callbacks.
Followup to last commit (
f238640c9ff855bc5c2ab812cf21fd747a624dc9).
We need to transition to unsafe to call file_share_release and the _wapi_
functions, and then back to safe to call close(2).
Aleksey Kliger (λgeek) [Tue, 14 Feb 2017 16:41:38 +0000 (11:41 -0500)]
[w32file] Push coop transitions into functions, closer to syscalls (#4370)
* [w32file] Push coop transitions into functions, closer to syscalls
Previous the coop transitions happened in the icalls and high level
platform-independent functions. Now they surround syscalls and platform API
calls, instead.
(Among other benefits, this fixes a problem where MoveFile on unix was
implemented in some circumstances in terms of CopyFile which resulted in an
illegal coop transition from blocking to blocking.)
* There is a FIXME with `mono_w32handle_new_fd` and `mono_w32handle_close`: the w32handle API is not coop-friendly yet, so we have to switch to gc safe mode around calls to `w32handle_new_fd` and `w32handle_close`. In the case of `w32handle_close`, it calls back into the w32file functions `pipe_close`, `console_close` and `file_close`. So the calls to `close(2)` inside those functions are not surrounded by transitions to GC safe mode - instead they require that we're already in safe mode (as is the case when they're called from w32handle).
Neale Ferguson [Tue, 14 Feb 2017 13:47:21 +0000 (08:47 -0500)]
Fix DateTime.Now and CurrentTimeToUtc during DST transition time (#4172)
* During the ambiguous hour .NET will return the DST version of the time whereas mono is returning the base time. Rather than use the transitions array we look up the Adjustment rules (which are created from the transition rules in the first place).
In addition, CurrentTimeToUtc() also has problems around the transition time.
Added test and fixed another.
Fixes #43805.
* Despite the tutorial on msdn about daylight saving time, .NET interprets the 'ambiguous' hour of DST as being DST rather than standard time which is what mono did.
Rodrigo Kumpera [Tue, 14 Feb 2017 05:51:55 +0000 (21:51 -0800)]
[corlib] Harden a GC test against possible false pinnig.
Rodrigo Kumpera [Tue, 14 Feb 2017 05:38:52 +0000 (21:38 -0800)]
[corlib] Disable broken tests that depend on crazy precise scheduling and system timers.
The disabled tests assume perfect scheduling and non-coalescing system timers. Neither exists
on OSX Sierra, iOS or Android. This tests fail there regularly.
mathieubourgeois [Tue, 14 Feb 2017 02:53:05 +0000 (21:53 -0500)]
Fix when() clause cutting stack traces when filtering doesn't succeed (fix for 46661) (#4328)
* * [exceptions] When encountering a filter (when) clause, don't setup the stack trace before we know if the filter is going to work. Otherwise, any exception that isn't blocked by the when clause will have its stack trace cut at the point of the parent of the function containing the when clause
* Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=46661
* + Added test case for bug 46661
Alexander Köplinger [Tue, 14 Feb 2017 02:38:02 +0000 (03:38 +0100)]
[Facades] Update netstandard facade to latest
Includes latest changes from dotnet/standard repo.
Vincent Povirk [Mon, 13 Feb 2017 23:26:39 +0000 (17:26 -0600)]
[tests] Fix out of tree build. (#4372)
Alexis Christoforides [Mon, 13 Feb 2017 23:13:23 +0000 (18:13 -0500)]
[MacSDK] Updated location of bundled PCL assemblies
Alexis Christoforides [Mon, 13 Feb 2017 22:22:07 +0000 (17:22 -0500)]
Bump Bockbuild
Alexis Christoforides [Mon, 13 Feb 2017 22:05:24 +0000 (17:05 -0500)]
[MacSDK] Switch back to xbuild for IronPython build. MSBuild seems to be having trouble
Alexis Christoforides [Mon, 13 Feb 2017 22:02:14 +0000 (17:02 -0500)]
Bump Bockbuild
Marek Safar [Mon, 13 Feb 2017 15:05:54 +0000 (16:05 +0100)]
[System.Net.Http] Allow re-sending StreamContent. Fixes #52448
Zoltan Varga [Mon, 13 Feb 2017 19:35:41 +0000 (14:35 -0500)]
[jit] Disable llvm for overly complex methods, to avoid compilation slowdowns. Fixes #52475.
Zoltan Varga [Mon, 13 Feb 2017 19:34:59 +0000 (14:34 -0500)]
[ssa] Fix an assertion if the buffer used to keep renaming history gets full.
Alexis Christoforides [Mon, 13 Feb 2017 19:19:02 +0000 (14:19 -0500)]
Bump Bockbuild
Alexis Christoforides [Mon, 13 Feb 2017 18:47:00 +0000 (13:47 -0500)]
Bump bockbuild
Alexis Christoforides [Mon, 13 Feb 2017 14:56:11 +0000 (09:56 -0500)]
Bump bockbuild
Alexis Christoforides [Mon, 13 Feb 2017 13:29:39 +0000 (08:29 -0500)]
Bump bockbuild
Alexis Christoforides [Mon, 13 Feb 2017 12:47:31 +0000 (07:47 -0500)]
[MacSDK] updates
Alexis Christoforides [Mon, 13 Feb 2017 12:14:09 +0000 (07:14 -0500)]
[MacSDK] Update F#
Marek Safar [Mon, 13 Feb 2017 11:49:38 +0000 (12:49 +0100)]
[System] Fixes failing tests on watch
Alexis Christoforides [Mon, 13 Feb 2017 11:37:41 +0000 (06:37 -0500)]
Bump bockbuild
Alexis Christoforides [Mon, 13 Feb 2017 08:55:16 +0000 (03:55 -0500)]
[MacSDK] Use full Mono version, incl. build number in build
Also add a VERSION file in the package.
Alexis Christoforides [Mon, 13 Feb 2017 10:32:56 +0000 (05:32 -0500)]
[MacSDK] Update MSBuild
Alexis Christoforides [Mon, 13 Feb 2017 04:40:37 +0000 (23:40 -0500)]
Move Mac package command to scripts so that it's available without configuring
Marek Safar [Mon, 13 Feb 2017 09:09:01 +0000 (10:09 +0100)]
[System.ServiceModel] Disable unreliable test
Marek Safar [Fri, 10 Feb 2017 15:13:25 +0000 (16:13 +0100)]
Bump roslyn to rc4
Ludovic Henry [Sun, 12 Feb 2017 16:10:42 +0000 (11:10 -0500)]
[finalizer] Suspend finalizer thread on after shutdown timeout (#4363)
Fixes bug https://bugzilla.xamarin.com/show_bug.cgi?id=52429
Zoltan Varga [Sat, 11 Feb 2017 04:41:24 +0000 (23:41 -0500)]
[runtime] Remove an obsolete option from --help=devel.
Alexander Köplinger [Fri, 10 Feb 2017 19:56:08 +0000 (20:56 +0100)]
[tools] Install pdb files for security tools (#4364)
We don't use the global executable.make install logic for the tools
in security so we missed updating this to copy .pdb's as well.
Bernhard Urban [Fri, 10 Feb 2017 07:38:07 +0000 (08:38 +0100)]
[exceptions] introduce suspend-on-native-crash that suspends on every native crash
not just `SIGSEGV`. rename `suspend-on-sigsegv` but keep it as an alias around.
Zoltan Varga [Fri, 10 Feb 2017 18:47:23 +0000 (13:47 -0500)]
[runtime] Avoid holding the init lock while calling the cctor in mono_runtime_class_init (), its not needed any more. (#4361)
monojenkins [Fri, 10 Feb 2017 16:47:59 +0000 (16:47 +0000)]
[msvc] Update csproj files
Alexis Christoforides [Fri, 10 Feb 2017 16:26:21 +0000 (11:26 -0500)]
Bump bockbuild
Marek Safar [Fri, 10 Feb 2017 15:03:16 +0000 (16:03 +0100)]
[System.Data] Add RESX_RESOURCE_STRING
Eberhard Beilharz [Thu, 9 Feb 2017 17:07:33 +0000 (18:07 +0100)]
[swf] Fix pasting of Unicode text
Previously pasting of Unicode text, e.g. from LibreOffice, resulted in
question marks being displayed.
This fixes Xamarin-7359.
Change-Id: I78ec4cb1bbbd0e14da91d06a6fc517bc5c91e135
Marek Safar [Tue, 17 Jan 2017 15:03:41 +0000 (16:03 +0100)]
[System] CodeDom from CoreFX
Alexis Christoforides [Fri, 10 Feb 2017 04:52:15 +0000 (23:52 -0500)]
Bump bockbuild
Alexis Christoforides [Fri, 10 Feb 2017 04:29:30 +0000 (23:29 -0500)]
"WIP (auto-committed by bockbuild)"
Alexis Christoforides [Fri, 10 Feb 2017 04:00:59 +0000 (23:00 -0500)]
Bump Bockbuild
Ludovic Henry [Fri, 10 Feb 2017 03:02:43 +0000 (22:02 -0500)]
[threads] Make OSEvent alertable to fix bug #51653 (#4347)
Alexis Christoforides [Fri, 10 Feb 2017 00:00:37 +0000 (19:00 -0500)]
Bump bockbuild
Ludovic Henry [Thu, 9 Feb 2017 19:57:59 +0000 (14:57 -0500)]
[process] Improve error message for inaccessible process (#4354)
Fixes bug https://bugzilla.xamarin.com/show_bug.cgi?id=51561
Alexander Köplinger [Thu, 9 Feb 2017 17:30:53 +0000 (18:30 +0100)]
[Mono.Security] Check NewLocalMachinePath too for deciding if store is machine store (#4357)
The code in X509Store only checked the legacy X509StoreManager.LocalMachinePath
when deciding whether CspProviderFlags.UseMachineKeyStore should be
set when dealing with private keys.
However, with BTLS we now also have X509StoreManager.NewLocalMachinePath.
This caused an issue/regression in the recent 4.8 builds that
started importing into the BTLS cert store when using cert-sync:
https://github.com/mono/mono/commit/
968c60a0f32c7a4c92568c3feda7503f99b98c94
Because cert-sync is ran at package installation time as root
on Linux we would erroneously not pass UseMachineKeyStore (because
the paths between legacy and BTLS store are different), which in turn
causes KeyPairPersistence to look into the user directory, e.g.
~/.config/.mono/keypairs. Since on a clean machine that directory
hierarchy doesn't exist, it goes on and creates it -> we now have
the ~/.config directory owned by root which means a normal user
application can't write to it anymore (like NuGet) and crashes.
The fix is to check for the BTLS store path as well so KeyPairPersistence
uses the machine path and ~/.config is not created on package installation.
See e.g. https://github.com/travis-ci/travis-ci/issues/7271
Marek Safar [Thu, 9 Feb 2017 16:12:43 +0000 (17:12 +0100)]
[build] Add simple target for easier corefx strings updating
Rodrigo Kumpera [Thu, 9 Feb 2017 06:11:25 +0000 (22:11 -0800)]
Merge pull request #4248 from Unity-Technologies/boehm-gc-alloc-fixed
Implement mono_gc_alloc_fixed/mono_gc_free_fixed on Boehm to match SGen
Ludovic Henry [Thu, 9 Feb 2017 03:29:03 +0000 (22:29 -0500)]
[process] Fix Process.GetProcessesByName (#4351)
To get a process by name, we need to access the other process ProcessName, but it can fails on non-win32 platforms. This failure wouldn't be caught in the referencesource implementation trigerring this bug.
The exception we would observe would be:
Unhandled Exception:
System.InvalidOperationException: Process has exited, so the requested information is not available.
at System.Diagnostics.Process.get_ProcessName () [0x0002d] in /Users/alexander/dev/mono/mcs/class/System/System.Diagnostics/Process.cs:336
at (wrapper remoting-invoke-with-check) System.Diagnostics.Process:get_ProcessName ()
at Program.Main (System.String[] args) [0x0003b] in <
9c838a66cdc44c81b38c974edcc9c029>:0
[ERROR] FATAL UNHANDLED EXCEPTION: System.InvalidOperationException: Process has exited, so the requested information is not available.
at System.Diagnostics.Process.get_ProcessName () [0x0002d] in /Users/alexander/dev/mono/mcs/class/System/System.Diagnostics/Process.cs:336
at (wrapper remoting-invoke-with-check) System.Diagnostics.Process:get_ProcessName ()
at Program.Main (System.String[] args) [0x0003b] in <
9c838a66cdc44c81b38c974edcc9c029>:0
Fixes bug https://bugzilla.xamarin.com/show_bug.cgi?id=52345
Zoltan Varga [Thu, 9 Feb 2017 03:25:18 +0000 (22:25 -0500)]
[runtime] Fix the reflected type of Delegate.Method if the method is an inherited virtual method. Fixes #39444. (#4353)
Ludovic Henry [Thu, 9 Feb 2017 02:12:44 +0000 (21:12 -0500)]
[threads] Allow resetting the name of a threadpool thread (#4350)
Fixes bug https://bugzilla.xamarin.com/show_bug.cgi?id=47221
Zoltan Varga [Wed, 8 Feb 2017 23:16:09 +0000 (18:16 -0500)]
[runtime] Add a cache for generic array helper wrappers to reduce the number created. This works because there are a lot of duplicates due to the fact that the interfaces passed to setup_generic_array_ifaces () have the same context. (#4343)
Zoltan Varga [Wed, 8 Feb 2017 23:11:53 +0000 (18:11 -0500)]
[jit] Remove the MONO_INIT_VARINFO macro, its only used in one place. (#4349)
Martin Baulig [Wed, 8 Feb 2017 16:12:02 +0000 (17:12 +0100)]
[btls]: Fix MonoBtlsX509Store.cs.AddTrustedRoots(). (#4340)
This internal method is only called from Mono.Btls.Interface.BtlsStore
and used by the web-tests.
Call MonoBtlsProvider.SetupCertificateStore(store) to make its
behavior consistent with the internal implementation.
Ludovic Henry [Wed, 8 Feb 2017 15:33:22 +0000 (10:33 -0500)]
Revert "[threads] Make OSEvent alertable to fix bug #51653" (#4346)
Ludovic Henry [Wed, 8 Feb 2017 15:01:08 +0000 (10:01 -0500)]
[threads] Make OSEvent alertable to fix bug #51653 (#4341)
Martin Baulig [Wed, 8 Feb 2017 13:33:47 +0000 (14:33 +0100)]
[btls]: Fix MonoBtlsProvider.SetupCertificateStore(MonoTlsSettings,bool). (#4337)
* When 'settings != null' and 'settings.CertificateSearchPaths == null',
then we add the default paths, including the 'settings.TrustAnchors'.
This applies to all platforms, including Android.
* In MonoBtlsContext, we can now simply call
MonoTlsProvider.SetupCertificateStore(MonoTlsSettings,bool) instead of
having a custom version of it.
Niklas Therning [Wed, 8 Feb 2017 10:18:55 +0000 (11:18 +0100)]
Merge pull request #4335 from ntherning/skip-unwind-info-functions-on-windows-with-disabled-jit
Skip unwind info functions on Windows when JIT is disabled
Niklas Therning [Wed, 8 Feb 2017 10:16:17 +0000 (11:16 +0100)]
Merge pull request #4333 from ntherning/Mono-Posix-Stdlib-do-not-clobber-Marshal.GetLastWin32Error
Make sure Stdlib.GetLastError() never clobbers Marshal.GetLastWin32Error()
Marek Safar [Tue, 7 Feb 2017 22:21:38 +0000 (23:21 +0100)]
Bump corefx
Zoltan Varga [Wed, 8 Feb 2017 03:03:43 +0000 (22:03 -0500)]
[lldb] Avoid a crash with the mono_tramp_info_register () call in load_aot_module ().
Zoltan Varga [Tue, 7 Feb 2017 23:35:20 +0000 (18:35 -0500)]
[sdb] Add an attach test, not yet enabled.
Marek Safar [Tue, 7 Feb 2017 18:54:18 +0000 (19:54 +0100)]
[xbuild] Add deprecation warning
Alexander Köplinger [Tue, 7 Feb 2017 21:50:36 +0000 (22:50 +0100)]
[ci] Temporarily use http url to download server until cert is fixed
Martin Baulig [Tue, 7 Feb 2017 21:24:02 +0000 (22:24 +0100)]
[btls]: MonoBtlsError.GetError(out string, out int) returns 0, not null. (#4338)
Ludovic Henry [Tue, 7 Feb 2017 20:09:47 +0000 (15:09 -0500)]
[threadpool] Fix hang on threadpool cleanup (#4330)
Waiting for the threadpool threads to exit on shutdown triggers a hand. The simplest solution is to not wait for them, and let the OS clean them up.
This is not an ideal solution, but this is to fix a months-long chase for this bug, and to release a less-buggy monthly release.
Zoltan Varga [Tue, 7 Feb 2017 19:35:50 +0000 (14:35 -0500)]
[runtime] Add a workaround for #50529 by locking around pthread_create()/pthread_join () calls so they can't happen at the same time. (#4332)