[xbuild] Fix dependency in C# targets
authorMichael Hutchinson <m.j.hutchinson@gmail.com>
Wed, 12 Feb 2014 19:02:45 +0000 (14:02 -0500)
committerMichael Hutchinson <m.j.hutchinson@gmail.com>
Wed, 12 Feb 2014 19:19:30 +0000 (14:19 -0500)
There was a typo in DependsOnTargets attribute of the
_AddCorlibReference target definition. It didn't break any
behaviour, since the target it depended on was always built
earlier in the build anyway, so it was really a sanity check.

However, it broke the tests for the new (unused) engine,
Microsoft.Build.dll, which checks for unexpected attributes.

mcs/tools/xbuild/data/12.0/Microsoft.CSharp.targets
mcs/tools/xbuild/data/4.0/Microsoft.CSharp.targets

index 79d92af3c39c4ffddce6d876d465a780ecda9629..5595d71b98a636706325896a40257dbe13994ff5 100644 (file)
@@ -24,7 +24,7 @@
                <DocFileItem Include="$(DocumentationFile)" Condition="'$(DocumentationFile)' != ''"/>
        </ItemGroup>
 
-       <Target Name="_AddCorlibReference" DependsOn="GetReferenceAssemblyPaths">
+       <Target Name="_AddCorlibReference" DependsOnTargets="GetReferenceAssemblyPaths">
                <!--
                HACK: We don't yet support property functions, so can't calculate FrameworkPathOverride
                by calling ToolLocationHelper.GetPathToStandardLibraries. Instead, we search the framework
index 79d92af3c39c4ffddce6d876d465a780ecda9629..5595d71b98a636706325896a40257dbe13994ff5 100644 (file)
@@ -24,7 +24,7 @@
                <DocFileItem Include="$(DocumentationFile)" Condition="'$(DocumentationFile)' != ''"/>
        </ItemGroup>
 
-       <Target Name="_AddCorlibReference" DependsOn="GetReferenceAssemblyPaths">
+       <Target Name="_AddCorlibReference" DependsOnTargets="GetReferenceAssemblyPaths">
                <!--
                HACK: We don't yet support property functions, so can't calculate FrameworkPathOverride
                by calling ToolLocationHelper.GetPathToStandardLibraries. Instead, we search the framework