Merge pull request #3540 from kumpera/abort-on-gerror
authormonojenkins <jo.shields+jenkins@xamarin.com>
Fri, 9 Sep 2016 00:45:04 +0000 (01:45 +0100)
committerGitHub <noreply@github.com>
Fri, 9 Sep 2016 00:45:04 +0000 (01:45 +0100)
[logging] Fix g_error not aborting.

Once we enabled g_log redirection, we stopped aborting as the new handlers didn't behave like eglib.

mono/utils/mono-log-common.c
mono/utils/mono-log-posix.c
mono/utils/mono-log-windows.c

index cf73d9acbb84cbcafc5328dc5fb6b3b6f9975e50..4948b91b80fbd84435428d56098e47d751d3b2a0 100644 (file)
@@ -132,7 +132,7 @@ mono_log_write_logfile (const char *log_domain, GLogLevelFlags level, mono_bool
 
        fflush(logFile);
 
-       if (level == G_LOG_FLAG_FATAL)
+       if (level & G_LOG_LEVEL_ERROR)
                abort();
 }
 
index 388fd26202f6c5f4b2b936b6bf81592d6ed0d049..6d25d3a6117b7cc4237bc10c8c6ef9e1e67cec3d 100644 (file)
@@ -84,7 +84,7 @@ mono_log_write_syslog(const char *domain, GLogLevelFlags level, mono_bool hdr, c
 {
        syslog (mapSyslogLevel(level), "%s", message);
 
-       if (level == G_LOG_FLAG_FATAL)
+       if (level & G_LOG_LEVEL_ERROR)
                abort();
 }
 
index d0ee01994371e00665dcea0f29e18634b377a66d..f6cd987fbba85c31ebda11b966b220ef3067f7ac 100644 (file)
@@ -104,7 +104,7 @@ mono_log_write_syslog(const char *domain, GLogLevelFlags level, mono_bool hdr, c
 
        fflush(logFile);
 
-       if (level == G_LOG_FLAG_FATAL)
+       if (level & G_LOG_LEVEL_ERROR)
                abort();
 }