1 2010-07-28 Marek Safar <marek.safar@gmail.com>
3 * anonymous.cs, assign.cs, attribute.cs, decl.cs, delegate.cs,
4 doc.cs, dynamic.cs, ecore.cs, expression.cs, generic.cs, import.cs,
5 iterators.cs, linq.cs, membercache.cs, method.cs, report.cs,
6 statement.cs, typemanager.cs: Major name lookup fixes to deal with
7 C# 3.0 invocable members, correctly handle accessibility hidding and
8 property-like different get/set base accessors.
10 Also fixes bugs #624870, #618522, #616068, #444180, #333891
12 2010-07-14 Marek Safar <marek.safar@gmail.com>
14 * namespace.cs, import.cs: When importing nested type via type
15 arguments set their parent type correctly (Fixes #622051).
17 2010-07-14 Marek Safar <marek.safar@gmail.com>
20 * attribute.cs: Add default lookup flags.
22 2010-07-12 Marek Safar <marek.safar@gmail.com>
24 * generic.cs: Don't use Report directly.
26 * expression.cs, ecore.cs: UserOperatorCall uses MethodSpec without
27 MethodGroupExpr, will be simplified later.
29 2010-07-09 Marek Safar <marek.safar@gmail.com>
31 * property.cs, parameters.cs: Inflated IndexerSpec parameters.
33 * import.cs: Don't build unused parameters.
35 2010-07-08 Marek Safar <marek.safar@gmail.com>
37 * expression.cs (Invocation): Don't recreate simple-name expression.
39 2010-07-07 Marek Safar <marek.safar@gmail.com>
41 * ecore.cs: Don't report NRE warning for lifted null.
43 2010-07-07 Marek Safar <marek.safar@gmail.com>
45 * typemanager.cs, convert.cs, expression.cs: Another reference
46 equality implementation attack (Fixes #620025, #579058).
48 2010-07-05 Marek Safar <marek.safar@gmail.com>
50 * context.cs, expression.cs, ecore.cs: BaseThis is fully based on
51 this expression (Fixes #619904).
53 2010-07-05 Marek Safar <marek.safar@gmail.com>
55 * membercache.cs, class.cs: Don't use base member to check for
56 property or indexer base implementation.
58 2010-07-03 Marek Safar <marek.safar@gmail.com>
60 * membercache.cs: Copy Membercache member state flags for 2 stage
61 inflate (Fixes #619555).
63 * ecore.cs: Use resolved accessors everywhere.
65 2010-07-02 Marek Safar <marek.safar@gmail.com>
68 * membercache.cs, property.cs: Check accessors of base property and
71 2010-07-02 Marek Safar <marek.safar@gmail.com>
73 * modifiers.cs, membercache.cs, import.cs, class.cs: Moved imported
74 override method checks into import.
76 * expression.cs: Removed redundant check.
78 2010-06-30 Marek Safar <marek.safar@gmail.com>
80 * nullable.cs, expression.cs, statement.cs, method.cs, ecore.cs,
81 delegate.cs, cs-parser.jay, visit.cs: Use MemberAccess to resolve
82 base access expression, it has all bits done correctly.
84 2010-06-30 Marek Safar <marek.safar@gmail.com>
86 * support.cs: Removed unused code.
88 * ecore.cs: Don't use memberlookup for operators.
90 2010-06-30 Marek Safar <marek.safar@gmail.com>
92 * typemanager.cs, membercache.cs, convert.cs, expression.cs,
93 ecore.cs: Replace remaining MethodLookup with correct user operator
94 lookup (to do correct deep lookup). Clean up most of outstanding
95 quirks in binary operator overload resolution.
97 2010-06-29 Marek Safar <marek.safar@gmail.com>
99 * import.cs: Operators must have between 1 and 2 parameters.
101 * method.cs: Switch destructor to direct membercache lookup
103 2010-06-29 Marek Safar <marek.safar@gmail.com>
105 * driver.cs, expression.cs: Use Membercache for StringConcat when
106 it got all what is needed.
108 2010-06-29 Marek Safar <marek.safar@gmail.com>
110 * membercache.cs, expression.cs, statement.cs, doc.cs, ecore.cs:
111 Changed FindMembers to allocate a new list only when a filter is
112 used. Saves decent chunk of memory and should save even more in the
113 future when the filter is not used that often.
115 2010-06-28 Marek Safar <marek.safar@gmail.com>
117 * field.cs, property.cs, assign.cs, const.cs, expression.cs,
118 ecore.cs, class.cs, cs-parser.jay, enum.cs: Don't use intermediate
119 structure for simple type fields (saves memory and makes few things
120 simpler). Clean up some hacks mostly for events.
122 2010-06-25 Marek Safar <marek.safar@gmail.com>
124 * statement.cs, cs-parser.jay: Don't create expensive block for
127 2010-06-24 Marek Safar <marek.safar@gmail.com>
129 * statement.cs, report.cs: Rethrow internal error when reporting is
132 * ecore.cs: Check for identical name only when simple name is set.
135 2010-06-24 Marek Safar <marek.safar@gmail.com>
137 A fix for bug #616809
138 * generic.cs, expression.cs, ecore.cs: Added a new type expression
139 for open generic type to pass unbound type arguments to typeof
142 2010-06-24 Marek Safar <marek.safar@gmail.com>
144 * statement.cs: Foreach collection implementation refactoring to
145 search for GetEnumerator more preciselly. Fixes #431453 and more
148 * linq.cs, decl.cs, ecore.cs, delegate.cs: Update methodgroup api.
150 2010-06-23 Marek Safar <marek.safar@gmail.com>
152 * cs-parser.jay: Track more locations.
154 2010-06-22 Marek Safar <marek.safar@gmail.com>
156 * cs-tokenizer.cs, location.cs, cs-parser.jay: Track more locations.
158 2010-06-18 Marek Safar <marek.safar@gmail.com>
160 * cs-tokenizer.cs, anonymous.cs, expression.cs, statement.cs,
161 support.cs, location.cs, cs-parser.jay: Some work on full ast mode.
163 2010-06-18 Marek Safar <marek.safar@gmail.com>
165 * convert.cs, typespec.cs, method.cs: Fixed few more dynamic
168 2010-06-18 Marek Safar <marek.safar@gmail.com>
170 * typemanager.cs, namespace.cs: Report more predefined types and
171 imported types collision types as a warning.
172 Fixes #537414, #601157
174 2010-06-18 Marek Safar <marek.safar@gmail.com>
176 * generic.cs: Overrides base method constraint can use method type
179 * import.cs: Removed redundant cache.
181 2010-06-17 Marek Safar <marek.safar@gmail.com>
183 * generic.cs: Propagate type only inflate downwards.
185 2010-06-17 Marek Safar <marek.safar@gmail.com>
187 A fix for bug #614955
188 * method.cs: Do not reject binary dynamic operators.
190 2010-06-17 Marek Safar <marek.safar@gmail.com>
192 * typespec.cs: Internal types have no generic parameters.
195 2010-06-17 Marek Safar <marek.safar@gmail.com>
197 A fix for bug #614955
198 * cs-parser.jay: Correctly set expression mode for default parameter
201 2010-06-17 Marek Safar <marek.safar@gmail.com>
203 A fix for bug #615023
204 * ecore.cs: Resolve dynamic namespace and keyword collision in the
205 favour of the keyword.
207 2010-06-17 Marek Safar <marek.safar@gmail.com>
209 A fix for bug #614917
210 * convert.cs: Allow more undocumented 0 like values to enum type
213 2010-06-17 Marek Safar <marek.safar@gmail.com>
215 * generic.cs, method.cs: Inflate copied type parameters from base
216 class or explicit interfaces.
218 * convert.cs: Fixed conversion between two type parameters.
221 2010-06-16 Marek Safar <marek.safar@gmail.com>
223 * membercache.cs, convert.cs: Correctly resize an array used by
226 2010-06-15 Marek Safar <marek.safar@gmail.com>
228 A fix for bug #599601
229 * dynamic.cs, ecore.cs: A new flag for dynamic resolver to ignore
230 generated member access left expression.
232 2010-06-16 Marek Safar <marek.safar@gmail.com>
234 * expression.cs: Dispatch dynamic invocation solely on left
237 2010-06-16 Marek Safar <marek.safar@gmail.com>
239 * expression.cs, statement.cs: Always persist explicit cast
240 semantic at expression level.
242 2010-06-15 Marek Safar <marek.safar@gmail.com>
244 * expression.cs, attribute.cs: Enable generic type parameters
247 2010-06-15 Marek Safar <marek.safar@gmail.com>
249 A fix for bug #612146
250 * generic.cs: Don't use fixed array for inflated type parameter
251 interface constraints.
253 2010-06-15 Marek Safar <marek.safar@gmail.com>
255 * typespec.cs: ElementTypeSpec has to use its own ITypeDefinition.
257 * report.cs: Unwrap elements for related symbols reporting.
259 2010-06-15 Marek Safar <marek.safar@gmail.com>
261 A fix for bug #612796
262 * cs-tokenizer.cs: Offset correctly keywords the first character
265 2010-06-15 Marek Safar <marek.safar@gmail.com>
267 A fix for bug #613397
268 * expression.cs: Removed too aggressive object initializers
271 2010-06-15 Marek Safar <marek.safar@gmail.com>
273 * parameter.cs, property.cs, membercache.cs, decl.cs, iterators.cs,
274 anonymous.cs, expression.cs, support.cs, method.cs, pending.cs,
275 class.cs, cs-parser.jay: Simplify parsing of accessors by removing
276 any intermediate steps and fake nodes, also saves few MBs of memory.
278 2010-06-11 Marek Safar <marek.safar@gmail.com>
280 * modifiers.cs, rootcontext.cs, location.cs, cs-parser.jay: More
281 precise modifiers parsing.
283 2010-06-09 Marek Safar <marek.safar@gmail.com>
285 * cs-tokenizer.cs, anonymous.cs, expression.cs, cs-parser.jay:
286 Fixed few shift/reduce conflicts.
288 2010-06-09 Marek Safar <marek.safar@gmail.com>
290 * typemanager.cs, parameter.cs, dynamic.cs, typespec.cs,
291 expression.cs, ecore.cs, cs-parser.jay: Fully parse composed type
292 specifiers and stop using string in AST.
294 2010-06-07 Marek Safar <marek.safar@gmail.com>
296 * typemanager.cs, eval.cs, iterators.cs, anonymous.cs, expression.cs
297 method.cs, class.cs, delegate.cs, cs-parser.jay, driver.cs, visit.cs
298 enum.cs: Hold location of predefined types.
300 2010-06-07 Marek Safar <marek.safar@gmail.com>
302 A fix for bug #610878
303 * pending.cs: Clone cached list before modifying.
305 2010-06-04 Marek Safar <marek.safar@gmail.com>
307 * convert.cs, typespec.cs, expression.cs: Start using array member
308 kind for better conversion checks.
310 * import.cs, report.cs: Report better error message for runtime
313 2010-06-04 Marek Safar <marek.safar@gmail.com>
315 * membercache.cs, convert.cs, nullable.cs, expression.cs: Optimize
316 user defined conversion probing and simplify user conversion for
317 nullabe types. Fixes #610940.
319 2010-06-03 Marek Safar <marek.safar@gmail.com>
321 A fix for bug #610919
322 * parameter.cs, property.cs, cs-parser.jay: Use independent implicit
323 parameters for explicit event accessors. Anonymous method capturing
324 won't otherwise work for event implicit parameter.
326 2010-06-02 Marek Safar <marek.safar@gmail.com>
328 A fix for bug #610088
329 * nullable.cs, expression.cs, statement.cs, method.cs, ecore.cs:
330 Ignore overrides for base overload resolution as for non-base
331 expressions and convert the best candidate to closest override
334 2010-06-01 Marek Safar <marek.safar@gmail.com>
336 A fix for bug #610139
337 * generic.cs, convert.cs: Recursively check effective base interface
339 2010-06-01 Marek Safar <marek.safar@gmail.com>
341 * statement.cs: Handle nullable types and type parameters in using
342 statement, avoid boxing value types. Also fixes #571010
344 2010-06-01 Marek Safar <marek.safar@gmail.com>
346 * convert.cs, expression.cs: Emit unbox for underlying nullable
349 2010-05-29 Marek Safar <marek.safar@gmail.com>
351 A fix for bug #610126
352 * expression.cs: Don't use branch optimization for types bigger than
355 2010-05-28 Marek Safar <marek.safar@gmail.com>
357 A fix for bug #609088
358 * import.cs: Check private modifier correctly.
360 2010-05-28 Marek Safar <marek.safar@gmail.com>
362 A fix for bug #609049
363 * ecore.cs: Don't ignore override methods when looking for base
366 2010-05-27 Marek Safar <marek.safar@gmail.com>
368 A fix for bugs #608007, #572540, #566130, #476358
370 * generic.cs, linq.cs, expression.cs, statement.cs, cs-parser.jay:
371 More tricky refactoring of implicit linq blocks.
373 2010-05-25 Marek Safar <marek.safar@gmail.com>
375 * linq.cs, cs-parser.jay: Keep location for all linq clauses.
377 2010-05-25 Marek Safar <marek.safar@gmail.com>
379 * context.cs, expression.cs, cs-parser.jay: Don't store current
380 block in This expression (it's too early for linq blocks).
382 2010-05-21 Marek Safar <marek.safar@gmail.com>
384 * expression.cs: Use constrained prefix more broadly to avoid boxing.
386 2010-05-20 Marek Safar <marek.safar@gmail.com>
388 A fix for bug #591149
389 * nullable.cs: Don't double wrap same expression.
391 2010-05-20 Marek Safar <marek.safar@gmail.com>
393 A fix for bug #569827
394 * anonymous.cs: Any issued error in probing mode means no match.
396 2010-05-20 Marek Safar <marek.safar@gmail.com>
398 * expression.cs: Search for base indexer using the closest match
401 2010-05-20 Marek Safar <marek.safar@gmail.com>
403 A fix for bug #572071
404 * method.cs: Set override constraints using unexpanded interface
407 2010-05-20 Marek Safar <marek.safar@gmail.com>
409 A fix for bug #572071
410 * ecore.cs: Include secondary extension method lookup in probing
413 2010-05-19 Marek Safar <marek.safar@gmail.com>
415 A fix for bug #515801
416 * typespec.cs (MayBecomeEqualGenericTypes): Recursively check
419 2010-05-19 Marek Safar <marek.safar@gmail.com>
421 A fix for bug #515801
422 * pending.cs: Advance counter correctly.
424 2010-05-19 Marek Safar <marek.safar@gmail.com>
426 A fix for bug #480139
427 * method.cs, pending.cs: Indexer override uses base name.
429 2010-05-19 Marek Safar <marek.safar@gmail.com>
431 A fix for bug #424064
432 * generic.cs: Replace original with inflated type parameter on
435 2010-05-19 Marek Safar <marek.safar@gmail.com>
437 A fix for bug #359733
438 * parameter.cs: Extension attribute can be defined in each assembly.
440 2010-05-18 Marek Safar <marek.safar@gmail.com>
442 A fix for bug #446507
443 * method.cs: Only one method can implement an interface.
445 2010-05-18 Marek Safar <marek.safar@gmail.com>
447 A fix for bug #594905
448 * convert.cs, constant.cs, expression.cs, literal.cs, ecore.cs:
449 Typed null can be used as a source for expression methods.
451 2010-05-18 Marek Safar <marek.safar@gmail.com>
453 A fix for bug #606551
454 * namespace.cs: Using directive imports only types and not nested
457 2010-05-17 Marek Safar <marek.safar@gmail.com>
459 * typespec.cs, expression.cs, statement.cs, ecore.cs, complete.cs,
460 delegate.cs: Member instance is resolved after member overload
461 definitely resolves static/instance property of member expression.
462 Fixes #545047, #358848, #456605, #460016, #603299
464 2010-05-12 Marek Safar <marek.safar@gmail.com>
466 A fix for bug #604981
467 * generic.cs, decl.cs, anonymous.cs: Reset more type arguments
468 details for nested anonymous methods stories.
470 2010-05-11 Marek Safar <marek.safar@gmail.com>
472 A fix for bug #604735
473 * namespace.cs: Don't report namespace collision.
475 2010-05-11 Marek Safar <marek.safar@gmail.com>
477 A fix for bug #604748
478 * class.cs, typespec.cs: Search full imported attribute hierarchy
481 2010-05-11 Marek Safar <marek.safar@gmail.com>
483 * namespace.cs: Ignore missing dependencies failure at
486 2010-05-11 Marek Safar <marek.safar@gmail.com>
488 A fix for bug #604640
489 * namespace.cs: Don't resolve using constraints too early.
491 2010-05-11 Marek Safar <marek.safar@gmail.com>
493 A fix for bug #604239
494 * generic.cs: Copy partial type constraints to partial container.
496 2010-05-10 Marek Safar <marek.safar@gmail.com>
498 A fix for bug #557210
499 * import.cs: Relax underlying enum field rules.
501 2010-05-10 Marek Safar <marek.safar@gmail.com>
503 A fix for bug #603476
504 * property.cs: Implement IParametersMember for indexer accessors.
506 2010-05-07 Marek Safar <marek.safar@gmail.com>
508 A fix for bug #601141
509 * class.cs: Update all partial modifiers.
511 2010-05-06 Marek Safar <marek.safar@gmail.com>
513 A fix for bug #601708
514 * method.cs, membercache.cs: Destructors cannot be hidden.
516 2010-05-06 Marek Safar <marek.safar@gmail.com>
518 A fix for bug #602551
519 * class.cs: Resursive reference of type definition is allowed.
521 2010-05-06 Marek Safar <marek.safar@gmail.com>
523 * anonymous.cs: Mutate cached storey instance types too.
525 2010-05-06 Marek Safar <marek.safar@gmail.com>
527 A fix for bug #602443
528 * convert.cs: Explicit enum conversion cannot involve user operators
530 2010-05-05 Miguel de Icaza <miguel@novell.com>
532 * class.cs (TypeContainer.DefineBaseTypes)
533 (TypeContainer.CheckRecursiveDefinition): check for the iface not
534 being null, as we could have failed resolution and crashed;
537 * cs-parser.jay: Productions to catch common mistakes when other
538 punctuation operators are used instead of comma. Fixes 571702
540 2010-05-05 Marek Safar <marek.safar@gmail.com>
542 * anonymous.cs: Mutate correct set of constraints.
544 2010-05-05 Marek Safar <marek.safar@gmail.com>
546 A fix for bug #602842
547 * expression.cs: Resolve all array bound arguments.
549 2010-05-05 Marek Safar <marek.safar@gmail.com>
551 * import.cs: Don't import private fields.
553 2010-04-30 Marek Safar <marek.safar@gmail.com>
555 Partially based on patch by <sami.lamti@gmail.com>
557 * eval.cs, ecore.cs: Fixed eval show methods.
559 2010-04-30 Marek Safar <marek.safar@gmail.com>
561 * generic.cs, delegate.cs: Implement output type inference of
562 methodgroup now when the specification was cleared at least little
565 2010-04-29 Marek Safar <marek.safar@gmail.com>
567 A fix for bug #575611
568 * class.cs: Fix recursive unmanaged recursice sruct check.
570 2010-04-29 Marek Safar <marek.safar@gmail.com>
572 A fix for bug #479776
573 * expression.cs: Implement typeof unbounded nested generic types.
575 2010-04-29 Marek Safar <marek.safar@gmail.com>
577 A fix for bug #474953
578 * class.cs: Fix valid recursive base type definition.
580 2010-04-29 Marek Safar <marek.safar@gmail.com>
582 A fix for bug #421737
583 * convert.cs, expression.cs: A boxing conversion exists from a
584 nullable-type to a reference type, if a boxing conversion exists
585 from the underlying non-nullable-value-type to the reference type.
587 2010-04-29 Marek Safar <marek.safar@gmail.com>
589 A fix for bug #376875
590 * import.cs: Import volatile modifier.
592 2010-04-29 Marek Safar <marek.safar@gmail.com>
594 A fix for bug #372412
595 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
598 2010-04-29 Marek Safar <marek.safar@gmail.com>
600 A fix for bug #568955
601 * statements.cs: Handle recursive scope initializers.
603 2010-04-28 Marek Safar <marek.safar@gmail.com>
605 A fix for bug #566511
606 * anonymous.cs: Always get inflated version of hoisted variable
607 on generic type definition.
609 2010-04-28 Marek Safar <marek.safar@gmail.com>
611 * import.cs, membercache.cs: Relax rules for valid properties.
613 2010-04-28 Marek Safar <marek.safar@gmail.com>
615 * import.cs: Intern arrays used in generic arguments.
617 2010-04-28 Marek Safar <marek.safar@gmail.com>
619 A fix for bug #600398
620 * convert.cs: Actually use effective base type for the comparison.
622 2010-04-28 Marek Safar <marek.safar@gmail.com>
624 A fix for bug #600326
625 * ecore.cs: Pass arity to base member lookup.
627 2010-04-28 Marek Safar <marek.safar@gmail.com>
629 A fix for bug #573385
630 * expression.cs: MemberAccess is of generic type based on right
633 2010-05-28 Marek Safar <marek.safar@gmail.com>
635 * cs-tokenizer.cs: Made tab size configurable.
637 2010-05-27 Marek Safar <marek.safar@gmail.com>
639 * attribute.cs: Ensure Obsolete members are defined before doing
642 2010-05-27 Marek Safar <marek.safar@gmail.com>
644 * visit.cs: Add DOM visitor skeleton.
648 2010-05-27 Marek Safar <marek.safar@gmail.com>
650 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
652 2010-05-27 Marek Safar <marek.safar@gmail.com>
654 * *.cs: Major rewrite of compiler internals to better work with
655 unmodified System.Reflection.Emit. Some of the key changes are
656 - TypeSpec replaces reflection specific System.Type.
657 - All Type(TypeSpec) operations are now done in compiler therefore
658 no dependency on SRE to inflate generic members and types or to
659 query unclosed types.
660 - MemberCache is now the only and full hierarchical topology.
661 - Generic constraints are implemented properly.
662 - And as a bonus compilation is on average 30% faster.
664 2010-04-15 Jb Evain <jbevain@novell.com>
666 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
668 2010-04-12 Marek Safar <marek.safar@gmail.com>
670 * expression.cs, attribute.cs, parameter.cs: More attribute type
673 2010-04-12 Marek Safar <marek.safar@gmail.com>
675 A fix for bug #593342
677 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
678 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
679 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
680 codegen.cs: Add custom attribute encoder to deal with unfinished
681 types and easier corlib bootstrap from its own types.
683 2010-03-26 Marek Safar <marek.safar@gmail.com>
685 * cs-parser.jay: Report invalid constraint types.
687 2010-03-16 Jb Evain <jbevain@novell.com>
689 * Makefile: rename the net_2_1 profile to moonlight.
691 2010-03-11 Marek Safar <marek.safar@gmail.com>
693 * statement.cs, cs-parser.jay: Use correct location for empty
696 2010-03-11 Marek Safar <marek.safar@gmail.com>
698 * cs-parser.jay: Disable Location from expression.
700 * generic.cs: Check constraints for overrides in the parser.
702 2010-03-09 Marek Safar <marek.safar@gmail.com>
704 * cs-parser.jay (GetLocation): Use an expression when available.
706 2010-03-04 Marek Safar <marek.safar@gmail.com>
708 A fix for bug #582579
709 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
711 2010-03-04 Marek Safar <marek.safar@gmail.com>
713 A patch by kornelpal@gmail.com
715 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
716 compiler generated classes sealed by default. Emit and close top
717 level compiler generated classes as well.
719 * support.cs: Use RuntimeHelpers.GetHashCode.
721 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
723 * Makefile: We need to use the internal bootstrapping gmcs for
724 net_2_1_bootstrap too now.
726 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
728 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
730 2010-03-02 Marek Safar <marek.safar@gmail.com>
732 * cs-tokenizer.cs: Missed few locations in previous fix.
734 2010-03-02 Marek Safar <marek.safar@gmail.com>
736 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
737 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
738 Report correct location for operator errors.
740 2010-03-02 Marek Safar <marek.safar@gmail.com>
742 * typemanager.cs (IsDynamicType): Don't check external types when
743 the attribute is not external.
745 2010-02-24 Marek Safar <marek.safar@gmail.com>
747 A fix for bug #582579
748 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
751 2010-02-24 Marek Safar <marek.safar@gmail.com>
753 A fix for bug #581804
754 * ecore.cs: Fixed type comparison.
756 2010-02-08 Miguel de Icaza <miguel@novell.com>
758 * namespace.cs (CompletionGetTypesStartingWith): Do not include
759 private types in the completion results.
761 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
764 2010-02-17 Marek Safar <marek.safar@gmail.com>
766 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
769 2010-02-14 Miguel de Icaza <miguel@novell.com>
771 * eval.cs: Do not do the report printer dance unless the user has
772 set the DescribeTypes feature.
774 2010-02-10 Marek Safar <marek.safar@gmail.com>
776 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
778 2010-02-08 Marek Safar <marek.safar@gmail.com>
780 A fix for bug #577029
781 * anonymous.cs: Fixed TypeBuilder* check.
783 2010-02-06 Miguel de Icaza <miguel@novell.com>
785 * eval.cs (CompileBlock): Also undo if there are problems during
786 semantic analysis, fixes various cases where invalid C# code would
787 be reported, but the internal changes would not be undone.
789 2010-02-03 Miguel de Icaza <miguel@novell.com>
791 * driver.cs: Change the --fatal flag to allow a number to be
792 passed, this ignores the first N fatal errors. Useful to debug
793 errors that do not happen on the first hit.
795 * cs-parser.jay (invocation_expression): accept both the
796 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
797 inside an invocation.
799 * driver.cs: Expose FatalErrors.
801 * eval.cs: Initialize the printer's Fatal property from the
802 Driver's FatalError flag, this allows csharp --fatal to work
805 Add support for calling Describe (typeof (TYPE)) if the expression
808 2010-02-02 Marek Safar <marek.safar@gmail.com>
810 A fix for bug #574991
811 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
814 2010-02-02 Marek Safar <marek.safar@gmail.com>
816 A fix for bug #575986
817 * expression.cs: Don't mutate typeof type definitions.
819 2010-01-28 Marek Safar <marek.safar@gmail.com>
821 * decl.cs: Use only one set of modifiers.
823 2010-01-26 Marek Safar <marek.safar@gmail.com>
825 A fix for bug #573329
826 * eval.cs: Don't disable error reporting completely on silent mode.
828 2010-01-25 Marek Safar <marek.safar@gmail.com>
830 A fix for bug #573312
831 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
832 pointer index of unknown size types greater than 2.
834 2010-01-15 Marek Safar <marek.safar@gmail.com>
836 * *.cs: Use only 1 member kind enum.
838 2010-01-15 Marek Safar <marek.safar@gmail.com>
840 * *.cs: Add event specification.
842 2010-01-14 Marek Safar <marek.safar@gmail.com>
844 * membercache.cs: Extracted from decl.cs.
846 * *.cs: Put more infrastructure in place.
848 2010-01-13 Marek Safar <marek.safar@gmail.com>
850 * *.cs: Add property specification, unused yet.
852 2010-01-13 Marek Safar <marek.safar@gmail.com>
854 * property.cs: Move all property based declarations into a new file.
856 2010-01-13 Marek Safar <marek.safar at gmail.com>
858 * expression.cs (Conditional): Resolve reduced expression.
860 2010-01-13 Marek Safar <marek.safar at gmail.com>
862 * *.cs: Introduced non-generic method specification.
864 2010-01-07 Marek Safar <marek.safar@gmail.com>
866 * method.cs: Move all method based declarations into a new file.
868 2010-01-07 Marek Safar <marek.safar@gmail.com>
870 * *.cs: Extract field specification.
872 2009-12-17 Marek Safar <marek.safar@gmail.com>
874 * field.cs: Extracted from class.cs
876 2009-12-15 Marek Safar <marek.safar@gmail.com>
878 * attribute.cs (GetFixedBuffer): Work on field definition only.
880 2009-12-15 Marek Safar <marek.safar@gmail.com>
882 * *.cs: Clean up NET_4_0 conditional where possible.
884 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
886 support.cs (DynamicType): Assembly property returns the assembly builder.
887 This is required due to how compiler context works in corlib.
889 2009-12-14 Marek Safar <marek.safar@gmail.com>
891 A fix for bug #564376
892 * assign.cs (LocalTemporary): Removed no longer needed special
895 2009-12-11 Marek Safar <marek.safar@gmail.com>
897 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
898 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
899 enum for easier debugging.
901 2009-12-10 Marek Safar <marek.safar@gmail.com>
903 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
906 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
909 2009-12-10 Marek Safar <marek.safar@gmail.com>
911 * cs-parser.jay, statement.cs: Handle parser error in code
914 2009-12-10 Marek Safar <marek.safar@gmail.com>
916 * ecore.cs: Ignore base imported methods when they are already
919 * eval.cs: Handle non-existent keys.
921 * report.cs, driver.cs: Make fatal work with console printer only.
923 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
925 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
927 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
929 * typemanager.cs: Add MakeGenericMethod that checks if the method
930 is really the generic method definition.
932 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
933 to inflate generic methods.
935 2009-12-08 Marek Safar <marek.safar@gmail.com>
937 A fix for bug #561149
938 * anonymous.cs: Use actual type parameters when checking for generic
941 2009-12-08 Marek Safar <marek.safar@gmail.com>
943 A fix for bug #561369
944 * expression.cs (DoNumericPromotion): Fixed typo.
946 2009-12-08 Marek Safar <marek.safar@gmail.com>
948 *.cs: Moving to generics world.
950 cs-parser.jay: Removed current_array_type.
952 2009-12-07 Marek Safar <marek.safar@gmail.com>
954 *.cs: Moving to generics world.
956 2009-12-04 Marek Safar <marek.safar@gmail.com>
958 *.cs: Moving to generics world (day 2).
960 2009-12-03 Marek Safar <marek.safar@gmail.com>
962 *.cs: Moving to generics world.
964 2009-12-02 Marek Safar <marek.safar@gmail.com>
966 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
967 Encode dynamic type attribute for elements where attributes cannot
970 2009-12-01 Marek Safar <marek.safar@gmail.com>
972 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
975 2009-12-01 Marek Safar <marek.safar@gmail.com>
977 A fix for bug #360455
978 * class.cs: Never report a unused warning for generic events to
979 workaround wrong expression type.
981 2009-11-30 Marek Safar <marek.safar@gmail.com>
983 A fix for bug #558305
984 * decl.cs, class.cs: Check partial method definitions using correct
987 2009-11-30 Marek Safar <marek.safar@gmail.com>
989 * argument.cs: Don't cache rarely used dynamic flag.
991 2009-11-27 Marek Safar <marek.safar@gmail.com>
993 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
995 2009-11-27 Marek Safar <marek.safar@gmail.com>
997 * ecore.cs (SimpleName): Removed no longer needed in_transit as
998 Resolve is now non-reentrant (saves ~0.6MB for corlib).
1000 2009-11-26 Marek Safar <marek.safar@gmail.com>
1002 A fix for bug #545081
1003 * decl.cs: Check private nested types of nested types recursively.
1005 2009-11-26 Marek Safar <marek.safar@gmail.com>
1007 A fix for bug #558305
1008 * location.cs: Ignore self referencing #line directive
1010 2009-11-26 Marek Safar <marek.safar@gmail.com>
1012 A fix for bug #558292
1013 * class.cs: Allow single unsafe fixed buffer fields.
1015 2009-11-26 Marek Safar <marek.safar@gmail.com>
1017 * expression: Optimize few more zero-based operations.
1019 2009-11-26 Marek Safar <marek.safar@gmail.com>
1021 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
1022 avoids boxing of literal values.
1024 2009-11-26 Marek Safar <marek.safar@gmail.com>
1026 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
1027 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
1028 codegen.cs: LocatedToken redesing to avoid excessive allocation and
1029 boxing (saves ~7MB for corlib). Also fixes presise token location.
1031 2009-11-25 Marek Safar <marek.safar@gmail.com>
1033 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
1034 common data buckers.
1036 2009-11-24 Marek Safar <marek.safar@gmail.com>
1038 * expression.cs: Lower static array initializer barrier.
1040 * support.cs, driver.cs: Share reader buffer.
1042 2009-11-23 Marek Safar <marek.safar@gmail.com>
1044 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
1046 2009-11-23 Marek Safar <marek.safar@gmail.com>
1048 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
1049 cleanup some obsolete code.
1051 2009-11-20 Marek Safar <marek.safar@gmail.com>
1053 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
1056 2009-11-20 Marek Safar <marek.safar@gmail.com>
1058 * *.cs: Resolved expressions are never resolved again, this helps to
1059 uncover some not easy to find bugs and improve the performance.
1061 2009-11-19 Marek Safar <marek.safar@gmail.com>
1063 * *.cs: Made constant expressions fully compatible with any other
1066 2009-11-19 Marek Safar <marek.safar@gmail.com>
1068 * *.cs: DoResolve is a worker method and has to be protected.
1070 2009-11-18 Marek Safar <marek.safar@gmail.com>
1072 * *.cs: More context specific handling.
1074 2009-11-17 Marek Safar <marek.safar@gmail.com>
1076 * *.cs: More context specific handling.
1078 2009-11-16 Marek Safar <marek.safar@gmail.com>
1080 * dynamic.cs, class.cs: Removed few fixed user types conversions.
1082 * symbolwriter.cs: Uses public ILOffset.
1084 2009-11-13 Marek Safar <marek.safar@gmail.com>
1086 A fix for bug #553650
1087 * generic.cs: Another missing TypeToCoreType, still too many to fix.
1089 2009-11-13 Marek Safar <marek.safar@gmail.com>
1091 A fix for bug #555170
1093 * class.cs, delegate.cs, enum.cs: Constants have to be available
1094 for parameters resolve.
1096 2009-11-12 Marek Safar <marek.safar@gmail.com>
1098 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
1101 2009-11-12 Marek Safar <marek.safar@gmail.com>
1103 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
1104 with a statically known candidate set.
1106 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
1108 * generic.cs: Made type inflation for generic constraint checks
1109 recursive. This fixes BGO #553655.
1111 2009-11-11 Marek Safar <marek.safar@gmail.com>
1113 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
1116 2009-11-10 Marek Safar <marek.safar@gmail.com>
1118 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
1119 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
1120 attribute.cs: Add some dynamic error checking.
1122 2009-11-07 Marek Safar <marek.safar@gmail.com>
1124 A fix for bug #553465
1126 * expression.cs: Fixed mixed version of expression tree anonymous
1129 2009-11-06 Marek Safar <marek.safar@gmail.com>
1131 A fix for bug #553031
1133 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
1134 expression tree version of anonymous type with members declaration.
1136 2009-11-05 Marek Safar <marek.safar@gmail.com>
1138 * parameter.cs: Handle nullable parameter default expression.
1140 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
1141 class.cs, attribute.cs: Check for wrong dynamic arguments.
1143 2009-11-05 Marek Safar <marek.safar@gmail.com>
1145 * statement.cs: Dynamic statements.
1147 2009-11-04 Marek Safar <marek.safar@gmail.com>
1149 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
1150 Compound assignments over dynamic type.
1152 2009-11-03 Marek Safar <marek.safar@gmail.com>
1154 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
1155 constructor arguments.
1157 2009-10-30 Marek Safar <marek.safar@gmail.com>
1159 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
1160 codegen.cs: Unary mutator on dynamic member access expression.
1162 2009-10-29 Marek Safar <marek.safar@gmail.com>
1164 A fix for bug #550580
1165 * convert.cs: Don't eliminate explicit precission casts.
1167 2009-10-28 Marek Safar <marek.safar@gmail.com>
1169 A fix for bug #550404
1171 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
1172 expression.cs, statement.cs, ecore.cs: Quote any nested expression
1175 2009-10-27 Marek Safar <marek.safar@gmail.com>
1177 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
1180 * class.cs: Allow nullable binary user operators.
1182 2009-10-26 Marek Safar <marek.safar@gmail.com>
1184 * expression.cs: Move binary expression optimization at the end of
1187 2009-10-23 Marek Safar <marek.safar@gmail.com>
1189 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
1190 Separate NullConstant from NullLiteral.
1192 2009-10-23 Marek Safar <marek.safar@gmail.com>
1194 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
1195 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
1196 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
1197 ModuleContainer. Add common unclosed member check routine.
1199 2009-10-22 Marek Safar <marek.safar@gmail.com>
1201 * argument.cs: Use literal flag for real literals only.
1203 * dynamic.cs: Use correct return type for custom delegates.
1205 2009-10-22 Marek Safar <marek.safar@gmail.com>
1207 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
1210 2009-10-22 Marek Safar <marek.safar@gmail.com>
1212 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
1214 2009-10-21 Marek Safar <marek.safar@gmail.com>
1216 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
1219 2009-10-21 Marek Safar <marek.safar@gmail.com>
1221 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
1224 2009-10-20 Marek Safar <marek.safar@gmail.com>
1226 * argument.cs, dynamic.cs, expression.cs: Latest API update.
1228 2009-10-19 Marek Safar <marek.safar@gmail.com>
1230 * typemanager.cs, expression.cs: Dynamic array initializer.
1232 2009-10-16 Marek Safar <marek.safar@gmail.com>
1234 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
1237 2009-10-16 Marek Safar <marek.safar@gmail.com>
1239 A fix for bug #493523, #507067
1240 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
1241 standard nullable conversion using underlying standard conversion
1242 and not full conversion.
1244 2009-10-15 Marek Safar <marek.safar@gmail.com>
1246 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
1247 type in VerifyArgumentsCompat.
1249 2009-10-15 Marek Safar <marek.safar@gmail.com>
1251 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1252 Reject variable used with type arguments.
1254 2009-10-14 Marek Safar <marek.safar@gmail.com>
1256 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
1257 Implement dynamic expressions assignment.
1259 2009-10-14 Marek Safar <marek.safar@gmail.com>
1261 * expression.cs: Build underlying expression when resolving unary
1264 2009-10-14 Marek Safar <marek.safar@gmail.com>
1266 * expression.cs: Emit enum array initializer using binary blob.
1268 2009-10-08 Marek Safar <marek.safar@gmail.com>
1270 * typemanager.cs, constant.cs: Optimize decimal constants which fit
1273 2009-10-07 Marek Safar <marek.safar@gmail.com>
1275 * typemanager.cs: Reset object_type.
1277 * assign: Made SimpleAssign public.
1279 2009-10-06 Marek Safar <marek.safar@gmail.com>
1281 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
1282 invocation assembly to IsThisOrFriendAssembly.
1284 2009-10-05 Marek Safar <marek.safar@gmail.com>
1286 * expression.cs: Equality comparison of generic parameter with
1289 2009-10-05 Marek Safar <marek.safar@gmail.com>
1291 A fix for bug #543570
1292 * generic.cs: Import predefined constraints correctly.
1294 2009-10-02 Marek Safar <marek.safar@gmail.com>
1296 * ecore.cs: Don't crash on overloads with optional paremeters where
1297 arguments count overflows.
1299 * parameter.cs: Import optional parameter constants using optional
1302 2009-10-01 Marek Safar <marek.safar@gmail.com>
1304 * Makefile: Default is gmcs compiler.
1306 2009-10-01 Marek Safar <marek.safar@gmail.com>
1308 * cs-parser.jay: Fixed few NRE.
1310 2009-10-01 Marek Safar <marek.safar@gmail.com>
1312 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
1314 2009-09-30 Marek Safar <marek.safar@gmail.com>
1316 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
1317 ShimExpression, ImplicitCast.
1319 2009-09-30 Marek Safar <marek.safar@gmail.com>
1321 A fix for bug #542959
1322 * delegate.cs: Emit correct delegate instance variable when there
1323 are static and non-static overloads.
1325 2009-09-29 Marek Safar <marek.safar@gmail.com>
1327 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
1328 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
1330 2009-09-28 Marek Safar <marek.safar@gmail.com>
1332 A fix for bug #542487
1333 * ecore.cs: Resolve extension methods hidden by properties.
1335 2009-09-25 Marek Safar <marek.safar@gmail.com>
1337 * expression.cs, ecore.cs: More dynamic binary expressions.
1339 2009-09-22 Marek Safar <marek.safar@gmail.com>
1341 * nullable.cs, expression.cs: Fixed null lifted conversion for
1342 bitwise enum operations.
1344 2009-09-22 Marek Safar <marek.safar@gmail.com>
1346 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
1347 values in checked context.
1349 2009-09-22 Marek Safar <marek.safar@gmail.com>
1351 * expression.cs, ecore.cs: Fixed array index constant conversion.
1353 2009-09-20 Miguel de Icaza <miguel@novell.com>
1355 * expression.cs: Do not crash when MemberLookup returns something
1356 that is not a MemberExpr here. Report error 582 instead.
1360 2009-09-18 Marek Safar <marek.safar@gmail.com>
1362 * decl.cs, class.cs: Check protected property accessors.
1364 2009-09-18 Marek Safar <marek.safar@gmail.com>
1366 * dynamic.cs, assign.cs: Dynamic compound assignment.
1368 2009-09-17 Marek Safar <marek.safar@gmail.com>
1370 * expression.cs: Fixed compound assignment explicit conversion.
1372 2009-09-17 Marek Safar <marek.safar@gmail.com>
1374 * expression.cs, ecore.cs: Cannot infer variables from method group.
1376 2009-09-16 Marek Safar <marek.safar@gmail.com>
1378 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
1379 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
1380 codegen.cs: Dynamic binary operations scaffolding.
1382 2009-09-15 Marek Safar <marek.safar@gmail.com>
1384 * expression.cs: Fixes nullable promotion for enum type variables.
1386 2009-09-11 Marek Safar <marek.safar@gmail.com>
1388 * driver.cs, dynamic.cs: Reset more static variables.
1390 2009-09-11 Marek Safar <marek.safar@gmail.com>
1392 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
1393 driver.cs: Introduced Expression::MakeExpression.
1395 2009-09-11 Marek Safar <marek.safar@gmail.com>
1397 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
1399 2009-09-09 Marek Safar <marek.safar@gmail.com>
1401 * eval.cs, report.cs: Use Console.Out for all eval error or warning
1404 2009-09-09 Marek Safar <marek.safar@gmail.com>
1406 A fix for bug #518707
1407 * expression.cs (Is): Optimize only generic parameter type
1408 expression probing value type generic parameter.
1410 2009-09-09 Marek Safar <marek.safar@gmail.com>
1412 A fix for bug #532571
1413 * ecore.cs: Check for simple name type arguments used with
1416 2009-09-08 Marek Safar <marek.safar@gmail.com>
1418 A fix for bug #497421
1419 * generic.cs (CheckConstraint): Don't use buildin types to check for
1420 parameterless constructor.
1422 2009-09-08 Marek Safar <marek.safar@gmail.com>
1424 A fix for bug #537402
1425 * generic.cs (CheckConstraint): Correctly inflate generic type
1426 arguments when checking generic method.
1428 2009-09-08 Marek Safar <marek.safar@gmail.com>
1430 A fix for bug #536463
1431 * decl.cs (AddToContainer): Don't report collision between explicit
1432 and parameterless non-explicit members.
1434 2009-09-08 Marek Safar <marek.safar@gmail.com>
1436 * eval.cs: Reset more static stuff.
1438 2009-09-07 Marek Safar <marek.safar@gmail.com>
1440 A fix for bug #324625
1441 * expression.cs, ecore.cs: Create nested generic type expression
1442 using declaring and not current type.
1444 2009-09-07 Marek Safar <marek.safar@gmail.com>
1446 * *.cs: Changed Report class to accept various output printers and
1447 be an instance class. An expression resolver can now use different
1448 message reporter for each call and Report.Error can safely throw
1449 an exception. Part of ongoing work to turn mcs into proper library.
1451 2009-09-04 Marek Safar <marek.safar@gmail.com>
1453 * statement.cs, ecore.cs: Removed error reporting from emit code.
1455 2009-09-04 Marek Safar <marek.safar@gmail.com>
1457 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
1459 2009-09-03 Marek Safar <marek.safar@gmail.com>
1461 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
1462 parser checks out of constructors.
1464 2009-09-02 Marek Safar <marek.safar@gmail.com>
1466 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
1468 2009-09-02 Marek Safar <marek.safar@gmail.com>
1470 A fix for bug #535448
1471 * anonymous.cs, class.cs: Copy return label between all contexts.
1473 2009-09-02 Marek Safar <marek.safar@gmail.com>
1475 A fix for bug #535395
1476 * namespace.cs: Resolve context can be null.
1478 2009-08-25 Marek Safar <marek.safar@gmail.com>
1480 A fix for bug #533912
1481 * generic.cs: Use correct context for constraints resolving.
1483 2009-08-25 Marek Safar <marek.safar@gmail.com>
1485 A fix for bug #532630
1486 * driver.cs: Trim conditional symbols.
1488 2009-08-25 Marek Safar <marek.safar@gmail.com>
1490 * context.cs: New file.
1492 * *.exe.sources, *.csproj: Updated.
1494 2009-08-25 Marek Safar <marek.safar@gmail.com>
1496 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
1497 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
1498 IMembercontext, some small cleanups.
1500 2009-08-24 Marek Safar <marek.safar@gmail.com>
1502 * *.cs: Split ResolveContext and EmitContext.
1504 2009-08-24 Marek Safar <marek.safar@gmail.com>
1506 * *.cs: Only ResolveContext implements IMemberContext.
1508 2009-08-21 Marek Safar <marek.safar@gmail.com>
1510 * *.cs: Renamed IResolveContext to IMemberContext.
1512 2009-08-21 Marek Safar <marek.safar@gmail.com>
1514 * *.cs: Detached ResolveContext from EmitContext.
1516 2009-08-21 Marek Safar <marek.safar@gmail.com>
1518 * codegen.cs: Moved flow-analysis to BlockContext.
1520 2009-08-21 Marek Safar <marek.safar@gmail.com>
1522 * *.cs: Detached BlockContext from EmitContext.
1524 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
1526 * statement.cs: avoid nullref when the return value of GetEnumerator()
1527 does not contain any MoveNext() method.
1529 2009-08-19 Marek Safar <marek.safar@gmail.com>
1531 * *.cs: Removed IResolveContext::GenericDeclContainer.
1533 2009-08-19 Marek Safar <marek.safar@gmail.com>
1535 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
1537 2009-08-19 Marek Safar <marek.safar@gmail.com>
1539 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1540 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1542 2009-08-18 Marek Safar <marek.safar@gmail.com>
1544 * *.cs: Removed boolean fields from EmitContext.
1546 2009-08-18 Marek Safar <marek.safar@gmail.com>
1548 * *.cs: Add IResolveContext::IsStatic.
1550 2009-08-18 Marek Safar <marek.safar@gmail.com>
1552 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1554 2009-08-17 Marek Safar <marek.safar@gmail.com>
1556 * *.cs: Removed DeclContainer from EmitContext.
1558 2009-08-17 Marek Safar <marek.safar@gmail.com>
1560 * *.cs: Add IResolveContext::CurrentTypeParameters.
1562 2009-08-14 Marek Safar <marek.safar@gmail.com>
1564 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1566 2009-08-14 Marek Safar <marek.safar@gmail.com>
1568 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1569 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1571 2009-08-13 Marek Safar <marek.safar@gmail.com>
1573 * decl.cs: Look in PartialContainer for parent type parameters.
1575 2009-08-13 Marek Safar <marek.safar@gmail.com>
1577 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1578 codegen.cs: Add IResolveContext::LookupTypeParameter.
1580 2009-08-13 Marek Safar <marek.safar@gmail.com>
1582 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1583 Moved resolved logic from Emit to Resolve.
1585 2009-08-13 Marek Safar <marek.safar@gmail.com>
1587 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1588 codegen.cs: Reworked atttributes handling of ResolveContext.
1590 2009-08-12 Marek Safar <marek.safar@gmail.com>
1592 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1593 LookupNamespaceOrType to ResolveContext.
1595 2009-08-12 Marek Safar <marek.safar@gmail.com>
1597 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1598 class.cs: Removed unused parameters and methods.
1600 2009-08-11 Marek Safar <marek.safar@gmail.com>
1602 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1603 codegen.cs: Finding the best common type of a set of expressions for
1606 2009-08-07 Marek Safar <marek.safar@gmail.com>
1608 * dynamic.cs, expression.cs: More dynamic conversions.
1610 2009-08-06 Miguel de Icaza <miguel@novell.com>
1612 * generic.cs: This loop was incorrect, it was increment ii, but
1613 checking for `i'. This was a change introduced to fix #327497,
1616 * class.cs: Catch another case for cs0533 error, fixes #324782.
1618 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1620 * typemanager.cs (GetGenericArguments): SRE returns null for
1621 generic methods on type builder instances if they are not generic
1622 themselves. For example, for Foo<int>::Bar() it returns null, but
1623 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1625 2009-08-05 Marek Safar <marek.safar@gmail.com>
1627 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1628 delegate.cs: Work on dynamic binding.
1630 2009-08-04 Marek Safar <marek.safar@gmail.com>
1632 A second fix for bug #525342
1633 * class.cs: Attach partial method attributes to method
1636 2009-08-03 Marek Safar <marek.safar@gmail.com>
1638 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1641 * rootcontext.cs: Default to langversion v4.
1643 2009-08-03 Marek Safar <marek.safar@gmail.com>
1645 * pending.cs: Check return type before member info is set.
1647 2009-08-03 Marek Safar <marek.safar@gmail.com>
1649 * anonymous.cs: Fully initialize generic hoisted field expression.
1651 2009-08-02 Miguel de Icaza <miguel@novell.com>
1653 * cs-parser.jay: Flag variables declared on the interactive shell
1654 as used to prevent the 168 warning about local variable not being
1657 2009-07-31 Marek Safar <marek.safar@gmail.com>
1659 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1660 attribute.cs: Emit dynamic export attribute.
1662 2009-07-30 Marek Safar <marek.safar@gmail.com>
1664 * expression.cs: More verifier work.
1666 2009-07-29 Marek Safar <marek.safar@gmail.com>
1668 * nullable.cs: Fixed SRE crash during corlib compilation.
1670 2009-07-29 Marek Safar <marek.safar@gmail.com>
1672 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1673 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1674 More TypeManager.TypeToCoreType needed.
1676 2009-07-29 Marek Safar <marek.safar@gmail.com>
1678 * anonymous.cs: Update after recent SRE fixes.
1680 2009-07-28 Marek Safar <marek.safar@gmail.com>
1682 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1683 version of GetFieldHandle for fields of generic types.
1685 2009-07-27 Marek Safar <marek.safar@gmail.com>
1687 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1688 ecore.cs: Add TypeManager.IsDynamicType,
1689 PredefinedAttributes.Dynamic.
1691 2009-07-27 Marek Safar <marek.safar@gmail.com>
1693 A fix for bug #415375
1694 * expression.cs: Fixed object and reference type parameter
1697 2009-07-27 Marek Safar <marek.safar@gmail.com>
1699 A fix for bug #525342
1700 * class.cs: Attach partial method attributes to method
1703 2009-07-24 Marek Safar <marek.safar@gmail.com>
1705 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1708 2009-07-24 Marek Safar <marek.safar@gmail.com>
1710 * anonymous.cs (MutateField): Add imported types handling.
1712 2009-07-23 Marek Safar <marek.safar@gmail.com>
1714 * expression.cs, delegate.cs: Moved arguments resolve into their
1715 counterparts expressions. Removed argument resolve from
1716 CollectionElementInitializer.
1718 2009-07-23 Marek Safar <marek.safar@gmail.com>
1720 A fix for bug #523683
1721 * convert.cs, delegate.cs: Use common overload mechanism for method
1722 group conversion check.
1724 2009-07-22 Marek Safar <marek.safar@gmail.com>
1726 A fix for bug #523899
1727 * generics.cs: Exact type inference with other bound types.
1729 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1731 Don't complain when the same type is implemented by the output
1732 assembly as well as multiple referenced assemblies
1733 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1734 'must_be_unique' flag.
1735 (GlobalRootNamespace): Update to changes.
1736 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1737 already have a type in hand.
1739 2009-07-22 Marek Safar <marek.safar@gmail.com>
1741 * expression.cs: More verifier instrumentation.
1743 * statement.cs: Do proper throw expression conversion.
1745 2009-07-22 Marek Safar <marek.safar@gmail.com>
1747 A fix for bug #522789
1748 * expression.cs: Mutate invocation return type.
1750 2009-07-16 Marek Safar <marek.safar@gmail.com>
1752 * anonymous.cs: Split assignable and readonly generated variable
1755 2009-07-16 Marek Safar <marek.safar@gmail.com>
1757 A fix for bug #521671
1758 * statement.cs: Fixed crash when checking missing type.
1760 2009-07-16 Marek Safar <marek.safar@gmail.com>
1762 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1763 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1764 class.cs, driver.cs: Work on dynamic binding.
1766 * dynamic.cs: New file.
1768 * *.sources, *.proj: Updated.
1770 2009-07-15 Marek Safar <marek.safar@gmail.com>
1772 * expression.cs (Conditional): Avoid double Resolve.
1774 2009-07-13 Marcus Griep <marcus@griep.us>
1776 * ecore.cs: Fix obscure bug with resolving members of interfaces
1777 that hide parent interface members. Fixes bug #444388 and corrects
1780 2009-07-13 Marek Safar <marek.safar@gmail.com>
1782 * expression.cs (LocalVariableReference): Bounce resolve.
1784 2009-07-10 Marek Safar <marek.safar@gmail.com>
1786 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1787 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1790 * support.cs: New dynamic type wrapper.
1792 2009-07-08 Marek Safar <marek.safar@gmail.com>
1794 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1795 typed local variable.
1797 2009-07-06 Marek Safar <marek.safar@gmail.com>
1799 A fix for bug #519005
1800 * anonymous.cs: Use null_type as no return type placeholder.
1802 2009-07-02 Marek Safar <marek.safar@gmail.com>
1804 * generic.cs: Handle type inference of identical type parameters
1805 with different bounds.
1807 2009-07-01 Marek Safar <marek.safar@gmail.com>
1809 * expression.cs, class.cs: Events variance.
1811 * cs-parser.jay: Interface events error messages.
1813 2009-07-01 Marek Safar <marek.safar@gmail.com>
1815 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1817 2009-06-29 Marek Safar <marek.safar@gmail.com>
1819 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1820 parameter expression can be value-type New.
1822 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1824 2009-06-26 Marek Safar <marek.safar@gmail.com>
1826 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1827 Implemented C# 4.0 named arguments.
1829 2009-06-24 Marek Safar <marek.safar@gmail.com>
1831 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1832 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1833 parameter modifier. Also fixes bug #515497.
1835 2009-06-24 Marek Safar <marek.safar@gmail.com>
1837 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1838 arguments expression to be implemented.
1840 *.sources: Add argument.cs
1842 2009-06-23 Marek Safar <marek.safar@gmail.com>
1844 * parameter.cs: Moved GetParameterIndexByName to base class.
1846 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1847 unused AType. Use argument's version of GetExpressionTree.
1849 2009-06-22 Marek Safar <marek.safar@gmail.com>
1851 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1854 2009-06-17 Marek Safar <marek.safar@gmail.com>
1856 A fix for bug #514096
1857 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1859 2009-06-17 Marek Safar <marek.safar@gmail.com>
1861 * expression.cs: The first multi-dimensional array nested array
1862 initializers was not checked.
1864 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1866 2009-06-17 Marek Safar <marek.safar@gmail.com>
1868 A fix for bug #513400
1869 * nullable.cs (EmitEquality): Operands emit could be simplified for
1870 built-in types when we now emit user operators differently.
1872 2009-06-16 Marek Safar <marek.safar@gmail.com>
1874 * ecore.cs: Report inaccessible delegate methods correctly.
1876 2009-06-16 Marek Safar <marek.safar@gmail.com>
1878 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1879 cs-parser.jay: Implemented C# 4.0 optional parameters.
1881 2009-06-16 Marek Safar <marek.safar@gmail.com>
1883 * driver.cs: Removed broken DefineManifestResource.
1885 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1887 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1888 Use $(BOOTSTRAP_PROFILE) instead.
1890 2009-06-12 Jb Evain <jbevain@novell.com>
1892 * rootcontext.cs: add a Platform field.
1893 * driver.cs: handle /platform.
1894 * codegen.cs: pass the proper flags according to
1895 the platform when saving the assembly.
1897 2009-06-11 Marek Safar <marek.safar@gmail.com>
1899 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1900 Add optional parameters grammar.
1902 2009-06-10 Marek Safar <marek.safar@gmail.com>
1904 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1905 driver.cs: Split lang version and metadata version.
1907 2009-06-10 Marek Safar <marek.safar@gmail.com>
1909 * decl.cs: Better overload ctor collision error message.
1911 2009-06-05 Jb Evain <jbevain@novell.com>
1913 * driver.cs (EmbededResource): avoid using an internal method
1914 in gmcs to embed manifest resources.
1916 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1918 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1919 the compiler from older mono versions (like moon's bots)
1921 2009-06-04 Marek Safar <marek.safar@gmail.com>
1923 * namespace.cs (LookupTypeReflection): Ignore collisions between
1926 2009-06-04 Marek Safar <marek.safar@gmail.com>
1928 * codegen.cs: Enabled generic type forwarders.
1930 2009-06-04 Marek Safar <marek.safar@gmail.com>
1932 * dmcs.*: Add another version of SRE compiler.
1934 2009-06-03 Marek Safar <marek.safar@gmail.com>
1936 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1937 generic-mcs.cs: Fixed variant type conversions.
1939 2009-06-02 Marek Safar <marek.safar@gmail.com>
1941 A fix for bug #507863
1942 * codegen.cs: Fixes a crash on invalid string value attribute.
1944 2009-06-01 Marek Safar <marek.safar@gmail.com>
1946 A fix for bug #508334
1947 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1948 cs-parser.jay: Fully import __arglist modifier.
1950 2009-05-29 Marek Safar <marek.safar@gmail.com>
1952 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1953 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1954 actually work with closed generic types.
1956 2009-05-27 Alan McGovern <amcgovern@novell.com>
1958 * class.cs, decl.cs, delegate.cs, parameter.cs:
1959 Fix the build by replacing the use of 'var' with the actual type.
1961 2009-05-27 Marek Safar <marek.safar@gmail.com>
1963 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1964 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1967 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1970 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1971 Marek Safar <marek.safar@gmail.com>
1973 A fix for bug #377509
1974 * parameter.cs: Use predefined and not empty name for implicit
1977 2009-05-21 Marek Safar <marek.safar@gmail.com>
1979 * class.cs: Don't report wrong warnings for event fields.
1981 2009-05-21 Marek Safar <marek.safar@gmail.com>
1983 A fix for bug #504667
1984 * class.cs: Check for static class using parent container instead of
1987 2009-05-08 Marek Safar <marek.safar@gmail.com>
1989 A fix for bug #496922
1990 * expression.cs: Always use temporary variable when using object
1993 2009-04-28 Marek Safar <marek.safar@gmail.com>
1995 A fix for bug #495112
1996 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1999 2009-04-27 Miguel de Icaza <miguel@novell.com>
2001 * driver.cs: Add a flag to work as a replacement for CSC in VS.
2003 2009-04-24 Miguel de Icaza <miguel@novell.com>
2005 * complete.cs: No idea how gonzalo got a null in the list, but
2008 2009-04-24 Miguel de Icaza <miguel@novell.com>
2010 * complete.cs (CompletionElementInitializer): New completion class
2011 to support completing inside a C# 3 element initializer, so this
2012 allows completion for Silverlight situations where it is very
2015 new TextBlock () { Fo<TAB>
2017 (CompletionSimpleName): Expose the prefix that was
2018 passed to the simple name.
2020 * cs-parser.jay (object_or_collection_initializer): Add support
2021 for element_initializers.
2023 * expression.cs (CollectionOrObjectInitializers.DoResolve):
2024 special case completion expressions as this method aggressively
2025 collects data before it operates, and errors were being thrown
2026 earlier than we were able to complete.
2028 2009-04-23 Miguel de Icaza <miguel@novell.com>
2030 * eval.cs: Make getcompletions silent and enable debugging output
2031 if the -v option is passed.
2033 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
2034 Consider looking up the namespace that matches the prefix being
2037 This is part of the support for allowing completions like:
2038 `System.Co<TAB>' to complete to System.Console.
2040 * complete.cs (CompletionSimpleName.AppendResults): Make this
2043 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
2045 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
2046 COMPLETE_COMPLETION as internal.
2048 2009-04-17 Miguel de Icaza <miguel@novell.com>
2050 * complete.cs: Include namespace resolution in simple names as
2051 well as global types and types in the using scope in the
2054 * namespace.cs: Supporting infrastrcture to provide completions
2055 based on the current using scope.
2057 * eval.cs: Introduce an entry point that allows for initialization
2058 to return a list of the files passed on the command line.
2060 2009-04-14 Marek Safar <marek.safar@gmail.com>
2062 A fix for bug #494243
2063 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
2065 2009-04-13 Marek Safar <marek.safar@gmail.com>
2067 A fix for bug #493887
2068 * statement.cs: Don't skip string multi-section with default or
2069 null label when populating string hashtable.
2071 2009-04-06 Marek Safar <marek.safar@gmail.com>
2073 A fix for bug #492329
2074 * expression.cs (New): Load variable when assigning type parameter
2077 2009-04-06 Marek Safar <marek.safar@gmail.com>
2079 A fix for bug #488960
2080 * decl.cs: Compare MVAR types using non-null values.
2082 2009-03-27 Marek Safar <marek.safar@gmail.com>
2084 * typemanager.cs, expression.cs: Removed unused nullable checks.
2086 2009-03-27 Marek Safar <marek.safar@gmail.com>
2088 * *.cs: Removed some gmcs conditionals.
2090 2009-03-26 Marek Safar <marek.safar@gmail.com>
2092 * generic.cs, support.cs: Moved generics stuff out of support.cs
2094 2009-03-24 Marek Safar <marek.safar@gmail.com>
2096 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
2099 2009-03-23 Marek Safar <marek.safar@gmail.com>
2101 * attribute.cs: Consider all members for error reporting when
2102 checking named arguments.
2104 2009-03-23 Marek Safar <marek.safar@gmail.com>
2106 A fix for bug #487625
2107 * namespace.cs: Use a warning for all predefined type conflicts.
2109 2009-03-23 Marek Safar <marek.safar@gmail.com>
2111 A fix for bug #485706
2112 * statement.cs: Explicitly type catch type argument to pass verifier
2115 2009-03-22 Miguel de Icaza <miguel@novell.com>
2117 Initial support to provide code completion facilities to consumers
2118 of the evaluator API.
2120 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
2121 support the completion engine. When we reach the end of the
2122 input stream instead of returning EOF, when this flag is true the
2123 tokenizer instead produces:
2125 One GENERATE_COMPLETION token: this token then must be
2126 handled in the grammar at every point where the user
2127 would likely request a completion.
2129 As many COMPLETE_COMPLETION tokens as necessary. These
2130 tokens are generated to assist the parser in unwinding and
2131 producing a valid parse tree.
2133 The parser rules do not have to be perfect, the parser needs to be
2134 augmented with judicious use of GENERATE_COMPLETION tokens to
2135 improve the areas where we can provide completion and the parser
2136 needs to add support for COMPLETE_COMPLETION tokens in productions
2139 It is common to not have enough support for COMPLETE_COMPLETION
2140 under certain rules and that even if we generated the
2141 GENERATE_COMPLETION token that the resulting tree will be invalid
2142 due to the missing rules that support COMPLETE_COMPLETION.
2144 The final EOF token is produced by having the parser notify the
2145 tokenizer when it reaches the root production that the next token
2148 * support.cs (CompletionResult): New Exception. This exception
2149 is thrown to return the completion results when one of the special
2150 completion expressions is reached.
2152 This exception is thrown by the completing ExpressionStatements
2153 classes that live in complete.cs
2155 * complete.cs (CompletingExpression): a new base class for
2156 completing expressions. This derives from the
2157 ExpressionStatement class and not from Expression as it allows
2158 completion to happen not only where expressions are expected in
2159 the grammar, but also where statements are expected.
2161 (CompletionSimpleName): A new class used to provide completions
2162 for SimpleNames. This currently only resolves to local
2163 variables from the evaluator context (GetVars call).
2165 (CompletionMemberAccess): Implements support for completing member
2168 * cs-parser.jay: Add support for completion in a few places.
2170 * eval.cs (GetCompletions): New public API for the evaluator that
2171 returns a list of possible completions given the input. The
2172 return value is an array of completions
2174 * anonymous.cs (Compatible): If the exception thrown from the
2175 resolved expression is a CompletionResult exception let that one
2176 through instead of printing a diagnostic error in the try/catch.
2178 2009-03-22 Miguel de Icaza <miguel@novell.com>
2182 * driver.cs (Main): Use Environment.Exit to quit quickly and
2183 prevent the compiler from doing the usual wait for helper thread
2186 This is to prevent a slowdown that was reported by Gonzalo on
2189 2009-03-19 Marek Safar <marek.safar@gmail.com>
2191 * ecore.cs: Load build-in types directly instead of accessing
2194 2009-03-18 Marek Safar <marek.safar@gmail.com>
2196 * ecore.cs: Always use unbox.any when available.
2198 2009-03-18 Marek Safar <marek.safar@gmail.com>
2200 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
2202 2009-03-17 Marek Safar <marek.safar@gmail.com>
2204 * generic.cs: Removed obsolete version of type inference.
2206 2009-03-16 Marek Safar <marek.safar@gmail.com>
2208 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
2209 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
2210 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
2211 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
2213 2009-03-11 Marek Safar <marek.safar@gmail.com>
2215 A fix for bug #482996
2216 * anonymous.cs: Make sure we are not infering return type when
2217 checking type compatibility.
2219 2009-03-11 Marek Safar <marek.safar@gmail.com>
2221 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
2222 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
2223 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
2224 attributes in their own structure. Needed when accessing their
2225 properties before they are resolved.
2227 2009-03-09 Marek Safar <marek.safar@gmail.com>
2229 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
2230 hashtable (~10x faster).
2232 * driver.cs: Removed wrong Reset.
2234 2009-03-08 Marek Safar <marek.safar@gmail.com>
2236 * class.cs: Use correct common base type for unmanaged delayed
2239 * rootcontext.cs: Wrap unhandled exception.
2241 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
2243 Make SeekableStreamReader self-tuning and arbitrarily seekable
2244 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
2246 (SeekableStreamReader.Position.set): Use it. Simplify logic
2247 which, as a side-effect, makes it arbitrarily-seekable. Tune the
2248 buffer size when the stream needs to be re-read from the beginning.
2250 2009-03-05 Marek Safar <marek.safar@gmail.com>
2252 A fix for bug #480100
2253 * parameter.cs: A parameter is not hoisted when used directly as ET.
2255 2009-03-04 Marek Safar <marek.safar@gmail.com>
2257 * statement.cs: Fixed an issue when using variable is of interface
2260 2009-03-03 Marek Safar <marek.safar@gmail.com>
2262 A fix for bug #480319
2263 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
2265 2009-03-03 Marek Safar <marek.safar@gmail.com>
2267 A fix for bug #480867
2268 * typemanager.cs, expression.cs, ecore.cs: Changed method group
2269 expression to have no valid type.
2271 2009-03-03 Marek Safar <marek.safar@gmail.com>
2273 A fix for bug #481258
2274 * class.cs: Set extension method flag in partial container.
2276 2009-03-03 Marek Safar <marek.safar@gmail.com>
2278 * statement.cs, typemanager.cs: Use expression for StringEmitter.
2280 * attribute.cs: Add sanity check.
2282 2009-02-27 Marek Safar <marek.safar@gmail.com>
2284 * class.cs: Add external constructor error.
2286 2009-02-26 Marek Safar <marek.safar@gmail.com>
2288 A fix for bug #475354
2289 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
2290 correctly user defined nullable equality operators.
2292 2009-02-25 Marek Safar <marek.safar@gmail.com>
2294 A fix for bug #479532
2295 * expression.cs: Implement NewInitialize::AddressOf.
2297 2009-02-25 Marek Safar <marek.safar@gmail.com>
2299 A fix for bug #413633
2300 * expression.cs: Iterate all base class-constraint types.
2302 2009-02-24 Marek Safar <marek.safar@gmail.com>
2304 A fix for bug #479209
2305 * literal.cs: Mutate null underlying type.
2307 2009-02-24 Marek Safar <marek.safar@gmail.com>
2309 A fix for bug #476295
2310 * convert.cs: Avoid wrapping implicitly convertible reference type.
2312 2009-02-23 Marek Safar <marek.safar@gmail.com>
2314 * iterators.cs: Create MemberName correctly.
2316 2009-02-23 Marek Safar <marek.safar@gmail.com>
2318 A fix for bug #478655
2319 * literal.cs: Check also underlying null type conversion.
2321 2009-02-21 Marek Safar <marek.safar@gmail.com>
2323 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
2325 2009-02-20 Marek Safar <marek.safar@gmail.com>
2327 A fix for bug #477447
2328 * statement.cs: Add reference to correct parent storey when this
2329 is accessible from deep children storey (more than 1 level).
2331 2009-02-19 Marek Safar <marek.safar@gmail.com>
2333 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
2334 * class.cs: Define base type members before setting up member cache.
2336 2009-02-18 Marek Safar <marek.safar@gmail.com>
2338 A fix for bug #477378
2339 * nullable.cs, expression.cs, statement.cs: More precise null type
2342 2009-02-18 Marek Safar <marek.safar@gmail.com>
2344 A fix for bug #472805
2345 * typemanager.cs, namespace.cs: Import only visible extension method
2348 2009-02-18 Marek Safar <marek.safar@gmail.com>
2350 A fix for bug #476895
2351 * attribute.cs: Use correct resolve context for attribute type.
2353 2009-02-18 Marek Safar <marek.safar@gmail.com>
2355 A fix for bug #476266
2356 * anonymous.cs: Mutate multi-dimensional arrays.
2358 2009-02-18 Marek Safar <marek.safar@gmail.com>
2360 A fix for bug #476400
2361 * statement.cs, expression.cs: Removed wrong Dispose optimization.
2363 2009-02-18 Marek Safar <marek.safar@gmail.com>
2365 A fix for bug #476811
2366 * generics.cs: Fixed null-literal check.
2368 2009-02-17 Marek Safar <marek.safar@gmail.com>
2370 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
2371 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
2372 messing with static variables.
2374 2009-02-16 Marek Safar <marek.safar@gmail.com>
2376 A fix for bug #475965
2377 * generics.cs: Check generic parameter type after extracting from
2380 2009-02-16 Marek Safar <marek.safar@gmail.com>
2382 A fix for bug #475823
2383 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
2386 2009-02-14 Marek Safar <marek.safar@gmail.com>
2388 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
2389 Simplified event field definition using backing field and not
2390 field builder directly.
2392 * expression.cs (EmitLdArg): Optimize fast paths.
2394 2009-02-13 Marek Safar <marek.safar@gmail.com>
2396 A fix for bug #475327
2397 * expression.cs (ArrayCreation): Don't mutate values optimized away.
2399 2009-02-13 Marek Safar <marek.safar@gmail.com>
2401 A fix for bug #475342
2402 * cs-parser.jay: Using 'super' instead of 'base' to call base
2403 constructor crashes compiler.
2405 2009-02-13 Marek Safar <marek.safar@gmail.com>
2407 A fix for bug #475354
2408 * expression.cs (Constantify): Add nullable types.
2410 * const.cs (EmitDecimalConstant): Avoid explicit cast.
2412 2009-02-12 Marek Safar <marek.safar@gmail.com>
2414 A fix for bug #475246
2415 * expression.cs: More broken flowanalysis hacking needed.
2417 2009-02-12 Marek Safar <marek.safar@gmail.com>
2419 * attribute.cs: Compare only ref/out array modifiers.
2421 2009-02-11 Marek Safar <marek.safar@gmail.com>
2423 * statement.cs: Use member cache when looking for foreach members.
2425 2009-02-11 Marek Safar <marek.safar@gmail.com>
2427 * expression.cs: Don't expose internal initializer types.
2429 * statement.cs: Check also explicit conversions for goto case.
2431 2009-02-11 Marek Safar <marek.safar@gmail.com>
2433 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
2435 2009-02-10 Marek Safar <marek.safar@gmail.com>
2437 * *.cs: Replace null-type with NullLiteral where appropriate.
2439 2009-02-09 Marek Safar <marek.safar@gmail.com>
2441 * expression.cs: Initializer of reference argument use temporary
2442 variable to be verifiable.
2444 * parameter.cs: Share EmitLdArg.
2446 2009-02-09 Marek Safar <marek.safar@gmail.com>
2448 A fix for bug #473559
2449 * class.cs: Fixed: Not reporting error about nested class with the
2452 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
2454 Contributed under the MIT/X11 license.
2456 * generic.cs: Added VerifyVariantTypeParameters which performs new
2457 variance verification logic. The old logic, based on the spec, was
2458 wrong because the spec is full of LIES!
2460 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
2462 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
2465 * ecore.cs: Added calls to the new variance verification logic.
2468 * delegate.cs: Removed calls to the old variance verification logic.
2470 2009-02-06 Marek Safar <marek.safar@gmail.com>
2472 * delegate.cs: Use cached Invoke method directly.
2474 2009-02-06 Marek Safar <marek.safar@gmail.com>
2476 * expression.cs: Emit expression tree for hoisted variable access.
2478 2009-02-04 Marek Safar <marek.safar@gmail.com>
2480 * namespace.cs: Add better extension class check.
2482 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
2484 * generic.cs: Fixed typeo (TypeParameter.Variacne).
2486 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
2488 This patch adds initial generic variance support to the compiler.
2489 It is contributed under the MIT/X11 license.
2491 * typemanager.cs: Modified ImplementsInterface to check variance.
2492 Added VerifyVariantTypeParameters which checks the specified type to see
2493 if it uses a variant type parameter as a type argument (which is not
2494 allowed). Added IsVariantOf which determins if the first type is a
2495 variant of the second. NOTE: This only supports reference types at
2496 the moment to conform with the current level of VM support. When the
2497 VM supports value types, this will follow step.
2499 * generic.cs: Added the Variance enum. Added a Variance property to
2500 TypeParameter and added variance support to definition phase. Added a
2501 Variance property to TypeParameterName. Also check to make sure that
2502 no variant types appear in generic method parameters.
2504 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
2505 keywords if the langversion supports it.
2507 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
2508 that variant types are only used in legal positions. Also added
2509 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
2512 * decl.cs: Construct TypeParameter with the variance information.
2514 * convert.cs: Checks variance in ImplicitReferenceConversionExists
2515 and ImplicitConversionStandard.
2517 * rootcontext.cs: Added new "Future" language version.
2519 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
2520 type parameters are not used as type arguments in interface inheritance.
2521 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
2522 parameters are not used as method return types. In MemberBase.
2523 ResolveMemberType, ensure that variant type parameters are not used
2524 as type arguments. Also call VerifyNoVariantTypeParameters on every
2525 set of parameters which are resolved.
2527 * delegate.cs: Modified Delegate.Define to ensure that variant
2528 parameters are not used as type arguments and that a contravariant
2529 parameter is not used as the return type. Also call
2530 VerifyNoVariantTypeParameters on the delegate parameters.
2532 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
2533 to specify generic variance.
2535 * driver.cs: Added support for LanguageVersion.Future in the form of
2536 "-langversion:future".
2538 * generic-mcs.cs: Stubbed out new members in generic.cs.
2540 2009-02-03 Marek Safar <marek.safar@gmail.com>
2542 * class.cs, generic.cs: Emit type parameter constraints for nested
2545 2009-02-02 Marek Safar <marek.safar@gmail.com>
2547 A fix for bug #471213
2548 * class.cs: Avoid emitting backing field for abstract event fields.
2550 2009-02-01 Marek Safar <marek.safar@gmail.com>
2552 A fix for bug #359731
2553 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2556 2009-01-30 Marek Safar <marek.safar@gmail.com>
2558 A fix for bug #470767
2559 * statement.cs: Introduced BlockScopeExpression, needed when
2560 expression tree conversion has to emit scope variables.
2562 2009-01-29 Marek Safar <marek.safar@gmail.com>
2564 * class.cs: Remove duplicate CallingConvention.
2566 2009-01-29 Marek Safar <marek.safar@gmail.com>
2568 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2569 when I finally found the right naming convention.
2571 2009-01-29 Marek Safar <marek.safar@gmail.com>
2573 * cs-tokenizer.cs: Put back different open parens optimization.
2575 2009-01-28 Marek Safar <marek.safar@gmail.com>
2577 A fix for bug #470227
2578 * cs-tokenizer.cs: Remove too agressive parser optimization.
2580 2009-01-28 Marek Safar <marek.safar@gmail.com>
2582 A fix for bug #324319
2583 * class.cs: Remove too early base type resolve.
2585 2009-01-27 Marek Safar <marek.safar@gmail.com>
2587 A fix for bug #324319
2588 * ecore.cs: Explicitly type null when assigning to type argument to
2589 make pass verifier check.
2591 2009-01-27 Marek Safar <marek.safar@gmail.com>
2593 * anonymous.cs: Fixed recent regression when initializing captured
2596 2009-01-26 Marek Safar <marek.safar@gmail.com>
2598 A fix for bug #469019
2599 * anonymous.cs: Use all parent type parameters when instantiating
2600 nested generic storey.
2602 2009-01-26 Marek Safar <marek.safar@gmail.com>
2604 * expression.cs: Check for null instance methodgroup expression.
2606 2009-01-26 Marek Safar <marek.safar@gmail.com>
2608 A fix for bug #469244
2609 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2610 instance inside a conditional expression.
2612 2009-01-23 Marek Safar <marek.safar@gmail.com>
2614 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2615 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2616 GetElementType and HasElementType. IsValueType clean up.
2618 2009-01-23 Marek Safar <marek.safar@gmail.com>
2620 * nullable.cs: Use common EmitCall.
2622 * expression.cs: Emit constraint. for virtual calls only.
2624 2009-01-23 Marek Safar <marek.safar@gmail.com>
2626 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2627 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2628 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2631 2009-01-22 Jb Evain <jbevain@novell.com>
2633 * anonymous.cs: make anonymous types' ToString implementation
2634 match what csc outputs.
2636 2009-01-21 Marek Safar <marek.safar@gmail.com>
2638 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2641 2009-01-17 Marek Safar <marek.safar@gmail.com>
2643 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2646 2009-01-16 Marek Safar <marek.safar@gmail.com>
2648 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2651 2009-01-15 Marek Safar <marek.safar@gmail.com>
2653 A fix for bug #466634
2654 * statement.cs: Add reference for nested storey when only this
2657 2009-01-15 Marek Safar <marek.safar@gmail.com>
2659 A fix for bug #466474
2660 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2663 2009-01-15 Marek Safar <marek.safar@gmail.com>
2665 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2666 Fixed nested stories parent referencing process. Also fixes #463985.
2668 2009-01-06 Marek Safar <marek.safar@gmail.com>
2670 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2671 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2672 implementation. Also fixes #463108.
2674 2009-01-05 Marek Safar <marek.safar@gmail.com>
2676 A fix for bug #416109
2677 * decl.cs: Issue correct CLSAttribute warning location.
2679 2009-01-05 Marek Safar <marek.safar@gmail.com>
2681 A fix for bug #456775
2682 * attribute.cs: Use attribute owner scope when resolving attribute
2685 2009-01-05 Marek Safar <marek.safar@gmail.com>
2687 A fix for bug #457257
2688 * decl.cs: Fixed incorrect member declaring type comparison.
2690 2009-01-05 Marek Safar <marek.safar@gmail.com>
2692 A fix for bug #460896
2693 * driver.cs: Handle /RES resources as embeddable.
2695 2009-01-05 Marek Safar <marek.safar@gmail.com>
2697 A fix for bug #462515
2698 * ecore.cs: Report inacessible members upwards.
2700 2009-01-05 Marek Safar <marek.safar@gmail.com>
2702 A fix for bug #463190, #463192
2703 * decl.cs, namespace.cs: Also import internal extension classes.
2705 2009-01-04 Marek Safar <marek.safar@gmail.com>
2707 A fix for bug #463415
2708 * generic.cs: Use right index for RemoveDependentTypes.
2710 2009-01-02 Marek Safar <marek.safar@gmail.com>
2712 A fix for bug #463196
2713 * expression.cs: Fixed enum to null comparison.
2715 2009-01-02 Marek Safar <marek.safar@gmail.com>
2717 A fix for bug #463121
2718 * nullable.cs: Fixed nullable user equality operator comparison.
2720 2009-01-02 Marek Safar <marek.safar@gmail.com>
2722 A fix for bug #462950
2723 * class.cs, decl.cs: Use full explicit name when defining automatic
2724 property backing field.
2726 2009-01-02 Marek Safar <marek.safar@gmail.com>
2728 A fix for bug #462592
2729 * pending.cs: Emit type arguments for generic proxy method.
2731 2008-12-30 Marek Safar <marek.safar@gmail.com>
2733 * expression.cs (As): Mutate all type arguments.
2735 2008-12-29 Marek Safar <marek.safar@gmail.com>
2737 A fix for bug #462622
2738 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2741 2008-12-29 Marek Safar <marek.safar@gmail.com>
2743 A fix for bug #450782
2744 * ecore.cs: Consider more variables of form V.I to be fixed.
2746 2008-12-29 Marek Safar <marek.safar@gmail.com>
2748 A fix for bug #460712
2749 * typemanager.cs: Core types could be imported.
2751 2008-12-28 Marek Safar <marek.safar@gmail.com>
2753 A fix for bugs #460847, #460772, #458049, #457339, #447807
2754 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2755 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2756 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2757 user lambdas used inside query clauses.
2759 2008-12-18 Marek Safar <marek.safar@gmail.com>
2761 A fix for bug #460229
2762 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2764 2008-12-18 Marek Safar <marek.safar@gmail.com>
2766 A fix for bug #459952
2767 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2769 2008-12-18 Marek Safar <marek.safar@gmail.com>
2771 A fix for bug #459630
2772 * convert.cs: Enum to valuetype conversion is not allowed.
2774 2008-12-18 Marek Safar <marek.safar@gmail.com>
2776 A fix for bug #457087
2777 * generic.cs: Don't crash when constraint comes from type
2780 2008-12-16 Marek Safar <marek.safar@gmail.com>
2782 A fix for bug #459221
2783 * anonymous.cs, statement.cs: Delay only captured this
2786 2008-12-12 Marek Safar <marek.safar@gmail.com>
2788 A fix for bug #457489
2789 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2790 and initialization to capture scope initializers correctly.
2792 2008-12-11 Marek Safar <marek.safar@gmail.com>
2794 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2795 ParameterReference refactoring.
2797 2008-12-03 Marek Safar <marek.safar@gmail.com>
2799 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2800 to be imported from any assembly.
2802 2008-12-03 Marek Safar <marek.safar@gmail.com>
2804 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2805 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2806 from anonymous method and lambda expression.
2808 2008-12-01 Marek Safar <marek.safar@gmail.com>
2810 A fix for bug #448560
2811 * expression.cs (As): Box any generic type arguments to be
2814 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2816 Add tripwire for implicit conversion bugs
2817 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2819 (MethodGroupExpr.OverloadResolve): Add sanity check between
2820 IsApplicable and VerifyArgumentsCompat.
2821 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2823 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2825 Fix build break in System.Data_test
2826 * convert.cs (ImplicitConversionExists): Move NullLiteral
2828 (ImplicitStandardConversionExists): ... here.
2830 2008-11-28 Marek Safar <marek.safar@gmail.com>
2832 * literal.cs: Emit correctly explicit null to nullable cast.
2834 2008-11-28 Marek Safar <marek.safar@gmail.com>
2836 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2839 2008-11-28 Marek Safar <marek.safar@gmail.com>
2841 A fix for bug #449005
2842 * convert.cs, nullable.cs: Use only one implicit nullable
2845 2008-11-27 Marek Safar <marek.safar@gmail.com>
2847 * convert.cs, literal.cs: More Convert cleanup is needed.
2849 2008-11-27 Marek Safar <marek.safar@gmail.com>
2851 * decl.cs, class.cs: Fixed misleading error message.
2853 2008-11-26 Marek Safar <marek.safar@gmail.com>
2855 A fix for bug #449005
2856 * nullable.cs (EmitEquality): Disable optimization for user operator
2859 2008-11-25 Marek Safar <marek.safar@gmail.com>
2861 A fix for bug #447027
2862 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2863 with context variables stored as expression instances.
2865 2008-11-25 Marek Safar <marek.safar@gmail.com>
2867 A fix for bug #447027
2868 * delegate.cs: Fixed delegate VerifyMethod logic.
2870 2008-11-24 Marek Safar <marek.safar@gmail.com>
2872 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2875 2008-11-21 Marek Safar <marek.safar@gmail.com>
2877 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2878 member type resolve to follow normal flow, instead of random
2881 2008-11-21 Marek Safar <marek.safar@gmail.com>
2883 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2886 2008-11-21 Marek Safar <marek.safar@gmail.com>
2888 * const.cs: Emit decimal array constant as literal.
2890 2008-11-20 Marek Safar <marek.safar@gmail.com>
2892 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2894 2008-11-19 Marek Safar <marek.safar@gmail.com>
2896 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2897 into real property (saves 8 MB for corlib compilation).
2899 2008-11-19 Marek Safar <marek.safar@gmail.com>
2901 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2902 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2903 generic-mcs.cs: Small cleanup of TypeArguments.
2905 2008-11-18 Marek Safar <marek.safar@gmail.com>
2907 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2908 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2909 of ConstructedType expression, renamed to GenericTypeExpr.
2911 2008-11-17 Marek Safar <marek.safar@gmail.com>
2913 A fix for bug #445303
2914 * location.cs (IsConditionalDefined): Handle undefined global
2917 2008-11-17 Marek Safar <marek.safar@gmail.com>
2919 A fix for bug #444678
2920 * expression.cs (TryReduceConstant): Always create new constant
2923 2008-11-17 Marek Safar <marek.safar@gmail.com>
2925 A fix for bug #444673
2926 * ecore.cs: Ignore open generic types when used as generic type
2929 2008-11-17 Marek Safar <marek.safar@gmail.com>
2931 A fix for bug #445458
2932 * expression.cs, cs-parser.jay: Don't crash when an expression
2935 2008-11-17 Marek Safar <marek.safar@gmail.com>
2937 A fix for bug #445464
2938 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2939 inside unbound type.
2941 2008-11-14 Jb Evain <jbevain@novell.com>
2943 * driver.cs: ignore empty -nowarn argument such as
2944 the one in -nowarn:12,13,,.
2946 2008-11-13 Marek Safar <marek.safar@gmail.com>
2948 A fix for bug #444271
2949 * anonymous.cs: Rescan parent storeys when best candidate was
2952 2008-11-13 Marek Safar <marek.safar@gmail.com>
2954 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2955 useless UnboundTypeExpression.
2957 * attribute.cs: Do check obsolete attribute on generic types.
2959 2008-11-12 Marek Safar <marek.safar@gmail.com>
2961 A fix for bugs #425680, #400139
2962 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2965 2008-11-11 Marek Safar <marek.safar@gmail.com>
2967 A fix for bug #435747
2968 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2969 compound value types assignment. Few micro optimizations added.
2971 2008-11-10 Marek Safar <marek.safar@gmail.com>
2973 A fix for bug #442610
2974 * anonymous.cs (MutateConstructor): More SRE hacking.
2976 2008-11-10 Marek Safar <marek.safar@gmail.com>
2978 A fix for bug #442579
2979 * ecore.cs: Also initialize expanded form of a method with 1 params
2982 2008-11-06 Marek Safar <marek.safar@gmail.com>
2984 * expression.cs (UnaryMutator): Do early l-side check.
2986 2008-11-05 Miguel de Icaza <miguel@novell.com>
2988 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2989 Init, otherwise we would crash later on when checking for friend
2992 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2993 Otherwise we never get any meaningful information as to what
2996 2008-11-05 Marek Safar <marek.safar@gmail.com>
2998 A fix for bug #436318
2999 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
3001 2008-11-05 Miguel de Icaza <miguel@novell.com>
3003 * namespace.cs: Turns out that it was a really bad idea to hide
3004 the errors for namespaces not found here in eval mode.
3006 * eval.cs: When we process using clauses, only enter those into
3007 the list of valid using clauses after they have been validated.
3009 The above change gives the proper semantics: it does not
3010 senselessly report the same errors with broken using statements by
3011 never storing them in the first place when they are invalid.
3013 2008-11-05 Marek Safar <marek.safar@gmail.com>
3015 A fix for bug #421839
3016 * cs-parser.jay: Remove expression from coalesce rule to force lower
3017 priority than the assignment operator.
3019 2008-11-05 Marek Safar <marek.safar@gmail.com>
3021 A fix for bug #437875
3022 * nullable.cs: Compile correctly method group operand used with null
3023 coalescing operator.
3025 2008-11-04 Marek Safar <marek.safar@gmail.com>
3027 A fix for bug #434589
3028 * expression.cs (Binary): Ignore lifted conversions when at least
3029 one operand is of reference type.
3031 2008-11-04 Marek Safar <marek.safar@gmail.com>
3033 * cs-parser.jay: Better syntax error report.
3035 2008-11-03 Marek Safar <marek.safar@gmail.com>
3037 A fix for bug #436792
3038 * cs-parser.jay: Use GetLocation to access location.
3040 2008-11-03 Marek Safar <marek.safar@gmail.com>
3042 A fix for bug #440774
3043 * cs-parser.jay: Also set current_array_type when parsing local
3046 2008-11-03 Marek Safar <marek.safar@gmail.com>
3048 A fix for bug #440785
3049 * expression.cs (As): Don't resolve self modifing expression
3052 2008-11-03 Marek Safar <marek.safar@gmail.com>
3054 A fix for bug #439447
3055 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
3057 2008-11-03 Marek Safar <marek.safar@gmail.com>
3059 A fix for bug #437571
3060 * cs-parser.jay: Fixes internal error for invalid expression
3063 2008-10-17 Marek Safar <marek.safar@gmail.com>
3065 * ecore.cs: Resolve correctly ambiguous params delegate methods.
3067 2008-10-17 Marek Safar <marek.safar@gmail.com>
3069 * generic.cs, anonymous.cs: Simplified GetDeclarations.
3071 2008-10-17 Marek Safar <marek.safar@gmail.com>
3073 * cs-tokenizer.cs: More precise cast parsing.
3075 2008-10-16 Martin Baulig <martin@ximian.com>
3077 * anonymous.cs (AnonymousMethodStorey): Put back the
3078 `hoisted_locals' hashtable and use it in EmitType().
3080 2008-10-15 Marek Safar <marek.safar@gmail.com>
3082 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
3083 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
3086 2008-10-14 Marek Safar <marek.safar@gmail.com>
3088 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
3090 2008-10-14 Marek Safar <marek.safar@gmail.com>
3092 * statement.cs: Mutate scope initializers.
3094 2008-10-14 Marek Safar <marek.safar@gmail.com>
3096 * expression.cs: Use typeless value for This constant.
3098 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
3100 2008-10-14 Marek Safar <marek.safar@gmail.com>
3102 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
3105 2008-10-13 Marek Safar <marek.safar@gmail.com>
3107 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
3110 2008-10-13 Marek Safar <marek.safar@gmail.com>
3112 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
3113 parser and tokenizer. Fixes many ambiguities including #433258.
3115 2008-10-10 Marek Safar <marek.safar@gmail.com>
3117 * cs-parser.jay: Fixed missing accessor recovery.
3119 2008-10-10 Marek Safar <marek.safar@gmail.com>
3121 A fix for bug #433701
3122 * expression.cs: Better error message.
3124 2008-10-10 Marek Safar <marek.safar@gmail.com>
3126 * cs-parser.jay, expression.cs: Start reporting real parser errors.
3128 * Makefile: Disabled unused debug symbols.
3130 Also fixes: #320556, #321097, #321656, #321876, #351316
3132 2008-10-09 Miguel de Icaza <miguel@novell.com>
3134 * eval.cs: rename "<interactive>" to "{interactive}", to work
3135 around a requirement in the compiler that this be a valid
3136 filename, and in Windows it is not (433886).
3138 2008-10-09 Marek Safar <marek.safar@gmail.com>
3140 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
3142 2008-10-08 Marek Safar <marek.safar@gmail.com>
3144 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
3145 cs-parser.jay: Generic type declaration and type arguments cleanup.
3147 2008-10-05 Marek Safar <marek.safar@gmail.com>
3149 * cs-parser.jay: Allow parsing weird array creation construct.
3151 2008-10-05 Marek Safar <marek.safar@gmail.com>
3153 * cs-parser.jay: Conflicts reduction.
3155 2008-10-04 Marek Safar <marek.safar@gmail.com>
3157 * cs-parser.jay: Conflicts reduction.
3159 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
3162 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
3163 property. Add a 'count' hint about the use of the shared vector.
3164 Ensure that we don't leak out dirty bits.
3165 (UsageVector.MergeChild): Throw away information about variables
3167 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
3169 2008-10-03 Marek Safar <marek.safar@gmail.com>
3171 A fix for bug #431746
3172 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
3173 parameters when iterator is created.
3175 2008-10-03 Marek Safar <marek.safar@gmail.com>
3177 A fix for bug #431827
3178 * expression.cs: Fixed right based pointer arithmetic operations
3181 2008-10-03 Marek Safar <marek.safar@gmail.com>
3183 A fix for bug #353779
3184 * assign.cs, expression.cs: Fixed compound assignment conversions.
3186 2008-10-02 Marek Safar <marek.safar@gmail.com>
3188 A fix for bug #375262
3189 * statement.cs: Refactor ArrayForeach to be usable with string
3190 indexer. Optimized single dimentional arrays foreach.
3192 2008-10-02 Marek Safar <marek.safar@gmail.com>
3194 A fix for bug #431255
3195 * anonymous.cs, expression.cs: Removed broken optimization.
3197 2008-10-01 Marek Safar <marek.safar@gmail.com>
3199 * anonymous.cs: Use full type parameters of parent generic
3200 containers. Removed unnecessary AddParentStoreyReference call.
3202 2008-10-01 Marek Safar <marek.safar@gmail.com>
3204 A fix for bug #324702
3205 * class.cs: Use better shorter names for explicit interface member
3208 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
3210 2008-10-01 Marek Safar <marek.safar@gmail.com>
3212 * expression.cs: Use new interface to check fixed expression.
3214 2008-10-01 Marek Safar <marek.safar@gmail.com>
3216 A fix for bug #421101
3217 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
3218 interface to check for fixed fixed-buffers.
3220 2008-10-01 Marek Safar <marek.safar@gmail.com>
3222 A fix for bug #429264
3223 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
3225 * delegate.cs: Removed unnecessary casts.
3227 2008-09-30 Marek Safar <marek.safar@gmail.com>
3229 A fix for bug #352151
3230 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
3231 class.cs: Fixed already defined explicit interface members check.
3233 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
3235 cs-tokenizer.cs: Fix typo.
3237 2008-09-28 Miguel de Icaza <miguel@novell.com>
3239 * eval.cs (InteractiveBase): The quit command now just sets a
3240 flag, instead of calling Environment.Exit(), it is milder on
3243 CompiledMethod is now in Mono.CSharp, not nested inside
3244 the Evaluator, it was inconvenient to use.
3246 2008-09-27 Miguel de Icaza <miguel@novell.com>
3248 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
3249 code to be invoked without having to reparse.
3251 2008-09-27 Miguel de Icaza <miguel@novell.com>
3253 * ecore.cs: The recent changes to FieldExpr broke this as well.
3254 Fixes LINQ queries in the interactive shell.
3256 * Multiple files: indentation fixing for the Mono coding
3257 guidelines for the switch statement.
3259 * eval.cs: Make the Evaluator API thread safe.
3261 2008-09-26 Marek Safar <marek.safar@gmail.com>
3263 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
3264 constructor parsing.
3266 2008-09-26 Marek Safar <marek.safar@gmail.com>
3268 A fix for bug #325326
3269 * statement.cs: Check possible mistaken empty statement using
3270 explicit blocks only.
3272 2008-09-25 Miguel de Icaza <miguel@novell.com>
3274 * eval.cs (LoadAssembly, ReferenceAssembly): Call
3275 RootNamespace.ComputeNamespaces to update the internal list of
3276 namespaces, this is no longer done for us.
3278 (InteractiveBase): Use the Evaluator APIs instead of calling into
3281 2008-09-25 Marek Safar <marek.safar@gmail.com>
3283 A fix for bug #429264
3284 * expression.cs: Missing mutator for access to multidimensional
3287 2008-09-25 Marek Safar <marek.safar@gmail.com>
3289 * class.cs, statement: Emit DebuggerHidden attribute for iterator
3292 * driver.cs: Missing input argument check.
3294 2008-09-25 Marek Safar <marek.safar@gmail.com>
3296 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
3297 expression.cs, statement.cs, rootcontext.cs, class.cs,
3298 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
3301 2008-09-24 Miguel de Icaza <miguel@novell.com>
3303 * ecore.cs (FieldExpr): Only initialize eclass when we return a
3304 fully constructed FieldExpr, fixes the regression introduced in
3307 * ecore.cs, expression.cs: Plug back the eclass initialization as
3308 otherwise it regresses `csharp'.
3310 2008-09-24 Marek Safar <marek.safar@gmail.com>
3312 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
3313 ecore.cs, attribute.cs: Moved obsolete method checks from emit
3314 phase to resolve phase. It resolves problems with expression trees
3315 and fixes bugs #323796, #325156.
3317 2008-09-23 Marek Safar <marek.safar@gmail.com>
3319 * codegen.cs: Report better error when symbol writer is missing.
3321 2008-09-23 Marek Safar <marek.safar@gmail.com>
3323 * codegen.cs: Set .NET symbol writer.
3325 * decl.cs: Guard against null generic arguments.
3327 * report.cs: Don't report exactly same additional details.
3329 2008-09-22 Marek Safar <marek.safar@gmail.com>
3331 A fix for bug #324917
3332 * cs-parser.jay: Add missing multidimensional non-expression type
3335 2008-09-22 Marek Safar <marek.safar@gmail.com>
3337 A fix for bug #428191
3338 * anonymous.cs: Create an outer generic fields also for non-storey
3341 2008-09-22 Marek Safar <marek.safar@gmail.com>
3343 A fix for bug #378294
3344 * class.cs: Make fixed size buffers gmcs feature only.
3346 2008-09-22 Marek Safar <marek.safar@gmail.com>
3348 A fix for bug #355622, #324993
3349 * assign.cs, const.cs, class.cs: Create new EmitContext for each
3352 2008-09-19 Marek Safar <marek.safar@gmail.com>
3354 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
3357 2008-09-19 Marek Safar <marek.safar@gmail.com>
3359 A fix for bug #416110
3360 * generic.cs: Struct constraint results in default ctor and
3361 ValueType base type constraint to be set.
3363 2008-09-19 Marek Safar <marek.safar@gmail.com>
3365 A fix for bug #423791
3366 * generic.cs: Fixed params output type type-inference.
3368 2008-09-19 Marek Safar <marek.safar@gmail.com>
3370 * cs-parser.jay, expression.cs: Fixed few expression crashes.
3372 2008-09-19 Marek Safar <marek.safar@gmail.com>
3374 * cs-tokenizer.cs: Don't break on extra partial modifier.
3376 2008-09-19 Marek Safar <marek.safar@gmail.com>
3378 A fix for bug #427592
3379 * generic.cs: Use common parameter resolve method.
3381 2008-09-18 Marek Safar <marek.safar@gmail.com>
3383 A fix for bug #414758
3384 * expression.cs, ecore.cs: Fixed crash when accessing non-static
3387 2008-09-18 Marek Safar <marek.safar@gmail.com>
3389 * driver.cs, namespace.cs: Read types and namespaces after all
3390 requested assemblies are loaded, fixes issues with System.Core
3391 auto-reference, and #419888.
3393 2008-09-18 Marek Safar <marek.safar@gmail.com>
3395 A fix for bug #417705
3396 * cs-parser.jay: Fixed as/is operator expression split.
3398 2008-09-18 Marek Safar <marek.safar@gmail.com>
3400 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
3401 Fixed expression tree representation of empty new expression and
3402 new initializer expression.
3404 2008-09-18 Miguel de Icaza <miguel@novell.com>
3406 * eval.cs: Remove warning, keep reference to driver around.
3408 * Hide fields that do not need to be public.
3410 2008-09-17 Marek Safar <marek.safar@gmail.com>
3412 A fix for bug #426385
3413 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
3414 conversion for array elements.
3416 2008-09-17 Marek Safar <marek.safar@gmail.com>
3418 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
3419 void parsing conflicts.
3421 2008-09-15 Marek Safar <marek.safar@gmail.com>
3423 A fix for bug #425601
3424 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
3425 System.Core only when there is no custom ExtensionAttribute
3428 2008-09-15 Miguel de Icaza <miguel@novell.com>
3430 * namespace.cs: Do not report CS0246 (name
3432 2008-09-12 Marek Safar <marek.safar@gmail.com>
3434 A fix for bug #425669
3435 * generic.cs: Don't cache generic static anonymous method
3438 2008-09-12 Marek Safar <marek.safar@gmail.com>
3440 * generic.cs, class.cs, delegate.cs: Check recursive inherited
3441 conflicting constraints.
3443 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
3445 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
3448 2008-09-12 Marek Safar <marek.safar@gmail.com>
3450 * literal.cs, convert.cs, expression.cs, statement.cs: More null
3451 to null pointer conversion fixes.
3453 2008-09-11 Marek Safar <marek.safar@gmail.com>
3455 * cs-parser.jay, expression.cs: An implicitly typed local variable
3456 declarator cannot use an array initializer.
3458 2008-09-11 Marek Safar <marek.safar@gmail.com>
3460 * cs-parser.jay: Reduced number of printed tokens, add sorting.
3462 2008-09-11 Marek Safar <marek.safar@gmail.com>
3464 * generic.cs (InflatedConstraints): Don't crash when constraints
3467 * cs-parser.jay: const_declarator is a block.
3469 * constant.cs: Check for not allowed NaN conversions.
3471 2008-09-10 Miguel de Icaza <miguel@novell.com>
3473 * driver.cs: Drop --shell argument, the compiler is no longer a
3476 * eval.cs: Move most of the code that deals with evaluation into
3477 this file and document the public API from repl.cs
3479 * repl.cs: Remove from here.
3481 2008-09-10 Marek Safar <marek.safar@gmail.com>
3483 A fix for bug #424684
3484 * generic.cs: Generic class constraints must come first.
3486 2008-09-09 Miguel de Icaza <miguel@novell.com>
3488 * cs-parser.jay: Improve error reporting for syntax errors in
3489 statements and expressions, we now report the expected tokens
3490 instead of reporting the useless "; expected".
3492 Drop the strings from the token declaration, it turns out that
3493 they did not do what I thought they did. Instead they were adding
3494 two sets of tokens to the tables.
3496 2008-09-09 Marek Safar <marek.safar@gmail.com>
3498 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
3499 delegate.cs: Share special type check.
3501 2008-09-09 Marek Safar <marek.safar@gmail.com>
3503 A fix for bug #423981
3504 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
3506 2008-09-09 Marek Safar <marek.safar@gmail.com>
3508 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
3511 2008-09-09 Marek Safar <marek.safar@gmail.com>
3513 A fix for bugs: #324750, #335946
3514 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
3515 lookup rule to determine ?-based tokens.
3517 2008-09-08 Miguel de Icaza <miguel@novell.com>
3519 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
3520 expressions (like event adding or removing) end up here, so we
3521 need to treat those as statements.
3523 Add LoadAssembly method.
3525 2008-09-04 Miguel de Icaza <miguel@novell.com>
3527 * repl.cs: Add Time method.
3529 2008-09-05 Marek Safar <marek.safar@gmail.com>
3531 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
3533 2008-09-05 Miguel de Icaza <miguel@novell.com>
3535 * repl.cs: Add workaround for old compilers.
3537 2008-09-04 Jb Evain <jbevain@novell.com>
3539 * repl.cs (PrettyPrint): pretty print everything that
3540 implements IDictionary, as well as IEnumerables. Also,
3541 add a quit helper property.
3543 2008-09-04 Marek Safar <marek.safar@gmail.com>
3545 * constant.cs: Better error reporting for decimal literals.
3547 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3550 2008-09-04 Marek Safar <marek.safar@gmail.com>
3551 Miguel de Icaza <miguel@novell.com>
3553 A fix for bug #422951
3554 * assign.cs (Assign.DoResolve): Perform the type conversions
3555 checks before we attempt to initialize `New' initializers.
3557 2008-09-04 Marek Safar <marek.safar@gmail.com>
3559 A fix for bug #422853
3560 * delegate.cs (DelegateCreation): Add special handling for
3561 EmptyExpression.Null instance expression which is just another
3562 hack for undecided member instance exression.
3564 2008-09-04 Marek Safar <marek.safar@gmail.com>
3566 * expression.cs, ecore.cs: Emit full expression tree for reduced
3569 2008-09-04 Marek Safar <marek.safar@gmail.com>
3571 * expression.cs (This): Guard against multi-resolving.
3573 * ecore.cs, statement.cs (Throw): Simplified.
3575 * flowanalysis.cs: Also verify event fields.
3577 2008-09-04 Miguel de Icaza <miguel@novell.com>
3579 * assign.cs (Assign.DoResolve): Perform the type conversions
3580 checks before we attempt to initialize `New' initializers.
3582 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3584 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3587 * repl.cs: Update help.
3589 2008-09-03 Miguel de Icaza <miguel@novell.com>
3591 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3592 handling of the default config handling, including the special
3593 treatment of System.Core assembly.
3595 Fixes the REPL processing for LINQ.
3597 2008-09-03 Marek Safar <marek.safar@gmail.com>
3599 A fix for bug #422507
3600 * expression.cs (UnboxCast): Add missing child expression mutator.
3602 2008-09-03 Marek Safar <marek.safar@gmail.com>
3604 * driver.cs: Don't self reference System.Core assembly.
3606 2008-09-03 Marek Safar <marek.safar@gmail.com>
3608 A fix for bug #422507
3609 * expression.cs (StringConcat): Add missing type mutator.
3611 2008-09-03 Marek Safar <marek.safar@gmail.com>
3613 * generic.cs (TypeInferenceContext): Follow equality rule for
3614 constructed type lower bound type inference.
3616 2008-09-02 Miguel de Icaza <miguel@novell.com>
3618 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3619 <dblank@cs.brynmawr.edu> which updates the cursor position on
3622 2008-09-02 Marek Safar <marek.safar@gmail.com>
3624 A fix for bug #367145
3625 * driver.cs: Fixed import of extension methods when using -noconfig
3628 2008-09-02 Marek Safar <marek.safar@gmail.com>
3630 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3631 version from non-generic implementation instead.
3633 2008-09-01 Marek Safar <marek.safar@gmail.com>
3635 A fix for bug #418908
3636 * class.cs: Use AddScopeStatement for field initializers.
3638 2008-09-01 Marek Safar <marek.safar@gmail.com>
3640 A fix for bug #415385
3641 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3643 2008-09-01 Marek Safar <marek.safar@gmail.com>
3645 A fix for bug #421736
3646 * iterators.cs: Don't crash on unreachable iterators.
3648 2008-09-01 Marek Safar <marek.safar@gmail.com>
3650 A fix for bug #421628
3651 * parameter.cs, attribute.cs: Clone also parameter attributes.
3653 2008-08-30 Miguel de Icaza <miguel@novell.com>
3655 * namespace.cs (LookupType): In EvalMode, try to replace
3656 the TypeBuilder from our cache with a Type as Reflection.Emit does
3657 not like to mix code from older assemblies emitted and new
3660 This sounds like a serious Mono bug that prevents multiple
3661 assemblies to be generated and consumed at the same time.
3663 * cs-parser.jay (push_current_class): Do not make interactive
3664 classes internal or private, make them public as we currently
3665 generate each new class in a new assembly.
3667 2008-08-29 Miguel de Icaza <miguel@novell.com>
3669 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3670 remove types that are entered into the global namespace during
3671 parsing so that we can remove them on failure.
3673 * cs-parser.jay: Parsing: we now keep track of types that are
3674 entered into global variables and queue those in case the parsing
3677 This happens in a few situations: during partial-input, we invoke
3678 the parser repeatedly for example with the string "class X", this
3679 would cause X to be registed, and we need to remove this
3680 registration so that another parse attempt later with say "class X {"
3681 would actually work.
3683 Additionally, if there is an error in the resolution phase, for
3684 example: "class X : NonExistant {}" th
3686 * cs-parser.jay: Be more precise with the errors being raised,
3687 instead of flagging all exceptions during parsing to be attributed
3688 to the parsing process, distinguish those from errors happening in
3689 the actions and hint that using -v would produce the actual
3692 * repl.cs: Do not load all compiler references on each reset,
3693 doing the partial reset takes care of this.
3695 2008-08-28 Miguel de Icaza <miguel@novell.com>
3697 * repl.cs: Add support for loading all the files from
3698 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3701 Introduce a micro-parser that is able to deambiguate on its input
3702 whether we are dealing with a compilation unit (namespace, class,
3703 interface, struct, delegate) declaration or a statement. This
3704 allows both declarations and statements to be entered.
3706 Set history size by default to 300 lines.
3708 Instead of distinguishing based on the parser.InteractiveResult,
3709 have only two cases: statements were parsed, or a compilation unit
3710 was. Always pull the Using statement additions from the
3711 compilation unit parse.
3713 * cs-tokenizer.cs: Rename tokens to better describe their intent
3714 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3716 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3717 EvalMode is used to trigger the lookup of global variables while
3718 StatementMode is used turn variable declarations into static
3721 * getline.cs: Allow history size to be set.
3723 2008-08-29 Marek Safar <marek.safar@gmail.com>
3725 A fix for bug #360755
3726 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3728 2008-08-29 Marek Safar <marek.safar@gmail.com>
3730 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3732 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3733 member name, it is too confusing
3735 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3737 * rootcontext.cs: Finally default to warning level 4.
3739 2008-08-28 Marek Safar <marek.safar@gmail.com>
3741 * class.cs (CheckBase): Ignore overloaded operators.
3743 2008-08-28 Marek Safar <marek.safar@gmail.com>
3745 A fix for bug #420830
3746 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3748 2008-08-28 Marek Safar <marek.safar@gmail.com>
3750 A fix for bug #420832
3751 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3753 2008-08-28 Marek Safar <marek.safar@gmail.com>
3755 A fix for bug #420386
3756 * nullables.cs: Fixed logic of nullable user comparison operators involving
3759 2008-08-28 Marek Safar <marek.safar@gmail.com>
3761 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3763 2008-08-27 Miguel de Icaza <miguel@novell.com>
3765 * repl.cs: Add support for aborting the running code with C-c.
3767 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3769 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3771 2008-08-27 Miguel de Icaza <miguel@novell.com>
3773 * cs-parser.jay (interactive_statement_list): A new set of rules
3774 for hosting statements that uses the "interactive_" prefix.
3776 * repl.cs: Add support for parsing `using' as a statement or as a
3777 directive. Deambiguating before passing this to the parser.
3779 We need to distinguish statement_expressions that occur at the
3780 toplevel vs those that occur embedded into expressions.
3782 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3783 that fixes the cursor key handling, and a history bug.
3785 2008-08-26 Miguel de Icaza <miguel@novell.com>
3787 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3788 limitations in Console, instead the 2.0 bootstrap libraries now
3789 include the Console bits.
3791 Also, remove the use of Nullables from getline.cs
3795 Interactive support for the C# compiler. Use gmcs --shell to
3796 enter a read-eval-print loop shell.
3798 Docs: http://www.mono-project.com/CsharpRepl
3800 * sources: include repl.cs here and getline.cs for gmcs.exe,
3801 everything else is getline.cs impaired.
3803 * Makefile: when bootstrapping pass a special flag
3804 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3805 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3806 This distinguishes those two cases.
3808 * repl.cs: Support for a read-eval-print loop. Will be soon
3809 refactored into eval support and then REPL on top of it.
3811 * ecore.cs: If a simplename lookup fails, before erroring out,
3812 if we are in EvalMode to resolve the name to a declaration in the
3815 This means that variable declarations that happened in previous
3816 classes (as repl puts every statement in a separate class) are
3817 made visible in this way.
3819 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3820 triggered an error due to the end of file being reached. This is
3821 used to do multi-line input, and notify the caller that the user
3822 needs to provide more text before a successful parse.
3824 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3825 to drive the evaluation with a custom wrapper.
3827 * driver.cs: Add support for --shell, and refactor some code to be
3830 * namespace.cs: Add support for serializing the contents of the
3831 namespaces and reloading them.
3833 * getline.cs: A managed implementation of ReadLine under
3834 X11/Apache2 license terms. Easy to embed in other applications as
3837 * namespace.cs: Add some functions to save and restore the
3840 * rootcontext.cs: New public field.
3842 * cs-tokenizer.cs: Add support for one of the possible characters
3843 we introduce into the token stream.
3845 This patch does not affect the regular tokenization process, the
3846 only performance hit would happen if there is an invalid character
3847 on the input string.
3849 * support.cs: Move isatty helper routine here.
3851 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3852 code generator for in-memory assemblies.
3854 2008-08-26 Marek Safar <marek.safar@gmail.com>
3856 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3857 parameter cannot be always used as a type.
3859 2008-08-21 Marek Safar <marek.safar@gmail.com>
3861 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3863 2008-08-21 Marek Safar <marek.safar@gmail.com>
3865 * convert.cs: Implement explicit array to IList<T> conversion.
3867 2008-08-20 Marek Safar <marek.safar@gmail.com>
3869 A fix for bug #362740
3870 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3872 2008-08-20 Marek Safar <marek.safar@gmail.com>
3874 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3875 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3876 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3877 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3878 handling to use just one type of infrastructure and deal with generics
3881 2008-07-23 Martin Baulig <martin@ximian.com>
3883 *** Merged this from trunk revision 108527 ***
3886 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3887 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3890 2008-08-15 Marek Safar <marek.safar@gmail.com>
3892 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3895 2008-08-15 Marek Safar <marek.safar@gmail.com>
3897 * delegate.cs: Fixed compiler crash when creating delegate using partial
3900 * typemanager.cs: MulticastDelegate is not a delegate.
3902 2008-08-14 Marek Safar <marek.safar@gmail.com>
3904 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3907 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3909 * cs-parser.jay (type): Allow 'var' in mcs too.
3910 (local_variable_type): Likewise.
3912 2008-08-14 Marek Safar <marek.safar@gmail.com>
3914 * driver.cs: Removed broken -noconfig variants.
3916 2008-08-14 Marek Safar <marek.safar@gmail.com>
3918 A fix for bug #417078
3919 * expression.cs: Emit correctly left side pointer operators.
3921 2008-08-13 Marek Safar <marek.safar@gmail.com>
3923 * generic.cs, lambda.cs: Inflate method generic arguments only.
3925 2008-08-12 Marek Safar <marek.safar@gmail.com>
3927 * class.cs: Fixed struct layout check regression.
3929 2008-08-12 Marek Safar <marek.safar@gmail.com>
3931 * cs-parser.jay, enum.cs: Simplified enum parsing.
3933 * decl.cs: Check all type parameters conflicts.
3935 * expression.cs, statement.cs, attribute.cs: More expression checks.
3937 2008-08-11 Marek Safar <marek.safar@gmail.com>
3939 * generic.cs: Add type inference types restriction.
3941 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3942 anonymous.cs, expression.cs: Allocate less accessor parameters.
3944 2008-08-08 Marek Safar <marek.safar@gmail.com>
3946 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3949 2008-08-08 Marek Safar <marek.safar@gmail.com>
3951 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3953 2008-08-07 Marek Safar <marek.safar@gmail.com>
3955 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3956 Also fixes #362146 and #381592.
3958 2008-08-07 Marek Safar <marek.safar@gmail.com>
3960 * ecore.cs: Reduced constant cannot be used as an attribute value.
3962 * cs-parser.jay: Base expression has to be a type.
3964 * expression.cs (Conditional): Uses ReducedExpression.
3966 2008-08-06 Marek Safar <marek.safar@gmail.com>
3968 A fix for bug #376826
3969 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3970 address of hoisted local variable or parameter cannot be taken.
3972 2008-08-05 Marek Safar <marek.safar@gmail.com>
3974 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3975 anonymous method inside checked/unchecked expression.
3977 2008-08-05 Marek Safar <marek.safar@gmail.com>
3979 * typemanager.cs (IsEqual): Guard against null.
3981 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3982 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3983 routine. Fixed few misleading conversion errors.
3985 2008-08-04 Marek Safar <marek.safar@gmail.com>
3987 * class.cs: Consider generics when checking cycles in struct layout.
3989 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3991 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3993 2008-08-04 Marek Safar <marek.safar@gmail.com>
3995 A fix for bug #414165
3996 * anonymous.cs: Use same anonymous implementation method for all anonymous
3999 2008-08-04 Marek Safar <marek.safar@gmail.com>
4001 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
4004 2008-08-04 Marek Safar <marek.safar@gmail.com>
4006 * cs-parser.jay: Typeof argument has to be a type expression.
4008 * namespace.cs: Check alias and namespace definitions collisions.
4010 * class.cs, pending.cs: Moved explicit interface accessor implementation
4013 * delegate.cs, expression.cs: Verify special name invocations.
4015 2008-08-01 Marek Safar <marek.safar@gmail.com>
4017 * cs-parser.jay: Don't choke on empty generic type arguments.
4019 * cs-tokenizer.cs: Handle escaped preprocessor directives.
4021 * expression.cs, ecore.cs: Minor expressions bugs.
4023 2008-08-01 Marek Safar <marek.safar@gmail.com>
4025 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
4026 and added more error handling.
4028 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
4030 * modifiers.cs, enum.cs: Fixed.
4032 2008-07-31 Jb Evain <jbevain@novell.com>
4034 * driver.cs: remove -pkg ability of smcs.
4036 2008-07-30 Marek Safar <marek.safar@gmail.com>
4038 * statement.cs (Switch): Correctly set empty default target for single
4041 2008-07-30 Marek Safar <marek.safar@gmail.com>
4043 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
4044 string switch statement implementation to use string dictionary which
4045 significantly (2-8x) improves performance of generated code.
4047 2008-07-29 Marek Safar <marek.safar@gmail.com>
4049 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
4050 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
4052 2008-07-29 Marek Safar <marek.safar@gmail.com>
4054 A fix for bug #412595
4055 * typemanager.cs, convert.cs, expression.cs: Some types are never
4056 convertible to each other.
4058 2008-07-29 Marek Safar <marek.safar@gmail.com>
4060 * nullable.cs (CreateNullConstant): An error messages update.
4062 2008-07-29 Marek Safar <marek.safar@gmail.com>
4064 A fix for bug #412595
4065 * cfold.cs: Don't cast undefined bool constant.
4067 2008-07-29 Martin Baulig <martin@ximian.com>
4070 (SymbolWriter.Reset): New public static method.
4073 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
4075 2008-07-28 Marek Safar <marek.safar@gmail.com>
4077 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
4079 * expression.cs (ElementAccess): Exact size allocation.
4081 2008-07-26 Marek Safar <marek.safar@gmail.com>
4083 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
4085 2008-07-25 Marek Safar <marek.safar@gmail.com>
4087 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
4089 * class.cs: Removed $PRIVATE$ field hack which caused problems during
4092 2008-07-25 Marek Safar <marek.safar@gmail.com>
4094 A fix for bug #412217
4095 * assign.cs: Mutate also assignment type.
4097 2008-07-25 Marek Safar <marek.safar@gmail.com>
4099 A fix for bug #323644
4100 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
4103 2008-07-25 Marek Safar <marek.safar@gmail.com>
4105 A fix for bug #412134
4106 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
4107 non-enumerable operands when overloading equality or bitwise operators.
4109 2008-07-25 Marek Safar <marek.safar@gmail.com>
4111 * anonymous.cs: Cache closed generic anonymous method delegates.
4113 2008-07-24 Marek Safar <marek.safar@gmail.com>
4115 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
4116 anonymous.cs, statement.cs: Always emit anonymous method as static method
4117 when is instance free. Use nesting for nested anynomous methods blocks.
4119 2008-07-23 Marek Safar <marek.safar@gmail.com>
4121 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
4124 2008-07-23 Marek Safar <marek.safar@gmail.com>
4126 * expression.cs: Removed MakeSimpleCall.
4128 2008-07-23 Marek Safar <marek.safar@gmail.com>
4130 A fix for bug #323012
4131 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
4132 Base method implementing interface has to be public.
4134 2008-07-23 Marek Safar <marek.safar@gmail.com>
4136 * cs-parser.jay: Don't break on missing argument.
4138 2008-07-22 Marek Safar <marek.safar@gmail.com>
4140 A fix for bug #320993
4141 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
4142 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
4144 2008-07-22 Marek Safar <marek.safar@gmail.com>
4146 A fix for bug #320748
4147 * convert.cs: Implicit user operators cannot convert to interfaces
4149 2008-07-22 Marek Safar <marek.safar@gmail.com>
4151 A fix for bug #312686
4152 * driver.cs: Ignore empty assembly references.
4154 2008-07-22 Marek Safar <marek.safar@gmail.com>
4156 A fix for bug #387040
4157 * ecore.cs: Skip constrains check for an explicit implementation.
4159 2008-07-21 Marek Safar <marek.safar@gmail.com>
4161 A fix for bug #409045
4162 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
4163 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
4164 identifiers are file specific unless passed as input arguments.
4166 2008-07-21 Marek Safar <marek.safar@gmail.com>
4168 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
4169 to emit UnmanagedMarshal data under 2.0 profile.
4171 2008-07-21 Marek Safar <marek.safar@gmail.com>
4173 A fix for bug #410369
4174 * parameter.cs: Clone correctly ParamsParameter.
4176 2008-07-21 Marek Safar <marek.safar@gmail.com>
4178 * expression.cs (Argument): Always report type for type based expressions
4181 2008-07-18 Marek Safar <marek.safar@gmail.com>
4183 A fix for bug #410666
4184 * anonymous.cs: Correctly initialize generic storey reference.
4186 2008-07-18 Marek Safar <marek.safar@gmail.com>
4188 * convert.cs: Don't box same type arguments.
4190 2008-07-18 Marek Safar <marek.safar@gmail.com>
4192 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
4193 Finished missing generic type mutators.
4195 2008-07-18 Marek Safar <marek.safar@gmail.com>
4197 * iterators.cs, statement.cs: Finished statements CloneTo.
4199 2008-07-18 Marek Safar <marek.safar@gmail.com>
4201 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
4203 * expression.cs: Emit optimized default value expressions in expression tree
4206 2008-07-18 Marek Safar <marek.safar@gmail.com>
4208 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
4210 2008-07-17 Marek Safar <marek.safar@gmail.com>
4212 A fix for bug #367536
4213 * cs-parser.jay: Check static constructor of generic types for an access
4216 2008-07-17 Marek Safar <marek.safar@gmail.com>
4218 A fix for bug #353800
4219 * lambda.cs: Emit ret for contextual statements.
4221 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
4222 up emitting redundant ret for all anonymous methods with return.
4224 2008-07-17 Marek Safar <marek.safar@gmail.com>
4226 A fix for bug #365188
4227 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
4228 create anonymous method storey in unreachable block.
4230 2008-07-17 Marek Safar <marek.safar@gmail.com>
4232 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
4233 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
4234 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
4235 statement.cs: Fixed relevant defects found by Gendarme.
4237 2008-07-17 Marek Safar <marek.safar@gmail.com>
4239 A fix for bug #325291
4240 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
4241 statement.cs: Replaced IAnonymousHost with top level block flag.
4243 2008-07-17 Marek Safar <marek.safar@gmail.com>
4245 * cs-parser.jay: Clean up unused open_parens.
4247 2008-07-17 Marek Safar <marek.safar@gmail.com>
4249 * ecore.cs: Custom error message for a range variable assignment.
4251 2008-07-16 Marek Safar <marek.safar@gmail.com>
4253 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
4256 2008-07-16 Marek Safar <marek.safar@gmail.com>
4258 * literal.cs: Null literal is of object type.
4260 2008-07-16 Marek Safar <marek.safar@gmail.com>
4262 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
4263 expression of nullable equality comparison.
4265 2008-07-15 Marek Safar <marek.safar@gmail.com>
4267 * expression.cs(PointerArithmetic): Removed redundant assignment.
4269 2008-07-15 Marek Safar <marek.safar@gmail.com>
4271 * decl.cs (GetSignatureForError): Report full namespace name for containers.
4273 2008-07-14 Marek Safar <marek.safar@gmail.com>
4275 A fix for bug #408361
4276 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
4277 they are replaced by GetMethod.
4279 2008-07-14 Marek Safar <marek.safar@gmail.com>
4281 A fix for bug #408721 by jeremie.laval@gmail.com
4282 * expression.cs (Indirection): Implemented CloneTo.
4284 2008-07-14 Marek Safar <marek.safar@gmail.com>
4286 * statement.cs (AssignableSlots): Temporary disabled variable initialization
4289 2008-07-14 Marek Safar <marek.safar@gmail.com>
4291 * report.cs (EnableReporting): Don't reinitialize 0-based values.
4293 2008-07-11 Marek Safar <marek.safar@gmail.com>
4295 * linq.cs: Reset tranparent parameter counter in probing mode.
4297 2008-07-11 Marek Safar <marek.safar@gmail.com>
4299 * anonymous.cs: Mutate anonymous method type.
4301 2008-07-11 Marek Safar <marek.safar@gmail.com>
4303 * ecore.cs, anonymous.cs: Mutate field expressions.
4305 2008-07-10 Marek Safar <marek.safar@gmail.com>
4307 A fix for bug #369670
4308 * linq.cs, statement.cs: Use explicit block for query expressions variables.
4310 2008-07-10 Marek Safar <marek.safar@gmail.com>
4312 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
4314 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
4317 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
4318 only one '>', and finds a '>>', abort the generic lookahead.
4320 2008-07-10 Marek Safar <marek.safar@gmail.com>
4322 A fix for bug #319902
4323 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
4325 2008-07-10 Marek Safar <marek.safar@gmail.com>
4327 A fix for bug #406371
4328 * statement.cs: Moved EmitSymbolInfo to Block.
4330 2008-07-09 Marek Safar <marek.safar@gmail.com>
4332 * ecore.cs: Report better error for extension method overload failures.
4334 2008-07-09 Marek Safar <marek.safar@gmail.com>
4336 * expression.cs (Is): No need to box reference values.
4338 2008-07-09 Marek Safar <marek.safar@gmail.com>
4340 * class.cs: Use event resolve context when initializing CreateEmitContext.
4342 2008-07-09 Marek Safar <marek.safar@gmail.com>
4344 A fix for bug #394436
4345 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
4346 method used inside expression trees. Added more LINQ to expression tree
4349 2008-07-08 Marek Safar <marek.safar@gmail.com>
4351 A fix for bug #378189, #370577
4352 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
4355 2008-07-08 Marek Safar <marek.safar@gmail.com>
4357 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
4360 2008-07-08 Marek Safar <marek.safar@gmail.com>
4362 A fix for bug #406702
4363 * anonymous.cs: Always park anonymous method in the nearest parent storey.
4365 2008-07-07 Marek Safar <marek.safar@gmail.com>
4367 A fix for bug #406648
4368 * cs-parser.jay: Report nullable use in mcs for some cases.
4370 2008-07-07 Marek Safar <marek.safar@gmail.com>
4372 * ecore.cs: Improved argument mismatch error messages.
4374 2008-07-07 Marek Safar <marek.safar@gmail.com>
4376 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
4378 2008-07-07 Marek Safar <marek.safar@gmail.com>
4380 * expression.cs (TypeOf): Mutate type argument.
4382 2008-07-04 Marek Safar <marek.safar@gmail.com>
4384 * class.cs: Report missing partial modifier for correct type.
4386 2008-07-04 Marek Safar <marek.safar@gmail.com>
4388 * ecore.cs, expression.cs (VariableReference): Variable property is
4391 2008-07-04 Marek Safar <marek.safar@gmail.com>
4393 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
4395 2008-07-04 Marek Safar <marek.safar@gmail.com>
4397 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
4400 2008-07-04 Marek Safar <marek.safar@gmail.com>
4402 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
4403 anonymous method storey to an instance method when only "this" is hoisted.
4405 2008-07-03 Marek Safar <marek.safar@gmail.com>
4407 A fix for bug #321615
4408 * expression.cs: Pointer comparisons use unsigned operator.
4410 2008-07-03 Marek Safar <marek.safar@gmail.com>
4412 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
4414 2008-07-02 Marek Safar <marek.safar@gmail.com>
4416 A fix for bug #404905
4417 * class.cs: Always initialize local unsafe variables.
4419 2008-06-30 Marek Safar <marek.safar@gmail.com>
4421 A fix for bug #396987
4422 * expression.cs (NewInitialize): Clear local temporary variable for next run
4424 2008-06-27 Marek Safar <marek.safar@gmail.com>
4426 A fix for bug #401020
4427 * ecore.cs: Both types and modifiers have to match for ref and out arguments
4429 2008-06-27 Marek Safar <marek.safar@gmail.com>
4431 A fix for bug #398319
4432 * cs-parser.jay: Implemented undocumented base access expression inside
4435 2008-06-26 Marek Safar <marek.safar@gmail.com>
4437 A fix for bug #404227
4438 * cs-parser.jay: Parse namespace declaration using qualified identifier.
4440 2008-06-26 Marek Safar <marek.safar@gmail.com>
4442 A fix for bug #404227
4443 * convert.cs: Fixed explicit array to interface cast.
4445 2008-06-26 Marek Safar <marek.safar@gmail.com>
4447 A fix for bug #403894
4448 * delegate.cs: Mutate DelegateInvocation type.
4450 2008-06-26 Marek Safar <marek.safar@gmail.com>
4452 A fix for bug #379348
4453 * delegate.cs: Box a load of generic parameters.
4455 2008-06-26 Marek Safar <marek.safar@gmail.com>
4457 * expression.cs: Add an array creation arguments mutate.
4459 2008-06-26 Marek Safar <marek.safar@gmail.com>
4461 A fix for bug #386068
4462 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
4465 2008-06-25 Marek Safar <marek.safar@gmail.com>
4467 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
4470 2008-06-25 Marek Safar <marek.safar@gmail.com>
4472 A fix for bug #403518
4473 * delegate.cs: Type correctly anonymous method new invocation.
4475 2008-06-24 Marek Safar <marek.safar@gmail.com>
4477 A fix for bug #394826
4478 * anonymous.cs: Fully qualify members when resolving anonymous type internal
4481 2008-06-24 Marek Safar <marek.safar@gmail.com>
4483 A fix for bug #394826
4484 * anonymous.cs, iterators.cs: Construct generic storey only when is really
4487 2008-06-24 Marek Safar <marek.safar@gmail.com>
4489 * class.cs: Clone indexer parameters for localized capturing.
4491 2008-06-24 Marek Safar <marek.safar@gmail.com>
4493 A fix for bug #402379
4494 * expression.cs: Don't crash when an object initializer resolve fails.
4496 2008-06-24 Marek Safar <marek.safar@gmail.com>
4498 A fix for bug #402888
4499 * expression.cs: Mutate conditional expression.
4501 2008-06-24 Marek Safar <marek.safar@gmail.com>
4503 A fix for bug #401012
4504 * class.cs: Keep StructLayout in shared container.
4506 2008-06-24 Marek Safar <marek.safar@gmail.com>
4508 A fix for bug #400438
4509 * decl.cs, class.cs: Only properties can be automatically implemented.
4511 2008-06-24 Marek Safar <marek.safar@gmail.com>
4513 * statement.cs (ChangeToIterator): Copy also labels.
4515 2008-06-23 Marek Safar <marek.safar@gmail.com>
4517 * ecore.cs: Pass type argument details to parent extension method.
4519 2008-06-23 Marek Safar <marek.safar@gmail.com>
4521 A fix for bug #375966
4522 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
4524 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
4526 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
4528 2008-06-22 Marek Safar <marek.safar@gmail.com>
4530 A fix for bug #394347
4531 * anonymous.cs: Cache compatible delegates as compatibility check produces
4532 a new method every time.
4534 2008-06-20 Marek Safar <marek.safar@gmail.com>
4536 * anonymous.cs: Propagate storey reference for single references.
4538 2008-06-20 Marek Safar <marek.safar@gmail.com>
4540 A fix for bug #387615
4541 * assign.cs, expression.cs: Correctly clone compound assignment.
4543 2008-06-19 Marek Safar <marek.safar@gmail.com>
4545 A fix for bug #359611, #359604
4546 * anonymous.cs: Mutate all types of hoisted parameters.
4548 2008-06-19 Marek Safar <marek.safar@gmail.com>
4550 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4551 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4552 expression.cs, codegen.cs, statement.cs
4554 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4555 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4557 ** Anonymous methods, lambda expressions rewrite **
4559 Anonymous expressions are now resolved when an explicit block is resolved
4560 and they don't require any registration procedure anymore. Further,
4561 anonymous methods are defined when explicit block is emitted which allows
4562 better control of whole process and opens possibilities for more
4563 optimizations as well as alternative to reverse whole process.
4565 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4566 process consistent and to correctly emit hoisted generic methods when they
4567 have at least 1 hoisted variable.
4569 2008-06-17 Martin Baulig <martin@ximian.com>
4571 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4573 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4574 virtual property; check it in Emit().
4575 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4577 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4579 (Indexer.Define): Likewise.
4581 2008-06-17 Marek Safar <marek.safar@gmail.com>
4583 * convert.cs: Don't use IsInterface on type arguments.
4585 * delegate.cs: DelegateInvocation uses MethodInfo.
4587 * parameter.cs: Removed IsTypeParameter.
4589 * generic-mcs.cs: More missing stuff.
4591 2008-06-16 Martin Baulig <martin@ximian.com>
4594 (Modifiers.DEBUGGER_HIDDEN): New public const.
4597 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4600 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4601 (AbstractPropertyEventMethod): Likewise.
4602 (Constructor.Emit): Likewise.
4603 (SourceMethod.SetCompilerGenerated): Removed.
4605 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4609 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4610 if we're an `IteratorHost'.
4611 (AnonymousMethodMethod..ctor): Don't set
4612 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4615 2008-06-16 Marek Safar <marek.safar@gmail.com>
4617 * statement.cs: Clean-up foreach statements.
4619 2008-06-12 Marek Safar <marek.safar@gmail.com>
4621 * class.cs: Stop using public method which should not exist
4622 (MethodBuilder.SetGenericMethodSignature).
4624 2008-06-11 Martin Baulig <martin@ximian.com>
4627 (Location.LookupFile): Add `CompilationUnit' argument; when given
4628 a relative file name, make it relative to the directory the .cs
4629 file is located in instead of using the current directory.
4631 2008-06-11 Martin Baulig <martin@ximian.com>
4634 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4635 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4636 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4637 (SourceMethod.SetCompilerGenerated): Likewise.
4639 2008-06-11 Marek Safar <marek.safar@gmail.com>
4641 * codegen.cs, driver: Only write symbol file when it's asked for.
4643 2008-06-11 Marek Safar <marek.safar@gmail.com>
4645 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4647 2008-06-10 Martin Baulig <martin@ximian.com>
4649 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4651 2008-06-09 Marek Safar <marek.safar@gmail.com>
4653 A fix for bug #316290
4654 * expression.cs: Include decimal operators in predefined table.
4656 * parameters.cs: More readonlyness.
4658 2008-06-09 Marek Safar <marek.safar@gmail.com>
4660 A fix for bug #397213
4661 * cs-parser.jay: One more missing current_local_parameters reset.
4663 2008-06-09 Marek Safar <marek.safar@gmail.com>
4665 A fix for bug #396633
4666 * class.cs: Host backing field in partial container.
4668 2008-06-09 Marek Safar <marek.safar@gmail.com>
4670 A fix for bug #397068
4671 * expression.cs: Check both operand types when predefined operator is used.
4673 2008-06-05 Martin Baulig <martin@ximian.com>
4675 Merged the `debugger-kahalo' branch.
4678 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4679 we're an iterator method.
4680 (SourceMethod): Reflect latest symbol writer changes;
4681 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4682 now `start_row' and `end_row'.
4683 (Constructor.Emit): Fix the logic whether to emit symbol information.
4685 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4689 (CompilationUnit): New public class; derives from `SourceFile'.
4690 (SourceFileEntry.DefineSymbolInfo): New public method.
4691 (SourceFileEntry.SetChecksum): New public method.
4692 (Location): Encode hidden line numbers by using `column == 255';
4693 the .ctor now accepts `column == -1' to mark a hidden line number.
4694 (Location.Hidden): New public property.
4695 (Location.CheckPoint): Add `CompilationUnit'.
4696 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4697 (Location.Push): Add `CompilationUnit compile_unit' argument.
4698 (Location.CompilationUnit): New public property.
4701 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4703 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4705 * driver.cs: `SourceFile' -> `CompilationUnit'.
4707 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4709 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4711 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4715 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4716 new symbol writer API to also pass the file.
4718 2008-06-05 Marek Safar <marek.safar@gmail.com>
4720 * statement.cs: Emit catch variable assignment using variable expression.
4722 2008-06-05 Marek Safar <marek.safar@gmail.com>
4724 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4725 with other variable types.
4727 2008-06-04 Marek Safar <marek.safar@gmail.com>
4729 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4730 GetLength method emit, it breaks resolve rules.
4732 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4733 Marek Safar <marek.safar@gmail.com>
4735 A fix for bug #395542
4736 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4739 2008-06-02 Marek Safar <marek.safar@gmail.com>
4741 A fix for bug #395287
4742 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4744 2008-05-31 Marek Safar <marek.safar@gmail.com>
4746 A fix for bug #395845
4747 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4748 non-nullable parameter type.
4750 2008-05-31 Marek Safar <marek.safar@gmail.com>
4752 * class.cs: Handle contructor initializer as a statement in top-level block.
4754 2008-05-30 Marek Safar <marek.safar@gmail.com>
4756 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4757 security attributes.
4759 2008-05-24 Marek Safar <marek.safar@gmail.com>
4761 * ecore.cs, expression.cs: Small IVariable refactoring.
4763 2008-05-22 Marek Safar <marek.safar@gmail.com>
4765 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4767 2008-05-21 Marek Safar <marek.safar@gmail.com>
4769 * cs-parser.jay: Removed redundant catch type check.
4771 2008-05-21 Marek Safar <marek.safar@gmail.com>
4773 A fix for bug #390372
4774 * nullable.cs: Set correct return type.
4776 2008-05-21 Marek Safar <marek.safar@gmail.com>
4778 A fix for bug #391062
4779 * typemanager.cs: Fixed crash when comparing null types.
4781 2008-05-21 Marek Safar <marek.safar@gmail.com>
4783 A fix for bug #391871
4784 * cs-parser.jay: Better error handling for invalid catch type.
4786 2008-05-20 Marek Safar <marek.safar@gmail.com>
4788 A fix for bug #392155
4789 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4791 2008-05-15 Marek Safar <marek.safar@gmail.com>
4793 A fix for bug #390666
4794 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4797 2008-05-15 Marek Safar <marek.safar@gmail.com>
4799 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4802 2008-05-13 Marek Safar <marek.safar@gmail.com>
4804 A fix for bug #389625
4805 * delegate.cs, generic.cs: Some progress on method group return type
4808 2008-05-13 Marek Safar <marek.safar@gmail.com>
4810 A fix for bug #378419
4811 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4813 2008-05-12 Marek Safar <marek.safar@gmail.com>
4815 * class.cs (Constructor): Added IsCompilerGenerated.
4817 2008-05-12 Marek Safar <marek.safar@gmail.com>
4819 * expression.cs: Enum binary operators can accept non-enum operand only when
4820 is implicitly convertible to underlying type.
4822 2008-05-12 Marek Safar <marek.safar@gmail.com>
4824 A fix for bug #389272
4825 * support.cs: Workaround System.InvalidOperationException for enums.
4827 2008-05-12 Marek Safar <marek.safar@gmail.com>
4829 A fix for bug #389073
4830 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4832 2008-05-10 Marek Safar <marek.safar@gmail.com>
4834 * driver.cs: Split Parse.
4836 * location.cs (LookupFile): Uses string.Empty.
4838 2008-05-07 Marek Safar <marek.safar@gmail.com>
4840 * expression.cs, parameter.cs: Small ParameterReference clean up.
4842 2008-05-07 Marek Safar <marek.safar@gmail.com>
4844 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4845 hack. Fixes #387502.
4847 2008-05-06 Martin Baulig <martin@ximian.com>
4849 * class.cs (Constructor.Emit): Fix the logic whether to emit
4852 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4855 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4856 InvalidOperationException when the iterator is before the start or
4859 2008-05-06 Marek Safar <marek.safar@gmail.com>
4861 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4862 when left is nullable type.
4864 2008-05-06 Marek Safar <marek.safar@gmail.com>
4866 A fix for bug #386628
4867 * expression.cs (LocalVariableReference): Continue in resolving when
4868 variable is not assigned.
4870 2008-05-05 Marek Safar <marek.safar@gmail.com>
4872 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4873 nullable operations.
4875 2008-05-04 Marek Safar <marek.safar@gmail.com>
4877 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4878 it saves many redundant temporary variables for nullable operations.
4880 2008-05-03 Marek Safar <marek.safar@gmail.com>
4882 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4884 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4887 * nullable.cs: Constant coalescing operator optimizations.
4889 2008-05-03 Marek Safar <marek.safar@gmail.com>
4891 * constant.cs: Use unsigned conversion for values which are unsigned only.
4893 2008-05-03 Marek Safar <marek.safar@gmail.com>
4895 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4896 coalescing operator as it should be.
4898 2008-05-02 Marek Safar <marek.safar@gmail.com>
4900 A fix for bug #371016
4901 * expression.cs: All predefined delegate operators require implicit method
4904 2008-05-02 Marek Safar <marek.safar@gmail.com>
4906 * constant.cs: Emit long constant as uint when fits the range.
4908 * convert.cs, expression.cs: Fixed few unsafe conversions.
4910 2008-05-02 Marek Safar <marek.safar@gmail.com>
4912 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4914 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4917 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4919 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4921 2008-05-01 Marek Safar <marek.safar@gmail.com>
4923 * constant.cs, literal.cs: IsLiteral property for error reporting.
4925 * ecore.cs, expression.cs: Implemented Property expression.
4927 2008-05-01 Marek Safar <marek.safar@gmail.com>
4929 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4931 * nullable.cs: Implemented nullable coalescing null operator.
4933 * ecore.cs, expression.cs: Expression trees work.
4935 2008-05-01 Marek Safar <marek.safar@gmail.com>
4937 * ecore.cs: CreateExpressionTree is finally abstract.
4939 * expression.cs, linq.cs: Updated.
4941 2008-05-01 Marek Safar <marek.safar@gmail.com>
4943 * expression.cs, ecore.cs: Block base access expression inside expression
4946 2008-05-01 Marek Safar <marek.safar@gmail.com>
4948 A fix for bug #385058
4949 * expression.cs: User-defined operator implementations always take
4950 precedence over predefined operator implementations.
4952 2008-04-30 Marek Safar <marek.safar@gmail.com>
4954 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4955 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4956 expression tree conversions.
4958 2008-04-30 Marek Safar <marek.safar@gmail.com>
4960 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4961 operators method details to Operator class.
4963 2008-04-30 Marek Safar <marek.safar@gmail.com>
4965 * anonymous.cs: Pass unsafe flags to anonymous container.
4967 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4968 inside expression tree.
4970 2008-04-29 Martin Baulig <martin@ximian.com>
4972 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4973 (Tokenizer.PopPosition): Also restore the `line'.
4975 2008-04-29 Marek Safar <marek.safar@gmail.com>
4977 * delegate.cs: Implemented Invoke expression.
4979 2008-04-29 Marek Safar <marek.safar@gmail.com>
4981 * expression.cs: Fixed equality reference comparison regression.
4983 2008-04-29 Marek Safar <marek.safar@gmail.com>
4985 * ecore.cs: Clean up EmptyCast hack.
4987 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4988 using correct conversion rules. Also fixes #383993.
4990 2008-04-28 Martin Baulig <martin@ximian.com>
4992 * class.cs (Constructor.Emit): Don't emit debugging information
4993 for generated default .ctor's.
4995 2008-04-28 Marek Safar <marek.safar@gmail.com>
4997 * convert.cs: Empty-cast ushort to int conversion.
4999 2008-04-28 Marek Safar <marek.safar@gmail.com>
5001 A fix for bug #384191
5002 * ecore.cs, expression.cs: Fixed expression cloning.
5004 2008-04-28 Marek Safar <marek.safar@gmail.com>
5006 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
5008 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
5010 Fix #381559, test-638.cs, test-639.cs
5011 * assign.cs (CompoundAssign.Helper): New wrapper.
5012 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
5014 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
5015 Pass unconverted expressions to the params array creation expression.
5016 (FieldExpr.EmitAssign): Don't special-case StringConcat.
5017 (PropertyExpr.EmitAssign): Likewise.
5018 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
5019 element if it is of kind CompoundAssign.Helper.
5020 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
5021 first before anything else.
5022 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
5023 (ArrayAccess.LoadArrayAndArguments): Simplify.
5025 2008-04-27 Marek Safar <marek.safar@gmail.com>
5027 * expression.cs: Fixed cloning of typeof(void).
5029 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
5031 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
5032 (Assign.Emit): Likewise. Move it to ...
5033 (CompoundAssign.DoResolve): ... here and ...
5034 (CompoundAssign.Emit): ... here.
5035 (EventAddOrRemove): New helper to handle += and -= on events, and
5036 avoid the use of BinaryDelegates.
5037 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
5038 (EventExpr.EmitAddOrRemove): Improve.
5039 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
5041 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
5042 create VarExprs for 'foo.bar.var'.
5043 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
5044 is a highly inappropriate name for its functionality.
5046 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
5048 Simplify handling of multiple assignments
5049 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
5051 (SimpleAssign): New. Class to be used for normal assignments.
5052 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
5053 * expression.cs, parameter.cs, statement.cs: Likewise.
5055 2008-04-25 Marek Safar <marek.safar@gmail.com>
5057 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
5058 for incompatible underlying types, more to come, uff.
5060 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
5063 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
5064 Handle 'leave_copy'.
5066 2008-04-25 Marek Safar <marek.safar@gmail.com>
5068 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
5070 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
5072 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
5073 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
5074 * statement.cs (While, Do, For): Allow test to have side effects.
5075 (For.DoEmit): Always emit InitStatement.
5078 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
5079 Always create SideEffectConstant.
5080 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
5081 of type EnumConstant.
5083 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
5084 Handle 'right' being SideEffectConstant of type 'bool'.
5086 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
5087 Use left.EmitBranchable instead of open coding it, so as to
5088 improve optimization opportunities.
5090 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
5092 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
5094 (Expression.EmitSideEffect): Document.
5096 2008-04-23 Marek Safar <marek.safar@gmail.com>
5098 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
5100 2008-04-23 Marek Safar <marek.safar@gmail.com>
5102 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
5104 2008-04-23 Marek Safar <marek.safar@gmail.com>
5106 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
5107 conversion to expression tree.
5109 2008-04-23 Marek Safar <marek.safar@gmail.com>
5111 * ecore.cs: Removed unused expression.
5113 2008-04-22 Marek Safar <marek.safar@gmail.com>
5115 * expression.cs: Implemented NegateChecked and New expressions.
5117 2008-04-22 Marek Safar <marek.safar@gmail.com>
5119 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
5121 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
5124 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
5125 needing final 'ret' instruction.
5127 2008-04-22 Marek Safar <marek.safar@gmail.com>
5129 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
5131 2008-04-21 Marek Safar <marek.safar@gmail.com>
5133 * expression.cs: Emit ldnull and not null expression as an instance argument
5134 of static method expression calls.
5136 2008-04-21 Marek Safar <marek.safar@gmail.com>
5138 A fix for bug #378200
5139 * expression.cs: Fixed crash when creating parameterless expression tree
5142 2008-04-21 Marek Safar <marek.safar@gmail.com>
5144 A fix for bug #375297
5145 * anonymous.cs: Fixed crash when inferring from null argument anonymous
5148 2008-04-21 Marek Safar <marek.safar@gmail.com>
5150 A fix for bug #377596
5151 * decl.cs, class.cs: Emit delegate type argument attributes.
5153 2008-04-21 Marek Safar <marek.safar@gmail.com>
5155 A fix for bug #365314
5156 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
5158 2008-04-21 Marek Safar <marek.safar@gmail.com>
5160 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
5163 2008-04-21 Marek Safar <marek.safar@gmail.com>
5165 * generic.cs (TypeParameter): Removed redundant location.
5167 2008-04-19 Marek Safar <marek.safar@gmail.com>
5169 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
5170 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
5171 FullNamedExpression in all declaration type expression, statements will come
5174 2008-04-18 Marek Safar <marek.safar@gmail.com>
5176 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
5177 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
5179 2008-04-18 Marek Safar <marek.safar@gmail.com>
5181 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
5184 2008-04-17 Marek Safar <marek.safar@gmail.com>
5186 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
5189 2008-04-17 Marek Safar <marek.safar@gmail.com>
5191 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
5195 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
5197 Hook up 'EmitSideEffect'
5198 * constant.cs (Constant.EmitSideEffect): New.
5199 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
5200 (SideEffectConstant.EmitSideEffect): New.
5201 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
5202 unconditional branch in EmitBranchable.
5203 (FieldExpr.EmitBranchable): New.
5204 * expression.cs (Unary.EmitSideEffect): New.
5205 (Binary.EmitSideEffect): New.
5206 (VariableReference.EmitSideEffect): New. Do nothing.
5208 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5210 Introduce 'EmitSideEffect'
5211 * ecore.cs (Expression.EmitSideEffect): New.
5212 (TypeCast): Rename from EmptyCast.
5214 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
5215 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
5216 * convert.cs, nullable.cs: Update to changes.
5218 2008-04-16 Marek Safar <marek.safar@gmail.com>
5220 * class.cs, cs-parser.jay: Early check for base types expression.
5222 2008-04-16 Marek Safar <marek.safar@gmail.com>
5224 * decl.cs (MemberName): Declare PrettyName as obsolete.
5226 2008-04-16 Marek Safar <marek.safar@gmail.com>
5228 * namespace.cs: Use MemberName comparison.
5230 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5233 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
5235 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
5236 (MemberName.FullyQualifiedName): New. Provides the functionality
5237 that users assume FullName would have.
5238 * ecore.cs, namespace.cs: Update to changes.
5240 * statement.cs (Using.assign): Make into ExpressionStatement.
5241 (Using.EmitPreTryBody): Simplify.
5243 2008-04-16 Marek Safar <marek.safar@gmail.com>
5245 * report.cs: ColorFormat is protected.
5247 * rootcontext.cs: Unused fields clean-up.
5249 * namespace.cs: Made UsingEntry name private.
5251 2008-04-16 Marek Safar <marek.safar@gmail.com>
5253 * cs-tokenizer.cs, location.cs: Removed unused field.
5255 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
5256 Raja R Harinath <harinath@hurrynot.org>
5259 * constant.cs (SideEffectConstant.value): Rename from 'left'.
5260 (SideEffectConstant.side_effect): Rename from 'right'.
5261 (SideEffectConstant..ctor): Normalize 'side_effect'.
5262 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
5263 value of this constant.
5264 * cfold.cs: Update to changes.
5266 2008-04-15 Marek Safar <marek.safar@gmail.com>
5268 * cs-paser.jay: Removed unused variable.
5270 * driver.cs: Made Compile instance method.
5272 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
5274 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
5276 2008-04-15 Marek Safar <marek.safar@gmail.com>
5278 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
5280 2008-04-13 Jb Evain <jbevain@novell.com>
5282 * namespace.cs: update the System.Core fullname for 2.1
5283 * driver.cs: update the list of required assemblies for 2.1.
5284 Merged from the Moonlight 2 branch.
5286 2008-04-11 Marek Safar <marek.safar@gmail.com>
5288 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
5289 types and user defined operators. User operators arguments has to be checked
5290 for null value before invocation, which also means no operator is called
5291 when any argument is not convertible to unwrapped nullable type.
5293 2008-04-09 Marek Safar <marek.safar@gmail.com>
5295 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
5296 of Unary expressions to follow operator overloading rules precisely.
5297 Also fixes #321794, #323794
5299 2008-04-08 Marek Safar <marek.safar@gmail.com>
5301 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
5304 2008-04-08 Marek Safar <marek.safar@gmail.com>
5306 * expression.cs, ecore.cs: Implemented MemberInit expression.
5308 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
5310 Fix mono/tests/exception4.cs
5311 * statement.cs (ExceptionStatement, TryCatch): Revert to using
5312 ec.NeedReturnLabel () rather emitting a 'nop'.
5314 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
5316 (TryCatch.SomeCodeFollows): Likewise.
5317 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
5318 for 'break', 'continue' and 'return' statements inside a try.
5319 We're fairly sure that the generated IL stream will have more
5320 instructions textually following the try.
5321 (FlowBranchingTryCatch): Likewise.
5323 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
5324 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
5327 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
5328 wrapper -- forward everything to CollectionForeach.
5329 (CollectionForeach.NonDisposableWrapper): New.
5330 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
5331 instead of a pop + branch to end.
5333 2008-04-07 Marek Safar <marek.safar@gmail.com>
5335 A fix for bug #377485
5336 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
5337 Propagate location for extension method groups. Report conversion failure at
5340 2008-04-07 Marek Safar <marek.safar@gmail.com>
5342 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
5343 ListInit and Field expressions.
5345 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
5347 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
5348 Since $PC is always -1 inside the body of MoveNext, the fault
5350 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
5351 * statement.cs (ExceptionStatement.emit_finally): Likewise.
5352 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
5354 The denouement! Fix #324708
5355 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
5356 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
5357 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
5358 'finally' inside the finally clause.
5360 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
5361 inside an iterator. Don't emit the body of the 'finally' inside
5362 the finally clause yet.
5364 Use the ResumableStatement infrastructure for MoveNext ()
5365 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
5366 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
5367 'old_resume_points'. Move dispatcher upfront.
5368 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
5369 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
5370 in an enumerator. This encodes the main fix in this patch series
5371 -- we can only jump into the first instruction of a try from the
5372 outside, but we want to emit try/finally regions in iterators and
5373 resume in the middle of them.
5375 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
5377 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
5378 of NeedReturnLabel here.
5380 Introduce a common point for emitting try/finally to IL
5381 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
5382 features of the various subclasses, which are now driven by ...
5383 (ExceptionStatement.EmitPreTryBody): ... this and ...
5384 (ExceptionStatement.EmitTryBody): ... this and the original
5386 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
5387 Remove DoEmit and update to follow above protocol.
5389 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
5390 of the dispatcher are the same, skip emitting the 'switch'.
5391 * iterator.cs (Iterator.EmitDispose): Update to changes.
5393 Clean up handling of 'using' statement
5394 * statement.cs (UsingTemporary): New. Carved out of ...
5395 (Using): ... this. Simplify drastically. Handle exactly
5397 * cs-parser.jay (using_statement): Split. Create UsingTemporary
5398 or Using as appropriate. If there are multiple variable declared,
5399 create nested Using statements.
5400 (resource_acquisition): Kill.
5402 * statement.cs (ExceptionStatement.EmitForDispose): Use
5403 EmitFinallyBody, not EmitFinally.
5405 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
5406 * iterator.cs: Update to changes.
5408 Start using the ResumableStatement infrastructure
5409 * statement.cs (ResumeableStatement.PrepareForDispose): New.
5410 (ResumableStatement.EmitForDispose): New.
5411 (ExceptionStatement): Override them.
5412 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
5413 EmitForDispose to create the body of the Dispose method. Don't
5416 * iterator.cs (Iterator.AddResumePoint): Move here from ...
5417 * statement.cs (Toplevel.AddResumePoint): ... here.
5418 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
5419 * flowanalysis.cs (FlowBranchingIterator): New.
5420 * codegen.cs (EmitContext): Update to changes.
5422 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
5423 (Iterator.old_resume_points): Rename from 'resume_points'.
5424 (Iterator.MoveNextStatement): Remove unused class.
5426 New infrastructure for try/finally in iterators (still unused)
5427 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
5428 (FlowBranchingToplevel.AddResumePoint): Hook into
5429 ToplevelBlock.AddResumePoint.
5430 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
5431 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
5432 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
5433 resume points and assign program-counter values.
5434 (ExceptionBlock.AddResumePoint): Collect resume points for
5435 de-muxer at the top of try block.
5436 * iterators.cs (Yield.CheckContext): Simplify.
5437 (Yield.Resolve): Use FlowBranching.AddResumePoint.
5439 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
5441 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
5442 argument to an ExitStatement.
5443 (FlowBranchingException): Refactor saved origins code.
5444 * statement.cs (ExitStatement): Update to cahges.
5445 * iterator.cs (YieldBreak): Likewise.
5447 * statement.cs (ResumableStatement): New. Common base class for
5448 YieldReturn and ExceptionStatement.
5449 (ExitStatement): New. Common base class for Return and YieldBreak.
5450 (Return): Update to changes.
5451 * iterator.cs (YieldBreak): Likewise.
5452 * lambda.cs (ContextualReturn): Likewise.
5455 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
5456 emit a meaningful error message.
5458 Fix #324765, #319508
5459 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
5460 (VariableInfo.SetAssigned): Set it.
5461 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
5462 determine if CS0219 or CS0168 is appropriate. Don't use
5463 flow-analysis information.
5464 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
5465 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
5466 (EmitContext.EndFlowBranching): ... this.
5468 2008-04-03 Marek Safar <marek.safar@gmail.com>
5470 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
5472 2008-04-03 Marek Safar <marek.safar@gmail.com>
5474 A fix for bug #376508
5475 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
5476 ImplicitConversionExists.
5478 2008-04-03 Marek Safar <marek.safar@gmail.com>
5480 * expression.cs (Binary): Added remaining binary operators to expression
5483 * nullable.cs: Optimize shift with null argument.
5485 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
5487 Fix minor IL regression
5488 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
5489 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
5490 * cs-parser.jay (try_statement): Update to changes.
5492 * statement.cs (TryFinally.need_exc_block): Delete.
5493 (TryFinally): Update to changes.
5495 Now all ExceptionStatements are unconditional
5496 * statement.cs (CollectionForeach.DisposableWrapper): New.
5497 Extract out the try/finally code into a new wrapper.
5498 (CollectionForeach.Resolve): Use it to simplify the code.
5500 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
5502 Start at simplifying ExceptionStatement semantics a bit
5503 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
5504 * cs-parser.jay (try_statement): Update to changes.
5505 (opt_catch_clauses): Remove.
5506 * flowanalysis.cs: Update to changes.
5507 (FlowBranching.BranchingType.TryCatch): New.
5508 (FlowBranchingTryCatch): New.
5510 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
5511 (FlowBranching.CreateBranching): Update to changes.
5512 (FlowBranchingBlock.AddSibling): Add sanity check.
5513 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
5516 * iterators.cs (Iterator.MarkFinally): Remove.
5517 * statement.cs (ExceptionStatement): Update to changes.
5519 Add support for skipping over finally blocks at runtime. First
5520 in a series to fix #324708
5521 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
5522 (Iterator.EmitMoveNext): Initialize it.
5523 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
5524 branch over the body of the 'finally' clause.
5526 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
5528 Avoid lopsided use of Foo/DoFoo names
5529 * statement.cs (ExpressionStatement.EmitFinallyBody):
5530 Rename from EmitFinally.
5531 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
5532 * iterator.cs: Update to changes.
5534 2008-04-02 Marek Safar <marek.safar@gmail.com>
5536 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
5537 based on UserOperatorCall. More binary nullable operators clean up.
5539 2008-04-02 Martin Baulig <martin@ximian.com>
5541 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5543 2008-04-02 Marek Safar <marek.safar@gmail.com>
5545 * nullable.cs: Merge user and empty conversions when lifting expression
5548 * expression.cs (StringConcat): Implemented expression tree representation.
5550 2008-04-01 Marek Safar <marek.safar@gmail.com>
5552 * nullable.cs: When lifting null literal and a user operator exists, no call
5555 2008-04-01 Marek Safar <marek.safar@gmail.com>
5557 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5560 2008-04-01 Marek Safar <marek.safar@gmail.com>
5562 * nullable.cs, expression.cs: Use namespace instead heavily nested
5563 monster abstract class.
5565 2008-04-01 Marek Safar <marek.safar@gmail.com>
5567 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5568 lifting of null literal and user operators. Clean up of some temporary
5571 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5573 Fix #368224, test-629.cs
5574 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5575 if it crossed an unwind-protect boundary.
5576 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5577 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5578 inside an unwind-protected region.
5579 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5580 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5581 'leave' instead of a 'br' if unwind-protected.
5582 (Iterator.EmitYieldBreak): Likewise.
5584 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5586 * driver.cs: Only define versioninfo resources if no win32 resource
5589 2008-03-28 Marek Safar <marek.safar@gmail.com>
5591 A fix for bug #372375
5592 * convert.cs: Fixed boxing of nullable types.
5594 2008-03-28 Marek Safar <marek.safar@gmail.com>
5596 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5599 2008-03-28 Marek Safar <marek.safar@gmail.com>
5601 A fix for bug #374619
5602 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5604 2008-03-27 Marek Safar <marek.safar@gmail.com>
5606 * lambda.cs: Check return type only for invocation.
5608 2008-03-27 Marek Safar <marek.safar@gmail.com>
5610 A fix for bug #374214
5611 * ecore.cs: Correctly report argument type mismatch.
5613 2008-03-27 Marek Safar <marek.safar@gmail.com>
5615 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5616 and not rely on broken IsEnum.
5618 2008-03-27 Marek Safar <marek.safar@gmail.com>
5620 * nullable.cs: New file, extracted from generic.cs.
5622 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5624 2008-03-27 Marek Safar <marek.safar@gmail.com>
5626 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5627 predefined comparison operators and null literals.
5629 * report.cs: New warning ID.
5631 2008-03-25 Marek Safar <marek.safar@gmail.com>
5633 A fix for bug #370577
5634 * lambda.cs: Check return type too.
5636 2008-03-25 Marek Safar <marek.safar@gmail.com>
5638 A fix for bug #372846
5639 * class.cs: Automatic properties can be declared as unsafe.
5641 2008-03-20 Marek Safar <marek.safar@gmail.com>
5643 * location.cs: Use string based concatenation.
5645 * expression.cs: LiftedBinaryOperator is gmcs only.
5647 2008-03-20 Marek Safar <marek.safar@gmail.com>
5649 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5650 conversions rules and expression trees.
5652 2008-03-19 Marek Safar <marek.safar@gmail.com>
5654 * delegate.cs: Use extension method source as delegate target.
5656 2008-03-19 Marek Safar <marek.safar@gmail.com>
5658 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5659 binary operations to be purely based on binary operations and optimized
5660 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5661 and other ET refactoring.
5663 * typemanager.cs: Fixed warning.
5665 2008-03-17 Marek Safar <marek.safar@gmail.com>
5667 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5669 * symbolwriter.cs: Fixed.
5671 2008-03-17 Marek Safar <marek.safar@gmail.com>
5673 * anonymous.cs, driver.cs: Reset anonymous types counters.
5675 2008-03-17 Marek Safar <marek.safar@gmail.com>
5677 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5679 * class.cs: Use fullname for all type member definitions.
5681 2008-02-19 Martin Baulig <martin@ximian.com>
5684 (IMethodData.EmitExtraSymbolInfo): New interface method.
5685 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5686 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5687 interface method here as an empty public virtual method.
5690 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5691 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5692 CodeGen.SymbolWriter.SetRealMethodName().
5694 2008-02-18 Martin Baulig <martin@ximian.com>
5697 (ScopeInfo.EmitType): Override this and emit debugging
5698 information for captured variables.
5699 (RootScopeInfo.EmitType): Override this and emit symbol
5700 information for a captured `this'.
5702 2008-02-15 Martin Baulig <martin@ximian.com>
5704 * iterators.cs: Emit debugging info.
5707 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5708 (EmitContext.OmitDebuggingInfo): New public property.
5711 (While): Override Emit() and don't emit symbol info there; do it
5712 inside DoEmit() instead.
5713 (Block.Emit): Omit symbol information while emitting the scope
5714 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5716 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5717 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5718 .ctor to make `IsIterator' work.
5720 2008-03-14 Martin Baulig <martin@ximian.com>
5722 * symbolwriter.cs: Added the new symbol writer function from the
5723 debugger's `terrania' branch; temporarily enclose them inside
5724 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5727 2008-03-14 Martin Baulig <martin@ximian.com>
5730 (SymbolWriter): Make this a public static class.
5733 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5734 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5736 2008-03-14 Marek Safar <marek.safar@gmail.com>
5738 A fix for bug #370577
5739 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5742 2008-03-14 Marek Safar <marek.safar@gmail.com>
5744 * typemanager.cs (CSharpName): Made 250 times faster.
5746 2008-03-13 Marek Safar <marek.safar@gmail.com>
5748 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5750 2008-03-12 Marek Safar <marek.safar@gmail.com>
5752 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5753 crash when predefined field does not exist.
5755 2008-03-12 Marek Safar <marek.safar@gmail.com>
5757 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5759 2008-03-12 Marek Safar <marek.safar@gmail.com>
5761 * class.cs (FixedField): Don't crash when contructors are missing.
5763 2008-03-11 Marek Safar <marek.safar@gmail.com>
5765 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5766 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5767 check internal types accessibility for internal and external types.
5768 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5770 2008-03-11 Marek Safar <marek.safar@gmail.com>
5772 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5773 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5774 attribute.cs, statement: Use corect instance of predefined types (work
5775 related to #364674).
5777 2008-03-07 Marek Safar <marek.safar@gmail.com>
5779 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5781 2008-03-07 Marek Safar <marek.safar@gmail.com>
5783 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5784 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5785 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5786 predefined types clean up, delayed predefined types members initialization
5787 (work related to #364674).
5789 2008-03-05 Marek Safar <marek.safar@gmail.com>
5791 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5793 2008-03-05 Marek Safar <marek.safar@gmail.com>
5795 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5796 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5797 predefined types clean up (work related to #364674).
5799 2008-03-04 Marek Safar <marek.safar@gmail.com>
5801 * ecore.cs: Print an error message instead of throwing exception.
5803 2008-03-04 Marek Safar <marek.safar@gmail.com>
5805 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5806 expression.cs, statement.cs: Unififed null literal representation.
5808 2008-03-03 Marek Safar <marek.safar@gmail.com>
5810 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5811 expression.cs: Refactored binary operators resolve phase and improved speed.
5812 The nullable code is still missing and won't work correctly, more fixes
5815 It also fixes #323726, #324312, #324248, and many other unreported issues.
5817 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5819 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5822 2008-02-27 Marek Safar <marek.safar@gmail.com>
5824 * ecore.cs: Clean-up and split BetterConversion.
5826 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5829 * enum.cs (EnumMember.Value): Only access 'value' if
5830 ResolveValue says it's ok.
5831 (EnumMember.DoResolveValue): Don't set prev_member.value.
5832 (Enum.GetDefinition): Reverse arguments of Equals --
5833 EnumMember.Value can return 'null'.
5835 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5837 2008-02-22 Marek Safar <marek.safar@gmail.com>
5839 * generic.cs, expression.cs: More ongoing work on expression trees.
5841 2008-02-21 Marek Safar <marek.safar@gmail.com>
5843 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5844 handle missing matches when mutiple operators exist.
5846 2008-02-20 Marek Safar <marek.safar@gmail.com>
5848 A fix for bug #363218
5849 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5852 2008-02-20 Marek Safar <marek.safar@gmail.com>
5854 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5855 update. This time to deal correctly with SideEffectConstant expression used
5856 as an argument for another constant folding.
5858 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5860 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5863 2008-02-19 Marek Safar <marek.safar@gmail.com>
5865 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5867 2008-02-19 Marek Safar <marek.safar@gmail.com>
5869 A fix for bug #328136
5870 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5871 side is a false constant, because we still need to evaluate the right-hand
5874 * statement.cs (If): Emit two types of boolean constants (simple constant,
5875 side-effect constant).
5877 2008-02-19 Marek Safar <marek.safar@gmail.com>
5879 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5881 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5884 2008-02-18 Marek Safar <marek.safar@gmail.com>
5886 A fix for bug #361457
5887 * ecore.cs (IsApplicable): Params methods have lower priority.
5889 * support.cs: Return correct parameter modifier for params types.
5891 2008-02-18 Marek Safar <marek.safar@gmail.com>
5893 * generic.cs (TypeParameter): Cache attribute target name.
5895 * support.cs: Removed unused variable.
5897 * typemanager.cs: Removed debugging leftover.
5899 * ecore.cs: Use local type instead of a property;
5901 * class.cs (VerifyMembers): Consider also parent to test whether type member
5904 * expression.cs (FullMethodDesc): Removed.
5906 * attribute.cs (IsValidArgumentType): Made static.
5908 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5910 Cleanup to be more readable.
5911 * Makefile (GMCS_PROFILE): Remove.
5912 (COMPILER_NAME): New helper.
5914 2008-02-15 Miguel de Icaza <miguel@novell.com>
5916 * cs-tokenizer.cs: if a conditional expression happens inside a
5917 (...) this also means that we do not need to de-ambiguate between
5918 an parenthesized expression and a cast.
5922 * constant.cs (SideEffectConstant): a constant value that happens
5923 to have a side effect.
5925 Fixes the build regressions introduced by the fix for #359789
5927 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5929 * expression.cs (Conditional.Emit): when emitting the ternary
5930 operator, use local variables to generate code verifiable code.
5932 The verifier cannot infer that the type on stack before the
5933 stloc.0 is executed is of type ParentB. This happens because the
5934 stack merge algorithm uses only parent types when deciding which
5935 is the common type. This is described in Part III 1.8.1.3 of ECMA
5938 This code compiled with mcs is not verifiable under MS. The MS
5939 verifier picks the first common interface of Foo and Bar, which is
5940 wrong, but doesn't use a full join type of the 2 interfaces.
5942 CSC uses a clever hack to compile such code in a verifiable
5943 way. It stores the intermediate values in a local variable with
5948 2008-02-14 Miguel de Icaza <miguel@novell.com>
5950 * expression.cs: Do not fold BitwiseAnd operators when the left
5951 side is a false constant, because we still need to evaluate the
5956 * support.cs: Instead of throwing an InternalErrorException when
5957 the position of the stream is outside the boundary of our buffer,
5958 reset the state of the reader, and restart the reading from the
5959 beginning of the file.
5961 2008-02-14 Marek Safar <marek.safar@gmail.com>
5963 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5965 2008-02-14 Marek Safar <marek.safar@gmail.com>
5967 A fix for bug #361686
5968 * decl.cs: A protected types used inside a private class which parents
5969 derives from the protected class are accessible.
5971 2008-02-13 Marek Safar <marek.safar@gmail.com>
5973 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5974 the parameterless constructor.
5976 2008-02-13 Marek Safar <marek.safar@gmail.com>
5978 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5979 lookup methods to use standard member cache when doing member lookup.
5981 2008-02-12 Marek Safar <marek.safar@gmail.com>
5983 * driver.cs: Don't report full path for referenced module as assembly error.
5985 2008-02-12 Marek Safar <marek.safar@gmail.com>
5987 * Makefile: Fixed `qh' target to work on all machines.
5989 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5990 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5991 and HasElementType with TypeManager implementation.
5993 2008-02-08 Marek Safar <marek.safar@gmail.com>
5995 A fix for bugs #325134, #359749
5996 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5997 first binds point to non-method member expression.
5999 2008-02-08 Marek Safar <marek.safar@gmail.com>
6001 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
6003 2008-02-08 Marek Safar <marek.safar@gmail.com>
6005 A fix for bugs #321394, #323028
6006 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
6007 Reworked naive IsAccessibleAs implementation to handle nested types.
6009 2008-02-05 Jb Evain <jbevain@novell.com>
6011 * class.cs: use generic type comparison for parameters
6014 2008-02-05 Marek Safar <marek.safar@gmail.com>
6016 A fix for bug #325372
6017 * class.cs: Use generic type comparison when testing method signatures.
6019 2008-02-05 Marek Safar <marek.safar@gmail.com>
6021 A fix for bug #357047
6022 * ecore.cs: Applied C# 3.0 changes to better conversion.
6024 2008-02-05 Marek Safar <marek.safar@gmail.com>
6026 A fix for bug #358374
6027 * cs-parser.jay: Correctly set modifiers for all constructor types.
6029 2008-02-04 Marek Safar <marek.safar@gmail.com>
6031 A fix for bug #355251
6032 * generic.cs: Added base class constraint based type inference.
6034 2008-02-01 Marek Safar <marek.safar@gmail.com>
6036 A fix for bug #357255
6037 * decl.cs: One more missing visibility check.
6039 2008-02-01 Marek Safar <marek.safar@gmail.com>
6041 * support.cs: Fixed broken return.
6043 2008-01-25 Marek Safar <marek.safar@gmail.com>
6045 * report.cs: Correctly reset warnings count after probing.
6047 2008-01-25 Martin Baulig <martin@ximian.com>
6050 (NamespaceEntry.SymbolFileID): Make this work again after
6051 MemberName.ToString() is gone.
6053 2008-01-25 Marek Safar <marek.safar@gmail.com>
6055 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
6058 2008-01-25 Marek Safar <marek.safar@gmail.com>
6060 * generic.cs: Use full implicit conversion for type inference fixing.
6062 2008-01-24 Marek Safar <marek.safar@gmail.com>
6064 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
6065 Fixed user operator conversions.
6067 2008-01-24 Marek Safar <marek.safar@gmail.com>
6069 * generic.cs: Do nullable type to null comparison optimization during
6072 2008-01-24 Marek Safar <marek.safar@gmail.com>
6074 A fix for bug #355163
6075 * generic.cs: Enabled l-value resolve on nullable expressions.
6077 2008-01-24 Marek Safar <marek.safar@gmail.com>
6079 A fix for bug #353986
6080 * class.cs: Ingore static ctors with parameters for any further checks.
6082 2008-01-24 Marek Safar <marek.safar@gmail.com>
6084 A fix for bug #354310
6085 * namespace.cs: Removed redundant check.
6087 2008-01-24 Marek Safar <marek.safar@gmail.com>
6089 A fix for bug #354928
6090 * expression.cs: ElementInitializers can be resolved only once.
6092 2008-01-24 Marek Safar <marek.safar@gmail.com>
6094 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
6095 Condition expressions.
6097 2008-01-23 Marek Safar <marek.safar@gmail.com>
6099 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
6101 2008-01-22 Marek Safar <marek.safar@gmail.com>
6103 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
6106 * generic.cs: Implemented coalesce expression.
6108 2008-01-22 Marek Safar <marek.safar@gmail.com>
6110 A fix for bug #355145
6111 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
6112 expression tree type inference.
6114 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
6117 * expression.cs (Binary.IsUnsignedType): Fix typo.
6119 2008-01-22 Marek Safar <marek.safar@gmail.com>
6121 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
6123 2008-01-22 Marek Safar <marek.safar@gmail.com>
6125 A fix for bug #355161
6126 * ecore.cs, expression.cs: Wider range of extension method supported
6129 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
6131 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
6132 AssemblyBuilder to operate in compiler context. Fixes mcs part of
6135 2008-01-22 Marek Safar <marek.safar@gmail.com>
6137 A fix for bug #355148
6138 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
6140 2008-01-22 Miguel de Icaza <miguel@novell.com>
6142 * expression.cs (CreateExpressionTree): Add support for or and
6143 logical or, and indent following the coding conventions.
6145 * typemanager.cs (LinqExpression): renamed from
6146 ExpressionTreeManager, for a shorter name.
6148 Use TypeManager.CoreLookupType to lookup types from our core
6149 assemblies and turn those into "Type" variables.
6151 Consumers that previously used "Namespace" and "Type" from this
6152 class should instead use the TypeExpression which is a type that
6153 is fully resolved (without involving the regular C# resolution
6156 This typically looks like this:
6158 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
6159 new MemberAccess (texpr, name, type_arguments, loc)
6161 This avoids the problem in: #355178
6163 2008-01-21 Marek Safar <marek.safar@gmail.com>
6165 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
6166 feature in parser only as we do in other cases.
6168 2008-01-21 Marek Safar <marek.safar@gmail.com>
6170 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
6171 typemanager.cs: A refactoring of params arguments to reuse existing
6172 expressions (params -> array initializer) to emit params argument instead
6173 of specialized handling.
6174 It was required by expression tree implementation and it has other benefits
6175 as well, we now apply same optimization for params arguments as we do for
6178 2008-01-18 Marek Safar <marek.safar@gmail.com>
6180 A fix for bug #353526
6181 * generic.cs: A type inference of params arguments may not required any
6182 temporary array creation.
6184 2008-01-18 Marek Safar <marek.safar@gmail.com>
6186 A fix for bug #353534
6187 * generic.cs, ecore.cs, expression.cs: A method group type inference is
6188 supported for delegates only.
6190 2008-01-18 Marek Safar <marek.safar@gmail.com>
6192 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
6193 type for more than 1 candidates.
6195 2008-01-18 Marek Safar <marek.safar@gmail.com>
6197 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
6200 2008-01-16 Marek Safar <marek.safar@gmail.com>
6202 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
6203 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
6204 operator) expressions.
6206 2008-01-16 Zoltan Varga <vargaz@gmail.com>
6208 * statement.cs: Avoid declaring an IL variable for this_variable since it is
6209 not accessed from the generated IL.
6211 2008-01-14 Marek Safar <marek.safar@gmail.com>
6213 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
6214 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
6215 statement.cs: The first expression tree implementation drop, mostly
6216 infrastructure work.
6218 2008-01-14 Marek Safar <marek.safar@gmail.com>
6220 * ecore.cs (IsNestedChild): Refactored.
6222 2008-01-11 Marek Safar <marek.safar@gmail.com>
6224 * lambda.cs: Don't use a cast on unknown expression statement.
6226 2008-01-10 Geoff Norton <gnorton@novell.com>
6228 * cs-tokenizer.cs: One more token to distinguish between method and lambda
6231 2008-01-09 Marek Safar <marek.safar@gmail.com>
6233 * doc.cs: Report better /doc crash details.
6235 2008-01-09 Marek Safar <marek.safar@gmail.com>
6237 A fix for bug #352536
6238 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
6240 2008-01-08 Marek Safar <marek.safar@gmail.com>
6242 A fix for bug #352287
6243 * ecore.cs, expression.cs: Do `this' access checking in all member access
6246 2008-01-08 Marek Safar <marek.safar@gmail.com>
6248 * rootcontext.cs, driver.cs: Switch to linq mode by default.
6250 * report.cs: Reset message stacks.
6252 2008-01-08 Marek Safar <marek.safar@gmail.com>
6254 * generic.cs (InferInPhases): Correctly calculate params position.
6256 2008-01-08 Marek Safar <marek.safar@gmail.com>
6258 * cs-tokenizer.cs: No need to parse full string when parsing lambda
6261 2008-01-07 Marek Safar <marek.safar@gmail.com>
6263 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
6265 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
6267 * driver.cs: Updated --help option.
6269 2008-01-07 Marek Safar <marek.safar@gmail.com>
6271 * generic.cs (InferParamsTypeArguments): Removed.
6272 (InferInPhases): Add params type inference.
6273 (LowerBoundInference): Fixed scoring mechanism.
6275 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
6277 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
6279 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
6280 byte array for unsigned "baked" assemblies.
6282 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
6284 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
6285 array for assemblies that are not strongnamed.
6287 2008-01-04 Marek Safar <marek.safar@gmail.com>
6289 A fix for bug #351481
6290 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
6291 declaring type for nested generic types.
6293 2008-01-04 Marek Safar <marek.safar@gmail.com>
6295 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
6296 instead of ToString.
6298 2008-01-03 Marek Safar <marek.safar@gmail.com>
6300 A fix for bug #351047
6301 * expression.cs (Binary.ResolveOperator): Allow equality operators between
6302 null and structs only when equality and inequality operators are defined
6303 either as an user-operators or predefined operators.
6305 2008-01-03 Marek Safar <marek.safar@gmail.com>
6307 A fix for bug #351047
6308 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
6310 2008-01-03 Marek Safar <marek.safar@gmail.com>
6312 A fix for bug #351257
6313 * cs-tokenizer.cs: Advance line number for '\r' correctly.
6315 2008-01-03 Marek Safar <marek.safar@gmail.com>
6317 A fix for bug #351157
6318 * class.cs (Using): Fixed yet another broken cloning.
6320 (Block): Put back more sensible default value for statements.
6322 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
6324 * codegen.cs: Allow AssemblyVersion with only major version component.
6327 2007-12-29 Marek Safar <marek.safar@gmail.com>
6329 A fix for bug #324654
6330 * class.cs: Use FullName property as member name.
6332 2007-12-28 Marek Safar <marek.safar@gmail.com>
6334 A fix for bug #342117
6335 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
6336 constructor constraint.
6338 2007-12-28 Marek Safar <marek.safar@gmail.com>
6340 A fix for bug #338273
6341 * class.cs (ProbertyBase): Access modifier checks are required for overrides
6344 2007-12-28 Marek Safar <marek.safar@gmail.com>
6346 A fix for bug #350839
6347 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
6349 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6351 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6354 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6356 * statement.cs: Changed some Hashtables to use HybridDictionaries
6357 instead. It was observed that some HashTables only contained a few
6358 items in the vast majority of cases. Since HybridDictionary is
6359 more efficient on small sets (<10 elements), "known_variables"
6360 from class ExplicitBlock as well as "labels" and "constants " from
6361 class Block were changed to HybridDictionaries.
6363 Atsai results: (56216kb->54987kb)
6365 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
6368 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6370 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6373 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6375 * expression.cs: foreach loop to for loop, saved on allocation of
6376 enumerator (59333kb->59141kb)
6378 * statement.cs. Changed foreach loops to for loops, saved on
6379 allocation of enumerator (59141kb->59006kb)
6381 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
6382 when constructed with no specified capacity. This was causing a
6383 few ArrayLists to allocate more memory than they would potentially
6384 need in the Block class and MemberCache class. Setting the
6385 ArrayLists to construct with a capacity of 1 saves some
6386 memory. (56216kb->55585kb)
6388 2007-12-27 Marek Safar <marek.safar@gmail.com>
6390 A fix for bug #347189 (2nd issue)
6391 * expression.cs (MemberAccess): Nested type can be found in base non-generic
6394 2007-12-27 Miguel de Icaza <miguel@novell.com>
6396 * report.cs: Do not use colors if stdout and stderr are not a
6399 2007-12-27 Marek Safar <marek.safar@gmail.com>
6401 A fix for bug #346998
6402 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
6405 2007-12-27 Marek Safar <marek.safar@gmail.com>
6407 A fix for bug #343465
6408 * class.cs: Explicit method name for nested types uses dots only.
6410 2007-12-27 Marek Safar <marek.safar@gmail.com>
6412 A fix for bug #343707
6413 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
6415 2007-12-27 Marek Safar <marek.safar@gmail.com>
6417 * ecore.cs: Report type inference errors only when arguments count matches
6420 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
6422 * expression.cs, report.cs: New warning.
6424 * typemanager.cs: Catch anonymous method type too.
6426 2007-12-23 Marek Safar <marek.safar@gmail.com>
6428 A fix for bug #346379
6429 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
6431 2007-12-23 Marek Safar <marek.safar@gmail.com>
6433 A fix for bug #347359
6434 * expression.cs (Invocation): Don't resolve already resolved expression.
6436 2007-12-23 Marek Safar <marek.safar@gmail.com>
6438 A fix for bug #347189
6439 * class.cs (FixedField): Use non-dependent code only in the define phase.
6441 2007-12-23 Marek Safar <marek.safar@gmail.com>
6443 A fix for bug #348076
6444 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
6446 2007-12-22 Marek Safar <marek.safar@gmail.com>
6448 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
6449 discovered extension methods.
6451 2007-12-22 Marek Safar <marek.safar@gmail.com>
6453 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
6456 2007-12-21 Miguel de Icaza <miguel@novell.com>
6458 * report.cs (ErrorMessage): Add support for using colors on
6459 terminals that support it.
6461 2007-12-21 Marek Safar <marek.safar@gmail.com>
6463 * ecore.cs: Use information about expanded params for error reporting.
6465 2007-12-21 Marek Safar <marek.safar@gmail.com>
6467 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
6468 and logic for params overloads.
6470 2007-12-15 Miguel de Icaza <miguel@novell.com>
6472 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
6473 as this is also created from the parser. Fixes #349034
6475 2007-12-12 Miguel de Icaza <miguel@novell.com>
6477 * statement.cs (Throw.CloneTo): it is valid to have empty
6478 expressions for throw.
6480 2007-12-03 Marek Safar <marek.safar@gmail.com>
6482 * cs-parser.jay: Set delegate constraint parsing region correctly.
6484 2007-12-03 Marek Safar <marek.safar@gmail.com>
6486 A fix for bug #345467
6487 * typemanager.cs (IsEqual): Compare generic parameters position only.
6489 2007-11-28 Marek Safar <marek.safar@gmail.com>
6491 * expression.cs (BaseAccess): Type arguments can be null.
6493 2007-11-27 Raja R Harinath <harinath@gmail.com>
6495 * statement.cs (Block.Resolve): Ensure flow-branching tree is
6496 consistent even when an error has occured.
6497 (Switch.Resolve): Likewise.
6499 2007-11-22 Marek Safar <marek.safar@gmail.com>
6501 A fix for bug #334505
6502 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
6505 2007-11-22 Marek Safar <marek.safar@gmail.com>
6507 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
6508 refactorings required to resolve extension methods correctly when mixing
6509 generics and non-generics members.
6511 2007-11-20 Marek Safar <marek.safar@gmail.com>
6513 A fix for bug #342584
6514 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
6517 2007-11-19 Marek Safar <marek.safar@gmail.com>
6519 A fix for bug #342512
6520 * delegate.cs: Use delegate argument expression when is available. Don't
6521 emit virtual call when class is sealed.
6523 2007-11-16 Marek Safar <marek.safar@gmail.com>
6525 A fix for bug #325423
6526 * assign.cs (FieldInitializer): Use resolved expression for emit.
6528 * class.cs: Print less confusing error message.
6530 2007-11-16 Marek Safar <marek.safar@gmail.com>
6532 * cs-tokenizer.cs: Removed GMCS ifdefs.
6534 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
6537 * cs-parser.jay: Disabled nullable check.
6539 * generic-mcs: Copied more generic stuff.
6541 2007-11-16 Marek Safar <marek.safar@gmail.com>
6543 * gcs-parser.jay: Merged to cs-parser.jay.
6545 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6546 * *.csproj, *.sources: Updated to use only jay parser file.
6548 2007-11-16 Marek Safar <marek.safar@gmail.com>
6550 * gcs-parser.jay: Added nullable and default expression feature checks.
6552 2007-11-16 Marek Safar <marek.safar@gmail.com>
6554 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6555 it fixes many TODOs and hidden bugs.
6557 * expression: Removed duplicate error check.
6559 2007-11-15 Marek Safar <marek.safar@gmail.com>
6561 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6562 implicitly type local variable only when it is used in a declaration.
6564 2007-11-15 Marek Safar <marek.safar@gmail.com>
6566 * attribute.cs: Use CS0612 for empty strings.
6568 2007-11-14 Marek Safar <marek.safar@gmail.com>
6570 * lambda.cs, statement.cs: Contextual return may act as a statement.
6572 2007-11-14 Marek Safar <marek.safar@gmail.com>
6574 A fix for a regression cause by #324222
6575 * class.cs: Don't report unused even when it implements an interface.
6577 2007-11-13 Marek Safar <marek.safar@gmail.com>
6579 A fix for bug #341205
6580 * ecore.cs, expression.cs: Method group expression cannot do static
6581 method access with an instance reference check before overloading takes
6584 2007-11-13 Marek Safar <marek.safar@gmail.com>
6586 A fix for bug #325359
6587 * class.cs: Use predictable name for automatically generated property.
6589 2007-11-12 Marek Safar <marek.safar@gmail.com>
6591 A fix for bug #324996
6592 * expression.cs (Is): Handle case where D is nullable and T is not
6595 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6597 2007-11-12 Marek Safar <marek.safar@gmail.com>
6599 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6600 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6601 Flush small error reporting changes.
6603 2007-11-09 Marek Safar <marek.safar@gmail.com>
6605 A fix for bug #324996
6606 * expression.cs: Rewrote Is expression implementation to work with
6607 generics, nullable types, anonymous method. A const result expression
6608 uses existing infrastructure instead of custom not fully-featured one.
6610 2007-11-08 Marek Safar <marek.safar@gmail.com>
6612 A fix for bug #340202
6613 * class.cs: Consider generics for volatile field.
6615 2007-11-08 Marek Safar <marek.safar@gmail.com>
6617 A fix for bug #335594
6618 * expression.cs: Use conversion rules when handling string addition.
6620 2007-11-07 Marek Safar <marek.safar@gmail.com>
6622 A fix for bug #336651
6623 * expression.cs: Fixed a crash when probing is on.
6625 2007-11-07 Marek Safar <marek.safar@gmail.com>
6627 A fix for bug #324242
6628 * covert.cs: Added a conversion from any nullable-type with an
6629 underlying enum-type to the type System.Enum.
6631 2007-11-07 Marek Safar <marek.safar@gmail.com>
6633 A fix for bug #324222
6634 * class.cs: Report all non-used event fields.
6636 2007-11-07 Marek Safar <marek.safar@gmail.com>
6638 A fix for bug #325161
6639 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6640 qualifier for generic types.
6642 2007-11-07 Marek Safar <marek.safar@gmail.com>
6644 A fix for bug #322971
6645 * expression.cs, ecore.cs: Added intermediate result value check for
6648 2007-11-07 Marek Safar <marek.safar@gmail.com>
6650 A fix for bug #324754
6651 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6652 when it was requested.
6654 2007-11-07 Marek Safar <marek.safar@gmail.com>
6656 A fix for bug #325101
6657 * expression.cs: Do type not value comparison for `is' expression.
6659 2007-11-07 Marek Safar <marek.safar@gmail.com>
6661 A fix for bug #320236
6662 * convert.cs: Don't apply user conversion on underlying target type.
6664 2007-11-06 Marek Safar <marek.safar@gmail.com>
6666 * expression.cs: Don't use unresolved expression for error reporting.
6668 2007-11-06 Marek Safar <marek.safar@gmail.com>
6670 A fix for bugs #337712, #324490
6671 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6672 overloading resolution too.
6674 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6675 the process consistent and more robust.
6677 * expression.cs, linq.cs, report.cs: Update.
6679 2007-11-02 Marek Safar <marek.safar@gmail.com>
6681 A fix for bug #332909
6682 * attribute.cs: Resolve attributes in correct context using error
6685 * rootcontext.cs: Define Obsolete attribute members as core members.
6687 2007-11-02 Marek Safar <marek.safar@gmail.com>
6689 * statement.cs: Removed unused methods.
6691 2007-10-31 Wade Berrier <wberrier@novell.com>
6693 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6694 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6697 2007-10-31 Marek Safar <marek.safar@gmail.com>
6699 A fix for bug #338102
6700 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6701 methods registered as non-generics.
6703 2007-10-31 Marek Safar <marek.safar@gmail.com>
6705 A fix for bugs #337712, #324490
6706 * delegate.cs: Delegate covariance and contravariance is not allowed for
6709 2007-10-31 Marek Safar <marek.safar@gmail.com>
6711 A fix for bug #337719
6712 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6715 2007-10-30 Marek Safar <marek.safar@gmail.com>
6717 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6719 2007-10-29 Marek Safar <marek.safar@gmail.com>
6721 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6724 2007-10-29 Raja R Harinath <rharinath@novell.com>
6726 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6728 2007-10-29 Marek Safar <marek.safar@gmail.com>
6730 A fix for bug #334652
6731 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6732 extension methods when we have not found the best candidate in normal
6735 2007-10-27 Marek Safar <marek.safar@gmail.com>
6737 * AssemblyInfo.cs: Keep up-to-date.
6739 2007-10-27 Marek Safar <marek.safar@gmail.com>
6741 * Makefile: Fixed generics compiler name.
6743 2007-10-27 Marek Safar <marek.safar@gmail.com>
6745 * lambda.test: removed, lambda parsing is done differently.
6747 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6749 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6751 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6753 2007-10-27 Marek Safar <marek.safar@gmail.com>
6755 * Makefile, *.sources : All C# compilers are in mcs folder.
6757 * *.cs: Use existing 2_1 define for smcs.
6759 2007-10-26 Marek Safar <marek.safar@gmail.com>
6761 A fix for bug #335847
6762 * assign.cs, expression.cs: Couple of changes to avoid creating a
6763 temporary variable for each object initializer assignment statement. It
6764 simplifies struct initialization too, otherwise two temporary variables
6766 Implemented optimization of redundant default element initializers.
6768 2007-10-25 Marek Safar <marek.safar@gmail.com>
6770 A fix for bug #336766
6771 * expression.cs (Class.CheckBase): Use generic name when method is
6774 2007-10-25 Marek Safar <marek.safar@gmail.com>
6776 A fix for bug #334737
6777 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6778 variable and not variable argument for prepared copies.
6780 2007-10-24 Marek Safar <marek.safar@gmail.com>
6782 A fix for bug #325110
6783 * class.cs, expression.cs, attribute.cs: Use open generic method when
6784 checking conditional attribute.
6786 2007-10-24 Marek Safar <marek.safar@gmail.com>
6788 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6789 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6790 FeatureIsNotAvailable.
6792 2007-10-24 Marek Safar <marek.safar@gmail.com>
6794 ** C# 3.0 Partial methods
6796 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6797 methods support. Because of member cache issue with generics only
6798 non-generics partial methods are fully supported.
6800 2007-10-23 Marek Safar <marek.safar@gmail.com>
6802 * class.cs, decl.cs: Rewrote member overloads check to cope with
6803 generics and to use member cache for member checking. It also improves
6804 performance and fixes remaining overloads issues.
6806 2007-10-20 Marek Safar <marek.safar@gmail.com>
6808 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6809 roottypes.cs, typemanager.cs:
6811 A member cache creation logic changed to add members immediately and
6812 not rely on fallback. The member cache is now only prefered way
6813 how to access and find type declaration members. It saves 5 MB of memory
6814 during MWF compilation and makes code ready for more optimizations and
6815 clean-ups, it's also a pre-requirement for partial methods.
6817 2007-10-18 Raja R Harinath <harinath@gmail.com>
6819 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6820 handling for generic parameters.
6822 2007-10-15 Marek Safar <marek.safar@gmail.com>
6824 * class.cs (FixedField): Removed redundant volatile check.
6826 2007-10-15 Marek Safar <marek.safar@gmail.com>
6828 * class.cs, decl.cs: Fixed overload members verification to do only one
6829 check per possible collision.
6831 2007-10-13 Marek Safar <marek.safar@gmail.com>
6833 A fix for bug #325478
6834 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6835 and create only one disposable flags container.
6837 2007-10-12 Marek Safar <marek.safar@gmail.com>
6839 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6840 * statement.cs (Fixed): Fixed variables cloning.
6842 2007-10-12 Marek Safar <marek.safar@gmail.com>
6844 A fix for bug #333342
6845 * class.cs (EventField): Don't mark value type event as synchronized.
6847 2007-10-12 Marek Safar <marek.safar@gmail.com>
6849 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6850 inference to identify best candidate method correctly.
6851 (ProperyExpr): A range variable is read only and cannot be modified.
6853 2007-10-11 Marek Safar <marek.safar@gmail.com>
6855 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6856 logic to identify best candidate method correctly.
6858 2007-10-11 Marek Safar <marek.safar@gmail.com>
6860 * location.cs (Equals, GetHashCode): Removed.
6862 2007-10-11 Marek Safar <marek.safar@gmail.com>
6864 * report.cs: Implemented message recorder. It is used mainly for lambda
6865 expressions to capture otherwise swallowed error messages.
6867 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6869 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6871 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6873 * expression.cs (MemberAccess): Always report lookup failure.
6875 * location.cs: Implemented Equals, GetHashCode.
6877 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6879 2007-10-10 Jb Evain <jbevain@novell.com>
6881 * codegen.cs: re-enable assembly version check.
6883 2007-10-09 Marek Safar <marek.safar@gmail.com>
6885 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6888 * namespace.cs (UsingAlias): Do correct version check.
6890 2007-10-08 Marek Safar <marek.safar@gmail.com>
6892 * expresison.cs, ecore.cs: Issue extension method error message when
6895 * rootcontext.cs: Added ISO_2 compiler mode option.
6897 2007-10-08 Marek Safar <marek.safar@gmail.com>
6899 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6902 2007-10-08 Marek Safar <marek.safar@gmail.com>
6904 * attribute.cs (GetString, GetBoolean): Work with both literal and
6907 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6908 Moved method overload specific methods to MethodGroupExpr.
6910 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6911 it should be less memory consuming.
6913 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6915 * codegen.cs: remove the assembly version check until the buildbot is
6918 2007-10-07 Jb Evain <jbevain@novell.com>
6920 * attribute.cs (Attribute.GetString): if the value
6921 expression is a StringConstant, return its string value.
6923 2007-10-07 Jb Evain <jbevain@novell.com>
6925 * typemanager.cs: add `assembly_version_attribute_type`.
6926 * codegen.cs: on attribute emission, check that the
6927 AssemblyVersionAttribute doesn't overflow.
6929 2007-10-05 Marek Safar <marek.safar@gmail.com>
6931 A fix for bug #324677
6932 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6933 parent container of a scope container with currently resolved one.
6935 2007-10-05 Marek Safar <marek.safar@gmail.com>
6937 A fix for bug #325534
6938 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6941 2007-10-05 Marek Safar <marek.safar@gmail.com>
6943 A fix for bug #327504
6944 * class.cs (Operator.Define): Refactored implicit and explicit user
6945 operator conversion rules.
6947 2007-10-05 Marek Safar <marek.safar@gmail.com>
6949 A fix for bug #327520
6950 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6952 2007-10-04 Marek Safar <marek.safar@gmail.com>
6954 A fix for bug #328022
6955 * class.cs (MethodData.Define): Use correct method to check whether
6956 a method implementents an accessor.
6958 2007-10-04 Marek Safar <marek.safar@gmail.com>
6960 A fix for bug #330069
6961 * statement.cs (Fixed.Resolve): Read the first array element only when
6962 an array is instantiated.
6964 2007-10-04 Marek Safar <marek.safar@gmail.com>
6966 * expression.cs, assign.cs, generics.cs: Print correct operator when
6967 compound assignment is used.
6969 2007-10-04 Marek Safar <marek.safar@gmail.com>
6971 A fix for bug #325841
6972 * expression.cs (ArrayAccess): Use full argument cloning only for
6973 string compound concatenation.
6975 2007-10-03 Marek Safar <marek.safar@gmail.com>
6977 A fix for bug #328774
6978 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6980 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6983 2007-10-03 Raja R Harinath <rharinath@novell.com>
6986 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6987 Event accessibility checks here. Remove some bogus code that
6988 accidently made GenericMethods work.
6989 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6991 2007-09-25 Marek Safar <marek.safar@gmail.com>
6993 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6995 * statement.cs (Block): Refactored AddVariable to allow error handling
6998 * generic.cs: New stub.
7000 2007-09-23 Marek Safar <marek.safar@gmail.com>
7002 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
7005 2007-09-17 Marek Safar <marek.safar@gmail.com>
7007 * class.cs: Use partial container to record whether any partial part
7008 contains static field initializer and therefore default contructor has
7011 2007-09-14 Marek Safar <marek.safar@gmail.com>
7013 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
7014 mono-list when only one of two partial parts has defined accessibility
7017 2007-09-14 Marek Safar <marek.safar@gmail.com>
7019 A fix for bug #82845
7021 * class.cs (TypeContainer): Set correct resolve context for all field
7024 2007-09-13 Marek Safar <marek.safar@gmail.com>
7026 * assign.cs: Fixed a crash when field is resolved twice with an error.
7028 * codegen.cs: Changed InFieldInitializer to be flag.
7030 * anonymous.cs, ecore.cs, expression.cs: Update after
7031 IsInFieldInitializer rename.
7033 * const.cs: Removed unused parameter.
7035 * class.cs: Changed the way how we resolve and emit field initializers.
7036 The field initilizers have to have access to contructor block to emit
7037 compiler generated code.
7039 2007-09-13 Marek Safar <marek.safar@gmail.com>
7041 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
7042 generics use TypeContainer instead.
7044 2007-09-12 Marek Safar <marek.safar@gmail.com>
7046 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
7048 * lambda.cs (ResolveParameters): Use more powerful
7049 InflateGenericArgument.
7051 * parameters.cs: Better exception message.
7053 2007-09-10 Marek Safar <marek.safar@gmail.com>
7055 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
7056 correct expression block type.
7058 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
7060 * expression.cs (Invocation): Extracted method group resolve to
7063 2007-09-07 Marek Safar <marek.safar@gmail.com>
7065 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
7066 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
7068 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
7069 generic extension methods.
7071 2007-09-06 Marek Safar <marek.safar@gmail.com>
7073 A fix for bug #82676 (Do I get it right now?)
7074 * convert.cs (Binary.ResolveOperator): An interface is converted to the
7075 object before a standard conversion is applied.
7077 2007-09-06 Marek Safar <marek.safar@gmail.com>
7079 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
7082 2007-09-05 Marek Safar <marek.safar@gmail.com>
7084 A fix for bug #82676
7085 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
7086 non-generic interface types.
7088 2007-09-05 Marek Safar <marek.safar@gmail.com>
7090 A fix for bug #82690
7091 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
7093 2007-09-05 Marek Safar <marek.safar@gmail.com>
7095 A fix for bug #82571
7096 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
7097 modifier for container based methods.
7099 2007-09-05 Marek Safar <marek.safar@gmail.com>
7101 A fix for bug #82676
7102 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
7103 any interface-type T means to any of interface type T.
7105 2007-09-04 Marek Safar <marek.safar@gmail.com>
7107 * namespace.cs: We have 2 versions of System.Core assembly.
7109 2007-09-04 Marek Safar <marek.safar@gmail.com>
7111 A fix for bug #82652
7112 * class.cs (Class.GetClassBases): Compare types and not expressions.
7114 2007-09-04 Marek Safar <marek.safar@gmail.com>
7116 A fix for bug #82620
7117 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
7118 actually never worked before.
7119 (IndexerAccess): Emit prepared arguments before they are modified.
7121 2007-09-04 Marek Safar <marek.safar@gmail.com>
7123 A fix for bug #82563
7124 * assign.cs: Revert wrong fix.
7126 * expression.cs (VariableReference.EmitAssign): Handle ref reference
7128 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
7129 Instead of ldelema/stdind we have to use temporary variables to handle
7130 cases like String.Concat (params string[]).
7132 2007-08-31 Marek Safar <marek.safar@gmail.com>
7134 * class.cs: EmitAttributes to Emit rename.
7136 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
7138 (MemberCore.HasClsCompliantAttribute): Don't depend on
7139 GetClsCompliantAttributeValue execution.
7141 2007-08-31 Marek Safar <marek.safar@gmail.com>
7143 * anonymous.cs: Use shorter type prefix.
7145 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
7148 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
7149 variables when probing is on.
7151 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
7152 unresolved variables.
7153 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
7154 handle transparent identifiers.
7156 2007-08-26 Marek Safar <marek.safar@gmail.com>
7158 * attribute.cs (IsClsCompliant): Add nullable types test.
7160 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
7162 * doc.cs : catch other types of exception than XmlException to
7163 report CS1570. Fixed bug #82565.
7165 2007-08-23 Marek Safar <marek.safar@gmail.com>
7167 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
7168 The number of delegate parameters has to match.
7169 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
7172 2007-08-21 Marek Safar <marek.safar@gmail.com>
7174 * anonymous.cs (AnonymousMethod): Generate private anonymous method
7175 to fix problem with private arguments.
7177 2007-08-20 Marek Safar <marek.safar@gmail.com>
7179 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
7181 * decl.cs (MemberName): Ignore generic type with no generic arguments.
7183 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
7184 empty. Add cloning suport.
7186 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
7188 2007-08-20 Marek Safar <marek.safar@gmail.com>
7190 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
7191 to create EmptyCast. It handles EmptyConstantCast specialization for
7194 2007-08-18 Marek Safar <marek.safar@gmail.com>
7196 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
7197 (EmitArrayArgument): One routine for array arguments.
7198 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
7200 2007-08-17 Marek Safar <marek.safar@gmail.com>
7202 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
7204 2007-08-17 Marek Safar <marek.safar@gmail.com>
7206 * anonymous.cs: MemberLookupFinal update.
7208 * class.cs (ConstructorInitializer): Is expression based.
7210 * delegate.cs: MethodGroupExpr update.
7212 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
7214 (Error_MemberLookupFailed): Customizable error override.
7215 (MethodGroupExpr): Keep queried type for later usage.
7216 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
7219 * expression.cs: Error_MemberLookupFailed refactoring.
7220 (New.DoResolve): Resolve as much as possible.
7221 (ElementInitializer.Error_MemberLookupFailed): Object initializer
7222 customization for invalid member types.
7224 * statement.cs: MethodGroupExpr update.
7226 2007-08-16 Marek Safar <marek.safar@gmail.com>
7228 * modifier.cs (Check): Check all modifiers and not only accessibility
7231 2007-08-16 Marek Safar <marek.safar@gmail.com>
7233 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
7234 type and not an expression.
7236 2007-08-16 Marek Safar <marek.safar@gmail.com>
7238 * statement.cs (Catch.Clone): Type and variable can be null.
7240 2007-08-16 Marek Safar <marek.safar@gmail.com>
7242 A fix for bug #81979
7243 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
7244 I am really not sure whether this is the best fix.
7246 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
7249 2007-08-14 Marek Safar <marek.safar@gmail.com>
7251 ** C# 3.0 Object and collection initializers (major re-write)
7253 * assign.cs (DoResolve): Initializers are not assign related.
7255 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
7256 used during collection or object initialization.
7258 * expression.cs (Error_InvalidArguments): Add initializers specific
7259 messages. More will come later because it requires some general
7261 (New.DoResolve): Better error handling for unsafe types.
7262 (EmptyExpressionStatement): New class.
7263 (ElementInitializer): An object initializer expression.
7264 (CollectionElementInitializer): A collection initializer expression.
7265 (CollectionOrObjectInitializers): A block of object or collection
7267 (NewInitialize): New expression with element/object initializers.
7269 * statement.cs: Reverted object/collection initializer hacks.
7271 * typemanager.cs (CSharpName): Filter __arglist type.
7273 2007-08-09 Marek Safar <marek.safar@gmail.com>
7275 ** C# 3.0 Anonymous Types (update to the latest standard)
7277 * expression.cs (Binary.ResolveOperator): Threat all null based types
7279 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
7280 (AnonymousTypeParameter): Updated.
7282 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
7283 (AnonymousTypeClass): New anonymous type container.
7285 * class.cs (AddField): Return operation result.
7287 * generic.cs: Another empty TypeArguments overload.
7289 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
7290 are stored at top of normal hierarchy.
7292 * typemanager.cs (CSharpName): Filter anonymous types.
7294 2007-08-09 Marek Safar <marek.safar@gmail.com>
7296 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
7297 as single Concat call. How could we miss that :-(
7299 2007-08-08 Marek Safar <marek.safar@gmail.com>
7301 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
7303 2007-08-07 Miguel de Icaza <miguel@novell.com>
7305 * expression.cs: Fix the previous commit, the creation of the
7306 arguments array list needs also to be conditional on the arguments
7309 * class.cs: Add a little bit of help to help narrow down problems.
7311 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
7312 not try to copy in that case.
7314 * driver.cs: When building SMCS, include a new different set of
7315 default assemblies here. Do this here so we can control whether
7316 to include the default assemblies with /noconfig.
7318 2007-08-03 Marek Safar <marek.safar@gmail.com>
7320 A fix for bug #81979
7321 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
7324 2007-08-03 Marek Safar <marek.safar@gmail.com>
7326 A fix for bug #82300
7328 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
7329 we are in probing scope.
7331 2007-08-03 Marek Safar <marek.safar@gmail.com>
7333 A fix for bug #82301
7335 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
7336 (Statement.CloneTo): Clone and not map children blocks.
7338 2007-08-03 Marek Safar <marek.safar@gmail.com>
7340 A fix for bug #82299
7342 * expression.cs (LocalVariableReference.CloneTo): Remap local info
7345 * statement.cs (Statement.CloneTo): Clone variables before statements
7346 to allow remaping of local variables.
7348 2007-08-03 Marek Safar <marek.safar@gmail.com>
7350 A fix for bug #82296
7353 * report.cs: Log crash details for future clone problems.
7355 * statement.cs (Return.Clone): Don't clone non-existent expression.
7357 2007-08-03 Raja R Harinath <harinath@gmail.com>
7359 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
7360 (Class.AddBasesForPart): Move CS0537 check here from ...
7361 * cs-parser.jay (class_declaration): ... here. Move calling of
7362 'AddBasesForPart' to ...
7363 (class_bases): ... here.
7364 (struct_declaration, interface_declaration): Update to changes.
7366 2007-08-02 Marek Safar <marek.safar@gmail.com>
7368 A fix for bug #81923
7370 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
7371 conversion is allowed.
7373 2007-08-02 Marek Safar <marek.safar@gmail.com>
7375 A fix for bug #81564
7377 * ecore.cs (EventExpr): Add IsBase handling.
7379 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
7382 2007-08-02 Raja R Harinath <harinath@gmail.com>
7384 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
7385 * cs-parser.jay: Some whitespace cleanups.
7386 (current_delegate): New.
7388 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
7389 a dummy code block, and use 'type_name' instead of 'member_name'.
7390 (interface_declaration, class_declaration): Likewise.
7391 (delegate_declaration): Likewise. Rearrange slightly and use
7393 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
7394 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
7396 2007-08-02 Marek Safar <marek.safar@gmail.com>
7398 A fix for bug #82039
7400 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
7403 * typemanager.cs (CSharpName): Split to string overload.
7405 2007-08-02 Marek Safar <marek.safar@gmail.com>
7408 * report.cs: Updated warning CS0472.
7410 2007-08-01 Marek Safar <marek.safar@gmail.com>
7412 A fix for bug #82181
7414 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
7416 2007-08-01 Marek Safar <marek.safar@gmail.com>
7418 A fix for bug #82277
7419 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
7421 2007-08-01 Marek Safar <marek.safar@gmail.com>
7423 ** C# 3.0 Type Inference (major bits are working)
7425 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
7426 (.ImplicitStandardConversionExists): Uses compatible.
7427 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
7428 (.InferReturnType): New method.
7429 (.Compatible): Refactored.
7430 (.ResolveParameters): Uses factory to create resolved parameters.
7431 (.CompatibleMethod): Add probing mode support.
7432 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
7433 clearly distinguish between 2 different operations.
7434 (LambdaMethod): Moved to lambda.cs.
7435 (AnonymousMethod): Removed unused fields and methods.
7436 (AnonymousDelegate): Simplified.
7438 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
7440 * convert. cs (ImplicitConversionStandard): Compatible works differently.
7442 * delegate.cs (Delegate): New mehods to reduce code duplication.
7443 (.GetConstructor): New method.
7444 (.GetInvokeMethod): New method.
7445 (DelegateCreation): Updated.
7447 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
7449 (OverloadResolve): Made probing little bit faster.
7451 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
7454 * generic.cs (TypeInferenceContext): Dummy implementation.
7456 * iterators.cs: Updated after Resolve/Define rename.
7458 * lambda.cs (LambdaExpression)
7459 (.ResolveParameters): Handles both type of arguments and type inference too.
7461 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
7462 (InflateTypes): Updated.
7464 * support.cs (InflateTypes): Changed signature and updated.
7466 * typemanager.cs (LookupMemberCache): Better dynamic type check.
7467 (MemberLookup_FindMembers): More MS tricks.
7468 (GetParameterData): Ditto.
7469 (GetDelegateParameters): Uses quick path for dynamic types.
7471 2007-08-01 Marek Safar <marek.safar@gmail.com>
7473 * class.cs (MethodData.Define): EmitContext is required for generic stuff
7476 2007-07-31 Marek Safar <marek.safar@gmail.com>
7478 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
7481 2007-07-26 Jb Evain <jbevain@novell.com>
7483 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
7484 which takes a boolean 'report_errors', similar to the GetMethod.
7485 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
7486 in .net 2.1, do not report errors here.
7488 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
7489 System.Runtime.CompilerServices.RequiredAttributeAttribute and
7490 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
7493 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
7494 of the type InternalsVisibleToAttribute before the first call
7495 to CoreLookupType which is allowed to fail (third boolean parameter
7496 to true). Because, during the resolution for a type that is not
7497 immediately found, we try to check if the type is not defined in
7498 a friend assembly, and to do so, we need the
7499 InternalVisibleToAttribute.
7501 2007-07-23 Miguel de Icaza <miguel@novell.com>
7503 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
7504 feature that allows structs to be compared against null and inline
7505 the result as true or false.
7507 Notice that the same code is not permitted inside a generic block
7508 of code that would do:
7510 class Foo<T> where T : struct {
7517 It is only allowed if the type of T is not bound (no where
7518 clause). In my opinion, this CSC 2 behavior is broken but people
7519 seem to be using it (IronRuby does, a few bug reports on bugzilla
7520 have it and some people have complained about it).
7522 All of the users that depend on this behavior have code that is
7525 * report.cs (Warning, Error): make these take object arguments,
7526 not strings, as that allows us to take advantage of Format.
7528 2007-07-20 William Holmes <billholmes54@gmail.com>
7530 * decl.cs: Changed MemberName.CountTypeArguments to also check the
7531 Left member variable for the Count.
7532 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
7533 MemberName.CountTypeArguments to avoid a NRE.
7535 This code is contributed under the MIT X11 license
7537 2007-07-18 Marek Safar <marek.safar@gmail.com>
7539 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7541 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7543 * doc.cs : generic method arguments are written as ``x while generic
7544 type arguments are `x. Combined with the previous change, fixed bug
7547 2007-07-18 Raja R Harinath <rharinath@novell.com>
7550 * expression.cs (Binary.ResolveOperator): When converting
7551 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7553 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7555 * doc.cs : when T: or whatever x: is specified, it does not really
7556 check the doc comment's syntax correctness. Fixed bug #82006.
7558 2007-07-18 Marek Safar <marek.safar@gmail.com>
7560 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7561 LambdaExpression better.
7563 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7565 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7567 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7568 as it can be generated.
7570 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7573 * lambda.cs (LambdaExpression): Refactored to share same code with
7574 AnonymousMethodExpression.
7576 2007-07-17 Marek Safar <marek.safar@gmail.com>
7578 * anonymous.cs (MakeName): Include host name for easier debugging.
7579 (LambdaMethod): New class for lambda spcecific stuff.
7581 * attribute.cs: Set EmitContext return type.
7583 * class.cs: Set EmitContext return type.
7585 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7586 with null/void meaning.
7588 * iterators.cs (ContainerType): Implemented.
7590 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7592 * statement.cs (Return): Updated to lambda expressions.
7593 (Block.CloneTo): Parent can be null.
7595 2007-07-13 Marek Safar <marek.safar@gmail.com>
7597 A fix for bug #81917
7598 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7600 * class.cs (FixedField): Check whether field is in unsafe scope.
7602 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7603 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7605 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7608 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7610 2007-07-13 Marek Safar <marek.safar@gmail.com>
7612 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7613 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7616 2007-07-13 Marek Safar <marek.safar@gmail.com>
7618 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7620 2007-07-13 Marek Safar <marek.safar@gmail.com>
7622 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7623 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7625 * codegen.cs(EmitContext): Add ProbingMode flag.
7627 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7629 * driver.cs: For now set both warning values.
7631 * ecore.cs (SimpleName): Name is readonly.
7632 (MethodGroup.OverloadResolve): One quick path for probing.
7634 * expression.cs (Unary): Set Oper r/o.
7635 (Binary): Set Oper r/o.
7636 (ParameterReference): Set few instance variables as r/o.
7637 (ParameterReference.DoResolveBase): Don't capture aruments when
7639 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7640 (Arglist): arguments are private.
7641 (SizeOf): type is private and r/o.
7642 (MemberAccess): arguments are private.
7644 * report.cs: Enhanced reporting on/off capabilities.
7646 * lambda.cs: Uses ec.IsInProbingMode.
7647 (ContextualReturn): Derives from return.
7649 * rootcontext.cs: For now set both warning values.
7651 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7653 (Return.Resolve): Don't die immediately.
7654 (Block.Resolve): Speed-up probing.
7655 (Block.CloneTo): Clone only child blocks.
7657 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7659 * iterators.cs: reverted Miguel's latest change (r81925) as it
7660 breaks the build in System.
7662 2007-07-13 Miguel de Icaza <miguel@novell.com>
7664 * iterators.cs (Yield.CheckContext): Check for the iterator type
7665 also here as we can call into Yield even in codepaths that are not
7667 (MethodOrOperator is the only path that was checked).
7669 In addition to the standard check, use a more specific check for
7670 constructors to report a more verbose error.
7672 2007-07-12 Miguel de Icaza <miguel@novell.com>
7674 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7675 report the warning and continue
7677 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7678 values on the stack on the call to Emit. Use EmitStatement if
7679 possible, or using Emit + Pop if not possible. Fixes #82064
7681 2007-07-12 Raja R Harinath <rharinath@novell.com>
7683 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7684 avoid try...finally in some cases.
7686 2007-07-10 Marek Safar <marek.safar@gmail.com>
7688 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7690 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7691 instead of method. Re-use standard error handling.
7692 (ConstructorInitializer.Emit): Simplified.
7694 * delegate.cs: Updated after Invocation.EmitCall change.
7696 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7697 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7698 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7699 method and don't permanently changing input arguments.
7700 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7701 is resolved it has one of the candidates is the best one which is later
7702 used to emit. Removed a few unused method.
7703 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7705 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7706 (Binary.ResolveOperator): Ditto.
7707 (ConditionalLogicalOperator.DoResolve): Ditto.
7708 (Invocation): Uses method group.
7709 (Invocation.DoResolve): Simplified.
7710 (Invocation.EmitCall): Removed useless is_static.
7711 (Invocation.Emit): Delegate to method group.
7712 (Invocation.EmitStatement): Simplified.
7713 (New): Uses method group.
7714 (MemberAccess.DoResolve): Don't destroy original expression.
7716 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7718 2007-07-04 Marek Safar <marek.safar@gmail.com>
7720 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7723 * lambda.cs: Add custom error message type.
7725 2007-07-03 Marek Safar <marek.safar@gmail.com>
7727 * lambda.cs: Simplified little bit.
7729 * parameter.cs: Introduced ImplicitLambdaParameter.
7730 (Parameters.CreateFullyResolved): New factory instead of ctor.
7734 * delegate.cs: Updated parameter creation.
7736 2007-07-03 Marek Safar <marek.safar@gmail.com>
7738 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7741 * generic.cs: Synchronized with gmcs.
7743 2007-07-03 Marek Safar <marek.safar@gmail.com>
7745 * class.cs (Indexer): Check return type as soon as possible.
7747 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7750 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7752 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7754 * parameter.cs (Parameter): Use expression type when it is available.
7756 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7757 method modifier for the first parameter only.
7759 2007-06-24 Marek Safar <marek.safar@gmail.com>
7761 A fix for bug #81938
7762 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7764 * constant.cs: Tide up an exception message.
7766 2007-06-22 Marek Safar <marek.safar@gmail.com>
7768 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7769 an uninitialized variable is used.
7771 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7773 2007-06-22 Marek Safar <marek.safar@gmail.com>
7775 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7776 not found error handling.
7778 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7780 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7781 (ArrayCreation.DoResolve): Simplified.
7782 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7783 its own resolve process.
7784 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7786 2007-06-20 Marek Safar <marek.safar@gmail.com>
7788 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7791 2007-06-20 Marek Safar <marek.safar@gmail.com>
7793 * cs-tokenizer.cs: Removed var related stuff.
7795 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7796 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7797 a type and a keyword at same time.
7799 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7802 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7803 implicitly typed arrays, more changes will follow.
7805 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7807 2007-06-19 Marek Safar <marek.safar@gmail.com>
7809 * ecore.cs (VarExpr): Removed Handled field.
7811 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7812 build-in assign functionality.
7813 (ForEach.Resolve): Removed all implicitly typed local variable code and
7815 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7816 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7818 2007-06-18 Marek Safar <marek.safar@gmail.com>
7820 * assign.cs: Removed implicitly typed local variable check.
7822 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7823 referencing implicitly typed local variable.
7824 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7827 * statement.cs (Fixed): Removed unsupported implicitly typed local
7830 2007-06-15 Marek Safar <marek.safar@gmail.com>
7832 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7834 2007-06-14 Marek Safar <marek.safar@gmail.com>
7836 A fix for bugs #81855 and #76274
7837 * attribute.cs (AttachTo): Always set owner for global attributes to
7840 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7843 * cs-parser.jay: Assembly and module attributes must precede all other
7844 elements except using clauses and extern alias declarations.
7846 2007-06-13 Marek Safar <marek.safar@gmail.com>
7848 A fix for bug #81748
7850 * expression.cs: More checks for non ISO-1 features.
7852 2007-06-12 Marek Safar <marek.safar@gmail.com>
7854 A fix for bug #81807
7855 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7856 present inside switch statement and it is required by nullable check.
7858 2007-06-12 Marek Safar <marek.safar@gmail.com>
7860 A fix for bug #81840
7861 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7862 when type matching fails.
7864 * namespace.cs: Tiny error message change.
7866 2007-06-12 Marek Safar <marek.safar@gmail.com>
7868 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7869 reporting. Added automatic property check.
7871 * class.cs: Updated after CheckAbstractAndExtern relocation.
7872 (AEventPropertyAccessor.GetSignatureForError): Customized.
7874 2007-06-11 Marek Safar <marek.safar@gmail.com>
7876 * class.cs (DefineBaseTypes): Base type can be undefined.
7878 * ecore.cs (TypeLookup): Minor refactoring.
7879 (DoResolveAsTypeStep): Removed redundant check.
7881 * namespace.cs (Lookup): Removed redundant check.
7883 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7884 ResolveAsTypeTerminal step.
7885 (BootstrapCorlib_*): Simplified.
7886 (PopulateCoreType): Core types can be now external.
7888 2007-06-07 Marek Safar <marek.safar@gmail.com>
7890 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7892 (InferTypeArguments): Infers anonymous expression type arguments.
7893 (Compatible): Split to Compatible and InferTypeArguments.
7895 * lambda.cs: Updated.
7897 2007-06-08 Marek Safar <marek.safar@gmail.com>
7899 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7901 2007-06-07 Raja R Harinath <harinath@gmail.com>
7903 Fix #80477, cs0135-2.cs, cs0135-3.cs
7904 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7905 names to the "known" variables list.
7906 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7907 parameter names are also "known".
7908 (Block.CheckError136): Remove.
7909 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7912 2007-06-07 Marek Safar <marek.safar@gmail.com>
7914 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7916 2007-06-06 Marek Safar <marek.safar@gmail.com>
7918 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7919 internal error not an user error.
7921 * expression.cs (IsApplicable): Refactored to make debugging easier.
7923 * support.cs: More tricks for non-mono runtimes.
7925 * typemanager.cs (CoreLookupType): Made public.
7926 (InitSystemCore): All linq specific stuff moved to linq.cs
7928 2007-06-05 Marek Safar <marek.safar@gmail.com>
7930 * typemanager.cs (CSharpSignature): One more missing build-in types
7932 More tricks for non-mono runtime.
7934 2007-06-05 Raja R Harinath <harinath@gmail.com>
7936 * statement.cs (Block.CheckError136_InParents): Remove.
7937 (Block.AddVariable): Use GetParameterInfo instead.
7938 (ToplevelBlock.ProcessArguments): Likewise.
7940 2007-06-04 Raja R Harinath <rharinath@novell.com>
7942 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7944 (ToplevelBlock.GetParameterInfo): Split out of ...
7945 (ToplevelBlock.GetParameterRefernce): ... this.
7946 (ToplevelBlock.ParameterMap): Remove.
7947 * expression.cs (ParameterReference): Update to use
7948 ToplevelParameterInfo.
7950 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7953 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7954 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7956 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7957 (ToplevelBlock.ProcessParameters) ... here.
7958 (ToplevelBlock..ctor): Invoke it.
7960 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7963 * statement.cs (IKnownVariable): New interface.
7964 (LocalInfo): Implement it.
7965 (ToplevelParameterInfo): New class.
7966 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7967 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7968 GetKnownVariableInfo.
7970 2007-06-03 Raja R Harinath <harinath@gmail.com>
7972 Partly speed up CS0136 error checks.
7973 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7974 'recurse' parameter.
7975 (Block.DoCheckError136): Only check errors in parameters. Move
7976 local variable checks ...
7977 (Block.AddVariable): ... here, and ...
7978 (ToplevelBlock.ResolveMeta): ... here.
7980 2007-06-02 Raja R Harinath <harinath@gmail.com>
7982 * statement.cs (Block.IsChildOf): Remove.
7984 * statement.cs (Statement.Clone): Move special case code ...
7985 (Block.CloneTo): ... here.
7987 2007-05-29 Raja R Harinath <rharinath@novell.com>
7989 * statement.cs (ToplevelBlock.container): Remove field. It's
7990 redundant with 'Parent'.
7991 (ToplevelBlock.ContainerBlock): Remove accessor.
7992 (ToplevelBlock..ctor): Update to changes. Register anonymous
7993 child with parent here, ...
7994 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7996 (start_anonymous): Don't save current_block.
7997 (top_current_block): Remove.
7999 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
8000 (Block.Resolve): Update to changes.
8001 (Block..ctor): Move setting of "correct" 'Toplevel'
8002 and 'Explicit' fields to ...
8003 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
8005 2007-05-27 Raja R Harinath <harinath@gmail.com>
8008 * statement.cs (Block.Implicit): Remove.
8009 (Block): Update to changes.
8010 * flowanalysis.cs: Likewise.
8012 Mildly speed up CheckInvariantMeaningInBlock
8013 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
8014 Recursively call AddKnownVariable to all enclosing blocks.
8015 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
8016 Remove recursive calls.
8017 (Block): Update to changes.
8019 New ExplicitBlock invariants
8020 * statement.cs (Block.Explicit): New field. It points to the
8021 immediately enclosing non-implicit block.
8022 (Block..ctor): Maintain the invariant.
8023 * cs-parser.jay: Take advantage of invariant.
8025 Introduce ExplicitBlock
8026 * statement.cs (ExplicitBlock): New.
8027 (ToplevelBlock): Derive from it.
8028 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
8030 (Block.Implicit): Update to changes.
8031 * cs-parser.jay: Update to changes.
8034 * codegen.cs (EmitContext.IsLastStatement): Remove.
8035 * statement.cs (Block.DoEmit): Update to changes.
8037 2007-05-25 Raja R Harinath <rharinath@novell.com>
8039 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
8040 modifying current_block directly.
8042 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
8044 * class.cs: Implemented automatic properties (C# 3.0)
8045 Thanks to Marek for the help.
8047 2007-05-23 Raja R Harinath <rharinath@novell.com>
8049 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
8050 variable as assigned, note also that all its components are
8052 (MyBitVector.SetRange): New. Function to set multiple bits to true.
8054 2007-05-19 Marek Safar <marek.safar@gmail.com>
8056 * anonymous.cs, class.cs: Emit Compiler generated attribute when
8057 member is marked as compiler generated.
8059 * decl.cs (MemberCore): Refactored ModFlags into property.
8061 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
8062 (Check): Check only accessibility modifiers.
8064 2007-05-18 Raja R Harinath <rharinath@novell.com>
8066 Track all assignable slots in one bit array
8067 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
8068 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
8069 logic from VariableMap constructor here. Use the same 'offset'
8070 variable that's later used for computing offsets of local
8072 * flowanalysis.cs (UsageVector.parameters): Remove.
8073 (UsageVector): Update to changes.
8074 (VariableMap): Remove.
8076 Avoid creating ParameterMap in every block
8077 * statement.cs (Block.ParameterMap): Move ...
8078 (ToplevelBlock.ParameterMap): ... here.
8079 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
8081 * flowanalysis.cs (FlowBranching.param_map): Remove.
8082 (FlowBranching.UsageVector): Update to changes.
8083 (FlowBranchingToplevel.CheckOutParameters): Likewise.
8085 * statement.cs (Block.CloneTo): Clone Toplevel field too.
8087 * expression.cs (ParameterReference): Distinguish between block
8088 where parameter was referenced and declared.
8090 2007-05-18 Marek Safar <marek.safar@gmail.com>
8092 * flowanalysis.cs, statement.cs: Put back improved error handling.
8094 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
8098 Imporved object and collection initialization (C# 3.0).
8100 2007-05-15 Marek Safar <marek.safar@gmail.com>
8102 A fix for bug #81380
8103 * expression.cs (Is.DoResolve): Only value types have constant `is'
8106 2007-05-15 Raja R Harinath <rharinath@novell.com>
8108 * statement.cs (ToplevelBlock.child): Remove.
8110 2007-05-15 Raja R Harinath <harinath@gmail.com>
8112 Rationalize ResolveMeta: refactoring
8113 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
8114 out constant handling code into ...
8115 (Block.DoResolveConstants): ... this.
8117 Rationalize ResolveMeta: kill local_map
8118 * statement.cs (Block.local_map, Block.LocalMap): Remove.
8119 (Block.AssignableSlots): New.
8120 (Block.ResolveMeta): Make protected. Don't create a VariableMap
8121 for locals -- move code from VariableMap here. Avoid unnecessary
8123 * flowanalysis.cs (FlowBranching.local_map): Remove.
8124 (FlowBranching..ctor): Use Block.AssignableSlots.
8125 (VariableMap): Remove unused constructors.
8127 2007-05-11 Raja R Harinath <rharinath@novell.com>
8129 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
8131 2007-05-11 Marek Safar <marek.safar@gmail.com>
8133 * typemanager.cs (IsFriendAssembly): Should not be called for building
8136 2007-05-09 Marek Safar <marek.safar@gmail.com>
8138 * literal.cs (NullConstant): Print null in all cases.
8140 * expression.cs (Binary.ResolveOperator): Implemented delegate
8141 comparison based on C# 2.0 changes.
8143 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
8145 This code is contributed under the MIT X11 license
8147 The following enables support for several C# 3.0 language features:
8149 * cs-tokenizer.cs: Added support for the "var" keyword.
8151 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
8152 Added VarExpr class to facilitate type inferencing.
8154 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
8155 to support anonymous types.
8157 * assign.cs: Added support for type inferencing and initialization.
8159 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
8161 * expression.cs: Added implicit array support to ArrayCreation.
8162 Added 5 types and 1 interface:
8164 IInitializable Implementing classes can inject initializing
8165 statements after object instantiation.
8167 Initializer Stores data for object initialization.
8169 AnonymousType An expression for anonymous types.
8171 AnonymousTypeParameter Stores data about an anonymous type's field.
8173 NewInitialize An expression for object initialization.
8175 CollectionInitialize An expression for collection initialization.
8177 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
8180 2007-05-06 Marek Safar <marek.safar@gmail.com>
8182 A fix for bug #81500
8183 * cs-tokenizer.cs: Add special handling for coalescing operator.
8185 2007-05-06 Marek Safar <marek.safar@gmail.com>
8187 A fix for bug #81529
8188 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
8189 its value from base class until it is redefined.
8191 2007-05-02 Raja R Harinath <rharinath@novell.com>
8193 Fix regression in cs0631-3.cs
8194 * cs-parser.jay (operator_declarator): Add opt_attributes to error
8195 fallback. Make error fallback catch more cases.
8197 2007-05-01 Miguel de Icaza <miguel@novell.com>
8199 * cs-parser.jay: Allow parameters in operator declarations to have
8202 2007-04-27 Miguel de Icaza <miguel@novell.com>
8204 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
8207 * lambda.cs (ContextualReturn.Resolve): An expression is valid
8208 inside the ContextualReturn, it does not have to be an
8209 ExpressionStatement.
8211 2007-04-24 Miguel de Icaza <miguel@novell.com>
8213 * lambda.cs (ContextualReturn.Resolve): if the return type is not
8216 2007-04-23 Miguel de Icaza <miguel@novell.com>
8218 * anonymous.cs (AnonymousContainer): split the virtual Resolve
8219 method in two methods: ResolveNoDefine and Resolve.
8221 ResolveNoDefine will stop just after ResolveTopBlock has been
8224 Resolve will then continue by creating a method and issuing the
8225 call to method.Define ().
8227 (AnonymousMethod): Split and implement the new Resolve and
8228 ResolveNoDefine as well.
8230 * lambda.cs (LambdaExpression): Split the anonymous method
8231 resolution code into a separate routine (CoreCompatibilityTest)
8232 from DoCompatibleTest.
8234 (LambdaExpression.TryBuild): New method, this method tries to
8235 build the LambdaExpression with the given set of types to be used
8236 as the types for the various parameters of the lambda expression.
8238 If the compilation succeed with the given types, the infered type
8239 of the Anonymous method is returned, otherwise null is returned.
8241 2007-04-23 Marek Safar <marek.safar@gmail.com>
8243 A fix for bug #81414
8244 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
8246 2007-04-22 Miguel de Icaza <miguel@novell.com>
8248 * cs-tokenizer.cs: Change various identifiers here from the
8249 camelCasing to the recommended Linux-like style for instance
8250 variables from the Coding Guidelines.
8252 2007-04-19 Martin Baulig <martin@ximian.com>
8255 (Convert.ImplicitReferenceConversionCore): Allow conversions from
8256 System.Enum to System.ValueType.
8258 2007-04-13 Martin Baulig <martin@ximian.com>
8260 Rewrote implicit reference conversions. We need to distinguish
8261 between implicit reference conversions (13.1.4) and implicit
8262 boxing conversions (13.1.5).
8264 According to the spec, there's an an implicit conversion
8265 "From a one-dimensional array-type S[] to IList<T> and base
8266 interfaces of this interface, provided there is an implicit
8267 reference conversion from S to T." Note that this does not
8268 include boxing conversions.
8271 (Convert.ImplicitTypeParameterBoxingConversion): New method.
8272 (Convert.ImplicitReferenceConversion): Split into
8273 ImplicitReferenceConversionCore() and
8274 ImplicitBoxingConversionExist().
8275 (Convert.ImplicitReferenceConversionExists): Use the new
8276 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
8278 2007-04-12 Martin Baulig <martin@ximian.com>
8280 * convert.cs (Convert.ImplicitReferenceConversion): Move the
8281 `TypeManager.null_type' checks up to the top of the method.
8283 2007-04-11 Marek Safar <marek.safar@gmail.com>
8285 A fix for bug #81350
8286 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
8289 2007-04-11 Martin Baulig <martin@ximian.com>
8291 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
8292 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
8293 to make this work for generic classes; fixes #79561.
8295 2007-04-11 Martin Baulig <martin@ximian.com>
8297 * expression.cs (As): Add support for nullable types; fixes #79371.
8299 2007-04-11 Martin Baulig <martin@ximian.com>
8301 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
8302 `type.FullName' is null; fixes #80243.
8304 2007-04-11 Martin Baulig <martin@ximian.com>
8306 * expression.cs (Invocation.IsApplicable): Don't modify the method
8307 if type inference succeeded, but the method was not applicable.
8310 2007-04-10 Marek Safar <marek.safar@gmail.com>
8312 A fix for bug #81324
8313 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
8314 internal and external namespaces containers.
8316 2007-04-10 Martin Baulig <martin@ximian.com>
8318 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
8319 TypeManager.DropGenericMethodArguments() so we also call
8320 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
8322 2007-04-10 Martin Baulig <martin@ximian.com>
8324 * iterators.cs (Iterator.CreateIterator): Don't crash if
8325 `method.ReturnType' is null. This happens if something went wrong
8326 while resolving that typ (we already reported an error in this case).
8328 2007-04-10 Martin Baulig <martin@ximian.com>
8330 * expression.cs (New.DoResolve): Don't call CheckComImport() on
8331 generic interfaces; report the CS0144 directly.
8333 2007-04-10 Martin Baulig <martin@ximian.com>
8335 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
8336 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
8338 2007-04-10 Martin Baulig <martin@ximian.com>
8340 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
8342 2007-04-09 Raja R Harinath <rharinath@novell.com>
8345 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
8346 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
8349 * statement.cs (For.Resolve): If resolution fails, use
8352 2007-04-08 Marek Safar <marek.safar@gmail.com>
8354 * anonymous.cs (MakeName): Make faster and zero-based.
8355 (VerifyExplicitParameterCompatibility): Back to mode where generic
8356 parameter is ignored.
8357 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
8359 * class.cs (EmitType): Method can emit another new method.
8361 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
8363 * driver.cs: Updated.
8365 * lambda.cs: Reuse predefined empty parameters.
8367 * parameter.cs: Updated
8369 * support.cs: Implemented InflateTypes.
8371 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
8372 (InitSystemCore): Introduced to isolate 3.0 dependencies.
8374 2007-04-03 Martin Baulig <martin@ximian.com>
8378 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
8379 version of TypeManager.IsOverride() which also works with generic
8382 2007-04-03 Martin Baulig <martin@ximian.com>
8387 (Convert.ExplicitReferenceConversion): We need to cast when
8388 converting from IList<T> to S[].
8390 2007-04-01 Marek Safar <marek.safar@gmail.com>
8392 * decl.cs (FindExtensionMethods): Consider all candidates with same name
8395 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
8397 2007-03-31 Marek Safar <marek.safar@gmail.com>
8399 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
8400 argument and return type inferring.
8402 * codegen.cs (InferReturnType): Flag whether return can be inferred.
8403 (ReturnType): Turned to property.
8405 * statement.cs (Return): Implemented return type inferring.
8407 * support.cs (ReflectionParameters): Use local types if possible.
8409 2007-03-30 Raja R Harinath <rharinath@novell.com>
8411 * flowanalysis.cs (FlowBranching.Reachability): Remove.
8412 (FlowBranching.UsageVector): Update to changes.
8414 Prepare to kill 'Reachability'
8415 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
8416 argument of constructor.
8418 2007-03-29 Raja R Harinath <rharinath@novell.com>
8420 Prepare to kill 'Reachability'
8421 * flowanalysis.cs (UsageVector.is_unreachable): New.
8422 (UsageVector): Update to maintain 'is_unreachable' in parallel to
8423 'reachability', and verify they're consistent.
8426 * expression.cs (New.EmitStatement): Handle type parameters here too.
8428 2007-03-29 Martin Baulig <martin@ximian.com>
8433 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
8434 CompilerGeneratedClass.
8435 (ScopeInfo.EmitScopeInstance): Make this protected.
8436 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
8437 `ec.CurrentAnonymousMethod.Scope == Scope'.
8439 * statement.cs (Block.ScopeInfo): Make this a property.
8441 2007-03-27 Raja R Harinath <harinath@gmail.com>
8443 Prepare to kill 'Reachability'
8444 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
8445 (FlowBranching.UsageVector.Reachability): Remove property.
8446 (FlowBranching.UsageVector.IsUnreachable): New property.
8447 (FlowBranching.UsageVector.ResetBarrier): New.
8448 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
8449 * codegen.cs, statement.cs: Update to changes.
8451 2007-03-27 Martin Baulig <martin@ximian.com>
8456 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
8459 2007-03-26 Raja R Harinath <rharinath@novell.com>
8461 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
8462 instead of TriState. Remove all mention of TriState.
8464 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
8465 replaced by a boolean. Add boolean 'is_unreachable' field, check
8466 and maintain invariants.
8468 2007-03-25 Marek Safar <marek.safar@gmail.com>
8470 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
8472 2007-03-25 Marek Safar <marek.safar@gmail.com>
8474 * expression.cs: Stop using obsolete 2.0 opcodes.
8476 2007-03-25 Marek Safar <marek.safar@gmail.com>
8478 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
8479 one of the latests Martin's fixes.
8481 2007-03-23 Miguel de Icaza <miguel@novell.com>
8483 * expression.cs: On BigEndian systems, swap the bytes, temporary
8484 solution until we get a new bitconverter class.
8486 2007-03-23 Martin Baulig <martin@ximian.com>
8490 * decl.cs (MemberCache.AddMembers): Add generic methods both as
8491 "Method" and "Method`1". Normally, a cache lookup is done on the
8492 "Method" form (ie. without the generic arity), but this one makes
8493 lookups on the full form work as well.
8495 2007-03-22 Raja R Harinath <rharinath@novell.com>
8497 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
8500 2007-03-20 Bill Holmes <billholmes54@gmail.com>
8502 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
8503 ordered_member_list, to TypeBuilder to store members to be defined
8504 in the order they were parsed in.
8505 - ordered_explicit_member_list contains all properties indexers
8506 and methods that are defined as explicit implementation of an
8507 interface or base class.
8508 - ordered_member_list contains all properties indexers and methods
8509 that are not defined as explicit implementation of an interface
8512 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
8513 functionality in these removed classes has been replaced with
8514 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
8515 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
8517 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
8518 to CheckForDuplications inside GetMethod and SetMethod Define Method
8519 to handle method property and indexer name conflicts.
8523 All code is contributed under the MIT/X11 license.
8525 2007-03-20 Martin Baulig <martin@ximian.com>
8527 * class.cs (TypeContainer.Interfaces): Removed; they're now
8528 included in `TypeContainer.Types'.
8530 2007-03-20 Martin Baulig <martin@ximian.com>
8532 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
8534 * class.cs (TypeContainer.CreateType): New public method. This is
8535 now called before DefineType() to create the TypeBuilders.
8536 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
8537 has already been created by CreateType().
8538 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8539 don't resolve our base classes here; this has been moved into
8540 DefineBaseTypes(). We're now called from CreateType().
8541 (TypeContainer.DefineBaseTypes): New private method; resolve our
8542 base classes here. We're now called from DefineType().
8545 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8546 our types first to create all the TypeBuilders. After that, call
8547 TypeContainer.DefineType() on all the types which'll resolve their
8548 base classes and setup the resolve order.
8550 2007-03-20 Martin Baulig <martin@ximian.com>
8552 * class.cs (TypeContainer.Enums): Removed; they're now included in
8553 `TypeContainer.Types'.
8555 2007-03-20 Martin Baulig <martin@ximian.com>
8558 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8559 (TypeContainer.DoResolveMembers): Call DefineType() on our
8560 `compiler_generated' classes; moved here from DefineNestedTypes().
8563 (RootContext.ResolveTree): Call ResolveMembers() on all
8564 TypeContainer's in the `type_container_resolve_order'.
8566 2007-03-19 Marek Safar <marek.safar@gmail.com>
8568 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8570 2007-03-17 Marek Safar <marek.safar@gmail.com>
8572 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8573 implementation flags.
8575 2007-03-17 Marek Safar <marek.safar@gmail.com>
8577 * class.cs: More optimizations for type parameters.
8579 2007-03-15 Marek Safar <marek.safar@gmail.com>
8581 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8583 * ecore.cs, parameter.cs: More common code for both corlibs.
8585 * typemanager.cs (IsGenericMethod): Simplified.
8587 2007-03-15 Raja R Harinath <rharinath@novell.com>
8589 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8591 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8593 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8594 unconditionally. Simplify explanation.
8595 (Try.Resolve, Using.Resolve): Likewise.
8597 2007-03-15 Martin Baulig <martin@ximian.com>
8601 * decl.cs (DeclSpace): If we're a partial class, use our
8602 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8604 2007-03-15 Raja R Harinath <rharinath@novell.com>
8606 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8608 (FlowBranching.UsageVector): Update to changes.
8609 (FlowBranching.MergeSiblings): Likewise.
8610 * statement.cs: Likewise.
8612 2007-03-15 Martin Baulig <martin@ximian.com>
8617 (MemberCache): Added a special .ctor for type parameters.
8620 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8623 2007-03-09 Martin Baulig <martin@ximian.com>
8625 * enum.cs (Enum): Make this a TypeContainer.
8626 (EnumMember): Derive from `Const'.
8629 (Const.DoResolveValue): New protected virtual method; move most of
8630 the functionality of ResolveValue() here so we can override it in
8632 (Const.CreateConstantReference): Make this virtual.
8634 * class.cs (Kind): Add `Kind.Enum'.
8635 (TypeContainer.Emit): Don't emit the enums here; they're already
8636 in the `RootContext.typecontainer_resolve_order'.
8638 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8639 here; they're already in the `typecontainer_resolve_order'.
8641 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8642 TypeManager.DropGenericTypeArguments().
8645 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8646 (TypeManager.IsEnumType): Likewise.
8647 (TypeManager.EnumToUnderlying): Likewise.
8648 (TypeManager.IsEqual): Add support for enums.
8650 2007-03-12 Raja R Harinath <rharinath@novell.com>
8652 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8653 DefaultParameterValueAttribute to be undefined, say if System.dll
8656 2007-03-11 Marek Safar <marek.safar@gmail.com>
8658 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8661 2007-03-10 Marek Safar <marek.safar@gmail.com>
8663 * class.cs, parameter.cs: Unified parameters verification.
8665 2007-03-08 Martin Baulig <martin@ximian.com>
8667 * cs-parser.jay (constructor_header): Pass the location to the
8668 newly created TopLevelBlock.
8670 2007-03-07 Martin Baulig <martin@ximian.com>
8672 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8674 2007-03-06 Miguel de Icaza <miguel@novell.com>
8676 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8677 with the changes from David, fixes the build.
8679 2007-03-05 David Mitchell <dmitchell@logos.com>
8681 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8682 and its base interfaces to a one-dimensional array type S[],
8683 provided there is an implicit or explicit reference conversion
8686 2007-03-03 Marek Safar <marek.safar@gmail.com>
8688 * cs-tokenizer.cs: Implemented basic linq grammar.
8690 * driver.cs: Set linq lang version on demand.
8692 2007-02-26 Marek Safar <marek.safar@gmail.com>
8694 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8696 2007-02-25 Marek Safar <marek.safar@gmail.com>
8698 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8701 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8703 Check property and event extern attributes.
8705 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8708 2007-02-24 Marek Safar <marek.safar@gmail.com>
8710 A fix for bug #80407
8711 * ecore.cs: Don't report ambiguity error when methods have same parent.
8713 2007-02-23 Marek Safar <marek.safar@gmail.com>
8715 A fix for bug #80878
8716 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8718 2007-02-22 Marek Safar <marek.safar@gmail.com>
8720 * attribute.cs: Enable ExtensionAttribute presence test.
8722 2007-02-22 Marek Safar <marek.safar@gmail.com>
8724 * class.cs: Warn about missing GetHashCode only when Equals is override.
8726 * decl.cs: Check accessibility of type arguments.
8728 * typemanager.cs: Correctly report nullable array.
8730 2007-02-20 Marek Safar <marek.safar@gmail.com>
8732 * class.cs, report.cs: Capture more details when things go wrong.
8734 2007-02-20 Marek Safar <marek.safar@gmail.com>
8736 A fix for bug #80650
8737 * cs-parser.jay: Anonymous container starts at constructor declaration
8738 and not at block beginning because it has to be usable in constructor
8741 * statement.cs: Use context location and not block one for error reporting.
8743 2007-02-18 Marek Safar <marek.safar@gmail.com>
8745 A fix for bug #78712
8746 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8749 2007-02-18 Marek Safar <marek.safar@gmail.com>
8751 A fix for bug #80493 by Atsushi Enomoto
8752 * cs-parser.jay: Ignore invalid attribute target.
8754 2007-02-18 Marek Safar <marek.safar@gmail.com>
8756 * cs-tokenizer.cs: Ignore '\0' as white space character.
8758 2007-02-17 Miguel de Icaza <miguel@novell.com>
8760 * cs-parser.jay: Add support for lambda expressions to the mcs
8763 * lambda.cs: Only clone when we are probing, not on the final call
8764 (Compatible is the final call).
8766 * statement.cs (CloneContext): Introduce class to provide block
8767 remapping during clone.
8769 All statements Clone themselves now.
8771 (Clone): special handling for blocks, when we clone a block, we
8772 register the block inside this routine, as children of the block
8773 might trigger a lookup.
8775 * expression.cs: Add support for CloneContext in all expressions.
8777 2007-02-17 Marek Safar <marek.safar@gmail.com>
8779 A fix for bug #80493
8780 * statement.cs: Report ambiguous warning when interfaces are not related.
8782 2007-02-15 Marek Safar <marek.safar@gmail.com>
8784 C# 3.0 extension methods.
8786 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8787 cannot be used directly.
8789 * class.cs (Class.Emit): Emit extension attribute if any class method
8790 is extension method.
8791 (Method.Define): Add basic extension method validation conditions.
8792 (Method.Emit): Emit extension attribute for method.
8794 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8795 extension method exists. Currently we follow same approach as Microsoft
8796 does, emit even if a method or a class are private but this can change
8799 * cs-parser.jay: Add handling of `this' keyword in method parameters
8802 * decl.cs (DeclSpace.IsStaticClass): New property.
8803 (MemberCache.FindExtensionMethods): Looks for extension methods with
8804 defined name and extension type.
8806 * doc.cs: Updated after OverloadResolve changes.
8808 * driver.cs: Add new soft reference to System.Core.dll.
8810 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8811 (ExtensionMethodGroupExpr): Represents group of extension methods.
8813 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8814 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8815 to MethodGroupExpr and made non-static for easier customization.
8816 (Invocation.DoResolve): Add extension method lookup when no standard
8818 (MemberAccess.DoResolve): Try extension methods if no member exists.
8820 * modifiers.cs: Add METHOD_EXTENSION modifier.
8822 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8823 as well as candidate extension type.
8824 (ComputeNamespaces): When assembly constains extension methods registers
8826 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8827 extension method lookup.
8828 (Namespace.LookupExtensionMethod): Looks for extension method in this
8830 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8831 find a method which matches name and extensionType.
8833 * parameter.cs (Parameter): Add This modifer.
8834 (HasExtensionMethodModifier): New property.
8835 (Resolve): Add extension parameter check.
8836 (ModFlags): turned to property to exclude this modifier as it is not real
8838 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8840 * support.cs (ParameterData): Add ExtensionMethodType.
8841 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8843 * typemanager.cs: Add type and ctor extension attribute type.
8845 2007-02-15 Miguel de Icaza <miguel@novell.com>
8847 * report.cs (DisableErrors, EnableErrors): used to prevent error
8848 output when we are "trying" to compile various methods with
8851 * ecore.cs (Expression): Add Clone method that calls the virtual
8852 CloneTo method. The current CloneTo method in Expression throws
8853 an exception so we can track down all the places where this must
8854 be implemented (not using abstract, because that would be a lot of
8855 up-front-work before we can start testing the implementation
8858 Important: we only need Clone capabilities for expressions created
8859 by the parser, as the expressions we will be cloning are
8860 expressions in the pre-resolved state. This vastly simplifies
8863 (SimpleName): Add CloneTo that does nothing.
8864 (EmptyCast): Add CloneTo.
8866 * expression.cs (Binary): Implement CloneTo.
8867 (Invocation.IsApplicable): Store the current ec in
8868 EmitContext.TempEc and restore it on return. This is used so we
8869 do not have to sprinkle hundres of methods with an extra
8870 EmitContext, we know that the only user is the lambda expression
8871 ImplicitConversionExists code.
8873 (Argument): Add Cloning capabilities.
8874 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8875 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8876 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8877 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8878 IndexerAccess): Add Clone capability.
8880 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8882 (Argument): Add cloning capability.
8884 * assign.cs (Assign): Implement CloneTo.
8886 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8888 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8889 version by calling Convert with the EmitContext (that we are
8890 currently storing in ec, this is not great, but will do for now,
8891 to avoid passing EmitContext parameters to hundreds of functions
8892 that do not need them now).
8894 (SetExpression): Remove, it is not needed.
8896 (ContextualReturn): Implement CloneTo.
8898 * statement.cs (Statement): Implement cloning infrastructure,
8899 similar to expressions.
8901 (Block): Partial implementation of Clone for statements.
8903 (Return): Implement clone.
8905 * constant.cs (Constant.CloneTo): New method, does nothing.
8907 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8908 solution, until we decide how to exactly do this.
8910 2007-02-14 Marek Safar <marek.safar@gmail.com>
8912 A fix for bug #80493
8913 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8914 a property is override we need to use second accessor.
8916 2007-02-13 Marek Safar <marek.safar@gmail.com>
8918 A fix for bug #80418
8919 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8922 2007-02-13 Marek Safar <marek.safar@gmail.com>
8924 Another fix for bug #80749
8925 * pending.cs: Abstract class has priority over interfaces.
8927 2007-02-13 Marek Safar <marek.safar@gmail.com>
8929 Another fix for bug #80749
8930 * pending.cs: Abstract class has priority over interfaces.
8932 2007-02-13 Marek Safar <marek.safar@gmail.com>
8934 Another fix for bug #80749
8935 * pending.cs: Abstract class has priority over interfaces.
8937 2007-02-13 Marek Safar <marek.safar@gmail.com>
8939 Another fix for bug #80749
8940 * pending.cs: Abstract class has priority over interfaces.
8942 2007-02-13 Marek Safar <marek.safar@gmail.com>
8944 * class.cs Better error message.
8946 * driver.cs: Add shorter versions of -optimize option.
8948 2007-02-13 Martin Baulig <martin@ximian.com>
8950 * class.cs (Constructor.Emit): Check the return value of
8951 ec.ResolveTopBlock() and return on error.
8953 2007-02-13 Raja R Harinath <rharinath@novell.com>
8955 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8956 message to fix error message regression.
8958 2007-02-12 Marek Safar <marek.safar@gmail.com>
8960 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8962 2007-02-12 Marek Safar <marek.safar@gmail.com>
8964 A fix for bug #80749
8965 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8966 its parent container.
8968 * class.cs (DefineFieldInitializers): Each initializer can has different
8971 * const.cs: Updated.
8973 2007-02-11 Miguel de Icaza <miguel@novell.com>
8975 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8976 now all the heavy lifting to check that embedded statements or
8977 expressions have the right form is done in the ContextualReturn.
8979 (ContextualReturn): New class.
8981 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8982 method that can be invoked to report 201, so we do not replicate
8985 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8987 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8988 treating tabs as spaces.
8990 2007-02-09 Marek Safar <marek.safar@gmail.com>
8992 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8993 * assign.cs: Use full implicit conversion for right side check.
8995 2007-02-09 Marek Safar <marek.safar@gmail.com>
8997 * statement.cs (Switch): Switch over boolean type is not standardized.
8999 2007-02-08 Marek Safar <marek.safar@gmail.com>
9001 A fix for bug #80755
9002 * decl.cs (FindBaseEvent): Don't use method cache for events.
9004 2007-02-07 Marek Safar <marek.safar@gmail.com>
9006 * cs-parser.jay: Better syntax error handling.
9008 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
9009 instead of underlying type value.
9011 2007-02-06 Marek Safar <marek.safar@gmail.com>
9013 * driver.cs: Check define identifier before is registered.
9015 * namespace.cs: Use existing error message.
9017 * report.cs: New warning.
9019 2007-02-06 Marek Safar <marek.safar@gmail.com>
9021 A fix for bug #80742
9022 * expression.cs: Delegate Invoke method can be called directly.
9024 2007-02-06 Marek Safar <marek.safar@gmail.com>
9026 A fix for bug #80676
9027 * class.cs (IsEntryPoint): The Main method can have params modifier.
9029 2007-02-04 Miguel de Icaza <miguel@novell.com>
9031 * parameter.cs (Parameter, Parameters): Add Clone method.
9033 * anonymous.cs (Compatible): Turn method into virtual method, so
9034 LambdaExpression can implement a different behavior.
9036 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
9037 out the basic checking here, so it can be used by
9040 * lambda.cs: Introduce "Compatible" function that will do the
9043 2007-02-02 Marek Safar <marek.safar@gmail.com>
9045 * attribute.cs: Unified one error message.
9047 * class.cs (Class): Use type attributes and not properties to test static
9049 (IsEntryPoint): Don's pass local variable.
9051 * convert.cs: Removed duplicate check.
9053 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
9055 * driver.cs: Don't crash when soft reference does not exist.
9057 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
9058 (UsingEntry): Removed redundant allocation.
9060 * parameter.cs: Add fast path for type parameters.
9062 * support.cs: Don't allocate attribute when it's not used.
9064 2007-01-30 Miguel de Icaza <miguel@novell.com>
9067 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
9068 this into a virtual method, so we can override it in LambdaExpression.
9070 * driver.cs: Improve diagnostics in case of failure.
9072 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
9073 write a function that is slightly more complex and that parses:
9075 type identifier [, type identifier]* )
9077 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
9080 (canEmpty ? i >= 0 : i > 0)
9082 2007-01-30 Raja R Harinath <rharinath@novell.com>
9084 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
9085 exception on possibly valid code.
9087 2007-01-29 Raja R Harinath <rharinath@novell.com>
9089 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
9091 (parse_opt_type_arguments): Remove. It's almost the same as
9093 (parse_namespace_or_typename): Use parse_less_than.
9095 2007-01-28 Miguel de Icaza <miguel@novell.com>
9097 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
9098 this bug took a few hours to find, because the state saved and
9099 restored by PushPosition and PopPosition was ignoring the state of
9100 parse_generic_less_than.
9102 I can also now remove the handling of OP_LT and OP_GT, this solves
9105 * cs-tokenizer.cs: store the location for the ARROW token, we use
9108 (PushPosition, PopPosition): save/restore also `current_token',
9109 restore `parse_generic_less_than' (was missing).
9111 (parse_opt_type_arguments): use parse_type, not
9112 parse_namespace_or_typename to parse types.
9114 * lambda.cs: Empty new file, will eventually have the lambda
9115 expression implementation.
9117 * lambda.test: used to test the internal tokenizer.
9119 * report.cs (FeatureIsNotISO1): Rename from
9120 FeatureIsNotStandardized, because it was about the language level
9121 (1 vs 2) it was not about standarization.
9123 (FeatureRequiresLINQ): New.
9125 * support.cs (SeekableStreamReader): Only require that the reader
9126 is a TextReader, not a StreamReader, so we can plug StringReader.
9128 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
9129 given position in the input stream the following tokens can be
9130 parsed as a type followed by an identifier.
9132 (is_punct): after a '(' if parse_type_and_parameter returns true,
9133 then return a special token OPEN_PARENS_LAMBDA which is used to
9134 avoid reduce/reduce errors in the grammar for the
9135 lambda_expression rules.
9137 (parse_type): implement a type parser inside the
9138 tokenizer, the parser only returns true or false depending on
9139 whether the input at a given position can be parsed as a type.
9141 (peek_token): new method used during type parsing.
9143 2007-01-28 Raja R Harinath <rharinath@novell.com>
9146 * anonymous.cs (ScopeInfo.InflateParameters): New.
9147 (AnonymousContainer.Resolve): Use it to redirect types of
9148 delegate parameters.
9150 2007-01-27 Raja R Harinath <rharinath@novell.com>
9153 * expression.cs (Error_InvalidArguments): Don't use two different
9154 messages for CS1503. Use ExtraInformation and
9155 SymbolRelatedToPreviousError instead.
9158 * decl.cs (DeclSpace.initialize_type_params): Don't access
9159 'type_params' of a partial class directly.
9161 2007-01-26 Miguel de Icaza <miguel@novell.com>
9163 * constant.cs: Removed a handful of out-of-range checks that were
9166 2007-01-25 Marek Safar <marek.safar@gmail.com>
9168 * expression.cs (CheckUselessComparison): Add additional check for char
9171 * namespace.cs: Fixed typo.
9173 2007-01-23 Miguel de Icaza <miguel@novell.com>
9175 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
9176 gone, instead we inline the test, preventing the needless casts to
9177 longs, ulongs and doubles for the parameters, avoiding calls to
9178 methods that overchecked stuff, and instead inlined things
9181 2007-01-20 Marek Safar <marek.safar@gmail.com>
9183 * cs-parser.jay: Better parameter error handling.
9185 2007-01-17 Marek Safar <marek.safar@gmail.com>
9187 A fix for bug #80368, #80522
9188 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
9189 whether array initializer contains constants only.
9190 (ArrayCreation.Emit): Use better formula to decide when
9191 are array initializers for static initialization.
9192 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
9193 have to emit even constants otherwise they are pre-initialized.
9195 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
9196 Raja R Harinath <rharinath@novell.com>
9198 Fix emit order of 'get' vs. 'set'.
9199 * support.cs (Accessors): New.
9200 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
9201 Note the order in which accessors are declared in the source.
9202 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
9203 Refactored from Property.Define and Indexer.Define.
9204 (PropertyBase.DefineAccessors): New helper that calls the above in
9205 appropriate order as noted by the parser.
9206 (Property.Define, Indexer.Define): Update to changes.
9207 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
9209 2007-01-17 Raja R Harinath <rharinath@novell.com>
9211 Fix cs0029-6.cs and gcs0029-2.cs (regression)
9212 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
9213 there's an implicit conversion from the current type to the target
9214 type before converting the underlying constant.
9216 2007-01-16 Marek Safar <marek.safar@gmail.com>
9218 * const.cs (ResolveValue): Updated after constant conversion was made more
9221 * constant.cs (GetAttributableValue): constant to object conversion is
9222 used for attributes only.
9223 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
9224 constant conversions.
9225 (LongConstant.ConvertImplicitly): Ditto.
9227 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
9228 (ImplicitConversionStandard): Handle constant conversion as extra step.
9229 It solves the issue when constant conversion was called indirectly like
9230 inside array initializer and constant folding was skipped.
9232 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
9235 * statement.cs(ImplicitConversionStandard): Updated after constant
9236 conversion was made more generic.
9238 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
9240 * expression.cs (As.DoResolve): Use GenericConstraints instead of
9241 Constraints, solves the problem where the compiler incorrectly
9242 reported that a type parameter was not constrained to a class (Bug
9245 2007-01-14 Marek Habersack <grendello@gmail.com>
9247 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
9249 2007-01-14 Marek Safar <marek.safar@gmail.com>
9251 A fix for bug #80368
9252 * assign.cs (FieldInitializer): New class implements field
9253 initializer statement.
9255 * attribute.cs: Update after FieldMember rename.
9257 * class.cs (PropertyBasedMember): New common class for property based
9259 (InterfaceMemberBase): New base class for all members which can be used as
9260 an interface members.
9261 (MethodCore): Moved really common code to InterfaceMemberBase.
9262 (Method.Define): Equal and GetHasCode detection is relevant for methods
9264 (MethodData.Define): Don't assume that public event implements an
9265 interface automatically.
9266 (MethodData.DefineMethodBuilder): Issue an error even if only extern
9268 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
9269 (FieldMember): Merged with FieldBase.
9270 (EventProperty.AEventPropertyAccessor): New specialization to check whether
9271 event extern modifier can be used.
9272 (EventField.EventFieldAccessor): Moved event field specific code here.
9273 (Event.AllowedModifiers): Even event can be extern.
9274 (Event.FindOutBaseMethod): New override specific to events.
9275 (Indexer.parameters): Reintroduce parameters because base class holds
9276 only properties common data.
9277 (Indexer.CheckForDuplications): Indexers are threated as methods so we
9278 need do extra parameters check.
9280 * const.cs: Update after FieldMember rename.
9282 * decl.cs (MemberCache.FindBaseEvent): New method.
9284 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
9285 to reflect that indexer is now derived from PropertyBased.
9287 * ecore.cs (GetMemberType): Made public.
9288 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
9291 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
9293 * typemanager.cs (CSharpSignature): Correctly print event accessors.
9294 (RegisterEvent): Removed.
9295 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
9296 (GetPrivateFieldOfEvent): Renamed to GetEventField.
9298 2007-01-11 Raja R Harinath <rharinath@novell.com>
9301 * statement.cs (CollectionForeach.TryType): Prefer generic
9302 GetEnumerator over non-generic variant. Fix code to follow comments.
9304 2007-01-09 Raja R Harinath <rharinath@novell.com>
9307 * support.cs (ReflectionParameter): Don't use an invalid index on
9308 the generic parameter data.
9310 2007-01-08 Miguel de Icaza <miguel@novell.com>
9312 * driver.cs: Just add a tiny bit of infrastructure.
9314 2007-01-02 Marek Safar <marek.safar@gmail.com>
9316 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
9317 where field type is struct from current assembly.
9319 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
9322 2007-01-02 Marek Safar <marek.safar@gmail.com>
9324 A fix for bug #80381
9325 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
9328 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
9330 (Namespace.LookupType): Always use core types from corlib when speficied.
9332 * report.cs: A new warning.
9334 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
9335 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
9336 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
9338 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
9339 (InitCoreTypes): Set expression type of object_type and value_type
9340 immediately after lookup.
9342 2007-01-01 Miguel de Icaza <miguel@novell.com>
9344 * cs-tokenizer.cs: Accept Pc class characters (Connector
9345 Punctuation) as valid identifiers. Fixes #78259
9347 * expression.cs (Invocation.DoResolve): Moved the check for the
9348 use of `this' for doing method calls to the Invocation resolution
9349 step, after overload resolution has taken place instead of doing
9350 the check at the low-level `This.DoResolve' level.
9352 The `This.DoResolve'(appens before overload resolution, so it has
9353 no way of knowing if the method that will be called will be
9354 instace or static, triggering an erroneous report for cs0188 (Bug
9357 We now do the check for instance method invocations after we know
9358 what method will be called.
9360 (This.CheckThisUsage): Move the actual use of this structure
9361 checking into its own method and expose it.
9363 * Everywhere that called Error_ValueCannotBeConverted: pass a new
9366 Exceptions: Null.ConvertImplicitly,
9367 Constant.ImplicitConversionRequired as there are too many call
9368 sites for passing the ec.
9370 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
9371 EmitContext, if the value is null, then we do not try to provide
9372 the extra information from the error (If a userdefined conversion
9373 exists, as UserDefinedConversion requires a non null-EmitContext).
9377 2006-12-30 Raja R Harinath <rharinath@novell.com>
9379 * flowanalysis.cs (MyBitVector): Document some invariants.
9380 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
9381 introduced below, and add a couple of others,
9383 2006-12-30 Marek Safar <marek.safar@gmail.com>
9385 * attribute.cs (GetMethodObsoleteAttribute): Uses new
9386 GetPropertyFromAccessor and GetEventFromAccessor.
9388 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
9389 overrides non-obsolete one.
9390 (Indexer.Define): Error message has been moved to the parser.
9392 * cs-parser.jay: Better syntax errors handling.
9394 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
9395 when an invocation has no arguments.
9397 * ecore.cs: Removed not used caching.
9399 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
9402 * report.cs: Add a new warning.
9404 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
9406 * typemanager.cs (enumeration_type): Removed.
9407 (CSharpSignature): Reuses IsSpecialMethod.
9408 (IsEqual): Hack for MS BCL.
9409 (GetPropertyFromAccessor): New method.
9410 (GetEventFromAccessor): New method.
9411 (IsSpecialMethod): Fixed to handle more cases.
9413 2006-12-30 Marek Safar <marek.safar@gmail.com>
9415 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
9416 Made white spaces array static.
9418 * ecore.cs (RemoveGenericArity): Optimized.
9420 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
9422 (MyBitVector.initialize_vector): Simplified.
9424 2006-12-22 Miguel de Icaza <miguel@novell.com>
9426 * ecore.cs: Am not entirely happy with this hack, but it seems to
9427 address the issue in 80257 (a small test case for
9430 I set the MethodGroupExpr.Type to an internal compiler type
9431 (itself in this case) to force the resolution to take place. Why
9432 it does not take place with a null is beyond me.
9434 2006-12-20 Marek Safar <marek.safar@gmail.com>
9436 A fix for bug #80288
9437 * expression.cs (ResolveOperator): Consider user defined conversion for
9438 logical and operator too.
9439 (EmitBranchable): Optimization for logical and when full constant folding
9440 could not be applied but one operand is constant.
9442 2006-12-19 Marek Safar <marek.safar@gmail.com>
9444 * class.cs (GetClassBases): Write 5 times every day, will never use
9445 FullName for error reporting.
9447 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
9449 2006-12-19 Martin Baulig <martin@ximian.com>
9451 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
9452 the symbol file info here.
9454 2006-12-18 Marek Safar <marek.safar@gmail.com>
9456 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
9457 of `elseif' is taking then following sections are not taking.
9458 Fixes an issue reported on mono mailing list.
9460 2006-12-18 Marek Safar <marek.safar@gmail.com>
9462 A fix for bug #80300
9463 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
9464 a caller is not taking.
9466 2006-12-18 Raja R Harinath <rharinath@novell.com>
9468 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
9469 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
9470 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
9471 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
9472 * class.cs: Update to changes.
9474 2006-12-17 Marek Safar <marek.safar@gmail.com>
9476 A fix for bug #79934
9477 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
9480 * class.cs (ResolveMembers): Register an iterator in current container and
9483 2006-12-16 Raja R Harinath <rharinath@novell.com>
9486 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
9487 satisfy a params annotated parameter.
9489 2006-12-16 Marek Safar <marek.safar@gmail.com>
9491 A fix for bug #77014
9492 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
9493 paramters correctly and not rely on hacks in Parameters class.
9494 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
9496 (Invocation.VerifyArgumentsCompat): Ditto.
9497 (Invocation.EmitArguments): Changed to correctly emit params arguments at
9500 * parameter.cs (HasParams): Don't assume that params is the last one.
9502 * support.cs (ReflectionParameters.ctor): Look for params attribute
9504 (ReflectionParameters.ParameterType): Removed hack when we returned last
9505 parameter for out of range parameters.
9506 (ParameterName, ParameterModifier): Ditto.
9508 2006-12-14 Marek Safar <marek.safar@gmail.com>
9510 A fix for bug #79987
9511 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
9512 when assembly is not CLS compliant but type is. I have no idea why is this
9515 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
9517 2006-12-13 Miguel de Icaza <miguel@novell.com>
9519 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
9520 in struct constructors, they are basically no-ops.
9522 2006-12-12 Marek Safar <marek.safar@gmail.com>
9524 * cs-tokenizer.cs (Position): Save preprocessor status too.
9526 2006-12-12 Marek Safar <marek.safar@gmail.com>
9528 A fix for bug #77794
9529 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
9531 2006-12-12 Marek Safar <marek.safar@gmail.com>
9533 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
9535 (pp_expr): Report error for an invalid expression.
9536 (handle_preprocessing_directive): Simplified; add more error checking.
9538 2006-12-11 Marek Safar <marek.safar@gmail.com>
9540 A fix for bug #74939
9541 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9542 directives handling.
9544 2006-12-10 Marek Safar <marek.safar@gmail.com>
9546 A fix for bugs #80093, and #75984
9547 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9548 logic, it seems to me as it worked before "by coincidence".
9549 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9550 (cleanup): Enabled endif check.
9552 2006-12-09 Marek Safar <marek.safar@gmail.com>
9554 A fix for bug #80162
9555 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9556 enumerators are never ambiguous.
9558 2006-12-08 Raja R Harinath <rharinath@novell.com>
9561 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9563 2006-12-06 Marek Safar <marek.safar@gmail.com>
9565 A fix for bug #80144
9566 * class.cs (EventProperty.Define): Explicit implementation means
9567 that an even is used.
9569 2006-12-06 Marek Safar <marek.safar@gmail.com>
9571 Fixes the operators implementation (part II)
9573 * cfold.cs (DoConstantNumericPromotions): Renamed to
9574 DoBinaryNumericPromotions and simplified.
9575 (BinaryFold): Couple of conversion fixes; simplified.
9577 * constant.cs, ecore.cs, literal.cs
9578 (ToType): Renamed to ConvertImplicitly.
9579 (Reduce): Renamed to ConvertExplicitly.
9581 * class.cs, convert.cs: Updated.
9583 * expression.cs: TryReduce doesn't throw an exception.
9585 2006-12-01 Marek Safar <marek.safar@gmail.com>
9587 A fix for bug #80108
9588 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9591 2006-11-30 Marek Safar <marek.safar@gmail.com>
9593 Fixes unary operators implementation (part I)
9596 * cfold.cs (Error_CompileTimeOverflow): Made internal
9598 * const.cs (IConstant): Changed to use reference to constant and
9599 not constant itself.
9600 Updated IConstant implementations.
9602 * constant.cs (CreateConstant): New factory method.
9603 Updated IConstant implementation.
9605 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9607 * ecore.cs: Updated to use CreateConstantReference.
9609 * enum.cs: Reflects IConstant changes.
9611 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9613 * literal.cs (NullConstant): Change to be independently usable.
9615 2006-11-29 Martin Baulig <martin@ximian.com>
9617 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9618 we need to emit the scope initializer before calling the base .ctor.
9620 * anonymous.cs: Merged back from the new anonymous methods branch.
9621 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9623 * expression.cs (ParameterReference.DoResolveBase): Create a
9624 "normal" ScopeInfo when capturing parameters rather than using the
9625 root scope; this makes things work with anonymous methods having
9629 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9631 2006-11-22 Marek Safar <marek.safar@gmail.com>
9633 A fix for bug #79987
9634 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9635 check to a base class.
9636 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9637 only when assembly has missing attribute.
9638 * report.cs: Update.
9640 2006-11-21 Marek Safar <marek.safar@gmail.com>
9642 * cs-tokenizer.cs: Merged with gmcs version.
9644 2006-11-20 Marek Safar <marek.safar@gmail.com>
9647 * cs-parser.jay: Better error message when partial keyword is misplaced.
9649 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9651 A fix for bug #79810
9652 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9653 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9654 a RuntimeWrappedException by default.
9656 2006-11-18 Marek Safar <marek.safar@gmail.com>
9658 A fix for bug #79843
9659 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9661 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9663 2006-11-18 Marek Safar <marek.safar@gmail.com>
9665 * driver.cs, namespace.cs: Uses faster IndexOf version.
9667 2006-11-17 Marek Safar <marek.safar@gmail.com>
9669 A fix for bug #79941
9670 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9672 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9673 even if internal name is different.
9674 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9675 (UserDefinedConversion): Simplified as the operators cannot be internal.
9676 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9678 (MethodLookup): Replaced EmitContext with parentType.
9679 * expression.cs: Updated.
9681 2006-11-09 Raja R Harinath <rharinath@novell.com>
9683 * driver.cs (BadAssembly): Handle all the ugliness of
9684 DefineDynamicAssembly.
9686 2006-11-08 Raja R Harinath <rharinath@novell.com>
9688 Address parts of #58244 -- most of what's left is in the runtime
9689 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9690 CS1509 error checks, and handle them for all assembly loads, not
9691 just the first invocation.
9692 (LoadModule): Likewise. Move handling of 'adder_method' ...
9693 * codegen.cs (AssemblyClass.AddModule): ... here.
9695 2006-11-02 Marek Safar <marek.safar@gmail.com>
9697 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9698 IEnumerable<T> is ambiguous.
9700 2006-10-31 Marek Safar <marek.safar@gmail.com>
9702 A fix for bug #67689
9703 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9704 GetEnumerator is ambiguous.
9706 * report.cs: Add new warning.
9708 2006-10-29 Marek Safar <marek.safar@gmail.com>
9710 A fix for bug #78602
9711 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9712 to protected member can be nested type.
9714 2006-10-28 Marek Safar <marek.safar@gmail.com>
9716 A fix for bug #78965
9717 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9718 to protected member must derive from current type.
9720 2006-10-27 Marek Safar <marek.safar@gmail.com>
9722 assign.cs: Reuses error method.
9724 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9725 instead of type for constants.
9726 (Expression.Error_ValueAssignment): Common error method.
9728 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9731 2006-10-27 Marek Safar <marek.safar@gmail.com>
9733 A fix for bug #79081
9734 * expression.cs (MemberAccess.DoResolve): Check nested type
9737 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9739 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9741 2006-10-26 Marek Safar <marek.safar@gmail.com>
9743 A fix for bug #76591
9744 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9746 2006-10-26 Marek Safar <marek.safar@gmail.com>
9748 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9749 type forwarder of the same type multiple times.
9751 2006-10-26 Raja R Harinath <rharinath@novell.com>
9754 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9755 instance as an rvalue, even when we later resolve as an lvalue.
9757 2006-10-25 Martin Baulig <martin@ximian.com>
9759 * anonymous.cs: Fix #79673.
9761 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9763 A fix for bug #79666
9764 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9765 ignored when is optimized (= default value) as its value is already set.
9767 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9769 A fix for bug #79724
9770 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9771 TypeContainer for type lookup.
9773 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9775 A fix for bug #79231
9776 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9777 * expression.cs (OverloadResolve): Always convert type name for
9779 (ResolveNamespaceOrType): Don't confuse a nested type with any
9782 2006-10-18 Martin Baulig <martin@ximian.com>
9784 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9786 2006-10-17 Miguel de Icaza <miguel@novell.com>
9788 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9789 an int32, but requesting an int64 from the conversion
9791 2006-10-12 Martin Baulig <martin@ximian.com>
9794 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9796 2006-10-12 Martin Baulig <martin@ximian.com>
9799 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9801 2006-10-11 Miguel de Icaza <miguel@novell.com>
9803 * convert.cs: Remove broken code: I was doing the "Existance"
9804 tests for Implicit conversions.
9806 2006-10-10 Miguel de Icaza <miguel@novell.com>
9808 * convert.cs: Added one missing case in
9809 ImplicitStandardConversionExists uint64 to intptr.
9813 * typemanager.cs (uintptr_type): another core known type.
9815 * ecore.cs (OperatorCast): routine used to do cast operations that
9816 depend on op_Explicit. We could change some of the Decimal
9817 conversions to use this.
9819 This one has a probe mechanism that checks both types for an op_
9820 which it coudl be used to eliminate two classes: CastToDecimal
9821 and CastFromDecimal.
9823 * convert.cs: Implement the conversions documented in #59800
9825 2006-10-10 Martin Baulig <martin@ximian.com>
9827 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9828 before RootScope.ResolveMembers().
9830 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9831 `CurrentType' if appropriate.
9833 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9835 A fix for bug #78568
9836 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9837 when contains binary operators.
9838 * cs-parser.jay: Updated.
9840 2006-10-09 Martin Baulig <martin@ximian.com>
9843 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9844 moved that into Define() and also do the other type parameter
9845 checks there. Fixes #79094. Added gtest-292.cs.
9848 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9849 since that doesn't include type parameters; don't use `Ldelema'
9850 for type parameters. Fixes #78980. Added gtest-293.cs.
9852 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9855 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9856 conversion is allowed.
9858 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9860 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9861 error reporting when no error occurs.
9863 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9865 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9868 2006-10-06 Raja R Harinath <rharinath@novell.com>
9871 * class.cs (DefineTypeBuilder): Check circular dependencies before
9872 setting the parent of the TypeBuilder.
9873 (CheckRecursiveDefinition): Don't use 'BaseType', since
9874 it may not be valid until after DefineTypeBuilder. Use
9875 'base_type' instead.
9877 2006-10-04 Martin Baulig <martin@ximian.com>
9879 Merged the Anonymous Methods patch.
9881 * anonymous.cs, iterators.cs: The new anonymous methods code.
9883 * statement.cs (Variable): New public abstract class.
9884 (LocalInfo.Variable): New public property.
9885 (LocalInfo.ResolveVariable): New public method.
9886 (Block.Flags): Add `IsIterator'.
9887 (Block.AddVariable): Improved the CS0136 check.
9888 (Block.AnonymousChildren): New public property.
9889 (Block.AddAnonymousChild): New public method.
9890 (ToplevelBlock): Update to use the new anonymous method framework.
9891 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9892 `ToplevelBlock'; this is required to correctly implement the
9894 (Fixed, Using): Use `TemporaryVariable' instead of directly
9895 creating the `LocalBuilder'.
9897 * parameter.cs (Parameter.ResolveVariable): New public method.
9898 (Parameters.ResolveVariable): Likewise.
9900 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9902 * class.cs (TypeContainer): Replaced the `iterators' list and
9903 corresponding methods with a list of `CompilerGeneratedClass'es.
9904 (TypeContainer.ResolveMembers): New public method.
9905 (Method): `IIteratorContainer' has been replaced by
9908 * expression.cs (VariableReference): New public abstract base
9909 class for `LocalVariableReference', `ParameterReference' and
9912 * codegen.cs (EmitContext): Removed `capture_context',
9913 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9914 (EmitContext.EmitThis): Removed.
9916 * cs-parser.jay: Replace `iterator_container' with
9919 2006-10-04 Martin Baulig <martin@ximian.com>
9921 * generic.cs (GenericMethod): Don't make this abstract.
9922 (Constraints.Clone): Added dummy implementation.
9924 2006-10-04 Raja R Harinath <harinath@gmail.com>
9927 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9928 'declspaces'. Avoid allocating arrays willy-nilly.
9931 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9932 cases out of the switch.
9934 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9936 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9937 message when non-generic type is used with the type arguments.
9938 * expression.cs: Updated.
9940 2006-09-28 Raja R Harinath <rharinath@novell.com>
9943 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9944 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9945 Change semantics slightly. Don't insist on having only one
9946 temporary EmptyExpression -- just throttle the creation of new ones.
9949 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9950 non-interfaces too. If no methods are found, don't try to create
9953 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9955 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9958 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9959 us produce better error message.
9961 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9963 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9964 of the `|' operator.
9966 * report.cs: A new warning added.
9968 2006-09-27 Martin Baulig <martin@ximian.com>
9970 * generic.cs (GenericMethod): Don't make this abstract.
9972 2006-09-27 Martin Baulig <martin@ximian.com>
9975 (InternalErrorException): Added overloaded ctor taking a params array.
9977 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9979 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9980 Fixed the cases when same error was reported twice.
9982 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9983 now report symbol information.
9985 2006-09-25 Martin Baulig <martin@ximian.com>
9987 * class.cs: Completely unified with the gmcs version.
9989 2006-09-25 Martin Baulig <martin@ximian.com>
9991 * typemanager.cs (TypeManager.IsNullableType): New public function.
9992 (TypeManager.IsNullableTypeOf): Likewise.
9993 (TypeManager.IsNullableValueType): Likewise.
9995 * class.cs (MethodCore): Added the `GenericMethod' argument from
9996 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9998 2006-09-24 Raja R Harinath <harinath@gmail.com>
10000 * convert.cs: Unify with gmcs version.
10002 2006-09-24 Marek Safar <marek.safar@seznam.cz>
10004 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
10005 verify them as well.
10007 * report.cs: New warning.
10009 2006-09-24 Marek Safar <marek.safar@seznam.cz>
10011 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
10012 for anonymous block with out argument.
10014 2006-09-24 Marek Safar <marek.safar@seznam.cz>
10016 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
10017 not used private events only.
10019 2006-09-23 Marek Safar <marek.safar@seznam.cz>
10021 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
10023 * const.cs (Const.Define): Check for constant type.
10024 (Const.IsConstantTypeValid): Looks for valid constant types.
10026 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
10028 * ecore.cs (EmptyConstantCast): New common class for all constant based
10031 * expression.cs (Is.DoResolve): Handle null constant especially.
10032 (New.DoResolve): Check for new void().
10033 (MemberAccess.DoResolve): Cope with all kind of nulls.
10035 * literal.cs (NullConstant): Uses EmptyConstantCast.
10036 (NullDefault): Based on EmptyConstantCast.
10037 (NullLiteral): Uses EmptyConstantCast.
10039 * statement.cs (Block.ResolveMeta): Check for constant type.
10041 2006-09-22 Martin Baulig <martin@ximian.com>
10043 * delegate.cs, attribute.cs: Merged with the gmcs versions.
10045 2006-09-22 Raja R Harinath <rharinath@novell.com>
10047 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
10051 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
10052 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
10055 2006-09-22 Martin Baulig <martin@ximian.com>
10057 * ecore.cs: Merged with the gmcs version.
10059 * generic.cs (ConstructedType): New dummy class.
10060 (TypeArguments): Don't make this abstract.
10063 (TypeManager.IsGenericTypeDefinition): New method.
10064 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
10066 2006-09-22 Raja R Harinath <rharinath@novell.com>
10068 * expression.cs (ComposedCast): Check for arrays of TypedReference
10069 before creating the type, not after.
10071 2006-09-21 Marek Safar <marek.safar@seznam.cz>
10073 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
10074 after ToType change.
10076 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
10077 when constant must be implicitly convertible.
10079 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
10081 * ecore.cs (NullCast): Derives from NullConstant.
10083 * expression.cs (Is.DoResolve): Removed useless variables.
10084 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
10085 (New.Constantify): Add enum support.
10086 (MemberAccess.DoResolve): Add warning when accessing null constant or
10089 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
10092 * literal.cs (NullConstant): New abstract class with common
10093 functionality for all null specializations.
10094 (NullDefault): Represents default(X) when result can be
10096 (NullLiteral): Updated.
10098 * report.cs: Add new warning.
10100 2006-09-21 Martin Baulig <martin@ximian.com>
10102 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
10104 2006-09-21 Martin Baulig <martin@ximian.com>
10106 * generic.cs (GenericConstraints): New dummy class.
10107 (Constraints): Likewise.
10108 (TypeParameter): Likewise.
10109 (TypeParameterName): Likewise.
10110 (GenericMethod): Likewise.
10112 * typemanager.cs (TypeManager.GetGenericArguments): New method.
10114 * decl.cs: Merged with the gmcs version.
10116 2006-09-21 Raja R Harinath <rharinath@novell.com>
10118 * generic.cs (TypeParameter): Implement IMemberContainer.
10119 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
10121 * rootcontext.cs: Unify with gmcs version.
10123 * report.cs: Unify with gmcs version.
10124 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
10125 from gmcs/generics.cs.
10126 * generics.cs (TypeParameter): New dummy class.
10128 * support.cs: Unify with gmcs version.
10130 2006-09-20 Raja R Harinath <rharinath@novell.com>
10132 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
10133 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
10135 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
10136 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
10137 * mcs.exe.sources: Add generic.cs.
10139 * codegen.cs: Unify with gmcs version.
10141 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
10142 (EmitContext): Add GenericDeclContainer implementation.
10143 * decl.cs (MemberCore, DeclSpace): Likewise.
10144 * namespace.cs: Remove #ifdef GMCS_SOURCE.
10146 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
10147 MCS TypeManager has a corresponding dummy method.
10149 2006-09-19 Martin Baulig <martin@ximian.com>
10151 * expression.cs: Completely merged with the gmcs version.
10153 2006-09-19 Martin Baulig <martin@ximian.com>
10155 * expression.cs (Invocation): Merged with the gmcs version.
10156 (ArrayAccess.GetStoreOpcode): Likewise.
10158 2006-09-19 Martin Baulig <martin@ximian.com>
10161 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
10162 (TypeManager.IsGenericMethodDefinition): Likewise.
10164 2006-09-19 Martin Baulig <martin@ximian.com>
10167 (TypeManager.IsEqual): Moved the gmcs implementation here.
10168 (TypeManager.DropGenericTypeArguments): Likewise.
10169 (TypeManager.DropGenericMethodArguments): Likewise.
10170 (TypeManager.GetTypeArguments): Moved here from gmcs.
10171 (TypeManager.HasGenericArguments): Likewise.
10173 2006-09-19 Martin Baulig <martin@ximian.com>
10175 * expression.cs (Binary): Merged with the gmcs version.
10177 2006-09-19 Martin Baulig <martin@ximian.com>
10179 * expression.cs (Probe, As, Is): Merged with the gmcs version.
10181 2006-09-19 Martin Baulig <martin@ximian.com>
10183 * typemanager.cs: Merged with the gmcs version.
10185 2006-09-16 Raja R Harinath <rharinath@novell.com>
10187 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
10188 * driver.cs: Likewise.
10190 2006-09-16 Marek Safar <marek.safar@seznam.cz>
10193 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
10194 only if parent type is class.
10195 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
10198 2006-09-15 Marek Safar <marek.safar@seznam.cz>
10201 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
10203 * typemanager.cs(CSharpName): Converts NullType to null.
10205 2006-09-15 Martin Baulig <martin@ximian.com>
10208 (TypeManager.GetMethodName): Added mcs implementation.
10209 (TypeManager.IsEqual): Likewise.
10212 (SimpleName.RemoveGenericArity): Added dummy implementation.
10214 * pending.cs: Merged with the gmcs version.
10216 2006-09-15 Martin Baulig <martin@ximian.com>
10218 * statement.cs: Merge with the gmcs version.
10220 2006-09-15 Martin Baulig <martin@ximian.com>
10222 * statement.cs (Switch): Merge with the gmcs implementation
10223 (without nullables), which is newer.
10225 2006-09-15 Martin Baulig <martin@ximian.com>
10227 * statement.cs (Block.Variables): Make this public.
10228 (ToplevelBlock.Parameters): Make this a property.
10229 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
10231 2006-09-15 Martin Baulig <martin@ximian.com>
10233 * namespace.cs: Merge with the gmcs version.
10235 2006-09-15 Martin Baulig <martin@ximian.com>
10237 * decl.cs (MemberName): Minor code cleanups.
10239 2006-09-15 Martin Baulig <martin@ximian.com>
10241 * parameter.cs: Merge with the gmcs version.
10243 2006-09-15 Martin Baulig <martin@ximian.com>
10245 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
10246 and an error in mcs.
10248 2006-09-15 Martin Baulig <martin@ximian.com>
10250 * flowanalysis.cs: Merged from GMCS; added the generics code into
10251 a `GMCS_SOURCE' conditional so we can share this file.
10253 2006-09-08 Martin Baulig <martin@ximian.com>
10255 * typemanager.cs (TypeManager.interlocked_type): New public field.
10256 (TypeManager.int_interlocked_compare-exchange): New public field.
10257 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
10258 enumerator types here and call InitGenericCoreTypes().
10259 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
10260 after calling InitEnumUnderlyingTypes().
10263 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
10264 `classes_second_stage'.
10266 2006-09-14 Marek Safar <marek.safar@seznam.cz>
10268 * assign.cs, ecore.cs, expression.cs: Share error message text.
10269 * class.cs (FieldMember.Define): Check for varible of static type.
10270 * driver.cs (LoadAssembly): Uses error output for errors.
10271 * statement.cs: Updated.
10273 2006-09-08 Marek Safar <marek.safar@seznam.cz>
10275 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
10278 2006-09-07 Martin Baulig <martin@ximian.com>
10281 (MainDriver): Revert r62663 from Marek; see #70506 for details.
10283 2006-08-29 Miguel de Icaza <miguel@novell.com>
10285 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
10287 2006-08-17 Miguel de Icaza <miguel@novell.com>
10289 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
10290 #52019 and #79064, the use of the \uXXXX sequence in source code
10291 to represent unicode characters.
10293 2006-08-15 Marek Safar <marek.safar@seznam.cz>
10295 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
10297 * class.cs, ecore.cs, statement.cs: Merged to one error message.
10299 2006-08-13 Miguel de Icaza <miguel@novell.com>
10301 * assign.cs: Catch attempts to assign to a method groups in += and
10304 2006-08-13 Marek Safar <marek.safar@seznam.cz>
10307 * cs-parser.jay: Don't destroy current array type by typeof of array's.
10309 2006-08-12 Marek Safar <marek.safar@seznam.cz>
10311 * class.cs (Method.Define): Issue a warning when generic method looks like
10313 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
10316 2006-08-09 Marek Safar <marek.safar@seznam.cz>
10318 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
10320 * decl.cs (MemberCache.FindMembers): When container is interface we need to
10321 search all base interfaces as a member can be ambiguous.
10322 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
10323 Constructor member type filter.
10324 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
10325 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
10326 reporting for returned memberinfos.
10327 * report.cs: Updated.
10328 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
10329 version to work on all runtimes.
10330 (TypeManager.RealMemberLookup): Removed members filtering.
10332 2006-08-08 Raja R Harinath <rharinath@novell.com>
10334 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
10335 (PropertyExpr.EmitAssign): Likewise.
10336 * expression.cs (Indirection.EmitAssign): Likewise.
10337 (LocalVariableReference.EmitAssign): Likewise.
10338 (ParameterReference.EmitAssign): Likewise.
10339 (Invocation.EmitArguments): Likewise.
10340 (ArrayAccess.EmitAssign): Likewise.
10341 (IndexerAccess.EmitAssign): Likewise.
10342 (This.EmitAssign): Likewise.
10343 (ConditionalLogicalOperator.Emit): Likewise.
10346 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
10347 instead of ArrayList. If the hashtable has a LocalBuilder, don't
10348 leave it in after returning it.
10349 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
10351 2006-08-06 Marek Safar <marek.safar@seznam.cz>
10353 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
10356 2006-08-03 Raja R Harinath <rharinath@novell.com>
10358 Fix cs0146-3.cs and cs0146-4.cs.
10359 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
10360 enclosing types don't depend on the current type.
10362 2006-08-02 Raja R Harinath <rharinath@novell.com>
10365 * class.cs (TypeContainer.DoDefineMembers): Use
10366 FindBaseMemberWithSameName on Parent, since we're interested in
10367 whether we hide inherited members or not.
10368 (FindBaseMemberWithSameName): Make slightly more robust.
10370 Fix the non-generic testcase from #77396
10371 * decl.cs (DeclSpace.DeclContainer): Remove override.
10373 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
10374 declspaces for doppelgangers too.
10375 (UsingEntry): Implement IResolveContext.
10376 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
10377 'this' as the resolve context.
10378 (LocalAliasEntry): Likewise.
10380 Implement parts of #77403
10381 * roottypes.cs (RootDeclSpace): New. Used to represent the
10382 toplevel declaration space. Each namespace declaration introduces
10383 a "partial" root declaretion space.
10384 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
10385 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
10386 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
10387 from 'current_namespace.SlaveDeclSpace'.
10388 (namespace_declaration): Likewise.
10389 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
10390 check. It can't happen now.
10391 * decl.cs (DeclSpace.LookupType): Likewise.
10392 * driver.cs (MainDriver): Sanity check.
10394 2006-08-01 Raja R Harinath <rharinath@novell.com>
10396 * decl.cs (DeclSpace.FindNestedType): Remove.
10397 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
10398 LookupTypeContainer to get the container of the nested type.
10399 * class.cs (TypeContainer.FindNestedType): Make non-override.
10401 2006-07-31 Raja R Harinath <rharinath@novell.com>
10403 * decl.cs (DeclSpace.PartialContainer): Move field from ...
10404 * class.cs (TypeContainer.PartialContainer): ... here.
10405 (TypeContainer.AddBasesForPart): New helper.
10406 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
10408 * cs-parser.jay (current_class): Convert to DeclSpace.
10409 (struct_declaration, interface_declaration, class_declaration):
10410 Use AddBasesForPart instead of .Bases directly.
10411 * const.cs, iterators.cs: Update to changes.
10413 2006-07-28 Raja R Harinath <rharinath@novell.com>
10415 * class.cs (TypeContainer.AddMemberType): Rename from
10416 AddToTypeContainer.
10417 (TypeContainer.AddMember): Rename from AddToMemberContainer.
10418 (AddTypeContainer): New. Combine AddClassOrStruct and
10420 (AddPartial): Update. Add 'is_partial' argument.
10421 * roottypes.cs: Update to changes.
10422 * cs-parser.jay (push_current_class): New helper for handling
10423 current_container and current_class.
10424 (struct_declaration, interface_declaration, class_declaration):
10427 2006-07-26 Raja R Harinath <rharinath@novell.com>
10429 * roottypes.cs: Rename from tree.cs.
10431 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
10432 * tree.cs (Tree, ITreeDump): Remove types.
10433 * rootcontext.cs (tree, Tree): Remove fields.
10434 (root, ToplevelTypes): New.
10435 * *.cs: Update to rename.
10437 * tree.cs (Tree.RecordDecl): Remove.
10438 (RootTypes.AddToTypeContainer): Record the toplevel type in its
10440 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
10442 2006-07-23 Raja R Harinath <harinath@gmail.com>
10444 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
10445 DoFlowAnalysis and OmitStructFlowAnalysis here.
10446 (ec.With): Rename from WithUnsafe and generalize.
10447 (ec.WithCheckState): Remove. All users can be handled by 'With'.
10448 (ec.WithFlowAnalyis): New.
10449 * ecore.cs, expression.cs, statement.cs: Update.
10451 2006-07-22 Raja R Harinath <harinath@gmail.com>
10453 * statement.cs (Block.ResolveMeta): Simplify slightly.
10455 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
10456 multiple boolean fields. Convert InUnsafe, constant_check_state,
10457 check_state to flags.
10458 (CheckState, ConstantCheckState): Update.
10459 (InUnsafe): New read-only property.
10460 (FlagsHandle): Rename from CheckStateHandle and convert to handle
10462 (WithUnsafe): New helper similar to WithCheckState.
10463 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
10464 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
10466 2006-07-21 Raja R Harinath <rharinath@novell.com>
10468 Make comparisons use the same IL irrespective of whether they're
10469 in a 'checked' or 'unchecked' context: one of the issues in #78899
10470 * codegen.cs (EmitContext.CheckState): Make read-only property.
10471 (EmitContext.ConstantCheckState): Likewise.
10472 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
10473 helper that implement a save/restore stack for CheckState
10474 values. This is the only way to change check-state.
10475 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
10476 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
10477 (CheckedExpr.EmitBranchable): New forwarding method.
10478 (UnCheckedExpr): Likewise.
10479 * statement.cs (Block.ResolveMeta): Use WithCheckState.
10480 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
10481 (Checked.Resolve, checked.DoEmit): Likewise.
10483 2006-07-20 Miguel de Icaza <miguel@novell.com>
10485 * anonymous.cs: Cache the resolved anonymous delegate, and return
10486 this so that the ResolveTopBlock is only triggered once, not
10489 Currently we trigger ResolvetopBlock twice due to a first pass of
10490 argument check compatibility, and a second pass that does the
10493 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10495 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
10497 * rootcontext.cs (Reset): Add helper_classes.
10499 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10502 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
10505 2006-07-13 Miguel de Icaza <miguel@novell.com>
10507 * statement.cs (Lock): Handle expressions of type
10508 TypeManager.null_type specially. Fixes #78770
10510 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10512 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
10515 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10517 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
10518 for accessors as well.
10519 * ecore.cs (EventExpr): Add AccessorTable.
10521 2006-07-01 Marek Safar <marek.safar@seznam.cz>
10524 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
10525 for CS0122 where appropriate.
10526 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
10528 (Filter): Assembly can be null in the case of top level attributes.
10530 2006-06-25 Marek Safar <marek.safar@seznam.cz>
10534 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
10535 is done at global level.
10537 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10539 A fix for #77002, Implemented TypeForwarder support.
10541 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10542 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10543 * typemanager.cs (): Add type_forwarder_attr_type.
10545 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10547 * report.cs: Add CS0469 warning.
10549 2006-06-21 Martin Baulig <martin@ximian.com>
10551 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10552 the `try'-block, so we also report CS0016 etc. there.
10554 2006-06-21 Martin Baulig <martin@ximian.com>
10557 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10559 2006-06-21 Martin Baulig <martin@ximian.com>
10561 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10562 also report CS1686 for parameters.
10564 2006-06-21 Martin Baulig <martin@ximian.com>
10566 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10567 instead of an error if the value is not implicitly convertible to
10568 the switch types; fixes #77964.
10570 2006-06-21 Raja R Harinath <rharinath@novell.com>
10573 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10574 FieldBuilder is null.
10577 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10578 'left' and 'right' before error-checking.
10580 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10582 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10584 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10585 (FieldExpr.DoResolve): likewise.
10586 (PropertyExpr.InstanceResolve): likewise.
10587 (EventExpr.InstanceResolve): likewise.
10589 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10591 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10592 attribute applicable tests for attribute argument.
10594 2006-06-02 Raja R Harinath <rharinath@novell.com>
10597 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10598 (Binary.OverloadResolve_PredefinedIntegral): New.
10599 (Binary.OverloadResolve_PredefinedFloating): New.
10600 (Binary.OverloadResolve_PredefinedString): New.
10601 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10602 Follow the standard more closely, and treat numeric promotions in
10603 terms of overload resolution.
10604 (Binary.CheckShiftArguments): Simplify.
10606 2006-06-01 Raja R Harinath <rharinath@novell.com>
10608 * flowanalysis.cs (MyBitVector): Simplify representation.
10609 (MyBitVector.Clone): Avoid allocating BitArray.
10610 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10611 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10612 (*): Update. Change all references to MyBitVector.And and
10613 MyBitVector.Or to &= and |=.
10615 2006-05-29 Raja R Harinath <rharinath@novell.com>
10617 Fix cs0231-[34].cs.
10618 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10619 to param arguments too.
10621 2006-05-26 Miguel de Icaza <miguel@novell.com>
10623 * cs-parser.jay: Catch another parsing form for arglist being
10624 followed by other arguments. Fixes #78313.
10626 2006-05-24 Raja R Harinath <rharinath@novell.com>
10628 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10629 checking of out parameters to ...
10630 (FlowBranchingToplevel.Merge): ... here.
10631 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10632 set, propagate the origin upward, and only complain if there was
10634 (FlowBranchingException.AddContinueOrigin): Likewise.
10635 (FlowBranchingException.AddReturnOrigin): Likewise.
10636 (FlowBranchingException.AddGotoOrigin): Likewise.
10638 2006-05-23 Raja R Harinath <rharinath@novell.com>
10640 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10641 unreachable, skip it.
10642 (FlowBranchingException.Merge): Always propagate jumps, even if
10643 the finally block renders subsequent code unreachable.
10645 2006-05-18 Raja R Harinath <rharinath@novell.com>
10648 * statement.cs (Goto.Resolve): Move responsibility for resolving
10649 'goto' to FlowBranching.AddGotoOrigin.
10650 (Goto.SetResolvedTarget): New. Callback to set the
10651 LabeledStatement that's the target of the goto.
10652 (Goto.DoEmit): Use Leave instead of Br when crossing an
10653 unwind-protect boundary.
10654 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10655 LookupLabel and adjust to new semantics.
10656 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10657 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10658 Goto.SetResolvedTarget to update target.
10659 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10660 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10661 AddBreakOrigin & co. Delay propagation until ...
10662 (FlowBranchingException.Merge): ... this.
10664 * statement.cs (Block.Resolve): Always depend on flow-branching to
10665 determine unreachability. Kill workaround that originally emitted
10666 only one statement after an "unreachable" label (see infloop in
10669 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10670 This is still "wrong", but anything better would probably need a
10671 multi-pass algorithm.
10672 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10673 usage vector. Force current usage vector to be reachable, to
10674 optimistically signify backward jumps.
10675 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10677 (FlowBranchingLabeled.Merge): New. If no backward jump was
10678 detected, return the original salted-away usage vector instead,
10679 updated with appropriate changes. Print unreachable warning if
10681 * statement.cs (Block.Resolve): Don't print unreachable warning on
10682 a labeled statement.
10684 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10686 * driver.cs: Pass filename without path to AssemblyBuilder's
10687 AddResourceFile. Fixes bug #78407.
10689 2006-05-17 Raja R Harinath <rharinath@novell.com>
10691 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10692 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10693 (FlowBranching.MergeChild): Overwrite
10694 reachability information from Labeled branchings too.
10696 2006-05-16 Raja R Harinath <rharinath@novell.com>
10698 * statement.cs (Goto.Resolve): Merge jump origins here ...
10699 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10701 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10702 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10703 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10704 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10706 * statement.cs (Goto.Resolve): ... not here.
10707 (Goto.Emit): Remove CS1632 check.
10709 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10711 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10714 2006-05-11 Raja R Harinath <rharinath@novell.com>
10716 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10717 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10718 (FlowBranchingException.Label): Likewise.
10720 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10722 (MyBitVector.Or): Use it to avoid losing information (Count).
10723 (FlowBranching.MergeOrigins): Likewise.
10725 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10726 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10727 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10728 (UsageVector.ToString): Simplify.
10729 (UsageVector.MergeSiblings): Move here from ...
10730 (FlowBranching.Merge): ... here.
10731 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10734 2006-05-10 Raja R Harinath <rharinath@novell.com>
10736 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10737 null bitvector is treated as all-true.
10739 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10740 (MyBitVector): Rationalize invariants. 'vector != null' implies
10741 that we have our own copy of the bitvector. Otherwise,
10742 'InheritsFrom == null' implies all inherited bits are true.
10744 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10746 * statement.cs (LocalInfo): Add IsConstant.
10747 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10748 local variable for constants.
10750 2006-05-09 Raja R Harinath <rharinath@novell.com>
10752 * flowanalysis.cs (MyBitVector.Empty): New.
10753 (MyBitVector): Don't allow InheritedFrom to be null.
10754 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10755 (UsageVector, FlowBranching): Update to changes.
10757 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10758 recursion. The 'Parent == null' condition isn't sufficient for
10760 (FlowBranching.AddBreakOrigin): Likewise.
10761 (FlowBranching.AddContinueOrigin): Likewise.
10762 (FlowBranching.AddReturnOrigin): Likewise.
10763 (FlowBranching.StealFinallyClauses): Likewise.
10764 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10765 (FlowBranching.CheckOutParameters): Likewise.
10766 (FlowBranchingToplevel): Terminate all the above recursions here.
10767 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10768 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10770 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10772 (FlowBranchingToplevel): New. Empty for now.
10773 (FlowBranching.MergeTopBlock): Update.
10774 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10775 branching for the anonymous delegate.
10776 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10778 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10779 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10780 information at the start of the merge. Reorganize.
10782 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10784 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10786 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10788 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10789 to newly introduced ctor.
10791 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10792 message to one place.
10793 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10796 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10798 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10800 * ecore.cs (Expression.ResolveAsConstant): Updated.
10802 * statement.cs (ResolveMeta): Updated.
10804 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10806 * cs-parser.jay: __arglist cannot be used in initializer.
10808 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10811 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10814 2006-05-05 Raja R Harinath <rharinath@novell.com>
10816 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10817 (LabeledStatement): Add 'name' parameter.
10818 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10819 (Block.AddLabel): Update to changes.
10820 * cs-parser.jay (labeled_statement): Likewise.
10822 * flowanalysis.cs (BranchingType.Labeled): New.
10823 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10824 (FlowBranchingLabeled): New. Does nothing for now, but will
10825 eventually handle 'goto' flows.
10826 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10827 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10828 that's terminated ...
10829 (Block.Resolve): ... here.
10831 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10832 (UsageVector.MergeFinallyOrigins): Likewise.
10833 (FlowBranching.InTryOrCatch): Likewise.
10834 (FlowBranching.AddFinallyVector): Likewise.
10835 (FlowBranchingException): Update to changes.
10838 * statement.cs (Return.Resolve): Move error checking to ...
10839 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10840 (FlowBranchingException): Handle return origins like break and
10842 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10844 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10847 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10850 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10853 * class.cs (MethodData.Define): Do public accessor check only when method
10854 implements an interface.
10856 2006-05-04 Raja R Harinath <rharinath@novell.com>
10858 Remove special handling of 'break'
10859 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10860 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10861 (UsageVector.Break): Remove.
10862 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10864 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10866 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10867 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10869 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10872 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10873 be the interface member.
10875 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10878 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10879 for emitting small (int) values.
10881 2006-05-03 Raja R Harinath <rharinath@novell.com>
10884 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10885 control-flow passes through the 'finally' after merging-in all the
10886 control-flows from 'try' and the 'catch' clauses.
10888 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10889 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10890 always true at the only non-recursive entry point.
10891 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10892 FlowBranchingBreakable.
10893 (FlowBranchingLoop): Remove.
10894 * statement.cs (Return.DoResolve): Update to changes.
10897 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10898 (FlowBranching.CreateBranching): Handle it: create a
10899 FlowBranchingContinuable.
10900 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10901 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10902 except that it handles the 'continue' command.
10903 (FlowBranching.UsageVector.MergeOrigins): Rename from
10905 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10906 except that it overrides AddContinueOrigin.
10907 (FlowBranchingException): Override AddContinueOrigin, similar to
10909 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10910 Create a new branching around the embedded statement.
10911 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10912 control flow after the embedded statement.
10913 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10915 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10916 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10917 FlowBranchingBreakable.
10918 (FlowBranchingSwitch): Remove.
10921 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10922 error reporting to ...
10923 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10924 Rename from 'AddBreakVector'. Add new location argument. Return
10925 a bool indicating whether the 'break' crosses an unwind-protect.
10926 (FlowBranchingException.AddBreakOrigin): Add.
10927 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10928 flowbranching after updating with the effects of the 'finally'
10930 (FlowBranchingBreakable): New common base class for
10931 FlowBranchingLoop and FlowBranchingSwitch.
10933 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10934 embedded statement.
10935 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10937 2006-05-02 Raja R Harinath <rharinath@novell.com>
10939 * statement.cs (Do.Resolve): If the loop is infinite, set the
10941 (While.Resolve, For.Resolve): Set a barrier after the embedded
10942 statement. There's no direct control flow that goes from the end
10943 of the embedded statement to the end of the loop.
10944 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10945 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10946 above ensure that the reachability is correctly computed.
10948 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10949 (UsageVector.MergeBreakOrigins): If the current path is
10950 unreachable, treat it as if all parameters/locals are initialized.
10951 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10952 infinite loops before merging-in break origins.
10954 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10955 (Reachability.Reachable): Split part into ...
10956 (Reachability.Unreachable): ... this. Simplify.
10957 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10959 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10960 (Reachability.SetThrowsSometimes): Likewise.
10961 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10962 TriState.Always, use corresponding property.
10963 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10964 (Block.Resolve): Likewise. Remove some redundant checks.
10966 2006-05-02 Raja R Harinath <harinath@gmail.com>
10968 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10969 (Reachability.Meet): Don't bother checking AlwaysThrows --
10970 barrier is always set.
10971 (FlowBranchingBlock.Merge): Likewise.
10973 2006-05-01 Raja R Harinath <harinath@gmail.com>
10975 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10976 checks for unreachable.
10978 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10981 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10983 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10984 whether field is really assigned.
10986 2006-04-30 Raja R Harinath <harinath@gmail.com>
10988 * flowanalysis.cs (Reachability): Make 4-argument constructor
10990 (Reachability.Meet): Rename from 'And'. Remove static variant.
10991 (Reachability.Always): Rename from the highly misleading
10992 'Reachability.Never'.
10993 (FlowBranching.Merge): Update to changes. Mark an impossible
10994 situation with a 'throw'.
10995 (*): Update to changes.
10997 2006-04-29 Raja R Harinath <harinath@gmail.com>
10999 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
11000 Remove 'Undefined'.
11001 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
11002 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
11003 (*): Update to changes.
11004 * statement.cs: Update to changes.
11006 2006-04-28 Marek Safar <marek.safar@seznam.cz>
11009 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
11011 2006-04-28 Raja R Harinath <harinath@gmail.com>
11013 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
11016 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
11017 argument to two arguments: an usage-vector and a bool. Move call
11018 to FlowBranching.Merge () ...
11019 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
11021 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
11022 handling of loop and switch reachability to ...
11023 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
11025 2006-04-27 Raja R Harinath <harinath@gmail.com>
11027 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
11028 handling to FlowBranchingLoop.InLoop.
11029 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
11031 2006-04-26 Marek Safar <marek.safar@seznam.cz>
11034 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
11035 anonymous method is allowed from AnonymousContainer here.
11037 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
11039 2006-04-24 Raja R Harinath <rharinath@novell.com>
11042 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
11044 2006-04-23 Marek Safar <marek.safar@seznam.cz>
11047 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
11048 (DoubleConstant.Reduce): Ditto.
11050 2006-04-23 Raja R Harinath <rharinath@novell.com>
11052 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
11053 Remove 'lvalue_right_side' argument. Move parts to ...
11054 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
11055 (LocalVariable.DoResolveLValue): ... these.
11057 2006-04-21 Raja R Harinath <rharinath@novell.com>
11060 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
11061 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
11062 (LocalVariableReference.DoResolveBase): Use it to implement new
11064 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
11065 (Argument.Resolve): Simplify. Move CS1510 check ...
11066 * ecore.cs (Expression.ResolveLValue): ... here.
11067 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
11068 (PropertyExpr.DoResolveLValue): Likewise.
11069 (FieldExpr.Report_AssignToReadonly): Likewise.
11070 (FieldExpr.DoResolve): Add 'out_access' argument. Use
11071 LValueMemberAccess or LValueMemberOutAccess on instance depending
11073 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
11074 DoResolve as appropriate.
11076 2006-04-20 Raja R Harinath <rharinath@novell.com>
11079 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
11080 implicit conversions on 'out' and 'ref' arguments.
11082 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
11083 improve clarity. Remove dead code.
11086 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
11087 (Catch.Resolve): Resolve VarBlock if it exists.
11089 2006-04-19 Miguel de Icaza <miguel@novell.com>
11091 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
11092 twice, this was some residual code, the enumerator was emitted
11093 properly in the two branche of if later.
11095 2006-04-19 Raja R Harinath <rharinath@novell.com>
11097 * expression.cs (Cast.ResolveLValue): Remove. The result of a
11098 cast is never an lvalue.
11099 (Cast.DoResolve, Cast.ResolveRest): Combine.
11100 (Argument.Emit): Simplify slightly. Move 'Expr is
11101 IMemoryLocation' check ...
11102 (Argument.Resolve): ... here.
11103 (Argument.Error_LValueRequired): Remove. Inline into only user.
11105 Simplifications. Fix cs0191-2.cs
11106 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
11107 CS1649 and CS1651 to ...
11108 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
11109 the actual selection of the error code and message to a lookup
11110 table. Add a dummy return value to simplify callsites.
11111 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
11112 readonly fields of other instances of the same type. Move CS0197
11114 * expression.cs (Argument.Resolve): ... here. Simplify code.
11115 Ensure that ec.InRefOutArgumentResolving is only set during LValue
11116 resolution of an out or ref argument. The code simplification
11117 above uses this invariant.
11119 2006-04-18 Raja R Harinath <rharinath@novell.com>
11121 Possibly fix #77752. Fix cs1690-[4-7].cs.
11122 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
11123 CheckMarshallByRefAccess. Drop parameter.
11124 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
11126 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
11127 InstanceExpression.
11128 * report.cs (AllWarnings): Add CS1690.
11129 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
11130 for ref access too.
11131 (LocalVariableReference.DoResolveBase): Update.
11133 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11135 * class.cs (MethodOrOperator): Moved common parts from method class.
11136 detect obsolete attributes.
11137 (Method.Define): Simplified as it reuses code from base.
11138 (Constructor.ValidAttributeTargets): Fixed issue found during
11140 (Destructor.ValidAttributeTargets): Fixed issue found during
11142 (Operator): Finished refactoring set off by #78020. Operator class is now
11143 ordinary method class.
11145 * anonymous.cs: Updated.
11147 * decl.cs (DeclSpace): Add IsGeneric
11149 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11151 * class.cs (Constructor.Emit): Don't emit the attributes twice.
11153 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11155 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
11156 detect obsolete attributes.
11157 (Method.CreateEmitContext): Moved to MethodOrOperator.
11159 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11162 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
11163 customized exception to make crash detection easier.
11164 (MethodOrOperator): Started to work on new base class for methods and
11166 (Method): Derives from MethodOrOperator.
11167 (Constructor.Emit): Emits its own attributes.
11168 (AbstractPropertyEventMethod.Emit): Ditto.
11169 (Operator): Derives from MethodOrOperator, will refactor fully in extra
11171 (Operator.Emit): It's temporary more tricky than should be.
11173 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
11175 * report.cs (InternalErrorException): Add ctor with inner exception.
11177 2006-04-08 Marek Safar <marek.safar@seznam.cz>
11180 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
11183 2006-04-07 Marek Safar <marek.safar@seznam.cz>
11186 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
11189 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11191 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
11192 attribute is present and Guid not.
11193 (Interface.ApplyAttributeBuilder): Ditto.
11195 * attribute.cs: Add error message.
11197 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11201 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
11202 sources (it's composite) so hold them in extra array as they are used in
11203 Emit phase only. It worked in the previous versions by mistake.
11204 (Attribute.Emit): Emit attribute for more owners when exist.
11206 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
11207 it has now different behaviour.
11209 2006-04-04 Marek Safar <marek.safar@seznam.cz>
11211 * constant.cs (Constant.IsDefaultInitializer): New method.
11213 * class.cs: Updated.
11215 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
11216 re-initialize default values. It saves KBs almost for every assembly.
11217 Thanks Zoltan for the idea.
11218 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
11219 (ArrayCreation.DoResolve): Resolve only once.
11220 (ArrayCreation.Emit): Emit static initializer only when it is faster.
11221 (ArrayCreation.GetAttributableValue): Cope with optimized values.
11223 2006-04-03 Zoltan Varga <vargaz@gmail.com>
11225 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
11228 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11230 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
11231 in an embedded statement too.
11233 2006-04-01 Raja R Harinath <rharinath@novell.com>
11236 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
11238 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11242 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
11245 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
11247 2006-03-31 Marek Safar <marek.safar@seznam.cz>
11249 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
11252 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
11253 LocalTemporary change.
11255 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
11257 (ClassOrStruct.DefineFieldInitializers): Implemented static field
11258 initializers optimization.
11259 (ClassOrStruct.TypeAttr): Moved from modifiers.
11260 (Constructor.CheckBase): Don't crash when static ctor has parameters.
11261 (FieldBase.ResolveInitializer): Resolves initializer.
11262 (FieldBase.HasDefaultInitializer): New property.
11264 * cs-parser.jay: Removed message.
11266 * expression.cs (CompilerGeneratedThis): New specialization.
11268 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
11270 2006-03-28 Marek Safar <marek.safar@seznam.cz>
11272 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
11274 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11276 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
11277 be now EnumConstants only.
11279 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11281 * attribute.cs, driver.cs: Reset more caches.
11283 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11285 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
11287 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11289 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
11290 for easier reuse. Updated all overrides.
11291 (IntegralConstant): New base class for all integral constants.
11292 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
11293 of the constant range, report custom error.
11294 (UIntConstant.Reduce): Fixed uint conversion.
11296 * ecore.cs, literal.cs: Reduce updates.
11298 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11302 * class.cs (Constructor.Define): Removed extra if for default ctors.
11303 A patch from Atsushi Enomoto.
11305 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11307 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
11308 GetAttributableValue.
11310 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
11313 * convert.cs (ImplicitConversionRequired): Error message moved to
11316 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
11317 automatic implicit conversion of an output value.
11318 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
11320 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
11322 (TypeOf.GetAttributableValue): Add extra handling for object type.
11324 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
11325 special error message.
11327 2006-03-25 Marek Safar <marek.safar@seznam.cz>
11329 * class.cs (Constructor.Emit): Don't crash when struct ctor is
11331 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
11332 compatible with MS runtime.
11334 2006-03-23 Marek Safar <marek.safar@seznam.cz>
11336 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
11337 attribute arguments here.
11339 * class.cs (Indexer.Define): The check was moved to attribute class.
11341 2006-03-22 Marek Safar <marek.safar@seznam.cz>
11343 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
11344 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
11347 2006-03-22 Raja R Harinath <rharinath@novell.com>
11349 Support ParameterDefaultValueAttribute in gmcs. Also applied to
11350 mcs to keep code differences small.
11351 * attribute.cs (Attribute.GetParameterDefaultValue): New.
11352 * typemanager.cs (parameter_default_value_attribute_type): New.
11353 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
11356 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11358 * expression.cs (StringConcat.Append): Reverted back to no warning state.
11360 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11362 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
11364 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
11367 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
11369 * doc-bootstrap.cs : fix build.
11371 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11373 * expression.cs (StringConcat.Append): Issue a warning when empty string
11374 is going to append.
11376 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11378 * assign.cs (CompoundAssign.ResolveSource): Removed.
11380 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
11383 * class.cs (TypeContainer.FindMethods): Removed.
11384 (TypeContainer.CheckMemberUsage): Made static.
11386 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
11388 * constant.cs (CheckRange): Removed unused type argument.
11389 (CheckUnsigned): Removed unused type argument.
11391 * cs-parser.jay: Updated after MemberAccess clean up.
11392 Uses Length for empty string test.
11394 * cs-tokenizer.cs: Uses Length for empty string test.
11395 (IsCastToken): Made static.
11396 (is_hex): Made static.
11397 (real_type_suffix): Made static.
11399 * decl.cs (SetupCache): Made static.
11400 (OnGenerateDocComment): Removed unused ds argument.
11402 * delegate.cs (VerifyDelegate): Removed unused argument.
11404 * doc.cs: Uses Length for empty string test.
11406 * driver.cs: Uses Length for empty string test.
11408 * enum.cs (IsValidEnumType): Made static
11410 * expression.cs (EnumLiftUp): Removed unused argument.
11411 (ResolveMethodGroup): Ditto.
11412 (BetterConversion): Ditto.
11413 (GetVarargsTypes): Ditto.
11414 (UpdateIndices): Ditto.
11415 (ValidateInitializers): Ditto.
11416 (MemberAccess.ctor): Ditto.
11417 (GetIndexersForType): Ditto.
11419 * flowanalysis.cs: (MergeFinally): Removed unused argument.
11421 * iterators.cs: Updated after MemberAccess clean up.
11423 * location.cs: Uses Length for empty string test.
11425 * namespace.cs: Uses Length for empty string test.
11427 * report.cs (CheckWarningCode): Made static.
11429 * statement.cs (LabeledStatement): Removed unused argument.
11431 * typemanager.cs (FilterNone): Removed.
11433 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11435 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
11438 * class.cs: Updated.
11440 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11442 * cs-parser.jay.cs: __arglist is not allowed for delegates.
11444 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11448 * expression.cs (VerifyArgumentsCompat): Reverted to double error
11449 reporting, it's more tricky than I thought.
11451 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11455 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
11457 (AnonymousMethod.ImplicitStandardConversionExists): New method.
11458 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
11459 Add more error reporting; Fixed issue with params.
11461 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
11463 * cs-parser.jay: AnonymousMethod requires host container.
11465 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
11467 2006-03-18 Raja R Harinath <harinath@gmail.com>
11469 * class.cs: Change 'TypeContainer ds' constructor argument to
11470 'DeclSpace parent'. Some classes were missed below due to
11471 different naming convention.
11473 * class.cs (MemberCore.Parent): Delete. This makes the
11474 ParentContainer changes below enforceable by the compiler.
11476 Treat pointers to enclosing declaration space as 'DeclSpace', not
11478 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
11479 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
11481 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
11483 (Block.AddThisVariable): Likewise.
11484 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
11485 (AbstractPropertyEventMethod.Emit): Likewise.
11486 (AbstractPropertyEventMethod.EmitMethod): Likewise.
11487 (GetMethod.Define, SetMethod.Define): Likewise.
11488 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
11489 (DelegateMethod.EmitMethod): Likewise.
11491 Fix regression test-partial-13.cs.
11492 Rationalize use of PartialContainer. Ensure that the partial
11493 class semantics can be tied to type-correctness, i.e., any
11494 violation will cause a compile error.
11495 * class.cs, const.cs: Access all fields that belong to class
11496 TypeContainer via ParentContainer. Arguments of EmitContexts and
11497 Resolve()-like functions still use 'Parent'.
11499 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
11500 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
11501 (PropertyMethod.CheckModifiers): Remove unused argument.
11502 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
11505 2006-03-17 Raja R Harinath <harinath@gmail.com>
11507 Make semantics of PartialContainer simpler.
11508 * decl.cs (DeclSpace.IsPartial): Remove.
11509 * class.cs (TypeContainer.IsPartial): Likewise.
11510 (TypeContainer..ctor): Set PartialContainer to point to self.
11511 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
11512 (TypeContainer.FindNestedType): Likewise.
11513 (MemberCore.ParentContainer): Simplify. Remove deprecation.
11515 2006-03-17 Marek Safar <marek.safar@seznam.cz>
11517 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
11519 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11521 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
11524 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11526 * class.cs (Operator.Define): An error for base conversion was not
11527 reported correctly.
11529 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
11531 * iterator.cs : yield break is allowed in try statement which has
11532 catch clauses. Fixed bug #77767.
11534 2006-03-13 Marek Safar <marek.safar@seznam.cz>
11536 A fix for #77593, #77574.
11538 * class.cs (MethodCore.CheckBase): Another if for operator.
11540 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11542 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11545 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11546 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11549 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11552 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11553 Updated after another emitcontext usage was clean up. It should help us to
11554 synchronize with gmcs easier.
11556 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11560 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11561 (Event.Define): ditto
11562 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11564 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11565 Removed redundant code and set NewSlot for Invoke method too.
11567 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11568 (Parameters.MergeGenerated): New method. Use this method when you merge
11569 compiler generated argument with user arguments.
11571 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11573 * attribute.cs (ResolveAsTypeTerminal): Removed.
11575 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11576 specialization for predefined types; 30% speed up.
11577 Finally placed obsolete check to right place.
11578 (Expression.ResolveType): Removed.
11580 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11581 Updated after ResolveType was removed.
11583 * expression.cs (Cast.ctor): Check void cast.
11584 (Binary.ResolveAsTypeTerminal): Is never type.
11585 (Conditional.ResolveAsTypeTerminal): Is never type.
11587 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11589 2006-03-01 Raja R Harinath <rharinath@novell.com>
11592 * expression.cs (ParameterReference.DoResolveBase): Change return
11594 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11598 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11601 * typemanager.cs (GetFullNameSignature): Don't nullref on
11602 protected accessors.
11604 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11606 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11607 these two separated members to simplify the code.
11608 (Attribute.Resolve): Refactored to use new fields and methods.
11609 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11610 implemented obsolete attribute checking.
11611 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11612 implemented obsolete checking again. It look line never ending quest ;-)
11613 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11615 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11617 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11619 *class.cs (Property.Define): Add RegisterProperty call.
11621 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11622 argument groups (only 2).
11624 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11625 encoding expression to arguments.
11626 (Expression.ExprClassToResolveFlags): Just turned to property.
11628 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11629 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11630 optimized as well as implemented support for zero-length attributes.
11632 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11633 Add caching of PropertyInfo's.
11635 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11637 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11638 error multiple times.
11640 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11642 New partial class implementation.
11643 A fix for #77027, #77029, #77403
11645 * attribute.cs (Attributable): Made attributes protected.
11647 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11648 the replacements of ClassPart and PartialContainer.
11649 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11650 (TypeContainer.AddInterface): Ditto.
11651 (TypeContainer.AddPartial): The main method for partial classes. It checks
11652 for errors and merges ModFlags and attributes. At the end class is added to
11653 partial_parts list.
11654 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11656 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11657 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11658 from the rest of partial classes.
11659 (TypeContainer.GetClassBases): Simplified.
11660 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11662 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11663 (TypeContainer.HasExplicitLayout): Uses Flags now.
11664 (PartialContainer): Removed.
11665 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11666 (StaticClass): Was merged with Class.
11667 (Class.GetClassBases): class and static class bases are verified here.
11668 (Class.TypeAttr): Added static attributes when class is static.
11669 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11670 (MemberBase): In some cases we need to call parent container for partial
11671 class. It should be eliminated but it's not easy now.
11673 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11675 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11676 partial classed to accumulate class comments.
11677 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11679 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11681 * driver.cs (MainDriver): Tree.GetDecl was removed.
11683 * modifiers.cs (Modifiers): Add partial modifier.
11685 * tree.cs (Tree.decl): Removed.
11686 (RootTypes): Started to use this class more often for root types
11689 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11693 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11694 external interface does not have an attribute.
11696 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11698 Another prerequisites for new partial classs implementation.
11700 * attribute.cs (Attribute.Equal): Implemented.
11701 (Attribute.Emit): Changed as attributes can be applied more than twice.
11702 (Attributes.Emit): Check for duplicate attributes here.
11704 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11705 as a parameter, clean-up.
11707 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11711 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11712 contains obsolete attribute check which can in some cases look for base
11713 type of current class which is not initialized yet.
11714 (TypeContainer.BaseType): Replacement of ptype.
11716 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11718 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11720 First of prerequisites for new partial classs implemention.
11722 * attribute.cs (Attributable): Extended by ResolveContext;
11723 Attributes finally have correct context for resolving in all cases.
11724 (AttachTo): Attribute owner is assigned here.
11726 * codegen.cs (IResolveContext): Introduce new interface to hold
11727 all information needed in resolving phase.
11728 (EmitContext): Implements IResolveContext; more clean-up needed here.
11730 * decl.cs (MemberCore): Implemented IResolveContext.
11732 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11733 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11734 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11735 Refactored to use new IResolveContext instead of EmitContext; cleanup
11737 2006-02-06 Miguel de Icaza <miguel@novell.com>
11739 * codegen.cs (EmitScopeInitFromBlock): check here the
11740 capture_context, there is no need to make two calls to the
11743 * anonymous.cs: Add some debugging messages that might help me
11744 track other instances of this problem in the future (the
11745 regression of test 467).
11747 * cs-parser.jay: track the variable block, as we need to initalize
11748 any captured variables declared in this block for the "catch"
11749 portion of the "Try" statement.
11751 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11752 scope initialization for captured variables.
11754 Also, move the emit for the variables after the block location has
11757 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11759 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11761 2006-02-02 Miguel de Icaza <miguel@novell.com>
11763 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11764 commit yesterday, the initialization for the roots is necessary.
11765 What is not necessary is the scope activation.
11767 2006-02-02 Raja R Harinath <rharinath@novell.com>
11769 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11770 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11772 (Argument.Resolve): Remove CS0206 checks.
11774 2006-02-01 Miguel de Icaza <miguel@novell.com>
11776 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11777 scopes for all the roots, the scopes will now be emitted when the
11778 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11780 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11781 code. This reduces a lot of existing cruft.
11783 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11784 that the ScopeInfo is generated as we enter the scope, not at the
11785 time of use, which is what we used to do before.
11787 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11788 every time a Block is about to be emitted if we have a
11791 2006-02-01 Raja R Harinath <rharinath@novell.com>
11793 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11795 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11797 * typemanager.cs (cons_param_array_attribute): Make private.
11798 (Reset): Set it to null.
11799 (InitCoreHelpers): Don't initialize it.
11800 (ConsParamArrayAttribute): New. Initialize it as needed.
11801 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11803 2006-01-31 Miguel de Icaza <miguel@novell.com>
11805 * expression.cs: There might be errors reported during the
11806 selection of applicable methods. If there are errors, do not
11807 continue execution as it will lead the compiler to crash.
11809 2006-01-30 Miguel de Icaza <miguel@novell.com>
11811 * expression.cs: Member access is not allowed on anonymous
11812 methods. Fixes #77402.
11814 2006-01-30 Raja R Harinath <rharinath@novell.com>
11817 * cs-parser.jay (VariableDeclaration): Don't set
11818 current_array_type to null.
11819 (field_declaration, event_declaration, declaration_statement):
11820 Set it to null here.
11822 2006-01-28 Raja R Harinath <harinath@gmail.com>
11824 * typemanager.cs (GenericParameterPosition): New.
11827 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11829 * doc.cs : To process "include" elements, first we should create
11830 another list than XmlNodeList, because it could result in node
11831 removal, which could result in that the XmlNodeList gives up
11832 yielding next node.
11834 (Also made code identical to gmcs again.)
11836 2006-01-25 Miguel de Icaza <miguel@novell.com>
11838 * ecore.cs: Introduce an error report that we were not catching
11839 before, if not silent, we must report the error. Gonzalo ran into
11842 2006-01-23 Miguel de Icaza <miguel@novell.com>
11844 A fix for bug: #76957
11846 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11847 ComputeMethodHost before creating the method, this is a new
11850 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11851 that this method references (RegisterScope). The actual scope
11852 where the method is hosted is computed with the ComputeMethodHost
11853 before we create the method.
11855 Moved the Deepest routine here.
11857 (AnonymousContainer.ComputeMethodHost): New routine used to
11858 compute the proper ScopeInfo that will host the anonymous method.
11860 (ScopeInfo): Deal with multiple roots. The problem was that we
11861 did not have a unique root where all ScopeInfos could be hanged
11862 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11865 Remove AdjustMethodScope which is now computed at the end. Remove
11866 LinkScope which did a partial link, instead link all ScopeInfos
11867 before code generation from the new "LinkScopes" routine.
11869 Simplify all the Add* routines as they no longer need to maintain
11870 the tree, they just need to record that they are using variables
11873 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11874 routines to produce the forest of ScopeInfo trees.
11876 * class.cs (TypeContainer.AppendMethod): This is just like
11877 AddMethod, but ensures that an interface implementation method
11878 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11879 methods, but at the end.
11881 We use this functionality to ensure that the generated MoveNext
11882 method in the iterator class is resolved/emitted before the
11883 enumerator methods created.
11885 This is required because the MoveNext method computes the right
11886 ScopeInfo for the method. And the other methods will eventually
11887 need to resolve and fetch information computed from the anonymous
11890 2006-01-21 Raja R Harinath <harinath@gmail.com>
11891 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11893 Fix rest of #76995.
11894 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11895 the 'aliases' hash.
11896 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11897 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11899 2006-01-18 Raja R Harinath <rharinath@novell.com>
11901 Fix #76656, cs0231-2.cs.
11902 * cs-parser.jay (formal_parameter_list): Make error case catch
11904 (parenthesized_expression_0): Add CS1026 check.
11905 (invocation_expression): Remove unused { $$ = lexer.Location }.
11907 2006-01-17 Raja R Harinath <rharinath@novell.com>
11910 * cs-parser.jay (statement_expression): Don't list out the
11911 individual statement-expressions. Convert syntax error into
11914 2006-01-16 Raja R Harinath <rharinath@novell.com>
11917 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11918 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11919 CheckIntermediateModification.
11920 (FieldExpr.DoResolve): Add new two-argument version that
11921 allows us to resolve the InstanceExpression as an lvalue.
11922 The one-argument variant is now just a wrapper.
11923 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11924 Resolve the lhs as an lvalue if the it has a value type.
11925 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11926 from Assign.DoResolve.
11927 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11928 resolved as an lvalue.
11929 (PropertyExpr.DoResolve): Update.
11930 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11931 has a value type. Move CS1612 check here from
11932 CheckIntermediateModification.
11933 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11934 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11935 'right_side' of a ResolveLValue on an 'out' argument.
11936 (EmptyExpression.LValueMemberAccess): New. Used as the
11937 'right_side' of a propagated ResolveLValue on a value type.
11938 (LocalVariableReference.DoResolveBase): Recognize
11939 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11941 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11942 EmptyExpression.Null.
11944 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11946 * typemanager.cs : added IsGenericParameter(). In mcs it always
11948 * doc.cs : for generic parameters, use GenericParameterPosition,
11951 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11953 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11955 2006-01-12 Miguel de Icaza <miguel@novell.com>
11957 This fixes the problem where we used ldfld instead of ldflda to
11958 load the "THIS" pointer on captured parameters, when THIS is a
11959 value type. See bug #77205.
11961 * iterators.cs (CapturedThisReference.Emit): Pass false to
11962 EmitThis (we do not need the address).
11964 * codegen.cs (EmitThis): it needs to know whether we need the
11965 address of `this' or not. This is used by value types.
11967 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11968 every other call passes false.
11970 2006-01-12 Raja R Harinath <rharinath@novell.com>
11973 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11975 * expression.cs (Invocation.OverloadResolve): Update.
11976 (Invocation.DoResolve): Avoid double resolution of invocation.
11978 2006-01-11 Raja R Harinath <rharinath@novell.com>
11981 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11982 unary negation of floating point types as 0-expr; negation cannot
11983 overflow in floating point types.
11986 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11987 on operands of 'void' type.
11990 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11991 and ExclusiveOr for boolean constants too.
11993 2006-01-09 Raja R Harinath <rharinath@novell.com>
11996 * expression.cs (Invocation.OverloadResolve): Replace reflected
11997 override methods with their base virtual methods, rather than
11998 skipping over them.
11999 * typemanager.cs (TypeManager.GetOverride): New.
12001 2006-01-05 Jb Evain <jbevain@gmail.com>
12003 * class.cs (Property.Define, Indexer.Define): do not tag the
12004 properties as SpecialName | RTSpecialName.
12006 2006-01-04 Miguel de Icaza <miguel@novell.com>
12008 * class.cs (MethodCore.IsDuplicateImplementation): This method was
12009 doing a low-level comparission of parameter types. It was lacking
12010 a check for __argslist.
12012 2005-12-30 Miguel de Icaza <miguel@novell.com>
12014 * expression.cs (ParameterReference.DoResolveBase): Allow
12015 reference parameters if they are local to this block.
12017 This allows the ref and out parameters of a delegate to be used in
12018 an anonymous method, for example:
12020 delegate void set (out int x);
12022 set s = delegate (out int x){
12026 This is used by functionality introduced late in the C# language.
12028 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
12029 method that take ref and out parameters.
12031 Fixes #77119 which was a late change in the spec.
12033 2005-12-23 Miguel de Icaza <miguel@novell.com>
12035 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
12036 parent if its the same scope. Fixes #77060.
12038 2005-12-21 Miguel de Icaza <miguel@novell.com>
12040 * driver.cs: Report the case of no source files and no -out:
12043 2005-12-20 Raja R Harinath <rharinath@novell.com>
12046 * expression.cs (ComposedCast.GetSignatureForError): Define.
12048 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12052 * namespace.cs (NamespaceEntry): Add extern_aliases as a
12053 ListDictionary, to contain the ExternAliasEntry entries (in
12054 addition to the NamespaceEntry.aliases hashtable). This field is
12055 shared between the original entry and its doppelganger (bodyless
12057 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
12058 extern_aliases field.
12059 (NamespaceEntry.Lookup): Move the IsImplicit check after the
12060 lookup in extern_aliases.
12062 2005-12-16 Raja R Harinath <rharinath@novell.com>
12065 * class.cs (TypeContainer.Mark_HasEquals): New.
12066 (TypeContainer.Mark_HasGetHashCode): New.
12067 (ClassPart): Override them.
12068 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
12071 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
12072 'parent' argument to the base constructor.
12074 Remove all mention of TypeContainer from decl.cs.
12075 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
12076 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
12077 (DeclSpace.DeclSpace): Likewise.
12078 (DeclSpace.DefineMembers): Remove unused argument.
12079 * cs-parser.jay (pop_current_class): Update to changes. Simplify
12080 debugging check -- we don't care if the debug code throws an
12081 InvalidCastException instead of an InternalErrorException.
12082 * class.cs (TypeContainer.DefineMembers): Update to changes.
12083 (TypeContainer.DoDefineMembers): Likewise.
12084 (TypeContainer.GetMethods): Likewise.
12085 (PropertyMember.Define): Likewise.
12086 (MemberBase.Parent): New property that forwards to
12087 MemberCore.Parent, but ensures that we get a TypeContainer.
12088 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
12089 (RootContext.PopulateTypes): Likewise. Remove special case code
12090 for !RootContext.StdLib: DefineMembers is idempotent.
12092 2005-12-14 Miguel de Icaza <miguel@novell.com>
12094 * convert.cs (ExplicitConversionCore): Check the return value from
12095 ExplicitConversionCore which can return null on failure. Fixes #76914
12097 2005-12-13 Marek Safar <marek.safar@seznam.cz>
12099 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
12101 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
12103 * doc.cs : The search for referenced namespace was insufficient to
12104 get global one as it used to do. Fixed bug #76965.
12106 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
12108 * doc.cs : check name in cref in the last phase that whether it is
12111 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12113 * cs-tokenizer.cs : reverted the latest change: it somehow broke
12116 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12118 * doc.cs : so it turned out that we cannot skip override check for
12119 interface members. Fixed bug #76954.
12121 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12123 * cs-tokenizer.cs : fixed bug #75984:
12124 - #warning and #error should not be handled when the source line
12126 - #line is not checked strictly when the source line is disabled.
12127 - #define and #undef is on the other hand checked strictly at any
12130 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
12132 * cs-tokenizer.cs : missing Location (actually, filename) in one of
12135 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12137 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
12139 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
12140 event initializers.
12141 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
12142 (FieldBase.Initializer): Initializer is now optional.
12143 (EventField.Define): Only event field can have initializer.
12145 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
12147 * const.cs (Const): Reuse initializer.
12149 * cs-parser.jay: Updated after FieldBase changes.
12150 Added current_array_type to simplify array initializers.
12152 * ecore.cs (NullCast.IsDefaultValue): Implemented.
12154 * expression.cs, iterators.cs: Updated.
12156 * namespace.cs (NamespaceEntry): Made UsingFound private.
12158 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12160 * parameterCollection.cs: Obsolete, removed.
12161 * parser.cs: Obsolete, removed.
12163 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12166 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
12168 * enum.cs (Enum.Define): Set obsolete context here.
12170 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12173 - FindDocumentedMember() now expects 1) paramList as null
12174 when "we don't have to check the number of parameters" and
12175 2) Type.EmptyTypes when "there is no arguments".
12176 - Introduced FoundMember struct to hold the exact type which was
12177 used to find the documented member (the above change broke
12178 test-xml-044; it might be better just to use DeclaringType than
12179 what MS does, like this change does, but it depends on usage.)
12181 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12183 * doc.cs : documented member might be from DeclaringType for nested
12184 types. Fixed bug #76782.
12186 2005-12-03 Ben Maurer <bmaurer@ximian.com>
12188 * anonymous.cs: Have the param code handle leaving copies on the
12189 stack etc. Allows anonymous params to take part in the assignment
12190 code (++, +=, etc). Fixes bug #76550
12192 * expression.cs: Handle the prepare_for_load/leave_copy by passing
12193 it down to the anon code.
12195 * iterators.cs: Use dummy var here
12197 * codegen.cs: Handle new vars
12199 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12202 * class.cs (MethodData.Define): Set proper Obsolete context.
12204 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
12206 (FieldExpr.DoResolve): Ditto.
12208 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12211 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
12212 parent is not obsolete.
12214 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
12216 * doc.cs : (FindDocumentedMember) find parameterless members first
12217 and get CS0419 in the early stage. Fixed first case of bug #76727.
12219 2005-11-30 Marek Safar <marek.safar@seznam.cz>
12222 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
12223 no error was reported.
12225 *expression.cs (Binary.DoResolve): left can be null.
12227 2005-11-22 Marek Safar <marek.safar@seznam.cz>
12230 * class.cs (MethodData.Emit): Parameters should be labeled first.
12232 2005-11-21 Marek Safar <marek.safar@seznam.cz>
12235 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
12237 2005-11-18 Marek Safar <marek.safar@seznam.cz>
12239 * attribute.cs (AreParametersCompliant): Moved to Parameter.
12241 * class.cs (MethodCore): Parameter clean up.
12242 (IMethodData): Added ParameterInfo.
12243 (MethodData): Parameter clean up.
12244 (Indexer.Define): Parameter clean up.
12256 * typemanager.cs: Parameter clean up.
12258 * delegate.cs (Define): Get rid of duplicated code.
12260 * expression.cs (ParameterReference): Removed useless parameters
12262 (Invocation): Ditto.
12264 * parameter.cs (ParamsParameter): New class, params specialization.
12265 (ArglistParameter): Attemp to separate arglist.
12266 (Parameter): Refactored to be reusable and faster.
12267 (Parameter.Modifier): Made understandable.
12268 (Parameters): Changed to be used as a class for `this' assembly
12269 parameters. Refactored to use new specialized classes.
12271 * support.cs (ParameterData): Added Types property.
12272 (InternalParameters): Deleted.
12274 2005-08-20 Martin Baulig <martin@ximian.com>
12276 Merging this patch from GMCS to fix #75867.
12278 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12279 scope if we don't already have it.
12281 2005-11-17 Martin Baulig <martin@ximian.com>
12284 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
12285 inherit the scope from our parent. Fixes #76653.
12287 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12289 * doc.cs : the previous patch does not actually fix the bug.
12290 PropertyInfo override check is now implemented and really fixed it.
12291 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
12293 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12295 * doc.cs : apply "override filter" also to properties.
12298 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12300 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
12301 no need to check overrides. For classes, omit those results from
12302 interfaces since they must exist in the class. Fixed bug #76726.
12304 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12306 * typemanager.cs : (GetFullNameSignature) differentiate indexers
12307 with different parameters. Fixed the second problem in #76685.
12309 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12311 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
12312 get expected 'protected' access in CheckValidFamilyAccess()).
12315 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12317 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
12318 Fixed bug #76705. CS1569 was incorrectly commented out.
12320 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12322 * doc.cs : use Invocation.IsOverride() to do real override check.
12323 * expression.cs : made Invocation.IsOverride() internal.
12325 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12327 * doc.cs : use TypeManager.FindMembers() instead of (possible)
12328 TypeBuilder.FindMembers() and filter overriden base members out.
12331 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12333 * doc.cs : ref/out parameters are represented as '@' (instead of
12334 '&' in type FullName). Fixed bug #76630 (additionally crefs).
12336 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12338 * doc.cs : when there was no '.' in cref to methods in doc comment,
12339 then parameters were missing in the output. Fixed bug #76691.
12341 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12343 * driver.cs : don't output docs when there is an error.
12346 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12349 Now it should detect indexers. Fixed primary concern in bug #76685.
12350 Fixed CS0419 message to not show the identical member signature in
12353 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12355 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
12356 instead of Type.FindMembers() since it does not handle events.
12359 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
12361 * codegen.cs: Fixed typo (speficied -> specified).
12363 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12366 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
12368 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12370 * attribute.cs: Changed error message.
12372 * cs-tokenizer.cs: One more check.
12374 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12376 * statement.cs (Block.Resolve): Ignore empty statement.
12378 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12380 * report.cs: Made error/warning methods more strict to avoid
12383 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
12384 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
12385 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
12386 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
12388 2005-11-08 Marek Safar <marek.safar@seznam.cz>
12390 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
12391 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
12393 * class.cs (TypeContainer.IsComImport): New property.
12394 (Constructor.Define): Create proper ctor for ComImport types.
12396 * expression.cs (New.CheckComImport): Fixed.
12398 2005-11-07 Miguel de Icaza <miguel@novell.com>
12400 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
12401 that a parameter has been captured does not mean that we do not
12402 have to do the rest of the processing. This fixes the second part
12403 of #76592. If there was another anonymous method capturing
12404 values in the past, the Scope would never be set for the second
12405 method that captured the same parameter.
12407 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
12408 properly manipulate the stack. Second part of fix for #76592.
12410 * expression.cs (New): Add support for invoking "new" on
12411 interfaces that have been flagged with the ComImport attribute and
12412 the CoClass. Fixes #76637
12414 * statement.cs (Try.DoEmit): When a variable is captured, do not
12415 try to emit the vi.LocalBuilder variable as it has been captured.
12416 Create a temporary variable and store the results on the
12417 FieldBuilder. Fixes #76642
12419 2005-11-07 Marek Safar <marek.safar@seznam.cz>
12421 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
12423 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
12425 * expression.cs (Binary.DoResolve): Added && optimalization.
12427 * typemanager.cs (AddUserType): Removed useless argument.
12429 2005-11-04 Marek Safar <marek.safar@seznam.cz>
12431 * statement.cs (Block.variables): Uses ListDictionary.
12433 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12436 * class.cs (PartialContainer.EmitType): Customized to emit
12437 security attributes.
12438 (ClassPart.ApplyAttributeBuilder): Transform security attribute
12439 for partial classes.
12441 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12444 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
12445 access has to be fixed.
12447 * typemanager.cs (IsUnmanagedType): Wrong common field type.
12449 2005-11-01 Marek Safar <marek.safar@seznam.cz>
12452 * ecore.cs (NullCast.Reduce): Implemented.
12454 * expression.cs (ArrayCreation.CheckIndices): Correcly check
12457 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
12459 (Foreach.Resolve): Catch null properly.
12461 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12463 * cs-tokenizer.cs: Warning text fix.
12465 * driver.cs: AllWarningNumbers exposed on public interface.
12467 * report.cs (): Reviewed warning numbers.
12468 (IsValidWarning): Use binary search.
12470 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12472 * driver.cs: Implemeted resource visibility.
12473 (Resources): New class for code sharing between /res: and
12476 2005-10-28 Marek Safar <marek.safar@seznam.cz>
12479 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
12482 * convert (Convert.ImplicitReferenceConversion): NullCast holds
12485 * ecore.cs (NullCast): Child is contant only.
12487 * literal.cs (NullLiteral.Reduce): null can be converted to any
12490 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
12492 * driver.cs: Use Encoding.Default as default code page instead
12495 2005-10-27 Raja R Harinath <rharinath@novell.com>
12498 * expression.cs (Invocation.Error_InvalidArguments): Handle
12499 __arglist parameters.
12500 (Invocation.VerifyArgumentsCompat): Likewise.
12501 * support.cs (ReflectionParameters.GetSignatureForError): Print
12502 __arglist parameters.
12503 (InternalParamters.GetSignatureForError): Likewise.
12504 * parameter.cs (Parameters.GetSignatureForError): Likewise.
12506 2005-10-26 Marek Safar <marek.safar@seznam.cz>
12508 * attribute.cs (GetPropertyValue): Made public.
12510 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
12512 Add new property WrapNonExceptionThrows to handle 2.0 assembly
12514 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
12517 * driver.cs: Reflect method name change.
12519 * statement.cs (Try.Resolve): Warn when try has both general
12520 exception handlers.
12522 * typemanager.cs: runtime_compatibility_attr_type new predefined
12525 2005-10-26 Raja R Harinath <harinath@gmail.com>
12528 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
12529 treat it as an empty parameter list.
12531 2005-10-26 Raja R Harinath <rharinath@novell.com>
12534 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
12535 ResolveAsTypeStep silent.
12536 * statement.cs (Block.AddConstant): Mark block as used.
12537 (Block.ResolveMeta): Avoid piling on error messages
12538 if a constant initializer resolution fails.
12540 2005-10-25 Raja R Harinath <rharinath@novell.com>
12542 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12544 (NamespaceEntry.VerifyAllUsing): New.
12545 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12546 behaviour. Delegates actual resolution of alias to ...
12547 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12548 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12550 * driver.cs (Driver.MainDriver): Update.
12552 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12553 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12555 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12557 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12558 RootNamespace.DefineNamespacesForAll.
12560 2005-10-24 Raja R Harinath <harinath@gmail.com>
12562 * typemanager.cs (assemblies, external_aliases, modules)
12563 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12564 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12565 overhead. Move resposibility ...
12566 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12567 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12569 2005-10-23 Raja R Harinath <harinath@gmail.com>
12571 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12572 cached_namespaces. Improve usage.
12573 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12574 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12575 Move from GlobalRootNamespace and simplify.
12576 (RootNamespace.Global): Make instance variable.
12577 (RootNamespace.RootNamespace): Add "alias name" parameter.
12578 (GlobalRootNamespace): Simplify drastically.
12579 (Namespace.Lookup): Don't use GetNamespace.
12580 * typemanager.cs (GetRootNamespace): Rename from
12581 ComputeNamespaceForAlias.
12582 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12584 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12586 * anonymous.cs (AnonymousContainer): Don't crash when container
12589 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12591 * expression.cs (Binary.DoResolve): Warn when comparing same
12594 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12597 * expression.cs (Binary.DoResolve): It looks like there are no
12598 convetsion rules in enum context.
12600 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12602 Add support for extern alias qualifiers.
12603 * typemanager.cs: Move some LookupTypeReflection code
12604 to namespace.cs, to have cleaner code. Added some methods
12605 to help us keep track of the extern aliased references.
12606 * driver.cs: Add suport for extern alias assemblies on command
12607 line and check for their warnings/errors. Also keep track of the
12608 extern aliased assemblies.
12609 * namespace.cs: Move the global functionality of Namespace
12610 to GlobalRootNamespace/RootNamespace. Now the global namespace
12611 is GlobalRootNamespace.Globa. Also the code moved from
12612 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12613 Finally added LocalAliasEntry (AliasEntry before) and
12614 ExternAliasEntry, to handle alias statements.
12615 * cs-parser.jay: Add support in the grammar for extern alias
12617 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12618 Update callings to Namespace (now in GlobalRootNamespace).
12620 2005-10-18 Raja R Harinath <rharinath@novell.com>
12623 * class.cs (TypeContainer.DefineType): Move updating of
12624 topological sort earlier in the code.
12625 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12627 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12630 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12632 * constant.cs (Constant.TryReduce): Moved from Cast class.
12633 (Reduce): Made little bit more OO and fixed missing conversions.
12635 * ecore.cs (Reduce): Implemented.
12636 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12638 * literal.cs (Reduce): Implemented.
12640 * class.cs: Reverted Miguel's wrong commit.
12642 2005-10-14 Miguel de Icaza <miguel@novell.com>
12644 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12646 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12648 * cs-parser.jay, expression.cs : CS0214 was missing error location
12649 for constants. Fixed bug #76404.
12651 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12654 * convert.cs (ExplicitConversionCore): Fixed object->enum
12657 2005-10-10 Raja R Harinath <rharinath@novell.com>
12659 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12660 InstanceExpression.
12661 (PropertyExpr.EmitCall): Likewise.
12662 * expression.cs (Invocation.EmitArguments): Handle case where
12664 (Invocation.EmitCall): Avoid allocating temporary variable if
12665 there are no arguments.
12667 2005-10-07 Raja R Harinath <rharinath@novell.com>
12670 * convert.cs (ImplicitConversionStandard): Move conversion of
12671 void* to arbitrary pointer types ...
12672 (ExplicitConversionStandard): .. here.
12673 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12674 error to always print typenames.
12676 2005-10-07 Raja R Harinath <rharinath@novell.com>
12678 * convert.cs (GetConversionOperator): Rename from
12679 GetConversionOperators. Move operator selection code from ...
12680 (UserDefinedConversion): ... here.
12682 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12684 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12687 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12689 * assign.cs (Assign.DoResolve): Error method changed.
12691 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12693 * const.cs (ResolveValue): Reset in_transit immediately.
12695 * constant.cs: Error method changed.
12697 * convert.cs: Removed useless location parameter.
12698 (ExplicitNumericConversion): Don't do double enum check.
12699 (ExplicitConversionCore): Renamed from ExplicitConversion.
12700 (ExplicitUnsafe): Extracted from ExplicitConversion.
12701 (ExplicitConversion): Uses for error reporting.
12703 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12705 (ResolveBoolean): Uses common error method.
12706 (CastToDecimal): Get rid of ec.
12707 (CastFromDecimal): Optimized.
12708 (ConvCast): Get rid of ec.
12710 * enum.cs (ResolveValue): Reset in_transit immediately.
12711 (Emit): Return after first error.
12713 * expression.cs: Convert changes.
12715 * literal.cs: Error method changed.
12717 * statement.cs: Error method changed.
12719 2005-10-03 Raja R Harinath <rharinath@novell.com>
12721 * support.cs (SeekableStreamReader.Position): Don't error out when
12722 the requested position is just beyond the end of the current
12725 2005-09-28 Raja R Harinath <rharinath@novell.com>
12727 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12728 try to keep in sync with the byte count of the underlying Stream.
12729 However, this limits us to a window size of 2048 characters: i.e.,
12730 the maximum lookahead of our lexer/parser can be 2048 characters.
12732 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12735 * driver.cs: Fix compilation files with full root path.
12737 2005-09-25 Miguel de Icaza <miguel@novell.com>
12739 * report.cs (SymbolRelatedToPreviousError): Format the output so
12740 it does not use an open parenthesis that is never closed.
12742 * driver.cs: Follow coding guidelines
12744 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12747 * const.cs (Const.ResolveValue): Check for assigning non-null
12748 value to reference type.
12750 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12752 * anonymous.cs: Implemented ExprClassName.
12754 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12757 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12760 * class.cs (StaticClass.DefineContainerMembers): Report protected
12763 * codegen.cs: if(ed) PRODUCTION.
12765 * convert.cs (Error_CannotImplicitConversion): Better error
12768 * cs-parser.jay: More error checks.
12770 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12772 * driver.cs (CSCParseOption): Enabled wrong option check.
12774 * ecore.cs (Expression.ExprClassName): Turned to property.
12775 (MemberExpr.CheckIntermediateModification): For checking boxed
12776 value types modification.
12778 * statement.cs (Fixed.Resolve): Expression type must be
12779 convertible to fixed type.
12780 (CollectionForeach.GetEnumeratorFilter,TryType):
12781 Small refactoring for easier error checking.
12783 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12785 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12788 * class.cs (GeneratedBaseInitializer): New class for customization
12789 compiler generated initializers.
12790 (MemberBase.DoDefine): Check Obsolete attribute here.
12791 (FieldMember.DoDefine): Ditto.
12793 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12796 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12797 (MemberCore.GetObsoleteAttribute): Removed argument.
12798 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12799 (MemberCore.CheckObsoleteType): New helper.
12803 * statement.cs: Updates after MemberCore changes.
12805 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12806 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12808 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12809 obsolete attribute for compiler construct.
12810 (As.DoResolve): Cache result.
12812 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12814 2005-09-26 Raja R Harinath <rharinath@novell.com>
12817 * expression.cs (This.VerifyFixed): In a value type T, the type of
12818 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12819 value type R, 'this' is treated as a value parameter.
12821 2005-09-22 Miguel de Icaza <miguel@novell.com>
12823 * statement.cs (Lock): Use the TemporaryVariable class instead of
12824 manually using local variables as those do not work when variables
12827 * ecore.cs: Moved the TemporaryVariable class from being a nested
12828 class inside Foreach to be a public class that can be employed in
12831 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12833 * cs-parser.jay: interface_accessors replaced by
12834 accessor_declarations.
12836 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12839 * statement.cs (GotoCase.Resolve): Convert null constant to
12841 (SwitchLabel.ResolveAndReduce): Ditto.
12842 (SwitchLabel.NullStringCase): Custom null stamp.
12843 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12845 typemanager.cs (CSharpSignature): Don't skip first argument
12848 2005-09-18 Miguel de Icaza <miguel@novell.com>
12850 * driver.cs: Set InEmacs based on the environment variable EMACS.
12852 * location.cs (InEmacs): in this mode, do not report column
12853 location as it confuses Emacs.
12855 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12857 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12858 expression.cs, iterators.cs, literal.cs: Store constants and
12861 * class.cs (MemberBase.ShortName): Pass location.
12863 * cs-parser.jay: Some location fixes.
12865 * ecore.cs (Expression.Location): Made virtual.
12867 2005-09-05 Miguel de Icaza <miguel@novell.com>
12869 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12870 if the underlying types are the same, otherwise we need to produce
12871 code that will do the proper cast.
12873 This was exposed by Marek's constant rewrite which produced
12874 invalid code for the call site:
12876 enum X : long { a }
12877 void Method (X v) {}
12881 This fixes test-49.cs
12883 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12885 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12886 Type/Object should be allowed as well. Fixed bug #75968.
12888 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12890 * expression.cs : (Binary.DoResolve): when one is enum constant and
12891 another is constant 0, then return enum one *as enum type*.
12894 2005-09-02 Raja R Harinath <rharinath@novell.com>
12896 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12900 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12901 flow-branching for LocalVariableReferences in case we were invoked
12902 from a MemberAccess.
12903 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12905 (LocalVariableReference.DoResolveBase): ... this.
12906 (MemberAccess.Resolve): Do the check that was disabled during
12909 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12912 (PartialContainer.Create): check abstract/sealed/static strictly
12913 but abstract/sealed can exist only at one side. Fixed bug #75883.
12915 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12918 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12919 specified, don't default to UnmanagedType.I4.
12921 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12923 * expression.cs : conditional operator should check possibly
12924 incorrect assign expression. Fixed bug #75946.
12926 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12928 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12929 Reverting the change. gmcs is much complex than mcs on this matter.
12931 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12933 * cs-tokenizer.cs : To read another token ahead of the actual
12934 consumption, use new SavedToken and cache token instead of moving
12935 back the stream with SeekableStreamReader (it seemed problematic).
12937 driver.cs : Thus use StreamReader directly.
12938 * support.cs : Thus removed SeekableStreamReader.
12940 2005-08-30 Raja R Harinath <rharinath@novell.com>
12943 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12944 (ScopeInfo.EmitScopeType): Use it to construct field names from
12945 names of captured locals.
12948 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12949 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12950 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12951 (ExplicitConversion): Remove enum cases already handled by
12952 implicit conversion. Move implicit conversion check to the beginning.
12953 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12954 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12955 Don't treat System.Enum as a struct.
12957 2005-08-30 Jb Evain <jbevain@gmail.com>
12959 * attribute.cs: handles as expression in parameters.
12961 2005-08-30 Raja R Harinath <rharinath@novell.com>
12964 * class.cs (TypeContainer.VerifyClsName): Don't use a
12965 PartialContainer when verifying CLS compliance.
12966 (AbstractPropertyEventMethod): Set Parent here, ...
12967 (PropertyMethod): ... not here.
12969 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12971 * attribute.cs : escaped attribute name should not be allowed to be
12972 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12974 2005-08-29 Raja R Harinath <rharinath@novell.com>
12977 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12978 when converting a long constant to unsigned long.
12979 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12980 detect where IsApplicable and VerifyArgumentsCompat disagree.
12982 2005-08-29 Raja R Harinath <rharinath@novell.com>
12983 and Carlos Alberto Cortez <carlos@unixmexico.org>
12986 * class.cs (TypeContainer.CanElideInitializer): New helper.
12987 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12988 can safely emitting the initializer of a field.
12990 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12992 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12993 allowed inside a switch (without loop). Fixed bug #75433.
12995 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12997 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12998 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
13000 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
13002 * driver.cs : kinda reverting the default encoding changes (not exact
13003 revert since I noticed that "codepage:reset" might not work fine).
13005 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
13007 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
13008 Location. Now getter and setter store location correctly.
13009 (errors/cs0111-12.cs now reports the expected location.)
13011 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
13013 * driver.cs : Use default encoding on the environment.
13014 Removed (now that) extra parameter for SeekableStreamReader.
13015 * support.cs : (SeekableStreamReader) third .ctor() argument for
13016 StreamReader is not required (always true). preamble size could
13017 be acquired in simpler and safe way.
13019 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
13021 * cs-parser.jay: report CS0642 at warning level 3
13022 and report CS0642 for an if else statement also
13023 fixes bug #74745. Patch by John Luke (and a bit
13025 Removed extra CS0642 warning check for "while",
13027 * statement.cs: In Block.Resolve(), CS0642 check
13028 is reimplemented to check a sequence of an empty
13029 statement and a block.
13031 Both fix bug #66777.
13033 2005-08-24 Marek Safar <marek.safar@seznam.cz>
13035 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
13036 detection until I fix it.
13038 * cs-tokenizer.cs: Changed error message.
13040 * cs-parser.jay: Fixed 2 error locations.
13042 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
13043 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
13046 * enum.cs (GetSignatureForError): Fixed.
13048 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
13052 * typemanager.cs (RegisterProperty): Removed.
13054 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
13056 2005-08-24 Raja R Harinath <rharinath@novell.com>
13059 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
13060 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
13062 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13064 * expression.cs : tiny fix is required for not warning positive ulong.
13067 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13069 * expression.cs : add CS0652 check for constant and integral
13070 expression. Fixed bug #53974.
13072 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13074 * expression.cs : in DoNumericPromotions(), check if there is implicit
13075 conversion overload for string (to check CS0034). Fixed bug #52492.
13077 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13079 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
13081 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13083 * ecore.cs : report location when it is *not* Null.
13085 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
13091 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
13092 correctly. Fixed bug #75721.
13094 2005-08-23 Raja R Harinath <rharinath@novell.com>
13096 * support.cs (SeekableStreamReader.Position): Avoid an expensive
13097 loop that performs 'min (pos, char_count)'.
13100 * expression.cs (Unary.ResolveOperator): Don't discard implicit
13101 converted value in Operator.OnesComplement.
13103 2005-08-22 Ben Maurer <bmaurer@ximian.com>
13105 * anonymous.cs: If the anon method is pulled into a helper class,
13106 it needs to be `internal' not `private'. Fixes runtime behavior on
13109 2005-08-20 Martin Baulig <martin@ximian.com>
13111 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
13112 scope if we don't already have it.
13114 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
13115 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
13118 2005-08-17 Marek Safar <marek.safar@seznam.cz>
13121 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
13122 is a partial class.
13124 2005-08-16 Marek Safar <marek.safar@seznam.cz>
13126 The big constants rewrite
13127 Fix #75746, #75685 and more
13128 As a side effect saved 1MB for MWF ;-)
13130 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
13131 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
13132 enum based for corlib compilation.
13134 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
13137 * class.cs (FixedField.Define): Use ResolveAsConstant.
13139 * const.cs (IConstant): Interface constants and enums.
13140 (Const.ResolveValue): New method for constant resolvning.
13141 (ExternalConstant): Constants from imported assemblies.
13143 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
13144 conversion; like enums.
13145 (Constant.ToType): Converts this constant to different type.
13146 (Constant.Increment): Adds 1.
13148 * convert.cs (ImplicitConversionRequired): Simplified.
13150 * cs-parser.jay: Create EnumMember directly.
13152 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
13154 * doc.cs (GenerateEnumDocComment): Removed.
13156 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
13157 (ConvertIntLiteral): Removed.
13158 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
13160 * enum.cs (EnumMember): Implement IConstant.
13161 (Enum.IsValidEnumConstant): Removed.
13162 (Enum.GetNextDefaultValue): Removed.
13163 (Enum.FindMembers): Updated.
13164 (Enum.GenerateDocComment): Iterate enum members.
13166 * expression.cs (Cast.TryReduce): Handle enums correctly.
13167 (New.Constantify): Made public.
13168 (MemberAccess.DoResolve): Removed contant specific if(s).
13170 * literal.cs (NullLiteral): Implement new abstract methods.
13172 * statement.cs (GotoCase.Resolve): Use new constant methods.
13173 (SwitchLabel.ResolveAndReduce): Use new constant methods.
13175 * typemanager.cs (LookupEnum): Removed.
13176 (IsEnumType): Fixed to work with corlib.
13177 (RegisterConstant): Removed.
13178 (LookupConstant): Removed.
13179 (GetConstant): Changed to work with IConstant.
13181 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
13183 * location.cs : Fixed overflown (>255) column number.
13185 2005-08-03 Raja R Harinath <rharinath@novell.com>
13187 First cut of the qualified-alias-member feature.
13188 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
13190 * cs-parser.jay (DOUBLE_COLON): New token.
13191 (namespace_or_type_name): Add rule for recognizing
13192 qualified-alias-members.
13193 (primary_expression): Likewise.
13194 (element_access): Allow QualifiedAliasMember as a possible
13195 type-bearing expression.
13196 (local_variable_type, local_variable_pointer_type): Likewise.
13197 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
13198 aliases in the current and enclosing namespace declarations.
13199 (NamespaceEntry.UsingAlias): Add CS0440 warning.
13200 * decl.cs (MemberName.is_double_colon): New.
13201 (MemberName.MemberName): Add new constructor for alias-member.
13202 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
13203 * expression.cs (QualifiedAliasMember): New expression type.
13205 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13207 * location.cs : it borked when no argument was specified.
13209 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13211 * location.cs : tiny ToString() format fix.
13213 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13215 * statement.cs : oops, it was missing.
13217 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13219 A set of fixes for precise line/column location.
13222 "token" field now holds a file/line "delta", a line number offset
13223 from the segment, and a column number. See also:
13224 http://lists.ximian.com/pipermail/mono-devel-list/2004-
13225 December/009508.html
13226 Removed static IsNull. Use instance IsNull property instead.
13227 * cs-tokenizer.cs :
13228 For some tokens it stores Location. For Identifier it stores
13229 LocatedToken which is a pair of string name and location.
13230 Column numbers are adjusted only at getChar().
13232 Use Location.ToString() for reporting (it now contains column).
13234 Largely modified to use LocatedToken instead of
13235 string (IDENTIFIER), and to acquire Location from some tokens.
13236 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
13237 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
13239 Now MemberName holds Location. DeclSpace.ctor() receives Location
13240 as a parameter. Removed extra parameters to all derived classes.
13241 Replaced Location.IsNull() with instance property.
13242 * assign.cs, expression.cs :
13243 Added .ctor() overload that omits Location.
13245 Added "nameEscaped" flag that indicates the identifier was escaped
13246 in the source file. This fixes bug #57047.
13248 2005-08-02 Marek Safar <marek.safar@seznam.cz>
13250 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
13251 New method, looking for lo-case imported cls type.
13253 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
13256 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
13258 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
13260 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
13261 all_imported_types.
13262 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
13264 Optimized to save 3.5 MB for SWF compilation.
13266 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13268 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
13269 (PartialContainer.Create): Moved logic AddToContainer.
13270 (PartialContainer.MarkForDuplicationCheck): Shares name.
13272 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
13275 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
13277 (Namespace.GetSignatureForError): New method.
13279 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
13280 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
13282 2005-08-01 Raja R Harinath <rharinath@novell.com>
13285 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
13286 member lookup rather than qualifier_type, since qualifier_type can
13289 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13291 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
13294 2005-07-31 Miguel de Icaza <miguel@novell.com>
13296 * statement.cs: Copy the local exception into the exception
13297 captured local. Fixes 75674
13299 2005-07-31 Raja R Harinath <harinath@gmail.com>
13302 * expression.cs (Invocation.OverloadResolve): Don't report error
13303 CS1501 if error CS1502 has been reported.
13304 (New.DoResolve): Delegate CS1501 reporting to
13305 Invocation.OverloadResolve.
13308 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
13309 invariant-meaning-in-block property in an enclosing block if
13312 2005-07-29 Marek Safar <marek.safar@seznam.cz>
13314 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
13315 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
13316 (Switch.CheckSwitch): Just save 50kb for SWF.
13318 2005-07-27 Martin Baulig <martin@ximian.com>
13320 * anonymous.cs (CaptureContext.AddField): Added
13321 `AnonymousContainer am' argument; compute its toplevel scope if
13322 it's not already computed. Fixes #75649.
13324 2005-07-26 Raja R Harinath <rharinath@novell.com>
13327 * class.cs (Constructor.Emit): Reset block to null if the block
13330 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13332 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
13334 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13336 * class.cs (MethodData.Define): Check whether accessor implementing
13337 interface is public.
13339 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
13341 2005-07-22 Marek Safar <marek.safar@seznam.cz>
13344 * namespace.cs (LookupType): Moved same type check to...
13346 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
13347 with the same name.
13349 2005-07-21 Raja R Harinath <rharinath@novell.com>
13351 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
13352 already found a typebuilder.
13353 * class.cs (MethodCore.IsDuplicateImplementation): Compare
13354 MemberNames, not strings.
13356 * const.cs (Error_ExpressionMustBeConst):
13357 Rename from Error_EpressionMustBeConst.
13358 * const.cs, class.cs, statement.cd: Update.
13360 2005-07-21 Marek Safar <marek.safar@seznam.cz>
13364 * const.cs (Const.LookupConstantValue): Report missing contant expression
13366 (Error_EpressionMustBeConstant): Only one error method.
13368 * class.cs, statement.c: Updated.
13370 2005-07-20 Raja R Harinath <rharinath@novell.com>
13372 * statement.cs (Block.Flags): Add back HasVarargs.
13373 (Block.flags): Make protected.
13374 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
13376 * typemanager.cs (types, typecontainers, user_types): Remove.
13377 (UserTypes, TypeContainers): Likewise.
13378 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
13379 (CleanUp, Reset): Update.
13380 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
13381 (GetNestedType): Use Type.GetNestedType.
13382 (CoreLookupType): Take two arguments, the namespace and the
13383 basename of the type. Update to use the Namespace.Lookup
13385 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
13386 (RealMemberLookup): Use IsNestedChildOf instead of playing with
13387 string concatenation and substring matches.
13388 * class.cs, enum.cs, delegate.cs: Update to changes.
13390 2005-07-20 Marek Safar <marek.safar@seznam.cz>
13392 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
13393 Expression and made virtual.
13395 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
13396 (ImplicitStandardConversionExists): Fixed `byte' typo ?
13398 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
13400 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
13403 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
13406 2005-07-18 Marek Safar <marek.safar@seznam.cz>
13409 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
13410 AssemblyCultureAttribute is not used on executable.
13413 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
13415 2005-07-16 Raja R Harinath <rharinath@novell.com>
13418 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
13419 New. Reports CS0252/CS0253.
13420 Mostly taken from preliminary patch by Duncak Mak.
13421 (Binary.DoResolveOperator): Store results of operator lookup.
13422 Use them to detect if we need to warn about unintended reference
13425 2005-07-15 Raja R Harinath <rharinath@novell.com>
13428 * namespace.cs (Namespace.Lookup): Add back location parameter.
13429 (Namespace.LookupType): Add CS0436 report. Add location parameter.
13430 * delegate.cs, ecore.cs, expression.cs: Update to changes.
13432 * codegen.cs (EmitContext.DeclSpace): Make readonly.
13433 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
13434 (Namespace.LookupType): ... this.
13435 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
13437 * typemanager.cs (LookupTypeReflection): Remove buggy code that
13438 purported to handle pointers.
13439 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
13442 2005-07-15 Marek Safar <marek.safar@seznam.cz>
13444 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
13447 2005-07-15 Raja R Harinath <rharinath@novell.com>
13449 * namespace.cs (Namespace.Lookup): Drop location parameter.
13450 (NamespaceEntry.LookupAlias): Remove. Merge into ...
13451 (NamespaceEntry.Lookup): ... this.
13452 (NamespaceEntry.Error_AmbiguousTypeReference):
13453 Move here from DeclSpace.
13454 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
13456 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
13457 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
13458 Move to NamespaceEntry.
13459 * delegate.cs, expression.cs: Update to changes.
13461 2005-07-14 Marek Safar <marek.safar@seznam.cz>
13463 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
13464 CheckAttributeType and refactored.
13465 (Attribute.ResolvePossibleAttributeType): Changed to reuse
13466 ResolveAsTypeTerminal error handling.
13467 (ResolveAsTypeTerminal): Introduced because of global attributes extra
13469 (GetSignatureForError): Print errors in same way.
13472 * codegen.cs: Reflect attribute GetSignatureForError change.
13475 * expression.cs: Add silent parameter to ResolveAsTypeStep.
13477 * namespace.cs (UsingEntry): Refactored to make fields private.
13480 statement.cs: Error_UnexpectedKind has extra parameter.
13482 2005-07-14 Raja R Harinath <rharinath@novell.com>
13484 * ecore.cs (IAlias): Remove.
13485 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
13486 that implement the interface.
13487 * namespace.cs (Namespace): Likewise.
13488 (Namespace.declspaces): Renamed from 'defined_names'.
13489 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
13490 DeclSpace instead of an IAlias.
13491 * tree.cs (Tree.AddDecl): Update.
13493 2005-07-12 Raja R Harinath <rharinath@novell.com>
13495 * statement.cs (Block.Flags); Remove HasVarargs.
13496 (Block.HasVarargs): Move to ToplevelBlock.
13497 (Block.ThisVariable, Block.AddThisVariable): Likewise.
13498 (Block.Variables): Make protected. Initialize variable hashtable
13500 (Block.AddVariable): Update.
13501 (Block.Resolve): Update to changes.
13502 (ToplevelBlock.HasVarargs): New boolean.
13503 (ToplevelBlock.ThisVariable): Move here from Block.
13504 (ToplevelBlock.AddThisVariable): Likewise.
13505 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
13506 * expression.cs (This.ResolveBase): Update to changes.
13507 (ArglistAccess.DoResolve): Likewise.
13509 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13512 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
13514 * class.cs (TypeContainer.VerifyMembers): Distinguish between
13515 not used and not used & assigned.
13516 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
13518 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13521 * expression.cs (Is.DoResolve): null is never provided type.
13523 2005-07-08 Marek Safar <marek.safar@seznam.cz>
13526 * cs-parser.jay: Less strict event error rule to catch more errors.
13528 2005-07-08 Martin Baulig <martin@ximian.com>
13530 Fix test-iter-10.cs - distinguish whether we `yield' in a property
13531 gettter (allowed) or setter (not allowed).
13533 * class.cs (Accessor): Implement IIteratorContainer.
13534 (Accessor.Yields): New public field.
13535 (PropertyBase.PropertyMethod.Define): Handle iterators on a
13536 per-accessor basis.
13539 (get_accessor_declaration, set_accessor_declaration): Set the
13540 `yields' flag on the accessor, not the property.
13541 (property_declaration): Do the iterators check on a per-accessor
13542 basis and not for the whole property.
13544 2005-07-08 Martin Baulig <martin@ximian.com>
13546 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13547 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13549 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13552 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13553 (ExtractSecurityPermissionSet): Cope with self referencing security
13554 attributes properly.
13556 * driver.cs (SetOutputFile): Made public property OutputFile.
13558 2005-07-07 Raja R Harinath <rharinath@novell.com>
13561 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13562 has_nonstatic_fields. Make into a FieldBase pointer.
13563 (TypeContainer.AddField): Add CS0282 check.
13564 (TypeContainer.EmitType): Update.
13566 2005-07-06 Miguel de Icaza <miguel@novell.com>
13568 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13569 compare if they start with __.
13571 2005-07-06 Raja R Harinath <rharinath@novell.com>
13573 * statement.cs (Switch.SwitchGoverningType): Only look at
13574 UserCasts that don't need implicit standard conversions to one of
13575 the allowed switch types (Fixes test-322.cs).
13576 (LocalInfo.Resolve): Re-enable sanity-test.
13578 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13580 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13582 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13584 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13586 2005-07-06 Raja R Harinath <rharinath@novell.com>
13589 * ecore.cs (SimpleName.GetSignatureForError): Add.
13590 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13591 (MemberAccess.GetSignatureForError): Add.
13593 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13595 The big error and warning messages review.
13625 * typemanager.cs: Updated.
13627 * class.cs: (MethodCore.SetYields): Moved here to share.
13628 (PropertyMethod.Define): Moved iterator setup here.
13630 * iterators.cs: Add orig_method to have full access to parent
13633 2005-07-05 Raja R Harinath <rharinath@novell.com>
13635 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13636 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13637 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13638 variable of struct type.
13639 * expression.cs (Unary.ResolveOperator): Update to change.
13640 (Indirection.VerifyFixed): Likewise.
13641 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13642 (ParameterReference.VerifyFixed): Value parameters are fixed.
13643 (This.VerifyFixed): Treat 'this' as a value parameter.
13644 * statement.cs (LocalInfo.IsFixed): Remove.
13646 2005-07-01 Martin Baulig <martin@ximian.com>
13648 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13649 `ec.EmitThis ()' to get the correct scope.
13651 2005-07-01 Martin Baulig <martin@ximian.com>
13653 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13654 instance is a ParameterReference; fixes #75299.
13656 2005-07-01 Martin Baulig <martin@ximian.com>
13658 Reverted Marek's latest patch (r46725):
13659 - it contains structural changes which are neither mentioned in
13660 the ChangeLog nor explained anywhere; for example the additional
13661 argument of EmitContext's and Iterator's .ctor's and the
13662 TypeContainer.DefineMembers() change.
13663 - structural changes like this should go in in seperate patches
13664 and not be hidden in a huge patch which just seems to affect
13665 warnings and errors.
13666 a big and hard to understand patch.
13667 - it breaks iterators and causes regressions, for instance in
13670 2005-06-30 Raja R Harinath <rharinath@novell.com>
13673 * expression.cs (Indexers.map): Remove.
13674 (Indexers.Append): Filter out inaccessible setters and getters.
13675 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13678 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13679 Refactored from ...
13680 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13681 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13682 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13683 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13685 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13688 * class.cs (FieldBase.GetInitializerExpression): One more field
13691 2005-06-28 Miguel de Icaza <miguel@novell.com>
13693 * pending.cs: Do not define a proxy if the base method is virtual,
13694 it will be picked up by the runtime (bug 75270).
13696 2005-06-08 Martin Baulig <martin@ximian.com>
13698 The big Iterators rewrite :-)
13700 * iterators.cs: Rewrite this to use the anonymous methods framework.
13702 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13703 before the TypeContainers; see 2test-21.cs.
13706 (TypeContainer.DefineType): Don't create a new EmitContext if we
13707 already have one (this only happens if we're an Iterator).
13708 (TypeContainer.Define): Also call Define() on all our iterators.
13709 (Method.CreateEmitContext): Added support for iterators.
13712 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13713 (AnonymousContainer.CreateMethodHost): Moved here from
13714 AnonymousMethod and made abstract.
13715 (AnonymousContainer.CreateScopeType): New abstract method.
13716 (AnonymousContainer.IsIterator): New public property.
13717 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13718 get the ScopeTypeBuilder rather than manually defining it here.
13719 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13722 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13723 before RootContext.DefineTypes().
13725 * codegen.cs (EmitContext.RemapToProxy): Removed.
13726 (EmitContext.CurrentAnonymousMethod): Changed type from
13727 AnonymousMethod -> AnonymousContainer.
13728 (EmitContext.ResolveTopBlock): Protect from being called twice.
13729 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13730 (EmitContext.EmitThis): Removed the iterators hacks; use the
13731 anonymous methods framework for that.
13734 (ToplevelBlock.Container): Make this a property, not a field.
13735 (ToplevelBlock.ReParent): New public method; move the
13736 ToplevelBlock into a new container.
13737 (Foreach.TemporaryVariable): Simplify.
13739 2005-06-05 Martin Baulig <martin@ximian.com>
13741 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13742 (Block.AddTemporaryVariable): New public method; creates a new
13743 `LocalInfo' for a temporary variable.
13744 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13746 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13747 non-iterator variables.
13749 2005-06-05 Martin Baulig <martin@ximian.com>
13751 * statement.cs (Foreach.TemporaryVariable): Create the
13752 LocalBuilder in the Emit phase and not in Resolve since in some
13753 situations, we don't have an ILGenerator during Resolve; see
13754 2test-19.cs for an example.
13756 2005-06-04 Martin Baulig <martin@ximian.com>
13758 **** Merged r45395 from GCS ****
13760 The big Foreach rewrite - Part II.
13762 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13763 with `PropertyInfo ienumerator_getcurrent'.
13765 * codegen.cs (VariableStorage): Removed.
13768 (Foreach): Derive from Statement, not ExceptionStatement.
13769 (Foreach.CollectionForeach): New nested class. Moved all the code
13770 dealing with collection foreach here.
13771 (Foreach.ForeachHelperMethods): Removed.
13772 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13774 2005-05-23 Martin Baulig <martin@ximian.com>
13776 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13777 don't need to. Fix #75014.
13779 2005-05-20 Martin Baulig <martin@ximian.com>
13781 Merged r44808 from GMCS.
13783 * class.cs (TypeContainer.CircularDepException): Removed.
13784 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13785 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13786 (CS0146) and interface (CS0529) dependencies here.
13788 2005-06-21 Raja R Harinath <rharinath@novell.com>
13790 * expression.cs (Invocation.EmitCall): Fix initialization
13791 'this_call' to reflect current behaviour. Fix indentation.
13793 * convert.cs (FindMostEncompassedType): Add two trivial special
13794 cases (number_of_types == 0 || number_of_types == 1).
13795 (FindMostEncompasingType): Likewise.
13797 2005-06-17 Raja R Harinath <rharinath@novell.com>
13799 Some cleanups preparing for the fix of #75283.
13800 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13802 (EventExpr.InstanceResolve): Likewise.
13803 (EventExpr.DoResolve): Remove redundant checks.
13805 2005-06-10 Duncan Mak <duncan@novell.com>
13807 * cs-tokenizer.cs (process_directives): New flag for controlling
13808 the processing of preprocessor directives.
13809 (x_token): After seeing a '#', return Token.NONE instead of going
13810 to handle_preprocessing_directive() when not processing
13811 directives. This avoids unnecessary processing during the token peek in
13816 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13817 the existing error reporting methods instead of Report.Error.
13819 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13820 after Raja's rewrite.
13822 2005-06-08 Miguel de Icaza <miguel@novell.com>
13824 * class.cs: Small fix.
13826 2005-06-08 Raja R Harinath <rharinath@novell.com>
13829 * class.cs (GetPartialBases): Fix return value check of
13830 part.GetClassBases.
13832 2005-06-07 Raja R Harinath <rharinath@novell.com>
13834 Ensure that partial classes are registered in their enclosing
13835 namespace. Initial part of fix of #75160.
13836 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13837 Register declspace with namespace here, not in
13838 DeclSpace.RecordDecl.
13839 * cs-parser.jay: Pass namespace to RecordDecl.
13840 * class.cs (PartialContainer.Create): Likewise.
13841 (ClassPart.DefineType): New sanity-check. Throws an exception if
13843 * decl.cs (Declspace.RecordDecl): Remove.
13844 * namespace.cs (NamespaceEntry.DefineName): Remove.
13846 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13848 * rootcontext.cs: Reset TargetExt as well.
13850 2005-06-03 Raja R Harinath <rharinath@novell.com>
13852 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13853 -langversion:ISO-1.
13855 2005-06-02 Raja R Harinath <rharinath@novell.com>
13857 Fix #75080, cs0119.cs.
13858 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13860 (Expression.Resolve): ... this. Use it. Remove bogus code
13861 allowing ExprClass.Type and ExprClass.Namespace for
13862 ResolveFlags.VariableOrValue.
13863 (Expression.Resolve) [1-argument variant]: Change default resolve
13864 flags based on language version.
13865 (Expression.Error_UnexpectedKind): Use a simple string array
13866 rather than an ArrayList.
13867 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13868 not ExprClass.Type.
13869 (TypeOfVoid.DoResolve): Likewise.
13870 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13871 flags argument -- it always has the same value.
13873 2005-05-31 Raja R Harinath <rharinath@novell.com>
13876 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13877 Use it in the error message.
13878 * assign.cs, expression.cs, statement.cs: Update.
13880 2005-05-30 Raja R Harinath <rharinath@novell.com>
13883 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13884 the "almostMatchedMember" case too.
13885 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13886 that failed the accessibility checks to 'almost_match'.
13888 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13890 * attribute.cs: Use internal MethodBuilder methods to set
13891 ExactSpelling and SetLastError on PInvoke methods, instead
13892 of passing them via charset. Fixes #75060.
13894 2005-05-27 Raja R Harinath <rharinath@novell.com>
13896 * parameter.cs (Parameter): Remove TODO comment.
13897 (Parameter.DefineParameter): Remove Location parameter.
13898 (Parameters.LabelParameters): Likewise.
13899 * class.cs (Constructor.Emit): Update to change.
13900 (MethodData.Emit): Likewise.
13901 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13902 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13904 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13907 Removed Parameters.Location and added Parameter.Location instead.
13908 Removed Location parameter from Emit() and GetSignature().
13915 Modified all related calls.
13917 2005-05-26 Raja R Harinath <rharinath@novell.com>
13919 Improve user-defined conversion handling.
13920 * convert.cs (GetConversionOperators): Rewrite. Return only the
13921 applicable operators.
13922 (AddConversionOperators): New. Helper for GetConversionOperators.
13923 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13924 there is only one most encompassed/encompassing type.
13925 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13926 "applicable operator" handling.
13927 (UserConversion): Move cache here from GetConversionOperators.
13928 Directly cache the chosen operator, rather than the whole
13930 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13931 case. Allow conversion of decimal to sbyte and byte too.
13932 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13933 New static methods. Used to avoid allocating EmptyExpressions in
13936 2005-05-24 Duncan Mak <duncan@novell.com>
13938 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13939 another class, used in Convert.ExplicitNumericConversion.
13940 (CastToDecimal): New class, similar to above, but casts to
13941 System.Decimal, used in Convert.ImplicitNumericConversion and also
13942 in explicit convesion from double/float to decimal.
13944 * convert.cs (ImplicitNumericConversion): Handle implicit
13945 conversions to System.Decimal.
13946 (ExplicitNumericConversion): handle explicit conversions to
13951 2005-05-20 Miguel de Icaza <miguel@novell.com>
13953 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13954 know the type at this stage, just break through. Fixes #75008
13956 2005-05-19 Martin Baulig <martin@ximian.com>
13959 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13960 to disable error reporting.
13962 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13963 here since we don't want to report an error; see the new test-336.cs.
13965 2005-05-19 Raja R Harinath <rharinath@novell.com>
13967 * statement.cs (ToplevelBlock.GetParameterReference)
13968 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13969 Move here from class Block.
13970 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13971 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13973 2005-05-18 Martin Baulig <martin@ximian.com>
13978 (FlowBranching.Reachability): Add non-static public And() and Or()
13980 (FlowBranchingSwitch): New class; do the `break_origins' thing
13981 like in FlowBranchingLoop.
13982 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13983 reachability, not just locals and parameters.
13984 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13985 switch; MergeBreakOrigins() now takes care of that.
13987 2005-05-18 Martin Baulig <martin@ximian.com>
13989 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13990 a loop and may leave it, reset the barrier; fixes #74974.
13992 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13994 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13997 * cs-parser.jay: Catch more lexical errors.
13999 * report.cs: Add one more Error method.
14002 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
14004 2005-05-17 Martin Baulig <martin@ximian.com>
14006 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
14009 2005-05-16 Raja R Harinath <rharinath@novell.com>
14011 Fix test-382.cs. Emit values of decimal constants.
14012 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
14014 (TypeContainer.AddField): ... this.
14015 (TypeContainer.EmitFieldInitializers): Allow the list of fields
14016 with initializers to include 'Const's.
14017 (ClassPart.RegisterFieldForInitialization): Forward to
14019 * const.cs (Const.Const): Pass initializer to base class.
14020 (Const.Define): In case of decimal constants, register them for
14021 initialization in a static constructor.
14023 2005-05-14 Martin Baulig <martin@ximian.com>
14025 * statement.cs (Block.Resolve): Correctly handle unreachable code;
14026 do not call ResolveUnreachable() on unreachable statements in
14027 here, see the comment in the source code.
14029 2005-05-13 Raja R Harinath <rharinath@novell.com>
14032 * expression.cs (BinaryResolveOperator): If one of the operands of
14033 an equality comparison is 'null' and the other is a pointer type,
14034 convert the null to a NullPointer.
14035 * convert.cs (ImplicitReferenceConversion): If the expression is a
14036 NullLiteral and the target type is a pointer type, return a
14037 NullPointer instead.
14038 (ImplicitConversionStandard): Likewise.
14040 2005-05-13 Marek Safar <marek.safar@seznam.cz>
14042 * cs-parser.jay: Set readonly context based on special constructs.
14044 * expression.cs (LocalVariableReference.DoResolveBase): Improved
14045 readonly variable error handling.
14047 * rootcontext.cs (EmitCode): Don't verify members when error
14050 * statement.cs (LocalInfo): Add reaodnly context information.
14051 (SetReadOnlyContext, GetReadOnlyContext): New methods.
14053 2005-05-13 Raja R Harinath <rharinath@novell.com>
14055 * statement.cs (Block.Resolve): Revert change below. Modify fix
14056 for #74041 to initialize 'resolved' to false only for explicit
14057 blocks. Fixes #74873.
14059 2005-05-12 Raja R Harinath <harinath@gmail.com>
14062 * typemanager.cs (unmanaged_enclosing_types): New.
14063 (IsUnmanagedType): Avoid infloops by using
14064 'unmanaged_enclosing_types' to talk with recursive invocations.
14066 2005-05-13 Martin Baulig <martin@ximian.com>
14068 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
14069 instance variable, not a local. Fix #74873.
14070 (Block.ResolveUnreachable): Set it to true here.
14072 2005-05-11 Duncan Mak <duncan@novell.com>
14074 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
14075 continuing to process for 'arg'.
14076 (handle_preprocessing_directive): Check the argument of the #endif
14077 directive and report error CS1025 if there are any trailing
14080 According to the C# spec, having even whitespace after the #endif
14081 directive is illegal; however, because we call arg.TrimEnd ()
14082 beforehand, we have the same behavior as csc, allowing whitespace
14083 after the directive.
14087 2005-05-11 Marek Safar <marek.safar@seznam.cz>
14091 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
14092 (Constructor.GetObsoleteAttribute): Implemented correctly.
14094 2005-05-10 Martin Baulig <martin@ximian.com>
14096 * support.cs (ReflectionParameters.ParameterModifier): Use
14097 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
14098 and `ParameterAttributes.In'. Fixes #74884.
14100 2005-05-10 Marek Safar <marek.safar@seznam.cz>
14102 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
14104 * expression.cs (Argument.GetParameterModifier): Turned to property.
14105 (Invocation.Error_InvalidArguments): Add more descriptive errors.
14107 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
14110 2005-05-09 Raja R Harinath <rharinath@novell.com>
14113 * decl.cs (MemberCache.AddMethods): Register override methods,
14114 rather than non-override methods.
14115 * typemanager.cs (RegisterOverride): New.
14116 (IsOverride): Update.
14118 2005-05-09 Marek Safar <marek.safar@seznam.cz>
14122 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
14123 recursive declaration.
14125 * statement.cs (Block.ResolveMeta): Report any error in resolving.
14127 2005-05-06 Marek Safar <marek.safar@seznam.cz>
14129 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
14131 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
14133 2005-05-05 Raja R Harinath <rharinath@novell.com>
14136 * decl.cs (DeclSpace.FamilyAccessible):
14137 Use TypeManager.IsNestedFamilyAccessible.
14139 Fix reopened #64812.
14140 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
14143 2005-05-04 Raja R Harinath <rharinath@novell.com>
14144 Abin Thomas <projectmonokochi@rediffmail.com>
14145 Anoob V E <projectmonokochi@rediffmail.com>
14146 Harilal P R <projectmonokochi@rediffmail.com>
14149 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
14150 allow access to all static members.
14152 2005-05-04 Martin Baulig <martin@ximian.com>
14154 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
14156 2005-05-04 Martin Baulig <martin@ximian.com>
14160 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
14161 section at the end; make things work if `default' is not the last
14164 2005-05-04 Martin Baulig <martin@ximian.com>
14168 * statement.cs (Switch): Replaced the `got_default' field with a
14169 `default_section' one.
14170 (Switch.CheckSwitch): Set `default_section' here.
14171 (Switch.Resolve): If we're a constant switch and the constant is
14172 not found, use the default section.
14174 2005-05-03 Martin Baulig <martin@ximian.com>
14176 * expression.cs (ArrayAccess.EmitGetLength): New public method.
14178 * statement.cs (Foreach.ArrayForeach): New nested class.
14179 (Foreach.TemporaryVariable): New nested class.
14180 (Foreach.EmitArrayForeach): Removed; this is now in the new
14181 ArrayForeach class.
14183 2005-05-03 Raja R Harinath <rharinath@novell.com>
14185 * pending.cs (BaseImplements): Move the #74773 fix here. This is
14187 (VerifyPendingMethods): Revert change below.
14189 * typemanager.cs (IsOverride, RegisterNonOverride): New.
14190 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
14191 that used to trigger warning -28. Remove warning -28.
14192 * expression.cs (Invocation.OverloadResolve): Use
14193 TypeManager.IsOverride to distinguish override methods.
14196 * pending.cs (VerifyPendingMethods): If a base type implements the
14197 requested interface, don't bother checking individual methods of
14198 the base type. As a side-effect, this prevents the creation of
14199 unnecessary proxies.
14201 2005-05-02 Martin Baulig <martin@ximian.com>
14205 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
14206 Also `And' the locals if the old vector is null.
14207 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
14208 null; in this case we basically reset all the variables.
14210 2005-05-02 Martin Baulig <martin@ximian.com>
14214 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
14215 Added `FlowBranching branching' argument; always `and' the
14216 variables instead of `or'ing them unless we're an infinite loop.
14218 * statement.cs (While.Resolve): Create a new sibling unless we're
14221 2005-05-02 Martin Baulig <martin@ximian.com>
14225 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
14226 arguments; use it instead of creating a new TopLevelBlock.
14227 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
14228 our ConstructorInitializer.
14231 (TopLevelBlock.TopLevelBranching): New public property.
14232 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
14233 and create our `TopLevelBranching'.
14235 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
14236 anonymous method host, use `block.TopLevelBranching' rather than
14237 creating a new branching.
14239 2005-04-20 Miguel de Icaza <miguel@novell.com>
14241 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
14242 a ScopeInfo, if any of the current children is a child of the new
14243 entry, move those children there.
14245 2005-04-30 Martin Baulig <martin@ximian.com>
14247 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
14248 at the beginning of a SwitchSection. Fix #73335.
14250 2005-04-27 Marek Safar <marek.safar@seznam.cz>
14253 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
14255 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
14256 (FieldExpr.DoResolve): Obsolete members are ignored for field
14259 2005-04-26 Marek Safar <marek.safar@seznam.cz>
14261 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
14262 of arrays detection.
14264 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
14266 (Field.VerifyClsCompliance): Volatile fields are not compliant.
14268 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
14271 2005-04-25 Ben Maurer <bmaurer@ximian.com>
14273 * cs-parser.jay: Use the prefered version of -unsafe in error
14276 2005-04-22 Marek Safar <marek.safar@seznam.cz>
14278 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
14281 2005-04-20 John Luke <john.luke@gmail.com>
14283 * driver.cs: fix typo in error message, --outout to --output
14285 2005-04-20 Marek Safar <marek.safar@seznam.cz>
14287 * codegen.cs (InRefOutArgumentResolving): New field.
14289 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
14290 fields outside contructor.
14292 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
14294 2005-04-19 Miguel de Icaza <miguel@novell.com>
14296 * anonymous.cs (CaptureContext.EmitParameterInstance): The
14297 parameter code was not completed ever, so it was not as up-to-date
14298 as local variables. Must finish it.
14300 The bug fix was to compare the Toplevel of the block, not the
14301 current block. Thanks for Ben for pointing this out.
14303 2005-04-19 Raja R Harinath <rharinath@novell.com>
14305 * decl.cs (AddMethods): Use the declaring type of the problem
14306 method to determine if we want to squash a warning.
14308 2005-04-19 Marek Safar <marek.safar@seznam.cz>
14310 * attribute.cs: Removed debug output.
14312 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
14314 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
14317 2005-04-18 Raja R Harinath <rharinath@novell.com>
14320 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
14321 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
14322 all null comparisons against reference types.
14324 2005-04-18 Marek Safar <marek.safar@seznam.cz>
14327 * class.cs (TypeContainer.CircularDepException) New nested
14329 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
14330 (TypeContainer.DefineType): Removed error, reset InTransit before
14332 (Class.DefineType): Throw exception when is in Transit.
14333 Catch exception and report error.
14334 (Struct.DefineType): Throw exception when is in Transit.
14335 Catch exception and report error.
14336 (Interface.DefineType): Throw exception when is in Transit.
14337 Catch exception and report error.
14339 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
14340 handle nested exception handlers.
14342 * flowanalysis.cs (InTryWithCatch): New method, search for try with
14345 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
14346 InFinally and InCatch storage.
14348 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
14349 (Catch.Resolve): Set and Restore ec.InCatch.
14350 (Try.Resolve): Set and Restore ec.InFinally.
14351 (Try.HasCatch): True when try has catch.
14353 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
14355 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
14356 for the same event member, so exclude such cases from warning 419.
14359 2005-04-16 Miguel de Icaza <miguel@novell.com>
14361 * expression.cs (Binary.ResolveOperator): Apply patch from John
14362 Luke to fix bug 59864: operators &, | and ^ on enumerations
14363 require that the same enum type on both sides.
14365 * driver.cs: Add warnings to old flag usage, this is to assist
14366 people who produce Makefiles and hope that the Makefiles will be
14369 * class.cs (TypeContainer.EmitType): Moved the definition of the
14370 special $PRIVATE$ field from the resolve phase to the Emit phase.
14371 During resolve we do not know if we are a struct with
14372 HasExplicitLayout, we know this only after the attributes for the
14375 Set the FieldOffset to zero on the dummy field that we create for
14376 the class. Fixes 74590.
14378 2005-04-16 Raja R Harinath <rharinath@novell.com>
14381 * ecore.cs (PropertyExpr.resolved): New.
14382 (DoResolve): Use it to handle a case of double resolution here.
14383 Handle a case of identical-name-and-type-name.
14384 * expression.cs (ArrayCreation.CheckIndices): Avoid double
14385 resolution by storing the results of expression resolution back
14386 into the "probes" array.
14388 2005-04-15 Raja R Harinath <rharinath@novell.com>
14390 Fix cs0208-7.cs and cs0208-8.cs.
14391 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
14392 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
14393 error reporting to point out the reason a struct is not unmanaged.
14395 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14397 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
14398 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
14400 2005-04-13 Raja R Harinath <rharinath@novell.com>
14403 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
14404 IdenticalNameAndTypeName here.
14405 (EventExpr.InstanceResolve): Likewise.
14407 2005-04-13 Marek Safar <marek.safar@seznam.cz>
14409 C# 2.0 DefaultCharSetAttribute implementation
14411 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
14412 which allows us to set GlobalNamespace for every resolve.
14413 (Attribute.ResolveArguments): Cut from Resolve.
14414 (Attribute.GetCharSetValue): Returns CharSet named argument.
14415 (Attribute.DefinePInvokeMethod): Gets default charset from
14417 (GlobalAttribute.ResolveAsTypeStep): Override.
14418 (GlobalAttribute.ResolveArguments): Override.
14420 * class.cs (TypeAttr): Is protected.
14422 * codegen.cs (ModuleClass.DefaultCharSet): New member.
14423 (ModuleClass.DefaultCharSetType): New memeber.
14424 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
14426 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
14427 charset from module.
14429 * delegate.cs (TypeAttr): Override.
14430 (Delegate.DefineType): Use this TypeAttr.
14432 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
14433 at very early stage (before types are defined) to resolve model
14434 module attributes. It will probably not work with corlib but it
14437 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
14438 charset from module.
14440 * typemanager.cs (default_charset_type): New type.
14442 2005-04-13 Raja R Harinath <rharinath@novell.com>
14444 * decl.cs (MemberCache.AddMethods): Don't warn if
14445 System.Object.Finalize has buggy MethodAttributes.
14447 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
14450 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14452 * doc.cs : detect ambiguous reference to overloaded members.
14453 Fixed bug #71603. MS 1.1 csc does not detect it.
14455 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14457 * doc.cs : delegates must not be referenced with parameters.
14460 2005-04-12 Miguel de Icaza <miguel@novell.com>
14462 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
14464 2005-04-10 Miguel de Icaza <miguel@novell.com>
14466 * driver.cs (MainDriver): Stop processing if the CLS stage found
14469 (CompilerCallableEntryPoint.InvokeCompiler): Always
14470 reset after execution; Take a TextWriter argument for the
14473 * report.cs: Use the error stream instead of hardcoding stderr.
14475 2005-04-09 Miguel de Icaza <miguel@novell.com>
14477 * class.cs: Reduce code paths to test, too small of an
14478 optimization to make it worth the extra testing. Always perform
14481 2005-04-08 Raja R Harinath <rharinath@novell.com>
14484 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
14485 operators that had errors reported on them.
14487 2005-04-08 Marek Safar <marek.safar@seznam.cz>
14489 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
14491 (Attribute.Resolve): Add named argument type checking.
14493 * class.cs (FixedField.Define): Use IsPrimitiveType
14495 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
14497 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
14498 unsafe parameter types.
14500 * statement.cs (Using.ResolveExpression): Add better error description.
14502 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
14504 2005-04-08 Raja R Harinath <rharinath@novell.com>
14507 * attribute.cs (Attribute.GetAttributeUsage): Resolve
14508 AttributeUsageAttribute in the emitcontext of the attribute class,
14509 not in the emitcontext of the attributable entity it was attached to.
14510 * cs-parser.jay: Use 'current_class', not 'current_container',
14511 when creating a GlobalAttribute.
14513 2005-04-08 Alp Toker <alp@atoker.com>
14515 * pending.cs: The fix to #58413 failed to compile methods implementing
14516 interfaces with/without params modifiers and vice versa, even though
14517 params modifiers aren't part of the signature. Make the modifier check
14518 less strict as in csc.
14520 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
14521 Anoob V E <projectmonokochi@rediffmail.com>
14522 Harilal P R <projectmonokochi@rediffmail.com>
14525 * pending.cs (TypeAndMethods.mods): New. Store the parameter
14526 modifiers of pending methods.
14527 (PendingImplementation.PendingImplementation): Initialize it.
14528 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
14529 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
14530 with ParameterData. Add check for modifiers.
14531 * class.cs (MethodData.Define): Update to changes.
14533 2005-04-07 Raja R Harinath <rharinath@novell.com>
14535 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
14537 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14539 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14542 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14545 * typemanager.cs: Registered RequiredAttributeAttribute.
14547 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14549 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14550 Warning CS0169 is back at level 3.
14551 (IMethodData.SetMemberIsUsed): New method.
14553 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14554 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14556 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14558 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14560 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14563 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14566 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14567 to avoid the problems with nested types.
14569 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14570 Anoob V.E <projectmonokochi@rediffmail.com>
14571 Harilal P.R <projectmonokochi@rediffmail.com>
14572 Raja R Harinath <rharinath@novell.com>
14575 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14577 * typemanager (GetConstructor): Make public.
14579 2005-04-05 John Luke <john.luke@gmail.com>
14580 Raja R Harinath <rharinath@novell.com>
14583 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14584 struct too. Return false quicker in a few cases.
14585 (VerifyUnManaged): Use it.
14587 2005-04-05 Raja R Harinath <rharinath@novell.com>
14590 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14591 not 'unreachable_seen'.
14593 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14595 * attribute.cs (Attribute.GetValue): Removed unused.
14597 * codegen.cs (CodeGen.TrimExt): Removed unused.
14599 * cs-parser.jay (output): Removed unused.
14601 * cs-tokenizer.cs (hex_digits): Removed unused.
14603 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14605 * expression.cs (Indirection.LoadExprValue): Removed unused.
14606 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14608 * iterators.cs (Iterator.param_types): Removed unused.
14610 * statement.cs (Goto.block): Removed unused.
14611 (ToplevelBlock.did): Removed unused.
14612 (Switch.ResolveConstantSwitch): Removed unused.
14614 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14616 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14619 2005-04-01 Raja R Harinath <rharinath@novell.com>
14621 Fix #74232 and cs0208-3.cs.
14622 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14623 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14624 unmanaged type. Don't use FieldBuilders when 't' is a
14625 TypeBuilder. Use ModFlags and MemberType fields.
14626 * class.cs (MemberBase.member_type): Rename from MemberType.
14627 (MemberBase.MemberType): New property. Determines member_type on
14629 (MemberBase.DoDefine): Don't initialize MemberType here.
14630 (FieldMember.Define): Likewise.
14632 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14635 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14636 Attributes are emitted there.
14638 2005-04-01 Raja R Harinath <rharinath@novell.com>
14640 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14641 keyword in 'partial enum' too.
14642 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14644 Report from Kamil Skalski <nazgul@omega.pl>.
14647 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14648 have partial containers too.
14650 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14651 in block' checks to Block.CheckInvariantMeaningInBlock.
14652 * statement.cs (Block.GetKnownVariableInfo): Make private.
14653 (Block.IsVariableUsedInChildBlock): Remove.
14654 (Block.IsVariableUsedInBlock): Likewise.
14655 (Block.CheckInvariantMeaningInBlock): New. Show location of
14656 conflicting declaration.
14657 (Block.AddVariable): Make error messages less long-winded and more
14658 specific. Show location of conflicting declaration.
14659 * parameter.cs (Parameters.Location): New readonly property.
14661 2005-03-31 Raja R Harinath <rharinath@novell.com>
14663 Clean up semantics of invoking ResolveMemberAccess.
14664 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14665 can have an instance, ensure that we pass in a non-TypeExpression
14666 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14667 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14668 argument. Update to changes and simplify.
14669 (FieldExpr.Emitinstance): Remove CS0120 check.
14670 (PropertyExpr.EmitInstance): Likewise.
14671 * expression.cs (Argument.Resolve): Likewise.
14672 (Invocation.DoResolve): Update to changes in semantics of
14673 InstanceExpression.
14675 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14678 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14681 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14683 2005-03-31 Raja R Harinath <rharinath@novell.com>
14685 Fix difference in behaviour with commandline invocation.
14686 * driver.cs (Driver.Reset): New.
14687 (CompilerCallableEntryPoint): Call it.
14689 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14690 variable" warnings if the boolean expression failed to resolve.
14692 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14694 * attribute.cs: Fix the union of several permissions when some of them
14695 are unrestricted (so the result isn't an unrestricted permission set).
14698 2005-03-30 Raja R Harinath <rharinath@novell.com>
14700 * ecore.cs (MemberExpr): New class. Convert from interface
14702 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14703 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14705 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14706 (MethodGroupExpr.IsExplicitImpl): Remove.
14707 (Expression.GetFieldFromEvent): Remove.
14708 (SimpleName.MemberStaticCheck): Remove.
14709 (SimpleName.DoSimpleNameResolve): Update to changes.
14710 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14711 (MemberAccess.IdenticalNameAndTypeName): Remove.
14712 (MemberAccess.error176): Move to MemberExpr.
14713 (MemberAccess.DoResolve): Update to changes.
14714 (BaseAccess.DoResolve): Likewise.
14716 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14718 C# 2.0 Conditional attribute class implementation
14720 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14721 Analyzes class whether it has attribute which has ConditionalAttribute
14722 and its condition is not defined.
14724 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14725 (Class.IsExcluded): New method. Search for at least one defined
14726 condition in ConditionalAttribute of attribute class.
14728 2005-03-30 Raja R Harinath <rharinath@novell.com>
14730 * ecore.cs (PropertyExpr): Derive from Expression, not
14731 ExpressionStatement.
14732 (PropertyExpr.EmitStatement): Remove.
14734 2005-03-29 Raja R Harinath <rharinath@novell.com>
14737 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14738 internal field "value__" of an enum be private. The examples for
14739 "value__" that I found on MSDN all used FieldAttributes.Private.
14741 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14742 Don't mention IL method attribute names.
14744 Fix #47991. Remove a TODO.
14745 * statement.cs (Block.Toplevel): Make into a field.
14746 (Block.Parameters): Move into ToplevelBlock.
14747 (Block.known_variables): Rename from child_variable_names.
14748 (Block.Block): Remove variants that take Parameters. Initialize
14749 'Toplevel' with the immediately surrounding toplevel block.
14750 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14751 LocalInfo parameter.
14752 (Block.GetKnownVariableInfo): New.
14753 (Block.IsVariableNameUsedInChildBlock): Update.
14754 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14755 the block, even though it may not be in scope.
14756 (Block.AddVariable): Remove Parameters parameter. Use
14757 Toplevel.Parameters instead.
14758 (Block.AddConstant): Remove Parameters parameter.
14759 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14760 (Block.IsParamaterReference): Likewise.
14761 (Block.IsLocalParameter): Likewise. Simplify a lot.
14762 (ToplevelBlock.Parameters): New. Moved from Block.
14763 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14764 initialize Parameters to a non-null value.
14765 * cs-parser.jay: Update to changes.
14766 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14767 simple names that mean different things in the same block. Use
14768 Block.IsVariableNameUsedInBlock.
14770 2005-03-28 Raja R Harinath <rharinath@novell.com>
14772 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14773 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14774 GetTypeHandle. It is possible for a reflected type to derive from
14775 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14776 System.Array during mscorlib compilation).
14777 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14778 contain a method_hash, don't create one either. Don't create a
14779 deep copy of the base cache's method_hash.
14780 (MemberCache.SetupCache): Rename back from DeepCopy.
14781 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14782 already initialized. If we see an override function, add its
14783 underlying base virtual function to the member_hash too.
14785 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14787 2005-03-26 Raja R Harinath <harinath@acm.org>
14790 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14791 fails to resolve, ensure that the LHS is still resolved as an
14794 2005-03-25 Raja R Harinath <harinath@acm.org>
14796 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14798 (Enum.current_ec): Remove.
14799 (Enum.LookupEnumValue): Remove EmitContext argument.
14800 Just uses the one created during DefineType.
14801 (Enum.FindMembers): Update.
14802 * expression.cs (MemberAccess.DoResolve): Update.
14804 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14806 * assign.cs (Assign.DoResolve): Check for CS1717 when
14807 source and target are same (uses Equals).
14809 * expression.cs (LocalVariableReference, ParameterReference,
14810 This): Implemented Equals, GetHashCode.
14812 * statement.cs (Block.GetParameterReference): Removed useless
14815 2005-03-22 Raja R Harinath <rharinath@novell.com>
14818 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14819 blocks before deciding whether the error is cs0136 or cs0128.
14821 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14822 (using_alias_directive, using_namespace_directive): Pass
14823 MemberName, not an expression to Namespace.UsingAlias and
14825 (MakeName): Use the MemberName of the namespace.
14826 * namespace.cs (Namespace.MemberName): New.
14827 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14828 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14830 * decl.cs (MemberName.Name): Make readonly.
14831 (MemberName.FromDotted): New "constructor".
14832 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14833 (MemberCore.Name): Compute from MemberName on demand.
14834 (MemberCore.SetMemberName): Provide a way to change the
14836 (MemberCore.AddToContainer): Don't take a fullname parameter.
14837 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14838 fully qualified name of the container to the member name.
14839 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14840 only if the type is a member of the root container.
14841 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14842 MemberName.Left rather than searching for an embedded ".".
14843 (PartialContainer.CreatePart): Update to changes in RootContext.
14844 (MemberBase.ShortName): Turn into a property. Use
14845 MemberCore.SetMemberName.
14846 (MemberBase.ExplicitInterfaceName): Remove.
14847 (MemberBase.UpdateMemberName): Remove.
14848 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14849 (PropertyBase.SetMemberName): New override.
14850 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14851 (Tree.GetDecl): New.
14852 (Tree.AllDecls): Rename from Decls.
14853 * attribute.cs, enum.cs, report.cs: Update to changes.
14854 * driver.cs (MainDriver): Use MemberName.FromDotted on
14855 RootContext.MainClass.
14857 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14859 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14862 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14864 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14866 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14867 property accessor modifiers.
14869 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14870 fixed buffer attribute (CS1716).
14871 (PropertyMethod.HasCustomAccessModifier): When property accessor
14872 has custom modifier.
14874 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14876 (PropertyExpr.DoResolveLValue): Add CS0272.
14878 2005-03-17 Miguel de Icaza <miguel@novell.com>
14880 * convert.cs: When converting to a pointer, use the proper Conv.U
14881 or Conv.I depending on the source data type.
14883 * cs-tokenizer.cs: Make the size for large decimal constants,
14886 2005-03-17 Martin Baulig <martin@ximian.com>
14888 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14889 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14891 2005-03-17 Martin Baulig <martin@ximian.com>
14893 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14894 to bool so we can return an error condition.
14895 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14898 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14900 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14903 2005-03-16 Raja R Harinath <rharinath@novell.com>
14905 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14906 Refactor to avoid traversing the list of assemblies, and to avoid
14907 string concatenation.
14908 * typemanager.cs (guid_attr_type): Remove.
14909 (negative_hits, pointers, references): Remove hashes.
14911 (GetConstructedType): New. Uses type_hash to handle constructed
14912 types (arrays, references, pointers).
14913 (GetReferenceType, GetPointerType): Use it.
14914 (GetNestedType): New. Uses type_hash to handle nested types of
14916 (LookupType, LookupTypeDirect): Remove.
14917 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14918 'types' hash and LookupTypeReflection directly.
14919 (params_string, params_object): Use GetConstructedType.
14920 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14922 (Namespace.Lookup): Use cached_types.
14923 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14924 provided by old TypeManager.LookupType.
14925 * rootcontext.cs (MakeFQN): Remove.
14926 * decl.cs (DeclSpace.MakeFQN): Likewise.
14927 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14928 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14929 TypeManager.GetConstructedType.
14930 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14932 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14934 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14937 * cs-parser.jay: Reports CS1527 for any namespace element.
14939 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14942 * expression.cs (ParameterReference.IsAssigned): Changed error to
14944 (Error_WrongNumArguments): Moved CS0245 detection here.
14946 * statement.cs (Return.Resolve): Add CS1622 report.
14948 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14950 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14952 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14954 * attribute.cs expression.cs: Get rid of some allocations.
14956 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14958 * doc.cs : just eliminate the latest change.
14960 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14962 * doc.cs : commented out the latest change. It breaks xml-030.cs
14964 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14966 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14967 fail. So invoke CreateType() in FindDocumentedType().
14969 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14971 * cs-tokenizer.cs : added IsKeyword().
14972 * doc.cs : Detect keyword incorrectly used as identifier.
14973 Allow identifiers prefixed by @.
14975 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14977 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14978 It caused exception in namespace resolving (again!).
14980 * class.cs (Class.ctor): Removed exit.
14981 (PropertyMethod.ctor): ditto.
14983 * codegen.cs (Codegen.Reset): Reset static data.
14984 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14986 * cs-tokenizer.cs (Cleanup): Removed.
14988 * driver.cs (GetSystemDir): Rewrote to one line command.
14989 It caused problem with unloaded dynamic modules.
14990 (UnixParseOption): Removed Exit.
14991 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14992 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14993 Now can be mcs used as library.
14995 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14998 * location.cs (Reset): Reset static data.
15000 * namespace.cs (Reset): Reset static data.
15002 * report.cs (Report.Reset): Reset static data.
15004 * rootcontext.cs (RootContext.Reset): Reset static data.
15006 * tree.cs (RootTypes.ctor): Use Location.Null
15008 * typemanager.cs (TypeManager.Reset): Reset static data.
15009 (CoreLookupType): Removed Exit.
15010 (TypeHandle.Reset): Reset static data.
15012 2005-03-10 Raja R Harinath <rharinath@novell.com>
15015 * typemanager.cs (ComputeNamespaces): Import namespaces from
15016 referenced modules too.
15018 2005-03-09 Raja R Harinath <rharinath@novell.com>
15020 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
15023 2005-03-09 Raja R Harinath <rharinath@novell.com>
15025 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
15026 enclosing DeclSpace. This ensures that a name-lookup populates
15027 more caches and there are fewer 'TypeExpression's. Carve out
15028 nested type lookup into ...
15029 (LookupNestedTypeInHierarchy): ... this.
15031 2005-03-09 Raja R Harinath <rharinath@novell.com>
15033 Clean up a few partial-class semantics.
15034 Fixes test-357.cs and cs1618-2.cs.
15035 * cs-parser.jay (struct_declaration): Use 'current_class' as
15036 parent of newly-created struct. Remove call to Register ().
15037 Use 'pop_current_class' to complete handing the current struct.
15038 (interface_declaration): Likewise.
15039 (class_declaration): Likewise.
15040 (enum_declaration): Use 'current_class' as parent of newly created
15042 (delegate_declaration): Likewise.
15043 (pop_current_class): New function. This is used to handle closing
15044 up the 'current_class' and 'current_container', and pointing them
15045 to the enclosing class/container.
15046 (CSharpParser): Initialize 'current_class' too.
15047 * decl.cs (MemberCore): Add check for invariant: a partial
15048 container is not a parsed entity, and thus does not enclose any
15050 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
15051 (DeclSpace.BaseTypeExpr): Use it.
15052 (DeclSpace.LookupType): Add check for invariant.
15053 * class.cs (TypeContainer): Add check for invariant: a nested
15054 class should have the same NamespaceEntry as its enclosing class.
15055 (TypeContainer.EmitFieldInitializers): Make virtual.
15056 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
15058 (TypeContainer.Register): Remove.
15059 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
15060 null. Use TypeResolveEmitContext for resolving base types and
15061 interfaces. Move initialization of Parts.TypeBuilder here from
15063 (TypeContainer.DefineNestedTypes): ... here.
15064 (PartialContainer): Take a Namespace not a NamespaceEntry.
15065 (PartialContainer.Create): Don't use Register. Call the
15066 appropriate Add... function directly.
15067 (ClassPart): Take both the PartialContainer and the enclosing
15068 class as constructor arguments.
15069 (ClassPart.EmitFieldInitializers): Override.
15070 (ClassPart.PartFindNestedTypes): Remove.
15071 (FieldBase.GetInitializerExpression): Resolve the initializer
15072 expression in the emit context of the enclosing class.
15073 * tree.cs (RootTypes): Remove Register ().
15075 2005-03-08 Marek Safar <marek.safar@seznam.cz>
15077 * cs-parser.jay: Removed CS0134.
15079 * driver.cs: Removed CS1901.
15081 * expression.cs (SizeOf.DoResolve): Don't report CS0233
15082 for predefined types.
15084 2005-03-07 Duncan Mak <duncan@novell.com>
15086 * codegen.cs (Save): Catch UnauthorizedAccessException as
15087 well. Fixes bug #73454.
15089 2005-03-07 Marek Safar <marek.safar@seznam.cz>
15091 * cs-tokenizer.cs (xtoken): Add CS1035.
15093 * class.cs (MethodData.Define): Add CS0683.
15094 (FieldMember.ctor): Add CS0681.
15096 2005-03-07 Raja R Harinath <rharinath@novell.com>
15098 * ecore.cs (SimpleName.DoResolve): Rename from
15099 SimpleName.DoResolveAllowStatic.
15100 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
15101 Pass 'intermediate' flag to MemberStaticCheck.
15102 (SimpleName.MemberStaticCheck): Skip "static check" only in case
15103 of "intermediate" lookups via MemberAccess.
15104 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
15105 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
15107 2005-03-07 Raja R Harinath <rharinath@novell.com>
15110 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
15111 slipped in because of variable names that are identical to a
15112 builtin type's BCL equivalent ('string String;', 'int Int32;').
15113 (PropertyExpr.EmitInstance): Likewise.
15115 2005-03-04 Marek Safar <marek.safar@seznam.cz>
15117 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
15119 * report.cs (warning_ignore_table): Made public.
15121 2005-03-04 Raja R Harinath <rharinath@novell.com>
15124 * class.cs (MethodData.Emit): Pass 'container' to
15125 container.GetObsoleteAttribute instead of 'container.Parent'.
15127 2005-03-03 Marek Safar <marek.safar@seznam.cz>
15129 * cs-parser.jay: Add 1534 error test.
15131 * iterators.cs (Yield.CheckContext): Add error 1629.
15132 (Iterator.ctor): Save unsafe modifier.
15133 (MoveNextMethod.DoEmit): Restore unsafe context.
15135 * namespace.cs (UsingAlias): Better error message.
15137 2005-03-03 Dan Winship <danw@novell.com>
15139 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
15140 the warning message [#73219]
15142 2005-03-03 Raja R Harinath <rharinath@novell.com>
15144 Fix compile with MCS 1.0.0.0.
15145 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
15146 w_restore to not depend on string constant folding.
15148 2005-03-03 Raja R Harinath <rharinath@novell.com>
15150 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
15151 CS0246 check to users who passed 'silent = false'.
15152 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
15154 (SimpleName.SimpleNameResolve): Update.
15155 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
15156 (MemberAccess.IdenticalNameAndTypeName): Update.
15157 * doc.cs (FindDocumentedTypeNonArray): Update.
15159 2005-03-03 Raja R Harinath <rharinath@novell.com>
15161 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
15162 * parameters.cs (ComputeAndDefineParameters): Remove.
15163 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
15164 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
15165 Use GetParameterInfo.
15167 2005-03-02 Marek Safar <marek.safar@seznam.cz>
15169 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
15171 2005-03-02 Raja R Harinath <rharinath@novell.com>
15173 Unify DeclSpace.LookupType and DeclSpace.FindType.
15174 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
15175 is in charge of defining nested types on demand.
15176 (DeclSpace.LookupType): Use it when the current_type is a
15177 TypeBuilder. Use LookupTypeDirect for reflected types.
15178 (DeclSpace.FindType): Remove.
15179 (DeclSpace.LookupInterfaceOrClass): Likewise.
15180 (DeclSpace.DefineTypeAndParents): Likewise.
15181 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
15182 DeclSpace.LookupType.
15183 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
15184 * typemanager.cs (LookupType): Simplify.
15185 (AddUserType): Remove type from negative_hits.
15186 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
15187 * class.cs (TypeContainer.FindMembers): Move handling of nested
15189 (TypeContainer.FindMembers_NestedTypes): ... here.
15190 (TypeContainer.FindNestedType): Implement override.
15191 (ClassPart.FindNestedType): Delegate to PartialContainer.
15192 (ClassPart.PartFindNestedType): Looks up the nested types of the
15195 2005-03-02 Martin Baulig <martin@ximian.com>
15197 * class.cs (TypeContainer.DoDefineMembers): We also need a default
15198 static constructor in static classes.
15200 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
15202 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
15203 sizeParamIndex is not specified.
15205 2005-03-01 Marek Safar <marek.safar@seznam.cz>
15208 * report.cs (WarningMessage.IsEnabled): Missing null check.
15210 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15212 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
15213 in the fields and not in the properties.
15215 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
15217 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
15220 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15222 * attribute.cs: Small refactoring (improved robustness).
15223 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
15224 (ValidateGuid): Removed.
15225 (Resolve): Removed referenced to above mentioned.
15226 (GetAttributeUsage): Made private and changed to work without
15228 (GetIndexerAttributeValue): Don't crash.
15229 (GetConditionalAttributeValue): Ditto.
15230 (GetClsCompliantAttributeValue): Ditto.
15231 (ExtractSecurityPermissionSet): All attributes exceptions are
15233 (GetPropertyValue): New helper.
15234 (GetMethodImplOptions): New method.
15235 (DefinePInvokeMethod): Reuse common code. Implemented handling of
15236 some missing properties.
15238 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
15239 (Method.ApplyAttributeBuilder): Updated.
15241 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
15244 2005-02-28 Raja R Harinath <rharinath@novell.com>
15247 * report.cs (Report.SymbolRelatedToPreviousError): Handle
15248 non-simple types (array, pointer, reference).
15250 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15252 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
15254 * class.cs (MethodCore.IsDuplicateImplementation): Special error
15256 (Method.CheckBase): Catch wrong destructor here.
15257 (MethodData.Define): Add errors 550, 668.
15259 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
15261 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
15263 * pending.cs (VerifyPendingMethods): Add error 551.
15265 * typemanager.cs (CSharpName): Next error report helper.
15267 2005-02-25 Marek Safar <marek.safar@seznam.cz>
15269 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
15270 attributes. Removed useless attribute double check.
15271 It saves almost 2MBs for corlib.
15273 2005-02-25 Raja R Harinath <rharinath@novell.com>
15276 * statement.cs (ExpressionStatement.Resolve): Make robust to being
15277 called twice in case of error.
15279 2005-02-23 Chris Toshok <toshok@ximian.com>
15281 Fix compiler portions of #72827.
15282 * statement.cs (Block.Emit): call Begin/EndScope on the
15283 EmitContext instead of the ILGenerator.
15285 * codegen.cs (EmitContext.BeginScope): new method, call
15286 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
15288 (EmitContext.BeginScope): same, but EndScope and CloseScope
15290 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
15291 offset and call the superclass's OpenScope(int) with it.
15292 (SymbolWriter.CloseScope): get the current il
15293 offset and call superclass's CloseScope(int) with it.
15295 2005-02-23 Marek Safar <marek.safar@seznam.cz>
15297 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
15298 CS1677 for out and ref as well.
15300 * class.cs (Method.Define): Add error CS1599 detection.
15302 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
15304 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
15306 * delegate.cs (Delegate.Define): Add error CS1599 detection.
15308 * support.cs.cs (ModifierDesc): New helper method.
15310 2005-02-23 Raja R Harinath <rharinath@novell.com>
15311 Abin Thomas <projectmonokochi@rediffmail.com>
15312 Anoob V E <projectmonokochi@rediffmail.com>
15313 Harilal P R <projectmonokochi@rediffmail.com>
15315 Fix #57851, #72718.
15316 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
15317 MemberLookup (used for error reporting) actually returns a result.
15318 Fix error report number (122, not 112).
15320 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
15321 Anoob V E <projectmonokochi@rediffmail.com>
15322 Harilal P R <projectmonokochi@rediffmail.com>
15325 * pending.cs (PendingImplementation.GetAbstractMethods):
15326 Find NonPublic members too.
15328 2005-02-22 Marek Safar <marek.safar@seznam.cz>
15330 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
15333 * class.cs (MethodCore.CheckMethodAgainstBase):
15334 Add error 239 report.
15336 2005-02-21 Raja R Harinath <rharinath@novell.com>
15339 * expression.cs (Invocation.IsApplicable): Make public.
15340 (Invocation.IsParamsMethodApplicable): Likewise.
15341 * delegate.cs (Delegate.VerifyApplicability): Don't use
15342 Invocation.VerifyArgumentCompat for parameter applicability
15343 testing. Use Invocation.IsApplicable and
15344 Invocation.IsParamsMethodApplicable.
15346 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15348 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
15350 * class.cs (Operator.Define): Add error 217 report.
15352 2005-02-21 Raja R Harinath <rharinath@novell.com>
15354 * namespace.cs (UsingEntry.Resolve): Undo change below.
15356 2005-02-21 Raja R Harinath <rharinath@novell.com>
15359 * ecore.cs (Expression.MemberLookupFailed): Add argument to
15360 disable the error message when the extended MemberLookup also
15362 (Expression.MemberLookupFinal): Update.
15363 (SimpleName.DoSimpleNameResolve): Update.
15364 * expression.cs (MemberAccess.ResolveNamespaceOrType):
15365 Don't use MemberLookupFinal.
15366 (New.DoResolve): Update.
15367 (BaseAccess.CommonResolve): Update.
15369 2005-02-21 Raja R Harinath <rharinath@novell.com>
15372 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
15373 occured previously, don't resolve again.
15375 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15378 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
15379 argument. Call ResolveAttributeUsage for unresolved.
15380 when types doesn't match ctor arguments.
15382 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
15383 for nested attribute classes.
15384 (Class.attribute_usage): Removed.
15385 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
15386 for attribute class.
15388 * ecore.cs (IsAttribute): Removed.
15390 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
15392 * rootcontext.cs (RegisterAttribute): Removed, attributes are
15394 (attribute_types): Removed.
15395 (EmitCode): Global attributes are emited as the latest.
15397 2005-02-18 Marek Safar <marek.safar@seznam.cz>
15399 * class.cs (EmitFieldInitializers): Don't emit field initializer
15400 for default values when optimilization is on.
15402 * constant.cs (Constant.IsDefaultValue): New property.
15404 * driver.cs: Add /optimize handling.
15408 * literal.cs: Implement new IsDefaultValue property.
15410 * rootcontext.cs (Optimize): New field, holds /optimize option.
15412 2005-02-18 Raja R Harinath <rharinath@novell.com>
15414 Fix crasher in re-opened #72347.
15415 * namespace.cs (Namespace.Lookup): Return null if
15416 DeclSpace.DefineType returns null.
15419 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
15421 2005-02-18 Raja R Harinath <rharinath@novell.com>
15423 Fix remainder of #63202. Change semantics of DoResolveLValue: it
15424 now returns null if it cannot resolve to an lvalue.
15425 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
15426 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
15427 returned null. Remove check for SimpleName.
15428 (EventExpr.DoResolveLValue): New.
15429 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
15430 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
15432 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
15433 avoid CS0131 error.
15434 (Unary.ResolveOperator): Move CS0211 check ...
15435 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
15437 (Unary.DoResolveLValue): Simplify.
15438 (AddressOf.DoResolveLValue): New.
15439 (ArrayAccess.DoResolveLValue): New.
15441 2005-02-16 Marek Safar <marek.safar@seznam.cz>
15443 * attribute.cs (Attribute.Resolve): Add arguments casting for
15444 when types doesn't match ctor arguments.
15446 2005-02-16 Raja R Harinath <rharinath@novell.com>
15448 Fix parts of #63202.
15449 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
15450 lookup of operator in base type. Ensure that all checks happen
15451 when the operator resolves to an "op_..." method.
15453 2005-02-15 Raja R Harinath <rharinath@novell.com>
15456 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
15457 'ignore_cs0104' parameter. Pass it to ...
15458 (NamespaceEntry.Lookup): ... this.
15459 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
15460 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
15461 (TypeLookupExpression.DoResolveAsTypeStep): Update.
15462 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
15463 Update. Request that cs0104 errors be ignored.
15464 (ComposedCast.ResolveAsTypeStep): Update.
15466 2005-02-14 Raja R Harinath <rharinath@novell.com>
15469 * expression.cs (Invocation.BetterFunction): Remove support for
15470 comparing virtual functions and their overrides.
15471 (Invocation.IsOverride): New.
15472 (Invocation.OverloadResolve): Don't consider 'override' functions
15473 during candidate selection. Store them in a lookaside list.
15474 If the selected method is a 'virtual' function, use the list to
15475 find any overrides that are closer to the LHS type.
15477 2005-02-14 Marek Safar <marek.safar@seznam.cz>
15479 * expression.cs (New.DoResolve): Add complex core type reduction.
15480 (New.Constantify): Converts complex core type syntax like 'new int ()'
15481 to simple constant.
15483 2005-02-14 Raja R Harinath <rharinath@novell.com>
15485 * decl.cs (EntryType.EntryType): New constructor to create an
15486 updated copy of a cache entry.
15487 (MemberCache.AddMethods): Use it.
15488 (MemberCache.ClearDeclaredOnly): Remove.
15489 (MemberCache.MemberCache): Update.
15491 2005-02-11 Miguel de Icaza <miguel@novell.com>
15493 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
15494 variable. This one is represents the actual low-level declaration
15495 of the method, as opposed to the semantic level `IsStatic'.
15497 An anonymous method which is hosted into a static method might be
15498 actually an instance method. IsStatic would reflect the
15499 container, while MethodIsStatic represents the actual code
15502 * expression.cs (ParameterReference): Use the new MethodIsStatic
15503 instead of IsStatic.
15505 * anonymous.cs (AnonymousMethod.Compatible): Pass the
15506 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
15507 set on the current EmitContext.
15509 * expression.cs (Cast): Overload DoResolveLValue so we can pass
15510 resolve our casted expression as an LValue. This triggers the
15511 proper LValue processing that is later required by Assign.
15515 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
15517 2005-02-11 Marek Safar <marek.safar@seznam.cz>
15519 C# 2.0 Fixed buffer implementation
15521 * anonymous.cs: Update after RegisterHelperClass renaming.
15523 * attribute.cs (AttributeTester.fixed_buffer_cache):
15524 Cache of external fixed buffers.
15525 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
15526 implementation if field is fixed buffer else null.
15529 (TypeContainer.AddField): Accept FieldMember instead of Field.
15530 (FieldBase.IsFieldClsCompliant): Extracted code from
15531 VerifyClsCompliance descendant customization.
15532 (FixedField): New class handles fixed buffer fields.
15533 (FixedFieldExternal): Keeps information about imported fixed
15535 (IFixedField): Make access to internal or external fixed buffer
15538 * cs-parser.jay: Add fixed buffer parsing.
15540 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15543 * expression.cs (Indirection): Extended implementation to accept
15544 fixed buffer field.
15545 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15546 (ElementAccess.MakePointerAccess): Get type as parameter.
15547 (DoResolve): Add fixed buffer field expression conversion.
15548 (DoResolveLValue): Ditto.
15549 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15550 (ArrayPtr): Derives from FixedBufferPtr.
15551 (ArrayPtr.Emit): Add extra emit for array elements.
15553 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15555 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15556 for compiler generated types.
15557 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15559 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15560 and consume less memory.
15561 (Fixed.Resolve): Add fixed buffer case.
15563 * typemanager.cs (compiler_generated_attr_ctor,
15564 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15565 (HasElementType): Add our own implementation to work on every
15568 2005-02-11 Miguel de Icaza <miguel@novell.com>
15570 * anonymous.cs (CaptureContext): Track whether `this' has been
15573 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15574 only captured `this' if it was implicitly done (instance
15575 methods/variables were used).
15577 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15578 `this' must be captured.
15580 2005-01-30 Miguel de Icaza <miguel@novell.com>
15582 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15583 is null it means that there has been no need to capture anything,
15584 so we just create a sibling.
15586 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15588 Just a partial fix. The other half is fairly elusive.
15590 2005-02-10 Raja R Harinath <rharinath@novell.com>
15592 Fix #52586, cs0121-4.cs.
15593 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15594 and return a hashtable.
15595 (MemberCache.ClearDeclaredOnly): New.
15596 (MemberCache.MemberCache): Update to change. Make a deep copy of
15597 the method_hash of a base type too.
15598 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15599 type methods. Overwrite entries with the same MethodHandle so
15600 that the ReflectedType is correct. The process leaves in base
15601 virtual functions and their overrides as distinct entries.
15602 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15603 matters since it was boxed in a ArrayList before.
15604 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15606 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15607 case of a virtual function and its override (choose the overload
15609 (Invocation.OverloadResolve): Avoid 'override' members during
15610 'applicable_type' calculation.
15612 2005-02-09 Raja R Harinath <rharinath@novell.com>
15614 Combine two near-redundant caches.
15615 * typemanager.cs (method_params): Rename from method_internal_params.
15616 (TypeManager.GetParameterData): New. Replace
15617 Invocation.GetParameterData.
15618 (TypeManager.LookupParametersByBuilder): Remove.
15619 * expression.cs (Invocation.method_parameter_cache): Remove.
15620 (Invocation.GetParameterData): Remove.
15622 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15625 2005-02-08 Raja R Harinath <rharinath@novell.com>
15628 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15629 TypeManager.multicast_delegate_type is null, resolve it by looking
15630 up "System.MulticastDelegate".
15631 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15633 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15634 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15635 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15638 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15639 (LabeledStatement.AddReference): New. Set 'referenced'.
15640 (Goto.Resolve): Use it.
15642 2005-02-05 John Luke <john.luke@gmail.com>
15644 * driver.cs: remove duplicate -doc line in Usage ()
15646 2005-02-04 Raja R Harinath <rharinath@novell.com>
15648 * location.cs (Location.AddFile): Fix CS2002 error report.
15650 2005-02-02 Martin Baulig <martin@ximian.com>
15652 * delegate.cs (Delegate.DefineType): Report an internal error if
15653 TypeManager.multicast_delegate_type is null. See bug #72015 for
15656 2005-02-02 Raja R Harinath <rharinath@novell.com>
15658 Fix a crasher in a variant of #31984.
15659 * const.cs (Constant.CheckBase): New override that defers the
15660 new-or-override check in case the base type hasn't been populated
15662 (Constant.Define): Ensure the new-or-override check is performed.
15664 2005-02-01 Duncan Mak <duncan@ximian.com>
15666 * const.cs (LookupConstantValue): Check that `ce' is not null
15667 before calling GetValue ().
15669 2005-02-01 Raja R Harinath <rharinath@novell.com>
15671 Fix test-334.cs (#69519).
15672 * cs-parser.jay (using_alias_directive): Pass in an expression to
15673 NamespaceEntry.UsingAlias.
15674 (using_namespace_directive): Pass in an expression to
15675 NamespaceEntry.Using.
15676 (namespace_name): Don't flatten to a string.
15677 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15678 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15680 (NamespaceEntry.UsingEntry): Likewise.
15681 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15683 (NamespaceEntry.LookupForUsing): Remove.
15684 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15686 (NamespaceEntry.Lookup): Remove support for dotted names.
15688 2005-02-01 Raja R Harinath <rharinath@novell.com>
15690 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15692 (NamespaceEntry.ImplicitParent): Compute on demand.
15693 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15694 parallels the current.
15695 (NamespaceEntry.LookupForUsing): Use it.
15696 (NamespaceEntry.Lookup): If the current namespace-entry is
15697 implicit, don't search aliases and using tables.
15699 2005-02-01 Raja R Harinath <rharinath@novell.com>
15702 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15704 (TypeContainer.BaseCache): Compute on demand.
15705 (TypeContainer.FindMembers): Define constants and types if they're
15706 not already created.
15707 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15709 * const.cs (Constant.Define): Make idempotent.
15711 2005-01-29 Miguel de Icaza <miguel@novell.com>
15713 * pending.cs: Produce better code (no nops produced by using Ldarg
15716 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15717 i - 1' it should be arg + 1.
15721 2005-01-28 Raja R Harinath <rharinath@novell.com>
15723 * attribute.cs (Attribute.CheckAttributeType): Make private
15725 (Attribute.ResolveType): Make virtual.
15726 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15727 handling of RootContext.Tree.Types.
15729 2005-01-27 Raja R Harinath <rharinath@novell.com>
15731 Update attribute-handling to use the SimpleName/MemberAccess
15733 * cs-parser.jay (attribute): Pass in an expression to the
15734 constructors of Attribute and GlobalAttribute.
15735 * attribute.cs (Attribute): Take an expression for the name.
15736 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15737 passed in attribute name expression.
15738 (Attribute.CheckAttributeType): Use it.
15739 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15740 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15741 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15742 argument to prevent error messages if the lookup fails.
15744 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15746 * expression.cs (Indirection): Implemented IVariable interface
15747 to support indirection in AddressOf operator.
15748 (PointerArithmetic.Emit): Add optimalization for case where
15749 result can be precomputed.
15751 2005-01-26 Martin Baulig <martin@ximian.com>
15753 * class.cs (TypeContainer.AttributeTargets): Return the correct
15754 AttributeTargets depending on our `Kind' instead of throwing an
15755 exception; fixes #71632.
15757 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15760 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15763 2005-01-25 Raja R Harinath <rharinath@novell.com>
15766 * expression.cs (MemberAccess.DoResolve): Don't complain with
15767 cs0572 when the LHS of a member access has identical name and type
15770 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15773 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15775 Create custom PermissionSet only for PermissionSetAttribute.
15777 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15780 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15781 delegates in static class.
15783 2005-01-24 Martin Baulig <martin@ximian.com>
15785 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15786 merging an implicit block, just use its reachability.
15788 * statement.cs (Block.Resolve): Make the unreachable code check
15789 work wrt. implicit blocks; see test-337 from #63842.
15791 2005-01-21 Alp Toker <alp@atoker.com>
15793 * cs-parser.jay: destructor_declaration's container is PartialContainer
15794 not Class when partial types are used, so use Kind prop instead of
15797 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15799 * cs-parser.jay: Improve error reporting when an interface
15800 declares new types.
15802 2005-01-20 Dick Porter <dick@ximian.com>
15804 * support.cs: SeekableStreamReader fix from Sandor Dobos
15805 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15806 chars are read. Fixes bug 70369.
15808 2005-01-20 Raja R Harinath <rharinath@novell.com>
15810 * cs-parser.jay (catch_clause): Simplify current_block handling
15813 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15815 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15816 code with ImplicitStandardConversion to handle the implicit
15817 conversion of method groups into valid delegate invocations.
15819 The problem is that in parameter handling we were using this code
15820 path. Fixes bug #64698
15822 2005-01-19 Raja R Harinath <rharinath@novell.com>
15824 * cs-parser.jay: Fix several infelicities.
15825 - Avoid assigning to the parser value stack. Code like
15826 '$3 = null' is unclean. Synthesize a value for the code block
15828 - Avoid using oob_stack for storing location information. Use ...
15829 (_mark_): ... this. New (empty) rule. Saves the current location
15831 (foreach_statement): Avoid using oob_stack for current_block
15832 handling. Use technique used in for_statement and
15833 using_statement. Synthesize a value for the code block to store
15834 additional intermediate information.
15836 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15838 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15839 of a different type is only allowed to private fields of a
15840 containing type, not on fields of a base class.
15842 See test-174.cs and error cs0122-9.cs
15844 2005-01-13 Raja R Harinath <rharinath@novell.com>
15846 Fix test-335.cs (bug #58126).
15847 * cs-parser.jay (argument): Split out non-expression parts of the
15848 rule into 'non_simple_argument'.
15849 (invocation_expression): Support parenthesized invocations with
15850 multiple arguments, and with single non-simple arguments.
15852 2005-01-13 Raja R Harinath <rharinath@novell.com>
15854 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15857 2005-01-12 Raja R Harinath <rharinath@novell.com>
15859 Fix cs0038-1.cs, cs1640-6.cs.
15860 * ecore.cs (Expression.Resolve): Remove special-case for
15861 SimpleName in error-handling.
15862 (Expression.almostMatchedMembers): Relax access permission to
15864 (Expression.MemberLookupFailed): Handle duplicates in
15865 almostMatchedMembers list.
15866 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15867 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15868 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15869 overload if the passed in MemberInfo is a MethodBase.
15871 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15874 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15875 for non-CAS & merge permission sets properly.
15877 2005-01-11 Raja R Harinath <rharinath@novell.com>
15879 Improve standard-compliance of simple name and member access
15880 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15881 * ecore.cs (FullNamedExpression): New abstract base class
15882 for Namespaces and TypeExpressions.
15883 (ResolveFlags.SimpleName): Remove.
15884 (SimpleName): Remove support for dotted names.
15885 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15886 DeclSpace.FindType and DeclSpace.LookupType.
15887 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15888 (Expression.ExprClassName): Make member function.
15889 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15890 a namespace. Remove creation of dotted "SimpleName"s.
15891 (MemberAccess.DoResolve): Likewise.
15892 * decl.cs (DeclSpace.Cache): Make private.
15893 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15894 (DeclSpace.FindType): Update.
15895 (DeclSpace.LookupType): Move here from RootContext. Return a
15896 FullNamedExpression.
15897 * namespace.cs (Namespace): Derive from FullNamedExpression
15898 so that it can be part of expression resolution.
15899 (Namespace.Lookup): Return an FullNamedExpression.
15900 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15902 * rootcontext.cs (NamespaceLookup): Remove.
15903 (LookupType): Move to DeclSpace.
15904 * attribute.cs (CheckAttributeType): Update.
15905 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15906 (FindDocumentedTypeNonArray): Likewise.
15908 2005-01-11 Raja R Harinath <rharinath@novell.com>
15910 Fix cs0509.cs, cs1632.cs.
15911 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15912 is the same as IsInterface.
15913 (TypeContainer.GetClassBases): Likewise.
15914 * statement.cs (LabeledStatement.ig): New field.
15915 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15917 (LabeledStatement.DoEmit): Check that the label was created with
15918 the same ILGenerator.
15920 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15923 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15924 accessors to its properties.
15926 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15927 from accessors to property.
15929 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15932 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15933 only for overrides.
15935 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15937 * attribute.cs: Check for null and empty strings.
15939 I have lost another battle to Paolo.
15941 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15944 * class.cs (PropertyMethod): Set Parent field in ctors.
15945 (SetMethod.InternalParameters): Add unsafe switch hack.
15946 Override MarkForDuplicationCheck where it is appropriate.
15948 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15949 It says whether container allows members with the same name.
15950 Base default is no.
15951 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15952 Removed is_method parameter.
15954 2005-01-06 Duncan Mak <duncan@ximian.com>
15956 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15957 because the previous change led to incorrect reporting of CS1032
15958 ("Cannot define/undefine preprocessor symbols after first token in
15959 file"). Instead of using `tokens_seen' as the only flag that
15960 triggers CS1040, introduce `comments_seen'. This new flag is used
15961 to signify having seen comments on the current line, so it is
15962 unset after a newline.
15964 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15966 * doc.cs : When searching for a type, find nested type too.
15967 This fixes bug #71040.
15969 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15972 - Warn missing member comment on those classes which also does not
15973 have doc comments. Fixed bug #71041.
15974 - Don't warn missing doc comment on default constructor.
15977 2005-01-06 Duncan Mak <duncan@ximian.com>
15979 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15980 comments, set `tokens_seen' to true. This allows us to detect
15981 misplaced preprocessor directives (i.e. not at the beginning of
15982 the a line, nor after whitespaces). In that case, report error
15983 CS1040. This fixes bug #56460.
15985 * cs-parser.jay (interface_member_declaration): Add checks for
15986 IsExplicitImpl, and report CS0541 error if an interface member is
15987 defined as an explicit interface declaration.
15989 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15992 * class.cs (PropertyMethod): Set Parent field in ctors.
15993 (SetMethod.InternalParameters): Add unsafe switch hack.
15995 * decl.cs (MemberCore.Parent): Cannot be readonly.
15997 2005-01-06 Raja R Harinath <rharinath@novell.com>
15999 * decl.cs (DeclSpace.ResolveType): Remove.
16000 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
16001 Merge in code from ...
16002 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
16003 * class.cs, enum.cs: Update to changes.
16005 2005-01-06 Miguel de Icaza <miguel@ximian.com>
16007 * anonymous.cs: Ensure that we init the scope of our parent if it
16008 has not been initialized yet.
16010 2004-12-30 Duncan Mak <duncan@ximian.com>
16012 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
16013 if field.FieldBuilder is null. Fixes #70758.
16015 * convert.cs: Fixed some typos and updated some of the comments.
16016 (ImplicitStandardConversionExists):
16017 (TryImplicitIntConversion): If `target_type' is an interface and
16018 the type of `ic' implements this interface, return true or a new
16019 BoxedCast instead of null. This fixes #70468.
16021 2004-12-29 Duncan Mak <duncan@ximian.com>
16023 * expression.cs (Argument.Emit): Check that Expr is
16024 IMemoryLocation before casting to it, and report CS1510 otherwise.
16028 2004-12-21 Ben Maurer <bmaurer@ximian.com>
16030 * statement.cs (Block.ThisVariable): remove the recursion here, to
16031 make the --profile more sane.
16033 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
16035 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
16036 assembly, by JB Evain.
16038 2004-12-17 Raja R Harinath <rharinath@novell.com>
16040 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
16041 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
16042 "parent" refers to enclosing type/class. "base" refers to superclass.
16044 2004-12-17 Raja R Harinath <rharinath@novell.com>
16046 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
16047 Ensure that we only have GlobalAttributes.
16048 * attribute.cs (Attribute.Emit): Make non-virtual.
16049 (GlobalAttribute.Emit): Remove.
16050 (Attribute.Resolve): Make virtual.
16051 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
16052 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
16053 the argument. Don't create one.
16054 (Attribute.GetObsoleteAttribute): Likewise.
16055 (Attribute.GetClsCompliantAttributeValue): Likewise.
16056 * class.cs, decl.cs: Update to changes.
16058 2004-12-17 Marek Safar <marek.safar@seznam.cz>
16060 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
16062 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
16064 * statement.cs (Foreach.Resolve): Add error 186 report.
16066 2004-12-16 Marek Safar <marek.safar@seznam.cz>
16068 * expression.cs (Conditional.DoResolve): Add warning 429.
16070 * statement.cs (If.Resolve): Add warning 665.
16072 2004-12-16 Raja R Harinath <rharinath@novell.com>
16074 New invariant: RootContext.Tree.Types.NamespaceEntry == null
16075 except when in the parser, and in GlobalAttribute.
16076 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
16077 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
16078 RootContext.Tree.Types.NamespaceEntry once work is done.
16079 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
16080 and resets RootContext.Tree.Types.NamespaceEntry.
16082 2004-12-15 Marek Safar <marek.safar@seznam.cz>
16084 * cs-parser.jay: Don't create a block for every variable.
16086 2004-12-14 Miguel de Icaza <miguel@ximian.com>
16088 * location.cs: Provide extra information.
16090 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
16091 variables from the captured environment, it is the ldarg_0.
16093 2004-12-14 Marek Safar <marek.safar@seznam.cz>
16095 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
16098 * class.cs: Changed warning level for 169 to avoid developer
16099 displeasure from warning flooding. It will be changed back when they
16100 fix most of current BCL warnings.
16102 * RootContext.cs: Pushed default WarningLevel to 3.
16104 * statement.cs: Removed unused variable.
16106 2004-12-14 Marek Safar <marek.safar@seznam.cz>
16108 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
16109 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
16110 Add error 502 report.
16111 (StaticClass.DefineType): Add error 441 report.
16112 (Class.AllowedModifiersProp): New virtual property as temporary
16113 extension to AllowedModifiers.
16114 (Class.DefineType): Add error 418 report. Moved ModFlags check here
16115 to share implementation with StaticClass and don't call virtual
16118 * driver.cs (MainDriver): Add error 1558 test.
16120 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
16121 report. Moved error 36 test here.
16123 * statement.cs (Throw.Resolve): Add error 724 report.
16125 * typemanager.cs: Add out_attribute_type core type.
16127 2004-12-13 Marek Safar <marek.safar@seznam.cz>
16129 * class.cs (TypeContainer.VerifyClsCompliance): Add error
16131 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
16133 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
16136 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
16138 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
16139 Add error 3023 report.
16140 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
16142 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
16145 2004-12-12 John Luke <john.luke@gmail.com>
16147 * driver.cs (AddArgs): take -- into account when
16148 adding arguments, fixes bug 65710
16150 2004-12-12 Martin Baulig <martin@ximian.com>
16152 * expression.cs (Unary.TryReduceNegative): Added support for
16153 SByteConstant and ByteConstant.
16154 (Unary.Reduce): Check error values from TryReduceNegative().
16156 2004-12-10 Marek Safar <marek.safar@seznam.cz>
16158 * attributes.cs (Attribute.Resolve): Avoid multiple error report
16159 and report exception as error 182.
16161 2004-12-10 Raja R Harinath <rharinath@novell.com>
16163 * driver.cs (Main): Fix message when there are warnings.
16165 2004-12-09 Miguel de Icaza <miguel@ximian.com>
16167 * delegate.cs: Fixed my fix from yesterday, sorry about that.
16169 2004-12-09 Marek Safar <marek.safar@seznam.cz>
16171 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
16172 Reduced number of warnings.
16174 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
16176 2004-12-08 Miguel de Icaza <miguel@ximian.com>
16178 * driver.cs: Removed message.
16180 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
16182 2004-12-08 <vargaz@freemail.hu>
16184 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
16186 2004-12-08 Martin Baulig <martin@ximian.com>
16188 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
16189 instead of a CS3002 for properties and indexer.
16191 2004-12-08 Martin Baulig <martin@ximian.com>
16193 * decl.cs (MemberName.ToString): Make this work again.
16195 2004-12-08 Marek Safar <marek.safar@seznam.cz>
16197 * attribute.cs (Resolve): Add error 591 detection.
16199 * class.cs (FieldMember.Define): Add error 1547 detection.
16200 (Indexer.Define): Add error 620 detection.
16201 (Operator.Define): Add error 590 detection.
16203 * ecore.cs: Missing argument for error 79.
16205 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
16208 2004-12-07 Marek Safar <marek.safar@seznam.cz>
16211 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
16214 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
16216 * cs-parser.jay : handle doc comments on implicit/explicit operators.
16217 Some operator comments were suppressed.
16218 * doc.cs : Implicit/explicit operator name in doc comments are like
16219 "op_Explicit(type)~returnType", so added suffix handling.
16221 2004-12-07 Martin Baulig <martin@ximian.com>
16224 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
16225 (MemberCore.GetClsCompliantAttributeValue): Likewise.
16226 (DeclSpace.ec): New protected field; store the EmitContext here.
16227 (DeclSpace.EmitContext): New public property; moved here from
16229 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
16232 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
16233 (Enum.Emit): Don't create a new EmitContext.
16235 * delegate.cs (Delegate.DefineType): Always create the
16238 * iterators.cs (Iterators.DefineIterator): Create a new
16239 EmitContext and store it in `ec'.
16241 2004-08-24 Martin Baulig <martin@ximian.com>
16244 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
16245 this for accessibility checks.
16246 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
16247 IsNestedFamilyAccessible.
16248 (TypeManager.IsSubclassOf): New method, do what the name actually
16251 2004-12-06 Raja R Harinath <rharinath@novell.com>
16253 Fix crash on cs0657-17.cs.
16254 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
16255 Use RootContext.Tree.Types, not 'new RootTypes ()'.
16256 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
16257 the case where the NamespaceEntry gets overwritten.
16259 2004-12-06 Marek Safar <marek.safar@seznam.cz>
16261 Fixed #69195, #56821
16262 * ecore.cs (ResolveBoolean): Tiny refactoring.
16264 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
16265 of right expression resolving when left is false constant and
16266 operator is LogicalAnd OR true constant and operator is LogicalOr.
16268 * statement.cs (ResolveUnreachable): Always reports warning.
16270 2004-12-05 Miguel de Icaza <miguel@ximian.com>
16272 * class.cs: Distinguish between 1721 and 1722 (just a little help
16273 for the programmer).
16275 2004-12-03 Miguel de Icaza <miguel@ximian.com>
16277 * delegate.cs: Only allow this on new versions of the language.
16279 2004-12-02 Duncan Mak <duncan@ximian.com>
16281 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
16283 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
16284 here as a static method. Take an additional bool out parameter
16285 `must_do_cs1540_check' for signaling to InstanceResolve.
16286 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
16287 member field from PropertyExpr class and made it an argument of
16288 the method instead.
16289 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
16290 check for MarshalByRefObject, and report CS0122 instead of CS1540.
16291 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
16292 and `remove_accessor' as well as InstanceResolve: report CS0122
16297 2004-12-03 Raja R Harinath <rharinath@novell.com>
16299 Fix test-327.cs, test-328.cs, and put in early infrastructure
16300 for eventually fixing #52697.
16301 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
16302 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
16303 from other methods.
16304 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
16305 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
16306 (VerifyUsing, error246): Update.
16307 * rootcontext.cs (RootContext.NamespaceLookup): Just use
16308 'NamespaceEntry.LookupNamespaceOrType'.
16310 2004-12-03 Martin Baulig <martin@ximian.com>
16312 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16313 method as our child, call AnonymousMethod.Compatible() on it.
16315 2004-12-03 Raja R Harinath <rharinath@novell.com>
16317 Disable XML documentation support in 'basic' profile.
16318 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
16319 Redirect XmlElement to System.Object.
16320 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
16321 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
16322 * mcs.exe.sources: Add doc-bootstrap.cs.
16323 * doc-bootstrap.cs: New file. Contains empty stub implementation
16326 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
16328 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
16329 comments are allowed.
16331 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16333 * delegate.cs: Add checks for subtypes in paramaters and return values
16334 in VerifyMethod () to add support for Covariance/Contravariance
16337 2004-12-02 Miguel de Icaza <miguel@ximian.com>
16339 * report.cs: Remove extra closing parenthesis.
16341 * convert.cs (Error_CannotImplicitConversion): If the name of the
16342 types are the same, provide some extra information.
16344 * class.cs (FieldBase): Use an unused bit field from the field to
16345 encode the `has_offset' property from the FieldMember. This saves
16346 a couple of Ks on bootstrap compilation.
16348 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16349 method as our child, return the AnonymousMethod resolved
16352 * expression.cs (New.DoResolve): Allow return values from
16353 NewDelegate to also include AnonymousMethods.
16357 2004-12-02 Marek Safar <marek.safar@seznam.cz>
16360 * attribute.cs (Resolve): Improved implementation of params
16361 attribute arguments.
16363 * support.cs (ParameterData): Add HasParams to be faster.
16365 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
16367 all things are for /doc support:
16369 * doc.cs: new file that supports XML documentation generation.
16370 * mcs.exe.sources: added doc.cs.
16372 Handle /doc command line option.
16373 Report error 2006 instead of 5 for missing file name for /doc.
16374 Generate XML documentation when required, after type resolution.
16376 Added support for picking up documentation (/// and /** ... */),
16377 including a new XmlCommentState enumeration.
16379 Added lines to fill Documentation element for field, constant,
16380 property, indexer, method, constructor, destructor, operator, event
16381 and class, struct, interface, delegate, enum.
16382 Added lines to warn incorrect comment.
16384 Added Documentation field (passed only when /doc was specified).
16386 Added DocComment, DocCommentHeader, GenerateDocComment() and
16387 OnGenerateDocComment() and some supporting private members for
16388 /doc feature to MemberCore.
16390 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
16392 Added overriden DocCommentHeader.
16394 Added overriden DocCommentHeader and GenerateDocComment().
16396 2004-12-01 Miguel de Icaza <miguel@ximian.com>
16398 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
16399 unwrapping the enumeration values, chain to
16400 DoConstantNumericPromotions again, so we can promote things to the
16401 fundamental types (takes care of enums that are bytes, sbytes).
16405 2004-12-01 Raja R Harinath <rharinath@novell.com>
16407 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
16408 Fix long-standing bug in type-lookup. Use FindType instead of
16409 LookupType when ec.ResolvingTypeTree.
16410 (Attribute.ResolveType, Attribute.Resolve)
16411 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
16413 (Attributes.Search): Remove internal version. Update.
16414 (Attributes.SearchMulti): Update.
16415 (Attributes.GetClsCompliantAttribute): Remove.
16416 (Attributes.GetIndexerNameAttribute): Remove.
16417 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
16418 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
16419 * class.cs (Indexer.Define): Likewise.
16421 2004-12-01 Marek Safar <marek.safar@seznam.cz>
16424 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
16425 MarshallByReference members access.
16427 * expression.cs: Use CheckMarshallByRefAccess;
16428 Better error CS0197 message.
16430 * report.cs: Print whole related error message.
16432 2004-11-30 Raja R Harinath <rharinath@novell.com>
16434 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
16435 the current directory to help debugging.
16437 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16439 * class (GetClassBases): Better error 60 report.
16440 (EventProperty): Disabled warning 67 detection.
16442 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16445 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
16447 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
16450 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16453 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
16455 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
16457 2004-11-26 Miguel de Icaza <miguel@ximian.com>
16459 * attribute.cs (Attribute.Resolve): Refine error reporting and
16460 report a cs0117 if the identifier does not exist, to distinguish
16461 from 0617 which is a miss-use of the actual identifier.
16463 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
16464 between cs0070 and cs0079.
16466 * class.cs (MemberBase.DoDefine): When reporting a wrong
16467 accessibility level, we use MethodCore to compare instead of
16468 Method (this was a regression in some refactoring effort).
16470 So now we correctly report cs0056 again.
16472 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
16473 testing the target_type (which was known to be object_type) and
16474 not the source type (which is anonymous_method).
16476 Fixed reporting of error cs1660.
16478 * expression.cs (UserCast.Source): Expose the underlying cast.
16480 * statement.cs (Switch.SwitchGoverningType): Sort the list of
16481 allowed types to find a match to int32 first (most common).
16483 In addition, it ignores any ImplicitUserConversions that did an
16484 internal implicit conversion (as the switch statement allows only
16485 one integral conversion to exist).
16487 * class.cs (PartialContainer.Create): rename `name' to
16488 `member_name' for clarity. Then replace the string calls with a
16489 call to MemberName.GetPartialName, as now using
16490 MemberName.ToString is an error (this is due to the side effects
16491 it had, that were fixed in the past).
16493 This will restore the error reporting on a number of partial class
16494 errors that were missusing this (and getting an exception as a
16495 results, which is now just a plain textual warning, because
16496 yyparse debug output would crash otherwise).
16498 2004-11-26 Raja R Harinath <rharinath@novell.com>
16500 * Makefile (PROGRAM_INSTALL_DIR): Remove.
16502 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16504 * rootcontext.cs (LookupType): Make sure to cache lookups that
16505 don't give us a negative result. This saves about 5% of corlib
16508 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16510 * report.cs (AbstractMessage.Print): messages are sent to stderr
16512 * class.cs (TypeContainer.GetClassBases): It is an error to have a
16513 non-interface in the list of interfaces (at this point, either
16514 parent was properly set, or a base class is being listed in the
16515 interfaces section).
16517 This flags error 1722, and resolves the crash from bug 69259.
16519 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16521 * statement.cs (Using.EmitExpressionFinally): make this work right
16522 for valuetypes. Fixes 69926.
16524 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16526 * const.cs (Const.ChangeType): Cope with the "0 literal can be
16527 converted to an enum" here, before we try to change the underlying
16528 type. This code exists, but it is a different code path than the
16529 one used while encoding constants.
16531 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
16532 old bug: when converting from the null literal to a pointer,
16533 return an EmptyCast, not the NullLiteral.
16535 This fixes #69921, the recent null_type changes probably made this
16536 bug more prominent.
16538 (ImplicitReferenceConversionExists): In addition, resynchronized
16539 the code here, so it matches the same code in
16540 ImplicitReferenceConversionExists for the `from any class-type S
16541 to any interface-type T'.
16544 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16546 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16548 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16550 * cs-parser.jay: Use verbosity accordingly.
16552 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16554 * expression.cs (Unary.ResolveOperator): Do not report warning;
16555 AddressOf reads from variable.
16557 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16559 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16563 * attribute.cs (Attributable): Removed CheckTargets.
16564 (Attributes.Emit): Explicit attribute targets are tested here.
16566 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16567 not enabled for interfaces.
16569 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16570 (GetAssemblyName): Ouch next bug there.
16572 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16574 * expression.cs: Error 275 added.
16576 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16578 Fix bug #69177 (Implemented decimal constant support)
16580 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16581 (BinaryFold): Add DecimalConstant.
16583 * const.cs (Define): Decimal constant
16585 (ChangeType): Add decimal type handling.
16586 (LookupConstantValue): Don't set value for decimal type but
16587 emit DecimalConstantAttribute. Needed for constant optimization.
16589 * constant.cs (ToDecimal): New method.
16590 (ConvertToDecimal): New method.
16591 (IntConstant): Implemented ConvertToDecimal.
16592 (DecimalConstant.Emit): Emit optimized version for decimals in
16595 * expression.cs (ResolveOperator): Changed order of constant
16596 reduction to work correctly with native types which have
16597 overloaded operators.
16598 (ResolveMemberAccess): Extract constant value from attribute
16601 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16603 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16604 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16605 (ChangeType): Decimal is special.
16606 (TypeToCoreType): Add decimal type.
16608 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16610 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16613 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16615 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16618 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16620 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16622 * pending.cs (PendingImplementation): Grab only interfaces.
16624 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16626 * statement.cs (ForeachHelperMethods): Add location member and
16627 error 202 detection.
16629 2004-11-19 Raja R Harinath <rharinath@novell.com>
16631 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16632 automatically handled by executable.make.
16633 (PROGRAM): Make profile-specific.
16635 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16637 * expression.cs (DoResolveBase): Fixed wrong warning for out
16640 2004-11-18 Martin Baulig <martin@ximian.com>
16642 Merged latest changes into gmcs. Please keep this comment in
16643 here, it makes it easier for me to see what changed in MCS since
16644 the last time I merged.
16646 2004-11-17 Raja R Harinath <rharinath@novell.com>
16648 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16649 (TypeHandle.GetMemberCache): New.
16650 (TypeHandle.TypeHandle): Update.
16651 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16652 (TypeManager.LookupParentInterfacesCache):
16653 Rename from LookupInterfaceCache. Optimize slightly.
16654 (TypeManager.MemberLookup_FindMembers): Update.
16655 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16656 multi-type variant.
16657 (AddCacheContents): Rename from AddHashtable.
16658 * class.cs (TypeContainer.parent_container): Remove.
16659 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16660 (TypeContainer.DoDefineMembers): Don't initialize it.
16661 Update to name changes.
16663 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16665 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16666 that factors the code to check access modifiers on override.
16668 (PropertyBase): Use the code here.
16670 Patch from Lluis S'anchez, fixes bug #69361.
16672 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16674 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16675 routine that is used to report the use of a captured variable
16676 whose address has been taken.
16678 There are two checks: one when variables are being captured and
16679 the other check is when the address of a variable is taken.
16681 (because an anonymous methods might be resolved before *or* after
16682 the address has been taken) and
16684 * expression.cs (Conditional.DoResolve): Remove the special
16685 casing that Martin added to trueExpr and falseExpr being both
16686 NullLiteral. We get the right behavior now just by introducing
16687 the null_type into the compiler.
16689 * convert.cs (ExplicitConversion): Change the code to use
16690 null_type instead of testing `expr is NullLiteral'.
16691 (ImplicitConversionStandard): use null_type too.
16692 (ImplicitReferenceConversionExists): use null_type too.
16693 (ImplicitReferenceConversion): use null_type too.
16695 * literal.cs: The type of `NullLiteral' is now null_type instead
16697 (Resolve): Set the type here.
16699 * typemanager.cs: Introduce null_type.
16701 2004-11-17 Martin Baulig <martin@ximian.com>
16703 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16704 direction, like FindMembers() does. Fixes #69546, testcase is in
16707 2004-11-16 Martin Baulig <martin@ximian.com>
16709 This is based on a patch from Marek Safar, see bug #69082.
16710 Fixes bugs #63705 and #67130.
16712 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16713 method; create a MemberCache for an interface type and cache the
16716 * decl.cs (IMemberContainer.ParentContainer): Removed.
16717 (IMemberContainer.ParentCache): New property.
16718 (MemberCache.SetupCacheForInterface): Removed.
16719 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16720 to create a cache for an interface's "parent".
16722 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16725 2004-11-16 Martin Baulig <martin@ximian.com>
16727 Merged back from gmcs; these changes already went into gmcs a
16728 couple of weeks ago.
16731 (TypeManager.AddUserType): Removed the `ifaces' argument.
16732 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16734 (TypeManager.AddUserInterface): Removed.
16735 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16737 (TypeManager.GetInterfaces): Likewise.
16738 (TypeManager.GetExplicitInterfaces): Likewise.
16740 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16742 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16743 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16745 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16747 * statement.cs: Avoid adding bools to a hashtable.
16749 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16751 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16752 calling an unsafe method from a safe location.
16754 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16757 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16759 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16761 * namespace.cs (VerifyUsing): use GetPartialName instead of
16764 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16766 * statement.cs (Return.Resolve): Fix regression in typo: if
16767 `in_exc', we have to request a NeedReturnLabel, this was a typo
16768 introduced in the anonymous method check-in. Fixes #69131.
16770 * Indexers were using the ShortName when defining themselves,
16771 causing a regression in the compiler bootstrap when applying the
16772 patch from 2004-11-02 (first part), now they use their full name
16773 and the bug is gone.
16775 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16777 * driver.cs: Strip the path from the names of embedded resources. Fixes
16780 2004-11-04 Raja R Harinath <rharinath@novell.com>
16782 Fix error message regression: cs0104-2.cs.
16783 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16784 (AliasEntry.Resolve): Update.
16785 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16787 (RootContext.LookupType): Update.
16789 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16791 * cs-parser.jay: Add support for handling accessor modifiers
16792 * class: Add support port accessor modifiers and error checking,
16793 define PropertyMethod.Define as virtual (not abstract anymore)
16794 * ecore.cs: Add checking for proeprties access with access modifiers
16795 * iterators.cs: Modify Accessor constructor call based in the modified
16797 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16799 * expression.cs (StringConcat): Handle being called twice,
16800 as when we have a concat in a field init with more than two
16803 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16805 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16806 special case explicit implementations, we should always produce
16807 the .property or .event declaration.
16809 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16810 since it will not return correct data if people use this
16811 unresolved in the presence of using statements (see test-313).
16813 * class.cs (MethodData.Define): If we are an explicit interface
16814 implementation, set the method name to the full name of the
16815 interface plus the name of the method.
16817 Notice that using the method.MethodName.GetFullName() does not
16818 work, as it will only contain the name as declared on the source
16819 file (it can be a shorthand in the presence of using statements)
16820 and not the fully qualifed type name, for example:
16824 class D : ICloneable {
16825 object ICloneable.Clone () {
16829 Would produce a method called `ICloneable.Clone' instead of
16830 `System.ICloneable.Clone'.
16832 * namespace.cs (Alias.Resolve): Use GetPartialName.
16834 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16836 * cs-parser.jay: Add error 1055 report.
16838 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16840 * assign.cs (Assign.DoResolve): Only do the transform of
16841 assignment into a New if the types are compatible, if not, fall
16842 through and let the implicit code deal with the errors and with
16843 the necessary conversions.
16845 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16847 * cs-parser.jay: Add error 1031 report.
16849 * cs-tokenizer.cs: Add location for error 1038.
16851 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16853 * cs-parser.jay: Add error 1016 report.
16855 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16857 * cs-parser.jay: Add errors 1575,1611 report.
16859 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16861 * cs-parser.jay: Add error 1001 report.
16863 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16866 * attribute.cs (GetMarshal): Add method argument for
16867 caller identification.
16869 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16870 agument for GetMarshal and RuntimeMissingSupport.
16872 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16874 * attribute.cs (ExtractSecurityPermissionSet): Removed
16875 TypeManager.code_access_permission_type.
16877 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16879 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16881 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16882 for obsolete use of a variable here. Fixes regression on errors
16883 cs0619-25 and cs0619-26.
16885 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16887 Fix #62358, implemented security attribute encoding.
16889 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16890 Tests permitted SecurityAction for assembly or other types.
16891 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16892 data from SecurityPermissionAttribute to PermisionSet class.
16894 * class.cs (ApplyAttributeBuilder): Added special handling
16895 for System.Security.Permissions.SecurityAttribute based types.
16897 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16898 special handling for System.Security.Permissions.SecurityAttribute
16901 * enum.cs (ApplyAttributeBuilder): Added special handling
16902 for System.Security.Permissions.SecurityAttribute based types.
16904 * parameter.cs (ApplyAttributeBuilder): Added special handling
16905 for System.Security.Permissions.SecurityAttribute based types.
16907 * rootcontext.cs: Next 2 core types.
16909 * typemanager.cs (TypeManager.security_permission_attr_type):
16910 Built in type for the SecurityPermission Attribute.
16911 (code_access_permission_type): Build in type.
16913 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16915 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16916 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16917 all of this information into
16918 EmitContext.EmitCapturedVariableInstance.
16920 * codegen.cs (EmitCapturedVariableInstance): move here the
16921 funcionality of emitting an ldarg.0 in the presence of a
16922 remapping. This centralizes the instance emit code.
16924 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16925 then emit a load of this: it means that we have reached the
16926 topmost ScopeInfo: the one that contains the pointer to the
16927 instance of the class hosting the anonymous method.
16929 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16930 captures to the topmost CaptureContext.
16932 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16934 * expression.cs (LocalVariableReference): Move the knowledge about
16935 the iterators into codegen's EmitCapturedVariableInstance.
16937 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16939 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16940 all code paths return a value from an anonymous method (it is the
16941 same as the 161 error, but for anonymous methods).
16943 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16945 The introduction of anonymous methods in the compiler changed
16946 various ways of doing things in the compiler. The most
16947 significant one is the hard split between the resolution phase
16948 and the emission phases of the compiler.
16950 For instance, routines that referenced local variables no
16951 longer can safely create temporary variables during the
16952 resolution phase: they must do so from the emission phase,
16953 since the variable might have been "captured", hence access to
16954 it can not be done with the local-variable operations from the runtime.
16958 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16959 is a toplevel block.
16961 (ToplevelBlock): A new kind of Block, these are the blocks that
16962 are created by the parser for all toplevel method bodies. These
16963 include methods, accessors and anonymous methods.
16965 These contain some extra information not found in regular blocks:
16966 A pointer to an optional CaptureContext (for tracking captured
16967 local variables and parameters). A pointer to the parent
16970 (Return.Resolve): Catch missmatches when returning a value from an
16971 anonymous method (error 1662).
16972 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16975 (Break.Resolve): ditto.
16977 (SwitchLabel): instead of defining the labels during the
16978 resolution phase, we now turned the public ILLabel and ILLabelCode
16979 labels into methods called GetILLabelCode() and GetILLabel() that
16980 only define the label during the Emit phase.
16982 (GotoCase): Track the SwitchLabel instead of the computed label
16983 (its contained therein). Emit the code by using
16984 SwitchLabel.GetILLabelCode ().
16986 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16987 whether the Local has been captured or not.
16989 (LocalInfo.IsCaptured): New property, used to tell whether the
16990 local has been captured.
16992 * anonymous.cs: Vastly updated to contain the anonymous method
16995 The main classes here are: CaptureContext which tracks any
16996 captured information for a toplevel block and ScopeInfo used to
16997 track the activation frames for various local variables.
16999 Each toplevel block has an optional capture context associated
17000 with it. When a method contains an anonymous method both the
17001 toplevel method and the anonymous method will create a capture
17002 context. When variables or parameters are captured, they are
17003 recorded on the CaptureContext that owns them, for example:
17007 MyDelegate d = delegate {
17012 Here `a' will be recorded as captured on the toplevel
17013 CapturedContext, the inner captured context will not have anything
17014 (it will only have data if local variables or parameters from it
17015 are captured in a nested anonymous method.
17017 The ScopeInfo is used to track the activation frames for local
17018 variables, for example:
17020 for (int i = 0; i < 10; i++)
17021 for (int j = 0; j < 10; j++){
17022 MyDelegate d = delegate {
17027 At runtime this captures a single captured variable `i', but it
17028 captures 10 different versions of the variable `j'. The variable
17029 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
17030 recorded on a child.
17032 The toplevel ScopeInfo will also track information like the `this'
17033 pointer if instance variables were referenced (this is necessary
17034 as the anonymous method lives inside a nested class in the host
17035 type of the method).
17037 (AnonymousMethod): Expanded to track the Toplevel, implement
17038 `AnonymousMethod.Compatible' to tell whether an anonymous method
17039 can be converted to a target delegate type.
17041 The routine now also produces the anonymous method content
17043 (AnonymousDelegate): A helper class that derives from
17044 DelegateCreation, this is used to generate the code necessary to
17045 produce the delegate for the anonymous method that was created.
17047 * assign.cs: API adjustments for new changes in
17048 Convert.ImplicitStandardConversionExists.
17050 * class.cs: Adjustments to cope with the fact that now toplevel
17051 blocks are of type `ToplevelBlock'.
17053 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
17054 insteda of standard blocks.
17056 Flag errors if params arguments are passed to anonymous methods.
17058 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
17059 `CurrentAnonymousMethod' which points to the current Anonymous
17060 Method. The variable points to the AnonymousMethod class that
17061 holds the code being compiled. It is set in the new EmitContext
17062 created for the anonymous method.
17064 (EmitContext.Phase): Introduce a variable and an enumeration to
17065 assist in enforcing some rules about when and where we are allowed
17066 to invoke certain methods (EmitContext.NeedsReturnLabel is the
17067 only one that enfonces this right now).
17069 (EmitContext.HaveCaptureInfo): new helper method that returns
17070 whether we have a CapturedContext initialized.
17072 (EmitContext.CaptureVariable): New method used to register that a
17073 LocalInfo must be flagged for capturing.
17075 (EmitContext.CapturedParameter): New method used to register that a
17076 parameters must be flagged for capturing.
17078 (EmitContext.CapturedField): New method used to register that a
17079 field must be flagged for capturing.
17081 (EmitContext.HaveCapturedVariables,
17082 EmitContext.HaveCapturedFields): Return whether there are captured
17083 variables or fields.
17085 (EmitContext.EmitMethodHostInstance): This is used to emit the
17086 instance for the anonymous method. The instance might be null
17087 (static methods), this (for anonymous methods that capture nothing
17088 and happen to live side-by-side with the current method body) or a
17089 more complicated expression if the method has a CaptureContext.
17091 (EmitContext.EmitTopBlock): Routine that drives the emission of
17092 code: it will first resolve the top block, then emit any metadata
17093 and then emit the code. The split is done so that we can extract
17094 any anonymous methods and flag any captured variables/parameters.
17096 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
17097 during this phase, the ILGenerator should not be used as labels
17098 and local variables declared here might not be accessible to any
17099 code that is part of an anonymous method.
17101 Exceptions to this include the temporary variables that are
17102 created by some statements internally for holding temporary
17105 (EmitContext.EmitMeta): New routine, in charge of emitting all the
17108 (EmitContext.TemporaryReturn): This method is typically called
17109 from the Emit phase, and its the only place where we allow the
17110 ReturnLabel to be defined other than the EmitMeta. The reason is
17111 that otherwise we would have to duplicate a lot of logic in the
17112 Resolve phases of various methods that today is on the Emit
17115 (EmitContext.NeedReturnLabel): This no longer creates the label,
17116 as the ILGenerator is not valid during the resolve phase.
17118 (EmitContext.EmitThis): Extended the knowledge in this class to
17119 work in anonymous methods in addition to iterators.
17121 (EmitContext.EmitCapturedVariableInstance): This emits whatever
17122 code is necessary on the stack to access the instance to a local
17123 variable (the variable will be accessed as a field).
17125 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
17126 EmitContext.EmitAddressOfParameter): Routines to support
17127 parameters (not completed at this point).
17129 Removals: Removed RemapLocal and RemapLocalLValue. We probably
17130 will also remove the parameters.
17132 * convert.cs (Convert): Define a `ConstantEC' which points to a
17133 null. This is just to prefity some code that uses
17134 ImplicitStandardConversion code and do not have an EmitContext
17137 The idea is to flag explicitly that at that point in time, it is
17138 known that the conversion will not trigger the delegate checking
17139 code in implicit conversions (which requires a valid
17142 Everywhere: pass new EmitContext parameter since
17143 ImplicitStandardConversionExists now requires it to check for
17144 anonymous method conversions.
17146 (Convert.ImplicitStandardConversionExists): If the type of an
17147 expression is the anonymous_method_type, and the type is a
17148 delegate, we invoke the AnonymousMethod.Compatible method to check
17149 whether an implicit conversion is possible.
17151 (Convert.ImplicitConversionStandard): Only do implicit method
17152 group conversions if the language level is not ISO_1.
17154 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
17155 MethodInfo for the Invoke method. used by Delegate and
17158 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
17159 method conversions if the target type is a delegate.
17161 Removed extra debugging nops.
17163 (LocalVariableReference): Turn the `local_info' into a public
17166 Add `prepared' field, the same hack used for FieldExprs to cope
17167 with composed assignments, as Local variables do not necessarily
17168 operate purely on the stack as they used to: they can be captured
17171 Add `temp' for a temporary result, like fields.
17173 Refactor DoResolve and DoResolveLValue into DoResolveBase.
17175 It now copes with Local variables that are captured and emits the
17176 proper instance variable to load it from a field in the captured
17179 (ParameterReference.DoResolveBase): During the resolve phase,
17180 capture parameters if we are in an anonymous method.
17182 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
17183 anonymous method, use the EmitContext helper routines to emit the
17184 parameter reference.
17186 * iterators.cs: Set RemapToProxy to true/false during the
17189 * parameters.cs (GetParameterByName): New helper method.
17191 * typemanager.cs (anonymous_method_type) a new type that
17192 represents an anonyous method. This is always an internal type,
17193 used as a fencepost to test against the anonymous-methodness of an
17196 2004-10-20 Marek Safar <marek.safar@seznam.cz>
17198 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
17200 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
17202 2004-10-18 Martin Baulig <martin@ximian.com>
17204 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
17205 `Type' directly, but call ResolveType() on it.
17206 (Catch.Resolve): Likewise.
17207 (Foreach.Resolve): Likewise.
17209 2004-10-18 Martin Baulig <martin@ximian.com>
17211 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
17212 `Type' directly, but call ResolveType() on it.
17213 (Probe.DoResolve): Likewise.
17214 (ArrayCreation.LookupType): Likewise.
17215 (TypeOf.DoResolve): Likewise.
17216 (SizeOf.DoResolve): Likewise.
17218 2004-10-18 Martin Baulig <martin@ximian.com>
17220 * expression.cs (Invocation.BetterFunction): Put back
17221 TypeManager.TypeToCoreType().
17223 2004-10-18 Raja R Harinath <rharinath@novell.com>
17225 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
17228 2004-10-18 Martin Baulig <martin@ximian.com>
17230 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
17231 `Type' directly, but call ResolveType() on it.
17233 2004-10-18 Martin Baulig <martin@ximian.com>
17235 * class.cs (FieldMember.Define): Don't access the TypeExpr's
17236 `Type' directly, but call ResolveType() on it.
17237 (MemberBase.DoDefine): Likewise.
17239 * expression.cs (New.DoResolve): Don't access the TypeExpr's
17240 `Type' directly, but call ResolveType() on it.
17241 (ComposedCast.DoResolveAsTypeStep): Likewise.
17243 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
17244 `Type' directly, but call ResolveType() on it.
17246 2004-10-17 John Luke <john.luke@gmail.com>
17248 * class.cs (Operator.GetSignatureForError): use CSharpName
17250 * parameter.cs (Parameter.GetSignatureForError): Returns
17251 correct name even if was not defined.
17253 2004-10-13 Raja R Harinath <rharinath@novell.com>
17256 * class.cs (TypeContainer.EmitContext): New property.
17257 (DefineNestedTypes): Create an emitcontext for each part.
17258 (MethodCore.DoDefineParameters): Use container's emitcontext.
17259 Pass type array to InternalParameters.
17260 (MemberBase.DoDefine): Use container's emitcontext.
17261 (FieldMember.Define): Likewise.
17262 (Event.Define): Likewise.
17263 (SetMethod.GetParameterInfo): Change argument to EmitContext.
17264 Pass type array to InternalParameters.
17265 (SetIndexerMethod.GetParameterInfo): Likewise.
17266 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
17267 * delegate.cs (Define): Pass emitcontext to
17268 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
17269 array to InternalParameters.
17270 * expression.cs (ParameterReference.DoResolveBase): Pass
17271 emitcontext to GetParameterInfo.
17272 (ComposedCast.DoResolveAsTypeStep): Remove check on
17273 ec.ResolvingTypeTree.
17274 * parameter.cs (Parameter.Resolve): Change argument to
17275 EmitContext. Use ResolveAsTypeTerminal.
17276 (Parameter.GetSignature): Change argument to EmitContext.
17277 (Parameters.ComputeSignature): Likewise.
17278 (Parameters.ComputeParameterTypes): Likewise.
17279 (Parameters.GetParameterInfo): Likewise.
17280 (Parameters.ComputeAndDefineParameterTypes): Likewise.
17281 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
17282 * support.cs (InternalParameters..ctor): Remove variant that takes
17284 * typemanager.cs (system_intptr_expr): New.
17285 (InitExpressionTypes): Initialize it.
17287 2004-10-12 Chris Toshok <toshok@ximian.com>
17289 * cs-parser.jay: fix location for try_statement and catch_clause.
17291 2004-10-11 Martin Baulig <martin@ximian.com>
17293 * report.cs: Don't make --fatal abort on warnings, we have
17294 -warnaserror for that.
17296 2004-10-07 Raja R Harinath <rharinath@novell.com>
17298 More DeclSpace.ResolveType avoidance.
17299 * decl.cs (MemberCore.InUnsafe): New property.
17300 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
17301 with newly created EmitContext.
17302 (FieldMember.Define): Likewise.
17303 * delegate.cs (Delegate.Define): Likewise.
17304 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
17305 only if normal name-lookup fails.
17306 (TypeExpr.DoResolve): Enable error-checking.
17307 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
17308 (SizeOf.DoResolve): Likewise.
17309 (ComposedCast.DoResolveAsTypeStep): Likewise.
17310 (StackAlloc.DoResolve): Likewise.
17311 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
17312 (Block.Unsafe): New property.
17313 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
17314 (Unsafe): Set 'unsafe' flag of contained block.
17315 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
17316 (Fixed.Resolve): Likewise.
17317 (Catch.Resolve): Likewise.
17318 (Using.ResolveLocalVariableDecls): Likewise.
17319 (Foreach.Resolve): Likewise.
17321 2004-10-05 John Luke <john.luke@gmail.com>
17323 * cs-parser.jay: add location to error CS0175
17325 2004-10-04 Miguel de Icaza <miguel@ximian.com>
17327 * ecore.cs (Expression.Constantity): Add support for turning null
17330 * const.cs (Const.Define): Allow constants to be reference types
17331 as long as the value is Null.
17333 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
17335 * namespace.cs (NamespaceEntry.Using): No matter which warning
17336 level is set, check if this namespace name has already been added.
17338 2004-10-03 Ben Maurer <bmaurer@ximian.com>
17340 * expression.cs: reftype [!=]= null should always use br[true,false].
17343 2004-10-03 Marek Safar <marek.safar@seznam.cz>
17346 * attribute.cs: Enum conversion moved to
17347 GetAttributeArgumentExpression to be applied to the all
17350 2004-10-01 Raja R Harinath <rharinath@novell.com>
17352 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
17353 * class.c (TypeContainer.DefineType): Flag error if
17354 base types aren't accessible due to access permissions.
17355 * decl.cs (DeclSpace.ResolveType): Move logic to
17356 Expression.ResolveAsTypeTerminal.
17357 (DeclSpace.ResolveTypeExpr): Thin layer over
17358 Expression.ResolveAsTypeTerminal.
17359 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
17360 Refactor code into NestedAccess. Use it.
17361 (DeclSpace.NestedAccess): New.
17362 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
17363 argument to silence errors. Check access permissions.
17364 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
17365 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
17366 (Cast.DoResolve): Likewise.
17367 (New.DoResolve): Likewise.
17368 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
17369 (TypeOf.DoResolve): Likewise.
17371 * expression.cs (Invocation.BetterConversion): Return the Type of
17372 the better conversion. Implement section 14.4.2.3 more faithfully.
17373 (Invocation.BetterFunction): Make boolean. Make correspondence to
17374 section 14.4.2.2 explicit.
17375 (Invocation.OverloadResolve): Update.
17376 (Invocation): Remove is_base field.
17377 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
17378 (Invocation.Emit): Likewise.
17380 2004-09-27 Raja R Harinath <rharinath@novell.com>
17382 * README: Update to changes.
17384 2004-09-24 Marek Safar <marek.safar@seznam.cz>
17386 * cs-parser.jay: Reverted 642 warning fix.
17388 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17391 * decl.cs (FindMemberWithSameName): Indexer can have more than
17394 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17396 * expression.cs (LocalVariableReference.DoResolveLValue):
17397 Do not report warning 219 for out values.
17398 (EmptyExpression.Null): New member to avoid extra allocations.
17400 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17402 * cs-parser.jay: Fix wrong warning 642 report.
17404 * cs-tokenizer.cs (CheckNextToken): New helper;
17405 Inspect next character if is same as expected.
17407 2004-09-23 Martin Baulig <martin@ximian.com>
17409 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
17410 (Convert.ImplicitReferenceConversionExists): Likewise.
17412 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17414 * class.cs (Operator.Define): Add error 448 and 559 report.
17416 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17418 * class.cs (MemberBase.IsTypePermitted): New protected
17419 method for checking error CS0610.
17421 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17423 * class.cs (TypeContainer.HasExplicitLayout): New property
17424 Returns whether container has StructLayout attribute set Explicit.
17425 (FieldMember): New abstract class for consts and fields.
17426 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
17427 (Field): Reuse FieldMember.
17429 * const.cs (Const): Reuse FieldMember.
17431 * rootcontext.cs: EmitConstants call moved to class.
17433 2004-09-22 Martin Baulig <martin@ximian.com>
17435 Thanks to Peter Sestoft for this bug report.
17437 * expression.cs (Conditional): If both the `trueExpr' and the
17438 `falseExpr' is a NullLiteral, return a NullLiteral.
17440 2004-09-22 Martin Baulig <martin@ximian.com>
17442 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
17443 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
17444 for the "get_Current" call.
17446 2004-09-22 Martin Baulig <martin@ximian.com>
17448 Marek and me just fixed one of our oldest bugs: #28562 :-)
17450 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
17452 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
17453 we're an EnumConstant, just return that.
17454 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
17455 an EnumConstant. In this case, we need to use GetValueAsEnumType()
17456 to get the value which'll actually be written into the attribute.
17457 However, we have to use GetValue() to access the attribute's value
17460 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17462 * constant.cs (Constant.IsNegative): New abstract property
17465 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
17466 (StackAlloc.DoResolve): Reused IsNegative.
17468 2004-09-21 Martin Baulig <martin@ximian.com>
17470 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
17471 if we're used in an iterator, we may be called from different
17474 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
17475 we actually have an exception block.
17477 2004-09-20 John Luke <jluke@cfl.rr.com>
17479 * class.cs, cs-parser.jay: Improve the error report for 1520:
17480 report the actual line where the error happens, not where the
17481 class was declared.
17483 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
17484 Pass location information that was available elsewhere.
17486 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
17488 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
17489 runtime to delay sign assemblies.
17491 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17493 * cs-parser.jay: Do not report the stack trace, this is barely
17496 2004-08-22 John Luke <john.luke@gmail.com>
17498 * driver.cs : check that a resource id is not already used
17499 before adding it, report CS1508 if it is, bug #63637
17501 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17503 * ecore.cs: Removed dead code.
17505 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17507 * class.cs: Do not report warning CS0067 on the interfaces.
17509 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17511 * cs-parser.jay: Add error 504 report.
17513 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17515 * rootcontext.cs: WarningLevel is 4 by default now.
17517 * statement.cs (Fixed.Resolve): Do not null
17520 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17523 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
17524 deep search when property is not virtual.
17525 (PropertyExpr.ResolveAccessors): Make one call for both
17528 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17531 * statement.cs: Error 152 report constains also location.
17533 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17536 * const.cs: Explicitly set constant as static.
17538 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17541 * cs-parser.jay: Add error 1017 report.
17543 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17545 Fixed bug #59980, #64224
17546 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17548 * typemanager.cs (IsSpecialMethod): Simplified
17550 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17552 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17553 condition with better params.
17555 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17558 * attribute.cs (Resolve): Property has to have both
17561 2004-09-14 Martin Baulig <martin@ximian.com>
17563 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17565 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17568 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17569 called and is obsolete then this member suppress message
17570 when call is inside next [Obsolete] method or type.
17572 * expression.cs: Use TestObsoleteMethodUsage member.
17574 2004-09-14 Martin Baulig <martin@ximian.com>
17576 * cs-parser.jay: Sync a bit with the GMCS version.
17578 2004-09-14 Martin Baulig <martin@ximian.com>
17580 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17581 (CSharpParser.yacc_verbose_flag): New public field.
17583 * genericparser.cs: Removed.
17585 2004-09-14 Raja R Harinath <rharinath@novell.com>
17587 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17589 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17591 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17593 2004-09-10 Martin Baulig <martin@ximian.com>
17595 Backported my MemberName changes from GMCS into MCS.
17597 - we are now using a special `MemberName' class instead of using
17598 strings; in GMCS, the `MemberName' also contains the type
17601 - changed the grammar rules a bit:
17602 * the old `member_name' is now a `namespace_or_type_name':
17603 The rule is that we use `namespace_or_type_name' everywhere
17604 where we expect either a "member name" (GetEnumerator) or a
17605 "member name" with an explicit interface name
17606 (IEnumerable.GetEnumerator).
17607 In GMCS, the explicit interface name may include type arguments
17608 (IEnumerable<T>.GetEnumerator).
17609 * we use `member_name' instead of just `IDENTIFIER' for
17611 The rule is that we use `member_name' wherever a member may
17612 have type parameters in GMCS.
17614 * decl.cs (MemberName): New public class.
17615 (MemberCore.MemberName): New public readonly field.
17616 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17617 (DeclSpace): Likewise.
17619 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17620 * enum.cs (Enum.ctor): Likewise.
17622 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17624 (AliasEntry.ctor): Take a MemberName, not an Expression.
17625 (AliasEntry.UsingAlias): Likewise.
17627 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17628 (IMethodData.MemberName): Changed type from string to MemberName.
17629 (MemberBase.ExplicitInterfaceName): Likewise.
17630 (AbstractPropertyEventMethod.SetupName): Make this private.
17631 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17632 argument; compute the member name here.
17633 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17634 on the `member.MemberName' and the `prefix'.
17636 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17638 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17639 thus, we get a `MemberName' instead of a `string'. These
17640 declarations may have type parameters in GMCS.
17641 (interface_method_declaration, delegate_declaration): Likewise.
17642 (class_declaration, interface_declaration): Likewise.
17643 (method_header): Use `namespace_or_type_name' instead of
17644 `member_name'. We may be an explicit interface implementation.
17645 (property_declaration, event_declaration): Likewise.
17646 (member_name): This is now just an `IDENTIFIER', not a
17647 `namespace_or_type_name'.
17648 (type_name, interface_type): Removed.
17649 (namespace_or_type_name): Return a MemberName, not an Expression.
17650 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17651 call GetTypeExpression() on the MemberName to get an expression.
17652 (IndexerDeclaration.interface_type): Changed type from string to
17654 (MakeName): Operate on MemberName's instead of string's.
17656 2004-09-13 Raja R Harinath <rharinath@novell.com>
17659 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17660 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17661 lookup to avoid symbols introduced by 'using'.
17662 * rootcontext.cs (NamespaceLookup): Update.
17664 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17666 * class.cs (TypeContainer.DoDefineMembers): Do not call
17667 DefineDefaultConstructor for static classes.
17669 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17671 * attribute.cs (Attribute.Resolve): Add error 653 report.
17673 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17675 (Method.ApplyAttributeBuilder): Add error 685 report.
17676 (Operator.Define): Add error 564 report.
17678 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17680 * expression.cs (Invocation.DoResolve): Add error
17681 245 and 250 report.
17683 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17686 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17688 * class.cs (ConstructorInitializer.Resolve):
17689 Wrong error number (515->516).
17691 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17693 * class.cs (Indexer.Define): Add error 631 report.
17695 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17697 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17699 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17701 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17703 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17705 * cs-parser.jay: Added error CS0241 report.
17707 2004-09-10 Raja R Harinath <rharinath@novell.com>
17709 * cs-parser.jay (fixed_statement): Introduce a scope for the
17710 declaration in the 'fixed' statement.
17712 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17714 * cs-parser.jay: Added CS0230 error report.
17716 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17718 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17720 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17722 * expression.cs (Argument.Resolve): Added error CS0192 and
17725 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17727 C# 2.0 #pragma warning feature
17729 * cs-tokenizer.cs (PreProcessPragma): New method;
17730 Handles #pragma directive.
17732 * report.cs (WarningRegions): New class; Support
17733 class for #pragma warning directive. It tests whether
17734 warning is enabled for a given line.
17736 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17738 * const.cs: Add more descriptive error report, tahnks to
17741 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17743 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17745 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17747 * expression.cs: Apply patch from Ben: Remove dead code from
17748 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17749 as that code just threw an exception anwyays.
17751 * const.cs: Remove the call to the turnintoconstant, for details
17754 * literal.cs: The type of the null-literal is the null type; So
17755 we use a placeholder type (literal.cs:System.Null, defined here)
17758 * expression.cs (Conditional.DoResolve): Remove some old code that
17759 is no longer needed, conversions have been fixed.
17761 (ArrayCreationExpression.DoResolve): Return false if we fail to
17762 resolve the inner expression.
17764 2004-09-07 Raja R Harinath <rharinath@novell.com>
17767 * cs-parser.jay (delegate_declaration): Record a delegate
17768 declaration as a type declaration.
17769 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17771 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17773 * parameter.cs: Do not crash if the type can not be resolved.
17775 * expression.cs: Report errors with unsafe pointers, fixes #64896
17777 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17779 * expression.cs: Pointer arith always needs to do a conv.i
17780 if the operand is a long. fix 65320
17782 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17784 Fixed cs0619-37.cs, cs0619-38.cs
17786 * enum.cs (GetObsoleteAttribute): Removed.
17788 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17789 on Enum member is double staged. The first is tested member
17792 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17794 Fixed #56986, #63631, #65231
17796 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17797 adds member to name container.
17798 (TypeContainer.AddToTypeContainer): New method, adds type to
17800 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17801 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17802 AddOperator): Simplified by reusing AddToMemberContainer.
17803 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17805 (Method.CheckForDuplications): Fixed implementation to test all
17807 (MemberBase): Detection whether member is explicit interface
17808 implementation is now in constructor.
17809 (MemberBase.UpdateMemberName): Handles IndexerName.
17810 (Accessor): Changed to keep also location information.
17811 (AbstractPropertyEventMethod): Is derived from MemberCore.
17812 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17813 will be emited or not.
17814 (PropertyBase.AreAccessorsDuplicateImplementation):
17815 Tests whether accessors are not in collision with some method.
17816 (Operator): Is derived from MethodCore to simplify common
17819 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17821 (DeclSpace.AddToContainer): Adds the member to defined_names
17822 table. It tests for duplications and enclosing name conflicts.
17824 * enum.cs (EnumMember): Clean up to reuse the base structures
17826 2004-09-03 Martin Baulig <martin@ximian.com>
17828 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17829 into TypeContainer, to make partial classes work again.
17831 2004-09-03 Martin Baulig <martin@ximian.com>
17833 * rootcontext.cs (RootContext.V2): Removed.
17835 2004-03-23 Martin Baulig <martin@ximian.com>
17837 * expression.cs (Invocation.OverloadResolve): Added `bool
17838 may_fail' argument and use it instead of the Location.IsNull() hack.
17840 2004-09-03 Martin Baulig <martin@ximian.com>
17842 Merged latest changes into gmcs. Please keep this comment in
17843 here, it makes it easier for me to see what changed in MCS since
17844 the last time I merged.
17846 2004-09-03 Raja R Harinath <rharinath@novell.com>
17849 * expression.cs (BetterConversion): Don't allow either conversion
17850 to be null. Remove redundant implicit conversion test when 'q ==
17851 null' -- when this function is invoked, we already know that the
17852 implicit conversion exists.
17853 (BetterFunction): Assume that 'best' is non-null. Remove
17854 redundant reimplementation of IsApplicable when 'best' is null.
17855 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17856 number of arguments.
17857 (IsAncestralType): Extract from OverloadResolve.
17858 (OverloadResolve): Make robust to the MethodGroupExpr being
17859 unsorted. Implement all the logic of Section 14.5.5.1, and
17860 support overloading of methods from multiple applicable types.
17861 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17863 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17864 (RealError, Warning): Append type of report to related symbol.
17866 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17868 * enum.cs: Fixed CLS-Compliance checks for enum members.
17869 Error tests cs3008-8.cs, cs3014-8.cs
17871 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17873 Fixed bug #62342, #63102
17874 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17875 like ImplementMethod.
17877 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17879 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17882 2004-09-02 Martin Baulig <martin@ximian.com>
17884 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17885 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17888 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17890 C# 2.0 Static classes implemented
17892 * class.cs (TypeContainer): instance_constructors,
17893 initialized_fields, initialized_static_fields,
17894 default_constructor, base_inteface_types are protected to be
17895 accessible from StaticClass.
17896 (TypeContainer.DefineDefaultConstructor): New virtual method
17897 for custom default constructor generating
17898 (StaticClass): New class to handle "Static classes" feature.
17900 * cs-parser.jay: Handle static keyword on class like instance
17903 * driver.cs: Added "/langversion" command line switch with two
17904 options (iso-1, default).
17906 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17908 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17910 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17912 * delegate.cs: Style.
17914 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17916 * delegate.cs: Add seperate instance expr field for miguel.
17918 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17920 * PointerArithmetic (Resolve): make sure we are not doing
17921 pointer arith on void*. Also, make sure we are resolved
17922 by not setting eclass until resolve.
17924 All callers: Make sure that PointerArithmetic gets resolved.
17926 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17928 * ArrayCreation (LookupType): If the type does not resolve
17929 to an array, give an error.
17931 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17933 * statement.cs (Try.Resolve): Fixed bug #64222
17935 2004-08-27 Martin Baulig <martin@ximian.com>
17938 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17941 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17943 * ecore.cs (Constantify): Get underlying type via
17944 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17945 Windows in special cases.
17947 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17949 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17950 for obtaining also private methods.
17951 (GetRemoveMethod): Used GetRemoveMethod (true)
17952 for obtaining also private methods.
17954 2004-08-24 Martin Baulig <martin@ximian.com>
17956 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17957 MethodAttributes.HideBySig for operators.
17959 2004-08-23 Martin Baulig <martin@ximian.com>
17961 Back to the old error reporting system :-)
17963 * report.cs (Message): Removed.
17964 (Report.MessageData, ErrorData, WarningData): Removed.
17965 (Report.Error, Warning): Back to the old system.
17967 2004-08-23 Martin Baulig <martin@ximian.com>
17969 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17971 * class.cs (TypeContainer.ParentContainer): New public virtual
17972 method; replaces the explicit interface implementation.
17973 (ClassPart.ParentContainer): Override.
17975 2004-08-23 Martin Baulig <martin@ximian.com>
17977 * statement.cs (Switch): Added support for constant switches; see
17978 #59428 or test-285.cs.
17980 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17983 * statement.cs (GetEnumeratorFilter): Removed useless
17984 logic because C# specs is strict. GetEnumerator must be
17987 2004-08-22 Martin Baulig <martin@ximian.com>
17989 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17990 a switch and may break, reset the barrier. Fixes #59867.
17992 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17994 CLS-Compliance speed up (~5% for corlib)
17996 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17997 New method. Tests container for CLS-Compliant names
17999 * class.cs (TypeContainer.VerifyClsName): New method.
18000 Checks whether container name is CLS Compliant.
18001 (Constructor): Implements IMethodData.
18003 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
18004 low-case table for CLS Compliance test.
18005 (MemberCache.VerifyClsParameterConflict): New method.
18006 Checks method parameters for CS3006 error.
18008 * enum.cs (EnumMember): Is derived from MemberCore.
18009 (Enum.VerifyClsName): Optimized for better performance.
18011 2004-08-06 Marek Safar <marek.safar@seznam.cz>
18013 * report.cs: Renamed Error_T to Error and changed all
18016 2004-08-06 Marek Safar <marek.safar@seznam.cz>
18018 * class.cs (TypeContainer.IndexerArrayList): New inner class
18019 container for indexers.
18020 (TypeContainer.DefaultIndexerName): New constant for default
18021 indexer name. Replaced all "Item" with this constant.
18022 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
18024 * typemanager.cs (TypeManager.default_member_ctor): Cache here
18025 DefaultMemberAttribute constructor.
18027 2004-08-05 Martin Baulig <martin@ximian.com>
18029 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
18032 2004-08-05 Marek Safar <marek.safar@seznam.cz>
18034 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
18035 multi platforms problem.
18037 * compiler.csproj: Included shared files.
18039 2004-08-04 Marek Safar <marek.safar@seznam.cz>
18041 Fix bug 60333, 55971 in the more general way
18042 * attribute.cs (Attribute.GetAttributeArgumentExpression):
18043 Added arg_type argument for constant conversion.
18044 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
18046 2004-08-04 Marek Safar <marek.safar@seznam.cz>
18049 * class.cs (TypeContainer ): New inner classes MethodArrayList,
18050 OperatorArrayList, MethodCoreArrayList for typecontainer
18051 containers. Changed class member types to these new types.
18052 (MethodArrayList.DefineMembers): Added test for CS0659.
18054 2004-08-04 Miguel de Icaza <miguel@ximian.com>
18056 * cfold.cs: Synchronize the folding with the code in expression.cs
18057 Binary.DoNumericPromotions for uint operands.
18059 * attribute.cs: Revert patch from Raja, it introduced a regression
18060 while building Blam-1.2.1 (hard to isolate a test case).
18062 2004-08-04 Marek Safar <marek.safar@seznam.cz>
18066 (TypeContainer.Define): Renamed to DefineContainerMembers because of
18068 (MethodCore.parent_method): New member. The method we're overriding
18069 if this is an override method.
18070 (MethodCore.CheckBase): Moved from Method class and made common.
18071 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
18073 (MethodCore.CheckForDuplications): New abstract method. For custom
18074 member duplication search in a container
18075 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
18076 method and its return type.
18077 (Event.conflict_symbol): New member. Symbol with same name in the
18081 (MemberCache.FindMemberWithSameName): New method. The method
18082 is looking for conflict with inherited symbols.
18084 2004-08-04 Martin Baulig <martin@ximian.com>
18086 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
18088 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
18090 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18092 * report.cs (Message): New enum for better error, warning reference in
18094 (MessageData): New inner abstract class. It generally handles printing of
18095 error and warning messages.
18096 Removed unused Error, Warning, Message methods.
18098 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18100 Fix for cs0592-8.cs test
18102 (Attributable.ValidAttributeTargets): Made public.
18103 (Attribute.ExplicitTarget): New member for explicit target value.
18104 (Attribute.CheckTargets): Now we translate explicit attribute
18105 target to Target here.
18107 2004-08-03 Ben Maurer <bmaurer@ximian.com>
18109 * ecore.cs (MethodGroupExpr): new IsBase property.
18111 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
18113 * delegate.cs (DelegateCreation): store a MethodGroupExpr
18114 rather than an instance expr.
18116 (DelegateCreation.Emit): Use the method group rather than
18117 the instance expression. Also, if you have base.Foo as the
18118 method for a delegate, make sure to emit ldftn, not ldftnvirt.
18120 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
18122 (NewDelegate.DoResolve): Only check for the existance of Invoke
18123 if the method is going to be needed. Use MethodGroupExpr.
18125 (NewDelegate.Emit): Remove, DelegateCreation implements this.
18127 * expression.cs: For pointer arith., make sure to use
18128 the size of the type, not the size of the pointer to
18131 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18134 * class.cs (Class): Added error CS0502 test.
18136 2004-08-03 John Luke <jluke@cfl.rr.com>
18137 Raja R Harinath <rharinath@novell.com>
18140 * attribute.cs (Attribute.complained_before): New flag.
18141 (Attribute.ResolveType, Attribute.Resolve),
18142 (Attribute.DefinePInvokeMethod): Set it.
18143 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
18145 2004-08-03 Martin Baulig <martin@ximian.com>
18147 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
18148 use a user-defined operator; we still need to do numeric
18149 promotions in case one argument is a builtin type and the other
18150 one has an implicit conversion to that type. Fixes #62322.
18152 2004-08-02 Martin Baulig <martin@ximian.com>
18154 * statement.cs (LocalInfo.Flags): Added `IsThis'.
18155 (LocalInfo.IsThis): New public property.
18156 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
18158 2004-08-01 Martin Baulig <martin@ximian.com>
18160 * class.cs (TypeContainer.GetClassBases): Don't set the default
18161 here since we may get called from GetPartialBases().
18162 (TypeContainer.DefineType): If GetClassBases() didn't return a
18163 parent, use the default one.
18165 2004-07-30 Duncan Mak <duncan@ximian.com>
18167 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
18169 2004-07-30 Martin Baulig <martin@ximian.com>
18171 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
18173 * class.cs (SourceMethod): New public class, derive from the
18174 symbol writer's ISourceMethod.
18175 (Method): Use the new symbol writer API.
18177 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
18178 as argument and use the new symbol writer.
18181 (SourceFile): Implement the symbol writer's ISourceFile.
18182 (Location.SymbolDocument): Removed.
18183 (Location.SourceFile): New public property.
18185 * symbolwriter.cs: Use the new symbol writer API.
18187 2004-07-30 Raja R Harinath <rharinath@novell.com>
18189 * Makefile (install-local): Remove. Functionality moved to
18192 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
18194 * Makefile: Install mcs.exe.config file together with mcs.exe.
18195 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
18196 correct runtime version.
18198 2004-07-25 Martin Baulig <martin@ximian.com>
18201 (TypeContainer.RegisterOrder): Removed, this was unused.
18202 (TypeContainer, interface_order): Removed.
18203 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
18204 TypeContainer as argument since we can also be called with a
18205 `PartialContainer' for a partial class/struct/interface.
18206 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
18207 of checking whether we're an `Interface' - we could be a
18208 `PartialContainer'.
18209 (PartialContainer.Register): Override; call
18210 AddClass()/AddStruct()/AddInterface() on our parent.
18212 * cs-parser.jay (interface_member_declaration): Add things to the
18213 `current_container', not the `current_class'.
18215 * rootcontext.cs (RegisterOrder): The overloaded version which
18216 takes an `Interface' was unused, removed.
18218 * typemanager.cs (TypeManager.LookupInterface): Return a
18219 `TypeContainer', not an `Interface'.
18220 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
18221 contain a `PartialContainer' for an interface, so check it's
18222 `Kind' to figure out what it is.
18224 2004-07-25 Martin Baulig <martin@ximian.com>
18226 * class.cs (Class.DefaultTypeAttributes): New public constant.
18227 (Struct.DefaultTypeAttributes): Likewise.
18228 (Interface.DefaultTypeAttributes): Likewise.
18229 (PartialContainer.TypeAttr): Override this and add the
18230 DefaultTypeAttributes.
18232 2004-07-25 Martin Baulig <martin@ximian.com>
18234 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
18235 we can just use the `Parent' field instead.
18237 2004-07-25 Martin Baulig <martin@ximian.com>
18239 * class.cs (TypeContainer.Emit): Renamed to EmitType().
18241 2004-07-25 Martin Baulig <martin@ximian.com>
18243 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
18244 our parts before defining any methods.
18245 (TypeContainer.VerifyImplements): Make this virtual.
18246 (ClassPart.VerifyImplements): Override and call VerifyImplements()
18247 on our PartialContainer.
18249 2004-07-25 Martin Baulig <martin@ximian.com>
18251 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
18253 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
18254 argument, we can just use the `Parent' field instead.
18257 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
18258 (MemberBase.DoDefine): Likewise.
18260 2004-07-24 Martin Baulig <martin@ximian.com>
18262 * decl.cs (MemberCore.Parent): New public field.
18263 (DeclSpace.Parent): Moved to MemberCore.
18265 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
18266 (MemberBase.ctor): Added TypeContainer argument, pass it to our
18268 (FieldBase, Field, Operator): Likewise.
18269 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
18270 (EventField, Event): Likewise.
18272 2004-07-23 Martin Baulig <martin@ximian.com>
18274 * class.cs (PartialContainer): New public class.
18275 (ClassPart): New public class.
18276 (TypeContainer): Added support for partial classes.
18277 (TypeContainer.GetClassBases): Splitted some of the functionality
18278 out into GetNormalBases() and GetPartialBases().
18280 * cs-tokenizer.cs (Token.PARTIAL): New token.
18281 (Tokenizer.consume_identifier): Added some hacks to recognize
18282 `partial', but only if it's immediately followed by `class',
18283 `struct' or `interface'.
18285 * cs-parser.jay: Added support for partial clases.
18287 2004-07-23 Martin Baulig <martin@ximian.com>
18289 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
18290 a `DeclSpace' and also made it readonly.
18291 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
18292 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
18293 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
18295 * cs-parser.jay: Pass the `current_class', not the
18296 `current_container' (at the moment, this is still the same thing)
18297 to a new Method, Property, Event, Indexer or Constructor.
18299 2004-07-23 Martin Baulig <martin@ximian.com>
18301 * cs-parser.jay (CSharpParser): Added a new `current_class' field
18302 and removed the `current_interface' one.
18303 (struct_declaration, class_declaration, interface_declaration):
18304 Set `current_class' to the newly created class/struct/interface;
18305 set their `Bases' and call Register() before parsing their body.
18307 2004-07-23 Martin Baulig <martin@ximian.com>
18309 * class.cs (Kind): New public enum.
18310 (TypeContainer): Made this class abstract.
18311 (TypeContainer.Kind): New public readonly field.
18312 (TypeContainer.CheckDef): New public method; moved here from
18314 (TypeContainer.Register): New public abstract method.
18315 (TypeContainer.GetPendingImplementations): New public abstract
18317 (TypeContainer.GetClassBases): Removed the `is_class' and
18318 `is_iface' parameters.
18319 (TypeContainer.DefineNestedTypes): Formerly known as
18321 (ClassOrStruct): Made this class abstract.
18323 * tree.cs (RootTypes): New public type.
18325 2004-07-20 Martin Baulig <martin@ximian.com>
18327 * tree.cs (Tree.RecordNamespace): Removed.
18328 (Tree.Namespaces): Removed.
18330 * rootcontext.cs (RootContext.IsNamespace): Removed.
18332 * cs-parser.jay (namespace_declaration): Just create a new
18333 NamespaceEntry here.
18335 2004-07-20 Martin Baulig <martin@ximian.com>
18337 * statement.cs (ExceptionStatement): New abstract class. This is
18338 now used as a base class for everyone who's using `finally'.
18339 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
18340 our local variables before using them.
18342 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
18343 virtual method. This is used by Yield.Resolve() to "steal" an
18344 outer block's `finally' clauses.
18345 (FlowBranchingException): The .ctor now takes an ExceptionStatement
18348 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
18349 version which takes an ExceptionStatement. This version must be
18350 used to create exception branchings.
18353 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
18354 (Iterator.EmitMoveNext): Added exception support; protect the
18355 block with a `fault' clause, properly handle 'finally' clauses.
18356 (Iterator.EmitDispose): Run all the `finally' clauses here.
18358 2004-07-20 Martin Baulig <martin@ximian.com>
18360 * iterator.cs: This is the first of a set of changes in the
18361 iterator code. Match the spec more closely: if we're an
18362 IEnumerable, then GetEnumerator() must be called. The first time
18363 GetEnumerator() is called, it returns the current instance; all
18364 subsequent invocations (if any) must create a copy.
18366 2004-07-19 Miguel de Icaza <miguel@ximian.com>
18368 * expression.cs: Resolve the constant expression before returning
18371 2004-07-19 Martin Baulig <martin@ximian.com>
18373 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
18374 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
18375 the return type of the new EmitContext.
18377 2004-07-18 Martin Baulig <martin@ximian.com>
18379 * class.cs (Property.Define): Fix iterators.
18381 * iterators.cs (Iterator.Define): Moved the
18382 `container.AddInterator (this)' call here from the .ctor; only do
18383 it if we resolved successfully.
18385 2004-07-17 Miguel de Icaza <miguel@ximian.com>
18387 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
18388 `true' for preprocessing directives that we parse. The return
18389 value indicates whether we should return to regular tokenizing or
18390 not, not whether it was parsed successfully.
18392 In the past if we were in: #if false ... #line #endif, we would
18393 resume parsing after `#line'. See bug 61604.
18395 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
18396 building: IsEnumType should return true only for enums, not for
18397 enums or System.Enum itself. This fixes #61593.
18399 Likely what happened is that corlib was wrong: mcs depended on
18400 this bug in some places. The bug got fixed, we had to add the
18401 hack, which caused bug 61593.
18403 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
18404 that was a workaround for the older conditions.
18406 2004-07-16 Ben Maurer <bmaurer@ximian.com>
18408 * assign.cs: IAssignMethod has a new interface, as documented
18409 inline. All assignment code now uses this new api.
18411 * ecore.cs, expression.cs: All classes which implement
18412 IAssignMethod now use the new interface.
18414 * expression.cs (Invocation): add a hack to EmitCall so that
18415 IndexerAccess can be the target of a compound assignment without
18416 evaluating its arguments twice.
18418 * statement.cs: Handle changes in Invocation api.
18420 2004-07-16 Martin Baulig <martin@ximian.com>
18422 * iterators.cs: Rewrote this. We're now using one single Proxy
18423 class for both the IEnumerable and the IEnumerator interface and
18424 `Iterator' derives from Class so we can use the high-level API.
18426 * class.cs (TypeContainer.AddIterator): New method.
18427 (TypeContainer.DoDefineType): New protected virtual method, which
18428 is called from DefineType().
18429 (TypeContainer.DoDefineMembers): Call DefineType() and
18430 DefineMembers() on all our iterators.
18431 (TypeContainer.Emit): Call Emit() on all our iterators.
18432 (TypeContainer.CloseType): Call CloseType() on all our iterators.
18434 * codegen.cs (EmitContext.CurrentIterator): New public field.
18436 2004-07-15 Martin Baulig <martin@ximian.com>
18439 (TypeManager.not_supported_exception_type): New type.
18441 2004-07-14 Martin Baulig <martin@ximian.com>
18443 * iterators.cs: Use real error numbers.
18445 2004-07-14 Martin Baulig <martin@ximian.com>
18447 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
18448 requires this to be a System.Collection.IEnumerable and not a
18449 class implementing that interface.
18450 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
18452 2004-07-13 Marek Safar <marek.safar@seznam.cz>
18454 * class.cs: Fixed previous fix, it broke some error tests.
18456 2004-07-12 Martin Baulig <martin@ximian.com>
18458 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
18461 2004-07-09 Miguel de Icaza <miguel@ximian.com>
18463 * assign.cs (LocalTemporary): Add new argument: is_address,If
18464 `is_address' is true, then the value that we store is the address
18465 to the real value, and not the value itself.
18467 * ecore.cs (PropertyExpr): use the new local temporary
18468 stuff to allow us to handle X.Y += z (where X is a struct)
18470 2004-07-08 Martin Baulig <martin@ximian.com>
18472 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
18473 not always return, just like we're doing in Using.Resolve().
18475 2004-07-07 Miguel de Icaza <miguel@ximian.com>
18477 * cs-parser.jay (fixed_statement): flag this as Pinned.
18479 2004-07-06 Miguel de Icaza <miguel@ximian.com>
18481 * typemanager.cs (TypeManager): Removed MakePinned method, this
18482 mechanism is replaced with the .NET 2.x compatible mechanism of
18483 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
18485 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
18486 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
18487 `IsFixed' property which has a different meaning.
18489 2004-07-02 Raja R Harinath <rharinath@novell.com>
18491 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
18492 visible from inside a nested class, not just the names of the
18493 immediately enclosing class.
18494 Fix for bug #60730.
18496 2004-06-24 Raja R Harinath <rharinath@novell.com>
18498 * expression.cs (BetterConversion): Remove buggy special-case
18499 handling of "implicit constant expression conversions". At this
18500 point, we already know that the conversion is possible -- we're
18501 only checking to see which is better.
18503 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18505 * cs-parser.jay: Added error CS0210 test.
18507 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18509 * cs-parser.jay: Added error CS0134 test.
18511 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18514 * cs-parser.jay: Added error CS0145 test.
18516 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18518 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
18520 2004-06-23 Ben Maurer <bmaurer@ximian.com>
18522 * expression.cs (StackAlloc.Resolve): The argument may not
18523 be a constant; deal with this case.
18525 2004-06-23 Marek Safar <marek.safar@seznam.cz>
18527 * attribute.cs (IndexerName_GetIndexerName): Renamed to
18528 GetIndexerAttributeValue.
18529 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
18531 * class.cs (Indexer.Define): Added error tests for CS0415,
18534 2004-06-23 Miguel de Icaza <miguel@ximian.com>
18536 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18539 2004-06-23 Martin Baulig <martin@ximian.com>
18541 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18542 neither return nor throw, reset the barrier as well. Fixes #60457.
18544 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18546 * class.cs : EventAttributes is now set to None by default.
18547 This fixes bug #60459.
18549 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18552 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18553 Don't throw exception but return null (it's sufficient now).
18555 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18557 * typemanager.cs (GetArgumentTypes): Faster implementation.
18559 2004-06-18 Martin Baulig <martin@ximian.com>
18561 * attribute.cs (Attribute.Resolve): Check whether we're an
18562 EmptyCast which a Constant child. Fixes #60333.
18564 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18566 * statement.cs (EmitCollectionForeach): Account for the fact that
18567 not all valuetypes are in areas which we can take the address of.
18568 For these variables, we store to a temporary variable. Also, make
18569 sure that we dont emit a `callvirt' on a valuetype method.
18571 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18573 * expression.cs (StackAlloc.DoReSolve): Added test for
18574 negative parameter (CS0247).
18576 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18579 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18581 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18584 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18587 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18589 Fix bug #58254 & cs1555.cs, cs1556.cs
18590 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18592 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18594 * cs-parser.jay: Added error CS1669 test for indexers.
18596 2004-06-11 Martin Baulig <martin@ximian.com>
18598 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18599 call this twice: for params and varargs methods.
18601 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18604 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18606 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18608 * attribute.cs (Attribute.GetValidTargets): Made public.
18611 (AbstractPropertyEventMethod): New class for better code sharing.
18612 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18614 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18616 2004-06-11 Raja R Harinath <rharinath@novell.com>
18619 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18620 that the call to Resolve is part of a MemberAccess.
18621 (Expression.Resolve): Use it for SimpleName resolution.
18622 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18623 Add 'intermediate' boolean argument.
18624 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18625 error message when the SimpleName can be resolved ambiguously
18626 between an expression and a type.
18627 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18629 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18630 call on the left-side.
18632 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18635 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18637 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18639 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18641 2004-06-11 Martin Baulig <martin@ximian.com>
18643 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18644 varargs methods if applicable.
18646 2004-06-11 Martin Baulig <martin@ximian.com>
18648 * expression.cs (Invocation.EmitCall): Don't use
18649 `method.CallingConvention == CallingConventions.VarArgs' since the
18650 method could also have `CallingConventions.HasThis'.
18652 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18654 * class.cs (Event.GetSignatureForError): Implemented.
18655 Fixed crash in error test cs3010.cs
18657 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18659 * cs-tokenizer.cs: Change the way we track __arglist to be
18660 consistent with the other keywords.
18662 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18664 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18667 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18669 * codegen.cs: Check that all referenced assemblies have a strongname
18670 before strongnaming the compiled assembly. If not report error CS1577.
18671 Fix bug #56563. Patch by Jackson Harper.
18672 * typemanager.cs: Added a method to return all referenced assemblies.
18673 Fix bug #56563. Patch by Jackson Harper.
18675 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18678 (Method.ApplyAttributeBuilder): Moved and added conditional
18679 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18682 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18684 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18687 * class.cs: (EventField.attribute_targets): Changed default target.
18689 2004-06-08 Martin Baulig <martin@ximian.com>
18691 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18693 2004-06-08 Martin Baulig <martin@ximian.com>
18695 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18697 2004-06-07 Martin Baulig <martin@ximian.com>
18699 Added support for varargs methods.
18701 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18704 * cs-parser.jay: Added support for `__arglist'.
18706 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18708 * expression.cs (Argument.AType): Added `ArgList'.
18709 (Invocation): Added support for varargs methods.
18710 (ArglistAccess): New public class.
18711 (Arglist): New public class.
18713 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18715 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18716 a method's top-level block if the method has varargs.
18718 * support.cs (ReflectionParameters, InternalParameters): Added
18719 support for varargs methods.
18721 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18723 * class.cs: Provide location in indexer error report.
18725 * driver.cs: Use standard names.
18727 * namespace.cs: Catch the use of using after a namespace has been
18728 declared also on using aliases.
18730 2004-06-03 Raja R Harinath <rharinath@novell.com>
18733 * typemanager.cs (closure_private_ok, closure_invocation_type)
18734 (closure_qualifier_type, closure_invocation_assembly)
18735 (FilterWithClosure): Move to ...
18736 (Closure): New internal nested class.
18737 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18738 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18739 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18740 (MemberLookup, MemberLookupFailed): Use it.
18741 * expression.cs (New.DoResolve): Treat the lookup for the
18742 constructor as being qualified by the 'new'ed type.
18743 (Indexers.GetIndexersForTypeOrInterface): Update.
18745 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18748 (GetConditionalAttributeValue): New method. Returns
18749 condition of ConditionalAttribute.
18750 (SearchMulti): New method. Returns all attributes of type 't'.
18751 Use it when attribute is AllowMultiple = true.
18752 (IsConditionalMethodExcluded): New method.
18755 (Method.IsExcluded): Implemented. Returns true if method has conditional
18756 attribute and the conditions is not defined (method is excluded).
18757 (IMethodData): Extended interface for ConditionalAttribute support.
18758 (PropertyMethod.IsExcluded): Implemented.
18761 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18764 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18767 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18769 * expression.cs (ArrayCreationExpression): Make this just an
18770 `expression'. It can't be a statement, so the code here was
18773 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18776 * typemanager.cs (GetFullNameSignature): New method for
18779 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18782 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18783 Use this method when MethodBuilder is null.
18784 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18785 Added test for error CS0626 (MONO reports error for this situation).
18786 (IMethodData.GetSignatureForError): Extended interface.
18788 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18791 (AttributeTester.GetObsoleteAttribute): Returns instance of
18792 ObsoleteAttribute when type is obsolete.
18795 (TypeContainer.VerifyObsoleteAttribute): Override.
18796 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18797 (MethodCode.VerifyObsoleteAttribute): Override.
18798 (MemberBase.VerifyObsoleteAttribute): Override.
18801 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18802 and report proper error.
18805 Delegate.VerifyObsoleteAttribute): Override.
18808 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18809 and report proper error.
18810 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18813 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18817 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18818 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18819 Added test for ObsoleteAttribute.
18822 (Catch): Derived from Statement.
18824 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18826 Fixed bug #59071 & cs0160.cs
18828 * statement.cs (Try.Resolve): Check here whether order of catch
18829 clauses matches their dependencies.
18831 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18833 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18834 caused a regression: #59343. Referencing nested classes from an
18835 assembly stopped working.
18837 2004-05-31 Martin Baulig <martin@ximian.com>
18839 MCS is now frozen for beta 2.
18841 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18843 * convert.cs: add a trivial cache for overload operator resolution.
18845 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18847 * decl.cs: If possible, use lookuptypedirect here. We can only do
18848 this if there is no `.' after the namespace. Avoids using
18849 LookupType, which does lots of slow processing.
18850 (FindNestedType) New method, does what it says :-).
18851 * namespace.cs: use LookupTypeDirect.
18852 * rootcontext.cs: use membercache, if possible.
18853 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18855 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18858 According to the spec,
18860 In a member access of the form E.I, if E is a single identifier,
18861 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18862 field, property, localvariable, or parameter with the same type as
18863 the meaning of E as a type-name (§3.8), then both possible
18864 meanings of E are permitted.
18866 We did not check that E as a simple-name had the same type as E as
18869 This trivial check gives us 5-7% on bootstrap time.
18871 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18873 * expression.cs (Invocation.OverloadResolve): Avoid the
18874 use of hashtables and boxing here by allocating on demand.
18876 2004-05-30 Martin Baulig <martin@ximian.com>
18878 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18879 we're doing a silent lookup. Don't try to lookup nested types in
18880 TypeManager.object_type (thanks to Ben Maurer).
18882 2004-05-30 Martin Baulig <martin@ximian.com>
18884 Committing a patch from Ben Maurer.
18886 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18888 2004-05-29 Martin Baulig <martin@ximian.com>
18890 * class.cs (IMethodData.ShouldIgnore): New method.
18892 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18893 `Location' argument, we don't need it anywhere. Use
18894 `IMethodData.ShouldIgnore ()' instead of
18895 `MethodData.GetMethodFlags ()'.
18896 (TypeManager.AddMethod): Removed.
18897 (TypeManager.AddMethod2): Renamed to AddMethod.
18899 2004-05-29 Martin Baulig <martin@ximian.com>
18901 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18903 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18904 converting from a class type S to an interface type and we already
18905 have an object on the stack, don't box it again. Fixes #52578.
18907 2004-05-29 Martin Baulig <martin@ximian.com>
18909 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18910 Added support for `params' parameters. Fixes #59267.
18912 2004-05-29 Martin Baulig <martin@ximian.com>
18914 * literal.cs (NullPointer): Provide a private .ctor which sets
18915 `type' to TypeManager.object_type. Fixes #59048.
18917 2004-05-29 Martin Baulig <martin@ximian.com>
18919 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18920 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18922 * ecore.cs (EventExpr.instance_expr): Make the field private.
18924 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18926 Fixed bug #50080 & cs0214-2.cs
18927 * expression.cs (Cast.DoResolve): Check unsafe context here.
18929 * statement.cs (Resolve.DoResolve): Likewise.
18931 2004-05-26 Martin Baulig <martin@ximian.com>
18933 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18935 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18936 (RootContext.LookupType): Pass down the `silent' flag.
18938 2004-05-25 Martin Baulig <martin@ximian.com>
18941 (MethodGroupExpr.IdenticalTypeName): New public property.
18942 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18943 expression actually refers to a type.
18945 2004-05-25 Martin Baulig <martin@ximian.com>
18947 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18948 for #56176 and made it actually work.
18950 2004-05-25 Martin Baulig <martin@ximian.com>
18952 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18953 (FieldExpr, PropertyExpr): Override and implement
18954 CacheTemporaries. Fixes #52279.
18956 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18958 * location.cs: In the new compiler listing a file twice is a
18959 warning, not an error.
18961 2004-05-24 Martin Baulig <martin@ximian.com>
18963 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18964 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18966 2004-05-24 Martin Baulig <martin@ximian.com>
18968 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18969 walking the `using' list. Fixes #53921.
18971 2004-05-24 Martin Baulig <martin@ximian.com>
18973 * const.cs (Const.LookupConstantValue): Added support for
18974 EmptyCast's; fixes #55251.
18976 2004-05-24 Martin Baulig <martin@ximian.com>
18978 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18979 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18980 which does the CS0135 check. The reason is that we first need to
18981 check whether the variable actually exists.
18983 2004-05-24 Martin Baulig <martin@ximian.com>
18985 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18986 than RootContext.LookupType() to find the explicit interface
18987 type. Fixes #58584.
18989 2004-05-24 Raja R Harinath <rharinath@novell.com>
18991 * Makefile: Simplify. Use executable.make.
18992 * mcs.exe.sources: New file. List of sources of mcs.exe.
18994 2004-05-24 Anders Carlsson <andersca@gnome.org>
18998 Use the invariant culture when doing String.Compare for CLS case
19001 2004-05-23 Martin Baulig <martin@ximian.com>
19003 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
19004 don't have any dots. Fixes #52622, added cs0246-8.cs.
19006 * namespace.cs (NamespaceEntry.Lookup): Likewise.
19008 2004-05-23 Marek Safar <marek.safar@seznam.cz>
19010 * class.cs (MemberBase.Define): Reuse MemberType member for
19011 resolved type. Other methods can use it too.
19013 2004-05-23 Martin Baulig <martin@ximian.com>
19015 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
19016 the variable also exists in the current block (otherwise, we need
19017 to report a CS0103). Fixes #58670.
19019 2004-05-23 Martin Baulig <martin@ximian.com>
19021 * flowanalysis.cs (Reachability.Reachable): Compute this
19022 on-the-fly rather than storing it as a field.
19024 2004-05-23 Martin Baulig <martin@ximian.com>
19026 * flowanalysis.cs (Reachability.And): Manually compute the
19027 resulting `barrier' from the reachability.
19029 2004-05-23 Marek Safar <marek.safar@seznam.cz>
19032 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
19033 instance of ObsoleteAttribute when symbol is obsolete.
19036 (IMethodData): Extended interface for ObsoleteAttribute support.
19038 2004-05-22 Marek Safar <marek.safar@seznam.cz>
19040 * attribute.cs: Fix bug #55970
19042 2004-05-22 Marek Safar <marek.safar@seznam.cz>
19046 (GetObsoleteAttribute): New method. Creates the instance of
19048 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
19049 ObsoleteAttribute when member is obsolete.
19050 (AttributeTester.Report_ObsoleteMessage): Common method for
19051 Obsolete error/warning reporting.
19054 (TypeContainer.base_classs_type): New member for storing parent type.
19057 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
19058 for this MemberCore.
19060 2004-05-21 Marek Safar <marek.safar@seznam.cz>
19062 * attribute.cs, const.cs: Fix bug #58590
19064 2004-05-21 Martin Baulig <martin@ximian.com>
19066 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
19067 out parameters if the end of the method is unreachable. Fixes
19070 2004-05-21 Marek Safar <marek.safar@seznam.cz>
19072 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
19073 Hari was right, why extra method.
19075 2004-05-21 Marek Safar <marek.safar@seznam.cz>
19077 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
19079 2004-05-20 Martin Baulig <martin@ximian.com>
19081 Merged this back from gmcs to keep the differences to a minumum.
19083 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
19084 instead of a Declspace.
19085 (Attribute.ResolveType): Likewise.
19086 (Attributes.Search): Likewise.
19087 (Attributes.Contains): Likewise.
19088 (Attributes.GetClsCompliantAttribute): Likewise.
19090 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
19092 (MethodData.ApplyAttributes): Take an EmitContext instead of a
19095 2004-05-19 Marek Safar <marek.safar@seznam.cz>
19097 Fix bug #58688 (MCS does not report error when the same attribute
19100 * attribute.cs (Attribute.Emit): Distinction between null and default.
19102 2004-05-19 Raja R Harinath <rharinath@novell.com>
19104 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
19105 of a top-level attribute without an attribute target.
19106 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
19108 (Attribute.Conditional_GetConditionName),
19109 (Attribute.Obsolete_GetObsoleteMessage): Update.
19110 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
19111 part of ScanForIndexerName.
19112 (Attribute.CanIgnoreInvalidAttribute): New function.
19113 (Attribute.ScanForIndexerName): Move to ...
19114 (Attributes.ScanForIndexerName): ... here.
19115 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
19116 (Attributes.Search): New internal variant that can choose not to
19117 complain if types aren't resolved. The original signature now
19119 (Attributes.GetClsCompliantAttribute): Use internal variant, with
19120 complaints suppressed.
19121 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
19122 only if it not useful.
19123 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
19124 top-level for attributes that are shared between the assembly
19125 and a top-level class.
19126 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
19127 * class.cs: Update to reflect changes.
19128 (DefineIndexers): Fuse loops.
19129 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
19130 a couple more variants of attribute names.
19132 2004-05-18 Marek Safar <marek.safar@seznam.cz>
19134 Fix bug #52585 (Implemented explicit attribute declaration)
19137 (Attributable.ValidAttributeTargets): New abstract method. It gets
19138 list of valid attribute targets for explicit target declaration.
19139 (Attribute.Target): It holds target itself.
19140 (AttributeSection): Removed.
19141 (Attribute.CheckTargets): New method. It checks whether attribute
19142 target is valid for the current element.
19145 (EventProperty): New class. For events that are declared like
19146 property (with add and remove accessors).
19147 (EventField): New class. For events that are declared like field.
19150 * cs-parser.jay: Implemented explicit attribute target declaration.
19152 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
19153 Override ValidAttributeTargets.
19156 (ReturnParameter): Class for applying custom attributes on
19158 (ParameterAtribute): New class. Class for applying custom
19159 attributes on the parameter type.
19161 2004-05-17 Miguel de Icaza <miguel@ximian.com>
19163 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
19166 (Method): Allow UNSAFE here.
19168 * modifiers.cs: Support unsafe reporting.
19170 2004-05-17 Marek Safar <marek.safar@seznam.cz>
19172 * decl.cs: Fix bug #58478.
19174 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19176 * statement.cs: When checking for unreachable code on an EmptyStatement,
19177 set the location. Fixes bug #58488.
19179 2004-05-13 Miguel de Icaza <miguel@ximian.com>
19181 * driver.cs: Add -pkg handling.
19183 From Gonzalo: UseShelLExecute=false
19185 2004-05-12 Marek Safar <marek.safar@seznam.cz>
19188 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
19190 (Attribute.IsClsCompliaceRequired): Moved to base for better
19192 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
19193 when attribute is AttributeUsageAttribute.
19194 (Attribute.GetValidTargets): Simplified.
19195 (Attribute.GetAttributeUsage): New method returns AttributeUsage
19196 attribute for this type.
19197 (Attribute.ApplyAttributes): Method renamed to Emit and make
19199 (GlobalAttributeSection): New class for special handling of global
19200 attributes (assembly, module).
19201 (AttributeSection.Emit): New method.
19203 * class.cs: Implemented Attributable abstract methods.
19204 (MethodCore.LabelParameters): Moved to Parameter class.
19205 (Accessor): Is back simple class.
19206 (PropertyMethod): Implemented Attributable abstract class.
19207 (DelegateMethod): Implemented Attributable abstract class.
19208 (Event): New constructor for disctintion between normal Event
19209 and Event with accessors.
19211 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
19213 * codegen.cs, const.cs, decl.cs, delegate.cs:
19214 (CommonAssemblyModulClass): Implemented Attributable abstract class
19217 * enum.cs: Implement IAttributeSupport interface.
19218 (EnumMember): New class for emum members. Implemented Attributable
19222 (ParameterBase): Is abstract.
19223 (ReturnParameter): New class for easier [return:] attribute handling.
19225 * typemanager.cs: Removed builder_to_attr.
19227 2004-05-11 Raja R Harinath <rharinath@novell.com>
19230 * attribute.cs (Attribute.GetPositionalValue): New function.
19231 * class.cs (TypeContainer.VerifyMembers): New function.
19232 (TypeContainer.Emit): Use it.
19233 (ClassOrStruct): New base class for Class and Struct.
19234 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
19235 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
19237 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
19238 then each non-static field should have a FieldOffset attribute.
19239 Otherwise, none of the fields should have a FieldOffset attribute.
19240 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
19241 and FieldOffset attributes.
19242 * typemanager.cs (TypeManager.struct_layout_attribute_type)
19243 (TypeManager.field_offset_attribute_type): New core types.
19244 (TypeManager.InitCoreTypes): Initialize them.
19246 2004-05-11 Michal Moskal <malekith@pld-linux.org>
19248 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
19249 Return correct type.
19252 2004-05-09 Miguel de Icaza <miguel@ximian.com>
19254 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
19255 be implicitly converted to ulong.
19257 * expression.cs: The logic for allowing operator &, | and ^ worked
19258 was wrong, it worked before because we did not report an error in
19259 an else branch. Fixes 57895.
19261 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
19262 allow volatile fields to be reference types.
19264 2004-05-07 Miguel de Icaza <miguel@ximian.com>
19266 * driver.cs: Add support for /debug-
19268 2004-05-07 Raja R Harinath <rharinath@novell.com>
19270 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
19271 Add a 'complain' parameter to silence errors.
19272 (Attribute.Resolve): Update to changes. Put in sanity check to catch
19273 silently overlooked type-resolutions.
19274 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
19275 to reflect changes.
19276 (Attributes.Search): New function.
19277 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
19278 (Attributes.GetAttributeFullName): Remove hack.
19279 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
19280 Update to reflect changes.
19281 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
19282 Use Attributes.Search instead of nested loops.
19284 2004-05-07 Marek Safar <marek.safar@seznam.cz>
19287 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
19288 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
19289 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
19291 * report.cs: (Report.Warning): Renamed to Warning_T because of
19292 parameter collision.
19294 2004-05-05 Raja R Harinath <rharinath@novell.com>
19296 * expression.cs (MemberAccess.ResolveMemberAccess):
19297 Exit with non-zero status after Report.Error.
19298 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
19300 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
19302 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19304 * support.cs: Don't hang when the file is empty.
19306 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19308 * support.cs: In SeekableStreamReader, compute the preamble size of the
19309 underlying stream. Position changes should take into account that initial
19312 2004-05-03 Todd Berman <tberman@sevenl.net>
19314 * driver.cs: remove unused GetSysVersion function.
19316 2004-05-03 Todd Berman <tberman@sevenl.net>
19318 * driver.cs: Remove the hack from saturday, as well as the hack
19319 from jackson (LoadAssemblyFromGac), also adds the CWD to the
19320 link_paths to get that bit proper.
19322 2004-05-01 Todd Berman <tberman@sevenl.net>
19324 * driver.cs: Try a LoadFrom before a Load, this checks the current
19325 path. This is currently a bug in mono that is be fixed, however, this
19326 provides a workaround for now. This will be removed when the bug
19329 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
19331 * CryptoConvert.cs: Updated to latest version. Fix issue with
19332 incomplete key pairs (#57941).
19334 2004-05-01 Todd Berman <tberman@sevenl.net>
19336 * driver.cs: Remove '.' from path_chars, now System.* loads properly
19339 2004-04-30 Jackson Harper <jackson@ximian.com>
19341 * codegen.cs: Open keys readonly.
19343 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19345 * typemanager.cs: don't report cyclic struct layout when a struct
19346 contains 2 or more fields of the same type. Failed for Pango.AttrShape
19347 which has 2 Pango.Rectangle fields.
19349 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
19351 * expression.cs: Handle IntPtr comparisons with IL code
19352 rather than a method call.
19354 2004-04-29 Martin Baulig <martin@ximian.com>
19356 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
19357 the list of PropertyInfo's in class hierarchy and find the
19358 accessor. Fixes #56013.
19360 2004-04-29 Martin Baulig <martin@ximian.com>
19362 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
19364 2004-04-29 Martin Baulig <martin@ximian.com>
19366 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19368 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
19370 2004-04-29 Martin Baulig <martin@ximian.com>
19372 * class.cs (ConstructorInitializer.Resolve): Check whether the
19373 parent .ctor is accessible. Fixes #52146.
19375 2004-04-29 Martin Baulig <martin@ximian.com>
19377 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19379 * statement.cs (Using.EmitLocalVariableDecls): Use
19380 TypeManager.idisposable_type, not typeof (IDisposable).
19381 (Foreach.EmitCollectionForeach): Added support for valuetypes.
19383 2004-04-29 Martin Baulig <martin@ximian.com>
19385 * class.cs (Event.Define): Don't emit the field and don't set
19386 RTSpecialName and SpecialName for events on interfaces. Fixes
19389 2004-04-29 Raja R Harinath <rharinath@novell.com>
19391 Refactor Attribute.ApplyAttributes.
19392 * attribute.cs (Attributable): New base class for objects that can
19393 have Attributes applied on them.
19394 (Attribute): Make AttributeUsage fields public.
19395 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
19396 (Attribute.IsInternalCall): New property.
19397 (Attribute.UsageAttr): Convert to a public read-only property.
19398 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
19399 (Attribute.ResolveType, Attribute.Resolve)
19400 (Attribute.ScanForIndexerName): Update to reflect changes.
19401 (Attribute.CheckAttributeTarget): Re-format.
19402 (Attribute.ApplyAttributes): Refactor, to various
19403 Attributable.ApplyAttributeBuilder methods.
19404 * decl.cs (MemberCore): Make Attributable.
19405 * class.cs (Accessor): Make Attributable.
19406 (MethodData.ApplyAttributes): Use proper attribute types, not
19408 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
19409 (TypeContainer.ApplyAttributeBuilder)
19410 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
19411 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
19412 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
19413 (Operator.ApplyAttributeBuilder): New factored-out methods.
19414 * const.cs (Const.ApplyAttributeBuilder): Likewise.
19415 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
19416 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
19417 * parameter.cs (ParameterBase): New Attributable base class
19418 that can also represent Return types.
19419 (Parameter): Update to the changes.
19421 2004-04-29 Jackson Harper <jackson@ximian.com>
19423 * driver.cs: Prefer the corlib system version when looking for
19424 assemblies in the GAC. This is still a hack, but its a better hack
19427 2004-04-29 Marek Safar <marek.safar@seznam.cz>
19429 * decl.cs, enum.cs: Improved error 3005 reporting.
19431 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
19432 (related_symbols): New private member for list of symbols
19433 related to reported error/warning.
19435 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
19437 2004-04-29 Martin Baulig <martin@ximian.com>
19439 * ecore.cs (Expression.Constantify): If we're an enum and
19440 TypeManager.TypeToCoreType() doesn't give us another type, use
19441 t.UnderlyingSystemType. Fixes #56178.
19443 2004-04-29 Martin Baulig <martin@ximian.com>
19445 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
19446 interfaces and for each interface, only add members directly
19447 declared in that interface. Fixes #53255.
19449 2004-04-28 Martin Baulig <martin@ximian.com>
19451 * expression.cs (ConditionalLogicalOperator): Use a temporary
19452 variable for `left' to avoid that we evaluate it more than once;
19455 2004-04-28 Martin Baulig <martin@ximian.com>
19457 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
19460 2004-04-28 Martin Baulig <martin@ximian.com>
19462 * statement.cs (LocalInfo.Resolve): Check whether the type is not
19465 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
19466 whether the type is not void (CS1547).
19468 2004-04-28 Martin Baulig <martin@ximian.com>
19470 * expression.cs (Unary.DoResolveLValue): Override this and report
19471 CS0131 for anything but Operator.Indirection.
19473 2004-04-28 Martin Baulig <martin@ximian.com>
19475 Committing a patch from Ben Maurer; see bug #50820.
19477 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19480 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19483 2004-04-28 Martin Baulig <martin@ximian.com>
19485 Committing a patch from Ben Maurer; see bug #50820.
19487 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19490 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19493 2004-04-28 Martin Baulig <martin@ximian.com>
19495 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
19496 (Block.AddLabel): Call DoLookupLabel() to only search in the
19499 2004-04-28 Martin Baulig <martin@ximian.com>
19501 * cfold.cs (ConstantFold.BinaryFold): Added special support for
19502 comparing StringConstants and NullLiterals in Equality and Inequality.
19504 2004-04-28 Jackson Harper <jackson@ximian.com>
19506 * driver.cs: Attempt to load referenced assemblies from the
19507 GAC. This is the quick and dirty version of this method that
19508 doesnt take into account versions and just takes the first
19509 canidate found. Will be good enough for now as we will not have more
19510 then one version installed into the GAC until I update this method.
19512 2004-04-28 Martin Baulig <martin@ximian.com>
19514 * typemanager.cs (TypeManager.CheckStructCycles): New public
19515 static method to check for cycles in the struct layout.
19517 * rootcontext.cs (RootContext.PopulateTypes): Call
19518 TypeManager.CheckStructCycles() for each TypeContainer.
19519 [Note: We only need to visit each type once.]
19521 2004-04-28 Martin Baulig <martin@ximian.com>
19523 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
19525 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
19526 success and added `out object value'. Use a `bool resolved' field
19527 to check whether we've already been called rather than
19528 `ConstantValue != null' since this breaks for NullLiterals.
19530 2004-04-28 Raja R Harinath <rharinath@novell.com>
19532 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
19533 setting of this flag, since the 'set' method may be non-public.
19535 2004-04-28 Raja R Harinath <rharinath@novell.com>
19537 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
19538 check on current_vector.Block.
19540 2004-04-27 Martin Baulig <martin@ximian.com>
19542 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19543 a field initializer. Fixes #56459.
19545 2004-04-27 Martin Baulig <martin@ximian.com>
19547 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19548 we're not attempting to use an indexer. Fixes #52154.
19550 2004-04-27 Martin Baulig <martin@ximian.com>
19552 * statement.cs (Return): Don't create a return label if we don't
19553 need it; reverts my change from January 20th. Thanks to Ben
19556 2004-04-27 Martin Baulig <martin@ximian.com>
19558 According to the spec, `goto' can only leave a nested scope, but
19561 * statement.cs (Block.LookupLabel): Only lookup in the current
19562 block, don't recurse into parent or child blocks.
19563 (Block.AddLabel): Check in parent and child blocks, report
19564 CS0140/CS0158 if we find a duplicate.
19565 (Block): Removed this indexer for label lookups.
19566 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19567 this already does the error reporting for us.
19570 (FlowBranching.UsageVector.Block): New public variable; may be null.
19571 (FlowBranching.CreateSibling): Added `Block' argument.
19572 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19573 label for the target of a `goto' and check whether we're not
19574 leaving a `finally'.
19576 2004-04-27 Martin Baulig <martin@ximian.com>
19578 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19579 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19582 2004-04-27 Martin Baulig <martin@ximian.com>
19584 * statement.cs (Block.AddLabel): Also check for implicit blocks
19585 and added a CS0158 check.
19587 2004-04-27 Martin Baulig <martin@ximian.com>
19589 * flowanalysis.cs (FlowBranchingLoop): New class.
19590 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19591 UsageVector's instead of an ArrayList.
19592 (FlowBranching.Label): Likewise.
19593 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19594 (FlowBranching.AddBreakVector): New method.
19596 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19598 * attribute.cs: Small regression fix: only convert the type if we
19599 the type is different, fixes System.Drawing build.
19601 2004-04-27 Martin Baulig <martin@ximian.com>
19603 * attribute.cs (Attribute.Resolve): If we have a constant value
19604 for a named field or property, implicity convert it to the correct
19607 2004-04-27 Raja R Harinath <rharinath@novell.com>
19609 * statement.cs (Block.Block): Implicit blocks share
19610 'child_variable_names' fields with parent blocks.
19611 (Block.AddChildVariableNames): Remove.
19612 (Block.AddVariable): Mark variable as "used by a child block" in
19613 every surrounding block.
19614 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19615 been used in a child block, complain about violation of "Invariant
19616 meaning in blocks" rule.
19617 * cs-parser.jay (declare_local_variables): Don't use
19618 AddChildVariableNames.
19619 (foreach_statement): Don't create an implicit block: 'foreach'
19620 introduces a scope.
19622 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19624 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19625 converting from 0L to ulong. Fixes 57522.
19627 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19629 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19630 derived class hides via 'new' keyword field from base class (test-242.cs).
19631 TODO: Handle this in the more general way.
19633 * class.cs (CheckBase): Ditto.
19635 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19637 * decl.cs (caching_flags): New member for storing cached values
19639 (MemberCore.Flags): New enum where bit flags for caching_flags
19641 (MemberCore.cls_compliance): Moved to caching_flags.
19642 (DeclSpace.Created): Moved to caching_flags.
19644 * class.cs: Use caching_flags instead of DeclSpace.Created
19646 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19648 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19649 if we are only a derived class, not a nested class.
19651 * typemanager.cs: Same as above, but do this at the MemberLookup
19652 level (used by field and methods, properties are handled in
19653 PropertyExpr). Allow for the qualified access if we are a nested
19656 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19658 * class.cs: Refactoring.
19659 (IMethodData): New inteface; Holds links to parent members
19660 to avoid member duplication (reduced memory allocation).
19661 (Method): Implemented IMethodData interface.
19662 (PropertyBase): New inner classes for get/set methods.
19663 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19664 (Event): New inner classes for add/remove methods.
19665 (Event.DelegateMethod): Implemented IMethodData interface.
19667 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19668 EmitContext (related to class.cs refactoring).
19670 2004-04-21 Raja R Harinath <rharinath@novell.com>
19672 * delegate.cs (Delegate.VerifyApplicability): If the number of
19673 arguments are the same as the number of parameters, first try to
19674 verify applicability ignoring any 'params' modifier on the last
19678 2004-04-16 Raja R Harinath <rharinath@novell.com>
19680 * class.cs (TypeContainer.AddIndexer): Use
19681 'ExplicitInterfaceName' to determine if interface name was
19682 explicitly specified. 'InterfaceType' is not initialized at this time.
19683 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19684 Indexers array is already in the required order. Initialize
19685 'IndexerName' only if there are normal indexers.
19686 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19687 (TypeContainer.Emit): Emit DefaultMember attribute only if
19688 IndexerName is initialized.
19691 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19693 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19696 2004-04-15 Raja R Harinath <rharinath@novell.com>
19698 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19702 * attribute.cs (Attribute.Resolve): Check for duplicate named
19706 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19708 * iterators.cs (MarkYield): track whether we are in an exception,
19709 and generate code accordingly. Use a temporary value to store the
19710 result for our state.
19712 I had ignored a bit the interaction of try/catch with iterators
19713 since their behavior was not entirely obvious, but now it is
19714 possible to verify that our behavior is the same as MS .NET 2.0
19718 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19720 * iterators.cs: Avoid creating temporaries if there is no work to
19723 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19724 Enumerations, use TypeManager.EnumToUnderlying and call
19727 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19730 (This.Emit): Use EmitContext.EmitThis to emit our
19733 (This.EmitAssign): Ditto.
19735 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19736 codepaths, we will move all the functionality into
19739 (FieldExpr.EmitAssign): Ditto.
19741 This fixes several hidden bugs that I uncovered while doing a code
19742 review of this today.
19744 * codegen.cs (EmitThis): reworked so the semantics are more clear
19745 and also support value types "this" instances.
19747 * iterators.cs: Changed so that for iterators in value types, we
19748 do not pass the value type as a parameter.
19750 Initialization of the enumerator helpers is now done in the caller
19751 instead of passing the parameters to the constructors and having
19752 the constructor set the fields.
19754 The fields have now `assembly' visibility instead of private.
19756 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19758 * expression.cs (Argument.Resolve): Check if fields passed as ref
19759 or out are contained in a MarshalByRefObject.
19761 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19762 another compiler type.
19764 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19766 * class.cs (Indexer.Define): use the new name checking method.
19767 Also, return false on an error.
19768 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19769 (is_identifier_[start/part]_character): make static.
19771 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19773 * expression.cs (Binary.ResolveOperator): Do no append strings
19774 twice: since we can be invoked more than once (array evaluation)
19775 on the same concatenation, take care of this here. Based on a fix
19776 from Ben (bug #56454)
19778 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19780 * codegen.cs: Fix another case where CS1548 must be reported (when
19781 delay-sign isn't specified and no private is available #56564). Fix
19782 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19783 error when MCS is used on the MS runtime and we need to delay-sign
19784 (which seems unsupported by AssemblyBuilder - see #56621).
19786 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19788 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19789 (TypeManager.ComputeNamespaces): Faster implementation for
19792 * compiler.csproj: Updated AssemblyName to mcs.
19794 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19796 * rootcontext.cs: Add new types to the boot resolution.
19798 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19799 MulticastDelegate is not allowed.
19801 * typemanager.cs: Add new types to lookup: System.TypedReference
19804 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19805 check for TypedReference or ArgIterator, they are not allowed.
19807 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19808 makes us properly catch 1510 in some conditions (see bug 56016 for
19811 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19813 * CryptoConvert.cs: update from corlib version
19816 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19818 * class.cs (Indexer.Define): Check indexername declaration
19820 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19822 * attribute.cs (IsClsCompliant): Fixed problem with handling
19823 all three states (compliant, not-compliant, undetected).
19825 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19827 * attribute.cs (Attribute): Location is now public.
19828 (Resolve): Store resolved arguments (pos_values) in attribute class.
19829 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19830 (GetClsCompliantAttributeValue): New method that gets
19831 CLSCompliantAttribute value.
19832 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19833 if exists else null.
19834 (AttributeTester): New class for CLS-Compliant verification routines.
19836 * class.cs (Emit): Add CLS-Compliant verification.
19837 (Method.GetSignatureForError): Implemented.
19838 (Constructor.GetSignatureForError): Implemented
19839 (Constructor.HasCompliantArgs): Returns if constructor has
19840 CLS-Compliant arguments.
19841 (Constructor.Emit): Override.
19842 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19843 is needed to test only parameters.
19844 (FieldBase.GetSignatureForError): Implemented.
19845 (TypeContainer): New member for storing base interfaces.
19846 (TypeContainer.FindMembers): Search in base interfaces too.
19848 * codegen.cs (GetClsComplianceAttribute): New method that gets
19849 assembly or module CLSCompliantAttribute value.
19850 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19852 (ModuleClass.Emit): Add error 3012 test.
19854 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19856 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19857 state for all decl types.
19858 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19859 if CLS-Compliant tests are required.
19860 (IsClsCompliaceRequired): New method. Analyze whether code
19861 must be CLS-Compliant.
19862 (IsExposedFromAssembly): New method. Returns true when MemberCore
19863 is exposed from assembly.
19864 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19865 value or gets cached value.
19866 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19867 is explicitly marked with CLSCompliantAttribute.
19868 (IsIdentifierClsCompliant): New abstract method. This method is
19869 used to testing error 3005.
19870 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19871 for identifier and parameters CLS-Compliant testing.
19872 (VerifyClsCompliance): New method. The main virtual method for
19873 CLS-Compliant verifications.
19874 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19875 null. I don't know why is null (too many public members !).
19876 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19877 and get value of first CLSCompliantAttribute that found.
19879 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19880 (VerifyClsCompliance): Override and add extra tests.
19882 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19883 clscheck- disable CLS-Compliant verification event if assembly is has
19884 CLSCompliantAttribute(true).
19886 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19887 ApllyAttribute is now called in emit section as in the other cases.
19888 Possible future Emit integration.
19889 (IsIdentifierClsCompliant): New override.
19890 (VerifyClsCompliance): New override.
19891 (GetEnumeratorName): Returns full enum name.
19893 * parameter.cs (GetSignatureForError): Implemented.
19895 * report.cs (WarningData): New struct for Warning message information.
19896 (LocationOfPreviousError): New method.
19897 (Warning): New method. Reports warning based on the warning table.
19898 (Error_T): New method. Reports error based on the error table.
19900 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19901 verifications are done here.
19903 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19905 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19906 CLSCompliantAttribute.
19907 (all_imported_types): New member holds all imported types from other
19909 (LoadAllImportedTypes): New method fills static table with exported types
19910 from all referenced assemblies.
19911 (Modules): New property returns all assembly modules.
19913 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19915 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19916 throwing a parser error.
19918 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19919 which removes the hardcoded get_/set_ prefixes for properties, as
19920 IL allows for the properties to be named something else.
19924 * expression.cs: Do not override operand before we know if it is
19925 non-null. Fix 56207
19927 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19929 * typemanager.cs: support for pinned variables.
19931 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19933 * decl.cs, typemanager.cs: Avoid using an arraylist
19934 as a buffer if there is only one result set.
19936 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19938 * expression.cs: Make sure you cant call a static method
19939 with an instance expression, bug #56174.
19941 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19943 * class.cs (IsDuplicateImplementation): Improve error reporting to
19944 flag 663 (method only differs in parameter modifier).
19946 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19947 in preprocessor directives.
19949 * location.cs (LookupFile): Allow for the empty path.
19951 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19952 better approach for some of that patch, but its failing with the
19953 CharSet enumeration. For now try/catch will do.
19955 * typemanager.cs: Do not crash if a struct does not have fields.
19958 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19960 * expression.cs: cs0213, cant fix a fixed expression.
19963 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19965 * cs-parser.jay: detect invalid embeded statements gracefully.
19968 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19970 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19973 the invocation type may not be a subclass of the tye of the item/
19974 The type of the item must be a subclass of the invocation item.
19979 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19981 * attribute.cs: Added methods to get a string and a bool from an
19982 attribute. Required to information from AssemblyKeyFileAttribute,
19983 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19984 * codegen.cs: Modified AssemblyName creation to include support for
19985 strongnames. Catch additional exceptions to report them as CS1548.
19986 * compiler.csproj: Updated include CryptoConvert.cs.
19987 * compiler.csproj.user: Removed file - user specific configuration.
19988 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19989 Mono.Security assembly. The original class is maintained and tested in
19990 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19991 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19992 like CSC 8.0 (C# v2) supports.
19993 * Makefile: Added CryptoConvert.cs to mcs sources.
19994 * rootcontext.cs: Added new options for strongnames.
19996 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19998 * driver.cs: For --expect-error, report error code `2'
19999 if the program compiled with no errors, error code `1' if
20000 it compiled with an error other than the one expected.
20002 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
20004 * compiler.csproj: Updated for Visual Studio .NET 2003.
20005 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
20006 * compiler.sln: Updated for Visual Studio .NET 2003.
20008 2004-03-24 Ravi Pratap M <ravi@ximian.com>
20010 * expression.cs: Fix bug #47234. We basically need to apply the
20011 rule that we prefer the conversion of null to a reference type
20012 when faced with a conversion to 'object' (csc behaviour).
20014 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
20016 * statement.cs: Shorter form for foreach, eliminates
20017 a local variable. r=Martin.
20019 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
20021 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
20022 checks if we can use brtrue/brfalse to test for 0.
20023 * expression.cs: use the above in the test for using brtrue/brfalse.
20024 cleanup code a bit.
20026 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
20028 * expression.cs: Rewrite string concat stuff. Benefits:
20030 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
20031 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
20032 rather than a concat chain.
20034 * typemanager.cs: Add lookups for more concat overloads.
20036 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
20038 * expression.cs: Emit shorter il code for array init.
20055 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
20057 * statement.cs: Before, two switch blocks would be merged if the
20058 total size of the blocks (end_item - begin_item + 1) was less than
20059 two times the combined sizes of the blocks.
20061 Now, it will only merge if after the merge at least half of the
20066 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
20068 * class.cs : csc build fix for GetMethods(). See bug #52503.
20070 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
20072 * expression.cs: Make sure fp comparisons work with NaN.
20073 This fixes bug #54303. Mig approved this patch a long
20074 time ago, but we were not able to test b/c the runtime
20077 2004-03-19 Miguel de Icaza <miguel@ximian.com>
20079 * ecore.cs (TypExpr.GetHashCode): implement this overload.
20081 2004-03-19 Martin Baulig <martin@ximian.com>
20083 * class.cs (MemberCore.IsDuplicateImplementation): Report the
20084 error here and not in our caller.
20086 2004-03-19 Martin Baulig <martin@ximian.com>
20088 * interface.cs: Completely killed this file.
20089 (Interface): We're now a TypeContainer and live in class.cs.
20091 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
20092 argument; we're now also called for interfaces.
20093 (TypeContainer.DefineMembers): Allow this method being called
20095 (TypeContainer.GetMethods): New public method; formerly known as
20096 Interface.GetMethod(). This is used by PendingImplementation.
20097 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
20098 it's now private and non-static.
20099 (Interface): Moved this here; it's now implemented similar to
20101 (Method, Property, Event, Indexer): Added `bool is_interface'
20102 argument to their .ctor's.
20103 (MemberBase.IsInterface): New public field.
20105 * cs-parser.jay: Create normal Method, Property, Event, Indexer
20106 instances instead of InterfaceMethod, InterfaceProperty, etc.
20107 (opt_interface_base): Removed; we now use `opt_class_base' instead.
20108 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
20110 2004-03-19 Martin Baulig <martin@ximian.com>
20112 * class.cs (MethodCore.IsDuplicateImplementation): New private
20113 method which does the CS0111 checking.
20114 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
20115 Use IsDuplicateImplementation().
20117 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
20119 * decl.cs (FindMemberToOverride): New method to find the correct
20120 method or property to override in the base class.
20122 - Make Method/Property use the above method to find the
20123 version in the base class.
20124 - Remove the InheritableMemberSignatureCompare as it is now
20127 This patch makes large code bases much faster to compile, as it is
20128 O(n) rather than O(n^2) to do this validation.
20130 Also, it fixes bug 52458 which is that nested classes are not
20131 taken into account when finding the base class member.
20133 Reviewed/Approved by Martin.
20135 2004-03-17 Marek Safar <marek.safar@seznam.cz>
20137 * interface.cs: In all interface classes removed redundant
20138 member initialization.
20140 2004-03-16 Martin Baulig <martin@ximian.com>
20142 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
20144 2004-03-15 Miguel de Icaza <miguel@ximian.com>
20146 * decl.cs (DefineTypeAndParents): New helper method to define a
20147 type's containers before the type itself is defined; This is a
20148 bug exposed by the recent changes to Windows.Forms when an
20149 implemented interface was defined inside a class that had not been
20152 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
20154 (Check): Loop correctly to report errors modifiers
20155 (UNSAFE was not in the loop, since it was the same as TOP).
20157 * interface.cs: Every interface member now takes a ModFlags,
20158 instead of a "is_new" bool, which we set on the base MemberCore.
20160 Every place where we called "UnsafeOk" in the interface, now we
20161 call the proper member (InterfaceMethod.UnsafeOK) instead to get
20162 the unsafe settings from the member declaration instead of the
20163 container interface.
20165 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
20167 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
20168 `set_indexer_name' to the pending bits (one per type).
20170 We fixed a bug today that was picking the wrong method to
20171 override, since for properties the existing InterfaceMethod code
20172 basically ignored the method name. Now we make sure that the
20173 method name is one of the valid indexer names.
20175 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
20177 * support.cs (SeekableStreamReader): Keep track of stream byte
20178 positions and don't mix them with character offsets to the buffer.
20180 Patch from Gustavo Giráldez
20182 2004-03-15 Marek Safar <marek.safar@seznam.cz>
20184 * interface.cs (InterfaceSetGetBase): Removed double member
20185 initialization, base class does it as well.
20187 2004-03-13 Martin Baulig <martin@ximian.com>
20189 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
20190 when compiling corlib.
20192 2004-03-13 Miguel de Icaza <miguel@ximian.com>
20194 * convert.cs (ExplicitConversion): We were reporting an error on
20195 certain conversions (object_type source to a value type, when the
20196 expression was `null') before we had a chance to pass it through
20197 the user defined conversions.
20199 * driver.cs: Replace / and \ in resource specifications to dots.
20202 * class.cs: Add check for duplicate operators. Fixes 52477
20204 2004-03-11 Miguel de Icaza <miguel@ximian.com>
20206 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
20207 that are in the middle of the statements, not only at the end.
20210 * class.cs (TypeContainer.AddField): No longer set the
20211 `HaveStaticConstructor' flag, now we call it
20212 `UserDefineStaticConstructor' to diferentiate the slightly
20213 semantic difference.
20215 The situation is that we were not adding BeforeFieldInit (from
20216 Modifiers.TypeAttr) to classes that could have it.
20217 BeforeFieldInit should be set to classes that have no static
20222 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
20224 And most importantly Zoltan's comment:
20226 http://bugzilla.ximian.com/show_bug.cgi?id=44229
20228 "I think beforefieldinit means 'it's ok to initialize the type sometime
20229 before its static fields are used', i.e. initialization does not need
20230 to be triggered by the first access to the type. Setting this flag
20231 helps the JIT to compile better code, since it can run the static
20232 constructor at JIT time, and does not need to generate code to call it
20233 (possibly lots of times) at runtime. Unfortunately, mcs does not set
20234 this flag for lots of classes like String.
20236 csc sets this flag if the type does not have an explicit static
20237 constructor. The reasoning seems to be that if there are only static
20238 initalizers for a type, and no static constructor, then the programmer
20239 does not care when this initialization happens, so beforefieldinit
20242 This bug prevents the AOT compiler from being usable, since it
20243 generates so many calls to mono_runtime_class_init that the AOT code
20244 is much slower than the JITted code. The JITted code is faster,
20245 because it does not generate these calls if the vtable is type is
20246 already initialized, which is true in the majority of cases. But the
20247 AOT compiler can't do this."
20249 2004-03-10 Miguel de Icaza <miguel@ximian.com>
20251 * class.cs (MethodData.Emit): Refactor the code so symbolic
20252 information is generated for destructors; For some reasons we
20253 were taking a code path that did not generate symbolic information
20256 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
20258 * class.cs: Create a Constructor.CheckBase method that
20259 takes care of all validation type code. The method
20260 contains some code that was moved from Define.
20262 It also includes new code that checks for duplicate ctors.
20263 This fixes bug #55148.
20265 2004-03-09 Joshua Tauberer <tauberer@for.net>
20267 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
20268 a { ... }-style array creation invokes EmitStaticInitializers
20269 which is not good for reference-type arrays. String, decimal
20270 and now null constants (NullCast) are not counted toward
20271 static initializers.
20273 2004-03-05 Martin Baulig <martin@ximian.com>
20275 * location.cs (SourceFile.HasLineDirective): New public field;
20276 specifies whether the file contains or is referenced by a "#line"
20278 (Location.DefineSymbolDocuments): Ignore source files which
20279 either contain or are referenced by a "#line" directive.
20281 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
20283 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
20284 direct access to our parent, so check the method inline there.
20286 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
20288 * expression.cs (Invocation.EmitCall): Miguel's last commit
20289 caused a regression. If you had:
20294 In Foo the implict this would be null.
20296 2004-02-27 Miguel de Icaza <miguel@ximian.com>
20298 * expression.cs (Invocation.EmitCall): If the method is not
20299 virtual, do not emit a CallVirt to it, use Call.
20301 * typemanager.cs (GetFullNameSignature): Improve the method to
20302 cope with ".ctor" and replace it with the type name.
20304 * class.cs (ConstructorInitializer.Resolve): Now the method takes
20305 as an argument the ConstructorBuilder where it is being defined,
20306 to catch the recursive constructor invocations.
20308 2004-02-26 Miguel de Icaza <miguel@ximian.com>
20310 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
20311 routines to check if a type is an enumerable/enumerator allow
20312 classes that implement the IEnumerable or IEnumerator interfaces.
20314 * class.cs (Property, Operator): Implement IIteratorContainer, and
20315 implement SetYields.
20317 (Property.Define): Do the block swapping for get_methods in the
20318 context of iterators. We need to check if Properties also
20319 include indexers or not.
20321 (Operator): Assign the Block before invoking the
20322 OperatorMethod.Define, so we can trigger the Iterator code
20325 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
20326 Property and Operator classes are not created when we parse the
20327 declarator but until we have the block completed, so we use a
20328 singleton SimpleIteratorContainer.Simple to flag whether the
20329 SetYields has been invoked.
20331 We propagate this setting then to the Property or the Operator to
20332 allow the `yield' to function.
20334 2004-02-25 Marek Safar <marek.safar@seznam.cz>
20336 * codegen.cs: Implemented attribute support for modules.
20337 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
20338 Assembly/Module functionality.
20340 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
20341 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
20342 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
20344 2004-02-16 Marek Safar <marek.safar@seznam.cz>
20346 * interface.cs (FindMembers): The operation is performed on all base
20347 interfaces and not only on the first. It is required for future CLS Compliance patch.
20349 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
20351 * statement.cs, codegen.cs:
20352 This patch deals with patterns such as:
20354 public class List : IEnumerable {
20356 public MyEnumerator GetEnumerator () {
20357 return new MyEnumerator(this);
20360 IEnumerator IEnumerable.GetEnumerator () {
20364 public struct MyEnumerator : IEnumerator {
20369 Before, there were a few things we did wrong:
20370 1) we would emit callvirt on a struct, which is illegal
20371 2) we emited ldarg when we needed to emit ldarga
20372 3) we would mistakenly call the interface methods on an enumerator
20373 type that derived from IEnumerator and was in another assembly. For example:
20375 public class MyEnumerator : IEnumerator
20377 Would have the interface methods called, even if there were public impls of the
20378 method. In a struct, this lead to invalid IL code.
20380 2004-02-11 Marek Safar <marek.safar@seznam.cz>
20382 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
20385 * delegate.cs (Define): Fixed crash when delegate type is undefined.
20387 2004-02-11 Miguel de Icaza <miguel@ximian.com>
20389 * cs-parser.jay: Fix small regression: we were not testing V2
20390 compiler features correctly.
20392 * interface.cs: If the emit context is null, then create one
20394 2004-02-09 Marek Safar <marek.safar@seznam.cz>
20396 * decl.cs (GetSignatureForError): New virtual method to get full name
20397 for error messages.
20399 * attribute.cs (IAttributeSupport): New interface for attribute setting.
20400 Now it is possible to rewrite ApplyAttributes method to be less if/else.
20402 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
20403 Duplicated members and code in these classes has been removed.
20404 Better encapsulation in these classes.
20406 2004-02-07 Miguel de Icaza <miguel@ximian.com>
20408 * assign.cs (Assign.DoResolve): When dealing with compound
20409 assignments, there is a new rule in ECMA C# 2.4 (might have been
20410 there before, but it is documented here) that states that in:
20414 If b is of type int, and the `op' is a shift-operator, then the
20415 above is evaluated as:
20419 * expression.cs (Binary.ResolveOperator): Instead of testing for
20420 int/uint/long/ulong, try to implicitly convert to any of those
20421 types and use that in pointer arithmetic.
20423 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
20424 method to print information for from the type, not from the
20425 null-method we were given.
20427 2004-02-01 Duncan Mak <duncan@ximian.com>
20429 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
20430 parsing for cmd, fixes bug #53694.
20432 2004-02-04 Marek Safar <marek.safar@seznam.cz>
20434 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
20435 in the member name duplication tests. Property and operator name duplication
20436 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
20438 2004-02-03 Marek Safar <marek.safar@seznam.cz>
20440 * interface.cs (PopulateMethod): Fixed crash when interface method
20441 returns not existing type (error test cs0246-3.cs).
20443 2004-02-02 Ravi Pratap M <ravi@ximian.com>
20445 * cs-parser.jay (interface_accessors): Re-write actions to also
20446 store attributes attached to get and set methods. Fix spelling
20449 (inteface_property_declaration): Modify accordingly.
20451 (InterfaceAccessorInfo): New helper class to store information to pass
20452 around between rules that use interface_accessors.
20454 * interface.cs (Emit): Apply attributes on the get and set
20455 accessors of properties and indexers too.
20457 * attribute.cs (ApplyAttributes): Modify accordingly to use the
20458 right MethodBuilder when applying attributes to the get and set accessors.
20460 2004-01-31 Miguel de Icaza <miguel@ximian.com>
20462 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
20464 2004-01-26 Miguel de Icaza <miguel@ximian.com>
20466 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
20468 2004-01-25 Miguel de Icaza <miguel@ximian.com>
20470 * cs-parser.jay: Remove YIELD token, instead use the new grammar
20471 changes that treat `yield' specially when present before `break'
20472 or `return' tokens.
20474 * cs-tokenizer.cs: yield is no longer a keyword.
20476 2004-01-23 Marek Safar <marek.safar@seznam.cz>
20478 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
20479 setting for default constructors.
20480 For default constructors are almost every time set wrong Modifier. The
20481 generated IL code has been alright. But inside mcs this values was
20482 wrong and this was reason why several of my CLS Compliance tests
20485 2004-01-22 Martin Baulig <martin@ximian.com>
20487 * cs-parser.jay (namespace_or_type_name): Return an Expression,
20488 not a QualifiedIdentifier. This is what `type_name_expression'
20489 was previously doing.
20490 (type_name_expression): Removed; the code is now in
20491 `namespace_or_type_name'.
20492 (qualified_identifier): Removed, use `namespace_or_type_name'
20494 (QualifiedIdentifier): Removed this class.
20496 2004-01-22 Martin Baulig <martin@ximian.com>
20498 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
20499 not a string as alias name.
20501 2004-01-21 Miguel de Icaza <miguel@ximian.com>
20503 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
20504 #52730 bug, and instead compute correctly the need to use a
20505 temporary variable when requesting an address based on the
20506 static/instace modified of the field and the constructor.
20508 2004-01-21 Martin Baulig <martin@ximian.com>
20510 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
20511 class and namespace before looking up aliases. Fixes #52517.
20513 2004-01-21 Martin Baulig <martin@ximian.com>
20515 * flowanalysis.cs (UsageVector.Merge): Allow variables being
20516 assinged in a 'try'; fixes exception4.cs.
20518 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20519 * class.cs : Implemented parameter-less constructor for TypeContainer
20521 * decl.cs: Attributes are now stored here. New property OptAttributes
20523 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
20525 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
20527 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20529 * typemanager.cs (CSharpSignature): Now reports also inner class name.
20530 (CSharpSignature): New method for indexer and property signature.
20532 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20534 * pending.cs (IsVirtualFilter): Faster implementation.
20536 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20538 * typemanager.cs: Avoid inclusion of same assembly more than once.
20540 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20542 * cs-parser.jay: Fixed problem where the last assembly attribute
20543 has been applied also to following declaration (class, struct, etc.)
20545 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20547 * class.cs: Added error CS0538, CS0539 reporting.
20548 Fixed crash on Microsoft runtime when field type is void.
20550 * cs-parser.jay: Added error CS0537 reporting.
20552 * pending.cs: Added error CS0535 reporting.
20553 Improved error report for errors CS0536, CS0534.
20555 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20557 Merge a few bits from the Anonymous Method MCS tree.
20559 * statement.cs (ToplevelBlock): New class for toplevel methods,
20560 will hold anonymous methods, lifted variables.
20562 * cs-parser.jay: Create toplevel blocks for delegates and for
20563 regular blocks of code.
20565 2004-01-20 Martin Baulig <martin@ximian.com>
20567 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20568 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20569 and `NeedExplicitReturn'; added `IsLastStatement'.
20570 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20571 have a `ReturnLabel' or we're not unreachable.
20573 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20574 child's reachability; don't just override ours with it. Fixes
20575 #58058 (lluis's example).
20576 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20577 InFinally(), InLoop(), InSwitch() and
20578 BreakCrossesTryCatchBoundary() methods.
20580 * statement.cs (Return): Do all error checking in Resolve().
20581 Unless we are the last statement in a top-level block, always
20582 create a return label and jump to it.
20583 (Break, Continue): Do all error checking in Resolve(); also make
20584 sure we aren't leaving a `finally'.
20585 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20586 statement in a top-level block.
20587 (Block.Flags): Added `IsDestructor'.
20588 (Block.IsDestructor): New public property.
20590 2004-01-20 Martin Baulig <martin@ximian.com>
20592 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20594 2004-01-20 Martin Baulig <martin@ximian.com>
20596 * statement.cs (Statement.ResolveUnreachable): New public method.
20597 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20598 (Block.Resolve): Resolve unreachable statements.
20600 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20602 * expression.cs: We need to fix the case where we do
20603 not have a temp variable here.
20605 * assign.cs: Only expression compound assignments need
20606 temporary variables.
20608 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20610 * flowanalysis.cs: Reduce memory allocation in a few ways:
20611 - A block with no variables should not allocate a bit
20613 - A method with no out parameters does not need any tracking
20614 for assignment of the parameters, so we need not allocate
20617 public readonly Type[] VariableTypes;
20618 public readonly string[] VariableNames;
20619 Are redundant. The data is already stored in the variable
20620 map, so we need not allocate another array for it.
20621 - We need to add alot of checks for if (params | locals) == null
20622 due to the first two changes.
20624 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20626 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20627 implement IMemoryLocation, we store a copy on a local variable and
20628 take the address of it. Patch from Benjamin Jemlich
20630 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20631 to use a special "type_name_expression" rule which reduces the
20632 number of "QualifiedIdentifier" classes created, and instead
20633 directly creates MemberAccess expressions.
20635 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20637 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20638 that fixes #52853. Null literal assignment to ValueType
20640 * class.cs (MethodData.Emit): Instead of checking the name of the
20641 method to determine if its a destructor, create a new derived
20642 class from Method called Destructor, and test for that.
20644 * cs-parser.jay: Create a Destructor object instead of a Method.
20646 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20650 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20652 * expression.cs (Binary.ResolveOperator): Perform an implicit
20653 conversion from MethodGroups to their delegate types on the
20654 Addition operation.
20656 * delegate.cs: Introduce a new class DelegateCreation that is the
20657 base class for `NewDelegate' and `ImplicitDelegateCreation',
20658 factor some code in here.
20660 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20661 conversion from MethodGroups to compatible delegate types.
20663 * ecore.cs (Expression.Resolve): Do not flag error 654
20664 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20665 we allow conversions from MethodGroups to delegate types now.
20667 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20668 assignments in v2 either.
20670 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20672 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20673 static read-only fields in ctors.
20675 Applied patch from Benjamin Jemlich
20677 * expression.cs (UnaryMutator): Avoid leaking local variables.
20679 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20681 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20682 here to return true, as they can be used like this:
20684 (XXX) int.MEMBER ()
20686 Fixed 49836 and all the other dups
20688 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20690 * driver.cs: Implement /win32res and /win32icon.
20692 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20694 * cs-parser.jay: Add a rule to improve error handling for the
20695 common mistake of placing modifiers after the type.
20697 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20699 * cs-parser.jay (interface_event_declaration): Catch
20700 initialization of events on interfaces, and report cs0068
20702 * cs-parser.jay (interface_event_declaration): Catch
20703 initialization of events.
20705 * ecore.cs: Better report missing constructors.
20707 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20708 the error reporting done in the wrong place. Fix.
20710 * expression.cs (Binary.ResolveOperator): Catch the
20711 operator + (E x, E y) error earlier, and later allow for implicit
20712 conversions in operator +/- (E e, U x) from U to the underlying
20715 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20716 52596, if the container class is abstract, the default constructor
20717 is protected otherwise its public (before, we were always public).
20719 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20722 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20723 Jemlich that fixes bug #52597, MCS was generating invalid code for
20724 idisposable structs. Thanks to Ben for following up with this
20727 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20729 * driver.cs: Allow assemblies without code to be generated, fixes
20732 2004-01-07 Nick Drochak <ndrochak@gol.com>
20734 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20736 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20738 * cs-parser.jay: Add rules to improve error reporting if fields or
20739 methods are declared at the namespace level (error 116)
20741 * Add rules to catch event add/remove
20743 2004-01-04 David Sheldon <dave-mono@earth.li>
20745 * expression.cs: Added matching ")" to error message for
20748 2004-01-03 Todd Berman <tberman@gentoo.org>
20750 * ecore.cs, attribute.cs:
20751 Applying fix from #52429.
20753 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20755 * ecore.cs, expression.cs, statement.cs:
20756 Total rewrite of how we handle branching. We
20757 now handle complex boolean expressions with fewer
20758 jumps. As well if (x == 0) no longer emits a ceq.
20760 if (x is Foo) is much faster now, because we generate
20763 Overall, we get a pretty big improvement on our benchmark
20764 tests. The code we generate is smaller and more readable.
20766 I did a full two-stage bootstrap. The patch was reviewed
20767 by Martin and Miguel.
20769 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20771 * cs-parser.jay: Make primary_expression not take a QI.
20772 we dont need this because the member_access rule covers
20773 us here. So we replace the rule with just IDENTIFIER.
20775 This has two good effects. First, we remove a s/r conflict.
20776 Second, we allocate many fewer QualifiedIdentifier objects.
20778 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20780 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20781 set the correct information via SRE. This prevents
20782 hanging on the MS runtime. Fixes #29374.
20784 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20786 * convert.cs: correctly handle conversions to value types
20787 from Enum and ValueType as unboxing conversions.
20789 Fixes bug #52569. Patch by Benjamin Jemlich.
20791 2004-01-02 Ravi Pratap <ravi@ximian.com>
20793 * expression.cs (BetterConversion): Prefer int -> uint
20794 over int -> ulong (csc's behaviour). This fixed bug #52046.
20796 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20798 * decl.cs (MemberCache.FindMembers): now returns a
20801 * typemanager.cs: In general, go with with ^^.
20802 (CopyNewMethods): take an IList.
20803 (RealMemberLookup): Only allocate an arraylist
20804 if we copy from two sets of methods.
20806 This change basically does two things:
20807 1) Fewer array lists allocated due to CopyNewMethods.
20808 2) the explicit cast in MemberList costed ALOT.
20810 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20812 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20813 a hashtable to avoid needless string allocations when an identifier is
20814 used more than once (the common case).
20816 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20818 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20819 is broken, it will not return anything. So, we
20820 have to use the information we have in mcs to
20823 * typemanager.cs: Add a cache for GetInterfaces,
20824 since this will now be used more often (due to ^^)
20826 (GetExplicitInterfaces) New method that gets the
20827 declared, not effective, interfaces on a type
20828 builder (eg, if you have interface IFoo, interface
20829 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20832 This patch makes MCS able to bootstrap itself on
20835 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20837 * expression.cs: Remove the Nop's that Miguel put
20840 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20842 * report.cs, codegen.cs: Give the real stack trace to
20843 the error when an exception is thrown.
20845 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20847 * decl.cs: only allocate hashtables for ifaces if
20850 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20852 * expression.cs: fix the error from cs0121-2.cs
20853 (a parent interface has two child interfaces that
20854 have a function with the same name and 0 params
20855 and the function is called through the parent).
20857 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20859 * class.cs, rootcontext.cs, typmanager.cs: do not
20862 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20864 * codegen.cs: remove stack for the ec flow branching.
20865 It is already a linked list, so no need.
20867 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20869 * Makefile: Allow custom profiler here.
20871 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20873 * typemanager.cs (LookupType):
20874 - Use a static char [], because split takes
20875 a param array for args, so it was allocating
20877 - Do not store true in a hashtable, it boxes.
20879 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20881 * flowanalysis.cs: bytify common enums.
20883 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20885 * modifiers.cs: Add a new set of flags for the
20886 flags allowed on explicit interface impls.
20887 * cs-parser.jay: catch the use of modifiers in
20888 interfaces correctly.
20889 * class.cs: catch private void IFoo.Blah ().
20891 All related to bug #50572.
20893 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20895 * decl.cs: Rewrite the consistant accessability checking.
20896 Accessability is not linear, it must be implemented in
20897 a tableish way. Fixes #49704.
20899 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20901 * expression.cs: Handle negation in a checked context.
20902 We must use subtraction from zero. Fixes #38674.
20904 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20906 * class.cs: Ignore static void main in DLLs.
20907 * rootcontext.cs: Handle the target type here,
20908 since we are have to access it from class.cs
20909 * driver.cs: account for the above.
20911 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20913 * report.cs: Give line numbers and files if available.
20915 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20917 * driver.cs: Implement /addmodule.
20919 * typemanager.cs: Change 'modules' field so it now contains Modules not
20922 2003-12-20 Martin Baulig <martin@ximian.com>
20924 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20925 (FieldBase.IsAssigned): Removed this field.
20926 (FieldBase.SetAssigned): New public method.
20927 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20929 2003-12-20 Martin Baulig <martin@ximian.com>
20931 * expression.cs (LocalVariableReference.DoResolve): Don't set
20932 `vi.Used' if we're called from DoResolveLValue().
20934 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20935 returns the usage vector it just merged into the current one -
20936 pass this one to UsageWarning().
20937 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20938 of the `EmitContext', don't call this recursively on our children.
20940 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20942 * driver.cs: Implement /target:module.
20944 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20946 * support.cs (CharArrayHashtable): New helper class.
20948 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20949 char arrays, not strings, so we can avoid creating a string in
20950 consume_identifier if the identifier is a keyword.
20952 2003-12-16 Martin Baulig <martin@ximian.com>
20954 * statement.cs (LocalInfo.Assigned): Removed this property.
20955 (LocalInfo.Flags): Removed `Assigned'.
20956 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20957 and uses flow analysis.
20958 (Block.UsageWarning): Made this method private.
20959 (Block.Resolve): Call UsageWarning() if appropriate.
20961 * expression.cs (LocalVariableReference.DoResolve): Always set
20962 LocalInfo.Used here.
20964 2003-12-13 Martin Baulig <martin@ximian.com>
20966 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20967 any value here; we're now using flow analysis to figure out
20968 whether a statement/block returns a value.
20970 2003-12-13 Martin Baulig <martin@ximian.com>
20972 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20974 (FlowBranching.MergeFinally): Don't call
20975 `branching.CheckOutParameters()' here, this is called in
20977 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20978 when adding the `finally' vector.
20980 2003-12-13 Martin Baulig <martin@ximian.com>
20983 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20984 actually work and also fix #48962.
20986 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20988 * decl.cs: Do not check System.Object for nested types,
20989 since we know it does not have any. Big bang for buck:
20992 Run 1: 8.35 seconds
20993 Run 2: 8.32 seconds
20994 corlib: 17.99 seconds
20996 Run 1: 8.17 seconds
20997 Run 2: 8.17 seconds
20998 corlib: 17.39 seconds
21000 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
21002 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
21003 time we are returning 0 members, so we save alot here.
21005 2003-12-11 Martin Baulig <martin@ximian.com>
21007 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
21008 `MergeChild()', also just take the `FlowBranching' as argument;
21009 call Merge() on it and return the result.
21010 (FlowBranching.Merge): We don't need to do anything if we just
21013 2003-12-11 Martin Baulig <martin@ximian.com>
21015 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
21016 them in an `ArrayList' to reduce memory usage. Thanks to Ben
21017 Maurer for this idea.
21019 2003-12-11 Martin Baulig <martin@ximian.com>
21021 * flowanalysis.cs (MergeResult): This class is now gone; we now
21022 use the `UsageVector' for this. The reason for this is that if a
21023 branching just has one sibling, we don't need to "merge" them at
21024 all - that's the next step to do.
21025 (FlowBranching.Merge): We now return a `UsageVector' instead of a
21028 2003-12-11 Martin Baulig <martin@ximian.com>
21030 Reworked flow analyis and made it more precise and bug-free. The
21031 most important change is that we're now using a special `Reachability'
21032 class instead of having "magic" meanings of `FlowReturns'. I'll
21033 do some more cleanups and optimizations and also add some more
21034 documentation this week.
21036 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
21037 largely reworked this class.
21038 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
21039 the new `Reachability' class instead of having "magic" values here.
21040 (FlowBranching): We're now using an instance of `Reachability'
21041 instead of having separate `Returns', `Breaks' etc. fields.
21043 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
21044 based on flow analysis; ignore the return value of block.Emit ().
21046 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
21048 * driver.cs typemanager.cs: Find the mono extensions to corlib even
21049 if they are private.
21051 2003-12-09 Martin Baulig <martin@ximian.com>
21053 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
21054 call them directly on the UsageVector.
21056 2003-12-09 Martin Baulig <martin@ximian.com>
21058 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
21059 Changed return type from `FlowReturns' to `Reachability'.
21061 2003-12-09 Martin Baulig <martin@ximian.com>
21063 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
21064 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
21065 `Reachable' fields with a single `Reachability' one.
21067 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21069 * class.cs (FindMembers): Remove foreach's.
21074 Run 1: 8.74 seconds
21075 Run 2: 8.71 seconds
21078 Run 1: 8.64 seconds
21079 Run 2: 8.58 seconds
21082 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21087 This patch does a few things:
21088 1. EmptyStatement is now a singleton, so it is never reallocated.
21089 2. All blah is EmptyStatement constructs have been changed to
21090 blah == EmptyStatement.Value, which is much faster and valid
21091 now that EmptyStatement is a singleton.
21092 3. When resolving a block, rather than allocating a new array for
21093 the non-empty statements, empty statements are replaced with
21094 EmptyStatement.Value
21095 4. Some recursive functions have been made non-recursive.
21096 Mainly the performance impact is from (3), however (1) and (2) are needed for
21097 this to work. (4) does not make a big difference in normal situations, however
21098 it makes the profile look saner.
21103 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
21104 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
21105 Total memory allocated: 56397 KB
21108 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
21109 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
21110 Total memory allocated: 55666 KB
21112 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21114 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
21115 than the hashtable in a hashtable version
21117 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
21118 we always end up concating a string. This results in a huge perf
21119 loss, because many strings have to be tracked by the GC. In this
21120 patch, we first use a hashtable that works with two keys, so that
21121 the strings do not need to be concat'ed.
21125 Run 1: 8.74 seconds
21126 Run 2: 8.71 seconds
21129 Run 1: 8.65 seconds
21130 Run 2: 8.56 seconds
21132 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21134 * Makefile: Add a new target `do-time' that does a quick and simple
21135 profile, leaving easy to parse output.
21137 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
21139 * codegen.cs (Init): Create the dynamic assembly with
21140 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
21142 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
21144 * support.cs: Make the PtrHashtable use only one
21145 instance of its comparer.
21147 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
21149 * typemanager.cs: Fix lookup of GetNamespaces.
21151 2003-11-29 Miguel de Icaza <miguel@ximian.com>
21153 * expression.cs: Removed redundant line.
21155 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
21156 ArrayLists, use for loops with bounds.
21158 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
21161 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
21162 arraylists, use for loop with bounds.
21164 The above three changes give us a 0.071 second performance
21165 improvement out of 3.294 seconds down to 3.223. On my machine
21166 the above changes reduced the memory usage by 1,387 KB during
21167 compiler bootstrap.
21169 * cs-parser.jay (QualifiedIdentifier): New class used to represent
21170 QualifiedIdentifiers. Before we created a new string through
21171 concatenation, and mostly later on, the result would be
21172 manipulated by DecomposeQI through string manipulation.
21174 This reduced the compiler memory usage for bootstrapping from
21175 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
21176 compile times in 0.05 seconds.
21178 2003-11-28 Dick Porter <dick@ximian.com>
21180 * support.cs: Do string compares with the Invariant culture.
21188 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
21189 the comparison is done with the Invariant culture.
21191 2003-11-27 Miguel de Icaza <miguel@ximian.com>
21193 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
21194 GetEnumerator method.
21196 (ProbeCollectionType): Iterate starting at the most specific type
21197 upwards looking for a GetEnumerator
21199 * expression.cs: Shift count can be up to 31 for int/uint and 63
21202 2003-11-26 Miguel de Icaza <miguel@ximian.com>
21204 * statement.cs (Block.LookupLabel): Also look for the label on the
21205 children blocks. Use a hash table to keep track of visited
21208 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
21209 we actually did transform the other operand, otherwise fall back
21210 to the common codepath that casts to long.
21212 * cs-tokenizer.cs: Use the same code pattern as the int case.
21213 Maybe I should do the parsing myself, and avoid depending on the
21214 Parse routines to get this done.
21216 2003-11-25 Miguel de Icaza <miguel@ximian.com>
21218 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21219 which fixes bug 51347. This time test it.
21221 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
21222 attributes for example can not tell the difference between these.
21223 The difference was only a syntax feature of the language.
21225 * attribute.cs: Apply attributes to delegates.
21227 * delegate.cs: Call the apply attributes method.
21229 2003-11-24 Miguel de Icaza <miguel@ximian.com>
21231 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
21232 comparing 0 vs Byte.MinValue, not the value
21234 (ImplicitConversionRequired): When reporting a conversion error,
21235 use error 31 to print out the constant error instead of the
21238 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21239 which fixes bug 51347.
21241 2003-11-22 Miguel de Icaza <miguel@ximian.com>
21243 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
21244 which fixes the -warnaserror command line option.
21246 2003-11-21 Miguel de Icaza <miguel@ximian.com>
21248 * cfold.cs (DoNumericPromotions): During constant folding of
21249 additions on UIntConstant, special case intconstants with
21250 IntConstants like we do on the expression binary operator.
21252 2003-11-12 Miguel de Icaza <miguel@ximian.com>
21254 * convert.cs (ImplicitReferenceConversion): We were missing a case
21255 (System.Enum are not value types or class types, so we need to
21256 classify them separatedly).
21258 * driver.cs: We do not support error 2007.
21260 2003-11-12 Jackson Harper <jackson@ximian.com>
21262 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
21263 system directory. Also use the full file name so users can
21264 libraries names mscorlib-o-tron.dll in a non system dir.
21266 2003-11-10 Martin Baulig <martin@ximian.com>
21268 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
21269 (TypeManager.InitCoreTypes): Initialize them here, but instead of
21270 calling `ResolveType()' on them, directly assign their `Type'.
21272 2003-11-08 Martin Baulig <martin@ximian.com>
21274 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
21275 return value and the `out parent' parameter.
21276 (TypeContainer.DefineType): Moved the CS0644 check into
21277 GetClassBases(). Don't pass the interface types to the
21278 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
21279 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
21281 * ecore.cs (TypeExpr.IsAttribute): New property.
21282 (TypeExpr.GetInterfaces): New method.
21284 * interface.cs (Interface.GetInterfaceTypeByName): Return a
21285 TypeExpr instead of a Type.
21286 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
21287 (Interface.DefineType): Don't pass the interface types to the
21288 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
21289 them later and then call `TypeBulider.AddInterfaceImplementation()'.
21291 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
21292 instead of a `Type[]'.
21293 (TypeManager.RegisterBuilder): Likewise.
21294 (TypeManager.AddUserInterface): Likewise.
21295 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
21296 `Type[]' and also return a `TypeExpr[]'.
21297 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
21299 2003-11-08 Martin Baulig <martin@ximian.com>
21301 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
21304 2003-11-08 Martin Baulig <martin@ximian.com>
21306 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
21307 TypeManager.ResolveExpressionTypes().
21309 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
21310 instead of an Expression.
21311 (TypeExpr): This is now an abstract base class for `TypeExpression'.
21312 (TypeExpression): New public class; formerly known as `TypeExpr'.
21314 * expression.cs (ComposedCast): Derive from TypeExpr.
21316 * typemanager.cs (TypeManager.system_*_expr): These are now
21317 TypExpr's instead of Expression's.
21318 (TypeManager.ResolveExpressionTypes): New public static function;
21319 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
21322 2003-11-06 Miguel de Icaza <miguel@ximian.com>
21324 * expression.cs (New.DoResolve): Do not dereference value that
21325 might be a null return.
21327 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
21328 sure that the constant value has the right type. Fixes an
21329 unreported bug, similar to 50425.
21331 * const.cs (Const.LookupConstantValue): Call
21332 ImplicitStandardConversionExists before doing a conversion to
21333 avoid havng the TypeManager.ChangeType do conversions.
21335 Reduced the number of casts used
21337 (Const.ChangeType): New routine to enable reuse of the constant
21338 type changing code from statement.
21340 * typemanager.cs (ChangeType): Move common initialization to
21341 static global variables.
21345 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
21346 every value type to go through, even if it was void. Fix that.
21348 * cs-tokenizer.cs: Use is_identifier_start_character on the start
21349 character of the define, and the is_identifier_part_character for
21350 the rest of the string.
21352 2003-11-05 Miguel de Icaza <miguel@ximian.com>
21354 * expression.cs (UnaryMutator.EmitCode): When I updated
21355 LocalVariableReference.DoResolve, I overdid it, and dropped an
21356 optimization done on local variable references.
21358 2003-11-04 Miguel de Icaza <miguel@ximian.com>
21360 * ecore.cs: Convert the return from Ldlen into an int.
21362 2003-10-20 Miguel de Icaza <miguel@ximian.com>
21364 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
21365 the accessibility, this is a special case for toplevel non-public
21366 classes (internal for instance).
21368 2003-10-20 Nick Drochak <ndrochak@gol.com>
21370 * ecore.cs: Fix typo and build. Needed another right paren.
21372 2003-10-19 Miguel de Icaza <miguel@ximian.com>
21374 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
21375 `internal' case regular and protected, but not allowing protected
21376 to be evaluated later. Bug 49840
21378 2003-10-15 Miguel de Icaza <miguel@ximian.com>
21380 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
21381 to kb.Nlast, and not the kb.nFirst to isolate the switch
21384 Extract the underlying type, so enumerations of long/ulong are
21385 treated like long/ulong.
21387 2003-10-14 Miguel de Icaza <miguel@ximian.com>
21389 * expression.cs (New): Overload the meaning of RequestedType to
21390 track the possible creation of the NewDelegate type, since
21391 DoResolve is invoked more than once for new constructors on field
21394 See bugs: #48800 and #37014
21396 * cs-parser.jay (declare_local_constants): Take an arraylist
21397 instead of a single constant.
21399 (local_constant_declaration): It should take a
21400 constant_declarators, not a constant_declarator. Fixes 49487
21402 * convert.cs: Fix error report.
21404 2003-10-13 Jackson Harper <jackson@ximian.com>
21406 * typemanager.cs (TypeToCoreType): Add float and double this fixes
21409 2003-10-09 Martin Baulig <martin@ximian.com>
21411 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
21413 (MethodCore.DoDefineParameters): Removed the TypeContainer
21414 argument; use the DeclSpace which was passed to the .ctor instead.
21415 (MethodCore.CheckParameter): Take a DeclSpace instead of a
21416 TypeContainer; we only need a DeclSpace here.
21418 2003-10-09 Martin Baulig <martin@ximian.com>
21420 * class.cs (MethodData): Added additional `DeclSpace ds' argument
21422 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
21423 EmitContext's .ctor.
21425 2003-10-09 Martin Baulig <martin@ximian.com>
21427 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
21428 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
21429 AsAccessible(), moved them as well.
21431 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
21433 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
21435 * cs-parser.jay : Renamed yyName to yyNames related to jay.
21437 2003-10-07 Miguel de Icaza <miguel@ximian.com>
21439 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
21440 generation for >=, as spotted by Paolo, bug 48679.
21441 Patch from David Waite.
21443 * cs-tokenizer.cs: Add handling for #pragma.
21445 * cs-parser.jay: Allow for both yield and yield return in the
21446 syntax. The anti-cobolization of C# fight will go on!
21448 * class.cs (TypeBuilder.DefineType): Catch error condition here
21449 (Parent.DefineType erroring out and returning null).
21451 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21452 coping with enumerations variables, we were mistakenly processing
21453 them as a regular value type instead of built-in types. Fixes the
21456 * typemanager.cs (IsBuiltinOrEnum): New method.
21458 2003-09-30 Miguel de Icaza <miguel@ximian.com>
21460 * cs-parser.jay: Upgrade: yield now needs the return clause.
21462 2003-09-19 Martin Baulig <martin@ximian.com>
21464 * decl.cs (MemberCache.SetupCacheForInterface): Take a
21465 `MemberCache parent' argument. Normally, an interface doesn't
21466 have a parent type except System.Object, but we use this in gmcs
21467 for generic type parameters.
21469 2003-09-18 Martin Baulig <martin@ximian.com>
21471 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
21472 on `type.IsInterface'; don't check whether the type has a parent
21473 to determine whether it's an interface.
21475 2003-09-15 Martin Baulig <martin@ximian.com>
21477 * class.cs (TypeContainer.DefineType): Added an error flag to
21478 avoid reporting duplicate CS0146's ("class definition is
21481 * driver.cs (Driver.MainDriver): Abort if
21482 RootContext.ResolveTree() reported any errors.
21484 2003-09-07 Martin Baulig <martin@ximian.com>
21486 * report.cs (Error, Warning): Added overloaded versions which take
21487 a `params object[] args' and call String.Format().
21489 2003-09-07 Martin Baulig <martin@ximian.com>
21491 * decl.cs (DeclSpace..ctor): Don't call
21492 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
21493 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
21494 (DeclSpace.RecordDecl): New method.
21496 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
21498 2003-09-02 Ravi Pratap <ravi@ximian.com>
21500 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
21501 value attributes to be applied to ParameterBuilders.
21503 * class.cs (MethodCore.LabelParameters): Make static and more
21504 generic so that it can be used from other places - like interface
21505 methods, for instance.
21507 * interface.cs (Interface.Emit): Call LabelParameters before
21508 emitting attributes on the InterfaceMethod.
21510 2003-08-26 Martin Baulig <martin@ximian.com>
21512 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
21513 resolving aliases; fixes #47927.
21515 2003-08-26 Martin Baulig <martin@ximian.com>
21517 * statement.cs (Using.DoResolve): This is internally emitting a
21518 try/finally clause, so we need to set ec.NeedExplicitReturn if we
21519 do not always return. Fixes #47681.
21521 2003-08-26 Martin Baulig <martin@ximian.com>
21523 * decl.cs (MemberCore): Moved WarningNotHiding(),
21524 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
21526 (AdditionResult): Make this nested in DeclSpace.
21527 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
21528 argument; call NamespaceEntry.Define() unless we're nested in a
21531 * namespace.cs (Namespace.DefineName): New public function. This
21532 is called from DeclSpace's .ctor to add
21533 (Namespace.Lookup): Include DeclSpaces in the lookup.
21535 * class.cs (Operator): Derive from MemberBase, not MemberCore.
21537 * const.cs (Const): Derive from MemberBase, not MemberCore.
21539 2003-08-25 Martin Baulig <martin@ximian.com>
21541 * convert.cs (Convert.ExplicitReferenceConversion): When
21542 converting from an interface type to a class, unbox if the target
21543 type is a struct type. Fixes #47822.
21545 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21547 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21550 2003-08-22 Martin Baulig <martin@ximian.com>
21552 * class.cs (TypeManager.DefineType): When defining a nested type,
21553 call DefineType() on our parent; fixes #47801.
21555 2003-08-22 Martin Baulig <martin@ximian.com>
21557 * class.cs (MethodData.Define): While checking if a method is an
21558 interface implementation, improve the test a bit more to fix #47654.
21560 2003-08-22 Martin Baulig <martin@ximian.com>
21562 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21563 correctly; fixes #47722.
21565 2003-08-22 Martin Baulig <martin@ximian.com>
21567 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21568 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21570 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21572 2003-08-22 Martin Baulig <martin@ximian.com>
21574 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21575 can only be assigned in static constructors. Fixes #47161.
21577 2003-08-22 Martin Baulig <martin@ximian.com>
21579 Rewrote and improved the flow analysis code.
21581 * flowbranching.cs (FlowBranching): Make this class abstract.
21582 (FlowBranching.CreateBranching): New static function to create a
21583 new flow branching.
21584 (FlowBranchingBlock, FlowBranchingException): New classes.
21585 (FlowBranching.UsageVector.Type): New public readonly field.
21586 (FlowBranching.UsageVector.Breaks): Removed the setter.
21587 (FlowBranching.UsageVector.Returns): Removed the setter.
21588 (FlowBranching.UsageVector): Added Break(), Return(),
21589 NeverReachable() and Throw() methods to modify the reachability.
21590 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21591 done by FlowBranching.Merge().
21592 (FlowBranching.UsageVector.MergeChild): New method; merges the
21593 merge result into the current vector.
21594 (FlowBranching.Merge): New abstract method to merge a branching.
21596 2003-08-12 Martin Baulig <martin@ximian.com>
21598 * expression.cs (Indirection.CacheTemporaries): Create the
21599 LocalTemporary with the pointer type, not its element type.
21601 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21603 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21604 token was a keyword or not.
21606 Add `error' options where an IDENTIFIER was expected; Provide
21607 CheckToken and CheckIdentifierToken convenience error reporting
21610 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21612 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21613 NameSpaceEntry NameSpaceEntry.
21615 (LookupInterfaceOrClass): Avoid creating a full qualified name
21616 from namespace and name: avoid doing lookups when we know the
21617 namespace is non-existant. Use new Tree.LookupByNamespace which
21618 looks up DeclSpaces based on their namespace, name pair.
21620 * driver.cs: Provide a new `parser verbose' to display the
21621 exception thrown during parsing. This is turned off by default
21622 now, so the output of a failure from mcs is more graceful.
21624 * namespace.cs: Track all the namespaces defined in a hashtable
21627 (IsNamespace): New method
21629 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21631 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21632 we know that we need to concatenate (full typename can never be
21637 * statement.cs: Use a bitfield; Do not initialize to null things
21638 which are done by the constructor by default.
21640 * cs-parser.jay: bug fix, parameter was 4, not 3.
21642 * expression.cs: Just use the property;
21644 * statement.cs: No need for GetVariableInfo method.
21646 2003-08-08 Martin Baulig <martin@ximian.com>
21648 * flowanalysis.cs (FlowReturns): This is now nested in the
21649 `FlowBranching' class.
21650 (MyBitVector): Moved this here from statement.cs.
21651 (FlowBranching.SiblingType): New enum type.
21652 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21654 2003-08-07 Martin Baulig <martin@ximian.com>
21656 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21657 `FlowBranching' class and called `BranchingType'.
21659 2003-08-07 Martin Baulig <martin@ximian.com>
21661 * flowanalysis.cs: Moved all the control flow analysis code into
21664 2003-08-07 Martin Baulig <martin@ximian.com>
21666 * assign.cs (Assign.DoResolve): `target' must either be an
21667 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21670 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21672 * expression.cs (BinaryMethod): This kind of expression is created by the
21673 Binary class if it determines that the operator has to be handled
21676 (BinaryDelegate): This kind of expression is created if we are
21677 dealing with a + or - operator on delegates.
21679 (Binary): remove method, argumetns, and DelegateOperator: when
21680 dealing with methods,
21682 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21684 * statement.cs (Block): use bitfields for the three extra booleans
21685 we had in use. Remove unused topblock parameter.
21687 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21689 * assign.cs: Drop extra unneeded tests.
21691 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21693 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21695 * statement.cs (Foreach): Use VariableStorage instead of
21698 * codegen.cs (VariableStorage): New class used by clients that
21699 require a variable stored: locals or fields for variables that
21700 need to live across yield.
21702 Maybe provide a convenience api for EmitThis+EmitLoad?
21704 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21707 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21709 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21710 RemapParameterLValue): New methods that are used to turn a
21711 precomputed FieldInfo into an expression like this:
21715 The idea is to use this instead of making LocalVariableReference
21716 have more than one meaning.
21718 * cs-parser.jay: Add error production to BASE.
21720 * ecore.cs: Deal with TypeManager.GetField returning null, which
21721 is now a valid return value.
21723 (FieldExprNoAddress): New expression for Fields whose address can
21726 * expression.cs (LocalVariableReference): During the resolve
21727 phases, create new expressions if we are in a remapping context.
21728 Remove code that dealt with remapping here.
21730 (ParameterReference): same.
21732 (ProxyInstance): New expression, like the `This' expression, but
21733 it is born fully resolved. We know what we are doing, so remove
21734 the errors that are targeted to user-provided uses of `this'.
21736 * statement.cs (Foreach): our variable is now stored as an
21737 Expression; During resolution, follow the protocol, dont just
21738 assume it will return this.
21740 2003-08-06 Martin Baulig <martin@ximian.com>
21742 * support.cs (SeekableStreamReader.cs): New public class.
21744 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21745 SeekableStreamReader instead of the normal StreamReader.
21747 2003-08-04 Martin Baulig <martin@ximian.com>
21749 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21750 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21751 deambiguate casts and delegate invocations.
21752 (parenthesized_expression): Use the new tokens to ensure this is
21753 not a cast of method invocation.
21755 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21756 when reading a `)' and Deambiguate_CloseParens () was previously
21759 * expression.cs (ParenthesizedExpression): New class. This is
21760 just used for the CS0075 test.
21761 (Binary.DoResolve): Check for CS0075.
21763 2003-07-29 Ravi Pratap <ravi@ximian.com>
21765 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21766 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21767 reference comparison.
21769 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21770 examine the ReturnType for equality - this is necessary in the
21771 cases of implicit and explicit operators whose signature also
21772 includes the return type.
21774 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21776 * namespace.cs: Cache the result of the namespace computation,
21777 instead of computing it every time.
21779 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21781 * decl.cs: Use a global arraylist that we reuse over invocations
21782 to avoid excesive memory consumption. Reduces memory usage on an
21783 mcs compile by one meg (45 average).
21785 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21786 private, work around that.
21788 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21790 * literal.cs (IntLiteral): Define Zero and One static literals.
21792 * cs-parser.jay (integer_literal): use static literals to reduce
21793 memory usage for the most used literals (0, 1 and -1). 211kb
21794 reduced in memory usage.
21796 Replace all calls to `new ArrayList' with `new
21797 ArrayList(4)' which is a good average number for most allocations,
21798 and also requires only 16 bytes of memory for its buffer by
21801 This reduced MCS memory usage in seven megabytes for the RSS after
21804 2003-07-28 Ravi Pratap <ravi@ximian.com>
21806 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21807 handle params methods the correct way by forming only one
21808 applicable set with params and normal methods in them. Earlier we
21809 were looking at params methods only if we found no normal methods
21810 which was not the correct thing to do.
21812 (Invocation.BetterFunction): Take separate arguments indicating
21813 when candidate and the best method are params methods in their
21816 This fixes bugs #43367 and #46199.
21818 * attribute.cs: Documentation updates.
21820 (CheckAttribute): Rename to CheckAttributeTarget.
21821 (GetValidPlaces): Rename to GetValidTargets.
21823 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21824 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21828 2003-07-28 Martin Baulig <martin@ximian.com>
21830 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21831 name when looking up the base class of a nested class. Fixes #46977.
21833 2003-07-26 Martin Baulig <martin@ximian.com>
21835 * expression.cs (Indexers.Indexer): New nested struct; contains
21836 getter, setter and the indexer's type.
21837 (Indexers.Properties): This is now an ArrayList of
21838 Indexers.Indexer's.
21839 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21840 indexer doesn't have any getters.
21842 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21843 for embedded property and indexer assignments.
21845 2003-07-26 Martin Baulig <martin@ximian.com>
21847 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21848 preprocessor directive is not the first non-whitespace character
21851 2003-07-26 Martin Baulig <martin@ximian.com>
21853 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21854 namespace parsing, follow the spec more closely.
21856 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21857 NamespaceEntry.Lookup().
21859 2003-07-25 Martin Baulig <martin@ximian.com>
21861 * MethodCore.cs (OverridesSomething): New public field; it's set
21862 from TypeContainer.DefineMembers if this method overrides
21863 something (which doesn't need to be a method). Fix #39462.
21865 2003-07-25 Ravi Pratap <ravi@ximian.com>
21867 * typemanager.cs (GetMembers): Ensure that the list of members is
21868 reversed. This keeps things in sync.
21870 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21871 find an AttributeUsage attribute.
21873 * expression.cs (Invocation.OverloadResolve): Perform the check
21874 which disallows Invoke to be directly called on a Delegate.
21876 (Error_InvokeOnDelegate): Report error cs1533.
21878 2003-07-25 Martin Baulig <martin@ximian.com>
21880 * expression.cs (Indexers.GetIndexersForType): Only look in the
21881 interface hierarchy if the requested type is already an
21882 interface. Fixes #46788 while keeping #46502 fixed.
21884 2003-07-25 Martin Baulig <martin@ximian.com>
21886 * class.cs (TypeContainer.DefineMembers): Check whether all
21887 readonly fields have been assigned and report warning CS0649 if
21890 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21893 2003-07-24 Ravi Pratap <ravi@ximian.com>
21895 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21896 returned from GetMethods to make things consistent with the
21897 assumptions MCS makes about ordering of methods.
21899 This should comprehensively fix bug #45127 and it does :-)
21901 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21902 ordering is actually reverse.
21904 * Clean up some debug messages I left lying around.
21906 * interface.cs (Populate*): Get rid of code which emits attributes
21907 since the stage in which we emit attributes is the 'Emit' stage,
21908 not the define stage.
21910 (Emit): Move attribute emission for interface members here.
21912 2003-07-22 Ravi Pratap <ravi@ximian.com>
21914 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21915 closely: we eliminate methods in base types when we have an
21916 applicable method in a top-level type.
21918 Please see section 14.5.5.1 for an exact description of what goes
21921 This fixes bug #45127 and a host of other related to corlib compilation.
21923 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21924 array is the method corresponding to the top-level type (this is
21925 because of the changes made to icall.c) so we change this
21928 (MethodGroupExpr.Name): This too.
21930 * typemanager.cs (GetElementType): New method which does the right
21931 thing when compiling corlib.
21933 * everywhere: Make use of the above in the relevant places.
21935 2003-07-22 Martin Baulig <martin@ximian.com>
21937 * cs-parser.jay (invocation_expression): Moved
21938 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21939 `cast_expression', but create a InvocationOrCast which later
21940 resolves to either an Invocation or a Cast.
21942 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21943 method; call this before EmitStatement() to make sure that this
21944 expression can be used as a statement.
21946 * expression.cs (InvocationOrCast): New class; resolves to either
21947 an Invocation or a Cast.
21949 * statement.cs (StatementExpression): Call ResolveStatement() on
21950 the ExpressionStatement before emitting it.
21952 2003-07-21 Martin Baulig <martin@ximian.com>
21954 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21955 `ref' and `out' attributes match; fixes #46220.
21956 (MemberAccess.ResolveMemberAccess): You can't reference a type
21957 through an expression; fixes #33180.
21958 (Indexers.GetIndexersForType): Don't return the indexers from
21959 interfaces the class implements; fixes #46502.
21961 2003-07-21 Martin Baulig <martin@ximian.com>
21963 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21964 CS0661 checks; fixes bug #30442.
21966 2003-07-21 Martin Baulig <martin@ximian.com>
21968 * decl.cs (AdditionResult): Added `Error'.
21970 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21972 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21973 makes cs0031.cs actually work.
21975 2003-07-20 Martin Baulig <martin@ximian.com>
21977 * namespace.cs: Fixed that bug which caused a crash when compiling
21978 the debugger's GUI.
21980 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21982 * typemanager.cs (LookupTypeReflection): Never expose types which
21983 are NotPublic, NestedPrivate, NestedAssembly, or
21984 NestedFamANDAssem. We used to return these, and later do a check
21985 that would report a meaningful error, but the problem is that we
21986 would not get the real match, if there was a name override.
21988 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21990 * namespace.cs (Namespace, Name): Do not compute the namespace
21991 name dynamically, compute it in the constructor. This reduced
21992 memory usage by 1697 KB.
21994 * driver.cs: Use --pause to pause at the end.
21996 2003-07-17 Peter Williams <peter@newton.cx>
21998 * Makefile: Change the name of the test target so that it doesn't
21999 conflict with the recursive test target.
22001 2003-07-17 Miguel de Icaza <miguel@ximian.com>
22003 * expression.cs (LocalVariableReference.Emit, EmitAssign,
22004 AddressOf): Do not use EmitThis, that was wrong, use the actual
22007 2003-07-15 Miguel de Icaza <miguel@ximian.com>
22009 * class.cs (MethodData.Define): While checking if a method is an
22010 interface implementation, improve the test: If we are not public
22011 (use new test here: use the computed MethodAttributes directly,
22012 instead of the parsed modifier flags) check if the `implementing'
22013 method comes from an interface or not.
22015 * pending.cs (VerifyPendingMethods): Slightly better error
22018 * makefile: add test target that does the mcs bootstrap.
22020 2003-07-16 Ravi Pratap <ravi@ximian.com>
22022 * interface.cs (Define): Do nothing here since there are no
22023 members to populate etc. Move the attribute emission out of here
22024 since this was just totally the wrong place to put it. Attribute
22025 application happens during the 'Emit' phase, not in the 'Define'
22028 (Emit): Add this method and move the attribute emission here
22030 * rootcontext.cs (EmitCode): Call the Emit method on interface
22033 2003-07-14 Ravi Pratap M <ravi@ximian.com>
22035 * expression.cs (OverloadResolve): Report error only if Location
22036 is not 'Null' which means that there was a probe going on.
22038 2003-07-14 Martin Baulig <martin@ximian.com>
22040 * expression.cs (ConditionalLogicalOperator): New public class to
22041 implement user defined conditional logical operators.
22042 This is section 14.11.2 in the spec and bug #40505.
22044 2003-07-14 Martin Baulig <martin@ximian.com>
22046 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
22048 2003-07-14 Martin Baulig <martin@ximian.com>
22050 * codegen.cs (EmitContext.InFixedInitializer): New public field.
22052 * ecore.cs (IVariable.VerifyFixed): New interface method.
22054 * expression.cs (Unary.ResolveOperator): When resolving the `&'
22055 operator, check whether the variable is actually fixed. Fixes bug
22056 #36055. Set a variable definitely assigned when taking its
22057 address as required by the spec.
22059 * statement.cs (LocalInfo.IsFixed): New field.
22060 (LocalInfo.MakePinned): Set `IsFixed' to true.
22062 2003-07-14 Ravi Pratap M <ravi@ximian.com>
22064 * attribute.cs (Attribute.Resolve): While doing a Member lookup
22065 for .ctors, ensure that we only ask for members declared in the
22066 attribute type (BindingFlags.DeclaredOnly).
22070 * expression.cs (Error_WrongNumArguments): Report error 1501
22071 correctly the way CSC does.
22073 2003-07-13 Martin Baulig <martin@ximian.com>
22075 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
22076 lookup on the fully qualified name, to make things like "X.X" work
22077 where "X.X" is a fully qualified type name, but we also have a
22078 namespace "X" in the using list. Fixes #41975.
22080 2003-07-13 Martin Baulig <martin@ximian.com>
22082 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
22083 function. If we're a CompoundAssign, we need to create an embedded
22084 CompoundAssign, not an embedded Assign.
22085 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
22088 2003-07-13 Martin Baulig <martin@ximian.com>
22090 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
22091 work to fix bug #46088.
22093 2003-07-13 Ravi Pratap <ravi@ximian.com>
22095 * class.cs (Operator.Emit): Do not emit attributes here - it is
22096 taken care of by the Method class that we delegate too. This takes
22097 care of bug #45876.
22099 2003-07-10 Martin Baulig <martin@ximian.com>
22101 * expression.cs (TypeOfVoid): New class.
22102 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
22104 2003-07-10 Martin Baulig <martin@ximian.com>
22106 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
22109 2003-07-10 Martin Baulig <martin@ximian.com>
22111 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
22112 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
22114 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
22116 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
22118 2003-07-10 Martin Baulig <martin@ximian.com>
22120 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
22121 of decimal. Fixes #42850.
22123 NOTE: I also fixed the created byte blob, but this doesn't work on
22124 the MS runtime and csc never produces any byte blobs for decimal
22127 2003-07-10 Martin Baulig <martin@ximian.com>
22129 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
22130 structs; fixes #32068.
22131 (Block.AddChildVariableNames): Fixed #44302.
22133 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22135 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
22137 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22139 * attribute.cs: And this test is onger needed.
22141 2003-07-08 Martin Baulig <martin@ximian.com>
22143 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
22144 inaccessible types. Fixes #36313.
22146 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
22148 * namespace.cs (NamespaceEntry): Create implicit entries for all
22149 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
22150 implicit entries for N1.N2 and N1.
22152 2003-07-08 Martin Baulig <martin@ximian.com>
22154 Rewrote the handling of namespaces to fix a lot of the issues
22155 wrt. `using' aliases etc.
22157 * namespace.cs (Namespace): Splitted this class into a
22158 per-assembly `Namespace' and a per-file `NamespaceEntry'.
22160 * typemanager.cs (TypeManager.IsNamespace): Removed.
22161 (TypeManager.ComputeNamespaces): Only compute namespaces from
22162 loaded assemblies here, not the namespaces from the assembly we're
22163 currently compiling.
22165 2003-07-08 Martin Baulig <martin@ximian.com>
22167 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
22169 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22171 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
22174 I thought about the memory savings here, but LookupTypeReflection
22175 is used under already very constrained scenarios. Compiling
22176 corlib or mcs only exposes one hit, so it would not really reduce
22177 any memory consumption.
22179 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22181 * typemanager.cs: fixes bug #45889 by only adding public types from
22182 other assemblies to the list of known types.
22184 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22186 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
22187 on the type we resolved.
22189 2003-07-05 Martin Baulig <martin@ximian.com>
22191 * pending.cs (PendingImplementation.ParentImplements): Don't
22192 create the proxy if the parent is abstract.
22194 * class.cs (TypeContainer.DefineIndexers): Process explicit
22195 interface implementations first. Fixes #37714.
22197 2003-07-04 Miguel de Icaza <miguel@ximian.com>
22199 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
22200 defined recursively; but since we modify the input parameters
22201 (left is set to `this' temporarily), we reset this value if the
22202 left_is_explicit is false, which gives the original semantics to
22205 * literal.cs (NullPointer): new class used to represent a null
22206 literal in a pointer context.
22208 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
22209 type is a pointer, use a NullPointer object instead of a
22210 NullLiteral. Closes 43687
22212 (ExplicitConversion): Convert pointer values using
22213 the conv opcode to the proper type.
22215 * ecore.cs (New): change ValueTypeVariable property into a method,
22216 that returns whether the valuetype is suitable for being used.
22218 * expression.cs (Binary.DoNumericPromotions): Only return if we
22219 the int constant was a valid uint, and we can return both left and
22220 right as uints. If not, we continue processing, to trigger the
22221 type conversion. This fixes 39018.
22223 * statement.cs (Block.EmitMeta): During constant resolution, set
22224 the CurrentBlock property on the emitcontext, so that we resolve
22225 constants propertly.
22227 2003-07-02 Martin Baulig <martin@ximian.com>
22229 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
22230 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
22232 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
22233 than emitting it here.
22235 * statement.cs: Fixed some more flow analysis bugs.
22237 2003-07-02 Martin Baulig <martin@ximian.com>
22239 * class.cs (MethodData.Define): When implementing interface
22240 methods, set Final unless we're Virtual.
22242 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
22243 check work for interface methods.
22245 2003-07-01 Martin Baulig <martin@ximian.com>
22247 * ecore.cs (EmitContext.This): Replaced this property with a
22248 GetThis() method which takes a Location argument. This ensures
22249 that we get the correct error location for a CS0188.
22251 2003-07-01 Miguel de Icaza <miguel@ximian.com>
22253 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
22254 ImplicitStandardConversion.
22256 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
22258 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
22260 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
22263 2003-06-30 Miguel de Icaza <miguel@ximian.com>
22265 * class.cs (Constructor.Define): Turn off initlocals for unsafe
22268 (MethodData.Define): Turn off initlocals for unsafe methods.
22270 2003-06-29 Miguel de Icaza <miguel@ximian.com>
22272 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
22273 complete; Fixes #37521.
22275 * delegate.cs: Use Modifiers.TypeAttr to compute the
22276 TypeAttributes, instead of rolling our own. This makes the flags
22277 correct for the delegates.
22279 2003-06-28 Miguel de Icaza <miguel@ximian.com>
22281 * class.cs (Constructor.Define): Set the private flag for static
22282 constructors as well.
22284 * cs-parser.jay (statement_expression): Set the return value to
22285 null, to avoid a crash when we catch an error.
22287 2003-06-24 Miguel de Icaza <miguel@ximian.com>
22289 * cs-parser.jay: Applied patch from Jackson that adds support for
22290 extern and unsafe modifiers to destructor declarations.
22292 * expression.cs: Report error 21 if the user is trying to index a
22295 * driver.cs: Add an error message, suggested by the bug report.
22297 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
22298 if we do not have a ": this ()" constructor initializer. Fixes 45149
22300 2003-06-14 Miguel de Icaza <miguel@ximian.com>
22302 * namespace.cs: Add some information to reduce FAQs.
22304 2003-06-13 Miguel de Icaza <miguel@ximian.com>
22306 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
22307 underlying enumeration types. Fixes #43915.
22309 * expression.cs: Treat ushort/short as legal values to be used in
22310 bitwise operations.
22312 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
22314 * delegate.cs: transfer custom attributes for paramenters from
22315 the delegate declaration to Invoke and BeginInvoke.
22317 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
22319 * attribute.cs: handle custom marshalers and emit marshal info
22322 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
22324 * makefile.gnu: Added anonymous.cs to the compiler sources.
22326 2003-05-28 Miguel de Icaza <miguel@ximian.com>
22328 * iterators.cs: Change the name of the proxy class to include two
22331 * cs-parser.jay: Update grammar to include anonymous methods.
22333 * anonymous.cs: new file.
22335 2003-05-27 Miguel de Icaza <miguel@ximian.com>
22337 * class.cs (Field.Define): Add missing test for pointers and
22340 2003-05-27 Ravi Pratap <ravi@ximian.com>
22342 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
22343 we use the stobj opcode.
22345 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
22346 since it wasn't the correct fix.
22348 It still is puzzling that we are required to use stobj for IntPtr
22349 which seems to be a ValueType.
22351 2003-05-26 Miguel de Icaza <miguel@ximian.com>
22353 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
22354 during regular simple name resolution. Now, the trick is that
22355 instead of returning for processing the simplename, we do a
22356 TypeManager.LookupType (ie, a rooted lookup as opposed to a
22357 contextual lookup type). If a match is found, return that, if
22358 not, return for further composition.
22360 This fixes long-standing 30485.
22362 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
22363 using the address to initialize an object, do an Stobj instead of
22364 using the regular Stelem.
22366 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
22367 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
22368 Because if we are a BaseIndexerAccess that value will be true.
22371 * statement.cs (GotoCase.Resolve): Return after reporting an
22372 error, do not attempt to continue.
22374 * expression.cs (PointerArithmetic.Emit): If our operand is a
22375 long, convert our constants to match the operand before
22376 multiplying. Convert to I type before adding. Fixes 43670.
22378 2003-05-14 Ravi Pratap <ravi@ximian.com>
22380 * enum.cs (ImplicitConversionExists) : Rename to
22381 ImplicitEnumConversionExists to remove ambiguity.
22383 * ecore.cs (NullCast): New type of cast expression class which
22384 basically is very similar to EmptyCast with the difference being
22385 it still is a constant since it is used only to cast a null to
22387 (eg. (string) null)
22389 * convert.cs (ImplicitReferenceConversion): When casting a null
22390 literal, we return a NullCast.
22392 * literal.cs (NullLiteralTyped): Remove - I don't see why this
22393 should be around anymore.
22395 The renaming (reported was slightly wrong). Corrections:
22397 ConvertImplicitStandard -> ImplicitConversionStandard
22398 ConvertExplicitStandard -> ExplicitConversionStandard
22400 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
22401 before passing them in !
22403 * convert.cs (ImplicitConversionStandard): When comparing for
22404 equal expr and target types, ensure that expr is not a
22407 In general, we must not be checking (expr_type ==
22408 target_type) in the top level conversion methods
22409 (ImplicitConversion, ExplicitConversion etc). This checking is
22410 done in the methods that they delegate to.
22412 2003-05-20 Miguel de Icaza <miguel@ximian.com>
22414 * convert.cs: Move Error_CannotConvertType,
22415 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
22416 ImplicitNumericConversion, ImplicitConversionExists,
22417 ImplicitUserConversionExists, StandardConversionExists,
22418 FindMostEncompassedType, FindMostSpecificSource,
22419 FindMostSpecificTarget, ImplicitUserConversion,
22420 ExplicitUserConversion, GetConversionOperators,
22421 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
22422 TryImplicitIntConversion, Error_CannotConvertImplicit,
22423 ConvertImplicitRequired, ConvertNumericExplicit,
22424 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
22425 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
22428 Perform the following renames:
22430 StandardConversionExists -> ImplicitStandardConversionExists
22431 ConvertImplicit -> ImplicitConversion
22432 ConvertImplicitStandard -> ImplicitStandardConversion
22433 TryImplicitIntConversion -> ImplicitIntConversion
22434 ConvertImplicitRequired -> ImplicitConversionRequired
22435 ConvertNumericExplicit -> ExplicitNumericConversion
22436 ConvertReferenceExplicit -> ExplicitReferenceConversion
22437 ConvertExplicit -> ExplicitConversion
22438 ConvertExplicitStandard -> ExplicitStandardConversion
22440 2003-05-19 Martin Baulig <martin@ximian.com>
22442 * statement.cs (TypeInfo.StructInfo): Made this type protected.
22443 (TypeInfo): Added support for structs having structs as fields.
22445 * ecore.cs (FieldExpr): Implement IVariable.
22446 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
22447 VariableInfo for the field.
22449 2003-05-18 Martin Baulig <martin@ximian.com>
22451 * expression.cs (This.DoResolve): Report a CS0027 if we're
22452 emitting a field initializer.
22454 2003-05-18 Martin Baulig <martin@ximian.com>
22456 * expression.cs (This.ResolveBase): New public function.
22457 (This.DoResolve): Check for CS0188.
22459 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
22462 * ecore.cs (MethodGroupExpr.DoResolve): Set the
22463 `instance_expression' to null if we don't have any non-static
22466 2003-05-18 Martin Baulig <martin@ximian.com>
22468 Reworked the way how local variables and parameters are handled by
22469 the flow analysis code.
22471 * statement.cs (TypeInfo, VariableMap): New public classes.
22472 (VariableInfo): New public class. This is now responsible for
22473 checking whether a variable has been assigned. It is used for
22474 parameters and local variables.
22475 (Block.EmitMeta): Take the InternalParameters as argument; compute
22476 the layout of the flow vectors here.
22477 (Block.LocalMap, Block.ParameterMap): New public properties.
22478 (FlowBranching): The .ctor doesn't get the InternalParameters
22479 anymore since Block.EmitMeta() now computes the layout of the flow
22481 (MyStructInfo): This class is now known as `StructInfo' and nested
22482 in `TypeInfo'; we don't access this directly anymore.
22484 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
22485 property and removed IsAssigned(), IsFieldAssigned(),
22486 SetAssigned() and SetFieldAssigned(); we now call them on the
22487 VariableInfo so we don't need to duplicate this code everywhere.
22489 * expression.cs (ParameterReference): Added `Block block' argument
22491 (LocalVariableReference, ParameterReference, This): The new
22492 VariableInfo class is now responsible for all the definite
22495 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
22496 IsParameterAssigned, SetParameterAssigned): Removed.
22498 2003-05-18 Martin Baulig <martin@ximian.com>
22500 * typemanager.cs (InitCoreTypes): Try calling
22501 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
22502 the 3-args-version. Corlib now also needs our `void_type'.
22503 (GetMethod): Added overloaded version which takes an optional
22504 `bool report_errors' to allow lookups of optional methods.
22506 2003-05-12 Martin Baulig <martin@ximian.com>
22508 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
22509 only used for locals and not for parameters.
22511 2003-05-12 Miguel de Icaza <miguel@ximian.com>
22513 * support.cs (InternalParameters.ParameterType): Return the
22514 ExternalType of the parameter.
22516 * parameter.cs (Parameter.ExternalType): drop the two arguments,
22519 2003-05-11 Miguel de Icaza <miguel@ximian.com>
22521 * class.cs (MethodData.Define): Do not set the `newslot' on
22522 interface members, if they are also flagged as "override".
22524 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
22525 better code for ++i and i++. This only works for static fields
22526 and local variables.
22528 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
22529 want to pull the DeclSpace out of the builder_to_declspace instead
22530 of the TypeBuilder (like in TypeContainer.FindMembers).
22532 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
22533 instead of LookupTypeContainer. Fixes the crash on .NET for
22534 looking up interface members.
22536 * const.cs: Create our own emit context during the Definition
22537 stage, so that constants are evaluated in the proper context, when
22538 a recursive definition happens.
22540 2003-05-11 Martin Baulig <martin@ximian.com>
22542 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22543 new block for a switch section.
22544 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22545 the adding/lookup in the switch block. Fixes #39828.
22547 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22549 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22550 functionality: I needed to convert the data after I had performed
22551 the add/sub operation into the operands type size.
22553 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22554 pass the type for the box operation, otherwise the resulting
22555 object would have been of type object.
22557 (BoxedCast): Add constructor to specify the type to box as.
22559 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22561 * iterators.cs: I was reusing the `count' variable inadvertently,
22562 take steps to not allow this to happen.
22564 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22566 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22567 by creating an array at the point where the params starts and
22568 putting all those arguments there, then adjusting the size of the
22571 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22573 * expression.cs (New.AddressOf): Implement interface
22574 IMemoryLocation. This is used when the `new' operator is used in
22575 the context of an invocation to a method on a value type.
22577 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22580 * namespace.cs: Also check the using aliases here.
22582 * driver.cs: Move the test for using validity after the types have
22583 been entered, so we do a single pass that also includes the using
22586 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22587 in the regular case. CreateSiblingForFinally is doing extra
22590 * attribute.cs (GetAttributeArgumentExpression): Store the result
22591 on an out value, and use the return value to indicate failure
22592 instead of using null (which is a valid return for Constant.GetValue).
22594 * statement.cs: Perform the analysis flow for the increment
22595 portion after the statement, because this will be the real flow of
22596 execution. Fixes #42385
22598 * codegen.cs (EmitContext.EmitArgument,
22599 EmitContext.EmitStoreArgument): New helper functions when the
22600 RemapToProxy flag is set.
22602 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22605 Add support for remapping parameters.
22607 * iterators.cs: Propagate parameter values; Store parameter
22608 values in the proxy classes.
22610 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22612 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22613 need a proxy reference; I do not know what I was thinking
22615 * cs-parser.jay (constructor_initializer): catch another error,
22616 and display nice message.
22618 (field_declaration): catch void field declaration
22619 to flag a better error.
22621 * class.cs (MemberBase.CheckBase): Report an error instead of a
22622 warning if a new protected member is declared in a struct.
22623 (Field.Define): catch the error of readonly/volatile.
22625 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22627 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22628 volatile variable is taken
22630 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22632 * statement.cs (Fixed.Resolve): Report an error if we are not in
22635 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22637 * typemanager.cs: reuse the code that handles type clashes for
22638 delegates and enumerations.
22640 * class.cs (Report28): Always report.
22642 * expression.cs (EncodeAsAttribute): Allow nulls here.
22644 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22646 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22647 the functionality for testing whether an expression is valid for
22648 an attribute here. Also handle the case of arrays of elements
22651 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22652 encoding a linear array into an array of objects that are suitable
22653 to be passed to an CustomAttributeBuilder.
22655 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22657 * ecore.cs: (FieldExpr): Handle field remapping here.
22659 * iteratators.cs: Pass the instance variable (if the method is an
22660 instance method) to the constructors, so we can access the field
22661 variables on the class.
22663 TODO: Test this with structs. I think the THIS variable on
22664 structs might have to be a pointer, and not a refenrece
22666 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22668 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22669 local variables to fields in a proxy class.
22671 * iterators.cs (PopulateProxy): Rename our internal fields to
22673 Create a <THIS> field if we are an instance method, so we can
22674 reference our parent container variables.
22675 (MapVariable): Called back from the EmitContext code to enter a
22676 new variable to field mapping into the proxy class (we just create
22680 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22681 for using the remapped locals to fields.
22683 I placed the code here, because that gives the same semantics to
22684 local variables, and only changes the Emit code.
22686 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22687 statements inside iterators.
22688 (VariableInfo): Add a FieldBuilder for the cases when we are
22689 remapping local variables to fields in a proxy class
22691 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22692 current_block != null.
22694 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22695 not cope with strings, as it has been moved to the
22696 TableSwitchEmit. Fixed bug in switch generation.
22698 * expression.cs (New.DoResolve): Provide more context for the user
22699 when reporting an error.
22701 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22704 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22705 check the permissions for it. Note than in a type-resolution
22706 context the check was already present in DeclSpace.ResolveType,
22707 but was missing from the MemberAccess.
22709 (ArrayCreation.CheckIndices): warn if the user has
22710 more nested levels of expressions, but there are no more
22711 dimensions specified. Avoids crash on bug 41906.
22713 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22715 * statement.cs (Block): replace Implicit bool, for a generic
22717 New flag: `Unchecked'. This is used during the EmitMeta phase
22718 (which is out-of-line with the regular Resolve/Emit process for a
22719 statement, as this is done ahead of time, but still gets a chance
22720 to call constant resolve).
22722 (Block.Flags): new enum for adding a new flag.
22724 (Block.EmitMeta): track the state of unchecked.
22726 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22727 to enable constant resolution to work there as well.
22729 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22731 * typemanager.cs (ienumerable_type): Also look up
22732 System.Collections.IEnumerable.
22734 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22736 TODO: Test more than one conditional per method.
22738 * class.cs (Indexer.Define): Report the location where the user is
22739 referencing the unsupported feature.
22741 (MethodData): Overload the use of `conditionals' to
22742 minimize the creation of needless ArrayLists. This saves roughly
22743 212kb on my machine.
22745 (Method): Implement the new IIteratorContainer interface.
22746 (Method.SetYields): Implement the method by setting the ModFlags
22747 to contain METHOD_YIELDS.
22749 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22750 which just got set to null.
22752 * iterators.cs: New file.
22754 (Yield, YieldBreak): New statements.
22756 * statement.cs (Return.Resolve): Flag an error if we are used in
22757 an iterator method.
22759 * codegen.cs (InIterator): New flag set if the code is being
22760 compiled in an iterator method.
22762 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22763 internal modifier, and we just use it to avoid adding extra
22764 fields, as this is seldom used.
22766 * cs-parser.jay: Add yield_statement (yield and yield break).
22768 * driver.cs: New flag -v2 to turn on version 2 features.
22770 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22771 hashtable when v2 is enabled.
22773 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22775 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22776 there is already a namespace defined with this name.
22778 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22779 people upgraded their corlibs.
22781 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22782 always use fully qualified types, no need to use the compiler
22785 (TypeManager.IsNamespace): Use binarysearch.
22787 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22788 AddDelegate): I did not quite use the new IsValid API properly: I
22789 have to pass the short-name and the fullname. I was passing only
22790 the basename instead of the fullname sometimes.
22792 (TypeContainer.DefineType): call NamespaceClash.
22794 * interface.cs (Interface.DefineType): use NamespaceClash before
22797 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22800 * enum.cs: (Enum.DefineType): use NamespaceClash before
22803 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22804 speed increase. First, use the negative_hits cache when we get a
22805 negative. Second, add the type with its full original name
22806 instead of the new . and + encoded name (reflection uses + to
22807 separate type from a nested type). Use LookupTypeReflection
22808 directly which bypasses the type->name hashtable (that we already
22809 know does not contain the type.
22811 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22812 location/container type.
22814 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22816 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22818 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22820 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22821 method is being referenced in the method group from a static
22822 context, and report error 120 if so.
22824 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22827 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22828 is created, we create the A namespace).
22830 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22833 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22835 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22836 invocation to ModuleBuilder.GetType with the same values will
22837 return a new type instance, so we need to cache its return
22840 * expression.cs (Binary.ResolveOperator): Only allow the compare
22841 operators on enums if they are of the same type.
22843 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22844 types of ValueType on their own case. Before we were giving them
22845 the same treatment as objects.
22847 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22848 fullname. Short name is used to compare against container name.
22849 Fullname is used to check against defined namespace names.
22851 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22852 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22854 (Method.CheckBase): Call parent.
22855 (MemberBase.CheckBase): Check for protected members on sealed
22857 (PropertyBase.CheckBase): Call parent.
22858 (Field.Define): Call parent.
22860 * report.cs: Negative error codes are now mapped to 8000 - code,
22861 so that the display is render more nicely.
22863 * typemanager.cs: Do not use try/catch, instead report a regular
22866 (GetPointerType, GetReferenceType): These methods provide
22867 mechanisms to obtain the T* and T& from a T. We had the code
22868 previously scattered around the code base, and it also used
22869 TypeManager.LookupType that would go through plenty of caches.
22870 This one goes directly to the type source.
22872 In some places we did the Type.GetType followed by
22873 ModuleBuilder.GetType, but not in others, so this unifies the
22874 processing as well.
22876 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22877 statements now that we have namespace information.
22879 * typemanager.cs (IsNamespace): New method, returns whether the
22880 string presented is a namespace or not.
22882 (ComputeNamespaces): New public entry point, computes the list of
22883 available namespaces, using the GetNamespaces API call in Mono, or
22884 the slower version in MS.NET.
22886 Now before we start the semantic analysis phase, we have a
22887 complete list of namespaces including everything that the user has
22890 Deleted old code to cache namespaces in .nsc files.
22892 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22894 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22895 class/struct location definition Location for the implicit
22896 constructor location.
22898 (Operator.Define): Use the location of the operator for the
22899 implicit Method definition.
22901 (Constructor.Emit): use the constructor location for the implicit
22902 base initializer constructor.
22904 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22905 and the Expression class now contains two new methods:
22907 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22908 isolate type lookup from the rest of the resolution process.
22910 Since we use Expressions to hold type definitions due to the way
22911 we parse the input we have historically overloaded Resolve to
22912 perform the Type lookups if a special flag is passed. Now this is
22913 eliminated and two methods take their place.
22915 The differences in the two methods between xStep and xTerminal is
22916 that xStep is involved in our current lookup system that uses
22917 SimpleNames to compose a name, while xTerminal is used just to
22918 catch the case where the simplename lookup failed.
22920 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22922 * expression.cs (ResolveMemberAccess): Remove redundant code.
22923 TypeExpr expressions are always born fully resolved.
22925 * interface.cs (PopulateMethod): Do not lookup the types twice.
22926 We were doing it once during SemanticAnalysis and once during
22929 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22930 in local variable type definitions, were being returned as a
22931 SimpleName (we decomposed everything into a string), that is
22932 because primary_expression was being used instead of a type in the
22933 grammar (reduce/reduce conflicts).
22935 The part that was wrong is that we converted the expression into a
22936 string (an oversimplification in one hand, compounded with primary
22937 expressions doing string concatenation).
22943 Would return "A.B.C[]" as a SimpleName. This stopped things like
22944 using clauses from working on this particular context. And a type
22945 was being matched directly against "A.B.C[]".
22947 We now use the correct approach, and allow for ComposedCast to be
22948 part of the unary expression. So the "A.B.C []" become a composed
22949 cast of "A.B.C" (as a nested group of MemberAccess with a
22950 SimpleName at the end) plus the rank composition "[]".
22954 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22956 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22957 for the access level checking.
22959 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22960 `TypeContainer container', because I kept getting confused when I
22961 was debugging this code.
22963 * expression.cs (Indexers): Instead of tracking getters/setters,
22964 we now track them in parallel. We create one arraylist less, but
22965 most importantly it is possible now for the LValue code to find a
22966 matching get for a set.
22968 (IndexerAccess.DoResolveLValue): Update the code.
22969 GetIndexersForType has been modified already to extract all the
22970 indexers from a type. The code assumed it did not.
22972 Also make the code set the correct return type for the indexer.
22973 This was fixed a long time ago for properties, but was missing for
22974 indexers. It used to be void_type.
22976 (Binary.Emit): Test first for doubles instead of
22977 floats, as they are more common.
22979 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22980 when dealing with floats and the <=, >= operators. This fixes bug
22983 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22984 to load the array value by emitting a load on the foreach variable
22985 type. This was incorrect.
22987 We now emit the code to load an element using the the array
22988 variable type, and then we emit the conversion operator.
22992 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22994 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22996 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22998 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22999 test for protection before we test for signatures.
23001 (MethodSignature.ToString): implement.
23003 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
23004 to the case where we reduced into a LongConstant.
23006 * decl.cs (CheckAccessLevel): If the type is an array, we can not
23007 depend on whether the information is acurrate, because the
23008 Microsoft runtime will always claim that the array type is public,
23009 regardless of the real state.
23011 If the type is a pointer, another problem happens: the type is
23012 reported as non-public in Microsoft.
23014 In both cases we have to call CheckAccessLevel recursively with
23015 the underlying type as the argument to be tested.
23017 2003-04-08 Miguel de Icaza <miguel@ximian.com>
23019 * assign.cs (Assign.Emit): If we are dealing with a compound
23020 assignment expression, we should use the code path that stores the
23021 intermediate result in a temporary value. This fixes #40903.
23023 *expression.cs (Indirection.ToString): Provide ToString method for
23026 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
23028 * class.cs: Null out fields holding references to Block objects so
23029 they can be garbage collected.
23031 * expression.cs (OverloadResolve): Remove unused local.
23033 2003-04-07 Martin Baulig <martin@ximian.com>
23035 * codegen.cs (EmitContext.CurrentFile): New public field.
23036 (EmitContext.Mark): Use the CurrentFile to check whether the
23037 location is in the correct file.
23038 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
23040 2003-04-07 Martin Baulig <martin@ximian.com>
23042 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
23044 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
23045 location. [FIXME: The location argument which gets passed to this
23046 method is sometimes wrong!]
23048 2003-04-07 Nick Drochak <ndrochak@gol.com>
23050 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
23052 2003-04-07 Miguel de Icaza <miguel@ximian.com>
23054 * expression.cs (Indirection.EmitAssign): We were using the
23055 temporary, but returning immediately instead of continuing the
23058 2003-04-06 Martin Baulig <martin@ximian.com>
23060 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
23061 if it's a nested child, but also deriving from the outer class.
23064 * typemanager.cs (IsNestedChildOf): Make this work if it's a
23065 nested child, but also deriving from the outer class. See
23067 (FilterWithClosure): We may access private members of the outer
23068 class if we're a nested child and deriving from the outer class.
23069 (RealMemberLookup): Only set `closure_private_ok' if the
23070 `original_bf' contained BindingFlags.NonPublic.
23072 2003-04-05 Martin Baulig <martin@ximian.com>
23074 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
23076 2003-04-02 Miguel de Icaza <miguel@ximian.com>
23078 * class.cs (Event.Define): Do not allow abstract events to have
23081 2003-04-01 Miguel de Icaza <miguel@ximian.com>
23083 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
23084 block in event declarations.
23086 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
23087 value type, get its address.
23089 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
23090 leaving a class on the stack instead of a boolean value (int
23091 0/1). Change the code so we compare against null, and then the
23092 result against zero.
23094 * class.cs (TypeContainer.GetClassBases): We were checking for the
23095 parent class being sealed too late.
23097 * expression.cs (Binary.Emit): For <= and >= when dealing with
23098 floating point values, use cgt.un and clt.un instead of cgt and
23101 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
23103 * statement.cs: Apply the same optimization as MS: skip the
23104 GetEnumerator returning an IEnumerator, and use the one returning a
23105 CharEnumerator instead. This allows us to avoid the try-finally block
23108 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
23110 * cs-parser.jay: Attributes cannot be applied to
23111 namespaces. Fixes #40473
23113 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23116 (Add*): check if the name is valid using the full name for constants,
23117 fields, properties and events.
23119 2003-03-28 Miguel de Icaza <miguel@ximian.com>
23121 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
23122 char constants to be part of the enumeration.
23124 * expression.cs (Conditional.DoResolve): Add support for operator
23125 true. Implements the missing functionality from 14.12
23127 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
23128 operator true/false as required by the spec.
23130 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
23131 implicit conversion to boolean.
23133 * statement.cs (Statement.ResolveBoolean): A boolean expression is
23134 also one where the type implements `operator true'.
23136 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
23137 get an expression that will invoke operator true based on an
23140 (GetConversionOperators): Removed the hack that called op_True
23143 (Expression.ResolveBoolean): Move this from Statement.
23145 2003-03-17 Miguel de Icaza <miguel@ximian.com>
23147 * ecore.cs (FieldExpr): do not allow initialization of initonly
23148 fields on derived classes
23150 2003-03-13 Martin Baulig <martin@ximian.com>
23152 * statement.cs (Block.Emit): Call ig.BeginScope() and
23153 ig.EndScope() when compiling with debugging info; call
23154 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
23156 2003-03-08 Miguel de Icaza <miguel@ximian.com>
23158 * expression.cs (Indexers): Do not construct immediately, allow
23159 for new members to be appended as we go. Fixes 38143
23161 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23163 * expression.cs: save/restore context when resolving an unchecked
23166 2003-03-05 Miguel de Icaza <miguel@ximian.com>
23168 * cfold.cs: Catch division by zero in modulus operator during
23171 2003-03-03 Miguel de Icaza <miguel@ximian.com>
23173 * interface.cs (Interface.DefineMembers): Avoid defining members
23176 2003-02-27 Miguel de Icaza <miguel@ximian.com>
23178 * driver.cs: handle the +/- options for -noconfig
23180 * statement.cs (Unckeched.Resolve): Also track the state of
23181 unchecked in the Resolve phase.
23183 2003-02-27 Martin Baulig <martin@ximian.com>
23185 * ecore.cs (Expression.MemberLookup): Don't create a
23186 MethodGroupExpr for something which is not a method. Fixes #38291.
23188 2003-02-25 Miguel de Icaza <miguel@ximian.com>
23190 * class.cs (MemberBase.CheckParameters): Also check that the type
23191 is unmanaged if it is a pointer.
23193 * expression.cs (SizeOf.Resolve): Add location information.
23195 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
23196 a managed type is declared.
23198 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
23199 parameter modifiers as well. Fixes bug 38606
23201 * class.cs: Very sad. Am backing out the speed up changes
23202 introduced by the ArrayList -> Array in the TypeContainer, as they
23203 were not actually that much faster, and introduced a bug (no error
23204 reports on duplicated methods).
23206 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
23207 source first, this will guarantee that we have a valid expression
23208 before calling in lower levels functions that will require a
23209 resolved object. Then use this original_source in the
23210 target.ResolveLValue instead of the original source that was
23213 Another change. Use target.Resolve instead of LValueResolve.
23214 Although we are resolving for LValues, we will let the Assign code
23215 take care of that (it will be called again from Resolve). This
23216 basically allows code like this:
23218 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
23219 class Y { void A (X x) { x [0] += o; }
23221 The problem was that the indexer was trying to resolve for
23222 set_Item (idx, object o) and never finding one. The real set_Item
23223 was set_Item (idx, X). By delaying the process we get the right
23228 2003-02-23 Martin Baulig <martin@ximian.com>
23230 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
23231 while calling DoEmit ().
23233 * codegen.cs (EmitContext.Mark): Don't mark locations in other
23234 source files; if you use the #line directive inside a method, the
23235 compiler stops emitting line numbers for the debugger until it
23236 reaches the end of the method or another #line directive which
23237 restores the original file.
23239 2003-02-23 Martin Baulig <martin@ximian.com>
23241 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
23243 2003-02-23 Martin Baulig <martin@ximian.com>
23245 * statement.cs (Block.AddChildVariableNames): We need to call this
23246 recursively, not just for our immediate children.
23248 2003-02-23 Martin Baulig <martin@ximian.com>
23250 * class.cs (Event.Define): Always make the field private, like csc does.
23252 * typemanager.cs (TypeManager.RealMemberLookup): Make events
23253 actually work, fixes bug #37521.
23255 2003-02-23 Miguel de Icaza <miguel@ximian.com>
23257 * delegate.cs: When creating the various temporary "Parameters"
23258 classes, make sure that we call the ComputeAndDefineParameterTypes
23259 on those new parameters (just like we do with the formal ones), to
23260 allow them to be resolved in the context of the DeclSpace.
23262 This fixes the bug that Dick observed in Bugzilla #38530.
23264 2003-02-22 Miguel de Icaza <miguel@ximian.com>
23266 * expression.cs (ResolveMemberAccess): When resolving a constant,
23267 do not attempt to pull a constant if the value was not able to
23268 generate a valid constant.
23270 * const.cs (LookupConstantValue): Do not report more errors than required.
23272 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23274 * expression.cs: fixes bug #38328.
23276 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23278 * class.cs: Changed all the various members that can be part of a
23279 class from being an ArrayList to be an Array of the right type.
23280 During the DefineType type_list, interface_list, delegate_list and
23281 enum_list are turned into types, interfaces, delegates and enums
23284 And during the member population, indexer_list, event_list,
23285 constant_list, field_list, instance_constructor_list, method_list,
23286 operator_list and property_list are turned into their real arrays.
23288 Although we could probably perform this operation earlier, for
23289 good error reporting we need to keep the lists and remove the
23290 lists for longer than required.
23292 This optimization was triggered by Paolo profiling the compiler
23293 speed on the output of `gen-sample-program.pl' perl script.
23295 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
23296 not crash in methods like MemberLookupFailed that use this field.
23298 This problem arises when the compiler fails to resolve a type
23299 during interface type definition for example.
23301 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23303 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
23304 inherit from System.Object, so we have to stop at null, not only
23305 when reaching System.Object.
23307 2003-02-17 Miguel de Icaza <miguel@ximian.com>
23309 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
23310 DeclaredOnly because the parent indexer might have had a different
23311 name, but did not loop until the top of the hierarchy was reached.
23313 The problem this one fixes is 35492: when a class implemented an
23314 indexer from an interface, we were getting the interface method
23315 (which was abstract) and we were flagging an error (can not invoke
23318 This also keeps bug 33089 functioning, and test-148 functioning.
23320 * typemanager.cs (IsSpecialMethod): The correct way of figuring
23321 out if a method is special is to see if it is declared in a
23322 property or event, or whether it is one of the predefined operator
23323 names. This should fix correctly #36804.
23325 2003-02-15 Miguel de Icaza <miguel@ximian.com>
23327 The goal here is to remove the dependency on EmptyCast.Peel ().
23328 Killing it completely.
23330 The problem is that currently in a number of places where
23331 constants are expected, we have to "probe" for an EmptyCast, and
23332 Peel, which is not the correct thing to do, as this will be
23333 repetitive and will likely lead to errors.
23335 The idea is to remove any EmptyCasts that are used in casts that
23336 can be reduced to constants, so we only have to cope with
23339 This bug hunt was triggered by Bug 37363 and the desire to remove
23340 the duplicate pattern where we were "peeling" emptycasts to check
23341 whether they were constants. Now constants will always be
23344 * ecore.cs: Use an enumconstant here instead of wrapping with
23347 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
23348 throwing me off. By handling this we can get rid of a few hacks.
23350 * statement.cs (Switch): Removed Peel() code.
23352 2003-02-14 Miguel de Icaza <miguel@ximian.com>
23354 * class.cs: Location information for error 508
23356 * expression.cs (New.DoResolve): Add a guard against double
23357 resolution of an expression.
23359 The New DoResolve might be called twice when initializing field
23360 expressions (see EmitFieldInitializers, the call to
23361 GetInitializerExpression will perform a resolve on the expression,
23362 and later the assign will trigger another resolution
23364 This leads to bugs (#37014)
23366 * delegate.cs: The signature for EndInvoke should contain any ref
23367 or out parameters as well. We were not doing this in the past.
23369 * class.cs (Field.Define): Do not overwrite the type definition
23370 inside the `volatile' group. Turns out that volatile enumerations
23371 were changing the type here to perform a validity test, which
23374 2003-02-12 Miguel de Icaza <miguel@ximian.com>
23376 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
23377 and structs, we do not want to load the instance variable
23379 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
23380 enum_type has to be handled like an object reference (implicit
23381 conversions exists from this to object), but the regular IsClass
23382 and IsValueType tests will never return true for this one.
23384 Also we use TypeManager.IsValueType instead of type.IsValueType,
23385 just for consistency with the rest of the code (this is only
23386 needed if we ever use the construct exposed by test-180.cs inside
23387 corlib, which we dont today).
23389 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
23391 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
23394 2003-02-09 Martin Baulig <martin@ximian.com>
23396 * namespace.cs (Namespace..ctor): Added SourceFile argument.
23397 (Namespace.DefineNamespaces): New static public method; this is
23398 called when we're compiling with debugging to add all namespaces
23399 to the symbol file.
23401 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
23402 pass it to the Namespace's .ctor.
23404 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
23405 and MethodBase arguments; pass the namespace ID to the symwriter;
23406 pass the MethodBase instead of the token to the symwriter.
23407 (SymbolWriter.DefineNamespace): New method to add a namespace to
23410 2003-02-09 Martin Baulig <martin@ximian.com>
23412 * symbolwriter.cs: New file. This is a wrapper around
23413 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
23414 methods here in near future.
23416 2003-02-09 Martin Baulig <martin@ximian.com>
23418 * codegen.cs (EmitContext.Mark): Just pass the arguments to
23419 ILGenerator.MarkSequencePoint() which are actually used by the
23422 2003-02-09 Martin Baulig <martin@ximian.com>
23424 * location.cs (SourceFile): New public sealed class. This
23425 contains the name and an index which is used in the location's token.
23426 (Location): Reserve an appropriate number of bits in the token for
23427 the source file instead of walking over that list, this gives us a
23428 really huge performance improvement when compiling with debugging.
23430 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
23431 `SourceFile' argument instead of a string.
23432 (Driver.ProcessFile): Add all the files via Location.AddFile(),
23433 but don't parse/tokenize here, we need to generate the list of all
23434 source files before we do that.
23435 (Driver.ProcessFiles): New static function. Parses/tokenizes all
23438 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
23439 instead of a string.
23441 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
23444 2003-02-09 Martin Baulig <martin@ximian.com>
23446 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
23447 filename on `#line default'.
23449 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
23451 * statement.cs: don't clear the pinned var when the fixed statement
23452 returns from the method (fixes bug#37752).
23454 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
23456 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
23459 2003-02-07 Martin Baulig <martin@ximian.com>
23461 * driver.cs: Removed the `--debug-args' command line argument.
23463 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
23464 automatically by the AsssemblyBuilder.
23465 (CodeGen.InitializeSymbolWriter): We don't need to call any
23466 initialization function on the symbol writer anymore. This method
23467 doesn't take any arguments.
23469 2003-02-03 Miguel de Icaza <miguel@ximian.com>
23471 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
23472 from referenced assemblies as well.
23474 2003-02-02 Martin Baulig <martin@ximian.com>
23476 * class.cs (MethodData.Emit): Generate debugging info for external methods.
23478 2003-02-02 Martin Baulig <martin@ximian.com>
23480 * class.cs (Constructor.Emit): Open the symbol writer before
23481 emitting the constructor initializer.
23482 (ConstructorInitializer.Emit): Call ec.Mark() to allow
23483 single-stepping through constructor initializers.
23485 2003-01-30 Miguel de Icaza <miguel@ximian.com>
23487 * class.cs: Handle error 549: do not allow virtual methods in
23490 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
23492 * decl.cs: Check access levels when resolving types
23494 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
23496 * statement.cs: Add parameters and locals set in catch blocks that might
23497 return to set vector
23499 2003-01-29 Miguel de Icaza <miguel@ximian.com>
23501 * class.cs (Operator): Set the SpecialName flags for operators.
23503 * expression.cs (Invocation.DoResolve): Only block calls to
23504 accessors and operators on SpecialName methods.
23506 (Cast.TryReduce): Handle conversions from char constants.
23509 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
23511 * statement.cs: small memory and time optimization in FlowBranching.
23513 2003-01-28 Pedro Mart <yoros@wanadoo.es>
23515 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
23516 problem that the last fix but in the other sid (Set).
23518 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
23519 access when there is no indexer in the hierarchy.
23521 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
23523 * class.cs: Combine some if statements.
23525 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23527 * driver.cs: fixed bug #37187.
23529 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
23531 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
23532 any indexer, it's needed to build a list with all the indexers in the
23533 hierarchy (AllGetters), else we have problems. Fixes #35653.
23535 2003-01-23 Miguel de Icaza <miguel@ximian.com>
23537 * class.cs (MethodData.Define): It is wrong for an interface
23538 implementation to be static in both cases: explicit and implicit.
23539 We were only handling this in one case.
23541 Improve the if situation there to not have negations.
23543 * class.cs (Field.Define): Turns out that we do not need to check
23544 the unsafe bit on field definition, only on usage. Remove the test.
23546 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23548 * driver.cs: use assembly.Location instead of Codebase (the latest
23549 patch made mcs fail when using MS assemblies).
23551 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23553 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23554 get the path to *corlib.dll.
23556 2003-01-21 Nick Drochak <ndrochak@gol.com>
23560 * typemanager.cs: Remove compiler warnings
23562 2003-01-20 Duncan Mak <duncan@ximian.com>
23564 * AssemblyInfo.cs: Bump the version number to 0.19.
23566 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23568 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23570 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23572 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23574 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23576 * cs-parser.jay: Small fix: we were not comparing the constructor
23577 name correctly. Thanks to Zoltan for the initial pointer.
23579 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23581 * cs-tokenizer.cs: Set file name when specified with #line
23583 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23585 * cs-parser.jay: Only perform the constructor checks here if we
23586 are named like the class; This will help provider a better
23587 error. The constructor path is taken when a type definition is
23588 not found, but most likely the user forgot to add the type, so
23589 report that rather than the constructor error.
23591 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23593 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23596 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23598 * cs-parser.jay: Add cleanup call.
23600 2003-01-13 Duncan Mak <duncan@ximian.com>
23602 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23603 consistent with other methods.
23605 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23607 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23609 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23611 * attribute.cs: only set GuidAttr to true when we have a
23614 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23618 * typemanager.cs: fixes to allow mcs compile corlib with the new
23619 Type.IsSubclassOf fix.
23621 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23623 * expression.cs (LocalVariableReference.DoResolve): Classify a
23624 constant as a value, not as a variable. Also, set the type for
23627 * cs-parser.jay (fixed_statement): take a type instead of a
23628 pointer_type, so we can produce a better error message later.
23630 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23633 (For.DoEmit): Make inifinite loops have a
23634 non-conditional branch back.
23636 (Fixed.DoEmit): First populate the pinned variables, then emit the
23637 statement, then clear the variables. Before I was emitting the
23638 code once for each fixed piece.
23641 2003-01-08 Martin Baulig <martin@ximian.com>
23643 * statement.cs (FlowBranching.MergeChild): A break in a
23644 SWITCH_SECTION does not leave a loop. Fixes #36155.
23646 2003-01-08 Martin Baulig <martin@ximian.com>
23648 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23649 lives in the same number space than `param_map'. Fixes #36154.
23651 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23653 * cs-parser.jay (constructor_declaration): Set the
23654 Constructor.ModFlags before probing for it. This makes the
23655 compiler report 514, 515 and 132 (the code was there, but got
23658 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23659 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23660 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23662 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23664 * enum.cs: create the enum static fields using the enum type.
23666 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23668 * class.cs: don't try to create the ParamBuilder for the return
23669 type if it's not needed (and handle it breaking for the ms runtime
23672 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23674 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23676 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23678 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23679 the command. This showed up while compiling the JANET source
23680 code, which used \r as its only newline separator.
23682 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23684 * class.cs (Method.Define): If we are an operator (because it
23685 reuses our code), then set the SpecialName and HideBySig. #36128
23687 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23689 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23690 exception, report error 120 `object reference required'.
23692 * driver.cs: Add --pause option, used during to measure the size
23693 of the process as it goes with --timestamp.
23695 * expression.cs (Invocation.DoResolve): Do not allow methods with
23696 SpecialName to be invoked.
23698 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23700 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23701 number before adding it.
23703 2002-12-21 Ravi Pratap <ravi@ximian.com>
23705 * ecore.cs (StandardImplicitConversion): When in an unsafe
23706 context, we allow conversion between void * to any other pointer
23707 type. This fixes bug #35973.
23709 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23711 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23712 is not thrown when extensionless outputs are used
23714 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23716 * rootcontext.cs: fixed compilation of corlib.
23718 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23720 * attribute.cs (Attributes.Contains): Add new method.
23722 * class.cs (MethodCore.LabelParameters): if the parameter is an
23723 `out' parameter, check that no attribute `[In]' has been passed.
23725 * enum.cs: Handle the `value__' name in an enumeration.
23727 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23729 * decl.cs: Added special case to allow overrides on "protected
23732 2002-12-18 Ravi Pratap <ravi@ximian.com>
23734 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23735 since it makes much more sense.
23737 (Attributes.ctor): Don't require a Location parameter.
23739 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23741 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23742 since we already have that information per attribute.
23744 * everywhere : make appropriate changes.
23746 * class.cs (LabelParameters): Write the code which actually
23747 applies attributes to the return type. We can't do this on the MS
23748 .NET runtime so we flag a warning in the case an exception is
23751 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23753 * const.cs: Handle implicit null conversions here too.
23755 2002-12-17 Ravi Pratap <ravi@ximian.com>
23757 * class.cs (MethodCore.LabelParameters): Remove the extra
23758 Type [] parameter since it is completely unnecessary. Instead
23759 pass in the method's attributes so that we can extract
23760 the "return" attribute.
23762 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23764 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23765 of ignoring it and letting the compile continue.
23767 * typemanager.cs (ChangeType): use an extra argument to return an
23768 error condition instead of throwing an exception.
23770 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23772 * expression.cs (Unary.TryReduce): mimic the code for the regular
23773 code path. Perform an implicit cast in the cases where we can
23774 implicitly convert to one of the integral types, and then reduce
23775 based on that constant. This fixes bug #35483.
23777 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23779 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23781 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23783 * namespace.cs: fixed bug #35489.
23785 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23787 * class.cs: Remove some dead code.
23789 * cs-parser.jay: Estimate the number of methods needed
23790 (RootContext.MethodCount);
23792 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23793 numbers instead of StringBuilders.
23795 * support.cs (PtrHashtable): Add constructor with initial size;
23796 We can now reduce reallocations of the method table.
23798 2002-12-10 Ravi Pratap <ravi@ximian.com>
23800 * attribute.cs (ApplyAttributes): Keep track of the emitted
23801 attributes on a per-target basis. This fixes bug #35413.
23803 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23805 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23806 default to the Windows 1252 encoding.
23808 (UnixParseOption): Support version, thanks to Alp for the missing
23811 * AssemblyInfo.cs: Add nice assembly information.
23813 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23816 * cs-parser.jay: Allow a trailing comma before the close bracked
23817 in the attribute_section production.
23819 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23820 address of the instance was being taken, I will take this out,
23821 because we take the address of the object immediately here.
23823 2002-12-09 Ravi Pratap <ravi@ximian.com>
23825 * typemanager.cs (AreMultipleAllowed): Take care of the most
23826 obvious case where attribute type is not in the current assembly -
23829 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23831 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23832 definitions, instead of doing that afterwards.
23834 Also we use a nice little hack, depending on the constructor, we
23835 know if we are a "composed" name or a simple name. Hence, we
23836 avoid the IndexOf test, and we avoid
23838 * codegen.cs: Add code to assist in a bug reporter to track down
23839 the source of a compiler crash.
23841 2002-12-07 Ravi Pratap <ravi@ximian.com>
23843 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23844 types have been emitted for a given element and flag an error
23845 if something which does not have AllowMultiple set is used more
23848 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23849 attribute types and their corresponding AllowMultiple properties
23851 (AreMultipleAllowed): Check the property for a given type.
23853 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23854 property in the case we have a TypeContainer.
23856 (Attributes.AddAttribute): Detect duplicates and just skip on
23857 adding them. This trivial fix catches a pretty gross error in our
23858 attribute emission - global attributes were being emitted twice!
23860 Bugzilla bug #33187 is now fixed.
23862 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23864 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23865 instead of pp_and).
23867 * expression.cs (Binary.ResolveOperator): I can only use the
23868 Concat (string, string, string) and Concat (string, string,
23869 string, string) if the child is actually a concatenation of
23872 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23874 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23875 context where we need a 2-character lookahead.
23877 * pending.cs (PendingImplementation): Rework so we can keep track
23878 of interface types all the time, and flag those which were
23879 implemented by parents as optional.
23881 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23883 * expression.cs (Binary.ResolveOperator): Use
23884 String.Concat(string,string,string) or
23885 String.Concat(string,string,string,string) when possible.
23887 * typemanager: More helper methods.
23890 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23892 * pending.cs: remove the bogus return from GetMissingInterfaces()
23893 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23895 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23897 * namespace.cs: avoid duplicated 'using xxx' being added to
23898 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23899 when we get more than one 'using' statement for the same namespace.
23900 Report a CS0105 warning for it.
23902 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23904 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23905 of calling getChar/putback, uses internal knowledge of it.
23907 (xtoken): Reorder tokenizer so most common patterns are checked
23908 first. This reduces the compilation time in another 5% (from 8.11s
23909 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23911 The parsing time is 22% of the compilation in mcs, and from that
23912 64% is spent on the tokenization process.
23914 I tried using a binary search for keywords, but this is slower
23915 than the hashtable. Another option would be to do a couple of
23918 * Not use a StringBuilder, instead use an array of chars,
23919 with a set value. Notice that this way we could catch
23920 the 645 error without having to do it *afterwards*.
23922 * We could write a hand-parser to avoid the hashtable
23923 compares altogether.
23925 The identifier consumption process takes 37% of the tokenization
23926 time. Another 15% is spent on is_number. 56% of the time spent
23927 on is_number is spent on Int64.Parse:
23929 * We could probably choose based on the string length to
23930 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23933 Another 3% is spend on wrapping `xtoken' in the `token' function.
23935 Handle 0xa0 as whitespace (#34752)
23937 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23939 * typemanager.cs (IsCLRType): New routine to tell whether a type
23940 is one of the builtin types.
23942 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23943 typecode in more places instead of doing pointer comparissions.
23944 We could leverage some knowledge about the way the typecodes are
23947 New code to cache namespaces in assemblies, it is currently not
23948 invoked, to be used soon.
23950 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23952 * expression.cs (Binary.ResolveOperator): specially handle
23953 strings, and do not perform user-defined operator overloading for
23956 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23958 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23959 internalcall as it is a pretty simple operation; Avoid whenever
23960 possible to call Char.IsLetter.
23962 (consume_identifier): Cut by half the number of
23963 hashtable calls by merging the is_keyword and GetKeyword behavior.
23965 Do not short-circuit, because if we do, we
23966 report errors (ie, #if false && true would produce an invalid
23970 2002-11-24 Martin Baulig <martin@ximian.com>
23972 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23973 check constant ranges and report a CS0221. Fixes #33186.
23975 2002-11-24 Martin Baulig <martin@ximian.com>
23977 * cs-parser.jay: Make this work for uninitialized variable
23978 declarations in the `for' initializer. Fixes #32416.
23980 2002-11-24 Martin Baulig <martin@ximian.com>
23982 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23983 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23985 2002-11-24 Martin Baulig <martin@ximian.com>
23987 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23988 argument; if true, we also check for user-defined conversions.
23989 This is only needed if both arguments are of a user-defined type.
23990 Fixes #30443, added test-175.cs.
23991 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23993 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23995 2002-11-24 Martin Baulig <martin@ximian.com>
23997 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23998 function to get the store opcode.
23999 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
24000 only emit the Ldelema if the store opcode is Stobj. You must run
24001 both test-34 and test-167 to test this. Fixes #34529.
24003 2002-11-23 Martin Baulig <martin@ximian.com>
24005 * ecore.cs (Expression.MemberLookup): Added additional
24006 `qualifier_type' argument which is used when we're being called
24007 from MemberAccess.DoResolve() and null if we're called from a
24009 (Expression.MemberLookupFailed): New method to report errors; this
24010 does the CS1540 check and reports the correct error message.
24012 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
24013 argument for the CS1540 check and redone the way how we're dealing
24014 with private members. See the comment in the source code for details.
24015 (FilterWithClosure): Reverted this back to revision 1.197; renamed
24016 `closure_start_type' to `closure_qualifier_type' and check whether
24017 it's not null. It was not this filter being broken, it was just
24018 being called with the wrong arguments.
24020 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
24021 and pass it the correct `qualifier_type'; this also does the error
24024 2002-11-22 Miguel de Icaza <miguel@ximian.com>
24026 * expression.cs (Invocation.EmitParams): If the we are dealing
24027 with a non-built-in value type, load its address as well.
24029 (ArrayCreation): Use a a pretty constant instead
24030 of the hardcoded value 2. Use 6 instead of 2 for the number of
24031 static initializers.
24033 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
24034 because they are not really value types, just glorified integers.
24036 * driver.cs: Do not append .exe, the CSC compiler does not do it.
24038 * ecore.cs: Remove redundant code for enumerations, make them use
24039 the same code path as everything else, fixes the casting issue
24040 with enumerations in Windows.Forms.
24042 * attribute.cs: Do only cast to string if it is a string, the
24043 validation happens later.
24045 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
24046 people upgrade their corlibs.
24048 * ecore.cs: Oops, enumerations were not following the entire code path
24050 2002-11-21 Miguel de Icaza <miguel@ximian.com>
24052 * typemanager.cs (FilterWithClosure): Commented out the test for
24053 1540 in typemanager.cs, as it has problems when accessing
24054 protected methods from a parent class (see test-174.cs).
24056 * attribute.cs (Attribute.ValidateGuid): new method.
24057 (Attribute.Resolve): Use above.
24059 2002-11-19 Miguel de Icaza <miguel@ximian.com>
24061 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
24063 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
24064 handling for enumerations, as we only needed the TypeContainer
24065 functionality to begin with (this is required for the fix below to
24066 work for enums that reference constants in a container class for
24069 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
24071 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
24072 a valid TypeBuilder to perform lookups on.o
24074 * class.cs (InheritableMemberSignatureCompare): Use true in the
24075 call to GetGetMethod and GetSetMethod, because we are comparing
24076 the signature, and we need to get the methods *even* if they are
24079 (PropertyBase.CheckBase): ditto.
24081 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
24082 GotoCase.Resolve): Use Peel on EmpytCasts.
24084 * ecore.cs (EmptyCast): drop child, add Peel method.
24086 2002-11-17 Martin Baulig <martin@ximian.com>
24088 * ecore.cs (EmptyCast.Child): New public property.
24090 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
24091 label resolved to an EmptyCast. Fixes #34162.
24092 (GotoCase.Resolve): Likewise.
24093 (Block.EmitMeta): Likewise.
24095 2002-11-17 Martin Baulig <martin@ximian.com>
24097 * expression.cs (Invocation.BetterConversion): Prefer int over
24098 uint; short over ushort; long over ulong for integer literals.
24099 Use ImplicitConversionExists instead of StandardConversionExists
24100 since we also need to check for user-defined implicit conversions.
24101 Fixes #34165. Added test-173.cs.
24103 2002-11-16 Martin Baulig <martin@ximian.com>
24105 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
24106 with the `true' and `false' literals. Fixes #33151.
24108 2002-11-16 Martin Baulig <martin@ximian.com>
24110 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
24111 October 22nd; don't do the cs1540 check for static members.
24113 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
24114 now using our own filter here and doing the cs1540 check again.
24116 2002-11-16 Martin Baulig <martin@ximian.com>
24118 * support.cs (InternalParameters): Don't crash if we don't have
24119 any fixed parameters. Fixes #33532.
24121 2002-11-16 Martin Baulig <martin@ximian.com>
24123 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
24124 when looking up static methods to make this work on Windows.
24127 2002-11-16 Martin Baulig <martin@ximian.com>
24129 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
24130 a setter rather than using PropertyInfo.CanWrite.
24132 2002-11-15 Nick Drochak <ndrochak@gol.com>
24134 * class.cs: Allow acces to block member by subclasses. Fixes build
24137 2002-11-14 Martin Baulig <martin@ximian.com>
24139 * class.cs (Constructor.Emit): Added the extern/block check.
24142 2002-11-14 Martin Baulig <martin@ximian.com>
24144 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
24145 iteration while looking for indexers, this is needed because the
24146 indexer may have a different name in our base classes. Fixed the
24147 error reporting (no indexers at all, not get accessor, no
24148 overloaded match). Fixes bug #33089.
24149 (IndexerAccess.DoResolveLValue): Likewise.
24151 2002-11-14 Martin Baulig <martin@ximian.com>
24153 * class.cs (PropertyBase.CheckBase): Make this work for multiple
24154 indexers. Fixes the first part of bug #33089.
24155 (MethodSignature.InheritableMemberSignatureCompare): Added support
24158 2002-11-13 Ravi Pratap <ravi@ximian.com>
24160 * attribute.cs (Attribute.Resolve): Catch the
24161 NullReferenceException and report it since it isn't supposed to
24164 2002-11-12 Miguel de Icaza <miguel@ximian.com>
24166 * expression.cs (Binary.EmitBranchable): Also handle the cases for
24167 LogicalOr and LogicalAnd that can benefit from recursively
24168 handling EmitBranchable. The code now should be nice for Paolo.
24170 2002-11-08 Miguel de Icaza <miguel@ximian.com>
24172 * typemanager.cs (LookupType): Added a negative-hit hashtable for
24173 the Type lookups, as we perform quite a number of lookups on
24174 non-Types. This can be removed once we can deterministically tell
24175 whether we have a type or a namespace in advance.
24177 But this might require special hacks from our corlib.
24181 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
24182 and double which avoids a conversion from an integer to a double.
24184 * expression.cs: tiny optimization, avoid calling IsConstant,
24185 because it effectively performs the lookup twice.
24187 2002-11-06 Miguel de Icaza <miguel@ximian.com>
24189 But a bogus return here to keep the semantics of the old code
24190 until the Mono runtime is fixed.
24192 * pending.cs (GetMissingInterfaces): New method used to remove all
24193 the interfaces that are already implemented by our parent
24194 classes from the list of pending methods.
24196 * interface.cs: Add checks for calls after ResolveTypeExpr.
24198 2002-11-05 Miguel de Icaza <miguel@ximian.com>
24200 * class.cs (Class.Emit): Report warning 67: event not used if the
24201 warning level is beyond 3.
24203 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
24204 being a NullLiteral.
24206 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
24209 * class.cs (TypeContainer.GetClassBases): Cover a missing code
24210 path that might fail if a type can not be resolved.
24212 * expression.cs (Binary.Emit): Emit unsigned versions of the
24215 * driver.cs: use error 5.
24217 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
24219 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
24221 2002-11-01 Miguel de Icaza <miguel@ximian.com>
24223 * cs-parser.jay (switch_section): A beautiful patch from Martin
24224 Baulig that fixed 33094.
24226 2002-10-31 Miguel de Icaza <miguel@ximian.com>
24228 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
24229 Check whether the base is abstract and report an error if so.
24231 * expression.cs (IndexerAccess.DoResolveLValue,
24232 IndexerAccess.DoResolve): ditto.
24234 (Invocation.DoResolve): ditto.
24236 (Invocation.FullMethodDesc): Improve the report string.
24238 * statement.cs (Block): Eliminate IsVariableDefined as it is
24239 basically just a wrapper for GetVariableInfo.
24241 * ecore.cs (SimpleName): Use new
24243 * support.cs (ReflectionParamter.ParameterType): We unwrap the
24244 type, as we return the actual parameter ref/unref state on a
24247 2002-10-30 Miguel de Icaza <miguel@ximian.com>
24249 * support.cs: Return proper flags REF/OUT fixing the previous
24252 * expression.cs: Reverted last patch, that was wrong. Is_ref is
24253 not used to mean `ref' but `ref or out' in ParameterReference
24255 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
24256 full type signature instead of calling TypeManger.CSharpName
24259 * support.cs (InternalParameters.ParameterDesc): Do not compare
24260 directly to the modflags, because REF/OUT will actually be bitsets
24263 * delegate.cs (VerifyMethod): Check also the modifiers.
24265 * cs-tokenizer.cs: Fix bug where floating point values with an
24266 exponent where a sign was missing was ignored.
24268 * driver.cs: Allow multiple assemblies to be specified in a single
24271 2002-10-28 Miguel de Icaza <miguel@ximian.com>
24273 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
24274 because identifiers after a parenthesis would end up in this kind
24275 of production, and we needed to desamiguate it for having casts
24278 (UserDefinedType *) xxx
24280 2002-10-24 Miguel de Icaza <miguel@ximian.com>
24282 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
24283 we should set on the Bindingflags.NonPublic, but not turn on
24284 private_ok. private_ok controls whether a Private member is
24285 returned (this is chekced on the filter routine), while the
24286 BindingFlags.NonPublic just controls whether private/protected
24287 will be allowed. This fixes the problem part of the problem of
24288 private properties being allowed to be used in derived classes.
24290 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
24291 so we can call the children DoResolveLValue method (this will
24292 properly signal errors on lvalue assignments to base properties)
24294 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
24295 getter are null, and we have a property info, we know that this
24296 happened because the lookup failed, so we report an error 122 for
24297 protection level violation.
24299 We also silently return if setter and getter are null in the
24300 resolve functions, this condition only happens if we have flagged
24301 the error before. This is the other half of the problem.
24303 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
24304 not have accessibility information, that is why we were returning
24305 true in the filter function in typemanager.cs.
24307 To properly report 122 (property is inaccessible because of its
24308 protection level) correctly, we report this error in ResolveAccess
24309 by failing if both the setter and the getter are lacking (ie, the
24312 DoResolve and DoLResolve have been modified to check for both
24313 setter/getter being null and returning silently, the reason being
24314 that I did not want to put the knowledge about this error in upper
24317 int old = Report.Errors;
24318 x = new PropertyExpr (...);
24319 if (old != Report.Errors)
24324 So the property expr is returned, but it is invalid, so the error
24325 will be flagged during the resolve process.
24327 * class.cs: Remove InheritablePropertySignatureCompare from the
24328 class, as we no longer depend on the property signature to compute
24329 whether it is possible to implement a method or not.
24331 The reason is that calling PropertyInfo.GetGetMethod will return
24332 null (in .NET, in Mono it works, and we should change this), in
24333 cases where the Get Method does not exist in that particular
24338 class X { public virtual int A { get { return 1; } } }
24340 class Z : Y { public override int A { get { return 2; } } }
24342 Would fail in Z because the parent (Y) would not have the property
24343 defined. So we avoid this completely now (because the alternative
24344 fix was ugly and slow), and we now depend exclusively on the
24347 (PropertyBase.CheckBase): Use a method-base mechanism to find our
24348 reference method, instead of using the property.
24350 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
24351 routines are gone now.
24353 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
24354 names, they were incorrectly named.
24356 * cs-tokenizer.cs: Return are more gentle token on failure.
24358 * pending.cs (PendingImplementation.InterfaceMethod): This routine
24359 had an out-of-sync index variable, which caused it to remove from
24360 the list of pending methods the wrong method sometimes.
24362 2002-10-22 Miguel de Icaza <miguel@ximian.com>
24364 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
24365 CanWrite, because those refer to this particular instance of the
24366 property, and do not take into account the fact that we can
24367 override single members of a property.
24369 Constructor requires an EmitContext. The resolution process does
24370 not happen here, but we need to compute the accessors before,
24371 because the resolution does not always happen for properties.
24373 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
24374 subclass, before we did not update this flag, but we did update
24377 (GetAccessors): Drop this routine, as it did not work in the
24378 presence of partially overwritten set/get methods.
24380 Notice that this broke the cs1540 detection, but that will require
24383 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24387 * driver.cs: issue a warning instead of an error if we don't support
24388 debugging for the platform. Also ignore a couple of errors that may
24389 arise when trying to write the symbols. Undo my previous patch.
24391 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24393 * driver.cs: ignore /debug switch except for Unix platforms.
24395 2002-10-23 Nick Drochak <ndrochak@gol.com>
24397 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
24399 2002-10-21 Miguel de Icaza <miguel@ximian.com>
24401 * driver.cs: Do not make mcs-debug conditional, so we do not break
24402 builds that use it.
24404 * statement.cs (UsageVector.MergeChildren): I would like Martin to
24405 review this patch. But basically after all the children variables
24406 have been merged, the value of "Breaks" was not being set to
24407 new_breaks for Switch blocks. I think that it should be set after
24408 it has executed. Currently I set this to the value of new_breaks,
24409 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
24410 conservative, but I do not understand this code very well.
24412 I did not break anything in the build, so that is good ;-)
24414 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
24416 2002-10-20 Mark Crichton <crichton@gimp.org>
24418 * cfold.cs: Fixed compile blocker. Really fixed it this time.
24420 2002-10-20 Nick Drochak <ndrochak@gol.com>
24422 * cfold.cs: Fixed compile blocker.
24424 2002-10-20 Miguel de Icaza <miguel@ximian.com>
24426 * driver.cs: I was chekcing the key, not the file.
24428 2002-10-19 Ravi Pratap <ravi@ximian.com>
24430 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
24431 message that we were generating - we just need to silently return
24434 2002-10-19 Miguel de Icaza <miguel@ximian.com>
24436 * class.cs (Event.Define): Change my previous commit, as this
24437 breaks the debugger. This is a temporary hack, as it seems like
24438 the compiler is generating events incorrectly to begin with.
24440 * expression.cs (Binary.ResolveOperator): Added support for
24441 "U operator - (E x, E y)"
24443 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
24446 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
24447 init-only variables, but this path did not take into account that
24448 there might be also instance readonly variables. Correct this
24451 This fixes bug 32253
24453 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
24456 * driver.cs: Change the extension for modules to `netmodule'
24458 * cs-parser.jay: Improved slightly the location tracking for
24459 the debugger symbols.
24461 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
24462 modifiers that were specified instead of the hardcoded value
24463 (FamAndAssem). This was basically ignoring the static modifier,
24464 and others. Fixes 32429.
24466 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
24467 fixed a bug in the process (32476)
24469 * expression.cs (ArrayAccess.EmitAssign): Patch from
24470 hwang_rob@yahoo.ca that fixes bug 31834.3
24472 2002-10-18 Miguel de Icaza <miguel@ximian.com>
24474 * driver.cs: Make the module extension .netmodule.
24476 2002-10-16 Miguel de Icaza <miguel@ximian.com>
24478 * driver.cs: Report an error if the resource file is not found
24479 instead of crashing.
24481 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
24482 false, like Emit does.
24484 2002-10-16 Nick Drochak <ndrochak@gol.com>
24486 * typemanager.cs: Remove unused private member. Also reported mcs
24487 bug to report this as a warning like csc.
24489 2002-10-15 Martin Baulig <martin@gnome.org>
24491 * statement.cs (Statement.Emit): Made this a virtual method; emits
24492 the line number info and calls DoEmit().
24493 (Statement.DoEmit): New protected abstract method, formerly knows
24494 as Statement.Emit().
24496 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
24498 2002-10-11 Miguel de Icaza <miguel@ximian.com>
24500 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
24501 have fixed a remaining problem: not every AddXXXX was adding a
24502 fully qualified name.
24504 Now everyone registers a fully qualified name in the DeclSpace as
24505 being defined instead of the partial name.
24507 Downsides: we are slower than we need to be due to the excess
24508 copies and the names being registered this way.
24510 The reason for this is that we currently depend (on the corlib
24511 bootstrap for instance) that types are fully qualified, because
24512 we dump all the types in the namespace, and we should really have
24513 types inserted into the proper namespace, so we can only store the
24514 basenames in the defined_names array.
24516 2002-10-10 Martin Baulig <martin@gnome.org>
24518 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
24519 from bug #31834, see the bug report for a testcase which is
24522 2002-10-10 Martin Baulig <martin@gnome.org>
24524 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
24525 flow analysis code for this.
24527 * statement.cs (Do, While, For): Tell the flow analysis code about
24529 (FlowBranching.UsageVector): Added support for infinite loops.
24530 (Block.Resolve): Moved the dead code elimination here and use flow
24533 2002-10-09 Miguel de Icaza <miguel@ximian.com>
24535 * class.cs (Field.Define): Catch cycles on struct type
24538 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24539 fields if the fields are static. We only need to check instance
24542 * expression.cs (As.DoResolve): Test for reference type.
24544 * statement.cs (Using.ResolveExpression): Use
24545 ConvertImplicitRequired, not ConvertImplicit which reports an
24547 (Using.ResolveLocalVariableDecls): ditto.
24549 * expression.cs (Binary.ResolveOperator): Report errors in a few
24550 places where we had to.
24552 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24554 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24556 * expression.cs: Use StoreFromPtr instead of extracting the type
24557 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24559 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24560 an enumeration value to a System.Enum, but System.Enum is not a
24561 value type, but an class type, so we need to box.
24563 (Expression.ConvertExplicit): One codepath could return
24564 errors but not flag them. Fix this. Fixes #31853
24566 * parameter.cs (Resolve): Do not allow void as a parameter type.
24568 2002-10-06 Martin Baulig <martin@gnome.org>
24570 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24571 if it's a class type and not a struct. Fixes #31815.
24573 2002-10-06 Martin Baulig <martin@gnome.org>
24575 * statement.cs: Reworked the flow analysis code a bit to make it
24576 usable for dead code elimination.
24578 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24580 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24582 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24584 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24585 to fix the test 165, will investigate deeper.
24587 2002-10-04 Martin Baulig <martin@gnome.org>
24589 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24590 finally blocks actually work.
24591 (Try.Resolve): We don't need to create a sibling for `finally' if
24592 there is no finally block.
24594 2002-10-04 Martin Baulig <martin@gnome.org>
24596 * class.cs (Constructor.Define): The default accessibility for a
24597 non-default constructor is private, not public.
24599 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24601 * class.cs (Constructor): Make AllowedModifiers public, add
24604 * cs-parser.jay: Perform the modifiers test here, as the
24605 constructor for the Constructor class usually receives a zero
24606 because of the way we create it (first we create, later we
24607 customize, and we were never checking the modifiers).
24609 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24610 is a version of LookupTypeReflection that includes the type-name
24611 cache. This can be used as a fast path for functions that know
24612 the fully qualified name and are only calling into *.GetType() to
24613 obtain a composed type.
24615 This is also used by TypeManager.LookupType during its type
24618 (LookupType): We now also track the real type name, as sometimes
24619 we can get a quey for the real type name from things like
24620 ComposedCast. This fixes bug 31422.
24622 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24623 complete type fullname, it does not have to go through the type
24624 resolution system to obtain the composed version of the type (for
24625 obtaining arrays or pointers).
24627 (Conditional.Emit): Use the EmitBoolExpression to
24628 generate nicer code, as requested by Paolo.
24630 (ArrayCreation.CheckIndices): Use the patch from
24631 hwang_rob@yahoo.ca to validate the array initializers.
24633 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24635 * class.cs (ConstructorInitializer.Emit): simplify code by using
24636 Invocation.EmitCall, and at the same time, fix the bugs in calling
24637 parent constructors that took variable arguments.
24639 * ecore.cs (Expression.ConvertNumericExplicit,
24640 Expression.ImplicitNumericConversion): Remove the code that
24641 manually wrapped decimal (InternalTypeConstructor call is now gone
24644 * expression.cs (Cast.TryReduce): Also handle decimal types when
24645 trying to perform a constant fold on the type.
24647 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24649 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24650 that only turned off an error report, and did nothing else.
24652 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24654 * driver.cs: Handle and ignore /fullpaths
24656 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24658 * expression.cs (Binary.ResolveOperator): Catch the case where
24659 DoNumericPromotions returns true,
24661 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24663 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24665 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24668 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24670 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24671 conversion exists, but it is also required that the conversion be
24672 performed. This manifested in "(Type64Enum) 2".
24674 * class.cs (TypeManager.AddMethod): The fix is not to change
24675 AddEnum, because that one was using a fully qualified name (every
24676 DeclSpace derivative does), but to change the AddMethod routine
24677 that was using an un-namespaced name. This now correctly reports
24678 the duplicated name.
24680 Revert patch until I can properly fix it. The issue
24681 is that we have a shared Type space across all namespaces
24682 currently, which is wrong.
24684 Options include making the Namespace a DeclSpace, and merge
24685 current_namespace/current_container in the parser.
24687 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24689 * cs-parser.jay: Improve error reporting when we get a different
24690 kind of expression in local_variable_type and
24691 local_variable_pointer_type.
24693 Propagate this to avoid missleading errors being reported.
24695 * ecore.cs (ImplicitReferenceConversion): treat
24696 TypeManager.value_type as a target just like object_type. As
24701 Is valid, and needs to result in the int 1 being boxed before it
24702 is assigned to the value type v.
24704 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24705 to validate the enumeration name.
24707 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24708 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24709 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24711 * ecore.cs (TryImplicitIntConversion): When doing an
24712 implicit-enumeration-conversion, check if the type is 64-bits and
24713 perform a conversion before passing to EnumConstant.
24715 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24717 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24718 report ambiguous type references. Unlike the MS version, we
24719 report what the ambiguity is. Innovation at work ;-)
24721 (DeclSpace.FindType): Require a location argument to
24722 display when we display an ambiguous error.
24724 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24726 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24728 * expression.cs (EmitDynamicInitializers): Apply patch from
24729 hwang_rob@yahoo.ca that fixes the order in which we emit our
24732 2002-09-21 Martin Baulig <martin@gnome.org>
24734 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24735 delegate takes no arguments.
24737 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24739 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24742 * expression.cs: Extract the underlying type.
24744 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24746 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24748 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24750 * class.cs (TypeContainer.DefineType): We can not use the nice
24751 PackingSize with the size set to 1 DefineType method, because it
24752 will not allow us to define the interfaces that the struct
24755 This completes the fixing of bug 27287
24757 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24758 means also structs. This fixes part of the problem.
24759 (Expresion.ImplicitReferenceConversionExists): ditto.
24761 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24762 error if there were no errors reported during the type lookup
24763 process, to avoid duplicates or redundant errors. Without this
24764 you would get an ambiguous errors plus a type not found. We have
24765 beaten the user enough with the first error.
24767 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24770 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24771 during the resolution process, stop the lookup, this avoids
24772 repeated error reports (same error twice).
24774 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24776 * typemanager.cs (LookupType): Redo the type lookup code to match
24777 the needs of System.Reflection.
24779 The issue is that System.Reflection requires references to nested
24780 types to begin with a "+" sign instead of a dot. So toplevel
24781 types look like: "NameSpace.TopLevelClass", and nested ones look
24782 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24785 2002-09-19 Martin Baulig <martin@gnome.org>
24787 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24788 says that a method always returns or always throws an exception,
24789 don't report the CS0161.
24791 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24792 set `Returns = new_returns'.
24794 2002-09-19 Martin Baulig <martin@gnome.org>
24796 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24797 to an enum constant, check for a CS0176.
24799 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24801 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24802 for operators that must be in pairs and report errors.
24804 * ecore.cs (SimpleName.DoResolveType): During the initial type
24805 resolution process, when we define types recursively, we must
24806 check first for types in our current scope before we perform
24807 lookups in the enclosing scopes.
24809 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24811 (Invocation.VerifyArgumentsCompat): Call
24812 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24813 I thought we were supposed to always call this, but there are a
24814 few places in the code where we dont do it.
24816 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24818 * driver.cs: Add support in -linkres and -resource to specify the
24819 name of the identifier.
24821 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24823 * ecore.cs (StandardConversionExists): Sync with the conversion
24824 code: allow anything-* to void* conversions.
24826 (FindMostSpecificSource): Use an Expression argument
24827 instead of a Type, because we might be handed over a Literal which
24828 gets a few more implicit conversions that plain types do not. So
24829 this information was being lost.
24831 Also, we drop the temporary type-holder expression when not
24834 2002-09-17 Martin Baulig <martin@gnome.org>
24836 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24837 this is an explicit interface implementation.
24839 2002-09-17 Martin Baulig <martin@gnome.org>
24841 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24842 different `IndexerName' attributes.
24844 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24845 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24846 virtual CommonResolve().
24848 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24850 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24851 and convert that to the UnderlyingType.
24853 * statement.cs (Foreach.Resolve): Indexers are just like variables
24854 or PropertyAccesses.
24856 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24857 inside quoted strings, we were not doing this before.
24859 2002-09-16 Martin Baulig <martin@gnome.org>
24861 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24862 resolve it. This is needed for the definite assignment check of the
24863 instance expression, fixes bug #29846.
24864 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24866 2002-09-16 Nick Drochak <ndrochak@gol.com>
24868 * parameter.cs: Fix compile error. Cannot reference static member
24869 from an instance object. Is this an mcs bug?
24871 2002-09-14 Martin Baulig <martin@gnome.org>
24873 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24874 multiple times. Fixes bug #30295, added test-166.cs.
24876 2002-09-14 Martin Baulig <martin@gnome.org>
24878 * statement.cs (Block.Emit): Don't emit unreachable code.
24879 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24880 `break' statements.
24881 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24883 2002-09-14 Martin Baulig <martin@gnome.org>
24885 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24888 2002-09-14 Martin Baulig <martin@gnome.org>
24890 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24891 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24892 be false on the ms runtime.
24894 2002-09-13 Martin Baulig <martin@gnome.org>
24896 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24897 the CS0038 error message.
24899 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24901 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24902 constant inside, return it.
24904 2002-09-12 Martin Baulig <martin@gnome.org>
24906 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24907 implicit conversion can be done between enum types.
24909 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24910 check whether an implicit conversion to the current enum's UnderlyingType
24911 exists and report an error if not.
24913 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24914 without debugging support.
24916 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24917 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24919 2002-09-12 Martin Baulig <martin@gnome.org>
24921 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24923 * ecore.cs (IMemberExpr.DeclaringType): New property.
24924 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24925 nonstatic member of an outer type (CS0038).
24927 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24929 * driver.cs: Activate the using-error detector at warning level
24930 4 (at least for MS-compatible APIs).
24932 * namespace.cs (VerifyUsing): Small buglett fix.
24934 * pending.cs (PendingImplementation): pass the container pointer.
24936 * interface.cs (GetMethods): Allow for recursive definition. Long
24937 term, I would like to move every type to support recursive
24938 definitions, not the current ordering mechanism that we have right
24941 The situation is this: Attributes are handled before interfaces,
24942 so we can apply attributes to interfaces. But some attributes
24943 implement interfaces, we will now handle the simple cases
24944 (recursive definitions will just get an error).
24946 * parameter.cs: Only invalidate types at the end if we fail to
24949 2002-09-09 Martin Baulig <martin@gnome.org>
24951 * ecore.cs (PropertyExpr.Emit): Also check for
24952 TypeManager.system_int_array_get_length so this'll also work when
24953 compiling corlib. Fixes #30003.
24955 2002-09-09 Martin Baulig <martin@gnome.org>
24957 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24958 and throw an exception if we can't get the type's size. Fixed #30040,
24961 2002-09-09 Martin Baulig <martin@gnome.org>
24963 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24965 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24966 context. Fixes bug #30027.
24968 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24969 virtual functions. Fixes bug #30043, added test-164.cs.
24971 2002-09-08 Ravi Pratap <ravi@ximian.com>
24973 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24975 2002-09-08 Nick Drochak <ndrochak@gol.com>
24977 * driver.cs: Use an object to get the windows codepage since it's not a
24980 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24982 * statement.cs (For.Emit): for infinite loops (test == null)
24983 return whether there is a break inside, not always "true".
24985 * namespace.cs (UsingEntry): New struct to hold the name of the
24986 using definition, the location where it is defined, and whether it
24987 has been used in a successful type lookup.
24989 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24994 2002-09-06 Ravi Pratap <ravi@ximian.com>
24996 * attribute.cs : Fix incorrect code which relied on catching
24997 a NullReferenceException to detect a null being passed in
24998 where an object was expected.
25000 2002-09-06 Miguel de Icaza <miguel@ximian.com>
25002 * statement.cs (Try): flag the catch variable as assigned
25004 * expression.cs (Cast): Simplified by using ResolveType instead of
25005 manually resolving.
25007 * statement.cs (Catch): Fix bug by using ResolveType.
25009 2002-09-06 Ravi Pratap <ravi@ximian.com>
25011 * expression.cs (BetterConversion): Special case for when we have
25012 a NullLiteral as the argument and we have to choose between string
25013 and object types - we choose string the way csc does.
25015 * attribute.cs (Attribute.Resolve): Catch the
25016 NullReferenceException and report error #182 since the Mono
25017 runtime no more has the bug and having this exception raised means
25018 we tried to select a constructor which takes an object and is
25021 2002-09-05 Ravi Pratap <ravi@ximian.com>
25023 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
25024 message (1502, 1503) when we can't locate a method after overload
25025 resolution. This is much more informative and closes the bug
25028 * interface.cs (PopulateMethod): Return if there are no argument
25029 types. Fixes a NullReferenceException bug.
25031 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
25032 expressions too. Previously we were checking only in one place for
25033 positional arguments leaving out named arguments.
25035 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
25036 type to the enum type is not allowed. Remove code corresponding to
25039 (ConvertNumericExplicit): Allow explicit conversions from
25040 the underlying type to enum type. This precisely follows the spec
25041 and closes a bug filed by Gonzalo.
25043 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25046 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
25048 2002-09-03 Miguel de Icaza <miguel@ximian.com>
25050 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
25051 it was important that we stored the right value after the
25052 reduction in `converted'.
25054 2002-09-04 Martin Baulig <martin@gnome.org>
25056 * location.cs (Location.SymbolDocument): Use full pathnames for the
25059 2002-08-30 Miguel de Icaza <miguel@ximian.com>
25061 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
25062 of the expression resolve mechanism, because that will catch the
25063 SimpleName error failures.
25065 (Conditional): If we can not resolve the
25066 expression, return, do not crash.
25068 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25071 (location): display token name instead of its number.
25073 2002-08-28 Martin Baulig <martin@gnome.org>
25075 * expression.cs (Binary.ResolveOperator): Don't silently return
25076 but return an error if an operator cannot be applied between two
25079 2002-08-28 Martin Baulig <martin@gnome.org>
25081 * class.cs (Constructor.Define): Set the permission attributes
25082 correctly instead of making all constructors public.
25084 2002-08-28 Martin Baulig <martin@gnome.org>
25086 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
25087 for private members before reporting a CS0103; if we find anything,
25090 2002-08-28 Martin Baulig <martin@gnome.org>
25092 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
25093 to check whether `closure_start_type == closure_invocation_type',
25094 we also need to check whether `m.DeclaringType == closure_invocation_type'
25095 before bypassing the permission checks. We might be accessing
25096 protected/private members from the base class.
25097 (TypeManager.RealMemberLookup): Only set private_ok if private
25098 members were requested via BindingFlags.NonPublic.
25100 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
25102 * expression.cs (MemberAccess.ResolveMemberAccess): Set
25103 MethodGroupExpr.IsExplicitImpl if appropriate.
25104 (Invocation.DoResolve): Don't report the CS0120 for explicit
25105 interface implementations.
25107 2002-08-27 Martin Baulig <martin@gnome.org>
25109 * expression.cs (Invocation.DoResolve): If this is a static
25110 method and we don't have an InstanceExpression, we must report
25113 2002-08-25 Martin Baulig <martin@gnome.org>
25115 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
25116 `==' between a valuetype and an object.
25118 2002-08-25 Miguel de Icaza <miguel@ximian.com>
25120 * ecore.cs (TypeExpr): Provide a ToString method.
25122 2002-08-24 Martin Baulig <martin@gnome.org>
25124 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
25125 now called proggie.dbg and it's a binary file.
25127 2002-08-23 Martin Baulig <martin@gnome.org>
25129 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
25131 2002-08-23 Martin Baulig <martin@gnome.org>
25133 * struct.cs (MyStructInfo.ctor): Make this work with empty
25134 structs; it's not allowed to use foreach() on null.
25136 2002-08-23 Martin Baulig <martin@gnome.org>
25138 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
25139 writer the full pathname of the generated assembly.
25141 2002-08-23 Martin Baulig <martin@gnome.org>
25143 * statements.cs (FlowBranching.UsageVector.MergeChildren):
25144 A `finally' block never returns or breaks; improved handling of
25147 2002-08-23 Martin Baulig <martin@gnome.org>
25149 * statement.cs (Throw.Resolve): Allow `throw null'.
25151 2002-08-23 Martin Baulig <martin@gnome.org>
25153 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
25154 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
25155 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
25156 MemberLookup would return a wrong event if this is an explicit
25157 interface implementation and the class has an event with the same
25160 2002-08-23 Martin Baulig <martin@gnome.org>
25162 * statement.cs (Block.AddChildVariableNames): New public method.
25163 (Block.AddChildVariableName): Likewise.
25164 (Block.IsVariableNameUsedInChildBlock): Likewise.
25165 (Block.AddVariable): Check whether a variable name has already
25166 been used in a child block.
25168 * cs-parser.jay (declare_local_variables): Mark all variable names
25169 from the current block as being used in a child block in the
25172 2002-08-23 Martin Baulig <martin@gnome.org>
25174 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
25175 find the symbol writer.
25177 * driver.cs: csc also allows the arguments to /define being
25178 separated by commas, not only by semicolons.
25180 2002-08-23 Martin Baulig <martin@gnome.org>
25182 * interface.cs (Interface.GetMembers): Added static check for events.
25184 2002-08-15 Martin Baulig <martin@gnome.org>
25186 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
25187 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
25189 * ecore.cs (Expression.MemberLookup): Added documentation and explained
25190 why the MethodData.EmitDestructor() change was necessary.
25192 2002-08-20 Martin Baulig <martin@gnome.org>
25194 * class.cs (TypeContainer.FindMembers): Added static check for events.
25196 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
25198 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
25199 use Type.GetEvents(), not Type.FindMembers().
25201 2002-08-20 Martin Baulig <martin@gnome.org>
25203 * decl.cs (MemberCache): Added a special method cache which will
25204 be used for method-only searched. This ensures that a method
25205 search will return a MethodInfo with the correct ReflectedType for
25208 2002-08-20 Martin Baulig <martin@gnome.org>
25210 * decl.cs (DeclSpace.FindMembers): Made this public.
25212 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25214 * delegate.cs: fixed build on windows.
25215 [FIXME: Filed as bug #29150: MCS must report these errors.]
25217 2002-08-19 Ravi Pratap <ravi@ximian.com>
25219 * ecore.cs (StandardConversionExists): Return a false
25220 if we are trying to convert the void type to anything else
25221 since that is not allowed.
25223 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
25224 we flag error 70 in the event an event is trying to be accessed
25225 directly from outside the declaring type.
25227 2002-08-20 Martin Baulig <martin@gnome.org>
25229 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
25230 MemberCache from typemanager.cs to decl.cs.
25232 2002-08-19 Martin Baulig <martin@gnome.org>
25234 * class.cs (TypeContainer): Implement IMemberContainer.
25235 (TypeContainer.DefineMembers): Create the MemberCache.
25236 (TypeContainer.FindMembers): Do better BindingFlags checking; only
25237 return public members if BindingFlags.Public was given, check
25238 whether members are static.
25240 2002-08-16 Martin Baulig <martin@gnome.org>
25242 * decl.cs (DeclSpace.Define): Splitted this in Define and
25243 DefineMembers. DefineMembers is called first and initializes the
25246 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
25247 DefineMembers() on all our DeclSpaces.
25249 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
25250 but call DefineMembers() on all nested interfaces. We call their
25251 Define() in our new Define() function.
25253 * interface.cs (Interface): Implement IMemberContainer.
25254 (Interface.Define): Moved all code except the attribute stuf to
25256 (Interface.DefineMembers): Initialize the member cache.
25258 * typemanager.cs (IMemberFinder): Removed this interface, we don't
25259 need this anymore since we can use MemberCache.FindMembers directly.
25261 2002-08-19 Martin Baulig <martin@gnome.org>
25263 * typemanager.cs (MemberCache): When creating the cache for an
25264 interface type, add all inherited members.
25265 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
25266 to `out bool used_cache' and documented it.
25267 (TypeManager.MemberLookup): If we already used the cache in the first
25268 iteration, we don't need to do the interfaces check.
25270 2002-08-19 Martin Baulig <martin@gnome.org>
25272 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
25273 here from IMemberFinder and don't implement this interface anymore.
25274 (DeclSpace.MemberCache): Moved here from IMemberFinder.
25276 * typemanager.cs (IMemberFinder): This interface is now only used by
25277 classes which actually support the member cache.
25278 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
25279 since we only put DeclSpaces into this Hashtable.
25280 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
25281 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
25283 2002-08-16 Martin Baulig <martin@gnome.org>
25285 * typemanager.cs (ICachingMemberFinder): Removed.
25286 (IMemberFinder.MemberCache): New property.
25287 (TypeManager.FindMembers): Merged this with RealFindMembers().
25288 This function will never be called from TypeManager.MemberLookup()
25289 so we can't use the cache here, just the IMemberFinder.
25290 (TypeManager.MemberLookup_FindMembers): Check whether the
25291 IMemberFinder has a MemberCache and call the cache's FindMembers
25293 (MemberCache): Rewrote larger parts of this yet another time and
25294 cleaned it up a bit.
25296 2002-08-15 Miguel de Icaza <miguel@ximian.com>
25298 * driver.cs (LoadArgs): Support quoting.
25300 (Usage): Show the CSC-like command line arguments.
25302 Improved a few error messages.
25304 2002-08-15 Martin Baulig <martin@gnome.org>
25306 * typemanager.cs (IMemberContainer.Type): New property.
25307 (IMemberContainer.IsInterface): New property.
25309 The following changes are conditional to BROKEN_RUNTIME, which is
25310 defined at the top of the file.
25312 * typemanager.cs (MemberCache.MemberCache): Don't add the base
25313 class'es members, but add all members from TypeHandle.ObjectType
25314 if we're an interface.
25315 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
25316 is the current type.
25317 (MemberCache.CacheEntry.Container): Removed this field.
25318 (TypeHandle.GetMembers): Include inherited members.
25320 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25322 * typemanager.cs: fixed compilation and added a comment on a field that
25325 2002-08-15 Martin Baulig <martin@gnome.org>
25327 * class.cs (ConstructorInitializer.Resolve): In the
25328 Expression.MemberLookup call, use the queried_type as
25331 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
25332 declared' attribute, it's always true.
25333 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
25334 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
25335 temporary wrapper for FindMembers which tells MemberLookup whether
25336 members from the base classes are included in the return value.
25337 This will go away soon.
25338 (TypeManager.MemberLookup): Use this temporary hack here; once the
25339 new MemberCache is completed, we don't need to do the DeclaredOnly
25340 looping here anymore since the MemberCache will take care of this.
25341 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
25342 (MemberCache): When creating the MemberCache for a class, get
25343 members from the current class and all its base classes.
25344 (MemberCache.CacheEntry.Container): New field. This is a
25345 temporary hack until the Mono runtime is fixed to distinguish
25346 between ReflectedType and DeclaringType. It allows us to use MCS
25347 with both the MS runtime and the unfixed Mono runtime without
25348 problems and without accecting performance.
25349 (MemberCache.SearchMembers): The DeclaredOnly looping from
25350 TypeManager.MemberLookup is now done here.
25352 2002-08-14 Martin Baulig <martin@gnome.org>
25354 * statement.cs (MyStructInfo.MyStructInfo): Don't call
25355 Type.GetFields on dynamic types but get the fields from the
25356 corresponding TypeContainer.
25357 (MyStructInfo.GetStructInfo): Added check for enum types.
25359 * typemanager.cs (MemberList.IsSynchronized): Implemented.
25360 (MemberList.SyncRoot): Implemented.
25361 (TypeManager.FilterWithClosure): No need to check permissions if
25362 closure_start_type == closure_invocation_type, don't crash if
25363 closure_invocation_type is null.
25365 2002-08-13 Martin Baulig <martin@gnome.org>
25367 Rewrote TypeContainer.FindMembers to use a member cache. This
25368 gives us a speed increase of about 35% for the self-hosting MCS
25369 build and of about 15-20% for the class libs (both on GNU/Linux).
25371 * report.cs (Timer): New class to get enhanced profiling. This
25372 whole class is "TIMER" conditional since it remarkably slows down
25375 * class.cs (MemberList): New class. This is an IList wrapper
25376 which we're now using instead of passing MemberInfo[]'s around to
25377 avoid copying this array unnecessarily.
25378 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
25379 (ICachingMemberFinder, IMemberContainer): New interface.
25380 (TypeManager.FilterWithClosure): If `criteria' is null, the name
25381 has already been checked, otherwise use it for the name comparision.
25382 (TypeManager.FindMembers): Renamed to RealMemberFinder and
25383 provided wrapper which tries to use ICachingMemberFinder.FindMembers
25384 if possible. Returns a MemberList, not a MemberInfo [].
25385 (TypeHandle): New class, implements IMemberContainer. We create
25386 one instance of this class per type, it contains a MemberCache
25387 which is used to do the member lookups.
25388 (MemberCache): New class. Each instance of this class contains
25389 all members of a type and a name-based hash table.
25390 (MemberCache.FindMembers): This is our new member lookup
25391 function. First, it looks up all members of the requested name in
25392 the hash table. Then, it walks this list and sorts out all
25393 applicable members and returns them.
25395 2002-08-13 Martin Baulig <martin@gnome.org>
25397 In addition to a nice code cleanup, this gives us a performance
25398 increase of about 1.4% on GNU/Linux - not much, but it's already
25399 half a second for the self-hosting MCS compilation.
25401 * typemanager.cs (IMemberFinder): New interface. It is used by
25402 TypeManager.FindMembers to call FindMembers on a TypeContainer,
25403 Enum, Delegate or Interface.
25404 (TypeManager.finder_to_member_finder): New PtrHashtable.
25405 (TypeManager.finder_to_container): Removed.
25406 (TypeManager.finder_to_delegate): Removed.
25407 (TypeManager.finder_to_interface): Removed.
25408 (TypeManager.finder_to_enum): Removed.
25410 * interface.cs (Interface): Implement IMemberFinder.
25412 * delegate.cs (Delegate): Implement IMemberFinder.
25414 * enum.cs (Enum): Implement IMemberFinder.
25416 * class.cs (TypeContainer): Implement IMemberFinder.
25418 2002-08-12 Martin Baulig <martin@gnome.org>
25420 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
25422 2002-08-12 Martin Baulig <martin@gnome.org>
25424 * ecore.cs (ITypeExpression): New interface for expressions which
25426 (TypeExpression): Renamed to TypeLookupExpression.
25427 (Expression.DoResolve): If we're doing a types-only lookup, the
25428 expression must implement the ITypeExpression interface and we
25429 call DoResolveType() on it.
25430 (SimpleName): Implement the new ITypeExpression interface.
25431 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
25432 hack, the situation that we're only looking up types can't happen
25433 anymore when this method is called. Moved the type lookup code to
25434 DoResolveType() and call it.
25435 (SimpleName.DoResolveType): This ITypeExpression interface method
25436 is now doing the types-only lookup.
25437 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
25438 (ResolveFlags): Added MaskExprClass.
25440 * expression.cs (MemberAccess): Implement the ITypeExpression
25442 (MemberAccess.DoResolve): Added support for a types-only lookup
25443 when we're called via ITypeExpression.DoResolveType().
25444 (ComposedCast): Implement the ITypeExpression interface.
25446 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
25447 Expression.Resolve() with ResolveFlags.Type instead.
25449 2002-08-12 Martin Baulig <martin@gnome.org>
25451 * interface.cs (Interface.Define): Apply attributes.
25453 * attribute.cs (Attribute.ApplyAttributes): Added support for
25454 interface attributes.
25456 2002-08-11 Martin Baulig <martin@gnome.org>
25458 * statement.cs (Block.Emit): Only check the "this" variable if we
25459 do not always throw an exception.
25461 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
25462 whether the property has a set accessor.
25464 2002-08-11 Martin Baulig <martin@gnome.org>
25466 Added control flow analysis support for structs.
25468 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
25469 with control flow analysis turned off.
25470 (IVariable): New interface.
25471 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
25472 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
25473 (FieldExpr.DoResolve): Resolve the instance expression with flow
25474 analysis turned off and do the definite assignment check after the
25475 resolving when we know what the expression will resolve to.
25477 * expression.cs (LocalVariableReference, ParameterReference):
25478 Implement the new IVariable interface, only call the flow analysis
25479 code if ec.DoFlowAnalysis is true.
25480 (This): Added constructor which takes a Block argument. Implement
25481 the new IVariable interface.
25482 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
25483 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
25484 This does the definite assignment checks for struct members.
25486 * class.cs (Constructor.Emit): If this is a non-static `struct'
25487 constructor which doesn't have any initializer, call
25488 Block.AddThisVariable() to tell the flow analysis code that all
25489 struct elements must be initialized before control returns from
25492 * statement.cs (MyStructInfo): New public class.
25493 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
25494 argument to this indexer. If non-zero, check an individual struct
25495 member, not the whole struct.
25496 (FlowBranching.CheckOutParameters): Check struct members.
25497 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
25498 overloaded versions of these methods which take an additional
25499 `int field_idx' argument to check struct members.
25500 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
25501 overloaded versions of these methods which take an additional
25502 `string field_name' argument to check struct member.s
25503 (VariableInfo): Implement the IVariable interface.
25504 (VariableInfo.StructInfo): New public property. Returns the
25505 MyStructInfo instance of the variable if it's a struct or null.
25506 (Block.AddThisVariable): New public method. This is called from
25507 Constructor.Emit() for non-static `struct' constructor which do
25508 not have any initializer. It creates a special variable for the
25509 "this" instance variable which will be checked by the flow
25510 analysis code to ensure that all of the struct's fields are
25511 initialized before control returns from the constructor.
25512 (UsageVector): Added support for struct members. If a
25513 variable/parameter is a struct with N members, we reserve a slot
25514 in the usage vector for each member. A struct is considered fully
25515 initialized if either the struct itself (slot 0) or all its
25516 members are initialized.
25518 2002-08-08 Martin Baulig <martin@gnome.org>
25520 * driver.cs (Driver.MainDriver): Only report an error CS5001
25521 if there were no compilation errors.
25523 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
25524 `UnsafeContext' property to determine whether the parent is in
25525 unsafe context rather than checking the parent's ModFlags:
25526 classes nested in an unsafe class are unsafe as well.
25528 2002-08-08 Martin Baulig <martin@gnome.org>
25530 * statement.cs (UsageVector.MergeChildren): Distinguish between
25531 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
25532 we return. Added test17() and test18() to test-154.cs.
25534 2002-08-08 Martin Baulig <martin@gnome.org>
25536 * typemanager.cs (TypeManager.FilterWithClosure): If we have
25537 Family access, make sure the invoking type isn't a subclass of the
25538 queried type (that'd be a CS1540).
25540 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25541 this method which takes an additional `Type invocation_type'.
25543 * expression.cs (BaseAccess.DoResolve): Use the base type as
25544 invocation and query type.
25545 (MemberAccess.DoResolve): If the lookup failed and we're about to
25546 report a CS0122, try a lookup with the ec.ContainerType - if this
25547 succeeds, we must report a CS1540.
25549 2002-08-08 Martin Baulig <martin@gnome.org>
25551 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25552 (MethodGroupExpr): Implement the IMemberExpr interface.
25554 * expression (MemberAccess.ResolveMemberAccess): No need to have
25555 any special code for MethodGroupExprs anymore, they're now
25558 2002-08-08 Martin Baulig <martin@gnome.org>
25560 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25561 Family, FamANDAssem and FamORAssem permissions.
25562 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25564 2002-08-08 Martin Baulig <martin@gnome.org>
25566 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25567 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25570 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25572 * driver.cs: implemented /resource option to embed managed resources.
25574 2002-08-07 Martin Baulig <martin@gnome.org>
25576 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25577 (FieldBase.HasFieldInitializer): New public property.
25578 (FieldBase.GetInitializerExpression): New public method. Resolves and
25579 returns the field initializer and makes sure it is only resolved once.
25580 (TypeContainer.EmitFieldInitializers): Call
25581 FieldBase.GetInitializerExpression to get the initializer, this ensures
25582 that it isn't resolved multiple times.
25584 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25585 the resolving process (SimpleName/MemberLookup) that we're currently
25586 emitting a field initializer (which must not access any instance members,
25587 this is an error CS0236).
25589 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25590 argument, if the `IsFieldInitializer' flag is set, we must report and
25591 error CS0236 and not an error CS0120.
25593 2002-08-07 Martin Baulig <martin@gnome.org>
25595 * ecore.cs (IMemberExpr): New public interface.
25596 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25597 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25598 if the expression is an IMemberExpr.
25600 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25601 to be null, implicitly default to `this' if we're non-static in
25602 this case. Simplified the code a lot by using the new IMemberExpr
25603 interface. Also fixed bug #28176 here.
25605 2002-08-06 Martin Baulig <martin@gnome.org>
25607 * cs-parser.jay (SimpleLookup): Removed. We need to create
25608 ParameterReferences during semantic analysis so that we can do a
25609 type-only search when resolving Cast, TypeOf and SizeOf.
25610 (block): Pass the `current_local_parameters' to the Block's
25613 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25614 argument to the constructor.
25615 (ConstructorInitializer.Resolve): Create a temporary implicit
25616 block with the parameters.
25618 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25619 references here if we aren't doing a type-only search.
25621 * statement.cs (Block): Added constructor which takes a
25622 `Parameters parameters' argument.
25623 (Block.Parameters): New public property.
25625 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25626 to `Parameters' and made it public readonly.
25628 2002-08-06 Martin Baulig <martin@gnome.org>
25630 * ecore.cs (Expression.Warning): Made this public as well.
25632 * report.cs (Report.Debug): Print the contents of collections.
25634 2002-08-06 Martin Baulig <martin@gnome.org>
25636 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25637 used to tell Resolve() which kinds of expressions it may return.
25638 (Expression.Resolve): Added overloaded version of this method which
25639 takes a `ResolveFlags flags' argument. This can be used to tell
25640 Resolve() which kinds of expressions it may return. Reports a
25642 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25643 ResolveFlags.SimpleName.
25644 (Expression.Error118): Added overloaded version of this method which
25645 takes a `ResolveFlags flags' argument. It uses the flags to determine
25646 which kinds of expressions are allowed.
25648 * expression.cs (Argument.ResolveMethodGroup): New public method.
25649 Resolves an argument, but allows a MethodGroup to be returned.
25650 This is used when invoking a delegate.
25652 * TODO: Updated a bit.
25654 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25656 Fixed compilation with csc.
25658 * ecore.cs: Expression.Error made public. Is this correct? Should
25659 Warning be made public too?
25661 * expression.cs: use ea.Location instead of ea.loc.
25662 [FIXME: Filed as bug #28607: MCS must report these errors.]
25664 2002-08-06 Martin Baulig <martin@gnome.org>
25666 * ecore.cs (Expression.loc): Moved the location here instead of
25667 duplicating it in all derived classes.
25668 (Expression.Location): New public property.
25669 (Expression.Error, Expression.Warning): Made them non-static and
25670 removed the location argument.
25671 (Expression.Warning): Added overloaded version which takes an
25672 `int level' argument.
25673 (Expression.Error118): Make this non-static and removed the
25674 expression and location arguments.
25675 (TypeExpr): Added location argument to the constructor.
25677 * expression.cs (StaticCallExpr): Added location argument to
25679 (Indirection, PointerArithmetic): Likewise.
25680 (CheckedExpr, UnCheckedExpr): Likewise.
25681 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25682 (StringPtr): Likewise.
25685 2002-08-05 Martin Baulig <martin@gnome.org>
25687 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25689 * assign.cs (Assign.DoResolve): Check whether the source
25690 expression is a value or variable.
25692 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25693 while resolving the corresponding blocks.
25695 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25696 an error, don't silently return null.
25698 * statement.cs (Block.AddVariable): Do the error reporting here
25699 and distinguish between CS0128 and CS0136.
25700 (Block.DoResolve): Report all unused labels (warning CS0164).
25701 (LabeledStatement): Pass the location to the constructor.
25702 (LabeledStatement.HasBeenReferenced): New property.
25703 (LabeledStatement.Resolve): Set it to true here.
25705 * statement.cs (Return.Emit): Return success even after reporting
25706 a type mismatch error (CS0126 or CS0127), this is what csc does and
25707 it avoids confusing the users with any consecutive errors.
25709 2002-08-05 Martin Baulig <martin@gnome.org>
25711 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25713 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25715 * expression.cs (MemberAccess.DoResolve): Silently return if an
25716 error has already been reported.
25718 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25719 error has already been reported.
25721 2002-08-05 Martin Baulig <martin@gnome.org>
25723 * statement.cs (UsageVector): Only initialize the `parameters'
25724 vector if we actually have any "out" parameters.
25726 2002-08-05 Martin Baulig <martin@gnome.org>
25728 * expression.cs (Binary.ResolveOperator): When combining delegates,
25729 they must have the same type.
25731 2002-08-05 Martin Baulig <martin@gnome.org>
25733 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25734 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25735 work with the ms runtime and we also don't need it: if we're a
25736 PropertyBuilder and not in the `indexer_arguments' hash, then we
25737 are a property and not an indexer.
25739 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25740 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25741 since the latter one doesn't work with the ms runtime.
25743 2002-08-03 Martin Baulig <martin@gnome.org>
25745 Fixed bugs #27998 and #22735.
25747 * class.cs (Method.IsOperator): New public field.
25748 (Method.CheckBase): Report CS0111 if there's already a method
25749 with the same parameters in the current class. Report CS0508 when
25750 attempting to change the return type of an inherited method.
25751 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25752 and it's not marked abstract or extern.
25753 (PropertyBase): New abstract base class for Property and Indexer.
25754 (PropertyBase.CheckBase): Moved here from Property and made it work
25756 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25757 the same so we can reuse it there.
25758 (Property, Indexer): Derive from PropertyBase.
25759 (MethodSignature.inheritable_property_signature_filter): New delegate
25760 to find properties and indexers.
25762 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25763 argument and improved error reporting.
25765 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25766 EmptyReadOnlyParameters and made it a property.
25768 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25769 version of this method which takes a `PropertyInfo indexer'.
25770 (TypeManager.RegisterIndexer): New method.
25772 * class.cs: Added myself as author of this file :-)
25774 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25776 * class.cs: fixed compilation on windoze.
25778 2002-08-03 Martin Baulig <martin@gnome.org>
25780 * interface.cs (Interface.GetInterfaceBases): Check whether all
25781 base interfaces are at least as accessible than the current one.
25783 * class.cs (TypeContainer.GetClassBases): Check whether base types
25784 are at least as accessible than the current type.
25785 (TypeContainer.AsAccessible): Implemented and made non-static.
25786 (MemberBase.CheckParameters): Report errors if the accessibility
25789 * delegate.cs (Delegate.Delegate): The default visibility is
25790 internal for top-level types and private for nested types.
25791 (Delegate.Define): Report errors if the accessibility checks fail.
25793 * enum.cs (Enum.Enum): The default visibility is internal for
25794 top-level types and private for nested types.
25795 (Enum.DefineType): Compute the correct visibility.
25797 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25798 function which takes a `bool is_toplevel' instead of a TypeContainer.
25800 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25803 2002-08-02 Martin Baulig <martin@gnome.org>
25805 * expression.cs (LocalVariableReferenc): Added constructor which
25806 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25807 (LocalVariableReference.IsReadOnly): New property.
25808 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25809 variable is readonly, use our own readonly flag to do this; you can
25810 use the new constructor to get a writable reference to a read-only
25813 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25814 reference to the local variable.
25816 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25818 * rootcontext.cs (ResolveCore): Also include System.Exception
25820 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25821 we reach an EmptyStatement.
25823 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25826 * expression.cs (Binary.ResolveOperator): Check error result in
25829 use brtrue/brfalse directly and avoid compares to null.
25831 2002-08-02 Martin Baulig <martin@gnome.org>
25833 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25834 Fixes bug #28407, added test-155.cs.
25836 2002-08-01 Martin Baulig <martin@gnome.org>
25838 * class.cs (Event.EmitDefaultMethod): Make this work with static
25839 events. Fixes #28311, added verify-3.cs.
25841 2002-08-01 Martin Baulig <martin@gnome.org>
25843 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25844 `is_disposable' fields.
25845 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25846 `hm.is_disposable' if we're using the collection pattern.
25847 (Foreach.EmitCollectionForeach): Use the correct type for the
25848 enumerator's local variable, only emit the try/finally block if
25849 necessary (fixes #27713).
25851 2002-08-01 Martin Baulig <martin@gnome.org>
25853 * ecore.cs (Expression.report118): Renamed to Error118 and made
25856 * statement.cs (Throw.Resolve): Check whether the expression is of
25857 the correct type (CS0118) and whether the type derives from
25858 System.Exception (CS0155).
25859 (Catch.Resolve): New method. Do the type lookup here and check
25860 whether it derives from System.Exception (CS0155).
25861 (Catch.CatchType, Catch.IsGeneral): New public properties.
25863 * typemanager.cs (TypeManager.exception_type): Added.
25865 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25867 * driver.cs: Updated About function.
25869 2002-07-31 Martin Baulig <martin@gnome.org>
25871 Implemented Control Flow Analysis.
25873 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25874 (EmitContext.CurrentBranching): Added.
25875 (EmitContext.StartFlowBranching): Added.
25876 (EmitContext.EndFlowBranching): Added.
25877 (EmitContext.KillFlowBranching): Added.
25878 (EmitContext.IsVariableAssigned): Added.
25879 (EmitContext.SetVariableAssigned): Added.
25880 (EmitContext.IsParameterAssigned): Added.
25881 (EmitContext.SetParameterAssigned): Added.
25882 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25883 Added control flow analysis stuff here.
25885 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25886 resolve the expression as lvalue.
25887 (LocalVariableReference.DoResolve): Check whether the variable has
25888 already been assigned.
25889 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25890 the parameter as assigned here.
25891 (ParameterReference.DoResolve): Check whether the parameter has already
25893 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25894 expression as lvalue.
25896 * statement.cs (FlowBranching): New class for the flow analysis code.
25897 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25898 (LabeledStatement.IsDefined): New public property.
25899 (LabeledStatement.AddUsageVector): New public method to tell flow
25900 analyis that the label may be reached via a forward jump.
25901 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25903 (VariableInfo.Number): New public field. This is used by flow analysis
25904 to number all locals of a block.
25905 (Block.CountVariables): New public property. This is the number of
25906 local variables in this block (including the locals from all parent
25908 (Block.EmitMeta): Number all the variables.
25910 * statement.cs: Added flow analysis support to all classes.
25912 2002-07-31 Martin Baulig <martin@gnome.org>
25914 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25915 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25916 then use this argument.
25918 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25920 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25921 use this to specify /define options.
25923 2002-07-29 Martin Baulig <martin@gnome.org>
25925 * statement.cs (Fixed): Moved all code that does variable lookups
25926 and resolvings from Emit to Resolve.
25928 * statement.cs (For): Moved all code that does variable lookups
25929 and resolvings from Emit to Resolve.
25931 * statement.cs (Using): Moved all code that does variable lookups
25932 and resolvings from Emit to Resolve.
25934 2002-07-29 Martin Baulig <martin@gnome.org>
25936 * attribute.cs (Attribute.Resolve): Explicitly catch a
25937 System.NullReferenceException when creating the
25938 CustromAttributeBuilder and report a different warning message.
25940 2002-07-29 Martin Baulig <martin@gnome.org>
25942 * support.cs (ParameterData.ParameterName): Added method to
25943 get the name of a parameter.
25945 * typemanager.cs (TypeManager.IsValueType): New public method.
25947 2002-07-29 Martin Baulig <martin@gnome.org>
25949 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25950 is a flag which specifies that it's either ref or out.
25951 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25952 the out parameter to `out Parameter.Modifier mod', also set the
25953 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25955 * support.cs (InternalParameters.ParameterModifier): Distinguish
25956 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25957 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25959 * expression.cs (Argument.GetParameterModifier): Distinguish
25960 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25961 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25963 2002-07-29 Martin Baulig <martin@gnome.org>
25965 * expression.cs (ParameterReference.ParameterReference): Added
25966 `Location loc' argument to the constructor.
25968 * cs-parser.jay: Pass location to ParameterReference.
25970 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25972 * statement.cs (Try): Initialize the location.
25974 * cs-parser.jay: pass location to Try.
25976 * expression.cs (Unary.Reduce): Change the prototype to return
25977 whether a constant fold could be performed or not. The result is
25978 returned in an out parameters. In the case of Indirection and
25979 AddressOf, we want to perform the full tests.
25981 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25983 * statement.cs (Statement.Emit): Flag dead code.
25985 2002-07-27 Andrew Birkett <andy@nobugs.org>
25987 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25989 2002-07-27 Martin Baulig <martin@gnome.org>
25991 * class.cs (MethodData.Define): Put back call to
25992 TypeManager.AddMethod(), accidentally commented this out.
25994 * report.cs (Debug): New public method to print debugging information,
25995 this is `[Conditional ("DEBUG")]'.
25997 2002-07-26 Martin Baulig <martin@gnome.org>
25999 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
26000 (switch_statement): Push the current_block to the switch_stack and
26001 pop it again when we're done with the switch.
26002 (switch_section): The new block is a child of the current_block.
26003 Fixes bug #24007, added test-152.cs.
26005 2002-07-27 Martin Baulig <martin@gnome.org>
26007 * expression.cs (Invocation.EmitArguments): When calling a varargs
26008 function with only its fixed arguments, we need to pass an empty
26011 2002-07-27 Martin Baulig <martin@gnome.org>
26013 Mono 0.13 has been released.
26015 2002-07-25 Miguel de Icaza <miguel@ximian.com>
26017 * driver.cs: Rename --resource to --linkres, because that is what
26018 we do currently, we dont support --resource yet.
26020 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
26022 2002-07-25 Martin Baulig <martin@gnome.org>
26024 * class.cs (MethodData): New public class. This is a `method builder'
26025 class for a method or one accessor of a Property/Indexer/Event.
26026 (MethodData.GetMethodFlags): Moved here from MemberBase.
26027 (MethodData.ApplyAttributes): Likewise.
26028 (MethodData.ApplyObsoleteAttribute): Likewise.
26029 (MethodData.ApplyConditionalAttribute): Likewise.
26030 (MethodData.ApplyDllImportAttribute): Likewise.
26031 (MethodData.CheckAbstractAndExternal): Likewise.
26032 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
26033 (MethodData.Emit): Formerly known as Method.Emit().
26034 (MemberBase): Moved everything which was specific to a single
26035 accessor/method to MethodData.
26036 (Method): Create a new MethodData and call Define() and Emit() on it.
26037 (Property, Indexer, Event): Create a new MethodData objects for each
26038 accessor and call Define() and Emit() on them.
26040 2002-07-25 Martin Baulig <martin@gnome.org>
26042 Made MethodCore derive from MemberBase to reuse the code from there.
26043 MemberBase now also checks for attributes.
26045 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
26046 (MemberBase.GetMethodFlags): Moved here from class Method and marked
26048 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
26049 `CallingConventions cc' and `Attributes opt_attrs' arguments.
26050 (MemberBase.ApplyAttributes): New virtual method; applies the
26051 attributes to a method or accessor.
26052 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
26053 (MemberBase.ApplyConditionalAttribute): Likewise.
26054 (MemberBase.ApplyDllImportAttribute): Likewise.
26055 (MemberBase.CheckAbstractAndExternal): Likewise.
26056 (MethodCore.ParameterTypes): This is now a property instead of a
26057 method, it's initialized from DoDefineParameters().
26058 (MethodCore.ParameterInfo): Removed the set accessor.
26059 (MethodCore.DoDefineParameters): New protected virtual method to
26060 initialize ParameterTypes and ParameterInfo.
26061 (Method.GetReturnType): We can now simply return the MemberType.
26062 (Method.GetMethodFlags): Override the MemberBase version and add
26063 the conditional flags.
26064 (Method.CheckBase): Moved some code from Define() here, call
26065 DoDefineParameters() here.
26066 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
26067 here to avoid some larger code duplication.
26068 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
26069 ensure that abstract and external accessors don't declare a body.
26071 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
26072 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
26073 lookup in the attribute's parent classes, so we need to abort as soon
26074 as we found the first match.
26075 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
26076 the attribute has no arguments.
26078 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
26081 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26083 * cs-parser.jay: reverted previous patch.
26085 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26087 * cs-parser.jay: fixed bug #22119.
26089 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26091 * attribute.cs: fixed compilation. The error was:
26092 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
26093 be assigned to before control leaves the current method."
26094 [FIXME: Filed as bug #28186: MCS must report this error.]
26096 2002-07-25 Martin Baulig <martin@gnome.org>
26098 * attribute.cs (Attribute.Conditional_GetConditionName): New static
26099 method to pull the condition name ouf of a Conditional attribute.
26100 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
26101 the obsolete message and error flag out of an Obsolete attribute.
26103 * class.cs (Method.GetMethodFlags): New public method to get the
26104 TypeManager.MethodFlags for this method.
26105 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
26107 (Method.Define): Get and apply the Obsolete and Conditional attributes;
26108 if we're overriding a virtual function, set the new private variable
26109 `parent_method'; call the new TypeManager.AddMethod().
26111 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
26112 the MethodBuilder and the Method in a PtrHashtable.
26113 (TypeManager.builder_to_method): Added for this purpose.
26114 (TypeManager.MethodFlags): Added IsObsoleteError.
26115 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
26116 Obsolete and Conditional arguments in MethodBuilders. If we discover
26117 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
26118 the message from the attribute.
26120 2002-07-24 Martin Baulig <martin@gnome.org>
26122 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
26123 preprocessor directives, ensure that the argument to #define/#undef is
26124 exactly one identifier and that it's actually an identifier.
26126 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
26129 2002-07-24 Martin Baulig <martin@gnome.org>
26131 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
26132 initialize it to TypeManager.object_type in the constructor.
26133 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
26134 of the `hm.get_current' method if we're using the collection pattern.
26135 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
26136 for the explicit conversion to make it work when we're using the collection
26137 pattern and the `Current' property has a different return type than `object'.
26140 2002-07-24 Martin Baulig <martin@gnome.org>
26142 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
26143 does not match, but don't report any errors. This method is called in
26144 order for all methods in a MethodGroupExpr until a matching method is
26145 found, so we don't want to bail out if the first method doesn't match.
26146 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
26147 matches, report the 123. Fixes #28070.
26149 2002-07-24 Martin Baulig <martin@gnome.org>
26151 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
26152 TypeManager.TypeToCoreType() to the top of the method so the
26153 following equality checks will work. Fixes #28107.
26155 2002-07-24 Martin Baulig <martin@gnome.org>
26157 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
26158 operand is of type uint, and the other operand is of type sbyte,
26159 short or int, the operands are converted to type long." -
26160 Actually do what this comment already told us. Fixes bug #28106,
26163 2002-07-24 Martin Baulig <martin@gnome.org>
26165 * class.cs (MethodBase): New abstract class. This is now a base
26166 class for Property, Indexer and Event to avoid some code duplication
26167 in their Define() and DefineMethods() methods.
26168 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
26169 generic methods for Define() and DefineMethods().
26170 (FieldBase): Derive from MemberBase, not MemberCore.
26171 (Property): Derive from MemberBase, not MemberCore.
26172 (Property.DefineMethod): Moved all the code from this method to the
26173 new MethodBase.DefineAccessor(), just call it with appropriate
26175 (Property.Define): Call the new Property.DoDefine(), this does some
26176 sanity checks and we don't need to duplicate the code everywhere.
26177 (Event): Derive from MemberBase, not MemberCore.
26178 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
26179 accessors, this will also make them work with interface events.
26180 (Indexer): Derive from MemberBase, not MemberCore.
26181 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
26182 (Indexer.Define): Use the new MethodBase functions.
26184 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
26185 argument to the constructor.
26186 (Interface.FindMembers): Added support for interface events.
26187 (Interface.PopluateEvent): Implemented.
26189 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
26191 2002-07-22 Miguel de Icaza <miguel@ximian.com>
26193 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
26194 but this is required to check for a method name being the same as
26195 the containing class.
26199 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26201 * interface.cs: initialize variable.
26203 2002-07-23 Martin Baulig <martin@gnome.org>
26205 Implemented the IndexerName attribute in interfaces.
26207 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
26208 name if this is an explicit interface implementation.
26209 (Indexer.InterfaceIndexerName): New public variable. If we're
26210 implementing an interface indexer, this is the IndexerName in that
26211 interface. Otherwise, it's the IndexerName.
26212 (Indexer.DefineMethod): If we're implementing interface indexer,
26213 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
26214 and Pending.ImplementIndexer methods.
26215 (Indexer.Define): Also define the PropertyBuilder if we're
26216 implementing an interface indexer and this is neither an explicit
26217 interface implementation nor do the IndexerName match the one in
26220 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
26221 If a method is defined here, then we always need to create a proxy
26222 for it. This is used when implementing interface indexers.
26223 (Pending.IsInterfaceIndexer): New public method.
26224 (Pending.ImplementIndexer): New public method.
26225 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
26226 This is used when implementing interface indexers to define a proxy
26228 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
26229 define a proxy if necessary.
26231 * interface.cs (Interface.IndexerName): New public variable.
26232 (Interface.PopulateIndexer): Set the IndexerName.
26233 (Interface.DefineIndexers): New private method. Populate all the
26234 indexers and make sure their IndexerNames match.
26236 * typemanager.cs (IndexerPropertyName): Added support for interface
26239 2002-07-22 Martin Baulig <martin@gnome.org>
26241 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
26242 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
26243 ret if HasReturnLabel.
26244 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
26247 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
26248 and set the ec.LoopBeginTryCatchLevel.
26249 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
26250 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
26251 the current ec.TryCatchLevel, the branch goes out of an exception
26252 block. In this case, we need to use Leave and not Br.
26254 2002-07-22 Martin Baulig <martin@gnome.org>
26256 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
26257 block unless the block does not always return or it is contained in
26258 another try { ... } catch { ... } block. Fixes bug #26506.
26259 Added verify-1.cs to the test suite.
26261 2002-07-22 Martin Baulig <martin@gnome.org>
26263 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
26264 then we do not always return. Fixes bug #24985.
26266 2002-07-22 Martin Baulig <martin@gnome.org>
26268 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
26269 lookup on a per-class level; ie. walk up the class hierarchy until we
26270 found at least one applicable method, then choose the best among them.
26271 Fixes bug #24463 and test-29.cs.
26273 2002-07-22 Martin Baulig <martin@gnome.org>
26275 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
26276 return types of the methods. The return type is not part of the
26277 signature and we must not check it to make the `new' modifier work.
26278 Fixes bug #27999, also added test-147.cs.
26279 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
26281 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
26282 on the method's return type.
26284 2002-07-21 Martin Baulig <martin@gnome.org>
26286 * assign.cs: Make this work if the rightmost source is a constant and
26287 we need to do an implicit type conversion. Also adding a few more tests
26288 to test-38.cs which should have caught this.
26290 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
26291 target in the makefile for this. The makefile.gnu is primarily intended
26292 for end-users who don't want to debug the compiler.
26294 2002-07-21 Martin Baulig <martin@gnome.org>
26296 * assign.cs: Improved the Assign class so it can now handle embedded
26297 assignments (X = Y = Z = something). As a side-effect this'll now also
26298 consume less local variables. test-38.cs now passes with MCS, added
26299 a few new test cases to that test.
26301 2002-07-20 Martin Baulig <martin@gnome.org>
26303 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
26304 instructions. Fixes bug #27977, also added test-146.cs.
26306 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26308 * cs-tokenizer.cs: fixed getHex ().
26310 2002-07-19 Martin Baulig <martin@gnome.org>
26312 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
26313 not Type.GetType() to lookup the array type. This is needed when
26314 we're constructing an array of a user-defined type.
26315 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
26316 single-dimensional arrays, but also for single-dimensial arrays of
26319 2002-07-19 Martin Baulig <martin@gnome.org>
26321 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
26322 this function is called, it's not allowed to share LocalBuilders
26323 among ILGenerators.
26325 2002-07-19 Martin Baulig <martin@gnome.org>
26327 * expression.cs (Argument.Resolve): Report an error 118 when trying
26328 to pass a type as argument.
26330 2002-07-18 Martin Baulig <martin@gnome.org>
26332 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
26333 Conv_R_Un for the signed `long' type.
26335 2002-07-15 Miguel de Icaza <miguel@ximian.com>
26337 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
26338 `expr' for the temporary result, as that will fail if we do
26339 multiple resolves on the same expression.
26341 2002-07-05 Miguel de Icaza <miguel@ximian.com>
26343 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
26344 ec.TypeContainer for looking up aliases.
26346 * class.cs (TypeContainer): Remove LookupAlias from here.
26348 * decl.cs (DeclSpace); Move here.
26350 2002-07-01 Miguel de Icaza <miguel@ximian.com>
26352 * class.cs (FindMembers): Only call filter if the constructor
26353 bulider is not null.
26355 Also handle delegates in `NestedTypes' now. Now we will perform
26356 type lookups using the standard resolution process. This also
26359 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
26360 This uses Expressions (the limited kind that can be parsed by the
26361 tree) instead of strings.
26363 * expression.cs (ComposedCast.ToString): Implement, used to flag
26364 errors since now we have to render expressions.
26366 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
26369 * ecore.cs (SimpleName.ToString): ditto.
26371 * cs-parser.jay: Instead of using strings to assemble types, use
26372 Expressions to assemble the type (using SimpleName, ComposedCast,
26373 MemberAccess). This should fix the type lookups in declarations,
26374 because we were using a different code path for this.
26376 * statement.cs (Block.Resolve): Continue processing statements
26377 even when there is an error.
26379 2002-07-17 Miguel de Icaza <miguel@ximian.com>
26381 * class.cs (Event.Define): Also remove the `remove' method from
26382 the list of pending items.
26384 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
26385 generate more compact code.
26387 2002-07-17 Martin Baulig <martin@gnome.org>
26389 * const.cs (Const.LookupConstantValue): Add support for constant
26390 `unchecked' and `checked' expressions.
26391 Also adding test case test-140.cs for this.
26393 2002-07-17 Martin Baulig <martin@gnome.org>
26395 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
26396 check whether mi.ReturnType implements the IEnumerator interface; the
26397 `==' and the IsAssignableFrom() will fail in this situation.
26399 2002-07-16 Ravi Pratap <ravi@ximian.com>
26401 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
26404 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26406 * expression.cs: fixed bug #27811.
26408 2002-07-14 Miguel de Icaza <miguel@ximian.com>
26410 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
26411 Molaro: when we are a ref, the value already contains a pointer
26412 value, do not take the address of it.
26414 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26415 * removed mb-parser.jay and mb-tokenizer.cs
26417 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26419 * expression.cs: check against the building corlib void type.
26421 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
26423 * ecore.cs: fix for valuetype static readonly fields: when
26424 initializing them, we need their address, not the address of a copy.
26426 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
26428 * typemanager.cs: register also enum_type in corlib.
26430 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26432 * class.cs: allow calling this (but not base) initializers in structs.
26434 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
26436 * ecore.cs: make sure we compare against the building base types
26439 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
26441 * typemanager.cs: fix TypeToCoreType() to handle void and object
26442 (corlib gets no more typerefs after this change).
26444 2002-07-12 Miguel de Icaza <miguel@ximian.com>
26446 * expression.cs (ArrayCreation.EmitArrayArguments): use
26447 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
26449 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
26450 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
26451 array indexes, the runtime actually forbids them.
26453 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
26454 for array arguments here.
26456 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
26457 instead of the default for ValueTypes.
26459 (New.DoEmit): Use IsValueType instead of
26460 IsSubclassOf (value_type)
26461 (New.DoResolve): ditto.
26462 (Invocation.EmitCall): ditto.
26464 * assign.cs (Assign): ditto.
26466 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
26467 Statements *are* currently doing part of their resolution during
26470 Expressions do always resolve during resolve, but statements are
26471 only required to propagate resolution to their children.
26473 2002-07-11 Miguel de Icaza <miguel@ximian.com>
26475 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
26477 (LoadAssembly): Do not add the dll if it is already specified
26479 (MainDriver): Add the System directory to the link path at the end,
26480 after all the other -L arguments.
26482 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
26483 wrong opcode for loading bytes and bools (ldelem.i1 instead of
26484 ldelem.u1) and using the opposite for sbytes.
26486 This fixes Digger, and we can finally run it.
26488 * driver.cs (UnixParseOption): Move the option parsing here.
26489 (CSCParseOption): Implement CSC-like parsing of options.
26491 We now support both modes of operation, the old Unix way, and the
26492 new CSC-like way. This should help those who wanted to make cross
26493 platform makefiles.
26495 The only thing broken is that /r:, /reference: and /lib: are not
26496 implemented, because I want to make those have the same semantics
26497 as the CSC compiler has, and kill once and for all the confussion
26498 around this. Will be doing this tomorrow.
26500 * statement.cs (Unsafe.Resolve): The state is checked during
26501 resolve, not emit, so we have to set the flags for IsUnsfe here.
26503 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26505 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
26506 not catch the Error_ObjectRefRequired in SimpleName (as it is
26507 possible to have a class/instance variable name that later gets
26508 deambiguated), we have to check this here.
26510 2002-07-10 Ravi Pratap <ravi@ximian.com>
26512 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
26513 make static and put into Expression.
26515 (Event.Define): Register the private field of the event with the
26516 TypeManager so that GetFieldFromEvent can get at it.
26518 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
26519 keep track of the private field associated with an event which
26522 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
26525 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
26527 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26529 * expression.cs (Binary.EmitBranchable): this routine emits the
26530 Binary expression in a branchable context. This basically means:
26531 we need to branch somewhere, not just get the value on the stack.
26533 This works together with Statement.EmitBoolExpression.
26535 * statement.cs (Statement.EmitBoolExpression): Use
26538 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26540 * statement.cs (For): Reduce the number of jumps in loops.
26542 (For): Implement loop inversion for the For statement.
26544 (Break): We can be breaking out of a Try/Catch controlled section
26545 (foreach might have an implicit try/catch clause), so we need to
26546 use Leave instead of Br.
26548 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26549 now). If the instace expression supports IMemoryLocation, we use
26550 the AddressOf method from the IMemoryLocation to extract the
26551 address instead of emitting the instance.
26553 This showed up with `This', as we were emitting the instance
26554 always (Emit) instead of the Address of This. Particularly
26555 interesting when This is a value type, as we dont want the Emit
26556 effect (which was to load the object).
26558 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26560 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26562 * statement.cs (Checked): Set the CheckedState during the resolve
26563 process too, as the ConvCast operations track the checked state on
26564 the resolve process, and not emit.
26566 * cs-parser.jay (namespace_member_declaration): Flag that we have
26567 found a declaration when we do. This is used to flag error 1529
26569 * driver.cs: Report ok when we display the help only.
26571 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26573 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26575 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26577 * cs-tokenizer.cs (define): We also have to track locally the
26578 defines. AllDefines is just used for the Conditional Attribute,
26579 but we also need the local defines for the current source code.
26581 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26583 * statement.cs (While, For, Do): These loops can exit through a
26584 Break statement, use this information to tell whether the
26585 statement is the last piece of code.
26587 (Break): Flag that we break.
26589 * codegen.cs (EmitContexts): New `Breaks' state variable.
26591 2002-07-03 Martin Baulig <martin@gnome.org>
26593 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26594 modifiers in method declarations in structs. Otherwise, you won't
26595 be able to override things like Object.Equals().
26597 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26599 * class.cs (Method, Property, Indexer): Do not allow the public
26600 modifier to be used in explicit interface implementations.
26602 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26603 override modifiers in method declarations in structs
26605 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26607 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26608 integer or real overflow, report an error
26610 2002-07-02 Martin Baulig <martin@gnome.org>
26612 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26613 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26614 to tell the runtime about our newly created System.Object and
26615 System.ValueType types.
26617 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26619 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26620 struct instead of Ldarg/Starg.
26622 2002-07-02 Martin Baulig <martin@gnome.org>
26624 * expression.cs (Indirection.Indirection): Call
26625 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26627 2002-07-02 Martin Baulig <martin@gnome.org>
26629 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26630 ValueType, call TypeManager.TypeToCoreType() on it.
26631 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26632 the OpCodes.Newarr argument.
26634 2002-07-02 Martin Baulig <martin@gnome.org>
26636 * expression.cs (Invocation.EmitCall): When compiling corlib,
26637 replace all calls to the system's System.Array type to calls to
26638 the newly created one.
26640 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26641 System.Array methods.
26642 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26643 from the system's System.Array type which must be replaced.
26645 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26647 * typemanager.cs: load unverifiable_code_ctor so we can build
26648 corlib using the correct type. Avoid using GetTypeCode() with
26650 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26651 TypeManager.object_type to allow building corlib.
26653 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26655 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26657 2002-07-01 Martin Baulig <martin@gnome.org>
26659 * class.cs: Make the last change actually work, we need to check
26660 whether `ifaces != null' to avoid a crash.
26662 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26664 * class.cs: when we build structs without fields that implement
26665 interfaces, we need to add the interfaces separately, since there is
26666 no API to both set the size and add the interfaces at type creation
26669 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26671 * expression.cs: the dimension arguments to the array constructors
26672 need to be converted if they are a long.
26674 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26676 * class.cs: don't emit ldarg.0 if there is no parent constructor
26677 (fixes showstopper for corlib).
26679 2002-06-29 Martin Baulig <martin@gnome.org>
26681 MCS now compiles corlib on GNU/Linux :-)
26683 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26684 ie. check for MethodImplOptions.InternalCall.
26686 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26687 and TypeManager.attribute_type are null, so we must explicitly check
26688 whether parent is not null to find out whether it's an attribute type.
26689 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26690 and SetBuilder, not only if the property is neither abstract nor external.
26691 This is necessary to set the MethodImplOptions on the accessor methods.
26692 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26693 SetBuilder, see Property.Emit().
26695 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26696 populate "System.Object", "System.ValueType" and "System.Attribute" since
26697 they've already been populated from BootCorlib_PopulateCoreTypes().
26699 2002-06-29 Martin Baulig <martin@gnome.org>
26701 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26702 is the NullLiteral, we also need to make sure that target_type is not
26705 2002-06-29 Martin Baulig <martin@gnome.org>
26707 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26708 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26709 before calling BootstrapCorlib_ResolveDelegate ().
26711 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26713 * statement.cs: fixed build-breaker. All tests passed ok.
26715 2002-06-27 Martin Baulig <martin@gnome.org>
26717 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26718 for System.Decimal when compiling corlib.
26720 2002-06-27 Martin Baulig <martin@gnome.org>
26722 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26723 switch blocks which contain nothing but a default clause.
26725 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26727 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26729 2002-06-27 Martin Baulig <martin@gnome.org>
26731 * ecore.cs (PropertyExpr.PropertyExpr): Call
26732 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26734 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26735 is already a TypeBuilder.
26737 2002-06-27 Martin Baulig <martin@gnome.org>
26739 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26740 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26741 the "from an array-type to System.Array" case. This makes it work
26742 when compiling corlib.
26744 2002-06-27 Martin Baulig <martin@gnome.org>
26746 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26747 non-static PropertyExpr, set its InstanceExpression. This makes
26748 the `ICollection.Count' property work in System/Array.cs.
26750 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26752 * driver.cs: Made error handling more consistent. Errors now
26753 tracked by Report class, so many methods which used to return int
26754 now return void. Main() now prints success/failure and
26755 errors/warnings message.
26757 Renamed '--probe' compiler argument to '--expect-error'. Removed
26758 the magic number return values (123 and 124). Now, if the
26759 expected error occurs, the compiler exits with success (exit value
26760 0). If the compilation completes without seeing that particular
26761 error, the compiler exits with failure (exit value 1). The
26762 makefile in mcs/errors has been changed to handle the new behaviour.
26764 * report.cs: Made 'expected error' number a property and renamed
26765 it from 'Probe' to 'ExpectedError'.
26767 * genericparser.cs: Removed error handling support, since it is
26768 now all done by Report class.
26770 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26771 class, so parse() no longer returns an int.
26773 * namespace.cs: Use Report.Error instead of GenericParser.error
26775 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26777 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26778 TypeContainer.AddOperator): At the front of the list put the
26779 explicit implementations, so they get resolved/defined first.
26781 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26783 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26784 interface type is implemented by this TypeContainer. Used during
26785 explicit interface implementation.
26787 (Property.Define, Indexer.Define, Method.Define): Validate that
26788 the given interface in the explicit implementation is one of the
26789 base classes for the containing type.
26791 Also if we are explicitly implementing an interface, but there is
26792 no match in the pending implementation table, report an error.
26794 (Property.Define): Only define the property if we are
26795 not explicitly implementing a property from an interface. Use the
26796 correct name also for those properties (the same CSC uses,
26797 although that is really not needed).
26799 (Property.Emit): Do not emit attributes for explicitly implemented
26800 properties, as there is no TypeBuilder.
26802 (Indexer.Emit): ditto.
26804 Hiding then means that we do not really *implement* a pending
26805 implementation, which makes code fail.
26807 2002-06-22 Martin Baulig <martin@gnome.org>
26809 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26810 the return value of Object.GetType(). [FIXME: we need to do this whenever
26811 we get a type back from the reflection library].
26813 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26815 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26817 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26819 * attribute.cs: Return null if we can not look up the type.
26821 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26822 the interface types found.
26824 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26825 interface types found.
26827 * typemanager.cs (GetInterfaces): Make this routine returns alll
26828 the interfaces and work around the lame differences between
26829 System.Type and System.Reflection.Emit.TypeBuilder in the results
26830 result for GetInterfaces.
26832 (ExpandInterfaces): Given an array of interface types, expand and
26833 eliminate repeated ocurrences of an interface. This expands in
26834 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26837 2002-06-21 Martin Baulig <martin@gnome.org>
26839 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26842 2002-06-21 Martin Baulig <martin@gnome.org>
26844 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26845 and called with one of the core types, return the corresponding typebuilder for
26848 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26851 2002-06-21 Martin Baulig <martin@gnome.org>
26853 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26854 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26855 (Expression.ConvertReferenceExplicit): Likewise.
26857 * expression.cs (ElementAccess.DoResolve): Likewise.
26858 (ElementAccess.DoResolveLValue): Likewise.
26860 2002-06-10 Martin Baulig <martin@gnome.org>
26862 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26863 add the "value" parameter to the parameter list.
26865 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26868 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26870 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26871 the argument to an int, uint, long or ulong, per the spec. Also
26872 catch negative constants in array creation.
26874 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26876 * class.cs: do not allow the same interface to appear twice in
26877 the definition list.
26879 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26881 * ecore.cs: don't use ldlen with System.Array.
26883 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26885 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26887 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26889 * modifiers.cs: produce correct field attributes for protected
26890 internal. Easy fix so miguel can work on ther harder stuff:-)
26892 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26894 * pending.cs: New file. Move the code from class.cs here.
26895 Support clearning the pending flag for all methods (when not doing
26896 explicit interface implementation).
26898 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26900 * rootcontext.cs: added a couple more types needed to bootstrap.
26902 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26904 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26905 constructor in the type, instead of any constructor in the type
26906 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26907 a bug in the Mono runtime when applying the params attribute).
26909 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26910 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26912 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26914 * expression.cs (Unary.ResolveOperator): Use TypeManager
26915 to resolve the type.
26917 2002-06-13 Ravi Pratap <ravi@ximian.com>
26919 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26922 * enum.cs (AddEnumMember): Add support to store the attributes associated
26923 with each member too.
26925 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26926 field builders too - this takes care of the enum member case.
26928 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26930 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26931 address-of operator on both value types and pointers.
26933 2002-06-10 Martin Baulig <martin@gnome.org>
26935 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26936 PropertyBuilder to the `property_builders' list.
26938 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26939 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26940 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26941 find any indexers which are inherited from an interface.
26943 2002-06-09 Martin Baulig <martin@gnome.org>
26945 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26946 the same type as the constant if necessary. There's also a test-130.cs
26949 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26951 * typemanager.cs (TypeManager.ChangeType): Previously known as
26952 Enum.ChangeEnumType().
26954 2002-06-09 Martin Baulig <martin@gnome.org>
26956 * expression.cs (Cast.TryReduce): Added support for consts.
26958 2002-06-08 Ravi Pratap <ravi@ximian.com>
26960 * class.cs (Accessor): Hold attributes information so we can pass
26963 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26964 Modify to pass in attributes attached to the methods.
26966 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26968 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26969 to handle the Accessor kind :-)
26971 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26973 2002-06-08 Martin Baulig <martin@gnome.org>
26975 * expression.cs (Unary.TryReduceNegative): Added support for
26978 2002-06-08 Martin Baulig <martin@gnome.org>
26980 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26981 name can't be found in the `defined_names' - the caller will do a
26982 MemberLookup in this case and thus find methods in System.Enum
26983 such as Enum.IsDefined().
26985 2002-06-08 Martin Baulig <martin@gnome.org>
26987 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26988 Convert.ChangeType() which works with TypeBuilder created types.
26989 (Enum.LookupEnumValue, Enum.Define): Use it here.
26991 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26992 `TypeBuilder.BaseType != null' check.
26993 (TypeContainer.FindMembers): Only lookup parent members if we
26994 actually have a parent.
26995 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26996 (ConstructorInitializer.Resolve): Likewise.
26998 * interface.cs (Interface.FindMembers): Added
26999 `TypeBuilder.BaseType != null' check.
27001 * rootcontext.cs (RootContext.ResolveCore): Added
27002 "System.Runtime.CompilerServices.IndexerNameAttribute" to
27003 classes_second_stage.
27005 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
27006 debug_type and trace_type when compiling with --nostdlib.
27008 2002-06-07 Martin Baulig <martin@gnome.org>
27010 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
27011 (AddField): Set it to true when adding a non-static field.
27012 (DefineType): Use `have_nonstatic_fields' to find out whether we
27013 have non-static fields, not `Fields != null'.
27015 2002-06-02 Miguel de Icaza <miguel@ximian.com>
27017 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
27018 dereferencing a null on the static-field code path)
27020 2002-05-30 Martin Baulig <martin@gnome.org>
27022 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
27023 to take command line arguments. Use reflection to call the new
27024 custom `Initialize' function on the symbol writer and pass it the
27025 command line arguments.
27027 * driver.cs (--debug-args): New command line argument to pass command
27028 line arguments to the symbol writer.
27030 2002-05-28 Miguel de Icaza <miguel@ximian.com>
27032 * assign.cs (DoResolve): Forgot to do the implicit conversion to
27033 the target type for indexers and properties. Thanks to Joe for
27036 2002-05-27 Miguel de Icaza <miguel@ximian.com>
27038 * typemanager.cs (MethodFlags): returns the method flags
27039 (Obsolete/ShouldIgnore) that control warning emission and whether
27040 the invocation should be made, or ignored.
27042 * expression.cs (Invocation.Emit): Remove previous hack, we should
27043 not do this on matching a base type, we should do this based on an attribute
27045 Only emit calls to System.Diagnostics.Debug and
27046 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
27047 on the command line.
27049 * rootcontext.cs: Global settings for tracing and debugging.
27051 * cs-tokenizer.cs (define): New utility function to track
27052 defines. Set the global settings for TRACE and DEBUG if found.
27054 2002-05-25 Ravi Pratap <ravi@ximian.com>
27056 * interface.cs (Populate*): Pass in the TypeContainer as well as
27057 the DeclSpace as parameters so that we can create EmitContexts and
27058 then use that to apply attributes etc.
27060 (PopulateMethod, PopulateEvent, PopulateProperty)
27061 (PopulateIndexer): Apply attributes everywhere.
27063 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
27066 (ApplyAttributes): Update accordingly.
27068 We now apply interface attributes for all members too.
27070 2002-05-26 Miguel de Icaza <miguel@ximian.com>
27072 * class.cs (Indexer.Define); Correctly check if we are explicit
27073 implementation (instead of checking the Name for a ".", we
27074 directly look up if the InterfaceType was specified).
27076 Delay the creation of the PropertyBuilder.
27078 Only create the PropertyBuilder if we are not an explicit
27079 interface implementation. This means that explicit interface
27080 implementation members do not participate in regular function
27081 lookups, and hence fixes another major ambiguity problem in
27082 overload resolution (that was the visible effect).
27084 (DefineMethod): Return whether we are doing an interface
27087 * typemanager.cs: Temporary hack until we get attributes in
27088 interfaces (Ravi is working on that) and we get IndexerName
27089 support in interfaces.
27091 * interface.cs: Register the indexers as properties.
27093 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
27094 warning, I have verified that this is a bug in the .NET runtime
27095 (JavaScript suffers of the same problem).
27097 * typemanager.cs (MemberLookup): When looking up members for
27098 interfaces, the parent of an interface is the implicit
27099 System.Object (so we succeed in searches of Object methods in an
27100 interface method invocation. Example: IEnumerable x; x.ToString
27103 2002-05-25 Miguel de Icaza <miguel@ximian.com>
27105 * class.cs (Event): Events should also register if they do
27106 implement the methods that an interface requires.
27108 * typemanager.cs (MemberLookup); use the new GetInterfaces
27111 (GetInterfaces): The code used to lookup interfaces for a type is
27112 used in more than one place, factor it here.
27114 * driver.cs: Track the errors at the bottom of the file, we kept
27117 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
27118 instance if the method we are calling is static!
27120 2002-05-24 Miguel de Icaza <miguel@ximian.com>
27122 * attribute.cs (ApplyAttributes): Make this function filter out
27123 the IndexerName attribute (as that attribute in reality is never
27124 applied) and return the string constant for the IndexerName
27127 * class.cs (TypeContainer.Emit): Validate that all the indexers
27128 have the same IndexerName attribute, and if so, set the
27129 DefaultName attribute on the class.
27131 * typemanager.cs: The return value might contain other stuff (not
27132 only methods). For instance, consider a method with an "Item"
27133 property and an Item method.
27135 * class.cs: If there is a problem with the parameter types,
27138 2002-05-24 Ravi Pratap <ravi@ximian.com>
27140 * ecore.cs (ImplicitConversionExists): Wrapper function which also
27141 looks at user defined conversion after making a call to
27142 StandardConversionExists - we need this for overload resolution.
27144 * expression.cs : Update accordingly the various method calls.
27146 This fixes 2 bugs filed against implicit user defined conversions
27148 2002-05-22 Miguel de Icaza <miguel@ximian.com>
27150 * statement.cs: Track the result of the assignment.
27152 2002-05-21 Miguel de Icaza <miguel@ximian.com>
27154 * expression.cs (MemberAccess): Improved error reporting for
27155 inaccessible members.
27157 2002-05-22 Martin Baulig <martin@gnome.org>
27159 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
27160 itself with debugging support.
27162 2002-05-22 Martin Baulig <martin@gnome.org>
27164 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
27165 Removed, this isn't needed anymore.
27167 2002-05-20 Martin Baulig <martin@gnome.org>
27169 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
27170 be underlying type for an enum.
27172 2002-05-20 Miguel de Icaza <miguel@ximian.com>
27174 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
27175 that splits out the loading of just the core types.
27177 * rootcontext.cs (ResolveCore): Split the struct resolution in
27178 two, so we can load the enumeration underlying types before any
27181 * expression.cs (Is): Bandaid until we fix properly Switch (see
27182 bug #24985 for details).
27184 * typemanager.cs (ImplementsInterface): The hashtable will contain
27185 a null if there are no interfaces implemented.
27187 2002-05-18 Miguel de Icaza <miguel@ximian.com>
27189 * cs-parser.jay (indexer_declarator): It is fine to have array
27192 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27194 * typemanager.cs: (RegisterBuilder): New function used to register
27195 TypeBuilders that implement interfaces. Since
27196 TypeBuilder.GetInterfaces (as usual) does not work with lame
27198 (AddUserType): register interfaces.
27200 (ImplementsInterface): Use the builder_to_ifaces hash if we are
27201 dealing with TypeBuilder. Also, arrays are showing up as
27202 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
27203 methods can not be invoked on them!
27205 * ecore.cs (ExplicitReferenceConversionExists): Made public.
27206 (ImplicitReferenceConversionExists): Split out from
27207 StandardConversionExists.
27209 * expression.cs (As): We were only implementing one of the three
27210 cases for the as operator. We now implement them all.
27211 (Is): Implement the various other cases for Is as well.
27213 * typemanager.cs (CACHE): New define used to control if we want or
27214 not the FindMembers cache. Seems to have a negative impact on
27215 performance currently
27217 (MemberLookup): Nested types have full acess to
27218 enclosing type members
27220 Remove code that coped with instance/static returns for events, we
27221 now catch this in RealFindMembers.
27223 (RealFindMembers): only perform static lookup if the instance
27224 lookup did not return a type or an event.
27226 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27228 * assign.cs (CompoundAssign): We pass more semantic information
27229 now to Compound Assignments than we did before: now we have all
27230 the information at hand, and now we resolve the target *before* we
27231 do the expression expansion, which allows the "CacheValue" method
27232 to have the effect we intended (before, a [x] += 1 would generate
27233 two differen ArrayAccess expressions from the ElementAccess,
27234 during the resolution process).
27236 (CompoundAssign.DoResolve): Resolve target and original_source here.
27238 2002-05-16 Miguel de Icaza <miguel@ximian.com>
27240 * expression.cs (ArrayAccess): dropped debugging information.
27242 * typemanager.cs: Small bug fix: I was always returning i_members,
27243 instead of one of i_members or s_members (depending on which had
27246 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
27247 method is invoked before any code generation takes place, and it
27248 is a mechanism to inform that the expression will be invoked more
27249 than once, and that the method should use temporary values to
27250 avoid having side effects
27252 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
27254 * ecore.cs (Expression.CacheTemporaries): Provide empty default
27257 * expression.cs (Indirection, ArrayAccess): Add support for
27258 CacheTemporaries in these two bad boys.
27260 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
27261 ldobj or ldind_ref.
27262 (StoreFromPtr): Handle stobj as well.
27264 * expression.cs (UnaryMutator): Share more code.
27266 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
27267 down: I was not tracking the Filter function as well, which
27268 was affecting the results of the cache.
27270 2002-05-15 Miguel de Icaza <miguel@ximian.com>
27272 * attribute.cs: Remove the hack to handle the CharSet property on
27275 2002-05-14 Miguel de Icaza <miguel@ximian.com>
27277 * attribute.cs (DoResolve): More uglyness, we now only try to
27278 resolve the attribute partially, to extract the CharSet
27279 information (only if we are a StructLayout attribute). Otherwise
27281 (GetExtraTypeInfo): Add some code to conditionally kill in the
27282 future this. I am more and more convinced that the .NET
27283 framework has special code to handle the attribute setting on
27286 * expression.cs (IsParamsMethodApplicable): Revert my previous
27287 foreach change here, it was wrong.
27289 2002-05-13 Miguel de Icaza <miguel@ximian.com>
27291 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
27292 (pp_expr): do not abort on unknown input, just return.
27293 (eval): abort if there are pending chars.
27295 * attribute.cs (Attribute.Resolve): Positional parameters are
27296 optional. Deal with that case.
27298 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
27299 the Ansi/Unicode/Auto information for the type.
27301 (TypeContainer.DefineType): instantiate the EmitContext here, as
27302 we will be using it during the type definition (to resolve
27303 attributes) and during the emit phase.
27305 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
27306 to pull type information out of the attributes
27308 (Attribute.Resolve): track the constructor builder, and allow for
27309 multiple invocations (structs and classes will use this).
27311 * ecore.cs (MemberLookupFinal): new version with all the
27312 parameters customizable.
27314 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
27315 constructors. Return if the result value is null (as the error
27316 would have been flagged already by MemberLookupFinal)
27318 Do not allow instances of abstract classes or interfaces to be
27321 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
27322 We have to compare the assembly property here when dealing with
27323 FamANDAssem and Assembly access modifiers, because we might be
27324 creating an assembly from *modules* (that means that we are not
27325 getting TypeBuilders for types defined in other modules that are
27326 part of this assembly).
27328 (Method.Emit): If the method is marked abstract and has a body,
27331 (TypeContainer.DefineMembers): If both the defined member and the
27332 parent name match are methods, then do not emit any warnings: let
27333 the Method.Define routine take care of flagging warnings. But if
27334 there is a mismatch (method overrides something else, or method is
27335 overriwritten by something, then emit warning).
27337 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
27338 set to null, this means `do not check for the return type on the
27341 (Method.Define): set the return type for the method signature to
27342 null, so that we get methods with the same name and parameters and
27343 different return types. This is used to flag warning 114 (you are
27344 hiding a method, and you probably want to use the new/override
27347 * typemanager.cs (MemberLookup): Implemented proper access
27348 control, closing a long standing set of bug reports. The problem
27349 was that the Framework only has two bits: Public and NonPublic,
27350 and NonPublic includes private and protected methods, but we need
27351 to enforce the FamANDAssem, FamOrAssem and Family.
27353 2002-05-11 Miguel de Icaza <miguel@ximian.com>
27355 * statement.cs (GotoCase): Return true: Ammounts to giving up
27356 knowledge on whether we return or not, and letting the other case
27357 be responsible for it.
27359 2002-05-10 Miguel de Icaza <miguel@ximian.com>
27361 * driver.cs: Do not load directories for each file processed, only
27362 do it if there is a pattern.
27364 * ecore.cs: Report readonly assigns here as well, as we might have
27365 been resolved only by MemberAccess.
27367 (SimpleName.SimpleNameResolve): Also be useful for LValue
27368 resolution. We need this to propagate assign to local readonly variables
27370 * typemanager.cs: Use a ptrhashtable for the criteria, because we
27371 do not want to reuse potential criteria memory.
27373 * class.cs (MyEventBuilder): Set reflected_type;
27375 * ecore.cs (Constantify): Added support for constifying bools.
27377 (RootContext.LookupType): Added a cache for values looked up in
27378 the declaration space.
27380 * typemanager.cs (FindMembers): Now is a front-end to
27381 RealFindMembers, and provides a two-level hashtable-based cache to
27384 15% performance improvement: from 22.5 to 19.2 seconds.
27386 * expression.cs (IsParamsMethodApplicable): use foreach.
27387 (Invocation.DoResolve): ditto.
27388 (New.DoResolve): ditto.
27389 (ArrayCreation.DoResolve): ditto.
27391 * ecore.cs (FindMostEncompassingType): use foreach.
27393 * delegate.cs (NewDelegate.DoResolve): Use foreach
27395 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
27396 (RemoveMethods): use foreach.
27398 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
27399 nested foreach statements instead of for, and also break out of
27400 the inner loop once a match is found.
27402 (Invocation.OverloadResolve): Use foreach, simplify the code.
27404 2002-05-08 Miguel de Icaza <miguel@ximian.com>
27406 * cfold.cs (BinaryFold): During an enumeration evaluation context,
27407 we actually unwrap the expression to allow for extra information
27410 * expression.cs: Use Shr_Un on unsigned operations.
27412 2002-05-08 Ravi Pratap <ravi@ximian.com>
27414 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
27415 applicable operators was not being considered correctly. This closes
27416 the bug Miguel reported.
27418 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
27420 * attribute.cs: check that the type derives from System.Attribute
27421 and report the correct error in that case (moved the duplicate code to
27422 its own method, too).
27424 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
27426 * attribute.cs: lookup attribute type name as the spec says: first the
27427 bare attribute name and then name + "Attribute" (nant compiles with
27428 mcs after this fix).
27430 2002-05-07 Miguel de Icaza <miguel@ximian.com>
27432 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
27433 Because of the way we parse things, we should try to see if a
27434 UIntConstant can fit in an integer.
27436 2002-05-07 Ravi Pratap <ravi@ximian.com>
27438 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
27439 when we are in an explicit context.
27441 (ConvertReferenceExplicit): When converting from Iface type S to Class
27442 T make sure the rules are implemented as an OR.
27444 * parameter.cs (ParameterType): Make it a property for now although the
27445 purpose really isn't anything immediate.
27447 * expression.cs (Is*Applicable): Do better checking on the parameter type
27448 of a ref/out parameter. The ones from the system assemblies are already
27449 marked with the correct type so we don't need to do any correction.
27451 * ecore.cs (StandardConversionExists): Conversion from Interface types to
27452 the object type is standard too so include that.
27454 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27456 * ecore.cs (StandardConversionExists): Augment with missing code:
27457 deal with IntConstant, LongConstants and Enumerations.
27459 * assign.cs: Report the error, instead of failing silently
27461 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
27462 typecontainer that they are declared, because the
27463 typecontainer/namespace will have the list of using clauses that
27464 need to be applied.
27466 Assembly Attributes were escaping the normal registration
27469 (EmitCode): Apply attributes within an EmitContext that represents
27470 the container they were declared on.
27472 * cs-parser.jay: Track bases for structs. How did I get this wrong?
27474 2002-05-06 Ravi Pratap <ravi@ximian.com>
27476 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
27477 Revamp completely - make much cleaner as we now operate only
27480 (FindMostSpecificSource, FindMostSpecificTarget): New methods
27481 to implement the logic detailed in the spec more correctly.
27483 (UserDefinedConversion): Update accordingly.
27485 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27487 * statement.cs: Return flow analysis information up.
27489 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
27492 (token): Do not consume an extra character before calling
27495 2002-05-06 Piers Haken <piersh@friskit.com>
27497 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
27499 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27501 * class.cs (Constructor.Emit): Set the IsStatic flag in the
27502 EmitContext during the instance constructor initializer
27503 resolution, to stop access to instance variables.
27505 This is mandated by the spec, last paragraph of the `constructor
27506 initializers' section.
27508 2002-05-05 Miguel de Icaza <miguel@ximian.com>
27510 * cs-parser.jay, class.cs (Accessor): new class used to represent
27511 an accessor (get or set). In the past we used `null' to represent
27512 a missing accessor. But this is ambiguous because there was no
27513 way to tell in abstract indexers/properties if one of them was
27516 Now there is a way of addressing that.
27518 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
27519 instead of FindMembers.
27521 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
27522 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
27524 * attribute.cs: Treat indexers and properties as the same in terms
27525 of applying attributes
27527 * ecore.cs (FindMostEncompassedType): Use statically initialized
27528 EmptyExpressions()s like we do elsewhere to avoid creating useless
27529 objects (and we take this out of the tight loop).
27531 (GetConversionOperators): Move the code to extract the actual
27532 operators to a separate routine to clean things up.
27534 2002-05-04 Miguel de Icaza <miguel@ximian.com>
27536 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
27537 events are always registered FieldBuilders.
27539 * class.cs (FieldBase): New class shared by Fields
27541 * delegate.cs: If we are a toplevel delegate, use our full name.
27542 If we are a nested delegate, then only use our tail name.
27544 2002-05-02 Ravi Pratap <ravi@ximian.com>
27546 * expression.cs (IsApplicable): Ensure that we add the "&" to
27547 ref/out types before comparing it with the type of the argument.
27549 (IsParamsMethodApplicable): Ditto.
27551 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27554 * delegate.cs : Handle the case when we have more than one applicable
27555 method. Flag an error only when we finish checking all.
27557 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27559 * expression.cs: Add support for boolean static initializers.
27561 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27563 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27565 * parameter.cs (ComputeParameterTypes,
27566 ComputeAndDefineParameterTypes): Better error handling: now we
27567 clear the `types' cache if we fail during any of the type lookups.
27568 We also return the status code correctly to our caller
27570 * delegate.cs: If we fail to define a delegate, abort the extra
27573 * expression.cs (Binary.ResolveOperator): for
27574 operator==(object,object) and operator !=(object, object) we also
27575 have to verify that there is an implicit conversion from one to
27578 (ArrayAccess.DoResolve): Array Access can operate on
27581 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27583 * assign.cs (CompoundAssign): A new class used as a "flag" that
27584 the assignment actually is happening as part of a compound
27585 assignment operator.
27587 During compound assignment, a few new rules exist to enable things
27594 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27595 to the type of x) if y is implicitly convertible to the type of x,
27596 and the operator is a builtin operator and the return type of the
27597 operator is explicitly convertible to the type of x.
27599 * rootcontext.cs: Reset warning level to 2. 4 catches various
27600 "interesting" features in mcs, we must clean this up at some
27601 point, but currently am trying to kill other bugs ;-)
27603 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27604 in container classes as well.
27606 * expression.cs (Binary.ResolveOperator): Handle string case
27607 before anything else (as operator overloading does emit an error
27608 before doing anything else).
27610 This code could go away when we move to a table driven model, but
27611 i could not come up with a good plan last night.
27613 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27615 * typemanager.cs (CSharpName): reimplementation using regex.
27616 * class.cs: added null check for fields in Emit
27617 * rootcontext.cs: set warninglevel to 4
27619 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27621 * typemanager.cs (CSharpName): reimplemented with Lupus
27624 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27626 * statement.cs (If): correclty implement Resolve, because we were
27627 not catching sem errors in there. The same process is needed
27629 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27632 (Statement.Warning_DeadCodeFound): Factorize code.
27633 (While): Report dead code here too.
27635 (Statement): Added Resolve virtual method to allow
27636 for resolution split from the emit code.
27638 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27640 * statement.cs (EmitBoolExpression): No longer try to resolve the
27642 (MakeBoolean): New utility function that resolve, implicitly
27643 converts to boolean and tags the expression.
27646 (If, Do): Implement dead code elimination.
27647 (While): Implement loop inversion
27649 (Do, While, For, If): Resolve the expression prior to calling our
27652 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27655 - added method Report28 (warning: program has more than one entry point)
27656 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27657 - modified method Method.Define, the part at the end of the method
27659 * rootcontext.cs: added static public Location EntryPointLocation;
27661 * ../errors/cs0028.cs : Add test case for the above warning.
27664 - modified method CSharpName to allow arrays of primitive type to
27665 be printed nicely (e.g. instead of System.Int32[][] it now prints
27667 - added method CSharpSignature: returns the signature of a method
27668 in string format to be used in reporting errors, warnings, etc.
27670 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27673 2002-04-26 Ravi Pratap <ravi@ximian.com>
27675 * delegate.cs (Define): Fix extremely silly bug where I was
27676 setting the type of the 'object' parameter of the BeginInvoke
27677 method to System.IAsyncResult instead of System.Object ;-)
27679 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27681 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27684 (Constructor.Emit): return if we fail to initialize the
27685 constructor. Another door closed!
27687 * expression.cs (New.DoResolve): Improve error message (from -6 to
27688 1501). Use DeclaredOnly lookup to find the exact constructor.
27690 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27691 loop. This is useful.
27693 * cs-parser.jay: Adjust the default parameters so that destructors
27694 have the proper signature.
27696 2002-04-26 Martin Baulig <martin@gnome.org>
27698 * driver.cs (LoadAssembly): If `assembly' contains any characters
27699 which are only valid in path names and not in assembly names
27700 (currently slash, backslash and point), use Assembly.LoadFrom ()
27701 instead of Assembly.Load () on the `assembly' (before iteration
27702 over the link_paths).
27704 2002-04-26 Martin Baulig <martin@gnome.org>
27706 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27708 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27710 * class.cs (Property): use the new typemanager.MemberLookup
27712 (TypeContainer.MemberLookup): Implement using the
27713 TypeManager.MemberLookup now.
27715 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27716 and return MemberInfos, so that these can be used without an
27717 EmitContext (what we had before).
27719 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27721 * expression.cs: Fix the case where the argument to params if the
27722 type of the params. I omitted handling this before. Fixed
27724 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27726 * driver.cs: Call BootCorlib_PopulateCoreType
27728 * class.cs (Property.CheckBase): Check for properties only, not
27731 * interface.cs: Temporary hack: try/catch around the
27732 CustomAttributeBuilder, because I am getting an exception that I
27735 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27736 types whose definitions are required to be there (attributes are
27737 defined before standard types).
27739 Compute definitions as we boot the various types, as they are used
27740 immediately (value_type class will need object_type, but if we do
27741 not initialize object_type, we will pass a null, which will let
27742 the runtime pick the System.Object from the existing corlib, which
27743 is not what we want).
27745 2002-04-22 Patrik Torstensson <totte@labs2.com>
27747 * cs-tokenizer.cs: fixed a number of trim() issues.
27749 2002-04-22 Ravi Pratap <ravi@ximian.com>
27751 * expression.cs (Argument.Type): Ensure that we return the correct
27752 type when we have out or ref parameters [in which case we
27755 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27757 * class.cs (Property, Indexer): Allow extern modifier in there.
27759 * typemanager.cs (InitBaseTypes): Initializes object_type and
27760 value_type, since those will be used early on during the bootstrap
27761 process to compile corlib.
27763 (InitCoreTypes): Move code from here to InitBaseTypes.
27765 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27767 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27768 single-dimension arrays as using the ldlen opcode.
27770 Daniel Lewis discovered this optimization.
27772 * typemanager.cs: Add signature for System.Array::get_Length
27774 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27776 * statement.cs: report the error when the foreach does not apply to an
27777 array nor a collection.
27779 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27781 * expression.cs: Add implicit conversions to the operator ~.
27783 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27785 * typemanager.cs: Locate the decimal constructor.
27787 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27789 * attribute.cs: use the new property of TypeOf.
27790 * expression.cs: added 'get' property around typearg.
27792 These changes fix a build breaker reported by NickD. Is this the
27793 correct way to fix? If not, please, revert my changes and make it
27796 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27798 * attribute.cs: Add support for typeof in attribute invocations.
27799 I am not sure that this is right though.
27801 2002-04-14 Duncan Mak <duncan@ximian.com>
27803 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27804 Binary.Operator.Division case.
27806 2002-04-13 Ravi Pratap <ravi@ximian.com>
27808 * class.cs (DefineType): Ensure that we do a proper check on
27809 attribute types and also register it with the TypeManager.
27811 (TypeContainer.Targets): The default for attribute types is
27812 AttributeTargets.All.
27814 * attribute.cs (ApplyAttributes): Registering the attribute type
27815 is done elsewhere, not when we discover we have a Usage attribute.
27817 2002-04-12 Ravi Pratap <ravi@ximian.com>
27819 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27820 and get rid of is_delegate parameter.
27822 * everywhere : update.
27824 2002-04-12 Ravi Pratap <ravi@ximian.com>
27826 * cs-parser.jay (compilation_unit): Revamp completely to use
27827 some new ideas that I got from Rhys' grammar to solve the problems
27828 with assembly level attributes.
27830 (outer_declaration): New grammar production.
27832 (attribute_sections): Add.
27834 (opt_attributes): Base on attribute_sections
27836 (namespace_declaration): Allow opt_attributes to tackle the case
27837 when we have assembly level attributes - we are clever in this
27840 * attribute.cs (ApplyAttributes): Do not worry about assembly
27841 attributes in the non-global context.
27843 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27844 instead of SetGlobalAttributes.
27846 * class.cs, rootcontext.cs : Ensure we define and generate
27847 attribute types before anything else.
27849 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27850 and flag the new error -20 for the case when the attribute type
27851 does not have valid targets specified. csc does not catch this.
27853 * ../errors/errors.txt : update for error # -20
27855 2002-04-11 Ravi Pratap <ravi@ximian.com>
27857 * support.cs (InternalParameters.ParameterModifier): Do some null
27858 checking and return sane values.
27860 * class.cs (Method.Define): If we are a PInvoke method, ensure
27861 that we are static and extern. Report error # 601
27863 * ../errors/cs0601.cs : Add test case for the above error.
27865 2002-04-07 Ravi Pratap <ravi@ximian.com>
27867 * rootcontext.cs (attribute_types): We need to keep type of
27868 all attribute types separately and emit code for them first.
27870 (RegisterAttribute) : Implement.
27872 * class.cs (DefineType): Check if the current Type is a custom
27873 attribute type and register it accordingly.
27875 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27876 adding the first attribute twice and rename to
27878 (SetGlobalAttributes): this.
27880 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27883 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27884 if we are processing global arguments. Hmm, I am unsure of this.
27886 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27888 * expression.cs: added static array of strings to avoid calling
27889 Enum.ToString () for Operator in Binary. Significant recover of
27892 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27894 * class.cs (FindMembers): Allow the Builders of the various
27895 members to be null. If they are skip them. This only happens
27896 during the PInvoke declaration.
27898 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27900 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27901 failure, so we do not keep going afterwards.
27903 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27904 wanted to pass `false' as the `is_delegate' argument. If this is
27905 the case, why not use delegate_type == null to mean `is_delegate =
27906 false' and anything else as is_delegate = true.
27908 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27910 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27911 code for the section, not the beginning of the tests.
27913 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27915 * cfold.cs: Handle operator + (Enum x, Underlying x)
27917 * expression.cs (Binary): same. Warn about errors where we have
27918 Enum/Enum in operator + as well.
27920 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27923 - added support for switch(bool)
27924 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27925 - add TableSwitchEmit() to handle table-based switch statements
27927 2002-04-05 Ravi Pratap <ravi@ximian.com>
27929 * expression.cs (Invocation.OverloadResolve): Factor out code which
27930 does parameter compatibility checking with arguments so that we can
27931 re-use the code even from Delegate.VerifyApplicability
27933 (VerifyArgumentsCompat): Move above code here.
27935 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27936 and instead make a call to the above method.
27938 2002-03-31 Ravi Pratap <ravi@ximian.com>
27940 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27941 We use it to keep track of classes which are attribute types.
27943 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27945 * delegate.cs (Delegate.Define): Correctly define the types in the
27946 presence of fixed and array parameters.
27948 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27951 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27952 include NonPublic after the first iteration.
27954 * class.cs (Indexer.CheckBase): Only check if both parents are
27957 * cs-parser.jay (accessor_body): If empty, set to null.
27959 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27960 same code path here to resolve constants names that we did have in
27961 MemberAccess.DoResolve. There is too much code duplicated here.
27963 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27965 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27967 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27970 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27971 tokens, numbers and strings.
27973 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27976 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27977 asyncronous parameters and the regular parameters.
27979 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27980 specify the target directory.
27982 * expression.cs: (This.DoResolve): Simplify
27983 (As.Emit): Optimize, do not generate IsInst if the expression is
27984 always of the given type.
27986 (Is.DoResolve): Bug fix, we were reporting both always/never for
27989 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27990 creating too many unnecessary arrays.
27992 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27994 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27995 fields instead of rolling our own initializer. Takes care of all
27996 implicit conversions, and drops unnecessary static checks/argument.
27998 2002-03-31 Dick Porter <dick@ximian.com>
28000 * driver.cs: use the GetDirectories() return values properly, and
28001 use "/" as path separator.
28003 2002-03-30 Miguel de Icaza <miguel@ximian.com>
28005 * expression.cs (Unary): Optimize - - expr into expr.
28006 (Binary): Optimize a + (-b) into a -b.
28008 * codegen.cs (CodeGen): Made all methods static.
28010 2002-03-29 Miguel de Icaza <miguel@ximian.com>
28014 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
28015 TypeBuilder property.
28017 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
28020 * tree.cs: Removed the various RecordXXXX, and replaced with a
28021 single RecordDecl. Removed all the accessor methods, and just
28022 left a single access point Type
28024 * enum.cs: Rename DefineEnum to DefineType.
28026 * decl.cs: New abstract method `DefineType' used to unify the
28027 Defines for Enumerations, Interfaces, TypeContainers and
28030 (FindType): Moved LookupInterfaceOrClass here. Moved the
28031 LookupBaseClasses method that used to live in class.cs and
28032 interface.cs here, and renamed to FindType.
28034 * delegate.cs: Implement DefineType. Take advantage of the
28035 refactored pattern for locating the parent builder without taking
28036 the parent_builder argument (which we know does not work if we are
28037 nested, and triggering a toplevel definition).
28039 2002-03-28 Miguel de Icaza <miguel@ximian.com>
28041 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
28042 accessibility of a member has changed during override and report
28045 * class.cs (Method.Define, Property.Define): Only complain on
28046 overrides if the method is private, any other accessibility is
28047 fine (and since we just checked the permission is the same, we are
28050 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
28051 and elif are processed always. The other pre-processing
28052 directives are only processed if we are "taking" the path
28054 2002-03-29 Martin Baulig <martin@gnome.org>
28056 * class.cs (Method.Emit): Only emit symbolic debugging info if the
28057 current location is not Null.
28059 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
28060 a separate method so we can profile it.
28062 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
28063 `span.Seconds' are just seconds, but no minutes or hours.
28064 (MainDriver): Profile the CodeGen.SaveSymbols calls.
28066 2002-03-28 Miguel de Icaza <miguel@ximian.com>
28068 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
28069 Remove the gratuitous set of Final:
28071 // If an interface implementation, then we can set Final.
28072 if (((flags & MethodAttributes.Abstract) == 0) &&
28073 implementing.DeclaringType.IsInterface)
28074 flags |= MethodAttributes.Final;
28076 I do not know what I was smoking when I used that.
28079 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
28080 step into fixing the name resolution issues for delegates and
28081 unifying the toplevel name resolution.
28083 2002-03-28 Martin Baulig <martin@gnome.org>
28085 * class.cs (Method.Emit): If we have a symbol writer, call its
28086 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
28087 tell it about the current method.
28089 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
28090 writer that we're going to emit the first byte of IL code for a new
28091 statement (a new source line).
28092 (EmitContext.EmitTopBlock): If we have a symbol writer, call
28093 EmitContext.Mark() before emitting any code.
28095 * location.cs (SymbolDocument): Return null when we're Null.
28097 * statement.cs (Statement): Moved the `Location loc' variable here.
28098 (Statement.EmitBoolExpression): If we have a symbol writer, call
28099 ec.Mark() before emitting any code to tell it that we're at the
28100 beginning of a new statement.
28101 (StatementExpression): Added `Location' argument to the constructor.
28102 (Block): Added public readonly variable `StartLocation' and public
28103 variable `EndLocation'. The latter is to be set using SetEndLocation().
28104 (Block): Added constructor which takes a start and end location.
28105 (Block.SetEndLocation): New method. This sets the end location.
28106 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
28107 local variables we create.
28108 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
28109 each statement and do also mark the begin and end of the block.
28111 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
28112 tell it the current lexer.Location, use Location.Null for the end of the
28114 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
28115 current block, set its end location using SetEndLocation().
28116 (statement_expression): StatementExpression constructor now takes the
28117 lexer.Location as additional argument.
28118 (for_statement, declare_local_variables): Likewise.
28119 (declare_local_variables): When creating a new implicit block, use the
28120 new Block constructor and pass it the lexer.Location.
28122 2002-03-28 Miguel de Icaza <miguel@ximian.com>
28124 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
28125 members also on the parent interfaces recursively.
28127 2002-03-27 Miguel de Icaza <miguel@ximian.com>
28129 * report.cs: Use new formats, since Gonzalo finished the missing
28132 * expression.cs (Binary.ResolveOperator): added missing operator|
28133 operator& and operator^ for bool/bool.
28135 * cs-parser.jay: CheckDef now takes a Location argument that is
28136 used to report errors more precisly (instead of reporting the end
28137 of a definition, we try to track something which is a lot closer
28138 to the source of the problem).
28140 * cs-tokenizer.cs: Track global token use, so we can properly flag
28141 the use of #define/#undef after the first token has been seen.
28143 Also, rename the reportXXXX to Error_DescriptiveName
28145 * decl.cs (DeclSpace.IsTopLevel): Move property here from
28146 TypeContainer, so that Enum and Interface can use this too.
28148 * class.cs (TypeContainer.LookupInterfaceOrClass,
28149 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
28150 `builder' argument. Typically this was used to pass the parent
28151 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
28154 The problem is that a nested class could trigger the definition of
28155 a toplevel class, and the builder would be obviously wrong in that
28158 So we drop this argument, and we compute dynamically the
28159 TypeBuilder/ModuleBuilder (the correct information was available
28160 to us anyways from DeclSpace.Parent)
28162 * interface.cs (Interface.DefineInterface): Drop builder
28163 parameter cleanup like class.cs
28165 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
28168 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
28171 (Try.Emit): Propagate the returns value from the statement.
28173 (Return.Emit): Even if we are leavning
28175 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
28177 * modifiers.cs: Fix the computation of MethodAttributes flags.
28179 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
28181 * driver.cs: allow compilation of files that start with '/'.
28182 Add a default case when checking the argument of --target.
28184 2002-03-25 Miguel de Icaza <miguel@ximian.com>
28186 * interface.cs: Implement the same search algorithm for types in
28187 the interface code.
28189 * delegate.cs: Do not allow multiple definition.
28191 * Recovered ChangeLog that got accidentally amputated
28193 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
28195 * rootcontext.cs: Load manually enum to allow core classes to
28196 contain enumerations.
28198 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
28199 Update to new static methods in TypeManager.
28201 * typemanager.cs (GetMethod, GetConstructor): Use our
28202 implementation of FindMembers to find the members, since during
28203 corlib compilation, the types are TypeBuilders and GetMethod and
28204 GetConstructor do not work.
28206 Make all methods in TypeManager static.
28208 (InitCodeHelpers): Split the functionality from
28209 the InitCodeTypes function.
28211 * driver.cs: Call InitCodeHelpers after we have populated the
28214 * cs-parser.jay (delegate_declaration): we did not used to compute
28215 the delegate name correctly for void delegates.
28217 2002-03-24 Miguel de Icaza <miguel@ximian.com>
28219 * rootcontext.cs (RootContext): Init the interface_resolve_order
28220 and type_container_resolve_order always.
28222 (ResolveCore, BootstrapCorlib_ResolveClass,
28223 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
28224 compiler when compiling with --nostdlib
28226 * class.cs (TypeContainer.DefineType): Check that our parent is
28227 not null. This test is most important when we are bootstraping
28230 * codegen.cs: Split out the symbol writing code.
28232 2002-03-25 Martin Baulig <martin@gnome.org>
28234 * driver.cs (-g): Made -g an alias for --debug.
28236 2002-03-24 Martin Baulig <martin@gnome.org>
28238 * codegen.cs (SymbolWriter): New public variable. Returns the
28239 current symbol writer.
28240 (CodeGen): Added `bool want_debugging_support' argument to the
28241 constructor. If true, tell the ModuleBuild that we want debugging
28242 support and ask it for the ISymbolWriter.
28243 (Save): If we have a symbol writer, call it's Close() method after
28244 saving the assembly.
28246 * driver.c (--debug): New command line argument to create a
28247 debugger information file.
28249 * location.cs (SymbolDocument): New public property. Returns an
28250 ISymbolDocumentWriter object for the current source file or null
28251 if we don't have a symbol writer.
28253 2002-03-21 Miguel de Icaza <miguel@ximian.com>
28255 * driver.cs (LoadAssembly): Correctly return when all the paths
28256 have been tried and not before.
28258 * statement.cs (Switch.Emit): return the actual coverage for this
28259 statement (returns/not-returns)
28261 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
28262 switch of the statement if we are the last switch section. That
28263 kills two problems: try/catch problems (we used to emit an empty
28264 nop at the end) and switch statements where all branches would
28267 2002-03-19 Miguel de Icaza <miguel@ximian.com>
28269 * driver.cs: Add default assemblies (the equivalent to the
28270 Microsoft CSC.RSP file)
28272 * cs-tokenizer.cs: When updating `cols and setting it to zero,
28273 also update tokens_seen and set it to false.
28275 * driver.cs: Implement --recurse for Mike.
28277 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
28278 correctly splitting out the paths.
28280 2002-03-18 Miguel de Icaza <miguel@ximian.com>
28282 * interface.cs (Interface.PopulateProperty): Instead of using
28283 `parent' as the declaration space for the set parameters, use
28286 * support.cs (InternalParameters): InternalParameters constructor
28287 takes a DeclSpace instead of a TypeContainer.
28289 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
28290 types are being initialized, load the address of it before calling
28293 (New): Provide a mechanism to disable the generation of local
28294 value type temporaries when the caller will be providing us with
28295 an address to store it.
28297 (ArrayCreation.EmitDynamicInitializers): Use it.
28299 2002-03-17 Miguel de Icaza <miguel@ximian.com>
28301 * expression.cs (Invocation.EmitArguments): Only probe for array
28302 property if there is more than one argument. Sorry about that.
28304 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
28305 empty param arrays.
28307 * class.cs (Method.LabelParameters): Fix incorrect code path that
28308 prevented the `ParamArrayAttribute' from being applied to the
28311 2002-03-16 Miguel de Icaza <miguel@ximian.com>
28313 * support.cs (ReflectionParameters): Correctly compute whether the
28314 last argument is a params array. Fixes the problem with
28317 * typemanager.cs: Make the assemblies array always be non-null
28318 (empty, but non-null)
28320 * tree.cs (RecordDecl): New function that abstracts the recording
28321 of names. This reports error 101, and provides a pointer to the
28322 previous declaration. Fixes a crash in the compiler.
28324 * cs-parser.jay (constructor_declaration): Update to new grammar,
28325 and provide a constructor_body that can be empty.
28327 2002-03-15 Miguel de Icaza <miguel@ximian.com>
28329 * driver.cs: Add support for --resources.
28331 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
28332 Make all types for the various array helper methods be integer.
28334 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
28335 CheckState to ConvCast.
28337 (ConvCast): Now it takes a `checked' state argument, to avoid
28338 depending on the emit context for the conversion, and just using
28339 the resolve time setting.
28341 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
28342 instead of Invocation.EmitArguments. We do not emit the original
28343 arguments, instead we emit those which have been converted to
28344 unsigned int expressions.
28346 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
28348 * codegen.cs: ditto.
28350 * expression.cs (LocalVariableReference): Drop the use of the
28351 Store function that depended on the variable index.
28353 * statement.cs (VariableInfo): Drop the `Idx' property from this
28354 class, as this is not taking into account the indexes for
28355 temporaries tat we generate during the execution, getting the
28358 * class.cs: First emit class initializers, then call the parent
28361 * expression.cs (Binary): Fix opcode emision.
28362 (UnaryMutator.EmitCode): Support checked code generation
28364 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
28365 matches for events for both the Static and Instance scans,
28366 pointing to the same element. Fix that.
28368 2002-03-14 Miguel de Icaza <miguel@ximian.com>
28370 * rootcontext.cs (ResolveTree): Always set the
28371 interface_resolve_order, because nested interfaces will be calling
28374 * class.cs (GetInterfaceOrClass): Track the same resolution
28375 process used by TypeManager.LookupType. This fixes the nested
28376 type lookups in class declarations (separate path from
28379 (TypeContainer.DefineType): Also define nested interfaces.
28380 (TypeContainer.RegisterOrder): New public function used to
28381 register the order in which child interfaces need to be closed.
28383 Nested interfaces need to be closed after their parents have been
28386 * interface.cs (InterfaceAttr): Put all the logic for computing
28387 the interface attribute here.
28389 (DefineInterface): Register our interface order with the
28390 RootContext or with the TypeContainer depending on the case.
28392 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28394 * cs-parser.jay: rework foreach statement to work with the new
28395 changes to the policy on SimpleNames.
28397 * report.cs: support Stacktrace on warnings as well.
28399 * makefile: drop --unsafe and /unsafe from the compile.
28401 2002-03-13 Ravi Pratap <ravi@ximian.com>
28403 * ecore.cs (StandardConversionExists): Modify to take an Expression
28404 as the first parameter. Ensure we do null -> reference type conversion
28407 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
28408 temporary Expression objects.
28410 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
28412 * interface.cs: workaround bug in method overloading resolution
28413 (there is already a bugzilla bug for it).
28415 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28417 We could also solve this problem by having a separate path for
28418 performing type lookups, instead of DoResolve, we could have a
28419 ResolveType entry point, and only participating pieces of the
28420 production (simplename, deref, array) would implement this.
28422 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
28423 signal SimpleName to only resolve type names and not attempt to
28424 resolve anything else.
28426 * expression.cs (Cast): Set the flag.
28428 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
28430 * class.cs: Only report 108 if there is no `new' modifier.
28432 * cs-parser.jay: rework foreach statement to work with the new
28433 changes to the policy on SimpleNames.
28435 * report.cs: support Stacktrace on warnings as well.
28437 * makefile: drop --unsafe and /unsafe from the compile.
28439 2002-03-11 Miguel de Icaza <miguel@ximian.com>
28441 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28442 lookups here, instead of doing that at parse time. This means
28443 that our grammar will not introduce `LocalVariableReferences' as
28444 expressions at this point. That solves the problem of code like
28448 static void Main ()
28452 This is only half the fix. The full fix requires parameters to
28453 also be handled in this way.
28455 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
28456 makes the use more obvious of the DeclSpace. The
28457 ec.TypeContainer.TypeBuilder is now only used to pull the
28458 TypeBuilder for it.
28460 My theory is that I can get rid of the TypeBuilder completely from
28461 the EmitContext, and have typecasts where it is used (from
28462 DeclSpace to where it matters).
28464 The only pending problem is that the code that implements Aliases
28465 is on TypeContainer, and probably should go in DeclSpace.
28467 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28468 lookups here, instead of doing that at parse time. This means
28469 that our grammar will not introduce `LocalVariableReferences' as
28470 expressions at this point. That solves the problem of code like
28474 static void Main ()
28478 This is only half the fix. The full fix requires parameters to
28479 also be handled in this way.
28481 * class.cs (Property.DefineMethod): When implementing an interface
28482 method, set newslot, when implementing an abstract method, do not
28483 set the flag (before we tried never setting it, or always setting
28484 it, which is the difference).
28485 (Indexer.DefineMethod): same.
28486 (Method.DefineMethod): same.
28488 * ecore.cs: Only set the status used flag if we get back a Field.
28490 * attribute.cs: Temporary hack, so Paolo can keep working.
28492 2002-03-08 Ravi Pratap <ravi@ximian.com>
28494 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
28495 the unmanaged type in the case we have a MarshalAs attribute.
28497 (Resolve): Handle the case when we are parsing the special MarshalAs
28498 attribute [we need to store the unmanaged type to use later]
28500 * typemanager.cs (marshal_as_attr_type): Built in type for the
28501 MarshalAs Attribute.
28503 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
28504 on parameters and accordingly set the marshalling info.
28506 2002-03-09 Miguel de Icaza <miguel@ximian.com>
28508 * class.cs: Optimizing slightly by removing redundant code after
28509 we switched to the `NoTypes' return value.
28510 (Property.DefineMethod): use NoTypes here too.
28512 This fixes the bug I introduced in my last batch of changes.
28514 2002-03-05 Ravi Pratap <ravi@ximian.com>
28516 * tree.cs (RecordEnum): Add. We now keep track of enums too.
28518 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
28519 Enums since those are types too.
28521 * cs-parser.jay (enum_declaration): Record enums as we parse them.
28523 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
28524 thanks to a call during the lookup process.
28526 2002-03-07 Miguel de Icaza <miguel@ximian.com>
28528 * statement.cs (Foreach): Lots of work to accomodate a particular
28529 kind of foreach statement that I had not kept in mind. It is
28530 possible to have foreachs on classes that provide a GetEnumerator
28531 method that return objects that implement the "pattern" for using
28532 a foreach, there is no need to support GetEnumerator
28535 This is needed to compile nant.
28537 * decl.cs: Only report 114 if the member is not `Finalize' and if
28538 the warning level is at least 2.
28540 * class.cs: Moved the compare function from Method to
28543 (MethodSignature.InheritableMemberSignatureCompare): Add new
28544 filter function that is used to extract inheritable methods from a
28547 (Method.Define): Use the new `inheritable_method_signature_filter'
28550 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28553 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28555 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28557 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28559 * expression.cs: Pass location information to
28560 ConvertImplicitStandard.
28562 * class.cs: Added debugging code to track return values from
28565 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28567 * expression.cs (Is.DoResolve): If either side of the `is' is an
28568 interface, do not flag the warning.
28570 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28573 * report.cs: Allow for --fatal to be used with --probe.
28575 * typemanager.cs (NoTypes): Move the definition for the empty Type
28578 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28580 (TypeContainer.DefineProxy): New function used to proxy to parent
28581 implementations when implementing interfaces.
28582 (TypeContainer.ParentImplements): used to lookup if our parent
28583 implements a public function that is required by an interface.
28584 (TypeContainer.VerifyPendingMethods): Hook this up.
28586 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28587 `modules' and `assemblies' arraylists into arrays. We only grow
28588 these are the very early start up of the program, so this improves
28589 the speedof LookupType (nicely measured).
28591 * expression.cs (MakeByteBlob): Replaced unsafe code with
28592 BitConverter, as suggested by Paolo.
28594 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28595 folding of string concatenation, but if either side is a string,
28596 and the other is not, then return null, and let the runtime use
28597 the concatenation on the string plus the object (using
28598 `Object.ToString').
28600 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28602 Constant Folding has been implemented now.
28604 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28605 the error instead on types that are not supported in one's
28608 * constant.cs (Constant and all children): New set of functions to
28609 perform implict and explicit conversions.
28611 * ecore.cs (EnumConstant): Implement the new functions to perform
28612 conversion by proxying to the child expression.
28614 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28615 own separate setting that can not be turned off from the command
28616 line using --unchecked or --checked and is only controlled using
28617 the checked/unchecked statements and expressions. This setting is
28618 used by the constant folder to flag errors.
28620 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28621 ConstantCheckState as well.
28623 During Resolve, they also have to flag the state, because the
28624 constant folder runs completely in the Resolve phase.
28626 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28629 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28631 * cfold.cs: New file, this file contains the constant folder.
28633 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28634 argument to track whether we are using the resulting address to
28635 load or store a value and provide better error messages.
28637 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28638 new AddressOf arguments.
28640 * statement.cs (Foreach.EmitCollectionForeach): Update
28642 * expression.cs (Argument.Emit): Call AddressOf with proper
28643 arguments to track usage.
28645 (New.DoEmit): Call AddressOf with new arguments.
28647 (Unary.Emit): Adjust AddressOf call.
28649 2002-03-01 Ravi Pratap <ravi@ximian.com>
28651 * cs-parser.jay (member_access): Change the case for pre-defined types
28652 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28655 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28658 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28659 essentially like methods and apply attributes like MethodImplOptions to them too.
28661 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28664 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28665 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28668 * Update code everywhere accordingly.
28670 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28672 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28674 2002-02-28 Ravi Pratap <ravi@ximian.com>
28676 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28677 try performing lookups against those instead of jumping straight into using
28678 the 'using' clauses.
28680 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28682 (LookupType): Perform lookups in implicit parents too.
28684 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28685 sequence as RootContext.LookupType.
28687 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28688 the various cases of namespace lookups into this method.
28690 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28692 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28693 in positional arguments)
28695 * class.cs (Operator): Update the AllowedModifiers to contain
28698 * cs-parser.jay: Update operator declaration to allow for the
28699 operator body to be empty.
28701 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28704 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28706 * class.cs (Method.Emit): Label parameters.
28708 * driver.cs: Return 1 or 0 as the program exit code.
28710 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28712 * expression.cs: Special case the `null' object when trying to
28713 auto-compute the type, as anything can be explicitly converted to
28716 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28717 spotting this Paolo.
28719 (Expression.ImplicitNumericConversion): Perform comparissions of
28720 the type using the underlying type in the case of an enumeration
28721 rather than using the enumeration type for the compare.
28723 Cope with the underlying == type case, which is not possible to
28726 (Expression.ConvertNumericExplicit): Perform comparissions of
28727 the type using the underlying type in the case of an enumeration
28728 rather than using the enumeration type for the compare.
28730 * driver.cs: If the user does not supply an extension, assume .exe
28732 * cs-parser.jay (if_statement): Rewrote so that we can track the
28733 location for the if statement.
28735 * expression.cs (Binary.ConstantFold): Only concat strings when
28736 the operation is "+", not everything ;-)
28738 * statement.cs (Statement.EmitBoolExpression): Take a location
28740 (If, While, Do): Track location.
28742 * expression.cs (Binary.ResolveOperator): In the object + string
28743 case, I was missing a call to ConvertImplicit
28745 2002-02-25 Ravi Pratap <ravi@ximian.com>
28747 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28748 Location arguments. Ensure we use RootContext.LookupType to do our work
28749 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28751 * interface.cs (PopulateMethod): Handle the type of the parameter being
28754 * expression.cs (Invocation.BetterFunction): Handle the case when we
28755 have a params method with no fixed arguments and a call is made with no
28758 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28760 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28761 the verbatim-string-literal
28763 * support.cs (InternalParameters.ParameterModifier): handle null
28765 (InternalParameters.ParameterType): ditto.
28767 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28768 duplicating the name of the variable parameter.
28769 (GetParameterByName): Fix bug where we were not looking up array
28770 paramters if they were the only present (thanks Paolo!).
28771 (GetParameterInfo): We only have an empty set of types if both
28772 fixed and array are set to null.
28773 (GetParameterInfo-idx): Handle FixedParameter == null
28775 * cs-parser.jay: Handle the case where there is no catch
28776 statements (missing null test).
28778 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28780 * driver.cs (MainDriver): Be conservative on our command line
28783 Catch DirectoryNotFoundException when calling GetFiles.
28785 (SplitPathAndPattern): Used to split the input specification into
28786 a path and a pattern that we can feed to Directory.GetFiles.
28788 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28790 * statement.cs (Fixed): Implement the last case of the Fixed
28791 statement (string handling).
28793 * expression.cs (StringPtr): New class used to return a char * to
28794 a string; Used by the Fixed statement.
28796 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28798 * expression.cs (Binary.ResolveOperator): Remove redundant
28799 MemberLookup pn parent type.
28800 Optimize union call, we do not need a union if the types are the same.
28801 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28804 Specialize the use of MemberLookup everywhere, instead of using
28805 the default settings.
28807 (StackAlloc): Implement stackalloc keyword.
28809 * cs-parser.jay: Add rule to parse stackalloc.
28811 * driver.cs: Handle /h, /help, /?
28813 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28814 before we supported unsafe code.
28816 * makefile: add --unsafe to the self compilation of mcs.
28818 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28820 * expression.cs (PointerArithmetic): New class that is used to
28821 perform pointer arithmetic.
28822 (Binary.Resolve): Handle pointer arithmetic
28823 Handle pointer comparission.
28824 (ArrayPtr): Utility expression class that is used to take the
28825 address of an array.
28827 (ElementAccess): Implement array access for pointers
28829 * statement.cs (Fixed): Implement fixed statement for arrays, we
28830 are missing one more case before we are done.
28832 * expression.cs (Indirection): Implement EmitAssign and set the
28833 ExprClass to Variable. This allows pointer dereferences to be
28834 treated as variables, and to have values assigned to them.
28836 * ecore.cs (Expression.StoreFromPtr): New utility function to
28837 store values dereferencing.
28839 2002-02-20 Ravi Pratap <ravi@ximian.com>
28841 * expression.cs (Binary.ResolveOperator): Ensure that we are
28842 not trying to operate on a void type - this fixes the reported
28845 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28846 the parent implementation is sealed.
28848 * ../errors/cs0239.cs : Add.
28850 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28852 * typemanager.cs (unverifiable_code_type): Corresponds to
28853 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28854 which have unsafe code in them.
28856 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28859 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28861 * cs-tokenizer.cs: Add support for @"litreal strings"
28863 Make tokenizer accept pre-processor directives
28864 on any column (remove the old C-like limitation).
28866 * rootcontext.cs (EmitCode): Emit any global attributes.
28867 (AddGlobalAttributes): Used to keep track of assembly attributes.
28869 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28871 * cs-parser.jay: Add support for global attributes.
28873 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28875 * expression.cs (Indirection): New helper class. Unary will
28876 create Indirection classes to be able to implement the
28877 IMemoryLocation interface on it.
28879 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28881 * cs-parser.jay (fixed_statement): reference the right statement.
28883 * statement.cs (Fixed.Emit): Finish implementing the fixed
28884 statement for the &x case.
28886 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28888 * class.cs (Property.Define, Method.Define): Remove newslot when
28891 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28892 wrong. NewSlot should only be used if the `new' keyword is present.
28894 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28895 locating our system dir. Sorry about this.
28897 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28899 * driver.cs (GetSystemDir): Compute correctly the location of our
28900 system assemblies. I was using the compiler directory instead of
28901 the library directory.
28903 2002-02-13 Ravi Pratap <ravi@ximian.com>
28905 * expression.cs (BetterFunction): Put back in what Miguel commented out
28906 since it is the correct fix. The problem is elsewhere ;-)
28908 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28909 parameters of the parms method are themselves compatible or not !
28911 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28912 to check that a class implements an interface before saying that an implicit
28913 conversion was allowed. Use ImplementsInterface to do the checking.
28915 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28917 * class.cs (Method.Define): Track whether we are an explicit
28918 implementation or not. And only call DefineMethodOverride if we
28919 are an explicit implementation.
28921 (Property.DefineMethod): Ditto.
28923 2002-02-11 Ravi Pratap <ravi@ximian.com>
28925 * expression.cs (BetterFunction): Catch hideous bug which was
28926 preventing us from detecting ambiguous calls due to implicit casts i.e
28929 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28931 * support.cs (Pair): Remove un-needed method. I figured why I was
28932 getting the error in cs-parser.jay, the variable in a foreach loop
28933 is readonly, and the compiler does not really treat this as a variable.
28935 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28936 instead of EQUALS in grammar.
28938 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28940 * expression.cs (Unary.DoResolve): Check whether the argument is
28943 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28945 * support.cs: Api for Pair to set a value. Despite the fact that
28946 the variables are public the MS C# compiler refuses to compile
28947 code that accesses the field if the variable is part of a foreach
28950 * statement.cs (Fixed): Begin implementation of the fixed
28953 (Block.AddVariable): Return the VariableInfo on success and null
28954 on failure instead of true/false.
28956 * cs-parser.jay (foreach): Catch errors on variables already
28957 defined (we were ignoring this value before) and properly unwind
28958 the block hierarchy
28960 (fixed_statement): grammar for the fixed statement.
28962 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28964 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28965 pointer types to be incretemented.
28967 (SizeOf): Implement.
28969 * cs-parser.jay (pointer_member_access): Implement
28970 expr->IDENTIFIER production.
28972 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28973 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28976 (Unary): Implement indirection.
28978 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28979 use in non-unsafe context).
28981 (SimpleName.DoResolve): Check for pointers in field access on safe
28984 (Expression.LoadFromPtr): Factor the load-indirect code in this
28985 function. This was duplicated in UnboxCast and ParameterReference
28987 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28989 * expression.cs (ComposedCast): report an error if a pointer cast
28990 is used in a safe region.
28992 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28993 pointer type casts in unsafe context.
28995 * codegen.cs (EmitContext): Set up IsUnsafe.
28997 * cs-parser.jay (non_expression_type): Add productions for pointer
29000 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
29001 code. We should not use force into static mode if the method is
29002 not virtual. Fixes bug in MIS
29004 * statement.cs (Do.Emit, While.Emit, For.Emit,
29005 Statement.EmitBoolExpression): Add support to Do and While to
29006 propagate infinite loop as `I do return' semantics.
29008 Improve the For case to also test for boolean constants.
29010 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
29011 to the list of attributes we can add.
29013 Remove `EmitContext' argument.
29015 * class.cs (Method.Define): Apply parameter attributes.
29016 (Constructor.Define): Apply parameter attributes.
29017 (MethodCore.LabelParameters): Move here the core of labeling
29020 * support.cs (ReflectionParameters.ParameterModifier,
29021 InternalParameters.ParameterModifier): Use IsByRef on the type and
29022 only return the OUT bit for these parameters instead of in/out/ref
29025 This is because I miss-understood things. The ParameterInfo.IsIn
29026 and IsOut represent whether the parameter has the [In] and [Out]
29029 2002-01-22 Miguel de Icaza <miguel@ximian.com>
29031 * ecore.cs (FieldExpr.Emit): Release temporaries.
29033 * assign.cs (LocalTemporary.Release): new function.
29035 * codegen.cs (EmitContext.GetTemporaryStorage,
29036 EmitContext.FreeTemporaryStorage): Rework the way we deal with
29037 temporary storage. Now we can "put back" localbuilders when we
29040 2002-01-21 Miguel de Icaza <miguel@ximian.com>
29042 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
29043 need to make a copy of the variable to generate verifiable code.
29045 2002-01-19 Miguel de Icaza <miguel@ximian.com>
29047 * driver.cs: Compute dynamically the system directory.
29049 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
29050 Slower, but more generally useful. Used by the abstract
29051 registering implementation.
29053 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
29054 the rules for the special rule on Type/instances. First check if
29055 we have the same name, and if so, try that special static path
29056 rather than the instance path.
29058 2002-01-18 Miguel de Icaza <miguel@ximian.com>
29060 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
29063 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
29064 Enum, ValueType, Delegate or Array for non-corlib compiles.
29066 * cs-tokenizer.cs: Catch long identifiers (645)
29068 * typemanager.cs (IndexerPropetyName): Ravi never tested this
29071 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
29072 fix, we were returning too early, so we were not registering
29073 pending methods from abstract classes.
29075 Do not register pending methods if the class is abstract.
29077 * expression.cs (Conditional.DoResolve): Report circular implicit
29078 conversions when we neecd to compute it for conditional
29081 (Is.DoResolve): If the expression is always of the provided type,
29082 flag warning 183. If the expression can not ever be of the
29083 provided type flag warning 184.
29085 * class.cs: Catch 169 as well.
29087 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
29090 2002-01-18 Nick Drochak <ndrochak@gol.com>
29092 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
29094 2002-01-17 Miguel de Icaza <miguel@ximian.com>
29096 * interface.cs: (PopulateMethod): Check for pointers being defined
29097 only if the unsafe context is active.
29098 (PopulateProperty): ditto.
29099 (PopulateIndexer): ditto.
29101 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
29102 specified. If pointers are present, make sure that they are
29103 present in an unsafe context.
29104 (Constructor, Constructor.Define): ditto.
29105 (Field, Field.Define): ditto.
29106 (Property, Property.Define): ditto.
29107 (Event, Event.Define): ditto.
29109 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
29110 hashtable if there are classes or structs defined.
29112 * expression.cs (LocalVariableReference.DoResolve): Simplify this
29113 code, as the constant resolution moved.
29115 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
29116 the metadata, so we can flag error 133.
29118 * decl.cs (MemberCore.UnsafeOK): New function to test that a
29119 pointer is being declared in an unsafe context.
29121 2002-01-16 Miguel de Icaza <miguel@ximian.com>
29123 * modifiers.cs (Modifiers.Check): Require a Location argument.
29124 Report error 227 for Unsafe use.
29126 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
29128 * statement.cs (For.Emit): If the test is null, then report that
29129 we do `return', as we wont reach anything afterwards.
29131 (Switch.SwitchGoverningType): Track the expression that matched
29134 * driver.cs: Allow negative numbers as an error code to flag.
29136 * cs-parser.jay: Handle 1551.
29138 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
29140 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29142 * cs-parser.jay: Report 1518 (type declaration can only contain
29143 class, struct, interface, enum or delegate)
29145 (switch_label): Report 1523 (keywords `case' or `default' must
29148 (opt_switch_sections): Report 1522 (empty switch)
29150 * driver.cs: Report 1515 (response file specified multiple times)
29151 Report 1516 (Source file specified multiple times).
29153 * expression.cs (Argument.Resolve): Signal 1510
29155 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
29156 access not allowed in static code)
29158 2002-01-11 Ravi Pratap <ravi@ximian.com>
29160 * typemanager.cs (IsPointerType): Utility method which we are going
29163 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
29164 the object type, so we take care of that.
29166 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
29168 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
29169 added to non-params parameters :-)
29171 * typemanager.cs (CSharpName): Include 'void' type too.
29173 (void_ptr_type): Include in the set of core types.
29175 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
29178 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
29181 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
29182 completely forgotten about it.
29184 2002-01-10 Ravi Pratap <ravi@ximian.com>
29186 * cs-parser.jay (pointer_type): Add. This begins our implementation
29187 of parsing rules for unsafe code.
29189 (unsafe_statement): Implement.
29191 (embedded_statement): Modify to include the above.
29193 * statement.cs (Unsafe): Implement new class for unsafe blocks.
29195 * codegen.cs (EmitContext.InUnsafe): Add. This determines
29196 if the current context is an unsafe one.
29198 * cs-parser.jay (local_variable_pointer_type): Since local variable types
29199 are handled differently, we need separate rules for them.
29201 (local_variable_declaration): Update to use local_variable_pointer_type
29202 to allow variable declarations of unmanaged pointer types.
29204 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
29205 in unsafe contexts.
29207 * ../errors/cs0214.cs : Add.
29209 2002-01-16 Nick Drochak <ndrochak@gol.com>
29211 * makefile: remove 'response' file when cleaning.
29213 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29215 * cs-parser.jay: Report 1524.
29217 2002-01-14 Miguel de Icaza <miguel@ximian.com>
29219 * typemanager.cs (RegisterMethod): drop checking if we have
29220 registered this from here
29222 2002-01-12 Miguel de Icaza <miguel@ximian.com>
29224 * class.cs (Method.EmitDestructor): Implement calling our base
29227 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
29228 value of InFinally.
29230 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
29231 this routine and will wrap the call in a try/catch block. Deal
29234 2002-01-11 Miguel de Icaza <miguel@ximian.com>
29236 * ecore.cs (Expression.MemberLookup): instead of taking a
29237 parameter `same_type' that was used to tell whether we could
29238 access private members we compute our containing type from the
29241 (FieldExpr): Added partial support for volatile fields. This does
29242 not work for volatile fields exposed from assemblies, as I can not
29243 figure out how to extract the modreq from it.
29245 Updated all the source files to use this.
29247 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
29248 because it is referenced by MemberLookup very often.
29250 2002-01-09 Ravi Pratap <ravi@ximian.com>
29252 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
29253 TypeBuilder.GetCustomAttributes to retrieve what we need.
29255 Get rid of redundant default_member_attr_type as this is the same as
29256 default_member_type which already exists.
29258 * interface.cs, attribute.cs : Update accordingly.
29260 2002-01-08 Miguel de Icaza <miguel@ximian.com>
29262 * typemanager.cs: Enable IndexerPropertyName again. It does not
29263 work for TYpeBuilders though. Ravi, can you please fix this?
29265 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
29267 * expression.cs (Argument.Emit): Handle the case of ref objects
29268 being passed to ref functions;
29270 (ParameterReference.EmitLoad): Loads the content of the pointer
29271 without dereferencing.
29273 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29275 * cs-tokenizer.cs: Implemented the pre-processing expressions.
29277 2002-01-08 Ravi Pratap <ravi@ximian.com>
29279 * class.cs (Indexer.DefineMethod): Incorporate the interface
29280 type in the name of the method if we are doing explicit interface
29283 * expression.cs (ConversionExists): Remove as it is completely obsolete.
29285 (BetterConversion): Fix extremely trivial bug where we were referring to
29286 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
29289 * ../errors/bug16.cs : Add although we have fixed it.
29291 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29293 * expression.cs (BaseIndexer): Begin implementation.
29295 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
29297 * cs-parser.jay (indexer_declarator): Use qualified_identifier
29298 production directly to remove a shift/reduce, and implement
29299 explicit interface implementation.
29301 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
29302 after a floating point suffix.
29304 * expression.cs (DoNumericPromotions): Improved the conversion for
29305 uint/uint. If we have a constant, we avoid doing a typecast to a
29308 * class.cs (Indexer): Implement explicit interface implementation
29311 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
29313 * class.cs: make the default instance constructor public and hidebysig.
29315 2001-01-03 Ravi Pratap <ravi@ximian.com>
29317 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
29318 so we can call it from elsewhere.
29320 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
29321 we emit it internally if the class has a defined indexer; otherwise the user
29322 emits it by decorating the class definition with the DefaultMemberAttribute.
29324 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
29325 attribute is not used on a type which defines an indexer.
29327 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
29328 character when we skip whitespace.
29330 * ../errors/cs0646.cs : Add.
29332 2002-01-03 Miguel de Icaza <miguel@ximian.com>
29334 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
29337 * makefile: Add practical target `mcs3.exe' which builds the third
29338 generation compiler.
29340 * expression.cs (New): Fix structures constructor calling.
29342 * class.cs (Property, Method, Indexer): Emit Final flag on the
29343 method if we are an interface implementation and we are not
29346 * ecore.cs (PropertyExpr): New public field `IsBase', tells
29347 whether this property is referencing a `base' method.
29349 * expression.cs (Invocation.EmitCall): take an extra argument:
29350 is_base, this is used to determine whether the `call' or
29351 `callvirt' opcode should be used.
29354 * delegate.cs: update EmitCall.
29356 * class.cs (Method.Define): Set NewSlot for the cases where we are
29357 not implementing an interface method.
29359 (Property.Define): ditto.
29361 2002-01-02 Miguel de Icaza <miguel@ximian.com>
29363 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
29364 'r'. Allows mcs to parse itself fully.
29366 2002-01-02 Ravi Pratap <ravi@ximian.com>
29368 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
29369 of the number of initializers that require the InitializeArray method.
29371 (CheckIndices): Store the Expression in all cases - not the plain value. Also
29372 update the above field where necessary.
29374 (MakeByteBlob): Update accordingly.
29376 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
29379 (EmitDynamicInitializers): Update in accordance with the new optimization.
29381 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
29382 same OpCode applies.
29384 * cs-parser.jay : Fix some glaring errors I introduced.
29386 2002-01-01 Ravi Pratap <ravi@ximian.com>
29388 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
29389 so that we can check for name clashes there too.
29391 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
29392 for interface indexers.
29394 * interfaces.cs (Define): Emit the default member attribute.
29396 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
29397 variable was being referred to while setting the value ;-)
29399 2002-01-01 Miguel de Icaza <miguel@ximian.com>
29401 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
29402 byte-by-byte information when we know the data is zero.
29404 Make the block always a multiple of 4, because
29405 DefineInitializedData has a bug.
29407 * assign.cs: Fix, we should assign from the temporary, not from
29410 * expression.cs (MakeByteBlob): Fix my incorrect code.
29412 2001-12-31 Miguel de Icaza <miguel@ximian.com>
29414 * typemanager.cs (EnumToUnderlying): This function is used to get
29415 the underlying type from an enumeration, because it does not
29418 * constant.cs: Use the I4_S form for values between -128 and 127.
29420 * statement.cs (Block.LookupLabel): Looks up a label.
29421 (Block): Drop support for labeled blocks.
29423 (LabeledStatement): New kind of statement that represents a label
29426 (Goto): Finally implement this bad boy.
29428 * cs-parser.jay: Update to reflect new mechanism to implement
29431 2001-12-30 Miguel de Icaza <miguel@ximian.com>
29433 * codegen.cs (EmitContext.This): a codegen property that keeps the
29434 a single instance of this instead of creating many different this
29437 * delegate.cs (Delegate.DoResolve): Update to use the property;
29439 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
29441 * expression.cs (BaseAccess.DoResolve): Ditto.
29443 2001-12-29 Ravi Pratap <ravi@ximian.com>
29445 * typemanager.cs (methodimpl_attr_type): Add to hold the type
29446 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
29448 (InitCoreTypes): Update accordingly.
29450 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
29451 so we can quickly store the state.
29453 (ApplyAttributes): Set the correct implementation flags
29454 for InternalCall methods.
29456 2001-12-29 Miguel de Icaza <miguel@ximian.com>
29458 * expression.cs (EmitCall): if a method is not virtual, then do
29459 not use callvirt on it.
29461 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
29462 user defined stuff) requires the use of stobj, which takes an
29463 address on the stack instead of an array and an index. So emit
29464 the Ldelema operation for it.
29466 (EmitStoreOpcode): Use stobj for valuetypes.
29468 (UnaryMutator.EmitCode): Use the right 1 value depending on
29469 whether we are dealing with int64/uint64, float or doubles.
29471 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
29472 constructors that I implemented last night.
29474 (Constructor.IsDefault): Fix to work properly for static
29477 * cs-parser.jay (CheckDef): report method signature errors.
29478 Update error number 103 to be 132.
29480 * decl.cs: New AdditionResult enumeration value: MethodExists.
29481 Although we do this check for methods later on in the semantic
29482 analysis, catching repeated default constructors is so easy that
29483 we catch these here.
29485 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
29488 (ParameterReference.EmitAssign, Emit): handle
29491 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
29492 (ArrayAccess.EmitStoreOpcode): ditto.
29494 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
29496 * expression.cs (MakeByteBlob): Complete all the missing types
29497 (uint, short, ushort, byte, sbyte)
29499 * class.cs: Only init instance field initializers on instance
29502 Rename `constructors' to instance_constructors.
29504 (TypeContainer.AddConstructor): Only add constructors to the list
29505 if it is not static.
29507 Make sure that we handle default_static_constructor independently
29508 everywhere where we handle instance_constructors
29510 2001-12-28 Miguel de Icaza <miguel@ximian.com>
29512 * class.cs: Do not lookup or create a base initializer for a
29513 static constructor.
29515 (ConstructorInitializer.Resolve): use the proper type to lookup
29518 * cs-parser.jay: Report error 1585 (modifiers between type and name).
29520 * enum.cs, interface.cs: Remove CloseType, this is taken care by
29523 * decl.cs: CloseType is now an virtual method, the default
29524 implementation just closes this type.
29526 2001-12-28 Ravi Pratap <ravi@ximian.com>
29528 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
29529 to PreserveSig by default. Also emit HideBySig on such methods.
29531 Basically, set the defaults to standard values.
29533 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
29534 argument, if candidate is better, it can't be worse than the best !
29536 (Invocation): Re-write bits to differentiate between methods being
29537 applicable in their expanded form and their normal form - for params
29540 Get rid of use_standard everywhere as only standard conversions are allowed
29541 in overload resolution.
29543 More spec conformance.
29545 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29547 * driver.cs: Add --timestamp, to see where the compiler spends
29550 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29551 `this' in static code.
29553 (SimpleName.DoResolve): Implement in terms of a helper function
29554 that allows static-references to be passed upstream to
29557 (Expression.ResolveWithSimpleName): Resolve specially simple
29558 names when called by MemberAccess to implement the special
29561 (Expression.ImplicitReferenceConversion): Handle conversions from
29562 Null to reference types before others, as Null's type is
29565 * expression.cs (Invocation.EmitCall): Handle the special case of
29566 calling methods declared on a reference type from a ValueType
29567 (Base classes System.Object and System.Enum)
29569 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29570 the left hand side is a TypeExpr, not on every enumeration.
29572 (Binary.Resolve): If types are reference types, then do a cast to
29573 object on operators != and == of both arguments.
29575 * typemanager.cs (FindMembers): Extract instance and static
29576 members if requested.
29578 * interface.cs (PopulateProperty): Use void_type instead of null
29579 as the return type for the setter method.
29581 (PopulateIndexer): ditto.
29583 2001-12-27 Ravi Pratap <ravi@ximian.com>
29585 * support.cs (ReflectionParameters): Fix minor bug where we
29586 were examining the wrong parameter for the ParamArray attribute.
29588 Cope with requests for the type of the parameter at position
29589 greater than the params parameter's. We now return the element
29590 type of the params array as that makes more sense.
29592 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29593 accordingly as we no longer have to extract the element type
29596 (Invocation.OverloadResolve): Update.
29598 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29600 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29601 against IEnumerator, test whether the return value is a descendant
29602 of the IEnumerator interface.
29604 * class.cs (Indexer.Define): Use an auxiliary method to implement
29605 the other bits of the method definition. Begin support for
29606 explicit interface implementation.
29608 (Property.DefineMethod): Use TypeManager.void_type instead of null
29609 for an empty return value.
29611 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29613 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29614 dealing with a FieldExpr which is composed of a FieldBuilder, in
29615 the code path we did extract the constant, but we should have
29616 obtained the underlying value to be able to cast it (otherwise we
29617 end up in an infinite loop, this is what Ravi was running into).
29619 (ArrayCreation.UpdateIndices): Arrays might be empty.
29621 (MemberAccess.ResolveMemberAccess): Add support for section
29622 14.5.4.1 that deals with the special case of E.I when E is a type
29623 and something else, that I can be a reference to a static member.
29625 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29626 handle a particular array type to create byte blobs, it is just
29627 something we dont generate byteblobs for.
29629 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29632 * location.cs (Push): remove the key from the hashtable that we
29633 are about to add. This happens for empty files.
29635 * driver.cs: Dispose files after we have parsed them.
29637 (tokenize): new function that only runs the tokenizer on its
29638 input, for speed testing.
29640 2001-12-26 Ravi Pratap <ravi@ximian.com>
29642 * class.cs (Event.Define): Define the private field only if there
29643 are no accessors defined.
29645 * expression.cs (ResolveMemberAccess): If there is no associated
29646 field with the event, that means we have an event defined with its
29647 own accessors and we should flag error cs0070 since transforming
29648 ourselves into a field is not valid in that case.
29650 * ecore.cs (SimpleName.DoResolve): Same as above.
29652 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29653 and charset to sane values.
29655 2001-12-25 Ravi Pratap <ravi@ximian.com>
29657 * assign.cs (DoResolve): Perform check on events only if they
29658 are being accessed outside the declaring type.
29660 * cs-parser.jay (event_declarations): Update rules to correctly
29661 set the type of the implicit parameter etc.
29663 (add_accessor, remove_accessor): Set current local parameters.
29665 * expression.cs (Binary): For delegate addition and subtraction,
29666 cast the return value from the method into the appropriate delegate
29669 2001-12-24 Ravi Pratap <ravi@ximian.com>
29671 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29672 of these as the workaround is unnecessary.
29674 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29675 delegate data - none of that is needed at all.
29677 Re-write bits to extract the instance expression and the delegate method
29680 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29683 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29684 of attaching attributes instead of duplicating code everywhere.
29686 * everywhere : Update code to do attribute emission using the above method.
29688 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29690 * expression.cs (IsParamsMethodApplicable): if there are not
29691 parameters, return immediately.
29693 * ecore.cs: The 0 literal can be implicity converted to an enum
29696 (SimpleName.DoResolve): First lookup the type, then lookup the
29699 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29700 want to get its address. If the InstanceExpression is not
29701 addressable, store the result in a temporary variable, then get
29704 * codegen.cs: Only display 219 errors on warning level or above.
29706 * expression.cs (ArrayAccess): Make it implement the
29707 IMemoryLocation interface.
29709 (Binary.DoResolve): handle the operator == (object a, object b)
29710 and operator != (object a, object b) without incurring into a
29711 BoxedCast (because 5 != o should never be performed).
29713 Handle binary enumerator operators.
29715 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29716 value type, otherwise use Ldelem_ref.
29718 Use precomputed names;
29720 (AddressOf): Implement address of
29722 * cs-parser.jay (labeled_statement): Fix recursive block
29723 addition by reworking the production.
29725 * expression.cs (New.DoEmit): New has a special case:
29727 If we are dealing with a ValueType, we have a few
29728 situations to deal with:
29730 * The target of New is a ValueType variable, that is
29731 easy, we just pass this as the variable reference
29733 * The target of New is being passed as an argument,
29734 to a boxing operation or a function that takes a
29737 In this case, we need to create a temporary variable
29738 that is the argument of New.
29741 2001-12-23 Ravi Pratap <ravi@ximian.com>
29743 * rootcontext.cs (LookupType): Check that current_type is not null before
29744 going about looking at nested types.
29746 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29747 not implement the IAssignMethod interface any more.
29749 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29750 where we tranform them into FieldExprs if they are being resolved from within
29751 the declaring type.
29753 * ecore.cs (SimpleName.DoResolve): Do the same here.
29755 * assign.cs (DoResolve, Emit): Clean up code considerably.
29757 * ../errors/bug10.cs : Add.
29759 * ../errors/cs0070.cs : Add.
29761 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29763 * assign.cs : Get rid of EventIsLocal everywhere.
29765 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29767 * ecore.cs (ConvertIntLiteral): finished the implementation.
29769 * statement.cs (SwitchLabel): Convert the value we are using as a
29770 key before looking up the table.
29772 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29774 * codegen.cs (EmitTopBlock): Require a Location argument now.
29776 * cs-parser.jay (constructor_declarator): We need to setup
29777 current_local_parameters before we parse the
29778 opt_constructor_initializer, to allow the variables to be bound
29779 to the constructor arguments.
29781 * rootcontext.cs (LookupType): First lookup nested classes in our
29782 class and our parents before we go looking outside our class.
29784 * expression.cs (ConstantFold): Extract/debox the values at the
29787 * rootcontext.cs (EmitCode): Resolve the constants first before we
29788 resolve the types. This is not really needed, but it helps debugging.
29790 * statement.cs: report location.
29792 * cs-parser.jay: pass location to throw statement.
29794 * driver.cs: Small bug fix.
29796 * report.cs: Updated format to be 4-zero filled digits.
29798 2001-12-22 Ravi Pratap <ravi@ximian.com>
29800 * expression.cs (CheckIndices): Fix minor bug where the wrong
29801 variable was being referred to ;-)
29803 (DoEmit): Do not call EmitStaticInitializers when the
29804 underlying type is System.Object.
29806 2001-12-21 Ravi Pratap <ravi@ximian.com>
29808 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29809 and do the usual workaround for SRE.
29811 * class.cs (MyEventBuilder.EventType): New member to get at the type
29812 of the event, quickly.
29814 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29816 * assign.cs (Assign.DoResolve): Handle the case when the target
29817 is an EventExpr and perform the necessary checks.
29819 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29822 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29824 (EventExpr): Set the type in the constructor itself since we
29825 are meant to be born fully resolved.
29827 (EventExpr.Define): Revert code I wrote earlier.
29829 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29830 instance expression is null. The instance expression is a This in that case
29831 or a null, depending on whether it is a static method or not.
29833 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29834 refers to more than one method.
29836 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29837 and accordingly flag errors.
29839 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29841 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29843 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29845 * location.cs (ToString): Provide useful rutine.
29847 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29849 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29850 objects, return the actual integral boxed.
29852 * statement.cs (SwitchLabel): define an ILLabel for each
29855 (Switch.CheckSwitch): If the value is a Literal, extract
29856 the underlying literal.
29858 Also in the unused hashtable we had, add the SwitchLabel so we can
29859 quickly look this value up.
29861 * constant.cs: Implement a bunch of new constants. Rewrite
29862 Literal based on this. Made changes everywhere to adapt to this.
29864 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29865 dereferencing array only once, and also copes with enumrations.
29867 bytes are two bytes wide, not one.
29869 (Cast): Perform constant conversions.
29871 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29872 wrappers to the literals here.
29874 * expression.cs (DoNumericPromotions): long literals can converted
29875 to ulong implicity (this is taken care of elsewhere, but I was
29876 missing this spot).
29878 * ecore.cs (Expression.Literalize): Make the return type Literal,
29879 to improve type checking.
29881 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29883 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29885 * literal.cs: Revert code from ravi that checked the bounds. The
29886 bounds are sane by the definition of the type itself.
29888 * typemanager.cs: Fix implementation of ImplementsInterface. We
29889 need to actually look up in our parent hierarchy for interfaces
29892 * const.cs: Use the underlying type for enumerations
29894 * delegate.cs: Compute the basename for the delegate creation,
29895 that should fix the delegate test case, and restore the correct
29896 Type Lookup semantics in rootcontext
29898 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29899 referencing a nested type with the Reflection API is using the "+"
29902 * cs-parser.jay: Do not require EOF token at the end.
29904 2001-12-20 Ravi Pratap <ravi@ximian.com>
29906 * rootcontext.cs (LookupType): Concatenate type names with
29907 a '.' instead of a '+' The test suite passes again.
29909 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29910 field of the enumeration.
29912 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29913 the case when the member is an EventExpr.
29915 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29916 static has an associated instance expression.
29918 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29920 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29922 * class.cs (Event.Define): Register event and perform appropriate checks
29925 We define the Add and Remove methods even if the use provides none because
29926 in that case, we provide default implementations ourselves.
29928 Define a private field of the type of the event. This is done by the CSC compiler
29929 and we should be doing it too ;-)
29931 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29932 More methods we use in code we generate.
29934 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29937 (InitCoreTypes): Update accordingly for the above.
29939 * class.cs (Event.Emit): Generate code for default accessors that we provide
29941 (EmitDefaultMethod): Do the job in the above.
29943 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29946 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29948 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29949 builders even if we were missing one.
29951 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29952 pass the Basename as our class name instead of the Name. The
29953 basename will be correctly composed for us.
29955 * parameter.cs (Paramters): Now takes a Location argument.
29957 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29958 make all the code call directly LookupType in RootContext and take
29959 this chance to pass the Location information everywhere.
29961 * Everywhere: pass Location information.
29963 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29965 * class.cs (Constructor.Define): Updated way of detecting the
29966 length of the parameters.
29968 (TypeContainer.DefineType): Use basename as the type name for
29971 (TypeContainer.Define): Do not recursively define types here, as
29972 definition is taken care in order by the RootContext.
29974 * tree.cs: Keep track of namespaces in a per-file basis.
29976 * parameter.cs (Parameter.ComputeSignature): Update to use
29979 (Parameters.GetSignature): ditto.
29981 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29982 instead of a TypeContainer.
29984 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29985 resolve names. Because we need to be resolve in our context, not
29988 * driver.cs: Implement response files.
29990 * class.cs (TypeContainer.DefineType): If we are defined, do not
29991 redefine ourselves.
29993 (Event.Emit): Emit the code for add/remove handlers.
29994 (Event.Define): Save the MethodBuilders for add/remove.
29996 * typemanager.cs: Use pair here too.
29998 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29999 DictionaryEntry requires the first argument to be non-null.
30001 (enum_declaration): Compute full name for registering the
30004 (delegate_declaration): Instead of using
30005 formal_parameter_list, use opt_formal_parameter_list as the list
30008 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
30009 (EventParsing): New property that controls whether `add' and
30010 `remove' are returned as tokens or identifiers (for events);
30012 2001-12-19 Ravi Pratap <ravi@ximian.com>
30014 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
30015 use MyEventBuilder only and let it wrap the real builder for us.
30017 (MyEventBuilder): Revamp constructor etc.
30019 Implement all operations that we perform on EventBuilder in precisely the same
30022 (FindMembers): Update to use the EventBuilder member.
30024 (Event.Emit): Update accordingly.
30026 2001-12-18 Ravi Pratap <ravi@ximian.com>
30028 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
30029 by calling the appropriate methods.
30031 (GetCustomAttributes): Make stubs as they cannot possibly do anything
30034 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
30036 2001-12-17 Ravi Pratap <ravi@ximian.com>
30038 * delegate.cs (Delegate.Populate): Check that the return type
30039 and various parameters types are indeed accessible.
30041 * class.cs (Constructor.Define): Same here.
30043 (Field.Define): Ditto.
30045 (Event.Define): Ditto.
30047 (Operator.Define): Check that the underlying Method defined itself
30048 correctly - so it's MethodBuilder should not be null.
30050 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
30051 expression happens to be null.
30053 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
30054 members but as of now we don't seem to be able to do anything really useful with it.
30056 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
30057 not the EventBuilder.
30059 2001-12-18 Miguel de Icaza <miguel@ximian.com>
30061 * cs-tokenizer.cs: Add support for defines.
30062 Add support for #if, #elif, #else, #endif
30064 (eval_var): evaluates a variable.
30065 (eval): stubbed for evaluating functions.
30067 * cs-parser.jay: Pass the defines information
30069 * driver.cs: Add --define command line option.
30071 * decl.cs: Move MemberCore here.
30073 Make it the base class for DeclSpace. This allows us to catch and
30074 report 108 and 109 for everything now.
30076 * class.cs (TypeContainer.Define): Extract all the members
30077 before populating and emit the warning 108 (new keyword required
30078 to override) instead of having each member implement this.
30080 (MemberCore.Define): New abstract method, we will be using this in
30081 the warning reporting engine in Populate.
30083 (Operator.Define): Adjust to new MemberCore protocol.
30085 * const.cs (Const): This does not derive from Expression, it is a
30086 temporary object we use to create fields, it is a MemberCore.
30088 * class.cs (Method.Define): Allow the entry point to be in a
30091 * driver.cs: Rewrite the argument handler to clean it up a bit.
30093 * rootcontext.cs: Made it just an auxiliary namespace feature by
30094 making everything static.
30096 * driver.cs: Adapt code to use RootContext type name instead of
30099 * delegate.cs: Remove RootContext argument.
30101 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
30104 * class.cs (Event.Define): The lookup can fail.
30106 * cs-tokenizer.cs: Begin implementation of pre-procesor.
30108 * expression.cs: Resolve the this instance before invoking the code.
30110 2001-12-17 Miguel de Icaza <miguel@ximian.com>
30112 * cs-parser.jay: Add a production in element_access that allows
30113 the thing to become a "type" reference. This way we can parse
30114 things like "(string [])" as a type.
30116 Note that this still does not handle the more complex rules of
30120 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
30122 * ecore.cs: (CopyNewMethods): new utility function used to
30123 assemble the list of methods from running FindMembers.
30125 (MemberLookup): Rework FindMembers so that
30127 2001-12-16 Miguel de Icaza <miguel@ximian.com>
30129 * class.cs (TypeContainer): Remove Delegates who fail to be
30132 * delegate.cs (Populate): Verify that we dont get null return
30133 values. TODO: Check for AsAccessible.
30135 * cs-parser.jay: Use basename to emit error 574 (destructor should
30136 have the same name as container class), not the full name.
30138 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
30139 possible representation.
30141 Also implements integer type suffixes U and L.
30143 2001-12-15 Miguel de Icaza <miguel@ximian.com>
30145 * expression.cs (ArrayCreation.DoResolve): We need to do the
30146 argument resolution *always*.
30148 * decl.cs: Make this hold the namespace. Hold the root context as
30150 (LookupType): Move here.
30152 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
30154 * location.cs (Row, Name): Fixed the code, it was always returning
30155 references to the first file.
30157 * interface.cs: Register properties defined through interfaces.
30159 * driver.cs: Add support for globbing on the command line
30161 * class.cs (Field): Make it derive from MemberCore as well.
30164 2001-12-15 Ravi Pratap <ravi@ximian.com>
30166 * class.cs (Event::Define): Check that the type of the event is a delegate
30167 type else flag error #66.
30169 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
30172 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
30173 values of EntryPoint, CharSet etc etc.
30175 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
30177 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
30178 be null and we should ignore this. I am not sure if this is really clean. Apparently,
30179 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
30180 which needs this to do its work.
30182 * ../errors/cs0066.cs : Add.
30184 2001-12-14 Miguel de Icaza <miguel@ximian.com>
30186 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
30189 * class.cs: (MethodSignature.MethodSignature): Removed hack that
30190 clears out the parameters field.
30191 (MemberSignatureCompare): Cleanup
30193 (MemberCore): New base class used to share code between MethodCore
30196 (RegisterRequiredImplementations) BindingFlags.Public requires
30197 either BindingFlags.Instace or Static. Use instance here.
30199 (Property): Refactored code to cope better with the full spec.
30201 * parameter.cs (GetParameterInfo): Return an empty array instead
30204 * class.cs (Property): Abstract or extern properties have no bodies.
30206 * parameter.cs (GetParameterInfo): return a zero-sized array.
30208 * class.cs (TypeContainer.MethodModifiersValid): Move all the
30209 method modifier validation to the typecontainer so we can reuse
30210 this on properties.
30212 (MethodCore.ParameterTypes): return an empty sized array of types.
30214 (Property.Define): Test property modifier validity.
30216 Add tests for sealed/override too.
30218 (Method.Emit): abstract or extern methods have no bodies.
30220 2001-12-14 Ravi Pratap <ravi@ximian.com>
30222 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
30225 (Method::Define, ::Emit): Modify accordingly.
30227 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
30229 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
30231 * makefile: Pass in /unsafe.
30233 2001-12-13 Miguel de Icaza <miguel@ximian.com>
30235 * class.cs (MakeKey): Kill routine.
30237 * class.cs (TypeContainer.Define): Correctly define explicit
30238 method implementations (they require the full interface name plus
30241 * typemanager.cs: Deply the PtrHashtable here and stop using the
30242 lame keys. Things work so much better.
30244 This of course broke everyone who depended on `RegisterMethod' to
30245 do the `test for existance' test. This has to be done elsewhere.
30247 * support.cs (PtrHashtable): A hashtable that avoid comparing with
30248 the object stupid Equals method (because, that like fails all over
30249 the place). We still do not use it.
30251 * class.cs (TypeContainer.SetRequiredInterface,
30252 TypeContainer.RequireMethods): Killed these two routines and moved
30253 all the functionality to RegisterRequiredImplementations.
30255 (TypeContainer.RegisterRequiredImplementations): This routine now
30256 registers all the implementations required in an array for the
30257 interfaces and abstract methods. We use an array of structures
30258 which can be computed ahead of time to reduce memory usage and we
30259 also assume that lookups are cheap as most classes will not
30260 implement too many interfaces.
30262 We also avoid creating too many MethodSignatures.
30264 (TypeContainer.IsInterfaceMethod): Update and optionally does not
30265 clear the "pending" bit if we find that there are problems with
30268 (TypeContainer.VerifyPendingMethods): Update to report errors of
30269 methods that look like implementations but are not.
30271 (TypeContainer.Define): Add support for explicit interface method
30274 2001-12-12 Miguel de Icaza <miguel@ximian.com>
30276 * typemanager.cs: Keep track of the parameters here instead of
30277 being a feature of the TypeContainer.
30279 * class.cs: Drop the registration of parameters here, as
30280 InterfaceMethods are also interface declarations.
30282 * delegate.cs: Register methods with the TypeManager not only with
30283 the TypeContainer. This code was buggy.
30285 * interface.cs: Full registation here.
30287 2001-12-11 Miguel de Icaza <miguel@ximian.com>
30289 * expression.cs: Remove reducer for binary expressions, it can not
30292 * const.cs: Put here the code that used to go into constant.cs
30294 * constant.cs: Put here the code for constants, this is a new base
30295 class for Literals.
30297 * literal.cs: Make Literal derive from Constant.
30299 2001-12-09 Miguel de Icaza <miguel@ximian.com>
30301 * statement.cs (Return.Emit): Report error 157 if the user
30302 attempts to return from a finally block.
30304 (Return.Emit): Instead of emitting a return, jump to the end of
30307 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
30308 LocalBuilder to store the result of the function. ReturnLabel is
30309 the target where we jump.
30312 2001-12-09 Radek Doulik <rodo@ximian.com>
30314 * cs-parser.jay: remember alias in current namespace
30316 * ecore.cs (SimpleName::DoResolve): use aliases for types or
30319 * class.cs (LookupAlias): lookup alias in my_namespace
30321 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
30323 (LookupAlias): lookup alias in this and if needed in parent
30326 2001-12-08 Miguel de Icaza <miguel@ximian.com>
30330 * rootcontext.cs: (ModuleBuilder) Made static, first step into
30331 making things static. I need this to avoid passing the
30332 TypeContainer when calling ParameterType.
30334 * support.cs (InternalParameters.ParameterType): Remove ugly hack
30335 that did string manipulation to compute the type and then call
30336 GetType. Use Parameter.ParameterType instead.
30338 * cs-tokenizer.cs: Consume the suffix for floating values.
30340 * expression.cs (ParameterReference): figure out whether this is a
30341 reference parameter or not. Kill an extra variable by computing
30342 the arg_idx during emission.
30344 * parameter.cs (Parameters.GetParameterInfo): New overloaded
30345 function that returns whether a parameter is an out/ref value or not.
30347 (Parameter.ParameterType): The type of the parameter (base,
30348 without ref/out applied).
30350 (Parameter.Resolve): Perform resolution here.
30351 (Parameter.ExternalType): The full type (with ref/out applied).
30353 * statement.cs (Using.Emit, Using.EmitExpression): Implement
30354 support for expressions on the using statement.
30356 2001-12-07 Miguel de Icaza <miguel@ximian.com>
30358 * statement.cs (Using.EmitLocalVariableDecls): Split the
30359 localvariable handling of the using statement.
30361 (Block.EmitMeta): Keep track of variable count across blocks. We
30362 were reusing slots on separate branches of blocks.
30364 (Try.Emit): Emit the general code block, we were not emitting it.
30366 Check the type of the declaration to be an IDisposable or
30367 something that can be implicity converted to it.
30369 Emit conversions if required.
30371 * ecore.cs (EmptyExpression): New utility class.
30372 (Expression.ImplicitConversionExists): New utility function.
30374 2001-12-06 Miguel de Icaza <miguel@ximian.com>
30376 * statement.cs (Using): Implement.
30378 * expression.cs (LocalVariableReference): Support read only variables.
30380 * statement.cs: Remove the explicit emit for the Leave opcode.
30381 (VariableInfo): Add a readonly field.
30383 2001-12-05 Miguel de Icaza <miguel@ximian.com>
30385 * ecore.cs (ConvCast): new class used to encapsulate the various
30386 explicit integer conversions that works in both checked and
30387 unchecked contexts.
30389 (Expression.ConvertNumericExplicit): Use new ConvCast class to
30390 properly generate the overflow opcodes.
30392 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30394 * statement.cs: The correct type for the EmptyExpression is the
30395 element_type, not the variable type. Ravi pointed this out.
30397 2001-12-04 Ravi Pratap <ravi@ximian.com>
30399 * class.cs (Method::Define): Handle PInvoke methods specially
30400 by using DefinePInvokeMethod instead of the usual one.
30402 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
30403 above to do the task of extracting information and defining the method.
30405 2001-12-04 Ravi Pratap <ravi@ximian.com>
30407 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
30408 of the condition for string type.
30410 (Emit): Move that here.
30412 (ArrayCreation::CheckIndices): Keep string literals in their expression
30415 (EmitDynamicInitializers): Handle strings appropriately.
30417 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30419 * codegen.cs (EmitContext): Replace multiple variables with a
30420 single pointer to the current Switch statement.
30422 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
30425 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30429 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
30432 (Foreach.Emit): Foreach on arrays was not setting
30433 up the loop variables (for break/continue).
30435 (GotoCase): Semi-implented.
30437 2001-12-03 Ravi Pratap <ravi@ximian.com>
30439 * attribute.cs (CheckAttribute): Handle system attributes by using
30440 Attribute.GetAttributes to examine information we need.
30442 (GetValidPlaces): Same here.
30444 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
30446 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
30448 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
30450 (Method::Define): Set appropriate flags if we have a DllImport attribute.
30452 (Method::Emit): Handle the case when we are a PInvoke method.
30454 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30456 * expression.cs: Use ResolveWithSimpleName on compound names.
30458 2001-12-02 Ravi Pratap <ravi@ximian.com>
30460 * constant.cs (EmitConstant): Make sure we resolve the associated expression
30461 before trying to reduce it.
30463 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
30465 * constant.cs (LookupConstantValue): Implement.
30467 (EmitConstant): Use the above in emitting the constant.
30469 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
30470 that are user-defined by doing a LookupConstantValue on them.
30472 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
30475 2001-11-29 Miguel de Icaza <miguel@ximian.com>
30477 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
30479 (BaseAccess.DoResolve): Implement.
30481 (MemberAccess.DoResolve): Split this routine into a
30482 ResolveMemberAccess routine that can be used independently
30484 2001-11-28 Miguel de Icaza <miguel@ximian.com>
30486 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
30487 As that share bits of the implementation. Is returns a boolean,
30488 while As returns the Type that is being probed.
30490 2001-12-01 Ravi Pratap <ravi@ximian.com>
30492 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
30493 instead of a Literal - much easier.
30495 (EnumInTransit): Remove - utterly useless :-)
30497 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
30499 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
30501 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
30502 chain when we have no associated expression.
30504 2001-11-30 Ravi Pratap <ravi@ximian.com>
30506 * constant.cs (Define): Use Location while reporting the errror.
30508 Also emit a warning when 'new' is used and there is no inherited
30511 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
30514 (LookupEnumValue): Implement to lookup an enum member's value and define it
30517 (Populate): Re-write accordingly to use the above routine.
30519 2001-11-27 Miguel de Icaza <miguel@ximian.com>
30521 * expression.cs (This): Fix prototype for DoResolveLValue to
30522 override the base class DoResolveLValue.
30524 * cs-parser.cs: Report errors cs574 and cs575 (destructor
30527 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
30528 (we need to load the address of the field here). This fixes
30531 (FieldExpr.DoResolveLValue): Call the DoResolve
30532 function to initialize the Instance expression.
30534 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
30535 correctly the GetEnumerator operation on a value type.
30537 * cs-parser.jay: Add more simple parsing error catches.
30539 * statement.cs (Switch): Add support for string switches.
30540 Handle null specially.
30542 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30544 2001-11-28 Ravi Pratap <ravi@ximian.com>
30546 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30548 (declare_local_constant): New helper function.
30550 * statement.cs (AddConstant): Keep a separate record of constants
30552 (IsConstant): Implement to determine if a variable is a constant.
30554 (GetConstantExpression): Implement.
30556 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30558 * statement.cs (IsVariableDefined): Re-write.
30560 2001-11-27 Ravi Pratap <ravi@ximian.com>
30562 * class.cs (TypeContainer::FindMembers): Look for constants
30563 in the case when we are looking for MemberTypes.Field
30565 * expression.cs (MemberAccess::DoResolve): Check that in the
30566 case we are a FieldExpr and a Literal, we are not being accessed
30567 by an instance reference.
30569 * cs-parser.jay (local_constant_declaration): Implement.
30571 (declaration_statement): Implement for constant declarations.
30573 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30575 * statement.cs (Switch): Catch double defaults.
30577 (Switch): More work on the switch() statement
30578 implementation. It works for integral values now, need to finish
30582 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30584 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30585 integer literals into other integer literals. To be used by
30588 2001-11-24 Ravi Pratap <ravi@ximian.com>
30590 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30593 (EmitDynamicInitializers): Cope with the above since we extract data
30594 directly from ArrayData now.
30596 (ExpectInitializers): Keep track of whether initializers are mandatory
30599 (Bounds): Make it a hashtable to prevent the same dimension being
30600 recorded for every element in that dimension.
30602 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30605 Also fix bug which was causing the indices to be emitted in the reverse
30608 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30610 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30611 unfinished. They do not work, because the underlying code is
30614 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30616 * cs-parser.jay: Remove bogus fixme.
30618 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30619 on Switch statement.
30621 2001-11-23 Ravi Pratap <ravi@ximian.com>
30623 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30626 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30627 parameter. Apparently, any expression is allowed.
30629 (ValidateInitializers): Update accordingly.
30631 (CheckIndices): Fix some tricky bugs thanks to recursion.
30633 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30634 I was being completely brain-dead.
30636 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30637 and re-write acordingly.
30639 (DelegateInvocation): Re-write accordingly.
30641 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30643 (MakeByteBlob): Handle types more correctly.
30645 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30646 initialization from expressions but it is incomplete because I am a complete
30649 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30651 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30652 on If. Basically, we have to return `true' (ie, we do return to
30653 our caller) only if both branches of the if return.
30655 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30656 short-circuit operators, handle them as short circuit operators.
30658 (Cast.DoResolve): Resolve type.
30659 (Cast.Cast): Take an expression as the target type.
30661 * cs-parser.jay (cast_expression): Remove old hack that only
30662 allowed a limited set of types to be handled. Now we take a
30663 unary_expression and we resolve to a type during semantic
30666 Use the grammar productions from Rhys to handle casts (this is
30667 not complete like Rhys syntax yet, we fail to handle that corner
30668 case that C# has regarding (-x), but we will get there.
30670 2001-11-22 Ravi Pratap <ravi@ximian.com>
30672 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30673 field which is an array type.
30675 * cs-parser.jay (declare_local_variables): Support array initialization too.
30677 * typemanager.cs (MakeKey): Implement.
30679 (everywhere): Use the above appropriately.
30681 * cs-parser.jay (for_statement): Update for array initialization while
30682 declaring variables.
30684 * ecore.cs : The error message was correct, it's the variable's names that
30685 were misleading ;-) Make the code more readable.
30687 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30688 the correct type etc.
30690 (ConvertExplicit): Handle Enum types by examining the underlying type.
30692 2001-11-21 Ravi Pratap <ravi@ximian.com>
30694 * parameter.cs (GetCallingConvention): Always return
30695 CallingConventions.Standard for now.
30697 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30699 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30700 and `r' after calling DoNumericPromotions.
30702 * ecore.cs: Fix error message (the types were in the wrong order).
30704 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30705 BindingFlags.Instance as well
30707 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30708 implicit int literal conversion in an empty cast so that we
30709 propagate the right type upstream.
30711 (UnboxCast): new class used to unbox value types.
30712 (Expression.ConvertExplicit): Add explicit type conversions done
30715 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30716 the target type before applying the implicit LongLiterals to ULong
30719 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30721 * cs-parser.jay (for_statement): Reworked the way For works: now
30722 we declare manually any variables that are introduced in
30723 for_initializer to solve the problem of having out-of-band code
30724 emition (that is what got for broken).
30726 (declaration_statement): Perform the actual variable declaration
30727 that used to be done in local_variable_declaration here.
30729 (local_variable_declaration): Do not declare anything, just pass
30730 the information on a DictionaryEntry
30732 2001-11-20 Ravi Pratap <ravi@ximian.com>
30734 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30735 re-write of the logic to now make it recursive.
30737 (UpdateIndices): Re-write accordingly.
30739 Store element data in a separate ArrayData list in the above methods.
30741 (MakeByteBlob): Implement to dump the array data into a byte array.
30743 2001-11-19 Ravi Pratap <ravi@ximian.com>
30745 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30748 * constant.cs (Define): Implement.
30750 (EmitConstant): Re-write fully.
30752 Pass in location info.
30754 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30757 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30758 DictionaryEntry since we need location info too.
30760 (constant_declaration): Update accordingly.
30762 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30763 code into another method : UpdateIndices.
30765 2001-11-18 Ravi Pratap <ravi@ximian.com>
30767 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30768 some type checking etc.
30770 2001-11-17 Ravi Pratap <ravi@ximian.com>
30772 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30773 bits to provide dimension info if the user skips doing that.
30775 Update second constructor to store the rank correctly.
30777 2001-11-16 Ravi Pratap <ravi@ximian.com>
30779 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30780 and try to implement.
30782 * ../errors/cs0150.cs : Add.
30784 * ../errors/cs0178.cs : Add.
30786 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30788 * statement.cs: Implement foreach on multi-dimensional arrays.
30790 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30791 name of the params argument.
30793 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30794 initializing the array.
30796 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30797 we can use this elsewhere.
30799 * statement.cs: Finish implementation of foreach for single
30802 * cs-parser.jay: Use an out-of-band stack to pass information
30803 around, I wonder why I need this.
30805 foreach_block: Make the new foreach_block the current_block.
30807 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30808 function used to return a static Parameters structure. Used for
30809 empty parameters, as those are created very frequently.
30811 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30813 2001-11-15 Ravi Pratap <ravi@ximian.com>
30815 * interface.cs : Default modifier is private, not public. The
30816 make verify test passes again.
30818 2001-11-15 Ravi Pratap <ravi@ximian.com>
30820 * support.cs (ReflectionParameters): Fix logic to determine
30821 whether the last parameter is a params one. Test 9 passes again.
30823 * delegate.cs (Populate): Register the builders we define with
30824 RegisterParameterForBuilder. Test 19 passes again.
30826 * cs-parser.jay (property_declaration): Reference $6 instead
30827 of $$ to get at the location.
30829 (indexer_declaration): Similar stuff.
30831 (attribute): Ditto.
30833 * class.cs (Property): Register parameters for the Get and Set methods
30834 if they exist. Test 23 passes again.
30836 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30837 call to EmitArguments as we are sure there aren't any params arguments.
30838 Test 32 passes again.
30840 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30841 IndexOutOfRangeException.
30843 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30844 Test 33 now passes again.
30846 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30848 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30849 broke a bunch of things. Will have to come up with a better way
30850 of tracking locations.
30852 * statement.cs: Implemented foreach for single dimension arrays.
30854 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30856 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30857 an error. This removes the lookup from the critical path.
30859 * cs-parser.jay: Removed use of temporary_loc, which is completely
30862 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30864 * support.cs (ReflectionParameters.ParameterModifier): Report
30865 whether the argument is a PARAMS argument or not.
30867 * class.cs: Set the attribute `ParamArrayAttribute' on the
30868 parameter argument.
30870 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30871 and cons_param_array_attribute (ConstructorInfo for
30872 ParamArrayAttribute).,
30874 * codegen.cs: Emit the return using the `Return' statement, that
30875 way we can report the error correctly for missing return values.
30877 * class.cs (Method.Emit): Clean up.
30879 * expression.cs (Argument.Resolve): Take another argument: the
30880 location where this argument is used. Notice that this is not
30881 part of the "Argument" class as to reduce the size of the
30882 structure (we know the approximate location anyways).
30884 Test if the argument is a variable-reference, if not, then
30885 complain with a 206.
30887 (Argument.Emit): Emit addresses of variables.
30889 (Argument.FullDesc): Simplify.
30891 (Invocation.DoResolve): Update for Argument.Resolve.
30893 (ElementAccess.DoResolve): ditto.
30895 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30896 method should be virtual, as this method is always virtual.
30898 (NewDelegate.DoResolve): Update for Argument.Resolve.
30900 * class.cs (ConstructorInitializer.DoResolve): ditto.
30902 * attribute.cs (Attribute.Resolve): ditto.
30904 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30906 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30908 * expression.cs (ParameterReference): Drop IStackStorage and implement
30909 IAssignMethod instead.
30911 (LocalVariableReference): ditto.
30913 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30914 IAssignMethod instead.
30916 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30918 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30919 enumerations that are used in heavily used structures derive from
30920 byte in a laughable and pathetic attempt to reduce memory usage.
30921 This is the kind of pre-optimzations that you should not do at
30922 home without adult supervision.
30924 * expression.cs (UnaryMutator): New class, used to handle ++ and
30925 -- separatedly from the other unary operators. Cleans up the
30926 code, and kills the ExpressionStatement dependency in Unary.
30928 (Unary): Removed `method' and `Arguments' from this class, making
30929 it smaller, and moving it all to SimpleCall, so I can reuse this
30930 code in other locations and avoid creating a lot of transient data
30931 strucutres when not required.
30933 * cs-parser.jay: Adjust for new changes.
30935 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30937 * enum.cs (Enum.Populate): If there is a failure during
30940 * cs-parser.jay (opt_enum_base): we used to catch type errors
30941 here, but this is really incorrect. The type error should be
30942 catched during semantic analysis.
30944 2001-12-11 Ravi Pratap <ravi@ximian.com>
30946 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30947 current_local_parameters as expected since I, in my stupidity, had forgotten
30950 * attribute.cs (GetValidPlaces): Fix stupid bug.
30952 * class.cs (Method::Emit): Perform check on applicability of attributes.
30954 (Constructor::Emit): Ditto.
30956 (Field::Emit): Ditto.
30958 (Field.Location): Store location information.
30960 (Property, Event, Indexer, Operator): Ditto.
30962 * cs-parser.jay (field_declaration): Pass in location for each field.
30964 * ../errors/cs0592.cs : Add.
30966 2001-11-12 Ravi Pratap <ravi@ximian.com>
30968 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30970 (InitCoreTypes): Update accordingly.
30972 (RegisterAttrType, LookupAttr): Implement.
30974 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30975 info about the same.
30977 (Resolve): Update to populate the above as necessary.
30979 (Error592): Helper.
30981 (GetValidPlaces): Helper to the above.
30983 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30985 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30987 2001-11-12 Ravi Pratap <ravi@ximian.com>
30989 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30991 * ../errors/cs0617.cs : Add.
30993 2001-11-11 Ravi Pratap <ravi@ximian.com>
30995 * enum.cs (Emit): Rename to Populate to be more consistent with what
30996 we expect it to do and when exactly it is called.
30998 * class.cs, rootcontext.cs : Update accordingly.
31000 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
31001 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
31003 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
31005 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
31006 of a fieldinfo using the above, when dealing with a FieldBuilder.
31008 2001-11-10 Ravi Pratap <ravi@ximian.com>
31010 * ../errors/cs0031.cs : Add.
31012 * ../errors/cs1008.cs : Add.
31014 * ../errrors/cs0543.cs : Add.
31016 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
31019 (FindMembers): Implement.
31021 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
31022 enums and delegates too.
31024 (enum_types): Rename to builder_to_enum.
31026 (delegate_types): Rename to builder_to_delegate.
31028 * delegate.cs (FindMembers): Implement.
31030 2001-11-09 Ravi Pratap <ravi@ximian.com>
31032 * typemanager.cs (IsEnumType): Implement.
31034 * enum.cs (Emit): Re-write parts to account for the underlying type
31035 better and perform checking etc.
31037 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
31038 of the underlying type.
31040 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
31043 * enum.cs (error31): Helper to report error #31.
31045 * cs-parser.jay (enum_declaration): Store location of each member too.
31047 * enum.cs (member_to_location): New hashtable.
31049 (AddEnumMember): Update location hashtable.
31051 (Emit): Use the location of each member while reporting errors.
31053 2001-11-09 Miguel de Icaza <miguel@ximian.com>
31055 * cs-parser.jay: A for_initializer if is a
31056 local_variable_declaration really ammount to have an implicit
31057 block with the variable declaration and no initializer for for.
31059 * statement.cs (For.Emit): Cope with null initializers.
31061 This fixes the infinite loop on for initializers.
31063 2001-11-08 Miguel de Icaza <miguel@ximian.com>
31065 * enum.cs: More cleanup.
31067 * ecore.cs: Remove dead code.
31069 * class.cs (Property.Emit): More simplification.
31070 (Event.Emit): ditto.
31072 Reworked to have less levels of indentation.
31074 2001-11-08 Ravi Pratap <ravi@ximian.com>
31076 * class.cs (Property): Emit attributes.
31086 * enum.cs (Emit): Ditto.
31088 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
31091 * class.cs (Field, Event, etc.): Move attribute generation into the
31092 Emit method everywhere.
31094 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
31095 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
31096 as we had no way of defining nested enums !
31098 * rootcontext.cs : Adjust code accordingly.
31100 * typemanager.cs (AddEnumType): To keep track of enum types separately.
31102 2001-11-07 Ravi Pratap <ravi@ximian.com>
31104 * expression.cs (EvalConstantExpression): Move into ecore.cs
31106 * enum.cs (Enum): Rename some members and make them public and readonly
31107 according to our convention.
31109 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
31112 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
31114 (Enum::Emit): Write a simple version for now which doesn't try to compute
31115 expressions. I shall modify this to be more robust in just a while.
31117 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
31119 (TypeContainer::CloseType): Create the Enum types too.
31121 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
31123 * expression.cs (EvalConstantExpression): Get rid of completely.
31125 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
31126 user-defined values and other cases.
31128 (IsValidEnumLiteral): Helper function.
31130 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
31131 out there in the case we had a literal FieldExpr.
31133 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
31135 (Literalize): Revamp a bit to take two arguments.
31137 (EnumLiteral): New class which derives from Literal to wrap enum literals.
31139 2001-11-06 Ravi Pratap <ravi@ximian.com>
31141 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
31143 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
31145 (Resolve): Use the above to ensure we have proper initializers.
31147 2001-11-05 Ravi Pratap <ravi@ximian.com>
31149 * expression.cs (Expression::EvalConstantExpression): New method to
31150 evaluate constant expressions.
31152 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
31154 2001-11-07 Miguel de Icaza <miguel@ximian.com>
31156 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
31159 (Binary.ResolveOperator): Handle operator != (object a, object b)
31160 and operator == (object a, object b);
31162 (Binary.DoNumericPromotions): Indicate whether the numeric
31163 promotion was possible.
31165 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
31168 Made the ArrayAccess implement interface IAssignMethod instead of
31169 IStackStore as the order in which arguments are passed reflects
31172 * assign.cs: Instead of using expr.ExprClass to select the way of
31173 assinging, probe for the IStackStore/IAssignMethod interfaces.
31175 * typemanager.cs: Load InitializeArray definition.
31177 * rootcontext.cs (RootContext.MakeStaticData): Used to define
31178 static data that can be used to initialize arrays.
31180 2001-11-05 Miguel de Icaza <miguel@ximian.com>
31182 * expression.cs: Handle operator== and operator!= for booleans.
31184 (Conditioal.Reduce): Implement reducer for the ?: operator.
31186 (Conditional.Resolve): Implement dead code elimination.
31188 (Binary.Resolve): Catch string literals and return a new
31189 concatenated string.
31191 (Unary.Reduce): Implement reduction of unary expressions.
31193 * ecore.cs: Split out the expression core handling here.
31195 (Expression.Reduce): New method used to perform constant folding
31196 and CSE. This is needed to support constant-expressions.
31198 * statement.cs (Statement.EmitBoolExpression): Pass true and false
31199 targets, and optimize for !x.
31201 2001-11-04 Ravi Pratap <ravi@ximian.com>
31203 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
31204 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
31205 set custom atttributes.
31207 * literal.cs (Literal::GetValue): New abstract method to return the actual
31208 value of the literal, cast as an object.
31210 (*Literal): Implement GetValue method.
31212 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
31213 expressions to the arraylist but objects of type Argument.
31215 * class.cs (TypeContainer::Emit): Emit our attributes too.
31217 (Method::Emit, Constructor::Emit): Ditto.
31219 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
31220 to be ignoring earlier.
31222 2001-11-03 Ravi Pratap <ravi@ximian.com>
31224 * attribute.cs (AttributeSection::Define): Implement to do the business
31225 of constructing a CustomAttributeBuilder.
31227 (Attribute): New trivial class. Increases readability of code.
31229 * cs-parser.jay : Update accordingly.
31231 (positional_argument_list, named_argument_list, named_argument): New rules
31233 (attribute_arguments): Use the above so that we are more correct.
31235 2001-11-02 Ravi Pratap <ravi@ximian.com>
31237 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
31238 to perform all checks for a method with a params parameter.
31240 (Invocation::OverloadResolve): Update to use the above method and therefore
31241 cope correctly with params method invocations.
31243 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
31246 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
31247 constructors in our parent too because we can't afford to miss out on
31250 * attribute.cs (AttributeSection): New name for the class Attribute
31252 Other trivial changes to improve readability.
31254 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
31255 use the new class names.
31257 2001-11-01 Ravi Pratap <ravi@ximian.com>
31259 * class.cs (Method::Define): Complete definition for params types too
31261 (Indexer::Define): Ditto.
31263 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
31264 Cope everywhere with a request for info about the array parameter.
31266 2001-11-01 Ravi Pratap <ravi@ximian.com>
31268 * tree.cs (RecordNamespace): Fix up to check for the correct key.
31270 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
31271 local_variable_type to extract the string corresponding to the type.
31273 (local_variable_type): Fixup the action to use the new helper method.
31275 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
31278 * expression.cs : Clean out code which uses the above.
31280 2001-10-31 Ravi Pratap <ravi@ximian.com>
31282 * typemanager.cs (RegisterMethod): Check if we already have an existing key
31283 and bale out if necessary by returning a false.
31285 (RegisterProperty): Ditto.
31287 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
31288 and print out appropriate error messages.
31290 * interface.cs (everywhere): Ditto.
31292 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
31293 location to constructor.
31295 * class.cs (Property, Event, Indexer): Update accordingly.
31297 * ../errors/cs111.cs : Added.
31299 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
31300 of a method, as laid down by the spec.
31302 (Invocation::OverloadResolve): Use the above method.
31304 2001-10-31 Ravi Pratap <ravi@ximian.com>
31306 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
31307 now take a TypeContainer and a Parameters object.
31309 (ParameterData): Modify return type of ParameterModifier method to be
31310 Parameter.Modifier and not a string.
31312 (ReflectionParameters, InternalParameters): Update accordingly.
31314 * expression.cs (Argument::GetParameterModifier): Same here.
31316 * support.cs (InternalParameters::ParameterType): Find a better way of determining
31317 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
31318 symbol in it at all so maybe this is only for now.
31320 2001-10-30 Ravi Pratap <ravi@ximian.com>
31322 * support.cs (InternalParameters): Constructor now takes an extra argument
31323 which is the actual Parameters class.
31325 (ParameterDesc): Update to provide info on ref/out modifiers.
31327 * class.cs (everywhere): Update call to InternalParameters to pass in
31328 the second argument too.
31330 * support.cs (ParameterData): Add ParameterModifier, which is a method
31331 to return the modifier info [ref/out etc]
31333 (InternalParameters, ReflectionParameters): Implement the above.
31335 * expression.cs (Argument::ParameterModifier): Similar function to return
31336 info about the argument's modifiers.
31338 (Invocation::OverloadResolve): Update to take into account matching modifiers
31341 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
31342 a new SetFormalParameters object which we pass to InternalParameters.
31344 2001-10-30 Ravi Pratap <ravi@ximian.com>
31346 * expression.cs (NewArray): Merge into the ArrayCreation class.
31348 2001-10-29 Ravi Pratap <ravi@ximian.com>
31350 * expression.cs (NewArray): Merge classes NewBuiltinArray and
31351 NewUserdefinedArray into one as there wasn't much of a use in having
31354 * expression.cs (Argument): Change field's name to ArgType from Type.
31356 (Type): New readonly property which returns the proper type, taking into
31357 account ref/out modifiers.
31359 (everywhere): Adjust code accordingly for the above.
31361 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
31362 whether we are emitting for a ref or out parameter.
31364 * expression.cs (Argument::Emit): Use the above field to set the state.
31366 (LocalVariableReference::Emit): Update to honour the flag and emit the
31369 * parameter.cs (Attributes): Set the correct flags for ref parameters.
31371 * expression.cs (Argument::FullDesc): New function to provide a full desc.
31373 * support.cs (ParameterData): Add method ParameterDesc to the interface.
31375 (ReflectionParameters, InternalParameters): Implement the above method.
31377 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
31380 (Invocation::FullMethodDesc): Ditto.
31382 2001-10-29 Miguel de Icaza <miguel@ximian.com>
31384 * cs-parser.jay: Add extra production for the second form of array
31387 * expression.cs (ArrayCreation): Update to reflect the above
31390 * Small changes to prepare for Array initialization.
31392 2001-10-28 Miguel de Icaza <miguel@ximian.com>
31394 * typemanager.cs (ImplementsInterface): interface might be null;
31395 Deal with this problem;
31397 Also, we do store negative hits on the cache (null values), so use
31398 this instead of calling t.GetInterfaces on the type everytime.
31400 2001-10-28 Ravi Pratap <ravi@ximian.com>
31402 * typemanager.cs (IsBuiltinType): New method to help determine the same.
31404 * expression.cs (New::DoResolve): Get rid of array creation code and instead
31405 split functionality out into different classes.
31407 (New::FormArrayType): Move into NewBuiltinArray.
31409 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
31412 (NewBuiltinArray): New class to handle creation of built-in arrays.
31414 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
31415 account creation of one-dimensional arrays.
31417 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
31419 (NewUserdefinedArray::DoResolve): Implement.
31421 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
31423 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
31424 we maintain inside the TypeManager. This is necessary to perform lookups on the
31427 (LookupType): Update to perform GetType on the module builders too.
31429 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
31431 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
31433 2001-10-23 Ravi Pratap <ravi@ximian.com>
31435 * expression.cs (New::DoResolve): Implement guts of array creation.
31437 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
31439 2001-10-27 Miguel de Icaza <miguel@ximian.com>
31441 * expression.cs: Fix bug I introduced lsat night that broke
31444 (Expression.Resolve): Report a 246 error (can not resolve name)
31445 if we find a SimpleName in the stream.
31447 (Expression.ResolveLValue): Ditto.
31449 (Expression.ResolveWithSimpleName): This function is a variant of
31450 ResolveName, this one allows SimpleNames to be returned without a
31451 warning. The only consumer of SimpleNames is MemberAccess
31453 2001-10-26 Miguel de Icaza <miguel@ximian.com>
31455 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
31456 might arrive here. I have my doubts that this is correct.
31458 * statement.cs (Lock): Implement lock statement.
31460 * cs-parser.jay: Small fixes to support `lock' and `using'
31462 * cs-tokenizer.cs: Remove extra space
31464 * driver.cs: New flag --checked, allows to turn on integer math
31467 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
31468 Threading.Monitor.Exit
31470 2001-10-23 Miguel de Icaza <miguel@ximian.com>
31472 * expression.cs (IndexerAccess::DoResolveLValue): Set the
31473 Expression Class to be IndexerAccess.
31475 Notice that Indexer::DoResolve sets the eclass to Value.
31477 2001-10-22 Miguel de Icaza <miguel@ximian.com>
31479 * class.cs (TypeContainer::Emit): Emit code for indexers.
31481 * assign.cs (IAssignMethod): New interface implemented by Indexers
31482 and Properties for handling assignment.
31484 (Assign::Emit): Simplify and reuse code.
31486 * expression.cs (IndexerAccess, PropertyExpr): Implement
31487 IAssignMethod, clean up old code.
31489 2001-10-22 Ravi Pratap <ravi@ximian.com>
31491 * typemanager.cs (ImplementsInterface): New method to determine if a type
31492 implements a given interface. Provides a nice cache too.
31494 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
31497 (ConvertReferenceExplicit): Ditto.
31499 * delegate.cs (Delegate::Populate): Update to define the parameters on the
31500 various methods, with correct names etc.
31502 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
31503 Operator.UnaryNegation.
31505 * cs-parser.jay (operator_declarator): Be a little clever in the case where
31506 we have a unary plus or minus operator.
31508 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
31511 * everywhere : update accordingly.
31513 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
31516 * class.cs (Method::Define): For the case where we are implementing a method
31517 inherited from an interface, we need to set the MethodAttributes.Final flag too.
31518 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
31520 2001-10-21 Ravi Pratap <ravi@ximian.com>
31522 * interface.cs (FindMembers): Implement to work around S.R.E
31525 * typemanager.cs (IsInterfaceType): Implement.
31527 (FindMembers): Update to handle interface types too.
31529 * expression.cs (ImplicitReferenceConversion): Re-write bits which
31530 use IsAssignableFrom as that is not correct - it doesn't work.
31532 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
31533 and accordingly override EmitStatement.
31535 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
31536 using the correct logic :-)
31538 2001-10-19 Ravi Pratap <ravi@ximian.com>
31540 * ../errors/cs-11.cs : Add to demonstrate error -11
31542 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31544 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31545 then pass this as a hint to ResolveLValue.
31547 * expression.cs (FieldExpr): Add Location information
31549 (FieldExpr::LValueResolve): Report assignment to readonly
31552 (Expression::ExprClassFromMemberInfo): Pass location information.
31554 (Expression::ResolveLValue): Add new method that resolves an
31557 (Expression::DoResolveLValue): Default invocation calls
31560 (Indexers): New class used to keep track of indexers in a given
31563 (IStackStore): Renamed from LValue, as it did not really describe
31564 what this did. Also ResolveLValue is gone from this interface and
31565 now is part of Expression.
31567 (ElementAccess): Depending on the element access type
31569 * typemanager.cs: Add `indexer_name_type' as a Core type
31570 (System.Runtime.CompilerServices.IndexerNameAttribute)
31572 * statement.cs (Goto): Take a location.
31574 2001-10-18 Ravi Pratap <ravi@ximian.com>
31576 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31577 if two delegates are compatible.
31579 (NewDelegate::DoResolve): Update to take care of the case when
31580 we instantiate a delegate from another delegate.
31582 * typemanager.cs (FindMembers): Don't even try to look up members
31583 of Delegate types for now.
31585 2001-10-18 Ravi Pratap <ravi@ximian.com>
31587 * delegate.cs (NewDelegate): New class to take care of delegate
31590 * expression.cs (New): Split the delegate related code out into
31591 the NewDelegate class.
31593 * delegate.cs (DelegateInvocation): New class to handle delegate
31596 * expression.cs (Invocation): Split out delegate related code into
31597 the DelegateInvocation class.
31599 2001-10-17 Ravi Pratap <ravi@ximian.com>
31601 * expression.cs (New::DoResolve): Implement delegate creation fully
31602 and according to the spec.
31604 (New::DoEmit): Update to handle delegates differently.
31606 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31607 because of which we were printing out arguments in reverse order !
31609 * delegate.cs (VerifyMethod): Implement to check if the given method
31610 matches the delegate.
31612 (FullDelegateDesc): Implement.
31614 (VerifyApplicability): Implement.
31616 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31617 delegate invocations too.
31619 (Invocation::Emit): Ditto.
31621 * ../errors/cs1593.cs : Added.
31623 * ../errors/cs1594.cs : Added.
31625 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31627 2001-10-16 Ravi Pratap <ravi@ximian.com>
31629 * typemanager.cs (intptr_type): Core type for System.IntPtr
31631 (InitCoreTypes): Update for the same.
31633 (iasyncresult_type, asynccallback_type): Ditto.
31635 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31638 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31641 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31642 the builders for the 4 members of a delegate type :-)
31644 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31647 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31649 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31651 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31653 * statement.cs (Break::Emit): Implement.
31654 (Continue::Emit): Implement.
31656 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31657 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31658 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31659 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31662 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31663 properties that track the label for the current loop (begin of the
31664 loop and end of the loop).
31666 2001-10-15 Ravi Pratap <ravi@ximian.com>
31668 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31669 use of emitting anything at all.
31671 * class.cs, rootcontext.cs : Get rid of calls to the same.
31673 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31675 (Populate): Define the constructor correctly and set the implementation
31678 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31681 (AddDelegateType): Implement.
31683 (IsDelegateType): Implement helper method.
31685 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31687 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31688 and accordingly handle it.
31690 * delegate.cs (Populate): Take TypeContainer argument.
31691 Implement bits to define the Invoke method. However, I still haven't figured out
31692 how to take care of the native int bit :-(
31694 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31695 Qualify the name of the delegate, not its return type !
31697 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31700 (StandardConversionExists): Checking for array types turns out to be recursive.
31702 (ConvertReferenceExplicit): Implement array conversion.
31704 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31706 2001-10-12 Ravi Pratap <ravi@ximian.com>
31708 * cs-parser.jay (delegate_declaration): Store the fully qualified
31709 name as it is a type declaration.
31711 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31714 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31715 as TypeContainer::DefineType.
31717 (Populate): Method in which all the definition of the various methods (Invoke)
31720 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31723 (CloseDelegate): Finally creates the delegate.
31725 * class.cs (TypeContainer::DefineType): Update to define delegates.
31726 (Populate, Emit and CloseType): Do the same thing here too.
31728 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31729 delegates in all these operations.
31731 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31733 * expression.cs: LocalTemporary: a new expression used to
31734 reference a temporary that has been created.
31736 * assign.cs: Handle PropertyAccess back here, so that we can
31737 provide the proper semantic access to properties.
31739 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31740 a few more explicit conversions.
31742 * modifiers.cs: `NEW' modifier maps to HideBySig.
31744 * expression.cs (PropertyExpr): Make this into an
31745 ExpressionStatement, and support the EmitStatement code path.
31747 Perform get/set error checking, clean up the interface.
31749 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31750 them into toplevel access objects.
31752 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31754 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31757 * typemanager.cs: Keep track here of our PropertyBuilders again to
31758 work around lameness in SRE.
31760 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31762 * expression.cs (LValue::LValueResolve): New method in the
31763 interface, used to perform a second resolution pass for LValues.
31765 (This::DoResolve): Catch the use of this in static methods.
31767 (This::LValueResolve): Implement.
31769 (This::Store): Remove warning, assigning to `this' in structures
31772 (Invocation::Emit): Deal with invocation of
31773 methods on value types. We need to pass the address to structure
31774 methods rather than the object itself. (The equivalent code to
31775 emit "this" for structures leaves the entire structure on the
31776 stack instead of a pointer to it).
31778 (ParameterReference::DoResolve): Compute the real index for the
31779 argument based on whether the method takes or not a `this' pointer
31780 (ie, the method is static).
31782 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31783 value types returned from functions when we need to invoke a
31784 method on the sturcture.
31787 2001-10-11 Ravi Pratap <ravi@ximian.com>
31789 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31790 defining the type in the Modulebuilder or Typebuilder. This is to take
31791 care of nested types which need to be defined on the TypeBuilder using
31792 DefineNestedMethod.
31794 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31795 methods in RootContext, only ported to be part of TypeContainer.
31797 (TypeContainer::GetInterfaceOrClass): Ditto.
31799 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31801 * interface.cs (Interface::DefineInterface): New method. Does exactly
31802 what RootContext.CreateInterface did earlier, only it takes care of nested types
31805 (Interface::GetInterfaces): Move from RootContext here and port.
31807 (Interface::GetInterfaceByName): Same here.
31809 * rootcontext.cs (ResolveTree): Re-write.
31811 (PopulateTypes): Re-write.
31813 * class.cs (TypeContainer::Populate): Populate nested types too.
31814 (TypeContainer::Emit): Emit nested members too.
31816 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31817 instead just use the name argument passed in as it is already fully
31820 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31821 to TypeContainer mapping to see if a type is user-defined.
31823 * class.cs (TypeContainer::CloseType): Implement.
31825 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31826 the default constructor.
31828 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31831 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31833 * interface.cs (CloseType): Create the type here.
31835 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31838 Remove all the methods which are now in TypeContainer.
31840 2001-10-10 Ravi Pratap <ravi@ximian.com>
31842 * delegate.cs (Define): Re-write bits to define the delegate
31845 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31847 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31849 * expression.cs (ImplicitReferenceConversion): handle null as well
31850 as a source to convert to any reference type.
31852 * statement.cs (Return): Perform any implicit conversions to
31853 expected return type.
31855 Validate use of return statement.
31857 * codegen.cs (EmitContext): Pass the expected return type here.
31859 * class.cs (Method, Constructor, Property): Pass expected return
31860 type to EmitContext.
31862 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31864 * expression.cs: Make DoResolve take an EmitContext instead of a
31867 Replaced `l' and `location' for `loc', for consistency.
31869 (Error, Warning): Remove unneeded Tc argument.
31871 * assign.cs, literal.cs, constant.cs: Update to new calling
31874 * codegen.cs: EmitContext now contains a flag indicating whether
31875 code is being generated in a static method or not.
31877 * cs-parser.jay: DecomposeQI, new function that replaces the old
31878 QualifiedIdentifier. Now we always decompose the assembled
31879 strings from qualified_identifier productions into a group of
31882 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31884 * rootcontext.cs: Deal with field-less struct types correctly now
31885 by passing the size option to Define Type.
31887 * class.cs: Removed hack that created one static field.
31889 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31891 * statement.cs: Moved most of the code generation here.
31893 2001-10-09 Ravi Pratap <ravi@ximian.com>
31895 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31898 (ElementAccess): Remove useless bits for now - keep checks as the spec
31901 2001-10-08 Ravi Pratap <ravi@ximian.com>
31903 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31904 and start performing checks according to the spec.
31906 2001-10-07 Ravi Pratap <ravi@ximian.com>
31908 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31909 rank_specifiers instead.
31911 (rank_specifiers): Change the order in which the rank specifiers are stored
31913 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31915 * expression.cs (ElementAccess): Implement the LValue interface too.
31917 2001-10-06 Ravi Pratap <ravi@ximian.com>
31919 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31920 except that user defined conversions are not included.
31922 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31923 perform the conversion of the return type, if necessary.
31925 (New::DoResolve): Check whether we are creating an array or an object
31926 and accordingly do the needful.
31928 (New::Emit): Same here.
31930 (New::DoResolve): Implement guts of array creation.
31932 (New::FormLookupType): Helper function.
31934 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31936 * codegen.cs: Removed most of the code generation here, and move the
31937 corresponding code generation bits to the statement classes.
31939 Added support for try/catch/finalize and throw.
31941 * cs-parser.jay: Added support for try/catch/finalize.
31943 * class.cs: Catch static methods having the flags override,
31944 virtual or abstract.
31946 * expression.cs (UserCast): This user cast was not really doing
31947 what it was supposed to do. Which is to be born in fully resolved
31948 state. Parts of the resolution were being performed at Emit time!
31952 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31954 * expression.cs: Implicity convert the result from UserCast.
31956 2001-10-05 Ravi Pratap <ravi@ximian.com>
31958 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31959 prevented it from working correctly.
31961 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31962 merely ConvertImplicit.
31964 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31966 * typemanager.cs: Make the LookupTypeContainer function static,
31967 and not per-instance.
31969 * class.cs: Make static FindMembers (the one that takes a Type
31972 * codegen.cs: Add EmitForeach here.
31974 * cs-parser.jay: Make foreach a toplevel object instead of the
31975 inline expansion, as we need to perform semantic analysis on it.
31977 2001-10-05 Ravi Pratap <ravi@ximian.com>
31979 * expression.cs (Expression::ImplicitUserConversion): Rename to
31980 UserDefinedConversion.
31982 (Expression::UserDefinedConversion): Take an extra argument specifying
31983 whether we look for explicit user conversions too.
31985 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31987 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31989 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31990 with the appropriate arguments.
31992 * cs-parser.jay (cast_expression): Record location too.
31994 * expression.cs (Cast): Record location info.
31996 (Expression::ConvertExplicit): Take location argument.
31998 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31999 to determine if we are doing explicit conversions.
32001 (UserCast::Emit): Update accordingly.
32003 (Expression::ConvertExplicit): Report an error if everything fails.
32005 * ../errors/cs0030.cs : Add.
32007 2001-10-04 Miguel de Icaza <miguel@ximian.com>
32009 * modifiers.cs: If the ABSTRACT keyword is present, also set the
32010 virtual and newslot bits.
32012 * class.cs (TypeContainer::RegisterRequiredImplementations):
32013 Record methods we need.
32015 (TypeContainer::MakeKey): Helper function to make keys for
32016 MethodBases, since the Methodbase key is useless.
32018 (TypeContainer::Populate): Call RegisterRequiredImplementations
32019 before defining the methods.
32021 Create a mapping for method_builders_to_methods ahead of time
32022 instead of inside a tight loop.
32024 (::RequireMethods): Accept an object as the data to set into the
32025 hashtable so we can report interface vs abstract method mismatch.
32027 2001-10-03 Miguel de Icaza <miguel@ximian.com>
32029 * report.cs: Make all of it static.
32031 * rootcontext.cs: Drop object_type and value_type computations, as
32032 we have those in the TypeManager anyways.
32034 Drop report instance variable too, now it is a global.
32036 * driver.cs: Use try/catch on command line handling.
32038 Add --probe option to debug the error reporting system with a test
32041 * report.cs: Add support for exiting program when a probe
32042 condition is reached.
32044 2001-10-03 Ravi Pratap <ravi@ximian.com>
32046 * expression.cs (Binary::DoNumericPromotions): Fix the case when
32047 we do a forcible conversion regardless of type, to check if
32048 ForceConversion returns a null.
32050 (Binary::error19): Use location to report error.
32052 (Unary::error23): Use location here too.
32054 * ../errors/cs0019.cs : Check in.
32056 * ../errors/cs0023.cs : Check in.
32058 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
32059 case of a non-null MethodInfo object with a length of 0 !
32061 (Binary::ResolveOperator): Flag error if overload resolution fails to find
32062 an applicable member - according to the spec :-)
32063 Also fix logic to find members in base types.
32065 (Unary::ResolveOperator): Same here.
32067 (Unary::report23): Change name to error23 and make first argument a TypeContainer
32068 as I was getting thoroughly confused between this and error19 :-)
32070 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
32071 (::FindMostEncompassedType): Implement.
32072 (::FindMostEncompassingType): Implement.
32073 (::StandardConversionExists): Implement.
32075 (UserImplicitCast): Re-vamp. We now need info about most specific
32076 source and target types so that we can do the necessary conversions.
32078 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
32079 mathematical union with no duplicates.
32081 2001-10-03 Miguel de Icaza <miguel@ximian.com>
32083 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
32084 in order from base classes to child classes, so that we can in
32085 child classes look up in our parent for method names and
32086 attributes (required for handling abstract, virtual, new, override
32087 constructs: we need to instrospect our base class, and if we dont
32088 populate the classes in order, the introspection might be
32089 incorrect. For example, a method could query its parent before
32090 the parent has any methods and would determine that the parent has
32091 no abstract methods (while it could have had them)).
32093 (RootContext::CreateType): Record the order in which we define the
32096 2001-10-02 Miguel de Icaza <miguel@ximian.com>
32098 * class.cs (TypeContainer::Populate): Also method definitions can
32099 fail now, keep track of this.
32101 (TypeContainer::FindMembers): Implement support for
32102 DeclaredOnly/noDeclaredOnly flag.
32104 (Constructor::Emit) Return the ConstructorBuilder.
32106 (Method::Emit) Return the MethodBuilder.
32107 Check for abstract or virtual methods to be public.
32109 * rootcontext.cs (RootContext::CreateType): Register all the
32110 abstract methods required for the class to be complete and the
32111 interface methods that must be implemented.
32113 * cs-parser.jay: Report error 501 (method requires body if it is
32114 not marked abstract or extern).
32116 * expression.cs (TypeOf::Emit): Implement.
32118 * typemanager.cs: runtime_handle_type, new global type.
32120 * class.cs (Property::Emit): Generate code for properties.
32122 2001-10-02 Ravi Pratap <ravi@ximian.com>
32124 * expression.cs (Unary::ResolveOperator): Find operators on base type
32125 too - we now conform exactly to the spec.
32127 (Binary::ResolveOperator): Same here.
32129 * class.cs (Operator::Define): Fix minor quirk in the tests.
32131 * ../errors/cs0215.cs : Added.
32133 * ../errors/cs0556.cs : Added.
32135 * ../errors/cs0555.cs : Added.
32137 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32139 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
32140 single integer which is really efficient
32142 2001-10-01 Ravi Pratap <ravi@ximian.com>
32144 * expression.cs (Expression::ImplicitUserConversion): Use location
32145 even in the case when we are examining True operators.
32147 * class.cs (Operator::Define): Perform extensive checks to conform
32148 with the rules for operator overloading in the spec.
32150 * expression.cs (Expression::ImplicitReferenceConversion): Implement
32151 some of the other conversions mentioned in the spec.
32153 * typemanager.cs (array_type): New static member for the System.Array built-in
32156 (cloneable_interface): For System.ICloneable interface.
32158 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
32159 we start resolving the tree and populating types.
32161 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
32163 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32165 * expression.cs (Expression::ExprClassFromMemberInfo,
32166 Expression::Literalize): Create literal expressions from
32167 FieldInfos which are literals.
32169 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
32170 type casts, because they were wrong. The test suite in tests
32173 (ImplicitNumericConversion): ushort to ulong requires a widening
32176 Int32 constant to long requires widening cast as well.
32178 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
32179 for integers because the type on the stack is not i4.
32181 2001-09-30 Miguel de Icaza <miguel@ximian.com>
32183 * expression.cs (report118): require location argument.
32185 * parameter.cs: Do not dereference potential null value.
32187 * class.cs: Catch methods that lack the `new' keyword when
32188 overriding a name. Report warnings when `new' is used without
32189 anything being there to override.
32191 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
32193 * class.cs: Only add constructor to hashtable if it is non-null
32194 (as now constructors can fail on define).
32196 (TypeManager, Class, Struct): Take location arguments.
32198 Catch field instance initialization in structs as errors.
32200 accepting_filter: a new filter for FindMembers that is static so
32201 that we dont create an instance per invocation.
32203 (Constructor::Define): Catch errors where a struct constructor is
32206 * cs-parser.jay: Pass location information for various new
32209 * delegate.cs (Delegate): take a location argument.
32211 * driver.cs: Do not call EmitCode if there were problesm in the
32212 Definition of the types, as many Builders wont be there.
32214 * decl.cs (Decl::Decl): Require a location argument.
32216 * cs-tokenizer.cs: Handle properly hex constants that can not fit
32217 into integers, and find the most appropiate integer for it.
32219 * literal.cs: Implement ULongLiteral.
32221 * rootcontext.cs: Provide better information about the location of
32222 failure when CreateType fails.
32224 2001-09-29 Miguel de Icaza <miguel@ximian.com>
32226 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
32229 * expression.cs (Binary::CheckShiftArguments): Add missing type
32231 (Binary::ResolveOperator): Add type to the logical and and logical
32232 or, Bitwise And/Or and Exclusive Or code paths, it was missing
32235 (Binary::DoNumericPromotions): In the case where either argument
32236 is ulong (and most signed types combined with ulong cause an
32237 error) perform implicit integer constant conversions as well.
32239 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32241 * expression.cs (UserImplicitCast): Method should always be
32243 (Invocation::BetterConversion): Simplified test for IntLiteral.
32245 (Expression::ImplicitNumericConversion): Split this routine out.
32246 Put the code that performs implicit constant integer conversions
32249 (Expression::Resolve): Become a wrapper around DoResolve so we can
32250 check eclass and type being set after resolve.
32252 (Invocation::Badness): Remove this dead function
32254 (Binary::ResolveOperator): Do not compute the expensive argumnets
32255 unless we have a union for it.
32257 (Probe::Emit): Is needs to do an isinst and then
32258 compare against null.
32260 (::CanConvert): Added Location argument. If the Location argument
32261 is null (Location.Null), then we do not report errors. This is
32262 used by the `probe' mechanism of the Explicit conversion. We do
32263 not want to generate an error for something that the user
32264 explicitly requested to be casted. But the pipeline for an
32265 explicit cast first tests for potential implicit casts.
32267 So for now, if the Location is null, it means `Probe only' to
32268 avoid adding another argument. Might have to revise this
32271 (ClassCast): New class used to type cast objects into arbitrary
32272 classes (used in Explicit Reference Conversions).
32274 Implement `as' as well.
32276 Reverted all the patches from Ravi below: they were broken:
32278 * The use of `level' as a mechanism to stop recursive
32279 invocations is wrong. That was there just to catch the
32280 bug with a strack trace but not as a way of addressing
32283 To fix the problem we have to *understand* what is going
32284 on and the interactions and come up with a plan, not
32285 just get things going.
32287 * The use of the type conversion cache that I proposed
32288 last night had an open topic: How does this work across
32289 protection domains. A user defined conversion might not
32290 be public in the location where we are applying the
32291 conversion, a different conversion might be selected
32292 (ie, private A->B (better) but public B->A (worse),
32293 inside A, A->B applies, but outside it, B->A will
32296 * On top of that (ie, even if the above is solved),
32297 conversions in a cache need to be abstract. Ie, `To
32298 convert from an Int to a Short use an OpcodeCast', not
32299 `To convert from an Int to a Short use the OpcodeCast on
32300 the variable 5' (which is what this patch was doing).
32302 2001-09-28 Ravi Pratap <ravi@ximian.com>
32304 * expression.cs (Invocation::ConversionExists): Re-write to use
32305 the conversion cache
32307 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
32308 cache all conversions done, not just user-defined ones.
32310 (Invocation::BetterConversion): The real culprit. Use ConversionExists
32311 to determine if a conversion exists instead of acutually trying to
32312 perform the conversion. It's faster too.
32314 (Expression::ConvertExplicit): Modify to use ConversionExists to check
32315 and only then attempt the implicit conversion.
32317 2001-09-28 Ravi Pratap <ravi@ximian.com>
32319 * expression.cs (ConvertImplicit): Use a cache for conversions
32320 already found. Check level of recursion and bail out if necessary.
32322 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32324 * typemanager.cs (string_concat_string_string, string_concat_object_object):
32325 Export standard methods that we expect for string operations.
32327 * statement.cs (Block::UsageWarning): Track usage of variables and
32328 report the errors for not used variables.
32330 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
32333 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32335 * codegen.cs: remove unnneded code
32337 * expression.cs: Removed BuiltinTypeAccess class
32339 Fix the order in which implicit conversions are
32342 The previous fixed dropped support for boxed conversions (adding a
32343 test to the test suite now)
32345 (UserImplicitCast::CanConvert): Remove test for source being null,
32346 that code is broken. We should not feed a null to begin with, if
32347 we do, then we should track the bug where the problem originates
32348 and not try to cover it up here.
32350 Return a resolved expression of type UserImplicitCast on success
32351 rather than true/false. Ravi: this is what I was talking about,
32352 the pattern is to use a static method as a "constructor" for
32355 Also, do not create arguments until the very last minute,
32356 otherwise we always create the arguments even for lookups that
32357 will never be performed.
32359 (UserImplicitCast::Resolve): Eliminate, objects of type
32360 UserImplicitCast are born in a fully resolved state.
32362 * typemanager.cs (InitCoreTypes): Init also value_type
32363 (System.ValueType).
32365 * expression.cs (Cast::Resolve): First resolve the child expression.
32367 (LValue): Add new method AddressOf to be used by
32370 Change the argument of Store to take an EmitContext instead of an
32371 ILGenerator, because things like FieldExpr need to be able to call
32372 their children expression to generate the instance code.
32374 (Expression::Error, Expression::Warning): Sugar functions for
32377 (Expression::MemberLookup): Accept a TypeContainer instead of a
32378 Report as the first argument.
32380 (Expression::ResolvePrimary): Killed. I still want to improve
32381 this as currently the code is just not right.
32383 (Expression::ResolveMemberAccess): Simplify, but it is still
32386 (Unary::Resolve): Catch errors in AddressOf operators.
32388 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
32389 index to a byte for the short-version, or the compiler will choose
32390 the wrong Emit call, which generates the wrong data.
32392 (ParameterReference::Emit, ::Store): same.
32394 (FieldExpr::AddressOf): Implement.
32396 * typemanager.cs: TypeManager: made public variable instead of
32399 * driver.cs: document --fatal.
32401 * report.cs (ErrorMessage, WarningMessage): new names for the old
32402 Error and Warning classes.
32404 * cs-parser.jay (member_access): Turn built-in access to types
32405 into a normal simplename
32407 2001-09-27 Ravi Pratap <ravi@ximian.com>
32409 * expression.cs (Invocation::BetterConversion): Fix to cope
32410 with q being null, since this was introducing a bug.
32412 * expression.cs (ConvertImplicit): Do built-in conversions first.
32414 2001-09-27 Ravi Pratap <ravi@ximian.com>
32416 * expression.cs (UserImplicitCast::Resolve): Fix bug.
32418 2001-09-27 Ravi Pratap <ravi@ximian.com>
32420 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
32421 I had introduced long ago (what's new ?).
32423 * expression.cs (UserImplicitCast::CanConvert): Static method to do
32424 the work of all the checking.
32425 (ConvertImplicit): Call CanConvert and only then create object if necessary.
32426 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
32428 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
32429 that is the right way.
32431 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
32432 overloading resolution. Use everywhere instead of cutting and pasting code.
32434 (Binary::ResolveOperator): Use MakeUnionSet.
32436 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
32437 we have to convert to bool types. Not complete yet.
32439 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32441 * typemanager.cs (TypeManager::CSharpName): support ushort.
32443 * expression.cs (Expression::TryImplicitIntConversion): Attempts
32444 to provide an expression that performsn an implicit constant int
32445 conversion (section 6.1.6).
32446 (Expression::ConvertImplicitRequired): Reworked to include
32447 implicit constant expression conversions.
32449 (Expression::ConvertNumericExplicit): Finished.
32451 (Invocation::Emit): If InstanceExpression is null, then it means
32452 that we perform a call on this.
32454 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32456 * expression.cs (Unary::Emit): Remove some dead code.
32457 (Probe): Implement Resolve and Emit for `is'.
32458 (Expression::ConvertImplicitRequired): Attempt to do constant
32459 expression conversions here. Maybe should be moved to
32460 ConvertImplicit, but I am not sure.
32461 (Expression::ImplicitLongConstantConversionPossible,
32462 Expression::ImplicitIntConstantConversionPossible): New functions
32463 that tell whether is it possible to apply an implicit constant
32464 expression conversion.
32466 (ConvertNumericExplicit): Started work on explicit numeric
32469 * cs-parser.jay: Update operator constants.
32471 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
32472 (Parameters::GetSignature): Hook up VerifyArgs here.
32473 (Parameters::VerifyArgs): Verifies that no two arguments have the
32476 * class.cs (Operator): Update the operator names to reflect the
32477 ones that the spec expects (as we are just stringizing the
32480 * expression.cs (Unary::ResolveOperator): Fix bug: Use
32481 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
32482 previous usage did only work for our methods.
32483 (Expression::ConvertImplicit): Handle decimal implicit numeric
32484 conversions as well.
32485 (Expression::InternalTypeConstructor): Used to invoke constructors
32486 on internal types for default promotions.
32488 (Unary::Emit): Implement special handling for the pre/post
32489 increment/decrement for overloaded operators, as they need to have
32490 the same semantics as the other operators.
32492 (Binary::ResolveOperator): ditto.
32493 (Invocation::ConversionExists): ditto.
32494 (UserImplicitCast::Resolve): ditto.
32496 2001-09-26 Ravi Pratap <ravi@ximian.com>
32498 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
32499 operator, return after emitting body. Regression tests pass again !
32501 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
32502 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
32503 (Invocation::OverloadResolve): Ditto.
32504 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
32506 * everywhere : update calls to the above methods accordingly.
32508 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32510 * assign.cs (Assign): Make it inherit from ExpressionStatement.
32512 * expression.cs (ExpressionStatement): New base class used for
32513 expressions that can appear in statements, so that we can provide
32514 an alternate path to generate expression that do not leave a value
32517 (Expression::Emit, and all the derivatives): We no longer return
32518 whether a value is left on the stack or not. Every expression
32519 after being emitted leaves a single value on the stack.
32521 * codegen.cs (EmitContext::EmitStatementExpression): Use the
32522 facilties of ExpressionStatement if possible.
32524 * cs-parser.jay: Update statement_expression.
32526 2001-09-25 Miguel de Icaza <miguel@ximian.com>
32528 * driver.cs: Change the wording of message
32530 2001-09-25 Ravi Pratap <ravi@ximian.com>
32532 * expression.cs (Binary::ResolveOperator): Had forgottten to set
32533 the type of the expression to the return type of the method if
32534 we have an overloaded operator match ! The regression tests pass again !
32535 (Unary::ResolveOperator): Ditto.
32537 * expression.cs (Invocation::ConversionExists): Correct the member lookup
32538 to find "op_Implicit", not "implicit" ;-)
32539 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32540 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32542 * everywhere : Correct calls to the above accordingly.
32544 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32545 (ConvertImplicit): Do user-defined conversion if it exists.
32547 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32549 * assign.cs: track location.
32550 (Resolve): Use implicit conversions on assignment.
32552 * literal.cs: Oops. Not good, Emit of short access values should
32553 pass (Bytes) or the wrong argument will be selected.
32555 * expression.cs (Unary::Emit): Emit code for -expr.
32557 (Unary::ResolveOperator): Handle `Substract' for non-constants
32558 (substract from zero from the non-constants).
32559 Deal with Doubles as well.
32561 (Expression::ConvertImplicitRequired): New routine that reports an
32562 error if no implicit conversion exists.
32564 (Invocation::OverloadResolve): Store the converted implicit
32565 expressions if we make them
32567 2001-09-24 Ravi Pratap <ravi@ximian.com>
32569 * class.cs (ConstructorInitializer): Take a Location argument.
32570 (ConstructorBaseInitializer): Same here.
32571 (ConstructorThisInitializer): Same here.
32573 * cs-parser.jay : Update all calls accordingly.
32575 * expression.cs (Unary, Binary, New): Take location argument.
32576 Update accordingly everywhere.
32578 * cs-parser.jay : Update all calls to the above to take a location
32581 * class.cs : Ditto.
32583 2001-09-24 Ravi Pratap <ravi@ximian.com>
32585 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32586 (Invocation::BetterConversion): Same here
32587 (Invocation::ConversionExists): Ditto.
32589 (Invocation::ConversionExists): Implement.
32591 2001-09-22 Ravi Pratap <ravi@ximian.com>
32593 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32594 Also take an additional TypeContainer argument.
32596 * All over : Pass in TypeContainer as argument to OverloadResolve.
32598 * typemanager.cs (CSharpName): Update to check for the string type and return
32601 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32604 2001-09-21 Ravi Pratap <ravi@ximian.com>
32606 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32607 (Invocation::BetterFunction): Implement.
32608 (Invocation::BetterConversion): Implement.
32609 (Invocation::ConversionExists): Skeleton, no implementation yet.
32611 Okay, things work fine !
32613 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32615 * typemanager.cs: declare and load enum_type, delegate_type and
32618 * expression.cs (Expression::Emit): Now emit returns a value that
32619 tells whether a value is left on the stack or not. This strategy
32620 might be reveted tomorrow with a mechanism that would address
32621 multiple assignments.
32622 (Expression::report118): Utility routine to report mismatches on
32625 (Unary::Report23): Report impossible type/operator combination
32628 (Unary::IsIncrementableNumber): Whether the type can be
32629 incremented or decremented with add.
32630 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32632 (Unary::ResolveOperator): Implement ++, !, ~,
32634 (Invocation::Emit): Deal with new Emit convetion.
32636 * All Expression derivatives: Updated their Emit method to return
32637 whether they leave values on the stack or not.
32639 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32640 stack for expressions that are statements.
32642 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32644 * expression.cs (LValue): New interface. Must be implemented by
32646 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32649 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32650 interface for generating code, simplifies the code.
32652 2001-09-20 Ravi Pratap <ravi@ximian.com>
32654 * expression.cs (everywhere): Comment out return statements in ::Resolve
32655 methods to avoid the warnings.
32657 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32659 * driver.cs (parse): Report error 2001 if we can not open the
32662 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32665 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32668 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32669 otherwise nested blocks end up with the same index.
32671 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32673 * expression.cs: Instead of having FIXMEs in the Resolve
32674 functions, throw exceptions so it is obvious that we are facing a
32677 * cs-parser.jay (invocation_expression): Pass Location information.
32679 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32680 Use a basename for those routines because .NET does not like paths
32683 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32686 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32688 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32689 are loading the correct data types (throws an exception if not).
32690 (TypeManager::InitCoreTypes): Use CoreLookupType
32692 * expression.cs (Unary::ResolveOperator): return the child
32693 expression for expressions which are just +expr.
32694 (Unary::ResolveOperator): Return negative literals for -LITERAL
32695 expressions (otherwise they are Unary {Literal}).
32696 (Invocation::Badness): Take into account `Implicit constant
32697 expression conversions'.
32699 * literal.cs (LongLiteral): Implement long literal class.
32700 (IntLiteral): export the `Value' of the intliteral.
32702 2001-09-19 Ravi Pratap <ravi@ximian.com>
32704 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32706 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32707 instead of 'Operator'
32709 * expression.cs (Binary::ResolveOperator): Update accordingly.
32710 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32713 * cs-parser.jay (unary_expression): Update to use the new names.
32715 * gen-treedump.cs (GetUnary): Same here.
32717 * expression.cs (Unary::Resolve): Implement.
32718 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32719 operators are found instead of making noise ;-)
32720 (Unary::ResolveOperator): New method to do precisely the same thing which
32721 Binary::ResolveOperator does for Binary expressions.
32722 (Unary.method, .Arguments): Add.
32723 (Unary::OperName): Implement.
32724 (Unary::ForceConversion): Copy and Paste !
32726 * class.cs (Operator::Define): Fix a small bug for the case when we have
32729 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32730 for the inbuilt operators. Only overloading works for now ;-)
32732 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32734 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32735 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32737 * expression.cs (This::Emit): Implement.
32738 (This::Resolve): Implement.
32739 (TypeOf:Resolve): Implement.
32740 (Expression::ResolveSimpleName): Add an implicit this to instance
32742 (MemberAccess::Resolve): Deal with Parameters and Fields.
32743 Bind instance variable to Field expressions.
32744 (FieldExpr::Instance): New field used to track the expression that
32745 represents the object instance.
32746 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32748 (FieldExpr::Emit): Implement.
32750 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32751 the last instruction contains a return opcode to avoid generating
32752 the last `ret' instruction (this generates correct code, and it is
32753 nice to pass the peverify output).
32755 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32756 initializer for static and instance variables.
32757 (Constructor::Emit): Allow initializer to be null in the case of
32758 static constructors. Only emit initializer for instance
32761 (TypeContainer::FindMembers): Return a null array if there are no
32764 Also fix the code for the MemberTypes.Method branch, as it was not
32765 scanning that for operators (or tried to access null variables before).
32767 * assign.cs (Assign::Emit): Handle instance and static fields.
32771 * driver.cs: Stop compilation if there are parse errors.
32773 * cs-parser.jay (constructor_declaration): Provide default base
32774 initializer for non-static constructors.
32775 (constructor_declarator): Do not provide a default base
32776 initializers if none was specified.
32777 Catch the fact that constructors should not have parameters.
32779 * class.cs: Do not emit parent class initializers for static
32780 constructors, that should be flagged as an error.
32782 2001-09-18 Ravi Pratap <ravi@ximian.com>
32784 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32785 Move back code into TypeContainer::Populate.
32787 2001-09-18 Ravi Pratap <ravi@ximian.com>
32789 * class.cs (TypeContainer::AddConstructor): Fix the check to
32790 compare against Name, not Basename.
32791 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32793 * cs-parser.jay : Update accordingly.
32795 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32796 for methods, don't forget to look into the operators too.
32797 (RegisterMethodBuilder): Helper method to take care of this for
32798 methods, constructors and operators.
32799 (Operator::Define): Completely revamp.
32800 (Operator.OperatorMethod, MethodName): New fields.
32801 (TypeContainer::Populate): Move the registering of builders into
32802 RegisterMethodBuilder.
32803 (Operator::Emit): Re-write.
32805 * expression.cs (Binary::Emit): Comment out code path to emit method
32806 invocation stuff for the case when we have a user defined operator. I am
32807 just not able to get it right !
32809 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32811 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32814 (Expression::MemberLookup): Provide a version that allows to
32815 specify the MemberTypes and BindingFlags.
32817 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32818 so it was not fetching variable information from outer blocks.
32820 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32821 Beforefieldinit as it was buggy.
32823 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32824 that Ravi put here.
32826 * class.cs (Constructor::Emit): Only emit if block is not null.
32827 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32828 deal with this by semantically definining it as if the user had
32831 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32832 constructors as we now "emit" them at a higher level.
32834 (TypeContainer::DefineDefaultConstructor): Used to define the
32835 default constructors if none was provided.
32837 (ConstructorInitializer): Add methods Resolve and Emit.
32839 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32841 2001-09-17 Ravi Pratap <ravi@ximian.com>
32843 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32844 the default constructor builder with our hashtable for methodbuilders
32847 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32848 and argument_count is 0 in which case we have a match.
32849 (Binary::ResolveOperator): More null checking and miscellaneous coding
32852 2001-09-17 Ravi Pratap <ravi@ximian.com>
32854 * rootcontext.cs (IsNameSpace): Compare against null.
32856 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32858 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32859 and Unary::Operator.
32861 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32864 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32865 we have overloaded operators.
32866 (Binary::ResolveOperator): Implement the part which does the operator overload
32869 * class.cs (Operator::Emit): Implement.
32870 (TypeContainer::Emit): Emit the operators we have too.
32872 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32873 the case when we have a user-defined operator.
32875 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32877 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32879 2001-09-16 Ravi Pratap <ravi@ximian.com>
32881 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32882 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32883 (Constructor::Emit): Implement.
32884 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32885 if we have no work to do.
32886 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32889 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32890 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32892 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32895 2001-09-15 Ravi Pratap <ravi@ximian.com>
32897 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32899 (Tree::RecordNamespace): Method to do what the name says ;-)
32900 (Tree::Namespaces): Property to get at the namespaces hashtable.
32902 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32905 * rootcontext.cs (IsNamespace): Fixed it :-)
32907 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32909 * class.cs (TypeContainer::FindMembers): Add support for
32911 (MethodCore): New class that encapsulates both the shared aspects
32912 of a Constructor and a Method.
32913 (Method, Constructor): Factored pieces into MethodCore.
32915 * driver.cs: Added --fatal which makes errors throw exceptions.
32916 Load System assembly as well as part of the standard library.
32918 * report.cs: Allow throwing exceptions on errors for debugging.
32920 * modifiers.cs: Do not use `parent', instead use the real type
32921 container to evaluate permission settings.
32923 * class.cs: Put Ravi's patch back in. He is right, and we will
32924 have to cope with the
32926 2001-09-14 Ravi Pratap <ravi@ximian.com>
32928 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32929 FamORAssem, not FamANDAssem.
32931 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32933 * driver.cs: Added --parse option that only parses its input files
32936 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32937 incorrect. IsTopLevel is not used to tell whether an object is
32938 root_types or not (that can be achieved by testing this ==
32939 root_types). But to see if this is a top-level *class* (not
32940 necessarly our "toplevel" container).
32942 2001-09-14 Ravi Pratap <ravi@ximian.com>
32944 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32945 parent instead of a direct call to GetType.
32947 2001-09-14 Ravi Pratap <ravi@ximian.com>
32949 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32950 Modifiers.TypeAttr. This should just be a call to that method.
32952 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32953 object so that we can determine if we are top-level or not.
32955 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32958 * enum.cs (Enum::Define): Ditto.
32960 * modifiers.cs (FieldAttr): Re-write.
32962 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32963 (TypeContainer::HaveStaticConstructor): New property to provide access
32964 to precisely that info.
32966 * modifiers.cs (MethodAttr): Re-write.
32967 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32969 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32970 of top-level types as claimed.
32972 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32974 * expression.cs (MemberLookup): Fruitless attempt to lookup
32975 constructors. Maybe I need to emit default constructors? That
32976 might be it (currently .NET emits this for me automatically).
32977 (Invocation::OverloadResolve): Cope with Arguments == null.
32978 (Invocation::EmitArguments): new function, shared by the new
32979 constructor and us.
32980 (Invocation::Emit): Handle static and instance methods. Emit
32981 proper call instruction for virtual or non-virtual invocations.
32982 (New::Emit): Implement.
32983 (New::Resolve): Implement.
32984 (MemberAccess:Resolve): Implement.
32985 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32986 to track instances.
32987 (FieldExpr::Resolve): Set type.
32989 * support.cs: Handle empty arguments.
32991 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32992 SimpleLookup): Auxiliary routines to help parse a qualifier
32995 Update qualifier_identifier rule.
32997 * codegen.cs: Removed debugging messages.
32999 * class.cs: Make this a global thing, this acts just as a "key" to
33000 objects that we might have around.
33002 (Populate): Only initialize method_builders_to_methods once.
33004 * expression.cs (PropertyExpr): Initialize type from the
33007 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
33008 Resolve pattern. Attempt to implicitly convert value to boolean.
33011 * expression.cs: Set the type for the int32/int32 argument case.
33012 (Binary::ResolveOperator): Set the return type to boolean for
33013 comparission operators
33015 * typemanager.cs: Remove debugging print code.
33017 (Invocation::Resolve): resolve type.
33019 * class.cs: Allocate a MemberInfo of the correct size, as the code
33020 elsewhere depends on the test to reflect the correct contents.
33022 (Method::) Keep track of parameters, due to System.Reflection holes
33024 (TypeContainer::Populate): Keep track of MethodBuilders to Method
33027 (TypeContainer::FindMembers): Use ArrayList and then copy an array
33028 of the exact size and return that.
33030 (Class::LookupMethodByBuilder): New function that maps
33031 MethodBuilders to its methods. Required to locate the information
33032 on methods because System.Reflection bit us again.
33034 * support.cs: New file, contains an interface ParameterData and
33035 two implementations: ReflectionParameters and InternalParameters
33036 used to access Parameter information. We will need to grow this
33039 * expression.cs (Invocation::GetParameterData): implement a cache
33040 and a wrapper around the ParameterData creation for methods.
33041 (Invocation::OverloadResolve): Use new code.
33043 2001-09-13 Ravi Pratap <ravi@ximian.com>
33045 * class.cs (TypeContainer::EmitField): Remove and move into
33046 (Field::Define): here and modify accordingly.
33047 (Field.FieldBuilder): New member.
33048 (TypeContainer::Populate): Update accordingly.
33049 (TypeContainer::FindMembers): Implement.
33051 2001-09-13 Miguel de Icaza <miguel@ximian.com>
33053 * statement.cs: (VariableInfo::VariableType): New field to be
33054 initialized with the full type once it is resolved.
33056 2001-09-12 Miguel de Icaza <miguel@ximian.com>
33058 * parameter.cs (GetParameterInfo): Use a type cache to compute
33059 things only once, and to reuse this information
33061 * expression.cs (LocalVariableReference::Emit): Implement.
33062 (OpcodeCast::Emit): fix.
33064 (ParameterReference::Resolve): Implement.
33065 (ParameterReference::Emit): Implement.
33067 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
33068 that are expressions need to stay as Expressions.
33070 * typemanager.cs (CSharpName): Returns the C# name of a type if
33073 * expression.cs (Expression::ConvertImplicit): New function that
33074 implements implicit type conversions.
33076 (Expression::ImplicitReferenceConversion): Implements implicit
33077 reference conversions.
33079 (EmptyCast): New type for transparent casts.
33081 (OpcodeCast): New type for casts of types that are performed with
33082 a sequence of bytecodes.
33084 (BoxedCast): New type used for casting value types into reference
33085 types. Emits a box opcode.
33087 (Binary::DoNumericPromotions): Implements numeric promotions of
33088 and computation of the Binary::Type.
33090 (Binary::EmitBranchable): Optimization.
33092 (Binary::Emit): Implement code emission for expressions.
33094 * typemanager.cs (TypeManager): Added two new core types: sbyte
33097 2001-09-12 Ravi Pratap <ravi@ximian.com>
33099 * class.cs (TypeContainer::FindMembers): Method which does exactly
33100 what Type.FindMembers does, only we don't have to use reflection. No
33101 implementation yet.
33103 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
33104 typecontainer objects as we need to get at them.
33105 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
33107 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
33108 typecontainer object.
33110 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
33111 of just a Report object.
33113 2001-09-11 Ravi Pratap <ravi@ximian.com>
33115 * class.cs (Event::Define): Go back to using the prefixes "add_" and
33117 (TypeContainer::Populate): Now define the delegates of the type too.
33118 (TypeContainer.Delegates): Property to access the list of delegates defined
33121 * delegates.cs (Delegate::Define): Implement partially.
33123 * modifiers.cs (TypeAttr): Handle more flags.
33125 2001-09-11 Ravi Pratap <ravi@ximian.com>
33127 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
33129 (Operator::Define): Re-write logic to get types by using the LookupType method
33130 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
33131 (Indexer::Define): Ditto.
33132 (Event::Define): Ditto.
33133 (Property::Define): Ditto.
33135 2001-09-10 Ravi Pratap <ravi@ximian.com>
33137 * class.cs (TypeContainer::Populate): Now define operators too.
33138 (TypeContainer.Operators): New property to access the list of operators
33140 (Operator.OperatorMethodBuilder): New member to hold the method builder
33141 for the operator we are defining.
33142 (Operator::Define): Implement.
33144 2001-09-10 Ravi Pratap <ravi@ximian.com>
33146 * class.cs (Event::Define): Make the prefixes of the accessor methods
33147 addOn_ and removeOn_
33149 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
33150 of the location being passed in too. Ideally, this should go later since all
33151 error reporting should be done through the Report object.
33153 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
33154 (Populate): Iterate thru the indexers we have and define them too.
33155 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
33156 for the get and set accessors.
33157 (Indexer::Define): Implement.
33159 2001-09-09 Miguel de Icaza <miguel@ximian.com>
33161 * expression.cs (Binary::Resolve): Beginning of it. I scratched
33162 my previous implementation, did not work.
33164 * typemanager.cs: Add a couple of missing types (the longs).
33166 * literal.cs: Use TypeManager.bool_type instead of getting it.
33168 * expression.cs (EventExpr): New kind of expressions.
33169 (Expressio::ExprClassFromMemberInfo): finish
33171 2001-09-08 Miguel de Icaza <miguel@ximian.com>
33173 * assign.cs: Emit stores to static fields differently.
33175 2001-09-08 Ravi Pratap <ravi@ximian.com>
33177 * Merge in changes and adjust code to tackle conflicts. Backed out my
33178 code in Assign::Resolve ;-)
33180 2001-09-08 Ravi Pratap <ravi@ximian.com>
33182 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
33183 instead Report.Error and also pass in the location.
33184 (CSharpParser::Lexer): New readonly property to return the reference
33185 to the Tokenizer object.
33186 (declare_local_variables): Use Report.Error with location instead of plain
33190 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
33191 (Operator.CheckBinaryOperator): Ditto.
33193 * cs-parser.jay (operator_declarator): Update accordingly.
33195 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
33196 (CheckBinaryOperator): Same here.
33198 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
33199 on the name without any prefixes of namespace names etc. This is because we
33200 already might have something already fully qualified like
33201 'System.Console.WriteLine'
33203 * assign.cs (Resolve): Begin implementation. Stuck ;-)
33205 2001-09-07 Ravi Pratap <ravi@ximian.com>
33207 * cs-tokenizer.cs (location): Return a string which also contains
33210 * expression.cs (ElementAccess): New class for expressions of the
33211 type 'element access.'
33212 (BaseAccess): New class for expressions of the type 'base access.'
33213 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
33216 * cs-parser.jay (element_access): Implement action.
33217 (base_access): Implement actions.
33218 (checked_expression, unchecked_expression): Implement.
33220 * cs-parser.jay (local_variable_type): Correct and implement.
33221 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
33223 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
33225 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
33226 name and the specifiers.
33228 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
33230 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
33231 making them all public ;-)
33233 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
33236 2001-09-07 Miguel de Icaza <miguel@ximian.com>
33238 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
33240 (FieldExpr, PropertyExprs): New resolved expressions.
33241 (SimpleName::MemberStaticCheck): Perform static checks for access
33242 to non-static fields on static methods. Maybe this should be
33243 generalized for MemberAccesses.
33244 (SimpleName::ResolveSimpleName): More work on simple name
33247 * cs-parser.jay (primary_expression/qualified_identifier): track
33248 the parameter index.
33250 * codegen.cs (CodeGen::Save): Catch save exception, report error.
33251 (EmitContext::EmitBoolExpression): Chain to expression generation
33252 instead of temporary hack.
33253 (::EmitStatementExpression): Put generic expression code generation.
33255 * assign.cs (Assign::Emit): Implement variable assignments to
33256 local variables, parameters and fields.
33258 2001-09-06 Miguel de Icaza <miguel@ximian.com>
33260 * statement.cs (Block::GetVariableInfo): New method, returns the
33261 VariableInfo for a variable name in a block.
33262 (Block::GetVariableType): Implement in terms of GetVariableInfo
33264 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
33265 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
33267 2001-09-06 Ravi Pratap <ravi@ximian.com>
33269 * cs-parser.jay (operator_declaration): Continue on my quest : update
33270 to take attributes argument.
33271 (event_declaration): Ditto.
33272 (enum_declaration): Ditto.
33273 (indexer_declaration): Ditto.
33275 * class.cs (Operator::Operator): Update constructor accordingly.
33276 (Event::Event): Ditto.
33278 * delegate.cs (Delegate::Delegate): Same here.
33280 * enum.cs (Enum::Enum): Same here.
33282 2001-09-05 Ravi Pratap <ravi@ximian.com>
33284 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
33286 * ../tests/cs0658.cs : New file to demonstrate error 0658.
33288 * attribute.cs (Attributes): New class to encapsulate all attributes which were
33289 being passed around as an arraylist.
33290 (Attributes::AddAttribute): Method to add attribute sections.
33292 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
33293 (struct_declaration): Update accordingly.
33294 (constant_declaration): Update.
33295 (field_declaration): Update.
33296 (method_header): Update.
33297 (fixed_parameter): Update.
33298 (parameter_array): Ditto.
33299 (property_declaration): Ditto.
33300 (destructor_declaration): Ditto.
33302 * class.cs (Struct::Struct): Update constructors accordingly.
33303 (Class::Class): Ditto.
33304 (Field::Field): Ditto.
33305 (Method::Method): Ditto.
33306 (Property::Property): Ditto.
33307 (TypeContainer::OptAttribute): update property's return type.
33309 * interface.cs (Interface.opt_attributes): New member.
33310 (Interface::Interface): Update to take the extra Attributes argument.
33312 * parameter.cs (Parameter::Parameter): Ditto.
33314 * constant.cs (Constant::Constant): Ditto.
33316 * interface.cs (InterfaceMemberBase): New OptAttributes field.
33317 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
33318 the attributes as a parameter.
33319 (InterfaceProperty): Update constructor call.
33320 (InterfaceEvent): Ditto.
33321 (InterfaceMethod): Ditto.
33322 (InterfaceIndexer): Ditto.
33324 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
33325 pass the attributes too.
33326 (interface_event_declaration): Ditto.
33327 (interface_property_declaration): Ditto.
33328 (interface_method_declaration): Ditto.
33329 (interface_declaration): Ditto.
33331 2001-09-05 Miguel de Icaza <miguel@ximian.com>
33333 * class.cs (Method::Define): Track the "static Main" definition to
33334 create an entry point.
33336 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
33337 EntryPoint if we find it.
33339 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
33340 (EmitContext::ig): Make this variable public.
33342 * driver.cs: Make the default output file be the first file name
33343 with the .exe extension.
33345 Detect empty compilations
33347 Handle various kinds of output targets. Handle --target and
33348 rename -t to --dumper.
33350 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
33351 methods inherited from Expression return now an Expression. This
33352 will is used during the tree rewriting as we resolve them during
33355 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
33356 the spec. Missing entirely is the information about
33357 accessability of elements of it.
33359 (Expression::ExprClassFromMemberInfo): New constructor for
33360 Expressions that creates a fully initialized Expression based on
33361 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
33364 (Invocation::Resolve): Begin implementing resolution of invocations.
33366 * literal.cs (StringLiteral): Implement Emit.
33368 2001-09-05 Ravi Pratap <ravi@ximian.com>
33370 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
33373 2001-09-04 Ravi Pratap <ravi@ximian.com>
33375 * cs-parser.jay (attribute_arguments): Implement actions.
33376 (attribute): Fix bug in production. Implement action.
33377 (attribute_list): Implement.
33378 (attribute_target): Implement.
33379 (attribute_target_specifier, opt_target_specifier): Implement
33380 (CheckAttributeTarget): New method to check if the attribute target
33382 (attribute_section): Implement.
33383 (opt_attributes): Implement.
33385 * attribute.cs : New file to handle attributes.
33386 (Attribute): Class to hold attribute info.
33388 * cs-parser.jay (opt_attribute_target_specifier): Remove production
33389 (attribute_section): Modify production to use 2 different rules to
33390 achieve the same thing. 1 s/r conflict down !
33391 Clean out commented, useless, non-reducing dimension_separator rules.
33393 * class.cs (TypeContainer.attributes): New member to hold list
33394 of attributes for a type.
33395 (Struct::Struct): Modify to take one more argument, the attribute list.
33396 (Class::Class): Ditto.
33397 (Field::Field): Ditto.
33398 (Method::Method): Ditto.
33399 (Property::Property): Ditto.
33401 * cs-parser.jay (struct_declaration): Update constructor call to
33402 pass in the attributes too.
33403 (class_declaration): Ditto.
33404 (constant_declaration): Ditto.
33405 (field_declaration): Ditto.
33406 (method_header): Ditto.
33407 (fixed_parameter): Ditto.
33408 (parameter_array): Ditto.
33409 (property_declaration): Ditto.
33411 * constant.cs (Constant::Constant): Update constructor similarly.
33412 Use System.Collections.
33414 * parameter.cs (Parameter::Parameter): Update as above.
33416 2001-09-02 Ravi Pratap <ravi@ximian.com>
33418 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
33419 (TypeContainer.delegates): New member to hold list of delegates.
33421 * cs-parser.jay (delegate_declaration): Implement the action correctly
33422 this time as I seem to be on crack ;-)
33424 2001-09-02 Miguel de Icaza <miguel@ximian.com>
33426 * rootcontext.cs (RootContext::IsNamespace): new function, used to
33427 tell whether an identifier represents a namespace.
33429 * expression.cs (NamespaceExpr): A namespace expression, used only
33430 temporarly during expression resolution.
33431 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
33432 utility functions to resolve names on expressions.
33434 2001-09-01 Miguel de Icaza <miguel@ximian.com>
33436 * codegen.cs: Add hook for StatementExpressions.
33438 * class.cs: Fix inverted test for static flag in methods.
33440 2001-09-02 Ravi Pratap <ravi@ximian.com>
33442 * class.cs (Operator::CheckUnaryOperator): Correct error number used
33443 to make it coincide with MS' number.
33444 (Operator::CheckBinaryOperator): Ditto.
33446 * ../errors/errors.txt : Remove error numbers added earlier.
33448 * ../errors/cs1019.cs : Test case for error # 1019
33450 * ../errros/cs1020.cs : Test case for error # 1020
33452 * cs-parser.jay : Clean out commented cruft.
33453 (dimension_separators, dimension_separator): Comment out. Ostensibly not
33454 used anywhere - non-reducing rule.
33455 (namespace_declarations): Non-reducing rule - comment out.
33457 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
33458 with TypeContainer::AddEnum.
33460 * delegate.cs : New file for delegate handling classes.
33461 (Delegate): Class for declaring delegates.
33463 * makefile : Update.
33465 * cs-parser.jay (delegate_declaration): Implement.
33467 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
33469 * class.cs (Event::Define): Implement.
33470 (Event.EventBuilder): New member.
33472 * class.cs (TypeContainer::Populate): Update to define all enums and events
33474 (Events): New property for the events arraylist we hold. Shouldn't we move to using
33475 readonly fields for all these cases ?
33477 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33479 * class.cs (Property): Revamp to use the convention of making fields readonly.
33480 Accordingly modify code elsewhere.
33482 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
33483 the Define method of the Property class.
33485 * class.cs : Clean up applied patch and update references to variables etc. Fix
33487 (TypeContainer::Populate): Update to define all the properties we have. Also
33488 define all enumerations.
33490 * enum.cs (Define): Implement.
33492 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33494 * cs-parser.jay (overloadable_operator): The semantic value is an
33495 enum of the Operator class.
33496 (operator_declarator): Implement actions.
33497 (operator_declaration): Implement.
33499 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
33500 validity of definitions.
33501 (Operator::CheckBinaryOperator): Static method to check for binary operators
33502 (TypeContainer::AddOperator): New method to add an operator to a type.
33504 * cs-parser.jay (indexer_declaration): Added line to actually call the
33505 AddIndexer method so it gets added ;-)
33507 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
33508 already taken care of by the MS compiler ?
33510 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33512 * class.cs (Operator): New class for operator declarations.
33513 (Operator::OpType): Enum for the various operators.
33515 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33517 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
33518 ostensibly handle this in semantic analysis.
33520 * cs-parser.jay (general_catch_clause): Comment out
33521 (specific_catch_clauses, specific_catch_clause): Ditto.
33522 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
33523 (catch_args, opt_catch_args): New productions.
33524 (catch_clause): Rewrite to use the new productions above
33525 (catch_clauses): Modify accordingly.
33526 (opt_catch_clauses): New production to use in try_statement
33527 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
33528 and re-write the code in the actions to extract the specific and
33529 general catch clauses by being a little smart ;-)
33531 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
33532 Hooray, try and catch statements parse fine !
33534 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33536 * statement.cs (Block::GetVariableType): Fix logic to extract the type
33537 string from the hashtable of variables.
33539 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33540 I end up making that mistake ;-)
33541 (catch_clauses): Fixed gross error which made Key and Value of the
33542 DictionaryEntry the same : $1 !!
33544 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33546 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33548 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33549 when the add and remove accessors are specified.
33551 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33553 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33554 information about indexer_declarator.
33555 (indexer_declarator): Implement actions.
33556 (parsing_indexer): New local boolean used to keep track of whether
33557 we are parsing indexers or properties. This is necessary because
33558 implicit_parameters come into picture even for the get accessor in the
33559 case of an indexer.
33560 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33562 * class.cs (Indexer): New class for indexer declarations.
33563 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33564 (TypeContainer::indexers): New member to hold list of indexers for the
33567 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33569 * cs-parser.jay (add_accessor_declaration): Implement action.
33570 (remove_accessor_declaration): Implement action.
33571 (event_accessors_declaration): Implement
33572 (variable_declarators): swap statements for first rule - trivial.
33574 * class.cs (Event): New class to hold information about event
33576 (TypeContainer::AddEvent): New method to add an event to a type
33577 (TypeContainer::events): New member to hold list of events.
33579 * cs-parser.jay (event_declaration): Implement actions.
33581 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33583 * cs-parser.jay (dim_separators): Implement. Make it a string
33584 concatenating all the commas together, just as they appear.
33585 (opt_dim_separators): Modify accordingly
33586 (rank_specifiers): Update accordingly. Basically do the same
33587 thing - instead, collect the brackets here.
33588 (opt_rank_sepcifiers): Modify accordingly.
33589 (array_type): Modify to actually return the complete type string
33590 instead of ignoring the rank_specifiers.
33591 (expression_list): Implement to collect the expressions
33592 (variable_initializer): Implement. We make it a list of expressions
33593 essentially so that we can handle the array_initializer case neatly too.
33594 (variable_initializer_list): Implement.
33595 (array_initializer): Make it a list of variable_initializers
33596 (opt_array_initializer): Modify accordingly.
33598 * expression.cs (New::NType): Add enumeration to help us
33599 keep track of whether we have an object/delegate creation
33600 or an array creation.
33601 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33602 members to hold data about array creation.
33603 (New:New): Modify to update NewType
33604 (New:New): New Overloaded contructor for the array creation
33607 * cs-parser.jay (array_creation_expression): Implement to call
33608 the overloaded New constructor.
33610 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33612 * class.cs (TypeContainer::Constructors): Return member
33613 constructors instead of returning null.
33615 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33617 * typemanager.cs (InitCoreTypes): Initialize the various core
33618 types after we have populated the type manager with the user
33619 defined types (this distinction will be important later while
33620 compiling corlib.dll)
33622 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33623 on Expression Classification. Now all expressions have a method
33624 `Resolve' and a method `Emit'.
33626 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33627 generation from working. Also add some temporary debugging
33630 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33632 * codegen.cs: Lots of code generation pieces. This is only the
33633 beginning, will continue tomorrow with more touches of polish. We
33634 handle the fundamentals of if, while, do, for, return. Others are
33635 trickier and I need to start working on invocations soon.
33637 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33640 * codegen.cs (EmitContext): New struct, used during code
33641 emission to keep a context. Most of the code generation will be
33644 * cs-parser.jay: Add embedded blocks to the list of statements of
33645 this block. So code generation proceeds in a top down fashion.
33647 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33649 * statement.cs: Add support for multiple child blocks.
33651 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33653 * codegen.cs (EmitCode): New function, will emit the code for a
33654 Block of code given a TypeContainer and its ILGenerator.
33656 * statement.cs (Block): Standard public readonly optimization.
33657 (Block::Block constructors): Link children.
33658 (Block::Child): Child Linker.
33659 (Block::EmitVariables): Emits IL variable declarations.
33661 * class.cs: Drop support for MethodGroups here, delay until
33663 (Method::): Applied the same simplification that I did before, and
33664 move from Properties to public readonly fields.
33665 (Method::ParameterTypes): Returns the parameter types for the
33666 function, and implements a cache that will be useful later when I
33667 do error checking and the semantic analysis on the methods is
33669 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33670 and made a method, optional argument tells whether this is a class
33671 or a structure to apply the `has-this' bit.
33672 (Method::GetCallingConvention): Implement, returns the calling
33674 (Method::Define): Defines the type, a second pass is performed
33675 later to populate the methods.
33677 (Constructor::ParameterTypes): implement a cache similar to the
33678 one on Method::ParameterTypes, useful later when we do semantic
33681 (TypeContainer::EmitMethod): New method. Emits methods.
33683 * expression.cs: Removed MethodGroup class from here.
33685 * parameter.cs (Parameters::GetCallingConvention): new method.
33687 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33689 * class.cs (TypeContainer::Populate): Drop RootContext from the
33692 (Constructor::CallingConvention): Returns the calling convention.
33693 (Constructor::ParameterTypes): Returns the constructor parameter
33696 (TypeContainer::AddConstructor): Keep track of default constructor
33697 and the default static constructor.
33699 (Constructor::) Another class that starts using `public readonly'
33700 instead of properties.
33702 (Constructor::IsDefault): Whether this is a default constructor.
33704 (Field::) use readonly public fields instead of properties also.
33706 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33707 track of static constructors; If none is used, turn on
33708 BeforeFieldInit in the TypeAttributes.
33710 * cs-parser.jay (opt_argument_list): now the return can be null
33711 for the cases where there are no arguments.
33713 (constructor_declarator): If there is no implicit `base' or
33714 `this', then invoke the default parent constructor.
33716 * modifiers.cs (MethodAttr): New static function maps a set of
33717 modifiers flags into a MethodAttributes enum
33718 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33719 MethodAttr, TypeAttr to represent the various mappings where the
33720 modifiers are used.
33721 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33723 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33725 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33728 * interface.cs (PopulateIndexer): Implemented the code generator
33729 for interface indexers.
33731 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33733 * interface.cs (InterfaceMemberBase): Now we track the new status
33736 (PopulateProperty): Implement property population. Woohoo! Got
33737 Methods and Properties going today.
33739 Removed all the properties for interfaces, and replaced them with
33740 `public readonly' fields.
33742 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33744 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33745 initialize their hashtables/arraylists only when they are needed
33746 instead of doing this always.
33748 * parameter.cs: Handle refs and out parameters.
33750 * cs-parser.jay: Use an ArrayList to construct the arguments
33751 instead of the ParameterCollection, and then cast that to a
33754 * parameter.cs: Drop the use of ParameterCollection and use
33755 instead arrays of Parameters.
33757 (GetParameterInfo): Use the Type, not the Name when resolving
33760 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33762 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33763 and instead use public readonly fields.
33765 * class.cs: Put back walking code for type containers.
33767 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33769 * class.cs (MakeConstant): Code to define constants.
33771 * rootcontext.cs (LookupType): New function. Used to locate types
33774 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33776 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33777 this System.Reflection code is. Kudos to Microsoft
33779 * typemanager.cs: Implement a type cache and avoid loading all
33780 types at boot time. Wrap in LookupType the internals. This made
33781 the compiler so much faster. Wow. I rule!
33783 * driver.cs: Make sure we always load mscorlib first (for
33784 debugging purposes, nothing really important).
33786 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33787 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33789 * rootcontext.cs: Lookup types on their namespace; Lookup types
33790 on namespaces that have been imported using the `using' keyword.
33792 * class.cs (TypeContainer::TypeAttr): Virtualize.
33793 (Class::TypeAttr): Return attributes suitable for this bad boy.
33794 (Struct::TypeAttr): ditto.
33795 Handle nested classes.
33796 (TypeContainer::) Remove all the type visiting code, it is now
33797 replaced with the rootcontext.cs code
33799 * rootcontext.cs (GetClassBases): Added support for structs.
33801 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33803 * interface.cs, statement.cs, class.cs, parameter.cs,
33804 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33805 Drop use of TypeRefs, and use strings instead.
33807 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33811 * class.cs (Struct::Struct): set the SEALED flags after
33812 checking the modifiers.
33813 (TypeContainer::TypeAttr): new property, returns the
33814 TypeAttributes for a class.
33816 * cs-parser.jay (type_list): Oops, list production was creating a
33817 new list of base types.
33819 * rootcontext.cs (StdLib): New property.
33820 (GetInterfaceTypeByName): returns an interface by type name, and
33821 encapsulates error handling here.
33822 (GetInterfaces): simplified.
33823 (ResolveTree): Encapsulated all the tree resolution here.
33824 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33827 * driver.cs: Add support for --nostdlib, to avoid loading the
33828 default assemblies.
33829 (Main): Do not put tree resolution here.
33831 * rootcontext.cs: Beginning of the class resolution.
33833 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33835 * rootcontext.cs: Provide better error reporting.
33837 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33839 * rootcontext.cs (CreateInterface): Handle the case where there
33840 are no parent interfaces.
33842 (CloseTypes): Routine to flush types at the end.
33843 (CreateInterface): Track types.
33844 (GetInterfaces): Returns an array of Types from the list of
33845 defined interfaces.
33847 * typemanager.c (AddUserType): Mechanism to track user types (puts
33848 the type on the global type hash, and allows us to close it at the
33851 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33853 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33854 RecordInterface instead.
33856 * cs-parser.jay: Updated to reflect changes above.
33858 * decl.cs (Definition): Keep track of the TypeBuilder type that
33859 represents this type here. Not sure we will use it in the long
33860 run, but wont hurt for now.
33862 * driver.cs: Smaller changes to accomodate the new code.
33864 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33867 * rootcontext.cs (CreateInterface): New method, used to create
33868 the System.TypeBuilder type for interfaces.
33869 (ResolveInterfaces): new entry point to resolve the interface
33871 (CodeGen): Property, used to keep track of the code generator.
33873 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33875 * cs-parser.jay: Add a second production for delegate_declaration
33878 (enum_body): Put an opt_comma here instead of putting it on
33879 enum_body or enum_member_declarations so we can handle trailing
33880 commas on enumeration members. Gets rid of a shift/reduce.
33882 (type_list): Need a COMMA in the middle.
33884 (indexer_declaration): Tell tokenizer to recognize get/set
33886 * Remove old targets.
33888 * Re-add the parser target.
33890 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33892 * cs-parser.jay: Add precendence rules for a number of operators
33893 ot reduce the number of shift/reduce conflicts in the grammar.
33895 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33897 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33900 Get rid of old crufty code.
33902 * rootcontext.cs: Use this to keep track of the parsed
33903 representation and the defined types available to the program.
33905 * gen-treedump.cs: adjust for new convention.
33907 * type.cs: Split out the type manager, and the assembly builder
33910 * typemanager.cs: the type manager will live here now.
33912 * cil-codegen.cs: And the code generator here.
33914 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33916 * makefile: Fixed up for easy making.
33918 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33920 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33923 (unary_expression): Expand pre_increment_expression and
33924 post_decrement_expression to reduce a shift/reduce.
33926 2001-07-11 Simon Cozens
33928 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33930 Improve allow_keyword_as_indent name.
33932 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33934 * Adjustments for Beta2.
33936 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33938 * decl.cs: Added `Define' abstract method.
33939 (InTransit): new property, used to catch recursive definitions.
33941 * interface.cs: Implement `Define'.
33943 * modifiers.cs: Map Modifiers.constants to
33944 System.Reflection.TypeAttribute flags.
33946 * class.cs: Keep track of types and user-defined types.
33947 (BuilderInit): New method for creating an assembly
33948 (ResolveType): New function to launch the resolution process, only
33949 used by interfaces for now.
33951 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33952 that are inserted into the name space.
33954 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33956 * ARGH. I have screwed up my tree so many times due to the use of
33957 rsync rather than using CVS. Going to fix this at once.
33959 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33962 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33964 * Experiment successful: Use System.Type rather that our own
33967 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33969 * cs-parser.jay: Removed nsAliases from here.
33971 Use new namespaces, handle `using XXX;'
33973 * namespace.cs: Reimplemented namespace handling, use a recursive
33974 definition of the class. Now we can keep track of using clauses
33975 and catch invalid using clauses.
33977 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33979 * gen-treedump.cs: Adapted for all the renaming.
33981 * expression.cs (Expression): this class now has a Type property
33982 which returns an expression Type.
33984 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33985 `Type', as this has a different meaning now in the base
33987 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33989 * interface.cs, class.cs: Removed from all the sources the
33990 references to signature computation, as we can not do method
33991 signature computation during the parsing time, as we are not
33992 trying to solve at that point distinguishing:
33996 void a (NS.Blah x) {}
33999 Which depending on the context might be valid or not, as we do not
34000 know if Blah is the same thing as NS.Blah at that point.
34002 * Redid everything so the code uses TypeRefs now instead of
34003 Types. TypeRefs are just temporary type placeholders, that need
34004 to be resolved. They initially have a pointer to a string and the
34005 current scope in which they are used. This is used later by the
34006 compiler to resolve the reference to an actual Type.
34008 * DeclSpace is no longer a CIR.Type, and neither are
34009 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
34010 are all DeclSpaces, but no Types.
34012 * type.cs (TypeRefManager): This implements the TypeRef manager,
34013 which keeps track of all the types that need to be resolved after
34014 the parsing has finished.
34016 2001-05-13 Miguel de Icaza <miguel@ximian.com>
34018 * ARGH. We are going to have to store `foreach' as a class rather
34019 than resolving it, as we need to verify error 1579 after name
34020 resolution. *OR* we could keep a flag that says `This request to
34021 IEnumerator comes from a foreach statement' which we can then use
34022 to generate the error.
34024 2001-05-10 Miguel de Icaza <miguel@ximian.com>
34026 * class.cs (TypeContainer.AddMethod): we now add methods to the
34027 MethodGroup instead of the method hashtable.
34029 * expression.cs: Add MethodGroup abstraction, which gets us one
34030 step closer to the specification in the way we handle method
34033 * cs-parser.jay (primary_expression): qualified_identifier now
34034 tried to match up an identifier to a local variable reference or
34035 to a parameter reference.
34037 current_local_parameters is now a parser global variable that
34038 points to the current parameters for the block, used during name
34041 (property_declaration): Now creates an implicit `value' argument to
34044 2001-05-09 Miguel de Icaza <miguel@ximian.com>
34046 * parameter.cs: Do not use `param' arguments as part of the
34047 signature, per the spec.
34049 2001-05-08 Miguel de Icaza <miguel@ximian.com>
34051 * decl.cs: Base class for classes, structs and interfaces. This
34052 is the "Declaration Space"
34054 * cs-parser.jay: Use CheckDef for checking declaration errors
34055 instead of having one on each function.
34057 * class.cs: Factor out some code for handling error handling in
34058 accordance to the "Declarations" section in the "Basic Concepts"
34059 chapter in the ECMA C# spec.
34061 * interface.cs: Make all interface member classes derive from
34062 InterfaceMemberBase.
34064 2001-05-07 Miguel de Icaza <miguel@ximian.com>
34066 * Many things: all interfaces are parsed and generated in
34067 gen-treedump. Support for member variables, constructors,
34068 destructors, properties, constants is there.
34070 Beginning of the IL backend, but very little done, just there for
34073 2001-04-29 Miguel de Icaza <miguel@ximian.com>
34075 * cs-parser.jay: Fix labeled statement.
34077 * cs-tokenizer.cs (escape): Escape " and ' always.
34078 ref_line, ref_name: keep track of the line/filename as instructed
34079 by #line by the compiler.
34082 2001-04-27 Miguel de Icaza <miguel@ximian.com>
34084 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
34085 to match the values in System.CodeDOM.
34087 Divid renamed to Divide.
34089 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
34091 (Statements.set): remove.
34093 * System.CodeDOM/CodeCatchClause.cs: always have a valid
34096 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
34097 falseStatements always have valid values.
34099 * cs-parser.jay: Use System.CodeDOM now.