More explicite and straight way to set seed.
authorZheng Bao <zheng.bao@amd.com>
Thu, 2 Dec 2010 01:50:38 +0000 (01:50 +0000)
committerZheng Bao <Zheng.Bao@amd.com>
Thu, 2 Dec 2010 01:50:38 +0000 (01:50 +0000)
The read-modify-write wasn't needed. This is easier to understand.

Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Acked-by: Marc Jones <marcj303@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6136 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

src/northbridge/amd/amdmct/mct/mctsrc.c
src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c

index 258be0468d22568e62711db1357f6d2ce08fbdaa..6a0ae306b37d0a4aab312516eab95863a2c44762 100644 (file)
@@ -1023,13 +1023,9 @@ static void fenceDynTraining_D(struct MCTStatStruc *pMCTstat,
 
        dev = pDCTstat->dev_dct;
        for (index = 0x50; index <= 0x52; index ++) {
-               val = Get_NB32_index_wait(dev, index_reg, index);
-               val |= (FenceTrnFinDlySeed & 0x1F);
+               val = (FenceTrnFinDlySeed & 0x1F);
                if (index != 0x52) {
-                       val &= ~(0xFF << 8);
-                       val |= (val & 0xFF) << 8;
-                       val &= 0xFFFF;
-                       val |= val << 16;
+                       val |= val << 8 | val << 16 | val << 24;
                }
                Set_NB32_index_wait(dev, index_reg, index, val);
        }
index b11da611564c0c85fc5d2d456137e9b56160cc88..76ddb88d53bb2a6b8a6811ab931ed3397d501831 100644 (file)
@@ -972,13 +972,9 @@ static void fenceDynTraining_D(struct MCTStatStruc *pMCTstat,
         */
        dev = pDCTstat->dev_dct;
        for (index = 0x50; index <= 0x52; index ++) {
-               val = Get_NB32_index_wait(dev, index_reg, index) & ~0xFF;
-               val |= (FenceTrnFinDlySeed & 0x1F);
+               val = (FenceTrnFinDlySeed & 0x1F);
                if (index != 0x52) {
-                       val &= ~(0xFF << 8);
-                       val |= (val & 0xFF) << 8;
-                       val &= 0xFFFF;
-                       val |= val << 16;
+                       val |= val << 8 | val << 16 | val << 24;
                }
                Set_NB32_index_wait(dev, index_reg, index, val);
        }