Trivial, cleanup of GPIO comments.
authorRudolf Marek <r.marek@assembler.cz>
Sun, 16 Jan 2011 16:23:51 +0000 (16:23 +0000)
committerRudolf Marek <r.marek@assembler.cz>
Sun, 16 Jan 2011 16:23:51 +0000 (16:23 +0000)
Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Rudolf Marek <r.marek@assembler.cz>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6256 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

src/mainboard/asrock/939a785gmh/romstage.c

index 76b8b510b9853544ab142bda71fd40282434ff3a..c5f3a8b196eafc5f0e01c0697999e40a8de39be8 100644 (file)
@@ -78,7 +78,7 @@ static void sio_init(void)
        pnp_enter_ext_func_mode(GPIO2345_DEV);
        pnp_set_logical_device(GPIO2345_DEV);
 
-       /* Pin 119 ~ 120 GP21, GP20  */
+       /* Pin 119 ~ 120 is GP21, GP20  */
        reg = pnp_read_config(GPIO2345_DEV, 0x29);
        pnp_write_config(GPIO2345_DEV, 0x29, (reg | 2));
 
@@ -90,28 +90,39 @@ static void sio_init(void)
        pnp_write_config(GPIO2345_DEV, 0x2c, 0x1);
        pnp_write_config(GPIO2345_DEV, 0x2d, 0x1);
 
-//idx 30 e0 e1 e2 e3 e4 e5 e6  e7 e8 e9 f0 f1 f2 f3 f4  f5 f6 f7 fe
-//val 07 XX XX XX f6 0e 00 00  00 00 ff d6 96 00 40 d0  83 00 00 07
-
-//GPO20 - 1 = 1.82 0 = 1.92 sideport voltage
-//mGPUV GPO40 | GPO41 | GPIO23 - 000 - 1.45V step 0.05 -- 111 - 1.10V
-//DDR voltage 44 45 46
-
-       /* GPO20 - sideport voltage GPO23 - mgpuV */
+       /* GPO20 - sideport voltage 1 = 1.82 0 = 1.92
+          GPI21 - unknown input (NC?)
+          GPI22 - unknown input (NC?)
+          GPO23 - mgpuV bit0
+          GP24-27 - PS/2 mouse/keyb (only keyb is connected use flip interface for mouse)*/
+       */
        pnp_write_config(GPIO2345_DEV, 0x30, 0x07);     /* Enable GPIO 2,3,4. */
        pnp_write_config(GPIO2345_DEV, 0xe3, 0xf6);     /* dir of GPIO2 11110110*/
        pnp_write_config(GPIO2345_DEV, 0xe4, 0x0e);     /* data */
        pnp_write_config(GPIO2345_DEV, 0xe5, 0x00);     /* No inversion */
 
-       /* GPO30 GPO33 GPO35 */
-       //GPO35 - loadline control 0 - enabled
-       //GPIO30 - unknown
-       //GPIO33 - unknown
+       /* GPIO30 - unknown output, set to 0 
+          GPI31 - unknown input NC?
+          GPI32 - unknown input NC?
+          GPIO33 - unknown output, set to 0.
+          GPI34 - unknown input NC?
+          GPO35 - loadline control 1 = enabled (2 phase clock) 0 = disabled 4 phase clock
+          GPIO36 - input = HT voltage 1.30V output (low) = HT voltage 1.35V
+          GP37 - unknown input NC? */
+
        pnp_write_config(GPIO2345_DEV, 0xf0, 0xd6);     /* dir of GPIO3 11010110*/
        pnp_write_config(GPIO2345_DEV, 0xf1, 0x96);     /* data */
        pnp_write_config(GPIO2345_DEV, 0xf2, 0x00);     /* No inversion */
 
-       /* GPO40 GPO41 GPO42 GPO43 PO45 */
+       /* GPO40 - mgpuV bit2
+          GPO41 - mgpuV bit1
+          GPO42  - IRTX
+          GPO43  - IRRX
+          GPIO44 - memory voltage bit2 (input/outputlow)
+          GPIO45 - memory voltage bit1 (2.60 (000) - 2.95 (111))
+          GPIO46 - memory voltage bit0
+          GPIO47 - unknown input? */
+
        pnp_write_config(GPIO2345_DEV, 0xf4, 0xd0);     /* dir of GPIO4 11010000 */
        pnp_write_config(GPIO2345_DEV, 0xf5, 0x83);     /* data */
        pnp_write_config(GPIO2345_DEV, 0xf6, 0x00);     /* No inversion */