move function from header file to .c file

http://review.coreboot.org/#change,378 introduced a function in k8x8xx.h
move this function to ctrl.c and add a prototype to the header file instead.

Change-Id: I0919ffb2030c53669b95f58b649d4a160f660923
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/429
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>

diff --git a/src/southbridge/via/k8t890/ctrl.c b/src/southbridge/via/k8t890/ctrl.c
index d68e03e5f0856ea5cd07ae76a71d0c4686906d46..3180412b90fbfe70be3666cdf7cfbe2d6672311d 100644 (file)
--- a/src/southbridge/via/k8t890/ctrl.c
+++ b/src/southbridge/via/k8t890/ctrl.c
@@ -25,6 +25,20 @@
 #include <console/console.h>
 #include "k8x8xx.h"
 
+void k8x8xx_vt8237_mirrored_regs_fill(struct k8x8xx_vt8237_mirrored_regs *regs)
+{
+       msr_t msr;
+
+       regs->rom_shadow_ctrl_pg_c = 0xff;
+       regs->rom_shadow_ctrl_pg_d = 0xff;
+       regs->rom_shadow_ctrl_pg_e_memhole_smi_decoding = 0xff;
+       regs->rom_shadow_ctrl_pg_f_memhole = 0x30;
+       regs->smm_apic_decoding = 0x19;
+       msr = rdmsr(TOP_MEM);
+       regs->shadow_mem_ctrl = msr.lo >> 24;
+       regs->low_top_address = msr.lo >> 16;
+}
+
 /* We support here K8M890/K8T890 and VT8237R PCI1/Vlink which setup is not in separate
  * PCI device 0:11.7, but it is mapped to PCI 0:0.7 (0x70-0x7c for PCI1)
  */

diff --git a/src/southbridge/via/k8t890/k8x8xx.h b/src/southbridge/via/k8t890/k8x8xx.h
index c61c98426bbaf4b38b9ddc099a3e80940dc6e639..908940a2f9b09e67b9bf4b8a6517811f698f1812 100644 (file)
--- a/src/southbridge/via/k8t890/k8x8xx.h
+++ b/src/southbridge/via/k8t890/k8x8xx.h
@@ -28,6 +28,7 @@
 #endif
 #include "k8t890.h"
 
+#ifndef __PRE_RAM__
 struct k8x8xx_vt8237_mirrored_regs {
        u16 low_top_address;
        u8 rom_shadow_ctrl_pg_c,
@@ -38,20 +39,7 @@ struct k8x8xx_vt8237_mirrored_regs {
                shadow_mem_ctrl;
 };
 
-static inline void k8x8xx_vt8237_mirrored_regs_fill(struct k8x8xx_vt8237_mirrored_regs *regs){
-       msr_t msr;
-
-       regs->rom_shadow_ctrl_pg_c = 0xff;
-       regs->rom_shadow_ctrl_pg_d = 0xff;
-       regs->rom_shadow_ctrl_pg_e_memhole_smi_decoding = 0xff;
-       regs->rom_shadow_ctrl_pg_f_memhole = 0x30;
-       regs->smm_apic_decoding = 0x19;
-       msr = rdmsr(TOP_MEM);
-       regs->shadow_mem_ctrl = msr.lo >> 24;
-       regs->low_top_address = msr.lo >> 16;
-}
-
-#ifndef __PRE_RAM__
+void k8x8xx_vt8237_mirrored_regs_fill(struct k8x8xx_vt8237_mirrored_regs *regs);
 void k8x8xx_vt8237r_cfg(struct device *, struct device *);
 #endif