i82830: fix debugging output and clarify bracketing
authorStefan Reinauer <stepan@coresystems.de>
Sun, 9 May 2010 15:15:08 +0000 (15:15 +0000)
committerStefan Reinauer <stepan@openbios.org>
Sun, 9 May 2010 15:15:08 +0000 (15:15 +0000)
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5536 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

src/northbridge/intel/i82830/i82830_smihandler.c

index c9c7bcb27fc27fe946611bb0272234ad233ac18f..f20b099e9ce9f84d8489066c461e6739204a487c 100644 (file)
@@ -258,11 +258,11 @@ static void mbi_call(u8 subf, banner_id_t *banner_id)
                        if (getobj->objnum == count) {
                                printk(BIOS_DEBUG, "|  |- len = %x\n", len);
                                memcpy((void *)(getobj->buffer + OBJ_OFFSET),
-                                               ((char *)mbi_header) + 0x20 , (len > getobj->buflen ? getobj->buflen : len));
+                                               ((char *)mbi_header) + 0x20 , (len > getobj->buflen) ? getobj->buflen : len);
 
                                getobj->banner.retsts = MSH_OK;
 #ifdef DEBUG_SMI_I82830
-                               dump(banner_id, sizeof(getobj));
+                               dump(banner_id, sizeof(*getobj));
                                dump(getobj->buffer + OBJ_OFFSET, len);
 #endif
                                break;