Fix an uninitialized variable. If it didn't end up being zero it sometimes
authorMyles Watson <mylesgw@gmail.com>
Thu, 23 Apr 2009 18:46:32 +0000 (18:46 +0000)
committerMyles Watson <mylesgw@gmail.com>
Thu, 23 Apr 2009 18:46:32 +0000 (18:46 +0000)
caused a seg fault, sometimes executed somewhere else.  Also add an error if
the algorithm is unknown.

Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Ward Vandewege <ward@gnu.org>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4198 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

util/cbfstool/tools/cbfs-mkpayload.c

index 9b3946a926a6eb8609fec6d324def52d660b7834..7db48cfa8b3e6d77f8ffb6fdd295a18b75fdb059 100644 (file)
@@ -191,7 +191,7 @@ err:
 int main(int argc, char **argv)
 {
        void (*compress) (char *, int, char *, int *);
-       int algo;
+       int algo = CBFS_COMPRESS_NONE;
 
        char *output = NULL;
        char *input = NULL;
@@ -251,6 +251,9 @@ int main(int argc, char **argv)
        case CBFS_COMPRESS_LZMA:
                compress = lzma_compress;
                break;
+       default:
+               fprintf(stderr, "E: Unknown compression algorithm %d!\n", algo);
+               return -1;
        }
 
        osize = parse_elf(buffer, &obuffer, algo, compress);