mono.git
13 years agoAMD64 version of the new mono.simd ops
Rodrigo Kumpera [Fri, 7 Jan 2011 00:19:03 +0000 (00:19 +0000)]
AMD64 version of the new mono.simd ops

13 years agoremove stupid debug spew
Rodrigo Kumpera [Thu, 6 Jan 2011 21:01:55 +0000 (22:01 +0100)]
remove stupid debug spew

13 years agoRevert
Gonzalo Paniagua Javier [Thu, 6 Jan 2011 21:02:43 +0000 (16:02 -0500)]
Revert

13 years ago[windows] Improve drive search
Gonzalo Paniagua Javier [Thu, 6 Jan 2011 20:52:54 +0000 (15:52 -0500)]
[windows] Improve drive search

Windows allows "A", "A:", @"a:\"... as synonyms for the same drive.
Patch by Vincent Povirk that fixes bug #660911.

13 years agoImplement Shuffle for 64bits types.
Rodrigo Kumpera [Thu, 6 Jan 2011 20:36:31 +0000 (21:36 +0100)]
Implement Shuffle for 64bits types.

* x86-codegen.h: Add macro and define to emit pshufpd.

* mini-ops.h: Add OP_SHUPD.

* cpu-x86.md:
* mini-x86.h: Implement x86 support.

* simd-intrinsics.c: Handle shuffle on 64bit types.

* VectorOperations.cs: Add new methods.

13 years agoImplement Shuffle/3
Rodrigo Kumpera [Thu, 6 Jan 2011 18:31:04 +0000 (19:31 +0100)]
Implement Shuffle/3

13 years agoImplement runtime support (x86 only) for 3 args Shuffle.
Rodrigo Kumpera [Thu, 6 Jan 2011 17:45:03 +0000 (18:45 +0100)]
Implement runtime support (x86 only) for 3 args Shuffle.

* cpu-x86.md: Add shufps.

* mini-ops.h: Add OP_SHUFPS.

* mini-x86.c (mono_arch_output_basic_block): Emit
OP_SHUFPS.

* simd-intrinsics.c (simd_intrinsic_emit_shuffle): Handle
3 args variant.

13 years agoAdd SHUFPS and macro to emit it.
Rodrigo Kumpera [Thu, 6 Jan 2011 17:43:59 +0000 (18:43 +0100)]
Add SHUFPS and macro to emit it.

13 years agoAdd test for call clobbering of XMM regs
Rodrigo Kumpera [Thu, 6 Jan 2011 17:42:00 +0000 (18:42 +0100)]
Add test for call clobbering of XMM regs

13 years agoProperly free xmm hregs.
Rodrigo Kumpera [Thu, 6 Jan 2011 17:38:13 +0000 (18:38 +0100)]
Properly free xmm hregs.

* mini-codegen.c (free_up_hreg): Use the bank argument instead of
a hardcoded one.

13 years ago[Windows] Implement GetDrives.
Gonzalo Paniagua Javier [Thu, 6 Jan 2011 20:42:52 +0000 (15:42 -0500)]
[Windows] Implement GetDrives.

Drive names are ok, but the type is always 'Fixed'.
Fixes bug #660907.

13 years agoRe-enable and fix the nacl changes.
Zoltan Varga [Thu, 6 Jan 2011 19:29:02 +0000 (20:29 +0100)]
Re-enable and fix the nacl changes.

13 years agoPut back a macro definition accidently removed by the nacl changes.
Zoltan Varga [Thu, 6 Jan 2011 18:35:45 +0000 (19:35 +0100)]
Put back a macro definition accidently removed by the nacl changes.

13 years agoFix .NET 4 API
Jérémie Laval [Thu, 6 Jan 2011 16:08:31 +0000 (16:08 +0000)]
Fix .NET 4 API

13 years agoAdd missing Debugger and ReliabilityContract attributes to .NET 4 types
Jérémie Laval [Thu, 6 Jan 2011 16:07:48 +0000 (16:07 +0000)]
Add missing Debugger and ReliabilityContract attributes to .NET 4 types

13 years agoAvoid random failure in CountdownEvent unit test
Jérémie Laval [Thu, 6 Jan 2011 15:16:35 +0000 (15:16 +0000)]
Avoid random failure in CountdownEvent unit test

13 years agoFail nice if the current profiler doesn't support ICustomMarshaler.
Rodrigo Kumpera [Thu, 6 Jan 2011 14:51:15 +0000 (15:51 +0100)]
Fail nice if the current profiler doesn't support ICustomMarshaler.

* marshal.c (emit_marshal_custom): If the lookup for ICustomMarshaler
fails, emit code to raise an exception instead of asserting.

Fixes #560334

13 years agoUse while loop instead of if for removing as much stalled tickets as possible
Jérémie Laval [Thu, 6 Jan 2011 14:43:12 +0000 (14:43 +0000)]
Use while loop instead of if for removing as much stalled tickets as possible

13 years agoFix comments
Jérémie Laval [Thu, 6 Jan 2011 14:42:26 +0000 (14:42 +0000)]
Fix comments

13 years agoProtect SpinLock's Enter method against asynchronous exception
Jérémie Laval [Thu, 6 Jan 2011 14:37:17 +0000 (14:37 +0000)]
Protect SpinLock's Enter method against asynchronous exception

13 years agoCheck if the method signature has type parameters when it shouldn't.
Rodrigo Kumpera [Thu, 6 Jan 2011 14:28:17 +0000 (15:28 +0100)]
Check if the method signature has type parameters when it shouldn't.

* verify.c (mono_method_verify): If neither the method or
its class is generic a signature can't have type parametets.

Fixes #662238

13 years ago Change some usages of ArrayList to List<T> to avoid calls to the slow ArrayList...
Zoltan Varga [Thu, 6 Jan 2011 12:17:01 +0000 (13:17 +0100)]
 Change some usages of ArrayList to List<T> to avoid calls to the slow ArrayList.ToArray(Type) method.

13 years agoFix x86 build.
Zoltan Varga [Thu, 6 Jan 2011 12:11:33 +0000 (13:11 +0100)]
Fix x86 build.

13 years agoChange some usages of ArrayList to List<T> to avoid calls to the slow ArrayList.ToArr...
Zoltan Varga [Thu, 6 Jan 2011 11:56:28 +0000 (12:56 +0100)]
Change some usages of ArrayList to List<T> to avoid calls to the slow ArrayList.ToArray(Type) method.

13 years agoAdd unit test for nested Parallel.For execution
Jérémie Laval [Thu, 6 Jan 2011 11:57:38 +0000 (11:57 +0000)]
Add unit test for nested Parallel.For execution

13 years agoExplicitely attach loop underlying tasks to their eventual parent
Jérémie Laval [Thu, 6 Jan 2011 11:24:52 +0000 (11:24 +0000)]
Explicitely attach loop underlying tasks to their eventual parent

13 years agoUse wider acceptance criteria to cope with nested child Task waiting and external...
Jérémie Laval [Thu, 6 Jan 2011 11:23:40 +0000 (11:23 +0000)]
Use wider acceptance criteria to cope with nested child Task waiting and external task waiting

13 years agoRevert a nacl change which is causing crashes.
Zoltan Varga [Thu, 6 Jan 2011 11:42:09 +0000 (12:42 +0100)]
Revert a nacl change which is causing crashes.

13 years agoFix warnings introduced by the NACL merge.
Zoltan Varga [Thu, 6 Jan 2011 10:49:32 +0000 (11:49 +0100)]
Fix warnings introduced by the NACL merge.

13 years agoMerge remote branch 'google-nacl/master'
Zoltan Varga [Thu, 6 Jan 2011 10:33:54 +0000 (11:33 +0100)]
Merge remote branch 'google-nacl/master'

13 years ago[xml] Out of range errors should be swallowed when doing string -> datetime conversion
Marek Habersack [Thu, 6 Jan 2011 09:36:32 +0000 (10:36 +0100)]
[xml] Out of range errors should be swallowed when doing string -> datetime conversion

13 years agoTests update
Marek Safar [Thu, 6 Jan 2011 09:20:14 +0000 (09:20 +0000)]
Tests update

13 years agoMore global state hacking
Marek Safar [Thu, 6 Jan 2011 09:17:27 +0000 (09:17 +0000)]
More global state hacking

13 years agoRemove #if NET_2_0 flags.
Thomas Goldstein [Thu, 6 Jan 2011 07:13:33 +0000 (23:13 -0800)]
Remove #if NET_2_0 flags.

13 years agoBump winconfig version
Geoff Norton [Thu, 6 Jan 2011 02:31:23 +0000 (21:31 -0500)]
Bump winconfig version

13 years agoFix an uninitialized memory error in the aot compiler.
Zoltan Varga [Thu, 6 Jan 2011 00:56:56 +0000 (01:56 +0100)]
Fix an uninitialized memory error in the aot compiler.

13 years agoMerge remote branch 'upstream/master'
Elijah Taylor [Thu, 6 Jan 2011 00:02:57 +0000 (16:02 -0800)]
Merge remote branch 'upstream/master'

13 years ago[sockets] Fixed reading blocking flag
Gonzalo Paniagua Javier [Wed, 5 Jan 2011 18:34:32 +0000 (13:34 -0500)]
[sockets] Fixed reading blocking flag

Calling ioctlsocket() would set the flag...
Thanks to Thad Thompson for finding this.

13 years ago[sgen] Always use the GC descriptor instead of MonoClass.has_references.
Mark Probst [Wed, 5 Jan 2011 17:12:45 +0000 (18:12 +0100)]
[sgen] Always use the GC descriptor instead of MonoClass.has_references.

has_references can be set even though the class has no references
registered by the GC.  One case is Ephemeron.  Now we always go by the
GC descriptor which holds the information relevant to SGen.

This fixes a crash in the 4.0 corlib testsuite.

13 years agoEnsure task wait chain isn't executed out of order in scheduler
Jérémie Laval [Wed, 5 Jan 2011 15:27:02 +0000 (15:27 +0000)]
Ensure task wait chain isn't executed out of order in scheduler

13 years ago[662440] Don't expand nested type builders of non-generic types
Marek Safar [Wed, 5 Jan 2011 15:44:02 +0000 (15:44 +0000)]
[662440] Don't expand nested type builders of non-generic types

13 years agoHandle the case when the parent fails to inflate.
Rodrigo Kumpera [Wed, 5 Jan 2011 15:43:15 +0000 (16:43 +0100)]
Handle the case when the parent fails to inflate.

* class.c (mono_generic_class_get_class): Use the checked
version of mono_class_inflate_generic_class to avoid
aborting on error.

Fixes #560327

13 years agoAdd missing files to dist.
Zoltan Varga [Wed, 5 Jan 2011 15:12:49 +0000 (16:12 +0100)]
Add missing files to dist.

13 years agoDon't assert in mono_get_lmf() if there is no LMF.
Mark Probst [Wed, 5 Jan 2011 14:39:46 +0000 (15:39 +0100)]
Don't assert in mono_get_lmf() if there is no LMF.

This function is called from mini-gc.c when a collection is triggered,
which can happen before any managed call is executed by the thread.
At least the allocation of the thread object happens in unmanaged code.

13 years agoFixed WinFormsTest System.Drawing namespace reference
Marek Safar [Wed, 5 Jan 2011 13:32:05 +0000 (13:32 +0000)]
Fixed WinFormsTest System.Drawing namespace reference

13 years agoReplace SIZEOF_REGISTER with sizeof(mgreg_t) for consistency with sizeof(gpointer)
Elijah Taylor [Wed, 5 Jan 2011 00:25:42 +0000 (16:25 -0800)]
Replace SIZEOF_REGISTER with sizeof(mgreg_t) for consistency with sizeof(gpointer)

13 years agomore ilp32 defines
Elijah Taylor [Tue, 4 Jan 2011 23:44:00 +0000 (15:44 -0800)]
more ilp32 defines

13 years agochange first batch of __native_client_codegen__ && TARGET_AMD64 to __mono_ilp32__...
Elijah Taylor [Tue, 4 Jan 2011 22:38:57 +0000 (14:38 -0800)]
change first batch of __native_client_codegen__ && TARGET_AMD64 to __mono_ilp32__ where appropriate

13 years agofix IMT_REG assignments that got switched for non-nacl builds, provide no-op versions...
Elijah Taylor [Tue, 4 Jan 2011 21:12:00 +0000 (13:12 -0800)]
fix IMT_REG assignments that got switched for non-nacl builds, provide no-op versions of nacl routines to avoid #ifdef's all over

13 years agoFix win32 build
Rodrigo Kumpera [Tue, 4 Jan 2011 18:23:43 +0000 (02:23 +0800)]
Fix win32 build

13 years agoAdd mcs solution file
Marek Safar [Wed, 5 Jan 2011 10:39:01 +0000 (10:39 +0000)]
Add mcs solution file

13 years agoFix operator != handling of LHS null
Rodrigo Kumpera [Tue, 4 Jan 2011 16:10:20 +0000 (00:10 +0800)]
Fix operator != handling of LHS null

13 years agoFix test suite as boehm doesn't support ephemerons
Rodrigo Kumpera [Tue, 4 Jan 2011 16:00:15 +0000 (00:00 +0800)]
Fix test suite as boehm doesn't support ephemerons

13 years ago[runtime] Include the al script in temporary installation directory
Marek Habersack [Wed, 5 Jan 2011 11:04:17 +0000 (12:04 +0100)]
[runtime] Include the al script in temporary installation directory

This is needed as the 4.0 profile calls 'al' (which is defaults to 4.0) and not
'al2' and if Mono older than 2.8 is installed on the machine, 'al' coming from it
will fail to work with the current Mono and thus some tests will fail.

The commit should fix the 300+ failing tests on the build bots.

13 years ago[asp.net] Disabled a racy test
Marek Habersack [Wed, 5 Jan 2011 10:35:50 +0000 (11:35 +0100)]
[asp.net] Disabled a racy test

13 years agoUnify naming convention for all 2.0 files
Marek Safar [Wed, 5 Jan 2011 10:34:59 +0000 (10:34 +0000)]
Unify naming convention for all 2.0 files

13 years agoFix invalid test constraint
Marek Safar [Wed, 5 Jan 2011 10:29:54 +0000 (10:29 +0000)]
Fix invalid test constraint

13 years agoAdd missing Accessibility reference
Marek Safar [Wed, 5 Jan 2011 10:03:51 +0000 (10:03 +0000)]
Add missing Accessibility reference

13 years agoBuild mcs before docs
Marek Safar [Wed, 5 Jan 2011 09:53:43 +0000 (09:53 +0000)]
Build mcs before docs

13 years ago[asp.net] Rewrote CacheItemPriorityQueue tests generator to produce simpler test...
Marek Habersack [Wed, 5 Jan 2011 09:27:50 +0000 (10:27 +0100)]
[asp.net] Rewrote CacheItemPriorityQueue tests generator to produce simpler test case.

The new test case uses arrays and postpones creation of CacheItemPriorityQueueTestItem and TestCacheItem
instances till the actual test is ran. This reduces complexity of the CacheItemPrioritQueueTest class
constructor and allows the code to run successfully on 32 bit machines.

13 years agoFix ToDateTime() with serialization mode to not mess hour based on timezone.
Atsushi Eno [Wed, 5 Jan 2011 08:00:58 +0000 (17:00 +0900)]
Fix ToDateTime() with serialization mode to not mess hour based on timezone.

Fixed bug #661787.

13 years agoSet build-in types modifiers
Marek Safar [Tue, 4 Jan 2011 22:31:34 +0000 (22:31 +0000)]
Set build-in types modifiers

13 years agoNew test
Marek Safar [Tue, 4 Jan 2011 21:47:58 +0000 (21:47 +0000)]
New test

13 years agoAssemblyPath support, patch by Michel Faucault.
Atsushi Eno [Wed, 5 Jan 2011 07:17:20 +0000 (16:17 +0900)]
AssemblyPath support, patch by Michel Faucault.

13 years ago[xbuild] Fix failing test in msbuild.tasks .
Ankit Jain [Wed, 5 Jan 2011 00:44:20 +0000 (06:14 +0530)]
[xbuild] Fix failing test in msbuild.tasks .

13 years ago[xbuild] Fix bug #662355.
Ankit Jain [Wed, 5 Jan 2011 00:39:48 +0000 (06:09 +0530)]
[xbuild] Fix bug #662355.

Support reference aliases in Csc task.

13 years agoMake test messages more usefull
Rodrigo Kumpera [Tue, 4 Jan 2011 03:12:33 +0000 (11:12 +0800)]
Make test messages more usefull

13 years agoFix guard interrupt protection.
Rodrigo Kumpera [Tue, 4 Jan 2011 02:56:39 +0000 (10:56 +0800)]
Fix guard interrupt protection.

* mini.h: Introduce a new MonoContext variable to be used
by the interrupt protection code.

* mini-exceptions.c: Use new field.

* mini-trampolines.c: Ditto.

This fixes finally_guard.exe on OSX.

13 years agoFix alignment of the block guard trampoline.
Rodrigo Kumpera [Tue, 4 Jan 2011 02:55:05 +0000 (10:55 +0800)]
Fix alignment of the block guard trampoline.

* tramp-x86.c (mono_arch_create_handler_block_trampoline): Make
sure we call the target with a properly aligned frame.

13 years agoEliminate the first PLT entry, it is no longer used.
Zoltan Varga [Tue, 4 Jan 2011 21:07:39 +0000 (22:07 +0100)]
Eliminate the first PLT entry, it is no longer used.

13 years agoEmit separate thumb2 plt entries called by LLVM code.
Zoltan Varga [Tue, 4 Jan 2011 21:03:46 +0000 (22:03 +0100)]
Emit separate thumb2 plt entries called by LLVM code.

13 years ago[moon] String.Join needs 'params' on MOONLIGHT profile too
Sebastien Pouliot [Tue, 4 Jan 2011 20:38:06 +0000 (15:38 -0500)]
[moon] String.Join needs 'params' on MOONLIGHT profile too

* String.cs: Silverlight 4 use the same API as FX4 for Join

13 years agoAvoid thumb->arm trampolines when calling between llvm methods.
Zoltan Varga [Tue, 4 Jan 2011 19:00:23 +0000 (20:00 +0100)]
Avoid thumb->arm trampolines when calling between llvm methods.

13 years agoFixes #635335 - map System.Transactions to 4.0 framework assemblies.
vvaradhan [Tue, 4 Jan 2011 18:04:37 +0000 (23:34 +0530)]
Fixes #635335 - map System.Transactions to 4.0 framework assemblies.

13 years agoType correctly implicit as expression
Marek Safar [Tue, 4 Jan 2011 17:56:23 +0000 (17:56 +0000)]
Type correctly implicit as expression

13 years agoUse correct exception when a key is not found in ConcurrentDictionary
Jérémie Laval [Tue, 4 Jan 2011 16:58:30 +0000 (16:58 +0000)]
Use correct exception when a key is not found in ConcurrentDictionary

13 years agoUse proper pattern for executing synchronous Task
Jérémie Laval [Tue, 4 Jan 2011 16:52:27 +0000 (16:52 +0000)]
Use proper pattern for executing synchronous Task

13 years agoRemove glib dependencies from the embed samples. Fixes #660117.
Zoltan Varga [Tue, 4 Jan 2011 15:38:33 +0000 (16:38 +0100)]
Remove glib dependencies from the embed samples. Fixes #660117.

13 years agoAdd AssemblyLoadEventRequest () type to the sdb api, and use it to fix the test suite.
Zoltan Varga [Tue, 4 Jan 2011 14:29:44 +0000 (15:29 +0100)]
Add AssemblyLoadEventRequest () type to the sdb api, and use it to fix the test suite.

13 years agoFixes the Monitor.Enter race on x86.
Rodrigo Kumpera [Mon, 3 Jan 2011 18:39:25 +0000 (02:39 +0800)]
Fixes the Monitor.Enter race on x86.

* mini-x86.h: Define MONO_ARCH_MONITOR_ENTER_ADJUSTMENT to
cover the whole stack adjustment add that comes after call.

* mini.c (create_jit_info): Use an ARCH define for how
big the try block adjustment needs to be as x86 is more
spacy than amd64.

13 years ago[system] Unbreak a 4.0 System.ServiceModel test.
Marek Habersack [Tue, 4 Jan 2011 13:27:51 +0000 (14:27 +0100)]
[system] Unbreak a 4.0 System.ServiceModel test.

This type is instantiated by one of the tests for the System.ServiceModel.Channels.HttpTransportBindingElement type.

13 years agoCleanup isinst expression resolver
Marek Safar [Tue, 4 Jan 2011 13:06:01 +0000 (13:06 +0000)]
Cleanup isinst expression resolver

13 years agoUse reduced expression for transparent is check
Marek Safar [Tue, 4 Jan 2011 12:39:28 +0000 (12:39 +0000)]
Use reduced expression for transparent is check

13 years ago[wcf] UriTemplate must trim the first leading slash in the rendered template.
Marek Habersack [Tue, 4 Jan 2011 12:52:43 +0000 (13:52 +0100)]
[wcf] UriTemplate must trim the first leading slash in the rendered template.

When using BindBy{Name,Position} UriTemplate must remove the the first slash from
the rendered URI. This fixes the 4 failing tests.

13 years ago[asp.net] The test must always run with the en-US locale
Marek Habersack [Tue, 4 Jan 2011 12:12:10 +0000 (13:12 +0100)]
[asp.net] The test must always run with the en-US locale

13 years agoUse one routine for type argument scan for type parameter
Marek Safar [Tue, 4 Jan 2011 11:29:09 +0000 (11:29 +0000)]
Use one routine for type argument scan for type parameter

13 years agoUpdate ThreadLocal to use default(T) for initialization with parameterless ctor follo...
Jérémie Laval [Tue, 4 Jan 2011 11:14:25 +0000 (11:14 +0000)]
Update ThreadLocal to use default(T) for initialization with parameterless ctor following comment on https://connect.microsoft.com/VisualStudio/feedback/details/630350/threadlocal-documentation-and-actual-behavior-mismatch

13 years ago[system.runtime.caching] Do not test the invalid behavior
Marek Habersack [Tue, 4 Jan 2011 09:22:22 +0000 (10:22 +0100)]
[system.runtime.caching] Do not test the invalid behavior

13 years ago[asp.net] Failing tests fixes.
Marek Habersack [Tue, 4 Jan 2011 09:02:29 +0000 (10:02 +0100)]
[asp.net] Failing tests fixes.

13 years agoFix ia64 build.
Zoltan Varga [Tue, 4 Jan 2011 08:37:10 +0000 (09:37 +0100)]
Fix ia64 build.

13 years ago[asp.net] Added code to handle local resources copying in the test suite
Marek Habersack [Tue, 4 Jan 2011 07:20:20 +0000 (08:20 +0100)]
[asp.net] Added code to handle local resources copying in the test suite

13 years ago[asp.net] Don't attempt to use System.Web resources in System.Web.Extensions test...
Marek Habersack [Tue, 4 Jan 2011 06:57:03 +0000 (07:57 +0100)]
[asp.net] Don't attempt to use System.Web resources in System.Web.Extensions test build

WebTest is now a partial class and every code outside System.Web that uses it can copy its own
resources in addition to the common ones by implementing the CopyResourcesLocal partial method.

13 years agoFix for bug 349053 - unable to serialize SortedDictionary
Luke Halliwell [Sun, 26 Dec 2010 16:26:44 +0000 (08:26 -0800)]
Fix for bug 349053 - unable to serialize SortedDictionary

13 years agoSocket is not connected after error
Gonzalo Paniagua Javier [Tue, 4 Jan 2011 02:09:29 +0000 (21:09 -0500)]
Socket is not connected after error

13 years agoAdd a case-insensitive hashtable
Gonzalo Paniagua Javier [Mon, 3 Jan 2011 22:18:55 +0000 (17:18 -0500)]
Add a case-insensitive hashtable

Use a hashtable instead of a loop when 'ignoreCase' is set.
Based on a patch by Curtis Wensley.

13 years agoImplement VBByRefStr marshalling. Fixes #661917.
Zoltan Varga [Mon, 3 Jan 2011 21:23:19 +0000 (22:23 +0100)]
Implement VBByRefStr marshalling. Fixes #661917.

13 years agoGet rid of mymono_metadata_type_(equal|hash).
Rodrigo Kumpera [Mon, 3 Jan 2011 01:32:31 +0000 (09:32 +0800)]
Get rid of mymono_metadata_type_(equal|hash).

* reflection.c: The copy versions of type/hash functions
is no longer needed. Just get rid of them which brings
some niceties such such as support for FNPTR.

13 years agoFix a warning.
Zoltan Varga [Mon, 3 Jan 2011 20:32:46 +0000 (21:32 +0100)]
Fix a warning.

13 years agoAdd more comments for the fields of MonoAotFileInfo.
Zoltan Varga [Mon, 3 Jan 2011 18:26:05 +0000 (19:26 +0100)]
Add more comments for the fields of MonoAotFileInfo.

13 years agoDon't make the 'thumb_end' symbol global.
Zoltan Varga [Mon, 3 Jan 2011 18:10:40 +0000 (19:10 +0100)]
Don't make the 'thumb_end' symbol global.