Marek Safar [Tue, 15 Nov 2016 16:32:37 +0000 (17:32 +0100)]
[build] Bump required bootraping mono version and download it automatically
Marek Safar [Tue, 5 Apr 2016 14:34:53 +0000 (16:34 +0200)]
[build] Roslyn switch
Miguel de Icaza [Mon, 28 Nov 2016 02:37:47 +0000 (21:37 -0500)]
[marshal] Fix API documentation comment on mono_string_to_byvalwstr
Zoltan Varga [Mon, 28 Nov 2016 02:36:48 +0000 (21:36 -0500)]
[runtime] Fix mono_image_load_module_checked () so it actually stores the loaded netmodule in image->modules, not the parent image itself. Fixes #47762. (#4029)
Zoltan Varga [Sun, 27 Nov 2016 03:45:21 +0000 (22:45 -0500)]
[aot] Avoid a crash on class loading failures. Fixes #47152.
Zoltan Varga [Sat, 26 Nov 2016 22:02:40 +0000 (17:02 -0500)]
[runtime] Fix a warning.
Zoltan Varga [Sat, 26 Nov 2016 21:33:31 +0000 (16:33 -0500)]
[jit] Fix some SIMD problems on x86.
Alexander Köplinger [Sat, 26 Nov 2016 18:16:09 +0000 (19:16 +0100)]
Merge pull request #4028 from monojenkins/update-csprojs
[msvc] Update csproj files
monojenkins [Sat, 26 Nov 2016 16:45:55 +0000 (16:45 +0000)]
[msvc] Update csproj files
Alexander Köplinger [Fri, 25 Nov 2016 19:48:36 +0000 (20:48 +0100)]
[Facades] Don't build System.Drawing.Primitives.dll by default for monotouch_watch profile
It needs special logic like the other monotouch profiles in the products
since we don't have a System.Drawing assembly/types for these profiles in Mono
and don't embed the types in the facade anymore after
1074fe91bd9b33a84040cc9d0d5da42079633d2a.
Marek Safar [Fri, 25 Nov 2016 17:24:35 +0000 (18:24 +0100)]
Merge pull request #4026 from monojenkins/update-csprojs
[msvc] Update csproj files
Marek Safar [Fri, 25 Nov 2016 16:57:58 +0000 (17:57 +0100)]
[Facades] Remove watch special System.Drawing.Primitives, all types are now available in watchos.dll
monojenkins [Fri, 25 Nov 2016 16:51:25 +0000 (16:51 +0000)]
[msvc] Update csproj files
Alexander Köplinger [Fri, 25 Nov 2016 16:07:13 +0000 (17:07 +0100)]
Merge pull request #4024 from akoeplinger/mkbundle-messages
[mkbundle] Print error message when assemblies couldn't be loaded
lateralusX [Fri, 25 Nov 2016 12:17:38 +0000 (13:17 +0100)]
Adding support for get test results in TestDriver.
Added support to pass in an instance of a TestDriverReporter class. If this
an instance of this class is passed in it will get the number of executed, skipped
and failed tests. This could be very useful for external runners that would like
to present the result of TestDriver executed tests.
Alexander Köplinger [Fri, 25 Nov 2016 11:40:49 +0000 (12:40 +0100)]
[mkbundle] Print error message when assemblies couldn't be loaded
There were two places in mkbundle where it'd simply exit without printing anything,
leading to confusion such as in https://bugzilla.xamarin.com/show_bug.cgi?id=46479.
Alexander Köplinger [Fri, 25 Nov 2016 11:03:35 +0000 (12:03 +0100)]
Merge pull request #4020 from akoeplinger/mobile_static-rename
Rename the mobile_static profile to aot_only
Alexander Köplinger [Tue, 11 Oct 2016 11:27:47 +0000 (13:27 +0200)]
[corlib] Simplify RNGCryptoServiceProvider file name on MT and enable tests
Also unify xammac and monotouch .sources files.
We're now using the CommonCrypto-based RNGCryptoServiceProvider on xammac too.
Alexander Köplinger [Fri, 25 Nov 2016 02:38:45 +0000 (03:38 +0100)]
[corlib] Move ComAwareEventInfo stub into System.Core
It was mistakenly added to corlib, it is in System.Core.dll on .NET
Zoltan Varga [Thu, 24 Nov 2016 22:23:59 +0000 (17:23 -0500)]
[jit] Fix more simd+aot issues. Avoid treating the Vector<T> GTD or Vector<T_REF> or Vector<T_GSHAREDVT> as simd types. (#4021)
Bernhard Urban [Thu, 24 Nov 2016 20:57:00 +0000 (21:57 +0100)]
Merge pull request #4019 from vargaz/get-gclass-locking
[runtime] Reduce the size of the critical section in mono_generic_cla…
Bernhard Urban [Thu, 24 Nov 2016 20:54:36 +0000 (21:54 +0100)]
Merge pull request #4017 from vargaz/get-array-class-locking
[runtime] Decrease the size of the critical section in mono_bounded_a…
Bernhard Urban [Thu, 24 Nov 2016 20:54:01 +0000 (21:54 +0100)]
Merge pull request #4018 from vargaz/get-fnptr-locking
[runtime] Reduce the size of the critical section in mono_fnptr_class…
Zoltan Varga [Wed, 23 Nov 2016 22:51:44 +0000 (17:51 -0500)]
[runtime] Reduce the size of the critical section in mono_fnptr_class_get ().
Alexander Köplinger [Thu, 24 Nov 2016 01:33:29 +0000 (02:33 +0100)]
Rename the mobile_static profile to aot_only
We decided it's a better name since we're using the profile to
test FullAOT scenarios on desktop (as opposed to the mobile profiles).
While doing the rename I saw that a lot of the #ifdefs were using
MOBILE_STATIC even though the code should actually be included/excluded
in all FullAOT scenarios, e.g. System.Reflection.Emit. I replaced those
cases with FULL_AOT_RUNTIME instead.
For cases where code is specific to this profile, I added a new
AOT_ONLY_DESKTOP define.
Marek Safar [Thu, 24 Nov 2016 16:14:54 +0000 (17:14 +0100)]
[Facades] Add netstandard
Marius Ungureanu [Thu, 24 Nov 2016 15:17:12 +0000 (17:17 +0200)]
[Perf] Free process in-place in loop on modules iterations.
Marek Safar [Thu, 24 Nov 2016 11:14:07 +0000 (12:14 +0100)]
Bump cecil
Marek Safar [Thu, 24 Nov 2016 10:58:46 +0000 (11:58 +0100)]
[mcs] Count arity correctly for deeply nested types
Zoltan Varga [Thu, 24 Nov 2016 00:23:10 +0000 (19:23 -0500)]
[runtime] Move more callbacks to the RuntimeCallbacks structure. (#4016)
Zoltan Varga [Thu, 24 Nov 2016 00:20:00 +0000 (19:20 -0500)]
[runtime] Decrease the size of the critical section in mono_bounded_array_class_get ().
Zoltan Varga [Wed, 23 Nov 2016 22:29:39 +0000 (17:29 -0500)]
[runtime] Reduce the size of the critical section in mono_generic_class_get_class ().
Andi McClure [Wed, 23 Nov 2016 21:22:11 +0000 (16:22 -0500)]
Use DateTime.UtcNow not DateTime.Now in test
Zoltan Varga [Wed, 23 Nov 2016 20:52:37 +0000 (15:52 -0500)]
[runtime] Disable the Wformat-zero-length warning.
Andi McClure [Wed, 23 Nov 2016 20:33:27 +0000 (15:33 -0500)]
Possibly fix hang in sgen-new-threads-collect.exe
This test is occasionally taking over 15 minutes to complete. This
could be a hang in the runtime, but the test has a scheduling fairness
issue which could also have the same result (if the GC thread wakes up
much more often than the join thread). Patch slows down the GC rate to
give the join thread a chance to work, and extends the test to a fixed
30 second runtime.
Zoltan Varga [Wed, 23 Nov 2016 19:48:22 +0000 (14:48 -0500)]
[simd] Fix a few AOT problems.
Zoltan Varga [Wed, 23 Nov 2016 19:43:47 +0000 (14:43 -0500)]
[bcl] Implement Thread.CurrentThread using an icall which calls mono_… (#4011)
* [bcl] Implement Thread.CurrentThread using an icall which calls mono_thread_current () to avoid creating duplicate Thread objects.
* [bcl] Remove unused Thread:CurrentInternalThread_internal () icall.
* [bcl] Optimize Thread:CurrentThread a bit.
Niklas Therning [Wed, 23 Nov 2016 17:58:29 +0000 (18:58 +0100)]
Merge pull request #4013 from ntherning/fix-assert-in-poll_event_wait-on-WSAENOTSOCK-on-windows-2
Fix assert in poll_event_wait() on WSAENOTSOCK on Windows #2
Marek Safar [Wed, 23 Nov 2016 16:40:00 +0000 (17:40 +0100)]
[System] Don't send response on empty stream write. Fixes #47549
Martin Baulig [Wed, 23 Nov 2016 15:50:09 +0000 (16:50 +0100)]
Merge pull request #3962 from mkorkalo/fix_MonoBtlsContext_memory_leak
fix a massive memory leak in MonoBtlsContext
Aleksey Kliger (λgeek) [Wed, 23 Nov 2016 14:47:37 +0000 (09:47 -0500)]
Merge pull request #3992 from lambdageek/dev-handles-srassembly
[coop] Use handles in System.Reflection.Assembly.{GetReferencedAssemblies,InternalGetAssemblyName}
Niklas Therning [Wed, 23 Nov 2016 13:57:45 +0000 (14:57 +0100)]
Fix assert in poll_event_wait() on WSAENOTSOCK on Windows #2
PR #3998 fixes an error handling issue in poll_event_wait(). This new change
fixes a minor code style problem in that PR, the condition in a ternary wasn't
enclosed in parentheses.
Zoltan Varga [Wed, 23 Nov 2016 13:20:56 +0000 (08:20 -0500)]
[runtime] Filter out duplicate interfaces in mono_class_get_implemented_interfaces (). (#4007)
Zoltan Varga [Wed, 23 Nov 2016 03:24:38 +0000 (22:24 -0500)]
[runtime] Allocate the temporary vtable array using g_malloc in mono_class_setup_vtable (), alloca can overflow for large vtable sizes. Hopefully fixes #45140. (#4006)
Ludovic Henry [Tue, 22 Nov 2016 15:52:00 +0000 (10:52 -0500)]
[threadpool] Replace stop by abort for worker thread
Kenneth Skovhede [Wed, 23 Nov 2016 00:04:57 +0000 (01:04 +0100)]
[Socket] Fix DuplicateAndClose (#3995)
* Fixed issue 47425
This fix simply ensures that the `m_Handle` value is not processed by the GC after a call to `DuplicateAndClose` as that causes the duplicated socket to close.
A potential issue is that this will leak sockets if the sockets are never re-created.
* Implemented ref-counting as suggested by @ludovic-henry
Alexis Christoforides [Wed, 23 Nov 2016 00:01:02 +0000 (19:01 -0500)]
Bockbuild
Aleksey Kliger [Mon, 21 Nov 2016 16:53:48 +0000 (11:53 -0500)]
Bump corlib version.
Aleksey Kliger [Mon, 21 Nov 2016 19:55:12 +0000 (14:55 -0500)]
[reflection] Implement GetReferencedAssemblies in managed
Call out to native to get an array of Mono.MonoAssemblyName* and use
AssemblyName.FillName to create the managed structs.
Alexis Christoforides [Tue, 22 Nov 2016 23:28:52 +0000 (18:28 -0500)]
Bump bockbuild properly
Alexis Christoforides [Tue, 22 Nov 2016 22:39:31 +0000 (17:39 -0500)]
Bump bockbuild
Zoltan Varga [Tue, 22 Nov 2016 20:42:17 +0000 (15:42 -0500)]
[runtime] Avoid passing a newline to mono_trace (), it adds one automatically.
Zoltan Varga [Tue, 22 Nov 2016 20:12:38 +0000 (15:12 -0500)]
[jit] Make an assert more informative. Fixes #47152.
Aleksey Kliger [Mon, 21 Nov 2016 16:52:28 +0000 (11:52 -0500)]
[reflection] Change Assembly.InternalGetAssemblyName to return native MonoAssemblyName
Use managed AssemblyName.FillName to make a
System.Reflection.AssemblyName from a Mono.MonoAssemblyName
Delete native fill_reflection_assembly_name implementation. It's dead code.
Aleksey Kliger [Mon, 21 Nov 2016 16:44:57 +0000 (11:44 -0500)]
[metadata] mono_assembly_fill_assembly_name_full
When copyBlobs is true, duplicates the
name, culture and public_key fields of MonoAssemblyName.
If copyBlobs is false, point those fields into the MonoImage.
Change mono_assembly_fill_assembly_name to call the full version with
copyBlobs == FALSE.
Aleksey Kliger [Fri, 18 Nov 2016 19:33:43 +0000 (14:33 -0500)]
[coop] Use handles for S.R.Assembly.{GetReferencedAssemblies,InternalGetAssemblyName}
Aleksey Kliger [Fri, 18 Nov 2016 19:12:43 +0000 (14:12 -0500)]
[runtime] Add mono_string_handle_to_utf8
Aleksey Kliger [Fri, 18 Nov 2016 19:09:07 +0000 (14:09 -0500)]
[runtime] mark mono_get_exception_{file_not_found2,bad_image_format2} external only.
Runtime should use
- mono_error_set_assembly_load for mono_get_exception_file_not_found2
- mono_error_set_bad_image_name for mono_get_exception_bad_image_format2
Alexis Christoforides [Tue, 22 Nov 2016 19:10:22 +0000 (14:10 -0500)]
Merge branch 'alexischr/nursery-canaries-managed-alloc'
Niklas Therning [Tue, 22 Nov 2016 19:03:22 +0000 (20:03 +0100)]
Merge pull request #4003 from ntherning/ignore-disconnected-interfaces-in-HttpListenerRequestTest.HttpRequestIsLocal
Ignore disconnected interfaces in HttpListenerRequestTest.HttpRequestIsLocal
Alexander Köplinger [Tue, 22 Nov 2016 18:26:39 +0000 (19:26 +0100)]
Merge pull request #4005 from monojenkins/update-csprojs
[msvc] Update csproj files
Marek Safar [Tue, 22 Nov 2016 17:06:33 +0000 (18:06 +0100)]
[System.Runtime.Remoting] Disable test accidentally re-enabled by nunitlite switch
Zoltan Varga [Tue, 22 Nov 2016 16:59:53 +0000 (11:59 -0500)]
[runtime] Disable some tests when running with llvm since they take too much time. Reduce the run time of the namedmutex-destroy-race test.
monojenkins [Tue, 22 Nov 2016 16:39:46 +0000 (16:39 +0000)]
[msvc] Update csproj files
Zoltan Varga [Tue, 22 Nov 2016 16:24:51 +0000 (11:24 -0500)]
[runtime] Mark the ThreadPool.PerformWaitCallback () method as save_lmf, so ThreadAbortExceptions thrown inside tp worker threads are always caught, otherwise if the TAE arrives while the threads is in native code while executing the callback, the EH will code will abort the thread so the worker thread cleanup code is not executed, causing problems later. (#4002)
Marek Safar [Tue, 22 Nov 2016 16:01:15 +0000 (17:01 +0100)]
[mcs] Null coalescing over typed null constants.
Ludovic Henry [Fri, 18 Nov 2016 20:58:03 +0000 (15:58 -0500)]
[profiles] Fix MOBILE assemblies and tests compilation + Rename MOBILE to AOT_HYBRID
This only fixes the compilation of the assemblies and the tests. This doesn't fix the failing tests or the crashes.
Ludovic Henry [Fri, 18 Nov 2016 21:53:21 +0000 (16:53 -0500)]
[ci] Add script to run MOBILE profile tests
Ludovic Henry [Thu, 17 Nov 2016 22:55:53 +0000 (17:55 -0500)]
[utils] Add MonoRefCount to factor ref-counting mechanisms
Marek Safar [Mon, 21 Nov 2016 15:49:30 +0000 (16:49 +0100)]
[corlib] Update list of known lcids and update CLRD data. Fixes #46456
Niklas Therning [Tue, 22 Nov 2016 13:27:59 +0000 (14:27 +0100)]
Ignore disconnected interfaces in HttpListenerRequestTest.HttpRequestIsLocal
This test creates an HttpListener for every IP address of all network
interfaces. On Windows disconnected network interfaces have unroutable IP
addresses (169.254.XXX.XXX) and this test fails when it tries to listen to
such an IP address. This patch adds a check to the test to ignore network
interfaces which don't have OperationalStatus == Up.
Niklas Therning [Tue, 22 Nov 2016 10:36:04 +0000 (11:36 +0100)]
Merge pull request #3998 from ntherning/fix-assert-in-poll_event_wait-on-WSAENOTSOCK-on-windows
Fix assert in poll_event_wait() on WSAENOTSOCK on Windows
Zoltan Varga [Tue, 22 Nov 2016 01:51:05 +0000 (20:51 -0500)]
[runtime] Add a test for appdomain unload + blocking tp thread. (#4000)
Alexis Christoforides [Mon, 21 Nov 2016 22:40:00 +0000 (17:40 -0500)]
[MacSDK] Fix typo
Zoltan Varga [Mon, 21 Nov 2016 22:28:34 +0000 (17:28 -0500)]
[runtime] Add back locking around mono_class_layout_fields () to work around https://bugzilla.xamarin.com/show_bug.cgi?id=47156.
Zoltan Varga [Mon, 21 Nov 2016 21:59:02 +0000 (16:59 -0500)]
Threadpool appdomain unload cleanup (#3996)
* [runtime] Move the threadpool related data from MonoDomain to ThreadPoolDomain.
* [runtime] Simplify the waiting for tp threads in the domain unload code. Use a condvar to wait for the active+outstanding number of jobs to reach 0.
Ludovic Henry [Fri, 18 Nov 2016 19:15:06 +0000 (14:15 -0500)]
[tests] Rework how we do disabled tests
Aleksey Kliger (λgeek) [Mon, 21 Nov 2016 14:43:07 +0000 (09:43 -0500)]
Merge pull request #3988 from lambdageek/dev-handles-srmodule
[coop] Use handles in System.Reflection.Module and System.Reflection.Assembly
Niklas Therning [Mon, 21 Nov 2016 09:17:40 +0000 (10:17 +0100)]
Fix assert in poll_event_wait() on WSAENOTSOCK on Windows
On Windows poll_event_wait() in threadpool-ms-io-poll.c checks
WSAGetLastError() when mono_poll() fails. However, mono_poll() sets errno
after converting the WSAXXX error code (e.g. WSAEFAULT->EFAULT). Occasionally
(maybe 1 in 100) the System test suite fails due to mono_poll() returning an
error and poll_event_wait() not handling the error code correctly on Windows.
This patch changes poll_event_wait() to use the same code path which checks
errno on all platforms including Windows. It also fixes a few other places
which used to check WSAGetLastError() rather than errno after a call to
mono_poll(). Also, the Socket.Poll_internal() and Socket.Select_internal()
icalls had to be patched to convert back the errno value to a corresponding
WSAXXX error code by adding WSABASEERR on Windows.
Marek Safar [Mon, 21 Nov 2016 13:40:23 +0000 (14:40 +0100)]
Revert "[runtime] Default mobile_static AOT type to FullAOT"
Marek Safar [Mon, 21 Nov 2016 08:54:08 +0000 (09:54 +0100)]
Merge pull request #3406 from alexanderkyte/mobile_static_default
[runtime] Default mobile_static AOT type to FullAOT
Zoltan Varga [Sun, 20 Nov 2016 23:01:32 +0000 (18:01 -0500)]
[runtime] Add even more logging code for the class.c assertion.
Zoltan Varga [Sun, 20 Nov 2016 16:01:47 +0000 (11:01 -0500)]
Fix the build.
Zoltan Varga [Sun, 20 Nov 2016 15:57:07 +0000 (10:57 -0500)]
Implement SIMD support for the Vector2/3/4 classes in System.Numerics. (#3765)
* [simd] Rename SimdIntrinsc->SimdIntrinsic.
* [ji] Add beginnings of support for the SIMD types in the System.Numerics assembly.
Add intrinsics for the methods marked [JitIntrinsic] in the System.Numerics.Vector2 class. Generalize some code in simd-intrinsic.c
so it works both with System.Numerics and Mono.Simd types.
* [jit] Add support for System.Numerics.Vector4.
* [jit] Add support for System.Numerics.Vector3.
* [jit] Add tests for the JIT intrinsics in System.Numerics.Vectors.
* [jit] Implement System.Numerics.Vector.IsHardwareAccelerated intrinsics.
* [jit] Fix the implementation of System.Numerics.Vector.IsHardwareAccelerated, it should return true.
* [jit] Implement some support for the SIMD intrinsics in System.Numerics.Vector<T>.
* [jit] Disable the usage of the Vector SIMD intrinsics when using r4fp until support for it is implemented.
* [jit] Fix llvm support for the Vector<T> intrinsics.
* [jit] Disable the Vector<T> tests since they don't compile yet.
* [jit] Add an optimization for the typeof(T)==typeof(<concrete type>) construct common in some generics code.
* [simd] Only return true from IsHardwareAccelerated () if simd_supported_versions is non-zero.
* [simd] Add support for add/sub/mul/div operations on Vector<T>.
Marek Safar [Sun, 20 Nov 2016 10:34:26 +0000 (11:34 +0100)]
[System] WebClient async request on file streams. Fixes #46538
Zoltan Varga [Sat, 19 Nov 2016 20:23:25 +0000 (15:23 -0500)]
[runtime] Add more debug code to help debug a class.c assert.
Marek Safar [Fri, 18 Nov 2016 22:37:54 +0000 (23:37 +0100)]
[corlib] Don't crash when calling Evidence on AssemblyBuilder. Fixes #46739
Jon Purdy [Thu, 3 Nov 2016 19:36:09 +0000 (12:36 -0700)]
[sgen] Fix sgen_qsort.
sgen_qsort sometimes had pathological behavior due to a poor choice of
pivot. This implementation uses the median-of-three strategy, and limits
stack depth by avoiding recursive calls when possible.
Ludovic Henry [Fri, 18 Nov 2016 16:12:24 +0000 (11:12 -0500)]
Revert "[process] Allocate a handle even for non-child processes"
This reverts commit
d6928839015effec6358d7bc9c7b1b547645140a.
Zoltan Varga [Fri, 18 Nov 2016 20:41:32 +0000 (15:41 -0500)]
Revert "[runtime] Change the thread wait code to use cond variables instead o… (#3946)"
This reverts commit
4a1161e2d691672e8544ce5a3e20e5c08daa4f45.
Revert this, keep the event based code for now.
Zoltan Varga [Fri, 18 Nov 2016 20:40:26 +0000 (15:40 -0500)]
Revert "[runtime] Fix the waiting for background threads which got broken by
4a1161e2d691672e8544ce5a3e20e5c08daa4f45. (#3983)"
This reverts commit
dbc63ae672bcd65d87dbf4b1960904102cdcde97.
Revert this, keep the event based code for now.
Marek Safar [Fri, 18 Nov 2016 16:58:05 +0000 (17:58 +0100)]
[System] Add range check for empty URI prefix when it also contains unicode character. Fixes #47205
Aleksey Kliger [Thu, 17 Nov 2016 22:28:42 +0000 (17:28 -0500)]
[reflection] Use handles for System.Reflection.Assembly.GetTypes
Also change mono_get_exception_reflection_type_load_checked() to use handles.
Aleksey Kliger [Thu, 17 Nov 2016 21:03:18 +0000 (16:03 -0500)]
[reflection] Use coop handles for 6 icalls in System.Reflection.Module
- Close
- GetGlobalType
- GetHINSTANCE
- GetMDStreamVersion
- GetPEKind
- InternalGetTypes
Aleksey Kliger [Thu, 17 Nov 2016 18:08:19 +0000 (13:08 -0500)]
[coop] mono_type_get_object_handle
Aleksey Kliger [Thu, 17 Nov 2016 20:19:19 +0000 (15:19 -0500)]
[coop] Add more handle utility functions
- MONO_HANDLE_ARRAY_GETREF
- HANDLE_FUNCTION_RETURN_OBJ
- mono_array_handle_memcpy_refs
Aleksey Kliger [Thu, 17 Nov 2016 20:18:30 +0000 (15:18 -0500)]
[coop] Add mono_error_set_exception_handle
Aleksey Kliger (λgeek) [Fri, 18 Nov 2016 14:53:59 +0000 (09:53 -0500)]
Merge pull request #3932 from lambdageek/dev-handles-outargs
[coop handles] Support out args; convert some icalls.
Niklas Therning [Fri, 18 Nov 2016 13:30:22 +0000 (14:30 +0100)]
Merge pull request #3985 from ntherning/fix-Mono.Posix-on-windows
Fix Mono.Posix tests on Windows
Henric Müller [Fri, 18 Nov 2016 06:11:17 +0000 (07:11 +0100)]
Merge pull request #3948 from henricm/fix-pinvoke-utf8-windows
Fix crash on Windows in PInvoke UTF8 tests