Alexander Köplinger [Thu, 13 Apr 2017 20:46:05 +0000 (22:46 +0200)]
Revert "[acceptance-tests] Disable a regressed coreclr test"
This reverts commit
5e8012a6787e4dc1bb6577c4e3572a2c8070dd05.
The bug was fixed.
Zoltan Varga [Thu, 13 Apr 2017 20:40:34 +0000 (16:40 -0400)]
[jit] Make newarr [void] unverified. Fixes #55083.
Aleksey Kliger (λgeek) [Thu, 13 Apr 2017 18:27:02 +0000 (14:27 -0400)]
Merge pull request #4680 from lambdageek/bug-49721-take2
[loader] Ignore public key token in strong name match, if requested framework assembly was remapped
Martin Baulig [Thu, 13 Apr 2017 17:46:54 +0000 (13:46 -0400)]
[btls]: Cleanup certificate store initialization (#4683)
* [BTLS]: Cleanup certificate store initialization.
* Kill unused MonoBtlsX509Store.AddTrustedRoots().
* In server-mode, MonoBtlsProvider.SetupCertificateStore() now only adds
certificates explicitly trused via MonoTlsSettings.TrustAnchors.
* MonoTlsProvider.ValidateCertificate() - which is called from
X509Certificate2.Verify() via X509CertificateImplBtls.Verify() - now
uses MonoTlsSettings.DefaultSettings and assumes client-mode.
* [appletls]: Actually use the new code that was added in PR #4671.
* [btls]: Add new MonoTlsSettings.CertificateValidationTime property.
This allows you to set a custom time for certificate expiration checks.
* [appletls]: Bind SecTrustSetVerifyDate() and check MonoTlsSettings.CertificateValidationTime.
Alexander Köplinger [Thu, 13 Apr 2017 17:15:37 +0000 (19:15 +0200)]
Fix check for file in gensources.sh
It didn't correctly check whether the file exists so we got
"tail: no such file or directory" messages during the build.
Zoltan Varga [Thu, 13 Apr 2017 16:16:24 +0000 (12:16 -0400)]
[runtime] Fix some small domain related memory leaks. (#4685)
Marek Safar [Thu, 13 Apr 2017 10:22:45 +0000 (12:22 +0200)]
[System.Core][System.ComponentModel.DataAnnotations] Update strings
Rodrigo Kumpera [Wed, 12 Apr 2017 23:01:36 +0000 (16:01 -0700)]
Merge pull request #4675 from kumpera/runtime-scalability-take1
[runtime] Reduce contention on some top locks when running Roslyn.
Martin Baulig [Wed, 12 Apr 2017 17:38:56 +0000 (13:38 -0400)]
[appletls]: Actually use the new code that was added in PR #4671.
Alexander Kyte [Wed, 12 Apr 2017 19:47:39 +0000 (15:47 -0400)]
Merge pull request #4615 from alexanderkyte/string_error_handling
[runtime] Don't discard string conversion errors
Zoltan Varga [Wed, 12 Apr 2017 19:16:00 +0000 (15:16 -0400)]
[ppdb] Fix a crash if mono_ppdb_get_seq_points () is only passed a 'source_file' argument.
monojenkins [Wed, 12 Apr 2017 16:36:50 +0000 (16:36 +0000)]
[msvc] Update csproj files
Aleksey Kliger [Wed, 12 Apr 2017 16:06:26 +0000 (12:06 -0400)]
[loader] Ignore public key token in strong name match, if requested framework assembly was remapped
When framework assemblies are compiled for the mobile runtime, they are
generally signed with a different key than the normal desktop one.
Unfortunately each assembly has different logic for which key is
used (typically silverlight.pub or corefx.pub in place of ecma.pub), and short
of hardcoding a table in the runtime, there's no good way to know.
Aleksey Kliger [Wed, 12 Apr 2017 16:04:25 +0000 (12:04 -0400)]
[assembly] Add option to ignore public key tokens when comparing MonoAssemblyNames
Aleksey Kliger [Tue, 11 Apr 2017 19:19:22 +0000 (15:19 -0400)]
Revert "[loader] Remap public key tokens of framework assemblies when running with --runtime=mobile"
This reverts commit
af7195e3493bc8c3e49da9e411ec7c8da1efcbef.
Alexander Köplinger [Wed, 12 Apr 2017 13:00:11 +0000 (15:00 +0200)]
[acceptance-tests] Disable a regressed coreclr test
I filed a tracking bug.
Vlad Brezae [Wed, 12 Apr 2017 00:54:08 +0000 (03:54 +0300)]
Merge pull request #4670 from BrzVlad/fix-sgen-testing
[tests] sgen testing tweaks
Vlad Brezae [Mon, 10 Apr 2017 16:18:23 +0000 (19:18 +0300)]
[tests] Improve configurations of sgen tests
Main pointers :
- explicit minor and bridge configuration (add some for missing major)
- reduce duplicated testing or of low relevance (like split nursery)
- intensive testing of latest new configurations combined (parallel minor + major + future experiments)
- include testing with a small and a large nursery for additional variance
Vlad Brezae [Mon, 10 Apr 2017 12:50:39 +0000 (15:50 +0300)]
[tests] Add timeout limits to some longer sgen tests
Rodrigo Kumpera [Tue, 22 Nov 2016 17:06:26 +0000 (09:06 -0800)]
[loader] Make MonoImageSet::gclass_cache concurrent.
Rodrigo Kumpera [Tue, 22 Nov 2016 09:41:46 +0000 (01:41 -0800)]
[loader] Move typespec_cache to a lock-free-reads hashtable.
Rodrigo Kumpera [Tue, 22 Nov 2016 09:20:45 +0000 (01:20 -0800)]
[loader] Add a lock-free cache in front of get_image_set. Doesn't override on fetch, maybe needs tweaking?
Rodrigo Kumpera [Tue, 11 Apr 2017 22:07:56 +0000 (18:07 -0400)]
Merge pull request #4673 from kumpera/fix_stdelem_ref_perf
[runtime] Fix get_virtual_stelemref_wrapper STELEMREF_CLASS case to actually do the base class check.
Martin Baulig [Tue, 11 Apr 2017 21:43:51 +0000 (17:43 -0400)]
[appletls]: Use SecIdentityCreate() to avoid using the Mac keychain. (#4671)
* [appletls]: Use SecIdentityCreate() to avoid using the Mac keychain when we have a private key.
Reading Certificates from the Mac Keychain
==========================================
Reading the private key from the keychain is a new feature introduced with
AppleTls on XamMac and iOS. On Desktop Mono, this new feature has several
known issues and it also did not received any testing yet. We go back to the old
way of doing things, which is to explicitly provide an X509Certificate2 with a
private key.
Keychain Dialog Popups
======================
When using Xamarin.Mac or Xamarin.iOS, we try to search the keychain
for the certificate and private key.
On Xamarin.iOS, this is easy because each app has its own keychain.
On Xamarin.Mac, the .app package needs to be trusted via code-sign
to get permission to access the user's keychain. [FIXME: I still have to
research how to actually do that.] Without this, you will get a popup
message each time, asking you whether you want to allow the app to access
the keychain, but you can make these go away by selecting "Trust always".
On Desktop Mono, this is problematic because selecting "Trust always"
give the 'mono' binary (and thus everything you'll ever run with Mono)
permission to retrieve the private key from the keychain.
This code would also trigger constant keychain popup messages,
which could only be suppressed by granting full trust. It also makes it
impossible to run Mono in headless mode.
SecIdentityCreate
=================
To avoid these problems, we are currently using an undocumented API
called SecIdentityRef() to avoid using the Mac keychain whenever a
X509Certificate2 with a private key is used.
On iOS and XamMac, you can still provide the X509Certificate without
a private key - in this case, a keychain search will be performed (and you
may get a popup message on XamMac).
Rodrigo Kumpera [Tue, 11 Apr 2017 18:36:49 +0000 (11:36 -0700)]
[runtime] Fix get_virtual_stelemref_wrapper STELEMREF_CLASS case to actually do the base class check.
The code was bailing straight to native which is significantly slower. This is the result of roslyn compiling corlib on my machine:
Before:
real 0m5.757s
user 0m22.059s
sys 0m1.736s
After:
real 0m5.816s
user 0m23.623s
sys 0m1.693s
Alexander Köplinger [Tue, 11 Apr 2017 18:23:26 +0000 (20:23 +0200)]
[netstandard] Remove System.ArgIterator from facade
It was removed today: https://github.com/dotnet/standard/commit/
52651e78ac329c56fb59cebf5b24174f25acb070
Alexander Köplinger [Tue, 11 Apr 2017 18:18:55 +0000 (20:18 +0200)]
[Facades] Build netstandard.dll by default (#4501)
Added a new EXTERNAL_FACADE_DRAWING_REFERENCE variable which
specifies the path to an assembly that contains drawing types,
e.g. in the monotouch/monodroid case System.Drawing is built
inside the XI/XA repos.
Also update netstandard typeforwards to the latest version
from the dotnet/standard repo.
monojenkins [Tue, 11 Apr 2017 16:29:26 +0000 (16:29 +0000)]
[msvc] Update csproj files
Rodrigo Kumpera [Tue, 11 Apr 2017 17:13:38 +0000 (10:13 -0700)]
Merge pull request #4116 from kumpera/jit-job-control
[mini] Introduce job control to the JIT. Limits by active and duplicate jobs.
Zoltan Varga [Tue, 11 Apr 2017 15:51:45 +0000 (11:51 -0400)]
[arm] Fix a gsharedvt assertion which happens with gsharedvt methods with a lot of arguments. Fixes #54976.
Marek Safar [Tue, 11 Apr 2017 14:36:11 +0000 (16:36 +0200)]
Update README.Mono.md
Marek Safar [Tue, 11 Apr 2017 11:59:37 +0000 (13:59 +0200)]
Readme rename
Marek Safar [Fri, 7 Apr 2017 22:25:45 +0000 (00:25 +0200)]
Updates referencesource to .NET 4.7
Alexander Köplinger [Mon, 10 Apr 2017 18:15:34 +0000 (20:15 +0200)]
[resgen] Remove dependency on WinForms and use it in mobile profiles (#4667)
resgen.exe used to load WinForms via reflection which is a pretty
large dependency. Instead we can just embed the few types that
are used for reading/writing resx files directly into the app.
Add System.Drawing.dll to the "build" profile so we can put
resgen there as well and allow us to no longer rely on system
resgen for mobile profiles like monotouch/monodroid.
monojenkins [Mon, 10 Apr 2017 16:48:21 +0000 (18:48 +0200)]
[msvc] Update csproj files (#4669)
Marek Safar [Mon, 10 Apr 2017 09:47:25 +0000 (11:47 +0200)]
[corlib] Deconstruct api from corert
Marek Safar [Sat, 8 Apr 2017 08:52:26 +0000 (10:52 +0200)]
Bump corert
Marek Safar [Fri, 7 Apr 2017 10:15:50 +0000 (12:15 +0200)]
[corlib] Add few checks for array boxing conversion of pointer types
Marek Safar [Wed, 5 Apr 2017 07:33:26 +0000 (09:33 +0200)]
[corlib] Share corert Array code
Vlad Brezae [Mon, 10 Apr 2017 10:43:09 +0000 (13:43 +0300)]
[tests] Bump timeouts on sgen tests
Tests that have been known to regularly fail in the past.
Zoltan Varga [Sun, 9 Apr 2017 22:59:44 +0000 (18:59 -0400)]
[arm64] Add a test file for codegen macros. Not used.
Ludovic Henry [Sat, 8 Apr 2017 00:56:59 +0000 (20:56 -0400)]
[tests] Make stress testing more verbose (#4664)
Rodrigo Kumpera [Fri, 7 Apr 2017 22:55:43 +0000 (15:55 -0700)]
[mini] Fix spurious wakeups within JIT job control.
The first iteration of this code suffered from spurious wakeups due to using a single cond-var for all compilation.
This introduce a per-job cond var and make threads wait on that. Spurious wakeups are quite problematic in heavily threaded
code such as Roslyn. On average, every wait would get 2 extra wakeups for no good reason.
With this change, on my laptop compilation times are the following:
With spurious wakeups:
real 0m6.134s
user 0m23.588s
sys 0m2.331s
Without spurious wakeups:
real 0m5.658s
user 0m22.851s
sys 0m1.694s
This represents a 8% wallclock speedup and 3% user time speedup.
As part of this change, the active threads accounting is gone as the number of waits due to cpu overload was close to zero.
Andi McClure [Fri, 7 Apr 2017 20:16:23 +0000 (16:16 -0400)]
Merge pull request #4660 from xmcclure/llvm-orbis
LLVM Orbis support
Andi McClure [Thu, 6 Apr 2017 21:15:19 +0000 (17:15 -0400)]
LLVM: Orbis support, fix typo in configure.ac
jmserrano [Fri, 7 Apr 2017 17:13:17 +0000 (19:13 +0200)]
Fix bug in SessionStateModule when session data is deleted
Alexander Köplinger [Fri, 7 Apr 2017 18:05:34 +0000 (20:05 +0200)]
[Facades] Add facades to winaot/orbis profiles (#4656)
Also remove Mono.Simd as we don't it on new platforms.
Cleanup monotouch_dirs to not depend on testing_aot_full_dirs since
it should be separate (even though it contains the same right now).
Andi McClure [Fri, 7 Apr 2017 17:47:16 +0000 (13:47 -0400)]
Merge pull request #4663 from xmcclure/bump-linker
Bump linker external to its master
Alexander Köplinger [Fri, 7 Apr 2017 16:07:52 +0000 (18:07 +0200)]
[bcl] Add check for newline to gensources.sh (#4662)
This has bitten us a bunch of times now so let's make sure
it doesn't happen again.
Andi McClure [Fri, 7 Apr 2017 15:42:00 +0000 (11:42 -0400)]
Bump linker external to its master
Alexander Köplinger [Fri, 7 Apr 2017 12:50:16 +0000 (14:50 +0200)]
Make sure .sources files end with newline
It confuses the build on Linux otherwise.
Marek Safar [Thu, 6 Apr 2017 21:24:25 +0000 (23:24 +0200)]
Bump corert
Zoltan Varga [Fri, 7 Apr 2017 04:44:23 +0000 (00:44 -0400)]
[arm] Commit the generated arm_dpimacros.h/arm_vfpmacros.h files, they change very infrequently, and having to generate them complicates the cross compiler/offsets tool build. (#4655)
Rodrigo Kumpera [Fri, 7 Apr 2017 01:43:04 +0000 (18:43 -0700)]
Remove debug fflush and fix active_jit_methods accounting in case of recursion.
Zoltan Varga [Fri, 7 Apr 2017 01:09:17 +0000 (21:09 -0400)]
[runtime] Update the offsets tool to a new version of CppSharp and use 64 bit binaries on osx. (#4659)
Rodrigo Kumpera [Wed, 22 Feb 2017 23:44:54 +0000 (15:44 -0800)]
Fix compilation issues.
Rodrigo Kumpera [Thu, 8 Dec 2016 00:10:41 +0000 (16:10 -0800)]
[mini] Introduce job control to the JIT. Limits by active and duplicate jobs.
This shown up as a problem under parallel roslyn.
We hit frequently the case of multiple threads compiling the same method in parallel
and wasting all but one.
Another issue that happens, but infrequently, is having more threads JITing than there
are cores in the machine. Such thrashing doesn't help.
Test setup. 4/8 macbook pro compiling corlib.
Baseline:
real 0m7.665s
user 0m20.078s
sys 0m2.653s
Methods JITted using mono JIT : 22422
Total time spent JITting (sec) : 18.5365
With this patch:
real 0m6.149s
user 0m18.504s
sys 0m1.487s
Methods JITted using mono JIT : 16619
Total time spent JITting (sec) : 4.9420
New counters
JIT compile waited others : 7681
JIT compile 1+ jobs : 1
JIT compile overload wait : 67
JIT compile spurious wakeups : 14469
This results in a 20% wall clock reduction but only a 8% reduction on user.
We JIT 26% less methods, with very few duplications. Showing this drastically improves the situation.
JIT compilation time metrics are bogus due to .cctors and other sources of interference. So take it with a grain of salt.
Future work:
Based on the new counters, it's clear that the current wakeup design is suboptimal and we could further improve it by cutting on spurious wakeups.
Vincent Povirk [Thu, 6 Apr 2017 22:08:18 +0000 (17:08 -0500)]
[tests] Fix out of tree build. (#4657)
Ludovic Henry [Thu, 6 Apr 2017 18:49:04 +0000 (14:49 -0400)]
[tests] Add stress testing and reduce sgen normal testing time (#4653)
* [tests] Keep testing even if a test has failed
* [tests] Add stress testing and reduce sgen normal testing time
Zoltan Varga [Thu, 6 Apr 2017 17:21:38 +0000 (13:21 -0400)]
[jit] Only free the unwind info inside a MonoTrampInfo if its owned by the structure.
Alexander Köplinger [Thu, 6 Apr 2017 00:25:35 +0000 (02:25 +0200)]
[tools] Remove old msbuild experiment
This is just confusing now that we have the real thing.
Rolf Bjarne Kvinge [Thu, 6 Apr 2017 03:06:58 +0000 (05:06 +0200)]
[runtime] Free leaked variable. (#4643)
Zoltan Varga [Thu, 6 Apr 2017 03:06:47 +0000 (23:06 -0400)]
[aot] Print JIT failures without having to pass an additional option. (#4648)
Rodrigo Kumpera [Wed, 5 Apr 2017 23:59:08 +0000 (16:59 -0700)]
Merge pull request #4612 from kumpera/android-changes-part2
Fix Android compilation and some tests
Ludovic Henry [Wed, 5 Apr 2017 23:54:49 +0000 (19:54 -0400)]
[tests] Rework how we AOT compile tests + General cleanup of make targets (#4639)
Rodrigo Kumpera [Wed, 5 Apr 2017 21:17:37 +0000 (14:17 -0700)]
[runtime] Don't return the modules for the current process when pid != getpid ().
Rodrigo Kumpera [Wed, 5 Apr 2017 21:16:39 +0000 (14:16 -0700)]
[System] Disable test that is too unreliable.
Rodrigo Kumpera [Mon, 20 Mar 2017 23:49:25 +0000 (16:49 -0700)]
Improve test assert.
Rodrigo Kumpera [Mon, 20 Mar 2017 22:01:30 +0000 (15:01 -0700)]
[System] Disable a few tests that don't work on Android.
Rodrigo Kumpera [Thu, 16 Mar 2017 23:04:35 +0000 (16:04 -0700)]
[System] Disable test that doesn't work on Android.
Rodrigo Kumpera [Thu, 16 Mar 2017 22:58:11 +0000 (15:58 -0700)]
[io-layer] Don't RC std handles or the current process on every lookup.
Caller don't expect those lookups to be RC'd so they don't compensate. This leads to unbound growth of their ref count, which eventually overflows.
Rodrigo Kumpera [Thu, 16 Mar 2017 18:30:43 +0000 (11:30 -0700)]
[runtime] When looking up the process name, don't bail out if you can't load its modules.
Loading modules for other processes can fail under some linux sandboxing rules but that doesn't mean
we should not be able to compute the process name. So when module == NULL, we make module loading non-fatal.
Rodrigo Kumpera [Thu, 16 Mar 2017 18:23:20 +0000 (11:23 -0700)]
[runtime] Improve tracing of process name lookup functions.
Rodrigo Kumpera [Thu, 16 Mar 2017 18:21:28 +0000 (11:21 -0700)]
[runtime] Fix compilation under Android
Zoltan Varga [Wed, 5 Apr 2017 20:23:15 +0000 (16:23 -0400)]
[jit] Fix a leak in the trampoline info registration code. (#4646)
Bernhard Urban [Wed, 5 Apr 2017 16:13:10 +0000 (18:13 +0200)]
[interp] testcase for stack overflow on tail recursion opt
inspired by
./mcs/mcs/assign.cs:
SimpleAssign:CheckEqualAssign ()
Bernhard Urban [Tue, 4 Apr 2017 09:16:27 +0000 (11:16 +0200)]
[interp] fix stack overflow on tail recursion
Bernhard Urban [Tue, 4 Apr 2017 09:16:27 +0000 (11:16 +0200)]
[interp] fix stack alloc size
monojenkins [Wed, 5 Apr 2017 16:42:25 +0000 (18:42 +0200)]
[msvc] Update csproj files (#4645)
Egor Bogatov [Wed, 5 Apr 2017 13:12:21 +0000 (16:12 +0300)]
[System.Data] Fix Azure SQL specific issues (ProviderTests) (#4622)
* [System.Data] Fix Azure SQL specific issues (ProviderTests)
* [System.Data] ChangeDatabase - Azure specific test
* [System.Data] SqlConnectionTest: use Assert.Throws instead
Marek Safar [Wed, 5 Apr 2017 08:03:02 +0000 (10:03 +0200)]
[Facades] Add forwarder for DbDataReaderExtensions
monojenkins [Tue, 4 Apr 2017 16:25:38 +0000 (16:25 +0000)]
[msvc] Update csproj files
Alexander Köplinger [Wed, 5 Apr 2017 01:34:23 +0000 (03:34 +0200)]
[tests] Fix the mcs-compileall target in runtime/ (#4637)
It is used as the "verify" step on Jenkins/Wrench and I noticed
it didn't run recently.
Looks like it was broken a while ago by
695e8f53ae7d2139.
Moving the verifiable_files variable at the top is wrong since
the $$profile variable is only defined inside the for loop and
so we'd get an empty list.
When that was fixed it still didn't work as piping to `echo`
doesn't work. Replaced it with a Makefile solution instead.
Vlad Brezae [Tue, 4 Apr 2017 23:52:03 +0000 (02:52 +0300)]
Merge pull request #4630 from BrzVlad/feature-valloc-limit
[sgen] OOM testing
Vlad Brezae [Mon, 3 Apr 2017 21:30:45 +0000 (00:30 +0300)]
[runtime] Add arch size InterlockedAdd
Vlad Brezae [Fri, 31 Mar 2017 11:51:30 +0000 (14:51 +0300)]
[sgen] Add old forgotten oom tests to sgen oom suite
Vlad Brezae [Fri, 31 Mar 2017 11:48:33 +0000 (14:48 +0300)]
[sgen] Add oom testing suite
Vlad Brezae [Fri, 31 Mar 2017 14:40:12 +0000 (17:40 +0300)]
[sgen] Don't pass gc options to the test-runner
Also remove some plain configurations (in the tests we should explicitly select the major)
Vlad Brezae [Tue, 4 Apr 2017 22:13:00 +0000 (01:13 +0300)]
Merge pull request #4618 from BrzVlad/feature-par-nrs
[sgen] Parallel nursery collections
Martin Baulig [Tue, 4 Apr 2017 18:28:17 +0000 (14:28 -0400)]
[appletls]: Make CFObject.dlsym() private and fix CFBoolean. (#4640)
This fixes a native crash when attempting to use appletls.
Vlad Brezae [Wed, 29 Mar 2017 11:17:02 +0000 (14:17 +0300)]
[sgen] Split up concurrent sweep from worker logic
While this was ok because workers and sweep could not run at the same time, this is no longer the case with parallel nursery collections. In the future, if many threads will be required for different types of jobs, we can consider running them on same native thread, but the jobs will still need to have appropriate contexts (the SgenThreadPool they belong to).
Vlad Brezae [Tue, 28 Mar 2017 21:12:02 +0000 (00:12 +0300)]
[sgen] Increase gray stack section size
Stealing a gray section is relatively expensive since it requires locking. We want to avoid repeated stealing, since only one gray queue section is stolen at a time (in the case of the parallel collector).
Vlad Brezae [Fri, 3 Mar 2017 11:54:14 +0000 (13:54 +0200)]
[sgen] Increase parallelization of minors
Vlad Brezae [Fri, 3 Mar 2017 10:38:15 +0000 (12:38 +0200)]
[sgen] Parallel nursery collections
Scans the card table and the roots on the workers, including draining the stack.
Michael DeRoy [Tue, 4 Apr 2017 12:20:13 +0000 (08:20 -0400)]
Fix mono_marshal_alloc to accept gsize instead of gulong(unsigned long) (#4623)
* Fix mono_marshal_alloc to accept gsize instead of platform dependent unsigned long
* fix header
Marek Safar [Tue, 4 Apr 2017 08:50:56 +0000 (10:50 +0200)]
[System.Core] Linker friendly test update
Marek Safar [Tue, 4 Apr 2017 08:04:48 +0000 (10:04 +0200)]
[Facades] Fixes System.Threading.Overlapped
Marek Safar [Tue, 4 Apr 2017 07:40:16 +0000 (09:40 +0200)]
[System.Core] Remove duplicate files
Marek Safar [Tue, 4 Apr 2017 07:12:51 +0000 (09:12 +0200)]
Bump cecil
Marek Safar [Wed, 29 Mar 2017 13:43:32 +0000 (15:43 +0200)]
[corlib] Port more of corert array