We define IO_APIC_ADDR in <arch/ioapic.h>, let's use it.
[coreboot.git] / src / southbridge / amd / cs5536 / cs5536.c
index 905d71f05206688c5b9fd2bfb6174a32650a0fb0..a2ac44647f4b61c2578b7baabe39fae64755c64e 100644 (file)
@@ -18,6 +18,7 @@
  */
 
 #include <arch/io.h>
+#include <arch/ioapic.h>
 #include <device/device.h>
 #include <device/pci.h>
 #include <device/pci_ops.h>
 #include "cs5536.h"
 
 struct msrinit {
-       uint32_t msrnum;
+       u32 msrnum;
        msr_t msr;
 };
 
 /*     Master Configuration Register for Bus Masters.*/
-struct msrinit SB_MASTER_CONF_TABLE[] = {
+static struct msrinit SB_MASTER_CONF_TABLE[] = {
        {USB2_SB_GLD_MSR_CONF, {.hi = 0,.lo = 0x00008f000}},
        {ATA_SB_GLD_MSR_CONF,  {.hi = 0,.lo = 0x00048f000}},
        {AC97_SB_GLD_MSR_CONF, {.hi = 0,.lo = 0x00008f000}},
@@ -49,7 +50,7 @@ struct msrinit SB_MASTER_CONF_TABLE[] = {
 };
 
 /*     5536 Clock Gating*/
-struct msrinit CS5536_CLOCK_GATING_TABLE[] = {
+static struct msrinit CS5536_CLOCK_GATING_TABLE[] = {
        /* MSR            Setting*/
        {GLIU_SB_GLD_MSR_PM,  {.hi = 0,.lo = 0x000000004}},
        {GLPCI_SB_GLD_MSR_PM, {.hi = 0,.lo = 0x000000005}},
@@ -61,11 +62,11 @@ struct msrinit CS5536_CLOCK_GATING_TABLE[] = {
 };
 
 struct acpiinit {
-       uint16_t ioreg;
-       uint32_t regdata;
+       u16 ioreg;
+       u32 regdata;
 };
 
-struct acpiinit acpi_init_table[] = {
+static struct acpiinit acpi_init_table[] = {
        {ACPI_IO_BASE + 0x00, 0x01000000},
        {ACPI_IO_BASE + 0x08, 0},
        {ACPI_IO_BASE + 0x0C, 0},
@@ -77,7 +78,7 @@ struct acpiinit acpi_init_table[] = {
        {PMS_IO_BASE + PM_SIDD, 0x000008C02},
        {PMS_IO_BASE + PM_WKD, 0x0000000A0},
        {PMS_IO_BASE + PM_WKXD, 0x0000000A0},
-       {0, 0, 0}
+       {0, 0}
 };
 
 struct FLASH_DEVICE {
@@ -86,7 +87,7 @@ struct FLASH_DEVICE {
        unsigned long fMask;    /* Flash size/mask */
 };
 
-struct FLASH_DEVICE FlashInitTable[] = {
+static struct FLASH_DEVICE FlashInitTable[] = {
        {FLASH_TYPE_NAND, FLASH_IF_MEM, FLASH_MEM_4K},  /* CS0, or Flash Device 0 */
        {FLASH_TYPE_NONE, 0, 0},        /* CS1, or Flash Device 1 */
        {FLASH_TYPE_NONE, 0, 0},        /* CS2, or Flash Device 2 */
@@ -95,7 +96,7 @@ struct FLASH_DEVICE FlashInitTable[] = {
 
 #define FlashInitTableLen (ARRAY_SIZE(FlashInitTable))
 
-uint32_t FlashPort[] = {
+static u32 FlashPort[] = {
        MDD_LBAR_FLSH0,
        MDD_LBAR_FLSH1,
        MDD_LBAR_FLSH2,
@@ -111,8 +112,8 @@ uint32_t FlashPort[] = {
 /* ***************************************************************************/
 static void pmChipsetInit(void)
 {
-       uint32_t val = 0;
-       uint16_t port;
+       u32 val = 0;
+       u16 port;
 
        port = (PMS_IO_BASE + 0x010);
        val = 0x0E00;           /*  1ms */
@@ -155,10 +156,10 @@ static void ChipsetFlashSetup(void)
        int i;
        int numEnabled = 0;
 
-       printk_debug("ChipsetFlashSetup: Start\n");
+       printk(BIOS_DEBUG, "ChipsetFlashSetup: Start\n");
        for (i = 0; i < FlashInitTableLen; i++) {
                if (FlashInitTable[i].fType != FLASH_TYPE_NONE) {
-                       printk_debug("Enable CS%d\n", i);
+                       printk(BIOS_DEBUG, "Enable CS%d\n", i);
                        /* we need to configure the memory/IO mask */
                        msr = rdmsr(FlashPort[i]);
                        msr.hi = 0;     /* start with the "enabled" bit clear */
@@ -171,14 +172,14 @@ static void ChipsetFlashSetup(void)
                        else
                                msr.hi &= ~0x00000004;
                        msr.hi |= FlashInitTable[i].fMask;
-                       printk_debug("MSR(0x%08X, %08X_%08X)\n", FlashPort[i],
+                       printk(BIOS_DEBUG, "MSR(0x%08X, %08X_%08X)\n", FlashPort[i],
                                     msr.hi, msr.lo);
                        wrmsr(FlashPort[i], msr);
 
                        /* now write-enable the device */
                        msr = rdmsr(MDD_NORF_CNTRL);
                        msr.lo |= (1 << i);
-                       printk_debug("MSR(0x%08X, %08X_%08X)\n", MDD_NORF_CNTRL,
+                       printk(BIOS_DEBUG, "MSR(0x%08X, %08X_%08X)\n", MDD_NORF_CNTRL,
                                     msr.hi, msr.lo);
                        wrmsr(MDD_NORF_CNTRL, msr);
 
@@ -187,7 +188,7 @@ static void ChipsetFlashSetup(void)
                }
        }
 
-       printk_debug("ChipsetFlashSetup: Finish\n");
+       printk(BIOS_DEBUG, "ChipsetFlashSetup: Finish\n");
 
 }
 
@@ -197,7 +198,7 @@ static void ChipsetFlashSetup(void)
 /*             Run after VSA init to enable the flash PCI device header */
 /* **/
 /* ***************************************************************************/
-static void enable_ide_nand_flash_header()
+static void enable_ide_nand_flash_header(void)
 {
        /* Tell VSA to use FLASH PCI header. Not IDE header. */
        outl(0x80007A40, 0xCF8);
@@ -247,7 +248,7 @@ static void lpc_init(struct southbridge_amd_cs5536_config *sb)
 
        isa_dma_init();
 }
-                       
+
 
 /**
  * Depending on settings in the config struct, enable COM1 or COM2 or both.
@@ -263,8 +264,8 @@ static void uarts_init(struct southbridge_amd_cs5536_config *sb)
        u16 addr = 0;
        u32 gpio_addr;
        device_t dev;
-       
-       dev = dev_find_device(PCI_VENDOR_ID_AMD, 
+
+       dev = dev_find_device(PCI_VENDOR_ID_AMD,
                        PCI_DEVICE_ID_AMD_CS5536_ISA, 0);
        gpio_addr = pci_read_config32(dev, PCI_BASE_ADDRESS_1);
        gpio_addr &= ~1;        /* Clear I/O bit */
@@ -427,11 +428,11 @@ static void uarts_init(struct southbridge_amd_cs5536_config *sb)
 
 static void enable_USB_port4(struct southbridge_amd_cs5536_config *sb)
 {
-       uint8_t *bar;
+       u32 bar;
        msr_t msr;
        device_t dev;
 
-       dev = dev_find_device(PCI_VENDOR_ID_AMD, 
+       dev = dev_find_device(PCI_VENDOR_ID_AMD,
                        PCI_DEVICE_ID_AMD_CS5536_EHCI, 0);
        if (dev) {
 
@@ -443,7 +444,7 @@ static void enable_USB_port4(struct southbridge_amd_cs5536_config *sb)
                /* write to clear diag register */
                wrmsr(USB2_SB_GLD_MSR_DIAG, rdmsr(USB2_SB_GLD_MSR_DIAG));
 
-               bar = (uint8_t *) pci_read_config32(dev, PCI_BASE_ADDRESS_0);
+               bar = pci_read_config32(dev, PCI_BASE_ADDRESS_0);
 
                /* Make HCCPARAMS writeable */
                write32(bar + IPREG04, read32(bar + IPREG04) | USB_HCCPW_SET);
@@ -452,10 +453,10 @@ static void enable_USB_port4(struct southbridge_amd_cs5536_config *sb)
                write32(bar + HCCPARAMS, 0x00005012);
        }
 
-       dev = dev_find_device(PCI_VENDOR_ID_AMD, 
+       dev = dev_find_device(PCI_VENDOR_ID_AMD,
                        PCI_DEVICE_ID_AMD_CS5536_OTG, 0);
        if (dev) {
-               bar = (uint8_t *) pci_read_config32(dev, PCI_BASE_ADDRESS_0);
+               bar = pci_read_config32(dev, PCI_BASE_ADDRESS_0);
 
                write32(bar + UOCMUX, read32(bar + UOCMUX) & PUEN_SET);
 
@@ -480,11 +481,10 @@ static void enable_USB_port4(struct southbridge_amd_cs5536_config *sb)
         * - set PADEN (former OTGPADEN) bit in uoc register
         * - set APU bit in uoc register */
        if (sb->enable_USBP4_device) {
-               dev = dev_find_device(PCI_VENDOR_ID_AMD, 
+               dev = dev_find_device(PCI_VENDOR_ID_AMD,
                                PCI_DEVICE_ID_AMD_CS5536_UDC, 0);
                if (dev) {
-                       bar = (uint8_t *) pci_read_config32(dev, 
-                                       PCI_BASE_ADDRESS_0);
+                       bar = pci_read_config32(dev, PCI_BASE_ADDRESS_0);
                        write32(bar + UDCDEVCTL,
                               read32(bar + UDCDEVCTL) | UDC_SD_SET);
 
@@ -493,42 +493,55 @@ static void enable_USB_port4(struct southbridge_amd_cs5536_config *sb)
                dev = dev_find_device(PCI_VENDOR_ID_AMD,
                                PCI_DEVICE_ID_AMD_CS5536_OTG, 0);
                if (dev) {
-                       bar = (uint8_t *) pci_read_config32(dev,
-                                       PCI_BASE_ADDRESS_0);
+                       bar = pci_read_config32(dev, PCI_BASE_ADDRESS_0);
                        write32(bar + UOCCTL, read32(bar + UOCCTL) | PADEN_SET);
                        write32(bar + UOCCAP, read32(bar + UOCCAP) | APU_SET);
                }
        }
 
        /* Disable virtual PCI UDC and OTG headers */
-       dev = dev_find_device(PCI_VENDOR_ID_AMD, 
+       dev = dev_find_device(PCI_VENDOR_ID_AMD,
                        PCI_DEVICE_ID_AMD_CS5536_UDC, 0);
        if (dev) {
                pci_write_config32(dev, 0x7C, 0xDEADBEEF);
        }
 
-       dev = dev_find_device(PCI_VENDOR_ID_AMD, 
+       dev = dev_find_device(PCI_VENDOR_ID_AMD,
                        PCI_DEVICE_ID_AMD_CS5536_OTG, 0);
        if (dev) {
                pci_write_config32(dev, 0x7C, 0xDEADBEEF);
        }
 }
 
-/* ***************************************************************************/
-/* **/
-/* *   ChipsetInit */
-/*                     Called from northbridge init (Pre-VSA). */
-/* **/
-/* ***************************************************************************/
+/****************************************************************************
+ *
+ *     ChipsetInit
+ *
+ *     Called from northbridge init (Pre-VSA).
+ *
+ ****************************************************************************/
 void chipsetinit(void)
 {
        device_t dev;
        msr_t msr;
-       uint32_t msrnum;
-       struct southbridge_amd_cs5536_config *sb =
-           (struct southbridge_amd_cs5536_config *)dev->chip_info;
+       u32 msrnum;
+       struct southbridge_amd_cs5536_config *sb;
        struct msrinit *csi;
 
+       dev = dev_find_slot(0, PCI_DEVFN(0xf, 0));
+
+       if (!dev) {
+               printk(BIOS_ERR, "CS5536 not found.\n");
+               return;
+       }
+
+       sb = (struct southbridge_amd_cs5536_config *)dev->chip_info;
+
+       if (!sb) {
+               printk(BIOS_ERR, "CS5536 configuration not found.\n");
+               return;
+       }
+
        post_code(P80_CHIPSET_INIT);
 
        /* we hope NEVER to be in coreboot when S3 resumes
@@ -568,7 +581,7 @@ void chipsetinit(void)
        }
 
        /*      Flash BAR size Setup */
-       printk_err("%sDoing ChipsetFlashSetup()\n",
+       printk(BIOS_ERR, "%sDoing ChipsetFlashSetup()\n",
                   sb->enable_ide_nand_flash == 1 ? "" : "Not ");
        if (sb->enable_ide_nand_flash == 1)
                ChipsetFlashSetup();
@@ -596,7 +609,13 @@ static void southbridge_init(struct device *dev)
         * unsigned short gpiobase = MDD_GPIO;
         */
 
-       printk_err("cs5536: %s\n", __func__);
+       printk(BIOS_ERR, "cs5536: %s\n", __func__);
+
+       if (!sb) {
+               printk(BIOS_ERR, "CS5536 configuration not found.\n");
+               return;
+       }
+
        setup_i8259();
        lpc_init(sb);
        uarts_init(sb);
@@ -608,7 +627,7 @@ static void southbridge_init(struct device *dev)
                        (sb->enable_gpio_int_route >> 16));
        }
 
-       printk_err("cs5536: %s: enable_ide_nand_flash is %d\n", __func__,
+       printk(BIOS_ERR, "cs5536: %s: enable_ide_nand_flash is %d\n", __func__,
                   sb->enable_ide_nand_flash);
        if (sb->enable_ide_nand_flash == 1) {
                enable_ide_nand_flash_header();
@@ -618,7 +637,7 @@ static void southbridge_init(struct device *dev)
 
        /* disable unwanted virtual PCI devices */
        for (i = 0; (i < MAX_UNWANTED_VPCI) && (0 != sb->unwanted_vpci[i]); i++) {
-               printk_debug("Disabling VPCI device: 0x%08X\n",
+               printk(BIOS_DEBUG, "Disabling VPCI device: 0x%08X\n",
                             sb->unwanted_vpci[i]);
                outl(sb->unwanted_vpci[i] + 0x7C, 0xCF8);
                outl(0xDEADBEEF, 0xCFC);
@@ -633,34 +652,26 @@ static void cs5536_read_resources(device_t dev)
 
        res = new_resource(dev, 1);
        res->base = 0x0UL;
-       res->size = 0x400UL;
+       res->size = 0x1000UL;
        res->limit = 0xffffUL;
-       res->flags = IORESOURCE_IO |
-                    IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
+       res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
 
        res = new_resource(dev, 3); /* IOAPIC */
-       res->base = 0xfec00000;
+       res->base = IO_APIC_ADDR;
        res->size = 0x00001000;
        res->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
 }
 
 static void southbridge_enable(struct device *dev)
 {
-       printk_err("cs5536: %s: dev is %p\n", __func__, dev);
+       printk(BIOS_ERR, "cs5536: %s: dev is %p\n", __func__, dev);
 
 }
 
-static void cs5536_pci_dev_enable_resources(device_t dev)
-{
-       printk_err("cs5536: %s()\n", __func__);
-       pci_dev_enable_resources(dev);
-       enable_childrens_resources(dev);
-}
-
 static struct device_operations southbridge_ops = {
        .read_resources = cs5536_read_resources,
        .set_resources = pci_dev_set_resources,
-       .enable_resources = cs5536_pci_dev_enable_resources,
+       .enable_resources = pci_dev_enable_resources,
        .init = southbridge_init,
 //      .enable                   = southbridge_enable,
        .scan_bus = scan_static_bus,