From e9e6f95822efe00783a98a9863b57e745b824289 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Fri, 4 Mar 2011 04:28:38 +0530 Subject: [PATCH] [xbuild] LogExtensions.LogError - disambiguate. * LogExtensions.cs(LogError): Rename the 'filename' overload to .. (LogErrorWithFilename): .. this. * Engine.cs: Track api changes. --- .../Microsoft.Build.BuildEngine/Engine.cs | 4 ++-- .../Microsoft.Build.BuildEngine/LogExtensions.cs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/Engine.cs b/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/Engine.cs index 5674cbaed38..47b5ffddffd 100644 --- a/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/Engine.cs +++ b/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/Engine.cs @@ -235,11 +235,11 @@ namespace Microsoft.Build.BuildEngine { result = BuildProjectFileInternal (projectFile, targetNames, globalProperties, targetOutputs, buildFlags, toolsVersion); return result; } catch (InvalidProjectFileException ie) { - this.LogError (projectFile, ie.Message); + this.LogErrorWithFilename (projectFile, ie.Message); this.LogMessage (MessageImportance.Low, String.Format ("{0}: {1}", projectFile, ie.ToString ())); return false; } catch (Exception e) { - this.LogError (projectFile, e.Message); + this.LogErrorWithFilename (projectFile, e.Message); this.LogMessage (MessageImportance.Low, String.Format ("{0}: {1}", projectFile, e.ToString ())); return false; } finally { diff --git a/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/LogExtensions.cs b/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/LogExtensions.cs index e83e82c880c..7577a6ede35 100644 --- a/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/LogExtensions.cs +++ b/mcs/class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine/LogExtensions.cs @@ -51,10 +51,10 @@ namespace Microsoft.Build.BuildEngine public static void LogError (this Engine engine, string message, params object[] messageArgs) { - engine.LogError (null, message, messageArgs); + engine.LogErrorWithFilename (null, message, messageArgs); } - public static void LogError (this Engine engine, string filename, string message, + public static void LogErrorWithFilename (this Engine engine, string filename, string message, params object[] messageArgs) { if (message == null) -- 2.25.1