Marcos Henrich [Tue, 22 Mar 2016 14:41:18 +0000 (14:41 +0000)]
Merge pull request #2764 from esdrubal/fileinfo_tostring
[corlib] Fix FileInfo.ToString after MoveTo
monojenkins [Tue, 22 Mar 2016 01:35:28 +0000 (01:35 +0000)]
Merge pull request #2534 from mhutch/install-api-html
Install mono-api-html
We install its counterpart mono-api-info already
mhutch [Thu, 28 Jan 2016 22:55:35 +0000 (17:55 -0500)]
Install mono-api-html
We install its counterpart mono-api-info already
Andi McClure [Mon, 21 Mar 2016 14:27:40 +0000 (10:27 -0400)]
Merge pull request #2778 from xmcclure/checked-build-updates-2
Fix patch merge error in PR#2753, was breaking checked build
Andi McClure [Mon, 21 Mar 2016 14:24:13 +0000 (10:24 -0400)]
Fix patch merge error in PR#2753, was breaking checked build
Alexander Köplinger [Mon, 21 Mar 2016 13:28:25 +0000 (14:28 +0100)]
Add note about acceptance-tests to top level README
Alexander Köplinger [Sun, 20 Mar 2016 19:20:39 +0000 (20:20 +0100)]
Fix "make dist"
Zoltan Varga [Sat, 19 Mar 2016 22:19:00 +0000 (23:19 +0100)]
[gsharedvt] Add a test for #39528.
Zoltan Varga [Sat, 19 Mar 2016 14:52:20 +0000 (15:52 +0100)]
[runtime] Remove some dead test code added by
c736aba5c94c20e6faad6b736f8e3a834e26d95f.
Zoltan Varga [Sat, 19 Mar 2016 12:03:31 +0000 (13:03 +0100)]
[runtime] Implement support for passing icall methods as delegates in pinvoke. Fixes #39347.
Zoltan Varga [Sat, 19 Mar 2016 11:21:15 +0000 (12:21 +0100)]
[runtime] Remove an mistaken assert. Fixes #39568.
Zoltan Varga [Sat, 19 Mar 2016 11:11:12 +0000 (12:11 +0100)]
[jit] Remove an mistaken assert. Fixes #39746.
monojenkins [Sat, 19 Mar 2016 01:30:17 +0000 (01:30 +0000)]
Merge pull request #2777 from xmcclure/win-makefile-aotcheck
Make `make fullaotcheck` in mono/mini runnable on Windows
Run with
MONO_EXECUTABLE=/path/to/msvc/mono.exe LIST_SEPARATOR=";"
This assumes you are running the test harness in Cygwin and you built mono with MSVC. Also, the test does not currently succeed.
Being able to run the test is a zeroth step toward making the test pass.
Alexander Köplinger [Sat, 19 Mar 2016 01:28:20 +0000 (02:28 +0100)]
[System.Net.Http] Make HttpClientTest.RequestUriAfterRedirect test more reliable
It was the only test in the class that required network access (for looking up xamarin.com in the redirect).
Replacing the redirect target with a second local HttpListener should be more resilient to network/DNS issues.
Andi McClure [Fri, 18 Mar 2016 22:24:41 +0000 (18:24 -0400)]
mono/mini make fullaotcheck can now be run on Windows
Test harness now uses the proper path separator and also now supports
MONO_EXECUTABLE if you built with MSVC.
monojenkins [Fri, 18 Mar 2016 22:00:34 +0000 (22:00 +0000)]
Merge pull request #2753 from xmcclure/checked-build-updates
Changes to "checked build" feature
Here are some changes to checked builds I made while trying to debug some coop gc problems. The changes made are:
- Replace the checked build configure flags with a single --enable-checked-build= flag
- Runtime environment variable required for checked build asserts to run
- Report the thread transition history for more kinds of asserts
- For the `mono_threads_reset_blocking` functions, add an assert that guarantees proper nesting
In addition to this, I have documented the checked build feature as implemented here, see my pull request for the website: https://github.com/mono/website/pull/187
Overall my goals with this patch were
- Make it easier to do rapid-fire testing with the checked builds (runtime switch, default-off)
- Make the checked build implementation more internally consistent (more uniform names etc)
Notice I do make the change that instead of checked build sub-features being disabled with a blacklist, you now must enable them with a whitelist. I think this is an improvement because it makes it easier to just casually keep a checked build around (for one thing I would have the option to ship debug builds to users with the checked build modes included but dormant) but I could be talked out of it if this change turns out to be controversial. The only thing I feel strongly about is that if the configure flag is changed back to a blacklist the environment variable should switch to a blacklist also.
If we accept this change the CI bots will need to adopt the new configure flag and environment variable.
monojenkins [Fri, 18 Mar 2016 22:00:24 +0000 (22:00 +0000)]
Merge pull request #2746 from lambdageek/dev/monoerror-mono_reflection_create_runtime_class
[System.Reflection.Emit] MonoError in mono_reflection_create_runtime_class
Depends on #2745
Bubble MonoError up to `mono_reflection_create_runtime_class`. Use `mono_error_set_pending_exception` instead of `mono_error_raise_exception` And try to release resources on the way out.
Andi McClure [Fri, 18 Mar 2016 19:18:38 +0000 (15:18 -0400)]
Add mono_threads_reset_blocking nesting checks to gc checked mode
Andi McClure [Fri, 18 Mar 2016 20:07:14 +0000 (16:07 -0400)]
Rename checked build assertion_fail to mono_fatal_with_history, use in more places
monojenkins [Fri, 18 Mar 2016 18:15:24 +0000 (18:15 +0000)]
Merge pull request #2772 from WeiHeCN/master
Update mini-llvm.c
These header files are already included in mini-llvm-cpp.h.
WeiHeCN [Fri, 18 Mar 2016 03:40:41 +0000 (11:40 +0800)]
Update mini-llvm.c
Aleksey Kliger [Tue, 8 Mar 2016 22:52:18 +0000 (17:52 -0500)]
[SRE] MonoError for mono_reflection_create_runtime_class
1. Don't raise while holding locks.
2. Change remove_instantiations_of_and_ensure_contents (called via
g_hash_table_foreach_remove) to populate a MonoError instead of
throwing. If there are multiple errors, we just stash the first one
in user_data and clean up the rest.
3. Use mono_erro_set_pending_exception instead of
mono_error_raise_exception since it's an icall.
monojenkins [Thu, 17 Mar 2016 21:35:31 +0000 (21:35 +0000)]
Merge pull request #2745 from lambdageek/dev/monoerror-sre-internals
[System.Reflection.Emit] Propagate MonoError through some more static functions
Some externally visible changes include:
* Bubble MonoError up to one more SRE icall: `System.Reflection.Emit.CustomAttributeBuilder.GetBlob()`
* `fix_partial_generic_class` and `ensure_generic_class_runtime_vtable` now expect their callers to set the class failure state which they do under slightly more circumstances now than previously (now: whenever there's an error set from the above functions; before: only when we had trouble initializing the generic type definition.)
* Previous API for `mono_reflection_bind_generic_parameters` didn't make it clear whether NULL was a valid return value or not. Now when we return NULL we always set the `error` out-arg. So non-NULL is success and NULL is failure.
Aleksey Kliger [Tue, 8 Mar 2016 00:02:34 +0000 (19:02 -0500)]
[reflection] MonoError for mono_marshal_spec_from_builder
Aleksey Kliger [Mon, 7 Mar 2016 21:59:14 +0000 (16:59 -0500)]
[reflection] Mark mono_reflection_get_custom_attrs_blob external only.
The runtime should use mono_reflection_get_custom_attrs_blob_checked.
The icall is now ves_icall_System_Reflection_Emit_CustomAttributeBuilder_GetBlob.
Aleksey Kliger [Mon, 7 Mar 2016 21:16:55 +0000 (16:16 -0500)]
[reflection] MonoError for resolve_object
Aleksey Kliger [Mon, 7 Mar 2016 18:55:00 +0000 (13:55 -0500)]
[reflection] MonoError for ensure_complete_type
Aleksey Kliger [Mon, 7 Mar 2016 18:37:00 +0000 (13:37 -0500)]
[reflection] MonoError for mono_reflection_get_dynamic_overrides
Aleksey Kliger [Mon, 7 Mar 2016 17:07:00 +0000 (12:07 -0500)]
[reflection] MonoError for mono_reflection_method_get_handle
Aleksey Kliger [Mon, 14 Mar 2016 20:28:59 +0000 (13:28 -0700)]
[SRE] Don't set failiure flag in ensure_generic_class_runtime_vtable
Leave it up to the caller to set the flag.
Aleksey Kliger [Mon, 14 Mar 2016 18:50:32 +0000 (11:50 -0700)]
[SRE] Don't set class failure in fix_partial_generic class
Leave it to callers to set it based on the MonoError.
Also return a boolean indicating whether we succeeded or failed.
Aleksey Kliger [Mon, 7 Mar 2016 17:02:18 +0000 (12:02 -0500)]
[reflection] MonoError for fix_partial_generic_class
Aleksey Kliger [Mon, 7 Mar 2016 16:38:06 +0000 (11:38 -0500)]
[SRE] Use MonoError for mono_reflection_bind_generic_parameters
This commit also changes the behavior of
mono_reflection_bind_generic_parameters slightly: if the passed in class
isn't generic, it sets error and returns NULL. (It wasn't clearly
previously whether NULL was an error condition or not - with this commit
we clarify that a NULL result is an error).
Aleksey Kliger [Fri, 4 Mar 2016 21:44:24 +0000 (16:44 -0500)]
[reflection] Use MonoError in encode_{cattr_value,named_val}
Aleksey Kliger [Fri, 4 Mar 2016 21:29:31 +0000 (16:29 -0500)]
[reflection] MonoError in get_{prop,field}_name_and_type
Aleksey Kliger [Fri, 4 Mar 2016 21:21:08 +0000 (16:21 -0500)]
[reflection] MonoError in parameters_to_signature
And a few other static fns
Marek Safar [Thu, 17 Mar 2016 16:13:18 +0000 (17:13 +0100)]
[gacutil] Add support for pdb file
Marek Safar [Thu, 17 Mar 2016 16:07:30 +0000 (17:07 +0100)]
[build] Fix more incomplete mcs references names
Marek Safar [Thu, 17 Mar 2016 15:58:44 +0000 (16:58 +0100)]
[mcs] Allow local variables and parameters on lhs of nameof expression. Fixes #39455
Alexander Köplinger [Thu, 17 Mar 2016 13:08:49 +0000 (14:08 +0100)]
[mono] Remove al2/dmcs from TEST_SUPPORT_FILES too
Alexander Köplinger [Thu, 17 Mar 2016 13:04:00 +0000 (14:04 +0100)]
[mono] Remove dmcs from temp install folder
Marek Safar [Thu, 17 Mar 2016 12:56:53 +0000 (13:56 +0100)]
[mono] Remove al2 from temp install folder
Alexander Köplinger [Thu, 17 Mar 2016 12:55:42 +0000 (13:55 +0100)]
[acceptance-tests] Bump ms-test-suite to pick up
4a95604fdf2c0523e68eaad64a17d22eebb051b3:
Zoltan Varga [Thu, 17 Mar 2016 11:06:02 +0000 (12:06 +0100)]
[runtime] Cleanup the debug info module before the images module since ppdb debug info depends on images. Fixes #39715.
Zoltan Varga [Thu, 17 Mar 2016 10:33:07 +0000 (11:33 +0100)]
[ppdb] Avoid an assert if the ppdb image has an empty guid heap, it can happen if the assembly has no types thus no document guids. Fixes #39644.
Zoltan Varga [Thu, 17 Mar 2016 10:14:41 +0000 (11:14 +0100)]
[arm] Avoid storing fp arguments below the stack pointer if the param area has size 0. Fixes #38161.
Marek Safar [Thu, 17 Mar 2016 09:23:28 +0000 (10:23 +0100)]
Bump referencesource
Aleksey Kliger (λgeek) [Wed, 16 Mar 2016 22:24:00 +0000 (15:24 -0700)]
Merge pull request #2766 from lambdageek/dev/monoerror-jit
[runtime] Propagate error from class loading when JIT-ing
Alexander Köplinger [Wed, 16 Mar 2016 21:15:15 +0000 (22:15 +0100)]
[acceptance-test] Ensure the exit code of the main test script is used
Due to our usage of chained commands it'd use the exit code of the last command,
which is not what we want. We use chaining because e.g. in the ms-test-suite
case we still want to run the systemruntimebringup suite even if the conformance
suite had a failing test.
Aleksey Kliger [Wed, 16 Mar 2016 17:28:04 +0000 (10:28 -0700)]
[runtime] Propagate error from class loading when JIT-ing
This is another approach to
a341404ecdd3b5ca2ed0ab1e9a5bcb9b5ccd2566
which was backed out because it was
stale (
2a899492c30740f6785883fae14bb1ddacbc8b77).
Marek Safar [Wed, 16 Mar 2016 17:34:05 +0000 (18:34 +0100)]
[bcl] Remove wrong IVT attributes
Marek Safar [Wed, 16 Mar 2016 17:18:27 +0000 (18:18 +0100)]
Merge pull request #2765 from akoeplinger/mcs-fix-test-windows-backslash
[compiler-tester] Fix incorrect failure with Windows paths in error messages
Marek Safar [Wed, 16 Mar 2016 14:55:40 +0000 (15:55 +0100)]
Revert "Merge pull request #2454 from tastywheattasteslikechicken/FixVtableAbort"
This reverts commit
a341404ecdd3b5ca2ed0ab1e9a5bcb9b5ccd2566, reversing
changes made to
04a177b2be47ec1de995b3abb8cd378a15590647.
Marek Safar [Wed, 16 Mar 2016 14:42:55 +0000 (15:42 +0100)]
[build] Add missing explicit references in docs
Marcos Henrich [Wed, 16 Mar 2016 10:07:06 +0000 (10:07 +0000)]
[corlib] Fix FileInfo.ToString after MoveTo
Fixes #38796
Marcos Henrich [Wed, 16 Mar 2016 10:04:40 +0000 (10:04 +0000)]
[corlib] Test FileInfo.ToString after MoveTo
Covers #38796
Zoltan Varga [Wed, 16 Mar 2016 09:54:02 +0000 (10:54 +0100)]
Merge pull request #2454 from tastywheattasteslikechicken/FixVtableAbort
[runtime] Fixes an abort caused by a TypeLoadException in certain ins…
Marek Safar [Wed, 16 Mar 2016 09:44:01 +0000 (10:44 +0100)]
[corlib] RuntimeEnvironment from referencesource
Alexander Köplinger [Wed, 16 Mar 2016 02:33:24 +0000 (03:33 +0100)]
[tests] Don't use AppDomain.AppendPrivateBinPath for assembly-load-remap.exe
It's not supposed to contain a full path to a directory, but rather a relative path
to a subdirectory of the ApplicationBase. However, this isn't enforced in all cases
by Mono so setting a full path worked when the path doesn't contain a '.' because then
the code in [1] doesn't clear the variable and the path is added to the domain->search_path.
This caused the test to fail on Wrench on the mono-4.4.0 lane because the path contains
a dot while confusingly it worked fine on master.
Fixing this by appending the xbuild_14 path via an alternative (albeit slightly hacky)
method related to the standard MONO_PATH env var. Because the variable is only read
once at app startup we need to call into the runtime to explicitly set the new path
before trying to load the MSBuild 14 assemblies. This is fine since we only
want to test that the correct assembly version is loaded and nothing else.
[1] https://github.com/mono/mono/blob/
37b2b9fbc25a2199aba1d794117924d4828360a7/mono/metadata/appdomain.c#L1319-L1337
James Venning [Wed, 16 Mar 2016 00:20:36 +0000 (10:20 +1000)]
[runtime] Fixes an abort caused by a TypeLoadException in certain instances
Martin Baulig [Tue, 15 Mar 2016 22:50:08 +0000 (18:50 -0400)]
[System]: Fix certificate validation on Linux. Bug #39307.
Martin Baulig [Sun, 28 Feb 2016 04:53:46 +0000 (23:53 -0500)]
[System]: Properly propagate exceptions in 'MonoTlsStream'.
(cherry picked from commit
a7ab399d093f4aac3f24b862e6075ab9f4fdb9e1)
Martin Baulig [Sun, 28 Feb 2016 03:15:29 +0000 (22:15 -0500)]
[System]: Copy 'ServicePoint.Certificate' and 'ClientCertificate' from the referencesource.
(cherry picked from commit
76e0f64862732c3fb4f5647d5a2687ad9557be45)
Martin Baulig [Thu, 18 Feb 2016 22:44:16 +0000 (17:44 -0500)]
[System]: In 'WebConnection.EndWrite()': always call EndWrite() on the underlying socket.
(cherry picked from commit
dd9d66a7c28ba77bf5ef7e4d7f6cb60ca3feb5a9)
Alexander Köplinger [Tue, 15 Mar 2016 20:16:24 +0000 (21:16 +0100)]
[System.Net.Http] Make HttpClientTest.GetString_Many test more reliable
It's flaky on Jenkins, removing the dependency on an external server and instead using a local HttpListener
to answer the requests should hopefully make it more reliable.
Marek Safar [Tue, 15 Mar 2016 20:05:58 +0000 (21:05 +0100)]
Marek Safar [Tue, 15 Mar 2016 17:41:43 +0000 (18:41 +0100)]
[mcs] Don't sign sqlmetal and linker tools
Marek Safar [Tue, 15 Mar 2016 17:06:49 +0000 (18:06 +0100)]
[compiler-tester] Expand members error reporting to avoid problems with members called {}
monojenkins [Tue, 15 Mar 2016 17:00:19 +0000 (17:00 +0000)]
Merge pull request #2747 from lambdageek/dev/monoerror-mono_remote_class
[runtime] Add MonoError to mono_remote_class
Alexander Köplinger [Tue, 15 Mar 2016 14:44:10 +0000 (15:44 +0100)]
[tools] Don't install cil-stringreplacer
It's a tool that is only used during the Mono class lib build.
Miguel de Icaza [Tue, 15 Mar 2016 14:25:57 +0000 (10:25 -0400)]
[getline] Fix condition where Console.WriteLi<TAB><ENTER> completed to Console.WriteLinene
Miguel de Icaza [Tue, 15 Mar 2016 14:22:20 +0000 (10:22 -0400)]
[repl] Further fine tuning; Show newlines as actual newlines in strings, plus fix quoting of chars < 32
Miguel de Icaza [Tue, 15 Mar 2016 14:11:55 +0000 (10:11 -0400)]
[repl] Do not escape space when pretty printing strings
Marek Safar [Tue, 15 Mar 2016 12:58:30 +0000 (13:58 +0100)]
[build] Use full filename for csc references
Marek Safar [Tue, 15 Mar 2016 12:55:59 +0000 (13:55 +0100)]
[compiler-tester] Remove moonlight build
Marek Safar [Tue, 15 Mar 2016 12:55:30 +0000 (13:55 +0100)]
[monodoc] Remove redundant codepage argument
Marek Safar [Tue, 15 Mar 2016 12:53:54 +0000 (13:53 +0100)]
[System.Xml.Linq] Simplify dependencies
Marek Safar [Tue, 15 Mar 2016 12:50:00 +0000 (13:50 +0100)]
[Mono.Security.Providers.NewSystemSource] Use LIB_REFS to track references
Marek Safar [Tue, 15 Mar 2016 12:48:24 +0000 (13:48 +0100)]
[system.runtime.serialization] Use correct IVT key for System.ServiceModel.Web
Alex Rønne Petersen [Tue, 15 Mar 2016 11:41:02 +0000 (12:41 +0100)]
Merge pull request #2543 from ermshiperete/Xamarin-31021
Don't ignore drives with type "aufs" or "overlay" (Xamarin-31021)
Alexander Köplinger [Tue, 15 Mar 2016 00:16:54 +0000 (01:16 +0100)]
Merge pull request #2757 from akoeplinger/fix-coreclr-test
Two coreclr test fixes
Zoltan Varga [Mon, 14 Mar 2016 21:52:16 +0000 (22:52 +0100)]
Fix the build.
Alexander Köplinger [Sun, 13 Mar 2016 01:42:26 +0000 (02:42 +0100)]
[corlib] Fix Delegate.Combine() to throw on non-matching types
This was inadvertently removed in https://github.com/mono/mono/commit/
611a43ee0f672adbac3e25dc77731843a3d10cf1 from MulticastDelegate.CombineImpl().
Add the type check back in the Delegate base class, we already do the same in Remove().
Add unit tests to cover the behavior to the corlib test suite. (reverted from commit
f29878dc713f4e148fe0a1e703fae8929e6fb6e0)
Needed to update some monodoc tests to match that an exception is now thrown again.
Andi McClure [Mon, 14 Mar 2016 18:12:24 +0000 (14:12 -0400)]
Merge pull request #2755 from xmcclure/disable-omit-fp
"disable_omit_fp" option for MONO_DEBUG
Marek Safar [Mon, 14 Mar 2016 17:47:22 +0000 (18:47 +0100)]
Merge pull request #2750 from radical/tasklogger
[xbuild] TaskLoggingHelper: Implement support for correctly using tas…
Ankit Jain [Thu, 10 Mar 2016 19:33:52 +0000 (14:33 -0500)]
[xbuild] TaskLoggingHelper: Implement support for correctly using task resources
- make task resources available to TaskLoggingHelper
- verify TaskLoggingHelper method args
- tests
Zoltan Varga [Mon, 14 Mar 2016 15:22:09 +0000 (16:22 +0100)]
[jit] Remove some loader error usage.
Alexander Köplinger [Sun, 13 Mar 2016 02:06:52 +0000 (03:06 +0100)]
[corlib] Fix UIntPtr.ToString() 64bit implementation
Cast to ulong instead of uint, this is also what referencesource does:
https://github.com/Microsoft/referencesource/blob/
d925d870f3cb3f6acdb14e71522ece7054e2233b/mscorlib/system/uintptr.cs#L114-L122
Also bump coreclr submodule to bring in another UIntPtr fix.
Marek Safar [Mon, 14 Mar 2016 12:34:48 +0000 (13:34 +0100)]
[mcs] Better check for automatically implemented property inside a type with an explicit StructLayout. Fixes #39574
Marek Safar [Mon, 14 Mar 2016 11:35:04 +0000 (12:35 +0100)]
[system.net.http] The backslash character may be used as a single-character quoting mechanism within quoted-string. Fixes #39569
Zoltan Varga [Mon, 14 Mar 2016 09:15:33 +0000 (10:15 +0100)]
Fix the build.
monojenkins [Mon, 14 Mar 2016 04:35:14 +0000 (04:35 +0000)]
Merge pull request #2754 from markusbeth/fix-mono-config
fixed replacement of $mono_libdir in config file
strncpy does not NUL-terminate the destination string in this case so one cannot use strcat to append
This fixes the error "malloc: top chunk is corrupt" as reported on mono-devel-list back in 2015-10-20 (subject: "malloc error executing OBS-built mono") at least for me.
monojenkins [Sun, 13 Mar 2016 20:35:18 +0000 (20:35 +0000)]
Merge pull request #2756 from vargaz/llvm-jit-3.9
[llvm] Finish JIT support for llvm 3.9.
Zoltan Varga [Sun, 13 Mar 2016 18:49:10 +0000 (19:49 +0100)]
[llvm] Finish JIT support for llvm 3.9.
Bernhard Urban [Sat, 12 Mar 2016 00:05:36 +0000 (16:05 -0800)]
[mono-config] fix copying of prefix during replacement
Alexander Köplinger [Sat, 12 Mar 2016 00:03:14 +0000 (01:03 +0100)]
[acceptance-tests] Bump coreclr and ms-test-suite to bring in some fixes
Also disable a test that makes no sense.
monojenkins [Fri, 11 Mar 2016 23:05:20 +0000 (23:05 +0000)]
Merge pull request #2752 from kumpera/the_loader_error_highlander
This removed the last source of loader error from the runtime
The last source was on the AOT compiler in load_image.
I hooked enough MonoError to bubble the issue to a reasonably higher layer.
@vargaz please review.
Markus Beth [Fri, 11 Mar 2016 21:52:34 +0000 (22:52 +0100)]
fixed more srtncpy bugs
Rodrigo Kumpera [Fri, 11 Mar 2016 21:25:06 +0000 (16:25 -0500)]
Merge pull request #2740 from lambdageek/dev/monoerror-reflection-icalls1
[reflection] MonoError for a few icalls
Rodrigo Kumpera [Fri, 11 Mar 2016 21:06:25 +0000 (16:06 -0500)]
Merge pull request #2739 from lambdageek/dev/monoerror-type_load_class
[MonoError] Use class name for mono_error_set_type_load_class() exceptions