Rolf Bjarne Kvinge [Fri, 27 Nov 2015 08:40:15 +0000 (09:40 +0100)]
[mscorlib][System] Use PlatformNotSupportedException instead of NotSupportedException when it makes sense.
Sebastien Pouliot [Thu, 26 Nov 2015 19:55:00 +0000 (14:55 -0500)]
[System][ios] Disable non-working Ping code (and non-existing DllImport)
* capget is not part of libc (libSystem.dylib) on iOS (or OSX); and
* There's no working Process class to invoke `ping` by itself leading to
[FAIL] DllImportTest.LackOfCapget : System.InvalidOperationException : Process has not been started.
at System.Diagnostics.Process.get_HasExited () [0x00039] in /Users/poupou/git/xamarin/maccore/_build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/System/System.Diagnostics/Process.cs:184
It's technically possible to implement ping on iOS [1] so the code is
not totally removed from the build (API remains identical to existing).
[1] https://bugzilla.xamarin.com/show_bug.cgi?id=964
Marek Safar [Thu, 26 Nov 2015 18:52:25 +0000 (19:52 +0100)]
[mcs] Fixes codegen for lifted bitwise operators which are liften only due to null operand
Sebastien Pouliot [Thu, 26 Nov 2015 16:45:04 +0000 (11:45 -0500)]
[Mono.Data.Sqlite] Remove p/invokes to symbols that are not available on iOS version of libsqlite3
/usr/lib/libsqlite3.dylib: 77 symbols
[NOT FOUND] sqlite3_column_database_name
[NOT FOUND] sqlite3_column_database_name16
[NOT FOUND] sqlite3_column_origin_name
[NOT FOUND] sqlite3_column_origin_name16
[NOT FOUND] sqlite3_column_table_name
[NOT FOUND] sqlite3_column_table_name16
[NOT FOUND] sqlite3_key
[NOT FOUND] sqlite3_rekey
note: XI has unit tests that will detect if those symbols are added in a
future version of iOS.
Sebastien Pouliot [Thu, 26 Nov 2015 16:37:03 +0000 (11:37 -0500)]
[mscorlib] Do not include several win32-p/invoke calls (AccessControl) for the mobile profile
Sebastien Pouliot [Thu, 26 Nov 2015 16:34:41 +0000 (11:34 -0500)]
[mscorlib] Do not include a win32-p/invoke call (GetFullPathName) for the mobile profile
Marek Safar [Thu, 26 Nov 2015 10:37:02 +0000 (11:37 +0100)]
[mcs] Fix null coalescing operator on cast of source expression resolved to implicit user operator conversion. Fixes #36161
Zoltan Varga [Thu, 26 Nov 2015 03:04:45 +0000 (22:04 -0500)]
Revert "[aot] Cache inflated methods loaded from aot images to avoid repeating an expensive search. Fixes #36256."
This reverts commit
d4828b42f0f777049abdba402a7a591fd24bcdac.
Revert this as it causes test failures.
Zoltan Varga [Thu, 26 Nov 2015 03:04:31 +0000 (22:04 -0500)]
[jit] Comment out a call to mono_debug_count (), it should only be enabled during debugging.
Martin Baulig [Wed, 25 Nov 2015 23:45:31 +0000 (18:45 -0500)]
[Mono.Security]: Actually rename MonoSslStream.cs into IMonoSslStream.cs.
(cherry picked from commit
6609e2719437fe2bc20546908053fb4c4f7f80d2)
Zoltan Varga [Wed, 25 Nov 2015 22:31:34 +0000 (17:31 -0500)]
[aot] Cache inflated methods loaded from aot images to avoid repeating an expensive search. Fixes #36256.
Martin Baulig [Wed, 25 Nov 2015 20:06:45 +0000 (15:06 -0500)]
[Mono.Security]: Rename 'Mono.Security.Interface.MonoSslStream' into 'IMonoSslStream' and make it an interface.
(cherry picked from commit
aa2166908a4c377d423b05aa75bc021e45d94c06)
Martin Baulig [Fri, 20 Nov 2015 18:52:01 +0000 (13:52 -0500)]
[Mono.Security]: Add a few more 'Mono.Security.Interface' APIs.
The following general-purpose enums and exception helpers were moved
here from Mono.Security.NewTls.Interface, which is going away.
* Alert, CipherAlgorithmType, CipherSuiteCode, ExchangeAlgorithmType,
HashAlgorithmType, TlsConnectionInfo, TlsException, TlsProtocolCode,
TlsProtocols.
* TlsConnectionInfo has been merged into MonoTlsConnectionInfo.
Note that you may not use 'using' statements for both 'Mono.Security.Interface'
and 'System.Security.Authentication' due to conflicting types. Use a prefix such as
"using MSI = Mono.Security.Interface;" or "using SSA = System.Security.Authentication;"
if you need both namespaces.
(cherry picked from commit
af05134433c658c93f82c6f4d47b93bb4b83257f)
Martin Baulig [Wed, 25 Nov 2015 19:51:19 +0000 (14:51 -0500)]
[System]: Make $(the_libdir_base)Mono.Security.dll depend on ../Mono.Security/Makefile.
(cherry picked from commit
77477b0e2b64bee3b75ed20c69e6f52e121df03f)
Marek Safar [Wed, 25 Nov 2015 18:04:04 +0000 (19:04 +0100)]
[System.Data] Implement CommandBehavior.SequentialAccess support for GetValues method. Fixes #35857
Zoltan Varga [Wed, 25 Nov 2015 17:31:35 +0000 (12:31 -0500)]
[aot] Escape some characters in method names to avoid assembler problems with obfuscated assemblies. Fixes #36247.
Rolf Bjarne Kvinge [Wed, 25 Nov 2015 16:57:33 +0000 (17:57 +0100)]
[System.Data] Try to fix random DataViewTest.DefaultColumnNameAddListChangedTest failure.
It looks like the GC might be involved somehow in these random
failures, so make sure objects aren't freed too early.
Rolf Bjarne Kvinge [Wed, 25 Nov 2015 13:03:56 +0000 (14:03 +0100)]
[System] Fix SmtpClientTest.Deliver_Async to not require main thread processing.
Rolf Bjarne Kvinge [Tue, 6 Oct 2015 12:56:38 +0000 (14:56 +0200)]
[System] Remove Process.Start and related API from TvOS/WatchOS.
Rolf Bjarne Kvinge [Tue, 24 Nov 2015 18:49:27 +0000 (19:49 +0100)]
[corlib] Re-introduce Thread.Abort/Suspend/Resume, but make them throw NotSupportedException instead.
Re-introduce Thread.Abort/Suspend/Resume so that we don't have to
create separate PCL profiles.
Instead make them throw a NotSupportedException, and add an
[Obsolete (error: true)] attribute so that these methods can't
be used from source.
Rolf Bjarne Kvinge [Fri, 20 Nov 2015 15:56:25 +0000 (16:56 +0100)]
[System] Tweak tests to work with Thread.Interrupt as well.
Rolf Bjarne Kvinge [Fri, 20 Nov 2015 15:56:06 +0000 (16:56 +0100)]
[System] Don't throw SocketExceptions when we're stopping.
Zoltan Varga [Tue, 24 Nov 2015 23:42:44 +0000 (18:42 -0500)]
[aot] Handle gsharedvt versions of delegate invoke wrappers correctly, there could be multiple copies of them for the same class. Fixes #36125.
Marek Safar [Tue, 24 Nov 2015 21:48:09 +0000 (22:48 +0100)]
Merge pull request #2263 from akoeplinger/net_4_6.xml
[xbuild] Add net_4.6.xml/net_4.6.1.xml and wire through xbuild
Martin Baulig [Fri, 20 Nov 2015 18:27:55 +0000 (13:27 -0500)]
[Mono.Security]: Minor 'Mono.Security.Interface' API improvements.
* MonoTlsSettings: Add static 'DefaultSettings' and CopyDefaultSettings().
* MonoTlsProvider: Add 'ID' and 'Name' properties.
(cherry picked from commit
51226c86f9f402e7bf09aefeeac7c24ca52bfdbd)
Martin Baulig [Tue, 24 Nov 2015 19:22:50 +0000 (14:22 -0500)]
[System]: Allow null 'settings' argument in ChainValidationHelper.
(cherry picked from commit
9d6b03a587b0230eb66404f611ff09616832c8d3)
Jonathan Pryor [Tue, 24 Nov 2015 19:03:20 +0000 (14:03 -0500)]
Merge pull request #2264 from xmcclure/fix-testwaitany-mini
Minimal fix for sporadic Mono.Unix.UnixSignalTest.TestWaitAny crashes (bug #35936)
Andi McClure [Tue, 24 Nov 2015 18:46:19 +0000 (13:46 -0500)]
Don't fsync() on a pipe (causes bug #35936)
fsync() on a file descriptor from a pipe() is invalid, and
occasionally crashes on current OS X.
Alexander Köplinger [Tue, 24 Nov 2015 16:49:29 +0000 (17:49 +0100)]
[xbuild] Add net_4.6.xml/net_4.6.1.xml and wire through xbuild
Commented the entries in ToolLocationHelper, they could be misunderstood since the 4.0/4.5/4.6 entries are all the same.
Alexander Köplinger [Tue, 24 Nov 2015 16:53:48 +0000 (17:53 +0100)]
[System.ComponentModel.DataAnnotations] Update tests to match the new strings from
21a3421f4c1a40a0b3af25e2533e3fef72e31869
Sebastien Pouliot [Tue, 24 Nov 2015 14:37:46 +0000 (09:37 -0500)]
[system][monodroid] Remove reference to Win32NetworkInterfaceAPI (as the type was removed from the profile earlier)
Sebastien Pouliot [Sun, 22 Nov 2015 22:05:08 +0000 (17:05 -0500)]
[system.net.http] Make HttpClient a partial class and skip default .ctor when building for iOS
Alexander Köplinger [Tue, 24 Nov 2015 14:26:39 +0000 (15:26 +0100)]
Merge pull request #2208 from martinbooth/dataannotation_strings_from_corefx_without_resx
[System.ComponentModel.DataAnnotations] Replaced data annotation error messages with values extracted from corefx resource file
Alexander Köplinger [Tue, 24 Nov 2015 14:16:03 +0000 (15:16 +0100)]
Merge pull request #2248 from barsgroup/bugfix/35980
CSharpCodeCompiler should treat multi-line warning messages as warnings
Dmitry Kalyanov [Wed, 18 Nov 2015 13:04:46 +0000 (16:04 +0300)]
CSharpCodeCompiler should not treat multi-line warnings from mcs as internal compiler errors.
Most errors and warnings from c# compiler are reported in one line in format "FILE(LINE, COL): warning CS1234: Text".
But some warning span multiple lines:
/tmp/
3fb23cc0/
634d2022.0.cs(22,29): warning CS0114: `NS.B.F()' hides inherited member `NS.A.F()' ..
/tmp/
3fb23cc0/
634d2022.0.cs(16,29): (Location of the symbol related to previous warning)
Previously the second line was considered to be an internal compiler error since it doesn't match the error regex.
This seems to be only type of messages that span multiple lines.
This fixes #35980
Zoltan Varga [Tue, 24 Nov 2015 02:18:40 +0000 (21:18 -0500)]
[llvm] Fix the mapping of byref types.
Jonathan Pryor [Mon, 23 Nov 2015 20:31:02 +0000 (15:31 -0500)]
Merge pull request #2259 from xmcclure/modet-pointer
Fix unsafe pointer conversion in sys-stat.c
Andi McClure [Mon, 23 Nov 2015 19:33:44 +0000 (14:33 -0500)]
Fix sys-stat.c where a pointer to a mode_t (potentially an int16) was being unsafely converted to an int32 pointer
Andi McClure [Mon, 23 Nov 2015 19:27:18 +0000 (14:27 -0500)]
Improve nunit error reporting in case of a test returning a null results object in the absence of an exception.
Zoltan Varga [Sun, 22 Nov 2015 14:04:18 +0000 (09:04 -0500)]
[runtime] Fix non-byref LPArray marshalling. Fixes #36128.
Alexander Köplinger [Sun, 22 Nov 2015 14:01:04 +0000 (15:01 +0100)]
Merge pull request #2255 from directhex/override-mono-wrapper
Allow mono-wrapper executable to be overridden by environment
Zoltan Varga [Sat, 21 Nov 2015 15:13:52 +0000 (10:13 -0500)]
[ji] Add a mini-llvm.h header file for the functions implemented by the LLVM backend.
Zoltan Varga [Sat, 21 Nov 2015 14:30:45 +0000 (09:30 -0500)]
[runtime] Implement FIXMEs in the portable ppdb code.
Zoltan Varga [Sat, 21 Nov 2015 13:32:24 +0000 (08:32 -0500)]
[runtime] Fix the loading of ppdb files.
Zoltan Varga [Sat, 21 Nov 2015 11:53:50 +0000 (06:53 -0500)]
[aot] Fix support for runtime invokes to array accessors of reference arrays. Fixes #35855.
Marek Safar [Sat, 21 Nov 2015 09:46:20 +0000 (10:46 +0100)]
[system] Bump uri limit to match .net. Fixes #36095
Alexis Christoforides [Sat, 21 Nov 2015 02:40:07 +0000 (21:40 -0500)]
[mkbundle] Improved support for Windows
Sebastien Pouliot [Sat, 21 Nov 2015 02:33:49 +0000 (21:33 -0500)]
[System.Data] Remove some win32-specific p/invokes for the mobile profile
This reduce the size of System.dll and also removes some Win32 specific
p/invokes.
They cause native linking issues for tvOS as Xcode 7.1 does not allow
`-u` in bitcode-enabled builds so we have to call directly the symbols
and it must exists at (native) link time.
**Incomplete** (some remains) but enough so we can run LinkSDK and
System.Data unit tests apps (the managed linker can remove the rest)
Miguel de Icaza [Sat, 21 Nov 2015 01:31:18 +0000 (20:31 -0500)]
[mdoc] Add some diagnostics
Marek Safar [Fri, 20 Nov 2015 23:18:21 +0000 (00:18 +0100)]
[corlib] Bump reference source for .net 4.6 hotfix. Fixes #36003
Zoltan Varga [Fri, 20 Nov 2015 22:48:56 +0000 (17:48 -0500)]
[runtime] Use the standard __MOBILE__ define instead of MOBILE for the mini tests.
Sebastien Pouliot [Fri, 20 Nov 2015 16:57:48 +0000 (11:57 -0500)]
[System] Remove internal Win32* classes from mobile builds
This reduce the size of System.dll and also removes some Win32 specific
p/invokes.
They cause native linking issues for tvOS as Xcode 7.1 does not allow
`-u` in bitcode-enabled builds so we have to call directly the symbols
and it must exists at (native) link time.
Sebastien Pouliot [Fri, 20 Nov 2015 15:07:37 +0000 (10:07 -0500)]
[System.ServiceModel.Internals] Do not include win32 p/invokes in mobile builds
This cause native linking issues for tvOS as Xcode 7.1 does not allow
`-u` in bitcode-enabled builds so we have to call directly the symbols
and it must exists at (native) link time.
Rolf Bjarne Kvinge [Fri, 20 Nov 2015 13:19:16 +0000 (14:19 +0100)]
[runtime] Revert breaking changes in MonoGHashGCType.
Xamarin.iOS and Xamarin.Mac uses this enum, and changing the values
causes us to break.
For Xamarin.Mac apps that do not bundle their mono, this would break
when the user updated their system mono.
Rolf Bjarne Kvinge [Fri, 20 Nov 2015 11:20:01 +0000 (12:20 +0100)]
[System.Drawing] Add ifdefs to source code used by Xamarin.iOS/Mac to make it compile there.
Zoltan Varga [Fri, 20 Nov 2015 11:15:56 +0000 (06:15 -0500)]
[aot] Add instances of LongEnumEqualityComparer which is used by EqualityComparer to compare long/ulong based enums.
Jo Shields [Fri, 20 Nov 2015 11:04:10 +0000 (11:04 +0000)]
Allow mono-wrapper executable to be overridden by environment
This makes it easier to force Cygwin-brokered test suite runs to use MSVC builds of Mono, i.e. by overriding MONO_EXECUTABLE to .../msvc/bin/Win32/mono-sgen.exe
Marek Safar [Fri, 20 Nov 2015 09:42:16 +0000 (10:42 +0100)]
Merge pull request #2254 from Sebmaster/fix-datasourceview
Fix NullReferenceException when reader fails in SqlDataSourceView
Zoltan Varga [Fri, 20 Nov 2015 07:29:39 +0000 (02:29 -0500)]
[corlib] Disable an attribute test which fails on mobile because of linking.
Alexander Köplinger [Fri, 20 Nov 2015 01:17:29 +0000 (02:17 +0100)]
[msvc] Remove outdated projects and configs to fix x64 build
Some of the profiler projects are no longer needed since the corresponding pieces were removed.
Update sln to only build required projects by default and update configurations in projects.
Fixes the Win64 build on Jenkins.
Sebastian Mayr [Fri, 20 Nov 2015 00:53:02 +0000 (01:53 +0100)]
Fix NullReferenceException when reader fails
If the reader execution in the try block fails, reader will stay null, but we later try to access reader.RecordsAffected. This raises a null reference exception which hides the original exception, making this particularly hard to detect.
Martin Baulig [Thu, 19 Nov 2015 20:19:42 +0000 (15:19 -0500)]
[System]: Implement X509Certificate2.Export(X509ContentType.Pfx).
(cherry picked from commit
e51b4ec6853e7e7ae6f7e862275a282a8c1e7904)
Zoltan Varga [Thu, 19 Nov 2015 19:19:08 +0000 (14:19 -0500)]
[x86] Fix OP_IMUL_OVF_UN clobbering edx in some cases. Fixes #36052.
Rolf Bjarne Kvinge [Thu, 19 Nov 2015 15:24:39 +0000 (16:24 +0100)]
Fix mcs build to use Thread.Abort.
Rolf Bjarne Kvinge [Thu, 19 Nov 2015 15:19:52 +0000 (16:19 +0100)]
Remove Thread API from the watch/tv runtime profiles as well.
Jonathan Pryor [Thu, 19 Nov 2015 15:39:54 +0000 (10:39 -0500)]
Merge pull request #2183 from joelmartinez/monodoc-ecmacref-fix
[monodoc] Fixed several issues with `.ToEcmaCref` method.
Jo Shields [Thu, 19 Nov 2015 14:20:21 +0000 (14:20 +0000)]
[msvc] Fix path to ml64.exe in masm.fixed.props
Miguel de Icaza [Thu, 19 Nov 2015 14:12:10 +0000 (09:12 -0500)]
Bring the Asin/Acos fix from CoreFX
Marek Safar [Thu, 19 Nov 2015 13:54:02 +0000 (14:54 +0100)]
[corlib] Update long/short timepatterns. Reference source DateTimeInfo uses different logic for single pattern extraction. Fixes part of #36003
Rolf Bjarne Kvinge [Tue, 6 Oct 2015 11:47:37 +0000 (13:47 +0200)]
Remove Thread.[Abort|Suspend|Resume] from TvOS/WatchOS.
In tests replace usages of Thread.Abort with Thread.Interrupt when it looks
like it can work, otherwise just disable the complete test.
Zoltan Varga [Thu, 19 Nov 2015 11:09:42 +0000 (06:09 -0500)]
[aot] Fix support for synchronized wrappers of gsharedvt methods.
Rolf Bjarne Kvinge [Thu, 19 Nov 2015 09:23:03 +0000 (10:23 +0100)]
[mono-api-info] Take return type into account when comparing methods.
Rolf Bjarne Kvinge [Thu, 19 Nov 2015 09:00:20 +0000 (10:00 +0100)]
[mono-api-info] Take into account parameters when sorting properties.
Rolf Bjarne Kvinge [Thu, 19 Nov 2015 08:59:36 +0000 (09:59 +0100)]
[mono-api-info] Sort attributes.
So that info files can be compared textually to test for api equality.
Zoltan Varga [Thu, 19 Nov 2015 07:00:23 +0000 (02:00 -0500)]
[jit] Fix memory leaks in the generic sharing code by making sure that values stored into an rgctx slot are never NULL, since otherwise the runtime would recompute them on every access. Fixes #36000.
Zoltan Varga [Thu, 19 Nov 2015 06:52:37 +0000 (01:52 -0500)]
[jit] Fix the gsharedvtcheck make target.
Alexander Köplinger [Wed, 18 Nov 2015 19:26:29 +0000 (11:26 -0800)]
[metadata] Remove unused empty struct from marshal.h
It breaks MSVC.
Alexander Köplinger [Wed, 18 Nov 2015 19:39:57 +0000 (11:39 -0800)]
[mini] Add MONO_API to mono_parse_env_options
We need this exported for our multi lib setup in MSVC.
Alexander Köplinger [Wed, 18 Nov 2015 22:18:15 +0000 (23:18 +0100)]
[msvc] Remove obsolete jay project files
We're requiring VS2013 now.
Alexander Köplinger [Wed, 18 Nov 2015 21:56:25 +0000 (13:56 -0800)]
[msvc] Fix msbuild warnings
OutDir/IntDir should end with trailing slash.
Don't override Linker OutputFile, instead copy jay via a PostBuildEvent to the correct dir.
Alexander Köplinger [Wed, 18 Nov 2015 19:51:55 +0000 (20:51 +0100)]
[msvc] Add missing files to libmonoutils.vcxproj
Alexander Köplinger [Wed, 18 Nov 2015 19:25:32 +0000 (11:25 -0800)]
[msvc] Update .def files
Sebastien Pouliot [Wed, 18 Nov 2015 17:30:27 +0000 (12:30 -0500)]
[tests] Skip Local name (incorrect) assumption for iOS/tvOS/watchOS/OSX in TimeZoneInfo tests
Zoltan Varga [Wed, 18 Nov 2015 16:48:33 +0000 (11:48 -0500)]
[runtime] Fix multiple inclusion of object-offsets.h
Ludovic Henry [Wed, 18 Nov 2015 13:57:25 +0000 (13:57 +0000)]
Merge pull request #2243 from konrad-kruczynski/process_exited_should_wait_in_background
Process.cs: adding a handler to Exited will make the program wait for the process to exit
Konrad M. Kruczynski [Wed, 18 Nov 2015 12:44:49 +0000 (13:44 +0100)]
Caller of Exited event should wait for process to exit in background.
Otherwise simply adding an event will make our program to live at least as long
as the created process lives.
Rolf Bjarne Kvinge [Tue, 6 Oct 2015 11:44:03 +0000 (13:44 +0200)]
[System] Exclude code that tries to load System.Windows.Forms.dll dynamically on mobile.
It won't succeed anyway.
Zoltan Varga [Wed, 18 Nov 2015 12:26:28 +0000 (07:26 -0500)]
[aot] Fix another memory leak.
Zoltan Varga [Wed, 18 Nov 2015 11:24:30 +0000 (06:24 -0500)]
Zoltan Varga [Wed, 18 Nov 2015 09:23:53 +0000 (04:23 -0500)]
Zoltan Varga [Wed, 18 Nov 2015 05:34:03 +0000 (00:34 -0500)]
[runtime] Add a DECL_SIZE2 macro usable from offsets files.
Zoltan Varga [Wed, 18 Nov 2015 05:06:49 +0000 (00:06 -0500)]
[runtime] Fix the lookup of nested types in type forwarders. Fixes #35447.
Zoltan Varga [Wed, 18 Nov 2015 03:54:02 +0000 (22:54 -0500)]
Fix a warning.
Zoltan Varga [Wed, 18 Nov 2015 03:36:22 +0000 (22:36 -0500)]
[aot] Fix a memory leak in init_amodule_got ().
Ludovic Henry [Wed, 18 Nov 2015 00:25:15 +0000 (00:25 +0000)]
Revert "[sgen] Remove sgen specific suspend code"
This reverts commit
64af68dd8d7ba888ad9e5d35dc9714df6f9d5963.
Martin Baulig [Tue, 17 Nov 2015 21:42:38 +0000 (16:42 -0500)]
Actually, really fix my last build - sorry for the breakage.
(cherry picked from commit
e95a4a2e35922fd68b3abf7b49685a93eebf599f)
Martin Baulig [Tue, 17 Nov 2015 21:04:48 +0000 (16:04 -0500)]
Fix my last commit.
(cherry picked from commit
4a5da6f7639a2ebeb4f7ac69fadec5be58a566a6)
Alexander Köplinger [Tue, 17 Nov 2015 21:03:53 +0000 (22:03 +0100)]
Merge pull request #2236 from akoeplinger/add-dataflow
[System.Threading.Tasks.Dataflow] Replace implementation with CoreFx version
Martin Baulig [Tue, 17 Nov 2015 18:43:16 +0000 (13:43 -0500)]
[Mono.Security]: Add 'X509Chain' to ICertificateValidator.InvokeSystemValidator and MonoTlsProvider.InvokeSystemCertificateValidator.
On OS X and Mobile, the X509Chain will be initialized with all the
certificates from the X509CertificateCollection, but not actually
built.
ServicePointManager.ServerCertificateValidationCallback can use the 'chain' argument
to get all the certificates from the server.
(cherry picked from commit
73e37f0ecfd403780d60f36d8b0d68f27987b256)
Martin Baulig [Tue, 17 Nov 2015 02:39:39 +0000 (21:39 -0500)]
[Mono.Security]: The default value of 'MonoTlsSettings.UseServicePointManagerCallback' is supposed to be true.
This fixes a regression where ServicePointManager.ServerCertificateValidationCallback
was not called when using WebClient.
(cherry picked from commit
5022db1956cd7dbde46928473800ff5b5e6b651e)