mono.git
10 years agoMerge pull request #829 from symform/httpwebreq-async-ssl
Sebastien Pouliot [Fri, 7 Feb 2014 21:48:05 +0000 (16:48 -0500)]
Merge pull request #829 from symform/httpwebreq-async-ssl

Convert blocking operations in HttpWebRequest and SslClientStream to non-blocking

10 years ago[corlib] Make primitive types smaller than int compare result compatible
Marek Safar [Fri, 7 Feb 2014 19:19:16 +0000 (20:19 +0100)]
[corlib] Make primitive types smaller than int compare result compatible

10 years ago[corlib] Fixes formatting of nested tuples
Marek Safar [Fri, 7 Feb 2014 19:17:14 +0000 (20:17 +0100)]
[corlib] Fixes formatting of nested tuples

10 years ago[corlib] Default comparer uses IComparable interface only
Marek Safar [Fri, 7 Feb 2014 19:07:45 +0000 (20:07 +0100)]
[corlib] Default comparer uses IComparable interface only

10 years agoFixes build
Marek Safar [Thu, 6 Feb 2014 21:36:50 +0000 (22:36 +0100)]
Fixes build

10 years ago[corlib] Update fixed test
Marek Safar [Thu, 6 Feb 2014 21:30:10 +0000 (22:30 +0100)]
[corlib] Update fixed test

10 years agoMerge pull request #889 from slluis/serializer-fix
Marek Safar [Thu, 6 Feb 2014 21:28:59 +0000 (22:28 +0100)]
Merge pull request #889 from slluis/serializer-fix

Fix serialization issue

10 years agoFix serialization issue
Lluis Sanchez [Thu, 6 Feb 2014 21:01:14 +0000 (22:01 +0100)]
Fix serialization issue

Fixes BXC 5667 - SerializationException: The object with ID 1 could
not be resolved

10 years ago[System] Fix process creation when UseShellExecute is set to false.
Rodrigo Kumpera [Thu, 6 Feb 2014 20:50:31 +0000 (15:50 -0500)]
[System] Fix process creation when UseShellExecute is set to false.

This fixes the behavior of process spawning when UseShellExecute is
set to true.

The right behavior is to return no process only when we used the system
launcher. So, spawning /bin/cat should behave in the same way independent
of how UseShellExecute is set.

10 years agoRevert "[runtime] Don't pass SEE_MASK_NOCLOSEPROCESS to ShellExecuteEx as we don...
Rodrigo Kumpera [Thu, 6 Feb 2014 20:23:10 +0000 (15:23 -0500)]
Revert "[runtime] Don't pass SEE_MASK_NOCLOSEPROCESS to ShellExecuteEx as we don't care for the launched process. Part 1/3 of Bug #16119."

This reverts commit 6c06d109952acb28a8198dcf85a6e8f4d4393985.

10 years ago[corlib] Harden CustomAttributeData::GetHashCode
Rodrigo Kumpera [Thu, 6 Feb 2014 14:42:16 +0000 (09:42 -0500)]
[corlib] Harden CustomAttributeData::GetHashCode

10 years ago[runtime] Put back ensure_synch_cs_set () which was removed in a157ac79e8f404f0eb9b26...
Zoltan Varga [Thu, 6 Feb 2014 19:08:05 +0000 (20:08 +0100)]
[runtime] Put back ensure_synch_cs_set () which was removed in a157ac79e8f404f0eb9b263f5de697f13528deec to work around some shutdown crashes.

10 years ago[mcs] Tests update
Marek Safar [Thu, 6 Feb 2014 15:57:18 +0000 (16:57 +0100)]
[mcs] Tests update

10 years ago[runtime] Filter out events with same name
Marek Safar [Thu, 6 Feb 2014 13:57:09 +0000 (14:57 +0100)]
[runtime] Filter out events with same name

10 years agoFixes build
Marek Safar [Thu, 6 Feb 2014 13:49:30 +0000 (14:49 +0100)]
Fixes build

10 years ago[corlib] Cleanup type ToString formatting.
Marek Safar [Thu, 6 Feb 2014 10:35:11 +0000 (11:35 +0100)]
[corlib] Cleanup type ToString formatting.

10 years ago[corlib] Fix some AssemblyName tests
Marek Safar [Thu, 6 Feb 2014 09:48:21 +0000 (10:48 +0100)]
[corlib] Fix some AssemblyName tests

10 years ago[corlib] Better recovery when tasks run on broken scheduler
Marek Safar [Thu, 6 Feb 2014 08:22:47 +0000 (09:22 +0100)]
[corlib] Better recovery when tasks run on broken scheduler

10 years ago[corlib] Cleanup ThreadLocal output formatting.
Marek Safar [Wed, 5 Feb 2014 16:02:39 +0000 (17:02 +0100)]
[corlib] Cleanup ThreadLocal output formatting.

10 years ago[runtime] Fix the computation of AssemblyName.ProcessorArchitecture () to be compatib...
Zoltan Varga [Thu, 6 Feb 2014 10:58:31 +0000 (11:58 +0100)]
[runtime] Fix the computation of AssemblyName.ProcessorArchitecture () to be compatible with MS.NET. Fixes #17632.

10 years agoAdd types from the method header even for gshared methods.
Andrés G. Aragoneses [Thu, 6 Feb 2014 10:34:09 +0000 (11:34 +0100)]
Add types from the method header even for gshared methods.

10 years agoRevert "[aot] Applied patch from "Andrés G. Aragoneses" <knocte@gmail.com>: Add types...
Zoltan Varga [Thu, 6 Feb 2014 10:33:25 +0000 (11:33 +0100)]
Revert "[aot] Applied patch from "Andrés G. Aragoneses" <knocte@gmail.com>: Add types from the method header even for gshared methods."

This reverts commit 9231594314ab2d9d4b42ee1874882a72448788f1.

10 years agofix bug #16744 - null values on nullable value types were not handled in deserializer.
Atsushi Eno [Thu, 6 Feb 2014 08:11:30 +0000 (17:11 +0900)]
fix bug #16744 - null values on nullable value types were not handled in deserializer.

10 years ago[Mono.Data.Sqlite] Add SqliteFunction tests.
Rolf Bjarne Kvinge [Thu, 6 Feb 2014 01:16:42 +0000 (20:16 -0500)]
[Mono.Data.Sqlite] Add SqliteFunction tests.

10 years ago[Mono.Data.Sqlite] Add support for custom collation functions in MonoTouch.
Rolf Bjarne Kvinge [Thu, 6 Feb 2014 00:55:02 +0000 (19:55 -0500)]
[Mono.Data.Sqlite] Add support for custom collation functions in MonoTouch.

10 years ago[aot] Applied patch from "Andrés G. Aragoneses" <knocte@gmail.com>: Add types from...
Zoltan Varga [Wed, 5 Feb 2014 23:52:13 +0000 (00:52 +0100)]
[aot] Applied patch from "Andrés G. Aragoneses" <knocte@gmail.com>: Add types from the method header even for gshared methods.

10 years agoRevert "[aot] Add types from the method header even for gshared methods."
Zoltan Varga [Wed, 5 Feb 2014 23:51:31 +0000 (00:51 +0100)]
Revert "[aot] Add types from the method header even for gshared methods."

This reverts commit 70d7512ac84dcaf903b80f80b36aafe210337a9a.

10 years ago[aot] Add types from the method header even for gshared methods.
Zoltan Varga [Wed, 5 Feb 2014 23:33:08 +0000 (00:33 +0100)]
[aot] Add types from the method header even for gshared methods.

10 years ago[runtime] Fix the windows build.
Zoltan Varga [Wed, 5 Feb 2014 23:16:43 +0000 (00:16 +0100)]
[runtime] Fix the windows build.

10 years ago[arm] Increase the length of the endfinally instruction. Fixes #17589.
Zoltan Varga [Wed, 5 Feb 2014 16:37:03 +0000 (17:37 +0100)]
[arm] Increase the length of the endfinally instruction. Fixes #17589.

10 years ago[corlib] Path.Combine with variable arguments length where one is empty should give...
Marek Safar [Wed, 5 Feb 2014 15:14:13 +0000 (16:14 +0100)]
[corlib] Path.Combine with variable arguments length where one is empty should give same result as other Combine overloads

10 years ago[corlib] Convert with incorrect provider type should still return value when possible
Marek Safar [Wed, 5 Feb 2014 14:44:50 +0000 (15:44 +0100)]
[corlib] Convert with incorrect provider type should still return value when possible

10 years ago[corlib] Use shared version of utf8 encoding in stream reader
Marek Safar [Wed, 5 Feb 2014 14:03:58 +0000 (15:03 +0100)]
[corlib] Use shared version of utf8 encoding in stream reader

10 years ago[corlib] Add nullable tests
Marek Safar [Wed, 5 Feb 2014 14:03:23 +0000 (15:03 +0100)]
[corlib] Add nullable tests

10 years ago[jit] Implement OP_CARD_TABLE_WBARRIER on ios.
Zoltan Varga [Wed, 5 Feb 2014 15:40:20 +0000 (16:40 +0100)]
[jit] Implement OP_CARD_TABLE_WBARRIER on ios.

10 years agoFlush changes in corlib expected results.
Rodrigo Kumpera [Wed, 5 Feb 2014 15:06:18 +0000 (10:06 -0500)]
Flush changes in corlib expected results.

10 years ago[corlib] Add more argument checks to ConcurrentStack
Marek Safar [Wed, 5 Feb 2014 13:09:11 +0000 (14:09 +0100)]
[corlib] Add more argument checks to ConcurrentStack

10 years ago[system] More SortedDictionary argument checks
Marek Safar [Wed, 5 Feb 2014 12:16:40 +0000 (13:16 +0100)]
[system] More SortedDictionary argument checks

10 years ago[system] Fix calls on empty linked list
Marek Safar [Wed, 5 Feb 2014 11:06:08 +0000 (12:06 +0100)]
[system] Fix calls on empty linked list

10 years ago[xbuild] Fix ResolveAssemblyReference verbosity
Michael Hutchinson [Tue, 4 Feb 2014 23:24:42 +0000 (18:24 -0500)]
[xbuild] Fix ResolveAssemblyReference verbosity

Always log search logger messages with low importance.

Missing non-primary references are a low priority message,
not a warning.

10 years ago[corlib] Implement parsing of complex double strings.
Marek Safar [Tue, 4 Feb 2014 16:39:35 +0000 (17:39 +0100)]
[corlib] Implement parsing of complex double strings.

10 years ago[corlib] Initialize null stream reader
Marek Safar [Tue, 4 Feb 2014 12:14:33 +0000 (13:14 +0100)]
[corlib] Initialize null stream reader

10 years ago[corlib] Add overflow checks to string padding
Marek Safar [Tue, 4 Feb 2014 11:40:33 +0000 (12:40 +0100)]
[corlib] Add overflow checks to string padding

10 years ago[jit] Avoid running class cctors during AOT when using the AggressiveInlining attribu...
Zoltan Varga [Tue, 4 Feb 2014 08:52:42 +0000 (09:52 +0100)]
[jit] Avoid running class cctors during AOT when using the AggressiveInlining attribute. Fixes #17558.

10 years ago[runtime] Fix a warning.
Zoltan Varga [Tue, 4 Feb 2014 06:05:34 +0000 (07:05 +0100)]
[runtime] Fix a warning.

10 years ago[corlib] The hashcode of an empty struct must be constant. Fixes #17577
Rodrigo Kumpera [Mon, 3 Feb 2014 23:08:53 +0000 (18:08 -0500)]
[corlib] The hashcode of an empty struct must be constant. Fixes #17577

10 years ago[corlib] Add overflow checks to functions that alloc memory and uses raw pointers.
Rodrigo Kumpera [Mon, 3 Feb 2014 22:36:39 +0000 (17:36 -0500)]
[corlib] Add overflow checks to functions that alloc memory and uses raw pointers.

10 years ago[runtime] Applied patch from Frank Fuchs <fk.fuchs@googlemail.com>. Add win64 support...
Zoltan Varga [Mon, 3 Feb 2014 21:15:30 +0000 (22:15 +0100)]
[runtime] Applied patch from Frank Fuchs <fk.fuchs@googlemail.com>. Add win64 support to mono_threads_core_get_stack_bounds ().

10 years ago[runtime] Applied patch from Frank Fuchs <fk.fuchs@googlemail.com>. Fix the windows...
Zoltan Varga [Mon, 3 Feb 2014 21:11:57 +0000 (22:11 +0100)]
[runtime] Applied patch from Frank Fuchs <fk.fuchs@googlemail.com>. Fix the windows build.

10 years ago[corlib] Allow to use custom comparer when sorting null values.
Marek Safar [Mon, 3 Feb 2014 19:27:58 +0000 (20:27 +0100)]
[corlib] Allow to use custom comparer when sorting null values.

10 years ago[corlib] Clean up array binary search argument checks
Marek Safar [Mon, 3 Feb 2014 17:36:24 +0000 (18:36 +0100)]
[corlib] Clean up array binary search argument checks

10 years ago[corlib] Throw correct exception when array::copy elements don't match
Marek Safar [Mon, 3 Feb 2014 15:13:49 +0000 (16:13 +0100)]
[corlib] Throw correct exception when array::copy elements don't match

10 years agoMerge pull request #886 from dmpot/master
Marek Safar [Mon, 3 Feb 2014 08:40:56 +0000 (00:40 -0800)]
Merge pull request #886 from dmpot/master

[WindowsBase]: 6 fixes to Dispatcher

10 years agoDispatcher should process a higher-priority task
Dmitry Potapov [Sun, 2 Feb 2014 22:07:44 +0000 (02:07 +0400)]
Dispatcher should process a higher-priority task

When a higher-priority tasked appeared in the dispatcher queue, the
dispatcher stopped processing of the current queue but moved to a low
priority queue instead of processing the most high priority queue.

10 years agoInvalidOperationException in Dispatcher.RunFrame
Dmitry Potapov [Sun, 2 Feb 2014 21:57:20 +0000 (01:57 +0400)]
InvalidOperationException in Dispatcher.RunFrame

When a Dispatcher exits due to 'frame.Continue' being false, it does not
clear queue_bits. As result, the next run of the Dispatcher could try to
dequeue a non-existing dispatcher operation.

10 years agoDispatcher should stop if Continue is false
Dmitry Potapov [Sun, 2 Feb 2014 21:48:32 +0000 (01:48 +0400)]
Dispatcher should stop if Continue is false

If the dispatcher encounters that frame.Continue is false, it should return
immediately and do not try to execute anything. The unit test may be seen as
rather artificial, but the problem may happen in more realistic situations
when frames are unwound.

10 years agoDispatcher: Run() can be used more than once
Dmitry Potapov [Sun, 2 Feb 2014 21:41:42 +0000 (01:41 +0400)]
Dispatcher: Run() can be used more than once

When Run() was invoked a second time, main_execution_frame had the Continue
flag set to false. So it did not work correctly.

10 years ago[runtime] Simplify the io-layer threading code a bit more.
Zoltan Varga [Sun, 2 Feb 2014 21:36:28 +0000 (22:36 +0100)]
[runtime] Simplify the io-layer threading code a bit more.

10 years agoDispatcher.PushFrame: clean references before return
Dmitry Potapov [Sun, 2 Feb 2014 19:55:12 +0000 (23:55 +0400)]
Dispatcher.PushFrame: clean references before return

The dispatcher did not clean references before returning, therefore
the second call to Dispatcher.Run() failed.

10 years agoFix src and dest indexes in DispatcherOperation ctor
Dmitry Potapov [Sun, 2 Feb 2014 18:40:55 +0000 (22:40 +0400)]
Fix src and dest indexes in DispatcherOperation ctor

The source and the destination indexes are confused. The source index, which
is the second parameter, should be 0 and the destination index, which is the
fourth parameter, should be 1.

10 years ago[runtime] Move more thread attach code to mono-threads from io-layer.
Zoltan Varga [Sun, 2 Feb 2014 15:43:45 +0000 (16:43 +0100)]
[runtime] Move more thread attach code to mono-threads from io-layer.

10 years agoMerge pull request #884 from akoeplinger/fix-ipv6-teredo
Marek Safar [Sun, 2 Feb 2014 13:17:22 +0000 (05:17 -0800)]
Merge pull request #884 from akoeplinger/fix-ipv6-teredo

[System] Fixed an error in the implementation of System.Net.IPAddress.IsIPv6Teredo

10 years ago[runtime] Simplify _wapi_set_termination_details ().
Zoltan Varga [Sun, 2 Feb 2014 05:11:31 +0000 (06:11 +0100)]
[runtime] Simplify _wapi_set_termination_details ().

10 years ago[System] Fixed an error in the implementation of System.Net.IPAddress.IsIPv6Teredo
Alexander Köplinger [Sat, 1 Feb 2014 21:02:27 +0000 (22:02 +0100)]
[System] Fixed an error in the implementation of System.Net.IPAddress.IsIPv6Teredo

The property was introduced with PR #870 but it missed to convert network byte order to host byte order, so the comparison
wasn't working correctly and the corresponding unit test failed. @marek-safar erroneously "fixed" the test in 27e07c7.

This is the corrected implementation and the original test now works as intended.

10 years ago[runtime] Rename mono_thread_info_dettach () to mono_thread_info_detach ().
Zoltan Varga [Sat, 1 Feb 2014 18:31:07 +0000 (19:31 +0100)]
[runtime] Rename mono_thread_info_dettach () to mono_thread_info_detach ().

10 years ago[runtime] Rename the MONO_GSHARING define to ENABLE_GSHAREDVT for consistency.
Zoltan Varga [Sat, 1 Feb 2014 12:56:19 +0000 (13:56 +0100)]
[runtime] Rename the MONO_GSHARING define to ENABLE_GSHAREDVT for consistency.

10 years ago[runtime] Implement GetCurrentThreadId () using mono-threads.
Zoltan Varga [Sat, 1 Feb 2014 12:50:47 +0000 (13:50 +0100)]
[runtime] Implement GetCurrentThreadId () using mono-threads.

10 years ago[runtime] Move thread attaching to mono-threads from the io-layer.
Zoltan Varga [Sat, 1 Feb 2014 12:44:54 +0000 (13:44 +0100)]
[runtime] Move thread attaching to mono-threads from the io-layer.

10 years ago[runtime] Remove code duplication from the wapi_interrupt_.. functions.
Zoltan Varga [Fri, 31 Jan 2014 17:58:14 +0000 (18:58 +0100)]
[runtime] Remove code duplication from the wapi_interrupt_.. functions.

10 years ago[corlib] Fixes our of range index access from a5fc91fc42a9a1edcc5ad9d6c656c9c9223e62a8
Marek Safar [Fri, 31 Jan 2014 16:42:06 +0000 (17:42 +0100)]
[corlib] Fixes our of range index access from a5fc91fc42a9a1edcc5ad9d6c656c9c9223e62a8

10 years agoMore tests
Marek Safar [Fri, 31 Jan 2014 14:44:12 +0000 (15:44 +0100)]
More tests

10 years ago[corlib] Decimal parsing with banker's rounding with non-zero digits beyond the thous...
Marek Safar [Fri, 31 Jan 2014 14:30:18 +0000 (15:30 +0100)]
[corlib] Decimal parsing with banker's rounding with non-zero digits beyond the thousandths digit. Fixes #17536

10 years ago[runtime] Remove some references to gc_wrapper.h which are no longer needed.
Zoltan Varga [Fri, 31 Jan 2014 13:29:51 +0000 (14:29 +0100)]
[runtime] Remove some references to gc_wrapper.h which are no longer needed.

10 years ago[runtime] Move the thread exit code to mono-threads from io-layer.
Zoltan Varga [Fri, 31 Jan 2014 13:18:14 +0000 (14:18 +0100)]
[runtime] Move the thread exit code to mono-threads from io-layer.

10 years ago[mcs] Improve daa862f17f7930e5618d1e46e09de46f95c667d4 commit
Marek Safar [Fri, 31 Jan 2014 13:04:49 +0000 (14:04 +0100)]
[mcs] Improve daa862f17f7930e5618d1e46e09de46f95c667d4 commit

10 years ago[mcs] Explicit user conversion from nullable types does not have to lift the result...
Marek Safar [Fri, 31 Jan 2014 12:30:49 +0000 (13:30 +0100)]
[mcs] Explicit user conversion from nullable types does not have to lift the result. Fixes #17469

10 years ago[mcs] Report less internal errors. Fixes #17472
Marek Safar [Fri, 31 Jan 2014 10:44:04 +0000 (11:44 +0100)]
[mcs] Report less internal errors. Fixes #17472

10 years ago[mcs] Fixes warning
Marek Safar [Fri, 31 Jan 2014 10:25:25 +0000 (11:25 +0100)]
[mcs] Fixes warning

10 years ago[mcs] Release array initializer stack field at the end of initialization. Fixes ...
Marek Safar [Fri, 31 Jan 2014 09:18:26 +0000 (10:18 +0100)]
[mcs] Release array initializer stack field at the end of initialization. Fixes #17494

10 years ago[runtime] Fix a shutdown leak.
Zoltan Varga [Fri, 31 Jan 2014 07:58:16 +0000 (08:58 +0100)]
[runtime] Fix a shutdown leak.

10 years ago[runtime] Use mono_thread_join () to wait for the finalizer thread to exit.
Zoltan Varga [Fri, 31 Jan 2014 05:43:32 +0000 (06:43 +0100)]
[runtime] Use mono_thread_join () to wait for the finalizer thread to exit.

10 years ago[llvm] Disable llvm instead of asserting in some cases. Fixes #17527.
Zoltan Varga [Fri, 31 Jan 2014 05:17:41 +0000 (06:17 +0100)]
[llvm] Disable llvm instead of asserting in some cases. Fixes #17527.

10 years ago[runtime] Use a separate lock for the joinable_threads () hash table.
Zoltan Varga [Fri, 31 Jan 2014 03:12:43 +0000 (04:12 +0100)]
[runtime] Use a separate lock for the joinable_threads () hash table.

10 years agoMerge pull request #880 from awinters-fvs/xbuild/make-dist-fix
Michael Hutchinson [Thu, 30 Jan 2014 21:13:59 +0000 (13:13 -0800)]
Merge pull request #880 from awinters-fvs/xbuild/make-dist-fix

Fix 'make dist' broken since 35287878

10 years ago[corlib] WeakReference<T>::TryGetTarget should return true only for non null targets.
Rodrigo Kumpera [Thu, 30 Jan 2014 21:11:31 +0000 (16:11 -0500)]
[corlib] WeakReference<T>::TryGetTarget should return true only for non null targets.

10 years agoFix warnings.
Zoltan Varga [Thu, 30 Jan 2014 18:08:22 +0000 (19:08 +0100)]
Fix warnings.

10 years ago[runtime] Change the way the runtime waits for threads to finish. Instead of detachin...
Zoltan Varga [Thu, 30 Jan 2014 09:28:42 +0000 (10:28 +0100)]
[runtime] Change the way the runtime waits for threads to finish. Instead of detaching them at thread startup and waiting for them using WaitForMultipleObject(), add threads to a hash table before they exit mono code and use the finalizer thread to call pthread_join () on them. This will hopefully fix the problems where a thread tried to access data which the runtime at shutdown/appdomain unload.

10 years agoMerge pull request #882 from jgagnon/master
Alex Rønne Petersen [Thu, 30 Jan 2014 03:51:18 +0000 (19:51 -0800)]
Merge pull request #882 from jgagnon/master

Fixes a socket leak in class TcpListener

10 years ago[jit]Add a missing call to mini_native_type_replace_type in mini_get_basic_type_from_...
Rodrigo Kumpera [Wed, 29 Jan 2014 19:17:13 +0000 (14:17 -0500)]
[jit]Add a missing call to mini_native_type_replace_type in mini_get_basic_type_from_generic.

10 years ago[aot] Add a more helpfull error message when a method cannot be loaded.
Zoltan Varga [Wed, 29 Jan 2014 15:47:19 +0000 (16:47 +0100)]
[aot] Add a more helpfull error message when a method cannot be loaded.

10 years ago[sgen] Fix a regression caused by 07fc727b8698a100aeb214ae3f7eb1cc3f5bab20. Fixes...
Zoltan Varga [Wed, 29 Jan 2014 15:24:28 +0000 (16:24 +0100)]
[sgen] Fix a regression caused by 07fc727b8698a100aeb214ae3f7eb1cc3f5bab20. Fixes the windows build.

10 years ago[xbuild] Rework escaping in TaskItem to be compatible with MSBuild
Michael Hutchinson [Tue, 28 Jan 2014 22:38:26 +0000 (17:38 -0500)]
[xbuild] Rework escaping in TaskItem to be compatible with MSBuild

The escaping/unescaping behaviour of TaskItem:ITaskItem was undocumented
originally in MSBuild, so our implementation did not perform any. This
caused issues with Tasks getting metadata and paths that were escaped,
trying to use them as-is, and failing horribly.

Fortunately the ITaskItem2 interface in .NET 4 provides complementary
accessors with documentation that indicates that it stores values
escaped internally, and the old accessors unescape the values.

This commit implements ITaskItem2, fixes the escaping behavior of the
old accessors, and removes some superluous uses of IDictionary.Contains.

10 years ago[xbuild] Remove unnecessary/inconsistent path conversion hack
Michael Hutchinson [Tue, 28 Jan 2014 22:19:53 +0000 (17:19 -0500)]
[xbuild] Remove unnecessary/inconsistent path conversion hack

Directory separators are automatically converted from Windows->Native
when parsing MSBuild files, but any paths provided in code must already
be native.

10 years ago[Microsoft.Build.Utilities] Properly escape/unescape ItemSpec
Alan McGovern [Tue, 28 Jan 2014 21:18:57 +0000 (16:18 -0500)]
[Microsoft.Build.Utilities] Properly escape/unescape ItemSpec

With tests.

10 years ago[Microsoft.Build.Utilities] Fix the escaping/unescaping of ItemSpec
Alan McGovern [Tue, 28 Jan 2014 20:40:25 +0000 (15:40 -0500)]
[Microsoft.Build.Utilities] Fix the escaping/unescaping of ItemSpec

This should hopefully fix compilation of projects using files with
names like 'foo@2x.png' in various places like embedded resources
or content items which must be copied to the output directory.

With tests.

10 years ago[mcs] Better check for invalid attribute targets. Fixes #17447
Marek Safar [Tue, 28 Jan 2014 09:16:12 +0000 (10:16 +0100)]
[mcs] Better check for invalid attribute targets. Fixes #17447

10 years ago[llvm] Load rgctx/imt arguments using a volatile load on arm to prevent LLVM from...
Zoltan Varga [Tue, 28 Jan 2014 05:30:09 +0000 (06:30 +0100)]
[llvm] Load rgctx/imt arguments using a volatile load on arm to prevent LLVM from moving the setting of the argument elsewhere. This is needed because these arguments are passed in a caller save register, but our code treats it as callee save in a lot of places. Fixes #17435.

10 years agoRevert "[jit] Precompute a bit more information for delegate trampolines to speed...
Zoltan Varga [Tue, 28 Jan 2014 05:11:22 +0000 (06:11 +0100)]
Revert "[jit] Precompute a bit more information for delegate trampolines to speed them up."

This reverts commit e3de4cb92e5f91fcd37d83f832401be45c0a77a5.

Revert this as it seems to break mt.

10 years ago[xbuild] Define VisualStudioVersion, since F# projects can depend on it
Michael Hutchinson [Mon, 27 Jan 2014 21:58:49 +0000 (16:58 -0500)]
[xbuild] Define VisualStudioVersion, since F# projects can depend on it

10 years agoProperly compare assembly versions when performing binding. Fixes #17368.
Rodrigo Kumpera [Mon, 27 Jan 2014 21:28:01 +0000 (16:28 -0500)]
Properly compare assembly versions when performing binding. Fixes #17368.

The right way to compare assembly versions is by translating the major/minor
pair into a single number and compare that.

Since each element can only be one byte long, we multiply major by 256
before adding to minor.

This solves the problem where version 100.0.0.0 was not after 3.5.0.0.