mono.git
7 years agoMerge pull request #4540 from kumpera/android-changes-part1
Rodrigo Kumpera [Wed, 29 Mar 2017 15:46:29 +0000 (11:46 -0400)]
Merge pull request #4540 from kumpera/android-changes-part1

[bcl+runtime] Multiple small cleanups to Android.

7 years ago[tools] Remove unused sources
Marek Safar [Wed, 29 Mar 2017 10:11:33 +0000 (12:11 +0200)]
[tools] Remove unused sources

7 years ago[jit] Cleanup the signature of the mono_arch_get_static_rgctx_trampoline () function...
Zoltan Varga [Wed, 29 Mar 2017 09:38:30 +0000 (05:38 -0400)]
[jit] Cleanup the signature of the mono_arch_get_static_rgctx_trampoline () function. (#4605)

Remove the unused MonoMethod argument, and rename the 'mrgctx' argument to 'arg', since it can be any value, not just
an mrgctx.

7 years agoBump cecil
Marek Safar [Wed, 29 Mar 2017 07:56:43 +0000 (09:56 +0200)]
Bump cecil

7 years agoBump corefx
Marek Safar [Thu, 23 Mar 2017 22:55:58 +0000 (23:55 +0100)]
Bump corefx

7 years ago[jit] Add ref types to mini_get_underlying_type (), use it to simplify the switch...
Zoltan Varga [Wed, 29 Mar 2017 00:17:31 +0000 (20:17 -0400)]
[jit] Add ref types to mini_get_underlying_type (), use it to simplify the switch loops in the jit. (#4606)

7 years ago[threadpool] Pass callback at initialization (#4546)
Ludovic Henry [Tue, 28 Mar 2017 21:03:31 +0000 (17:03 -0400)]
[threadpool] Pass callback at initialization (#4546)

This remove the possibility to execute different callbacks on the threadpool, but this allows us to remove the work_items_lock, which is called on the hot path of the ThreadPool.

7 years ago[msvc] Update csproj files
monojenkins [Tue, 28 Mar 2017 16:42:55 +0000 (16:42 +0000)]
[msvc] Update csproj files

7 years agoMerge pull request #4168 from xmcclure/aot-man
Andi McClure [Tue, 28 Mar 2017 18:14:08 +0000 (14:14 -0400)]
Merge pull request #4168 from xmcclure/aot-man

Correctly document --aot options in man page

7 years agoRemove 'experimental' label from full/hybrid AOT in manpage
Andi McClure [Mon, 27 Mar 2017 21:58:27 +0000 (17:58 -0400)]
Remove 'experimental' label from full/hybrid AOT in manpage

7 years agoCorrectly document --aot options in man page
Andi McClure [Mon, 27 Mar 2017 21:50:46 +0000 (17:50 -0400)]
Correctly document --aot options in man page

- Ensure all AOT options are both documented and listed in
  alphabetical order in both the manpage and --help line
- Ensure all exceptoins are commented in the aot-compiler.c source
  with "intentionally udnocumented"

7 years ago[mono] Remove unused icall
Marek Safar [Mon, 27 Mar 2017 22:28:08 +0000 (00:28 +0200)]
[mono] Remove unused icall

7 years agoUpdate copyright years
Miguel de Icaza [Tue, 28 Mar 2017 15:18:43 +0000 (11:18 -0400)]
Update copyright years

7 years ago[corlib] Add back X509 support for watchOS.
Rolf Bjarne Kvinge [Thu, 23 Mar 2017 17:43:29 +0000 (18:43 +0100)]
[corlib] Add back X509 support for watchOS.

Otherwise we'd be regressing existing (and working) behavior.

7 years agoDisable a few x509 tests that fail on older macOS
Chris Hamons [Mon, 27 Mar 2017 20:05:09 +0000 (15:05 -0500)]
Disable a few x509 tests that fail on older macOS

- Handles https://bugzilla.xamarin.com/show_bug.cgi?id=53958
- https://bugzilla.xamarin.com/show_bug.cgi?id=53689 is filed to turn them
  back on later with a better version check
- SecCertificateCreateWithData handles invalid arguments differently based on
  macOS version

7 years ago[corlib] Add more Array tests
Marek Safar [Thu, 23 Mar 2017 13:12:13 +0000 (14:12 +0100)]
[corlib] Add more Array tests

7 years ago[System.Windows.Forms] Fixes DataGridViewColumnCollection comparer not to return...
Marek Safar [Wed, 22 Mar 2017 14:05:53 +0000 (15:05 +0100)]
[System.Windows.Forms] Fixes DataGridViewColumnCollection comparer not to return 1 on match

7 years ago[System.Windows.Forms] Imrove DataGridViewColumnCollectionTest
Marek Safar [Wed, 22 Mar 2017 14:04:21 +0000 (15:04 +0100)]
[System.Windows.Forms] Imrove DataGridViewColumnCollectionTest

7 years ago[corlib] Use array managed parts from corert to fix bugs in sorting and arguments...
Marek Safar [Fri, 17 Mar 2017 09:42:36 +0000 (10:42 +0100)]
[corlib] Use array managed parts from corert to fix bugs in sorting and arguments checking. Fixes #53196 and similar

7 years agoBump corert
Marek Safar [Tue, 21 Mar 2017 17:11:17 +0000 (18:11 +0100)]
Bump corert

7 years ago[corlib] Fix RegistryKeyTest cleanup
Marek Safar [Fri, 17 Mar 2017 09:08:37 +0000 (10:08 +0100)]
[corlib] Fix RegistryKeyTest cleanup

7 years agoMerge pull request #4594 from lambdageek/bug-53890
Andi McClure [Mon, 27 Mar 2017 19:15:26 +0000 (15:15 -0400)]
Merge pull request #4594 from lambdageek/bug-53890

[remoting] Pass correct object to invoke of IRemotingTypeInfo.CanCastTo

7 years agoMerge pull request #4570 from lateralusX/jlorenss/visual_studio_msbuild_fix
Johan Lorensson [Mon, 27 Mar 2017 07:04:53 +0000 (09:04 +0200)]
Merge pull request #4570 from lateralusX/jlorenss/visual_studio_msbuild_fix

Windows msbuild triggers too much to rebuild.

7 years agoAdd FieldInfoMirror.FullName (#4588)
Jb Evain [Sun, 26 Mar 2017 13:33:34 +0000 (06:33 -0700)]
Add FieldInfoMirror.FullName (#4588)

7 years ago[interp] call mono_unhandled_exception, so exit() is called with proper return code
Bernhard Urban [Sun, 26 Mar 2017 02:06:10 +0000 (22:06 -0400)]
[interp] call mono_unhandled_exception, so exit() is called with proper return code

7 years ago[interp] enable more tests for CI
Bernhard Urban [Sun, 26 Mar 2017 02:06:09 +0000 (22:06 -0400)]
[interp] enable more tests for CI

7 years ago[interp] support floating point in runtime_invoke
Bernhard Urban [Sun, 26 Mar 2017 02:06:09 +0000 (22:06 -0400)]
[interp] support floating point in runtime_invoke

7 years ago[interp] allow more gregs, enable pinvoke17.exe
Bernhard Urban [Sun, 26 Mar 2017 02:06:09 +0000 (22:06 -0400)]
[interp] allow more gregs, enable pinvoke17.exe

7 years ago[interp] throw NRE in mint_strlen
Bernhard Urban [Sun, 26 Mar 2017 02:06:09 +0000 (22:06 -0400)]
[interp] throw NRE in mint_strlen

7 years ago[interp] add write barriers
Bernhard Urban [Fri, 24 Mar 2017 23:32:20 +0000 (00:32 +0100)]
[interp] add write barriers

issues found with
`MONO_GC_DEBUG=3,collect-before-allocs,check-remset-consistency ../mini/mono-sgen --interpreter /Users/bernhardu/work/mono/b/lib/mono/4.5/mcs.exe hello.cs`

7 years ago[interp] respect reference type in stobj insn
Bernhard Urban [Fri, 24 Mar 2017 23:32:20 +0000 (00:32 +0100)]
[interp] respect reference type in stobj insn

stackval_from_data does everything for us.

7 years ago[remoting] Pass correct object to invoke of IRemotingTypeInfo.CanCastTo
Aleksey Kliger [Fri, 24 Mar 2017 22:47:38 +0000 (18:47 -0400)]
[remoting] Pass correct object to invoke of IRemotingTypeInfo.CanCastTo

Pass the payload of the coop handle as the 'this' object, not the handle
itself.

Add asserts in ves_icall_Remoting_RealProxy_InternalGetProxyType that
remote_class and the proxy_class are non-NULL.

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=53890

7 years ago[docs] Update formatting in mono-api-utils.
Jon Purdy [Fri, 10 Mar 2017 21:10:49 +0000 (13:10 -0800)]
[docs] Update formatting in mono-api-utils.

7 years ago[docs] Update formatting in mono-api-unsorted.
Jon Purdy [Fri, 10 Mar 2017 21:10:02 +0000 (13:10 -0800)]
[docs] Update formatting in mono-api-unsorted.

7 years ago[docs] Update formatting in mono-api-type.
Jon Purdy [Fri, 10 Mar 2017 21:04:17 +0000 (13:04 -0800)]
[docs] Update formatting in mono-api-type.

7 years ago[docs] Update formatting in mono-api-threads.
Jon Purdy [Fri, 10 Mar 2017 20:59:51 +0000 (12:59 -0800)]
[docs] Update formatting in mono-api-threads.

7 years ago[docs] Update formatting in mono-api-string.
Jon Purdy [Fri, 10 Mar 2017 20:55:58 +0000 (12:55 -0800)]
[docs] Update formatting in mono-api-string.

7 years ago[docs] Update formatting in mono-api-security.
Jon Purdy [Fri, 10 Mar 2017 00:32:53 +0000 (16:32 -0800)]
[docs] Update formatting in mono-api-security.

7 years ago[docs] Update formatting in mono-api-reflection.
Jon Purdy [Fri, 10 Mar 2017 00:28:18 +0000 (16:28 -0800)]
[docs] Update formatting in mono-api-reflection.

7 years ago[docs] Update formatting in mono-api-profiler.
Jon Purdy [Fri, 10 Mar 2017 00:22:39 +0000 (16:22 -0800)]
[docs] Update formatting in mono-api-profiler.

7 years ago[docs] Update formatting in mono-api-object.
Jon Purdy [Fri, 10 Mar 2017 00:19:29 +0000 (16:19 -0800)]
[docs] Update formatting in mono-api-object.

7 years ago[docs] Update formatting in mono-api-methods.
Jon Purdy [Fri, 10 Mar 2017 00:09:45 +0000 (16:09 -0800)]
[docs] Update formatting in mono-api-methods.

7 years ago[docs] Update formatting in mono-api-metadata.
Jon Purdy [Thu, 9 Mar 2017 22:53:58 +0000 (14:53 -0800)]
[docs] Update formatting in mono-api-metadata.

7 years ago[docs] Update formatting in mono-api-jitinternal.
Jon Purdy [Thu, 9 Mar 2017 21:45:59 +0000 (13:45 -0800)]
[docs] Update formatting in mono-api-jitinternal.

7 years ago[docs] Update formatting in mono-api-jit.
Jon Purdy [Thu, 9 Mar 2017 21:29:09 +0000 (13:29 -0800)]
[docs] Update formatting in mono-api-jit.

7 years ago[docs] Update formatting in mono-api-internal.
Jon Purdy [Thu, 9 Mar 2017 21:23:27 +0000 (13:23 -0800)]
[docs] Update formatting in mono-api-internal.

7 years ago[docs] Update formatting in mono-api-image.
Jon Purdy [Thu, 9 Mar 2017 20:57:31 +0000 (12:57 -0800)]
[docs] Update formatting in mono-api-image.

7 years ago[docs] Update formatting in mono-api-gchandle.
Jon Purdy [Thu, 9 Mar 2017 20:19:13 +0000 (12:19 -0800)]
[docs] Update formatting in mono-api-gchandle.

7 years ago[docs] Update formatting in mono-api-gc.
Jon Purdy [Thu, 9 Mar 2017 20:16:58 +0000 (12:16 -0800)]
[docs] Update formatting in mono-api-gc.

7 years ago[docs] Update formatting in mono-api-exc.
Jon Purdy [Thu, 9 Mar 2017 01:45:48 +0000 (17:45 -0800)]
[docs] Update formatting in mono-api-exc.

7 years ago[docs] Update formatting in mono-api-embedding.
Jon Purdy [Thu, 9 Mar 2017 01:20:48 +0000 (17:20 -0800)]
[docs] Update formatting in mono-api-embedding.

7 years ago[docs] Update formatting in mono-api-dynamic-codegen.
Jon Purdy [Thu, 9 Mar 2017 01:14:15 +0000 (17:14 -0800)]
[docs] Update formatting in mono-api-dynamic-codegen.

7 years ago[docs] Update formatting in mono-api-domains.
Jon Purdy [Thu, 9 Mar 2017 01:04:16 +0000 (17:04 -0800)]
[docs] Update formatting in mono-api-domains.

7 years ago[docs] Update formatting in mono-api-debug.
Jon Purdy [Thu, 9 Mar 2017 00:41:50 +0000 (16:41 -0800)]
[docs] Update formatting in mono-api-debug.

7 years ago[docs] Update formatting in mono-api-counters.
Jon Purdy [Thu, 9 Mar 2017 00:41:33 +0000 (16:41 -0800)]
[docs] Update formatting in mono-api-counters.

7 years ago[docs] Update formatting in mono-api-class.
Jon Purdy [Wed, 8 Mar 2017 23:24:44 +0000 (15:24 -0800)]
[docs] Update formatting in mono-api-class.

7 years ago[docs] Update formatting in mono-api-class.
Jon Purdy [Wed, 8 Mar 2017 23:24:44 +0000 (15:24 -0800)]
[docs] Update formatting in mono-api-class.

7 years ago[docs] Update formatting in mono-api-assembly.
Jon Purdy [Wed, 8 Mar 2017 02:43:28 +0000 (18:43 -0800)]
[docs] Update formatting in mono-api-assembly.

7 years ago[exdoc] Enable formatting in deprecated annotations.
Jon Purdy [Wed, 8 Mar 2017 23:44:13 +0000 (15:44 -0800)]
[exdoc] Enable formatting in deprecated annotations.

7 years ago[exdoc] Handle punctuation better in code formatting.
Jon Purdy [Wed, 8 Mar 2017 02:42:39 +0000 (18:42 -0800)]
[exdoc] Handle punctuation better in code formatting.

7 years ago[docs] Use Doxygen syntax for Monodoc.
Jon Purdy [Tue, 28 Feb 2017 00:58:33 +0000 (16:58 -0800)]
[docs] Use Doxygen syntax for Monodoc.

7 years ago[exdoc] Update warnings.
Jon Purdy [Wed, 1 Mar 2017 02:34:06 +0000 (18:34 -0800)]
[exdoc] Update warnings.

7 years ago[exdoc] Support Doxygen syntax.
Jon Purdy [Tue, 28 Feb 2017 00:58:09 +0000 (16:58 -0800)]
[exdoc] Support Doxygen syntax.

7 years ago[docs] Fix exdoc warnings.
Jon Purdy [Thu, 23 Feb 2017 02:29:29 +0000 (18:29 -0800)]
[docs] Fix exdoc warnings.

7 years ago[exdoc] Refactor.
Jon Purdy [Thu, 23 Feb 2017 02:27:54 +0000 (18:27 -0800)]
[exdoc] Refactor.

Avoid globals, use proper data structures instead of strings, and
produce some warnings for documentation errors.

7 years ago[exdoc] Add missing dependency.
Jon Purdy [Tue, 21 Feb 2017 23:41:15 +0000 (15:41 -0800)]
[exdoc] Add missing dependency.

7 years ago[exdoc] Enable 'warnings' and 'strict'.
Jon Purdy [Tue, 21 Feb 2017 23:40:59 +0000 (15:40 -0800)]
[exdoc] Enable 'warnings' and 'strict'.

7 years ago[exdoc] Fix whitespace.
Jon Purdy [Tue, 21 Feb 2017 23:15:20 +0000 (15:15 -0800)]
[exdoc] Fix whitespace.

7 years ago[docs] Remove redundant filename.
Jon Purdy [Mon, 13 Feb 2017 23:42:55 +0000 (15:42 -0800)]
[docs] Remove redundant filename.

7 years ago[docs] Fix Doxygen errors.
Jon Purdy [Mon, 13 Feb 2017 23:33:41 +0000 (15:33 -0800)]
[docs] Fix Doxygen errors.

Doxygen treats '@code' as the start of a '@code'...'@endcode' block, so
it raised spurious "reached end of file while inside code block" errors
when '@code' was used to denote a parameter. Change these instances to
'\param code' (declaration) and '\p code' (mention).

7 years ago[docs] Enable documentation for utils.
Jon Purdy [Mon, 13 Feb 2017 23:10:40 +0000 (15:10 -0800)]
[docs] Enable documentation for utils.

7 years ago[docs] Enable documentation for mini.
Jon Purdy [Sat, 11 Feb 2017 01:17:57 +0000 (17:17 -0800)]
[docs] Enable documentation for mini.

7 years ago[docs] Enable documentation for sgen.
Jon Purdy [Fri, 10 Feb 2017 23:32:44 +0000 (15:32 -0800)]
[docs] Enable documentation for sgen.

7 years ago[docs] Enable documentation for metadata.
Jon Purdy [Fri, 10 Feb 2017 01:43:01 +0000 (17:43 -0800)]
[docs] Enable documentation for metadata.

7 years ago[docs] Improve Doxygen config.
Jon Purdy [Fri, 10 Feb 2017 01:43:07 +0000 (17:43 -0800)]
[docs] Improve Doxygen config.

7 years agoRevert "Update corefx"
Marek Safar [Fri, 24 Mar 2017 19:04:55 +0000 (20:04 +0100)]
Revert "Update corefx"

This reverts commit 2a2c317d07e389088737b391e97853fdb6dbc390.

7 years ago[tests] Remove duplicate property
Marek Safar [Fri, 24 Mar 2017 19:04:03 +0000 (20:04 +0100)]
[tests] Remove duplicate property

7 years agoMerge pull request #4590 from xmcclure/master
Andi McClure [Fri, 24 Mar 2017 18:42:43 +0000 (14:42 -0400)]
Merge pull request #4590 from xmcclure/master

Improve "Could not resolve type with token" exception message

7 years agoImprove "Could not resolve type with token" exception message
Andi McClure [Fri, 24 Mar 2017 18:37:26 +0000 (14:37 -0400)]
Improve "Could not resolve type with token" exception message

7 years agoUpdate corefx
Marek Safar [Fri, 24 Mar 2017 18:36:23 +0000 (19:36 +0100)]
Update corefx

7 years ago[mcs] Reset also all partial parts current-type
Marek Safar [Fri, 24 Mar 2017 14:36:31 +0000 (15:36 +0100)]
[mcs] Reset also all partial parts current-type

7 years agoMerge pull request #4503 from BrzVlad/fix-appdomain-unload
Vlad Brezae [Fri, 24 Mar 2017 14:21:30 +0000 (16:21 +0200)]
Merge pull request #4503 from BrzVlad/fix-appdomain-unload

[runtime] Fix abort issues

7 years agoA few fixes to the man page
Miguel de Icaza [Fri, 24 Mar 2017 14:01:01 +0000 (10:01 -0400)]
A few fixes to the man page

7 years ago[bcl] Add a finalizer to MemoryMappedFile.
Zoltan Varga [Thu, 23 Mar 2017 17:34:57 +0000 (13:34 -0400)]
[bcl] Add a finalizer to MemoryMappedFile.

7 years ago[System.Data] Update tests for mobile profiles
Marek Safar [Fri, 24 Mar 2017 13:15:14 +0000 (14:15 +0100)]
[System.Data] Update tests for mobile profiles

7 years ago[runtime] Don't reset abort exception in invoke wrapper
Vlad Brezae [Thu, 23 Mar 2017 22:17:30 +0000 (00:17 +0200)]
[runtime] Don't reset abort exception in invoke wrapper

It leads to missing self aborts on full-aot.

7 years ago[runtime] Improve debugging of thread interruptions
Vlad Brezae [Mon, 20 Mar 2017 23:34:49 +0000 (01:34 +0200)]
[runtime] Improve debugging of thread interruptions

7 years ago[runtime] Defer async requests during abort protected blocks
Vlad Brezae [Mon, 20 Mar 2017 23:00:17 +0000 (01:00 +0200)]
[runtime] Defer async requests during abort protected blocks

We avoid unnecessary checks for each interruption checkpoint.

7 years ago[runtime] Fix detecting abort at end of abort protected block
Vlad Brezae [Fri, 17 Mar 2017 21:45:50 +0000 (23:45 +0200)]
[runtime] Fix detecting abort at end of abort protected block

If we have a pending abort then we know we will have the thread_state set and the thread_interruption_requested bumped. We used to consume this request and set the MonoError with the exception. The problems with this is that not all callsites handle the passed MonoError and handling it means converting it back to a pending exception anyway. We just leave the interruption request untouched now.

If the cctor self aborts it means that we consumed the abort exception so we do need to call mono_thread_resume_interruption to reactivate it. We need to make sure that we still don't throw a TypeInitializationException if we had a self abort.

7 years ago[AppleTls]: Use correct definition of `SecTrustResult`. (#4586)
Martin Baulig [Thu, 23 Mar 2017 20:29:47 +0000 (16:29 -0400)]
[AppleTls]: Use correct definition of `SecTrustResult`. (#4586)

* [AppleTls]: Use correct definition of `SecTrustResult`.

We need all the values in this enum because `SecTrustResult.Unspecified`
means success - which currently has an integer value of 4, not 0.

* Oops, make it build.

* Don't make it public.

* Revert whitespace change.

7 years agoBump version to 5.1.0
Andi McClure [Thu, 23 Mar 2017 20:29:06 +0000 (16:29 -0400)]
Bump version to 5.1.0

7 years agoAdd test for AutomaticDecompression behaviour
Filip Navara [Thu, 23 Mar 2017 11:36:58 +0000 (12:36 +0100)]
Add test for AutomaticDecompression behaviour

Test that HttpWebRequest.AutomaticDecompression actually performs the
decompression and that it removes the Content-Encoding header. Also fix
the value of Content-Encoding for other tests to follow the HTTP
specification.

7 years agoRemove Content-Encoding header after doing automatic decompression
Filip Navara [Thu, 23 Mar 2017 09:54:18 +0000 (10:54 +0100)]
Remove Content-Encoding header after doing automatic decompression

Match the .NET Framework behaviour by removing the Content-Encoding
header after doing automatic decompression.

7 years ago[msvc] Update csproj files
monojenkins [Thu, 23 Mar 2017 16:21:08 +0000 (16:21 +0000)]
[msvc] Update csproj files

7 years ago[reflection] Set correct reflected type in MonoMethod.get_base_method
Aleksey Kliger [Wed, 22 Mar 2017 19:08:59 +0000 (15:08 -0400)]
[reflection] Set correct reflected type in MonoMethod.get_base_method

It can be the case that we have two different System.MonoMethod objects that both
point to the same native MonoMethod* but have two different reflected types.
(For example if we call derivedType.GetMethod("f") where f is virtual and
derivedType corresponds to a class that did not override a base definition.  In
that case, the MonoMethod* corresponds to the parent type's f method, but the
reflected type is derivedType)

In this case, GetBaseDefinition will return the same MonoMethod* but the
reflected type of the result should be the base type, not the derived type.

7 years ago[tests] Additional tests of System.Reflection.MethodInfo.GetBaseDefinition
Aleksey Kliger [Wed, 22 Mar 2017 20:19:25 +0000 (16:19 -0400)]
[tests] Additional tests of System.Reflection.MethodInfo.GetBaseDefinition

7 years ago[threadpool-io] Ensure selector thread is running before waiting on it (#4572)
Ludovic Henry [Thu, 23 Mar 2017 14:09:33 +0000 (10:09 -0400)]
[threadpool-io] Ensure selector thread is running before waiting on it (#4572)

This could result in a unecessary wait on shutdown where the selector thread would have exited, and the finalizer thread would try to dispose a Socket, which would try to remove the socket from the IOSelector. This removal operation would wait on the selector thread to acknowledge the removal, but because the selector thread would have alreday exited, we would wait on an event that would never happen.

7 years ago[mkbundle] Use correctly link paths when loading assembly deps
Andoni Morales Alastruey [Thu, 20 Oct 2016 09:17:38 +0000 (11:17 +0200)]
[mkbundle] Use correctly link paths when loading assembly deps

7 years agoinvoke_array_extract_argument() will create objects and set them in the parameters...
Brian Raderman [Wed, 8 Mar 2017 19:13:02 +0000 (14:13 -0500)]
invoke_array_extract_argument() will create objects and set them in the parameters array when it detects a null parameter, but when we return a by-value parameter may no longer be null, which is an error.  This fix detects the change and sets the parameter back to null for by-value parameters before we return.

7 years agoOne brace missed
Adrian Cheng [Wed, 15 Mar 2017 12:57:53 +0000 (20:57 +0800)]
One brace missed