From: Rolf Bjarne Kvinge <rolf@xamarin.com>
Date: Wed, 27 Jan 2016 16:39:45 +0000 (+0100)
Subject: [mono-api-info] Improve CleanupTypeName to not create 3 strings every time somethings... 
X-Git-Url: http://wien.tomnetworks.com/gitweb/?p=mono.git;a=commitdiff_plain;h=f4f993f4bf4b9c413f61e6b7704dbbf6964d74bd

[mono-api-info] Improve CleanupTypeName to not create 3 strings every time somethings needs to change.
---

diff --git a/mcs/tools/corcompare/mono-api-info.cs b/mcs/tools/corcompare/mono-api-info.cs
index e2bbb36751a..173c39f6604 100644
--- a/mcs/tools/corcompare/mono-api-info.cs
+++ b/mcs/tools/corcompare/mono-api-info.cs
@@ -119,6 +119,7 @@ namespace CorCompare
 	}
 
 	public class Utils {
+		static char[] CharsToCleanup = new char[] { '<', '>', '/' };
 
 		public static string CleanupTypeName (TypeReference type)
 		{
@@ -127,7 +128,27 @@ namespace CorCompare
 
 		public static string CleanupTypeName (string t)
 		{
-			return t.Replace ('<', '[').Replace ('>', ']').Replace ('/', '+');
+			if (t.IndexOfAny (CharsToCleanup) == -1)
+				return t;
+			var sb = new StringBuilder (t.Length);
+			for (int i = 0; i < t.Length; i++) {
+				var ch = t [i];
+				switch (ch) {
+				case '<':
+					sb.Append ('[');
+					break;
+				case '>':
+					sb.Append (']');
+					break;
+				case '/':
+					sb.Append ('+');
+					break;
+				default:
+					sb.Append (ch);
+					break;
+				}
+			}
+			return sb.ToString ();
 		}
 	}