From: lateralusX Date: Fri, 29 Sep 2017 12:19:44 +0000 (+0200) Subject: Updated with review feedback. X-Git-Url: http://wien.tomnetworks.com/gitweb/?p=mono.git;a=commitdiff_plain;h=216b92db17ef8c7d6cf86e6cd483df2c420251eb Updated with review feedback. --- diff --git a/msvc/README b/msvc/README index 7c6541e0282..375febbdbb2 100755 --- a/msvc/README +++ b/msvc/README @@ -22,12 +22,16 @@ MAINTENANCE Files that should not be build on Windows should be excluded using this configuration: - true - true - true - true + $(ExcludeFromWindowsBuild) + and at the begning of the target file have a property set when to exclude files. This example will always + exclude the file, but could be condtional if needed: + + + true + + All header files added to makefiles should be included in the different targets files for consistency. Each target file has a corresponding filter file, files added to target files should also be added to the corresponding diff --git a/msvc/eglib-posix.targets b/msvc/eglib-posix.targets index 3b758dd151e..4c1217eb1f3 100644 --- a/msvc/eglib-posix.targets +++ b/msvc/eglib-posix.targets @@ -1,41 +1,26 @@ + + true + - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) diff --git a/msvc/eglib-win32.targets b/msvc/eglib-win32.targets index 2e741df7913..fbe78bc87f5 100644 --- a/msvc/eglib-win32.targets +++ b/msvc/eglib-win32.targets @@ -9,5 +9,5 @@ - + diff --git a/msvc/libgc.targets b/msvc/libgc.targets index cf510fb7694..2dfb0bbb30f 100644 --- a/msvc/libgc.targets +++ b/msvc/libgc.targets @@ -1,178 +1,147 @@  + + true + true + false + - true - + $(ExcludeBoehmGCFromBuild) + - true - + $(ExcludeBoehmGCFromBuild) + - true - + $(ExcludeBoehmGCFromBuild) + - true - true - true - true - true + $(ExcludeBoehmGCFromBuild) + $(ExcludeFromWindowsBuild) - true - + $(ExcludeBoehmGCFromBuild) + - true - + $(ExcludeBoehmGCFromBuild) + - true - + $(ExcludeBoehmGCFromBuild) + - true - true - true - true - true + $(ExcludeBoehmGCFromBuild) + $(ExcludeFromWindowsBuild) - true - + $(ExcludeBoehmGCFromBuild) + - true - + $(ExcludeBoehmGCFromBuild) + - true - + $(ExcludeBoehmGCFromBuild) + - true - + $(ExcludeBoehmGCFromBuild) + - true - + $(ExcludeBoehmGCFromBuild) + - true - + $(ExcludeBoehmGCFromBuild) + - true - + $(ExcludeBoehmGCFromBuild) + - true - + $(ExcludeBoehmGCFromBuild) + - true - + $(ExcludeBoehmGCFromBuild) + - true - + $(ExcludeBoehmGCFromBuild) + - true - true - true - true - true + $(ExcludeBoehmGCFromBuild) + $(ExcludeFromWindowsBuild) - true - + $(ExcludeBoehmGCFromBuild) + - true - true - true - true - true + $(ExcludeBoehmGCFromBuild) + $(ExcludeFromWindowsBuild) - true - + $(ExcludeBoehmGCFromBuild) + - true - true - true - true - true + $(ExcludeBoehmGCFromBuild) + $(ExcludeFromWindowsBuild) - true - true - true - true - true + $(ExcludeBoehmGCFromBuild) + $(ExcludeFromWindowsBuild) - true - true - true - true - true + $(ExcludeBoehmGCFromBuild) + $(ExcludeFromWindowsBuild) - true - + $(ExcludeBoehmGCFromBuild) + - true - + $(ExcludeBoehmGCFromBuild) + - true - true - true - true - true + $(ExcludeBoehmGCFromBuild) + $(ExcludeFromWindowsBuild) - true - + $(ExcludeBoehmGCFromBuild) + - true - true - true - true - true + $(ExcludeBoehmGCFromBuild) + $(ExcludeFromWindowsBuild) - true - true - true - true - true + $(ExcludeBoehmGCFromBuild) + $(ExcludeFromWindowsBuild) - true - true - true - true - true + $(ExcludeBoehmGCFromBuild) + $(ExcludeFromWindowsBuild) - true - true - true - true - true + $(ExcludeBoehmGCFromBuild) + $(ExcludeFromWindowsBuild) - true - + $(ExcludeBoehmGCFromBuild) + - true + $(ExcludeBoehmGCFromBuild) - true + $(ExcludeBoehmGCFromBuild) - true - + $(ExcludeBoehmGCFromBuild) + - true + $(ExcludeBoehmGCFromBuild) - true + $(ExcludeBoehmGCFromBuild) - true - + $(ExcludeBoehmGCFromBuild) + - true + $(ExcludeBoehmGCFromBuild) diff --git a/msvc/libgcmonosgen.targets b/msvc/libgcmonosgen.targets index fc5cc26d586..75e62cb0bac 100644 --- a/msvc/libgcmonosgen.targets +++ b/msvc/libgcmonosgen.targets @@ -1,158 +1,162 @@  + + true + false + - true + $(ExcludeSGenGCFromBuild) - true - + $(ExcludeSGenGCFromBuild) + - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) - true + $(ExcludeSGenGCFromBuild) diff --git a/msvc/libmini-arch.targets b/msvc/libmini-arch.targets index 24fc1aadfa0..c02878fe9c1 100644 --- a/msvc/libmini-arch.targets +++ b/msvc/libmini-arch.targets @@ -1,231 +1,151 @@ + + true + false + false + true + true + - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true + $(ExcludeFromWindows64Build) - true - true + $(ExcludeFromWindows64Build) - true - true + $(ExcludeFromWindows64Build) - true - true + $(ExcludeFromWindows64Build) - true - true + $(ExcludeFromWindows64Build) - true - true + $(ExcludeFromWindows64Build) - true - true + $(ExcludeFromWindows32Build) - true - true + $(ExcludeFromWindows32Build) - true - true + $(ExcludeFromWindows32Build) - true - true + $(ExcludeFromWindows32Build) - true - true + $(ExcludeFromWindows32Build) - true - true + $(ExcludeFromWindows32Build) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true - + $(ExcludeFromWindowsBuild) + - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) diff --git a/msvc/libmini-interp.targets b/msvc/libmini-interp.targets index a3b0e63b84a..350b8a66b5d 100644 --- a/msvc/libmini-interp.targets +++ b/msvc/libmini-interp.targets @@ -1,29 +1,23 @@ + + true + - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) diff --git a/msvc/libmini-llvm.targets b/msvc/libmini-llvm.targets index 432b99c24b7..f4b6737f6f4 100644 --- a/msvc/libmini-llvm.targets +++ b/msvc/libmini-llvm.targets @@ -1,35 +1,23 @@ + + true + - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) diff --git a/msvc/libmini-posix.targets b/msvc/libmini-posix.targets index 39b348a29ef..12132021680 100644 --- a/msvc/libmini-posix.targets +++ b/msvc/libmini-posix.targets @@ -1,19 +1,16 @@ + + true + - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) diff --git a/msvc/libmonoruntime-common.targets b/msvc/libmonoruntime-common.targets index 69f10227f6b..67e0bc8e837 100644 --- a/msvc/libmonoruntime-common.targets +++ b/msvc/libmonoruntime-common.targets @@ -6,16 +6,16 @@ - + - + - + @@ -56,14 +56,14 @@ - + - + @@ -199,15 +199,15 @@ - + - + - + @@ -217,7 +217,7 @@ - + diff --git a/msvc/libmonoruntime-posix.targets b/msvc/libmonoruntime-posix.targets index 9ea4f29f1f8..ff2534889d4 100644 --- a/msvc/libmonoruntime-posix.targets +++ b/msvc/libmonoruntime-posix.targets @@ -1,85 +1,49 @@ + + true + - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) diff --git a/msvc/libmonoruntime-posix.targets.filters b/msvc/libmonoruntime-posix.targets.filters index becf24e9c60..5718e6a0d22 100644 --- a/msvc/libmonoruntime-posix.targets.filters +++ b/msvc/libmonoruntime-posix.targets.filters @@ -45,7 +45,7 @@ Source Files$(MonoRuntimeFilterSubFolder)\posix - + diff --git a/msvc/libmonoruntime-win32.targets.filters b/msvc/libmonoruntime-win32.targets.filters index eab619cb689..3b360da00e2 100644 --- a/msvc/libmonoruntime-win32.targets.filters +++ b/msvc/libmonoruntime-win32.targets.filters @@ -48,7 +48,7 @@ Header Files$(MonoRuntimeFilterSubFolder)\win32 - + Source Files$(MonoRuntimeFilterSubFolder)\win32 diff --git a/msvc/libmonoutils-arch.targets b/msvc/libmonoutils-arch.targets index 2790d649a0a..041daa7863d 100644 --- a/msvc/libmonoutils-arch.targets +++ b/msvc/libmonoutils-arch.targets @@ -1,110 +1,77 @@ + + true + false + false + true + true + - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) Document - true - true + $(ExcludeFromWindows32Build) X64 - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) diff --git a/msvc/libmonoutils-arch.targets.filters b/msvc/libmonoutils-arch.targets.filters index 261fc2f662e..836b30fb65d 100644 --- a/msvc/libmonoutils-arch.targets.filters +++ b/msvc/libmonoutils-arch.targets.filters @@ -65,7 +65,7 @@ Source Files$(MonoUtilsFilterSubFolder)\arch\cross - + diff --git a/msvc/libmonoutils-common.targets b/msvc/libmonoutils-common.targets index f68262ab176..d9da64597f1 100644 --- a/msvc/libmonoutils-common.targets +++ b/msvc/libmonoutils-common.targets @@ -1,5 +1,8 @@ + + true + @@ -14,44 +17,26 @@ - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) @@ -132,71 +117,38 @@ - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) - true - true - true - true + $(ExcludeFromWindowsBuild) @@ -212,7 +164,7 @@ - + @@ -238,14 +190,14 @@ - + - + - + diff --git a/msvc/libmonoutils-posix.targets b/msvc/libmonoutils-posix.targets index c0d070e8fa8..16da38196fe 100644 --- a/msvc/libmonoutils-posix.targets +++ b/msvc/libmonoutils-posix.targets @@ -1,11 +1,11 @@ + + true + - true - true - true - true + $(ExcludeFromWindowsBuild) diff --git a/msvc/monoposixhelper.targets b/msvc/monoposixhelper.targets index 4a00ec1f344..6d5d9c1fa02 100644 --- a/msvc/monoposixhelper.targets +++ b/msvc/monoposixhelper.targets @@ -1,6 +1,5 @@  -