From: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Mon, 19 Jun 2017 10:54:32 +0000 (+0200)
Subject: [btls] Fix a small memleak in btls-x509-lookup.c (#5065)
X-Git-Url: http://wien.tomnetworks.com/gitweb/?p=mono.git;a=commitdiff_plain;h=1aef35403dc6978a581d38469fdbed4f4b30ba83

[btls] Fix a small memleak in btls-x509-lookup.c (#5065)

Noticed this while looking at the Clang Analysis Report[1] as the
only memory leak in the report and thought why not fix it :)

[1] https://jenkins.mono-project.com/job/test-mono-mainline-staticanalysis/Clang_Analysis_Report/
---

diff --git a/mono/btls/btls-x509-lookup.c b/mono/btls/btls-x509-lookup.c
index 567d19c237a..9e7dbee7702 100644
--- a/mono/btls/btls-x509-lookup.c
+++ b/mono/btls/btls-x509-lookup.c
@@ -48,8 +48,10 @@ mono_btls_x509_lookup_new (MonoBtlsX509Store *store, MonoBtlsX509LookupType type
 		return NULL;
 
 	store_lookup = X509_STORE_add_lookup (mono_btls_x509_store_peek_store (store), method);
-	if (!store_lookup)
+	if (!store_lookup) {
+		OPENSSL_free (lookup);
 		return NULL;
+	}
 
 	memset (lookup, 0, sizeof(MonoBtlsX509Lookup));
 	// The X509_STORE owns the X509_LOOKUP.