[Microsoft.Build] Make BuildSubmissionTest.EndBuildWaitsForCompletion more reliable...
authorAlexander Köplinger <alex.koeplinger@outlook.com>
Fri, 14 Jul 2017 12:47:14 +0000 (14:47 +0200)
committerGitHub <noreply@github.com>
Fri, 14 Jul 2017 12:47:14 +0000 (14:47 +0200)
commit5dd17f89421f7911c6da5f8bc057ace775e0cd20
treec7d651ec837f9e417ab2f89bdecb86db120d16b1
parent2c59986b441cbcabc139feea58cb80aa3b09371a
[Microsoft.Build] Make BuildSubmissionTest.EndBuildWaitsForCompletion more reliable (#5209)

We've seen this test failure a few times:

```
MESSAGE:
  #2
  Expected: greater than or equal to 00:00:01
  But was:  00:00:00.9544900

+++++++++++++++++++
STACK TRACE:
  at MonoTests.Microsoft.Build.Execution.BuildSubmissionTest.EndBuildWaitsForSubmissionCompletion () [0x000d8] in /mnt/jenkins/workspace/test-mono-mainline-linux/label/ubuntu-1404-amd64/mcs/class/Microsoft.Build/Test/Microsoft.Build.Execution/BuildSubmissionTest.cs:110
  at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
  at System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00032] in /mnt/jenkins/workspace/test-mono-mainline-linux/label/ubuntu-1404-amd64/mcs/class/corlib/System.Reflection/MonoMethod.cs:305
```

Rewriting the test to use Stopwatch instead of DateTime
for measuring elapsed time should make it more reliable.
mcs/class/Microsoft.Build/Test/Microsoft.Build.Execution/BuildSubmissionTest.cs
mcs/class/test-helpers/NunitHelpers.cs