From c55bcdecf70586ba575af403f26f92dbbbc05190 Mon Sep 17 00:00:00 2001 From: Uwe Hermann Date: Thu, 9 Jun 2011 20:56:29 +0200 Subject: [PATCH] superiotool: Cosmetics and coding style fixes. Change-Id: Iacda2a9e37635d5cffc5004caf588ef3e5e09b5e Signed-off-by: Uwe Hermann Reviewed-on: http://review.coreboot.org/18 Tested-by: build bot (Jenkins) Reviewed-by: David Hendricks --- util/superiotool/ite.c | 21 ++++++++++++++------- util/superiotool/smsc.c | 4 ++-- util/superiotool/winbond.c | 12 ++++++++---- 3 files changed, 24 insertions(+), 13 deletions(-) diff --git a/util/superiotool/ite.c b/util/superiotool/ite.c index 0e43614c0..c83d78830 100644 --- a/util/superiotool/ite.c +++ b/util/superiotool/ite.c @@ -892,37 +892,44 @@ void probe_idregs_ite(uint16_t port) enter_conf_mode_ite_legacy(port, initkey_it8661f); probe_idregs_ite_helper("(init=legacy/it8661f) ", port); exit_conf_mode_ite(port); - if (chip_found_at_port) return; + if (chip_found_at_port) + return; enter_conf_mode_ite_legacy(port, initkey_it8671f); probe_idregs_ite_helper("(init=legacy/it8671f) ", port); exit_conf_mode_ite(port); - if (chip_found_at_port) return; + if (chip_found_at_port) + return; } else { enter_conf_mode_ite(port); probe_idregs_ite_helper("(init=standard) ", port); exit_conf_mode_ite(port); - if (chip_found_at_port) return; + if (chip_found_at_port) + return; enter_conf_mode_ite_it8502e(port); probe_idregs_ite_helper("(init=it8502e) ", port); exit_conf_mode_ite(port); - if (chip_found_at_port) return; + if (chip_found_at_port) + return; enter_conf_mode_ite_it8761e(port); probe_idregs_ite_helper("(init=it8761e) ", port); exit_conf_mode_ite(port); - if (chip_found_at_port) return; + if (chip_found_at_port) + return; enter_conf_mode_ite_it8228e(port); probe_idregs_ite_helper("(init=it8228e) ", port); exit_conf_mode_ite(port); - if (chip_found_at_port) return; + if (chip_found_at_port) + return; enter_conf_mode_winbond_fintek_ite_8787(port); probe_idregs_ite_helper("(init=0x87,0x87) ", port); exit_conf_mode_winbond_fintek_ite_8787(port); - if (chip_found_at_port) return; + if (chip_found_at_port) + return; } } diff --git a/util/superiotool/smsc.c b/util/superiotool/smsc.c index 260f3bb20..820be0871 100644 --- a/util/superiotool/smsc.c +++ b/util/superiotool/smsc.c @@ -396,7 +396,7 @@ static const struct superio_registers reg_table[] = { {0x4d, "MEC1308", { {NOLDN, NULL, {0x02,0x03,0x07,0x17,0x20,0x21,0x22,0x23,0x24,0x25, - 0x26,0x27,0X28,0X29,0X2a,0X2b,0X2c,0X2d,0X2e,0X2f, + 0x26,0x27,0x28,0x29,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f, EOT}, {0x00,RSVD,0x00,RSVD,0x4d,0x00,0x00,0x00,0x04,0x04, MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC, @@ -408,7 +408,7 @@ static const struct superio_registers reg_table[] = { {0x30,0x60,0x61,0x70,EOT}, {0x00,0x00,0x00,0x00,EOT}}, {0x7, "KBD", - {0x30,0x70,0x72,0xF0,EOT}, + {0x30,0x70,0x72,0xf0,EOT}, {0x00,0x00,0x00,0x00,EOT}}, {0x8, "EC/ACPI", {0x30,0x60,0x61,EOT}, diff --git a/util/superiotool/winbond.c b/util/superiotool/winbond.c index d29b87ff6..a3c6547d5 100644 --- a/util/superiotool/winbond.c +++ b/util/superiotool/winbond.c @@ -749,22 +749,26 @@ void probe_idregs_winbond(uint16_t port) enter_conf_mode_winbond_88(port); probe_idregs_winbond_helper("(init=0x88) ", port); exit_conf_mode_winbond_fintek_ite_8787(port); - if (chip_found_at_port) return; + if (chip_found_at_port) + return; enter_conf_mode_winbond_89(port); probe_idregs_winbond_helper("(init=0x89) ", port); exit_conf_mode_winbond_fintek_ite_8787(port); - if (chip_found_at_port) return; + if (chip_found_at_port) + return; enter_conf_mode_winbond_86(port); probe_idregs_winbond_helper("(init=0x86,0x86) ", port); exit_conf_mode_winbond_fintek_ite_8787(port); - if (chip_found_at_port) return; + if (chip_found_at_port) + return; enter_conf_mode_winbond_fintek_ite_8787(port); probe_idregs_winbond_helper("(init=0x87,0x87) ", port); exit_conf_mode_winbond_fintek_ite_8787(port); - if (chip_found_at_port) return; + if (chip_found_at_port) + return; } void print_winbond_chips(void) -- 2.25.1