From 67e6c2aaf4d4194dac824014197cc684af9750f5 Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Wed, 18 Jan 2012 10:05:18 -0800 Subject: [PATCH] Don't re-init EBDA in S3 resume path. I forgot to implement this the first time around. It does not seem to cause noticeable problems but in heavy suspend/resume testing I saw a suspicious crash in the kernel when trying to bring one of the CPUs back online. Change-Id: I950ac260f251e2683693d9bd20a0dd5e041aa26e Signed-off-by: Duncan Laurie Reviewed-on: http://review.coreboot.org/770 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich --- src/arch/x86/lib/ebda.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/arch/x86/lib/ebda.c b/src/arch/x86/lib/ebda.c index faf1451a2..fb407b6ac 100644 --- a/src/arch/x86/lib/ebda.c +++ b/src/arch/x86/lib/ebda.c @@ -23,9 +23,18 @@ #include #include #include +#if CONFIG_HAVE_ACPI_RESUME +#include +#endif void setup_ebda(u32 low_memory_size, u16 ebda_segment, u16 ebda_size) { +#if CONFIG_HAVE_ACPI_RESUME + /* Skip in S3 resume path */ + if (acpi_slp_type == 3) + return; +#endif + if (!low_memory_size || !ebda_segment || !ebda_size) return; -- 2.25.1