From: Marc Jones Date: Tue, 6 Jan 2009 16:45:42 +0000 (+0000) Subject: The ACPI PSS CPU Pstate table was calculating the frequency incorrectly for X-Git-Url: http://wien.tomnetworks.com/gitweb/?p=coreboot.git;a=commitdiff_plain;h=505aaf56e21b94e52cfdeb16b765163f7604e1aa The ACPI PSS CPU Pstate table was calculating the frequency incorrectly for revF CPUs. The 100MHz/200MHz stepping is already handled in the FID setting and doesn't need to be checked to set the fid_multiplier. The multiplier is always 100. Signed-off-by: Marc Jones Acked-by: zheng bao git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3847 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- diff --git a/src/mainboard/amd/dbm690t/acpi_tables.c b/src/mainboard/amd/dbm690t/acpi_tables.c index eb3433cc6..987eeae8b 100644 --- a/src/mainboard/amd/dbm690t/acpi_tables.c +++ b/src/mainboard/amd/dbm690t/acpi_tables.c @@ -258,12 +258,11 @@ u32 pstates_algorithm(acpi_header_t * dsdt) return 0; } - /*get the multipier of the fid frequency */ + /* Get the multipier of the fid frequency */ /* - * In RevG, 100MHz step is added + * Fid multiplier is always 100 revF and revG. */ - cpuid1 = cpuid(0x80000007); - fid_multiplier = ((cpuid1.edx & 0x40) >> 6) * 100; + fid_multiplier = 100; /* * Formula1: CPUFreq = FID * fid_multiplier + 800 diff --git a/src/mainboard/amd/pistachio/acpi_tables.c b/src/mainboard/amd/pistachio/acpi_tables.c index eb3433cc6..dfb916748 100644 --- a/src/mainboard/amd/pistachio/acpi_tables.c +++ b/src/mainboard/amd/pistachio/acpi_tables.c @@ -258,12 +258,11 @@ u32 pstates_algorithm(acpi_header_t * dsdt) return 0; } - /*get the multipier of the fid frequency */ + /* Get the multipier of the fid frequency */ /* - * In RevG, 100MHz step is added + * Fid multiplier is always 100 revF and revG. */ - cpuid1 = cpuid(0x80000007); - fid_multiplier = ((cpuid1.edx & 0x40) >> 6) * 100; + fid_multiplier = 100; /* * Formula1: CPUFreq = FID * fid_multiplier + 800