libpayload: fix possible mem leak in get_option_as_string()
authorMathias Krause <mathias.krause@secunet.com>
Wed, 8 Feb 2012 09:31:42 +0000 (10:31 +0100)
committerPeter Stuge <peter@stuge.se>
Fri, 10 Feb 2012 14:15:01 +0000 (15:15 +0100)
Change-Id: I7c3adbd1b72be81585bbaabb42532fc4cad57f58
Signed-off-by: Mathias Krause <mathias.krause@secunet.com>
Reviewed-on: http://review.coreboot.org/616
Tested-by: build bot (Jenkins)
Reviewed-by: Peter Stuge <peter@stuge.se>
payloads/libpayload/drivers/options.c

index 10d165ecc713382a4c2c036b9e5049a79c12eaef..8161c22e12898cf151861fa20815beacb3e708f3 100644 (file)
@@ -292,7 +292,7 @@ int get_option_as_string(const struct nvram_accessor *nvram, struct cb_cmos_opti
                        *dest = strdup((const char*)cmos_enum->text);
                        break;
                default: /* fail */
-                       return 1;
+                       ret = 1;
        }
        free(raw);
        return ret;