Currently the
authorTobias Diedrich <ranma+coreboot@tdiedrich.de>
Sun, 14 Nov 2010 14:12:14 +0000 (14:12 +0000)
committerRudolf Marek <r.marek@assembler.cz>
Sun, 14 Nov 2010 14:12:14 +0000 (14:12 +0000)
commitd441afda9106d000ff1d518bad01e98cfb26630e
treeafebdc883a3aa5cb09ace2b0ac8031cd65189aee
parentf3cce2f3c4ff4af4a386bddd49c92a55ad9cefa2
Currently the
        cablesel |= (sb->ide0_80pin_cable << 28) |
                    (sb->ide0_80pin_cable << 20) |
                    (sb->ide1_80pin_cable << 12) |
                    (sb->ide1_80pin_cable << 4);
in vt8237r_ide.c ends up doing
cablesel |= 0xfffffff0;
(with both bits set to 1) which is probably not the intended result. ;)

After a short discussion on irc the consensus was to change the
bitfields to u8 as it's probably not worth it using bitfields here.

Signed-off-by: Tobias Diedrich <ranma+coreboot@tdiedrich.de>
Acked-by: Rudolf Marek <r.marek@assembler.cz>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6068 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
src/southbridge/via/vt8237r/chip.h