cbfstool: improve error messages

[coreboot.git] / util / cbfstool / cbfstool.c

diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c
index 3c6db6f231ef3393157a1373da504db79db04c81..f017b2e2e07f3d58e2c1d938b0e4ba09edd0693b 100644 (file)
--- a/util/cbfstool/cbfstool.c
+++ b/util/cbfstool/cbfstool.c
@@ -19,7 +19,7 @@
  */
 
 #include <stdio.h>
-#include <stdint.h>
+#include <string.h>
 #include "common.h"
 #include "cbfs.h"
 
@@ -29,7 +29,8 @@ typedef enum {
        CMD_ADD_STAGE,
        CMD_CREATE,
        CMD_LOCATE,
-       CMD_PRINT
+       CMD_PRINT,
+       CMD_EXTRACT,
 } cmd_t;
 
 struct command {
@@ -80,9 +81,12 @@ static int cbfs_add(int argc, char **argv)
                base = strtoul(argv[6], NULL, 0);
        }
        cbfsfile = create_cbfs_file(cbfsname, filedata, &filesize, type, &base);
-       if (add_file_to_cbfs(cbfsfile, filesize, base))
+       if (add_file_to_cbfs(cbfsfile, filesize, base)) {
+               printf("Adding file '%s' failed.\n", filename);
+               return 1;
+       }
+       if (writerom(romname, rom, romsize))
                return 1;
-       writerom(romname, rom, romsize);
        return 0;
 }
 
@@ -128,9 +132,12 @@ static int cbfs_add_payload(int argc, char **argv)
        cbfsfile =
            create_cbfs_file(cbfsname, payload, &filesize,
                             CBFS_COMPONENT_PAYLOAD, &base);
-       if (add_file_to_cbfs(cbfsfile, filesize, base))
+       if (add_file_to_cbfs(cbfsfile, filesize, base)) {
+               printf("Adding payload '%s' failed.\n", filename);
+               return 1;
+       }
+       if (writerom(romname, rom, romsize))
                return 1;
-       writerom(romname, rom, romsize);
        return 0;
 }
 
@@ -177,9 +184,12 @@ static int cbfs_add_stage(int argc, char **argv)
            create_cbfs_file(cbfsname, stage, &filesize,
                             CBFS_COMPONENT_STAGE, &base);
 
-       if (add_file_to_cbfs(cbfsfile, filesize, base))
+       if (add_file_to_cbfs(cbfsfile, filesize, base)) {
+               printf("Adding stage '%s' failed.\n", filename);
+               return 1;
+       }
+       if (writerom(romname, rom, romsize))
                return 1;
-       writerom(romname, rom, romsize);
        return 0;
 }
 
@@ -241,29 +251,55 @@ static int cbfs_print(int argc, char **argv)
        return 0;
 }
 
+static int cbfs_extract(int argc, char **argv)
+{
+       char *romname = argv[1];
+       char *cmd = argv[2];
+       void *rom = loadrom(romname);
+
+       if (rom == NULL) {
+               printf("Could not load ROM image '%s'.\n", romname);
+               return 1;
+       }
+
+       if (argc != 5)
+       {
+               printf("Error: you must specify a CBFS name and a file to dump it in.\n");
+               return 1;
+       }
+
+       return extract_file_from_cbfs(romname, argv[3], argv[4]);
+}
+
 struct command commands[] = {
        {CMD_ADD, "add", cbfs_add},
        {CMD_ADD_PAYLOAD, "add-payload", cbfs_add_payload},
        {CMD_ADD_STAGE, "add-stage", cbfs_add_stage},
        {CMD_CREATE, "create", cbfs_create},
        {CMD_LOCATE, "locate", cbfs_locate},
-       {CMD_PRINT, "print", cbfs_print}
+       {CMD_PRINT, "print", cbfs_print},
+       {CMD_EXTRACT, "extract", cbfs_extract},
 };
 
 void usage(void)
 {
        printf
-           ("cbfstool: Management utility for CBFS formatted ROM images\n"
-            "USAGE:\n" "cbfstool [-h]\n"
-            "cbfstool FILE COMMAND [PARAMETERS]...\n\n" "OPTIONs:\n"
-            " -h               Display this help message\n\n"
+           ("cbfstool: Management utility for CBFS formatted ROM images\n\n"
+            "USAGE:\n" " cbfstool [-h]\n"
+            " cbfstool FILE COMMAND [PARAMETERS]...\n\n" "OPTIONs:\n"
+            "  -h              Display this help message\n\n"
             "COMMANDs:\n"
-            "add FILE NAME TYPE [base address]    Add a component\n"
-            "add-payload FILE NAME [COMP] [base]  Add a payload to the ROM\n"
-            "add-stage FILE NAME [COMP] [base]    Add a stage to the ROM\n"
-            "create SIZE BOOTBLOCK [ALIGN]        Create a ROM file\n"
-            "locate FILE NAME ALIGN               Find a place for a file of that size\n"
-            "print                                Show the contents of the ROM\n");
+            " add FILE NAME TYPE [base address]    Add a component\n"
+            " add-payload FILE NAME [COMP] [base]  Add a payload to the ROM\n"
+            " add-stage FILE NAME [COMP] [base]    Add a stage to the ROM\n"
+            " create SIZE BOOTBLOCK [ALIGN]        Create a ROM file\n"
+            " locate FILE NAME ALIGN               Find a place for a file of that size\n"
+            " print                                Show the contents of the ROM\n"
+            " extract NAME FILE                    Extracts a raw payload from ROM\n"
+            "\n"
+            "TYPEs:\n"
+            );
+       print_supported_filetypes();
 }
 
 int main(int argc, char **argv)