Various fixes to cbfstool.

[coreboot.git] / util / cbfstool / cbfstool.c

diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c
index 4c28c2984490f07688c3d7321be049b81d2da8c3..b8abb515bf42cdddcb3dbb9a2f7b49c9958468ac 100644 (file)
--- a/util/cbfstool/cbfstool.c
+++ b/util/cbfstool/cbfstool.c
@@ -19,7 +19,9 @@
  */
 
 #include <stdio.h>
+#include <stdlib.h>
 #include <string.h>
+#include <ctype.h>
 #include "common.h"
 #include "cbfs.h"
 
@@ -81,8 +83,10 @@ static int cbfs_add(int argc, char **argv)
                base = strtoul(argv[6], NULL, 0);
        }
        cbfsfile = create_cbfs_file(cbfsname, filedata, &filesize, type, &base);
-       if (add_file_to_cbfs(cbfsfile, filesize, base))
+       if (add_file_to_cbfs(cbfsfile, filesize, base)) {
+               printf("Adding file '%s' failed.\n", filename);
                return 1;
+       }
        if (writerom(romname, rom, romsize))
                return 1;
        return 0;
@@ -130,8 +134,10 @@ static int cbfs_add_payload(int argc, char **argv)
        cbfsfile =
            create_cbfs_file(cbfsname, payload, &filesize,
                             CBFS_COMPONENT_PAYLOAD, &base);
-       if (add_file_to_cbfs(cbfsfile, filesize, base))
+       if (add_file_to_cbfs(cbfsfile, filesize, base)) {
+               printf("Adding payload '%s' failed.\n", filename);
                return 1;
+       }
        if (writerom(romname, rom, romsize))
                return 1;
        return 0;
@@ -180,8 +186,10 @@ static int cbfs_add_stage(int argc, char **argv)
            create_cbfs_file(cbfsname, stage, &filesize,
                             CBFS_COMPONENT_STAGE, &base);
 
-       if (add_file_to_cbfs(cbfsfile, filesize, base))
+       if (add_file_to_cbfs(cbfsfile, filesize, base)) {
+               printf("Adding stage '%s' failed.\n", filename);
                return 1;
+       }
        if (writerom(romname, rom, romsize))
                return 1;
        return 0;
@@ -190,7 +198,6 @@ static int cbfs_add_stage(int argc, char **argv)
 static int cbfs_create(int argc, char **argv)
 {
        char *romname = argv[1];
-       char *cmd = argv[2];
        if (argc < 5) {
                printf("not enough arguments to 'create'.\n");
                return 1;
@@ -233,7 +240,6 @@ static int cbfs_locate(int argc, char **argv)
 static int cbfs_print(int argc, char **argv)
 {
        char *romname = argv[1];
-       char *cmd = argv[2];
        void *rom = loadrom(romname);
 
        if (rom == NULL) {
@@ -248,7 +254,6 @@ static int cbfs_print(int argc, char **argv)
 static int cbfs_extract(int argc, char **argv)
 {
        char *romname = argv[1];
-       char *cmd = argv[2];
        void *rom = loadrom(romname);
 
        if (rom == NULL) {
@@ -265,7 +270,7 @@ static int cbfs_extract(int argc, char **argv)
        return extract_file_from_cbfs(romname, argv[3], argv[4]);
 }
 
-struct command commands[] = {
+static const struct command commands[] = {
        {CMD_ADD, "add", cbfs_add},
        {CMD_ADD_PAYLOAD, "add-payload", cbfs_add_payload},
        {CMD_ADD_STAGE, "add-stage", cbfs_add_stage},
@@ -275,7 +280,7 @@ struct command commands[] = {
        {CMD_EXTRACT, "extract", cbfs_extract},
 };
 
-void usage(void)
+static void usage(void)
 {
        printf
            ("cbfstool: Management utility for CBFS formatted ROM images\n\n"
@@ -296,6 +301,20 @@ void usage(void)
        print_supported_filetypes();
 }
 
+/* Small, OS/libc independent runtime check
+ * for endianess
+ */
+int host_bigendian = 0;
+
+static void which_endian(void)
+{
+       char test[4] = "1234";
+       uint32_t inttest = *(uint32_t *) test;
+       if (inttest == 0x31323334) {
+               host_bigendian = 1;
+       }
+}
+
 int main(int argc, char **argv)
 {
        int i;
@@ -305,6 +324,8 @@ int main(int argc, char **argv)
                return 1;
        }
 
+       which_endian();
+
        char *cmd = argv[2];
 
        for (i = 0; i < ARRAY_SIZE(commands); i++) {