C and other Super I/O cosmetic fixes.

[coreboot.git] / src / superio / nsc / pc87417 / pc87417_early_init.c

diff --git a/src/superio/nsc/pc87417/pc87417_early_init.c b/src/superio/nsc/pc87417/pc87417_early_init.c
index c9332eedbe0c862bc415046b026607b4305c6846..a635beb61d5566a66f59bd83bbcba8790ea51b1b 100644 (file)
--- a/src/superio/nsc/pc87417/pc87417_early_init.c
+++ b/src/superio/nsc/pc87417/pc87417_early_init.c
@@ -3,7 +3,7 @@
  *
  * Copyright (C) 2000 AG Electronics Ltd.
  * Copyright (C) 2003-2004 Linux Networx
- * Copyright (C) 2004 Tyan by yhlu
+ * Copyright (C) 2004 Tyan
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -29,7 +29,7 @@ static void pc87417_disable_dev(device_t dev)
        pnp_set_enable(dev, 0);
 }
 
-static void pc87417_enable_dev(device_t dev, unsigned iobase)
+static void pc87417_enable_dev(device_t dev, u16 iobase)
 {
        pnp_set_logical_device(dev);
        pnp_set_enable(dev, 0);
@@ -39,17 +39,16 @@ static void pc87417_enable_dev(device_t dev, unsigned iobase)
 
 static void xbus_cfg(device_t dev)
 {
-       uint8_t i, data;
-       uint16_t xbus_index;
+       u8 i, data;
+       u16 xbus_index;
 
        pnp_set_logical_device(dev);
-       /* select proper BIOS size (4MB) */
-       pnp_write_config(dev, PC87417_XMEMCNF2, (pnp_read_config(dev, PC87417_XMEMCNF2)) | 0x04);
+       /* Select proper BIOS size (4MB). */
+       pnp_write_config(dev, PC87417_XMEMCNF2,
+                        (pnp_read_config(dev, PC87417_XMEMCNF2)) | 0x04);
        xbus_index = pnp_read_iobase(dev, 0x60);
 
-       /* enable writes to devices attached to XCS0 (XBUS Chip Select 0) */
-       for (i=0; i<= 0xf; i++) {
-               outb((i<<4), xbus_index + PC87417_HAP0);
-       }
-       return;
+       /* Enable writes to devices attached to XCS0 (XBUS Chip Select 0). */
+       for (i = 0; i <= 0xf; i++)
+               outb((i << 4), xbus_index + PC87417_HAP0);
 }