Some more DIMM0 related cleanups and deduplication.

[coreboot.git] / src / mainboard / dell / s1850 / debug.c

diff --git a/src/mainboard/dell/s1850/debug.c b/src/mainboard/dell/s1850/debug.c
index 45315618b7c4aa90d104e1b8ee041047674fa9f4..7904c0635a00b7db0d07a977832ef18004167e94 100644 (file)
--- a/src/mainboard/dell/s1850/debug.c
+++ b/src/mainboard/dell/s1850/debug.c
@@ -1,6 +1,4 @@
-#define SMBUS_MEM_DEVICE_START 0x50
-#define SMBUS_MEM_DEVICE_END 0x57
-#define SMBUS_MEM_DEVICE_INC 1
+#include <spd.h>
 
 static void print_reg(unsigned char index)
 {
@@ -208,8 +206,8 @@ static void dump_pci_devices(void)
 void dump_spd_registers(void)
 {
         unsigned device;
-        device = SMBUS_MEM_DEVICE_START;
-        while(device <= SMBUS_MEM_DEVICE_END) {
+        device = DIMM0;
+        while(device <= DIMM7) {
                 int status = 0;
                 int i;
                print_debug("\n");
@@ -233,7 +231,7 @@ void dump_spd_registers(void)
                        print_debug_hex8(status);
                        print_debug_char(' ');
                }
-               device += SMBUS_MEM_DEVICE_INC;
+               device++;
                print_debug("\n");
        }
 }
@@ -241,8 +239,8 @@ void dump_spd_registers(void)
 void show_dram_slots(void)
 {
         unsigned device;
-        device = SMBUS_MEM_DEVICE_START;
-        while(device <= SMBUS_MEM_DEVICE_END) {
+        device = DIMM0;
+        while(device <= DIMM7) {
                 int status = 0;
                int i;
                print_debug("\n");
@@ -257,7 +255,7 @@ void show_dram_slots(void)
                }
                print_debug_hex8(status);
                print_debug("\n");
-               device += SMBUS_MEM_DEVICE_INC;
+               device++;
                print_debug("\n");
        }
 }
@@ -285,7 +283,7 @@ void dump_ipmi_registers(void)
                        print_debug_hex8(status);
                        print_debug_char(' ');
                }
-               device += SMBUS_MEM_DEVICE_INC;
+               device++;
                print_debug("\n");
        }
 }