From: Stefan Ring Date: Sat, 25 Feb 2012 09:11:36 +0000 (+0100) Subject: * src/native/jni.cpp (GetObjectClass): Remove null pointer check. X-Git-Url: http://wien.tomnetworks.com/gitweb/?p=cacao.git;a=commitdiff_plain;h=f5287d069d5089f7100420be5fdcc25755ce3011 * src/native/jni.cpp (GetObjectClass): Remove null pointer check. * tests/regression/native/checkjni.java: Adapt test. * tests/regression/native/checkjni.output: Adapt test output. Hotspot doesn't accept a null pointer here, so neither should we. --- diff --git a/src/native/jni.cpp b/src/native/jni.cpp index 9a06ab245..bf1401a65 100644 --- a/src/native/jni.cpp +++ b/src/native/jni.cpp @@ -1,6 +1,6 @@ /* src/native/jni.cpp - implementation of the Java Native Interface functions - Copyright (C) 1996-2011 + Copyright (C) 1996-2012 CACAOVM - Verein zur Foerderung der freien virtuellen Maschine CACAO This file is part of CACAO. @@ -1425,9 +1425,6 @@ jclass jni_GetObjectClass(JNIEnv *env, jobject obj) o = (java_handle_t *) obj; - if ((o == NULL) || (LLNI_vftbl_direct(o) == NULL)) - return NULL; - LLNI_class_get(o, c); java_handle_t* h = LLNI_classinfo_wrap(c); diff --git a/tests/regression/native/checkjni.java b/tests/regression/native/checkjni.java index e7de87733..5cfd2f409 100644 --- a/tests/regression/native/checkjni.java +++ b/tests/regression/native/checkjni.java @@ -1,9 +1,7 @@ /* src/tests/native/checkjni.java - for testing JNI related stuff - Copyright (C) 1996-2005, 2006 R. Grafl, A. Krall, C. Kruegel, - C. Oates, R. Obermaisser, M. Platter, M. Probst, S. Ring, - E. Steiner, C. Thalinger, D. Thuernbeck, P. Tomsich, C. Ullrich, - TU Wien + Copyright (C) 1996-2012 + CACAOVM - Verein zur Foerderung der freien virtuellen Maschine CACAO This file is part of CACAO. @@ -22,12 +20,6 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - Contact: cacao@cacaojvm.org - - Authors: Christian Thalinger - - Changes: - */ @@ -140,7 +132,6 @@ public class checkjni { equal(GetObjectClass(obj1), clazz1); equal(GetObjectClass(obj2), clazz2); - equal(GetObjectClass(null), null); } void checkNewString() { diff --git a/tests/regression/native/checkjni.output b/tests/regression/native/checkjni.output index 418953246..0b05c7479 100644 --- a/tests/regression/native/checkjni.output +++ b/tests/regression/native/checkjni.output @@ -20,7 +20,6 @@ PASS, java.lang.Exception: Exception from JNI GetObjectClass: PASS PASS -PASS Field Access: PASS PASS