From c512352d56880cfa87f451a65b9b0d1c32e1f5af Mon Sep 17 00:00:00 2001 From: Jordi Mas i Hernandez Date: Fri, 20 May 2005 07:39:29 +0000 Subject: [PATCH] * ComboBox.cs: fixes OnSelectedItemChanged * ControlBindingsCollection.cs: fixes item range check 2005-05-20 Jordi Mas i Hernandez svn path=/trunk/mcs/; revision=44797 --- .../Managed.Windows.Forms/System.Windows.Forms/ChangeLog | 5 +++++ .../Managed.Windows.Forms/System.Windows.Forms/ComboBox.cs | 6 ++++-- .../System.Windows.Forms/ControlBindingsCollection.cs | 2 +- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ChangeLog b/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ChangeLog index 607a6b5b942..39203b9332b 100644 --- a/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ChangeLog +++ b/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ChangeLog @@ -1,3 +1,8 @@ +2005-05-20 Jordi Mas i Hernandez + + * ComboBox.cs: fixes OnSelectedItemChanged + * ControlBindingsCollection.cs: fixes item range check + 2005-05-20 Jordi Mas i Hernandez * UpDownBase.cs: diff --git a/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ComboBox.cs b/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ComboBox.cs index f11231a97f9..f64e266546e 100644 --- a/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ComboBox.cs +++ b/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ComboBox.cs @@ -416,6 +416,7 @@ namespace System.Windows.Forms OnSelectedIndexChanged (new EventArgs ()); OnSelectedValueChanged (new EventArgs ()); + OnSelectedItemChanged (new EventArgs ()); Refresh (); } } @@ -785,8 +786,7 @@ namespace System.Windows.Forms protected virtual void OnSelectedItemChanged (EventArgs e) { - if (SelectedIndexChanged != null) - SelectedIndexChanged (this, e); + } protected override void OnSelectedValueChanged (EventArgs e) @@ -950,6 +950,8 @@ namespace System.Windows.Forms combobox_info.textarea.Height); listbox_ctrl.CalcListBoxArea (); } + + area.Dispose (); } private void CreateComboListBox () diff --git a/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ControlBindingsCollection.cs b/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ControlBindingsCollection.cs index e36fef4bf48..b6b322328a5 100644 --- a/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ControlBindingsCollection.cs +++ b/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ControlBindingsCollection.cs @@ -90,7 +90,7 @@ namespace System.Windows.Forms { } public void RemoveAt(int index) { - if (index < 0 || index > base.List.Count) { + if (index < 0 || index >= base.List.Count) { throw new ArgumentOutOfRangeException("index"); } -- 2.25.1