From bbc4722277845fbe190fc997f3a2eb2408f6152e Mon Sep 17 00:00:00 2001
From: Kevin O'Connor <kevin@koconnor.net>
Date: Fri, 30 Jul 2010 13:07:08 -0400
Subject: [PATCH] Breakup jpeg_decode into parsing and displaying phases.

Split the screen display code out of the jpeg parsing code.

Allow ability for caller to obtain jpeg dimensions.
---
 src/bootsplash.c |  9 ++++++--
 src/jpeg.c       | 60 +++++++++++++++++++++++++-----------------------
 src/jpeg.h       |  7 +++---
 3 files changed, 42 insertions(+), 34 deletions(-)

diff --git a/src/bootsplash.c b/src/bootsplash.c
index 2c45406..b381935 100644
--- a/src/bootsplash.c
+++ b/src/bootsplash.c
@@ -187,12 +187,17 @@ void enable_vga_console(void)
     dprintf(8, "Copying boot splash screen...\n");
     cbfs_copyfile(file, jpeg, filesize);
     dprintf(8, "Decompressing boot splash screen...\n");
-    int ret = jpeg_decode(jpeg, picture, CONFIG_BOOTSPLASH_X,
-                          CONFIG_BOOTSPLASH_Y, CONFIG_BOOTSPLASH_DEPTH, decdata);
+    int ret = jpeg_decode(decdata, jpeg);
     if (ret) {
         dprintf(1, "jpeg_decode failed with return code %d...\n", ret);
         goto gotext;
     }
+    ret = jpeg_show(decdata, picture, CONFIG_BOOTSPLASH_X, CONFIG_BOOTSPLASH_Y
+                    , CONFIG_BOOTSPLASH_DEPTH);
+    if (ret) {
+        dprintf(1, "jpeg_show failed with return code %d...\n", ret);
+        goto gotext;
+    }
 
     /* Show the picture */
     iomemcpy(framebuffer, picture, imagesize);
diff --git a/src/jpeg.c b/src/jpeg.c
index b204345..0831c5b 100644
--- a/src/jpeg.c
+++ b/src/jpeg.c
@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2001, Novell Inc.
+ * Copyright (C) 2010  Kevin O'Connor <kevin@koconnor.net>
  * All rights reserved.
  * 
  * Redistribution and use in source and binary forms, with or without
@@ -177,6 +178,8 @@ struct jpeg_decdata {
     unsigned char quant[4][64];
     struct dec_hufftbl dhuff[4];
     struct in in;
+
+    int height, width;
 };
 
 static int getbyte(struct jpeg_decdata *jpeg)
@@ -292,29 +295,11 @@ struct jpeg_decdata *jpeg_alloc(void)
     return jpeg;
 }
 
-int jpeg_check_size(struct jpeg_decdata *jpeg, unsigned char *buf
-                    , int width, int height)
-{
-    jpeg->datap = buf;
-    getbyte(jpeg);
-    getbyte(jpeg);
-    readtables(jpeg, M_SOF0);
-    getword(jpeg);
-    getbyte(jpeg);
-    if (height != getword(jpeg) || width != getword(jpeg))
-        return 0;
-    return 1;
-}
-
-int jpeg_decode(unsigned char *buf, unsigned char *pic,
-                int width, int height, int depth,
-                struct jpeg_decdata *jpeg)
+int jpeg_decode(struct jpeg_decdata *jpeg, unsigned char *buf)
 {
     int i, j, m, tac, tdc;
-    int mcusx, mcusy, mx, my;
-    int max[6];
 
-    if (!jpeg || !buf || !pic)
+    if (!jpeg || !buf)
         return -1;
     jpeg->datap = buf;
     if (getbyte(jpeg) != 0xff)
@@ -327,11 +312,9 @@ int jpeg_decode(unsigned char *buf, unsigned char *pic,
     i = getbyte(jpeg);
     if (i != 8)
         return ERR_NOT_8BIT;
-    if (((getword(jpeg) + 15) & ~15) != height)
-        return ERR_HEIGHT_MISMATCH;
-    if (((getword(jpeg) + 15) & ~15) != width)
-        return ERR_WIDTH_MISMATCH;
-    if ((height & 15) || (width & 15))
+    jpeg->height = getword(jpeg);
+    jpeg->width = getword(jpeg);
+    if ((jpeg->height & 15) || (jpeg->width & 15))
         return ERR_BAD_WIDTH_OR_HEIGHT;
     jpeg->info.nc = getbyte(jpeg);
     if (jpeg->info.nc > MAXCOMP)
@@ -387,10 +370,6 @@ int jpeg_decode(unsigned char *buf, unsigned char *pic,
         || jpeg->dscans[2].hv != 0x11)
         return ERR_NOT_YCBCR_221111;
 
-    mcusx = width >> 4;
-    mcusy = height >> 4;
-
-
     idctqtab(jpeg->quant[jpeg->dscans[0].tq], jpeg->dquant[0]);
     idctqtab(jpeg->quant[jpeg->dscans[1].tq], jpeg->dquant[1]);
     idctqtab(jpeg->quant[jpeg->dscans[2].tq], jpeg->dquant[2]);
@@ -406,6 +385,29 @@ int jpeg_decode(unsigned char *buf, unsigned char *pic,
 
     dec_initscans(jpeg);
 
+    return 0;
+}
+
+void jpeg_get_size(struct jpeg_decdata *jpeg, int *width, int *height)
+{
+    *width = jpeg->width;
+    *height = jpeg->height;
+}
+
+int jpeg_show(struct jpeg_decdata *jpeg, unsigned char *pic
+              , int width, int height, int depth)
+{
+    int m, mcusx, mcusy, mx, my;
+    int max[6];
+
+    if (jpeg->height != height)
+        return ERR_HEIGHT_MISMATCH;
+    if (jpeg->width != width)
+        return ERR_WIDTH_MISMATCH;
+
+    mcusx = jpeg->width >> 4;
+    mcusy = jpeg->height >> 4;
+
     jpeg->dscans[0].next = 6 - 4;
     jpeg->dscans[1].next = 6 - 4 - 1;
     jpeg->dscans[2].next = 6 - 4 - 1 - 1;        /* 411 encoding */
diff --git a/src/jpeg.h b/src/jpeg.h
index 44c83d7..a2ac501 100644
--- a/src/jpeg.h
+++ b/src/jpeg.h
@@ -3,8 +3,9 @@
 
 struct jpeg_decdata;
 struct jpeg_decdata *jpeg_alloc(void);
-int jpeg_decode(unsigned char *, unsigned char *, int, int, int,
-                struct jpeg_decdata *);
-int jpeg_check_size(struct jpeg_decdata *, unsigned char *, int, int);
+int jpeg_decode(struct jpeg_decdata *jpeg, unsigned char *buf);
+void jpeg_get_size(struct jpeg_decdata *jpeg, int *width, int *height);
+int jpeg_show(struct jpeg_decdata *jpeg, unsigned char *pic
+              , int width, int height, int depth);
 
 #endif
-- 
2.25.1