From 41e57ac60f3d746c200b114863a3d58bb271403d Mon Sep 17 00:00:00 2001 From: Rodrigo Kumpera Date: Thu, 3 Jul 2008 13:47:10 +0000 Subject: [PATCH] In .: 2008-07-03 Rodrigo Kumpera * Exception.cs (GetFullNameForStackTrace): Don't do string concatenation. svn path=/trunk/mcs/; revision=107146 --- mcs/class/corlib/System/ChangeLog | 5 +++++ mcs/class/corlib/System/Exception.cs | 11 +++++------ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/mcs/class/corlib/System/ChangeLog b/mcs/class/corlib/System/ChangeLog index e48ee45194e..bc42c3f4fc4 100644 --- a/mcs/class/corlib/System/ChangeLog +++ b/mcs/class/corlib/System/ChangeLog @@ -1,3 +1,8 @@ +2008-07-03 Rodrigo Kumpera + + * Exception.cs (GetFullNameForStackTrace): Don't do string + concatenation. + 2008-06-30 Andreas Nahr * ContextMarshalException.cs: diff --git a/mcs/class/corlib/System/Exception.cs b/mcs/class/corlib/System/Exception.cs index 3372dc82d4f..f76c8ff4a5b 100644 --- a/mcs/class/corlib/System/Exception.cs +++ b/mcs/class/corlib/System/Exception.cs @@ -334,16 +334,15 @@ namespace System for (int i = 0; i < p.Length; ++i) { if (i > 0) sb.Append (", "); - string paramName = (p [i].Name == null) ? String.Empty : (" " + p [i].Name); Type pt = p[i].ParameterType; if (pt.IsClass && pt.Namespace != String.Empty) { sb.Append (pt.Namespace); sb.Append ("."); - sb.Append (pt.Name); - sb.Append (paramName); - } else { - sb.Append (pt.Name); - sb.Append (paramName); + } + sb.Append (pt.Name); + if (p [i].Name != null) { + sb.Append (" "); + sb.Append (p [i].Name); } } sb.Append (")"); -- 2.25.1