Ludovic Henry [Fri, 27 Jun 2014 02:15:27 +0000 (19:15 -0700)]
[sgen-gray-queue] Always update queue->cursor when dequeing
Previously, queue->cursor would not be set to NULL if the last element would be dequeued and queue->first would be set to NULL.
Zoltan Varga [Fri, 27 Jun 2014 01:53:35 +0000 (03:53 +0200)]
[jit] Remove now unused MONO_ARCH_HAVE_OP_LREM_IMM define.
Alex Rønne Petersen [Fri, 27 Jun 2014 01:48:05 +0000 (03:48 +0200)]
Fix a couple of format string warnings in sgen-gc.c.
Zoltan Varga [Fri, 27 Jun 2014 01:44:22 +0000 (03:44 +0200)]
Merge pull request #1131 from schani/feature-portable-fast-lrem-imm
[jit] Portably decompose power-of-two OP_[IL]REM_IMM.
Zoltan Varga [Fri, 27 Jun 2014 00:01:47 +0000 (02:01 +0200)]
[sdb] Avoid running tests in the 2.0 profile.
Mark Probst [Thu, 26 Jun 2014 21:43:01 +0000 (14:43 -0700)]
[jit] Portably decompose power-of-two OP_[IL]REM_IMM.
Instead of generating a sequence of AMD64 instructions for
power-of-two OP_[IL]REM_IMM, portably decompose them to intermediate
code.
OP_IREM_IMM is decomposed on 32 and 64 bit archs, OP_LREM_IMM only on
64 bit archs.
Alex Rønne Petersen [Thu, 26 Jun 2014 19:01:19 +0000 (21:01 +0200)]
Merge pull request #1130 from akoeplinger/descriptive-tests
[System] Make tests more descriptive on failure
Alexander Köplinger [Thu, 26 Jun 2014 18:55:47 +0000 (20:55 +0200)]
[System] Make tests more descriptive on failure
By using StringAssert we get a more descriptive error message when the test fails, i.e. the expected vs. the actual string value instead of just true/false.
Mark Probst [Thu, 26 Jun 2014 18:46:53 +0000 (11:46 -0700)]
Merge pull request #1128 from ludovic-henry/pr19g-sgen-grayqueue
[sgen-gray-queue] Use a cursor based accessing pattern to reduce memory indirection
Alex Rønne Petersen [Thu, 26 Jun 2014 18:40:06 +0000 (20:40 +0200)]
[System] Up the timeout in the BeginConnectMultiple test to 30s.
Most Linux systems have the net.ipv4.tcp_syn_retries sysctl
set to 5 or 6, so we need at least 30 seconds here.
Rolf Bjarne Kvinge [Thu, 26 Jun 2014 17:06:22 +0000 (19:06 +0200)]
[Mono.Data.Sqlite] Add support for Scalar and Aggregate functions in Xamarin.iOS.
Marek Safar [Thu, 26 Jun 2014 15:20:05 +0000 (17:20 +0200)]
[corlib] Update racy test
Marek Safar [Thu, 26 Jun 2014 14:49:09 +0000 (16:49 +0200)]
[mcs] Emit correct attribute reference when async lambda ends up in nested type. Fixes #20849
Marek Safar [Thu, 26 Jun 2014 14:41:54 +0000 (16:41 +0200)]
[corlib] Fix typo
Marek Safar [Thu, 26 Jun 2014 14:22:55 +0000 (16:22 +0200)]
[mcs] Fix local exits from try-finally scope with awaited statements
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 23:11:01 +0000 (01:11 +0200)]
Print pid_t's portably in mono/metadata/attach.c
The pid_t type is required by POSIX to be a signed integer type (and that it
isn't wider than long in at least one programming environment). Mono has a
bunch of issues with 64-bit pids at the present, this is a start. Cast the
pid to the largest available signed type before printing it.
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 23:07:08 +0000 (01:07 +0200)]
Avoid non-standard BSD types in mono/io-layer/wapi_glob.c
The u_char, u_short and u_int types are non-standard and no system headers
are required to provide them. There are no particular use for them and the
builtin standard types will do just as well.
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 23:15:16 +0000 (01:15 +0200)]
Restore the null garbage collector
I had to use the null garbage collector due to boehm being troublesome. The
code appears unmaintained but I can see a recent git commit enabled support
again. However, I had to do more than that to get it working. I'm really not
sure how semantically correct this is and it needs review from an expert in
how threads and garbage collection interplay in Mono. It seems very odd that
various attributes (such as its short id) about the main thread is
initialized as a side effect of initializing the garbage collection. The
mono_thread_info_attach was needed to prevent a crash.
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 23:39:10 +0000 (01:39 +0200)]
Remove Mono_Posix_Syscall_utimes_bad
Welcome to the world of tomorrow! It's been almost a decade since this was
made obsolete in 2005. Nothing uses this function any longer. Additionally
it is completely broken as utimes takes a pointer to an array with two
timevals, but the code passes only a pointer to a single timeval.
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 22:41:33 +0000 (00:41 +0200)]
Remove test whether thread-local storage works in shared libraries
This test was added in 2004 to work around buggy Linux distributions and is
not needed today. The test caused problems as it also ran on non-Linux
operating systems and assumed dynamic linking was available. This caused it
to mistakenly decide thread-local storage was unavailable on operating
systems with no dynamic linking (but perfectly usable thread-local storage).
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 22:43:40 +0000 (00:43 +0200)]
Don't touch internal feature macros in eglib
The __USE_GNU macro is an internal macro used by glibc to enable the GNU
extensions. Programs are instead meant to use the _GNU_SOURCE macro before
including any system header.
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 23:28:30 +0000 (01:28 +0200)]
Use SIGPROF only if it is available
The SIGPROF signal is an XSI option and obsolescent in XSI. POSIX systems
are not required to have it.
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 23:23:31 +0000 (01:23 +0200)]
Use memset instead of bzero
There is no standard bzero function, only the standard memset function, and
Mono does not declare its own bzero function.
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 23:21:31 +0000 (01:21 +0200)]
Remove MONO_SIZEOF_SUNPATH
The configure script determines the size of the sun_path member in struct
sockaddr_un. However the test is broken during cross-compilation (with a
comment that there is no macro to determine the size of struct members at
configure time) and MONO_SIZEOF_SUNPATH defaults to 0 (leading to buffer
underflows and overflows). There is no reason to determine this at configure
time when a simple traditional sizeof will do the job at compile time.
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 23:34:21 +0000 (01:34 +0200)]
Use MAP_FAILED instead of (void*)-1
The MAP_FAILED macro is the standard return value of mmap() upon failure and
it is allowed to have other values than (void*)-1.
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 23:31:14 +0000 (01:31 +0200)]
Avoid unused function warning in mono/profiler/proflog.c
The dump_ubin function is only used by the elf_dl_callback function. It
should be wrapped in the same #if conditional to avoid a warning if the
preprocessor conditional isn't true.
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 22:54:10 +0000 (00:54 +0200)]
Avoid unused function warning in mono/io-layer/io.c
The get_fstypename function is only used by the GetVolumeInformation
function. It should be wrapped in the same #if conditional to avoid a
warning if the preprocessor conditional isn't true.
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 22:50:08 +0000 (00:50 +0200)]
Use S_IWUSR instead of S_IWRITE
The S_IWRITE macro is a non-standard macro provided by some operating
systems for compatibility with BSD. POSIX specifics a standard macro with
identical semantics with the name S_IWUSR.
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 22:59:44 +0000 (00:59 +0200)]
Get struct timespec from <time.h> in mono/io-layer/misc-private.h
POSIX defines struct timespec in time.h and struct timeval in sys/time.h.
Some operating systems have merged these headers, but this isn't required or
encouraged by POSIX.
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 23:12:20 +0000 (01:12 +0200)]
Remove unnecessary <sys/syscall.h> inclusion
Only mono/metadata/icall.c and mono/metadata/filewatcher.c include the
mono/metadata/filewatcher.h header and none of them depend on the contents
of the non-standard header <sys/syscall.h>.
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 23:03:11 +0000 (01:03 +0200)]
Only include the <sys/param.h> header if available
The <sys/param.h> header is non-standard and usually not required if it isn't
available.
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 23:37:47 +0000 (01:37 +0200)]
Use <poll.h> to get poll rather than <sys/poll.h>
POSIX specifies <poll.h> as the standard header that declares the poll
function. Many systems provide <sys/poll.h> to be compatible with historical
practice. Prefer the <poll.h> header over <sys/poll.h> if it is available.
This change is released under the MIT/X11 license.
Jonas 'Sortie' Termansen [Mon, 23 Jun 2014 22:48:42 +0000 (00:48 +0200)]
Use <sys/select.h> to get select
POSIX mandates that select is declared in <sys/select.h> (and in the header
<sys/time.h> for compatibility). It would be best to include the new header
if it is available. This is already done throughout the source tree, though
not in all instances.
This change is released under the MIT/X11 license.
Ludovic Henry [Wed, 25 Jun 2014 23:28:07 +0000 (16:28 -0700)]
[sgen-gray-queue] Add heavy statistics for allocation, and enqueue/dequeue fast/slow paths
Ludovic Henry [Wed, 25 Jun 2014 23:16:13 +0000 (16:16 -0700)]
[sgen-gray-queue] Remove compilation warning in mini-gc.c : redefinition of typedef 'mword'
Ludovic Henry [Wed, 25 Jun 2014 22:36:29 +0000 (15:36 -0700)]
[sgen-binprot,sgen-gray-queue] Add binary_protocol_gray_(en|de)queue and call them on object enqueuing and dequeuing
Ludovic Henry [Wed, 25 Jun 2014 23:06:22 +0000 (16:06 -0700)]
[sgen-protocol] Avoid multiple inclusion of sgen-protocol.h
Ludovic Henry [Wed, 25 Jun 2014 22:25:52 +0000 (15:25 -0700)]
[sgen-gray-queue] Add macros to compute first and last cursor position address on a section
Ludovic Henry [Wed, 25 Jun 2014 21:25:45 +0000 (14:25 -0700)]
[sgen-gray-queue] Transform GRAY_OBJECT_(EN|DE)QUEUE to always inlined functions
Ludovic Henry [Wed, 25 Jun 2014 18:16:09 +0000 (11:16 -0700)]
[sgen-gray-queue] Change from index based to cursor based gray queue access to current element
This patch consist in changing the way we access the current element value in the gray queue. Before, we would save the index of the last element in the queue, then to access to the current value, we would have to make 2 memory access + 1 array offset access. Now we store a pointer to the current element, so we only need 1 memory access, thus reducing the number of memory indirection. We see ~25% speed improvement in major gc collection time on gc-graystack-stress test.
Ludovic Henry [Fri, 13 Jun 2014 23:26:18 +0000 (19:26 -0400)]
[sgen-gray-queue] Add graystack stress test
Zoltan Varga [Wed, 25 Jun 2014 17:34:33 +0000 (19:34 +0200)]
[jit] Add a MONO_ARCH_HAVE_OP_LREM_IMM define instead of using TARGET_AMD64.
Joao Matos [Wed, 25 Jun 2014 17:26:43 +0000 (18:26 +0100)]
Fixed compiler warning introduced in the last commit about redefining typedefs.
Redefinition of typedef 'foo' is a C11 feature [-Wtypedef-redefinition].
Joao Matos [Fri, 20 Jun 2014 16:29:05 +0000 (17:29 +0100)]
Fixed Mono includes to be able to be included independently.
Joao Matos [Wed, 18 Jun 2014 15:33:24 +0000 (16:33 +0100)]
Cleaned up C++ keywords in Mono metadata headers.
Marek Safar [Wed, 25 Jun 2014 15:30:05 +0000 (17:30 +0200)]
[corlib] Enum::TryParse ignores leading whitespaces. Fixes #20870
Marek Safar [Wed, 25 Jun 2014 15:28:43 +0000 (17:28 +0200)]
[mcs] Fix array access of value type compound assignment with awaited argument
Marek Safar [Wed, 25 Jun 2014 14:51:16 +0000 (16:51 +0200)]
[xbuild] Add 4.5.1 framework. Fixes #20827
Marek Safar [Wed, 25 Jun 2014 13:14:49 +0000 (15:14 +0200)]
[mcs] Allow unsafe code in async block when scope does not need variable capturing
Alex Rønne Petersen [Wed, 25 Jun 2014 11:21:06 +0000 (13:21 +0200)]
[System.Web] Disable AppResourcesCompilerTest for now.
This is a stopgap measure: This test hangs a *lot* on Jenkins
and it's only being disabled to get stable-ish builds. It's
being actively investigated still.
Marek Safar [Tue, 24 Jun 2014 22:01:22 +0000 (00:01 +0200)]
[mcs] Add experimental value changes notifications to evaluator
Marek Safar [Tue, 24 Jun 2014 14:09:28 +0000 (16:09 +0200)]
[mcs] Handle side effect constants in await context
Zoltan Varga [Wed, 25 Jun 2014 00:13:10 +0000 (02:13 +0200)]
Fix a warning.
Zoltan Varga [Wed, 25 Jun 2014 00:03:20 +0000 (02:03 +0200)]
Merge pull request #1126 from schani/feature-fast-lrem-imm
[amd64] Fast OP_LREM_IMM for power of two operands.
Mark Probst [Tue, 24 Jun 2014 23:04:26 +0000 (16:04 -0700)]
[amd64] Fast OP_LREM_IMM for power of two operands.
This was the reason for one of our bad performance results in the
paper "Clash of the Lambdas" by Biboudis, Palladinos, Smaragdakis:
http://cgi.di.uoa.gr/~biboudis/clashofthelambdas.pdf
Zoltan Varga [Tue, 24 Jun 2014 22:49:07 +0000 (00:49 +0200)]
[aot] Fix the decoding of MonoJitInfo. Fixes #16439.
Mark Probst [Tue, 24 Jun 2014 17:00:53 +0000 (10:00 -0700)]
[sgen] Binary protocol freeing whole M&S blocks.
Mark Probst [Tue, 24 Jun 2014 16:23:49 +0000 (09:23 -0700)]
[sgen] Nicer sgen-grep-binprot output.
Indent events that are always printed so that the ones we're grepping
for are more easily recognized.
Jeffrey Stedfast [Tue, 24 Jun 2014 15:07:35 +0000 (11:07 -0400)]
Merge pull request #995 from yjoly/master
Fix the date time set in file by removing the ':'.
Marek Safar [Tue, 24 Jun 2014 12:19:54 +0000 (14:19 +0200)]
[corlib] Fix racy test
Marek Safar [Tue, 24 Jun 2014 11:57:53 +0000 (13:57 +0200)]
[System.Net.Http] Fix disposing of DelegatingHandler. Fixes #20818
Marek Safar [Tue, 24 Jun 2014 11:52:31 +0000 (13:52 +0200)]
[mcs] Emit side effects of reduced probing expression
Marek Safar [Tue, 24 Jun 2014 11:20:40 +0000 (13:20 +0200)]
[mcs] Fix emit of array access with awaited indexer expression and result field write.
Marek Safar [Mon, 23 Jun 2014 15:39:54 +0000 (17:39 +0200)]
[mcs] Fix scope initialization for exception filters using hoisted lambdas with awaited catch clause
Marek Safar [Mon, 23 Jun 2014 13:29:16 +0000 (15:29 +0200)]
[mcs] Recognize await as simple name in type context
Alex Rønne Petersen [Tue, 24 Jun 2014 09:11:46 +0000 (11:11 +0200)]
Add a section to CONTRIBUTING.md on inactivity.
Mark Probst [Mon, 23 Jun 2014 20:16:51 +0000 (13:16 -0700)]
[sgen] Don't crash for describe_ptr() when there's no bridge processor.
Chris Hamons [Mon, 23 Jun 2014 15:32:39 +0000 (10:32 -0500)]
Fix Mono.Linker.csproj so it can build
Mono.Linker.csproj has drifted from its associated Makefile was was not buildable.
This change applies changes from the last few Makefile changes.
Marek Safar [Mon, 23 Jun 2014 12:30:02 +0000 (14:30 +0200)]
[corlib] Fix race in unit test
Marek Safar [Mon, 23 Jun 2014 12:16:10 +0000 (14:16 +0200)]
[mcs] Handle try await nested in multiple finally blocks.
Alex Rønne Petersen [Mon, 23 Jun 2014 12:10:58 +0000 (14:10 +0200)]
[corlib] Disable TaskContinuationChainLeak test on non-mobile too.
Alex Rønne Petersen [Mon, 23 Jun 2014 02:06:46 +0000 (04:06 +0200)]
Merge pull request #1123 from akoeplinger/fix-webreq-test
[System] Use the same port number instead of a random port in HttpWebRequestTest
Zoltan Varga [Sun, 22 Jun 2014 19:38:11 +0000 (21:38 +0200)]
Fix a warning.
Alexander Köplinger [Sun, 22 Jun 2014 18:10:17 +0000 (20:10 +0200)]
[System] Use the same port number instead of a random port in HttpWebRequestTest
A random port doesn't add any value and resulted in at least one port conflict on monojenkins:
http://monojenkins.cloudapp.net/job/Mono/243/testReport/MonoTests.System.Net/HttpWebRequestTest/BeginGetRequestStreamCancelIfNotAllBytesWritten/
Alex Rønne Petersen [Sun, 22 Jun 2014 14:30:53 +0000 (16:30 +0200)]
Merge pull request #1121 from inkdev/master
Fix MSVC build
i59 [Sun, 22 Jun 2014 14:24:46 +0000 (16:24 +0200)]
libmono.vcxproj: Link to libmonoruntimesgen.lib in the Release_SGen mode
Previously attempted to link to the libmonoruntime library outputted by the boehm configuration
i59 [Sun, 22 Jun 2014 14:23:16 +0000 (16:23 +0200)]
Added file-mmap-windows.c to libmonoruntime.vcxproj
i59 [Sun, 22 Jun 2014 14:21:29 +0000 (16:21 +0200)]
Moved _WIN32_WINNT to winconfig.h; dropped support for WinXP SP1 and below
Win32 compilation was broken due to attempting to use Interlocked* functions introduced with XP SP2.
i59 [Sun, 22 Jun 2014 14:19:52 +0000 (16:19 +0200)]
libmonoutils: Removed need for X64 MASM definition
Check for availability of the RAX register, checking if we're running x64
Alex Rønne Petersen [Sat, 21 Jun 2014 21:45:54 +0000 (23:45 +0200)]
Merge pull request #1118 from kitsilanosoftware/udp-client-test-check-ipv6
[System.Net] Do not assume IPv6 is enabled in UdpClientTest
Alex Rønne Petersen [Sat, 21 Jun 2014 21:45:03 +0000 (23:45 +0200)]
Merge pull request #1119 from akoeplinger/fix-currencymanager
[Managed.Windows.Forms] Revert a revert commit that accidentally changed the wrong code
Zoltan Varga [Sat, 21 Jun 2014 16:40:05 +0000 (18:40 +0200)]
[llvm] Update the LLVM backend to llvm
ca4e226df2e13a9e87376a880035efa376639c98.
Alexander Köplinger [Sat, 21 Jun 2014 14:39:27 +0000 (16:39 +0200)]
[Managed.Windows.Forms] Added more asserts to the CurrencyManagerTest2 test
These were useful while investigating
4b50211fb7f1dd2621673edd100f30eb39098d7d
Alexander Köplinger [Sat, 21 Jun 2014 10:50:28 +0000 (12:50 +0200)]
[Managed.Windows.Forms] Revert a revert commit that accidentally changed the wrong code
When the commit
8334fe3a56c978ffe7f8cb199536f9b3234afdbe was reverted in
a791cfc1640bec442757f78fe71e428d643e90ed, accidentally the wrong chunk of code was changed.
This commit reverts the changes correctly.
Zoltan Varga [Sat, 21 Jun 2014 13:42:11 +0000 (15:42 +0200)]
[llvm] Remove a small source workaround which is no longer needed.
Alex Rønne Petersen [Fri, 20 Jun 2014 18:48:21 +0000 (20:48 +0200)]
Merge pull request #1117 from akoeplinger/fix-databindingsource
[Managed.Windows.Forms] Verify that DataMember is valid when setting DataSource
Damien Diederen [Fri, 20 Jun 2014 16:45:35 +0000 (18:45 +0200)]
[System.Net] Do not assume IPv6 is enabled in UdpClientTest
Without this, three of the tests fail on Linux kernels without IPv6
support.
This is a minimal fix, copy'n'pasting a conditional which was used in
other tests. It might be nicer to factor out the SupportsIPv6 to its
own utility function.
Alexander Köplinger [Fri, 20 Jun 2014 14:35:47 +0000 (16:35 +0200)]
[Managed.Windows.Forms] Verify that DataMember is valid when setting DataSource
When DataMember is already set before DataSource we need to verify that it refers to a valid property in the DataSource setter, otherwise we'd get an exception in ResetList ().
This fixes the following failing tests: BindingSourceTest.DataMemberBeforeDataSource and BindingSourceTest.DataSourceAssignToDefaultType.
Commit licensed under MIT/X11.
Alex Rønne Petersen [Fri, 20 Jun 2014 02:17:30 +0000 (04:17 +0200)]
Fix the build.
Alex Rønne Petersen [Fri, 20 Jun 2014 02:11:48 +0000 (04:11 +0200)]
Silence a warning in file-mmap-posix.c.
Alex Rønne Petersen [Fri, 20 Jun 2014 01:26:29 +0000 (03:26 +0200)]
Merge pull request #1113 from akoeplinger/fix-cache-test
[System.Runtime.Caching] Fixed test that failed intermittently on slow systems
Alex Rønne Petersen [Fri, 20 Jun 2014 01:24:21 +0000 (03:24 +0200)]
[MWF] Disable OneIdlePerThread test.
The code that made this test work was reverted, so this test is
bound to fail randomly.
Alexis Christoforides [Thu, 19 Jun 2014 23:47:01 +0000 (19:47 -0400)]
Rodrigo Kumpera [Thu, 19 Jun 2014 23:08:40 +0000 (19:08 -0400)]
[runtime] Rework named mapping to use an unlinked file to provide correct mapping semantics.
Instead of using mono_valloc we create a temp file and unlink it. With this we can have the right
mmap semantics regarding CoW and access rights.
This does simplify the code too by completely removing the mapping kind.
Rodrigo Kumpera [Thu, 19 Jun 2014 22:17:20 +0000 (18:17 -0400)]
[runtime] Fix error handling with named memory regions.
Rodrigo Kumpera [Thu, 19 Jun 2014 21:57:02 +0000 (17:57 -0400)]
[runtime] Make it possible to create views to magic zero size files such as /dev/zero. Fixes #19460
Rodrigo Kumpera [Thu, 19 Jun 2014 21:03:44 +0000 (17:03 -0400)]
[runtime] Define DEFFILEMODE to 0666 if not defined.
Alex Rønne Petersen [Thu, 19 Jun 2014 21:58:05 +0000 (23:58 +0200)]
[MWF] Disable DataRemainsOnClipboard_Xamarin4959 test.
It works fine on a regular system but breaks under Xvfb.
http://monojenkins.cloudapp.net/job/Mono/230/testReport/MonoTests.System.Windows.Forms/ClipboardTest/DataRemainsOnClipboard_Xamarin4959/
Miguel de Icaza [Thu, 19 Jun 2014 21:45:05 +0000 (17:45 -0400)]
[WCF] Make BasicHttpBinding.AllowCookies work
This patch is from Brendan Zagaeski and fixes bug 11307
The description of the problem was:
In Mono 2.10.12, the BasicHttpBinding property no longer supports
EnableHttpCookieContainer because it is Depreciated. The replacement
is AllowCookies, but this property does not work. Upon inspection of
the source source, we find that the HttpCookieContainerBindingElement
is added in accordance with EnableHttpCookieContainer, but not
AllowCookies.
The conditional compile logic at [1] is no longer needed for
Xamarin.iOS or Xamarin.Android.
Alexander Köplinger [Thu, 19 Jun 2014 15:51:16 +0000 (17:51 +0200)]
[System.Runtime.Caching] Fixed test that failed intermittently on slow systems
Apparently on slow systems the items with 1sec expiration time are already removed from the cache by the time the #CS3 Assert() is hit, which caused the test to fail.
Increasing the expiration time by +2sec should hopefully fix this.
Commit licensed under MIT/X11.