From: Rolf Bjarne Kvinge <rolf@xamarin.com>
Date: Mon, 18 Sep 2017 12:34:55 +0000 (+0200)
Subject: [mono-api-html] Print ref/out modifiers on parameters. Fixes #59430.
X-Git-Url: http://wien.tomnetworks.com/gitweb/?a=commitdiff_plain;h=e90147646f2be7d614ce02b5a7d073f23a1efaab;hp=5b483a682096189eddd25d856358726f007fdbcf;p=mono.git

[mono-api-html] Print ref/out modifiers on parameters. Fixes #59430.

Print ref/out modifiers on parameters, so that any changes in ref/out are detected.

https://bugzilla.xamarin.com/show_bug.cgi?id=59430
---

diff --git a/mcs/tools/mono-api-html/ConstructorComparer.cs b/mcs/tools/mono-api-html/ConstructorComparer.cs
index 9bd837e241f..e322d4ef556 100644
--- a/mcs/tools/mono-api-html/ConstructorComparer.cs
+++ b/mcs/tools/mono-api-html/ConstructorComparer.cs
@@ -133,10 +133,15 @@ namespace Xamarin.ApiDiff {
 			if (parameters != null) {
 				var list = new List<string> ();
 				foreach (var p in parameters.Elements ("parameter")) {
-					var pTypeName   = p.GetTypeName ("type");
-					list.Add (State.IgnoreParameterNameChanges
-						? pTypeName
-						: pTypeName + " " + p.GetAttribute ("name"));
+					var param = p.GetTypeName ("type");
+					if (!State.IgnoreParameterNameChanges)
+						param += " " + p.GetAttribute ("name");
+
+					var direction = p.GetAttribute ("direction");
+					if (direction?.Length > 0)
+						param = direction + " " + param;
+						
+					list.Add (param);
 				}
 				sb.Append (String.Join (", ", list));
 			}