From: Kevin O'Connor <kevin@koconnor.net>
Date: Sat, 15 Mar 2008 15:07:50 +0000 (-0400)
Subject: Minor cleanups.
X-Git-Url: http://wien.tomnetworks.com/gitweb/?a=commitdiff_plain;h=c38e480c83e5090c622d3b42370134aff7d97632;p=seabios.git

Minor cleanups.

Remove some redundant code from Makefile.
Improve a couple of comments.
---

diff --git a/Makefile b/Makefile
index fcb5169..1ffe500 100644
--- a/Makefile
+++ b/Makefile
@@ -96,10 +96,6 @@ $(OUT)rom16.o: $(OUT)romlayout16.o
 	@echo "  Linking $@"
 	$(Q)ld -melf_i386 -e post16 -Ttext 0 $< -o $@
 
-$(OUT)rom16.bin: $(OUT)rom16.o
-	@echo "  Extracting binary $@"
-	$(Q)objcopy -O binary $< $@
-
 $(OUT)romlayout32.o: $(OUT)rom16.offset.auto.h ; $(call whole-compile, $(CFLAGS), $(addprefix src/, $(SRC32)),$@)
 
 $(OUT)rom32.o: $(OUT)romlayout32.o $(OUT)rombios32.lds
diff --git a/src/apm.c b/src/apm.c
index 63bb44f..1cb054c 100644
--- a/src/apm.c
+++ b/src/apm.c
@@ -178,6 +178,7 @@ handle_1553XX(struct bregs *regs)
 void VISIBLE16
 handle_1553(struct bregs *regs)
 {
+    //debug_stub(regs);
     switch (regs->al) {
     case 0x00: handle_155300(regs); break;
     case 0x01: handle_155301(regs); break;
diff --git a/src/ata.h b/src/ata.h
index af64e1a..763dbf1 100644
--- a/src/ata.h
+++ b/src/ata.h
@@ -9,7 +9,7 @@
 #define __ATA_H
 
 #include "types.h" // u16
-#include "atabits.h"
+#include "atabits.h" // ATA_CB_DH_DEV1
 
 struct ata_pio_command {
     void *far_buffer;
diff --git a/src/output.c b/src/output.c
index 0336610..e22b159 100644
--- a/src/output.c
+++ b/src/output.c
@@ -20,7 +20,7 @@ screenc(u8 c)
     call16_int(0x10, &br);
 }
 
-// XXX
+// XXX - move PORT_DEBUG to standard place?
 #define PORT_DEBUG  0x403
 
 // Write a charcter to the framebuffer.