From: Ludovic Henry <ludovic@xamarin.com>
Date: Tue, 1 Nov 2016 18:45:47 +0000 (-0400)
Subject: [threads] Fix Posix async resume (#3861)
X-Git-Url: http://wien.tomnetworks.com/gitweb/?a=commitdiff_plain;h=bfff01173476e3a26d7010c7504dc13d0e15fca9;p=mono.git

[threads] Fix Posix async resume (#3861)

If we fail to send the signal, we should not add a pending operation, as the signal handler is never going to answer this operation (via mono_threads_notify_initiator_of_resume).
---

diff --git a/mono/utils/mono-threads-posix.c b/mono/utils/mono-threads-posix.c
index 0592cd68d27..5447a8fe93f 100644
--- a/mono/utils/mono-threads-posix.c
+++ b/mono/utils/mono-threads-posix.c
@@ -286,8 +286,13 @@ This begins async resume. This function must do the following:
 gboolean
 mono_threads_suspend_begin_async_resume (MonoThreadInfo *info)
 {
-	mono_threads_add_to_pending_operation_set (info);
-	return mono_threads_pthread_kill (info, mono_threads_suspend_get_restart_signal ()) == 0;
+	int sig = mono_threads_suspend_get_restart_signal ();
+
+	if (!mono_threads_pthread_kill (info, sig)) {
+		mono_threads_add_to_pending_operation_set (info);
+		return TRUE;
+	}
+	return FALSE;
 }
 
 void